patch stringlengths 18 160k | callgraph stringlengths 4 179k | summary stringlengths 4 947 | msg stringlengths 6 3.42k |
|---|---|---|---|
@@ -1,6 +1,6 @@
<%= javascript_include_tag "submissions_manager" %>
-<%= javascript_include_tag "ajax_paginate" %>
-<%= javascript_include_tag "help_system" %>
+
+<%= render partial: 'submissions_table', formats: [:'js.jsx'], handlers: [:erb] %>
<div class="notice">
<% if Time.zone.now >= @assignment.submission_... | [No CFG could be retrieved] | Displays a list of all possible assignments for a single node. path to the file containing the given . | Why did you delete this? |
@@ -0,0 +1,16 @@
+$(document).on('page:change', function () {
+ var slideTime = 300;
+
+ $('#help-button').click(function () {
+ if ($('#help-content').hasClass('open')) {
+ $('#help-content').removeClass('open');
+ $('#help-content').slideUp(slideTime);
+ $('#help-label').html("<%= raw(I18n.t('idp.... | [No CFG could be retrieved] | No Summary Found. | This isn't related to Devise authentication. |
@@ -439,11 +439,11 @@ def add_defaults_to_specs(r, linked, specs, update=False, prefix=None):
def install_actions(prefix, index, specs, force=False, only_names=None, always_copy=False,
- pinned=True, minimal_hint=False, update_deps=True, prune=False,
+ pinned=True, update_deps... | [_remove_actions->[add_unlink,ensure_linked_actions,add_defaults_to_specs],execute_plan->[update_old_plan],revert_actions->[format],execute_actions->[plan_from_actions],display_actions->[format->[format,channel_filt],format,print_dists,channel_filt,channel_str],plan_from_actions->[inject_UNLINKLINKTRANSACTION,format],r... | Installs a series of actions from a prefix. | As far as I can tell nothing calls this function, so it can probably be ripped out too. |
@@ -325,6 +325,12 @@ class WPCOM_social_media_icons_widget extends WP_Widget {
* @return void
*/
function wpcom_social_media_icons_widget_load_widget() {
+ // [DEPRECATION]: Only register widget if active widget exists already
+ $has_widget = is_active_widget( false, false, 'wpcom_social_media_icons_widget', false... | [WPCOM_social_media_icons_widget->[widget->[check_genericons]]] | Load the icons widget. | Are we sure this works? Testing if a widget is active before registering it? Also, it seems like this may be more efficient to cache in a transient rather than having WordPress scan through every sidebar on every page load. That's probably a blocker. |
@@ -871,6 +871,10 @@ public class ZeppelinConfiguration {
completeConfiguration.put(c.getVarName(), sysConfig.getString(c.getVarName()));
} else if (envConfig.containsKey(c.name())) {
completeConfiguration.put(c.getVarName(), envConfig.getString(c.name()));
+ }else {
+ if (getString... | [ZeppelinConfiguration->[getLong->[getLong,getLongValue],getS3BucketName->[getString],isJMXEnabled->[getBoolean],isClusterMode->[getString],getMongoAutoimport->[getBoolean],credentialsPersist->[getBoolean],getTrustStorePassword->[getKeyStorePassword,getString],getMongoDatabase->[getString],getHeliumNodeInstallerUrl->[g... | This method returns a map of the system and environment variables that are complete. | Since `envConfig` and `sysConfig` are checked in `getString()`, would it be okay to delete lines 870~873? However, it seems that the check order of `envConfig` and `sysConfig` is different only in `getCompleteConfiguration()`. @zjffdu @Reamer Which of `envConfig` and `sysConfig` takes precedence? |
@@ -38,6 +38,8 @@ import org.springframework.webflow.execution.Action;
* @since 5.0.0
*/
@Configuration("authyConfiguration")
+@ConditionalOnMultifactorTrustedDevicesEnabled(prefix = "cas.authn.mfa.authy")
+@ConditionalOnProperty(prefix="cas.authn.mfa.authy", name="api-key")
@EnableConfigurationProperties(CasConf... | [AuthyConfiguration->[authyCasWebflowExecutionPlanConfigurer->[authyMultifactorWebflowConfigurer],authyAuthenticationWebflowAction->[authyAuthenticationWebflowEventResolver],AuthyMultifactorTrustConfiguration->[authyMultifactorTrustWebflowConfigurer->[authyAuthenticatorFlowRegistry],authyMultifactorTrustCasWebflowExecu... | Package private for unit testing. Bean to provide a . | This is not correct, and should be removed. Trusted-devices feature is separate from MFA, and requiring both is a breaking change in behavior. |
@@ -433,9 +433,9 @@ func (p *Provider) getServicePriority(container dockerData, serviceName string)
// Extract backend from labels for a given service and a given docker container
func (p *Provider) getServiceBackend(container dockerData, serviceName string) string {
if value, ok := getContainerServiceLabel(contain... | [Provide->[createClient],containerFilter->[hasServices],getIPAddress->[createClient,getIPAddress],listServices->[getIsBackendLBSwarm]] | getServiceBackend returns the backend name for the given service. | `provider.Normalize(container.ServiceName + "-" + p.getBackend(container) + "-" + serviceName)` |
@@ -71,8 +71,9 @@ import static java.lang.Integer.MAX_VALUE;
* annotated with {@link @Sharable}.
* <p>
* Some methods such as {@link ByteBuf#readBytes(int)} will cause a memory leak if the returned buffer
- * is not released or added to the <tt>out</tt> {@link List}. Use derived buffers like {@link ByteBuf#readSl... | [ByteToMessageDecoder->[fireChannelRead->[fireChannelRead],channelInputClosed->[fireChannelRead,channelInputClosed],discardSomeReadBytes->[discardSomeReadBytes],decodeRemovalReentryProtection->[fireChannelRead,handlerRemoved,decode],decodeLast->[decodeRemovalReentryProtection],callDecode->[isSingleDecode,fireChannelRea... | A decoder that can combine multiple ByteBufs into a single ByteBuf. cumulation can be expanded with a reallocation operation to accommodate the additional data. | typo: throught -> through |
@@ -19,6 +19,18 @@ static struct dai esai[] = {
.index = 0,
.plat_data = {
.base = ESAI_BASE,
+ .fifo[SOF_IPC_STREAM_PLAYBACK] = {
+ .offset = ESAI_BASE + REG_ESAI_ETDR,
+ .depth = 96, /* in 4 bytes words */
+ .handshake = EDMA_HANDSHAKE(EDMA_ESAI_IRQ,
+ EDMA_ESAI_TX_CHAN),
+ },
+ .fifo[SOF_IP... | [dai_init->[spinlock_init,dai_install,ARRAY_SIZE],ARRAY_SIZE,EDMA_HANDSHAKE] | Component of the DAI that holds the data of a specific ethernet channel. - - - - - - - - - - - - - - - - - -. | This value 96 might be probably a temporary patch. Eventually, after the current submission, we should at some point set it to the real ESAI's FIFO size, ie 128. This bigger value would then allow the EDMA driver to find the optimal value when computing the number of bytes to transfer at each major loop iteration. |
@@ -239,7 +239,7 @@ public class FlowCatalog extends AbstractIdleService implements SpecCatalog, Mut
}
}
- public void put(Spec spec, boolean triggerListener) {
+ public String put(Spec spec, boolean triggerListener) {
try {
Preconditions.checkState(state() == State.RUNNING, String.format("%s is... | [FlowCatalog->[getSpecsWithTimeUpdate->[getSpecs],getSpec->[getSpec],getSpecs->[getSpecs],addListener->[addListener],exists->[exists],serialize->[serialize],registerWeakSpecCatalogListener->[registerWeakSpecCatalogListener],removeListener->[removeListener],remove->[remove],deserialize->[deserialize],put->[put]]] | Gets a Spec from the store. If the Spec is not yet present in the store it. | I don't think String return type is good enough. First we could invoke multiple listeners instead of just GobblinServiceJobScheduler. Also even if GobblinServiceJobScheduler is the only listener here, its return type doesn't have to be a String. I think we should have a generic return type such as 'AddSpecResponse' and... |
@@ -6,8 +6,6 @@ import (
"strconv"
"strings"
- "github.com/Unknwon/paginater"
-
"code.gitea.io/gitea/models"
"code.gitea.io/gitea/modules/base"
"code.gitea.io/gitea/modules/context"
| [Tr,ServerError,HTML,PostFormValue,GetNotificationCount,Sprintf,ParseInt,Trim,New,UpdateNotificationStatuses,SetNotificationStatus,NotificationsForUser,QueryInt,Redirect,HasPrefix,Query] | GetNotificationCount returns a middleware that sets the notification count for the user NotificationStatusPost is a route for changing the status of a notification. | please add copyright header to this file |
@@ -96,7 +96,7 @@ function vimeo_shortcode( $atts ) {
*/
$height = (int) apply_filters( 'vimeo_height', $height );
- $url = esc_url( set_url_scheme( "http://player.vimeo.com/video/$id" ) );
+ $url = esc_url( set_url_scheme( "https://player.vimeo.com/video/$id" ) );
// $args['autoplay'] is parsed from the emb... | [No CFG could be retrieved] | Generate a Vimeo shortcode Filter the Vimeo player. | the `set_url_scheme` will return `http` or `https` depending on result of `is_ssl`. If we want to always use `https` (any real downsides anyone? I'm okay with that vs protocol neutral), we can omit `set_url_scheme`. |
@@ -303,9 +303,7 @@ public class EndRoundDelegate extends BaseTripleADelegate {
// end round delegate)
final String title =
"Victory Achieved"
- + (winners.isEmpty()
- ? ""
- : " by " + MyFormatter.defaultNamedToTextList(winners, ", ", false));
+ ... | [EndRoundDelegate->[start->[start],loadState->[loadState],end->[end],saveState->[saveState]]] | Signal game over. This method is called when user presses the JDialog for confirmation. | Remove unnecessary parameters. |
@@ -161,6 +161,14 @@ class SharedTokenCacheBase(ABC):
# cache is empty or contains no refresh token -> user needs to sign in
raise CredentialUnavailableError(message=NO_ACCOUNTS)
+ if self._auth_record:
+ for account in accounts:
+ if account.get("home_accoun... | [SharedTokenCacheBase->[_get_accounts_having_matching_refresh_tokens->[_get_cache_items_for_authority],_get_account->[_account_to_string,_filtered_accounts,_get_accounts_having_matching_refresh_tokens]]] | returns exactly one account which has a refresh token and matches username and tenant_id. | Do we need try catch here? if it is an invalid auth_record, what's our expected behavior? |
@@ -509,13 +509,14 @@ final class SelectionComponentFactory {
.addLeftJustified(JButtonBuilder.builder()
.title("Presets...")
.actionListener(() -> {
- final JComboBox<EmailProviderSetting> comboBox =
- JComboBoxBuilder.builder(EmailProviderSett... | [SelectionComponentFactory->[selectionBox->[resetToDefault->[setComboBoxSelectedItem],reset->[setComboBoxSelectedItem],newComboBox->[getListCellRendererComponent->[getListCellRendererComponent]]],folderPath->[selectFile],intValueRange->[resetToDefault->[toValidIntValue],reset->[toValidIntValue],getComponentValue->[unse... | Creates a component which selects a 3 - tuple consisting of a host port TLS username and password Displays a confirmation dialog to select a specific configuration. This method is called when the user changes the host port username and password. | Probably want to replace `GenericEmailSender` with `IEmailSender` when qualifying `EmailProviderSetting` throughout this class. |
@@ -5762,8 +5762,9 @@ inline void gcode_M17() {
}
}
- static bool pause_print(const float& retract, const float& z_lift, const float& x_pos, const float& y_pos,
- const float& unload_length = 0 , int max_beep_count = 0, bool show_lcd = false) {
+ static bool pause_print(const float ... | [No CFG could be retrieved] | - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -. | Moving the &s to next to the variable names doesn't seem to match the code style for the rest of the file |
@@ -481,7 +481,6 @@ def get_random_cached_bottlenecks(sess, image_lists, how_many, category,
ground_truth[label_index] = 1.0
bottlenecks.append(bottleneck)
ground_truths.append(ground_truth)
- filenames.append(image_name)
else:
# Retrieve all bottlenecks.
for label_index, label_na... | [get_bottleneck_path->[get_image_path],get_random_distorted_bottlenecks->[get_image_path,run_bottleneck_on_image],get_random_cached_bottlenecks->[get_image_path,get_or_create_bottleneck],main->[create_inception_graph,get_random_distorted_bottlenecks,should_distort_images,get_random_cached_bottlenecks,cache_bottlenecks,... | Retrieves a list of bottlenecks for the specified number of images from the specified category. Retrieve all bottlenecks ground truths and filenames. | I think we should put this line back? |
@@ -1156,9 +1156,10 @@ def _create_subparsers(helpful):
" Currently --csr only works with the 'certonly' subcommand.")
helpful.add("revoke",
"--reason", dest="reason",
- choices=CaseInsensitiveList(constants.REVOCATION_REASONS.keys()),
+ choices=CaseI... | [_add_all_groups->[add_group],_plugins_parsing->[add,add_group,add_plugin_args],HelpfulArgumentParser->[add_group->[HelpfulArgumentGroup],set_test_server->[flag_default],remove_config_file_domains_for_renewal->[_Default],modify_kwargs_for_default_detection->[_Default],__init__->[flag_default],add_deprecated_argument->[... | Create the sub - parsers for the certbot command. Initialize and prepare plugins. | Why call `sorted` here? |
@@ -50,9 +50,13 @@ CertStore::CertInfo CertStore::_preprocessCert(uint32_t length, uint32_t offset,
memset(&ci, 0, sizeof(ci));
// Process it using SHA256, same as the hashed_dn
- br_x509_decoder_context *ctx = new br_x509_decoder_context;
- br_sha256_context *sha256 = new br_sha256_context;
+ br_x509_decode... | [br_x509_trust_anchor->[free],initCertStore->[_preprocessCert,free],free->[free]] | This function processes the cert - specific information from the BSSL decoder. | is `if (...)` redundant here? afaik, delete will be no-op with nullptr |
@@ -4810,6 +4810,7 @@ def test_address_query_as_app_with_permission(
address_other_country,
permission_manage_users,
):
+
variables = {"id": graphene.Node.to_global_id("Address", address_other_country.pk)}
response = app_api_client.post_graphql(
ADDRESS_QUERY, variables, permissions=[permi... | [test_password_change_incorrect_old_password->[check_password,post_graphql,get_graphql_content,refresh_from_db],test_user_with_cancelled_fulfillments->[upper,len,post_graphql,to_global_id,get_graphql_content,add],test_me_query_checkout->[str,save,post_graphql,get_graphql_content],test_customer_delete->[assert_called_on... | Test address query as app with permission. | @mateuszgrzyb IMO we can leave this file unchanged. |
@@ -255,6 +255,12 @@ module.exports = JhipsterGenerator.extend({
this.generatorType = 'server';
this.skipUserManagement = configOptions.skipUserManagement = true;
}
+ if (this.applicationType == 'uaa') {
+ this.skipClient = true;
+ ... | [No CFG could be retrieved] | Component that provides a function to configure the application type. The main entry point for the client. | need to remove this |
@@ -94,8 +94,7 @@ public class ComponentLocationVisitor implements Consumer<Pair<ComponentAst, Lis
}
public void accept(ComponentAst componentModel, List<ComponentAst> hierarchy) {
- if (((ComponentModel) componentModel).getParent() == null) {
- // do not process root element
+ if (((ComponentModel) ... | [ComponentLocationVisitor->[accept->[accept],processModuleOperationChildren->[getModuleOperationTypeComponentIdentifier],processFlowDirectChild->[findNonProcessorPath]]] | Accept a component. This method is called to find a free chunk of data that can be added to the next Add a connection to the parent component. | If I'm not wrong I see locations with value "null" for some components. Would it be a problem here? |
@@ -105,6 +105,16 @@ func New(logger logr.Logger, allowInvalidExtensionResources bool) *handler {
},
},
+ gvr("etcds"): {
+ newObject: func() client.Object { return new(druidv1alpha1.Etcd) },
+ validateCreateResource: func(n, _ client.Object) field.ErrorList {
+ return druidvalidation.ValidateEtcd(n.(*... | [Handle->[WithTimeout,handleValidation,Allowed],handleValidation->[NewInvalid,Error,Denied,Allowed,Errorf,ObjectName,Info,Errored,DecodeRaw],ValidateContainerRuntimeUpdate,ValidateNetwork,ValidateBackupBucket,ValidateBackupEntryUpdate,ValidateContainerRuntime,ValidateBastion,ValidateBackupEntry,ValidateExtensionUpdate,... | Replies the functions that provide access to the object returned by the API. ErrorList returns an ErrorList if the object is not an instance of an Infrastructure or. | This function will return the wrong resource group and version, you could create e.g. `gvrDruid` to return the correct ones. |
@@ -266,7 +266,7 @@ class Client(object):
cert, chain = crypto_util.cert_and_chain_from_fullchain(orderr.fullchain_pem)
return cert.encode(), chain.encode()
- def obtain_certificate(self, domains):
+ def obtain_certificate(self, domains, oldkeypath=None):
"""Obtains a certificate from... | [sample_user_agent->[DummyConfig,determine_user_agent],perform_registration->[perform_registration],Client->[obtain_and_enroll_certificate->[obtain_certificate],obtain_certificate->[obtain_certificate_from_csr,obtain_certificate],__init__->[acme_from_config_key]],view_config_changes->[view_config_changes],register->[ac... | Obtain a certificate from a CSR. Get the certificate chain key and CSR from the certificate store. | `old_key_path` or `old_keypath` for pythonicness? |
@@ -10,6 +10,8 @@ import (
const (
// DefaultRollingTimeoutSeconds is the default TimeoutSeconds for RollingDeploymentStrategyParams.
DefaultRollingTimeoutSeconds int64 = 10 * 60
+ // DefaultRecreateTimeoutSeconds is the default TimeoutSeconds for RecreateDeploymentStrategyParams.
+ DefaultRecreateTimeoutSeconds i... | [No CFG could be retrieved] | Imports the given object from the given namespace. | we should default this in defaulter for recreate? |
@@ -964,7 +964,7 @@ class FilterEditorSafetyTests(TestCase):
<svg><circle onload=confirm(3)>
<h1 class="header1">Header One</h1>
<p>test</p>
- <section>
+ <section onclick="alert('hacked!')">
<h1 class="header2">Header Two</h1>
... | [test_annotate_links_existing_doc->[get_absolute_url,get_full_url,parse,startswith,normalize_html],test_annotate_links_uilocale_to_nonexisting_doc->[parse,normalize_html],FilterEditorSafetyTests->[test_editor_safety_filter->[parse,normalize_html]],test_extractSection_descending_heading_levels->[parse,normalize_html],te... | Test that the editor safety filter is used. | I'm surprised this was needed - ``filterEditorSafety`` is supposed to remove it, which I think it is whole purpose of this test. |
@@ -179,6 +179,9 @@ public abstract class TemplateOnErrorHandler extends AbstractExceptionListener
new DefaultMessageProcessorChainBuilder(this.flowConstruct);
try {
configuredMessageProcessors = defaultMessageProcessorChainBuilder.chain(getMessageProcessors()).build();
+ if (configuredMessage... | [TemplateOnErrorHandler->[doInitialise->[doInitialise]]] | Override doInitialise to chain the message processors. | It's be good to add a utility method to LifecycleUtils for this, so we are not repeating it everywhere. |
@@ -834,7 +834,10 @@ func (u *User) HasDeviceInCurrentInstall() bool {
func (u *User) SigningKeyPub() (GenericKey, error) {
// Get out key that we're going to sign with.
- arg := SecretKeyArg{Me: u, All: true}
+ arg := SecretKeyArg{
+ Me: u,
+ KeyType: AllSecretKeyTypes,
+ }
lockedKey, _, err := G.Keyring... | [GetDeviceSibkey->[GetComputedKeyFamily],GetTrackingStatementFor->[String],CheckBasicsFreshness->[GetIdVersion],GetRemoteTrackingStatementFor->[GetTrackingStatementFor,IdTable],GetSyncedSecretKey->[GetComputedKeyFamily],StoreTopLevel->[String],Store->[Store,StoreSigChain],GetDeviceSubkeyKid->[GetComputedKeyFamily],Trac... | SigningKeyPub returns the public key that we re going to sign with. | Should fix the typo: out -> our |
@@ -0,0 +1,9 @@
+module Db
+ module LetterRequestsToUspsFtpLog
+ class LettersSentInRange
+ def self.call(start_date, end_date)
+ ::LetterRequestsToUspsFtpLog.where(ftp_at: start_date..end_date)
+ end
+ end
+ end
+end
| [No CFG could be retrieved] | No Summary Found. | It looks like this class and method is only called in one place. What do you think of removing the class and using `::LetterRequestsToUspsFtpLog.where(ftp_at: start_date..end_date)` directly instead? |
@@ -141,6 +141,7 @@ public abstract class SQLMetadataConnector implements MetadataStorageConnector
return e != null && (e instanceof SQLTransientException
|| e instanceof SQLRecoverableException
|| e instanceof UnableToObtainConnectionException
+ ... | [SQLMetadataConnector->[createEntryTable->[createTable,getPayloadType],createAuditTable->[createTable,getPayloadType,createAuditTable,getSerialType],createSegmentTable->[createTable,getPayloadType,createSegmentTable],createTable->[withHandle->[tableExists],retryWithHandle],createLogTable->[createTable,getPayloadType,ge... | Checks if the given exception is a transient exception. | @gianm this causes lots of retries for duplicate primary key entry errors that will never be transient unless someone manually cleans the DB |
@@ -128,6 +128,7 @@ public class ExportMojo extends AbstractMojo {
try (Bndrun run = Bndrun.createBndrun(null, runFile)) {
run.setBase(temporaryDir);
Workspace workspace = run.getWorkspace();
+ workspace.setParent(processor);
workspace.setBuildDir(cnf);
workspace.setOffline(session.getSettings()
... | [ExportMojo->[attach->[debug,addAttachedArtifact,setFile,endsWith,DefaultArtifact,getGroupId,DefaultArtifactHandler,setExtension,getArtifactId,getVersion],export->[getValue,equals,setBase,createBndrun,isOk,lastModified,getNamePart,setLastModified,getInfo,getKey,setProperty,File,isOffline,list,addBasicPlugin,error,setBu... | This method exports a bnd run to the target directory. This method is called to export a resource to a jar file. | I am not sure this is correct. When the Workspace is created, its parent is `Workspace.getDefaults()`. You now replace the parent and lose the defaults. |
@@ -64,7 +64,12 @@ def _changed(path_info, tree, hash_info, cache, filter_info=None):
logger.debug("cache for '%s'('%s') has changed.", path, hi)
return True
- actual = tree.get_hash(path)
+ try:
+ actual = tree.get_hash(path)
+ except FileNotFoundError:
+ logger.debug("'%s' d... | [_remove_redundant_files->[_remove],_checkout->[_checkout_file,_checkout_dir],_remove->[_is_cached],_changed->[_filter_hash_info],checkout->[_changed,_remove,_checkout],_checkout_file->[_changed,_remove],_checkout_dir->[_checkout_file,_remove_redundant_files]] | Checks if data has changed. | Some clouds don't properly wrap exceptions into OSErrors, but the followup PR will move `get_hash` out of trees into a separate helper and those clouds will use stat() that uses ls() that handles exceptions properly. |
@@ -151,6 +151,18 @@ namespace Dynamo.Wpf.UI.GuidedTour
}
}
+ /// <summary>
+ /// This method will update the Popup offset so it will be re-drawn in the new location (just when the PlacementTarget is moved or resized).
+ /// </summary>
+ public void UpdateLocation()
+... | [Content->[NewLine,Replace],Step->[Show->[IsOpen,ExecuteUIAutomationStep],OnStepClosed->[StepClosed],Hide->[IsOpen,ExecuteUIAutomationStep],ExecuteUIAutomationStep->[StaysOpenOnClick,ToUpper,UIElementAutomation,IsSubmenuOpen,Equals],TOP_LEFT,CreatePopup]] | Hide the current action automation. | Is there a different way? Like mark it as modified ets? Using events? |
@@ -68,4 +68,11 @@ class User < Base
def inspect
"#{self.class.name} - id: #{id} name: #{name}"
end
+
+ def validate
+ super
+ validates_unique(:name, :email, { message: 'is already registered' })
+ validates_format /^[^\s]+$/, :name, message: 'may not be empty'
+ validates_format /^[^@\s]+@[^@\... | [User->[to_h->[to_h],update_settings->[empty?,include?,raise,each,name],inspect->[name],by_email->[function,downcase],reset_hashes->[hexdigest,to_i,map],can_reset?->[to_i],freeze,create,empty?,raise,one_to_many],require_relative,require] | Returns a string describing the n - node in the sequence. | You may be able to use this, which is apparently a standard import URI::MailTo::EMAIL_REGEXP (since hand-rolled email regexes are tricky) |
@@ -96,9 +96,9 @@ class H2OWord2vecEstimator(H2OEstimator):
@property
def word_model(self):
"""
- Use the Skip-Gram model
+ The word model to use (SkipGram or CBOW)
- One of: ``"skip_gram"`` (default: ``"skip_gram"``).
+ One of: ``"skip_gram"``, ``"cbow"`` (default: ``... | [H2OWord2vecEstimator->[from_external->[H2OWord2vecEstimator]]] | Get the word model. | need to look into this if we recognize both SkipGram and skip_gram, the docs are inconsitent |
@@ -994,11 +994,16 @@ class Optimizer(object):
return no_grad_set
@framework.dygraph_only
- def clear_grad(self):
+ def clear_grad(self, set_to_zero=True):
"""
Clear the gradients of all optimized parameters for model.
If not, new gradient will accumulat on previous gr... | [Optimizer->[apply_gradients->[_create_optimization_pass],step->[_apply_optimize],append_regularization_ops->[_create_regularization_of_grad],state_dict->[state_dict],set_state_dict->[set_state_dict],_create_param_lr->[_global_learning_rate],_apply_optimize->[apply_gradients,_create_optimization_pass],_create_optimizat... | Clear the gradients of all optimized parameters for model. | bool -> bool, optional |
@@ -184,6 +184,7 @@ class AdminController
'resetResend' => $this->router->generate('sulu_security.reset_password.email.resend'),
'resources' => $this->router->generate('sulu_admin.resources', ['resource' => ':resource']),
'translations' => $this->router->generate('sulu_admin.trans... | [AdminController->[configAction->[getUser,toArray,generate,getAll,getAllResourceMetadata,getKey,getLocale,setGroups,getEndpoint,getRoutes,getChildrenAsArray,getId,getById,getConfiguration,setFormat,setContext,handle],indexAction->[generate,renderResponse],translationsAction->[getCatalogue,all,get,getFallbackCatalogue],... | Renders a single node in the administration area. | I think that's where we agreed that these kind of URLs should go into the `configAction` into the `sulu_security` section, because then we don't have to build two different extension points for bundles. |
@@ -249,8 +249,9 @@ class HelixRetriggeringJobCallable implements Callable {
String newPlanningId;
Closer closer = Closer.create();
try {
- HelixManager planningJobManager = this.taskDriverHelixManager.isPresent()?
+ HelixManager planningJobHelixManager = this.taskDriverHelixManager.isPresent()... | [HelixRetriggeringJobCallable->[runJobExecutionLauncher->[deleteJobSpec],runJobLauncherLoop->[isRetriggeringEnabled,buildJobLauncherForCentralizedMode],cancel->[cancel]]] | This method runs the planning job launcher. This method is called by the planning job manager to initialize the planning job and then This method is called when the planning job is submitted successfully. | `getOrElse`? ...actually thought I earlier saw a similar replacement above... |
@@ -57,6 +57,7 @@ class Dataspaces(AutotoolsPackage):
args = []
cookie = self.spec.variants['gni-cookie'].value
ptag = self.spec.variants['ptag'].value
+ args.append('CFLAGS={0}'.format(self.compiler.pic_flag))
if self.spec.satisfies('+dimes'):
args.append('--enab... | [is_string->[isinstance],Dataspaces->[autoreconf->[which,bash],configure_args->[append,satisfies],variant,depends_on,version]] | Returns a list of arguments to pass to the command line. | cannot find a proper configure flag for that in DataSpaces... |
@@ -203,7 +203,7 @@ class ReactiveMongodbPanacheResourceTest {
nbEvent.increment();
});
source.open();
- Thread.sleep(100);//wait a little for the events to comes in
+ Thread.sleep(150);//wait a little for the events to comes in
assertEquals(... | [ReactiveMongodbPanacheResourceTest->[testReactiveBookRepository->[callReactiveBookEndpoint],testReactiveBookEntity->[callReactiveBookEndpoint],testReactivePersonRepository->[callReactivePersonEndpoint],callReactiveBookEndpoint->[setDetails,assertTrue,IntegerAdder,size,setTransientDescription,assertNull,statusCode,setS... | Call the given endpoint with the response body. Get magic query. This method is used to test if a specific object is found in the database. a private method that deletes a specific object from the server. | Can't we use awaitility instead of this? We would wait for longer but still be more reactive as it would poll the result automatically. |
@@ -29,8 +29,15 @@ class FmtResult:
)
-class FmtResults(Collection[FmtResult]):
- """This collection allows us to aggregate multiple `FmtResult`s for a language."""
+@dataclass(frozen=True)
+class AggregatedFmtResults:
+ """This collection allows us to safely aggregate multiple `FmtResult`s for a language.
+... | [FmtResult->[from_execute_process_result->[FmtResult]],fmt->[is_formattable,Fmt]] | Returns a FmtResult object for the given type. Format a object. | Why is this optional? What does it being empty signify? |
@@ -79,7 +79,7 @@ namespace System
public override string ToString()
{
- return Number.FormatInt32(m_value, null, null);
+ return Number.Int32ToDecStr(m_value, digits: -1, provider: null);
}
public string ToString(string? format)
| [Int32->[TypeCode->[Int32],ToUInt16->[ToUInt16],ToInt64->[ToInt64],ToSingle->[ToSingle],ToDecimal->[ToDecimal],ToUInt64->[ToUInt64],ToChar->[ToChar],ToBoolean->[ToBoolean],ToDouble->[ToDouble],ToSByte->[ToSByte],ToByte->[ToByte],ToInt16->[ToInt16],ToUInt32->[ToUInt32]]] | Method to return the string representation of a . | Why not to inline these as well? Like the Int16 ones, etc. |
@@ -270,6 +270,7 @@ public final class OzoneConsts {
public static final String SRC_KEY = "srcKey";
public static final String DST_KEY = "dstKey";
public static final String USED_BYTES = "usedBytes";
+ public static final String USED_NAMESPACE = "usedNamespace";
public static final String QUOTA_IN_BYTES = ... | [OzoneConsts->[key,of,compile]] | A property that can be tracked on a per - container basis. Missing names for all the classes. | Seems we don't use this variable, Could you be so kind as to let me know its usage if I miss something. |
@@ -1053,12 +1053,8 @@ func (c *Container) addLocalVolumes(ctx context.Context, g *generate.Generator)
}
if c.config.User != "" {
- if !c.state.Mounted {
- return errors.Wrapf(ErrCtrStateInvalid, "container %s must be mounted in order to translate User field", c.ID())
- }
- execUser, err := lookup.GetUserGro... | [pause->[save],handleExitFile->[bundlePath],cleanup->[cleanupStorage,cleanupRuntime],restartWithTimeout->[start,init,stop,reinit],CheckpointPath->[bundlePath],cleanupRuntime->[save,removeConmonFiles],initAndStart->[init,reinit],saveSpec->[bundlePath],cleanupStorage->[save],removeConmonFiles->[bundlePath],start->[save],... | addLocalVolumes adds volumes from the local container to the container s volumes list Point is the path to the k - th volume in the root FS. Copy the contents of the volume into the volumePath. | nit of a nit: s/pass/passed |
@@ -933,6 +933,7 @@ def while_loop(cond, body, loop_vars, is_test=False, name=None):
body(Callable): A callable returning a tuple or list of tensors and LoDTensorArrays of the same arity
(length and structure) and types as ``loops_vars`` .
loop_vars(list|tuple): A list or tuple of tensors... | [Switch->[default->[ConditionalBlock,ConditionalBlockGuard],case->[_case_check_args->[],ConditionalBlock,ConditionalBlockGuard]],IfElseBlockGuard->[__exit__->[__exit__],__enter__->[__enter__],__init__->[block]],DynamicRNN->[_parent_block_->[block],block->[array_write,block,increment,less_than,array_to_lod_tensor],stati... | While loop. Returns the variable list of the last n - nodes in the system. | tensors and LoDTensorArrays tensors **or** LoDTensorArrays? |
@@ -988,7 +988,13 @@ void PurgeLocks(void)
entry.time = now;
DeleteDBCursor(dbcp);
+ CloseLock(dbp);
+ dbp = OpenLock();
+ if(!dbp)
+ {
+ return;
+ }
WriteDB(dbp, "lock_horizon", &entry, sizeof(entry));
CloseLock(dbp);
}
| [No CFG could be retrieved] | Reads and deletes all of the non - standard lock entries. Unlocks a single block of lock. | Same. Not necessary. |
@@ -72,4 +72,12 @@ public class ApplicationModel {
LOGGER.warn("Already register the same:" + serviceName);
}
}
+
+ /**
+ * For unit test
+ */
+ public static void reset() {
+ providedServices.clear();
+ consumedServices.clear();
+ }
}
| [ApplicationModel->[getConsumerModel->[get],initProviderModel->[putIfAbsent,warn],allConsumerModels->[values],getProviderModel->[get],allProviderModels->[values],initConsumerModel->[putIfAbsent,warn],getLogger]] | Initialize providerModel. | I beleive providedServices and consumedServices would be never null here? |
@@ -14,6 +14,7 @@
#include "Marked_Default_Qos.h"
#include "SubscriberImpl.h"
#include "TypeSupportImpl.h"
+#include "DCPS_Utils.h"
#include <stdexcept>
| [No CFG could be retrieved] | Reads a single object from the DCPS. protected void _add_ref _remove_ref. | Is this include needed? |
@@ -787,12 +787,10 @@ func (t *LocalTarget) HabSupRestart(sortedServiceList []string) (bool, error) {
return true, errors.Wrap(err, "failed to restart habitat supervisor")
}
-func (t *LocalTarget) waitForUnload(name string, timeout time.Duration) error {
- ctx, cancel := context.WithTimeout(context.Background(), t... | [habSupSymlinkPath->[deploymentServiceDataDir],installHabViaInstallScript->[habTmpDir],InstallAutomateUnitFile->[WriteAutomateUnitFile,RenderAutomateUnitFile,SymlinkHabSup],waitForHabSupToStart->[getHabSupBin,getHabBin],startHabSupFromLauncher->[getHabSupBin,getHabBin],reconfigurePendingSentinel->[deploymentServiceData... | HabSupRestart restarts the hab - sup supervisor Unload a service waitForUnload - Wait for service to unload. | I don't understand why we can remove this. If we remove this, how do we exit this for loop in the case of a timeout? |
@@ -231,4 +231,4 @@ public class SslUtilTest {
private static String trustStoreProp(final String config) {
return ClientTrustStore.trustStoreProps().get(config);
}
-}
\ No newline at end of file
+}
| [SslUtilTest->[shouldExtractKeyPassword->[is,assertThat,getKeyPassword,of],shouldThrowIfTrustStorePasswordWrong->[expect,of,trustStoreProp,hasMessage,expectMessage,loadTrustStore,is,expectCause],trustStoreProp->[get],shouldNotLoadKeyStoreByDefault->[empty,emptyMap,is,assertThat,loadKeyStore],shouldThrowIfTrustStoreNotF... | Returns the trust store property. | Same as above question, Is there an extra space here? |
@@ -351,11 +351,15 @@ func expandBackends(configured []interface{}) ([]*compute.Backend, error) {
}
if v, ok := data["max_rate"]; ok {
b.MaxRate = int64(v.(int))
- b.ForceSendFields = append(b.ForceSendFields, "MaxRate")
+ if b.MaxRate == 0 {
+ b.NullFields = append(b.NullFields, "MaxRate")
+ }
}
... | [Printf,Set,Sprintf,Do,GetOk,New,List,Id,Insert,Errorf,Delete,String,SetId,Get,WriteString,Sum256,Update] | expandBackends expands a list of backend objects into a list of compute. Backend objects expandBackendService expands a resource data into a backend service. | Shouldn't this be `MaxRatePerInstance`? |
@@ -210,8 +210,6 @@ namespace System.Diagnostics.Tests
Assert.Equal(parentId, activity.ParentId);
- // With probability 1/MaxLong, Activity.Id length may be expectedIdLength + 1
- Assert.InRange(activity.Id.Length, expectedIdLength, expectedIdLength + 1);
Assert.DoesN... | [ActivityTests->[Options_W3CNonHexCharsNotSupportedAndDoesNotThrow->[IdIsW3CFormat,SetParentId],ActivityTraceIdTests->[IsLowerCaseHex],TraceIdBeforeStart_FromInProcParent->[SetParentId],IdFormat_W3CWhenParentIdIsW3C->[IdIsW3CFormat,SetParentId],SetIdFormat_CanSetW3CAfterHierarchicalParentIsSet->[IdIsW3CFormat,SetParent... | Checks that the activity id length is not overflow during Id generation. | Can you provide background why this needed to change? I expected it would be unaffected. |
@@ -1901,8 +1901,9 @@ public class SchedV2 extends AbstractSched {
public boolean revDue() {
return mCol.getDb()
.queryScalar(
- "SELECT 1 FROM cards WHERE did IN " + _deckLimit() + " AND queue = " + Consts.QUEUE_TYPE_REV + " AND due <= " + mToday
- ... | [SchedV2->[_resetRevCount->[_currentRevLimit],_revConf->[_cardConf],haveBuried->[haveBuriedSiblings,haveManuallyBuried],dueForecast->[dueForecast],_fillNew->[_resetNew,_fillNew],suspendCards->[log],resetCards->[log,forgetCards],cardCount->[_deckLimit],counts->[counts],_getLrnCard->[_fillLrn,_maybeResetLrn,getCard,_getL... | Checks if the current order of the deck is in the past. | The parameter seems wrong |
@@ -182,12 +182,11 @@ class GraphLock(object):
""" returns the object serialized as a dict of plain python types
that can be converted to json
"""
- result = {}
nodes = OrderedDict() # Serialized ordered, so lockfiles are more deterministic
- for id_, node in sorted(se... | [GraphLockNode->[from_dict->[loads,GraphLockNode],as_dict->[dumps]],GraphLock->[update_check_graph->[_closure_affected],from_dict->[GraphLock,from_dict],as_dict->[as_dict],__init__->[GraphLockNode]],GraphLockFile->[dumps->[dumps],loads->[loads,GraphLockFile],save->[save],load->[load]]] | Returns the object serialized as a dict of plain python types that can be converted to json. | Update this doc-string. I think that it should talk about `status`, not `modified`. |
@@ -0,0 +1,15 @@
+package games.strategy.triplea.settings;
+
+public class IntegerValueRange {
+
+ public final int lowerValue;
+ public final int upperValue;
+ public final int defaultValue;
+
+ public IntegerValueRange(int lowerValue, int upperValue, int defaultValue) {
+ this.lowerValue = lowerValue;
+ thi... | [No CFG could be retrieved] | No Summary Found. | Would it be better if these were private and we have getters? |
@@ -58,7 +58,14 @@ class MTurkManager():
return
print('Setting up MTurk backend...')
- html_api_endpoint_url, json_api_endpoint_url, requester_key_gt = setup_aws(task_description=opt['task_description'], num_hits=opt['num_hits'], num_assignments=opt['num_assignments'], is_sandbox=opt['is_... | [MTurkManager->[review_hits->[get_approval_status_count]],MTurkAgent->[observe->[send_new_message,get_new_messages_and_save_to_db,get_new_messages],shutdown->[get_approval_status_count],act->[get_new_messages]]] | Initialize the object with the options provided. | @yf225 shouldn't you check here if each mturk_agent_id has its templates in task_files_to_copy? |
@@ -271,6 +271,15 @@ def product_type(color_attribute, size_attribute):
return product_type
+@pytest.fixture
+def product_type_no_shipping(color_attribute, size_attribute):
+ product_type = ProductType.objects.create(
+ name='Default Type', has_variants=False, is_shipping_required=False)
+ product... | [size_attribute->[create],product_without_shipping->[Money,create],payment_txn_preauth->[save,create],color_attribute_without_values->[create],admin_user->[create_superuser],payment_txn_refunded->[save,create],voucher_translation_fr->[create],taxes->[update,get_tax_for_rate],page->[create],order->[get_copy,create],prod... | Get a single product from a product_type and category. | > no shipping I would suggest to say: > without shipping |
@@ -373,6 +373,16 @@ export class PreactBaseElement extends AMP.BaseElement {
*/
mutationObserverCallback() {}
+ /**
+ * A callback that allows the user to specify additional init properties
+ * to the Mutation Observer.
+ * @protected
+ * @return {!MutationObserverInit}
+ */
+ getAdditionalMutatio... | [No CFG could be retrieved] | A callback to check if a has been observed on the current container. Check if mutations are necessary and if so schedule render. | Needed to add the additional init property `attributeOldValue` in Social Share. Can also do this as a static class property. Open to opinions, I put it here as a method so it can be next to the closely related `mutationObserverCallback()` Also open to opinions on shorter naming. |
@@ -0,0 +1 @@
+#include "pandamic.h"
| [No CFG could be retrieved] | No Summary Found. | Please add a license header. |
@@ -47,6 +47,7 @@ public class SimpleChannelPool implements ChannelPool {
new IllegalStateException("Channel is unhealthy not offering it back to pool"),
SimpleChannelPool.class, "releaseAndOffer(...)");
+ protected final ConcurrentMap<Channel, Channel> allChannels = PlatformDependent.new... | [SimpleChannelPool->[acquire->[acquire],notifyHealthCheck->[acquireHealthyFromPoolOrNew],release->[release],closeAndFail->[closeChannel],close->[close,pollChannel]]] | Implementation of the SimpleChannelPool class. | Just use a DefaultChannelGroup ? |
@@ -88,7 +88,7 @@ func newPluginInstallCmd() *cobra.Command {
// Now for each kind, name, version pair, download it from the release website, and install it.
for _, install := range installs {
label := fmt.Sprintf("[%s plugin %s]", install.Kind, install)
- cmdutil.Diag().Infoerrf(
+ cmdutil.Diag().In... | [CloudURL,IsPluginKind,Message,ValueOrDefaultURL,Wrap,ParseTolerant,New,RunFunc,Diag,DownloadPlugin,PluginKind,StringVarP,Errorf,Wrapf,HasPluginGTE,Infoerrf,Sprintf,Install,Open,MaximumNArgs,PersistentFlags,HasPlugin,BoolVar] | Version - returns a version object that can be used to download a package from the release website Download the plugin if it doesn t exist. | @swgillespie None of these seem like errors, so i made them simple info events. I do not see why we would want to ever emit these to stderr. |
@@ -25,7 +25,7 @@ import org.apache.beam.sdk.testing.PAssert;
import org.apache.beam.sdk.testing.RunnableOnService;
import org.apache.beam.sdk.testing.TestPipeline;
import org.apache.beam.sdk.transforms.Create;
-import org.apache.beam.sdk.transforms.RemoveDuplicates;
+import org.apache.beam.sdk.transforms.Distinct;
... | [DeDupExampleTest->[testRemoveDuplicates->[create,of,apply,containsInAnyOrder,waitUntilFinish,asList,withCoder],testRemoveDuplicatesEmpty->[create,of,apply,empty,waitUntilFinish,asList,withCoder]]] | Imports a single object. Test if the given strings contain the given number of unique elements. | The name of this Test is `DeDupExampleTest.java` should be renamed. |
@@ -225,4 +225,12 @@ public interface Result<V, E> {
*/
Result<V, E> recover(FunctionWithException<? super E, ? extends V> recover);
+ /**
+ * Terminal function that processes the result or the error
+ *
+ * @param ok the consumer called when ok
+ * @param err the consumer called when not ok
+ */
+ void the... | [of->[err,ok]] | Recover the result of a function. | I would call this something like `accept` rather than `then`. `then` implies some chaining in a monadic style. This is really about consuming the Result and `accept` is the Java method name for consumers. |
@@ -112,6 +112,14 @@ class Optimizer(Registrable):
else:
parameter_groups = [param for name, param in model_parameters]
+ # Log the number of parameters to optimize
+ num_parameters = 0
+ for parameter_group in parameter_groups:
+ if isinstance(parameter_group, di... | [DenseSparseAdam->[step->[make_sparse->[dim,constructor],_sparse_mask,sqrt_,div_,pow,size,add_,sub,sqrt,len,_values,_indices,closure,make_sparse,coalesce,addcdiv_,zeros_like,mul_],__init__->[dict,super,ValueError,format]],Optimizer->[from_params->[info,enumerate,parameter_groups,pop_choice,parameter_group_names,groups,... | Create a new optimizer from a list of model parameters and a list of params. Construct a object. | Do you need to check for `trainable` somewhere in here? |
@@ -674,7 +674,7 @@ namespace cryptonote
if (prune_blockchain)
{
// display a message if the blockchain is not pruned yet
- if (m_blockchain_storage.get_current_blockchain_height() > 1 && !m_blockchain_storage.get_blockchain_pruning_seed())
+ if (!m_blockchain_storage.get_blockchain_pruning_s... | [No CFG could be retrieved] | This function loads the checkpoints from the given file and checks them against the network and updates them This function returns true if the object is found in the system and false if it is not. | I take it this prune_blockchain() will be a no-op if height <= 1 ? |
@@ -31,6 +31,9 @@ def pick_events(events, include=None, exclude=None):
A event id to exclude or a list of them.
If None no event is excluded. If include is not None
the exclude parameter is ignored.
+ step : bool
+ If True (default is False), events have a step format.
+ In t... | [_find_events->[_find_stim_steps],read_events->[pick_events,_read_events_fif],find_stim_steps->[_find_stim_steps],find_events->[_find_events]] | Pick some events from a list of events. | add a note referring to output='step' param in find_events |
@@ -163,4 +163,16 @@ class SiteSerializer < ApplicationSerializer
scope.can_create_shared_draft?
end
+ private
+
+ def ordered_flags(flags)
+ notify_moderators_type = PostActionType.flag_types[:notify_moderators]
+ types = flags
+
+ if notify_moderators_flag = types.index(notify_moderators_type)
+ ... | [SiteSerializer->[topic_featured_link_allowed_category_ids->[topic_featured_link_allowed_category_ids],uncategorized_category_id->[uncategorized_category_id],top_tags->[top_tags]]] | if the category id is shared drafts category id then it should be included in the result. | Isn't this constant available elsewhere? |
@@ -739,7 +739,7 @@ namespace DotNetNuke.Entities.Urls
if (rx.IsMatch(pair[1]) == false)
{
// Contains Non-AlphaNumeric Characters
- if (pair[0].ToLower() == "tabid")
+ ... | [AdvancedFriendlyUrlProvider->[FriendlyUrl->[FriendlyUrl],OutputFriendlyUrlMessages->[CheckForDebug],ImproveFriendlyUrlWithMessages->[CreateFriendlyUrl,DeterminePageNameAndExtension,DetermineExtension],GetFriendlyQueryString->[AddPage],GetFriendlyAlias->[GetCultureOfSettings,GetCultureOfPath]]] | Returns the friendly query string for a given tab and path. function to handle the case where a key is missing or if the value is missing. Add a n - ary entry to the URL. | Please use `String#Equals(String, StringComparison)` |
@@ -1378,6 +1378,13 @@ public abstract class NuxeoLauncher {
return pwd;
}
+ /**
+ * @since 11.1
+ */
+ public char[] promptToken() throws IOException {
+ return promptPassword("Please enter your token: ");
+ }
+
/**
* @return a {@link NuxeoClientInstanceType}. Never {... | [NuxeoLauncher->[launch->[start,commandRequiresNoRunningServer,checkNoRunningServer,commandIs],setJSONOutput->[setXMLOutput],initConnectBroker->[getInfo],pkgRemove->[pkgRemove],isRunning->[getPid],logProcessStreams->[start],removeShutdownHook->[removeShutdownHook],configure->[run,checkNoRunningServer],pkgSetRequest->[p... | Prompt the user for a password and type. | This creates a deprecation warning. |
@@ -621,8 +621,8 @@
}]);
</script>
<div ng-controller="GreeterController">
- <input ng-model="name"> <br>
- <textarea ng-model="html"></textarea> <br>
+ <input ng-model="name"> <br/>
+ <textarea ng-model="html"></textarea> <br/>
<div compile="html"></div>
</div>
</fi... | [No CFG could be retrieved] | directive factory creates a directive that compiles the given element into a template function and registers the A link function which is used to bind a template to a parent scope. | These should have labels too. Oops! I'll fix them up later. |
@@ -203,6 +203,18 @@ func (eb *ethBroadcaster) processUnstartedEthTxs(fromAddress gethCommon.Address)
return errors.Wrap(err, "processUnstartedEthTxs failed")
}
for {
+ maxInFlightTransactions := eb.config.EthMaxInFlightTransactions()
+ if maxInFlightTransactions > 0 {
+ nUnconfirmed, err := CountUnconfirmed... | [Close->[Close],ethTxInsertTriggerer->[Trigger],tryAgainWithHigherGasPrice->[handleInProgressEthTx]] | processUnstartedEthTxs processes any unstarted transactions that are not yet started. | could also include the value of nUnconfirmed in the log |
@@ -66,12 +66,13 @@ public class MapReduceManagerImpl implements MapReduceManager {
@Inject
public void init(EmbeddedCacheManager cacheManager, PersistenceManager persistenceManager,
@ComponentName(ASYNC_TRANSPORT_EXECUTOR) ExecutorService asyncTransportExecutor,
- ClusteringDependentLog... | [MapReduceManagerImpl->[IntermediateCompositeKey->[hashCode->[hashCode],equals->[equals]],combineForLocalReduction->[reduce],combine->[reduce],map->[map],reduce->[reduce]]] | Initializes the object with the given parameters. | why using the state transfer chunk size? |
@@ -90,7 +90,7 @@ namespace System.Net.NetworkInformation
public override string ToString()
{
- return Convert.ToHexString(_address.AsSpan());
+ return HexConverter.ToString(_address.AsSpan(), HexConverter.Casing.Upper);
}
public byte[] GetAddressBytes()
| [PhysicalAddress->[Equals->[GetHashCode],TryParse->[TryParse]]] | Get the string representation of this node. | It's concerning if the brand new public API is insufficient. |
@@ -40,7 +40,12 @@ class TestNPFunctions(TestCase):
functions to be tested.
x_types: the types of the values being tested, see numba.types
x_values: the numerical values of the values to be tested
- flags: flags to pass to the ComplicationnCache::ccache::compile function
+ ... | [sinc->[sinc],TestNPFunctions->[test_sinc->[run_unary_real,run_unary_complex]]] | Runs tests for a unary function operating in the numerical real space. | I like how the "ComplicationCache" typo is retained ;-) |
@@ -140,6 +140,7 @@ def check_lines_quantity(
quantities,
country,
channel_slug,
+ site_settings_quantity_limit,
allow_zero_quantity=False,
existing_lines=None,
replace=False,
| [CheckoutBillingAddressUpdate->[perform_mutation->[CheckoutBillingAddressUpdate,save,get_checkout_by_token]],CheckoutLinesDelete->[perform_mutation->[update_checkout_shipping_method_if_invalid,CheckoutLinesDelete,validate_lines,get_checkout_by_token]],CheckoutComplete->[perform_mutation->[CheckoutComplete,get_checkout_... | Check if the quantity of a single branch is sufficient for each checkout line. | Just curious. Do we need to name it `site_settings_...`? I mean - is it important that this limit comes from site_settings? |
@@ -25,6 +25,9 @@ import org.mule.service.http.api.HttpConstants;
*/
public final class RequestConnectionParams {
+ public static final String DEFAULT_MAX_CONNECTIONS = "-1";
+ public static final String DEFAULT_CONNECTION_IDLE_TIMEOUT = "30000";
+ public static final String DEFAULT_RESPONSE_BUFFER_SIZE = "1024... | [No CFG could be retrieved] | Package for request connection parameters. The host attribute is the host where the requests will be sent. | Easier to read with `10 * 1024` |
@@ -63,9 +63,8 @@ public class IncrementalIndexStorageAdapterTest
@Test
public void testSanity() throws Exception
{
- IncrementalIndex index = new IncrementalIndex(
- 0, QueryGranularity.MINUTE, new AggregatorFactory[]{new CountAggregatorFactory("cnt")},
- TestQueryRunners.pool
+ Incrementa... | [IncrementalIndexStorageAdapterTest->[testResetSanity->[get],testFilterByNull->[get,makeGroupByQueryEngine]]] | Test if there is a sequence of rows that are sorted by sequence of sequence of sequence of. | same here, parametrize for both on- and off-heap |
@@ -253,6 +253,8 @@ var ngIncludeDirective = ['$templateRequest', '$anchorScroll', '$animate',
currentScope.$emit('$includeContentLoaded', src);
scope.$eval(onloadExp);
}, function() {
+ if (scope.$$destroyed) return;
+
if (thisChangeId === changeCo... | [No CFG could be retrieved] | The ng - include directive is called when the content of the element is loaded. A directive that checks if an element is not an element with a - 400 priority. | looks like this code path is not tested |
@@ -71,9 +71,7 @@ def check_collection_ownership(request, collection, require_owner=False):
if not request.user.is_authenticated():
return False
- if action_allowed(request, amo.permissions.ADMIN):
- return True
- elif action_allowed(request, amo.permissions.COLLECTIONS_EDIT):
+ if actio... | [check_static_theme_reviewer->[action_allowed],check_collection_ownership->[action_allowed],submission_allowed->[action_allowed_user],check_personas_reviewer->[action_allowed],check_unlisted_addons_reviewer->[action_allowed],check_ownership->[check_ownership],check_addons_reviewer->[action_allowed],is_reviewer->[check_... | Check if the user has permission to view the collection. | observation: we could rewrite this entire method into a single `return xxx and (yyy or zzz)` statement. With debatable improvement on code readability. |
@@ -207,6 +207,8 @@ class Constants
ACADEMY_BL_LINK = 'https://scinote.net/academy/?utm_source=SciNote%20software%20BL&utm_medium=SciNote%20software%20BL'.freeze
+ PWA_URL = 'https://:pwa_domain/teams/:team_id/projects/:project_id/experiments/:experiment_id/tasks/:task_id/protocol/:protocol_id/:step_id?domain=:... | [Constants->[megabyte,freeze,times]] | Displays a list of missing nag records. Services for the Nexus authentication protocol. | Layout/LineLength: Line is too long. [164/120] |
@@ -81,7 +81,7 @@
EndpointSetup<DefaultServer>(c =>
{
var transport = c.UseTransport<MsmqTransport>();
- transport.Routing().RegisterPublisherForType(PublisherEndpoint, typeof(MyEvent));
+ transport.Routing().RegisterPublisherF... | [When_distributing_an_event->[Subscriber2->[MyMessageHandler->[Task->[OnReceived2]]],Subscriber1->[MyMessageHandler->[Task->[OnReceived1]]]]] | Creates an endpoint that can be used to configure a single . implements the interface. | Not related to this PR, but I wondered if we could automatically expose the endpoint name on the context by doing something like `context.EndpointNames[typeof(Publisher)]` and the convention calling is already done by the infra |
@@ -138,6 +138,9 @@ class Jetpack_Sync_Listener {
$is_importing = Jetpack_Sync_Settings::is_importing();
foreach ( $args_array as $args ) {
+ $previous_endpoint = isset( $args['previous_endpoint'] ) ? $args['previous_endpoint'] : null;
+ $args = isset( $args['ids'] )? $args['ids']: $args;
+
/**
... | [Jetpack_Sync_Listener->[enqueue_action->[can_add_to_queue],bulk_enqueue_full_sync_actions->[can_add_to_queue,get_full_sync_queue],set_defaults->[set_queue_lag_limit,set_queue_size_limit]]] | This function will enqueue all actions that can be performed in a full sync queue. | Minor spacing issue here: spaces after braces please. |
@@ -321,7 +321,7 @@ import a11ySpeak from "a11y-speak";
} );
// Allow collapsing of the content types sections.
- jQuery( "body" ).on( "click", "button.toggleable-container-trigger", ( event ) => {
+ jQuery( "body" ).on( "click", "div.toggleable-container-trigger", ( event ) => {
const target = jQuery( ev... | [No CFG could be retrieved] | On the first click on the switch - toggles and on the second click on the PRIVATE FUNCTIONS. | Please leave this a button. |
@@ -82,7 +82,7 @@ public class MetastoreUtil {
String topicname = node.get("topicname").asText();
String kafkaTopicName = node.get("kafkatopicname").asText();
String serde = node.get("serde").asText();
- if (serde.equalsIgnoreCase("avro")) {
+ if ("AVRO".equals(serde)) {
if (node.get("avrosc... | [MetastoreUtil->[addSchemas->[getKQLTypeInJson],loadMetaStoreFromJSONFile->[createKafkaTopicDataSource,createStructuredDataSource],writeMetastoreToFile->[addTopics,addSchemas],main->[loadMetaStoreFromJSONFile,MetastoreUtil]]] | Create Kafka topic data source. | Maybe we should be using the `*_SERDE_NAME` constants in DataSource while we're at it? |
@@ -200,7 +200,7 @@ var _ = g.Describe("[builds][Slow] openshift pipeline build", func() {
br.AssertSuccess()
g.By("confirm all the log annotations are there")
- _, err = jenkins.ProcessLogURLAnnotations(oc, br)
+ err = jenkins.ProcessLogURLAnnotations(oc, br, !useSnapshotImage)
o.Expect(err).NotTo(o.... | [Context,KubeClient,By,SetupSnapshotImage,StartBuildAndWait,Expect,HaveOccurred,FixturePath,NewRef,It,CheckBuildFailedFn,GetLastJobConsoleLogs,Stop,Args,Post,New,To,ReplicationControllers,StartBuildResult,Errorf,Namespace,GetResource,GetEndpointAddress,After,WaitForContent,TrimSpace,Equal,Execute,NewCLI,CheckBuildSucce... | Context is a context that starts the pipeline build and waits for it to complete. debug any failure in Jenkins. | this means the PR tester won't ever confirm we haven't broken the log annotations.... can't we make this instead discriminate on the jenkins image version being tested? |
@@ -421,8 +421,9 @@ void Client::step(float dtime)
ScopeProfiler sp(g_profiler, "Client: map timer and unload");
std::vector<v3s16> deleted_blocks;
m_env.getMap().timerUpdate(map_timer_and_unload_dtime,
- g_settings->getFloat("client_unload_unused_data_timeout"),
- &deleted_blocks);
+ g_settings->getFl... | [No CFG could be retrieved] | This function is called from the server code to initialize a specific network protocol. region Handle methods. | What!!? Why is this a float? |
@@ -153,6 +153,7 @@ public class AppenderatorPlumber implements Plumber
{
final SegmentIdWithShardSpec identifier = getSegmentIdentifier(row.getTimestampFromEpoch());
if (identifier == null) {
+ metrics.reportMessageMaxTimestamp(row.getTimestampFromEpoch());
return Plumber.THROWAWAY;
}
| [AppenderatorPlumber->[startJob->[startJob],mergeAndPush->[onSuccess->[apply],onFailure->[apply],apply->[dropSegment],add],getQueryRunner->[run->[run]],add->[add]]] | Add a row to the index. | @kaijianding Did you mean this to help with the Kafka indexing service mechanism? If so, this isn't the right file; it's only used by `AppenderatorPlumberSchool`, but Kafka indexing doesn't use that. I think AppenderatorImpl would be the right place to add it. |
@@ -189,8 +189,10 @@ class BertBasicWordSplitter(WordSplitter):
This is used to split a sentence into words.
Then the ``BertTokenIndexer`` converts each word into wordpieces.
"""
- def __init__(self, do_lower_case: bool = True) -> None:
- self.basic_tokenizer = BertTokenizer(do_lower_case)
+ ... | [SpacyWordSplitter->[split_words->[_remove_spaces],batch_split_words->[_remove_spaces]],OpenAISplitter->[split_words->[_remove_spaces,_standardize],batch_split_words->[_remove_spaces,_standardize]]] | Initialize the BertTokenizer class. | Should it be `never_split: Tuple[str]` instead of `never_split: Set[str]`? |
@@ -259,7 +259,7 @@ public class DruidCoordinatorLogger implements DruidCoordinatorHelper
final Stream<DataSegment> allSegments = params
.getDataSources()
.stream()
- .flatMap((final DruidDataSource dataSource) -> dataSource.getSegments().stream());
+ .flatMap((ImmutableDruidDataSou... | [DruidCoordinatorLogger->[emitTieredStats->[emitTieredStat],run->[emitTieredStat,emitTieredStats]]] | Run the coordinator. Emit coordinator metrics. This method is called to build metrics for all segments that are not yet in the queue. Missing params. | is the type even needed here? |
@@ -983,7 +983,15 @@ function stats_admin_bar_menu( &$wp_admin_bar ) {
$title = esc_attr( __( 'Views over 48 hours. Click for more Site Stats.', 'jetpack' ) );
- $menu = array( 'id' => 'stats', 'title' => "<div><script type='text/javascript'>var src;if(typeof(window.devicePixelRatio)=='undefined'||window.devicePi... | [stats_admin_bar_menu->[add_menu],stats_build_view_data->[get_queried_object_id],stats_print_wp_remote_error->[get_error_messages,get_error_codes]] | Add menu to admin bar. | This is made obsolete by #13450. |
@@ -22,9 +22,13 @@ import java.nio.file.Paths;
public class PropertyTestUtil {
public static void setLogFileProperty() {
+ System.setProperty("quarkus.log.file.path", getLogFileLocation());
+ }
+
+ public static String getLogFileLocation() {
if (Files.isDirectory(Paths.get("build"))) {
- ... | [PropertyTestUtil->[setLogFileProperty->[setProperty,get,isDirectory]]] | This method sets the log file property if the build directory or the target file is a directory. | Missing bracketing of else (assumed unintentional due to following indent) |
@@ -9,8 +9,12 @@ import (
"github.com/openshift/origin/pkg/util/namer"
)
-// BuildPodSuffix is the suffix used to append to a build pod name given a build name
-const BuildPodSuffix = "build"
+const (
+ // BuildPodSuffix is the suffix used to append to a build pod name given a build name
+ BuildPodSuffix = "build"... | [Index,GetPodName] | GetBuildName returns the name of the given build pod or build object. IsBuildComplete returns true if the provided build is complete. | period at the end, to align it with the rest of the message you're appending this to. |
@@ -19,10 +19,14 @@ namespace System.Runtime.InteropServices
{
private readonly object _dummy;
private readonly int _dummyPrimitive;
+ public static System.Runtime.InteropServices.OSPlatform Android { get { throw null; } }
public static System.Runtime.InteropServices.OSPlatform Br... | [No CFG could be retrieved] | Creates a new OSPlatform object. | @terrajobst, are all of these approved and ready to go? |
@@ -48,7 +48,6 @@
#include "libzfs_impl.h"
#define ZDIFF_SNAPDIR "/.zfs/snapshot/"
-#define ZDIFF_SHARESDIR "/.zfs/shares/"
#define ZDIFF_PREFIX "zfs-diff-%d"
#define ZDIFF_ADDED '+'
| [No CFG could be retrieved] | Creates a CDDL HEADER from a single object. Get the stats for a single object. | Why move this? Is the path different on FreeBSD? Note this is currently unimplemented on Linux. |
@@ -6,6 +6,8 @@
package io.opentelemetry.instrumentation.api.config;
public class ConfigParsingException extends RuntimeException {
+ private static final long serialVersionUID = 384182080843382041L;
+
public ConfigParsingException(String message) {
super(message);
}
| [No CFG could be retrieved] | Exception thrown when a configuration is not present. | I would use `serialVersionUID = 1L;` otherwise it is hard to tell whether this is just a random number or deliberately computed with serialver |
@@ -109,6 +109,8 @@ define([
* @param {Boolean} [options.show=true] Determines if the tileset will be shown.
* @param {Matrix4} [options.modelMatrix=Matrix4.IDENTITY] A 4x4 transformation matrix that transforms the tileset's root tile.
* @param {Number} [options.maximumScreenSpaceError=16] The maximum... | [No CFG could be retrieved] | A Cesium 3D tileset is a base class for all the tiles in a Display the bounding volume for each tile. | Do we still need `maximumNumberOfLoadedTiles`? When would it be used now that we have `maximumMemoryUsage`? |
@@ -146,10 +146,11 @@ func validateDBAgainstConfig(bucket *bolt.Bucket, fieldName, runtimeValue string
return nil
}
- // If DB value is the empty string, check that the
- // runtime value is the default
- if string(keyBytes) == "" && defaultValue != "" &&
- runtimeValue == defaultValue {
+ // If D... | [getContainerFromDB->[Wrapf,Equal,Bucket,RetrieveLock,Unmarshal,Get],closeDBCon->[Close,Unlock],removeContainer->[ID,Wrapf,Join,Bucket,ForEach,Split,Contains,Name,Dependencies,Delete,Errorf,Get,DeleteBucket],addContainer->[ID,Wrapf,Bucket,Equal,Marshal,closeDBCon,Update,Put,Name,Contains,CreateBucket,Dependencies,Names... | validateDBAgainstConfig validates a given configuration entry in the DB and creates a new configuration returns the database for the given sequence number. | Should we update the data with the correct value? |
@@ -1058,6 +1058,7 @@ export class AmpAdNetworkDoubleclickImpl extends AmpA4A {
this.element.getAttribute('data-amp-slot-index'));
return Promise.reject('Cannot access body of friendly frame');
}
+ setImportantStyles(this.element, {position: 'static'});
return this.attemptChange... | [AmpAdNetworkDoubleclickImpl->[postTroubleshootMessage->[dict,stringify,now,devAssert,userAgent],extractSize->[height,extractAmpAnalyticsConfig,dev,get,width],getBlockParameters_->[width,height,getContainerWidth,isInManualExperiment,serializeTargeting,assign,devAssert,googleBlockParameters,Number],constructor->[user,ex... | Expands a fluid creative if possible. | This will cause a full reflow of the page, so it needs to be done in measure/mutate phases. Also, how does `position: absolute` affect the measurements? The only thing it should change is child elements will consider it the `offsetParent`, which is why we set all elements to absolute by default. |
@@ -73,6 +73,12 @@ func (c *Repair) RunUntil(ch chan struct{}) {
// RunOnce verifies the state of the cluster IP allocations and returns an error if an unrecoverable problem occurs.
func (c *Repair) RunOnce() error {
+ return client.RetryOnConflict(client.DefaultBackoff, c.runOnce)
+}
+
+// runOnce verifies the sta... | [RunUntil->[Until,RunOnce,HandleError],RunOnce->[NewCIDRRange,NewDefaultContext,IsServiceIPSet,WithNamespace,ListServices,Allocate,CreateOrUpdate,Errorf,Snapshot,Get,ParseIP,Sleep,HandleError,Everything]] | RunOnce runs the service repair This function is used to allocate a new cluster IP for a service. It will also attempt. | Update doc to match upstream change |
@@ -36,13 +36,13 @@ import org.sonar.plugins.java.api.tree.Tree;
@Rule(key = "S1313")
public class HardcodedIpCheck extends BaseTreeVisitor implements JavaFileScanner {
- private static final Pattern IP_V4_REGEX = Pattern.compile("([^\\d.]*\\/)?((?<ip>(?:\\d{1,3}\\.){3}\\d{1,3})(:\\d{1,5})?(?!\\d|\\.))(\\/.*)?");
... | [HardcodedIpCheck->[extractIPV6->[findFirst],isBroadcastAddress->[equals],extractIPV4->[filter,looksLikeAsn1ObjectIdentifier],looksLikeAsn1ObjectIdentifier->[startsWith],isValidIPV4Parts->[allMatch],isLoopbackAddress->[startsWith,matches],isNonRoutableAddress->[matches,equals],isValidIPV6PartCount->[countMatches,split]... | region Private methods Scans the file for hardcoded IP addresses. | This will probably be more readable if we split the regex into multiple named (private static final String) variables, PROTOCOL, IP, PORT and PATH. That will hopefully make it more readable, fix the regex complexity issue and avoid the confusion I had initially about what the rule is even matching. |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.