patch stringlengths 18 160k | callgraph stringlengths 4 179k | summary stringlengths 4 947 | msg stringlengths 6 3.42k |
|---|---|---|---|
@@ -53,8 +53,8 @@ public abstract class AbstractKeyOperation<T> extends RetryOnFailureOperation<T>
return readHeaderAndValidate(transport, params);
}
- protected byte[] returnPossiblePrevValue(Transport transport) {
- if (hasForceReturn(flags)) {
+ protected byte[] returnPossiblePrevValue(Transpor... | [AbstractKeyOperation->[returnVersionedOperationResponse->[returnPossiblePrevValue],getTransport->[getTransport]]] | Send a key operation. | hasForceReturn is no longer referenced and can be removed it seems. |
@@ -193,8 +193,8 @@ class UntilSuccessfulRouter {
} else { // Retries exhausted
// Current context already pooped. No need to re-insert it
LOGGER.error("Retry attempts exhausted. Failing...");
- Throwable resolvedError = getThrowableFunction(ctx.event).apply(error);
// Delete cu... | [UntilSuccessfulRouter->[expressionToIntegerSupplierFor->[getValue,RetryContextInitializationException],getScopeResultMapper->[isLeft,propagate,getLeft,getRight],getRetryContextForEvent->[get,getId],getRetryHandler->[schedule,error,getRetryContextForEvent,apply,eventWithCurrentContext,getAndDecrement,getAttemptNumber,l... | Gets the handler to be used to handle a retry. | is there any reason to move this line down? |
@@ -173,10 +173,10 @@ def test_bem_solution():
def test_fit_sphere_to_headshape():
"""Test fitting a sphere to digitization points"""
# Create points of various kinds
- rad = 90. # mm
- big_rad = 120.
- center = np.array([0.5, -10., 40.]) # mm
- dev_trans = np.array([0., -0.005, -10.])
+ rad... | [test_bem_model->[_compare_bem_surfaces],test_bem_solution->[_compare_bem_solutions],_compare_bem_solutions->[_compare_bem_surfaces],test_io_bem->[_compare_bem_surfaces,_compare_bem_solutions]] | Test fitting a sphere to digitization points of various kinds of a specific base. Test if a bunch of points in the sphere match a perfect sphere. Test if all points in the system fit to the head shape of the noisy E Test if a node in a sphere is a missing node in a non - overlapping region. | -> [0.0005, -0.01, 0.04] |
@@ -69,7 +69,9 @@
<input type='reset' value='<%= t(:cancel) %>' onclick='modal_upload.close();'>
</p>
<% end %>
+</aside>
+<aside class='dialog' id='upload_yml_dialog'>
<h1><%= t('rubric_criteria.upload.yml_title') %></h1>
<p><%= t('rubric_criteria.upload.yml_prompt') %></p>
<%= form_for :yml_... | [No CFG could be retrieved] | Renders the list of all possible elements in the hierarchy. View for selecting a specific assignment rubric. | onclick should be `modal_upload_csv.close()`? Same with yml below? |
@@ -88,7 +88,7 @@ class AnalyticsEvent {
/**
* @param {!AnalyticsEventType|string} type The type of event.
- * @param {!Object<string, string>=} opt_vars A map of vars and their values.
+ * @param {?Object<string, string>=} opt_vars A map of vars and their values.
*/
constructor(type, opt_vars) {
... | [No CFG could be retrieved] | Adds a listener to the window and the analytics element. The viewport for the document. | Confused. How does ! and = work together? How is it different from ? and = being used together? |
@@ -13,7 +13,14 @@ def get_list(text):
return [item.strip() for item in text.split(',')]
-DEBUG = ast.literal_eval(os.environ.get('DEBUG', 'True'))
+def get_bool(name, default_value):
+ if name in os.environ:
+ value = os.environ[name]
+ return ast.literal_eval(value)
+ return default_value... | [get_list->[strip,split],get_host->[get_current],get_currency_fraction,literal_eval,bool,int,_,parse,append,get_list,dirname,insert,get,getenv,config,setdefault,repr,join,normpath] | Load a specific object. This function is a static helper function that returns a list of all possible unique identifiers. | I wonder if we can find more descriptive name for this. `get_env_variable_value`? I'd look for something not too long, but providing enough information. |
@@ -56,6 +56,9 @@ class Flang(CMakePackage):
spec['python'].command.path)
]
+ if '+nvptx' in spec:
+ options.append('-DFLANG_OPENMP_GPU_NVIDIA=ON')
+
return options
@run_after('install')
| [Flang->[setup_build_environment->[set],setup_run_environment->[set],post_install->[write,chmod,format,join,close,which,open],cmake_args->[find_libraries,format,join],run_after,depends_on,version]] | Return a list of options for cmake. Check if chmod is available. | We should explicitly disable this in an else clause |
@@ -1327,7 +1327,9 @@ namespace System.Xml
{
if (node2.XPNodeType == XPathNodeType.Attribute)
{
- XmlElement element = ((XmlAttribute)node1).OwnerElement;
+ XmlElement? element = ((XmlAttribute)node1).OwnerElement;
+ ... | [DocumentXPathNavigator->[CalibrateText->[ResetPosition],MoveToFirstNamespaceGlobal->[MoveToFirstNamespaceLocal],XmlNodeOrder->[GetDepth],LookupNamespace->[LookupNamespace],IsDescendant->[IsDescendant],MoveToNextNamespaceGlobal->[MoveToFirstNamespaceLocal,MoveToNextNamespaceLocal]],DocumentXPathNodeIterator_AllElemChil... | Compares two nodes in the tree. | Not needed, I believe at this point attribute always have OwnerElement |
@@ -17,12 +17,8 @@ import (
// a *testing.T). We define this in order to avoid pulling in the
// "testing" package in exported code.
type TestLogBackend interface {
- Error(args ...interface{})
- Errorf(format string, args ...interface{})
- Fatal(args ...interface{})
- Fatalf(format string, args ...interface{})
- L... | [CFatalf->[Fatalf],CNoticef->[Logf],CCriticalf->[Logf],Error->[Logf],CErrorf->[Logf],CDebugf->[Logf],CInfof->[Logf],Warning->[Logf],Critical->[Logf],CWarningf->[Logf],Errorf->[Logf],Fatalf->[Fatalf],Info->[Logf],Notice->[Logf],Profile->[Logf],Debug->[Logf],Sprintf,Split,Caller] | Logger creates a Logger that logs to a specific context tag. Centralized version of Debug. | @strib Any reason for not logging context tags? Is it because it's too spammy for unit tests? Would it be useful for the DSL/fuse/docker tests? |
@@ -228,6 +228,14 @@ public class PutHDFS extends AbstractHadoopProcessor {
FsPermission.setUMask(config, new FsPermission(dfsUmask));
}
+ @OnScheduled
+ public void onScheduled(final ProcessContext context) {
+ aclCache = Caffeine.newBuilder()
+ .maximumSize(20L)
+ ... | [PutHDFS->[changeOwner->[getOwner,getGroup,warn,setOwner],findCause->[findFirst,stream],onTrigger->[run->[process->[create,of,getFileDefault,equals,append,applyUMask,getUMask,flush,BufferedInputStream,copy,delete,shouldIgnoreLocality,close,add,createOutputStream,getConf],getValue,Path,equals,getWorkingDirectory,getFail... | Pre - process the configuration. if destination file already exists then resolve that otherwise create temp file on HDFS copies a dot file to HDFS and checks if it can be resolved. Private method for writing to HDFS. | Should there a corresponding `onStopped` method that clears the `aclCache`? |
@@ -182,6 +182,7 @@ class AmpSpringboardPlayer extends AMP.BaseElement {
} else {
placeholder.setAttribute('alt', 'Loading video');
}
+ this.applyFillContent(placeholder);
return placeholder;
}
}
| [No CFG could be retrieved] | - placeholder - placeholder. | Remove the `setAttribute('layout', 'fill')`? |
@@ -247,6 +247,9 @@ function wpseo_admin_bar_menu() {
// @todo: add links to bulk title and bulk description edit pages.
if ( $user_is_admin_or_networkadmin ) {
+
+ $advanced_settings = wpseo_advanced_settings_enabled( $options );
+
$wp_admin_bar->add_menu( array(
'parent' => 'wpseo-menu',
'id' =>... | [wpseo_admin_bar_style->[register_assets,enqueue_style],wpseo_admin_bar_menu->[get_new_notifications,add_menu,is_enabled,canonical,get_notification_count]] | This function is used to output the admin bar menu Top level menu item content Yoast menu for the SEO Add menu items to the admin bar Add menu for WordPress SEO Add menu for WordPress SEO Add menu for all WordPress modules. | The first time I saw `$advanced_settings` I thought is contains an array with advanced settings. I think `has_advanced_settings_enabled` or `advanced_settings_enabled` would be better. |
@@ -747,6 +747,11 @@ class Trainer:
self._save_checkpoint(epoch, validation_metric_per_epoch, is_best=is_best_so_far)
self._metrics_to_tensorboard(epoch, train_metrics, val_metrics=val_metrics)
self._metrics_to_console(train_metrics, val_metrics)
+ for ind, param_group ... | [Trainer->[_parameter_and_gradient_statistics_to_tensorboard->[add_train_scalar,is_sparse],train->[_enable_activation_logging,_validation_loss,_should_stop_early,_metrics_to_tensorboard,_enable_gradient_clipping,_metrics_to_console,_train_epoch,_get_metrics],_enable_activation_logging->[hook->[add_train_histogram]],_re... | Trains the model with the supplied parameters. This function is called when a single epoch has hit a . It will save the training Get the best validation metric for each epoch. | `ind` is for `index`? If so, just use `index` - for the price of just two characters, I don't have to guess what you mean ;). |
@@ -110,9 +110,9 @@ public final class ValueProviderMediator<T extends ParameterizedModel & Enrichab
* @return a {@link Set} of {@link Value} correspondent to the given parameter
* @throws ValueResolvingException if an error occurs resolving {@link Value values}
*/
- public Set<Value> getValues(String para... | [ValueProviderMediator->[resolveValues->[toCollection,resolve,createValueProvider,collect],getValues->[getMessage,orElseThrow,getName,ValueResolvingException,get,getValues,getParameters,resolveValues,format,isEmpty,withRefreshToken],getParameters->[toList,collect]]] | Gets the values for the given parameter. | Would this bring problems for tooling? I think they use this class directly. @gsfernandes |
@@ -119,10 +119,16 @@ func (o *DockerbuildOptions) Run() error {
if glog.V(2) {
glog.Infof("Builder: "+format, args...)
} else {
- fmt.Fprintf(e.ErrOut, "# %s\n", fmt.Sprintf(format, args...))
+ fmt.Fprintf(e.ErrOut, "--> %s\n", fmt.Sprintf(format, args...))
}
}
- return stripLeadingError(e.Build(f, ... | [Run->[Build,Fprintf,Infof,NewClientExecutor,Sprintf,Close,V,Open],Complete->[SplitEnvironmentFromResources,Join,NewClientFromEnv,UsageError,NewDockerKeyring,ParseEnvironmentArguments],Exit,StringVar,Flags,Error,HasPrefix,Sprintf,Validate,TrimPrefix,Errorf,MarkFlagFilename,CheckErr,Run,Complete,BoolVar] | Run executes the Docker build. | +1 for this... I was going to suggest that in the other PR... '#' looks weird. |
@@ -48,6 +48,7 @@ public abstract class NiFiProperties {
// core properties
public static final String PROPERTIES_FILE_PATH = "nifi.properties.file.path";
+ public static final String FLOW_CONFIGURATION_IMPLEMENTATION = "nifi.flow.configuration.implementation";
public static final String FLOW_CONFIG... | [NiFiProperties->[getComponentDocumentationWorkingDirectory->[getProperty],getKerberosSpnegoKeytabLocation->[getProperty],getFlowConfigurationFile->[getProperty],getAutoResumeState->[getProperty],getEmbeddedZooKeeperPropertiesFile->[getProperty],getNarLibraryDirectories->[getPropertyKeys,getProperty],getFlowServiceWrit... | This class is used to provide all the properties that are needed for various values of the n NAR library directory prefix. | This needs to be added in nifi.properties file in nifi-resources. |
@@ -195,6 +195,8 @@ public class TestHoodieDataSourceInternalWriter extends
}
}
+ // takes up lot of running time with CI.
+ @Disabled
@ParameterizedTest
@MethodSource("bulkInsertTypeParams")
public void testLargeWrites(boolean populateMetaFields) throws Exception {
| [TestHoodieDataSourceInternalWriter->[testDataSourceWriterEmptyExtraCommitMetadata->[testDataSourceWriterInternal],testDataSourceWriterExtraCommitMetadata->[testDataSourceWriterInternal]]] | This test method creates a data writer and writes data to the data source. This test method creates large writes with random rows. Returns a new instance of the class that will be used to create the class. | but do we need this re-enabled at some point? |
@@ -153,12 +153,12 @@ class JarDependencyManagementIntegrationTest(PantsRunIntegrationTest):
with self._testing_build_file():
with temporary_dir() as distdir:
run = self.run_pants([
- '--pants-distdir={}'.format(distdir),
+ f'--pants-distdir={distdir}',
'binary',
- ... | [JarDependencyManagementIntegrationTest->[test_managed_redundant->[_assert_run_classpath],test_forceful_fail->[_run_project],test_managed_auto->[_assert_run_classpath],test_managed_fail->[_run_project],test_managed_forceful_use_managed->[_assert_run_classpath],test_all_targets_work->[_testing_build_file],test_managed->... | Test if two managers build are available. | These aren't technically wrong..but are strange. Can you please simplify them to be basic strings where possible? |
@@ -76,6 +76,7 @@ RSpec.describe ApplicationHelper, type: :helper do
before do
allow(ApplicationConfig).to receive(:[]).with("APP_PROTOCOL").and_return("https://")
allow(ApplicationConfig).to receive(:[]).with("APP_DOMAIN").and_return("dev.to")
+ SiteConfig.app_domain = "dev.to"
end
... | [create,let,be,size,describe,community_name,slug,cl_image_tag,it,to,optimized_image_tag,have_selector,before,community_copyright_start_year,have_text,and,require,optimized_image_url,to_s,include,image,have_link,path,context,build,eq,and_return] | endregion region Private Methods The test example. | Do we need to unset this so that it doesn't leak into other tests? |
@@ -1393,9 +1393,9 @@ static int s390x_aes_cfb8_cipher(EVP_CIPHER_CTX *ctx, unsigned char *out,
static int s390x_aes_cfb1_cipher(EVP_CIPHER_CTX *ctx, unsigned char *out,
const unsigned char *in, size_t len);
-# define S390X_aes_128_ctr_CAPABLE 1 /* checked by callee */
-# define S39... | [No CFG could be retrieved] | Initialize the AES - T4 cipher. Initialize AES - T4 cipher. | ???? Is this field not used? If not why not remove it. |
@@ -946,11 +946,11 @@ class Diaspora {
// Yes, then it is fine.
return true;
// Is it a post to a community?
- } elseif (($contact["rel"] == CONTACT_IS_FOLLOWER) && ($importer["page-flags"] == PAGE_COMMUNITY)) {
+ } elseif (($contact["rel"] == CONTACT_IS_FOLLOWER) && ($importer["page-flags"] == PAGE_COMMUN... | [Diaspora->[receive_status_message->[children],decode_raw->[children,attributes],verify_magic_envelope->[children,attributes],message->[getName],decode->[children,attributes],receive_request_make_friend->[get_hostname],transmit->[get_curl_code,get_curl_headers],valid_posting->[children,getName],dispatch->[getName]]] | This method is used to determine if a contact is allowed to post to a community or a. | I don't like combinations of different logical operators without braces. They tend to confuse. Why not use the old code here? |
@@ -453,6 +453,14 @@ export class AmpStoryEventTracker extends CustomEventTracker {
fireListener_(event, rootTarget, config, listener) {
const type = event['type'];
const vars = event['vars'];
+ const storySpec = config['storySpec'] || {};
+ const repeat =
+ storySpec['repeat'] === undefined ? t... | [No CFG could be retrieved] | Adds an event listener to the buffer and the associated root element. The ClickEventTracker tracks click events. | I'd like to discuss what is a good default value here? Personally I prefer the default value to be false. Are we making it true to not change current behavior? |
@@ -912,8 +912,14 @@ def apply_montage(info, montage):
The measurement info to update.
montage : instance of Montage
The montage to apply.
+ ch_type : string
+ The type of electrode contained in this montage. Can be 'eeg' or 'ieeg'
"""
- if not _contains_ch_type(info, 'eeg'):
+ ... | [make_grid_layout->[Layout],read_montage->[Montage],find_layout->[read_layout,make_eeg_layout],read_layout->[_read_lout,Layout,_read_lay],make_eeg_layout->[Layout],_pair_grad_sensors->[_find_topomap_coords]] | Apply montage to the EEG data. | ValueError('Channel type should be eeg or ieeg (got %s).' % ch_type) |
@@ -1929,7 +1929,7 @@ class UpdatePFS(SignedMessage):
)
-CMDID_TO_CLASS = {
+CMDID_TO_CLASS: Dict[int, Any] = {
messages.DELIVERED: Delivered,
messages.LOCKEDTRANSFER: LockedTransfer,
messages.PING: Ping,
| [from_dict->[from_dict],LockedTransferBase->[unpack->[Lock],__init__->[assert_transfer_values]],RefundTransfer->[from_event->[Lock],from_dict->[from_dict],to_dict->[to_dict],unpack->[Lock]],EnvelopeMessage->[message_hash->[packed],__init__->[assert_envelope_values]],Message->[__ne__->[__eq__]],Lock->[from_bytes->[Lock]... | This function takes a packed object and returns a dictionary of the object s properties. | This would be `[int, Message]` |
@@ -62,7 +62,7 @@ void RenderingCoreSideBySide::drawAll()
void RenderingCoreSideBySide::useEye(bool _right)
{
driver->setRenderTarget(_right ? right : left, true, true, skycolor);
- RenderingCoreStereo::useEye(_right);
+ RenderingCoreStereo::useEye(flipped != _right);
}
void RenderingCoreSideBySide::rese... | [resetEye->[resizeHotbar,setRenderTarget,drawHUD],initTextures->[addRenderTargetTexture,v2s32],clearTextures->[removeTexture],useEye->[setRenderTarget],drawAll->[OnResize,draw2DImage,renderBothImages]] | This function is called from the main rendering loop. | `_right ^ flipped` might be clearer |
@@ -2483,8 +2483,16 @@ class TypeChecker(NodeVisitor[None], CheckerPluginInterface):
# control in cases like: a, b = [int, str] where rhs would get
# type List[object]
- rvalues = rvalue.items
-
+ rvalues = [] # type: List[Expression]
+ for rval in rvalue.it... | [TypeChecker->[get_op_other_domain->[get_op_other_domain],analyze_async_iterable_item_type->[accept],visit_try_without_finally->[check_assignment,accept],visit_class_def->[accept],iterable_item_type->[lookup_typeinfo],visit_for_stmt->[accept_loop],visit_operator_assignment_stmt->[check_final,try_infer_partial_generic_t... | Checks if a single lvalue or rvalue is assigned to a single nvalue. | If the type is an iterable, for example, the correct thing to do here would be to expand the right number of iterable item types, depending on the number of lvalues. It's okay if you don't want to implement that in this PR, however. The alternative would be to give an error about not being able to check the number of r... |
@@ -20,7 +20,7 @@ from allennlp.data.tokenizers.tokenizer import Tokenizer
from allennlp.data.tokenizers.word_splitter import SpacyWordSplitter
from allennlp.data.token_indexers import SingleIdTokenIndexer
from allennlp.data.token_indexers.token_indexer import TokenIndexer
-from allennlp.semparse import ParsingError... | [WikiTablesDatasetReader->[text_to_instance->[tokenize,IndexField,enumerate,TextField,is_instance_specific_entity,get_agenda,Instance,WikiTablesLanguage,MetadataField,debug,logical_form_to_action_sequence,error,append,get_table_knowledge_graph,len,KnowledgeGraphField,split,ProductionRuleField,read_from_lines,lower,List... | This class creates a DatasetReader for Wikitables. Provide the content of a table as a dictionary. | Isn't this imported at the module level? If it's not, it should be, so this line shouldn't need to be changed. |
@@ -38,6 +38,10 @@ export default createPreviewComponent(305, 165, {
paint(ctx, colors, font, width, height) {
const headerHeight = height * 0.3;
+ if (font === "-apple-system") {
+ font = "System";
+ }
+
this.drawFullHeader(colors, font);
const margin = width * 0.04;
| [No CFG could be retrieved] | Creates a component that displays a dark light diff of the base scheme and a link to the Displays the user - specified link to the user s link to the link to the link to. | I think I messed something up during initial implementation because at this point, `font` should hold the value of `font[:name]`. |
@@ -0,0 +1,13 @@
+from django.conf.urls import patterns, url
+from . import views
+
+urlpatterns = patterns('',
+ url(r'^$', views.ProductListView.as_view(),
+ name='products'),
+ url(r'^(?P<pk>[0-9]+)/update/$',
+ views.Pro... | [No CFG could be retrieved] | No Summary Found. | PEP8 line to long, it should look like `saleor/dashboard/order/urls.py`. |
@@ -33,13 +33,17 @@ import {user} from '../../../src/log';
export function fetchCachedSources(videoEl, win) {
if (
!extensionScriptInNode(win, 'amp-cache-url', '0.1') ||
- !videoEl.querySelector('source[src]').getAttribute('src')
+ !(
+ videoEl.getAttribute('src') ||
+ videoEl.querySelector('so... | [No CFG could be retrieved] | Fetches the cached sources for a video element. Selects and returns the prioritized video source URL. | Can you guarantee that `videoEl.querySelector('source[src]')` matches something? |
@@ -280,8 +280,8 @@ public class FileSplitter extends AbstractMessageSplitter {
}
catch (IOException e) {
try {
- bufferedReader.close();
this.done = true;
+ bufferedReader.close();
}
catch (IOException e1) {
// ignored
| [FileSplitter->[splitMessage->[close->[close],next->[hasNext],hasNext->[close],next,hasNext]]] | This method splits a message into two parts. Iterator that implements the Iterator interface. This method is used to create a message builder that will add a marker to the message. | Why did you swap these lines? |
@@ -78,9 +78,12 @@ class InitializerApplicator:
not_explicitly_initialized_parameters.append((name, parameter))
for name, parameter in not_explicitly_initialized_parameters:
- self._default_initializer(parameter)
- logger.info("Initializing %s using the Default "
- ... | [InitializerApplicator->[from_params->[InitializerApplicator]]] | Initializes the n - tuple with the given module. Construct a InitializerApplicator containing the specified initializers. | Why are there brackets here? It doesn't look like the functionality has changed. |
@@ -674,9 +674,13 @@ func (node *Node) setupForShardLeader() {
node.serviceManager.RegisterService(service_manager.BlockProposal, blockproposal.NewService(node.Consensus.ReadySignal, node.WaitForConsensusReady))
// Register client support service.
node.serviceManager.RegisterService(service_manager.ClientSupport,... | [ServiceManagerSetup->[setupForShardLeader,setupForBeaconValidator,setupForShardValidator,setupForNewNode,setupForBeaconLeader],AddFaucetContractToPendingTransactions->[addPendingTransactions],CallFaucetContract->[addPendingTransactions],SupportSyncing->[DoSyncing],DoSyncing->[IsOutOfSync],AddPeers->[AddPeers],AddDepos... | setupForShardLeader registers the services for the node that are used for the leader of a. | as discussed you said peerdiscovery does 2 things: 1/ for new node, it talks to bootnode to obtain info of some beacon peers 2/ maintain the discovery peers i believe we need 2/ for every node. 1/ is just for new node or anyone who does not know how to join the blockchain network. with that i'm thinking we can break do... |
@@ -4801,7 +4801,11 @@ EVP_PKEY *ssl_generate_param_group(SSL *s, uint16_t id)
EVP_PKEY_CTX *pctx = NULL;
EVP_PKEY *pkey = NULL;
const TLS_GROUP_INFO *ginf = tls1_group_id_lookup(id);
+#if 0
+ const char * pkey_ctx_name;
+#else
int pkey_ctx_id;
+#endif
if (ginf == NULL)
goto err;
| [No CFG could be retrieved] | Generate parameters from a group ID region EncryptionGroup methods Ejecuta un nuevo nuevo nuevo nuevo. | `*pkey_ctx_name` (no space)? |
@@ -151,7 +151,7 @@ func (l *Limits) RegisterFlags(f *flag.FlagSet) {
f.IntVar(&l.MaxGlobalMetricsWithMetadataPerUser, "ingester.max-global-metadata-per-user", 0, "The maximum number of active metrics with metadata per user, across the cluster. 0 to disable. Supported only if -distributor.shard-by-all-labels is true.... | [NotificationBurstSize->[NotificationRateLimit],NotificationRateLimit->[getNotificationLimitForUser]] | RegisterFlags registers the flags for the distributor. This is a convenience function for setting the maximum number of label names and values that can be - per - query limit -distributor. shard - by - all - labels Cortex with blocks storage. | Should we break these two configs apart and have `querier.max-fetched-chunks-per-query` be it's own config option rather than having this config override `-store.query-chunk-limit.`? |
@@ -1308,6 +1308,14 @@ func (pkg *pkgContext) getDefaultValue(dv *schema.DefaultValue, t schema.Type) (
return "", err
}
val = v
+ switch t.(type) {
+ case *schema.EnumType:
+ typeName := strings.TrimSuffix(strings.TrimSuffix(pkg.typeString(t), "Input"), "Ptr")
+ if typeName == "pulumi." {
+ typeName... | [outputType->[resolveObjectType,outputType,resolveResourceType,tokenToType,tokenToEnum],genEnumRegistrations->[detailsForType,tokenToEnum],genOutputTypes->[detailsForType,tokenToType,typeString,outputType],functionResultTypeName->[functionName],genResourceModule->[genHeader],argsTypeImpl->[tokenToType,tokenToEnum,argsT... | getDefaultValue returns the default value of a field. | It feels like there is some deficiency in typeString here. Perhaps the unwrapping of Input(T) -> T and *T -> T can happen as a transform of `t`, not the string, before we pass it to `pkg.typeString()` and pkg.typeString could take care of `pulumi.Any` as well? |
@@ -1,11 +1,5 @@
<% if @default_home_feed && user_signed_in? %>
<% cache("fetched-home-articles-object", expires_in: 3.minutes) do %>
- <% @new_stories = Article.published.
- where("published_at > ? AND score > ?", rand(2..6).hours.ago, -15).
- limited_column_select.
- order("published_at... | [No CFG could be retrieved] | Renders a hidden element with the necessary HTML for the user s article list. Find out which stories have a n - article. | These are taken out because they'll be coming via JSON from the endpoint right? |
@@ -46,6 +46,8 @@ module GobiertoAdmin
click_on "Recover element"
end
+ page.accept_alert
+
assert has_message?("Container of contributions recovered correctly")
end
end
| [ArchiveContributionContainerTest->[site->[sites],process->[gobierto_participation_processes],contribution_container->[gobierto_participation_contribution_containers],test_archive_restore_contribution_container->[visit,within,with_signed_in_admin,exists?,has_message?,with_javascript,refute,assert,with_current_site,id,c... | Checks that the archive and restore contribution container items are not deleted. | Trailing whitespace detected. |
@@ -0,0 +1,9 @@
+using System.Collections.Generic;
+
+namespace Pulumi.X.Automation
+{
+ /// <summary>
+ /// A Pulumi program as an inline function (in process).
+ /// </summary>
+ public delegate IDictionary<string, object?> PulumiFn();
+}
| [No CFG could be retrieved] | No Summary Found. | I do wonder if we should have this return `Task<IDictionary<string, object?>` instead? It would allow consumers to make their `PulumiFn` asynchronous, but it would also make synchronous functions a bit uglier because they would need to return `Task.FromResult(output)`. We could have a `PulumiFnAsync` and a `PulumiFn` a... |
@@ -211,6 +211,10 @@ type MasterConfig struct {
// EtcdClientInfo contains information about how to connect to etcd
EtcdClientInfo EtcdConnectionInfo
+ // KubernetesEtcdClientInfo contains information about how to connect to another etcd
+ // for kuberenetes data storage
+ KubernetesEtcdClientInfo *EtcdConnection... | [StringKeySet,NewString] | This function is only used for version 1. 1 and above. It is only used for. | this should be under KubernetesMasterConfig, it isn't relevant if we aren't running k8s in-process |
@@ -33,7 +33,7 @@ module Admin
def update
@user = User.find(params[:id])
- manage_credits
+ Users::ManageCredits.call(@user, user_params)
add_note if user_params[:new_note]
redirect_to "/admin/users/#{params[:id]}"
end
| [UsersController->[remove_credits->[remove_from,to_i],add_note->[create,id],banish->[redirect_to,perform_async,id,to_i],unlock_access->[redirect_to,unlock_access!,find,admin_user_path],user_params->[permit],add_credits->[to_i,add_to],show->[limit,find,verified_at,order,includes],full_delete->[call,redirect_to,find,mess... | Updates a user nag - check credits and status. | Since this handles user and org credits, I'd prefer `Credits::Manage` as a name. |
@@ -168,6 +168,6 @@ public class DefaultMultifactorTriggerSelectionStrategyTests {
private Principal mockPrincipal(final String attrName, final String... attrValues) {
return principalFactory.createPrincipal("user",
- ImmutableMap.of(attrName, attrValues.length == 1 ? attrValues[0] : ... | [DefaultMultifactorTriggerSelectionStrategyTests->[mockPrincipalService->[mockService],mockRequest->[mockRequest]]] | Mock principal. | Could this be moved to CoreAuthenticationTestUtils? I vaguely remember a method call in there that mocks principal creation? |
@@ -265,6 +265,7 @@ class DEMAnalysisStage(AnalysisStage):
def Initialize(self):
self.time = 0.0
self.time_old_print = 0.0
+ self.is_printing_rank = False
self.ReadModelParts()
| [DEMAnalysisStage->[RunAnalytics->[MakeAnalyticsMeasurements],SetRotationalScheme->[SelectRotationalScheme],SetInitialNodalValues->[SetInitialNodalValues],CleanUpOperations->[__SafeDeleteModelParts],SelectRotationalScheme->[SelectTranslationalScheme],_CreateSolver->[SetSolverStrategy],_BeforeSolveOperations->[IsTimeToP... | Initialize the object. Initialize the DEM inlet and the DEM energy calculator. | this is not needed In fact it is removed in #5154 |
@@ -51,6 +51,10 @@ func (c *buildConfigs) List(label, field labels.Selector) (result *buildapi.Buil
// Get returns information about a particular buildconfig and error if one occurs.
func (c *buildConfigs) Get(name string) (result *buildapi.BuildConfig, err error) {
+ if len(name) == 0 {
+ return nil, errors.New("... | [Create->[Path,Into,Do,Post,Namespace,Body],List->[Path,Into,Do,SelectorParam,Namespace,Get],Delete->[Path,Error,Do,Delete,Namespace],Watch->[Path,Param,Watch,SelectorParam,Namespace,Get],Get->[Path,Into,Do,Namespace,Get],Update->[Path,Into,Do,Namespace,Body,Put]] | Get returns the buildConfig with the given name. | Or we should just make Path("") return an error. Offhand I can't think when that is useful. |
@@ -602,14 +602,13 @@ public class CalciteParameterQueryTest extends BaseCalciteQueryTest
and(
bound("l1", "3", null, true, false, null, StringComparators.NUMERIC),
selector("f1", useDefault ? "0.0" : null, null)
-
)
... | [CalciteParameterQueryTest->[testParametersInStrangePlaces->[testQuery,SqlParameter,build,of],testFloats->[testQuery,SqlParameter,build,of],testLongs->[testQuery,SqlParameter,build,of],testMissingParameter->[expectMessage,testQuery,expect,of],testSelectTrimFamilyWithParameters->[testQuery,SqlParameter,build,of],testDou... | This test is used to test the type of missing key. No - op if there is no partition in the query. VARCHAR | CHAR | CHAR | CHAR | CHAR | CHAR | CHAR | CHAR | CHAR. | This doesn't seem right.. I guess it should be always 0. Based on the expected results before this PR, it seems that a timeseries query was issued when `useDefault = true` which returns an empty result. When `useDefault = false`, no query was issued so probably the query computation was done by Calcite. So, I guess the... |
@@ -1758,9 +1758,6 @@ class TypeChecker(NodeVisitor[Type]):
self.binder.try_frames.add(len(self.binder.frames) - 2)
self.accept(s.body)
self.binder.try_frames.remove(len(self.binder.frames) - 2)
- if s.else_body:
- self.accept(s.else_body)
- self.breaking_out = False
... | [TypeChecker->[visit_op_expr->[visit_op_expr],visit_operator_assignment_stmt->[accept,check_indexed_assignment],visit_unicode_expr->[visit_unicode_expr],visit_yield_from_expr->[accept,get_generator_return_type,get_generator_yield_type],visit_func_expr->[visit_func_expr],visit_ellipsis->[visit_ellipsis],try_infer_partia... | Type check a try statement. Called when a frame is on completion. | I suspect that `self.breaking_out = False` should be left here. I can try to come up with a test case, but if nothing breaks, I'd leave it. |
@@ -245,6 +245,16 @@ public class PullQueryQueue implements BlockingRowQueue {
return false;
}
+ private boolean doAcceptRow(final PullQueryRow row) throws InterruptedException {
+ while (!closed.get()) {
+ if (rowQueue.offer(row, offerTimeoutMs, TimeUnit.MILLISECONDS)) {
+ queuedCallback.run(... | [PullQueryQueue->[size->[size],pollRow->[poll],poll->[poll],drainRowsTo->[drainTo],acceptRow->[closeInternal],close->[closeInternal],isEmpty->[isEmpty]]] | Accept a row to be processed. | specific ask: I'd prefer to do everything in one loop, but if it's better not to, can you either inline this method or extract a method for the other loop? It looked to me like if we didn't have a limit, we'd only try to insert once, which is not the case. |
@@ -78,7 +78,10 @@ def automatically_fulfill_digital_lines(order: Order):
fulfillment=fulfillment, order_line=line, quantity=quantity
)
fulfill_order_line(order_line=line, quantity=quantity)
- emails.send_fulfillment_confirmation.delay(order.pk, fulfillment.pk)
+ emails.send_fulfill... | [order_needs_automatic_fullfilment->[order_line_needs_automatic_fulfillment],cancel_fulfillment->[update_order_status],update_order_prices->[recalculate_order],automatically_fulfill_digital_lines->[order_line_needs_automatic_fulfillment,fulfill_order_line]] | Fulfill all digital lines which have enabled automatic fulfillment setting. | Do we have a test that checks whether an order has the right status after this operation? |
@@ -322,7 +322,7 @@ void WebAssemblyInstance::LoadImports(
{
Assert(env->GetWasmFunction(counter) == nullptr);
AsmJsScriptFunction* func = AsmJsScriptFunction::FromVar(prop);
- if (!wasmModule->GetSignature(counter)->IsEquivalent(func->GetSignature()))
+ ... | [LoadGlobals->[GetType,GetConstInit,GetGlobalValue,GetGlobalCount,GetReferenceType,SetGlobalValue,GetGlobalIndexInit,GetGlobal],BuildObject->[GetType,IsMutable,GetExportCount,GetPropertyId,GetWasmFunction,GetGlobalValue,GetScriptContext,GetOrAddPropertyRecord,Assert,GetTable,GetMemory,GetExport,GetGlobal,GetLibrary],Lo... | LoadImports - Loads all imports of a module. private static int counter = 0 ;. | I wonder if we should get rid of the `GetFunctionSignature` method all together and use `GetWasmFunctionInfo(counter)->GetSignature()`. Having these two methods seems like we are asking for trouble. Or maybe rename to something like `GetSignatureByIndex` and `GetSignatureByFunctionIndex`. What do you think? |
@@ -59,11 +59,8 @@ char *StringFormat(const char *fmt, ...)
return res;
}
-unsigned int StringHash(const char *str, unsigned int seed, unsigned int max)
+unsigned int StringHash(const char *str, unsigned int seed)
{
- CF_ASSERT(ISPOW2(max),
- "StringHash() called with non power-of-2 max: %u", m... | [No CFG could be retrieved] | Creates a string representation of a single unique integer in the form of a format string and returns function StringHash_untyped - string hash function. | Shouldn't this assert still be somewhere, since you are still using binary and instead of division ? |
@@ -903,7 +903,8 @@ class ConvertToInt8Pass(object):
place(fluid.CPUPlace|fluid.CUDAPlace): place is used to restore the
8bits weight tensors.
quantizable_op_type(list[str]): List the type of ops that will be quantized.
- Default is ["conv2d", "depthwise_conv2d", "mul"].
+ ... | [ScaleForTrainingPass->[apply->[_init_var_node]],AddQuantDequantPass->[_inser_quant_dequant_moving_average_abs_max_op->[_init_var_node]],ConvertToInt8Pass->[apply->[_remove_unused_var_nodes],_convert_to_int8->[_load_var]],QuantizationTransformPass->[_insert_quant_range_abs_max_op->[_init_var_node],apply->[_transform_ba... | Initializes the object with the given parameters. | `_supported_quantizable_op_type = QuantizationTransformPass._supported_quantizable_op_type` |
@@ -81,8 +81,10 @@ class Internal::UsersController < Internal::ApplicationController
def toggle_trust_user
if user_params[:trusted_user] == "1"
@user.add_role :trusted
+ @user.trusted
else
@user.remove_role :trusted
+ Rails.cache.delete("user-#{@user.id}/has_trusted_role")
end
... | [inactive_mentorship->[update],deactivate_mentorship->[update],toggle_ban_from_mentorship->[create_note,update]] | toggle_trust_user toggle_warn_user toggle_user_role. | I believe you should also clear/update cache upon trusting a user. If for some reason `#trusted` was called on user in the past 200 hours (ie async controller), the cache would exist and this line would return false despite the role just got added. |
@@ -127,8 +127,14 @@ final class SubresourceOperationFactory implements SubresourceOperationFactoryIn
$operation['operation_name']
);
+ $prefix = trim(trim($rootResourceMetadata->getAttribute('route_prefix', '')), '/');
+ if ('' !== $prefix) {
+ ... | [SubresourceOperationFactory->[computeSubresourceOperations->[computeSubresourceOperations,create]]] | Compute sub - resource operations. Inflector for subresources. Computes a tree of subresource operations. | we don't need the first `trim` imo |
@@ -33,11 +33,12 @@ import (
// transactions from testdata/intake-v2/transactions.ndjson used to trigger tracing
var testTransactionIds = map[string]bool{
- "945254c567a5417e": true,
- "4340a8e0df1906ecbfa9": true,
- "cdef4340a8e0df19": true,
- "00xxxxFFaaaa1234": true,
- "142e61450efb8574": true,
+... | [Equal,MustNewConfigFrom,Do,Contains,Short,Setenv,Unsetenv,GetValue,NoError,Skip,Close,FailNowf,After,Add,FailNow] | TestServerTracingEnabled tests if a given event occurs in a server and if it does Beater is a blocking function that checks if there are any events that can be logged. | I think we can revert this one too? |
@@ -255,6 +255,9 @@ export class AmpStory extends AMP.BaseElement {
/** @private @const {!Array<!./amp-story-page.AmpStoryPage>} */
this.adPages_ = [];
+ /** @private @const {!Array<!./amp-story-page.AmpStoryPage>} */
+ this.storyPath_ = [];
+
/** @const @private {!AmpStoryVariableService} */
... | [AmpStory->[pauseCallback->[TOGGLE_PAUSED,PAUSED_STATE],buildSystemLayer_->[element],onPausedStateUpdate_->[PLAYING,PAUSED],registerAndPreloadBackgroundAudio_->[upgradeBackgroundAudio,childElement,tagName],constructor->[documentStateFor,timerFor,forElement,getStoreService,registerServiceBuilder,platformFor,TOGGLE_RTL,i... | Private methods for the class which instantiates a new object of the given type. private private void methods_ Private properties for the Negotiation of the Negotiation Service. Register the localization service builder in the Windows Registry. | Nit: maybe `storyNavigationPath`? In this ever growing file, it's useful to give as much context as possible... |
@@ -103,7 +103,7 @@ class UserDecorator # rubocop:disable Metrics/ClassLength
}
url = user.provisioning_uri(nil, options)
qrcode = RQRCode::QRCode.new(url)
- qrcode.as_png(size: 280).to_data_url
+ qrcode.as_png(size: 240).to_data_url
end
def locked_out?
| [UserDecorator->[delete_account_bullet_key->[identity_verified?],verified_account_partial->[identity_verified?],email->[email]]] | Returns a QR code for the user if it exists. | this decreases the padding in the image around the actual QR code, doesn't change the barcode size itself |
@@ -251,8 +251,9 @@ class DepsCppInfo(_BaseDepsCppInfo):
def __getitem__(self, item):
return self._dependencies[item]
- def update(self, dep_cpp_info, pkg_name):
- assert isinstance(dep_cpp_info, CppInfo)
+ def update(self, cpp_info, pkg_name):
+ assert isinstance(cpp_info, CppInfo)
... | [DepsCppInfo->[__getattr__->[_get_cpp_info->[],_BaseDepsCppInfo]],_CppInfo->[lib_paths->[_filter_paths],framework_paths->[_filter_paths],include_paths->[_filter_paths],bin_paths->[_filter_paths],res_paths->[_filter_paths],build_paths->[_filter_paths],src_paths->[_filter_paths]],_BaseDepsCppInfo->[update->[merge_lists]]... | Get a dependency by name. | This is still running thousands of times for a medium size graph. I would try to define the DepCppInfo() object just once for each conanfile. It can be defined before calling this ``update()`` method, maybe in the ``_propagate_info()`` one, as a conanfile private object (initially None) |
@@ -66,13 +66,16 @@ void EpsilonKBasedWallConditionData::CalculateConstants(
KRATOS_TRY
mEpsilonSigma = rCurrentProcessInfo[TURBULENT_ENERGY_DISSIPATION_RATE_SIGMA];
- mKappa = rCurrentProcessInfo[WALL_VON_KARMAN];
mCmu25 = std::pow(rCurrentProcessInfo[TURBULENCE_RANS_C_MU], 0.25);
KRATOS_ERR... | [No CFG could be retrieved] | Replies the constant of the k - based condition. Checks if a condition is not set at the current location. | Shouldn't this be obtained from the parent element? |
@@ -75,7 +75,7 @@ namespace System.Runtime.CompilerServices
internal QCallAssembly(ref System.Reflection.RuntimeAssembly assembly)
{
_ptr = Unsafe.AsPointer(ref assembly);
- _assembly = assembly.GetUnderlyingNativeHandle();
+ _assembly = assembly?.GetUnderlyingNative... | [QCallModule->[GetUnderlyingNativeHandle,AsPointer],ObjectHandleOnStack->[],StackCrawlMarkHandle->[AsPointer],StringHandleOnStack->[AsPointer],QCallTypeHandle->[GetUnderlyingNativeHandle,Value,Zero,AsPointer],QCallAssembly->[GetUnderlyingNativeHandle,AsPointer]] | Wraps a reference to the module and the module builder into a handle. | Could you please update `QCallTypeHandle` constructor in this file to follow the same style? |
@@ -268,6 +268,13 @@ func startServer() *apiserver.Server {
version.DockerDefaultVersion,
version.DockerMinimumVersion)
api.UseMiddleware(mw)
+
+ if vchConfig.HostCertificate.IsNil() && vchConfig.Diagnostics.DebugLevel <= 2 {
+ // only enforce host header check in non-debug http-only mode
+ log.Warnf("Docker ... | [Trap,NewCheckpointBackend,InitLogger,ClientIP,NewImageBackend,Certificate,NewLoggingConfig,Close,NewVolumeBackend,Subjects,Info,Exit,Routes,NewPortlayerEventMonitor,Stop,UseMiddleware,NewRouter,Init,New,NewNetworkBackend,Start,IsNil,NewSystemBackend,InitRouter,Wait,Bool,Debugf,NewContainerBackend,PrintDefaults,Accept,... | setAPIRoutes creates a new API server for the given container. createClusterComponent creates a cluster component router. | This warning seems applicable regardless of debug level. |
@@ -261,7 +261,7 @@ static int ossl_encoder_ctx_setup_for_pkey(OSSL_ENCODER_CTX *ctx,
}
}
- if (OSSL_ENCODER_CTX_get_num_encoders(ctx) != 0) {
+ if (data != NULL && OSSL_ENCODER_CTX_get_num_encoders(ctx) != 0) {
if (!OSSL_ENCODER_CTX_set_construct(ctx, encoder_construct_pkey)
... | [No CFG could be retrieved] | Select the first encoder implementation that matches the keymgmt implementation. Create an OSSL encoder for a given EVP_PKEY. | I suppose this cannot happen as OSSL_ENCODER_CTX_get_num_encoders() would return 0 here in that case. But anyway... |
@@ -153,6 +153,7 @@ class ClientCache(object):
# TODO: cache2.0 this will be removed in the future is just to adapt to some tests
# that call this directly
def package_layout(self, ref, short_paths=None):
+ raise Exception("buuuuuuuhhhhh")
assert isinstance(ref, ConanFileReference), "It ... | [ClientCache->[get_remote->[get_remote],get_build_id->[get_build_id],reset_default_profile->[initialize_default_profile],get_template->[get_template],assign_rrev->[assign_rrev],get_package_ids->[get_package_ids],get_timestamp->[get_timestamp],closedb->[closedb],get_recipe_revisions->[get_recipe_revisions],assign_prev->... | Package layout for a given file reference. | Buuuuuhhhhhh!!! If this is no longer used, just remove the method. |
@@ -33,6 +33,8 @@ import org.infinispan.factories.scopes.Scopes;
import org.infinispan.marshall.core.ClassToExternalizerMap.IdToExternalizerMap;
import org.infinispan.util.logging.Log;
import org.infinispan.util.logging.LogFactory;
+import org.jboss.marshalling.ObjectTable;
+import org.jboss.marshalling.Unmarshaller... | [GlobalMarshaller->[readWithExternalizer->[getExternalizer],getBufferSizePredictor->[getBufferSizePredictor],stopDefaultExternalMarshaller->[stop],readArray->[readNullableObject,getExternalizer],writeObjectOutput->[writeObjectOutput],objectFromByteBuffer->[objectFromObjectInput],startDefaultExternalMarshaller->[start],... | Imports a single object from the System. Array encoding functions. | This is not right the right way. GlobalMarshaller is independent from underlying marshalling library. It should not be depending on JBoss Marshalling itself. Any JBoss Marshalling code should be limited to ExternalJBossMarshaller. |
@@ -11,6 +11,8 @@ import javax.validation.constraints.NotNull;
* @author Misagh Moayyed
* @since 4.2
*/
+@Entity
+@DiscriminatorValue("PT")
public class ProxyTicketImpl extends ServiceTicketImpl implements ProxyTicket {
private static final long serialVersionUID = -4469960563289285371L;
| [No CFG could be retrieved] | Package private for testing purposes. | Could we use `ProxyTicket.PREFIX` instead? |
@@ -7648,6 +7648,18 @@ void pacman_state::init_pengomc1()
romdata[i] = buf[i^0xff];
}
+uint8_t pacman_state::clubpacm_input_r(offs_t offset)
+{
+ uint8_t data = ioport((offset & 0x40) ? "IN1" : "IN0")->read();
+
+ if (!m_mainlatch->q5_r())
+ data &= ioport("P1")->read();
+ if (!m_mainlatch->q4_r())
+ data &= io... | [No CFG could be retrieved] | region Game drivers init Find all the possible names of the GAMEs that are not empty. | It's not acceptable to continue adding runtime tag map lookups like this. Use a `required_ioport_array` instead. |
@@ -423,8 +423,15 @@ public class PySparkInterpreter extends Interpreter implements ExecuteResultHand
}
synchronized (statementFinishedNotifier) {
- while (statementOutput == null) {
+ long startTime = System.currentTimeMillis();
+ while (statementOutput == null
+ && pythonScriptInitia... | [PySparkInterpreter->[getProgress->[getProgress],completion->[PythonInterpretRequest],getSQLContext->[getSQLContext,getSparkInterpreter],getJavaSparkContext->[getSparkInterpreter],createGatewayServerAndStartScript->[createPythonScript],getZeppelinContext->[getZeppelinContext,getSparkInterpreter],getSparkConf->[getJavaS... | completion method. | Shall we replace hard-coded constant value here with `MAX_TIMEOUT_SEC` ? Also, to get pretty stacktrace in case of this error - it's better to `logger.error("...", e);` |
@@ -470,7 +470,7 @@ static int ssl_servername_cb(SSL *s, int *ad, void *arg)
BIO_printf(p->biodebug, "Hostname in TLS extension: \"");
while ((uc = *cp++) != 0)
BIO_printf(p->biodebug,
- isascii(uc) && isprint(uc) ? "%c" : "\\x%02x", uc);
+ (((u... | [No CFG could be retrieved] | Reads an SSL context from the BIO and returns the index of the next read context. Get an OCSP response from a responder or a certificate. | I would not mind removing isascii completely in this case, since uc is unsigned char. When I brought up the issue with isxxx I was making a point about an implementation where isprint is a macro which is assuming the argument is in the range -1 .. 255, thus -1 being EOF. and that breaks when using signed char as index. |
@@ -42,7 +42,8 @@ export let AmpAdExitConfig;
* finalUrl: string,
* trackingUrls: (!Array<string>|undefined),
* vars: (VariablesDef|undefined),
- * filters: (!Array<string>|undefined)
+ * filters: (!Array<string>|undefined),
+ * behaviors: (BehaviorsDef|undefined)
* }}
*/
export let NavigationTar... | [No CFG could be retrieved] | Exports an object that exports an AmpAdExitConfig or AmpAdExitConfigOptions Create a new export. | based on the code, I think this type should be BehaviorDef and BehaviorsDef shouldn't exist. Otherwise you'd access it as target.behaviors["???"].clickTarget |
@@ -0,0 +1,11 @@
+class CreateUserBlocks < ActiveRecord::Migration[5.2]
+ def change
+ create_table :user_blocks do |t|
+ t.bigint :blocked_id, null: false
+ t.bigint :blocker_id, null: false
+ t.string :config, null: false, default: "default"
+
+ t.timestamps null: false
+ end
+ end
+end
| [No CFG could be retrieved] | No Summary Found. | these should probably be both foreign keys to the user table |
@@ -0,0 +1,6 @@
+# ------------------------------------
+# Copyright (c) Microsoft Corporation.
+# Licensed under the MIT License.
+# ------------------------------------
+
+VERSION = "4.0.0b1"
| [No CFG could be retrieved] | No Summary Found. | @johanste first release, but should this be b3? |
@@ -128,6 +128,11 @@ def main() -> None:
f"--coverage-py-extra-requirements={repr(CoverageSubsystem.default_extra_requirements)}",
f"--coverage-py-interpreter-constraints={repr(CoverageSubsystem.default_interpreter_constraints)}",
f"--coverage-py-lockfile={CoverageSubsystem.defaul... | [main->[info,repr,run],getLogger,main] | Generate all the required lockfiles for the user. Add missing flags to the default lockfile. Add missing flags to the default configuration. No - op if no coverage is available. | Needs to also set the --interpreter-constraints option. See black or isort in this file for an example. |
@@ -114,14 +114,14 @@ class AgendaEvents extends DolibarrApi
// If the internal user must only see his customers, force searching by him
$search_sale = 0;
- if (! DolibarrApiAccess::$user->rights->societe->client->voir && !$socid) $search_sale = DolibarrApiAccess::$user->id;
+ if (! em... | [AgendaEvents->[post->[create,_validate],index->[plimit,fetch,query,num_rows,_cleanObjectDatas,fetch_object,lasterror,order],get->[fetch,fetch_optionals,fetchObjectLinked,_cleanObjectDatas],delete->[fetch,delete]]] | This function returns an array of events in the database. Get Agenda Event list. | This change breaks the security. What value of $search_sale do you have when you make your search ? |
@@ -111,4 +111,17 @@ module ApplicationHelper
end
end
end
+
+ def whom(entity_name)
+ if I18n.locale == :ca
+ if /\A[aeiou]/i =~ entity_name
+ " l'#{entity_name}"
+ else
+ # TODO: define a setting with the genre of the entity
+ "la #{entity_name}"
+ end
+ else
+... | [body_css_classes->[join,push],localized_enum->[pluralize,i18n_key,merge!,reduce,t,respond_to?,capitalize],render_if_exists->[render,exists?,new,basename,dirname],translate_enum_value->[pluralize,t,i18n_key],privacy_policy_page_link->[privacy_page?,privacy_page,link_to,gobierto_cms_page_or_news_path,t],filetype_icon->[... | Returns a hidden indication of the given attribute. | Use match? instead of =~ when MatchData is not used. |
@@ -801,6 +801,13 @@ public abstract class SingleThreadEventExecutor extends AbstractScheduledEventEx
});
}
+ /**
+ * An interface that is called with a long argument.
+ */
+ protected interface LongConsumer {
+ void consume(long aLong);
+ }
+
private static final class Defa... | [SingleThreadEventExecutor->[confirmShutdown->[runShutdownHooks,isShuttingDown,inEventLoop,runAllTasks,wakeup,isShutdown],delayNanos->[delayNanos],doStartThread->[run->[confirmShutdown,cleanup,updateLastExecutionTime,run],execute],runShutdownHooks->[run],shutdown->[inEventLoop,wakeup],DefaultThreadProperties->[isInterr... | This method is called by the event executor when it is starting. | make a top level interface in `io.netty.util` to increase visibility (easier to find/replace later) |
@@ -195,6 +195,9 @@ def create_user_profile(sender, instance, created, **kwargs):
@receiver(user_signed_up)
def on_user_signed_up(sender, request, user, **kwargs):
+ context={'request': request}
+ msg = _('You have completed the first step of <a href="%s">getting started with MDN</a>') % wiki_url(context, 'MD... | [UserBan->[save->[save]],UserProfile->[get_absolute_url->[get_absolute_url]]] | Send welcome email if user has already verified at least one email address. | Should we add a space around the operator for PEP8? |
@@ -48,7 +48,9 @@ public class CompressionUtils
{
private static final Logger log = new Logger(CompressionUtils.class);
private static final int DEFAULT_RETRY_COUNT = 3;
+ private static final String BZ2_SUFFIX = ".bz2";
private static final String GZ_SUFFIX = ".gz";
+ private static final String XZ_SUFFIX ... | [CompressionUtils->[gunzip->[openStream->[openStream,gzipInputStream],gzipInputStream,gunzip],gzip->[openStream->[openStream],gzip],unzip->[unzip],gzipInputStream->[available->[available]],getGzBaseName->[isGz],zip->[zip]]] | This class will zip the contents of a directory into a file. Zip the given directory into the given outputZipFile. | These constants wouldn't happen to be in the apache libs anywhere would they? |
@@ -595,7 +595,13 @@ module Repository
if found==true
ga_repo.reload!
ga_repo.config.rm_repo(repo)
+
+ # Readd the 'git' public key to the gitolite admin repo after changes
+ self.class.readd_admin_key
+
+ # update Gitolite repo
ga_repo.... | [GitRevision->[initialize->[get_repos]],GitRepository->[delete_bulk_permissions->[add_user],expand_path->[expand_path],remove_user->[add_user],add_file->[path_exists_for_latest_revision?],latest_revision_number->[get_revision_number],remove_file->[commit_options,create],create->[commit_options,create],access->[open],ma... | Delete permissions over several repositories. Use remove_user to remove permissions over multiple repositories. Use. | Line is too long. [81/80] |
@@ -1332,10 +1332,10 @@ class ProNonCombatMoveAi {
// Get all transport final territories
ProMoveUtils.calculateAmphibRoutes(player, new ArrayList<>(), new ArrayList<>(), new ArrayList<>(), moveMap,
false);
- for (final Territory t : moveMap.keySet()) {
- for (final Unit u : moveMap... | [ProNonCombatMoveAi->[findInfraUnitsThatCanMove->[hasNext,remove,get,trace,iterator,test,put,info,getUnitMoveMap,next],doNonCombatMove->[getLandOptions,getClosestEnemyLandTerritoryDistance,territoryHasLocalLandSuperiorityAfterMoves,test,warn,populateEnemyAttackOptions,info,findTerritoryValues,findInfraUnitsThatCanMove,... | Move units to best territories. Find best land territory and transport territory that can be moved to the highest value. Find the best possible unload from the transport and add the new amphib units to This method checks if the transport can move land units and is allied. | Here it would make sense to iterate over `values()` + this value should be mapped to ProTerritory#getTransportTerritoryMap, which should then iterate over its `keySet()` as well. |
@@ -17,12 +17,13 @@ def create_unique_slug_for_warehouses(apps, schema_editor):
first_char = warehouse.name[0].lower()
if first_char != previous_char:
previous_char = first_char
- slug_values = Warehouse.objects.filter(
+ slug_values = list(Warehouse.objects.filter(
... | [generate_unique_slug->[slugify],create_unique_slug_for_warehouses->[append,get_model,filter,generate_unique_slug,name],Migration->[AddField,RunPython,SlugField,AlterField]] | Create a unique slug for Warehouse objects. | what if some warehouse has same first letter name ?? (same for ProductType and collection) |
@@ -61,7 +61,7 @@ public class MqttMessage {
}
public Object payload() {
- return payload;
+ return null;
}
public DecoderResult decoderResult() {
| [MqttMessage->[toString->[toString]]] | payload - > decoderResult. | remove the method ? |
@@ -95,7 +95,10 @@ class MultipleVhostsTest(util.ApacheTest):
def test_prepare_locked(self):
server_root = self.config.conf("server-root")
self.config.config_test = mock.Mock()
- os.remove(os.path.join(server_root, ".certbot.lock"))
+ try:
+ os.remove(os.path.join(server_... | [MultipleVhostsTest->[test_deploy_cert->[mock_add_dummy_ssl->[find_args]]],InstallSslOptionsConfTest->[test_current_file->[_call,_assert_current_file],_assert_current_file->[_current_ssl_options_hash],test_manually_modified_current_file_does_not_update->[_call,_current_ssl_options_hash],test_current_file_hash_in_all_ha... | Test prepare locked. | Why do we need to make this change? My understanding here is we're deleting the lockfile because it's already acquired and we want another process to acquire it so we can try to do so ourselves again. If that's the case, rather than just ignoring exceptions here, can we flip the logic and test acquiring it in another p... |
@@ -1406,7 +1406,7 @@ function esc_sql_ident( $idents ) {
* @return bool Whether the provided string is a valid JSON representation.
*/
function is_json( $argument, $ignore_scalars = true ) {
- if ( empty( $argument ) || ! is_string( $argument ) ) {
+ if ( ! is_string( $argument ) || '' === $argument ) {
retur... | [iterator_map->[add_transform],http_request->[getType,getMessage,getData],mustache_render->[render],format_items->[display_items]] | Checks if the argument is a JSON string. | Removing the extra space after the equals will satisfy the wpcs sniff, so `'' === $argument` goes to `'' === $argument` (hard to see on github!). |
@@ -145,8 +145,11 @@ class QAT_Quantizer(Quantizer):
state where activation quantization ranges do not exclude a significant fraction of values, default value is 0
- op_types : list of string
types of nn.module you want to apply quantization, eg. 'Conv2d'
+ ... | [DoReFaQuantizer->[quantize_weight->[get_bits_length],export_model->[_del_simulated_attr]],QAT_Quantizer->[quantize_weight->[get_bits_length,_dequantize,update_ema,_quantize,update_quantization_param],export_model->[_del_simulated_attr],quantize_output->[get_bits_length,_dequantize,update_ema,_quantize,update_quantizat... | Initialize the quantization layer. Missing max activation. | I think we also need to explain the graph is used to find bn after Conv. If user doesn't provide `dummy_input`, the quantizer will not fold bn. |
@@ -31,7 +31,7 @@ const {isTravisBuild} = require('../common/travis');
function writeIfUpdated(patchedName, file) {
if (!fs.existsSync(patchedName) || fs.readFileSync(patchedName) != file) {
fs.writeFileSync(patchedName, file);
- if (!isTravisBuild()) {
+ if (!isCiBuild()) {
log(colors.green('Patc... | [No CFG could be retrieved] | Writes the given contents to the given file if it s not already present. Fixes the bug in AMP - 7687. | General thought after reviewing this PR: a lot of cases where we do these checks are just to determine whether or not to log something. Having a `log` and `ciLog` (or standardizing log levels) could simplify some of the code throughout |
@@ -65,13 +65,16 @@ public class ReconContainerManager extends SCMContainerManager {
public ReconContainerManager(
ConfigurationSource conf,
Table<ContainerID, ContainerInfo> containerStore,
- BatchOperationHandler batchHandler,
+ DBStore batchHandler,
PipelineManager pipelineManager,
... | [ReconContainerManager->[updateContainerReplica->[updateContainerReplica]]] | Creates a new container manager. Check if the container is open. | Is there any reason why we cannot maintain the ScmDB and replica history map only in this class and move the related methods (getContainerHistory, upsertContainerHistory, flushDb) from the ContainerSchemaManager to this class? The ContainerEndpoint class already has an instance of the Recon container manager. After thi... |
@@ -4839,6 +4839,11 @@ public class VmwareResource implements StoragePoolResource, ServerResource, Vmwa
String path = cmd.getVolumePath();
VmwareHypervisorHost hyperHost = getHyperHost(getServiceContext());
+ VmwareHypervisorHost hyperHostInTargetCluster = null;
+ if (cmd.getHostGuidIn... | [VmwareResource->[getNetworkStats->[networkUsage],ensureDiskControllersInternal->[ensureDiskControllers,ensureScsiDiskControllers],getUnmanageInstanceNics->[compare->[extractInt],getName],connect->[connect],configure->[configure],resizeRootDiskOnVMStart->[appendFileType],canSetEnableSetupConfig->[setBootOptions],execut... | This method is called when a new volume is migrated. find the VM in the datastore and attach it to the VM in the VM machine. find vm on the hyper host and if it exists create a new vm on the hyper host after volume migration. | this merrits a call to a specific method |
@@ -2248,9 +2248,8 @@ DataReaderImpl::instances_liveliness_update(WriterInfo& info,
const ACE_Time_Value& when)
{
ACE_GUARD(ACE_Recursive_Thread_Mutex, instance_guard, this->instances_lock_);
- for (SubscriptionInstanceMapType::iterator iter = instances_.begin(),
- next = iter; iter != instances_.end(); ... | [No CFG could be retrieved] | This is a private method that is called by DDS to update the liveliness region DataReader Implementation. | I made this change but I should've have asked why it has the `next` iterator, because it looks redundant to me. |
@@ -78,7 +78,12 @@ class CategoryList
if SiteSetting.fixed_category_positions
@categories = @categories.order(:position, :id)
else
- @categories = @categories.includes(:latest_post).order("posts.created_at DESC NULLS LAST").order('categories.id ASC')
+ allowed_category_ids = @categories.pluck... | [CategoryList->[preload_key->[freeze],prune_empty->[uncategorized?,blank?,delete_if,allow_uncategorized_topics],trim_results->[each,displayable_topics,blank?,num_featured_topics],prune_muted->[notification_level,delete_if,notification_levels],sort_unpinned->[empty?,size,present?,unpinned?,current_user,num_featured_topi... | find_categories - Find all categories in the system that have a specific key. check for a missing node in the category tree. | This line is a bit odd to me. It's taking the array of `id`s and then adding a value for `nil`? Why is that necessary? |
@@ -64,11 +64,10 @@ public class TimeseriesQuery extends BaseQuery<Result<TimeseriesResultValue>>
@JsonProperty("context") Map<String, Object> context
)
{
- super(dataSource, querySegmentSpec, descending, context);
+ super(dataSource, querySegmentSpec, descending, context, granularity);
this.v... | [TimeseriesQuery->[hashCode->[hashCode],equals->[equals]]] | This class is used to create a TimeseriesQuery for a list of DataFrames. Returns a sequence of all the columns that are not in the query. | How do timeseries queries behave with `null` granularity? |
@@ -401,6 +401,11 @@ class NettingChannelMock(object):
for filter_ in BlockChainServiceMock.filters[self.address]:
filter_.event(event)
+ def transferredAmount(self, participant_address):
+ # TODO: Make this work if we don't drop support for the mock client
+ raise RuntimeError(... | [RegistryMock->[add_asset->[ethereum_event,AssetMock,event],assetadded_filter->[FilterMock]],ChannelManagerMock->[channelnew_filter->[FilterMock],new_netting_channel->[ethereum_event,asset_address,event]],NettingChannelMock->[unlock->[block_number,ethereum_event,unlock,event],channelsecretrevealed_filter->[FilterMock],... | Deposit a block from a participant to another address. | please, use python's coding standard `transferred_amount` |
@@ -312,13 +312,11 @@ class SimpleCodegenTask(Task):
:param sources: A FilesetWithSpec to inject for the target.
"""
target = vt.target
-
# NB: For stability, the injected target exposes the stable-symlinked `vt.results_dir`,
# rather than the hash-named `vt.current_results_dir`.
synthetic... | [SimpleCodegenTask->[execute->[codegen_targets,get_fingerprint_strategy,_validate_sources_globs,_do_validate_sources_present],_inject_synthetic_target->[synthetic_target_dir,synthetic_target_extra_dependencies,synthetic_target_type,_get_synthetic_address,synthetic_target_extra_exports],_capture_sources->[synthetic_targ... | Create a synthetic target and return a synthetic target. This method is called by the build - graph. It will walk the transitive dependee. | nit: Are these changes actually necessary? |
@@ -118,10 +118,12 @@ class BasePlugin:
"""
return NotImplemented
+ # TODO: Add information about this change to `breaking changes in changelog`
def calculate_checkout_line_total(
self,
checkout_line: "CheckoutLine",
discounts: List["DiscountInfo"],
+ channe... | [BasePlugin->[save_plugin_configuration->[validate_plugin_configuration,_update_config_items],get_plugin_configuration->[_update_configuration_structure,_append_config_structure]]] | Calculate the shipping costs for the order. | What do you thing to pass here `channel_id` instead of channel object? |
@@ -48,14 +48,14 @@ public class CompressedVSizeIndexedV3Writer extends MultiValueIndexedIntsWriter
return new CompressedVSizeIndexedV3Writer(
new CompressedIntsIndexedWriter(
ioPeon,
- String.format("%s.offsets", filenameBase),
+ StringUtils.safeFormat("%s.offsets", fil... | [CompressedVSizeIndexedV3Writer->[writeToChannel->[writeToChannel],create->[CompressedVSizeIndexedV3Writer],getSerializedSize->[getSerializedSize],close->[close],open->[open]]] | Create a new CompressedVSizeIndexedV3Writer with the given parameters. | Probably should crash if bad format string |
@@ -1393,8 +1393,8 @@ obj_local_rw(crt_rpc_t *rpc, struct obj_io_context *ioc,
rc = vos_fetch_begin(ioc->ioc_coc->sc_hdl, orw->orw_oid,
orw->orw_epoch,
- cond_flags, dkey, orw->orw_nr, iods,
- fetch_flags, shadows, &ioh, dth);
+ dkey, orw->orw_nr, iods,
+ cond_flags | fetc... | [No CFG could be retrieved] | Get the next object from the list of objects region DCP DCP DCP DCP DCP DCP DCP DCP D EC_DEGRADED - EC_DEGRADED. | (style) line over 80 characters |
@@ -4,3 +4,11 @@ def clean_seo_fields(data):
if seo_fields:
data['seo_title'] = seo_fields.get('title')
data['seo_description'] = seo_fields.get('description')
+
+
+def snake_to_camel_case(name):
+ """Convert snake_case variable name to camelCase."""
+ if isinstance(name, str):
+ spl... | [clean_seo_fields->[get,pop]] | Extract and assign seo fields to given dictionary. | "Split" is an irregular verb and its past participle is also "split". |
@@ -0,0 +1,13 @@
+class AbTest
+ def initialize(key, percent_on)
+ @key = key
+ @percent_on = percent_on.to_s.to_i
+ end
+
+ def enabled?(session, reset)
+ return false if @percent_on.zero?
+ return true if @percent_on == 100
+ return session[@key] if !reset && session.key?(@key)
+ session[@key] = ... | [No CFG could be retrieved] | No Summary Found. | Is it possible to separate checking whether the feature is enabled and enabling the feature? Changing the state as a side effect of seeing if its enabled it seems unexpected to me (unless I'm measuring its quantum state...) Also, this looks like the only case where `FeatureManagement` is looking to any logic besides en... |
@@ -35,7 +35,7 @@ import java.util.Locale;
public class NotebookImportDeserializer implements JsonDeserializer<Date> {
private static final String[] DATE_FORMATS = new String[] {
"yyyy-MM-dd'T'HH:mm:ssZ",
- "MMM dd, yyyy HH:mm:ss"
+ "MMM d, yyyy h:mm:ss a"
};
@Override
| [NotebookImportDeserializer->[deserialize->[parse,JsonParseException,getAsString,toString]]] | Deserialize a date. | Thanks for the contribution. Because of deserialize() tries all formats in `DATE_FORMATS` sequentially, i think we can keep both formats. "MMM d, yyyy h:mm:ss a" and then "MMM dd, yyyy HH:mm:ss". |
@@ -52,7 +52,7 @@ class AlertRule extends BaseModel
{
return $query->enabled()
->join('alerts', 'alerts.rule_id', 'alert_rules.id')
- ->where('alerts.state', 1);
+ ->whereIn('alerts.state', [1, 3, 4]);
}
/**
| [AlertRule->[scopeEnabled->[where],devices->[belongsToMany],scopeIsActive->[where],scopeHasAccess->[isJoined,join,hasDeviceAccess,hasGlobalRead],alerts->[hasMany]]] | Scope is active alert query. | I noticed you use whereNotIn in the legacy index and whereIn here. Not an issue just an inconsistency. |
@@ -324,7 +324,7 @@ describe UserProfile::AboutMeController do
it 'updates the user about_me' do
# By whitelisting we're giving them the benefit of the doubt
- put :update, :user => { :about_me => '[HD] Watch Jason Bourne Online free MOVIE Full-HD' }
+ put :update, params: { :user => { :... | [reset,create,and_return,let,describe,spam_score_threshold,first,it,put,to,create_profile_photo!,show_user_path,before,require,score_mappings,dirname,match,id,load_file_fixture,redirect_to,context,url_name,get,eq,after,render_template,site_name,expand_path] | it redirects to the user page User data structure. | Line is too long. [110/80] |
@@ -75,7 +75,12 @@ class GoProtobufGen(SimpleCodegenTask):
outdir = os.path.join(target_workdir, 'src', 'go')
safe_mkdir(outdir)
- target_cmd.append('--go_out={}'.format(outdir))
+ protoc_plugins = self.get_options().protoc_plugins + list(target.protoc_plugins)
+ if protoc_plugins:
+ go_out = ... | [GoProtobufGen->[execute_codegen->[is_gentarget]]] | Execute codegen on a target. | Is making this additive consistent with what we do elsewhere, say for `javac_plugins`? I don't actually know, but I think that in some cases (compiler_options_sets), the target value is a replacement. No preference either way. |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.