patch stringlengths 18 160k | callgraph stringlengths 4 179k | summary stringlengths 4 947 | msg stringlengths 6 3.42k |
|---|---|---|---|
@@ -1225,12 +1225,14 @@ static int mac_test_run_mac(EVP_TEST *t)
goto err;
}
tmpval = strchr(tmpkey, ':');
- if (tmpval != NULL)
+ if (tmpval != NULL) {
*tmpval++ = '\0';
- if (!OSSL_PARAM_allocate_from_text(¶ms[params_n], defined_params,
- ... | [No CFG could be retrieved] | Construct the OSSL - encoded MAC parameters from the given object. region MAC Implementation. | There is something very funky about the indenting here - where is the matching } for this one?? |
@@ -185,7 +185,7 @@ public class JsonObjectDecoderTest {
EmbeddedChannel ch = new EmbeddedChannel(new JsonObjectDecoder());
// {"foo" : "bar\""}
String json = "{\"foo\" : \"bar\\\"\"}";
- System.out.println(json);
+
ch.writeInbound(Unpooled.copiedBuffer(json, CharsetUt... | [JsonObjectDecoderTest->[testSpecialJsonCharsInString->[EmbeddedChannel,JsonObjectDecoder,assertFalse,copiedBuffer,release,toString,readInbound,finish,writeInbound,assertEquals],testJsonObjectOverMultipleWrites->[EmbeddedChannel,JsonObjectDecoder,assertFalse,copiedBuffer,release,toString,readInbound,finish,writeInbound... | This test fails if there is a broken broken JSON object in the chain. | Remove trailing whitespaces. |
@@ -408,7 +408,7 @@ func orgAssignment(args ...bool) macaron.Handler {
}
func mustEnableIssues(ctx *context.APIContext) {
- if !ctx.Repo.CanRead(models.UnitTypeIssues) {
+ if !setting.Service.EnableIssues || !ctx.Repo.CanRead(models.UnitTypeIssues) {
if log.IsTrace() {
if ctx.IsSigned {
log.Trace("Permi... | [RequireCSRF,IsOrganizationOwner,APIContexter,Patch,Before,IsErrOrgNotExist,Delete,RepoRef,CORS,GetRepositoryByName,CanEnablePulls,IsUserRepoWriter,Set,CheckForOTP,IsErrRepoNotExist,Put,IsTeamMember,IsErrRepoRedirectNotExist,Error,IsUserRepoOwner,GetTeamByID,NotFound,Post,GetUserRepoPermission,CanRead,JSON,Trace,IsOrga... | orgAssignment returns a middleware that assigns an organization to an organization or a team to a user mustAllowPulls checks if the user has permission to read the unit type pull requests or. | You can check that on `CanRead` or more deep function but not here. |
@@ -186,8 +186,8 @@ public final class Http2StreamChannelBootstrap {
return;
}
- ChannelFuture future = streamChannel.register();
- future.addListener((ChannelFutureListener) future1 -> {
+ Future<Void> future = streamChannel.register();
+ future.addListener(future1 -... | [Http2StreamChannelBootstrap->[open0->[handler],open->[open]]] | open0 - open new outbound stream. | maybe thats also a place to use `future.addListener(streamChannel, future1 -> {` |
@@ -34,6 +34,9 @@ def _fetch(
config.NoRemoteError: thrown when downloading only local files and no
remote is configured
"""
+
+ used_run_cache = self.stage_cache.pull(remote) if run_cache else []
+
used = self.used_cache(
targets,
all_branches=all_branches,
| [_fetch_external->[_git_to_cache,exception,append,update,pull,isinstance,find_out_by_relpath,NamedCache,format,join,get_used_cache,external_repo],_fetch->[DownloadError,_fetch_external,pull,used_cache,items],_git_to_cache->[PathInfo,debug,save_info,exception,get,len,changed_cache,set,format,join,add,save],getLogger] | Download data items from a cloud and a repository. | Shame NamedCache relies on checksums so heavily(or rather push/pull itself), otherwise we could've fed stage_cache to it directly. But for now, this works fine. |
@@ -45,7 +45,11 @@ class WorldFOIWebsites
{:name => "Acceso Intelligente",
:country_name => "Chile",
:country_iso_code => "CL",
- :url => "http://accesointeligente.org"}]
+ ... | [WorldFOIWebsites->[by_code->[find,downcase]]] | A list of all world FoI websites that are available on the website. if no such object exists return nil. | It's picky but the trailing comma is superfluous AFAICT. |
@@ -82,10 +82,8 @@ class GroupsControllerCsvUploadTest < AuthenticatedControllerTest
end
should 'be named after student usernames only' do
- expected_list = %w(c6scriab c5anthei c5cagejo c5charpe)
- assert_equal(Dir.chdir(@repository_storage), 0)
- assert_equal(expected_li... | [GroupsControllerCsvUploadTest->[new,cd,post_as,pwd,fixture_file_upload,join,should,map,teardown,assert_equal,repository_name,returns,glob,t,to_s,sort,touch,rm_r,make,id,length,context,assert_response,chdir,mkdir,setup,assert_recognizes],include,dirname,join,require,expand_path] | should be able to upload groups using CSV file upload and repos as a simple example of how to create a new user object. | Line is too long. [90/80]<br>Use `%w` or `%W` for an array of words. |
@@ -475,8 +475,7 @@ class Command(object):
"specify both install-folder and any setting/option "
"it will raise an error.")
parser.add_argument("-j", "--json", nargs='?', const="1", type=str,
- help='Only with --build-order op... | [Command->[export->[export],info->[info],install->[install],source->[source],remove->[remove,info],new->[new],imports->[imports],link->[link],upload->[upload],copy->[copy],download->[download],run->[_commands,_warn_python2,_show_help],export_pkg->[export_pkg],test->[test],inspect->[inspect],package->[package],_show_hel... | Gets information about a specific . This function is called from the command line interface. It will return the information about a specific Builds a single object. | I've intentionally removed the mention to `--json` (without value) will output to console, I think it is something we don't want to promote. Shall I revert it? |
@@ -217,11 +217,14 @@ class RawProgramOptimizer(MetaOptimizerBase):
block = self.main_program.global_block()
ring_id = self.global_ring_id
param_grads = []
+ first_backward_idx = -1
# find all grad params
- for op in reversed(block.ops):
+ for idx, op in enumer... | [RawProgramOptimizer->[_init_process_group->[_get_process_group_info,_broadcast_params],minimize_impl->[_init_process_group]]] | Allreduceusion program for all - reduce. inserts the next n - node in the network if there is no node in the network. | `OP_ROLE_VAR_KEY in op.attr_names`first_op_role_var_idx |
@@ -160,7 +160,7 @@ if ( ! class_exists( 'WPSEO_Pointers' ) ) {
'prev_function' => 'window.location="' . admin_url( 'admin.php?page=wpseo_internal-links' ) . '";',
),
'wpseo_import' => array(
- 'content' => '<h3>' . __( 'Import & Export', 'wordpress-seo' ) . '</h3>'
+ 'content'... | [WPSEO_Pointers->[tracking_request->[print_scripts],intro_tour->[print_scripts]]] | This function will display a tour showing the WordPress SEO settings This function shows the administration page of the plugin s newsletter. This function will display all the post types taxonomies archives special pages and the settings for the site This tab allows you to enable the Facebook Open Graph functionality f... | `&` should be escaped here, so either the translation changes and we use `esc_html__()` or the translation should stay as it was. |
@@ -1010,7 +1010,14 @@ namespace Internal.JitInterface
else
{
var methodContext = (MethodDesc)typeOrMethodContext;
- Debug.Assert((!methodContext.HasInstantiation && !owningMethod.HasInstantiation) ||
+ // Allow cases where the... | [No CFG could be retrieved] | Resolves a token in the scope of a method. returns the type of the token or null if it is not a type. | The first two terms in the assert condition can be simplified to just single `!owningMethod.HasInstantiation` |
@@ -91,6 +91,11 @@ public class SecurityUtils {
String principal;
if (subject.isAuthenticated()) {
principal = extractPrincipal(subject);
+ if (ZeppelinServer.notebook.getConf().isUsernameForceLowerCase()) {
+ log.debug("Converting principal name " + principal
+ + " to lower case:"... | [SecurityUtils->[isAuthenticated->[isAuthenticated],getRoles->[getRealmsList,getPrincipal,getRoles],extractPrincipal->[getPrincipal]]] | Returns the principal of the user. | log.warn()? since this is possibly security related. |
@@ -157,9 +157,13 @@ public class RStudio implements EntryPoint
};
}
+ private static final native void maybeSetWindowName(String name)
+ /*-{
+ $wnd.name = $wnd.name || name;
+ }-*/;
+
private static final native void maybeDelayLoadApplication(RStudio rstudio)
/*-{
-
if... | [RStudio->[ensureStylesInjected->[ensureStylesInjected],delayLoadApplication->[onFailure->[execute],showProgress]]] | show progress command. load a specific node in the system. | It seems like this won't set the window name if it already has one (`"abc" || "123"` evaluates to `"abc"`). Is that intentional? |
@@ -173,7 +173,9 @@ func Select(c rd.Conn, keyspace uint) error {
// CreatePool creates a redis connection pool
func CreatePool(
- host, password, network string,
+ uri string,
+ password string,
+ database int,
maxConn int,
idleTimeout, connTimeout time.Duration,
) *rd.Pool {
| [Dial,Do,Values,DialReadTimeout,DialWriteTimeout,Close,String,DialConnectTimeout,Int64,Scan,Split,Err,Debug] | Select selects the keys in a keyspace to use for a connection. It returns a connection pool. | There are still missing timeout configurations (`DialReadTimeout` and `DialWriteTimeout`), is there a reason for that? Maybe with the idle and the connect timeout is enough... |
@@ -101,12 +101,12 @@ def test_participant_selection(raiden_network, token_addresses):
joinable_funds_target=-1,
)
- # connect the other nodes
+ # Make all nodes connect
connect_greenlets = [
gevent.spawn(
RaidenAPI(app.raiden).token_network_connect, registry_add... | [is_manager_saturated->[is_channel_open_and_funded],test_participant_selection->[is_manager_saturated,wait_for_transaction,saturated_count],saturated_count->[is_manager_saturated]] | Test that the participant selection of a token is valid. This function is called when a token is not reachable from any token network. This function is called when a token is not in the state of a channel. | Since node 0 is already connecting, and only created 1 channel to (0x222...), why doesn't it automatically connect to the new nodes without calling `RaidenAPI(app.raiden).token_network_connect` again? |
@@ -355,6 +355,11 @@ public abstract class Row implements Serializable {
return this;
}
+ public <T1, T2> Builder addMap(Map<T1, T2> data) {
+ this.values.add(data);
+ return this;
+ }
+
public Builder addArray(Object ... values) {
addArray(Arrays.asList(values));
return... | [Row->[getInt64->[getInt64,getValue],getDateTime->[getDateTime,getValue],Builder->[verify->[getFieldCount,equals],addArray->[addArray],verifyArray->[verifyArray,equals],build->[verify],addValues->[addValues]],equals->[getValues,getSchema,equals],getArray->[getArray,getValue],getFloat->[getFloat,getValue],getInt16->[get... | Add array. | <!--new_thread; commit:7bf9d2048e8d568ee9280629db391775cc490358; resolved:0--> Is this overload needed? addArray was needed because otherwise passing an array into addValues tended to unroll the array, but I don't think Java will do that for maps. |
@@ -145,6 +145,12 @@ static int data_init(int server, crt_init_options_t *opt)
setenv("FI_UNIVERSE_SIZE", "2048", 1);
}
+ d_getenv_int("CRT_MRC_ENABLE", &mrc_enable);
+ if (mrc_enable == 0) {
+ D_INFO("Disabling MR CACHE (FI_MR_CACHE_COUNT=0)\n");
+ setenv("FI_MR_CACHE_COUNT", "0", 1);
+ }
+
if (credits == 0... | [int->[D_GOTO,strerror,setenv,srand,mem_pin_workaround,D_ASSERT,D_RWLOCK_INIT,d_timeus_secdiff,rand,D_CASSERT,D_WARN,D_DEBUG,D_FREE,D_MUTEX_INIT,D_ALLOC_ARRAY,D_ERROR,d_getenv_int,mallopt,d_getenv_bool,dump_envariables,getpid,D_INIT_LIST_HEAD],inline->[getpid,strlen,D_DEBUG],crt_na_ofi_config_init->[D_STRNDUP,D_GOTO,in... | Initialize the CRT - Gdata This function is used to set the global configuration values for CRT. set environment variables and values for flow control c2c_sep_mode is set to false and CRT_CTX_. | @frostedcmos Shouldn't this be FI_MR_CACHE_MAX_COUNT instead of FI_MR_CACHE_COUNT? |
@@ -8,12 +8,14 @@
- No FM mode
- A third sample format (ADPCM) has been added
- Some minor other tweeks (no EGHOLD, slighly more capable DSP)
+ - Internal ARM7DI Core
*/
#include "emu.h"
#include "aica.h"
#define ICLIP16(x) (x<-32768)?-32768:((x>32767)?32767:x)
+#define CLIP(x,min,max) (x<min)?mi... | [No CFG could be retrieved] | The 64 - voice SCSP version of the object. PCM - specific functions. | This isn't safe with macro substitution when the arguments are expressions. The macro above it isn't safe either, but there's no excuse for adding more unsafe macros. |
@@ -62,6 +62,10 @@ class AsyncInfoController < ApplicationController
end.to_json
end
+ def check_user_role
+ @user.creator?
+ end
+
def user_cache_key
"user-info-#{current_user&.id}__
#{current_user&.last_sign_in_at}__
| [AsyncInfoController->[broadcast_data->[presence,to_json],base_data->[user_signed_in?,decorate,render,respond_to,discard,json],user_data->[to_json],user_cache_key->[last_sign_in_at,id,last_reacted_at,updated_at,blocking_others_count,reactions_count,last_followed_at,following_tags_count,articles_count]]] | user - data - missing - user - cache - key. | Maybe it's just me, but I don't find the name of this method very intent-revealing. |
@@ -42,7 +42,7 @@ public class CancelAction implements CeWsAction {
@Override
public void define(WebService.NewController controller) {
WebService.NewAction action = controller.createAction("cancel")
- .setDescription("Cancels a pending task. Requires system administration permission. In-progress tasks ... | [CancelAction->[define->[setExampleValue,setHandler],handle->[cancel,checkPermission,noContent,mandatoryParam]]] | This method defines the missing configuration for a task. | description should be fixed, root is now required, not system administration... or is that the name we give to root? |
@@ -1,7 +1,13 @@
Flipper.configure do |config|
config.default do
- # pick an adapter, this uses memory, any will do
- adapter = Flipper::Adapters::ActiveRecord.new
+ adapter = if (cache_duration = ENV["CACHE_FEATURE_FLAGS_SECONDS"])
+ Flipper::Adapters::ActiveSupportCacheStore.new(
+ ... | [new,default,configure] | Pick an instance of the from the Flipper instance. | nitpick: we have a convention of reading from ApplicationConfig, rather than from ENV directly - the initializers are executed alphabetically so 0_application_config.rb is loaded early enough. Should this be set in the example .env_sample file as well (i.e. is it expected to be turned on in dev and test, or only used i... |
@@ -246,6 +246,8 @@ static inline void init_module_info(struct exception_handler_data *data)
data);
}
+extern const char *get_win_release_id();
+
static inline void write_header(struct exception_handler_data *data)
{
char date_time[80];
| [No CFG could be retrieved] | Initialize the exception handler data. Initializes the exception handler information. | Should this not be in a platform header? |
@@ -1379,6 +1379,7 @@ class BlobClient(StorageAccountHostsMixin): # pylint: disable=too-many-public-m
dest_access_conditions = get_access_conditions(kwargs.pop('destination_lease', None))
options['source_modified_access_conditions'] = source_mod_conditions
options['lease_access_c... | [BlobClient->[create_page_blob->[_create_page_blob_options],abort_copy->[_abort_copy_options],set_sequence_number->[_set_sequence_number_options],start_copy_from_url->[_start_copy_from_url_options,start_copy_from_url],resize_blob->[_resize_blob_options],upload_blob->[_upload_blob_options],upload_pages_from_url->[_uploa... | Start a copy from a source URL. Returns a list of access conditions that can be used to copy a blob asynchronously. Copy the specified name - value sequence number from the source blob to the destination blob. | Thanks for fixing this! Also in a clean way! Just noticed it failed IC while I haven't pushed the fix. |
@@ -148,12 +148,4 @@ public abstract class AbstractRealtimeRecordReader {
public Schema getHiveSchema() {
return hiveSchema;
}
-
- public long getMaxCompactionMemoryInBytes() {
- // jobConf.getMemoryForMapTask() returns in MB
- return (long) Math
- .ceil(Double.parseDouble(jobConf.get(HoodieRea... | [AbstractRealtimeRecordReader->[init->[getNameToFieldMap,getBasePath,getFields,info,toList,addPartitionFields,get,generateProjectionSchema,format,toString,readLatestSchemaFromLogFiles,collect,getBaseFileSchema,constructHiveOrderedSchema,length,orderFields,getPath,getDeltaLogPaths],constructHiveOrderedSchema->[schema,sp... | getHiveSchema - get the hive schema for this task. | why remove this? |
@@ -85,6 +85,18 @@ module View
def actions_for(company)
@game.round.actions_for(company)
end
+
+ def render_sell_company_button
+ sell = lambda do
+ process_action(Engine::Action::SellCompany.new(
+ @game.current_entity,
+ company: @selected_company,
+ ... | [Abilities->[render_actions->[h,is_a?,include?,actions_for,any?],render_companies->[compact],render->[closed?,partition,company?,any?,lambda,name,h,render_companies,concat,select,entity_can_use_company?,current_entity,sort!,empty?,dig,include?,player,desc,owner,store],actions_for->[actions_for],needs,freeze],require] | Returns the actions for the company. | can other games do this? it seems like the action already exists looks like 1860 allows this already, can you do it in the same way 1860 does it? |
@@ -74,6 +74,8 @@ public class PageCursorProviderImpl implements PageCursorProvider {
private final SoftValueLongObjectHashMap<PageCache> softCache;
+ private final LongObjectHashMap<PageCache> indexCacheMap;
+
private final LongObjectHashMap<CompletableFuture<PageCache>> inProgressReadPages;
privat... | [PageCursorProviderImpl->[resumeCleanup->[scheduleCleanup],flushExecutors->[waitForFuture,flushExecutors],getMessage->[getMessage],onPageModeCleared->[onPageModeCleared],onDeletePage->[cloneSubscriptions,onDeletePage],stop->[stop],processReload->[processReload],getPageCache->[getMessage],finishCleanup->[close]]] | Implementation of the PageCursorProvider interface. | Wouldn't this break SoftReferences cleanup? meaning a page will be leaving forever. I would use a SoftValueLongObjectHashMap here as well. In case memory is low, we want PageCache to be releasable. And this would make hard references on pageCache. <<this is a question>> |
@@ -159,7 +159,7 @@ func main() {
events.GenericEventRecorder().FatalEvent(err, events.InitializationError, "Error creating MeshSpec")
}
- certManager, certDebugger, err := getCertificateManager(kubeClient, kubeConfig)
+ certManager, certDebugger, err := getCertificateManager(kubeClient, kubeConfig, cfg.IsDebugS... | [StringVar,IssueCertificate,RegisterExitHandlers,BuildConfigFromFlags,TrimRight,CoreV1,Msgf,NewADSServer,NewMeshSpecClient,NewProvider,Info,GetExpiration,IntVar,NewForConfigOrDie,Int,Error,Format,Secrets,New,NewConfigurator,GetConfigMap,StringVarP,Start,Errorf,GetCertificateChain,FatalEvent,GetRootCertificate,SetLogLev... | osmConfigMap is a helper function that creates a new OSM config map and creates if creates a Kubernetes endpoint provider. | This is a start, although the goal of PR #1740 is to make it possible to dynamically turn on/off the debug server via a ConfigMap. This change does not achieve this because the DebugServer is still initialized in `main()`. The existing code must be refactored so that the debug server can be dynamically turned on/off vi... |
@@ -65,6 +65,8 @@ public class UpdateUserCmd extends BaseCmd {
acceptedOnAdminPort = false)
private String password;
+ @Parameter(name = ApiConstants.OLD_PASSWORD, type = CommandType.STRING, description = "Old password that was being used by the user. You must inform the old password when updatin... | [UpdateUserCmd->[getEntityOwnerId->[getId],execute->[getCommandName,getId]]] | Creates a Command that updates a user account. | I would prefer the word "current" instead of "old* |
@@ -62,9 +62,14 @@ def test_serialize_kubernetes_run(config):
"memory_request",
"service_account_name",
"image_pull_secrets",
+ "always_pull_new_image",
]
for field in fields:
- assert getattr(config, field) == getattr(config2, field)
+ if field == "always_pull_... | [test_serialize_docker_run->[RunConfigSchema,getattr,sorted],test_serialized_run_config_sorts_labels->[RunConfigSchemaBase],test_serialize_universal_run->[RunConfigSchema,sorted],test_serialize_ecs_run->[RunConfigSchema,getattr,sorted],test_serialize_local_run->[RunConfigSchema,getattr,sorted],test_serialize_kubernetes... | Test serialize kubernetes run. | I think the serialization field type is causing issues here, we should not have to change the test logic here |
@@ -24,7 +24,7 @@ FLAG(int32, worker_threads, 4, "Number of work dispatch threads");
/// Cancel the pause request.
void RunnerInterruptPoint::cancel() {
- WriteLock lock(mutex_);
+ std::unique_lock<std::mutex> lock(mutex_);
stop_ = true;
condition_.notify_all();
}
| [stopServices->[interrupt],pauseMilli->[pause],interrupt->[cancel]] | Cancels the current interrupt. | NB: This must remain since it is used in a condition point. |
@@ -147,6 +147,10 @@ def monkey_patch_varbase():
:code:`retain_graph` to True, then the grads will be retained. Thus, seting it to False is much more memory-efficient.
Defaults to False.
+ grad_tensor(Tensor, optional): initial gradient values of `outputs` . If `grad_tenso... | [monkey_patch_varbase->[grad->[gradient],__bool__->[__nonzero__]]] | Monkey patches VarBase into a static Variable. Variable set_value function Returns the value of the last node of the system. A property to provide a representation of a object. A property that returns a new object with a unique name for the object. | `Tensor`API`initial gradient values of outputs``initial gradient values of current Tensor` |
@@ -13,3 +13,11 @@ class UserConfig(AuthConfig):
def ready(self):
# Connect signal handlers
from . import signal_handlers # noqa
+
+ # Configure global 'stripe' module
+ if settings.STRIPE_SECRET_KEY:
+ # XXX Perhaps we ought to sanity check that *all* other Stripe
+ ... | [UserConfig->[_]] | Check if the signal handler is available. | Let's not do that. It's out of context. It's perhaps weird but you might have a `STRIPE_SECRET_KEY` but prefer to not set up the `STRIPE_PLAN_ID`. |
@@ -825,7 +825,10 @@ func UpdateTeamUnits(team *Team, units []TeamUnit) (err error) {
}
if _, err = sess.Insert(units); err != nil {
- sess.Rollback()
+ err = sess.Rollback()
+ if err != nil {
+ return err
+ }
return err
}
| [RemoveRepository->[HasRepository,removeRepository],unitEnabled->[getUnits],GetRepositories->[getRepositories],AddRepository->[HasRepository,addRepository],addRepository->[getMembers],GetMembers->[getMembers],HasRepository->[hasRepository],getRepositories,IsOwnerTeam,getMembers,GetRepositories] | Insert a new unit into the database. | This if statement is not necessary because no matter the outcome err will be returned |
@@ -7808,7 +7808,8 @@ namespace System.Xml
private string LookupNamespace(NodeData node)
{
- string ns = _namespaceManager.LookupNamespace(node.prefix);
+ Debug.Assert(_namespaceManager != null);
+ string? ns = _namespaceManager.LookupNamespace(node.prefix);
... | [No CFG could be retrieved] | Private methods for parsing XML nodes. Private methods - add a namespace to the namespace manager. | `!` not needed if `Throw(...)` [DoesNotReturn] |
@@ -94,13 +94,12 @@ export function Option({
style,
...rest
}) {
- const selectorContext = useContext(SelectorContext);
const {
- 'selected': selected,
- 'selectOption': selectOption,
- 'disabled': selectorDisabled,
- 'multiple': selectorMultiple,
- } = selectorContext;
+ selected,
+ selec... | [No CFG could be retrieved] | Displays a single component. | Ready to be fixed. |
@@ -282,9 +282,9 @@ public class MuleArtifactResourcesRegistry {
}
/**
- * @return the {@link ToolingApplicationDescriptorFactory}.
+ * @return the {@link AbstractDeployableDescriptorFactory}.
*/
- public ToolingApplicationDescriptorFactory getToolingApplicationDescriptorFactory() {
+ public AbstractD... | [MuleArtifactResourcesRegistry->[Builder->[build->[MuleArtifactResourcesRegistry]]]] | getToolingApplicationDescriptorFactory This method returns the ToolingApplicationDescriptorFactory. | if possible return an interface instead of an abstract class. |
@@ -60,6 +60,9 @@ public class HttpToHttp2ConnectionHandler extends Http2ConnectionHandler {
* @throws Exception If the {@code httpHeaders} object specifies an invalid stream id
*/
private int getStreamId(HttpHeaders httpHeaders) throws Exception {
+ if (httpScheme != null && !httpHeaders.contai... | [HttpToHttp2ConnectionHandler->[writeHeaders->[writeHeaders],write->[write,getStreamId]]] | Get the next stream id from the HTTP headers. | honestly I think thats a very bad idea... a method with `get` in its name should not modify the headers that are passed in. This is just super unexpected. |
@@ -46,7 +46,7 @@ namespace System.DirectoryServices.Protocols.Tests
Assert.Throws<ObjectDisposedException>(() => connection.SessionOptions.ReferralChasing = ReferralChasingOptions.All);
}
- [Theory]
+ [ConditionalTheory(nameof(PlatformDetection.IsWindows))]
[InlineData(tr... | [LdapSessionOptionsTests->[VerifyServerCertificate_GetGetSetWhenDisposed_ThrowsObjectDisposedException->[VerifyServerCertificate]]] | This method is used to set the ReferralChasing and SecureSocketLayer when disposing. | Why ConditionalTheory instead of `[PlatformSpecific(TestPlatforms.Windows)]`? |
@@ -100,6 +100,16 @@ class TestTrainModel(unittest.TestCase):
'Task accuracy is averaged incorrectly',
)
+ def test_multitasking_id_overlap(self):
+ with self.assertRaises(KeyError) as context:
+ testing_utils.train_model(
+ {'task': 'integration_tests,' 'inte... | [TestTrainModel->[test_fast_final_eval->[train_model,assertEqual],test_multitasking_metrics_micro->[train_model,assertEqual],test_multitasking_metrics_macro->[train_model,assertEqual,value]],main] | Test multitasking metrics macro. | maybe just create world instead of full blown train model? |
@@ -532,7 +532,7 @@ Matrix& GenericSmallStrainIsotropicPlasticity<TConstLawIntegratorType>::Calculat
Matrix constitutive_matrix;
this->CalculateElasticMatrix(constitutive_matrix, rParameterValues);
- array_1d<double,VoigtSize> tmp = prod(constitutive_matrix, strain_vector - mPlasticStrain);
+... | [No CFG could be retrieved] | This function calculates the value of an individual constant on the basis of the constant of the constant Checks if a given object has a non - zero number of non - zero number of non. | this is computing the "old" plastic strain, with the savd value of mPlasticStrain, as changed in the FinalizeSolutionStep. Is that what you want? |
@@ -79,7 +79,7 @@ def fetch_nni_log_path(experiment_url):
'''get nni's log path from nni's experiment url'''
experiment_profile = requests.get(experiment_url)
experiment_id = json.loads(experiment_profile.text)['id']
- experiment_path = os.path.join(os.environ['HOME'], 'nni/experiments', experiment_id... | [parse_max_duration_time->[int],get_experiment_status->[get],dump_yml_content->[open,dump,write],get_yml_content->[open,load],deep_update->[get,isinstance,items,deep_update],setup_experiment->[abspath,get,join],remove_files->[remove,suppress],read_last_line->[open,strip],print_stderr->[trial_job,get,run],get_succeeded_... | fetch the path of the nni s log file from the given experiment url. | Better with space after `'nni',` |
@@ -0,0 +1,12 @@
+package main
+
+import (
+ "github.com/pulumi/pulumi/sdk/v2/go/pulumi"
+)
+
+func main() {
+ pulumi.Run(func(ctx *pulumi.Context) error {
+ ctx.Export("exp_static", pulumi.String("foo"))
+ return nil
+ })
+}
| [No CFG could be retrieved] | No Summary Found. | Should it have a sleep or something to guarantee the clash? |
@@ -34,5 +34,11 @@ module Admin
def settings_params
params.permit(ALLOWED_PARAMS)
end
+
+ def upload_logo(image)
+ ArticleImageUploader.new.tap do |uploader|
+ uploader.store!(image)
+ end
+ end
end
end
| [CreatorSettingsController->[extra_authorization->[has_role?],create->[logo_svg,redirect_to,render,transaction,community_name,message,public,now,primary_brand_color_hex,invite_only_mode,update!],settings_params->[permit],freeze]] | params that are not allowed for setting. | I'm using what I found in the image uploader. |
@@ -27,6 +27,7 @@
//= require ./discourse/lib/formatter
//= require ./discourse/lib/eyeline
//= require ./discourse/lib/show-modal
+//= require ./discourse/lib/safari-hacks
//= require ./discourse/mixins/scrolling
//= require ./discourse/lib/ajax-error
//= require ./discourse/models/model
| [No CFG could be retrieved] | The default discourse model is a model that is not a part of the discourse model Model modules. | I would extract `isAppleDevice` from `safari-hacks` |
@@ -108,8 +108,6 @@ class BucketIterator(DataIterator):
maximum_samples_per_batch: Tuple[str, int] = None,
skip_smaller_batches: bool = False,
) -> None:
- if not sorting_keys:
- raise ConfigurationError("BucketIterator requires sorting_keys to be specified")
super().... | [BucketIterator->[_create_batches->[sort_by_padding]]] | Initialize the object with the given configuration. | So the idea here is that since the basic iterator really is a bucket iterator, we don't want this check anymore? I'm a bit worried that this could mislead some users. Basically, they'll use the bucket iterator, won't set a sort key and (surprise) won't see any improvement. What about leaving this in for the old iterato... |
@@ -45,6 +45,10 @@ class SelfAttention(TransformerModule, FromParams):
else:
self.attn = Attention.by_name(self.scoring_func)()
+ # out linear layer for distilbert.
+ if output_linear:
+ self.output = torch.nn.Linear(hidden_size, self.all_head_size)
+
self.dropo... | [SelfAttention->[forward->[_transpose_for_scores]]] | Initialize the object with the specified parameters. | What is this? Does it get initialized as well? |
@@ -26,7 +26,7 @@
* Parent class for class inheritance lines of business objects
* This class is useless for the moment so no inherit are done on it
*/
-abstract class CommonObjectLine
+abstract class CommonObjectLine extends CommonObject
{
/**
* Call trigger based on this instance
| [CommonObjectLine->[call_trigger->[run_triggers]]] | The base class for all of the common object line of a single object. get - 1 - 0. | Great job, but extending CommonObjectLine from CommonObject feels weird. CommonObject is supposed to be the common class for business rules. CommonObjectLine represents the lines of a CommonObject but is not a business rule itself. |
@@ -104,9 +104,12 @@ class ExpectedRiskMinimization(DecoderTrainer[Callable[[StateType], torch.Tensor
batch_costs[batch_index].append(cost)
return batch_costs
- def _get_best_action_sequences(self, finished_states: List[StateType]) -> Dict[int, List[int]]:
+ def _get_best_action_sequences(... | [ExpectedRiskMinimization->[_get_best_action_sequences->[_get_model_scores_by_batch]]] | Returns the best action sequences for each batch based on model scores. | Nit: This is a private method, and `max_num_decoded_sequences` is a member variable. You don't need to pass it as an argument to this method. Do you gain anything by passing it instead of just reading it from `self`? |
@@ -60,8 +60,14 @@ class Lammps(CMakePackage):
depends_on('netcdf+mpi', when='+user-nc-dump')
depends_on('blas', when='+user-atc')
depends_on('lapack', when='+user-atc')
+ depends_on('latte', when='+latte')
+ depends_on('blas', when='+latte')
+ depends_on('lapack', when='+latte')
+
+ conflict... | [Lammps->[url_for_version->[str,strftime,strptime,format],cmake_args->[format],depends_on,format,version,patch,variant]] | Return a list of arguments for the cmake command. | I will drop this when lammps/lammps#660 is merged. |
@@ -44,6 +44,7 @@ namespace System.Runtime.InteropServices.Tests
[Fact]
[SkipOnMono("Marshal.WriteInt32 will not be implemented in Mono, see https://github.com/mono/mono/issues/15085.")]
+ [ActiveIssue("https://github.com/dotnet/runtime/issues/37093", TestPlatforms.Android)]
public v... | [Int32Tests->[WriteInt32_NullObject_ThrowsAccessViolationException->[WriteInt32,Assert],WriteInt32_StructWithReferenceTypes_ReturnsExpected->[byValueArray,Equal,stringValue,ToInt32,pointerValue,ReadInt32,WriteInt32,NotEqual],ReadInt32_StructWithReferenceTypes_ReturnsExpected->[NotEqual,ToInt32,ReadInt32,Equal],ReadInt3... | Write int32 magic number in structure. | Same thing applies as in ByteTests |
@@ -433,6 +433,16 @@ class TestBase(unittest.TestCase, metaclass=ABCMeta):
if self._build_graph is not None:
self._build_graph.reset()
+ _P = TypeVar("_P")
+
+ def request_single_product(
+ self, product_type: Type["TestBase._P"], subject: Union[Params, Any]
+ ) -> "TestBase._P":
+ result = asser... | [TestBase->[reset_build_graph->[invalidate_for,buildroot_files],target->[_init_target_subsystem],create_resources->[create_library],LoggingRecorder->[warnings->[_messages_for_level],errors->[_messages_for_level],infos->[_messages_for_level]],create_file->[invalidate_for],scheduler->[_init_engine],isolated_local_store->... | Start over with a fresh build graph with no targets in it. Creates a new context object with a that can be used to create a task. | This is awesome! I love how flexible the type system is!!! |
@@ -43,7 +43,7 @@ class SingleIdTokenIndexer(TokenIndexer[int]):
index_name: str) -> Dict[str, List[int]]:
indices: List[int] = []
- for token in tokens:
+ for token in itertools.chain(self._start_tokens, tokens, self._end_tokens):
if getattr(token, 'text... | [SingleIdTokenIndexer->[count_vocab_items->[getattr,lower],pad_token_sequence->[pad_sequence_to_length,items],tokens_to_indices->[append,getattr,lower,get_token_index]],register] | Converts a list of tokens to a list of indices. | I need to remember to use itertools more often... I would have just done `self._start_tokens + tokens + self._end_tokens`, which is less efficient. |
@@ -6458,4 +6458,4 @@ public class UserVmManagerImpl extends ManagerBase implements UserVmManager, Vir
}
return false;
}
-}
+}
\ No newline at end of file
| [UserVmManagerImpl->[removeInstanceFromInstanceGroup->[expunge],applyUserData->[getName],moveVMToUser->[doInTransactionWithoutResult->[getName,resourceCountIncrement,resourceCountDecrement],removeInstanceFromInstanceGroup,resourceLimitCheck,getName,getVmId,getSecurityGroupIdList],loadVmDetailsInMapForExternalDhcpIp->[V... | Checks if there are ongoing snapshots on a volume of a given type. | it is hard to find functional changes in this file. the new 2380-2424 are it, are they? |
@@ -62,7 +62,7 @@ const commonFiles = {
],
},
{
- condition: generator => generator.enableI18nRTL,
+ condition: generator => generator.enableI18nRTL && !generator.clientFrameworkReact,
path: CLIENT_MAIN_SRC_DIR,
templates: ['content/scss/rtl.scss'],
},
| [No CFG could be retrieved] | Package common files. | Why do we skip this? Is it all handled by the post-rtlcss plugin now? |
@@ -332,11 +332,13 @@ public abstract class SQLMetadataConnector implements MetadataStorageConnector
StringUtils.format(
"CREATE TABLE %1$s (\n"
+ " id %2$s NOT NULL,\n"
- + " %4$s_id VARCHAR(255) DEFAULT NULL,\n"
- + " log_payload %3$s,\n"... | [SQLMetadataConnector->[createAuditTable->[createTable,getPayloadType,createAuditTable,getSerialType],createSegmentTable->[createTable,getPayloadType,getQuoteString,createSegmentTable],createPendingSegmentsTable->[createTable,createPendingSegmentsTable,getPayloadType,getQuoteString],createConfigTable->[createTable,getP... | Create log table if not exists. | Does this require SQL upgrades on metadata storage? |
@@ -213,11 +213,15 @@ void IS31FL3733_set_led_control_register(uint8_t index, bool red, bool green, bo
void IS31FL3733_update_pwm_buffers(uint8_t addr, uint8_t index) {
if (g_pwm_buffer_update_required[index]) {
- // Firstly we need to unlock the command register and select PG1
+ // Firstly we nee... | [IS31FL3733_init->[IS31FL3733_write_register],IS31FL3733_set_color_all->[IS31FL3733_set_color],IS31FL3733_update_pwm_buffers->[IS31FL3733_write_pwm_buffer,IS31FL3733_write_register],IS31FL3733_update_led_control_registers->[IS31FL3733_write_register]] | This function updates the LED control registers and PWM buffers if they are not already set. | you aren't using return value at all? is that ok |
@@ -678,11 +678,6 @@ class ElggPlugin extends ElggObject {
$this->getBootstrap()->activate();
- if ($this->canReadFile('activate.php')) {
- elgg_deprecated_notice("The usage of the activate.php for {$this->getDisplayName()} is deprecated. Use the Bootstrap->activate() function.", '3.1');
- $return =... | [ElggPlugin->[getAllSettings->[getStaticConfig,getAllSettings],unsetAllUserAndPluginSettings->[getID,unsetAllSettings],invalidateCache->[invalidateCache,getID],isActive->[getID],includeFile->[getPath,getID],setSetting->[getID],setUserSetting->[getID],registerLanguages->[getLanguagesPath],registerRoutes->[getStaticConfi... | Activate the plugin This function is called when a plugin is not activated. | I can't find anything in the docs that this was deprecated. Maybe add in the migration docs that this was removed. |
@@ -260,7 +260,8 @@ class Multinomial(distribution.Distribution):
def _log_unnormalized_prob(self, counts):
counts = self._maybe_assert_valid_sample(counts)
- return math_ops.reduce_sum(counts * math_ops.log(self.probs), -1)
+ logsumexp = math_ops.reduce_logsumexp(self.logits, -1, keep_dims=True)
+ r... | [Multinomial->[_event_shape->[get_shape],_maybe_assert_valid_sample->[reduce_sum,assert_equal,with_dependencies,embed_check_nonnegative_integer_form],_batch_shape_tensor->[shape],_log_normalization->[_maybe_assert_valid_sample,log_combinations],_event_shape_tensor->[shape],_sample_n->[batch_shape_tensor,reduce_sum,NotI... | Log probability of unnormalized model. | this doesn't _seem_ to be the same calculation. sorry if i'm being thick, can you show how this calculation is equivalent mathematically to the old one? |
@@ -30,6 +30,7 @@ class Configuration implements ConfigurationInterface
$treeBuilder->root('sulu_admin')
->children()
->scalarNode('name')->defaultValue('Sulu Admin')->end()
+ ->scalarNode('email')->defaultValue('hikari.sulu@su.lu')->end()
->scalarN... | [Configuration->[getConfigTreeBuilder->[end]]] | Returns a TreeBuilder for the Sulu Admin configuration. | I would not put a default value here, either it is a required value, which has to be set or it is optional. |
@@ -330,9 +330,12 @@ class FixedDialogTeacher(Teacher):
return observation
def batch_act(self, observations):
- """Returns an entire batch of examples instead of just one.
- Note: Currently used by PytorchDataTeacher.
"""
+ Returns an entire batch of examples instead of ... | [StreamDialogData->[reset->[_load],num_examples->[load_length],num_episodes->[load_length],__init__->[get],load_length->[_read_episode],get->[_lock,build_table],_data_generator->[_read_episode]],FbDialogTeacher->[__init__->[get]],DialogData->[build_table->[get],_load->[_read_episode],__init__->[get]],FixedDialogTeacher... | Returns a batch of examples instead of just one. | i _think_ it is actually still used by the `PytorchDataTeacher` |
@@ -244,6 +244,10 @@ public class ZeppelinServer extends ResourceConfig {
LOG.info("Starting zeppelin server");
try {
jettyWebServer.start(); // Instantiates ZeppelinServer
+ List<ErrorData> errorData = handler.waitForAtLeastOneConstructionError(5 * 1000);
+ if(errorData.size() > 1 && errorDa... | [ZeppelinServer->[setupNotebookServer->[getService,setInitParameter,getWebsocketMaxTextMessageSize,ServletContextHandler,addServlet,ServletHolder],getSslContextFactory->[getTrustStorePassword,SslContextFactory,getKeyManagerPassword,getKeyStorePassword,getKeyStoreType,setKeyStorePath,setKeyStorePassword,setNeedClientAut... | Main method. Binds the application to the application manager. Add JMX Beans and Jetty Beans check if any key is available in console window. | Should this be `>=1` or `>0`? |
@@ -1551,7 +1551,7 @@ public final class StandardProcessSession implements ProcessSession, ProvenanceE
}
}, expiredRecords);
}
- }, false);
+ }, true);
}
@Override
| [StandardProcessSession->[read->[mark->[mark],reset->[reset],skip->[skip],available->[available],markSupported->[markSupported],close->[close,remove],getInputStream,get,read],decrementReadCount->[get,remove],transfer->[get,updateLastQueuedDate,transfer],finalize->[finalize,rollback],write->[close->[remove,flush],flush-... | Get a batch of flow files in a round - robin manner. | I think in this case we can still get away with 'false'. When the processor passes a Filter in, we lock all queues because we want to ensure that there aren't multiple threads interfering with one another, causing odd filtering (e.g., one thread pulls a given flowfile and then is waiting for another to match but a seco... |
@@ -203,8 +203,7 @@ namespace System.Text.Json
// There are 3 copies of the property name:
// 1) NameAsString. The unescaped property name.
// 2) NameAsUtf8Bytes. The Utf8 version of NameAsString. Used during during deserialization for property lookup.
- // 3) EscapedName. The escaped ... | [JsonPropertyInfo->[ReadJsonAndAddExtensionProperty->[GetValueAsObject],GetPolicies->[DetermineSerializationCapabilities,DeterminePropertyName,DetermineIgnoreCondition]]] | XML - like object that represents a single object that can be serialized into a JSON - like ReadJsonAndAddExtensionProperty - Read JSON and add extension property. | Would these be null for "PropertyInfoForClassInfo"s? |
@@ -25,7 +25,8 @@ class MPMExplicitSolver(MPMSolver):
this_defaults = KratosMultiphysics.Parameters("""{
"time_integration_method" : "explicit",
"scheme_type" : "central_difference",
- "stress_update" : "usf"
+ "stress_update" : "usf",
+ "is_fix_ex... | [MPMExplicitSolver->[_CreateSolutionStrategy->[SetValue,_CreateLinearStrategy,GetGridModelPart,settings,Exception],_CreateSolutionScheme->[SetValue,MPMExplicitScheme,_GetDomainSize,GetGridModelPart,settings,Exception],AddVariables->[PrintInfo,_AddDynamicVariables,super,GetGridModelPart,AddNodalSolutionStepVariable],_Cr... | Get the default settings for the MPMExplicitSolver. | This sounds like it can/should be done with a process |
@@ -556,8 +556,9 @@ func (c *createConfig) GetContainerCreateOptions() ([]libpod.CtrCreateOption, er
options = append(options, libpod.WithName(c.Name))
}
// TODO parse ports into libpod format and include
- // TODO should not happen if --net=host
- options = append(options, libpod.WithNetNS([]ocicni.PortMapping{... | [GetVolumeMounts->[Wrapf,Split,Relabel],GetContainerCreateOptions->[WithNetNS,WithStopSignal,WithName,WithStdin,WithStopTimeout,Debugf],GetTmpfsMounts->[Split],CreateBlockIO->[Minor,Wrapf,Major],SetLinuxResourcesCPURealtimePeriod,GetAnnotations,IsContainer,SetLinuxResourcesMemoryReservation,AddLinuxSysctl,AddCgroupsMou... | GetContainerCreateOptions returns the list of container create options. | I think this should also be eliminated on IsNone and IsContainer? |
@@ -101,6 +101,11 @@ public class InformationSchemaPageSource
table = tableHandle.getTable();
prefixIterator = Suppliers.memoize(() -> {
Set<QualifiedTablePrefix> prefixes = tableHandle.getPrefixes();
+ if (!tableHandle.getLimit().isPresent()) {
+ // no limit is ... | [InformationSchemaPageSource->[getNextPage->[isFinished]]] | Creates a page source that can be used to retrieve a set of records from a table. Returns a stream of information schema columns. | Listing schemas explicitly here also helps return results to client sooner. And with respect to Hive Connector, it doesn't really increase the number of metadata calls to HMS. Having said that, I think it's fine to make the change as it may help in case of other connectors. |
@@ -157,11 +157,7 @@ static int test_record_overflow(int idx)
overf_expected = 0;
}
- if (idx == TEST_ENCRYPTED_OVERFLOW_TLS1_3_OK
- || idx == TEST_ENCRYPTED_OVERFLOW_TLS1_3_NOT_OK)
- recversion = TLS1_VERSION;
- else
- recversion = TLS1_2_VERSION;
+ recversion = TLS1_2... | [cleanup_tests->[bio_s_mempacket_test_free],int->[fail_due_to_record_overflow,TLS_server_method,create_ssl_connection,create_ssl_objects,SSL_accept,TEST_true,ERR_clear_error,TEST_int_eq,BIO_write_ex,SSL_get_rbio,ERR_GET_LIB,ERR_peek_error,SSL_CTX_set_max_proto_version,TEST_false,ERR_GET_REASON,write_record,SSL_read_ex,... | This method checks if record overflow overflow is detected and returns the number of bytes written. This method checks if any of the SSL record headers are present and if so returns true if. | I'm slightly surprised that this works with no-tls12 builds, but any issue there is not new to this version, so it's clearly okay. |
@@ -203,8 +203,9 @@ export class AmpSelector extends AMP.BaseElement {
selectedValues = this.setInputs_();
}
- // Don't trigger action if selected values haven't changed.
+ // Don't change focus trigger action if selected values haven't changed.
if (selectedValues) {
+ this.upd... | [No CFG could be retrieved] | Adds hidden elements to the list of selected options and triggers select and select events. Removes all selected options from the list and clears others if required. | Don't trigger action or update focus if ... |
@@ -8727,6 +8727,14 @@ namespace Js
#endif
}
}
+ else
+ {
+#ifdef DEBUG
+ for (int __i = i; __i < EQUIVALENT_TYPE_CACHE_SIZE; __i++)
+ { Assert(this->types[__i] == nullptr); }
+#endif
+ break; // array must be shrinked alr... | [No CFG could be retrieved] | ClearUnusedTypes - This function clears all unused types from the cache. Register constructor cache and constructor cache list. | I dont know this code very well to ascertain that this assert is valid. Maybe @pleath has more context. |
@@ -95,3 +95,6 @@ RENEWAL_CONFIGS_DIR = "renewal"
RENEWER_CONFIG_FILENAME = "renewer.conf"
"""Renewer config file name (relative to `IConfig.config_dir`)."""
+
+FORCE_INTERACTIVE_FLAG = "--force-interactive"
+"""Flag to disable TTY checking in IDisplay."""
| [dict,int,get,join] | RENEWER_CONFIG_FILENAME - Name of the configuration file to use. | This pattern is okay, but I'd note that we haven't used it in other situations where there are string literals around the code that contain things like this (`git grep cli_flag`) |
@@ -30,7 +30,8 @@ $notifications = new ObjectCache('notifications');
<div class="row">
<div class="col-md-12">
<h1><a href="/notifications">Notifications</a></h1>
- <h4><strong class="count-notif"><?php echo $notifications['count']; ?></strong> Unread Notifications <?php echo ($_SESSION['userlevel']... | [No CFG could be retrieved] | Displays a single in the UI. Displays a hidden field that displays a notifnion. | Mark All as read should not be displayed on the notifications page. |
@@ -23,6 +23,8 @@ module Engine
@loans = []
@color = opts[:color]
@text_color = opts[:text_color] || '#ffffff'
+ @dest_coordinates = opts[:dest_coordinates]
+ @dest_icon = opts[:dest_icon] ? "/icons/#{opts[:dest_icon]}" : ''
end
def operator?
| [init_operator->[new,map],runnable_trains->[reject],unplaced_tokens->[reject],tokens_by_type->[uniq],placed_tokens->[select],find_token_by_type->[find,type,used],next_token->[find,used],operated?->[empty?],attr_reader,require_relative,include,attr_accessor] | Initialize a new object with the given options. | rename all of these to destination_x |
@@ -15,6 +15,7 @@ class PyXopen(PythonPackage):
homepage = "https://github.com/marcelm/xopen"
url = "https://pypi.io/packages/source/x/xopen/xopen-0.1.1.tar.gz"
+ version('0.9.0', sha256='1e3918c8a5cd2bd128ba05b3b883ee322349219c99c305e10114638478e3162a')
version('0.8.2', sha256='003749e09af7410... | [PyXopen->[depends_on,version]] | Small Python module provides a function that works like the built - in open function but. | You'll need to update the deps, Python 3.5+ is required now, as well as a build dep on `py-setuptools-scm` |
@@ -578,7 +578,7 @@ public class OutOfBandManagementServiceImpl extends ManagerBase implements OutOf
@Override
public Long getDelay() {
- return null;
+ return OutOfBandManagementBackgroundTaskExecutionInterval.value() * 1000L;
}
}
| [OutOfBandManagementServiceImpl->[executePowerOperation->[transitionPowerState,getDriver,checkOutOfBandManagementEnabledByZoneClusterHost,getOptions,getConfigForHost,sendAuthError],getDriver->[getDriver],isOutOfBandManagementEnabled->[isOutOfBandManagementEnabledForCluster,isOutOfBandManagementEnabledForZone,isOutOfBan... | Returns the delay of the next sequence. | When this returns null, I think the poll manager uses some default value (I think 5s?). If the default config value is 4s, it may not make much difference. |
@@ -294,7 +294,9 @@ def default_lib_path(data_dir: str,
# Add fallback path that can be used if we have a broken installation.
if sys.platform != 'win32':
path.append('/usr/local/lib/mypy')
-
+ assert path, "Could not resolve typeshed subdirectories. If you are using MyPy " \
+ "fr... | [find_modules_recursive->[BuildSource,find_module,find_modules_recursive],process_graph->[trace,log],BuildManager->[all_imported_modules_in_file->[correct_rel_imp,import_priority],get_stat->[maybe_swap_for_shadow_path],report_file->[is_source]],load_plugins->[plugin_error],State->[parse_file->[parse_file,read_with_pyth... | Return default standard library search paths. | Is there a way to turn this into a regular (blocking) error message? Many people don't read the error when they get a traceback, and just instantly file a bug or go to a help forum. |
@@ -57,9 +57,8 @@ public class RecurringStateApplyJob extends RhnJavaJob {
}
private void scheduleAction(JobExecutionContext context, RecurringAction action) {
- List<Long> minionIds = action.computeMinions().stream()
- .map(m -> m.getId())
- .collect(Collectors.toList()... | [RecurringStateApplyJob->[scheduleAction->[of,error,toList,isTestMode,scheduleApplyStates,collect,getCreator,getFireTime],cleanSchedule->[unscheduleBunch,format,error,warn],execute->[ifPresentOrElse,scheduleAction,cleanSchedule,debug,getName,isActive,lookupByJobName,format]]] | Schedules the given action for the given job execution context. | `Collectors` are not used anymore. Remove the import please. |
@@ -31,6 +31,14 @@ func (factory *BuildControllerFactory) Create() *controller.BuildController {
buildQueue := cache.NewFIFO()
cache.NewReflector(&buildLW{client: factory.Client}, &buildapi.Build{}, buildQueue).Run()
+ // Kubernetes does not currently synchronize Pod status in storage with a Pod's container
+ // ... | [Create->[NewStore,NewPoller,NewFIFO,Pop,NewReflector,Run],List->[ListBuilds,Everything,NewContext],CreateBuildPod->[CreateBuildPod,New],Watch->[WatchBuilds,Everything,NewContext],pollPods->[ListPods,Everything,NewContext]] | Create creates a new build controller. | TODO: zomg this is horribly unperformant and will have to be fixed etc |
@@ -68,7 +68,7 @@ internal class Utils
{
if (!silent)
{
- LogError(e.Data);
+ LogInfo(e.Data, outputMessageImportance);
outputBuilder.AppendLine(e.Data);
}
errorBuilder.AppendLine(... | [Utils->[DirectoryCopy->[Copy,predicate,GetRelativePath,IsNullOrEmpty,Combine,GetDirectoryName,AllDirectories,CreateDirectory,GetFiles],GetEmbeddedResource->[ReadToEnd,GetManifestResourceStream,Name],RunProcess->[Value,Count,High,WaitForExit,EnvironmentVariables,Start,ErrorDataReceived,BeginOutputReadLine,LogError,Key,... | Runs a process with the specified parameters. Get the output of the process if any. | This method is used in many other places too. Maybe we should add a method param like `logStdErrAsError` or something, defaulting to true? |
@@ -1,10 +1,9 @@
-# rubocop:disable Metrics/ClassLength
class UserMailer < ActionMailer::Base
include Mailable
include LocaleHelper
before_action :attach_images
- default from: email_with_name(Figaro.env.email_from, Figaro.env.email_from),
- reply_to: email_with_name(Figaro.env.email_from, Figaro.en... | [UserMailer->[reset_password_instructions->[t,mail],confirm_email_and_reverify->[email,t,mail,request_token],email_deleted->[email_should_receive_nonessential_notifications?,t,mail],doc_auth_desktop_link_to_sp->[t,mail],letter_expired->[email_should_receive_nonessential_notifications?,t,mail],please_reset_password->[t,... | Sends an email to the user with a confirmation token. | This deploy contains the change to the email display name -- we should try to validate this on as many emails as possible to make sure we don't affect our deliverability |
@@ -495,8 +495,8 @@ namespace System.Security.Cryptography
}
finally
{
- Marshal.FreeHGlobal(descPtr);
- Marshal.FreeHGlobal(buffPtr);
+ NativeMemory.Free((void*)(nint)descPtr);
+ NativeMemory.... | [ECCng->[IsMagicValueOfKeyPublic->[IsMagicValueOfKeyPrivate]]] | Imports a key blob. | It would be nice to change the type of the variables to `void*` or other appropriate pointer type to make these back and forth casts unnecessary. These casts do not look good. |
@@ -51,13 +51,17 @@ class ResolveRequirementsTaskBase(Task):
else:
target_set_id = 'no_targets'
+ # We need to ensure that we are resolving for only the current platform if we are
+ # including local python dist targets that have native extensions.
+ maybe_platforms = ['current'] if sel... | [ResolveRequirementsTaskBase->[merge_pexes->[merged_pex]]] | Resolve requirements against this interpreter. Return a PEX object with the path to the file containing the missing requirements. | It's probably better to only set maybe_platforms to `current` if the default configuration has more than one platform and current is in the platform list. |
@@ -1,13 +1,13 @@
from __future__ import unicode_literals
-
from django.core.exceptions import ValidationError
+
from django.db import models
from django.db import transaction
from django.shortcuts import redirect
from django.utils.translation import ugettext_lazy as _
from satchless.process import InvalidData
... | [SummaryStep->[add_to_order->[save],process->[forms_are_valid]],ShippingStep->[add_to_order->[save]],BillingAddressStep->[add_to_order->[save]]] | A step that creates a base object for a single node. Tests if a is valid. | This line is not required here, but it will be nice, to separate `__future__` imports with one blank line, but you've removed it. |
@@ -1,11 +1,13 @@
// Licensed to the .NET Foundation under one or more agreements.
// The .NET Foundation licenses this file to you under the MIT license.
// See the LICENSE file in the project root for more information
+using DotNetNuke.Abstractions;
using DotNetNuke.Abstractions.Portals;
using DotNetNuke.Abstra... | [ConsoleCommand->[NormalizeFlagName->[Trim,Empty,StartsWith,Substring],ParseFlags->[NormalizeFlagName,Add,Empty,IsNullOrEmpty,ToLower,StartsWith,Length],CreateMapping->[property,Add,ForEach],IsValid->[IsNullOrEmpty],ParseParameters->[CanWrite,ForEach,PropertyType,CreateMapping,Name,ContainsKey,DeserializeProperty,Attri... | Creates an abstract class that represents a single system - wide unique identifier. Initialize the object. | This should be private otherwise any object in the `DotNetNuke.Library` has access to this reference |
@@ -38,6 +38,11 @@ public class NativeWorkerContext implements WorkerContext {
return ActorId.fromByteBuffer(nativeGetCurrentActorId(nativeCoreWorkerPointer));
}
+ @Override
+ public boolean getIsDirectCall() {
+ return nativeGetIsDirectCall(nativeCoreWorkerPointer);
+ }
+
@Override
public ClassLo... | [NativeWorkerContext->[getCurrentJobId->[nativeGetCurrentJobId,fromByteBuffer],getCurrentTaskId->[nativeGetCurrentTaskId,fromByteBuffer],getCurrentActorId->[nativeGetCurrentActorId,fromByteBuffer],getCurrentWorkerId->[nativeGetCurrentWorkerId,fromByteBuffer],getCurrentTaskType->[forNumber,nativeGetCurrentTaskType]]] | Returns the current actor id. | It seems that we don't need to expose this method in Java. Because this var will only be passed into c++ `PrepareActorCheckpoint`. So we directly get this variable in C++. |
@@ -489,7 +489,17 @@ class ConanManager(object):
return adapter
+ def search_recipes_all(self, pattern, ignorecase):
+ adapter = ConanProxy(self._client_cache, self._user_io, self._remote_manager, '')
+ references = []
+ for remote in adapter.registry.remotes:
+ result = ... | [_load_deps_info->[get_forbidden_access_object->[InfoObjectNotDefined],get_forbidden_access_object],ConanManager->[info_build_order->[_get_deps_graph],search_packages->[_get_search_adapter],export_alias->[export],install->[_get_graph_builder,get_loader,BuildMode,install,report_matches,_load_install_conanfile,_inject_re... | Return a function that returns a conan adapter for the given search parameters. | Maybe this is not necessary, the Registry could be directly used (accesed from ``self._client_cache``) |
@@ -103,7 +103,14 @@ def set_working_dir():
def add_all_commands(parser):
"""Add all spack subcommands to the parser."""
for cmd in spack.cmd.all_commands():
- parser.add_command(cmd)
+ try:
+ parser.add_command(cmd)
+ except Exception:
+ if spack.config.get('config... | [_profile_wrapper->[_invoke_command],SpackArgumentParser->[format_help_sections->[add_subcommand_group->[add_group],add_all_commands,index_commands,add_group,add_subcommand_group],add_command->[add_subparsers,add_parser],format_help->[format_help_sections]],print_setup_info->[shell_set],main->[_profile_wrapper,setup_ma... | Add all commands to the parser. | Also preferably this would catch a more specific exception. |
@@ -108,6 +108,12 @@ bio_spdk_env_init(void)
opts.env_context = (char *)dpdk_cli_override_opts;
+ rc = bio_set_hotplug_filter(nvme_glb.bd_nvme_conf);
+ if (rc != 0) {
+ D_ERROR("Failed to set hotplug filter, "DF_RC"\n", DP_RC(rc));
+ goto out;
+ }
+
rc = spdk_env_init(&opts);
if (rc != 0) {
rc = -DER_INV... | [No CFG could be retrieved] | Initializes the environment variables and the DAOS environment. Initialize the environment variables and the DAOS thread library. | I think Silong is pushing a patch to initialize spdk (for using hugepages) even without bdev configured, so you'd skip set hotplug filter when bd_nvme_conf isn't specified to avoid potential merge conflicts. |
@@ -17,4 +17,4 @@
"""Apache Beam SDK version information and utilities."""
-__version__ = '2.30.0.dev'
+__version__ = '2.30.0'
| [No CFG could be retrieved] | Apache Beam SDK version information and utilities. | These are not part of testing the sp versions. |
@@ -281,6 +281,8 @@ func (a AssertionHTTP) CollectUrls(v []AssertionURL) []AssertionURL { ret
func (a AssertionHTTPS) CollectUrls(v []AssertionURL) []AssertionURL { return append(v, a) }
func (a AssertionDNS) CollectUrls(v []AssertionURL) []AssertionURL { return append(v, a) }
func (a AssertionF... | [MatchSet->[MatchSet,matchSet],CollectUrls->[CollectUrls],HasOr->[HasOr],NeedsParens->[NeedsParens,HasOr],CheckAndNormalize->[String],ToSocialAssertion->[ToSocialAssertionHelper],HasFactor->[MatchSet],String->[String],ToSocialAssertionHelper->[GetValue,GetKey],GetValue,IsUID,CollectUrls,IsRemote,IsTeamName,IsTeamID,IsF... | CollectUrls returns a slice of all URLs in the assertion. | seems like this should cascade up and infect AND and ORs |
@@ -875,7 +875,10 @@ App.WizardController = Em.Controller.extend(App.LocalStorage, App.ThemesMappingM
var interval = setInterval(function () {
if (miscController.get('dataIsLoaded')) {
if (self.get("content.hdfsUser")) {
- self.set('content.hdfsUser', miscController.get('content.hdfsUser')... | [No CFG could be retrieved] | This function is used to load the user data and the cluster status. filter for a single stack config that is not in the stored configs. | It doesn't extract the actual value of user_group, so it stays hardcoded. When you refresh on Manual commands step sometimes loading goes in a different order and UI uses the default(hardcoded) value of hdfsUser. |
@@ -271,7 +271,6 @@ class CollectiveOptimizer(DistributedOptimizer):
node_num = self._node_num()
assert node_num >= 1, "nccl2 node_num must >= 1, now:{}" % node_num
- self._strategy.fuse_all_reduce_ops = True
exec_strategy = self._strategy.exec_strategy
if node_num <= 1:
| [Collective->[save_inference_model->[save_inference_model],save_persistables->[save_persistables]],CollectiveOpBasedOptimizer->[apply_gradients->[apply_gradients],backward->[backward]],CollectiveOptimizer->[apply_gradients->[apply_gradients],__init__->[DistributedStrategy],_try_to_compile->[_transpile,_node_num],minimi... | Try to compile a single node. Returns a compiled program that builds a single in parallel. | This line of code forces fuse_all_reduce_ops = True, regardless of whether the user has previously set it or not. |
@@ -125,7 +125,10 @@ public abstract class ChannelInitializer<C extends Channel> extends ChannelInbou
// We do so to prevent multiple calls to initChannel(...).
exceptionCaught(ctx, cause);
} finally {
- remove(ctx);
+ ChannelPipeline pipeline... | [ChannelInitializer->[channelRegistered->[initChannel],initChannel->[exceptionCaught,initChannel],remove->[operationComplete->[remove],remove],handlerAdded->[initChannel]]] | Initializes the channel if it is not already initialized. | This is a confusing name now. Call it `removeState` or `clearState`? |
@@ -58,7 +58,8 @@ namespace System.Security.Cryptography.EcDsa.Tests
public abstract partial class ECDsaTests : ECDsaTestsBase
{
[Fact]
- public void KeySizeProp()
+ [SkipOnMono("Android doesn't support getting a curve name from a curve.", TestPlatforms.Android)]
+ public void Ke... | [ECDsaTests->[PublicKey_CannotSign->[SignData]],ECDsaTests_Span->[UseAfterDispose->[UseAfterDispose],VerifyData_InvalidArguments_Throws->[VerifyData],VerifyData->[VerifyData]]] | KeySizeProp - This method checks the key size property of the curve. | Could you please annotate not supported curve name APIs with `UnsupportedOSPlatformAttribute("android")]` |
@@ -316,6 +316,7 @@ static void ffmpeg_source_update(void *data, obs_data_t *settings)
"color_range");
s->buffering_mb = (int)obs_data_get_int(settings, "buffering_mb");
s->is_local_file = is_local_file;
+ s->is_not_seekable = obs_data_get_bool(settings, "not_seekable");
if (s->media_valid) {
mp_media_fr... | [bool->[UNUSED_PARAMETER,obs_data_get_bool,obs_property_set_visible,obs_properties_get],obs_properties_t->[UNUSED_PARAMETER,obs_properties_create,obs_module_text,dstr_cat,dstr_resize,dstr_free,obs_properties_add_list,dstr_replace,dstr_copy,obs_properties_add_bool,obs_property_set_modified_callback,obs_properties_set_fl... | Updates the contents of an ffmpeg source. This function is called from the constructor of the class. It is called by the constructor of. | Style: This line and the line below can be on one line without hitting the 80 column line length limit. |
@@ -148,6 +148,7 @@ def parse_args():
parser_trial_export.add_argument('id', nargs='?', help='the id of experiment')
parser_trial_export.add_argument('--type', '-t', choices=['json', 'csv'], required=True, dest='type', help='target file type')
parser_trial_export.add_argument('--filename', '-f', required... | [parse_args->[add_argument,ArgumentParser,parse_args,set_defaults,add_subparsers,add_parser,func],nni_info->[print,get_distribution,print_error],init,process_startup,parse_args,get] | Parse command line options and return a object. This function is used to parse the command - line arguments and call the appropriate function depending on This function is used to determine the max number of time the trial should be run. | -> is intermediate results included |
@@ -2633,7 +2633,7 @@ if ($action == 'create' && $usercancreate)
$somethingshown = $form->showLinkedObjectBlock($object, $linktoelem, $compatibleImportElementsList);
// Show online payment link
- $useonlinepayment = (!empty($conf->paypal->enabled) || !empty($conf->stripe->enabled) || !empty($conf->paybox->e... | [update_price,create,form_multicurrency_rate,selectInputReason,getLinesArray,getNbOfServicesLines,cloture,getNomUrl,setDeliveryDate,select_incoterms,begin,select_comptes,formInputReason,insert_discount,setProject,add_contact,getOutstandingBills,showOptionals,printOriginLinesList,textwithpicto,fetch_optionals,selectDate... | Print a single object in the multidir output Show direct download link for element with id id. | If we don't use the invoice module, we still should be able to record online payment for order. Test `if !empty($conf->facture->enabled) ` must be done inside the paymentok.php file and is the condition to know if we must auto-create the invoice+payment, or if we must do nothing else. |
@@ -44,11 +44,13 @@ public class EncryptedMapDecoratorTests {
private EncryptedMapDecorator decorator;
+ private CacheManager cacheManager;
+
@Before
public void setUp() throws Exception {
try {
- final Cache cache = new Cache("name", 200, false, false, 100, 100);
- CacheManager.getInstance().addCach... | [EncryptedMapDecoratorTests->[addManyItems->[size,get,assertNull,assertEquals,put],addNullValue->[put,get,assertNull],addNullKeyAndValue->[put,get,assertNull],addAndRemoveItem->[get,assertNull,remove,assertEquals,put],setUp->[getMessage,Cache,EncryptedMapDecorator,EhcacheBackedMap,addCache,fail],tearDown->[removalAll],... | This method is called by the constructor of the class. | Is there a particular reason the test needs to change? Do you just prefer this or is it required to demonstrate the bug you're trying to fix? |
@@ -40,7 +40,15 @@ public class FunctionalTestNotification extends CustomNotification
static
{
- registerAction("event received", EVENT_RECEIVED);
+ //TODO(pablo.kraan): find a better way to manage this situation.
+ try
+ {
+ registerAction("event received", EVENT_RECE... | [FunctionalTestNotification->[getEventContext,registerAction,getPayload,getName]] | This class is used to register a Notification for a specific event. - The reply message. | put your name here |
@@ -416,6 +416,12 @@ dsl_pool_close(dsl_pool_t *dp)
rrw_destroy(&dp->dp_config_rwlock);
mutex_destroy(&dp->dp_lock);
cv_destroy(&dp->dp_spaceavail_cv);
+
+ aggsum_fini(&dp->dp_wrlog_total);
+ for (int i = 0; i < TXG_SIZE; i++) {
+ aggsum_fini(&dp->dp_wrlog_pertxg[i]);
+ }
+
taskq_destroy(dp->dp_unlinked_drain_... | [No CFG could be retrieved] | Destroy all of the objects associated with a managed object. The method for creating the obsolete_bpobj. | How about adding an `ASSERT0` here for the `dp_wrlog_total` and per-txg `dp_wrlog_pertxg[i]` values to ensure the accounting is working as intended. |
@@ -210,8 +210,8 @@ public class FormulaHandler extends BaseHandler {
* @xmlrpc.returntype struct with saved formula data
*/
public Map<String, Object> getSystemFormulaData(User loggedInUser, Integer systemId, String formulaName) {
- FormulaManager manager = FormulaManager.getInstance();
- ... | [FormulaHandler->[getCombinedFormulasByServerId->[getCombinedFormulasByServerId],getSystemFormulaData->[getSystemFormulaData],getGroupFormulaData->[getGroupFormulaData],getFormulasByGroupId->[getFormulasByGroupId]]] | Get the system formula data. | Nitpick: maybe return the result directly. |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.