patch stringlengths 18 160k | callgraph stringlengths 4 179k | summary stringlengths 4 947 | msg stringlengths 6 3.42k |
|---|---|---|---|
@@ -219,6 +219,18 @@ func (f *fleetGateway) execute(ctx context.Context) (*fleetapi.CheckinResponse,
return resp, nil
}
+func (f *fleetGateway) shouldUnroll() bool {
+ return f.unauthCounter >= maxUnauthCounter
+}
+
+func isUnauth(err error) bool {
+ if err == nil {
+ return false
+ }
+
+ return strings.Contains(... | [stop->[Info,Wait,Stop],worker->[Error,stop,doExecute,Errorf,Debugf,WaitTick,Dispatch,Done,Debug],doExecute->[Reset,M,New,Errorf,Err,Wait,URI,execute],Start->[worker,Info,Done,Add],execute->[Error,Execute,New,Events,NewCheckinCmd],NewEqualJitterBackoff,New,NewPeriodicJitter,Unpack] | execute executes a check - in request. | Is it not possible to unwrap the error and check for the specific error type? Would prefer that over string matching. |
@@ -82,16 +82,13 @@ public abstract class AbstractExpressionEvaluator implements BeanFactoryAware, I
}
protected MessageBuilderFactory getMessageBuilderFactory() {
- if (this.messageBuilderFactory == null) {
- this.messageBuilderFactory = new DefaultMessageBuilderFactory();
- }
return this.messageBuilderFa... | [AbstractExpressionEvaluator->[setConversionService->[setConversionService],afterPropertiesSet->[getMessageBuilderFactory],setBeanFactory->[setBeanFactory],evaluateExpression->[evaluateExpression,getEvaluationContext],getEvaluationContext->[getEvaluationContext]]] | This method is invoked after all the bean - factory properties have been set. | Should we move this to `evaluateExpression` ? |
@@ -5,6 +5,9 @@ import unittest
import time
import torch
import torch.nn as nn
+import numpy as np
+import random
+from pytorch_lightning.utilities.seed import seed_everything
from pathlib import Path
| [_load_mnist->[_new_trainer],CGOEngineTest->[test_dedup_input_two_devices->[_build_logical_with_mnist,_reset],test_dedup_input_four_devices->[_build_logical_with_mnist,_reset],_build_logical_with_mnist->[_load_mnist],test_multi_model_trainer_gpu->[_get_final_result,_reset],test_add_model->[_build_logical_with_mnist,_re... | Imports a single node object. Forward computation of the M - 1 and M - 2 network. | Is this required? |
@@ -219,6 +219,17 @@ class BPEHelper(ABC):
agent with which we are syncing the dictionary
"""
+ def add_special_tokens(self, dict_agent, special_tokens: List[str]):
+ """
+ Add special tokens to the tokenizer.
+
+ These tokens are treated as discreet tokens, and prioritiz... | [Gpt2BpeHelper->[helper_encode->[bpe,encode],bpe->[get_pairs],_build_encoder->[encode]],HuggingFaceBpeHelper->[add_special_tokens->[add_special_tokens],helper_encode->[encode],sync_with_dict->[add_special_tokens],helper_decode->[decode]]] | Sync with the dictionary of the BPEs. | nit: discrete ? but i'm also not sure what you're trying to say here |
@@ -63,7 +63,12 @@ public abstract class AbstractQuartzTest {
.hasKind(SpanKind.INTERNAL)
.hasNoParent()
.hasStatus(StatusData.unset())
- .hasAttributes(Attributes.empty()),
+ .ha... | [AbstractQuartzTest->[startScheduler->[configureScheduler]]] | Test successful job. | could use `SemanticAttributes.CODE_NAMESPACE.getKey()` and `SemanticAttributes.CODE_FUNCTION.getKey()` |
@@ -98,7 +98,7 @@ def apply_maxfilter(in_fname, out_fname, origin=None, frame='device',
mv_comp=False, mv_headpos=False, mv_hp=None,
mv_hpistep=None, mv_hpisubt=None, mv_hpicons=True,
linefreq=None, mx_args='', overwrite=True,
- verbose=N... | [apply_maxfilter->[_mxwarn,fit_sphere_to_headshape]] | Apply NeuroMag MaxFilter to raw data. Checks if a node has a reserved head position. command to run maxfilter - f - o - frame - x - y - z - Get the max filter value. | can you put these options before mx_args for consistency? |
@@ -121,6 +121,9 @@ public class GobblinHelixJobLauncher extends AbstractJobLauncher {
this.stateSerDeRunnerThreads = Integer.parseInt(jobProps.getProperty(ParallelRunner.PARALLEL_RUNNER_THREADS_KEY,
Integer.toString(ParallelRunner.DEFAULT_PARALLEL_RUNNER_THREADS)));
+ URI fsUri = URI.create(jobProps... | [GobblinHelixJobLauncher->[getJobLock->[getJobName,getProperty,FileBasedJobLock],addWorkUnit->[persistWorkUnit,newHashMap,Path,getJobId,from,getJobName,getId,put],runWorkUnits->[awaitTerminated,getJobId,submitJobToHelix,stop,deletePersistedWorkUnitsForJob,waitForJobCompletion,format,createJob,info,awaitRunning,getTimin... | Closes the connection and releases any resources associated with a . | what the reason for moving the `FileSystem` creation into this class? |
@@ -239,7 +239,7 @@ static int test_builtin(void)
unsigned char dirt, offset;
nid = curves[n].nid;
- if (nid == NID_ipsec4 || nid == NID_X25519)
+ if (nid == NID_ipsec4)
continue;
/* create new ecdsa key (== EC_KEY) */
if (!TEST_ptr(eckey = EC_KEY_new())
| [int->[EC_KEY_check_key,RAND_set_rand_method,EVP_DigestInit,ECDSA_sign_setup,EC_KEY_generate_key,EC_GROUP_new_by_curve_name,EVP_DigestFinal,EC_GROUP_free,BN_new,TEST_true,TEST_ptr,ECDSA_sign,ERR_clear_error,EC_KEY_set_group,TEST_int_eq,EC_KEY_new,TEST_info,EC_KEY_get0_group,TEST_BN_eq,ECDSA_verify,ECDSA_SIG_get0,EVP_Di... | This method is used to test if a builtin curve is available. EC_KEY_check_key EC_KEY_check_key EC_KEY_ read the raw signature and read the bignums back in from the buffer. check if the last two bytes of raw_buf and modified_buf are in common OPENSSL_free - Frees all curves. | Should NID_ipsec3 get excluded here too? |
@@ -32,15 +32,12 @@ type Project struct {
kapi.TypeMeta
kapi.ObjectMeta
- // TODO: remove me
- DisplayName string
- Spec ProjectSpec
- Status ProjectStatus
+ Spec ProjectSpec
+ Status ProjectStatus
}
type ProjectRequest struct {
kapi.TypeMeta
kapi.ObjectMeta
-
DisplayName string
}
| [No CFG could be retrieved] | type is a helper to retrieve the type meta data for a given type. | I do not understand removing this from a ProjectRequest. Can you add back or elaborate why you thought it should be removed? It's not clear to me since if I request a project, the project's display name is part of that request. |
@@ -31,8 +31,8 @@ class PythonAwsLambdaRuntime(StringField):
value: str
@classmethod
- def compute_value(cls, raw_value: Optional[str], *, address: Address) -> str:
- value = cast(str, super().compute_value(raw_value, address=address))
+ def sanitize_raw_value(cls, raw_value: Optional[str], *, ... | [PythonAwsLambdaRuntime->[to_interpreter_version->[group,match,cast,int],compute_value->[super,cast,match,InvalidFieldException]]] | Compute value from raw_value and check runtime field. | I agree with using the same method for both types of `Field`s. I originally wanted to separate them to emphasize how the two APIs are consumed differently, but that's not worth it. It makes it confusing to navigate between both. I'm not sure which name I prefer, though: `compute_value` vs. `sanitize_raw_value`. I'm con... |
@@ -74,6 +74,7 @@ public final class RayActorImpl<T> implements RayActor<T>, Externalizable {
ret.numForks = 0;
ret.taskCursor = this.taskCursor;
ret.handleId = this.computeNextActorHandleId();
+ newActorHandles.add(ret.handleId.copy());
return ret;
}
| [RayActorImpl->[writeExternal->[writeObject],readExternal->[readObject],computeNextActorHandleId->[getBytes,UniqueId,digest],fork->[computeNextActorHandleId],RayActorImpl]] | Fork actor. | no need to `copy` here, as `UniqueId` is immutable. |
@@ -103,13 +103,13 @@ func NewStore(cfg Config, storeCfg chunk.StoreConfig, schemaCfg chunk.SchemaConf
return stores, nil
}
-func nameToStorage(name string, cfg Config, schemaCfg chunk.SchemaConfig) (chunk.StorageClient, error) {
+// NewIndexClient makes a new index client of the desired type.
+func NewIndexClient... | [RegisterFlags->[DurationVar,RegisterFlagsWithPrefix,RegisterFlags,IntVar],Warn,NewMemcached,Wrap,AddPeriod,NewMemcachedClient,NewDynamoDBTableClient,NewMockStorage,StopOnce,Instrument,New,NewTiered,NewStorageClient,Errorf,NewCompositeStore,NewFifoCache,NewBackground,Log,NewTableClient,Background,NewStorageClientV1,Tri... | nameToStorage returns a storage client for the given name. NewTableClient creates a new table client based on the configuration. | In this commit you have used "ChunkClient" 21 times and "ObjectClient" 48 times. I can't figure out the distinction - if there isn't one then I think it would be better to settle on one term. |
@@ -149,7 +149,7 @@ namespace System.Net.Http
Debug.Assert(longToEncode >= 0);
Debug.Assert(longToEncode <= EightByteLimit);
- if (longToEncode < OneByteLimit)
+ if (longToEncode <= OneByteLimit)
{
if (buffer.Length != 0)
{... | [VariableLengthIntegerHelper->[TryRead->[TryRead],WriteInteger->[TryWrite],GetInteger->[TryRead]]] | TryWrite - writes a byte array into a byte array. | Is this a bug in header encoding? If so, what happens when an integer that is right at the boundary between limits triggers the bug? |
@@ -354,10 +354,9 @@ public class StorageSystemSnapshotStrategy extends SnapshotStrategyBase {
s_logger.error(errMsg);
- throw new CloudRuntimeException(errMsg);
+ throw new CloudRuntimeException("Failed to revert a volume to a snapshot state");
}
- ... | [StorageSystemSnapshotStrategy->[takeSnapshot->[verifyFormat,verifyLocationType,takeSnapshot],backupSnapshot->[backupSnapshot],usingBackendSnapshotFor->[getProperty],cleanupSnapshotOnPrimaryStore->[deleteSnapshot],postSnapshotCreation->[deleteSnapshot],getHostId->[getHostId],getHost->[getHost,getHostId],performSnapshot... | Revert a snapshot to a snapshot state. This method is called when the volume is not available in the hypervisor. | This seems like a very generic message. Can't we add something like the volume name? |
@@ -2056,7 +2056,11 @@ bool Planner::_populate_block(block_t * const block, bool split_move,
#if ENABLED(LIN_ADVANCE)
#if ENABLED(JUNCTION_DEVIATION)
- #define MAX_E_JERK (max_e_jerk_factor * max_acceleration_mm_per_s2[_EINDEX])
+ #if ENABLED(DISTINCT_E_FACTORS)
+ #define MAX_E_JERK... | [No CFG could be retrieved] | \ Function to compute acceleration and acceleration values. VANCE for blocks with all of these conditions. | This cannot be changed, because `_EINDEX` relies on the `extruder` parameter passed to `_populate_block`. We cannot use `active_extruder`, which could very well have been changed before this function was called. |
@@ -2738,7 +2738,7 @@ bulk_update_transfer_done_aux(const struct crt_bulk_cb_info *info)
&cb_info->buc_iv_value,
cb_info->buc_user_priv);
output->rc = rc;
- rc = crt_reply_send(info->bci_bulk_desc->bd_rpc);
+ crt_reply_send(info->bci_bulk_desc->bd_rpc);
RPC_PUB_DECREF(info->bci_bulk_desc->bd_rpc);... | [No CFG could be retrieved] | This function is called when the user has requested to update the value of the key. on put - callback for bulk update - callback for bulk update - callback for bulk update -. | This isn't right, crt_reply_send can return an error so it should be checked/handled. |
@@ -14,9 +14,15 @@
package statistics
import (
+ "fmt"
+
"github.com/montanaflynn/stats"
)
+func storeTag(id uint64) string {
+ return fmt.Sprintf("store-%d", id)
+}
+
// RollingStats provides rolling statistics with specified window size.
// There are window size records for calculating.
type RollingStats ... | [Median->[Median]] | NewRollingStats returns a RollingStats object with the median of the window size records. | This function also can be used somewhere else. |
@@ -694,7 +694,8 @@ void coco_state::poll_joystick(bool *joyin, uint8_t *buttons)
{
/* conventional joystick */
joyval = analog->input(joystick, joystick_axis);
- joyin_value = (dac_output() <= (joyval >> 2));
+ float joyval_f = joyval / 10.0;
+ joyin_value = (dac_output() <= joyval_f);
}
... | [ff60_read->[current_vhd,floating_space_read],poll_joystick->[joystick_type,is_joystick_hires],update_prinout->[joystick_type,diecom_lightgun_clock],pia1_pa_changed->[poll_keyboard,update_sound,update_prinout,update_cassout], poll_keyboard->[poll_keyboard],ff60_write->[floating_space_write,current_vhd],poll_hires_joyst... | poll a joystick DCLG state machine. | This doesn't make much sense - why convert to a `double` (10.0 is a `double` literal), then convert to a `float`, only to compare to a `uint8_t`? |
@@ -6,10 +6,12 @@
namespace UnifiedRegex
{
+ const int CharTrie::initCapacity;
+
// ----------------------------------------------------------------------
// CharTrie
// ----------------------------------------------------------------------
- __inline bool CharTrie::Find(Char c, int& outi)
+ ... | [No CFG could be retrieved] | - - - - - - - - - - - - - - - - - - sizeof - free - char trie entry. | Header file has 'static const int initCapacity = 4`. It works by init in header file and not here? |
@@ -238,12 +238,9 @@ int run_test(int argc, ACE_TCHAR *argv[], Args& my_args)
int ACE_TMAIN(int argc, ACE_TCHAR *argv[])
{
Args my_args;
-
- int result = run_test(argc, argv, my_args);
- if (result == my_args.expected_result_) {
- return 0;
- } else {
+ if (run_test(argc, argv, my_args) != my_args.expected_... | [No CFG could be retrieved] | Main entry point for ACE_T. | I think I originally expected to have the Perl script be more aware of the returned error codes for determining where the errors occurred (compiling lists of error locations for multiple scenarios), but after adding the "expected value" stuff in order to check for expected / required failures, it became moot since the ... |
@@ -35,7 +35,6 @@ function writeFiles() {
this.copy('gitignore', '.gitignore');
this.copy('gitattributes', '.gitattributes');
this.copy('editorconfig', '.editorconfig');
- this.template('_travis.yml', '.travis.yml', this, {});
this.template('_Jenkinsfile', ... | [No CFG could be retrieved] | Create a list of files that can be written to the server. Missing package - level variables. | Shouldn't _Jenkinsfile be removed from main generator and from here then also? If yes then also remove from expected test files. |
@@ -262,8 +262,8 @@ func resourceComputeInstanceTemplate() *schema.Resource {
"automatic_restart": &schema.Schema{
Type: schema.TypeBool,
Optional: true,
- Default: true,
ForceNew: true,
+ Computed: true,
},
"on_host_maintenance": &schema.Schema{
| [Set,Sprintf,GetOk,Do,UniqueId,PrefixedUniqueId,Id,Insert,Errorf,Delete,SetId,Get,Split,Bool] | A schema that is used to allow access to a resource s neccessary components. returns a schema. Resource that is used to populate a resource with a sequence number of. | If you set this field to Computed, it means a user cannot specify a value for `automatic_restart`. GCP default value for this field is true. It means a user could never create an instance with terraform with `automatic_restart = false`. I am confused about why that would be something desirable. Am I missing something? |
@@ -9,7 +9,8 @@ Tester.RunTestCases("TestSystemVectorAssembly")
Tester.RunTestCases("TestCSRConstruction")
Tester.RunTestCases("TestSpMV")
-
+Tester.RunTestCases("TestSystemVectorOperations")
+Tester.RunTestCases("TestToAMGCLMatrix")
#Tester.RunTestCases("TestPerformanceBenchmarkSparseGraph")
#Tester.RunTestCas... | [SetVerbosity,RunTestCases] | Run all tests for a given sequence number. | please remove this file, it should not be in master |
@@ -148,7 +148,7 @@ export class AmpState extends AMP.BaseElement {
return;
}
const id = user().assert(this.element.id, '<amp-state> must have an id.');
- const state = Object.create(null);
+ const state = /** @type {!JsonObject} */ (map());
state[id] = json;
Services.bindForDocOrNull(t... | [No CFG could be retrieved] | Fetches the src tag and updates the state of the tag. | `dict()` (it returns `{!JsonObject}`) |
@@ -1478,7 +1478,7 @@ function admin_page_site(App $a)
'$community_page_style' => ['community_page_style', L10n::t("Community pages for visitors"), Config::get('system','community_page_style'), L10n::t("Which community pages should be available for visitors. Local users always see both pages."), $community_page_styl... | [admin_page_summary->[get_baseurl],admin_page_users_post->[getMessage],admin_page_site_post->[set_baseurl,get_path],admin_page_site->[get_hostname,get_path],admin_page_users->[set_pager_itemspage,set_pager_total],admin_page_contactblock->[set_pager_itemspage,set_pager_total]] | Admin page site Get all user names that are allowed to install a personal install of X Returns a string with the administration section Returns a list of all possible configuration options. Config values for the menu. | Writing this down before reaching the end of the diff... so ignore if you already had done so ;-) You may regenerate the master messages.po file for the translation pipe to pick up the changes. |
@@ -685,14 +685,15 @@ func (txm *EthTxManager) handleSafe(
}
func (txm *EthTxManager) BumpGasByIncrement(originalGasPrice *big.Int) *big.Int {
- return BumpGas(txm.config, originalGasPrice)
+ gasPrice, _ := BumpGas(txm.config, originalGasPrice)
+ return gasPrice
}
// BumpGas computes the next gas price to attem... | [handleSafe->[String],createAttempt->[newTx],bumpGas->[BumpGasByIncrement],processAttempt->[String,CheckAttempt],updateLastSafeNonce->[updateLastSafeNonce],sendInitialTx->[CreateTx,getCurrentHead],nextAccount->[Connected],checkChainForConfirmation->[getCurrentHead],String] | BumpGasByIncrement increments the gas of the transaction by the given amount. | Should this error be logged! |
@@ -264,13 +264,16 @@ class GradeEntryFormsController < ApplicationController
id: 'total_marks',
content: t('grade_entry_forms.grades.total') \
+ ' ' + grade_entry_form.out_of_total.to_s,
+ sortable: true,
+ compare: "compare_gradebox"
}
end
... | [GradeEntryFormsController->[new->[new],create->[new]]] | get mark columns in JSON format. | Prefer single-quoted strings when you don't need string interpolation or special symbols. |
@@ -168,6 +168,12 @@ void GenericAgentDiscoverContext(EvalContext *ctx, GenericAgentConfig *config)
WritePolicyServerFile(GetWorkDir(), config->agent_specific.agent.bootstrap_policy_server);
SetPolicyServer(ctx, config->agent_specific.agent.bootstrap_policy_server);
+
+ if (am_policy_server) ... | [No CFG could be retrieved] | - - - - - - - - - - - - - - - - - - Check if the agent is bootstrapped and if so add the necessary class to the context. | Shouldn't this also be checking for an enterprise class ? As it is, unless I'm missing something, we'll spam all community users' policy servers, when verbose, with the message about HA not being available, when they never asked for it. |
@@ -0,0 +1,7 @@
+class Config < ApplicationRecord
+ # This class exists to take advantage of Rolify for limiting authorization
+ # on internal reports.
+ # NOTE: It is not backed by a database table and should not be expected to
+ # function like a traditional Rails model
+ resourcify
+end
| [No CFG could be retrieved] | No Summary Found. | @jacobherrington would it make sense to move these in an `models/internal` namespace/folder? |
@@ -49,6 +49,7 @@ func HandleTimeCache(req *http.Request, w http.ResponseWriter, fi os.FileInfo) (
func HandleEtagCache(req *http.Request, w http.ResponseWriter, fi os.FileInfo) (handled bool) {
etag := generateETag(fi)
if req.Header.Get("If-None-Match") == etag {
+ w.Header().Set("ETag", etag)
w.WriteHeader(h... | [ModTime,Header,Size,Unix,Format,Sprint,Seconds,FormatInt,Name,IsProd,UTC,Parse,Get,EncodeToString,Set,WriteHeader] | HandleEtagCache handles ETag - based caching for a HTTP request. | `Etag` is already set 5 lines below for non-matching requests. What is the benefit of echoing the same Etag back to the client that was already sent? |
@@ -140,4 +140,15 @@ public class GrowableOffsetRangeTracker extends OffsetRangeTracker {
totalWork.subtract(workRemaining, MathContext.DECIMAL128).doubleValue(),
workRemaining.doubleValue());
}
+
+ @Override
+ public RestrictionBoundness isBounded() {
+ // If current range has been done, the ... | [GrowableOffsetRangeTracker->[trySplit->[trySplit],getProgress->[estimate,getProgress]]] | Override to provide progress. | Note that for any restriction that is done, it won't matter if we return bounded or unbounded since processing them to completion should be a no-op. I would drop this logic and only keep the `range.getTo() == Long.MAX_VALUE` you have below. |
@@ -1899,8 +1899,8 @@ dc_tx_restart(tse_task_t *task)
D_GOTO(out_task, rc = -DER_NO_HDL);
D_MUTEX_LOCK(&tx->tx_lock);
- if (tx->tx_status != TX_OPEN && tx->tx_status != TX_FAILED) {
- D_ERROR("Can't restart non-open/non-failed state TX (%d)\n",
+ if (tx->tx_status != TX_FAILED) {
+ D_ERROR("Can't restart non-f... | [No CFG could be retrieved] | \ n Returns number of errors - 1 - 5 - 11 t - > leader_dtrg_idx - > leader_dtrg_ - - - - - - - - - - - - - - - - - -. | If the application want to restart the TX based on some conditional operation result, how to process? have to re-open the transaction? That seems inconvenient. |
@@ -65,6 +65,7 @@ class CpasbienProvider(TorrentProvider):
for result in torrent_rows:
try:
title = result.find(class_="titre").get_text(strip=True).replace("HDTV", "HDTV x264-CPasBien")
+ title = re.sub(r'\ Saison', '... | [CpasbienProvider->[__init__->[__init__]],CpasbienProvider] | Search for torrents with a given search string. Get the items with seeders and leechers if available. | The backslash is wrong, and is this really necessary? |
@@ -62,7 +62,7 @@ def context(request, **kw):
return ctx
-@addons_reviewer_required
+@any_reviewer_required
def eventlog(request):
form = forms.EventLogForm(request.GET)
eventlog = ActivityLog.objects.reviewer_events()
| [beta_signed_log->[context],leaderboard->[context],performance->[_sum,context],review->[_get_comments_for_hard_deleted_versions,context],queue_auto_approved->[_queue],_reviewer_progress->[pct],abuse_reports->[context],_queue->[is_admin_reviewer,exclude_admin_only_addons,context],context->[base_context],queue_content_re... | Show a list of all eventlogs for the user. | This will expose the add-on review log to users who don't have access to view the review pages. |
@@ -75,9 +75,9 @@ class CalleeInfo extends Component<Props, State> {
_onLargeVideoAvatarVisible: Function;
- _playAudioInterval: ?number;
+ _playAudioInterval: *;
- _ringingTimeout: ?number
+ _ringingTimeout: *;
_setAudio: Function;
| [No CFG could be retrieved] | Provides a base class for the given object. Adds event listener to handle the timeout of a given component. | `?InternvalID` works for me here (declared in flow core) |
@@ -1,8 +1,8 @@
package aQute.bnd.cdi;
+import java.io.InputStream;
import java.util.ArrayList;
import java.util.Arrays;
-import java.util.Collection;
import java.util.EnumSet;
import java.util.List;
import java.util.Map;
| [CDIAnnotations->[parse->[add,substring,remove,startsWith,valueOf],analyzeJar->[getValue,size,matches,addAll,updateHeader,allOf,containsKey,toStringList,getFQN,getProperty,getKey,noneOf,isEmpty,values,error,sort,parse,addServiceCapability,isNegated,parseHeader,getDefinition,entrySet,MergedRequirement,get,addExtenderReq... | Implements the CDI annotation interface. Returns a list of all classes that provide or requires the given analyzer. | You can move `dbf` to be a local var in the static initialized since you don't need it any more after the static initializer completes. Best to let it be GC'd. |
@@ -256,8 +256,14 @@ if (defined('SHOW_SETTINGS')) {
}
if (($mode == 1 || $mode == 2) && ($config['show_services'] != 0)) {
- $service_query = 'select `S`.`service_type`, `S`.`service_id`, `S`.`service_desc`, `S`.`service_status`, `D`.`hostname`, `D`.`sysName`, `D`.`device_id`, `D`.`os`, `D`.`icon` f... | [No CFG could be retrieved] | Displays a list of available devices. This function returns a tag that represents the availability map service. | You can change this to `if (is_normal_user() === false) {` rather than using sessions direct. |
@@ -12,7 +12,14 @@ Bokeh.Collections.register_models({
var websocket_url = null;
{%- endif %}
+{% if comms_target -%}
+ var comms_target = "{{ comms_target }}";
+{%- else %}
+ var comms_target = null;
+{%- endif %}
+
+
var docs_json = {{ docs_json }};
var render_items = {{ render_items }};
-Bokeh.embed.embe... | [No CFG could be retrieved] | embed the items in the docs_json. | Might be nice to call this notebook_comms_target or somehow be clear it's for the notebook case. |
@@ -1107,7 +1107,8 @@ def concat(values, axis, name="concat"):
Args:
values: A list of `Tensor` objects or a single `Tensor`.
axis: 0-D `int32` `Tensor`. Dimension along which to concatenate. Must be
- in the range `[-rank(values), rank(values))`.
+ in the range `[-rank(values), rank(values))`. ... | [identity->[identity],reverse_sequence->[reverse_sequence],boolean_mask->[_apply_mask_1d,shape,concat],rank_internal->[size,rank],_SliceHelperVar->[_slice_helper],sparse_placeholder->[_normalize_sparse_shape,placeholder],quantize->[quantize_v2],gather->[gather],transpose->[rank],ones_like->[shape_internal],_get_dtype_f... | Concatenates tensors along one dimension. Concatenate values into a single tensor. | I would reword this to emphasize that this is the same as indexing in Python. |
@@ -53,6 +53,16 @@ async def find_changed_owners(request: ChangedRequest) -> ChangedAddresses:
return ChangedAddresses(dependees_with_roots)
+class ChangedFiles(Collection[str]):
+ pass
+
+
+@dataclass(frozen=True)
+class ChangedFilesRequest:
+ options: 'ChangedOptions'
+ git: Git
+
+
@dataclass(froz... | [ChangedOptions->[changed_files->[changed_files]],find_changed_owners->[ChangedAddresses]] | Creates a ChangedOptions object from the given options. Create a new object that represents the options of a node. | Nit: if you move this below `ChangedOptions`, you can remove the quotes, and the dataclass definitions will also be closer to the rule where they're directly used. |
@@ -7917,7 +7917,8 @@ var _examplesQuickstartsDancerMysqlPersistentJson = []byte(`{
},
"message": "The following service(s) have been created in your project: ${NAME}, ${DATABASE_SERVICE_NAME}.\n\nFor more information about using this template, including OpenShift considerations, see https://github.com/openshift/... | [FileMode,ModTime,Dir,Unix,Error,WriteFile,Join,Chtimes,Replace,Errorf,Split,MkdirAll,Mode] | ExamplesQuickstartsDancerMysqlPersistentJson returns a JSON object that represents a Dan Missing required fields. | The app label should be parameterized so that when templates are used in conjunction to form a single application we can make the `app` labels match. |
@@ -103,13 +103,15 @@ public class DruidSchema extends AbstractSchema
// For awaitInitialization.
private final CountDownLatch initialized = new CountDownLatch(1);
- // Protects access to segmentSignatures, mutableSegments, segmentsNeedingRefresh, lastRefresh, isServerViewInitialized
+ // Protects access to s... | [DruidSchema->[getFunctionMultimap->[build,put,entrySet,builder],timelineInitialized->[notifyAll],start->[run->[notifyAll,max,equals,refreshSegments,getRowSignature,addAll,warn,info,put,countDown,add,emit,isInterrupted,getDataSource,isEmpty,getMillis,buildDruidTable,debug,difference,wait,currentTimeMillis,isAfterNow,fo... | Creates a new instance of the DruidSchema class. | nit: please add a space after `//`. |
@@ -2,6 +2,7 @@ from __future__ import absolute_import
import logging
import operator
+import errno
import os
import shutil
import tempfile
| [InstallCommand->[__init__->[only_binary,no_deps,make_option_group,progress_bar,ignore_requires_python,no_clean,global_options,install_options,constraints,add_option,require_hashes,requirements,super,insert_option_group,build_dir,editable,src,pre,no_binary],run->[populate_requirement_set,any,attrgetter,mkdtemp,ensure_d... | Creates a command that installs a single package. Adds options for the command. | Let's try to keep the imports alphabetically sorted |
@@ -619,7 +619,7 @@ public final class HttpConversionUtil {
translations = request ? REQUEST_HEADER_TRANSLATIONS : RESPONSE_HEADER_TRANSLATIONS;
}
- public void translateHeaders(Iterable<Entry<CharSequence, CharSequence>> inputHeaders) throws Http2Exception {
+ private void transla... | [HttpConversionUtil->[Http2ToHttpHeaderTranslator->[text],toHttpResponse->[parseStatus],addHttp2ToHttpHeaders->[addHttp2ToHttpHeaders,text],setHttp2Scheme->[text],toFullHttpResponse->[parseStatus],toHttp2Headers->[toHttp2HeadersFilterTE,toLowercaseMap,toHttp2Headers]]] | Translates the given HTTP headers into HTTP headers. | actually this should be package-private imho |
@@ -1168,6 +1168,18 @@ public class ExpressionInterpreter
return new SubscriptExpression(toExpression(base, type(node.getBase())), toExpression(index, type(node.getIndex())));
}
+ // Subscript on Row hasn't got a dedicated operator. It is interpreted by hand.
+ if (... | [ExpressionInterpreter->[expressionOptimizer->[ExpressionInterpreter],Visitor->[visitFunctionCall->[type],visitSubscriptExpression->[type],visitLikePredicate->[type],visitLogicalBinaryExpression->[type],toExpressions->[toExpressions],visitLiteral->[evaluate],visitCurrentUser->[visitFunctionCall],visitCoalesceExpression... | Visit a SubscriptExpression. | Are there any tests that hit this path? |
@@ -1955,10 +1955,11 @@ MSG_PROCESS_RETURN tls_process_key_exchange(SSL *s, PACKET *pkt)
SSLerr(SSL_F_TLS_PROCESS_KEY_EXCHANGE, ERR_R_EVP_LIB);
goto err;
}
- if (ispss) {
+ if (SSL_USE_PSS(s)) {
if (EVP_PKEY_CTX_set_rsa_padding(pctx, RSA_PKCS1_PSS_PADDING) <... | [No CFG could be retrieved] | The following functions are used to determine if a packet is part of a client - wide handshake Figure out if the message is a client HELLO message. | Since you changed indentation for this kind of continuation line elsewhere, you might as well do it here too ;-) |
@@ -82,6 +82,7 @@ class LSUN(VisionDataset):
# for each class, create an LSUNClassDataset
self.dbs = []
for c in self.classes:
+ self._download(c)
self.dbs.append(LSUNClass(
root=root + '/' + c + '_lmdb',
transform=transform))
| [LSUNClass->[__getitem__->[write,get,target_transform,BytesIO,begin,seek,open,transform],__init__->[dump,isfile,begin,super,join,cursor,open,stat,load]],LSUN->[_verify_classes->[list,split,type,verify_str_arg,cast,iterable_to_str,ValueError,isinstance,format,join],__getitem__->[target_transform],extra_repr->[format],__... | Initialize LSUN object with a single base - class hierarchy. | The download should be optional. Other datasets have a `download=True` flag in the constructor that indicates whether the download should happen or not. |
@@ -0,0 +1,14 @@
+# -------------------------------------------------------------------------
+# Copyright (c) Microsoft Corporation. All rights reserved.
+# Licensed under the MIT License. See License.txt in the project root for
+# license information.
+# ---------------------------------------------------------------... | [No CFG could be retrieved] | No Summary Found. | We don't need to expose `ItemPaged` here - users are unlikely to need this type, and if they do they can import it from azure-core directly. |
@@ -506,7 +506,7 @@ class Protocol < ActiveRecord::Base
name: new_name,
protocol_type: new_protocol_type,
added_by: current_user,
- organization: self.organization
+ team: self.team
)
if clone.in_repository_public?
clone.published_on = Time.now
| [Protocol->[deep_clone->[clone_contents],destroy_contents->[space_taken],clone_contents->[deep_clone_assets],space_taken->[space_taken],in_repository?->[in_repository_active?],load_from_repository->[clone_contents],update_parent->[clone_contents],update_from_parent->[clone_contents],deep_clone_my_module->[new_blank_for... | Copy a protocol from current node to repository. | Redundant self detected. |
@@ -46,7 +46,7 @@ describe('JHipster generator languages', function () {
.inTmpDir(function (dir) {
fse.copySync(path.join(__dirname, '../test/templates/default'), dir);
})
- .withOptions({'skip-wiredep': true})
+ .... | [value,const,describe,on,fileContent,file,replace,beforeEach,function,var,constants,forEach,noFile,it,require,name] | Creates expected language files This function is called from the main i18n client. | @sendilkumarn no need to change this, let it be `skip-wiredep` |
@@ -962,6 +962,9 @@ class MessageBuilder:
self.fail("{} becomes {} due to an unfollowed import".format(prefix, self.format(typ)),
ctx)
+ def need_annotation_for_var(self, node: SymbolNode, context: Context) -> None:
+ self.fail("Need type annotation for \'{}\'".format(node.name()... | [for_function->[callable_name,format],format_key_list->[format],append_invariance_notes->[format],make_inferred_type_note->[format],callable_name->[format],temp_message_builder->[MessageBuilder],pretty_or->[format],MessageBuilder->[undefined_in_superclass->[format,fail],report_non_method_protocol->[note,fail],redundant... | Check that a typed dict type is missing or missing. | You don't need to escape quotes here. |
@@ -60,11 +60,11 @@ public class VarianceAggregatorCollector
}
public static final Comparator<VarianceAggregatorCollector> COMPARATOR = (o1, o2) -> {
- int compare = Longs.compare(o1.count, o2.count);
+ int compare = Doubles.compare(o1.nvariance, o2.nvariance);
if (compare == 0) {
- compare = Do... | [VarianceAggregatorCollector->[from->[VarianceAggregatorCollector],combineValues->[fold]]] | Algorithms for computing the sample variance. private static final int MAX_INTERMEDIATE_SIZE = 8 ;. | Will this sort the same way as `getVariance(isVariancePop)` in `finalizeComputation`? |
@@ -79,4 +79,17 @@ public class EsUtils {
}
return null;
}
+
+ public static void setShards(NewIndex index, Settings settings) {
+ boolean clusterMode = settings.getBoolean(ProcessProperties.CLUSTER_ACTIVATE);
+ if (clusterMode) {
+ index.getSettings().put(IndexMetaData.SETTING_NUMBER_OF_SHARDS... | [EsUtils->[formatDateTime->[print,getTime],termsKeys->[apply->[getKey],getBuckets,transform],termsToMap->[getDocCount,getBuckets,put,getKey],parseDateTime->[toDate],convertToDocs->[add,getSource,getHits,apply]]] | Format a date time if it is not null. | I don't think this should be extracted in "yet another util method". Why not moving it to NewIndex ? |
@@ -188,5 +188,10 @@ func (r *Runtime) Shutdown(force bool) error {
r.valid = false
_, err := r.store.Shutdown(force)
- return err
+ if err != nil {
+ return err
+ }
+
+ // TODO: Should always call this even if store.Shutdown failed
+ return r.state.Close()
}
| [Shutdown->[Shutdown,Lock,Unlock],GetConfig->[Copy,RUnlock,To,RLock],Copy,Wrapf,GetStore,SetStore,Shutdown,To,Errorf,MkdirAll,IsExist] | Shutdown shuts down the runtime. | Why not defer it? |
@@ -828,5 +828,12 @@ describes.fakeWin('AmpSubscriptions', {amp: true}, env => {
return expect(subscriptionService.getAuthdataField('data.other'))
.to.eventually.be.undefined;
});
+
+ it('should return a null encryptedDocumentKey', () => {
+ sandbox.stub(subscriptionService.serviceAdapter... | [No CFG could be retrieved] | Checks that the other authdata field is present. | Does this test do anything? |
@@ -24,6 +24,14 @@
namespace Kratos
{
+void AuxiliarModelPartUtilities::CopySubModelPartStructure(const ModelPart& rModelPartToCopy)
+{
+ AuxiliarCopySubModelPartStructure(mrModelPart, rModelPartToCopy);
+}
+
+/***********************************************************************************/
+/***************... | [RemoveElementAndBelongings->[RemoveElementAndBelongings],RemoveConditionAndBelongings->[RemoveConditionAndBelongings],RemoveConditionsAndBelongingsFromAllLevels->[RemoveConditionsAndBelongings],RemoveConditionAndBelongingsFromAllLevels->[RemoveConditionAndBelongings,RemoveConditionAndBelongingsFromAllLevels],RemoveEle... | RecursiveEnsureModelPartOwnsProperties - recursively checks whether all submodelparts of this model. | I think in this case the `AuxiliarCopySubModelPartStructure` with two arguments is a more clear interface than the `CopySubModelPartStructure` At least I would expose both! |
@@ -963,6 +963,15 @@ public final class ExtensionLoader {
return chainConfig;
}
+ protected static List<Method> getMethods(Class<?> clazz) {
+ List<Method> declaredMethods = new ArrayList<>();
+ if (!clazz.getName().equals(Object.class.getName())) {
+ declaredMethods.addAll(g... | [ExtensionLoader->[loadStepsFrom->[isRecorder,loadStepsFrom]]] | Loads all build steps from the given class. Determines the best match for the given type. private int consumerOrder = 0 ; Determines if a build - and - run - time configuration can be consumed. Method to consume multi - consumer and produce buildItem. | Generally I prefer to split those sort of methods in two, with one taking a mutable `List` result parameter to avoid creating one collection per class just to throw it away in `addAll`. Also, won't this behaviour change impact other users? |
@@ -59,11 +59,8 @@ async def create_python_binary(fields: PythonBinaryFields) -> CreatedBinary:
if fields.entry_point.value is not None:
entry_point = fields.entry_point.value
else:
- # TODO: rework determine_source_files.py to work with the Target API. It should take the
- # Sources A... | [convert_python_binary_target->[hydrated_struct_to_target,python_targets,create],rules->[UnionRule],create_python_binary->[Addresses,CreatedBinary,CreatePexFromTargetClosure,len,translate_source_path_to_py_module_specifier,StripSnapshotRequest],PythonBinaryFields->[create->[cls,get],is_valid_target->[has_fields]],datac... | Create a binary from a target closure. | The followup queued up for after this PR will replace this to use `await Get[SourceFiles](AllSourceFilesRequest([fields.sources], strip_source_roots=True)`. |
@@ -223,10 +223,13 @@ function yst_updateTitle(force) {
var placeholder_title = divHtml.html(title).text();
titleElm.attr('placeholder', placeholder_title);
+ // Run possibly set filters
+ title = wpseo_apply_filter( title, 'title');
+
title = yst_clean(title);
// and now the snippet preview title
- ... | [No CFG could be retrieved] | yst_updateTitle - update the title and description of the metabox Get the meta description of a metabox. | @andizer For the description you have created `sanitize_desc`. Why wouldn't you do the same for the title? |
@@ -456,7 +456,7 @@ public class DoFnOperator<InputT, OutputT>
}
private void setPushedBackWatermark(long watermark) {
- pushedBackWatermark = Optional.fromNullable(watermark);
+ pushedBackWatermark = watermark;
}
@Override
| [DoFnOperator->[processElement2->[setPushedBackWatermark],processElement1->[setPushedBackWatermark,checkInitPushedBackWatermark],snapshotState->[close,invokeFinishBundle],TaggedKvCoder->[decode->[decode],verifyDeterministic->[verifyDeterministic],encode->[encode]],restoreKeyGroupState->[restoreKeyGroupState],processEle... | This method is called when a stream element is pushed back. | Maybe remove this one too given that nothing is done too. |
@@ -43,10 +43,15 @@ export function initAnalytics({ getState }: { getState: Function }) {
const state = getState();
const config = state['features/base/config'];
- const { analyticsScriptUrls, deploymentInfo, googleAnalyticsTrackingId }
- = config;
+ const {
+ amplitudeAPPKey,
+ a... | [No CFG could be retrieved] | Initializes the JitsiMeetJS. analytics object by sending the specified event to the Adds the permanent properties to the window. config. deploymentInfo object and sets the handlers. | Can we put this in some `analytics` key instead of all of them at the top level? |
@@ -385,6 +385,10 @@ namespace Kratos
class_< ResidualBasedBlockBuilderAndSolverType, typename ResidualBasedBlockBuilderAndSolverType::Pointer,BuilderAndSolverType>(m,"ResidualBasedBlockBuilderAndSolver")
.def(init< LinearSolverType::Pointer > ());
+ typedef ResidualBasedBlockBuil... | [UnaliasedAdd->[UnaliasedAdd],Dot->[Dot],CreateEmptyMatrixPointer->[CreateEmptyMatrixPointer],CreateEmptyVectorPointer->[CreateEmptyVectorPointer],TransposeMult->[TransposeMult],ScaleAndAdd->[ScaleAndAdd],Mult->[Mult],TwoNorm->[TwoNorm]] | Adds strategies to Python module. Defines methods for the base scheme type. The base class for all of the types of objects in the system. Creates a private object that represents a sequence of objects that can be built and solved by Define all of the built - in objects in the order they are defined in the grammar. | You don't need `typename`. This keeps getting copied around. |
@@ -857,6 +857,10 @@ func NewContext() {
SuccessfulTokensCacheSize = sec.Key("SUCCESSFUL_TOKENS_CACHE_SIZE").MustInt(20)
InternalToken = loadInternalToken(sec)
+ if InstallLock && InternalToken == "" {
+ // if Gitea has been installed but the InternalToken hasn't been generated (upgrade from an old release), we ... | [IsFile,LastIndex,Dir,SetValue,Warn,Critical,TrimRight,Perm,RequestURI,MustBool,Close,JoinHostPort,Hostname,TempDir,MustInt,LookupEnv,Info,WriteFile,Mode,Strings,MapTo,Error,Clean,Append,Stat,Format,URLJoin,Marshal,Empty,ParseAuthorizedKey,New,SaveTo,Trace,LookPath,TrimSpace,IsAbs,Key,NewInternalToken,Create,Join,NewLo... | Reads configuration data from the configuration file. PasswordComplexity returns a list of strings that are used to generate a unique identifier for. | How about put all logic here? |
@@ -2696,8 +2696,9 @@ class SemanticAnalyzer(NodeVisitor):
# one type checker run. If we reported errors here,
# the build would terminate after semantic analysis
# and we wouldn't be able to report any type errors.
- full_name = '%s.%s' % (file.fullname... | [SemanticAnalyzer->[analyze_comp_for->[analyze_lvalue],build_newtype_typeinfo->[named_type],check_classvar->[is_self_member_ref],build_typeddict_typeinfo->[basic_new_typeinfo,str_type,object_type,named_type_or_none],visit_for_stmt->[fail_invalid_classvar,anal_type,is_classvar,store_declared_types,visit_block,visit_bloc... | Visit a MemberExpr and find a ckey. If bar is a module or a type and it is a type alias it is handled by. | Why did you add three ``# type: ignore``s in this file? Are you trying to self check mypy with ``--strct-optional``? If yes, then I think you should not put them here in this PR. |
@@ -283,7 +283,8 @@ def execute_config(args, parser):
if key not in sequence_parameters:
from ..exceptions import CondaValueError
raise CondaValueError("Key '%s' is not a known sequence parameter." % key)
- if not isinstance(rc_config.get(key, []), list):
+ ... | [execute_config->[describe_all_parameters,format_dict,parameter_description_builder],describe_all_parameters->[parameter_description_builder]] | Execute the command line interface for the command. Get a list of all possible configuration parameters. arc - get a from the config file. add is the base function for parsing the yaml file. Add or remove a key - value pair to the condarc config file. | You can change `str_type` to `string_types` here. `string_types` is already imported from `conda.common.compat` and does the same thing. |
@@ -57,6 +57,12 @@ module View
children.concat(render_buttons)
children.concat(render_failed_merge) if @current_actions.include?('failed_merge')
+ children << render_bidbox(@game.bidbox_minors) if @current_actions.include?('bidbox_minors') &&
+ @game.respond_to?(:bidbox_priva... | [Stock->[render_buy_tokens->[h,new,include?,process_action,lambda],render_player_companies->[h,render_sell_input,map],render_pre_ipo->[h,empty?,ipo_type,include?,compact!],render_merge_button->[call,h,new,owner,check_consent,process_action,store,lambda,merge_action],render_subsidiaries->[h,include?,map],render->[mergea... | Renders a node with a that can be used to show a menu item. Returns the last NK node that can be found in the game. | Why do these need to be actions? Isn't the action always bid? |
@@ -276,11 +276,12 @@ public final class LibvirtMigrateCommandWrapper extends CommandWrapper<MigrateCo
} else {
libvirtComputingResource.destroyNetworkRulesForVM(conn, vmName);
for (final InterfaceDef iface : ifaces) {
+ String vlanId = getVlanIdFromBridgeName(iface.get... | [LibvirtMigrateCommandWrapper->[execute->[createMigrationURI],replaceDiskSourceFile->[getXml]]] | Execute the migrate command. This method is called when a VM is migrated. It will create a new VM in the check if a VM is in a dead state and if so wait for it to complete. This method is called when a VM is not associated with any network. | Maybe renamed to `shouldDeleteBridge()` or similar? |
@@ -93,7 +93,7 @@ func (d jobSpawnerDelegate) ServicesForSpec(spec job.SpecDB) (services []job.Ser
contractCaller,
d.ethClient,
d.logBroadcaster,
- concreteSpec.ID,
+ jobSpec.ID,
*logger.Default,
)
if err != nil {
| [ServicesForSpec->[DecryptedOCRKey,IsStarted,ExplorerAccessKey,NewBootstrapNode,Duration,NewOracle,With,Wrap,Info,DB,ExplorerURL,RecordError,P2PPeerID,New,OCRContractPollInterval,OCRContractConfirmations,Errorf,OCRDatabaseTimeout,OCRObservationTimeout,Address,OCRBlockchainTimeout,JSON,Wrapf,P2PBootstrapPeers,CreateLogg... | ServicesForSpec returns a list of services that can be started by the given OCR job OCR configured peer with ID OCR job that creates a new OCR instance using the local config. This function creates a new oracle and adds it to the list of services. | this was probably causing some subtle issues also |
@@ -341,7 +341,7 @@ class BokehServerTransaction(object):
userobj=self.server_userobj)
docid = self.server_docobj.docid
if mode not in {'auto', 'rw', 'r'}:
- raise Authentication('Unknown Mode')
+ raise AuthenticationException('Unknown Mode')
if mode == ... | [PersistentBackboneStorage->[pull->[smembers,parse_modelkey,dockey,mget],push->[sadd,dockey,mset,modelkey],get_document->[pull],del_obj->[srem,delete,dockey,modelkey],store_callbacks->[callbackskey,set],store_objects->[set]],prune->[prune],BokehServerTransaction->[save->[store_document],load->[pull,get_document,load,pr... | Initialize a transaction object. | Yay! found an actual bug! |
@@ -81,6 +81,12 @@ func Run(client *cmd.Client, args ...string) {
Usage: "Import a key file to use with the node",
Action: client.ImportKey,
},
+ {
+ Name: "adapter",
+ Aliases: []string{"a"},
+ Usage: "Add a new bridge to an external adapter",
+ Action: client.AddAdapter,
+ },
}
app.R... | [Run,NewApp,Bool,NewConfig] | NewProductionClient returns a new client for the chainlink - norequest client. | I think we should call this `AddBridge` and replace all the `adapter` vocabulary with bridge. @se3000, care to chime in? |
@@ -133,8 +133,15 @@ func NewPulumiCmd() *cobra.Command {
// Before exiting, if there is a new version of the CLI available, print it out.
jsonFlag := cmd.Flag("json")
isJSON := jsonFlag != nil && jsonFlag.Value.String() == "true"
- if checkVersionMsg := <-updateCheckResult; checkVersionMsg != nil && !isJ... | [StringVar,RawMessage,Dir,Colorize,Executable,Warningf,Now,Encode,HasPrefix,Add,IsTruthy,IgnoreClose,Flush,Stat,ParseTolerant,NewEncoder,New,RunFunc,Diag,StringVarP,NewClient,InitLogging,Run,After,Chdir,AddCommand,LookPath,GetCachedVersionFilePath,Bytes,TrimSpace,AssertNoError,InitProfiling,Join,Wrapf,Infof,Current,Eva... | Check if the version of the command is available and if it is print it out. Flow log settings to child processes. | Not sure if you are still working on it, but I think these changes should now be reverted, right? (It's possible I am incorrect here). |
@@ -319,8 +319,8 @@ class PantsDaemon(FingerprintedProcessManager):
self.terminate(include_watchman=False)
self._logger.debug('launching pantsd')
self.daemon_spawn()
- # Wait up to 10 seconds for pantsd to write its pidfile so we can display the pid to the user.
- self.await_pid... | [launch->[create],_LoggerStream->[fileno->[fileno]],PantsDaemon->[_close_fds->[flush,fileno],terminate->[terminate],watchman_launcher->[create],maybe_launch->[maybe_launch],Factory->[create->[create,PantsDaemon]],run_sync->[_setup_services,_setup_logging,_write_named_sockets,_run_services],_setup_logging->[_close_fds,_... | Launches pantsd if not already running. | this is probably fine as a bandaid, but it ultimately means a 6x longer wait for legitimate failure cases. I'd be super shocked if it actually ever took even half that long (even under extreme load) - but I'm also surprised that it takes longer than 10s in some observed cases, mainly because theres no meaningful resour... |
@@ -550,10 +550,11 @@ class BlockAdmin(BlockAdminAddMixin, admin.ModelAdmin):
def get_form(self, request, obj=None, change=False, **kwargs):
form = super().get_form(request, obj=obj, change=change, **kwargs)
- form.base_fields['min_version'].choices = _get_version_choices(
- obj, 'min_... | [BlockSubmissionAdmin->[save_model->[is_pending_signoff,has_signoff_permission,has_change_permission],change_view->[is_pending_signoff,has_signoff_permission,has_change_permission,_get_enhanced_guid_context],formfield_for_dbfield->[is_single_guid],has_change_permission->[is_pending_signoff],add_view->[is_single_guid,ha... | Returns a form with a ChoiceField for the min_version and max_version. | Why is this change necessary for this patch? I don't see any changes that would cause `form.base_fields` to not have `min_version`. |
@@ -10374,7 +10374,8 @@ var _examplesQuickstartsNodejsMongodbPersistentJson = []byte(`{
},
"message": "The following service(s) have been created in your project: ${NAME}, ${DATABASE_SERVICE_NAME}.\n\nFor more information about using this template, including OpenShift considerations, see https://github.com/opensh... | [FileMode,ModTime,Dir,Unix,Error,WriteFile,Join,Chtimes,Replace,Errorf,Split,MkdirAll,Mode] | _examplesQuickstartsNodejsMongodbPersistentJson returns a JSON object that represents a single Missing spec. | The app label should be parameterized so that when templates are used in conjunction to form a single application we can make the `app` labels match. |
@@ -193,6 +193,11 @@ func (h *Handler) ServeHTTP(rw http.ResponseWriter, req *http.Request, next http
core[RequestPath] = urlCopyString
core[RequestProtocol] = req.Proto
+ core[RequestScheme] = "http"
+ if req.TLS != nil {
+ core[RequestScheme] = "https"
+ }
+
core[ClientAddr] = req.RemoteAddr
core[ClientHos... | [Rotate->[Close],ServeHTTP->[ServeHTTP],Close->[Close],Write->[Write]] | ServeHTTP is the http. Handler interface implementation. It is the main entry point for the This function is called when a response is received from the server. It is called by the. | what about ws and wss? do we want to take them into account? do we want to look at the headers to see the connection upgrade maybe? |
@@ -269,12 +269,12 @@ Requires: %{name}-server%{?_isa} = %{version}-%{release}
%description firmware
This is the package needed to manage server storage firmware on DAOS servers.
-%package daos_serialize
+%package serialize
Summary: DAOS serialization library that uses HDF5
BuildRequires: hdf5-devel
Requires: hd... | [No CFG could be retrieved] | A summary of the given n - tuple. Dasos for the n - node - centric network. | I'm not 100% sure, but I think this change to the spec might also need to bump the release and add a changelog entry. |
@@ -191,14 +191,14 @@ public class GameData implements Serializable {
}
/**
- * @return The Technology Frontier for this game.
+ * Return The Technology Frontier for this game.
*/
public TechnologyFrontier getTechnologyFrontier() {
return technologyFrontier;
}
/**
- * @return The list ... | [GameData->[getRepairFrontierList->[ensureLockHeld],getRepairRuleList->[ensureLockHeld],getRelationshipTracker->[ensureLockHeld],getResourceList->[ensureLockHeld],getUnitTypeList->[ensureLockHeld],getCurrentRound->[releaseReadLock,acquireReadLock],getAllianceTracker->[ensureLockHeld],getUnitHolder->[ensureLockHeld],get... | Get the technologyFrontier. | Whether -> wether |
@@ -350,6 +350,14 @@ def cancel_waiting_fulfillment(
events.fulfillment_canceled_event(
order=fulfillment.order, user=user, app=app, fulfillment=None
)
+
+ order_lines = []
+ for line in fulfillment:
+ order_line = line.order_line
+ order_line.quantity_fulfilled -= line.quantity
+... | [_move_fulfillment_lines_to_target_fulfillment->[_get_fulfillment_line],create_replace_order->[_populate_replace_order_fields],process_replace->[_move_lines_to_replace_fulfillment,create_replace_order],approve_fulfillment->[order_fulfilled],_get_fulfillment_line->[_get_fulfillment_line_if_exists],_process_refund->[_cal... | Cancel a waiting fulfillment which is in waiting for approval state. | make sure that allocations are correctly returned |
@@ -23,9 +23,11 @@ import io.confluent.ksql.util.KsqlException;
import java.util.List;
import java.util.Objects;
import java.util.function.Supplier;
+import jdk.nashorn.internal.ir.annotations.Immutable;
import org.apache.kafka.connect.data.Schema;
import org.apache.kafka.connect.data.Struct;
+@Immutable
public... | [BaseAggregateFunction->[getFunctionName->[of],IllegalArgumentException,isOptional,toSqlType,get,requireNonNull,connectToSqlConverter,KsqlException]] | Implementation of a base aggregate function. Creates an aggregate function from the given arguments. | wrong Immutable annotation! we use the google.errorprone one. I recommend adding this to a auto-import blacklist in IntelliJ since not all JVMs come with this annotation and cause compilation to fail |
@@ -149,6 +149,14 @@ describe AdminPublicBodyController do
}.to change{ PublicBody.count }.from(existing).to(expected)
end
+ it 'can create a public body when the default locale is an underscore locale' do
+ AlaveteliLocalization.set_locales('es en_GB', 'en_GB')
+ post :create, @par... | [setup_emergency_credentials->[env,load_default],create,find,let,be,to_not,describe,public_bodies,tag_string,fixture_file_upload,load_default,it,name,put,find_by_name,env,to,setup_emergency_credentials,save!,before,public_body_name,post,create_embargo,destroy,with,assigns,require,count,get_user_email,public_body_id,inc... | expects the admin page of the body saves the default locale translation. | Line is too long. [86/80] |
@@ -15,6 +15,7 @@
package io.confluent.ksql.tools.migrations.commands;
+import static io.confluent.ksql.tools.migrations.util.CommandParser.preserveCase;
import static io.confluent.ksql.tools.migrations.util.MigrationsDirectoryUtil.getAllMigrations;
import static io.confluent.ksql.tools.migrations.util.Migration... | [ApplyMigrationCommand->[validateCurrentState->[info,validate],executeCommands->[getMessage,of,parse,getCommand,updateState,executeCommand,MigrationException,format],verifyMigrated->[getMessage,getState,error,equals,MigrationException,retryWithBackoff,format],apply->[getMessage,error,size,parseInt,equals,loadMigrations... | Imports a single object. This method is exported for use in the migration package. | This import is unused, right? |
@@ -112,7 +112,7 @@ func worker(queue workqueue.RateLimitingInterface, resourceType string, reconcil
res, err := reconciler.Reconcile(req)
if err != nil {
- logger.Logger.Infof("Error syncing %s %v: %v", resourceType, key, err)
+ logger.Logger.Debugf("Error reconciling %s %v: %v", resourceType, key,... | [AddRateLimited,Until,Error,Add,Infof,Reconcile,AddAfter,WithError,ObjectMeta,StopChannelInto,SplitMetaNamespaceKey,Forget,Errorf,MetaNamespaceKeyFunc,Get,Func,Done] | check if the queue is empty and if so add it to the queue. | Why was this changed? |
@@ -1197,7 +1197,7 @@ if (empty($reshook))
// Don't add lines with qty 0 when coming from a shipment including all order lines
if($srcobject->element == 'shipping' && $conf->global->SHIPMENT_GETS_ALL_ORDER_PRODUCTS && $lines[$i]->qty == 0) continue;
// Don't add closed lines when coming fr... | [update_price,create,form_multicurrency_rate,get_OutstandingBill,jdate,getLinesArray,setValueFrom,getVentilExportCompta,getNomUrl,select_incoterms,begin,select_comptes,insert_discount,getLibType,setProject,add_contact,showOptionals,printOriginLinesList,textwithpicto,fetch_optionals,free,transnoentitiesnoconv,query,form... | Adds line objects from source to target object Private function for adding a discount line to a line in the cart. | If service was just suspended, i think a lot of use case will need to invoice despite that. I suggest a hidden option to be able to choose status to invoice if (! isset( $conf->global->CONTRACT_EXCLUDE_SERVICES_STATUS_FOR_INVOICE)) $conf->global->CONTRACT_EXCLUDE_SERVICES_STATUS_FOR_INVOICE = '0,5'; and replace test wi... |
@@ -57,6 +57,12 @@ describe UserAvatarsController do
expect(OptimizedImage.where(upload_id: upload.id).count).to eq(1)
expect(response.status).to eq(200)
+
+ upload.reload
+
+ expect(upload.extension).to eq('png')
+ expect(File.extname(upload.url)).to eq('.png')
+ ... | [create_for,let,enable_s3_uploads,describe,s3_upload_bucket,s3_secret_access_key,it,to,rm,update_columns,root,avatar_sizes,s3_access_key_id,returns,path_for,require,username,mv,external_system_avatars_url,url,hex,open,id,redirect_to,context,s3_cdn_url,get,eq,after,to_return,username_lower] | expects non local content This method is used to download an image from a specific node. | @SamSaffron The two assertions above will fail because the original_filename and url are still incorrect. I think we need to at least fix it for the upload's url. |
@@ -47,7 +47,11 @@ public class CasConfigurationJasyptCipherExecutor implements CipherExecutor<Stri
setProviderName(pName);
val iter = getJasyptParamFromEnv(environment, JasyptEncryptionParameters.ITERATIONS);
setKeyObtentionIterations(iter);
- setInitializationVector();
+ val i... | [CasConfigurationJasyptCipherExecutor->[setAlgorithmForce->[setAlgorithm],setProviderName->[setProviderName],setAlgorithm->[setAlgorithm],setKeyObtentionIterations->[setKeyObtentionIterations],setPassword->[setPassword]]] | Creates a new Jasypt cipher executor. Sets the algorithm for the . | Rename to `configureInitializationVendor()`. Set implies that you're passing a value as a setter. |
@@ -286,3 +286,15 @@ def wrap_subprocess_call(on_win, root_prefix, prefix, command):
command_args = [shell_path, "-x", script_caller]
return script_caller, command_args
+
+
+def ensure_comspec_set():
+ if 'COMSPEC' not in environ:
+ cmd_exe = join(environ.get('SystemRoot'), 'System32', 'cmd.ex... | [wrap_subprocess_call->[abspath,NamedTemporaryFile,write,get,copy,str,format,join,\"$],sys_prefix_unfollowed->[dirname,next,iter,_current_frames],md5_file->[compute_md5sum],hashsum_file->[new,update,read,hexdigest,open],unix_path_to_win->[_translation->[group,format,len],group,sub,len,replace,count],translate_stream->[... | Wrap a subprocess call to get the name of the script and the arguments to execute. | Should this be .info() or .warn()? |
@@ -46,7 +46,7 @@ public class IssuesWs implements WebService {
@Override
public void define(Context context) {
NewController controller = context.createController(API_ENDPOINT);
- controller.setDescription("Coding rule issues");
+ controller.setDescription("Read and update issues.");
controller.s... | [IssuesWs->[defineChangelogAction->[setExampleValue,getResource,addFormatParam,setResponseExample],defineEditCommentAction->[setExampleValue,addFormatParam,setPost],defineBulkChangeAction->[setPost,setExampleValue,addFormatParam,setPossibleValues,setSince],defineTransitionsAction->[setExampleValue,getResource,setRespon... | Define the missing action. | why not Manage issues? we search for issues, which is an important element of the domain @ganncamp WDYT? |
@@ -1,11 +1,11 @@
class Reaction < ApplicationRecord
- include AlgoliaSearch
include Searchable
SEARCH_SERIALIZER = Search::ReactionSerializer
SEARCH_CLASS = Search::Reaction
- CATEGORIES = %w[like readinglist unicorn thinking hands thumbsdown vomit].freeze
+ CATEGORIES = %w[like readinglist unicorn th... | [Reaction->[reading_time->[reading_time],negative_reaction_from_untrusted_user?->[negative?]]] | The Reaction class is a subclass of the ApplicationRecord class. It is a subclass of The action that will be indexed is to be indexed by the user and the action that will. | this is an example of why you don't want to have enums in the DB after all @atsmith813 :D Our `reactions` table is probably one of the biggest ones and it would have required a complicated dance of `ALTER TABLE` with such a massive table |
@@ -121,7 +121,7 @@ if (preloadScript) {
try {
require(preloadScript)
} catch (error) {
- if (error.code === 'MODULE_NOT_FOUND') {
+ if (error.code === 'MODULE_NOT_FOUND' && error.message.indexOf(preloadScript) > -1) {
console.error('Unable to load preload script ' + preloadScript)
} else {... | [No CFG could be retrieved] | Load the script specified by the preload attribute. | Should this be `===` 0 instead of `> -1`? That way a path like `/foo/bar.js` won't incorrectly match `/prefix/foo/bar.js`. |
@@ -31,7 +31,7 @@
</fieldset>
<%= f.submit I18n.t('save'), :onclick => "set_onbeforeunload(false);",
- :disable_with => I18n.t('working') %>
+ :disable_with => I18n.t('working') %>
<%= link_to I18n.t('cancel'), notes_path(), :class => "button" %>
<% end %>
</div>
| [No CFG could be retrieved] | <fieldset class = header >. | This seems oddly aligned. |
@@ -319,6 +319,8 @@ const files = {
'shared/util/entity-utils.ts',
// components
{ file: 'shared/auth/private-route.tsx', method: 'processJsx' },
+ { file: 'shared/error-boundary/error-boundary.tsx', method: 'processJsx' },
+ { file: 'shar... | [No CFG could be retrieved] | This module contains all the necessary tsx files and methods that can be used to create the Missing JSX file. | lets put them in a folder called `error` |
@@ -370,7 +370,12 @@ FORCE_INLINE void probe_specific_action(const bool deploy) {
BUZZ(100, 698);
PGM_P const ds_str = deploy ? PSTR(MSG_MANUAL_DEPLOY) : PSTR(MSG_MANUAL_STOW);
- lcd_setstatusPGM(ds_str);
+ // leave the menu if it is displayed to make LCD messsages visible
+ lcd_return_to_status();... | [No CFG could be retrieved] | This function is called by the network layer when a network action is required. set_probe_deployed - Sets the probe deployed state. | I don't feel it's appropriate to make a click sound if the user hasn't actually pressed the click-wheel or a keypad button. The concept of adding audio feedback to Marlin exists, but it would have event-appropriate sounds indicating success, failure, completion, etc. |
@@ -301,7 +301,7 @@ def test_handle_trade_roi(default_conf, ticker, limit_buy_order, mocker, caplog)
assert ('freqtrade', logging.DEBUG, 'Executing sell due to ROI ...') in caplog.record_tuples
-def test_handle_trade_experimental(default_conf, ticker, limit_buy_order, mocker, caplog):
+def test_handle_trade_ex... | [test_process_operational_exception->[get_state,_process,dict,init,create_engine,multiple,patch,MagicMock],test_process_trade_handling->[_process,dict,init,create_engine,len,multiple,filter,patch,MagicMock],test_check_handle_timedout_sell->[dict,init,create_engine,multiple,check_handle_timedout,add,utcnow,MagicMock,Tra... | Test for the case of the case of the FMRI with experimental mode. | why is the `limit_buy_order` removed? |
@@ -48,7 +48,13 @@ type ComputedKeyInfo struct {
// Map of SigID -> KID
Delegations map[keybase1.SigID]keybase1.KID
DelegatedAt *KeybaseTime
- RevokedAt *KeybaseTime
+
+ RevokedAt *KeybaseTime
+ // TODO: would like to add this to support desktop's request
+ // to know who revoked a device, but changing this ch... | [HasActiveEncryptionSubkey->[FindActiveEncryptionSubkey],GetSibkeyForDevice->[FindActiveSibkey,getSibkeyKidForDevice],GetKeyRoleAtTime->[getCkiIfActiveAtTime],GetActivePGPKeys->[GetKeyRole,FindKeyWithKIDUnsafe],FindActiveSibkeyAtTime->[FindKeyWithKIDUnsafe,getCkiIfActiveAtTime],GetAllActiveSibkeysAtTime->[GetAllActiveK... | type is a type that can be used to determine the current Merkle root time. A map from the most current KID to the most current device object. | Should the storage format be forwards compatible for this change? |
@@ -39,8 +39,9 @@ func (c *RaftCluster) HandleRegionHeartbeat(region *core.RegionInfo) error {
}
c.RLock()
- defer c.RUnlock()
- c.coordinator.opController.Dispatch(region, schedule.DispatchFromHeartBeat)
+ co := c.coordinator
+ c.RUnlock()
+ co.opController.Dispatch(region, schedule.DispatchFromHeartBeat)
retu... | [handleReportSplit->[checkSplitRegion],handleBatchReportSplit->[checkSplitRegions],handleAskBatchSplit->[validRequestRegion]] | HandleRegionHeartbeat handles a region heartbeat request. | What's the meaning of this `RLock()`? `c.coordinator` is just a pointer, this assign is thread-safe (I didn't find any code will modify(`c.coordinator = xxx`) it after init). The original code is using the `RLock()` to protect the `Dispatch()` function call. Maybe you want to remove this `RLock()`? |
@@ -5082,7 +5082,7 @@ void home_all_axes() { gcode_G28(); }
const int8_t verbose_level = code_seen('V') ? code_value_byte() : 1;
if (!WITHIN(verbose_level, 0, 2)) {
- SERIAL_PROTOCOLLNPGM("?(V)erbose level is implausible (0-2).");
+ SERIAL_PROTOCOLLNPGM("?(V)erbose Level is implausible (0-... | [No CFG could be retrieved] | G33 - related functions The method is called to set the values of the NICs in the Configuration. h. | This was changed in a previous merge, and it isn't important really, but it suggests a rebase may be needed? |
@@ -18,5 +18,12 @@ class RepositoryDateValue < RepositoryDateTimeValueBase
value
end
+ def self.import_from_text(text, attributes, options = {})
+ date_format = (options.dig(:user, :settings, :date_format) || Constants::DEFAULT_DATE_FORMAT).gsub(/%-/, '%')
+ new(attributes.merge(data: DateTime.strptim... | [RepositoryDateValue->[data_changed?->[parse,to_date],new_with_payload->[parse,new,data]]] | Creates a new object with the given attributes and payload. | Layout/TrailingWhitespace: Trailing whitespace detected. |
@@ -50,6 +50,7 @@
namespace Amesos2 {
+// TODO: How does TPETRA_INST_INT_INT influence an Epetra instantiation???
#ifdef HAVE_TPETRA_INST_INT_INT
#ifdef HAVE_AMESOS2_EPETRA
AMESOS2_SOLVER_EPETRA_INST(MUMPS);
| [No CFG could be retrieved] | This function is responsible for handling the creation of a new object. Replies the names of the amesos2 objects. | It's a known issue that if you enable Epetra in Amesos2, then you must enable `GlobalOrdinal=int` in Tpetra. See #2548. This is unfortunate and Trilinos needs to fix it, but I think that's out of scope for this PR. |
@@ -167,7 +167,10 @@ public class VlanDaoImpl extends GenericDaoBase<VlanVO, Long> implements VlanDao
List<PodVlanMapVO> vlanMaps = _podVlanMapDao.listPodVlanMapsByPod(podId);
List<VlanVO> result = new ArrayList<VlanVO>();
for (PodVlanMapVO pvmvo : vlanMaps) {
- result.add(findById... | [VlanDaoImpl->[configure->[configure],findNextVlan->[listByZoneAndType]]] | List all VLANs for a given pod. | a null check is enough, removed items are not returned by `GenericDaoBase::findById()` |
@@ -223,7 +223,7 @@ async def setup_pytest_for_target(
)
-@rule
+@rule(level=LogLevel.INFO)
async def run_python_test(
field_set: PythonTestFieldSet,
test_setup: TestTargetSetup,
| [run_python_test->[reference,append,PathGlobs,PytestCoverageData,create_process,from_fallible_process_result,extend,tuple,warning,join,AddPrefix,Get,SnapshotSubset],setup_pytest_for_target->[CoverageConfig,partial,pex_request,join,PexRequirements,MergeDigests,MultiGet,get_requirement_strings,SpecifiedSourceFilesRequest... | Runs pytest for one target. Get the coverage data for a node. | Rather than adjusting the level of this `@rule`, you probably want to adjust `coordinator_of_tests` so that this will affect all tests rather than just python. But it should probably stay debug by default: we don't want it to render unless this fails. Finally, rather than changing the level, you should probably give it... |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.