patch stringlengths 18 160k | callgraph stringlengths 4 179k | summary stringlengths 4 947 | msg stringlengths 6 3.42k |
|---|---|---|---|
@@ -2569,7 +2569,17 @@ void Game::processUserInput(VolatileRunFlags *flags,
|| noMenuActive() == false
|| guienv->hasFocus(gui_chat_console)) {
input->clear();
+#ifdef HAVE_TOUCHSCREENGUI
+ g_touchscreengui->Hide();
+#endif
}
+#ifdef HAVE_TOUCHSCREENGUI
+ else if (g_touchscreengui) {
+ /* on touchscreeng... | [No CFG could be retrieved] | processing of input region GameKeyboardInputHandler. | Where is the corresponding `Show()` called? |
@@ -16,7 +16,9 @@ class Openfdtd(MakefilePackage):
homepage = "http://www.e-em.co.jp/OpenFDTD/"
url = "http://www.e-em.co.jp/OpenFDTD/OpenFDTD.zip"
- version('2.3.0', sha256='10ac70f2ed7160da87dd9222a5a17ca7b72365ee886235359afc48c4fb7b4be4')
+ version('2.6.0', sha256='92f7b92dc55ff6d8fc8c31eda77c... | [Openfdtd->[build->[working_dir,make],install->[install,mkdirp],edit->[filter_file],variant,depends_on,version]] | Creates a new object of type n - tuple with the appropriate name and description. Create a package for all n - ary packages. | Is the new version available at a version-specific URL? |
@@ -656,7 +656,6 @@ namespace System.Data.Common
return ((null != inputString) ? inputString.Length : 0);
}
- [ReliabilityContract(Consistency.WillNotCorruptState, Cer.MayFail)]
internal static IntPtr IntPtrOffset(IntPtr pbase, int offset)
{
if (4 == ADP.Ptr... | [ADP->[GetFullPath->[GetFullPath],InvalidOperationException->[GetString],Exception->[GetString,TimeoutException],TimerHasExpired->[TimerCurrent],TimerRemaining->[TimerCurrent],CheckArgumentLength->[GetString],TimerRemainingMilliseconds->[TimerRemaining],ArgumentException->[GetString]]] | StringLength - Returns length of a in the given string. | This project targets netstandard + netframework. |
@@ -185,12 +185,10 @@ public class GameStepPropertiesHelper {
data.getSequence().getStep().getProperties().getProperty(GameStep.PropertyKeys.REMOVE_AIR_THAT_CAN_NOT_LAND);
if (prop != null) {
return Boolean.parseBoolean(prop);
- } else if (data.getSequence().getStep().getDelegate() != nu... | [GameStepPropertiesHelper->[isGiveBonusMovement->[acquireReadLock,getProperty,releaseReadLock,isCombatDelegate,parseBoolean],getRepairPlayers->[acquireReadLock,split,getProperty,getName,getPlayerId,println,releaseReadLock,add],isAirborneMove->[acquireReadLock,getProperty,isAirborneDelegate,releaseReadLock,parseBoolean]... | Checks if the game data is remove air that can not land. | formatting; a line should not end wiht ` && (` |
@@ -82,6 +82,9 @@ public class CSVFileDataAdapter extends LookupDataAdapter {
if (isNullOrEmpty(config.path())) {
throw new IllegalStateException("File path needs to be set");
}
+ if (!pathChecker.fileIsInAllowedPath(Paths.get(config.path()))) {
+ throw new IllegalStateE... | [CSVFileDataAdapter->[Config->[validate->[path,create]]]] | This method is called when the adapter is starting. | I just noticed that we are missing this check in `doRefresh()` So, if you wait after the check interval of the data adapter, the file gets loaded anyway. |
@@ -14,7 +14,7 @@ _logger = logging.getLogger(__name__)
def to_v1_yaml(config: ExperimentConfig, skip_nnictl: bool = False) -> Dict[str, Any]:
- config.validate(skip_nnictl)
+ config.validate(False)
data = config.json()
ts = data.pop('trainingService')
| [to_cluster_metadata->[to_v1_yaml],to_rest_json->[to_v1_yaml]] | Convert v1. 0 config to v1. 0 config. Missing - Pop some data from algo and return it as a dict. | `skip_nnictl` is not used in this function. what is the meaning of `skip_nnictl`? |
@@ -246,13 +246,14 @@ int X509_get_signature_nid(const X509 *x)
}
#ifndef OPENSSL_NO_SM2
-void X509_set_sm2_id(X509 *x, ASN1_OCTET_STRING *sm2_id)
+void X509_set0_sm2_id(X509 *x, ASN1_OCTET_STRING *sm2_id)
{
- x->sm2_id = *sm2_id;
+ ASN1_OCTET_STRING_free(x->sm2_id);
+ x->sm2_id = sm2_id;
}
ASN1_OCTET... | [No CFG could be retrieved] | Get sm2_id from a X509 object. | There should be a test for this function. |
@@ -108,8 +108,8 @@ function render_player( $player_data, $attributes ) {
// Generate object to be used as props for PodcastPlayer.
$player_props = array_merge(
- // Make all attributes available.
- $attributes,
+ // Add all attributes.
+ array( 'attributes' => $attributes ),
// Add all player data.
$pl... | [render_block->[get_error_message]] | Renders a block of data for a podcast player. Renders the warning that the podcast player does not provide any information. | Should we explain _why_ we need to nest attributes? What was the motivation? |
@@ -106,6 +106,8 @@ public class SparkInterpreter extends Interpreter {
getSystemDefault("ZEPPELIN_SPARK_USEHIVECONTEXT",
"zeppelin.spark.useHiveContext", "true"),
"Use HiveContext instead of SQLContext if it is true.")
+ .add("zeppelin.default.interpret... | [SparkInterpreter->[getProgress->[getJobGroup],interpretInput->[toString,interpret],getSQLContext->[useHiveContext,getSparkContext],getProgressFromStage_1_0x->[getProgressFromStage_1_0x],getProgressFromStage_1_1x->[getProgressFromStage_1_1x],close->[close],cancel->[getJobGroup],open->[getDependencyResolver,getSQLContex... | Creates a spark interpreter for the given number of nodes. Construct a SparkInterpreter that can be used to interpret a single non - empty sequence of properties. | if this is spark group specific, should this setting by called 'zeppelin.spark.default.interpreter'? |
@@ -130,13 +130,13 @@ public class Rules
AggregateValuesRule.INSTANCE
);
- // Rules from VolcanoPlanner's registerAbstractRelationalRules.
+ // Rules from VolcanoPlanner's registerAbstractRelationalRules, minus JoinCommuteRule since it's already
+ // in DEFAULT_RULES.
private static final List... | [Rules->[druidConventionRuleSet->[getMaxSemiJoinRowsInMemory,instance,build,rules,addAll,add],programs->[druidConventionRuleSet,of,DecorrelateAndTrimFieldsProgram,sequence,bindableConventionRuleSet,ofRules,subQuery],baseRuleSet->[instance,build,getPlannerConfig,isUseApproximateCountDistinct,addAll,add,builder],Decorrel... | Creates a list of all abstract relations. Method to find the object in the hierarchy of the object. | todo: need a test for this |
@@ -300,10 +300,10 @@ function renderStartedNoInline(doc) {
/**
* Indicates that the body is always visible. For instance, in case of PWA.
- * @param {!Window} win
+ * @param {!Window} unusedWin
*/
-export function bodyAlwaysVisible(win) {
- win[bodyVisibleSentinel] = true;
+export function bodyAlwaysVisible(un... | [No CFG could be retrieved] | Checks whether a non - empty element was registered in the DOM. | now I'm bit worried it will break PWA @choumx |
@@ -87,10 +87,14 @@ BuildRequires: libpsm_infinipath1
BuildRequires: libpmemblk1
%endif # (0%{?suse_version} >= 1315)
%endif # (0%{?rhel} >= 7)
+
+%global min_pmdk 1.8-1
%if (0%{?suse_version} >= 1500)
-Requires: libpmem1, libpmemobj1
+Requires: libpmem1 >= %{min_pmdk}, libpmemobj1 >= %{min_pmdk}, libpmemblk1 >= %{... | [No CFG could be retrieved] | Return a list of all possible objects. The DAOS server is a shared library version that is used to release a single . | The title only says pmdk |
@@ -228,11 +228,11 @@ class OutputBase(object):
return
if self.is_in_repo:
- if self.repo.scm.is_tracked(self.path):
+ if self.repo.scm.is_tracked(self.fspath):
raise OutputAlreadyTrackedError(self)
if self.use_cache:
- self.re... | [OutputBase->[is_dir_checksum->[is_dir_checksum],isfile->[isfile],supported->[match],move->[move,commit,save],unprotect->[unprotect],commit->[save],download->[download],changed->[status],exists->[exists],status->[changed_checksum,changed_cache],changed_cache->[changed_cache],save->[OutputAlreadyTrackedError,changed],gr... | Saves a object to disk. | not related to this PR. should all the stuff that depends on local-specific things go into outputLocal? |
@@ -17,6 +17,7 @@
package org.apache.gobblin.writer;
+import com.sun.javafx.binding.StringFormatter;
import java.io.IOException;
import java.util.ArrayList;
import java.util.List;
| [PartitionedDataWriter->[bytesWritten->[bytesWritten],getFinalState->[getFinalState,bytesWritten,recordsWritten],writeEnvelope->[writeEnvelope],commit->[commit],cleanup->[cleanup],serializePartitionInfoToState->[getPartitionsKey],createPartitionWriter->[isDataWriterWatermarkCapable],getPartitionInfoAndClean->[getPartit... | Imports a single object. Package for import. | `String.format` should serve the same purpose? |
@@ -52,6 +52,18 @@ def convert_dtype(dtype):
return 'int64'
elif dtype == core.VarDesc.VarType.UINT8:
return 'uint8'
+ else:
+ if dtype in [
+ 'bool', 'float16', 'float32', 'float64', 'int8', 'int16',
+ 'int32', 'int64', 'uint8'
+ ]:
+ ... | [ListTensorProvider->[__call__->[_readData],_readData->[NumpyToLoDTensorConverter,done,feed]],DataToLoDTensorConverter->[_feed_impl_->[_feed_impl_],done->[_reset],__init__->[convert_dtype]],NumpyToLoDTensorConverter->[done->[_reset],__init__->[_reset]],BatchedTensorProvider->[__call__->[_done,_reset],_done->[done],__in... | Convert dtype to a nanomagical type. | if isinstance( dtye, [str, unicode]) |
@@ -47,9 +47,13 @@ DESIRES = {
class LateralPlanner():
- def __init__(self, CP):
+ def __init__(self, CP, use_lanelines=None):
params = Params()
+ if use_lanelines is None:
+ self.use_lanelines = not params.get_bool('EndToEndToggle')
+ else:
+ self.use_lanelines = use_lanelines
wide_c... | [LateralPlanner->[setup_mpc->[init,new],__init__->[setup_mpc,arange,get,LanePlanner,ones,zeros,get_bool,Params],update->[any,max,column_stack,sec_since_boot,init,min,norm,warning,abs,list,get_d_path,len,clip,float,run_mpc,isnan,set_weights,parse_model,interp,array],publish->[bool,send,list,all_alive_and_valid,float,new... | Initialize the object with the missing configuration values. | Should we just pass in both toggle values and have later_planner read the params? |
@@ -514,6 +514,16 @@ func (http *httpPlugin) newTransaction(requ, resp *message) beat.Event {
}
}
+func (http *httpPlugin) makeRawMessage(m *message) string {
+ var result []byte
+ result = append(result, m.rawHeaders...)
+ if m.sendBody {
+ result = append(result, m.body...)
+ }
+ // TODO: (go1.10) Use strings.B... | [cutMessageBody->[extractBody],ReceivedFin->[PrepareForNewMessage],extractParameters->[Parse,hideSecrets],doParse->[PrepareForNewMessage,messageComplete],GapInStream->[messageComplete,messageGap]] | newTransaction creates a new transaction from a request and response publishTransaction publishes a transaction. | We have a followup github issue? |
@@ -131,6 +131,13 @@ class DepsGraph(object):
conanfile.package_id()
return ordered
+ def direct_requires(self):
+ closure = set()
+ nodes_by_level = self.inverse_levels()
+ open_nodes = nodes_by_level[1]
+ closure.update(open_nodes)
+ return closure... | [DepsGraph->[build_order->[_inverse_closure],ordered_closure->[public_neighbors],private_nodes->[by_levels,public_neighbors]],DepsGraphBuilder->[load->[DepsGraph,Node,add_node,propagate_info],_load_deps->[_resolve_deps,add_edge,_load_deps],_create_new_node->[Node,add_node,add_edge]],Node->[__ge__->[__cmp__],__le__->[__... | Propagates the info of a node in the system. Returns a list of nodes that are in the closure of the given node. | creation and update of the "closure" is unnecessary. |
@@ -2272,7 +2272,9 @@ public class BigQueryIO {
public final KV<String, Long> close() throws IOException {
channel.close();
- return KV.of(fileName, out.getCount());
+ KV<String, Long> record = KV.of(fileName, out.getCount());
+ out.close();
+ return record;
}
}... | [BigQueryIO->[displayTable->[TableRefToTableSpec],PassThroughThenCleanup->[expand->[apply]],verifyTablePresence->[getTable,toTableSpec],BigQueryQuerySource->[populateDisplayData->[populateDisplayData],create->[BigQueryQuerySource],TableRefToJson,TableRefToProjectId],TransformingSource->[getEstimatedSizeBytes->[getEstim... | Closes the file and returns the file name and number of bytes written. | Should line 2254 above also be modified? |
@@ -452,7 +452,7 @@ func (c *coordinator) runScheduler(s *scheduleController) {
select {
case <-timer.C:
timer.Reset(s.GetInterval())
- if !s.AllowSchedule() {
+ if !s.AllowSchedule() && !s.isPaused() {
continue
}
if op := s.Schedule(); op != nil {
| [Schedule->[Schedule],run->[drivePushOperator,patrolRegions]] | runScheduler runs the scheduler in a goroutine. | I think we can invoke `isPaused` inside `AllowSchedule` which makes the API clearer. |
@@ -23,7 +23,7 @@ RSpec.describe WebHookUserSerializer do
it 'should only include the required keys' do
count = serializer.as_json.keys.count
- difference = count - 45
+ difference = count - 47
expect(difference).to eq(0), lambda {
message = (difference < 0 ?
| [email,to,new,let,describe,fab!,create!,eq,as_json,lambda,it,require,id,count] | should include relevant user info. | I don't think we should expose `unconfirmed_emails` to the web hook yet. |
@@ -205,7 +205,7 @@ module.exports = class bitflyer extends Exchange {
const symbol = this.safeSymbol (undefined, market);
const timestamp = this.parse8601 (this.safeString (ticker, 'timestamp'));
const last = this.safeNumber (ticker, 'ltp');
- return {
+ return this.safeTicker ... | [No CFG could be retrieved] | fetchBalance retrieves the balance of an order from the BTC or ETH market Get a ticker for the . | @kroitor since for this case the market has to be in the request I'm not "fetching" it again because it was in the fetchTicker to construct the request |
@@ -51,13 +51,12 @@ namespace System.Windows.Forms
public override RightToLeft RightToLeft
{
get => RightToLeft.No;
- set
- {
- }
+ set { }
}
+
[Browsable(false)]
[EditorBrowsable(EditorBrowsableState.Never)]
- ... | [VScrollBar->[AutoDispatch,IsScalingRequirementMet,No,Style,nameof,RightToLeftChanged,VerticalScrollBarWidth,LogicalToDeviceUnits,VERT,Never,DescriptionVScrollBar,CreateParams,GetVerticalScrollBarWidthForDpi]] | RightToLeft . | Sorry if this has been discussed or checked before, but does it make sense to subscribe `null` to an event? (will it throw on subscription or invocation time?) How is the base class library of the dotnet runtime handling nullability on events, is there a pattern WinForms could follow? |
@@ -125,6 +125,9 @@ import com.google.common.collect.ImmutableMap;
*/
public class MuleExtensionUtils {
+ private static final String IMPLICIT_CONFIGURATION_SUFFIX = "-implicit";
+ public static final String HYPHEN = "-";
+
/**
* @param componentModel a {@link ComponentModel}
* @return Whether the {@c... | [MuleExtensionUtils->[getExtensionsNamespace->[getExtensionsNamespace],getOperationExecutorFactory->[getLegacyOperationExecutorFactory],withExtensionClassLoader->[getClassLoader],loadExtension->[getClassLoader,loadExtension],extractExpression->[isExpression],toBackPressureStrategy->[toBackPressureStrategy]]] | Checks if the componentModel returns a list of messages. | isnt there a definition for this somewhere else already? |
@@ -104,7 +104,7 @@ class TokenNetworkRegistry:
channel_participant_deposit_limit: TokenAmount,
token_network_deposit_limit: TokenAmount,
given_block_identifier: BlockIdentifier,
- ) -> TokenNetworkAddress:
+ ) -> Tuple[TransactionHash, TokenNetworkAddress]:
"""
Regist... | [TokenNetworkRegistry->[add_token->[get_token_network],_add_token->[get_token_network],settlement_timeout_max->[settlement_timeout_max],settlement_timeout_min->[settlement_timeout_min]]] | Register a token with the token network. Returns the minimum timeout for the given token in the token network. Adds a token to the token network. | I would have put the txhash last in this case. But i guess that's a matter of taste, so no need to change. |
@@ -146,6 +146,7 @@ class JSONRPCClient:
privkey: bytes,
gas_price_strategy: Callable = rpc_gas_price_strategy,
nonce_offset: int = 0,
+ block_num_confirmations: int = 0,
):
if privkey is None or len(privkey) != 32:
raise ValueError('Invalid p... | [JSONRPCClient->[poll->[block_number],send_transaction->[check_startgas,gas_price],__init__->[monkey_patch_web3],deploy_solidity_contract->[new_contract_proxy,get_transaction_receipt,dependencies_order_of_build,deploy_dependencies_symbols],check_startgas->[gaslimit]]] | Initializes the object with the given private key and optional nonce offset. | Have you made sure that in all the integration tests the value of 0 is given? i.e. that for all tests this is 0? Except perhaps one test that could test specifically for confirmations? |
@@ -372,9 +372,7 @@ export class AmpConsent extends AMP.BaseElement {
this.consentStateManager_.getConsentInstanceState(instanceId)
.then(state => {
if (state == CONSENT_ITEM_STATE.UNKNOWN) {
-
- this.notificationUiManager_.registerUI(
- this.show_.bind(this, instanceI... | [No CFG could be retrieved] | Register AMP consent UI and AMP notifications. | Can this be unknown because user dismissed? If so, do we always want to show it again? |
@@ -88,4 +88,10 @@ public class DatanodeSchemaOneDBDefinition
getDeletedBlocksColumnFamily() {
return DELETED_BLOCKS;
}
+
+ @Override
+ public DBColumnFamilyDefinition[] getColumnFamilies() {
+ return new DBColumnFamilyDefinition[] {getBlockDataColumnFamily(),
+ getMetadataColumnFamily(), get... | [DatanodeSchemaOneDBDefinition->[LongCodec,SchemaOneChunkInfoListCodec,bytes2String,SchemaOneKeyCodec,BlockDataCodec]] | Returns the deleted blocks column family. | I don't think this override is necessary. It looks the same as the parent class method. |
@@ -453,6 +453,18 @@ public final class OzoneManager extends ServiceRuntimeInfoImpl
OMConfigKeys.OZONE_OM_RATIS_ENABLE_KEY,
OMConfigKeys.OZONE_OM_RATIS_ENABLE_DEFAULT);
+ this.defaultBucketLayout =
+ configuration.getTrimmed(OZONE_DEFAULT_BUCKET_LAYOUT,
+ OZONE_DEFAULT_BUCKET_LA... | [OzoneManager->[getScmBlockClient->[getScmBlockClient],completeMultipartUpload->[buildAuditMessageForFailure,buildAuditMessageForSuccess,completeMultipartUpload],getVolumeInfo->[checkAcls,getVolumeInfo],startTrashEmptier->[start],loginOMUserIfSecurityEnabled->[loginOMUser],join->[join],hasAcls->[checkAcls],allocateBloc... | This function is called once before starting the OM service. It is called once before starting the Creates an OOM if the user has not specified a security config. | Can we use Configuration Exception, and in the message can we add supported values. |
@@ -223,6 +223,6 @@ public class OMException extends IOException {
INVALID_VOLUME_NAME,
- REPLAY // When ratis logs are replayed.
+ REPLAY
}
}
| [OMException->[toString->[toString]]] | INVALID_VOLUME_NAME - Invalid volume name. | Any reason for keeping this around? |
@@ -24,7 +24,8 @@ os:
SunOS:
Arduino:
board: ANY
-arch: [x86, x86_64, ppc64le, ppc64, armv6, armv7, armv7hf, armv8, sparc, sparcv9, mips, mips64, avr]
+ AIX:
+arch: [x86, x86_64, ppc64le, ppc64, armv6, armv7, armv7hf, armv8, sparc, sparcv9, mips, mips64, avr, ppc64]
compiler:
sun-cc:
... | [ConanClientConfigParser->[proxies->[get_conf],default_profile->[get_item],storage->[get_conf],__init__->[__init__]]] | Load the environment variables from a file. The default client configuration for the Windows MinGW client. | ppc64 is already there |
@@ -122,9 +122,9 @@ func (je *journeyEnricher) enrichSynthEvent(event *beat.Event, se *SynthEvent) e
case "step/screenshot_ref":
fallthrough
case "screenshot/block":
- add_data_stream_index.SetEventDataset(event, "browser_screenshot")
+ add_data_stream_index.SetEventDataset(event, "browser.screenshot")
case ... | [enrichSynthEvent->[MergeEventFields,SetID,GetValue,SetEventDataset,createSummary,ToMap,Put],enrich->[enrich,MergeEventFields,enrichSynthEvent,Timestamp,Now,IsZero],createSummary->[Sub,Errorf,MergeEventFields],NewV1,String,Errorf] | enrichSynthEvent adds the synth event to the event object. | How is this related? |
@@ -1112,10 +1112,7 @@ namespace System.Windows.Forms
//
int[] structData = new int[] { baseStructSize, 0, 0, 0, 0 };
- if (unicode)
- {
- structData[4] = unchecked((int)0xFFFFFFFF);
- }
+ structData[4] = unchecked((int)0xFFFFFFFF);
... | [DataObject->[SetData->[SetData],GetCanonicalFormatEtc->[GetCanonicalFormatEtc],ContainsFileDropList->[GetDataPresent],EnumDAdvise->[EnumDAdvise],DataStore->[GetData->[GetData,GetMappedFormats],SetData->[SetData],GetFormats->[GetFormats,GetMappedFormats,GetDistinctStrings],GetDataPresent->[GetFormats,GetDataPresent]],F... | Save the file list to handle. private int i = 0 ;. | is this this needed? |
@@ -145,7 +145,14 @@ class RowAsDictJsonCoder(coders.Coder):
"""
def encode(self, table_row):
- return json.dumps(table_row)
+ # The normal error when dumping NAN/INF values is:
+ # ValueError: Out of range float values are not JSON compliant
+ # This code will catch this error to emit an error that... | [BigQuerySource->[__init__->[RowAsDictJsonCoder,_parse_table_reference]],BigQueryWriter->[__exit__->[_flush_rows_buffer],Write->[_flush_rows_buffer]],BigQuerySink->[schema_as_json->[schema_list_as_object->[schema_list_as_object],schema_list_as_object],__init__->[RowAsDictJsonCoder,validate_write,validate_create,_parse_... | Encode a sequence of tokens. | Do you know the performance impact of this change ? |
@@ -84,9 +84,8 @@ namespace System.Security.Cryptography
{
Interop.Crypto.CheckValidOpenSslHandle(ctx);
Interop.Crypto.EvpCipherSetCcmNonceLength(ctx, nonce.Length);
- Interop.Crypto.EvpCipherSetCcmTag(ctx, tag);
-
Interop.Crypto.EvpCipherSe... | [AesCcm->[DecryptInternal->[CreateOpenSslCryptographicException,Clear,CheckValidOpenSslHandle,EvpCipherSetKeyAndIV,EvpCipherSetCcmNonceLength,EvpCipherCreatePartial,Decrypt,Empty,Fail,EvpCipherSetInputLength,Cryptography_AuthTagMismatch,EvpCipherSetCcmTag,EvpCipherUpdate,GetCipher,Length],ImportKey->[ToArray,nameof],Di... | Internal method to decrypt the given ciphertext. | Was this a bug? If so, was a test failing? |
@@ -341,6 +341,13 @@ def _new_xy_plot(x_range=None, y_range=None, plot_width=None, plot_height=None,
tool_objs.append(tool_obj)
+ #Checking for repeated tools
+ _tools_in_list = [i.__str__().split(" ")[0][:-1] for i in tool_objs]
+ repeat_tool = [_tools_in_list.count(i)>1 for i in _too... | [_materialize_colors_and_alpha->[get_default_color]] | Create a new Plot object with x and y values. Plots a single missing - value block of content. Returns a datasource and a list of names corresponding to the n - dimensional iterable of strings and This function is called by the base class to add a new to the list of arrays. | why no use `__name__` instead of `__str__` with all the slices? |
@@ -152,6 +152,8 @@ public abstract class AbstractClient extends AbstractEndpoint implements Client
@Override
public void run() {
try {
+ if (cancelFutureIfOffline()) return;
+
if (!isConnected()) {
... | [AbstractClient->[getLocalAddress->[getLocalAddress],getRemoteAddress->[getRemoteAddress],disconnect->[destroyConnectStatusCheckCommand],toString->[getLocalAddress,getRemoteAddress],getAttribute->[getAttribute],connect->[initConnectStatusCheckCommand,getRemoteAddress,isConnected],close->[close,disconnect],isConnected->... | initConnectStatusCheckCommand - init connect status check command. | Can be considered plus `{}` to Increase readability |
@@ -585,8 +585,13 @@ func (sg *stepGenerator) generateStepsFromDiff(
//
// Note that if we're performing a targeted replace, we already have the correct inputs.
if prov != nil && !sg.isTargetedReplace(urn) {
+ // Increment the sequence number (if it's known) before calling check so we get a new autoname
... | [AnalyzeResources->[getProviderResource],GenerateSteps->[isTargetedUpdate],generateSteps->[isTargetedForUpdate,isTargetedReplace],determineAllowedResourcesToDeleteFromTargets->[getTargetDependents],diff->[isTargetedReplace,providerChanged],calculateDependentReplacements->[loadResourceProvider],generateStepsFromDiff->[i... | generateStepsFromDiff generates steps from a diff of the old state and new state. This is a helper method that is used to perform a replacement on a resource. This is a very simple implementation of the logic that is used to perform a resource deletion and This function returns a list of steps that can be performed whe... | This is the main place where we're incrementing it seems. Right? Why is it under `prov != nil && !sg.isTargetedReplace(urn)` condition? Looks like otherwise we don't even call Check. In other words, if we *are* doing targeted replace, will sequence auto-increment? |
@@ -3,6 +3,18 @@ using System.Collections.Generic;
namespace Dynamo.Graph.Workspaces
{
+ /// <summary>
+ /// Enum containing the different types of package dependency states.
+ /// </summary>
+ internal enum PackageDependencyState
+ {
+ Loaded,
+ IncorrectVersion,
+ Missing,
+ ... | [PackageDependencyInfo->[ToString->[ToString],GetHashCode->[GetHashCode]],PackageInfo->[ToString->[ToString],GetHashCode->[GetHashCode]]] | PackageInfo is a base class for all of the components of a package. The type of reference this dependency is. | Where is this set and how? |
@@ -35,6 +35,7 @@ class Magma(CMakePackage):
homepage = "http://icl.cs.utk.edu/magma/"
url = "http://icl.cs.utk.edu/projectsfiles/magma/downloads/magma-2.2.0.tar.gz"
+ version('2.4.0', 'fe15b98a0c4fed3eec6dc7a0c36765c4')
version('2.3.0', '9aaf85a338d3a17303e0c69f86f0ec52')
version('2.2.0', '6c1... | [Magma->[post_install->[install],cmake_args->[,spec,extend,satisfies],depends_on,conflicts,version,patch,variant,run_after]] | Creates a new object. Returns a list of arguments for the cmake command. | could you provide the sha256 hash? |
@@ -19,7 +19,7 @@ namespace Microsoft.Extensions.Logging.Abstractions
/// <param name="state">The state for which log is being written.</param>
/// <param name="exception">The log exception.</param>
/// <param name="formatter">The formatter.</param>
- public LogEntry(LogLevel logLevel,... | [No CFG could be retrieved] | Creates a new object that represents a single log entry. | - [x] Perhaps formatter can be nullable too |
@@ -556,9 +556,11 @@ def test_repr():
"""Test repr of Raw."""
sfreq = 256
info = create_info(3, sfreq)
- r = repr(RawArray(np.zeros((3, 10 * sfreq)), info))
+ raw = RawArray(np.zeros((3, 10 * sfreq)), info)
+ r = repr(raw)
assert re.search('<RawArray | 3 x 2560 (10.0 s), ~.* kB, data loaded... | [_test_raw_reader->[assert_named_constants],test_5839->[raw_factory],test_test_raw_reader->[_test_raw_reader],_read_raw_arange->[_RawArange]] | Test repr of Raw. | This just testst `__repr__`, you need to call `raw._repr_html_()` |
@@ -118,6 +118,7 @@ namespace Dynamo.Graph.Workspaces
/// <summary>
/// Indicates whether this dependency is loaded in the current session
/// </summary>
+ [Obsolete("This property is obsolete", false)]
bool IsLoaded { get; set; }
}
| [PackageDependencyInfo->[ToString->[ToString],GetHashCode->[GetHashCode]],PackageInfo->[ToString->[ToString],GetHashCode->[GetHashCode]]] | Dependencies property of a package dependency Replies the set of nodes that are referenced by the package. | Why can't we just remove this property? These are new, unreleased interfaces and classes, right? |
@@ -90,3 +90,7 @@ def generate_fxa_state():
def camel_case(snake):
parts = snake.split('_')
return parts[0] + ''.join(part.capitalize() for part in parts[1:])
+
+
+def redirect_for_login(request):
+ return HttpResponseRedirect(default_fxa_login_url(request))
| [default_fxa_login_url->[fxa_login_url,path_with_query]] | Convert a snake_case string to a camelCase string. | So, we use the `.helpers` module usually to store template relevant code, e.g filters and jinja-functions but not general utilities (usually at least, there are some here). Can this move to `accounts.utils` instead? |
@@ -760,6 +760,7 @@ def get_kit_info(rawfile, allow_unknown_format, standardize_names=None,
is_exg = [ch['type'] in (KIT.CHANNEL_EEG, KIT.CHANNEL_ECG)
for ch in channels]
exg_gains /= 2 ** (adc_stored - 14)
+ exg_gains[exg_gains == 0] = ad_to_volt
conv_factor[is_exg] = exg_gains
sq... | [EpochsKIT->[__init__->[_call_digitization]],read_raw_kit->[RawKIT],read_epochs_kit->[EpochsKIT],RawKIT->[__init__->[_call_digitization]],UnsupportedKITFormat->[__init__->[__init__]],get_kit_info->[_read_dir,UnsupportedKITFormat]] | Extract all the information from the KIT file. Read the basic information from the SQD file. Missing NMR - MGH information. Read KIT file and return a list of missing or missing channel information. Get the n - th un - filtered state of a node. | FYI with this change I get 2.55 V on that channel at that time, feel free to try it |
@@ -5540,3 +5540,9 @@ def has_bool_item(typ: ProperType) -> bool:
return any(is_named_instance(item, 'builtins.bool')
for item in typ.items)
return False
+
+
+# TODO: why can't we define this as an inline function?
+# Does mypyc not support them?
+def is_exactly_literal_type(t: Type) -... | [TypeChecker->[get_op_other_domain->[get_op_other_domain],analyze_async_iterable_item_type->[accept],visit_try_without_finally->[check_assignment,accept],visit_class_def->[accept],iterable_item_type->[lookup_typeinfo],visit_for_stmt->[accept_loop],visit_operator_assignment_stmt->[check_final,try_infer_partial_generic_t... | Return True if type is bool or a union with a bool item. | Do you mean lambda by "inline function"? What exactly goes wrong when you try? |
@@ -14,6 +14,7 @@ class PySalib(PythonPackage):
maintainers = ['schmitts']
+ version('1.4.4', sha256='50a6459088700f55261a683752818530d14ede30cece2c324ac94d4b9e288b6d')
version('1.4.0.1', sha256='dbf6e865af9f3be82a79cf64889ed66d6d3b6803f0c22a242a112876789d49e7')
depends_on('py-setuptools@38.3:',... | [PySalib->[depends_on,version]] | Python implementations of commonly used sensitivity analysis methods. | Can you update the dependencies? I see a new build dep on setuptools-scm and build/run deps on importlib-metadata and wheel (wheel should not be in install_requires since it isn't required for build or run...) |
@@ -378,9 +378,12 @@ def rescale_gradients(model: Model, grad_norm: Optional[float] = None) -> Option
return None
-def get_metrics(
- model: Model, total_loss: float, num_batches: int, reset: bool = False
-) -> Dict[str, float]:
+def get_metrics(model: Model,
+ total_loss: float,
+ ... | [rescale_gradients->[sparse_clip_norm],get_batch_size->[get_batch_size],evaluate->[get_metrics],get_metrics->[get_metrics]] | Gets the metrics but sets loss to the total loss divided by the num_batches so. | I think this needs to be before the bit above where we replace the `metrics["loss"]` with a float, as it won't have been all_reduced (and then subsequently won't be all reduced correctly, as we've lost the reference to the tensor) |
@@ -44,12 +44,13 @@ import org.nuxeo.ecm.platform.relations.api.impl.LiteralImpl;
import org.nuxeo.ecm.platform.relations.api.impl.ResourceImpl;
import org.nuxeo.ecm.platform.relations.api.impl.StatementImpl;
import org.nuxeo.ecm.platform.relations.api.util.RelationConstants;
+import org.nuxeo.ecm.platform.test.Plat... | [TestPublishRelationsListener->[testKeepCommentsAndRelationsFromOldProxy->[addSomeComments,addSomeRelations],testCopyRelationsFromWork->[addSomeComments,addSomeRelations],testDeleteRelationsOnOriginalDoc->[addSomeRelations]]] | This method imports the given object as a sequence of features. region TestPublishRelationsListener class. | Can you revert this change? It doesn't looks like linked to your fix. |
@@ -14,7 +14,7 @@
* limitations under the License.
*/
-import {getExistingServiceForDoc} from './service';
+import {getExistingEmbedServiceForDoc} from './service';
/**
| [No CFG could be retrieved] | Gets the url replacements for a given node or a given document. | Maybe `EmbedScoped`. It typically isn't an `EmbedService` |
@@ -751,6 +751,8 @@ func (s *Stack) runPulumiCmdSync(
args ...string,
) (string, string, int, error) {
var env []string
+ debugEnv := fmt.Sprintf("%s=%s", "PULUMI_DEBUG_COMMANDS", "true")
+ env = append(env, debugEnv)
if s.Workspace().PulumiHome() != "" {
homeEnv := fmt.Sprintf("%s=%s", pulumiHomeEnv, s.Works... | [RefreshConfig->[Name,Workspace,RefreshConfig],Destroy->[Name,Workspace],Info->[Name,Workspace],Refresh->[Name,Workspace],SetConfig->[Name,Workspace,SetConfig],Cancel->[Name,Workspace],History->[Name,Workspace],Outputs->[Name,Workspace],Up->[Name,Workspace],RemoveConfig->[Name,Workspace,RemoveConfig],SetAllConfig->[Nam... | runPulumiCmdSync executes the command synchronously and returns the stdout stderr and error. | Was this intended? |
@@ -290,13 +290,3 @@ func replacePod(name string) error {
}
return removePods([]string{name}, rmOptions, false)
}
-
-func MapOptions() {
- createOptions.Cpus = infraOptions.CPUS
- createOptions.CpusetCpus = infraOptions.CPUSetCPUs
- createOptions.Hostname = infraOptions.Hostname
- createOptions.InfraConmonPidFile ... | [StringVar,DefineCreateFlags,NewPodSpecGenerator,SetNormalizeFunc,Ints,SetInterspersed,NewSpecGenerator,WriteFile,Itoa,GetAllLabels,NumCPU,IsExist,New,StringVarP,NormalizedName,ToPodSpecGen,Errorf,Debugf,DefineNetFlags,Wrapf,NetFlagsToNetOptions,OpenExclusiveFile,RegisterFlagCompletionFunc,CreateInit,PullImage,SyncQuie... | RemovePods - remove all pods from the container. | It looks like this has moved to common. I'd like to suggest a name change to make it less generic there. Perhaps PodsMapOptions? |
@@ -89,6 +89,7 @@ public class RowBasedGrouperHelper
final DateTime fudgeTimestamp = GroupByStrategyV2.getUniversalTimestamp(query);
final Grouper.KeySerdeFactory<RowBasedKey> keySerdeFactory = new RowBasedKeySerdeFactory(
fudgeTimestamp,
+ query.getContextSortByDimsFirst(),
query.get... | [RowBasedGrouperHelper->[RowBasedKeySerde->[comparator->[compare->[compare]],toByteBuffer->[getTimestamp,getDimensions],fromByteBuffer->[RowBasedKey],entryComparator->[compare->[getTimestamp,compare,getDimensions]]],RowBasedColumnSelectorFactory->[makeMathExpressionSelector->[size],makeDimensionSelectorUndecorated->[lo... | Creates a new grouper accumulator pair. private int dimensionSelectors = null ;. | Maybe extract the above 9 lines into a method, for making `comparator()` body more readable? |
@@ -3195,18 +3195,6 @@ void make_uppercase(char *string)
string[i] = toupper((unsigned char)string[i]);
}
-/* This function is defined here due to visibility of bio_err */
-int opt_printf_stderr(const char *fmt, ...)
-{
- va_list ap;
- int ret;
-
- va_start(ap, fmt);
- ret = BIO_vprintf(bio_err,... | [No CFG could be retrieved] | Set the next - of - type header and CRL from the given string. region Parameter allocation. | Windows build doesnt like this change.. libtestutil.lib(libtestutil-lib-options.obj) : error LNK2005: opt_printf_stderr already defined in libapps.lib(libapps-lib-opt_err.obj) test\aesgcmtest.exe : fatal error LNK1169: one or more multiply defined symbols found NMAKE : |
@@ -348,6 +348,7 @@ namespace Js
JavascriptString* methodName = JavascriptString::FromVar(methodNameProperty);
int argumentsCount = TaggedInt::ToInt32(argumentsCountProperty);
+ BOOL staticMethod = JavascriptConversion::ToBoolean(staticMethodProperty, scriptContext);
BOOL forceInline... | [InjectJsBuiltInLibraryCode->[InitializePrototypes],EntryJsBuiltIn_RegisterFunction->[RecordDefaultIteratorFunctions,GetPrototypeFromName,RecordCommonNativeInterfaceBuiltIns],EntryJsBuiltIn_RegisterChakraLibraryFunction->[GetPrototypeFromName]] | Registers a new function in the built - in object. This function is called when a class is built - in and the JS code that is used. | May want to add `Assert(Is())` for staticMethod and forceInline above (forceInline isn't your change but the remaining properties all have asserts). aliasProperty also doesn't have an assert, but I can't see where its used? |
@@ -613,6 +613,13 @@ type TeamLoader interface {
ClearMem()
}
+type DeviceEKStorage interface {
+ Put(ctx context.Context, generation keybase1.EkGeneration, deviceEK keybase1.DeviceEk) (err error)
+ Get(ctx context.Context, generation keybase1.EkGeneration) (deviceEK keybase1.DeviceEk, err error)
+ GetAll(ctx cont... | [No CFG could be retrieved] | HandlerUserChanged is called when a user has seen a unique identifier in the system. Get - get the last known object from the cache. | I'm surprised @oconnor663 let you get away with `DeviceEk` rather than `DeviceEphemeralKeyInOtherWordsAKeyThatIsNotPersisted` :) |
@@ -425,7 +425,10 @@ build_dir = partial(
'-b', '--build', '--build-dir', '--build-directory',
dest='build_dir',
metavar='dir',
- help='Directory to unpack packages into and build in.'
+ help='Directory to unpack packages into and build in. '
+ 'Initial build would still take place in direc... | [only_binary->[Option,set,FormatControl],_handle_only_binary->[getattr,fmt_ctl_handle_mutual_exclude],exists_action->[Option],trusted_host->[Option],extra_index_url->[Option],make_option_group->[add_option,option,OptionGroup],constraints->[Option],check_install_build_global->[getname->[getattr],any,fmt_ctl_no_binary,wa... | Adds package names to the set of packages to be installed. Adds global options and options to the setup. py file. | - typo: `directory` |
@@ -623,8 +623,8 @@ namespace Kratos
Properties::Pointer p_elem_prop = r_model_part.CreateNewProperties(0);
// In case the StructuralMechanicsApplciation is not compiled we skip the test
- if (!KratosComponents<ConstitutiveLaw>::Has("LinearElastic3DLaw"))
- return v... | [CreateModelPart->[IntegrationPoints,SetValue,size,constitutive_law_vector,Execute,Nodes,KRATOS_CHECK_LESS_EQUAL,GetValueOnIntegrationPoints,GetGeometry,GetIntegrationMethod,ZeroVector,Clone,CreateNewProperties,Elements,Parameters,GetProcessInfo,AddNodalSolutionStepVariable,CreateModelPart]] | Tests if the given process elements are in the case of a 3D basis. unknown element in the model. | Since we are thinking of moving this to the core I would use sth else Probably the solid-elements are suited best |
@@ -231,7 +231,9 @@ public class DatabaseUpgradeChecker implements SystemIntegrityChecker {
_upgradeMap.put("4.4.3", new DbUpgrade[] {new Upgrade443to450(), new Upgrade450to451(), new Upgrade451to460()});
- _upgradeMap.put("4.5.0", new DbUpgrade[] {new Upgrade450to451(), new Upgrade451to460()});
+ ... | [DatabaseUpgradeChecker->[check->[upgrade],runScript->[runScript],upgrade->[runScript]]] | Creates a mapping from version numbers to their corresponding upgrade class. Upgrade - related functions. | missing Upgrade451to460 class, I'll add that. |
@@ -75,9 +75,6 @@ class AmpInstagram extends AMP.BaseElement {
/** @private {?Element} */
this.iframe_ = null;
- /** @private {?Promise} */
- this.iframePromise_ = null;
-
/** @private {?string} */
this.shortcode_ = '';
| [No CFG could be retrieved] | Component which embeds a single node with a specific shortcode. The data - shortcode attribute is required for the element. | This is actually used in testing, so `@visibleForTesting`. |
@@ -34,6 +34,8 @@ func PGPDecryptWithBundles(g *GlobalContext, source io.Reader, sink io.Writer, k
return PGPDecrypt(g, source, sink, opkr)
}
+// PGPDecrypt only generates warnings about insecure _message_ signatures, not
+// _key_ signatures - that is handled by engine.PGPDecrypot.
func PGPDecrypt(g *GlobalConte... | [Copy,NewReader,CheckDetachedSignature,Decode,ReadMessage,Errorf,ReadAll,Debug] | PGPDecryptWithBundles decrypts a message using a given key ring. ReadMessage reads a message from source and decrypts it if it is signed. | is ` engine.PGPDecrypot.` a typo? |
@@ -0,0 +1,5 @@
+class AddSupportWebmentionsToArticles < ActiveRecord::Migration[6.0]
+ def change
+ add_column :articles, :support_webmentions, :boolean, default: false
+ end
+end
| [No CFG could be retrieved] | No Summary Found. | I'm not saying this can go here, but right now the articles table has 76 columns (according to `article.attributes.keys.size`) and I think we should weigh carefully wether or not we add another one especially given that (a) it will conceivably be false for a majority of the articles (at least until webmentions gain wid... |
@@ -59,9 +59,14 @@ def module(*args):
shell=True,
executable="/bin/bash")
+ # Make sure the command succeeded
+ module_output = module_p.communicate()
+ if module_p.returncode != 0:
+ raise EnvironmentParseErro... | [get_path_from_module_contents->[match_flag_and_strip->[strip_path],match_pattern_and_strip->[get_path_args_from_module_line,strip_path],match_flag_and_strip,match_pattern_and_strip],load_module->[module],path_from_modules->[module]] | The main function of the module. Either the new LD_LIBRARY_PATH or SPACKIGNORE is restored. | Looks like you want to return `module_output[0]` here and below for a meaningful error message, at least for the `command not found` error being reported here. |
@@ -70,7 +70,12 @@ public class QuarkusDevModeTest
static {
System.setProperty("java.util.logging.manager", "org.jboss.logmanager.LogManager");
- rootLogger = (Logger) LogManager.getLogManager().getLogger("");
+ java.util.logging.Logger logger = LogManager.getLogManager().getLogger("");
+ ... | [QuarkusDevModeTest->[beforeEach->[close->[close]],addResourceFile->[addResourceFile,sleepForFileChanges],modifyResourceFile->[sleepForFileChanges],setDevModeRunnerJarFile->[setDevModeRunnerJarFile],afterEach->[close],deleteResourceFile->[sleepForFileChanges]]] | This class is used to test against a specific . The Supplier that is invoked when a new object is created. | So this line is useless? |
@@ -380,6 +380,7 @@ class ColorSpec(DataSpec):
return "ColorSpec(field=%r)" % self.field
class Include(object):
+ ''' Property to include other property mixins under a prefix. '''
def __init__(self, delegate):
if not (isinstance(delegate, type) and issubclass(delegate, HasProps)):
| [Tuple->[validate->[is_valid]],Array->[__init__->[_validate_type_param]],RelativeDelta->[__init__->[Enum]],Property->[__set__->[validate,matches,__get__,transform],is_valid->[validate]],List->[validate->[is_valid],__init__->[_validate_type_param]],MetaHasProps->[__new__->[__new__,autocreate]],Either->[validate->[is_val... | Initialize the object with a delegate object. | This is not a property, just a placeholder. |
@@ -134,6 +134,9 @@ namespace PInvokeTests
[DllImport("LayoutClassNative")]
private static extern bool SimpleExpLayoutClassByRef(ExpClass p);
+ [DllImport("LayoutClassNative")]
+ private static extern bool SimpleBlittableSeqLayoutClass_Null(Blittable p);
+
[DllImport("LayoutCl... | [StructureTests->[BlittableClassByInAttr->[ValidateBlittableClassInOut],SealedBlittableClassByInAttr->[ValidateSealedBlittableClassInOut],ExplicitClass->[SimpleExpLayoutClassByRef],Main->[BlittableClassByInAttr,SealedBlittableClassByInAttr,ExplicitClass,SealedBlittableClassByOutAttr,SequentialClass,SealedBlittableClass... | Returns true if a Blittable has a reference to it. | Should we add one for the non-blittable case too? |
@@ -123,6 +123,15 @@ export class LocalSubscriptionPlatformRenderer {
if (expr && evaluateExpr(expr,
/** @type {!JsonObject} */(renderState))) {
candidate.classList.add('i-amphtml-subs-display');
+ if (candidate.getAttribute('subscriptions-service')
+ && candidate.ge... | [No CFG could be retrieved] | Determines if there are any actions that should be rendered in the given node. | Can we make it a default? I think it's better to disable then explicitly enable. E.g. `if (... && candidate.getAttribute('subscriptions-decorate') !== 'false')` |
@@ -281,10 +281,13 @@ abstract class AbstractNioChannel<C extends SelectableChannel & WritableByteChan
if (newWriteBufferSize == 0 || newWriteBufferSize < lowWaterMark) {
if (newWriteBufferSize + messageSize >= lowWaterMark) {
highWaterMarkCounter.decrement... | [AbstractNioChannel->[WriteRequestQueue->[retainAll->[retainAll],size->[size],toArray->[toArray],addAll->[addAll],contains->[contains],poll->[poll],peek->[peek],element->[element],remove->[remove],containsAll->[containsAll],removeAll->[removeAll],clear->[clear],add->[add],offer->[offer],isEmpty->[isEmpty],iterator->[it... | poll method. | write -> Write |
@@ -1396,7 +1396,7 @@ extern "C" {
int freeheap = ESP.getFreeHeap();
static int laststack, lastheap, laststack2;
if ((laststack != freestack) || (lastheap != freeheap) || (laststack2 != (int)br_esp8266_stack_proxy_usage())) {
- Serial.printf("%s:%s(%d): FREESTACK=%d, STACK2USAGE=%d, FREEHEAP=%d\n", ... | [No CFG could be retrieved] | load private key from stream _BearSSLSerialPrint - Prints a string to the BearSSL serial port. | instead of casting to int, add "l" (lower case L) for size_t, which is long, i.e.: 0x%08X => 0x%08Xl |
@@ -106,7 +106,7 @@ namespace NServiceBus.MessageInterfaces.MessageMapper.Reflection
/// </summary>
public T CreateInstance<T>()
{
- return (T)CreateInstance(typeof(T));
+ return (T) CreateInstance(typeof(T));
}
/// <summary>
| [MessageMapper->[GenerateImplementationFor->[Any,GetConstructor,TypeHandle,IsSpecialName,CreateTypeFrom,IsVisible,Name,MethodHandle,EmptyTypes,StartsWith],InitType->[IsSimpleType,TypeHandle,InitType,MethodHandle,IsGenericTypeDefinition,GetConstructor,IsAssignableFrom,ContainsKey,EmptyTypes,FieldType,GetTypeName,Instanc... | Create an instance of the class if it is not there. | I think we just changed the settings to not use the space between casts? |
@@ -76,7 +76,8 @@ public class ResourceNameEndpointURIBuilder extends AbstractEndpointURIBuilder
}
int x = address.indexOf(":", y);
- if (x > -1)
+ int repeatedColon = address.indexOf("::", y);
+ if (x > -1 && x != repeatedColon)
{
String resourceIn... | [ResourceNameEndpointURIBuilder->[setEndpoint->[getHost,getUserInfo,equals,indexOf,substring,setProperty,length,getPath,getAuthority],getLog]] | Method to set the endpoint. | use a regex to contemplate both cases |
@@ -1219,11 +1219,11 @@ public class SimpleDoFnRunner<InputT, OutputT> implements DoFnRunner<InputT, Out
Instant windowExpiry = window.maxTimestamp().plus(allowedLateness);
if (TimeDomain.EVENT_TIME.equals(spec.getTimeDomain())) {
checkArgument(
- !outputTimestamp.isAfter(target),
+ ... | [SimpleDoFnRunner->[TimerInternalsTimerMap->[set->[set,TimerInternalsTimer],get->[get,TimerInternalsTimer]],DoFnStartBundleArgumentProvider->[Context],DoFnProcessContext->[pipelineOptions->[getPipelineOptions],sideInput->[sideInput],schemaElement->[element],timerFamily->[window,timestamp,getNamespace],state->[state,get... | Checks if the output timestamp is set and if not sets it. | Actually now that I think about it, the output timestamp really should be before the end of the window. That is a requirement on `WindowFn.assign` and other timestamp adjusting methods. |
@@ -14,7 +14,7 @@ export default class <%=jhiPrefixCapitalized%>UserManagementView extends Vue {
}
});
}
- public init(userId: <% if (pkType === 'String' || pkType === 'UUID') { %>string<% } else { %>number<% } %>): void {
+ public init(userId: <% if (user.primaryKeyType === 'String' || user.primaryK... | [No CFG could be retrieved] | missing param userId. | two spaces after `'String'` |
@@ -119,6 +119,12 @@ public class CopyDataPublisher extends DataPublisher implements UnpublishedHandl
this.recoveryHelper = new RecoveryHelper(this.fs, state);
this.recoveryHelper.purgeOldPersistedFile();
+
+ Config config = ConfigUtils.propertiesToConfig(state.getProperties());
+
+ this.srcDataFileVe... | [CopyDataPublisher->[getCommitSequence->[compare->[compare]]]] | Publish all files in a collection of WorkUnitStates to all files in a CopyableDataset. | this should be this.srcDataFileVersionStrategy? |
@@ -1327,8 +1327,10 @@ out:
D_FREE(ec_agg_in->ea_remove_recxs.ca_arrays);
D_FREE(ec_agg_in->ea_remove_eps.ca_arrays);
}
+
if (rpc)
crt_req_decref(rpc);
+
ABT_eventual_set(stripe_ud->asu_eventual, (void *)&rc, sizeof(rc));
}
| [No CFG could be retrieved] | This function is called from the DSS_AddRemoveRecords and DSS_AddRemove This function updates the parity and stripe number of an entry in the network. | I think after successful obj_req_create, we can probably assert that rpc != NULL but we should initialize it to NULL if we do that. |
@@ -51,6 +51,16 @@
</select>
</p>
+<p>
+ <label>
+ <?php esc_html_e( 'Open images in new tab?', 'jetpack' ); ?>
+ </label>
+ <input
+ type="checkbox"
+ name="<?php echo esc_attr( $this->get_field_name( 'target' ) ); ?>"
+ <?php checked( $instance['target'] ); ?>
+ />
+</p>
<p>
<div>
<?php esc_html_e( 'Wh... | [get_field_name] | View a list of all fields View function for displaying the calendar component that has a radio on the nofilter image. | I would place the checkbox before the label, I think it feels more natural. |
@@ -210,6 +210,9 @@ public class QueueImpl extends CriticalComponentImpl implements Queue {
private final Runnable deliverRunner = new DeliverRunner();
+ //This lock is used to prevent deadlocks between direct and async deliveries
+ private final ReentrantLock deliverLock = new ReentrantLock();
+
privat... | [QueueImpl->[getDurableDeliveringCount->[getDurableMessageCount],scheduleDepage->[getName],configureExpiry->[getExpiryAddress],addConsumer->[debug],deleteAllReferences->[deleteAllReferences],configureSlowConsumerReaper->[equals,getName,cancel,debug],getMessageCount->[getMessageCount],getDeliveringCount->[getMessageCoun... | This class is used to initialize the queue memory and metrics. | Ouch really??? Seriouslly, this means we now have two different locking approaches in same class. Ignoring the perf impact, its dangerous. |
@@ -13132,6 +13132,13 @@ var poloniex = {
let timestamp = this.parse8601 (trade['date']);
let id = undefined;
let order = undefined;
+ let symbol = undefined;
+ if (!market) {
+ if ('currencyPair' in trade) {
+ let marketId = trade['marketId'];
+ ... | [No CFG could be retrieved] | Get a list of all objects. Get all return trades for a given market. | This opening bracket `{` is not closed |
@@ -355,6 +355,9 @@ void enable_all_steppers() {
ENABLE_AXIS_X();
ENABLE_AXIS_Y();
ENABLE_AXIS_Z();
+ #if ENABLED(SOFTWARE_DRIVER_ENABLE)
+ planner.axis_enabled = {true};
+ #endif
enable_e_steppers();
}
| [No CFG could be retrieved] | - Warrowing - GCC diagnostic push - Warrowing - GCC diagnostic ignore Event handler for all event - probe - related events. | I would rather see this use the following form, so that it is more clear that all three values are being set. What you have is _likely_ working due to the operators defined on the class, but this looks like a bug if this were normal array initialziation :) `planner.axis_enabled.set(true, true, true);` |
@@ -317,7 +317,7 @@ export class AmpList extends AMP.BaseElement {
const attributes = dict({
'ampListAttributes': {
'items': this.element.getAttribute('items') || 'items',
- 'singleItem': this.element.getAttribute('single-item'),
+ 'singleItem': this.element.hasAttribute('si... | [No CFG could be retrieved] | Provides a proxy to the ssr template rendering to the viewer. Schedules a render pass for the given data. | We should clarify in the PR description why `getAttribute` won't work (e.g., it doesn't work because different browsers have inconsistent behaviors on whether to return an empty string when the attribute doesn't exist). |
@@ -455,8 +455,8 @@ def sha256sum(filename):
:rtype: str
"""
sha256 = hashlib.sha256()
- with open(filename, 'rb') as f:
- sha256.update(f.read())
+ with open(filename, 'rU') as f:
+ sha256.update(f.read().encode('UTF-8'))
return sha256.hexdigest()
def cert_and_chain_from_full... | [dump_pyopenssl_chain->[dump_pyopenssl_chain],_get_sans_from_cert_or_req->[_load_cert_or_req],get_names_from_cert->[_get_names_from_cert_or_req],_get_names_from_cert_or_req->[_load_cert_or_req],get_sans_from_cert->[_get_sans_from_cert_or_req]] | Compute a sha256sum of a file. | While this is a nice solution for the way we currently use this function, I think it's probably worth making clear that newlines are converted in the docstring. |
@@ -185,6 +185,8 @@ QueryData genOsqueryExtensions(QueryContext& context) {
QueryData genOsqueryInfo(QueryContext& context) {
QueryData results;
+
+#ifndef WIN32
Row r;
r["pid"] = INTEGER(getpid());
r["version"] = kVersion;
| [genOsqueryExtensions->[TEXT,push_back,getExtensionSocket,getExtensions],genOsqueryInfo->[INTEGER,ok,pingExtension,STR,getpid,getInstance,push_back],genOsquerySchedule->[INTEGER,TEXT,BIGINT,getInstance,push_back],genOsqueryEvents->[INTEGER,state,hasStarted,restartCount,getType,isEnding,push_back,numEvents,numSubscripti... | Generate OS query information. | Why is this POSIX only? |
@@ -1193,7 +1193,7 @@ int ScheduleAgentOperations(EvalContext *ctx, Bundle *bp)
{
ClassBanner(ctx, type);
- PromiseType *sp = BundleGetPromiseType(bp, AGENT_TYPESEQUENCE[type]);
+ const PromiseType *sp = BundleGetPromiseType((Bundle *)bp, AGENT_TYPESEQUENCE[type]);
... | [No CFG could be retrieved] | This function is called from the main function of the class loader. It creates a file containing Check if the agent can access the given policy. | Ouch ! Do you promise us that BundleGetPromiseType() won't modify *bp ? ... and, of course, if you can promise that, why doesn't it admit it in its signature ? |
@@ -276,15 +276,13 @@ class NginxParser(object):
return False
- def add_server_directives(self, vhost, directives, replace, insert_at_top=False):
+ def add_server_directives(self, vhost, directives, insert_at_top=False):
"""Add or replace directives in the server block identified by vhost.
... | [_add_directive->[_parse_ssl_options,is_whitespace_or_comment,comment_directive,can_append,_find_location,_comment_out_directive],_parse_ssl_options->[load],_do_for_subarray->[_do_for_subarray],_remove_directives->[_find_location,_is_certbot_comment],NginxParser->[_update_vhost_based_on_new_directives->[parse_server,_g... | Checks if vhost has ssl on. | nit: "or replace" should be removed here. |
@@ -1 +1,5 @@
-require( "babel-polyfill" );
+// The babel polyfill sets the _babelPolyfill to true. So only load it ourselves if the variable is undefined or false.
+if ( typeof window._babelPolyfill !== "undefined" || ! window._babelPolyfill ) {
+ // eslint-disable-next-line global-require
+ require( "babel-polyfill" ... | [require] | Requires babel - polyfill. | `typeof window._babelPolyfill !== "undefined"` should be `typeof window._babelPolyfill === "undefined"` |
@@ -18,6 +18,8 @@ import os
import six
import pickle
import numpy as np
+import math
+import sys
import paddle
from paddle import compat as cpt
| [_append_block->[_collect_current_and_parent_var],_construct_params_and_buffers->[_load_persistable_vars,_remove_varname_suffix,_load_persistable_vars_by_program],_get_loaded_var_new_old->[_get_persistable_vars],_append_loaded_suffix_to_var->[_append_loaded_suffix,_get_persistable_vars],_rename_var_program_desc->[_gene... | Creates a n - dimensional array of objects from a model file. Returns a new object with the given version of the program. | remove these two import? |
@@ -207,8 +207,12 @@ class Shop(graphene.ObjectType):
)
@staticmethod
- def resolve_available_payment_gateways(_, info, currency: Optional[str] = None):
- return info.context.plugins.list_payment_gateways(currency=currency)
+ def resolve_available_payment_gateways(
+ _, info, currenc... | [Shop->[resolve_limits->[LimitInfo,Limits],resolve_domain->[Domain],resolve_available_shipping_methods->[resolve_available_shipping_methods],resolve_navigation->[Navigation],resolve_translation->[resolve_translation]]] | Resolve available payment gateways and external authentications. | Should we use `validate_one_of_args_is_in_query` here? |
@@ -189,11 +189,13 @@ class Agent:
}
now = pendulum.now("UTC")
+ self.logger.debug("Current process time {}".format(now.isoformat()))
result = self.client.graphql(
mutation,
variables={"input": {"tenantId": tenant_id, "before": now.isoformat()}},
)
... | [Agent->[agent_connect->[ConnectionError,type,print,format,info,query_tenant_id],agent_process->[bool,error,deploy_flows,update_states,len,_log_flow_run_exceptions,run,info,query_flow_runs],_verify_token->[AuthorizationError,graphql],start->[agent_connect,agent_process,heartbeat,max,keys,sleep],update_states->[Submitte... | Query the list of flow runs that need to be deployed and executed Return the flow_run of the query. | I'm happy to keep this in, but note that the timestamps will be included in the logging output as well. |
@@ -3336,14 +3336,14 @@ public class ConfigurationManagerImpl extends ManagerBase implements Configurati
}
/**
- * Check the tags parameters to the diskOffering
+ * Check the tags parameters to the disk/service offering
* <ul>
* <li>If tags is null, do nothing and return.</li>
- ... | [ConfigurationManagerImpl->[updateConfiguration->[start,updateConfiguration],commitVlan->[doInTransaction->[createVlanAndPublicIpRange]],deletePod->[checkIfPodIsDeletable],checkPodCidrSubnets->[getCidrAddress,getCidrSize],createPod->[createPod,checkPodAttributes],editPod->[editPod,podHasAllocatedPrivateIPs,checkPodAttr... | Updates the tags of the disk offering if is not null. | I think it would be interesting to use the same logic as the hostTags conditional here, allowing you to remove existing tags. |
@@ -114,8 +114,8 @@ class PipelineClient(PipelineClientBase):
config.redirect_policy,
config.retry_policy,
config.custom_hook_policy,
- config.logging_policy,
DistributedTracingPolicy(),
+ config.logging_policy,
... | [PipelineClient->[close->[__exit__],__exit__->[__exit__],__enter__->[__enter__]]] | Build a Pipeline object from the given configuration. | Maybe we should add proxy policy as well. |
@@ -523,6 +523,13 @@ class HTMLPage(object):
real_url = geturl(resp)
headers = resp.info()
+ content_type = headers.get('Content-Type', None)
+ if not content_type.lower().startswith('text/html'):
+ logger.debug('Skipping page %s because of Content-Type: ... | [PackageFinder->[find_requirement->[_sort_locations,mkurl_pypi_url],_sort_locations->[sort_path],_link_package_versions->[_known_extensions],_package_versions->[_sort_links]],get_requirement_from_url->[Link,splitext],HTMLPage->[get_page->[is_archive,add_page_failure,get_page,set_is_archive,add_page,too_many_failures]],... | Get a page from the cache. Get a object from the cache. | It is not a good idea to choose `None` as default and in the next line do `content_type.lower()` |
@@ -0,0 +1,18 @@
+# Bokeh imports
+from ..core.properties import Nullable, String
+from ..model import Model
+
+
+class MathText(Model):
+ """
+ Class for signaling you want you text converted to LaTex
+ """
+
+ text = Nullable(String, help="""
+ The text value to render.
+ """)
+
+ def __init__(se... | [No CFG could be retrieved] | No Summary Found. | `LaTeX` != `TeX` != `TeX` math. Besides this, you're not converting text to anything, but you're rendering `TeX` math formatted strings. If anything this is a marker indicating that an `str` value should be interpreted as `TeX` math, instead of a raw string, the same as we may have a `HTML` marker that indicates HTML c... |
@@ -0,0 +1,3 @@
+#include <stdint.h>
+
+const uint8_t b_m16_interleave[8] = { 0, 49, 49, 41, 90, 27, 117, 10 };
| [No CFG could be retrieved] | No Summary Found. | I'd put this directly into lib8tion.c instead. |
@@ -83,6 +83,7 @@ setup(
'msrest>=0.5.0',
'msrestazure>=0.4.32,<2.0.0',
'azure-common~=1.1',
+ 'azure-mgmt-core>=1.2.0,<2.0.0',
],
extras_require={
":python_version<'3.0'": ['azure-mgmt-nspkg'],
| [find_packages,setup,search,replace,read,format,join,RuntimeError,exists,open,Exception] | Requires that the nspkg package is installed. | Hi @turalf , Thanks for help fixing dependency in mgmt plane. I think msrestazure dependency can be removed for track2 package. would you help remove this line? Thanks! |
@@ -198,8 +198,8 @@ def gen_module(schema, algo, module):
yield " beta_constraints <- as.h2o(beta_constraints)"
yield " }"
elif algo == "generic":
- yield " # Required args: model_key"
- yield " if (is.null(model_key)) stop(\"argument 'model_key' must be provided\")"
+ ... | [main->[model_builders,init,vprint,gen_module,write_to_file],gen_module->[any,help_example_for,join,remove,help_extra_checks_for,help_references_for,help_epilogue_for,replace,help_details_for,help_extra_params_for,normalize_value,append,len,help_afterword_for,help_return_for,algo_to_modelname,wrap,help_preamble_for,get... | Generates a module that represents a single node - level . Yields a sequence of possible errors. Yields code for a object. Generate H2O function for training a single H2O model. Yields code for missing key - value pairs. | should the same be done for py? |
@@ -1250,17 +1250,11 @@ public class ITestPersistentProvenanceRepository {
repo.waitForRollover();
- try {
- repo.getEvent(0L, null);
- Assert.fail("getEvent() did not throw an Exception");
- } catch (final Exception e) {
- Assert.assertSame(expectedException,... | [ITestPersistentProvenanceRepository->[testIndexOnRolloverWithImmenseAttribute->[getEventReporter,createConfiguration],testIndexDirectoryRemoved->[getEventReporter,createConfiguration],testLineageReceiveDrop->[getEventReporter,createConfiguration],testAddAndRecover->[getEventReporter,createConfiguration],testIndexAndCo... | Test not authorized get specific event. This method creates a new index for the missing events. Checks that there are 7 events with ID s 3 through 10. | Why no DisabledOnOs? |
@@ -220,7 +220,7 @@ const (
keyvaultFlexVolumeAddonDestinationFilename string = "keyvault-flexvolume-installer.yaml"
dashboardAddonSourceFilename string = "kubernetes-dashboard.yaml"
dashboardAddonDestinationFilename string = "kubernetes-dashboard.yaml"
- reschedulerAddonSourceF... | [No CFG could be retrieved] | This function returns the path to the deployment file with the given names. This function is a helper function to find the source filename of the Azure Network Policy in the. | vote to change the name in `/etc/kubernetes/addons` as well |
@@ -355,8 +355,7 @@ cont_iv_prop_ent_create(struct ds_iv_entry *entry, struct ds_iv_key *key)
if (iv_entry == NULL)
D_GOTO(out, rc = -DER_NOMEM);
- memcpy(&root_hdl, entry->iv_value.sg_iovs[0].iov_buf,
- sizeof(root_hdl));
+ memcpy(&root_hdl, entry->iv_value.sg_iovs[0].iov_buf, sizeof(root_hdl));
uuid_copy(... | [No CFG could be retrieved] | create a property from a key find the entry in the dbtree and return the handle of the entry. | Whitespace only change |
@@ -1,8 +1,9 @@
# Copyright (c) Microsoft Corporation.
# Licensed under the MIT license.
-import os
import json
+import logging
+import os
import netifaces
from schema import Schema, And, Optional, Regex, Or, SchemaError
from nni.package_utils import create_validator_instance, get_all_builtin_names, get_builtin... | [AlgoSchema->[validate_class_args->[validate_class_args],validate->[validate_extras],validate_extras->[validate_class_args,missing_customized_keys],__init__->[setType,setPathCheck,setChoice]],NNIConfigSchema->[validate_annotation_content->[validate_search_space_content],validate->[validate,validate_extras],validate_pai... | Create a schema of the n - tuple of all possible values of a single key. A class that contains the data for the . | what is the order of imported object? `os` should be after `netifaces` in character order? |
@@ -1144,7 +1144,7 @@ namespace System.Text
return this;
}
- public StringBuilder Append(bool value) => Append(value.ToString());
+ public StringBuilder Append(bool value) => Append(value);
public StringBuilder Append(char value)
{
| [StringBuilder->[MakeRoom->[AssertInvariants,ThreadSafeCopy],CopyTo->[AssertInvariants,CopyTo],ChunkEnumerator->[MoveNext->[MoveNext]],ExpandByABlock->[AssertInvariants],ToString->[AssertInvariants],Remove->[AssertInvariants,ThreadSafeCopy],AssertInvariants]] | Append a sequence of characters to the end of this string builder. | This change seems unrelated... and like it's now just infinite recursion. |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.