patch stringlengths 18 160k | callgraph stringlengths 4 179k | summary stringlengths 4 947 | msg stringlengths 6 3.42k |
|---|---|---|---|
@@ -17,8 +17,8 @@ echo elgg_view_menu('title:widgets', [
[
'name' => 'widgets_add',
'href' => 'javascript: void(0)',
- 'text' => elgg_echo('widgets:add'),
- 'link_class' => 'elgg-button elgg-button-action elgg-lightbox',
+ 'text' => elgg_view_icon('cog') . ' ' . elgg_echo('widgets:add'),
+ 'link_clas... | [No CFG could be retrieved] | Displays a menu of widgets. | next time use the icon parameter to add icons to menu items |
@@ -286,8 +286,9 @@ namespace System.Collections.Immutable
{
Requires.NotNull(list, nameof(list));
- if (list.Count == 0 && startIndex == 0)
+ if (list.Count == 0)
{
+ // Avoid argument out of range exceptions.
return -1;
... | [ImmutableList->[IndexOf->[IndexOf],LastIndexOf->[LastIndexOf],Replace->[Replace],Remove->[Remove],RemoveRange->[RemoveRange]]] | This method returns the last index of the specified item in the specified list starting at the specified. | Both changes are potentially breaking changes. What use cases is this PR meant to address? Could you share an example (or better create an issue so that we can debate potential actions?). I'm assuming that this has something to do with `ImmutableList<T>` throwing ArgumentOutOfRangeException for certain inputs, but do n... |
@@ -101,9 +101,12 @@ func (c *RaftCluster) stop() {
return
}
- c.balancerWorker.stop()
-
c.running = false
+
+ close(c.quit)
+ c.wg.Wait()
+
+ c.balancerWorker.stop()
}
func (c *RaftCluster) isRunning() bool {
| [RemoveStore->[saveStore,GetStore],getRegion->[getRegion],bootstrapCluster->[start,getClusterRootPath],stop->[stop],createRaftCluster->[start,isRunning,getClusterRootPath],GetRaftCluster->[isRunning]] | stop stops the Raft cluster. | no need to wait balancer worker stopped? |
@@ -246,8 +246,10 @@ class TestCUDNN(TestConv2dOp):
self.op_type = "conv2d"
-class TestFP16CUDNN(TestCUDNN):
- def init_data_type(self):
+class TestFP16CUDNN(TestConv2dOp):
+ def init_op_type(self):
+ self.use_cudnn = True
+ self.op_type = "conv2d"
self.dtype = np.float16
... | [TestFP16CUDNN->[test_check_output->[CUDAPlace,is_float16_supported,is_compiled_with_cuda,check_output_with_place]],TestWith1x1->[init_test_case->[mod]],TestWithDilation->[init_test_case->[mod]],TestDepthwiseConv->[init_test_case->[mod]],conv2d_forward_naive->[pad,sum,zeros,range,mod],TestFP16CUDNNWithGroup->[test_chec... | Initialize the data type of the object. | `self.op_type` should be placed in `setUp`, because the unit tests of `test_conv2d_op.py` is all about `conv2d` and the difference is just `op_kernels`. |
@@ -132,6 +132,9 @@ DiminishingGroup GetDiminishingReturnsGroupForSpell(SpellInfo const* spellproto,
// Faerie Fire
else if (spellproto->SpellFamilyFlags[0] & 0x400)
return DIMINISHING_LIMITONLY;
+ // Feral Charge Root Effect
+ else if (spellproto->Id == ... | [LoadSpellRequired->[IsSpellRequiringSpell,GetFirstSpellInChain],CheckSpellGroupStackRules->[GetGroupStackFlags,GetSpellGroupSpecialFlags,GetSpellGroup],LoadSpellTalentRanks->[UnloadSpellInfoChains],GetSpellIdForDifficulty->[GetSpellDifficultyId],LoadSpellRanks->[LoadSpellTalentRanks],GetSpellWithRank->[GetSpellWithRan... | Returns the DiminishingGroup for the given spell. Missing tokens in the tree. Missing arguments in the SpellFamilyFlags field. Missing node - level flags based on spellfamily and mechanic flags Missing DIMINISHING_NONE DIMINISHING_BANISH DIMINISH. | it would be better to wrap those numbers into costants |
@@ -101,6 +101,7 @@ func (s StoreInfluence) ResourceSize(kind core.ResourceKind) int64 {
// OpStep describes the basic scheduling steps that can not be subdivided.
type OpStep interface {
fmt.Stringer
+ ConsumeConfVer() int
IsFinish(region *core.RegionInfo) bool
Influence(opInfluence OpInfluence, region *core.R... | [Check->[IsFinish],IsTimeout->[IsFinish],Influence->[GetStoreInfluence],IsFinish->[String],MarshalJSON->[String],TotalInfluence->[Influence],UnfinishedInfluence->[IsFinish,Influence],String->[IsFinish,String]] | GetStoreInfluence returns a StoreInfluence that can be used to determine the store difference uence is an op step that adds a region peer to the store. | em, I think `Consume` seems hard to understand. Actually, the step does not 'consume' the config version, but trigger the update of config version. How about something like `ExpectConfVarChange() bool`? |
@@ -13,7 +13,7 @@ import java.util.stream.Collectors;
*/
public class UserDTO {
- public static final int PASSWORD_MIN_LENGTH = 5;
+ public static final int PASSWORD_MIN_LENGTH = 4;
public static final int PASSWORD_MAX_LENGTH = 100;
@Pattern(regexp = "^[a-z0-9]*$")
| [No CFG could be retrieved] | DTO for a user. This class is used to store all the properties of the object. | I changed this from 5 to 4 because one of our default passwords ("user") is only 4 characters. |
@@ -17,10 +17,16 @@
*/
package org.apache.hadoop.ozone.container.ozoneimpl;
+import org.apache.hadoop.conf.StorageUnit;
import org.apache.hadoop.hdds.conf.Config;
import org.apache.hadoop.hdds.conf.ConfigGroup;
import org.apache.hadoop.hdds.conf.ConfigTag;
import org.apache.hadoop.hdds.conf.ConfigType;
+import... | [No CFG could be retrieved] | This class defines the configuration parameters for the container scrubber. Minimum time interval between two metadata scans by container scrubber. | How does type change affect existing config users may have? Are plain numbers still accepted and handled as if `B` suffix was specified? |
@@ -27,6 +27,8 @@ import org.apache.dubbo.rpc.cluster.Directory;
*/
public class BroadcastCluster implements Cluster {
+ public static final String NAME = "broadcast";
+
@Override
public <T> Invoker<T> join(Directory<T> directory) throws RpcException {
return new BroadcastClusterInvoker<T>(di... | [No CFG could be retrieved] | Join the specified directory with the current cluster. | ^_^, each `Cluster` has a name except this one. |
@@ -185,6 +185,11 @@ class ProductVariant(models.Model):
Product, related_name='variants', on_delete=models.CASCADE)
attributes = HStoreField(default={}, blank=True)
images = models.ManyToManyField('ProductImage', through='VariantImage')
+ handle_stock = models.BooleanField(
+ default=True,... | [ProductVariant->[get_absolute_url->[get_slug],get_ajax_label->[display_product,get_price],get_first_image->[get_first_image]],Product->[is_in_stock->[is_in_stock]]] | Returns the first image in the list of images. Get the quantity of an object. | Although I understood the purpose of this field from reading the code, this name sounds a bit too general to me. What about `track_inventory`? I think it would be more understandable. |
@@ -250,7 +250,7 @@ func (f pollingDeviationCheckerFactory) New(
}
fetcher, err := newMedianFetcherFromURLs(
- timeout,
+ timeout.Duration(),
initr.InitiatorParams.RequestData.String(),
urls)
if err != nil {
| [Stop->[Stop],consume->[Tick,Stop,Reset],Reset->[Stop],respondToAnswerUpdatedLog->[Reset],Start->[Start],pollIfEligible->[checkEligibilityAndAggregatorFunding],serveInternalRequests->[Start,Stop],New] | New creates a new instance of the polling deviation checker. | Shouldn't the `models.Duration` be pushed further down here? |
@@ -44,6 +44,10 @@ var config = {
//
testing: {
+ // Disables the End to End Encryption feature. Useful for debugging
+ // issues related to insertable streams.
+ // disableE2EE: false,
+
// P2P test mode disables automatic switching to P2P when there are 2
// particip... | [No CFG could be retrieved] | Configuration for a single component. Enables or disables the specified . | is it possible to specify it through the URL params? is that something we would want? if yes the it needs to be added to the whitelist, right? |
@@ -1335,7 +1335,7 @@ class CI_Email {
for ($i = 0, $c = count($this->_attachments), $z = 0; $i < $c; $i++)
{
$filename = $this->_attachments[$i]['name'][0];
- $basename = is_null($this->_attachments[$i]['name'][1])
+ $basename = $this->_attachments[$i]['name'][1] === NULL
? basename($filename) : $th... | [CI_Email->[_write_headers->[_get_protocol],_send_command->[_get_encoding],_build_message->[_write_headers,word_wrap,_get_content_type,_get_alt_message,_get_mime_message,_set_boundaries,_get_encoding,_get_protocol],_build_headers->[_get_message_id,set_header,clean_email],batch_bcc_send->[set_header,clean_email,_build_m... | Builds the message. This method is called to prepare the message. Returns an array of email attachments. This method reads the file and populates the final body and content. | Either revert or put parenthesis around this. |
@@ -1234,7 +1234,9 @@ class RandomRotation(torch.nn.Module):
"""
fill = self.fill
if isinstance(img, Tensor):
- if isinstance(fill, (int, float)):
+ if fill is None:
+ fill = [.0] * F._get_image_num_channels(img)
+ elif isinstance(fill, (int, fl... | [RandomAffine->[forward->[get_params]],_setup_angle->[_check_sequence_input],RandomPerspective->[forward->[get_params]],RandomCrop->[forward->[get_params]],GaussianBlur->[forward->[get_params]],RandomResizedCrop->[forward->[get_params]],ColorJitter->[forward->[get_params]],RandomRotation->[forward->[get_params]],Random... | Forward transformation of the image. | If we set fill as 0 in all the cases previously, we can skip this |
@@ -2321,7 +2321,8 @@ export default {
},
/**
- * Inits list of current devices and event listener for device change.
+ * Updates the list of current devices.
+ *
* @private
*/
_initDeviceList() {
| [No CFG could be retrieved] | Add listeners for the specified in the UI Add listeners to the UI to change the micDeviceId. | i looked at this and thought we could do it without `enumerateDevicesPromise`, but i guess not, since enumerate devices is callback-based? |
@@ -55,10 +55,5 @@ public class WordCountIT {
options.getJobName(), "output", "results"}));
WordCount.main(TestPipeline.convertToArgs(options));
- PipelineResult result =
- TestDataflowPipelineRunner.getPipelineResultByJobName(options.getJobName());
-
- assertNotNull("Result was null.", res... | [WordCountIT->[testE2EWordCount->[assertNotNull,assertEquals,getState,setOutput,getPipelineResultByJobName,convertToArgs,register,getJobName,join,getTempRoot,main,as]]] | Example of how to test E2E word count. | I like the explicit nature of the verifier here. Perhaps we can keep that -- not have a "default" verifier. |
@@ -675,6 +675,9 @@ class _BaseEpochs(ProjMixin, ContainsMixin, UpdateChannelsMixin,
Computes an average of all epochs in the instance, even if
they correspond to different conditions. To average by condition,
do ``epochs[condition].average()`` for each condition separately.
+
+ Will n... | [EpochsArray->[__init__->[copy,_detrend_offset_decim,drop_bad]],combine_event_ids->[copy],equalize_epoch_counts->[drop,drop_bad],_BaseEpochs->[equalize_event_counts->[_keys_to_idx,drop,drop_bad],plot_drop_log->[plot_drop_log],_get_data->[_get_epoch_from_raw,_detrend_offset_decim,_is_good_epoch,_project_epoch],get_data-... | Compute the average of all epochs in the instance even if they correspond to different conditions. | maybe something more like: > When picks is None and evoked contains only ICA channels, no channels are selected, which results in an error. This is because ICA channels are not considered data channels (they are of misc type) and only data channels are selected when picks is None. ? But I think that ICA channels not be... |
@@ -41,16 +41,15 @@ module GobiertoAttachments
# from the API, we can't remove it.
validates :file_digest, uniqueness: {
scope: :site_id,
- message: ->(object, data) do
+ message: -> (object, data) do
url = object.site.attachments.find_by!(file_digest: object.file_digest).url
- ... | [Attachment->[created_at->[created_at],content_type->[content_type],update_file_attributes->[file_digest]]] | This is a convenience method that allows you to add custom file attachments to a Gobier This is a simple method to provide a list of all the items in the system that are. | Do not use spaces between -> and opening brace in lambda literals<br>Use the lambda method for multiline lambdas.<br>Unused block argument - data. If it's necessary, use _ or _data as an argument name to indicate that it won't be used. |
@@ -106,6 +106,8 @@ void DistanceModificationProcess::CheckDefaultsAndProcessSettings(Parameters &rP
mAvoidAlmostEmptyElements = rParameters["avoid_almost_empty_elements"].GetBool();
mNegElemDeactivation = rParameters["deactivate_full_negative_elements"].GetBool();
mRecoverOriginalDistance = rParameters[... | [No CFG could be retrieved] | Initializes the embedded is_active property. Computes the nodal H value of the node. | I would suggest initializing vectors of variables (or references/pointers of variables) from the string-based input. This allows you to validate the input at construction (if KratosComponents does not have the variable, you will know it here) and minimizes (expensive) calls to KratosComponents<...>::Get(). |
@@ -41,15 +41,16 @@ def test_callouts(base_url, selenium):
@pytest.mark.smoke
@pytest.mark.nodata
@pytest.mark.nondestructive
+@pytest.mark.maintenance_mode
def test_header_displays(base_url, selenium):
page = HomePage(selenium, base_url).open()
- assert page.Header.is_displayed
- assert page.Header.is_m... | [test_header_displays->[HomePage],test_callouts->[HomePage,assert_valid_url,is_expected_stacking,get_attribute],test_masthead_displayed->[HomePage],test_header_signin->[str,HomePage,trigger_signin],test_footer_displays->[HomePage],test_header_platform_submenu->[show_platform_submenu,HomePage],test_hacks_blog->[HomePage... | Test header displays. | Is there a non-MM test that still tests this? |
@@ -350,7 +350,10 @@ public class Reviewer extends AnkiActivity {
*/
private Map<String, AnkiFont> mCustomFontsMap;
private String mCustomDefaultFontCss;
+ private String mCustomOverrideFontCss;
+ private String mThemeFontCss;
private String mCustomFontStyle;
+ private String mSystemicFon... | [Reviewer->[MyWebView->[onCheckIsTextEditor->[onCheckIsTextEditor],onScrollChanged->[onScrollChanged]],reloadCollection->[onPostExecute->[onCreate]],initLayout->[onClick->[lookUp,clipboardHasText]],onDestroy->[onDestroy],onOptionsItemSelected->[onOptionsItemSelected],onCreate->[onCreate,setFullScreen],onKeyDown->[onKey... | Private methods for the Card object. region EventManager API. | I think Systemic Font is unclear. What does this represent? |
@@ -401,7 +401,7 @@ static int aes_ocb_get_ctx_params(void *vctx, OSSL_PARAM params[])
p = OSSL_PARAM_locate(params, OSSL_CIPHER_PARAM_IV);
if (p != NULL) {
- if (ctx->base.ivlen != p->data_size) {
+ if (ctx->base.ivlen > p->data_size) {
ERR_raise(ERR_LIB_PROV, PROV_R_INVALID_IV_L... | [No CFG could be retrieved] | This function returns the number of parameters that can be used to generate the OCB cipher. - - - - - - - - - - - - - - - - - -. | Isn't the data_size the size of the pointer in the case of octet_ptr? |
@@ -8,4 +8,10 @@ def console_entry() -> None:
if __name__ == '__main__':
- main(None)
+ import cProfile
+ import pstats
+
+ cProfile.run('main(None)', 'profstats')
+ p = pstats.Stats('profstats')
+ p.sort_stats('time').print_stats(40)
+ #main(None)
| [console_entry->[main],main] | This is the main entry point for the module. | It looks like the temporary profiling code should be removed. |
@@ -93,7 +93,8 @@ public class HoodieJavaWriteClientExample {
List<HoodieRecord<HoodieAvroPayload>> recordsSoFar = new ArrayList<>(records);
List<HoodieRecord<HoodieAvroPayload>> writeRecords =
recordsSoFar.stream().map(r -> new HoodieRecord<HoodieAvroPayload>(r)).collect(Collectors.toList());
- c... | [HoodieJavaWriteClientExample->[main->[Path,size,Configuration,generateUpdates,addAll,info,initTableType,startCommit,valueOf,upsert,println,HoodieJavaEngineContext,close,exists,delete,generateInserts,getName,build,toList,getFs,collect,exit],getLogger,name]] | Example of how to write records in a table. Write records to the Hoodie. | would we just change the BaseJavaCommitActionExecutor#execute method to add `updateIndexAndCommitIfNeeded` method and align with BaseSparkCommitActionExecutor? |
@@ -5,6 +5,7 @@ require "test_helper"
module GobiertoAdmin
module GobiertoCalendars
class EventsIndexTest < ActionDispatch::IntegrationTest
+
def setup
super
@collection_path = admin_common_collection_path(collection)
| [EventsIndexTest->[test_person_event_filtering->[visit,within,with_signed_in_admin,with_javascript,assert,has_selector?,with_current_site,count],collection->[events_collection],site->[sites],test_person_published_events_index->[visit,within,with_signed_in_admin,has_link?,has_content?,published?,with_javascript,click_li... | Setup the missing admin collection. | Extra empty line detected at class body beginning. |
@@ -63,7 +63,7 @@ func resourceAwsVpcEndpointService() *schema.Resource {
},
"private_dns_name": {
Type: schema.TypeString,
- Computed: true,
+ Optional: true,
},
"service_name": {
Type: schema.TypeString,
| [Difference,GetChange,NewSet,IgnoreAws,StringSlice,Ec2KeyValueTags,Set,Ec2UpdateTags,Error,GetOk,HasChange,New,Errorf,Len,SetId,Bool,DescribeVpcEndpointServiceConfigurations,IgnoreConfig,ModifyVpcEndpointServiceConfiguration,Id,DeleteVpcEndpointServiceConfigurations,Get,Map,DescribeVpcEndpointServicePermissions,Printf,... | This function returns the aws - vpc - endpoint - service - create schema for the given resource ec2TagSpecificationsFromMap - returns a vpc - endpoint - service tag specification. | Leave `Computed: true` here as the value is computed if no explicit DNS name is specified. |
@@ -19,6 +19,7 @@
package org.apache.hudi.util;
import org.apache.hudi.common.model.HoodieRecordLocation;
+import org.apache.hudi.common.model.HoodieTableType;
import org.apache.hudi.common.table.HoodieTableMetaClient;
import org.apache.hudi.common.util.TablePathUtils;
import org.apache.hudi.exception.HoodieExce... | [StreamerUtil->[initTableIfNotExists->[getHadoopConf],getHoodieClientConfig->[getHoodieClientConfig],getTablePath->[getTablePath],getSourceSchema->[getSourceSchema]]] | Imports a single object. Imports the java. lang. Object from the Java source code. | Strange. Why the CI did not find the compile error before we merge relevant changes. |
@@ -73,6 +73,16 @@ func (r *defaultReporter) ReportVerifyFailure(componentName string, msg string)
fmt.Printf("%s\n", formatMessage(msg))
}
+func (r *defaultReporter) ReportCleanupSkip(componentName string, msg string) {
+ r.s.Stop()
+ fmt.Printf("[-] Skipping cleaning up for %s\n", componentName)
+ fmt.Printf("%s... | [ReportGenerateSuccess->[Printf,Stop],ReportVerifyStart->[Sprintf,Start],ReportCleanupErrored->[Printf,Stop],ReportVerifyFailure->[Printf,Stop],ReportCleanupSuccess->[Printf,Stop],ReportGenerateStart->[Sprintf,Start],ReportCleanupStart->[Sprintf,Start],ReportVerifyFinish->[Printf,Stop],ReportGenerateErrored->[Printf,St... | ReportVerifyFailure reports a failure to verify a component. | ohhhh we're reporting skipping cleanup . Worth switching the words around? Or am I overthinking it? |
@@ -47,7 +47,9 @@ namespace System.Threading.Tasks
// Run LongRunning tasks on their own dedicated thread.
Thread thread = new Thread(s_longRunningThreadWork);
thread.IsBackground = true; // Keep this thread from blocking process shutdown
+#if !TARGET_BROWSER
... | [ThreadPoolTaskScheduler->[NotifyWorkItemProgress->[NotifyWorkItemProgress]]] | Queues a task in the queue. | Please if-def out whole block to remove also `s_longRunningThreadWork` lambda |
@@ -18,6 +18,7 @@ func init() {
rootCmd.PersistentFlags().StringVar(&MainGlobalOpts.ConnectionName, "connection", "", "remote connection name")
rootCmd.PersistentFlags().StringVar(&MainGlobalOpts.RemoteConfigFilePath, "remote-config-path", "", "alternate path for configuration file")
rootCmd.PersistentFlags().Str... | [BoolVar,StringVar,PersistentFlags,Current] | +build - build. | Worth doing any validation on this? Making sure they gave us a positive integer between 0 and 65536, exclusive? |
@@ -241,6 +241,8 @@ class ClassAgnosticDetectionAdapter(Adapter):
parameters.update({
'output_blob': StringField(optional=True, default=None, description="Output blob name."),
'scale': NumberField(optional=True, default=1.0, description="Scale factor for bboxes."),
+ 'scale... | [FaceBoxesAdapter->[prior_boxes->[calculate_anchors_zero_level,calculate_anchors],calculate_anchors_zero_level->[calculate_anchors],process->[prior_boxes,_extract_predictions,nms]],FasterRCNNONNX->[process->[_extract_predictions]],TwoStageDetector->[process->[_extract_predictions]],MTCNNPAdapter->[_extract_predictions-... | Return a dictionary of parameters for the class. | @eaidova Here are changes I've made to support several scales for bboxes. I wasn't find a way to pass to `scale` parameter both the number and list of 2 numbers, so I added the new `scales` parameter. Is it appropriate or I missed some way to do it? Feel free to criticize me |
@@ -441,7 +441,7 @@ class Propal extends CommonObject
$localtaxes_type=getLocalTaxesFromRate($txtva,0,$this->thirdparty,$mysoc);
$txtva = preg_replace('/\s*\(.*\)/','',$txtva); // Remove code into vatrate.
- $tabprice=calcul_price_total($qty, $pu, $remise_percent, $tx... | [Propal->[valid->[fetch],info->[fetch],create->[addline],classer_facturee->[classifyBilled],createFromClone->[create],create_from->[create]]] | Adds a line to the current unit. Diese une total TTC et le total TTC et le total TTC et Diese un objeto nueva nueva avec propale lign This method is used to initialize the object variables related to a node in the tax2 table. | This means you decide to work with quantity that are decimals and calculated with a prorata of time defined by start and end date. All users won't want to work this way, so this must be an option. Also this will bock the PR integration, for all the 19 modified files. it is recommanded when a lot of files are impacted, ... |
@@ -7,15 +7,16 @@ import (
"net"
"net/http"
"os"
- "regexp"
"strconv"
"strings"
"time"
"unicode"
+ testutil "github.com/openshift/origin/test/util"
kapiv1 "k8s.io/api/core/v1"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
"k8s.io/apimachinery/pkg/labels"
+ "k8s.io/apimachinery/pkg/util/wait"
kcl... | [ExpectNoError,TempFile,CoreV1,Duration,Close,Compile,WriteFile,Itoa,Error,ReadFile,Args,Marshal,HandleFunc,Logf,Create,Fprintln,Execute,Failf,Endpoints,Name,Remove,ToLower,ToUpper,Serve,Pods,ReplaceAll,Printf,Write,Listen,Println,Sprintf,ParseLabelsOrDie,ConfigMaps,Unmarshal,List,String,Parse,Sleep,Run,WaitForPods] | ParsePods parses a json file defined in the CL config and returns a struct with the parsed retryCount is the number of retries to retry. | Not sure we need to export this? |
@@ -28,14 +28,7 @@ import hudson.FilePath;
import hudson.Functions;
import hudson.Util;
import hudson.console.ConsoleLogFilter;
-import hudson.model.Computer;
-import hudson.model.Executor;
-import hudson.model.ExecutorListener;
-import hudson.model.Node;
-import hudson.model.Queue;
-import hudson.model.Slave;
-impo... | [SlaveComputer->[getRetentionStrategy->[getNode,getRetentionStrategy],setNode->[setNode],getClassLoadingTime->[call],getResourceLoadingCount->[call],getNode->[getNode],grabLauncher->[getLauncher],getDelegatedLauncher->[getLauncher],taskCompleted->[taskCompleted],taskCompletedWithProblems->[taskCompletedWithProblems],ge... | This function imports the given object into the Software. Imports the package with all the necessary dependencies. | Please do not squash imports in the production code. It may cause ambiguity in some edge cases. |
@@ -501,7 +501,7 @@ namespace MonoGame.Tools.Pipeline
Encoding encoding;
try {
encoding = Encoding.GetEncoding(CultureInfo.CurrentCulture.TextInfo.OEMCodePage);
- } catch (NotSupportedException) {
+ } catch (Exception ex) when (ex is NotSupportedException... | [PipelineController->[IncludeDirectory->[IncludeDirectory],LoadTemplates->[GetFiles],AskSaveProject->[SaveProject],GetFiles->[GetFiles],DoBuild->[FindMGCB],Undo->[Undo],IncludeFolder->[GetCurrentPath],NewItem->[GetCurrentPath],Exit->[AskSaveProject],NewFolder->[GetCurrentPath],ImportProject->[ImportProject],UpdateConte... | Do the build. | MonoGame is using an older version of C# (C# 5?), so this will have to handle both exceptions in separate catch blocks. |
@@ -50,7 +50,7 @@ func newDestroyCmd() *cobra.Command {
if preview || yes ||
confirmPrompt("This will permanently destroy all resources in the '%v' stack!", string(s.Name())) {
- return s.Destroy(pkg, root, debug, engine.DestroyOptions{
+ return s.Destroy(pkg, root, debug, engine.UpdateOptions{
D... | [StringVar,Name,RunFunc,IntVarP,StringVarP,QName,Destroy,BoolVarP,PersistentFlags,BoolVar] | SuggestFor is a list of possible commands to suggest the stack to be destroyed. Allow P resource operations to run in parallel at once. | at the same time, i'm a fan of primary matching flag (eg DryRun: dryrun) below ... not a huge deal, just seems nice to me. |
@@ -257,13 +257,13 @@ public final class RecordFormatter {
enum WindowSchema {
- SESSION(SessionWindowedDeserializer::new),
+ SESSION(WindowSchema::newSessionWindowedDeserializer),
HOPPING(WindowSchema::newTimeWindowedDeserializer),
TUMBLING(WindowSchema::newTimeWindowedDeserializer);
- priv... | [RecordFormatter->[formatRowTime->[format],delayedFormat->[format]]] | Wrap a named deserializer. | Off-topic, but just wanted to check you have it on your radar to split out a `SR_JSON` out of the `JSON` format? |
@@ -248,7 +248,7 @@ namespace Microsoft.Xna.Framework.Input.Touch
foreach (var touch in temp)
{
if (touch.State != TouchLocationState.Released)
- ApplyTouch(_touchState, new TouchLocation(touch.Id, TouchLocationState.Released, touch.Position)... | [TouchPanelState->[ProcessTap->[GestureIsEnabled],ProcessPinch->[GestureIsEnabled],ReleaseAllTouches->[ApplyTouch],AddEvent->[ApplyTouch,AgeTouches,AddEvent],UpdateGestures->[GestureIsEnabled],ProcessDrag->[GestureIsEnabled],TouchCollection->[AgeTouches],ProcessHold->[GestureIsEnabled],ProcessDoubleTap->[GestureIsEnabl... | private private void ReleaseAllTouches - This method is called when there is no touch event in. | We don't use `DateTime` for timestamps anymore. The right fix here is to set this to `TouchPanelState.CurrentTimestamp`. |
@@ -61,5 +61,6 @@ __all__ = [
'BratsNumpyConverter',
'Cifar10FormatConverter',
'MNISTCSVFormatConverter',
- 'WMTConverter'
+ 'WMTConverter',
+ 'common_semantic_segmentation'
]
| [No CFG could be retrieved] | Get all the possible converters for a given type. | is there any reason to have different naming convention? |
@@ -144,13 +144,13 @@ exports.jsBundles = {
includePolyfills: false,
},
},
- 'amp-story-embed.js': {
+ 'amp-story-embed-manager.js': {
srcDir: './src/',
- srcFilename: 'amp-story-embed.js',
+ srcFilename: 'amp-story-embed-manager.js',
destDir: './dist',
minifiedDestDir: './dist',
... | [No CFG could be retrieved] | Define the dependencies of AMP. JS files for AMP4 AMP4 AMP4 AMP4 AMP4. | What's motivating the name change? This is still the JavaScript file for the `<amp-story-embed>` component. This new name implies that it manages `amp-story-embeds`, which it does not, except for the few lines of code at the end. |
@@ -292,13 +292,14 @@ public class IngestSegmentFirehoseFactory implements FirehoseFactory<InputRowPar
// segments to olders.
// timelineSegments are sorted in order of interval
- int index = 0;
+ int[] index = {0};
for (TimelineObjectHolder<String, DataSegment> timelineHolder : Lists.reverse(tim... | [IngestSegmentFirehoseFactory->[getUniqueMetrics->[getMetrics],connect->[apply->[]],getUniqueDimensions->[getDimensions]]] | Returns a list of all unique metrics in the specified timeline segments. | Using index variable as int as is, the compiler complains `"Variables used in lambda should be final or effectively final"`. The fix is to use an integer array with one element. Let me know if this is right. |
@@ -338,3 +338,13 @@ def get_voucher_discount_for_order(order: Order) -> Money:
def match_orders_with_new_user(user: User) -> None:
Order.objects.confirmed().filter(user_email=user.email, user=None).update(user=user)
+
+
+def generate_invoice_pdf_for_order(invoice):
+ logo_path = static_finders.find("images/... | [restock_fulfillment_lines->[get_order_country],order_needs_automatic_fullfilment->[order_line_needs_automatic_fulfillment],update_order_prices->[recalculate_order],restock_order_lines->[get_order_country],add_variant_to_order->[get_order_country],get_voucher_discount_for_order->[get_products_voucher_discount_for_order... | Match orders with a new user. | What about people using custom media storage? |
@@ -2045,7 +2045,7 @@ class Command(object):
raise ConanException("Unknown command %s" % str(exc))
if is_config_install_scheduled(self._conan) and \
- (command != "config" or (command == "config" and args[0] != "install")):
+ (command != "config" or (command =... | [Command->[export->[export],info->[info],install->[install],editable->[info],source->[source],remove->[remove,info],new->[new],_print_similar->[_commands],imports->[imports],upload->[upload],copy->[copy],download->[download],run->[_warn_python_version,_print_similar,_commands,_show_help],export_pkg->[export_pkg],test->... | Entry point for executing commands dispatcher to class methods. | args now is a tuple with a list ([]) that's why config install triggered the scheduler ... |
@@ -454,7 +454,7 @@ class CuraApplication(QtApplication):
# Misc.:
"ConsoleLogger", #You want to be able to read the log if something goes wrong.
"CuraEngineBackend", #Cura is useless without this one since you can't slice.
- "UserAgreement", #Our lawyers want every use... | [CuraApplication->[groupSelected->[getMultiBuildPlateModel],arrangeObjectsToAllBuildPlates->[getCuraSceneController],discardOrKeepProfileChangesClosed->[getGlobalContainerStack],arrangeAll->[getMultiBuildPlateModel],showMoreInformationDialogForAnonymousDataCollection->[log],run->[initialize],initialize->[initialize],_r... | Start the splash window phase. This method is called when the user clicks on a specific node in the system. It sets Initialize a specific object in the preferences. | This message will be useless after a while because it doesn't matter that this used to be a plug-in at some point. |
@@ -889,10 +889,10 @@ type Kube2IAMRole struct {
Policy string `json:"policy"`
}
-// Backup holds information about the backup interval and maximum.
+// Backup holds information about the backup schedule and maximum.
type Backup struct {
- // IntervalInSecond defines the interval in seconds how often a backup is ... | [No CFG could be retrieved] | Additional information about a specific resource in the Gardener. Required. | If they are optional then they should be pointers with `// +optional` tag and the `omitempty` struct tag. |
@@ -44,7 +44,16 @@ if __name__ == "__main__":
print('tracking_url:' + run.get_portal_url())
elif line == 'stop':
run.cancel()
- exit(0)
+ loop_count = 0
+ status = run.get_status()
+ # wait until the run is canceled
+ while status... | [ScriptRunConfig,Workspace,get_status,get_metrics,Experiment,cancel,get_portal_url,log,submit,add_argument,print,ArgumentParser,parse_args,get_details,split,RunConfiguration,ComputeTarget,dumps,readline,exit] | This function is called for each line in the log file. | do we need `exit(0)` in this place? |
@@ -35,7 +35,7 @@ public class UserHS implements User, Serializable {
@Field(store = Store.YES, analyze = Analyze.NO, indexNullAs = Field.DEFAULT_NULL_TOKEN)
private String surname;
- @Field(store = Store.YES, analyze = Analyze.NO, indexNullAs = Field.DEFAULT_NULL_TOKEN)
+ @Field(store = Store.YES, analyz... | [UserHS->[hashCode->[hashCode],equals->[getClass,equals]]] | Produces a class which implements the User interface. Constructor for the class. | this change is needed in the integrationstests also, to solve one of the CI failures. |
@@ -2677,6 +2677,9 @@ public class VolumeApiServiceImpl extends ManagerBase implements VolumeApiServic
}
// perform extraction
ImageStoreEntity secStore = (ImageStoreEntity)dataStoreMgr.getImageStore(zoneId);
+ if (secStore == null) {
+ throw new InvalidParameterValueExcepti... | [VolumeApiServiceImpl->[handleVmWorkJob->[handleVmWorkJob],orchestrateExtractVolume->[orchestrateExtractVolume],doesTargetStorageSupportDiskOffering->[doesTargetStorageSupportDiskOffering],attachVolumeToVmThroughJobQueue->[VmJobVolumeOutcome],createVolumeFromSnapshot->[createVolumeFromSnapshot],migrateVolumeThroughJobQ... | orchestrate extract volume. get the extractUrl from the volumeStoreRef. | What about the `VolumeVO uploadVolume` and the `GetUploadParamsResponse uploadVolume` , that also use `getImageStore` , will you also also handle the null returns there? |
@@ -19,6 +19,7 @@
import { Injectable } from '@angular/core';
import { Resolve, ActivatedRouteSnapshot, RouterStateSnapshot, Routes } from '@angular/router';
import { JhiResolvePagingParams } from 'ng-jhipster';
+import { map } from 'rxjs/operators';
import { UserRouteAccessService } from 'app/core/auth/user-rout... | [No CFG could be retrieved] | Creates an object that represents a single user in the system. User management section. | This import is unused. |
@@ -56,11 +56,9 @@
}
},
<%_ } _%>
- "lint": [{
- "project": "../../../tsconfig.json"
- },
+ "lint": [
{
- "project": "../../../tsconfig-aot.json"
+ "project": "../../../tsconfig.json"
}
],
"test": {
| [No CFG could be retrieved] | The main entry point for the application. YARN requires a spec to be included in the YARN spec. | can you try to lint this like the deleted line above ? |
@@ -152,7 +152,7 @@ public class ITWizardAndUpdateCenterTests extends AbstractTest {
userPage = userPage.navById(WizardPage.class, "checkNetwork");
assertTrue(userPage.hasError());
userPage.clearInput("nuxeo.ldap.url");
- userPage.fillInput("nuxeo.ldap.url", "ldap://ldap.testathon.net:... | [ITWizardAndUpdateCenterTests->[runWizardAndRestart->[getTestPassword]]] | Runs the Wizard and restarts the application. This method checks if the next page of the wizard contains a non - empty nuxeo Enter embedded IFrame and enter a new CAS . Select Modules and download screen . | Can't we find a host under our control to test LDAP connectivity rather than something on the internet? |
@@ -232,10 +232,16 @@ class Command(object):
help='Force install specified package ID (ignore settings/options)')
parser.add_argument("-r", "--remote", help='look in the specified remote server',
action=OnceArgument)
+ parser.add_argument("-or", ... | [Command->[upload->[upload],copy->[copy],package->[package],test->[test],export->[export],info->[info],_show_help->[check_all_commands_listed],install->[install],download->[download],run->[_commands,_show_help],create->[create],source->[source],user->[user],remove->[remove],new->[new],build->[build],export_pkg->[export... | Downloads a specific package from the remote and installs it into the local cache. This function is called from the command line interface. It can be either a file reference or. | If --package is an arg, I would call it --recipe |
@@ -51,9 +51,10 @@ public class IPySparkInterpreter extends IPythonInterpreter {
PySparkInterpreter.getPythonExec(getProperties()));
sparkInterpreter = getSparkInterpreter();
SparkConf conf = sparkInterpreter.getSparkContext().getConf();
- // only set PYTHONPATH in local or yarn-client mode.
+ ... | [IPySparkInterpreter->[getProgress->[getProgress],setupIPythonEnv->[setupIPythonEnv],getSQLContext->[getSQLContext],getJavaSparkContext->[getJavaSparkContext],open->[open],getSparkSession->[getSparkSession],close->[close],cancel->[cancel],getSparkInterpreter->[open]]] | Open the interpreter. | I think it's better to whitelist instead of a blacklist. also we should check the `master` - other places people are using with mesos, kubernetes etc. |
@@ -134,6 +134,7 @@ public class DruidInputSource extends AbstractInputSource implements SplittableI
@Nullable
@JsonProperty
+ @JsonInclude(Include.NON_NULL)
public Interval getInterval()
{
return interval;
| [DruidInputSource->[getTimelineForSegmentIds->[getInterval],withSplit->[DruidInputSource],createWindowedSegmentIdFromTimeline->[getInterval],createSplits->[createSplits],estimateNumSplits->[createSplits]]] | Gets the interval of the given . | Is it better to add this annotation at the class-level? Seems reasonable to not include any fields in JSON if they are null. |
@@ -39,7 +39,7 @@ electron.ipcRenderer.on('ELECTRON_INTERNAL_RENDERER_SYNC_WEB_FRAME_METHOD', (eve
electron.ipcRenderer.on('ELECTRON_INTERNAL_RENDERER_ASYNC_WEB_FRAME_METHOD', (event, requestId, method, args) => {
const responseCallback = function (result) {
- event.sender.send(`ELECTRON_INTERNAL_BROWSER_ASYNC... | [No CFG could be retrieved] | Initialize the global variable and register the methods that are called by the ipc renderer. The main entry point for the command line. | Does this handle array `results` since `typeof []` is also `'object'`? |
@@ -185,6 +185,7 @@ public class BeamAggregationTransforms implements Serializable {
aggregators.add(BeamBuiltinAggregations.createMin(call.type.getSqlTypeName()));
break;
case "SUM":
+ case "$SUM0":
aggregators.add(BeamBuiltinAggregations.createSum(call.type.g... | [BeamAggregationTransforms->[AggregationAdaptor->[addInput->[addInput],mergeAccumulators->[mergeAccumulators],getAggregatorOutput->[extractOutput],createAccumulator->[createAccumulator],getAccumulatorCoder->[getAccumulatorCoder]],AggregationAccumulatorCoder->[decode->[AggregationAccumulator,decode],encode->[encode]]]] | Adds the necessary fields to the aggregation list. Adds an aggregate to the list of aggregators. | This one raises the issue that we maybe should start our test coverage of operators with a bunch of these internal variants that Beam SQL may already support, at least partly. (this one is probably a hack) |
@@ -1117,6 +1117,14 @@ func (mod *modContext) genResource(res *schema.Resource) (string, error) {
return fmt.Sprintf("pulumi.Output[%s]", ty)
})
+ // Write out Python property getters for all inputs if this is a provider resource because all inputs are implicitly outputs.
+ if res.IsProvider {
+ mod.genProperti... | [importTypeFromToken->[tokenToModule,getRelImportFromRoot],importResourceFromToken->[tokenToResource,getRelImportFromRoot],genPropertyConversionTables->[genHeader],addEnum->[add],genInit->[genHeader,hasTypes,submodulesExist,isEmpty],pyType->[pyType,tokenToResource],isEmpty->[isEmpty],addResource->[add],genConfig->[genH... | genResource generates code for a resource This function is used to generate a class definition with optional parameters. Print out the description of the object in the given writer. This function is only valid when passed in combination with a valid opts. | I'm actually not sure we want to handle this here. It doesn't look like we generate equivalent getters for the Provider resource in any of the other languages. If we do want to add these, I wonder if this should be something that gets defined in the schema, basically mirroring the InputProperties in Properties. Then th... |
@@ -152,9 +152,8 @@ int EVP_CipherInit_ex(EVP_CIPHER_CTX *ctx, const EVP_CIPHER *cipher,
skip_to_init:
#endif
/* we assume block size is a power of 2 in *cryptUpdate */
- OPENSSL_assert(ctx->cipher->block_size == 1
- || ctx->cipher->block_size == 8
- || ctx->cipher->block_... | [No CFG could be retrieved] | region EncryptionContext Functions private private functions. | We tend not to like `OPENSSL_assert` these days because it causes the library to crash even in production builds. I prefer `ossl_assert` (crash in debug builds, return an error in production builds). Or failing that just `assert`. Style nit: Please use "== 0" rather than "!" here. |
@@ -29,9 +29,11 @@ func (cfg *Config) RegisterFlags(f *flag.FlagSet) {
// RegisterFlagsWithPrefix registers flags with prefix.
func (cfg *Config) RegisterFlagsWithPrefix(prefix string, f *flag.FlagSet) {
+ cfg.prefix = prefix
f.IntVar(&cfg.MaxRecvMsgSize, prefix+".grpc-max-recv-msg-size", 100<<20, "gRPC client ma... | [DialOption->[DialOption,CallOptions],RegisterFlagsWithPrefix->[RegisterFlags,RegisterFlagsWithPrefix]] | RegisterFlagsWithPrefix registers flags with a given prefix. | should be `... use -%s.grpc-compression` now. |
@@ -25,6 +25,7 @@ class PyCvxopt(PythonPackage):
# Required dependencies
depends_on('python@2.7:')
+ depends_on('python@2.7:3.7.999', when='@:1.1.9')
depends_on('py-setuptools', type='build')
depends_on('blas')
depends_on('lapack')
| [PyCvxopt->[setup_build_environment->[set,join],install_test->[python],depends_on,version,on_package_attributes,variant,run_after]] | Creates a object that can be used to create a convex optimization of a random number Sets up the build environment for the given sequence number. | I think python should be `type=('build', 'link', 'run'))` |
@@ -29,6 +29,10 @@ module Idv
vendor_validator.errors if form_valid?
end
+ def vendor_reasons
+ vendor_validator.reasons if form_valid?
+ end
+
def vendor_params
finance_type = idv_form.finance_type
{ finance_type => idv_form.idv_params[finance_type] }
| [FinancialsStep->[vendor_params->[idv_params,finance_type],vendor_errors->[form_valid?,errors],complete?->[form_valid?,success?],submit->[params,idv_params,financials_confirmation,complete?],attr_reader]] | check if there are any errors for a specific vendor type. | if `form_valid?` that means we didn't talk to our vendor, correct? Otherwise we want reasons for both success and failure right? |
@@ -25,6 +25,10 @@ func newEnvInitCmd() *cobra.Command {
return errors.New("missing required environment name")
}
+ if _, staterr := os.Stat(workspace.EnvPath(tokens.QName(args[0]))); staterr == nil {
+ return fmt.Errorf("environment '%v' already exists", args[0])
+ }
+
return lumiEngine.InitEnv(a... | [InitEnv,New,RunFunc] | Initialization of environment variables. | Random aside: as I am burning the ships, I keep running into tokens. It feels like a useless abstraction in a world where we don't have a runtime. And in fact, we freely cast (like this) everywhere and seldom check invariants like I had originally intended. It feels like unidiomatic Go. Do you vote to rip and remove th... |
@@ -177,11 +177,13 @@ var _ = g.Describe("[sig-cli] oc adm must-gather", func() {
expectedDirectoriesToExpectedCount := map[string]int{
path.Join(pluginOutputDir, "audit_logs", "kube-apiserver"): 1000,
path.Join(pluginOutputDir, "audit_logs", "openshift-apiserver"): 10, // openshift apiservers don't nec... | [RemoveAll,KubeClient,Size,By,CoreV1,BeADirectory,Expect,OAuthAuthorizeTokens,HaveOccurred,TempDir,BeAnExistingFile,BeTrue,Close,It,AdminConfigClient,HasPrefix,Walk,NewForConfigOrDie,WaitForServiceAccount,Stat,Succeed,Args,OAuthAccessTokens,AsAdmin,GenerateOAuthTokenPair,ResolveLatestTaggedImage,ImageV1,To,Errorf,Names... | Takes a directory containing the audit logs and returns the count of the files that were found. Minute checks if there are any tokens that need to be logged in the audit directory. | Why do we count the number of audit events? This seems to be error-prone. Checking if the audit logs contain some events is not enough? |
@@ -72,6 +72,13 @@ class Jetpack_Twitter_Timeline_Widget extends WP_Widget {
'modules/widgets/twitter-timeline-admin.js'
)
);
+
+ wp_enqueue_style(
+ 'twitter-timeline-admin-css',
+ plugins_url( 'twitter-timeline-admin.css', __FILE__ ),
+ array(),
+ JETPACK__VERSION
+ );
}
}
| [Jetpack_Twitter_Timeline_Widget->[form->[get_docs_link]]] | Enqueue admin scripts. | lets prefix this with jetpack as well |
@@ -168,7 +168,7 @@ public class QuarkusBootstrap implements Serializable {
appModelFactory.setEnableClasspathCache(true);
}
}
- return new CuratedApplication(this, appModelFactory.resolveAppModel(), classLoadingConfig);
+ return new CuratedApplication(this, appModel... | [QuarkusBootstrap->[Builder->[build->[createClassLoadingConfig,QuarkusBootstrap]]]] | Bootstrap the application. if there is a bootstrap classloading config that is not loaded from application. properties then we. | You don't need to pass this in as a constructor argument, as it has access to QuarkusBootstrap. |
@@ -27,7 +27,10 @@
#include <daos_srv/vos.h>
#include <daos/object.h> /* for daos_unit_oid_compare() */
+#include <daos/checksum.h>
+#include <daos_srv/srv_csum.h>
#include "vos_internal.h"
+#include "evt_priv.h"
/*
* EV tree sorted iterator returns logical entry in extent start order, and
| [No CFG could be retrieved] | This function is used to create a new object. This function is called when a new physical entry is coalesced. | why we need this? |
@@ -186,6 +186,9 @@ public class QueryResource implements QueryCountStatsProvider
final String currThreadName = Thread.currentThread().getName();
try {
+ final Map<String, Object> responseContext = new MapMaker().makeMap();
+ responseContext.put(DirectDruidClient.QUERY_START_TIME, System.currentTi... | [QueryResource->[getFailedQueryCount->[get],doPost->[equals,Resource,withId,getType,makeMap,nanoTime,toString,setName,isDebugEnabled,remove,warn,getDefaultQueryTimeout,of,createContext,isAuthorized,makeRequestMetrics,withOverriddenContext,emit,writeValueAsString,empty,log,success,RequestLogLine,getNames,getRemoteAddr,D... | POST a single node in the database. This method is used to handle a GET request for a single chunk of data. This method is called when a request is executed. It will log the query time the request Get a response object from the yielder. | Why not attach total bytes gathered as well? |
@@ -52,6 +52,11 @@ function createValidator(jdlObject, logger = console) {
checkForErrors: () => {
checkForApplicationErrors();
jdlObject.forEachApplication(jdlApplication => {
+ const blueprints = jdlApplication.getConfigurationOptionValue('blueprints');
+ ... | [No CFG could be retrieved] | Creates a validator for a given object. Check for all possible errors in the application. | This message implies the validator knows about the context where it's being used, meaning the validator knows we're using it to generate applications. It shouldn't. What about something like "Blueprints are being used, the JDL validation phase is skipped."? |
@@ -52,8 +52,6 @@ class ExtruderStack(CuraContainerStack):
return super().getNextStack()
def setEnabled(self, enabled: bool) -> None:
- if "enabled" not in self._metadata:
- self.setMetaDataEntry("enabled", "True")
self.setMetaDataEntry("enabled", str(enabled))
self.e... | [ExtruderStack->[_onPropertiesChanged->[getNextStack],_getMachineDefinition->[getNextStack],getProperty->[getNextStack],setCompatibleMaterialDiameter->[getCompatibleMaterialDiameter],getApproximateMaterialDiameter->[getCompatibleMaterialDiameter]]] | Enable or disable the node. | Nitpicking: This will also emit a signal if the setEnabled didn't actually change (it was true and it's set to true again) |
@@ -46,6 +46,16 @@ public class CacheWritingMessageHandler extends AbstractMessageHandler {
private final Map<Expression, Expression> cacheEntryExpressions = new LinkedHashMap<Expression, Expression>();
private final GemfireTemplate gemfireTemplate = new GemfireTemplate();
+
+ private boolean autoStartup;
+
+ pu... | [CacheWritingMessageHandler->[parseCacheEntries->[getValue,entrySet,put,size],handleMessageInternal->[doInGemfire->[putAll],size,getPayload,parseCacheEntries,isTrue,execute],setCacheEntries->[getValue,size,getKey,parseExpression,put,clear,entrySet],afterPropertiesSet,GemfireTemplate,setRegion,notNull]] | Implementation that writes a message to a GemFire region. region - > GemFire. | No; it doesn't go on the `MessageHandler` it's set on the consumer - see `ConsumerEndpointFactoryBean`. `isAutoStartup()` is a method on `SmartLifecycle`. |
@@ -208,6 +208,10 @@ export class IntersectionObserver extends Observable {
* @private
*/
flush_() {
+ if (!this.iframe_) {
+ return;
+ }
+
this.flushTimeout_ = 0;
if (!this.pendingChanges_.length) {
return;
| [No CFG could be retrieved] | Send a batch of post messages to all interested windows. | If `!this.iframe` will this `IntersectionObserver` be reused. Do we need to do some clean up here? We can probably set `this.boundFlush = null`, `this.pendingChanges_ = null` here? |
@@ -62,6 +62,15 @@ func NewResponse(meshCatalog catalog.MeshCataloger, proxy *envoy.Proxy, _ *xds_d
}
clusters = append(clusters, localCluster)
+ if featureflags.IsRoutesV2Enabled() {
+ // if this service is associated with a trafficsplit service, add a local cluster for the apex service
+ for _, splitService :... | [NewSet,Msgf,GetCertificateCommonName,Add,GetPodUID,GetCertificateSerialNumber,Error,GetServicesFromEnvoyCertificate,GetLocalClusterNameForService,IsPrometheusScrapingEnabled,GetServiceAccountFromProxyCertificate,Contains,IsEgressEnabled,Err,ListAllowedOutboundServicesForIdentity,MarshalAny,IsBackpressureEnabled,IsSynt... | Construct a service cluster for the given service. GetCertificateSerialNumber returns the last unique identifier for the cluster. | I am not sure why a traffic split configuration should impact local clusters (on the uptream). Since traffic split is a client side configuration, why does this affect the configuration at the server side? |
@@ -56,7 +56,10 @@ def _generate_metadata_legacy(install_req):
command_desc='python setup.py egg_info',
)
+ # Return the metadata directory.
+ return install_req.find_egg_info()
+
def _generate_metadata(install_req):
- # type: (InstallRequirement) -> None
- install_req.prepare_pep... | [_generate_metadata->[prepare_pep517_metadata],_generate_metadata_legacy->[make_setuptools_shim_args,debug,ensure_dir,format,join,call_subprocess],getLogger] | Generate metadata for a legacy package. | A follow up PR will move this method's contents into this file. |
@@ -254,14 +254,11 @@ if ($optioncss != '') {
if ($search_ref) {
$param .= '&search_ref='.urlencode($search_ref);
}
-if ($saerch_day) {
- $param .= '&search_day='.urlencode($search_day);
-}
-if ($saerch_month) {
- $param .= '&search_month='.urlencode($search_month);
+if ($search_date_start) {
+ $param.= '&search_da... | [fetch_object,jdate,order,getNomUrl,initHooks,select_comptes,plimit,executeHooks,loadLangs,select_types_paiements,escape,close,showCheckAddButtons,showFilterAndCheckAddButtons,query,trans,num_rows,select_year,multiSelectArrayWithCheckbox] | Creates a list of n - ary objects. This function print a hidden input that can be used to display a list of supplier payments. | We must always keep the detail of the 3 component (day, month, year) for search component so we shoul dhave if ($search_date_startday) { if ($search_date_startmonth) { .. |
@@ -857,9 +857,10 @@ var VideoLayout = {
* @param object
*/
updateLocalConnectionStats (percent, object) {
- let resolutions = object.resolution;
+ const { framerates, resolutions } = object;
object.resolution = resolutions[APP.conference.getMyUserId()];
+ object.framera... | [No CFG could be retrieved] | Updates the local and remote stats of a single video. Hide all the indicators. | Do we have docs for this "bubble" ? |
@@ -372,7 +372,8 @@ def test_combine_channels():
# Test good cases
combine_channels(raw, good)
- combine_channels(epochs, good)
+ combined_epochs = combine_channels(epochs, good)
+ assert np.array_equal(combined_epochs.events, epochs.events)
combine_channels(evoked, good)
combine_channels... | [test_read_ch_adjacency->[all,_TempDir,todense,any,dict,partial,diagonal,assert_equal,read_ch_adjacency,len,savemat,join,array,raises,a],test_find_ch_adjacency->[getnnz,_compute_ch_adjacency,read_raw_bti,read_raw_ctf,assert_equal,data_path,len,read_raw_fif,read_raw_kit,find_ch_adjacency,join,raises,pick_types],test_get... | Test combine channels on Raw Epochs and Evoked. Tests if a sequence of images is unique within a combined standard deviation. | use from numpy.testing import assert_array_equal assert_array_equal(combined_epochs.events, epochs.events) |
@@ -1,5 +1,5 @@
class ProfileField < ApplicationRecord
- include ActsAsProfileField
+ WORD_REGEX = /\b\w+\b/.freeze
# Key names follow the Rails form helpers
enum input_type: {
| [ProfileField->[type->[check_box?],validates,include,enum,belongs_to]] | The ProfileField class is a class that represents a single ProfileField object. | All the changes in this file are related to inlining the old `ActsAsProfileField` concern that was used to share functionality between `ProfileField` and `CustomProfileField`. |
@@ -258,6 +258,9 @@ class Metrics(object):
for k in self.metrics_list:
if self.metrics[k + '_cnt'] > 0 and k != 'correct' and k != 'f1':
m[k] = round_sigfigs(self.metrics[k] / self.metrics[k + '_cnt'], 4)
+ # if 'loss' in m and 'ppl' not in m:
+ if 'loss'... | [_exact_match->[_normalize_answer],Metrics->[update_ranking_metrics->[_lock,_normalize_answer],clear->[_lock],update->[_exact_match,_f1_score,_lock,update_ranking_metrics]],_f1_score->[_score,_normalize_answer],_normalize_answer->[lower->[lower],white_space_fix,remove_articles,remove_punc,lower]] | Report the metrics over all data seen so far. | this doesn't make sense in that loss could mean anything (0/1, ranking, cross ent, mse).. this should only be for a specific kind of loss |
@@ -97,6 +97,6 @@ func Install() error {
}
// Create builds and creates a docker plugin
-func Create() {
+func Package() {
mg.SerialDeps(Build, Install)
}
| [Rm,SerialDeps,GoVersion,Deps,RunV,Mkdir,Getwd,Wrap,Chdir] | Create creates a new . | Package builds and create a docker logging plugin |
@@ -110,12 +110,12 @@ public class TrashAction implements StreamProcessorTopology {
}
}
- public void setSystemProperty(CoreSession session, List<String> ids, Boolean value) {
+ public void setSystemProperty(CoreSession session, List<String> ids, boolean value) {
List<... | [TrashAction->[TrashComputation->[fireEvent->[fireEvent]]]] | This method is used to remove proxies from the session and set the system property to true if. | don't change the `public` method signature this will break the forward compatibility because a customer code will not compile in a case where the passed param is a `null` value. Actually if a client code call this method with a `null` param it will compile and fail with NPE at line `119` just keep this behaviour. |
@@ -209,7 +209,6 @@ if ($result > 0) {
}
$ldap->unbind();
- $ldap->close();
} else {
setEventMessages($ldap->error, $ldap->errors, 'errors');
}
| [fetch,getAttribute,transnoentitiesnoconv,getNomUrl,connect_bind,unbind,loadLangs,update,trans,close,_load_ldap_dn,load,_load_ldap_info] | Print the list of records that can be read from LDAP. | Why removing the ldap->close() ? |
@@ -1822,7 +1822,7 @@ def plot_compare_evokeds(evokeds, picks=None, gfp=False, colors=None,
show_sensors = False # don't show sensors for GFP
ch_names = ['Global Field Power']
if len(picks) < 2:
- raise ValueError("A GFP with less than 2 channels doesn't work, "
+ r... | [plot_evoked_joint->[plot_evoked_joint,_plot_evoked],_combine_grad->[pair_and_combine],_setup_styles->[convert_colors,_aux_setup_styles],plot_evoked_image->[_plot_evoked],_handle_spatial_colors->[_plot_legend],_plot_lines->[_rgb],plot_compare_evokeds->[_format_evokeds_colors,_combine_grad,_setup_styles,_plot_legend,_ch... | Plot evoked time courses for one or more conditions and or more channels. Plots a single with the given colors and style. Draws a colorbar - rank order of the condition tags on the colorbar. Plots a single . | "fewer" rather than "less" (for countable items) |
@@ -192,7 +192,10 @@ class AbstractScannerRule(ModelBase):
max_length=200,
help_text=_('This is the exact name of the rule used by a scanner.'),
)
- scanner = models.PositiveSmallIntegerField(choices=SCANNERS.items())
+ select_scanner = SCANNERS
+ del select_scanner[WAT]
+ del select_... | [ScannerQueryRule->[change_state_to->[ImproperScannerQueryRuleStateError],completion_rate->[_get_completed_tasks_count]],AbstractScannerResult->[save->[extract_rule_names]]] | Creates a model instance from a version object. Validate a Yara rule object. | You can't do this - `select_scanner = SCANNERS` doesn't create a copy of `SCANNERS`, you're modifying the original dict, which will affect all other code that references the same constants (and because the server instances are reused, other requests/users too). A generator function would work e.g. `[name: scanner for n... |
@@ -319,7 +319,8 @@ Rails.application.routes.draw do
namespace :gobierto_plans, path: "planes" do
constraints GobiertoSiteConstraint.new do
get "/" => "plan_types#index", as: :root
- get ":slug/:year" => "plan_types#show"
+ get ":slug" => "plan_types#show", as: :plans
+ get ":slug/:year" =... | [draw,namespace,new,resources,collection,root,member,resource,get,constraints,post,production?,put,delete] | The api module provides a list of all the items in the system. Ajoute un nombre de indicators. | Prefer single-quoted strings when you don't need string interpolation or special symbols. |
@@ -0,0 +1,13 @@
+# frozen_string_literal: true
+
+class AddNormalizedEmailToUserEmail < ActiveRecord::Migration[6.1]
+ def change
+ add_column :user_emails, :normalized_email, :string
+ execute "CREATE INDEX index_user_emails_on_normalized_email ON user_emails (LOWER(normalized_email))"
+ end
+
+ def down
+ ... | [No CFG could be retrieved] | No Summary Found. | Should this be a `UNIQUE` index? |
@@ -368,6 +368,14 @@ func (r *RollingUpdater) Update(config *RollingUpdaterConfig) error {
if err != nil {
return err
}
+ // Perform the update acceptance check exactly once.
+ if config.UpdateAcceptor != nil && !updateAccepted {
+ err := config.UpdateAcceptor.Accept(newRc)
+ if err != nil {
+ return... | [UpdateReplicationController->[Update],ControllerHasDesiredReplicas->[ControllerHasDesiredReplicas]] | Update updates the current state of the controller. Updates oldRc and newRc until newRc has desired number of replicas or oldRc has Scale newRc. Spec. Replicas = desired. | combine with above line? |
@@ -161,14 +161,14 @@ class SGD(object):
self.__parameter_updater__.update(each_param)
cost_sum = out_args.sum()
cost = cost_sum / len(data_batch)
- self.__parameter_updater__.finishBatch(cost)
- batch_evaluator.finish()
... | [SGD->[train->[__prepare_parameter__],test->[__prepare_parameter__],__prepare_parameter__->[__use_remote_sparse_updater__]]] | Train a single n - dimensional network using a reader that reads and yeilds data Batch processing of . | Just a little confusing, why we move the `batch_evaluator` to the `event_handler`? |
@@ -154,7 +154,7 @@ public final class TopologyMemberImpl implements TopologyMember {
@Override
public String toString() {
- return "TopologyMember[id = " + nodeId + ", connector=" + connector + ", backupGroupName=" + backupGroupName + ", scaleDownGroupName=" + scaleDownGroupName + "]";
+ return "To... | [TopologyMemberImpl->[equals->[equals],toBackupURI->[getBackup],hashCode->[hashCode],toURI->[getLive]]] | This method is used to check if the topology member is equal to the given object. | Is this change on purpose? |
@@ -70,6 +70,12 @@ func makeSimpleFSPath(g *libkb.GlobalContext, path string) keybase1.Path {
path = filepath.ToSlash(filepath.Clean(path))
+ // Certain users seem to want to use SimpleFS on their
+ // mounted KBFS
+ if strings.HasPrefix(path, mountDir) {
+ return keybase1.NewPathWithKbfs(path[len(mountDir):])
+... | [AddOp->[Warning,Lock,Unlock,G],IsCancelled->[Lock,Unlock],Cancel->[Info,SimpleFSCancel,Unlock,Error,G,Lock,EncodeToString,TODO],Dir,SimpleFSList,SimpleFSStat,HasPrefix,PromptYesNo,NewPathWithKbfs,Clean,Stat,Args,New,SimpleFSWait,NewPathWithLocal,HasSuffix,IsAbs,Debug,SimpleFSMakeOpid,Match,Join,Local,EvalSymlinks,NewC... | Arguments for SimpleFS checkPathToString returns the string representation of the given path. | This seems duplicated from line 55 above. Is that intended? Also it looks like this is relying on `mountDir` not having a trailing slash. Is that something we can rely on? |
@@ -19,3 +19,10 @@ def resolve_access_token(info, root, **_kwargs):
if user.is_anonymous:
return None
return create_access_token_for_app(root, user)
+
+
+@permission_required(AppPermission.MANAGE_APPS)
+def _resolve_app(info, id):
+ from .types import App
+
+ return graphene.Node.get_node_from_... | [resolve_apps_installations->[all],resolve_access_token->[create_access_token_for_app],resolve_apps->[all]] | Resolve an access token for the given app. | Other app resolvers have the decorator defined at the schema.py level. I think it would be more consistent to keep it there. I think a dedicated function `_resolve_app` is not needed since it's a one-line resolver. |
@@ -246,8 +246,8 @@ public final class SparkRunner extends PipelineRunner<SparkPipelineResult> {
result = new SparkPipelineResult.BatchMode(startPipeline, jsc);
}
- if (mOptions.getEnableSparkMetricSinks()) {
- registerMetricsSource(mOptions.getAppName());
+ if (pipelineOptions.getEnableSparkMe... | [SparkRunner->[Evaluator->[enterCompositeTransform->[doVisitTransform],visitPrimitiveTransform->[doVisitTransform]],create->[SparkRunner],fromOptions->[SparkRunner]]] | Runs the given pipeline and returns a Future that will be completed once all of the files have This method is called when a user has requested to reschedule the accumulator. | I'm curious how `jsc` could be null here? |
@@ -543,7 +543,10 @@ class Label(TextAnnotation):
x = Float(help="""
The x-coordinate in screen coordinates to locate the text anchors.
- """)
+
+ Datetime values are also accepted, but note that they are immediately
+ converted to milliseconds-since-epoch.
+ """).accepts(Datetime, convert_datet... | [Title->[Float,Override,value,Enum,NumberSpec,String,FontSizeSpec,Include,ColorSpec],Tooltip->[Enum,Bool,Override],Legend->[Tuple,Int,Override,LegendItem,Enum,List,Either,Include,Instance],ColorBar->[Tuple,Float,Int,Override,BasicTickFormatter,Enum,String,Either,Include,Instance,BasicTicker],Band->[ColumnDataSource,Ove... | Create a label for a filled area band along a dimension. The x - coordinate of the first non - standard text anchor in the screen coordinates to locate. | Note that the coords for label had to have an `accepts` added explicitly since they are not number specs to begin with. Perhaps should have/should change label to be vectorized like other annotations. |
@@ -11,12 +11,14 @@ function jetpack_responsive_videos_init() {
/* If the theme does support 'jetpack-responsive-videos', wrap the videos */
add_filter( 'wp_video_shortcode', 'jetpack_responsive_videos_embed_html' );
- add_filter( 'embed_oembed_html', 'jetpack_responsive_videos_embed_html' );
add_filter( 'vide... | [No CFG could be retrieved] | This function initializes the jetpack - responsive videos filter. | So judging by the code it's not just YouTube and Vimeo, right? |
@@ -3797,6 +3797,9 @@ PlayerSAO* Server::emergePlayer(const char *name, session_t peer_id, u16 proto_v
playersao->finalize(player, getPlayerEffectivePrivs(player->getName()));
player->protocol_version = proto_version;
+ // Set player lang_code
+ player->m_lang_code = getClient(peer_id, CS_Invalid)->m_lang_code;
+... | [No CFG could be retrieved] | Get a single player with the given name and peer_id. Registers a mod storage with the server. | please add a getter on the m_lang_code instead of calling the variable publically |
@@ -151,9 +151,11 @@ public class StreamModelTaskRunner {
this.task.configureStreamingFork(fork);
}
}
- new Thread(() -> {
- connectableStream.connect();
- }).start();
+ Thread thread = new Thread(() -> connectableStream.connect());
+ thread.setName(this.getClass().getSimpleName())... | [StreamModelTaskRunner->[run->[getForkOperator,doOnCancel,size,getSchema,start,publish,Fork,getWatermark,consumeRecordStream,TimeoutException,put,observeOn,withRecordStream,of,getConverters,immediateFuture,onRecordExtract,register,forkStream,await,isEmpty,getPropAsInt,getForkExecutor,isStreamingTask,isPresent,addCallBa... | This method is called when the extractor is started. Process the record stream. Waits for all the forks to finish. | Just curious: What was the motivation to put this line alone in a new thread? isn't the `connect()` an async call ? |
@@ -311,9 +311,11 @@ class BlockSubmission(ModelBase):
list(block_qs)
if load_full_objects else
[cls.FakeBlock(
- id_, guid, addon_guid_dict.get(guid), min_version, max_version)
- for id_, guid, min_version, max_version in block_qs.values_list(
- ... | [BlockSubmission->[save_to_block_objects->[preload_addon_versions,save,_get_block_instances_to_save],process_input_guids->[Block],update_if_signoff_not_needed->[any_unsafe],is_submission_ready->[can_user_signoff],delete_block_objects->[preload_addon_versions,save],save->[_serialize_blocks],_serialize_blocks->[serialize... | Process a line - return separated list of guids into a list of invalid guids Returns a dict of invalid_guid existing_guids and the list of existing blocks that. | keyword arguments here as well. (the whole `existing_blocks = (...)` bit is hard to read, I don't think trying to squeeze all that in the same "line" helps... |
@@ -1,9 +1,9 @@
from unittest import TestCase, main
-import nni.compression.tensorflow as tf_compressor
-import nni.compression.torch as torch_compressor
+import tensorflow as tf
import torch
import torch.nn.functional as F
-import tensorflow as tf
+import nni.compression.tensorflow as tf_compressor
+import nni.com... | [max_pool->[max_pool],CompressorTestCase->[test_torch_quantizer->[TorchMnist],test_tf_quantizer->[TfMnist],test_tf_pruner->[TfMnist],test_torch_pruner->[TorchMnist]],conv2d->[conv2d],TfMnist->[__init__->[max_pool,weight_variable,bias_variable,conv2d]]] | Weight variable for the nanoseconds. | this import order cannot pass pylint |
@@ -95,7 +95,7 @@ export type PropsT = {
/** Defaults to filterOptions that excludes selected options for
* multi select. A custom method to filter options to be displayed in the dropdown. */
filterOptions: ?(
- options: ValueT,
+ options: OptionsT,
filterValue: string,
excludeOptions: ?ValueT... | [No CFG could be retrieved] | A list of options that can be used to select a control. The object that represents the configuration of the option. | is this a breaking change now that flow will complain that consumers are not properly handling the case where `OptionsT` could be an object shape? |
@@ -663,6 +663,9 @@ namespace MonoGame.Tests.Graphics
// DXT5
[TestCase(16, "random_16px_dxt_alpha", 0)]
[TestCase(16, "random_16px_dxt_alpha", 1)]
+#if XNA
+ [Ignore("FIXME: Fails under XNA!")]
+#endif
public void GetAndSetDataDxtNotMultipleOf4Rounding(int bs, string texName,... | [Texture2DNonVisualTest->[GetDataRowPitch->[AreEqual,SetData,Dispose,Bgr565,GetData,Length],SetData1ParameterGoodTest->[White,B,A,AreEqual,G,SetData,Dispose,FromStream,BaseStream,R,GetData,Length],PlatformGetDataWithOffsetTest->[White,Dispose,BaseStream,FromStream,R,GetData,Length,AreNotEqual],SetData3ParameterGoodTest... | This test sets the data of a texture to a multiple of 4 rounded boxes. Tests if the data in the region are identical. | @Jjagg - I'm not sure why these Set/GetData tests are failing under XNA. It makes we worry we have things wrong. After this gets merged can you come back and take a look at it? |
@@ -141,6 +141,7 @@ func waitForRouteToRespond(ns, execPodName, proto, host, abspath, ipaddr string,
set -e
STOP=$(($(date '+%%s') + %d))
while [ $(date '+%%s') -lt $STOP ]; do
+ rc=0
code=$( curl -k -s -m 5 -o /dev/null -w '%%{http_code}\n' --resolve %s:%d:%s %q ) || rc=$?
if [[ "${rc:-0}" -eq 0 ]];... | [CurrentGinkgoTestDescription,By,FindRouterImage,CoreV1,Expect,HaveOccurred,FixturePath,Delete,RouteV1,It,Routes,NewForConfigOrDie,Args,AsAdmin,DumpPodLogsStartingWith,Poll,AdminKubeClient,Errorf,Namespace,Skip,TrimSpace,KubeFramework,NewDeleteOptions,Execute,NewCLI,AdminConfig,BeforeEach,Get,Split,NotTo,Pods,RunHostCm... | waitForRouteToRespond waits for a route to respond to. | It might make sense to replace `${rc:-0}` with `$rc` now that we know `rc` is always initialized, but using `${rc:-0}` doesn't actually hurt anything. |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.