patch stringlengths 18 160k | callgraph stringlengths 4 179k | summary stringlengths 4 947 | msg stringlengths 6 3.42k |
|---|---|---|---|
@@ -170,6 +170,15 @@
<div class="alert alert-info">Used to determine what a member will be called e.g developer, hobbyist etc.</div>
</div>
+ <div class="form-group">
+ <%= f.label :community_action, "Community action" %>
+ <%= f.text_field :community_a... | [No CFG could be retrieved] | A list of all components of the nag - core community. The template for the email - lease header. | `community_action` sounded okay to me eventually, but I spent a lot of time on trying to think of the appropriate name for the field, if anyone feels its terrible, feel free to suggest an alternative |
@@ -14,7 +14,7 @@ namespace System.IO.Compression
{
private const int TaskTimeout = 30 * 1000; // Generous timeout for official test runs
- [Fact]
+ [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsThreadingSupported))]
public virtual void FlushAsync_DuringWr... | [CompressionStreamUnitTestBase->[TestCompressCtor->[CtorFunctions]],ManualSyncMemoryStream->[ReadAsync->[ReadAsync]],BadWrappedStream->[Read->[Read]]] | This method is called when a base stream is flushed. It is called when a write operation. | Assuming the issue here is the blocking, these tests could be made to work; there just wasn't a reason to avoid the blocking previously. How do we want to track the difference between "this test can never work with wasm" and "this test doesn't currently work with wasm but could be made to"? |
@@ -262,11 +262,14 @@ var tmceHelper = require( './wp-seo-tinymce' );
$( '.adminbar-seo-score' )
.attr( 'class', 'wpseo-score-icon adminbar-seo-score ' + indicator.className )
.attr( 'alt', indicator.screenReaderText );
+
+ publishBox.updateScore('keyword', indicator.className);
}
// If multi ke... | [No CFG could be retrieved] | Saves the score to the linkdex and the content tab. Initializes the keyword tab template if multi keyword isn t available. | Missing spaces between parentheses. |
@@ -78,7 +78,7 @@ void AddCustomProcessesToPython(pybind11::module &m)
// Normalized Free Energy extrapolation to Nodes
class_<ComputeNormalizedFreeEnergyOnNodesProcess, ComputeNormalizedFreeEnergyOnNodesProcess::Pointer, Process>(m, "ComputeNormalizedFreeEnergyOnNodesProcess")
- .def(init<ModelPart &, unsigned ... | [AddCustomProcessesToPython->[,Process>]] | Add custom processes to Python module. Initializes all methods of the Nested Nested Nested Nested Nested Nested Nested Nested Nested Nested Nested Nested Nested. | See, here you are using unsigned int instead of int. BTW, you don't need dimension, DOMAIN_SIZE should be defined on the ProcessInfo of the model part |
@@ -226,6 +226,12 @@ public class ClientIntegrationTest {
public void setUp() {
vertx = Vertx.vertx();
client = createClient();
+ makeKsqlRequest("CREATE SOURCE CONNECTOR " + TEST_CONNECTOR + " WITH ('connector.class'='" + MOCK_SOURCE_CLASS + "');");
+ assertThatEventually(
+ () -> ((Connector... | [ClientIntegrationTest->[makeKsqlRequest->[makeKsqlRequest],shouldReceiveStreamRows->[shouldReceiveStreamRows]]] | This method is called before any other method of the class. | I don't think this belongs here. Most tests don't need the connector so it feels wasteful. How about we wrap this in a `givenConnectorExists()` method and only call it from the `Given:` portion of the tests that actually need it instead? |
@@ -204,7 +204,7 @@ class ProductVariant(models.Model, Item):
app_label = 'product'
def __str__(self):
- return self.name or self.sku
+ return self.display_product()
def get_weight(self):
return self.weight_override or self.product.weight
| [ProductVariant->[as_data->[get_price_per_item],get_first_image->[get_first_image],get_absolute_url->[get_slug],display_product->[display_variant],get_cost_price->[select_stockrecord]],Product->[is_in_stock->[is_in_stock],ProductManager],Stock->[StockManager]] | A string representation of the node. | Why are these two separate methods? Do we ever need to pass `attributes` to `display_*` instead of doing a `prefetch_related`? |
@@ -59,6 +59,16 @@ import java.util.List;
public class BufferGrouper<KeyType> implements Grouper<KeyType>
{
private static final Logger log = new Logger(BufferGrouper.class);
+ private static final AggregateResult DICTIONARY_FULL = AggregateResult.failure(
+ "Not enough dictionary space to execute this query... | [BufferGrouper->[isUsed->[get],reset->[reset],growIfPossible->[isUsed],findBucket->[get],aggregate->[init,aggregate],close->[close],bucketEntryForOffset->[get],iterator->[set->[get],compare->[compare],next->[get]]]] | A buffer grouper which groups keys into a single buffer. The serialized key is stored in Returns a new instance of the class that will be used to create the class. | s/positive/larger , user might already have a positive number in there |
@@ -613,7 +613,7 @@ namespace System.Windows.Forms
public static extern int GetThemeTextMetrics(HandleRef hTheme, HandleRef hdc, int iPartId, int iStateId, ref VisualStyles.TextMetrics ptm);
[DllImport(ExternDll.Uxtheme, CharSet = CharSet.Auto)]
- public static extern int HitTestThemeBackgrou... | [SafeNativeMethods->[ImageList_Destroy->[IntImageList_Destroy],SetViewportOrgEx->[SetViewportOrgEx],TrackMouseEvent->[_TrackMouseEvent]]] | Returns true if the current theme is a theme background. | The last param is a `ref ushort`, not an `int`. (`WORD`) |
@@ -557,8 +557,15 @@ func (i *Ingester) flushLoop(j int) {
}
userState.fpLocker.Lock(op.fp)
+
+ // Assume we're going to flush everything
chunks := series.chunkDescs
- if !series.headChunkClosed {
+
+ // If the head chunk is old enough, close it
+ if op.immediate || model.Now().Sub(series.head().FirstTim... | [Ready->[Ready],UserStats->[getStateFor],append->[getStateFor],Collect->[Collect],Describe->[Describe],Query->[getStateFor],LabelValuesForLabelName->[getStateFor]] | flushLoop is the main loop that flushes all the outstanding operations in the queue. on process exit. | Kind of surprised `series` doesn't have a method that does both of these together, since it seems like a vaguely atomic operation. |
@@ -125,11 +125,9 @@ namespace Microsoft.Xna.Framework.Graphics
var vp = gd.Viewport;
Matrix projection;
-#if PSM || DIRECTX
Matrix.CreateOrthographicOffCenter(0, vp.Width, vp.Height, 0, -1, 0, out projection);
-#else
+#if !PSM && !DIRECTX
// GL requires a half pixel offset to mat... | [SpriteBatch->[Draw->[Draw,CheckValid],Dispose->[Dispose],DrawString->[CheckValid]]] | Setup the default sprite effect. | So basically DX and GL both needed the same matrix construction? |
@@ -105,6 +105,8 @@ class testFormatterCase extends zcTestCase
public function testListStandardFormatterMultiRow()
{
define('TEST_BUY_NOW', 1);
+ define('STORE_STATUS', 1);
+ define('ENABLE_SSL', 1);
define('SEARCH_ENGINE_FRIENDLY_URLS', 0);
define('PROPORTIONAL_IMAGES... | [testFormatterCase->[testListStandardFormatterNoItems->[assertTrue,setDBConnection,getFormattedResults,willReturn,format,getMock],testTabularProductFormatterMultiRow->[assertTrue,getFormattedResults,willReturn,setRequest,format,getMock],testColumnarFormatterMultiRow->[assertTrue,getFormattedResults,format],testTabularC... | This method is used to test the standard formatter for multiple rows of a list of images. This method returns an array of items that are not part of a product list. | Probably should be `'true'` (string) instead of `1` (int) |
@@ -0,0 +1,16 @@
+// Licensed to the .NET Foundation under one or more agreements.
+// The .NET Foundation licenses this file to you under the MIT license.
+// See the LICENSE file in the project root for more information.
+
+internal static class FXAssembly
+{
+ internal const string Version = "4.0.0.0";
+}
+
+inte... | [No CFG could be retrieved] | No Summary Found. | I assume you do actually need this file for some reason (designers?) |
@@ -168,10 +168,10 @@ public class BigQueryTableRowIteratorTest {
String photoBytesEncoded = BaseEncoding.base64().encode(photoBytes);
// Mock table data fetch.
when(mockTabledataList.execute())
- .thenReturn(rawDataList(rawRow("Arthur", 42, photoBytesEncoded)));
+ .thenReturn(rawDataList(r... | [BigQueryTableRowIteratorTest->[testReadFromQuery->[tableWithBasicSchema,rawDataList,rawRow]]] | This test method runs a BigQuery query and verifies that the results read from the query are in Execute a mock query that gets a batch of jobs from the mock client. | shouldn't photoBytes be "photo"? |
@@ -1390,6 +1390,9 @@ public class DeckPicker extends NavigationDrawerActivity implements
public void showImportDialog(int id, String message) {
Timber.d("showImportDialog() delegating to ImportDialog");
+ if (message == null) {
+ message = "";
+ }
AsyncDialogFragment n... | [DeckPicker->[handleDbError->[showDatabaseErrorDialog],onRequestPermissionsResult->[onRequestPermissionsResult,handleStartup],undo->[undoTaskListener],mediaCheck->[mediaCheckListener],MediaCheckListener->[actualOnPostExecute->[showMediaCheckDialog]],updateDeckList->[updateDeckListListener,updateDeckList],onDestroy->[on... | Show the import dialog with the specified id and message. | This could be removed later, should never be hit |
@@ -9,6 +9,7 @@ using System.Globalization;
using System.Diagnostics;
using System.Reflection;
using System.Runtime.InteropServices;
+using System.Diagnostics.CodeAnalysis;
namespace System.Xml.Serialization
{
| [CodeIdentifier->[EscapeKeywords->[EscapeKeywords,CheckValidIdentifier],MakeValidInternal->[MakeValid],GetCSharpName->[GetCSharpName]]] | Creates a CodeIdentifier object that can be used to create a code identifier from a string. region Implementation. | NullReferenceException on `MakeValid` when `identifier` is passed as null. It also affects the other two public methods since they call into it. |
@@ -81,14 +81,14 @@ public final class CanalDefinitionsPanel extends ImageScrollPanePanel {
@Override
protected void paintCenterSpecifics(final Graphics g, final String centerName, final FontMetrics fontMetrics,
- final Point item, final int xTextStart) {
+ final Point item, final int textStartX) {
... | [CanalDefinitionsPanel->[layout->[CanalDefinitionsPanel,layout]]] | Paints the center specifics. | Meh, not really happy with this naming convention, but it is used in many other places throughout the code (i.e. `<something>X` or `<something>Y`). Any better suggestions are welcome. |
@@ -44,8 +44,7 @@ class SlidingEstimator(BaseEstimator, TransformerMixin):
self.n_jobs = n_jobs
self.scoring = scoring
- if not isinstance(self.n_jobs, int):
- raise ValueError('n_jobs must be int, got %s' % n_jobs)
+ _validate_type(self.n_jobs, Integral, 'n_jobs')
de... | [_sl_transform->[transform],_gl_transform->[transform],GeneralizingEstimator->[decision_function->[_transform],score->[_check_Xy],predict_proba->[_transform],_transform->[_check_Xy,_check_method],transform->[_transform],predict->[_transform]],SlidingEstimator->[decision_function->[_transform],score->[_check_Xy],predict... | Initialize the object with a base estimator and scoring. | Now we have to `import Integral` which is a bit annoying. It's probably safe enough to use `int` in your special-casing, or even `'int-like'` if we're worried there are cases we require an actual built-in `int` (though I doubt we have any of those currently). |
@@ -229,8 +229,9 @@ class ElggBatch
private function getNextResultsChunk() {
// reset memory caches after first chunk load
if ($this->chunkIndex > 0) {
- global $DB_QUERY_CACHE, $ENTITY_CACHE;
- $DB_QUERY_CACHE = $ENTITY_CACHE = array();
+ global $ENTITY_CACHE;
+ $ENTITY_CACHE = array();
+ _elgg_inval... | [ElggBatch->[next->[getNextResultsChunk],rewind->[getNextResultsChunk]]] | get next results chunk This method is called when the iterator is ready to iterate over the results. | This line was accidentally removed when I refactored ElggBatch. |
@@ -412,13 +412,13 @@ public class ExplodedGraphWalker extends BaseTreeVisitor {
private void executeArrayAccessExpression(ArrayAccessExpressionTree tree) {
// unstack expression and dimension
- Pair<ProgramState, List<SymbolicValue>> unstack = programState.unstackValue(2);
- programState = unstack.a;
+... | [ExplodedGraphWalker->[clearStack->[clearStack],visitMethod->[visitMethod],execute->[MaximumStepsReachedException],enqueue->[debugPrint,ExplodedGraphTooBigException],resetFieldValues->[resetFieldValues],handleBranch->[handleBranch]]] | Execute an array access expression. | please fix this issue. |
@@ -68,6 +68,7 @@ public class ByteBuddyPluginConfigurator {
private Task createLanguageTask(AbstractCompile compileTask, String name) {
ByteBuddySimpleTask task = project.getTasks().create(name, ByteBuddySimpleTask.class);
task.setGroup("Byte Buddy");
+ task.getOutputs().cacheIf(unused -> true);
... | [ByteBuddyPluginConfigurator->[getTaskName->[getName,equals],getCompileTask->[isEmpty,getCompileTaskName,findByName],createTransformation->[setPlugin,ClasspathTransformation],createLanguageTask->[create,setGroup,setDestinationDir,setClassPath,setTarget,getClasspath,setSource,getAbsoluteFile,add,createTransformation,dep... | Creates a language task. | It is indeed suspicious. I would assume that better approach would be to have correctly configured inputs and outputs for this task |
@@ -390,7 +390,12 @@ public class TransactionTable implements org.infinispan.transaction.TransactionT
if (topologyId < minTxTopologyId) {
if (trace)
log.tracef("Changing minimum topology ID from %d to %d", minTxTopologyId, topologyId);
- minTxTopologyId = to... | [TransactionTable->[getOrCreateRemoteTransaction->[getOrCreateRemoteTransaction,killTransaction],releaseLocksForCompletedTransaction->[removeLocalTransaction,getGlobalTransaction],removeRemoteTransaction->[releaseResources],getGlobalTransaction->[getGlobalTransaction],onViewChange->[cleanupLeaverTransactions],removeLoc... | Returns a new remote transaction or creates a new one if it doesn t exist. return null if not a transaction. | I'm not sure if it makes much sense to lock here. at lest, include the `if (topologyId < minTxTopologyId)` in the locked section. |
@@ -2162,6 +2162,10 @@ spa_removal_get_stats(spa_t *spa, pool_removal_stat_t *prs)
}
#if defined(_KERNEL)
+module_param(zfs_removal_ignore_errors, int, 0644);
+MODULE_PARM_DESC(zfs_removal_ignore_errors,
+ "Ignore hard IO errors when removing device");
+
module_param(zfs_remove_max_segment, int, 0644);
MODULE_PAR... | [No CFG could be retrieved] | ZFS Remove Device remap segment can span. | Maybe say "Ignore hard IO errors when doing a zpool remove", so that it's not confused with a physical device removal. |
@@ -33,7 +33,7 @@
<%= inline_svg_tag("overflow-horizontal.svg", aria_hidden: true, class: "dropdown-icon crayons-icon", title: t("views.actions.more.title")) %>
</button>
- <div id="article-show-more-dropdown" class="crayons-dropdown side-bar left-2 right-2 m:right-auto m:left-100 s:left-auto bot... | [No CFG could be retrieved] | Displays a menu with a menu of all possible reactions. Renders a skeleton block of content. | little fix and cleanup |
@@ -872,6 +872,13 @@ func (t *BaseOperations) Fork() error {
}
func (t *BaseOperations) Setup(config Config) error {
+ if err := createBindSrcTarget(filesForMinOSLinux); err != nil {
+ return err
+ }
+
+ Sys.Hosts = etcconf.NewHosts(hostsPathBindSrc)
+ Sys.ResolvConf = etcconf.NewResolvConf(resolvConfPathBindSrc)
... | [RouteDel->[RouteDel],LinkSetAlias->[LinkSetAlias],AddrDel->[AddrDel],LinkSetUp->[LinkSetUp],dhcpLoop->[Apply],RouteAdd->[RouteAdd],AddrAdd->[AddrAdd],RuleList->[RuleList],LinkBySlot->[LinkByName],AddrList->[AddrList],LinkSetDown->[LinkSetDown],LinkSetName->[LinkSetName],LinkByName->[LinkByName],updateNameservers,Route... | Setup - initializes the network operations. | `Setup` is called per tether instance, while Sys is package global. You should put this in an init() function. |
@@ -221,6 +221,7 @@ Infer output and weight shape of a module/function from its input shape
infer_from_inshape = {
'ReLU': lambda module_masks, mask: relu_inshape(module_masks, mask),
'ReLU6': lambda module_masks, mask: relu_inshape(module_masks, mask),
+ 'Sigmoid': lambda module_masks, mask: relu_inshape... | [conv2d_mask->[convert_to_coarse_mask->[CoarseMask,add_index_mask],merge,convert_to_coarse_mask,set_output_mask,CoarseMask,add_index_mask,set_param_masks],dropout_inshape->[set_input_mask,set_output_mask],maxpool2d_inshape->[set_input_mask,set_output_mask],CoarseMask->[merge->[merge_index],__le__->[__eq__,__lt__],__eq_... | This method extracts input and output shape of a module or function from its weight mask. Masks module masks in the same shape as the input mask. | `aten::sigmoid` needs to be added, too. |
@@ -1496,12 +1496,12 @@ class BlobClient(AsyncStorageAccountHostsMixin, BlobClientBase): # pylint: disa
:param bytes page:
Content of the page.
- :param int start_range:
+ :param int offset:
Start of byte range to use for writing to a section of the blob.
... | [BlobClient->[create_snapshot->[create_snapshot],upload_pages_from_url->[upload_pages_from_url],append_block->[append_block],get_block_list->[get_block_list],commit_block_list->[commit_block_list],get_page_ranges->[get_page_ranges],stage_block_from_url->[stage_block_from_url],append_block_from_url->[append_block_from_u... | Uploads a page to a blob. This operation retrieves a page of a list of blobs from the Azure Storage account. Upload pages of blob. | Probably description docstring needs update |
@@ -69,7 +69,7 @@ class StoriesController < ApplicationController
def get_latest_campaign_articles
campaign_articles_scope = Article.tagged_with(SiteConfig.campaign_featured_tags, any: true).
- where("published_at > ?", 2.weeks.ago).where(approved: true).
+ where("published_at > ?", 4.weeks.ago).whe... | [StoriesController->[assign_second_and_third_user->[find,third_user_id,blank?,present?,second_user_id],handle_base_index->[decorate,render,decorate_collection,campaign_sidebar_enabled?,set_surrogate_key_header,set_cache_control_headers],redirect_if_view_param->[redirect_to,id],assign_user_stories->[user_signed_in?,deco... | Get the latest campaign articles that are tagged with any of the campaigns. | I need to circle back on #7582 but this temporarily ensures we're showing the right posts. |
@@ -93,7 +93,16 @@ class WebSocketConnectionTest {
@BeforeEach
void setup() {
webSocketConnection = new WebSocketConnection(INVALID_URI);
- webSocketConnection.setClient(webSocketClient);
+ }
+
+ private void requiresSendTextAction() {
+ when(webSocket.sendText(any(), anyBoolean()))
+ ... | [WebSocketConnectionTest->[WebSocketClientCallbacks->[onClose->[onClose],onError->[onError],onMessage->[onMessage]],SendMessageAndConnect->[sendMessage->[sendMessage],connectionFailure->[givenWebSocketConnects],sendMessageWillQueueMessagesIfConnectionIsNotOpen->[sendMessage],close->[close],connectionFailureWithInterrup... | Setup the connection. | This method seems out of order, it is invoked much further down in the test, right? Second, why does this method make sense, what does requiring a close action mean and have to do with a send close returning a nullable future? |
@@ -18,6 +18,7 @@ using Robust.Shared.IoC;
using Robust.Shared.Localization;
using Robust.Shared.Map;
using Robust.Shared.Players;
+using System;
namespace Content.Server.GameObjects.EntitySystems
{
| [HandsSystem->[Shutdown->[Shutdown],Initialize->[Initialize],HandleSwapHands->[TryGetAttachedComponent],HandleActivateItem->[TryGetAttachedComponent]]] | The HandsSystem class is a base class for all content - key events that are handled Bind the input functions to the throw item in hand and the smart equip backpack input. | Is this import necessary? |
@@ -1358,7 +1358,7 @@ ActiveRecord::Schema.define(version: 2021_06_24_153854) do
t.datetime "last_article_at", default: "2017-01-01 05:00:00"
t.datetime "last_comment_at", default: "2017-01-01 05:00:00"
t.datetime "last_followed_at"
- t.datetime "last_moderation_notification", default: "2017-01-01 05:... | [jsonb,bigint,declare,string,text,citext,add_foreign_key,datetime,integer,check_constraint,enable_extension,create_table,float,boolean,index,define,tsvector,inet] | 2017 - 01 - 01 XML description of a link in the linkedin. | I think these schema.rb changes can be safely removed from the commit, it's probably something from your initial setup caused these changes (they're unrelated to your change above and not needed to render strikethrough) |
@@ -434,10 +434,14 @@ class AnyTypeConstraint(TypeConstraint):
class TypeVariable(AnyTypeConstraint):
- def __init__(self, name):
+ def __init__(self, name, ignore_name=False):
self.name = name
+ self.ignore_name = ignore_name
def __eq__(self, other):
+ if self.ignore_name:
+ return type(sel... | [check_constraint->[type_check],SequenceTypeConstraint->[type_check->[CompositeTypeHintError],bind_type_variables->[bind_type_variables],match_type_variables->[match_type_variables]],ListHint->[ListConstraint->[__repr__->[_unified_repr]],__getitem__->[ListConstraint,validate_composite_type_param]],DictHint->[__getitem_... | Initialize a with the given name. | I think the logic here is reversed? (I don't see ignore_name used in any test in this commit.) About naming: (optional ideas) 1. I'd recommend to be more descriptive about when name is ignored. Ex: `ignore_name_in_eq` 2. I find using positive variable names easier to reason about. `if use_name_in_eq` is easier to read ... |
@@ -257,7 +257,12 @@ class ServiceBusReceiver(BaseHandler, ReceiverMixin): # pylint: disable=too-man
:keyword dict http_proxy: HTTP proxy settings. This must be a dictionary with the following
keys: `'proxy_hostname'` (str value) and `'proxy_port'` (int value).
Additionally the following k... | [ServiceBusReceiver->[_open->[_create_handler],_receive->[_open],peek->[_open],receive_deferred_messages->[_open]]] | Creates a ServiceBusReceiver from a connection string. Creates a new ServiceBusReceiverClient object from a connection string. | Is this public? |
@@ -64,7 +64,7 @@ module GobiertoAdmin
person_statement_params = {
title_translations: { I18n.locale => person_statement.title },
published_on: person_statement.published_on,
- content_block_records_attributes: { "0" => { attachment_file: "file.pdf" } }
+ content_block_r... | [PersonStatementFormTest->[invalid_person_statement_form->[new],test_error_messages_with_invalid_attributes->[save,assert_equal,size],site->[sites],test_content_block_records_are_assigned_after_site_id->[new,merge,returns,published_on,valid?,assert,title,id,locale],person->[person],valid_person_statement_form->[new,att... | This method checks that all content block records are assigned after the site id. | Prefer single-quoted strings when you don't need string interpolation or special symbols.<br>Line is too long. [89/80] |
@@ -658,17 +658,4 @@ public class FnApiDoFnRunnerTest {
}
return out.toByteString();
}
-
- @Test
- public void testRegistration() {
- for (Registrar registrar :
- ServiceLoader.load(Registrar.class)) {
- if (registrar instanceof FnApiDoFnRunner.Registrar) {
- assertThat(registrar.ge... | [FnApiDoFnRunnerTest->[testUsingUserState->[TestStatefulDoFn],TestStatefulDoFn->[ConcatCombineFnWithContext,ConcatCombineFn],testCreatingAndProcessingDoFn->[TestDoFn],multimapSideInputKey->[multimapSideInputKey],encode->[encode]]] | Encode the given values. | This test should stick around but we should ensure that the ParDo URN is registered. |
@@ -611,15 +611,12 @@ func TestMergeQueryable_LabelValues(t *testing.T) {
},
labelName: "instance",
expectedLabelValues: []string{},
- skipReason: matchersNotImplemented,
},
{
name: "should only query tenant-b when there is an equals matcher for te... | [LabelNames->[matrix],init->[Querier],Next->[Next],At->[At],LabelValues->[matrix],Select->[matrix],Err,init,Warnings,LabelNames,Next,LabelValues,Select,Querier] | missing - label - values should return all label values for the instance when there are no matchers missing - label - value should return only label values for team - c when there is an. | [nit] Can we remove `skipReason` support at all from `labelValuesTestCase`? I think it's no more used after this PR changes. |
@@ -51,7 +51,8 @@ public final class PullQueryExecutionUtil {
final Set<QueryId> queries = engineContext.getQueryRegistry().getQueriesWithSink(sourceName);
if (source.getDataSourceType() != DataSourceType.KTABLE) {
- throw new KsqlException("Pull queries are not supported on streams."
+ throw new ... | [PullQueryExecutionUtil->[notMaterializedException->[replaceAll,KsqlException],findMaterializingQuery->[getOnlyElement,getDataSourceType,getName,size,getQueriesWithSink,orElseThrow,IllegalStateException,notMaterializedException,getDataSource,isEmpty,KsqlException],checkRateLimit->[KsqlException,tryAcquire,getRate]]] | Finds a materializing query in the query registry. | This is now just serving as a last-minute check on the source type. As far as we know, though, all code paths leading here will only send us table queries now, so it makes sense to reword the error. |
@@ -68,7 +68,7 @@ public class UpdateAction implements OrganizationsAction {
@Override
public void handle(Request request, Response response) throws Exception {
- userSession.checkPermission(GlobalPermissions.SYSTEM_ADMIN);
+ userSession.checkLoggedIn();
String key = request.mandatoryParam(PARAM_KE... | [UpdateAction->[writeResponse->[build,writeProtobuf],define->[setExampleValue,setHandler,addOrganizationDetailsParams],getDto->[selectByKey,isPresent,get,NotFoundException,format],handle->[setAvatarUrl,getAndCheckAvatar,getAndCheckName,checkPermission,mandatoryParam,update,openSession,getAndCheckUrl,commit,writeRespons... | Handles a request for a missing key. | what's the point to check that user is logged in ? |
@@ -32,8 +32,7 @@ module ApplicationHelper
def works_page?
params[:controller] == 'works' &&
- (params[:action] == 'on_air' ||
- params[:action] == 'season' ||
+ (params[:action] == 'season' ||
params[:action] == 'popular' ||
params[:action] == 'recommend' ||
params[:action] == 'se... | [annict_image_tag->[image_tag,mobile?],tombo_thumb_url->[path,send,background_image_animated?],custom_time_ago_in_words->[time_ago_in_words,t],meta_description->[t],meta_keywords->[split,join]] | Checks if a given block of params is a works page. | Use 2 (not 0) spaces for indenting an expression spanning multiple lines.<br>Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping. |
@@ -511,9 +511,14 @@ class ViewsService {
public function extendView($view, $view_extension, $priority = 501) {
$view = self::canonicalizeViewName($view);
$view_extension = self::canonicalizeViewName($view_extension);
+
+ if ($view === $view_extension) {
+ // do not allow direct extension on self with self... | [ViewsService->[autoregisterViews->[autoregisterViews],viewIsExtended->[getViewList],renderView->[doesViewtypeFallback,getViewtype,isValidViewtype,getViewList],mergeViewsSpec->[autoregisterViews],viewExists->[findViewFile,isValidViewtype,viewExists,doesViewtypeFallback,getViewtype],registerPluginViews->[autoregisterVie... | Extend a view with a view extension. | At least deserves a logged error. |
@@ -171,6 +171,10 @@ namespace System.IO
{
throw new ArgumentOutOfRangeException(nameof(bufferSize), SR.ArgumentOutOfRange_NeedPosNum);
}
+ else if (preallocationSize < 0)
+ {
+ throw new ArgumentOutOfRangeException(nameof(preallocationSize... | [FileStream->[Flush->[Flush],BaseEndWrite->[EndWrite],SetLength->[SetLength],WriteByte->[WriteByte],BaseReadAsync->[ReadAsync],Write->[Write],DisposeInternal->[Dispose],Read->[Read],ReadAsync->[Task,ReadAsync],CopyTo->[CopyTo],BaseEndRead->[EndRead],Lock->[Lock],Seek->[Seek],BaseWrite->[Write],ReadByte->[ReadByte],EndR... | Replies the file flags that should be used to create a new file. A FileHandle that implements FileStream. PickStrategy. | I do prefer that you throw on negatives but I wonder why did you choose to switch? Also, the PR description says the following: >Value provided as allocationSize argument has no effect unless it's positive and a regular file is being created, overwritten, or replaced. It means that: > >* if value is <= 0 it's just igno... |
@@ -285,6 +285,8 @@ class Jetpack_Search_Widget_Filters extends WP_Widget {
function update( $new_instance, $old_instance ) {
$instance = array();
+ error_log( print_r( array( $_GET, $_POST ), true ) );
+
$instance['title'] = sanitize_text_field( $new_instance['title'] );
$instance['use_filters'] = empty(... | [Jetpack_Search_Widget_Filters->[form->[get_sort_types],widget->[get_sort_types,should_display_sitewide_filters],render_current_filters->[add_post_types_to_url,ensure_post_types_on_remove_url]]] | Updates an existing object This function create a new object with all the necessary fields. | I don't think you meant to leave it here :) |
@@ -79,3 +79,8 @@ define('LOCALE_PATH', ROOT_PATH . 'locale/');
* is used)
*/
define('K_PATH_IMAGES', ROOT_PATH);
+
+/**
+ * Define the cache directory for routing
+ */
+define('ROUTING_CACHE_DIR', ROOT_PATH . 'libraries/cache/');
| [No CFG could be retrieved] | define - K_PATH_IMAGES. | I think just `CACHE_DIR` is better, because we can use this for other types of cache later. |
@@ -34,6 +34,8 @@ def concretize(parser, args):
tests = False
with env.write_transaction():
- concretized_specs = env.concretize(force=args.force, tests=tests)
+ concretized_specs = env.concretize(
+ force=args.force, tests=tests, reuse=args.reuse
+ )
ev.display_... | [concretize->[write,concretize,require_active_env,display_specs,write_transaction],setup_parser->[add_argument]] | Process the concretized specs. | I think this would be better coming from a config setting, rather than an argument to the command |
@@ -69,17 +69,6 @@ size_t rand_pool_acquire_entropy(RAND_POOL *pool)
extern void s$sleep2(long long *_duration, short int *_code);
# endif
- /*
- * Seed with the gid, pid, and uid, to ensure *some* variation between
- * different processes.
- */
- curr_gid = getgid();
- rand_pool_add(pool,... | [No CFG could be retrieved] | Reads the 16 - bit code from the random pool and acquires entropy for the specified number Get entropy of an object in the entropy pool. | So uid/gid aren't used anymore? (I don't really care, just asking.) |
@@ -44,12 +44,12 @@ namespace System.IO
return _startIndex >= _endIndex; // Everything has been processed;
}
- internal unsafe void AppendExtraBuffer(byte* buffer, int bufferLength)
+ internal void AppendExtraBuffer(ReadOnlySpan<byte> buffer)
{
// Then convert... | [StdInReader->[ReadOrPeek->[ReadLineCore,Peek],ConsoleKeyInfo->[IsUnprocessedBufferEmpty,MapBufferToConsoleKey,AppendExtraBuffer,ReadStdin],AppendExtraBuffer->[IsUnprocessedBufferEmpty],MapBufferToConsoleKey->[IsUnprocessedBufferEmpty,MapBufferToConsoleKey],ReadStdin->[ReadStdin]]] | Internal method to check if the buffer has been processed and if so append the data to the. | Unrelated to your changes, but shouldn't this be guarding against large char counts (perhaps using an assert)? |
@@ -2,7 +2,7 @@ require "rails_helper"
require "requests/shared_examples/internal_policy_dependant_request"
RSpec.describe "/admin/consumer_apps", type: :request do
- let(:get_resource) { get "/admin/consumer_apps" }
+ let(:get_resource) { get admin_consumer_apps_path }
let(:params) do
{
app_bundle... | [create,let,describe,it,put,domain_name,to,before,post,let!,require,it_behaves_like,have_http_status,id,redirect_to,context,get,by,eq,sign_in,reload,raise_error] | requires rails_helper to be installed tenant - consumer - app - administration. | These routes have not changed and so we've kept the descriptions the same |
@@ -969,10 +969,10 @@ namespace ProtoCore.DSASM.Mirror
// check if the members are primitive type
if (val.IsPointer &&
- core.Heap.Heaplist[(int)val.opdata].Stack.Length == 1 &&
- !core.Heap.Heaplist[(int)val.opdata].Stack[0].IsPointer &&
- ... | [ExecutionMirror->[PrintClass->[PrintClass],CompareArrays->[CompareArrays],SetValueAndExecute->[SetValue],GetClassTrace->[GetStringValue],GetArrayTrace->[GetStringValue,GetPointerTrace],Obj->[GetType,GetSymbolIndex],EqualDotNetObject->[GetType,GetProperties,EqualDotNetObject],GetGlobalVarTrace->[GetStringValue,GetForma... | GetProperties - Get properties of given object. | Calling same method four times :( |
@@ -8,7 +8,7 @@ from scipy import linalg
from distutils.version import LooseVersion
from .mixin import TransformerMixin
-
+from mne import EvokedArray
class CSP(TransformerMixin):
"""M/EEG signal decomposition using the Common Spatial Patterns (CSP)
| [CSP->[_fit->[diag,sqrt,trace,maximum,eigh,pinv,argsort,dot],transform->[,type,asarray,log,ValueError,isinstance,RuntimeError,dot],fit->[,_fit,LedoitWolf,asarray,atleast_3d,std,transpose,Exception,ShrunkCovariance,LooseVersion,dot,type,unique,mean,len,ValueError,isinstance,OAS,fit]]] | A base class for the CSP object. Estimate the CSP decomposition on epochs. | oh boy. Use relative imports |
@@ -141,6 +141,10 @@ export default Component.extend({
focusTarget = this.element.querySelector(
".modal-body input, .modal-body button, .modal-footer input, .modal-footer button"
);
+
+ if (!focusTarget) {
+ focusTarget = this.element.querySelector(".modal-header button");
... | [No CFG could be retrieved] | Autofocus the modal body. | Why not add to the selector above? it's already doing multiple things in one line. |
@@ -76,9 +76,11 @@ public class OidcIdTokenGeneratorServiceTests extends AbstractOidcTests {
val claims = oidcTokenSigningAndEncryptionService.decode(idToken, Optional.ofNullable(registeredService));
assertNotNull(claims);
- assertTrue(claims.hasClaim("mail"));
- assertEquals("casuser@... | [OidcIdTokenGeneratorServiceTests->[verifyTokenGenerationWithoutCallbackService->[setAttribute,assertNotNull,of,CommonProfile,getSimpleName,thenReturn,getAuthentication,mock,generate,MockHttpServletResponse,setId,getRegisteredOAuthServiceByClientId,wrap,MockHttpServletRequest,setClientName],verifyTokenGenerationFailsWi... | Verify token generation. Verify token generation without callback service. | Please also verify that claims returned are single-valued claims. For example, why is name a list here? |
@@ -242,9 +242,13 @@ public class HadoopDruidIndexerConfig
)
)
);
+
+ Map<ShardSpec, HadoopyShardSpec> hadoopyShardSpecLookup = Maps.newHashMap();
for (HadoopyShardSpec hadoopyShardSpec : entry.getValue()) {
- hadoopShardSpecLookup.put(hadoopyShardSpec.getActualSpec()... | [HadoopDruidIndexerConfig->[getIndexSpec->[getIndexSpec],isIgnoreInvalidRows->[isIgnoreInvalidRows],fromFile->[fromMap],isDeterminingPartitions->[isDeterminingPartitions],makeIntermediatePath->[getDataSource,getWorkingPath],isOverwriteFiles->[isOverwriteFiles],verify->[getDataSource,getGranularitySpec,getWorkingPath],s... | Gets the schema of the ingestion spec. | suggest rename to `innerHadoopShardSpecLookup` - "hadoopy" is easy to mistake for "hadoop" when someone is reading this code |
@@ -588,6 +588,9 @@ void ModApiUtil::Initialize(lua_State *L, int top)
API_FCT(decompress);
API_FCT(mkdir);
+ API_FCT(rmdir);
+ API_FCT(cpdir);
+ API_FCT(mvdir);
API_FCT(get_dir_list);
API_FCT(safe_file_write);
| [l_safe_file_write->[luaL_checklstring,CHECK_SECURE_PATH,luaL_checkstring,lua_pushboolean],l_get_last_run_mod->[lua_rawgeti,empty,lua_pop,getScriptApiBase,lua_pushstring],l_get_us_time->[lua_pushnumber],l_write_json->[lua_pushlstring,fastWriteJson,size,lua_isnone,c_str,what,toStyledString,lua_pop,lua_pushnil,read_json_... | Initializes the API. | Missing `mvdir` here (not that it matters, async is mainmenu-only currently) |
@@ -18,9 +18,13 @@
*/
const _ = require('lodash');
const Randexp = require('randexp');
+const faker = require('faker');
const utils = require('../utils');
const constants = require('../generator-constants');
+// In order to have consistent results with RandExp, the RNG is seeded.
+Randexp.prototype.randInt = (m... | [No CFG could be retrieved] | Creates a new object. Entity - management detail component. | It's not used elsewhere in this file, this should be removed. Further more, I'm not fond of modifying the prototype of something like that. In this case, I see that we set a new function to Randexp: - if it's a new one, then it's kinda okay... until Randexp implements a `randIt` function. - if a `randInt` already exist... |
@@ -242,6 +242,10 @@ public class Schema implements Serializable {
public abstract TypeName getTypeName();
// For container types (e.g. ARRAY), returns the type of the contained element.
@Nullable public abstract FieldType getComponentType();
+ // For MAP type, returns the type of the key element.
+ ... | [Schema->[fromFields->[Schema],of->[build],Builder->[addFields->[addFields],build->[Schema]],getRowCoder->[of],equals->[equals],builder->[Builder],Field->[of->[build],withType->[build],withNullable->[build],equals->[getDescription,equals,getNullable,getName,getType],hashCode->[getNullable,getName,getDescription,getType... | Replies the type of the column. | to me it looks like both `getComponentValueType()` and `getComponentType()` mean the same thing, i.e. they both describe the type of the value in the container. Keep just one of them? |
@@ -384,7 +384,9 @@ class ServiceBusClient(object):
retry_backoff_max=self._config.retry_backoff_max,
**kwargs
)
- else:
+ except ValueError:
+ if sub_queue: # If we got here and sub_queue is defined, it's an incorrect value or something unrelated.... | [ServiceBusClient->[get_queue_receiver->[append,get,ServiceBusReceiver,ValueError,generate_dead_letter_entity_name],get_queue_sender->[append,ServiceBusSender],get_subscription_receiver->[append,get,ServiceBusReceiver,ValueError,generate_dead_letter_entity_name],__enter__->[_create_uamqp_connection],__exit__->[close],g... | Returns a ServiceBusReceiver for the given topic and subscription. Creates a new ServiceBusReceiver instance. Creates a new service bus receiver object. | I think it should be moved ahead of "handler = ServiceBusReceiver". otherwise if it's a normal queue if any value raised by ServiceBusReceiver constructors would be omitted. |
@@ -5665,7 +5665,13 @@ SpellCastResult Spell::CheckCast(bool strict)
m_caster->RemoveMovementImpairingAuras(true);
}
if (m_caster->HasUnitState(UNIT_STATE_ROOT))
- return SPELL_FAILED_ROOTED;
+ {
+ ... | [No CFG could be retrieved] | finds the next unit in the list of units that can be played and has a finds the unit target spell in the ring of the vehicle. | I'd really appreciate if you turn this into a constexpr or something readable |
@@ -224,6 +224,16 @@ bool GenericAgentCheckPolicy(GenericAgentConfig *config, bool force_validation,
{
if (!MissingInputFile(config->input_file))
{
+ {
+ time_t validated_at = ReadTimestampFromPolicyValidatedFile(config, NULL);
+ if (config->agent_type == AGENT_TYPE_SERVER ||
+ ... | [No CFG could be retrieved] | Check if the policy is valid. Check if the policy is valid. | This is begging to be a switch (config->agent_type) ! |
@@ -51,7 +51,9 @@ func (a *appendableAppender) AddFast(l labels.Labels, ref uint64, t int64, v flo
}
func (a *appendableAppender) Commit() error {
- if _, err := a.pusher.Push(a.ctx, client.ToWriteRequest(a.samples)); err != nil {
+ ctx, cancel := context.WithTimeout(a.ctx, 15*time.Second)
+ defer cancel()
+ if _, ... | [AddFast->[Add],Add->[Time,LabelValue,LabelName,SampleValue],Commit->[Push,ToWriteRequest]] | Commit writes the samples to the appender. | Is this timeout path sufficiently central to warrant a command line flag? More specifically I wonder if a sufficiently large cluster would benefit from a configurable timeout on writing back to the ingesters. |
@@ -72,4 +72,15 @@ public class TestGroupingSets
"GROUP BY DISTINCT a, GROUPING SETS ((), (t.a))",
"VALUES 1");
}
+
+ @Test
+ public void testRollupAggregationWithOrderedLimit()
+ {
+ assertions.assertQuery("" +
+ "SELECT a " +
+ ... | [TestGroupingSets->[init->[QueryAssertions],testDistinctWithMixedReferences->[assertQuery],teardown->[close],testPredicateOverGroupingKeysWithEmptyGroupingSet->[assertQuery]]] | Checks that the distinct elements of the sequence are distinct with mixed references. | The parenthesis around each element are not necessary. |
@@ -210,7 +210,7 @@ public class ITUnionQueryTest extends AbstractIndexerTest
LOG.info("Event Receiver Found at host [%s]", host);
LOG.info("Checking worker /status/health for [%s]", host);
- final StatusResponseHandler handler = new StatusResponseHandler(StandardCharsets.UTF_8);
+ final Statu... | [ITUnionQueryTest->[setShutOffTime->[replace,toString],postEvents->[waitUntilInstanceReady,error,getPort,equals,start,stop,get,postEventsFromFile,format,EventReceiverFirehoseTestClient,retryUntilTrue,info,StatusResponseHandler,createSelector,getMiddleManagerHost],withServiceName->[replace],setFullDatasourceName->[getEx... | Post events from the event receiver. | This variable is unnecessary now. |
@@ -147,7 +147,7 @@ public final class DefaultExtensionsClient implements ExtensionsClient {
}
} else {
if (value instanceof String && parser.isContainsTemplate((String) value)) {
- values.put(name, new TypeSafeExpressionValueResolver<>((String) value, Object.class));
+ values... | [DefaultExtensionsClient->[executeAsync->[doAfterTerminate,createProcessor,toFuture,disposeProcessor],resolveParameters->[MuleRuntimeException,initialiseIfNeeded,build,isContainsTemplate,getType,createStaticMessage,addPropertyResolver,format,forEach,put],disposeProcessor->[MuleRuntimeException,dispose,stop,createStatic... | Resolves parameters. | why? you're loosing functionality here |
@@ -147,6 +147,10 @@ namespace Content.Server.Electrocution
if (!electrified.OnInteractUsing)
return;
+ // Make an exception for floor tiles, to make placing them around exposed wires less of a hassle.
+ if (HasComp<FloorTileItemComponent>(args.Used))
+ ... | [ElectrocutionSystem->[GetChainedElectrocutionTargetsRecurse->[GetChainedElectrocutionTargetsRecurse],Initialize->[Initialize]]] | This method is called when a user is electrified in the system. TryNode - tries to find a node in the system with the highest power and dam. | Do you know if disposal pipes are also okay? |
@@ -45,3 +45,8 @@ class AssignHomepageCollectionForm(forms.ModelForm):
class Meta:
model = SiteSettings
fields = ('homepage_collection',)
+
+ def __init__(self, *args, **kwargs):
+ super().__init__(*args, **kwargs)
+ self.fields['homepage_collection'].queryset = Collection.object... | [CollectionForm->[save->[slugify,super,unidecode],Meta->[pgettext_lazy],__init__->[all,SeoDescriptionField,super,SeoTitleField,fields],all,pgettext_lazy,AjaxSelect2MultipleChoiceField,reverse_lazy]] | The default meta class. | I think we could break the line after `queryset =` to make it a little bit prettier |
@@ -1,10 +1,10 @@
class ResultsController < ApplicationController
- before_filter :authorize_only_for_admin, :except => [:codeviewer,
+ before_filter :authorize_only_for_admin, except: [:codeviewer,
:edit, :update_mark, :view_marks, :create, :add_extra_mark, :next_grouping, :update_overall_comment, :exp... | [ResultsController->[create->[redirect_to,id,find,get_result_used,new,has_result?,submission,result_version_used,save,marking_state],add_extra_mark->[new,find,unit,render,update_attributes,result,post?,save],view_marks->[submission_files,find,percentage,accepted_grouping_for,first,rubric_criteria,released_to_students,g... | Creates a new result for a given Submission and returns the ID of the newly created result. | Put one space between the method name and the first argument. |
@@ -1,15 +1,7 @@
-// Copyright 2015 The Gogs Authors. All rights reserved.
-// Use of this source code is governed by a MIT-style
// license that can be found in the LICENSE file.
// Package v1 Gitea API.
//
-// This provide API interface to communicate with this Gitea instance.
-//
-// Terms Of Service:
-//
-// t... | [IsOrganizationOwner,APIContexter,Patch,Status,IsErrOrgNotExist,Delete,RepoRef,UserID,IsWriter,GetRepositoryByName,AllowsPulls,IsErrRepoNotExist,Put,IsErrRepoRedirectNotExist,UnitEnabled,Error,GetTeamByID,Post,IsOrganizationMember,RedirectToRepo,LookupRepoRedirect,Any,ParamsInt64,GetOrgByName,ToLower,IsErrUserNotExist,... | Requires a MIT license and API interface to communicate with this Gitea instance. repoAssignment returns a handler which checks if the user has the same name as the repository owner. | Why you remove copyrigths ? We could add gitea ones ? |
@@ -75,6 +75,7 @@ function SidebarWithRef(
side = 'left',
onBeforeOpen,
onAfterClose,
+ maskStyle,
children,
...rest
},
| [No CFG could be retrieved] | Creates a sidebar with a single . This is a utility function that is used by the UI and the UI components. | Is the `mask` a good name? It's usually called backdrop... Also, if we supply `backdrop/maskStyle`, then we should also supply `backdrop/maskClassName`. |
@@ -39,12 +39,16 @@ public interface KafkaConsumerGroupClient {
* API POJOs
*/
class ConsumerGroupSummary {
- final Set<ConsumerSummary> consumerSummaries = new HashSet<>();
+ private final ImmutableSet<ConsumerSummary> consumerSummaries;
public ConsumerGroupSummary(final Set<ConsumerSummary> su... | [ConsumerSummary->[addPartition->[add],addPartitions->[addAll],hashCode->[hash],equals->[getClass,equals]],ConsumerGroupSummary->[addAll]] | Returns a collection of all consumers. | Adding `private` is a side improvement. |
@@ -158,6 +158,18 @@ public interface BaseEventContext extends EventContext {
*/
void onResponse(BiConsumer<CoreEvent, Throwable> consumer);
+ /**
+ * Register a {@link BiConsumer} callback that will be executed when a response event or error is available for this
+ * {@link EventContext} before response ... | [No CFG could be retrieved] | onResponse is called when a response is received from the client. | place this method before `onResponse ` |
@@ -42,7 +42,15 @@ func (r *RegistryComponentOptions) Name() string {
}
func (r *RegistryComponentOptions) Install(dockerClient dockerhelper.Interface, logdir string) error {
- kubeClient, err := kubernetes.NewForConfig(r.ClusterAdminKubeConfig)
+ clusterAdminKubeConfigBytes, err := ioutil.ReadFile(path.Join(r.Mast... | [Install->[DiscardContainer,AddSCCToServiceAccount,NewForConfig,LogContainer,Bind,New,HostPid,Errorf,Services,NewHelper,NewError,Join,Infof,Output,Privileged,Name,Get,Entrypoint,Command,HostNetwork,Image,Sprintf,Core,IsNotFound,NewRunHelper,WithCause]] | Install creates a docker registry component run the command. | Can we make something like `ComponentContext` and have all clients there? Guess we will have to repeat this in all installs. |
@@ -39,6 +39,11 @@ import org.nuxeo.runtime.transaction.TransactionHelper;
*/
public class RestServerInit implements RepositoryInit {
+ /**
+ * @since 9.3
+ */
+ protected static final int MAX_FILE = 5;
+
@Override
public void populate(CoreSession session) {
JsonFactoryManager json... | [RestServerInit->[populate->[getMessage,toggleStackDisplay,commitOrRollbackTransaction,createSavedSearch,getService,getDocument,println,isStackDisplay,getInstance,createDocument,setProperty,set,startTransaction,getId,setPropertyValue,createDocumentModel,saveSavedSearch],getSavedSearchId->[getService,getCurrentUserPerso... | Populates the missing data structures. This method is called when a user enters a saved search. It creates a new saved. | No need for `@since 9.3` here, it's protected and in tests. |
@@ -1747,11 +1747,6 @@ BLOCKABLE_USER_AGENTS = [
"curl",
]
-# TODO: Once using DRF more we need to make that exception handler more generic
-REST_FRAMEWORK = {
- 'EXCEPTION_HANDLER': 'kuma.search.utils.search_exception_handler'
-}
-
SENTRY_DSN = config('SENTRY_DSN', default=None)
if SENTRY_DSN:
| [pipeline_one_scss->[pipeline_scss],_get_locales->[path],path,_get_locales,parse_iframe_url] | This function is a utility function that can be used to configure the user account. SP reporting endpoint. | So weird that the error handling was attached to the `search` app when it should be generic. A relic from the past. |
@@ -544,6 +544,7 @@ public class QueueImpl extends CriticalComponentImpl implements Queue {
@Override
public synchronized void setExclusive(boolean exclusive) {
+ new Exception("exclusive set at " + exclusive).printStackTrace();
this.exclusive = exclusive;
}
| [QueueImpl->[getDurableDeliveringCount->[getDurableMessageCount],scheduleDepage->[getName],configureExpiry->[getExpiryAddress],addConsumer->[debug],deleteAllReferences->[deleteAllReferences],configureSlowConsumerReaper->[equals,getName,cancel,debug],getMessageCount->[getMessageCount],getDeliveringCount->[getMessageCoun... | Sets the exclusive flag. | Think this needs to be removed. |
@@ -1014,6 +1014,13 @@ func useAnsible(v semver.Version) bool {
return v.GTE(openshiftVersion36)
}
+// clusterVersionIsCurrent returns whether the cluster version being
+// brought up matches the client binary being used. This needs to
+// be updated each release.
+func clusterVersionIsCurrent(v semver.Version) b... | [determineIP->[OpenShiftHelper,DockerHelper],InstallRouter->[InstallRouter,imageFormat],InstallMetrics->[InstallMetrics],CreateProject->[CreateProject],Bind->[Bind],importObjects->[OpenShiftHelper,Factory],RegisterTemplateServiceBroker->[RegisterTemplateServiceBroker],Login->[Login],InstallServiceCatalog->[imageFormat,... | InstallLogging installs logging for the client. | Won't this return true for 3.7.1? |
@@ -94,6 +94,10 @@ void goto_tramming_wizard() {
set_all_unhomed();
queue.inject_P(TERN(CAN_SET_LEVELING_AFTER_G28, PSTR("G28L0"), G28_STR));
+ // Initialize points to invalid so we will know if they have been measured.
+ LOOP_L_N(i, G35_PROBE_COUNT) z_isvalid[i] = false;
+ reference_index = -1;
+
ui.goto... | [No CFG could be retrieved] | Goto the screen with the tramming wizard. | `ZERO(z_isvalid)` would also be fine here, but I'm not sure whether it results in smaller code. Probably the compiler knows to convert `memset` into a small loop in some cases. |
@@ -149,7 +149,7 @@ def cast_to_floatx(x):
Example:
```python
- >>> from keras import backend as K
+ >>> from tensorflow.keras import backend as K
>>> K.floatx()
'float32'
>>> arr = numpy.array([1.0, 2.0], dtype='float64')
| [var->[cast],all->[cast],batch_set_value->[get_session,placeholder,dtype,get_graph],gradients->[gradients],argmin->[argmin],set_value->[get_session,placeholder,dtype,get_graph],repeat->[ndim],dropout->[dropout],gather->[gather],binary_crossentropy->[_to_tensor,log],resize_images->[constant,permute_dimensions,shape,int_... | Cast a Numpy array to the default Keras float type. | This is the docstring for `cast_to_floatx`, so I guess this should be `K.cast_to_floatx` |
@@ -313,8 +313,8 @@ static struct daos_obj_class daos_obj_classes[] = {
},
},
{
- .oc_name = "EC_4P2G1",
- .oc_id = OC_EC_4P2G1,
+ .oc_name = "DAOS_OC_EC_K4P1_L32K",
+ .oc_id = DAOS_OC_EC_K4P2_L32K,
{
.ca_schema = DAOS_OS_SINGLE,
.ca_resil = DAOS_RES_EC,
| [obj_ec_codec_init->[obj_ec_codec_fini],obj_encode_full_stripe->[obj_ec_codec_get,daos_oclass_attr_find]] | private function for returning names of objects that can be indexed by their respective values. find the object class attributes for the provided object class find object class by oid. | why remove original EC_4P2G1? (with cell size as 1M), looks better keep it, so we have a default cell size 1M's 4P2 |
@@ -8,7 +8,6 @@ import (
"fmt"
"net"
"net/http"
- "net/http/fcgi"
_ "net/http/pprof" // Used for debugging if enabled and a web server is running
"os"
"strings"
| [IsFile,FileMode,SetValue,Critical,HandlerFunc,TrimRight,RequestURI,Close,Getppid,Redirect,Info,IsSet,IsNotExist,Error,Append,Empty,WaitForServers,SaveTo,WaitForTerminate,Errorf,ListenUnix,NewMacaron,HTTPHandler,Key,Section,Remove,HostWhitelist,RegisterRoutes,ListenAndServe,ClearHandler,Serve,DirCache,GlobalInit,TrimSu... | Commands for the main application of the gopkg. Run the LetsEncrypt handshaking. | `net` imported and not used. |
@@ -0,0 +1,14 @@
+// @flow
+
+import { StateListenerRegistry } from '../base/redux';
+import VideoLayout from '../../../modules/UI/videolayout/VideoLayout';
+
+/**
+ * Updates the on stage participant video.
+ */
+StateListenerRegistry.register(
+ /* selector */ state => state['features/large-video'].participantId,
... | [No CFG could be retrieved] | No Summary Found. | This change just broke mobile. `VideoLayout` is not working there. |
@@ -98,7 +98,7 @@ public class SearchProjectsAction implements ComponentsWsAction {
Ordering<ComponentDto> ordering = Ordering.explicit(searchResult.getIds()).onResultOf(ComponentDto::uuid);
List<ComponentDto> projects = ordering.immutableSortedCopy(dbClient.componentDao().selectByUuids(dbSession, searchResul... | [SearchProjectsAction->[doHandle->[openSession,buildResponse,searchProjects],searchProjects->[immutableSortedCopy,setPage,getFilter,search,newProjectMeasuresQuery,firstNonNull,SearchResults,validate,getPage,onResultOf,selectByUuids,getPageSize,getTotal,getIds],toRequest->[build,mandatoryParamAsInt,setPageSize],buildRes... | Search for projects based on the filter and page size. | Why not give only searchResult to SearchResults ? Instead of Facets + total. |
@@ -95,6 +95,7 @@ inverse_node_kinds = {_kind: _name for _name, _kind in node_kinds.items()} # ty
implicit_module_attrs = {'__name__': '__builtins__.str',
+ '__qualname__': '__builtins__.str',
'__doc__': None, # depends on Python version, see semanal.py
... | [ClassDef->[serialize->[serialize],is_generic->[is_generic],deserialize->[ClassDef,deserialize]],TypeAlias->[serialize->[serialize]],FuncDef->[serialize->[serialize],deserialize->[FuncDef]],Decorator->[fullname->[fullname],serialize->[serialize],name->[name],deserialize->[Decorator,deserialize]],TypeVarExpr->[serialize... | Json dictionary representation of a Critical Number of Node - Kinds. This keeps track of the oldest supported Python version where the corresponding alias _target_. | I don't think this is a right solution since this way mypy will not complain about `__qualname__` at module scope. The latter is defined only at a class scope. |
@@ -9,12 +9,12 @@ namespace System
/// <summary>
/// Check if the stress mode is enabled.
/// </summary>
- /// <value> true if the environment variable COREFX_STRESS set to '1' or 'true'. returns false otherwise</value>
+ /// <value> true if the environment variable DOTNET_TEST_... | [TestEnvironment->[OrdinalIgnoreCase,GetEnvironmentVariable,Equals]] | Checks if the system environment variable COREFX_STRESS is set to 1 or true. | I can live with "DOTNET_TEST" But I would have preferred "DOTNETLIB_TEST". I think "DOTNET" might be too generic and these variables are specifically about .NET Libraries stuff. |
@@ -219,6 +219,16 @@ func TwoFactorPost(ctx *context.Context, form auth.TwoFactorAuthForm) {
return
}
+ if ctx.Session.Get("linkAccount") != nil {
+ gothUser := ctx.Session.Get("linkAccountGothUser")
+ if gothUser == nil {
+ ctx.Handle(500, "UserSignIn", errors.New("not in LinkAccount session"))
+ r... | [Handle,Auth,LinkAccountToUser,IsErrTwoFactorNotEnrolled,GetSuperSecureCookie,QueryUnescape,CreateUser,Delete,GetUser,GetUserByID,Redirect,Info,Set,ProviderCallback,RenderWithErr,Put,GetActiveOAuth2Providers,Activate,GetUserByEmail,HTML,Error,IsErrUserAlreadyExist,VerifyScratchToken,GetActiveOAuth2LoginSourceByName,Upd... | TwoFactorPost validates a user s two - factor authentication token and displays a page with a TwoFactorScratchPost validates and invalidates a user s two - factor scratch token. | handle the error? |
@@ -225,12 +225,8 @@ public class HttpUploadServerHandler extends SimpleChannelInboundHandler<HttpObj
logger.info(" 100% (FinalSize: " + partialContent.length() + ")");
partialContent = null;
}
- try {
- // ... | [HttpUploadServerHandler->[writeHttpData->[getValue,getMessage,getName,append,isCompleted,getCharset,getString,printStackTrace,getHttpDataType,length,name],reset->[destroy],readHttpDataChunkByChunk->[hasNext,writeHttpData,definedLength,append,currentPartialHttpData,release,toString,StringBuilder,info,length,next],chann... | readHttpDataChunkByChunk - Read HTTP data chunk by chunk. | writeHttpData always guarantees to release data even if it throws an exception for some reason? |
@@ -915,7 +915,13 @@ static int _has_list(char *name)
return !strcmp(name, "subject")
|| !strcmp(name, "hierarchicalSubject")
|| !strcmp(name, "RetouchInfo")
- || !strcmp(name, "ToneCurvePV2012");
+ || !strcmp(name, "ToneCurvePV2012")
+ || !strcmp(name, "title")
+ || !strcmp(name, "description")
+ ||... | [No CFG could be retrieved] | _handle_xpath returns true if the node contains a list of values. XML node - lightroom - import. | no tabulations please. |
@@ -18,6 +18,14 @@ from ..utils import logger
from ..io.pick import pick_types
+def get_fast_dot():
+ try:
+ from sklearn.utils.extmath import fast_dot
+ except ImportError:
+ fast_dot = np.dot
+ return fast_dot
+
+
def linear_regression(inst, design_matrix, names=None):
"""Fit Ordinar... | [linear_regression->[namedtuple,EvokedArray,warn,RuntimeError,info,enumerate,get_data,isgenerator,copy,zeros,range,product,len,lm,ValueError,isinstance,_fit_lm,next,pick_types,array],_fit_lm->[log10,cdf,diag,dict,sqrt,len,ValueError,inv,lstsq,zip,product,range,reshape,abs,dot]] | Fit Ordinary Least Squares regression for a given set of data. Fit a linear model to the given data. | don't we already have this elsewhere? please import from wherever that is, or better move it to e.g. `mne/fixes.py` |
@@ -52,7 +52,9 @@ namespace System.Net.Http.Functional.Tests
return useVersion.Major switch
{
#if NETCOREAPP
+#if HTTP3
3 => Http3LoopbackServerFactory.Singleton,
+#endif
2 => Http2LoopbackServerFactory.Singleton,
#endif
_ => Http11LoopbackS... | [HttpClientHandlerTestBase->[VersionCheckerHttpHandler->[SendAsync->[SendAsync]]]] | Get the factory for the given version. | We don't have this #if elsewhere, what is the intent? |
@@ -15,13 +15,12 @@ package io.prestosql.plugin.session.file;
import com.fasterxml.jackson.databind.JsonMappingException;
import com.fasterxml.jackson.databind.exc.UnrecognizedPropertyException;
-import com.google.common.collect.ImmutableMap;
+import com.google.common.collect.ImmutableList;
import io.airlift.json.... | [FileSessionPropertyManager->[getSystemSessionProperties->[copyOf,match,putAll],getCatalogSessionProperties->[of],fromJson,UncheckedIOException,IllegalArgumentException,listJsonCodec,getColumnNr,getMessage,readAllBytes,getCause,getLineNr,getPropertyName,requireNonNull,format,toPath]] | Creates an object that represents a single session match specification. File session property manager. | We could just use interface type in the declaration |
@@ -142,7 +142,17 @@ public class InfinispanClientProducer {
}
builder.marshaller((Marshaller) marshallerInstance);
}
+
+ // Override serverList property value at runtime if such configuration exists
+ if (infinispanClientConfigRuntime != null) {
+ Optional<St... | [InfinispanClientProducer->[remoteCacheManager->[initialize]]] | This method creates a builder from the given properties. region MessageMarshaller Implementation. | check in case this is null ... |
@@ -332,6 +332,16 @@ class WPCOM_JSON_API_Site_Settings_Endpoint extends WPCOM_JSON_API_Endpoint {
}
break;
+ case 'holidaysnow':
+ if ( empty( $value ) || WPCOM_JSON_API::is_falsy( $value ) ) {
+ if ( function_exists( 'jetpack_holiday_snow_option_name' ) && delete_option( jetpack_holiday_snow... | [WPCOM_JSON_API_Site_Settings_Endpoint->[update_settings->[jetpack_relatedposts_supported],get_settings_response->[jetpack_relatedposts_supported]]] | Updates the site settings This function is called to set the related posts settings Update the options of the WordPress Google Analytics plugin This function is called when a user changes the value of the relatedposts option in the J This function is used to populate the updated field of the configuration object. | Nitpick: too much whitespace and `break` is misaligned. |
@@ -420,7 +420,8 @@ public class ComputeEngineContainerImpl implements ComputeEngineContainer {
LogServerId.class,
ServerLifecycleNotifier.class,
PurgeCeActivities.class,
- CeQueueCleaner.class
+ CeQueueCleaner.class,
+ CeWorkerCountSettingWarning.class
};
}
| [ComputeEngineContainerImpl->[toArray->[toArray]]] | This method returns an array of components that can be used to initialize the server. | As the component is declared in the CE container, the warning will only be seen when executing a CE task. I think this will be hard for users to see it. Why not put in the web container in order to see the warning in web.log, at startup ? |
@@ -369,9 +369,10 @@ export class PreactBaseElement extends AMP.BaseElement {
* A callback called immediately after mutations have been observed on a
* component. This differs from `checkPropsPostMutations` in that it is
* called in all cases of mutation.
+ * @param {Array<MutationRecord>} unusedRecords
... | [No CFG could be retrieved] | A callback to check if a given has been observed on the current component. Checks if the given mutations have a and if so schedules the render of the . | Also, it should be `!Array...`. |
@@ -5,13 +5,17 @@ require_dependency 'gaps'
class TopicView
- attr_reader :topic, :posts, :guardian, :filtered_posts, :chunk_size
+ attr_reader :topic, :posts, :guardian, :filtered_posts, :chunk_size, :print
attr_accessor :draft, :draft_key, :draft_sequence, :user_custom_fields, :post_custom_fields
def s... | [TopicView->[relative_url->[relative_url],title->[title],setup_filtered_posts->[summary,has_deleted?],initialize->[chunk_size,slow_chunk_size,whitelisted_post_custom_fields],filter_posts_by_ids->[filter_post_types],image_url->[image_url],filter_posts_in_range->[filter_posts_by_ids],unfiltered_posts->[filter_post_types]... | Initialize the object. | This and the surrounding methods should be a constant IMO. |
@@ -1522,6 +1522,14 @@ func resourceAwsInstanceUpdate(d *schema.ResourceData, meta interface{}) error {
}
}
}
+
+ if d.HasChange("root_block_device.0.tags") {
+ o, n := d.GetChange("root_block_device.0.tags")
+
+ if err := keyvaluetags.Ec2UpdateTags(conn, volumeID, o, n); err != nil {
+ return fmt.E... | [IgnoreAws,DescribeIamInstanceProfileAssociations,HasPrefix,Int64Value,New,Len,SetId,AssignPrivateIpAddresses,Bool,Any,Timeout,IgnoreConfig,Map,Split,DescribeVpcs,IntBetween,Difference,GetPasswordData,ErrMessageContains,VolumeType_Values,Ec2UpdateTags,DescribeTags,GetOk,TimedOut,DescribeVolumes,HasChanges,RetryableErro... | region Instance Read returns the unique id for the instance. | Won't we need to handle `d.HasChange("ebs_block_device.0.tags")` also? |
@@ -672,12 +672,12 @@ class FreqtradeBot:
order_book_min = config_ask_strategy.get('order_book_min', 1)
order_book_max = config_ask_strategy.get('order_book_max', 1)
- order_book = self.exchange.get_order_book(trade.pair, order_book_max)
-
+ order_book = self._order_boo... | [FreqtradeBot->[execute_buy->[get_buy_rate,_get_min_pair_stake_amount],_check_available_stake_amount->[_get_available_stake_amount],_notify_buy_cancel->[get_buy_rate],_notify_sell->[get_sell_rate],_notify_sell_cancel->[get_sell_rate],cleanup->[cleanup],handle_trailing_stoploss_on_exchange->[create_stoploss_order],handl... | Handle a trade. Check if there is a non - sell signal. | these are not 'asks top' anymore, these are 'side's top N entries' |
@@ -57,7 +57,7 @@ module Admin
def page_params
allowed_params = %i[title slug body_markdown body_html body_json description template is_top_level_path
- social_image]
+ social_image landing_page overwrite]
params.require(:page).permit(allowed_params... | [PagesController->[destroy->[destroy],prepopulate_new_form->[new],new->[new],create->[new]]] | page params that can be used in the coc_text action. | maybe we can call that `overwrite_landing_page` ? |
@@ -71,6 +71,13 @@ function elgg_can_edit_widget_layout($context, $user_guid = 0) {
* @since 1.8.0
*/
function elgg_register_widget_type($handler, $name, $description, $context = array('all'), $multiple = false) {
+ if (is_string($context)) {
+ elgg_deprecated_notice('context parameters for elgg_register_widget_t... | [elgg_is_widget_type->[validateType],elgg_get_widgets->[getWidgets],elgg_can_edit_widget_layout->[canEditLayout],elgg_create_widget->[createWidget],elgg_register_widget_type->[registerType],_elgg_create_default_widgets->[getType,save,getSubtype],elgg_get_widget_types->[getTypes],elgg_unregister_widget_type->[unregister... | Registers a widget type. | Why don't we just cast to array so we support both? |
@@ -43,6 +43,7 @@ OpenDDS::DCPS::TransportReactorTask::TransportReactorTask(bool useAsyncSend)
this->reactor_ = new ACE_Reactor(new ACE_Select_Reactor, 1);
this->proactor_ = 0;
+ this->reactor_owner_ = ACE_OS::NULL_thread;
}
OpenDDS::DCPS::TransportReactorTask::~TransportReactorTask()
| [No CFG could be retrieved] | Creates a new instance of the TransportReactorTask object. Implementation of the Event Processor. | This should be moved to the initializer list so that in the case of useAsyncSend it is also initialized. |
@@ -995,7 +995,7 @@ func Head(val interface{}) *eth.Head {
case *big.Int:
h = eth.NewHead(t, utils.NewHash(), utils.NewHash(), time, utils.NewBig(&FixtureChainID))
default:
- logger.Panicf("Could not convert %v of type %T to Head", val, val)
+ panic(fmt.Sprintf("Could not convert %v of type %T to Head", val, v... | [NewBox->[NewBox],Get->[Get],Delete->[Delete],NewClientAndRenderer->[MustSeedNewSession],NewHTTPClient->[MustSeedNewSession],Start->[Start],Post->[Post],Import->[Import],Patch->[Patch],Put->[Put],Get,Delete,FailNow,NewHTTPClient,Post] | NullableTime returns a valid nullable time given a time string. DynamicFeeTransactionsFromTipCaps returns a new block with transactions with the given tip caps. | It is more accurate to use `logger.Fatalf` or `logger.Panicf` instead of panic |
@@ -22,14 +22,17 @@ package org.apache.hadoop.hdds.scm.ha;
import com.google.common.base.Strings;
import org.apache.hadoop.hdds.conf.ConfigurationException;
import org.apache.hadoop.hdds.conf.ConfigurationSource;
+import org.apache.hadoop.hdds.conf.OzoneConfiguration;
import org.apache.hadoop.hdds.scm.ScmConfigKeys... | [SCMHAUtils->[getLocalSCMNodeId->[addSuffix],getSCMNodeIds->[addSuffix,getTrimmedStringCollection],isSCMHAEnabled->[getBoolean],getScmServiceId->[size,getTrimmedStringCollection,getTrimmed,next,ConfigurationException],addSuffix->[startsWith,isEmpty],getSCMRatisDirectory->[isNullOrEmpty,getDefaultRatisDirectory,getRatis... | Imports a single object. This utility class is used by the SCMHA framework. | Minor: Expand * import. |
@@ -296,7 +296,17 @@ void ClientEnvironment::step(float dtime)
node_at_lplayer = m_map->getNode(p);
u16 light = getInteriorLight(node_at_lplayer, 0, m_client->ndef());
+
+ ItemStack wielditem;
+ wielditem = lplayer->getWieldedItem(&wielditem, nullptr);
+ ItemDefinition wielddef = wielditem.getDefinition(m_cl... | [No CFG could be retrieved] | Determine the fall damage modifier and update lighting. Step the object and handle all objects. | I don't think the idea was to override the light_color from here. Also this code is below `final_color_blend` which would have applied the changes. |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.