patch stringlengths 18 160k | callgraph stringlengths 4 179k | summary stringlengths 4 947 | msg stringlengths 6 3.42k |
|---|---|---|---|
@@ -32,7 +32,7 @@ namespace Dynamo.Models
public CustomNodeWorkspaceModel(
string name, string category, string description, double x, double y, Guid customNodeId,
- NodeFactory factory, string fileName="")
+ NodeFactory factory, ElementResolver elementResolver, string file... | [CustomNodeWorkspaceModel->[SaveAs->[SaveAs,SetInfo],PopulateXmlDocument->[PopulateXmlDocument],OnNodesModified->[OnNodesModified]]] | Creates a workspace model which contains all of the CustomNodeDefinitions that are part of a workspace returns the dependencies of this custom node based on the current state of this workspace. | Can `WorkspaceModel` not create `ElementResolver` internally? If it can, then we should definitely remove this, and make a `private readonly ElementResolver elementResolver` that can only be instantiated in the base `WorkspaceModel`. Derived workspace classes can use `WorkspaceModel.ElementResolver` internal property t... |
@@ -1325,6 +1325,8 @@ public class KVMStorageProcessor implements StorageProcessor {
image.snapRemove(snapshotName);
s_logger.info("Snapshot " + snap_full_name + " successfully removed from " +
primaryPool.getType().toString() + " pool.");
+ ... | [KVMStorageProcessor->[backupSnapshot->[backupSnapshotForObjectStore],attachVolume->[attachOrDetachDisk],cloneVolumeFromBaseTemplate->[templateToPrimaryDownload],configure->[getDefaultStorageScriptsDir,configure],dettachIso->[attachOrDetachISO],attachOrDetachDisk->[attachOrDetachDevice],dettachVolume->[attachOrDetachDi... | Delete snapshot. remove snapshot from storage pool. | Should we maybe include a bit more? Like: <pre>Failed to remove snapshot X, due to error: Y</pre> Now we just dump a Exception into the logs which might not always tell a user where it came from. |
@@ -1731,7 +1731,7 @@ namespace ProtoCore.Lang
var svArray = runtimeCore.Heap.ToHeapObject<DSArray>(sv1).Values.ToArray();
int length = svArray.Length;
- int indexToBeRemoved = (int)sv2.opdata;
+ int indexToBeRemoved = (int)sv2.IntegerValue;
if (indexToBeRe... | [MapBuiltIns->[MapTo->[Map]],FileIOBuiltIns->[StackValue->[ConvertToString]],RangeExpressionUntils->[GenerateNumericRange->[GenerateRangeByStepNumber,GenerateRangeByAmount,GenerateRangeByStepSize]],ArrayUtilsForBuiltIns->[CountTrue->[CountTrue],IsUniformDepth->[Rank],Exists->[Exists],SomeFalse->[Exists],SomeNulls->[Exi... | Remove method for the method that removes a value from the array. | Another casting that may not be needed if we made `IntegerValue` an `int` instead of `Int64`. |
@@ -26,10 +26,10 @@ from paddle import enable_static
"place does not support BF16 evaluation")
class TestMatmulBf16MklDNNOp(OpTest):
def generate_data(self):
- self.x = np.random.random((25, 2, 2)).astype(np.float32)
- self.y = np.random.random((25, 2, 2)).astype(np.float32)
+ ... | [TestMatmulBf16MklDNNOp->[setUp->[generate_data,set_attributes]]] | Generate data from the data model. | You have `self.alpha` set in `setUp `method already |
@@ -313,7 +313,7 @@ class AnnotationsControllerTest < AuthenticatedControllerTest
end
should 'recognize action to destroy' do
- assert_recognizes( {:action => 'destroy', :controller => 'annotations'},
- {:path => 'annotations', :method => 'delete'} )
+ assert_recognizes( {:action => ... | [AnnotationsControllerTest->[create,post_as,should,assert,post,assigns,assert_not_nil,delete_as,content,put_as,make,id,delete,context,assert_response,get,render_template,setup,assert_recognizes],join,require,expand_path,dirname] | - > find all annotations with action to destroy - > find all annotations with method delete. | Use the new Ruby 1.9 hash syntax. |
@@ -66,6 +66,15 @@ public final class HeadedGameRunner {
SwingUtilities.invokeLater(
() -> DownloadMapsWindow.showDownloadMapsWindowAndDownload(mapName));
});
+ MacOsIntegration.setOpenFilesHandler(
+ list ->
+ list.stream()
+ .findAny... | [HeadedGameRunner->[main->[isHeadless,start,isMac,getValueOrThrow,checkNotNull,decode,handleCommandLineArgs,updateSystemProxy,initialize,launch,invokeLater,getLocalizedMessage,orElse,await,log,addOpenUriHandler,checkState,isUsingSystemProxy,substring,invokeAndWait,length,showDownloadMapsWindowAndDownload,setDefaultUnca... | Main entry point for the triplea application. | Why is this a list? I'm noting that as picking the first element we find could cause ordering dependencies or other incorrect behavior. Is this to cover if a person selects many files and opens them all? |
@@ -55,7 +55,8 @@ func (c *CmdSigsRevoke) Run() error {
func NewCmdSigsRevoke(cl *libcmdline.CommandLine) cli.Command {
return cli.Command{
Name: "revoke",
- ArgumentHelp: "<id>",
+ ArgumentHelp: "<id> ...",
+ Usage: "Verify one or more signatures by sig ID",
Action: func(c *cli.Context) {
... | [Run->[RevokeSigs,TODO],ParseArgv->[Args,Errorf],ChooseCommand] | NewCmdSigsRevoke creates a cli. Command that revokes the given signature ID. | Verify? That doesn't sound right. Also, I believe there was no Usage for this command so it wouldn't show up in help. We can tell users about it if they need it, but don't want them running it without guidance. |
@@ -3803,8 +3803,9 @@ def numpy_full_dtype_nd(context, builder, sig, args):
def full(shape, value, dtype):
arr = np.empty(shape, dtype)
- for idx in np.ndindex(arr.shape):
- arr[idx] = value
+ arr_flat = arr.flat
+ for idx, _ in enumerate(arr_flat):
+ arr_flat[... | [np_array->[assign_sequence_to_array,compute_sequence_shape,_empty_nd_impl,check_sequence_shape],array_shape->[make_array],get_array_memory_extents->[offset_bounds_from_strides,compute_memory_extents],numpy_empty_nd->[_parse_empty_args,_empty_nd_impl],normalize_index->[make_array,load_item],maybe_copy_source->[src_geti... | Compile a full dtype nd signature. | Suggest using `for idx in range(len(arr_flat))` (or similar)? There's no need to set up the more complex loop structure? |
@@ -222,8 +222,9 @@ func (o *LoginOptions) gatherAuthInfo() error {
}
}
- // if a username was provided try to make use of it
- if o.usernameProvided() {
+ // if a username was provided try to make use of it, but if a password were provided we force a token
+ // request which will return a proper response code f... | [GatherInfo->[gatherAuthInfo,gatherProjectInfo],gatherAuthInfo->[ClientConfig,Has,Fprintf,NewDefaultClientConfig,Fprint,RequestToken,tokenProvided,New,IsUnauthorized,getClientConfig,usernameProvided],whoAmI->[New],SaveConfig->[IsNotExist,Dir,ModifyConfig,Stat,Errorf,MakeAbs,Getwd,RelativizeClientConfigPaths,GetDefaultF... | gatherAuthInfo is a helper function to gather authentication information from the CLI This function is called by the user to log into the kubeconfig. It will return nil if. | When password were explicitly provided through `--password` we are supposed to try to authenticate instead of reusing a matching stanza, because for example the password provided can be invalid. |
@@ -281,7 +281,7 @@ void OPENSSL_showfatal(const char *fmta, ...)
if (!ReportEvent(hEventLog, EVENTLOG_ERROR_TYPE, 0, 0, NULL,
1, 0, &pmsg, NULL)) {
-#if defined(DEBUG)
+# if! defined(NDEBUG)
/*
* We are in a situation where we tried to r... | [No CFG could be retrieved] | This function checks if the format string is valid and reports a critical error if it is. This function is called when a failure occurs. It is called by OpenSSL. It is. | That's an odd formatting? Strangely enough it seems to work at least with gcc and cl. Even if!defined(NDEBUG) works, i.e. without any spaces... Well, even if it works, please fix ~is~ this :-) |
@@ -706,8 +706,16 @@ func (s *HybridInboxSource) SetAppNotificationSettings(ctx context.Context, uid
func (s *HybridInboxSource) TeamTypeChanged(ctx context.Context, uid gregor1.UID,
vers chat1.InboxVers, convID chat1.ConversationID, teamType chat1.TeamType) (conv *chat1.ConversationLocal, err error) {
defer s.Tra... | [MembershipUpdate->[MembershipUpdate,Read,handleInboxError],SetAppNotificationSettings->[SetAppNotificationSettings,handleInboxError,getConvLocal],Localize->[filterSelfFinalized,filterInboxRes],ReadMessage->[ReadMessage,handleInboxError,getConvLocal],NewConversation->[NewConversation,handleInboxError],TlfFinalize->[not... | TeamTypeChanged implements keybase. NotifyTeamInterface. | Is this from debugging? |
@@ -374,3 +374,11 @@ function update_1315()
{
DBA::delete('item-delivery-data', ['postopts' => '', 'inform' => '', 'queue_count' => 0, 'queue_done' => 0]);
}
+
+function update_1318()
+{
+ DBA::update('profile', ['marital' => "In a relation"], ['marital' => "Unavailable"]);
+ DBA::update('profile', ['marital' => "S... | [No CFG could be retrieved] | Update the 1315 item delivery data. | I'm missing the `return Update::Success` statement, but I do see that the last update is missing it too. I'd prefer adding it to be consistent |
@@ -31,6 +31,7 @@ namespace DotNetNuke.Modules.CoreMessaging.ViewModels
public string Body { get; set; }
public string SenderAvatar { get; set; }
public string SenderProfileUrl { get; set; }
+ public string SenderDisplayName { get; set; }
public string DisplayDate { get; set; ... | [No CFG could be retrieved] | - The From - Body - The Sender - Profile - Url - The Display - Date. | Did you check all the place where this ViewModel is used? |
@@ -140,10 +140,9 @@ type Config struct {
func (cfg *Config) RegisterFlags(f *flag.FlagSet) {
cfg.BillingConfig.RegisterFlags(f)
cfg.PoolConfig.RegisterFlags(f)
- cfg.HATrackerConfig.RegisterFlags(f)
+ cfg.HATrackerConfig.RegisterFlags("distributor.", f)
f.BoolVar(&cfg.EnableBilling, "distributor.enable-billin... | [AllUserStats->[AllUserStats],Stop->[Stop],sendSamples->[Push],MetricsForLabelMatchers->[forAllIngesters,MetricsForLabelMatchers],Push->[tokenForLabels,checkSample],UserStats->[forAllIngesters,UserStats],LabelNames->[forAllIngesters,LabelNames],RegisterFlags->[RegisterFlags],LabelValuesForLabelName->[forAllIngesters]] | RegisterFlags registers flags for the config. | @tomwilkie I'm confused, I had the prefix as `distributor.` but your commit removing the prefix shows it was just `distributor` |
@@ -106,7 +106,7 @@ func (h *AccountHandler) ResetAccount(ctx context.Context, arg keybase1.ResetAcc
m.Debug("reset account succeeded, logging out.")
- return m.Logout()
+ return m.LogoutKillSecrets()
}
type GetLockdownResponse struct {
| [ResetAccount->[ResetAccount],PassphrasePrompt->[getDelegateSecretUI]] | ResetAccount resets the account for the given username. | We are resetting an account so we have a passphrase - kill secrets, don't force |
@@ -33,7 +33,7 @@ class Gapfiller(Package):
def patch(self):
with working_dir('.'):
- files = glob.iglob("*.pl")
+ files = glob.glob("**.pl")
for file in files:
change = FileFilter(file)
change.filter('usr/bin/perl', 'usr/bin/env perl'... | [Gapfiller->[install->[install,install_tree],url_for_version->[format,getcwd],patch->[set_executable,working_dir,filter,iglob,FileFilter],depends_on,version]] | Patch all the nagios - core packages with the new one. | Is there any reason to switch from iglob to glob? |
@@ -1442,7 +1442,10 @@ public class Queue extends ResourceController implements Saveable {
if (r != null) {
r.run();
} else {
- new BlockedItem(top).enter(this);
+ //this is to solve JENKINS-30084: the task ... | [Queue->[BuildableItem->[leave->[all],enter->[all,add],isStuck->[getEstimatedDuration,getAssignedLabel],getCauseOfBlockage->[isEmpty,getAssignedLabel,isBlockedByShutdown]],getApproximateItemsQuickly->[get],isBuildBlocked->[isBuildBlocked],getItems->[add],withLock->[call],isEmpty->[isEmpty],LockedJUCCallable->[call->[wi... | Maintains the queue. This method is called from the QueueSorter. DEFAULT_BLOCKED_ITEM_COMPARATOR JENKINS - 28926 check if there is a sequence of comments in a tabpanel. | I _think_ this is incorrect. The job could be blocked for reasons other than no nodes with the correct label are available. (concurrent builds is disabled for example - or many other reasons). |
@@ -153,7 +153,7 @@ func runWeb(ctx *cli.Context) error {
log.Fatal(4, "Failed to bind %s", listenAddr, err)
}
defer listener.Close()
- err = fcgi.Serve(listener, context2.ClearHandler(m))
+ fcgi.Serve(listener, context2.ClearHandler(m))
case setting.UnixSocket:
if err := os.Remove(listenAddr); err != ... | [IsFile,FileMode,SetValue,HandlerFunc,Close,Redirect,Info,IsSet,IsNotExist,Append,Empty,RegisterParsers,SaveTo,Errorf,ListenUnix,NewMacaron,Key,Section,Remove,ListenAndServe,ClearHandler,Serve,GlobalInit,TrimSuffix,Listen,Sprintf,Chmod,String,Fatal,Replace,RegisterRoutes] | StartServer starts the server if LFS is enabled. Get the from the server. | why remove `err` as all other switch cases have same pattern. |
@@ -489,7 +489,7 @@ public class DefaultHttp2OutboundFlowController implements Http2OutboundFlowCont
/**
* Returns the the head of the pending queue, or {@code null} if empty.
*/
- Frame peek() {
+ private Frame peek() {
return pendingWriteQueue.peek();
}... | [DefaultHttp2OutboundFlowController->[writePendingBytes->[flush],writeAllowedBytes->[state,connectionWindow,writeAllowedBytes],state->[state],connectionState->[state],OutboundFlowState->[writeBytes->[writableWindow,hasFrame,peek],Frame->[writeError->[size],write->[size,write,incrementStreamWindow,writeData],split->[siz... | peek - peek frame from pending write queue. | isn't the class already private? |
@@ -197,14 +197,13 @@ export class InaboxMessagingHost {
*
* @param {!Object} request
* @param {!Window} source
- * @param {string} origin
* @param {?JsonObject} data
*/
- sendPosition_(request, source, origin, data) {
+ sendPosition_(request, source, data) {
dev().fine(TAG, 'Sent position ... | [No CFG could be retrieved] | Provides a function to handle sending position data to the specified element. Cancels a full overlay if the user cancels the full overlay. | shall we still pass down `origin` and do `*` only when it is `null`? cc @molnarg to chime in from security's perspective |
@@ -379,7 +379,7 @@ class Epochs(object):
epochs._data = self._data[key]
return epochs
- def average(self, keep_only_data_channels=True):
+ def average(self, keep_only_data_channels=True, _do_stderr=False):
"""Compute average of epochs
Parameters
| [Epochs->[resample->[resample],_get_data_from_disk->[_get_epoch_from_disk],next->[next,_is_good_epoch,_get_epoch_from_disk],get_data->[_get_data_from_disk]]] | Return an Epochs object with a subset of epochs. Picks data channel types and evases it with a . | I would not expose here _do_stderr unless you want to return both the evoked mean and the standard error. I would refactor with `_reduction(self, keep_only_data_channels=True, mode='mean' | 'std'):` which is then called by epochs.average and epochs.std |
@@ -702,6 +702,14 @@ public abstract class AbstractProcessingStrategyTestCase extends AbstractMuleCon
}
}
+ protected void assertProcessingStrategyTracing() {
+ if (enableProfilingServiceProperty.getValue().equals("true")) {
+ Assert.assertThat(profilingService.getTracingService().getCurrentExecution... | [AbstractProcessingStrategyTestCase->[after->[setFeaturesState],asyncCpuLightConcurrent->[internalConcurrent],process->[process],RejectingScheduler->[submit->[submit]],AnnotatedAsyncProcessor->[getProcessingType->[getProcessingType],apply->[apply],process->[process]],WithInnerPublisherProcessor->[apply->[apply],process... | Assert that profiling is enabled for all events. | use Boolean constant for the string. |
@@ -253,6 +253,11 @@ public abstract class AbstractRayRuntime implements RayRuntime {
actorCreationId = returnIds[0];
}
+ UniqueId actorCreationDummyObjectId = actor.getCreationDummyObjectId();
+ if (isActorCreationTask) {
+ actorCreationDummyObjectId = actorCreationId;
+ }
+
Map<String... | [AbstractRayRuntime->[createTaskSpec->[put,genReturnIds],loop->[loop],wait->[wait],get->[put,get],put->[put]]] | create a task spec. | This is confusing, but I think for actor creation tasks, the creation dummy object is actually set to nil. |
@@ -19,10 +19,10 @@ namespace NServiceBus.AcceptanceTests.Core.Recoverability
{
await Scenario.Define<Context>(ctx => context = ctx)
.WithEndpoint<EndpointWithFailingHandler>(b => b
- .When((session, ctx) => session.SendLocal(new InitiatingMessag... | [When_configuring_unrecoverable_exception->[Should_move_to_error_queue_without_retries->[HandlerInvoked,Single,That,AreEqual,Assert,Is,Run,Exception],EndpointWithFailingHandler->[InitiatingHandler->[Task->[HandlerInvoked]],AddUnrecoverableException]]] | Tests if a message is in the error queue without retries. | formatting looks a bit off here? |
@@ -240,7 +240,6 @@ public class HttpServerConnectionTestCase extends AbstractMuleContextTestCase
HttpConnector httpConnector = new HttpConnector(muleContext);
httpConnector.setSendTcpNoDelay(SEND_TCP_NO_DELAY);
httpConnector.setKeepAlive(KEEP_ALIVE);
- httpConnector.setReceiveBufferSi... | [HttpServerConnectionTestCase->[resetClosesRequestBody->[configureValidRequestForSocketInputStream],testUrlWithoutParams->[getUrlWithoutRequestParams],createHttpServerConnectionForResponseTest->[configureValidRequestForSocketInputStream]]] | Create a server connection for the client and the http connector. | Is it possible to incorporate the scenario where the socket does not use the hint, rather than remove the assertion completely? |
@@ -11,7 +11,7 @@ require "git_source_patch"
require "functions"
-MIN_BUNDLER_VERSION = "2.0.0"
+MIN_BUNDLER_VERSION = "2.1.0"
def validate_bundler_version!
return true if correct_bundler_version?
| [output->[print,dump],correct_bundler_version?->[new],validate_bundler_version!->[raise,correct_bundler_version?],send,parse,output,unshift,message,transform_keys,class,backtrace,read,exit,validate_bundler_version!,require,expand_path] | Checks that the Bundler version is correct and raises an error if not. | We actually rely on the Bundler v2.1.0 API for Bundler::URI, which was private in 2.0.x |
@@ -13561,8 +13561,14 @@ void setup() {
pe_deactivate_magnet(1);
#endif
#endif
-}
-
+#if defined (MKS_12864OLED)
+ SET_OUTPUT(LCD_PINS_DC);
+ SET_OUTPUT(LCD_PINS_RST);
+ WRITE(LCD_PINS_RST, LOW);
+ delay(1000);
+ WRITE(LCD_PINS_RST, HIGH);
+#endif
+}
/**
* The main Marlin program loop
*
| [No CFG could be retrieved] | Initialize the color mixing to 100% color 1. This is the main loop of the Marlin program. It loops through the available commands. | Is this supposed to be a different pin from `LCD_PINS_RS`? Your PR is the only place this pin appears. |
@@ -303,7 +303,7 @@ static unsigned vlcs_video_format(void **p_data, char *chroma, unsigned *width,
new_format = convert_vlc_video_format(chroma, &new_range);
- libvlc_video_get_size_(c->media_player, 0, width, height);
+ //int res = libvlc_video_get_size_(c->media_player, 0, width, height);
/* don't allocate... | [bool->[dstr_free,dstr_cmp,dstr_copy,dstr_ncopy,strchr],obs_properties_t->[obs_properties_create,dstr_cat,dstr_resize,pthread_mutex_lock,obs_properties_add_list,dstr_free,dstr_replace,dstr_copy,obs_properties_add_bool,da_end,obs_properties_add_editable_list,strrchr,dstr_cat_dstr,obs_property_list_add_string,pthread_mut... | This function is called from the VLC API to convert a video into a format. | For streams this will not give the right frame size. The arguments are already set, why is this needed anyways? |
@@ -19,10 +19,10 @@ RSpec.describe Bufferizer, type: :labor do
end
it "sends to buffer sattelite twitter" do
- tweet = "test tweet #DEVCommunity"
+ tweet = "test tweet #{SiteConfig.twitter_hashtag}"
described_class.new("article", article, tweet).satellite_tweet!
expect(article.last_buffered.utc.... | [create,to,to_i,let,main_tweet!,be,describe,include,facebook_post!,first,satellite_tweet!,not_to,listings_tweet!,name,it,require,id] | description of Bufferizer test facebook post. | I suggest setting `SiteConfig.twitter_hashtag` explicitly in tests before performing checks that include it. It would be nice not to rely on the default value, especially regarding that we plan to remove the default values in the future, so may accidentally keep tests that check for empty strings then. |
@@ -47,7 +47,7 @@ const error = function(msg, trace) {
if (trace) {
console.log(trace);
}
- process.exit(1);
+ process.exitCode = 1;
};
const init = function(program) {
| [No CFG could be retrieved] | Displays a single . The toString function is used to convert an object into a string. | By removing process.exit at this point, jhipster will not exit on this.error anymore. We should find a cleaner way to exit the process. |
@@ -137,6 +137,10 @@ func (p *Plugin) processInstallParams() error {
return cli.NewExitError("--version must be specified", 1)
}
+ if strings.HasPrefix(strings.ToLower(p.URL), "https://") && p.ServerThumbprint == "" {
+ return cli.NewExitError("--server-thumbprint must be specified when using HTTPS plugin URL",... | [Install->[processInstallParams],Remove->[processRemoveParams]] | processInstallParams processes install and remove parameters. | URL.Scheme should be "https" in your case |
@@ -135,7 +135,10 @@ export function getIframe(
export function addDataAndJsonAttributes_(element, attributes) {
for (let i = 0; i < element.attributes.length; i++) {
const attr = element.attributes[i];
- if (attr.name.indexOf('data-') != 0) {
+ if (!startsWith(attr.name, 'data-')
+ // data-vars- is... | [No CFG could be retrieved] | Adds data - and - from the name and capitalizes after -. Load the meta tag in the bootstrap window. | Why aren't we iterating the dataset? We could get rid of `dashToCamelcase`, `#substr`, and a `startsWith`: ```js const set = element.dataset; for (const name in set) { if (!startsWith(name, 'vars')) { attributes[name] = set[name]; } } |
@@ -225,7 +225,7 @@ define([
billboard.setShow(true);
position = positionProperty.getValueCartesian(time, position);
- if (position !== 'undefined') {
+ if (typeof position !== 'undefined') {
billboard.setPosition(position);
}
| [No CFG could be retrieved] | This function returns the object that is the ethernet point of the object. This function is used to determine the outline width and the pixel size of the visualizer. | I did a grep and found a similar mistake in DynamicBillboardVisualizer. Want to fix that too? |
@@ -55,6 +55,16 @@ public class HdfsDataSegmentKiller implements DataSegmentKiller
}
}
+ private boolean safeNonRecursiveDelete(FileSystem fs, Path path)
+ {
+ try {
+ return fs.delete(path, false);
+ }
+ catch (Exception ex) {
+ return false;
+ }
+ }
+
private Path getPath(DataSeg... | [HdfsDataSegmentKiller->[checkPathAndGetFilesystem->[exists,getFileSystem,SegmentLoadingException],kill->[getParent,SegmentLoadingException,endsWith,checkPathAndGetFilesystem,getPath,delete],getPath->[get,Path,valueOf]]] | Kill a segment. | should we log something? |
@@ -130,6 +130,10 @@ module Engine
@active_step ||= @steps.find { |step| step.active? && step.blocking? }
end
+ def derived_actions
+ active_step(nil)&.derived_actions(current_entity)
+ end
+
def finished?
!active_step
end
| [Base->[can_act?->[current_entity],process_action->[description],description->[description],pass_description->[pass_description],active_entities->[active_entities]]] | Returns the active step or nil if there is no active step. | do we need derived actions? can't we just do @game.add_x_action(action) def add_x_action(action) raise if @loading |
@@ -488,6 +488,7 @@ export class Resource {
this.premeasuredRect_ = null;
} else {
this.computeMeasurements_();
+ this.premeasuredRect_ = null;
}
const newBox = this.layoutBox_;
| [No CFG could be retrieved] | Determines if the element is ready to be measured. Missing parameters for layout. | Let's move this down, so we can reduce the duplication in both branches? |
@@ -783,12 +783,12 @@ class RoIHeads(nn.Module):
mask_proposals.append(proposals[img_id][pos])
pos_matched_idxs.append(matched_idxs[img_id][pos])
else:
- pos_matched_idxs = None
+ pos_matched_idxs = None # type: ignore[assignment]
... | [paste_masks_in_image->[paste_mask_in_image,expand_boxes,_onnx_paste_masks_in_image_loop,expand_masks],heatmaps_to_keypoints->[_onnx_heatmaps_to_keypoints_loop],RoIHeads->[check_targets->[has_mask],select_training_samples->[check_targets,add_gt_proposals,assign_targets_to_proposals,subsample],forward->[fastrcnn_loss,ma... | Forward computation of the N - D CNN model on a list of features and proposals Computes the n - node state of the n - node. compile each branch and return the result and loss_keypoint. | `mask_head` and `mask_predictor` are `None` by Default. So there maybe a case when `None` flows down here. Hence mypy complains. |
@@ -16,7 +16,7 @@ module Api
title description main_image published_at crossposted_at social_image
cached_tag_list slug path canonical_url comments_count
public_reactions_count created_at edited_at last_comment_at published
- updated_at video_thumbnail_url
+ updated_at video_thu... | [ArticlesController->[create->[decorate,persisted?,render,url,errors_as_sentence],show->[record_key,decorate,set_surrogate_key_header],allowed_to_change_org_id?->[nil?,dig,exists?,user,any_admin?,org_admin?],article_params->[permit,dig,allowed_to_change_org_id?],update->[call,article,find,has_role?,render,errors_as_sen... | Controller for the Nova - Nova tag API This method is used to render the show page of the given object. | it might make me medium happy if this were alphabetized but I probably worry about that too much - suffice it to say I did wonder _where_ to add the new attribute to the list for more than a second. |
@@ -82,10 +82,10 @@ s.serve_forever()" """
def more_info(self): # pylint: disable=missing-docstring,no-self-use
return """\
This plugin requires user's manual intervention in setting up a HTTP
-server for solving SimpleHTTP challenges and thus does not need to be
-run as a privilidged process. Alternati... | [Authenticator->[_perform_single->[_test_mode_busy_wait]]] | A function to provide additional information about the server. | Since we are hiding this plugin from the UI, user's will likely never see this message, so it's probably better to move it to the docstring. Could we also add information that this plugin can be run on laptop, while the code is executed on a remote web server? |
@@ -496,11 +496,11 @@ int RAND_poll(void)
do
RAND_add(&hentry, hentry.dwSize, 5);
while (heap_next(&hentry)
+ && (!good || NOTTOOLONG(starttime))
&& --entrycnt... | [No CFG could be retrieved] | private helper methods - - - - - - - - - - - - - - - - - -. | Looks like this code needs more `)`. Maybe at other locations too. |
@@ -86,13 +86,16 @@ def AssembleTestSuites():
nightSuite.addTest(TPenaltyImpositionBeamCantileverStaticHyperelasticSelfWeightLoad2DQuadTest('test_execution'))
+ nightSuite.addTest(TBeamCantileverLinearStaticHyperelasticSelfWeightLoad2DQuadTest('test_execution'))
+
### Adding Validation Tests
## Fo... | [AssembleTestSuites->[addTest,TestLoader,TBeamCantileverStaticLinearElasticPointLoad2DTriTest,TCLLinearElastic3DQuadTest,TBeamCantileverStaticLinearElasticParticlePointLoad2DTriTest,TCooksMembraneUPCompressibleTest,TCooksMembraneCompressibleTest,TBeamCantileverStaticLinearElasticSurfaceLoad3DHexaTest,TCooksMembraneUPIn... | Assemble a test suites with the specified test cases. Adds tests to the test suite that contains all the tests in night. | Can you revert this? I think it's better to put the smallsuite in nightly too so that we can get noticed by the community if our unit tests are failing. The nightsuite will also include the smallsuite if you do that. |
@@ -96,7 +96,7 @@ func ValidateLDAPClientConfig(url, bindDN, bindPassword, CA string, insecure boo
func ValidateRFC2307Config(config *api.RFC2307Config) ValidationResults {
validationResults := ValidationResults{}
- validationResults.Append(ValidateLDAPQuery("allGroupsQuery", config.AllGroupsQuery))
+ validationRe... | [Error,DetermineDerefAliasesBehavior,Append,AddErrors,Sprintf,DetermineLDAPScope,CompileFilter,ParseURL,AddWarnings,NewFieldInvalid,ParseDN,NewFieldRequired] | ValidateRFC2307Config validates the RFC2307Config and ActiveDirectoryConfig objects. AllUsersQuery - Validates that all the user name attributes and group membership attributes are set. | validation fixes could be split off if @liggitt thinks this will take a while. |
@@ -1407,7 +1407,10 @@ def linspace(start, stop, num, dtype):
or a tensor of shape [1] with input data type float32, float64.
num(int|Variable): The input :attr:`num` is given num of the sequence. It is an int scalar, \
or a tensor of shape [1] with type int32.
- dtype(string):... | [create_parameter->[create_parameter],zeros->[fill_constant],concat->[concat],range->[cast,fill_constant],ones->[fill_constant],linspace->[fill_constant],diag->[assign],fill_constant->[fill_constant]] | This OP return fixed number of evenly spaced values within a given interval. Computes the next n - intervals in a sequence. | the data**t** type typo |
@@ -1994,12 +1994,16 @@ void WalletImpl::refreshThreadFunc()
void WalletImpl::doRefresh()
{
+ bool rescan = m_refreshShouldRescan.exchange(false);
// synchronizing async and sync refresh calls
boost::lock_guard<boost::mutex> guarg(m_refreshMutex2);
- try {
+ do try {
+ LOG_PRINT_L3(__FUNCT... | [No CFG could be retrieved] | This function is the main refresh thread which periodically refreshes the wallet. This is a private method that is called by the daemon to refresh the wallet. It is. | I doubt it works with light wallet. |
@@ -61,8 +61,8 @@ Rails.application.configure do
# enable Bullet in testing mode only if requested
config.after_initialize do
- Bullet.enable = ENV["BULLET"]
- Bullet.raise = ENV["BULLET"]
+ Bullet.enable = ApplicationConfig["BULLET"]
+ Bullet.raise = ApplicationConfig["BULLET"]
Bullet.add_whit... | [new,show_exceptions,after_initialize,queue_adapter,level,headers,test_order,consider_all_requests_local,cache_classes,deprecation,logger,enabled,to_i,delivery_method,eager_load,default_url_options,allow_forgery_protection,enable,cache_store,perform_caching,log_level,raise,configure,add_whitelist] | Initialize the object. | test related, no need to be changed. |
@@ -63,10 +63,14 @@ def main():
args = parser.parse_args()
- # Enforce --privkey is set along with --csr.
+ # Make sure each given file is readable.
+ for f in (args.privkey, args.csr):
+ if f and not os.access(f, os.R_OK):
+ parser.error("the file '{}' is not readable.".format(f))
+... | [view_checkpoints->[display_checkpoints],main->[,set_display,error,add_argument,rollback,authenticate,list_certs_keys,ArgumentParser,parse_args,Client,print_usage,view_checkpoints,format,FileDisplay,geteuid,NcursesDisplay,exit,ApacheConfigurator],rollback->[rollback_checkpoints,restart],main,FileLogger,setLogger,setLog... | Command line entry point for the letsencrypt script. Parse command line arguments and authenticate a single key. | `"{}"` is not Python 2.6 compat syntax |
@@ -506,8 +506,13 @@ public class ConfigurationSetup {
// Build the config
final ResultHandle config = carc.checkCast(carc.invokeVirtualMethod(SRCB_BUILD, builder), SmallRyeConfig.class);
- final ResultHandle providerResolver = carc.newInstance(SCPR_CONSTRUCT, config);... | [ConfigurationSetup->[generateParserBody->[generateParserBody]]] | Finalize the configuration loader. region ConfigBuilder Implementation create the configuration object and the root configuration region ConfigurationBuilder Implementation region > readInstance. | There doesn't seem to be a good reason to change this? |
@@ -13,8 +13,11 @@ class PySniffio(PythonPackage):
homepage = "https://github.com/python-trio/sniffio"
pypi = "sniffio/sniffio-1.1.0.tar.gz"
+ version('1.2.0', sha256='c4666eecec1d3f50960c6bdf61ab7bc350648da6c126e3cf6898d8cd4ddcd3de')
version('1.1.0', sha256='8e3810100f69fe0edd463d02ad407112542a11ff... | [PySniffio->[depends_on,version]] | This file contains the information for the version of the sniffio. | I don't actually see anywhere where wheel or certifi are used, I think these deps can be removed |
@@ -731,7 +731,11 @@ function videopress_get_attachment_url( $post_id ) {
return null;
}
} else {
- $return = $meta['videopress']['file_url_base']['https'] . $meta['videopress']['files']['hd']['mp4'];
+ $return = $meta['videopress']['file_url_base']['https'] . (
+ $meta['videopress']['files']['hd']['hls']
... | [videopress_get_attachment_id_by_url->[have_posts],videopress_get_post_id_by_guid->[have_posts,next_post],videopress_cleanup_media_library->[have_posts]] | Get the url of the video press attachment. | Could we have it pull the `hd_1080p` entry if it's available? I think maybe we discussed this on our call but can't remember what decision was made there |
@@ -3,9 +3,14 @@
# Licensed under the MIT License. See License.txt in the project root for license information.
# --------------------------------------------------------------------------------------------
+from typing import TYPE_CHECKING, Union, Any # pylint: disable=unused-import
from threading import Lock
f... | [get_connection_manager->[_SeparateConnectionManager,_SharedConnectionManager]] | Creates a connection object for the given object. Returns a connection object that can be used to access the network. | Make it a protocol as said earlier |
@@ -663,6 +663,9 @@ func convertContainerToContainerInfo(c *exec.Container) *models.ContainerInfo {
ep.Ports = append(ep.Ports, endpoint.Ports...)
}
+ macaddress, _ := container.GetContainerVM().GetMacAddressBasedSpecifiedNetworkName(context.Background(), endpoint.Assigned.IP.String())
+ ep.Macaddress = maca... | [CreateHandler->[GetBuild,Now,NewCreateOK,NewOperationFromID,Error,New,UTC,End,WithPayload,Errorf,MarshalPKCS1PrivateKey,EncodeToMemory,Create,UnixNano,GenerateKey,NewCreateNotFound,Begin,Background,String],GetContainerStatsHandler->[Begin,NewGetContainerStatsNotFound,Unsubscribe,NewEncoder,Background,End,NewOperation,... | Aliases - returns the list of aliases - nameservers - returns list of endpoints. | Use ep.Macaddress directly? |
@@ -2627,7 +2627,8 @@ public final class FilePath implements SerializableOnlyOverRemoting {
* Reads from a tar stream and stores obtained files to the base dir.
* Supports large files > 10 GB since 1.627 when this was migrated to use commons-compress.
*/
- private void readFromTar(String name, File... | [FilePath->[UntarFrom->[invoke->[extract]],unzip->[FilePath,unzip],AbstractInterceptorCallableWrapper->[call->[call],getClassLoader->[getClassLoader]],ValidateAntFileMask->[invoke->[equals],hasMatch->[isCaseSensitive->[isCaseSensitive,Cancel]]],UnzipLocal->[invoke->[getRemote,unzip]],copyTo->[copyTo,write,act],LastModi... | Reads a file from a tar archive. | why do't pass the consume in here directly - so that you can get progress as it happens as opposed to after the fact (which is unhelpfull in the case something goes wrong)? |
@@ -1683,11 +1683,11 @@ TEUCHOS_UNIT_TEST_TEMPLATE_4_DECL(Tpetra_MatMat, threaded_add_unsorted, SC, LO,
#define UNIT_TEST_GROUP_SC_LO_GO_NO( SC, LO, GO, NT ) \
- TEUCHOS_UNIT_TEST_TEMPLATE_4_INSTANT(Tpetra_MatMat, operations_test,SC, LO, GO, NT) \
- TEUCHOS_UNIT_TEST_TEMPLATE_4_INSTANT(Tpetra_M... | [No CFG could be retrieved] | \ brief Tests for the unit test. | Should all of these still be disabled? |
@@ -110,7 +110,10 @@ class Silo(AutotoolsPackage):
def force_autoreconf(self):
# Update autoconf's tests whether libtool supports shared libraries.
# (Otherwise, shared libraries are always disabled on Darwin.)
- return self.spec.satisfies('+shared')
+ if self.spec.satisfies('@4.11-... | [Silo->[libs->[find_libraries],clang_9_patch->[repl->[group],filter_file,satisfies],force_autoreconf->[satisfies],flag_handler->[append,spec],patch->[clang_9_patch],configure_args->[append,extend,is_system_path],depends_on,version,patch,when,variant]] | Force autoconf to use the specified . return config_args . | I wasn't aware of any issues with `bsd` variant and `autoreconf`. That said, I don't honestly know if Silo's AutoTools usage is such that it really supports `autoreconf`ing except from some limited versions of AutoTools available on LLNL systems. The `bsd` variant of the release removes a couple of builtin compression ... |
@@ -22,6 +22,9 @@ class Specfem3dGlobe(AutotoolsPackage, CudaPackage):
description="Build with OpenMP code generator")
variant('double-precision', default=False,
description="Treat REAL as double precision")
+ variant('par_file', values=str, default='original',
+ description... | [Specfem3dGlobe->[install->[install_tree],configure_args->[append,enable_or_disable,format,extend],variant,depends_on,version,patch]] | Creates a object from a GloBE - formatted object. Configures the command line options for the command. | Is this something fixed at compile time? I'm worried about having a parameter file as a variant (since it will change the hash of the installation), but on the other hand I don't know at all how specfem3d works. |
@@ -115,6 +115,16 @@ public final class Ray extends RayCall {
return runtime.createActor(actorClass);
}
+ /**
+ * Free a list of objects from Plasma Store.
+ *
+ * @param objectIds The object ids to free.
+ * @param localOnly Whether only free objects for local object or not.
+ */
+ public static ... | [Ray->[wait->[wait],shutdown->[shutdown],init->[init],createActor->[createActor],get->[get],put->[put]]] | create actor with given class. | I think we don't want to make `free` public for now. If so, don't add to `Ray.java`. Then people can call it by `Ray.internal().free()` (need to change the internal() method public). |
@@ -1286,9 +1286,9 @@ export class AmpStory extends AMP.BaseElement {
* @private
*/
unmute_() {
- this.mediaPool_.blessAll().then(() => {
- this.activePage_.unmuteAllMedia();
- });
+ this.mediaPool_.blessAll()
+ .then(() => this.activePage_.unmuteAllMedia(),
+ () => this.activ... | [AmpStory->[assertAmpStoryExperiment_->[user,toggleExperiment,removeElement,textContent,appendChild,classList,addEventListener],constructor->[once,timerFor],isSwipeLargeEnoughForHint_->[abs],next_->[dev,SHOW_BOOKEND,next,dispatch],getPageDistanceMapHelper_->[getAdjacentPageIds],initializeListeners_->[NEXT_PAGE,PREVIOUS... | Unmute all media in the page. | Nit: Hoist closure into a local var to reuse. |
@@ -483,9 +483,11 @@ static int sig_in(BIO *b)
void *md_data;
ctx = BIO_get_data(b);
- md = ctx->md;
+ if ((md = ctx->md) == NULL)
+ goto berr;
digest = EVP_MD_CTX_get0_md(md);
- md_size = EVP_MD_get_size(digest);
+ if ((md_size = EVP_MD_get_size(digest)) < 0)
+ goto berr;
... | [No CFG could be retrieved] | - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -. | not really necessary since both EVP_MD_CTX_get0_md() and EVP_MD_get_size() handle NULL |
@@ -55,6 +55,7 @@ public class Paragraph extends Job implements Serializable, Cloneable {
private transient Note note;
private transient AuthenticationInfo authenticationInfo;
+ String replGrouName;
String title;
String text;
String user;
| [Paragraph->[getRequiredReplName->[getRequiredReplName],completion->[getRepl,getRequiredReplName,completion,getScriptBody,getInterpreterCompletion],progress->[getRepl,getRequiredReplName],ParagraphRunner->[run->[run]],createOrGetApplicationState->[getApplicationId],jobAbort->[getRepl,getRequiredReplName],getCurrentRepl... | A paragraph is a representation of an execution unit. The Paragraph class. | @astroshim Seems like a typo :) |
@@ -14,6 +14,7 @@ class HashInfo:
value: Optional[str]
size: Optional[int] = field(default=None, compare=False)
nfiles: Optional[int] = field(default=None, compare=False)
+ obj_name: Optional[str] = field(default=None, compare=False)
def __bool__(self):
return bool(self.value)
| [HashInfo->[__hash__->[hash],isdir->[endswith],__bool__->[bool],from_dict->[copy,cls,pop,items],to_dict->[OrderedDict],field]] | A property to provide a readable string representation of the node. | Hm, looks like `obj` is leaking here. I see that you only use it for status (prev obj.name), maybe there is a nicer way to handle that without leaking obj things into HashInfo? |
@@ -61,7 +61,7 @@ $.extend(frappe.model, {
if(frappe.route_options && !doc.parent) {
$.each(frappe.route_options, function(fieldname, value) {
var df = frappe.meta.has_field(doctype, fieldname);
- if(df && in_list(['Link', 'Select'], df.fieldtype) && !df.no_copy) {
+ if(df && !df.no_copy) {
doc[... | [No CFG could be retrieved] | add doc to parent doc - - - - - - - - - - - - - - - - - -. | what is the use case for this? We had specifically set this so that other filters (percent complete) do not get set by this. |
@@ -21,7 +21,7 @@ const (
func (d *driverV2) master(env *serviceenv.ServiceEnv, objClient obj.Client, db *gorm.DB) {
ctx := context.Background()
masterLock := dlock.NewDLock(d.etcdClient, path.Join(d.prefix, masterLockPath))
- err := backoff.RetryNotify(func() error {
+ err := backoff.RetryUntilCancel(ctx, func() ... | [master->[Printf,Join,Unlock,NewDLock,Background,NewInfiniteBackOff,Lock,ServiceEnvToOptions,RetryNotify,Run]] | master runs the master process. | I don't think this is going to solve the problem. If the master context gets canceled, then the run function is going to return nil and we will exit the retry. We want the master goroutine to try and re-claim the master lock after it loses it. The retry until cancel should be in the polling function in the garbage coll... |
@@ -185,7 +185,13 @@ public class BndMavenPlugin extends AbstractMojo {
// Merge in current project properties
File baseDir = project.getBasedir();
- File bndFile = new File(baseDir, Project.BNDFILE);
+ File bndFile;
+ if(bndLocation != null) {
+ bndFile = new File(bndLocation);
+ } else {
+ bndFile = n... | [BndMavenPlugin->[BeanProperties->[getField->[getField]],loadProjectProperties->[loadProjectProperties]]] | Load project properties from the given Maven project. | This won't work. `loadProjectProperties` is recursively called to load the bnd file of the parent project. So the configuration of the location of the bnd file in _this_ project may have no relation to the location of the bnd file in all the parent projects. Note: It is also possible that a parent project may have a bn... |
@@ -221,13 +221,13 @@ agg_clear_extents(struct ec_agg_entry *entry)
}
if (extent->ae_orig_recx.rx_idx + extent->ae_orig_recx.rx_nr >
- next_stripe_st) {
+ next_stripe_st && !tail) {
entry->ae_cur_stripe.as_extent_cnt--;
d_list_del(&extent->ae_link);
d_list_add_tail(&extent->ae_link,
... | [No CFG could be retrieved] | This function is called by the object_stripe_as_stripe_extents_list Private functions for the nested iterator. | I don't quite understand the tail and holdover extent logic here. could you please explain why need to add "!tail" here? at above L248 ~ L255 you only init/set the extent when "if (tail)", why here (L259) add "!tail" then? and seems I completely did not understand why need to remove those holdover extents? thanks |
@@ -81,12 +81,6 @@ class WebDAVTree(BaseTree): # pylint:disable=abstract-method
if self.user is None and self.path_info.user is not None:
self.user = self.path_info.user
- # If username specified add to path_info
- if self.user is not None:
- self.pa... | [WebDAVTree->[move->[move],_upload->[makedirs],_client->[WebDAVConnectionError],walk_files->[exists],makedirs->[exists,makedirs]]] | Initialize a base - tree node object. Returns a client object that can be used to retrieve a single node from the WebDAV server. | It's not necessary to add user to the url, as we also provide the login config anyway to the webdav Client. |
@@ -934,7 +934,12 @@ abstract class AbstractHttp2StreamChannel extends DefaultAttributeMap implements
}
private void writeHttp2StreamFrame(Http2StreamFrame frame, final ChannelPromise promise) {
- if (!firstFrameWritten && !isStreamIdValid(stream().id()) && !(frame instanceof Http2Headers... | [AbstractHttp2StreamChannel->[isActive->[isOpen],connect->[connect],write->[write],hashCode->[hashCode],eventLoop->[eventLoop],Http2ChannelUnsafe->[writeComplete->[closeForcibly],disconnect->[close],notifyReadComplete->[closeForcibly,flush],beginRead->[isActive],recvBufAllocHandle->[config,newHandle],write->[toString,i... | Writes a single frame to the stream. | If the `write0` call gets bounced through the executor I think this can cause issues, so maybe this is a no-go. |
@@ -137,9 +137,9 @@ namespace System.Security.Principal
}
}
- public override bool Equals(object o)
+ public override bool Equals(object? o)
{
- return (this == o as NTAccount); // invokes operator==
+ return o is NTAccount acc && this == acc; // invo... | [NTAccount->[GetHashCode->[GetHashCode],IdentityReferenceCollection->[ToString],ToString,Equals]] | Translates this object to the given type. | Why is this change needed? |
@@ -803,9 +803,7 @@ export class AmpDatePicker extends AMP.BaseElement {
this.updateDateFieldFocus_(this.dateField_);
}
this.transitionTo_(DatePickerState.OVERLAY_OPEN_INPUT);
- } else if (this.element.contains(target)) {
- this.transitionTo_(DatePickerState.OVERLAY_OPEN_PICKER);
- } e... | [No CFG could be retrieved] | Handles focus events in the date picker. Handle keydown events on the date picker. | Is removing this `else if` block intentional? |
@@ -90,7 +90,15 @@ public class TokenProvider {
return true;
} catch (SignatureException e) {
log.info("Invalid JWT signature: " + e.getMessage());
- return false;
+ } catch (MalformedJwtException e) {
+ log.info("Invalid JWT token: " + e.getMessage());
+ ... | [,TokenProvider,parser,getMessage,init,validity,getAuthentication,getAuthorities,joining,builder,createToken,getSecurity] | Checks if the token is valid. | Why not logging full exception? log.info("Invalid JWT signature", e); |
@@ -99,8 +99,11 @@ public abstract class SketchAggregatorFactory extends AggregatorFactory
}
@Override
- public Object combine(Object lhs, Object rhs)
+ public Object combine(Object lhs, @Nullable Object rhs)
{
+ if (rhs == null) {
+ return lhs;
+ }
return SketchHolder.combine(lhs, rhs, siz... | [SketchAggregatorFactory->[equals->[equals],makeAggregateCombiner->[reset->[reset]],combine->[combine],hashCode->[hashCode],deserialize->[deserialize]]] | Combine two sketches. | would you add this `@Nullable` annotation on `AggregatorFactory.combine(lhs,rhs)` and may be update when it is gonna be null ? I see you added `@Nullable` to `Aggregator.get()` but not on `BufferAggregator.get()` which probably needs to have same. However did we already have `Aggregator.get()` impls returning nulls or ... |
@@ -74,6 +74,11 @@ public class DependencyContext {
return rep;
}
+ public void addCredential(String reponame, String user, String password) {
+ auths.put(reponame, new Authentication(user, password));
+ return;
+ }
+
public void reset() {
dependencies = new LinkedList<Dependency>();
repo... | [DependencyContext->[fetch->[isDist,File,getGroupArtifactVersion,fetchArtifactWithDep,isLocalFsArtifact,add,getFile],addRepo->[add,Repository],fetchArtifactWithDep->[inferScalaVersion,addRepository,setPolicy,isSnapshot,andFilter,classpathFilter,getExclusions,getName,RemoteRepository,DependencyRequest,Dependency,Default... | Adds a repository to the repository list. | nit: no need for the return, for consistency on coding style |
@@ -133,8 +133,7 @@ class SimpleCache {
* @return void
*/
function enable() {
- $this->datalist->set('simplecache_enabled', 1);
- $this->config->set('simplecache_enabled', 1);
+ $this->config->save('simplecache_enabled', 1);
$this->invalidate();
}
| [SimpleCache->[invalidate->[getPath],getUrl->[registerView]]] | Enable SimpleCache. | store as bool, this makes isEnabled() easier |
@@ -644,8 +644,8 @@ func (ur *UpResult) GetPermalink() (string, error) {
// GetPermalink returns the permalink URL in the Pulumi Console for the update
// or refresh operation. This will error for alternate, local backends.
func GetPermalink(stdout string) (string, error) {
- const permalinkSearchStr = "View Live: "... | [RefreshConfig->[Name,Workspace,RefreshConfig],Destroy->[Name,Workspace],Info->[Name,Workspace],Refresh->[Name,Workspace],SetConfig->[Name,Workspace,SetConfig],Cancel->[Name,Workspace],History->[Name,Workspace],Outputs->[Name,Workspace],Up->[Name,Workspace],RemoveConfig->[Name,Workspace,RemoveConfig],SetAllConfig->[Nam... | GetPermalink returns the permalink URL for the given expected state transition. Op is the kind of operation being performed. | `View Live:` is only relevant to app.pulumi.com backend. Other backends fail to get the permalink. |
@@ -885,8 +885,7 @@ void TrussElement3D2N::CalculateElasticStiffnessMatrix(
void TrussElement3D2N::FinalizeSolutionStep(const ProcessInfo& rCurrentProcessInfo)
{
KRATOS_TRY;
- ProcessInfo temp_process_information;
- ConstitutiveLaw::Parameters Values(GetGeometry(),GetProperties(),temp_process_information);... | [No CFG could be retrieved] | This function is called when the solution step is done. private static final int NUM_ABSOLUTE_VARIANCE = 0 ;. | does this work? I remember that we had to create a non-const ProcessInfo to pass |
@@ -48,6 +48,8 @@ public interface TemplateManager {
static final ConfigKey<Integer> TemplatePreloaderPoolSize = new ConfigKey<Integer>("Advanced", Integer.class, TemplatePreloaderPoolSizeCK, "8",
"Size of the TemplateManager threadpool", false, ConfigKey.Scope.Global);
+
+
static final String ... | [No CFG could be retrieved] | Implementation of the TemplateManager interface. This method is used to check if a system - managed node has a specific node ID. | white spaces, no relevant changes in this file. can remove all the changes in this file? |
@@ -52,10 +52,16 @@ namespace NServiceBus
{
var metadata = messageMetadataRegistry.GetMessageMetadata(messageType);
- var assemblyQualifiedNames = new HashSet<string>();
+ var assemblyQualifiedNames = new List<string>();
foreach (var type in metadata.MessageHie... | [SerializeMessageConnector->[Serialize->[Serialize]]] | SerializeEnclosedMessageTypes returns a string containing the message types that are enclosed by the given. | Since we're likely dealing with relatively low numbers of items in `metadata.MessageHierarchy`, I suppose adding an O(N) call here isn't too big of a deal. |
@@ -134,9 +134,15 @@ public class MonitoringService {
}
};
- private static Supplier<Boolean> tomcatJmxStatusSupplier = () ->
- StringUtils.isNotEmpty(System.getProperty("com.sun.management.jmxremote.port")) &&
- StringUtils.isNotEmpty(System.getProperty("java.rmi.server.hos... | [MonitoringService->[invokeMonitoringCtl->[getLocal],disableMonitoring->[MonitoringStatus],getStatus->[MonitoringStatus],enableMonitoring->[MonitoringStatus]]] | Creates a function that executes the MGR_MONITORING_CTL and returns the Sets the function that is called when the is detected. | Can references to this member be changed with `TaskoXmlRpcHandler::isJmxEnabled` (making it static if necessary)? |
@@ -38,14 +38,14 @@ const uint16_t PROGMEM keymaps[][MATRIX_ROWS][MATRIX_COLS] = {
* |----------------------------------------------------------------|
* | |<- |Dn | ->| | | | | | | | | |End |
* |----------------------------------------------------------------|
- * | | ... | [No CFG could be retrieved] | |----------------------------------------------------------------| List |. | Is there any reason for this? It looks like `KC_UP` may be misaligned now. This still has a backlight, right? |
@@ -650,6 +650,14 @@ func (e *Env) GetEmail() string {
)
}
+func (e *Env) GetEnableSharedDH() bool {
+ return e.GetBool(false,
+ func() (bool, bool) { return e.getEnvBool("KEYBASE_ENABLE_SHARED_DH") },
+ func() (bool, bool) { return e.config.GetEnableSharedDH() },
+ func() (bool, bool) { return e.cmd.GetEnableS... | [GetGpgHome->[GetGpgHome,GetString,GetHome],GetPvlKitFilename->[GetString,GetPvlKitFilename],GetGpg->[GetString,GetGpg],GetUpdatePreferenceSkip->[GetUpdatePreferenceSkip],GetLogFormat->[GetString,GetLogFormat],getHomeFromCmdOrConfig->[GetString,GetHome],GetGregorDisabled->[GetGregorDisabled,GetBool],GetStoredSecretServ... | GetEmail returns the email address to use for the user. | you'll also want to check `TestParameters` for testing. |
@@ -61,6 +61,7 @@ public class CachingSessionFactoryTests {
assertTrue(sess1.isOpen());
sess1 = cache.getSession();
assertEquals("session:1", TestUtils.getPropertyValue(sess1, "targetSession.id"));
+ assertTrue((TestUtils.getPropertyValue(sess1, "targetSession.testCalled", Boolean.class)));
sess1.close();
... | [CachingSessionFactoryTests->[TestSessionFactory->[getSession->[TestSession]],testCacheAndReset->[assertTrue,getPropertyValue,isOpen,assertFalse,close,resetCache,assertEquals,TestSessionFactory,getSession],testDirtySession->[RuntimeException,getMessage,assertThat,thenReturn,LiteralExpression,mock,afterPropertiesSet,get... | test cache and reset. | The `TestSession` is a part of this class, so its `private` properties are visible. And afterwards we don't need that `@SuppressWarnings("unused")` as well. |
@@ -32,7 +32,7 @@ function toString(value) {
* @return {boolean}
*/
export function isArray(value) {
- return toString(value) === '[object Array]';
+ return Array.isArray(value);
}
/**
| [No CFG could be retrieved] | Determines if value is actually an array or object. | @erwinmombay Why did we remove `Array.isArray` uses before? |
@@ -278,6 +278,7 @@ KRATOS_CREATE_3D_VARIABLE_WITH_COMPONENTS(LOCAL_AUX_ANGULAR_VELOCITY)
// ******************* Quaternion Integration END *******************
// FORCE AND MOMENTUM
+KRATOS_CREATE_3D_VARIABLE_WITH_COMPONENTS(CONTACT_IMPULSE)
KRATOS_CREATE_3D_VARIABLE_WITH_COMPONENTS(PARTICLE_MOMENT)
KRATOS_CREATE... | [No CFG could be retrieved] | Creates a new 3D variable with the given components. - - - - - - - - - - - - - - - - - -. | why are you adding this in DEM? |
@@ -300,6 +300,7 @@ def concat(input, axis=0, name=None):
x1 = fluid.dygraph.to_variable(in1)
x2 = fluid.dygraph.to_variable(in2)
x3 = fluid.dygraph.to_variable(in3)
+ #when the axis is negative, the real axis is (axis + Rank(x))
out1 = ... | [create_parameter->[create_parameter],zeros->[fill_constant],concat->[concat],range->[range,cast,fill_constant],eye->[eye],ones->[fill_constant],linspace->[linspace,fill_constant],diag->[assign],fill_constant->[fill_constant]] | This OP concatenates the input along the specified axis. Adds a single - dimensional array to the network. | > the real axis is (axis + Rank(x)) |
@@ -55,6 +55,12 @@ func NewMissingError(info workspace.PluginInfo) error {
}
func (err *MissingError) Error() string {
+ if err.Info.Version != nil {
+ return fmt.Sprintf("no %[1]s plugin '%[2]s-v%[3]s' found in the workspace or on your $PATH, "+
+ "install the plugin using `pulumi plugin install %[1]s %[2]s v%[... | [Close->[Append,IgnoreError,Kill,Close,KillChildren],Error->[Sprintf,String],Close,WithInsecure,RegisterProcessGroup,StdinPipe,StderrPipe,Code,Atoi,Itoa,Dial,IgnoreError,Start,WaitForStateChange,Errorf,Assert,AddInt32,TrimSpace,Wrapf,Invoke,Infof,ReadString,Kill,V,StdoutPipe,Read,GetState,Command,WithUnaryInterceptor,N... | Error returns the error message for missing plugin. | NIT: Do we use this syntax elsewhere vs just `%s`? |
@@ -90,6 +90,7 @@ namespace System.Net.Test.Common
// Read until the buffer is full
// Return false on EOF, throw on partial read
+#if !NETFRAMEWORK
private async Task<bool> FillBufferAsync(Memory<byte> buffer, CancellationToken cancellationToken = default(CancellationToken))
{
... | [Http2LoopbackConnection->[DecodeInteger->[DecodeInteger],DecodeHeader->[DecodeInteger,DecodeLiteralHeader],ReadAndParseRequestHeaderAsync->[DecodeHeader],DecodeLiteralHeader->[DecodeString,DecodeInteger],DecodeString->[DecodeInteger],ReadRequestBodyAsync->[ReadBodyAsync],Task->[ReadFrameAsync,IgnoreWindowUpdates,Shutd... | FillBufferAsync - Reads data from the connection stream into the given buffer. | Can we give `Stream.ReadAsync` the same extension method treatment as `WriteAsync` to collapse this `#if`? |
@@ -445,6 +445,12 @@ public abstract class AbstractConfig implements Serializable {
}
}
}
+ boolean isAnnotationArray(Class target){
+ if(target.isArray() && target.getComponentType().isAnnotation()){
+ return true;
+ }
+ return false;
+ }
@Overrid... | [AbstractConfig->[appendAttributes->[appendAttributes],checkParameterName->[checkNameHasSymbol],isPrimitive->[isPrimitive],appendProperties->[convertLegacyValue],toString->[getTagName,toString,isPrimitive],appendParameters->[appendParameters]]] | Append an annotation to this object. Returns a string with the field name and value if the field is public and the method is. | May need a space between `)` and `{`. |
@@ -31,11 +31,17 @@ class HhvmDetector
$this->processExecutor = $processExecutor;
}
+ /**
+ * @return void
+ */
public function reset()
{
self::$hhvmVersion = null;
}
+ /**
+ * @return string|false|null
+ */
public function getVersion()
{
... | [HhvmDetector->[getVersion->[find,execute]]] | Initializes the object. | Interesting, that's a bug IMO. Looking at the first return I think the intent was to return a `?string`, so once it has been evaluated, if it resolved to false it just means it could not be detected, and it should return null. Which happens on second call but on first call not as the `?: null` is missing from the last ... |
@@ -58,7 +58,7 @@ public final class MockDelegateBridge {
public static Answer<int[]> withValues(final int... values) {
return invocation -> {
final int count = invocation.getArgument(1);
- assertEquals(values.length, count, "count of requested random values does not match");
+ assertThat("coun... | [MockDelegateBridge->[newDelegateBridge->[addChange,any,thenReturn,mock,getData],whenGetRandom->[any,anyInt,anyString,when,getRandom],advanceToStep->[acquireWriteLock,IllegalArgumentException,size,getData,contains,next,releaseWriteLock],withValues->[getArgument,assertEquals],thenGetRandomShouldHaveBeenCalled->[any,anyI... | Get random values answer. | I modified this because the order of elements was wrong. It is `(expected, actual, description)` and it is being used as `(actual, expected, description)`. I switched to assertThat while modifying this. |
@@ -1379,6 +1379,11 @@ func GeneratePackage(tool string, pkg *schema.Package) (map[string][]byte, error
return files, nil
}
+// goPackage returns the suggested package name for the given string.
+func goPackage(name string) string {
+ return strings.Split(name, "-")[0]
+}
+
const utilitiesFile = `
type envParser... | [genResource->[getConstValue,plainType,outputType,getDefaultValue,inputType],genType->[genInputTypes,genOutputTypes,details,genPlainType,tokenToType],plainType->[tokenToType,plainType],genFunction->[genPlainType],outputType->[tokenToType,outputType],getTypeImports->[tokenToPackage,getTypeImports,add],genConfig->[genHea... | genFunction generates code for a function XML Element that represents a sequence number. | should we be defensive here and check to see if there are any items after the split? |
@@ -54,7 +54,8 @@ const commands = {
toggleFilmStrip: 'toggle-film-strip',
toggleShareScreen: 'toggle-share-screen',
toggleTileView: 'toggle-tile-view',
- toggleVideo: 'toggle-video'
+ toggleVideo: 'toggle-video',
+ toggleRaiseHand: 'toggle-raise-hand'
};
/**
| [No CFG could be retrieved] | The events map from the name of the events to the events that are expected by the API This function returns a dictionary of all the possible events that are registered with the network. | Please sort it alphabetically. |
@@ -59,10 +59,6 @@ func main() {
flag.CommandLine.ParseErrorsWhitelist.UnknownFlags = true
flag.Parse()
- if help {
- flag.Usage()
- os.Exit(0)
- }
if version {
server.PrintPDInfo()
os.Exit(0)
| [StringVar,Close,Exit,Mode,NewEx,Stat,Usage,Notify,StringVarP,Start,PrintPDInfo,TrimSpace,Readline,Split,Printf,Println,Parse,ReadAll,Getenv,BoolVarP] | Private functions - related to the pdctl and pdctl. Check if the user has passed a magic number and if so exit. | Is it appropriate to output subcommands option in help ? |
@@ -326,18 +326,6 @@ def retry_on_error(func: Callable[[], Any], max_wait: float = 1.0) -> None:
raise
time.sleep(wait_time)
-# TODO: assert_true and assert_false are redundant - use plain assert
-
-
-def assert_true(b: bool, msg: Optional[str] = None) -> None:
- if not b:
- ra... | [assert_equal->[good_repr],assert_target_equivalence->[assert_string_arrays_equal],copy_and_fudge_mtime->[retry_on_error],assert_type->[typename],testcase_pyversion->[testfile_pyversion],parse_options->[testcase_pyversion],check_test_output_files->[normalize_error_messages,assert_string_arrays_equal],assert_module_equi... | Retry callback with exponential backoff when it raises OSError. | Follow up for PR #4369 |
@@ -58,9 +58,9 @@ type telemetryIngressClient struct {
}
type TelemPayload struct {
- Ctx context.Context
- Telemetry []byte
- ContractAddress common.Address
+ Ctx context.Context
+ Telemetry []byte
+ ContractID string
}
// NewTelemetryIngressClient returns a client backed by wsrpc tha... | [Send->[logBufferFullWithExpBackoff],connect->[Close]] | TelemetryIngressClient encapsulates all the functionality needed to send telemetry to the ingress server Close disconnects the wsrpc client from the ingress server and disconnects the wsrpc client. | I wonder if it would be possible to put this in the relay config instead... but then you'd lose the unique guarantee at DB level, right? |
@@ -1280,7 +1280,15 @@ func Issues(opts *IssuesOptions) ([]*Issue, error) {
if err := IssueList(issues).LoadAttributes(); err != nil {
return nil, fmt.Errorf("LoadAttributes: %v", err)
}
-
+ if opts.RenderEmojiTitle == util.OptionalBoolTrue {
+ var issuesWithEmojis []*Issue
+ for _, issue := range issues {
+ ... | [DiffURL->[HTMLURL],ChangeStatus->[changeStatus,loadRepo,loadPoster],loadAttributes->[loadPullRequest,loadTotalTimes,loadRepo,loadLabels,loadAttributes,isTimetrackerEnabled,loadPoster,loadComments,loadReactions,loadMilestone],LoadMilestone->[loadMilestone],doChangeStatus->[getLabels],ClearLabels->[loadPullRequest,loadR... | Issues returns a list of issues by given conditions. GetParticipantsIDsByIssueID returns all user IDs of all comments who participated in. | Rendering of the emoji should be done elsewhere. |
@@ -118,6 +118,8 @@ class Jetpack_Simple_Payments {
return $this->output_shortcode( $data );
}
+ function ignore_shortcode() { return; }
+
function output_shortcode( $data ) {
$items = '';
$css_prefix = self::$css_classname_prefix;
| [Jetpack_Simple_Payments->[parse_shortcode->[get_blog_id],init_hook_action->[register_shortcode,register_scripts]]] | Parses a shortcode Output a single confirmation shortcode This is a UI element that can be used to show a network error. | If it's the blog owner (maybe just any admin?) viewing the page, it'd be nice if this could output something like "Simple Payments is not supported by your Jetpack Plan. To learn more, and to upgrade to a supported plan, visit _these resources_. (This message is only shown to site administrators.)" |
@@ -21,7 +21,7 @@
import contextlib
import collections
import json
-import os
+import os,sys
import subprocess
import requests
import yaml
| [parse_max_duration_time->[int],get_experiment_status->[get],dump_yml_content->[open,dump,write],get_yml_content->[open,load],deep_update->[get,isinstance,items,deep_update],setup_experiment->[abspath,get,join],remove_files->[remove,suppress],read_last_line->[open,strip],print_stderr->[trial_job,get,run],get_succeeded_... | This function returns the ID of the given object. read last line of a file and return None if file not found. | `import sys` the next line |
@@ -2032,8 +2032,8 @@ vos_update_begin(daos_handle_t coh, daos_unit_oid_t oid, daos_epoch_t epoch,
"\n", DP_UOID(oid), iod_nr,
dtx_is_valid_handle(dth) ? dth->dth_epoch : epoch);
- rc = vos_ioc_create(coh, oid, false, epoch, flags, iod_nr, iods,
- iods_csums, 0, NULL, dedup, dedup_th, dth, &ioc);
+ rc = ... | [No CFG could be retrieved] | region Private functions vos_csum_init vos_csum_init vos_c. | (style) line over 80 characters |
@@ -59,7 +59,7 @@ module Opus::Types::Test
describe 'sig_builder_error_handler' do
describe 'when in default state' do
it 'raises an error' do
- @mod.sig {returns(Symbol).void}
+ @mod.sig {generated.returns(Symbol).checked(:always)}
def @mod.foo
:bar
... | [ConfigurationTest->[new,let,describe,assert_raises,assert_includes,must,lambda,it,name,inline_type_error_handler,is_a?,assert_equal,before,extend,sig,foo,message,returns,sig_validation_error_handler,with,assert_nil,include?,receive,scalar_types,sig_builder_error_handler,after,call_validation_error_handler,void],requir... | returns an object that represents the next failure in the sequence. | @ptarjan every change in this file is a revert of the change to disable generated / checked for open source. |
@@ -552,4 +552,9 @@ AVAILABLE_CLI_OPTIONS = {
help='Do not print epoch details header.',
action='store_true',
),
+ "hyperopt_ignore_unparam_space": Arg(
+ "-u", "--ignore-unparameterized-spaces",
+ help="Suppress errors for any requested Hyperopt spaces that do not contain any pa... | [check_int_nonzero->[ArgumentTypeError,int],check_int_positive->[ArgumentTypeError,int],Arg,join] | Print epoch details header. | To be honest, i'd use shorthand commands sparingly (only for important options that are needed often, like `--config` or `--strategy`). For the moment, i consider this as a edge-case option - which i'd not like to "waste" a single letter shortcut for (not many people will probably use this (and your usecase is in a scr... |
@@ -163,8 +163,7 @@ public final class TestRun
// "-agentlib:jdwp=transport=dt_socket,server=y,suspend=n,address=5007", // TODO implement sth like --debug switch
"-Djava.util.logging.config.file=/docker/presto-product-tests/conf/tempto/lo... | [TestRun->[TestRunOptions->[toModule->[toInstance],File],run->[build,runCommand],Execution->[cleanUp->[info,pruneEnvironment],getEnvironment->[configureContainer,toArray,build,get,withCommand,addExposedPort],runTests->[UncheckedIOException,checkState,getCurrentContainerInfo,getState,RuntimeException,sleep,getStatus,isR... | Creates an environment that can be used to run the tempto - product - test suite. This method is called by the test suite to add the test arguments to the environment. | why is this obsolete? do we collect reports in a way that are accessible outside of docker container? |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.