patch stringlengths 18 160k | callgraph stringlengths 4 179k | summary stringlengths 4 947 | msg stringlengths 6 3.42k |
|---|---|---|---|
@@ -568,7 +568,13 @@ function runTests() {
cyan('https://codecov.io/gh/ampproject/amphtml') + '...');
const codecovCmd =
'./node_modules/.bin/codecov --file=test/coverage/lcov.info';
- const output = getStdout(codecovCmd);
+ let flags = ' --flags=';
+ if (argv.uni... | [No CFG could be retrieved] | Creates a new and starts it if necessary. Entry point for the coverage report. | couldnt you end up with `--flags=` with empty value if unit or integration wasnt passed in? |
@@ -19,7 +19,7 @@ func (c APIClient) Dump(w io.Writer) error {
}
// Profile writes a pprof profile for pachd to w.
-func (c APIClient) Profile(profile string, duration time.Duration, w io.Writer) error {
+func (c APIClient) Profile(profile string, duration time.Duration, workerIP string, sidecar bool, w io.Writer) ... | [Profile->[Profile],Binary->[Binary],Dump->[Dump]] | Profile sends a profile to the debug service. | I think we should expose this as a pod / container name rather than an ip and bool. It's a little more friendly that way. The container name can default to `user` so you don't need to type anything in the more common case. |
@@ -82,6 +82,11 @@ class Transform(dict):
trans : array-like, shape (4, 4) | None
The transformation matrix. If None, an identity matrix will be
used.
+ Notes
+ ------
+ Valid coordinate systems are 'meg','mri','mri_voxel','head','mri_tal','ras'
+ 'fs_tal','ctf_head','ctf_meg','unknow... | [_print_coord_trans->[_coord_frame_name],combine_transforms->[_to_const,_coord_frame_name,Transform],Transform->[__init__->[_to_const]],_compute_sph_harm->[_sh_negate,_deg_ord_idx,_get_n_moments,_sh_complex_to_real],_find_vector_rotation->[_skew_symmetric_cross],transform_surface_to->[_ensure_trans,apply_trans],_get_tr... | Initialize a transform object with a sequence of sequence numbers. | Need a newline before this to render properly |
@@ -286,10 +286,7 @@ class ConditionalRandomField(torch.nn.Module):
# Transition from last state to "stop" state. To start with, we need to find the last tag
# for each instance.
last_tag_index = mask.sum(0).long() - 1
- last_tags = tags.gather(0, last_tag_index.view(1, batch_size).exp... | [ConditionalRandomField->[forward->[_input_likelihood,_joint_likelihood]]] | Computes the numerator term for the log - likelihood which is just the log - likelihood of the Compute the score of the last tag in the sequence. | Can't you just switch the `.expand()` here to a `.squeeze(0)`, and still remove the three lines below? `.squeeze()` is generally preferable to `.view(-1)`, as it's easier to reason about (unless there's some efficiency reason to prefer `.view(-1)` that I don't know about...?). |
@@ -67,7 +67,7 @@ final class EntrypointAction
$executionResult = new ExecutionResult(null, [$e]);
}
- return new JsonResponse($executionResult->toArray($this->debug), $executionResult->errors ? Response::HTTP_BAD_REQUEST : Response::HTTP_OK);
+ return new JsonResponse($executionRe... | [EntrypointAction->[__invoke->[render,toArray,getSchema,parseRequest,executeQuery,getRequestFormat,isMethod],parseRequest->[isMethod,getContentType,get,getContent]]] | This method is invoked by the client when a user is redirected to the index page. Get the array of conditions that can be found in the query. | I would just keep this change. (It looks like Apollo behave in a similar way). |
@@ -67,6 +67,9 @@ const visibilityStateCodes = {
/** @const {string} */
export const QQID_HEADER = 'X-QQID';
+/** @type {string} */
+export const SANDBOX_HEADER = 'amp-ff-sandbox';
+
/**
* Element attribute that stores experiment IDs.
*
| [No CFG could be retrieved] | Provides a function to export a single AMP - tagged element with a specific ID. Get the navigation start value using the performance API. | Nit: Use `const` instead of `type`? |
@@ -228,7 +228,7 @@ func TestRecreate_deploymentPreHookFail(t *testing.T) {
func TestRecreate_deploymentMidHookSuccess(t *testing.T) {
config := appstest.OkDeploymentConfig(1)
config.Spec.Strategy = recreateParams(30, "", appsapi.LifecycleHookFailurePolicyAbort, "")
- deployment, _ := appsutil.MakeDeployment(confi... | [Pods->[Pods],ReplicationControllers->[ReplicationControllers],fakeScaleClient,scaledOnce] | TestRecreate_deployment_midHookSuccess tests a deployment mid - hook success. TestRecreate_deploymentPo creates a fake pod client that can be used to recreate. | check the error |
@@ -99,9 +99,11 @@ public abstract class ObjectStore {
object = ObjectSerializer
.deserialize(dataAndMeta, ids.get(i), elementType);
}
- if (object instanceof RayException) {
+ if (object instanceof io.ray.api.exception.RayException) {
// If the object is a `RayException`... | [ObjectStore->[put->[putRaw],get->[get,getRaw],wait->[wait,get]]] | Get the list of objects with the specified ids. | Why do we have both `io.ray.api.exception.RayException` and `io.ray.runtime.exception.RayException`? |
@@ -10,6 +10,9 @@ class PyDiskcache(PythonPackage):
homepage = "http://www.grantjenks.com/docs/diskcache/"
pypi = "diskcache/diskcache-4.1.0.tar.gz"
+ version('5.2.1', sha256='1805acd5868ac10ad547208951a1190a0ab7bbff4e70f9a07cde4dbdfaa69f64')
version('4.1.0', sha256='bcee5a59f9c264e2809e58d01be6569a... | [PyDiskcache->[depends_on,version]] | https://github. com/grantjenks/docs - diskcache - 4. | The latest release still seems to support Python 2. Can you remove these lines? |
@@ -149,8 +149,8 @@ class KerasActivationsTest(test.TestCase):
x = keras.backend.placeholder(ndim=2)
f = keras.backend.function([x], [keras.activations.hard_sigmoid(x)])
test_values = np.random.random((2, 5))
- result = f([test_values])[0]
expected = hard_sigmoid(test_values)
+ result = f([tes... | [KerasActivationsTest->[test_softmax->[_ref_softmax],test_temporal_softmax->[_ref_softmax],test_softsign->[softsign],test_softplus->[softplus]]] | Test hard - sigmoid and relu. | Can you provide the rationale for this change? |
@@ -593,7 +593,7 @@ describe SamlIdpController do
expect(subject).to_not be_nil
end
- it 'has contents set to the loa of the ial?' do
+ it 'has contents set to the loa of the ial' do
expect(subject.content).to eq Saml::Idp::Constants::LOA1_AUTHNCONTEXT_CLASSREF
... | [create,new,let,be,to_not,describe,original_url,current,at,instance_double,it,identities,domain_name,map,session,to,generate_saml_response,root,before,post,require,include,have_actions,receive,read,match,session_uuid,delete,redirect_to,context,saml_get_auth,uuid,get,eq,sign_in,head,and_return] | Checks that the response contains all required elements includes the uuid Attribute element. | What does "loa of the ial" mean here? Why not just "has content set to LOA1"? |
@@ -249,6 +249,8 @@ class ASTConverter:
is_stub: bool,
errors: Errors) -> None:
self.class_nesting = 0
+ # 'C' for class, 'F' for function
+ self.class_and_function_stack = [] # type: List[Literal['C', 'F']]
self.imports = [] # type: List[ImportBase]... | [parse_type_string->[parse_type_comment],parse_type_comment->[ast3_parse],stringify_name->[stringify_name],TypeConverter->[visit_UnaryOp->[invalid_type,visit],visit_Num->[numeric_type],visit_Str->[parse_type_string],visit_Attribute->[invalid_type,visit],_extract_argument_name->[fail],visit_Subscript->[invalid_type,visi... | Initialize a object. | Shouldn't you delete this variable? It's no longer updated. |
@@ -2644,6 +2644,13 @@ namespace System.Diagnostics.Tracing
else if (m_matchAnyKeyword != 0)
m_matchAnyKeyword = unchecked(m_matchAnyKeyword | commandArgs.matchAnyKeyword);
}
+
+ if (commandArgs.dispatcher != n... | [No CFG could be retrieved] | Get the opcode of the exception that occurred while processing the event. returns EventOpcode. Start or EventOpcode. Stop if name ends with ActivityStartSuffix. | This condition includes dispatchers that correspond to ETW and EventPipe. For computing m_EventListenerMaxLevel and m_EventListenersKeywords you would only want dispatchers with EventListeners (dispatcher.listener != null). |
@@ -34,6 +34,10 @@ public class DefaultTlsContextFactoryTestCase extends AbstractMuleTestCase {
@BeforeClass
public static void createTlsPropertiesFile() throws Exception {
+
+ // This test will be ignored when the Allure framework is used because of this issue MULE-10805
+ assumeThat(System.getProperty("... | [DefaultTlsContextFactoryTestCase->[useConfigFileIfDefaultProtocolsAndCipherSuites->[getFileEnabledCipherSuites,getFileEnabledProtocols]]] | create the TLS properties file. | If you use an assumption you will never be aware that this test is not running. The test will show as Passed while it didn't actually run. We should use an @ Ignore and place a TODO tag. |
@@ -2767,7 +2767,7 @@ void MarlinSettings::reset() {
, " X", LINEAR_UNIT(planner.max_jerk.x)
, " Y", LINEAR_UNIT(planner.max_jerk.y)
, " Z", LINEAR_UNIT(planner.max_jerk.z)
- #if !BOTH(JUNCTION_DEVIATION, LIN_ADVANCE)
+ #if HAS_CLASSIC_E_JERK
, " E", LINEAR_UNIT(plann... | [No CFG could be retrieved] | Section 9. 2. 4. 4. Cycles through the list of objects in the Planner system and prints the max_j. | Mistake here. Need to replace !HAS_LINEAR_E_JERK. See PR #15968 |
@@ -207,11 +207,6 @@ namespace ILCompiler.Reflection.ReadyToRun
/// </summary>
public MetadataReader MetadataReader { get; private set; }
- /// <summary>
- /// An unique index for the method
- /// </summary>
- public int Index { get; set; }
-
/// <summary>
... | [ReadyToRunMethod->[ParseRuntimeFunctions->[Image,Size,Amd64,I386,ArmThumb2,ReadInt32,GetOffset,CalculateRuntimeFunctionSize,Machine,Arm64,MajorVersion,Add,RelativeVirtualAddress],EnsureFixupCells->[Value,Image,ImportSections,Signature,Count,HasValue,Entries,ReadUInt,Add],EnsureRuntimeFunctions->[ParseRuntimeFunctions,... | The base UnwindInfo for the method. - A unique identifier for the entity that is referenced by the given method. | This property is not assigned correctly and never used, so I removed it. |
@@ -99,6 +99,11 @@ public class OMKeyCreateResponse extends OMClientResponse {
omMetadataManager.getVolumeTable().putWithBatch(batchOperation,
omMetadataManager.getVolumeKey(omVolumeArgs.getVolume()),
omVolumeArgs);
+ // update bucket usedBytes.
+ omMetadataManager.getBucketTable().putWithB... | [OMKeyCreateResponse->[addToDBBatch->[getOzoneDirKey,getKeyName,debug,getOpenKey,getBucketName,getVolumeKey,getVolume,putWithBatch,isDebugEnabled,getVolumeName],getLogger,checkStatusNotOK]] | Add to DB batch. | the same. please double check the rest files. |
@@ -16,6 +16,13 @@ namespace Content.Server.Voting.Managers
{
public sealed partial class VoteManager
{
+ public void SetupStandardVoteTypeEnableCVars()
+ {
+ _voteTypesToEnableCVars[StandardVoteType.Restart] = CCVars.VoteRestartEnabled;
+ _voteTypesToEnableCVars[StandardV... | [VoteManager->[TimeoutStandardVote->[DirtyCanCallVoteAll,RealTime,GetCVar,FromSeconds,VoteSameTypeTimeout],CreateMapVote->[ToDictionary,Winner,ID,TrySelectMap,CreateVote,InitiatorTimeout,PlayerCount,FromSeconds,GetString,Pick,MapName,WirePresetVoteInitiator,OnFinished,Winners,DispatchServerAnnouncement],CreateRestartVo... | Create a standard vote. | This seems like something that could probably just be set in the field initializer instead. Hell, you could even make it static. |
@@ -4649,7 +4649,9 @@ static int test_key_exchange(int idx)
return testresult;
}
-# if !defined(OPENSSL_NO_EC) && !defined(OPENSSL_NO_DH)
+# if !defined(OPENSSL_NO_TLS1_2) \
+ && !defined(OPENSSL_NO_EC) \
+ && !defined(OPENSSL_NO_DH)
static int set_ssl_groups(SSL *serverssl, SSL *clientssl, int client... | [No CFG could be retrieved] | Reads the specified kexch group from the server and client ssl objects and checks if the && nec_kexch_alg ;. | NIT: Update the matching #endif /* */ |
@@ -507,7 +507,6 @@ class SDFProcessElementInvoker(object):
if self._max_num_outputs and output_count >= self._max_num_outputs:
initiate_checkpoint()
- tracker.check_done()
result = (
SDFProcessElementInvoker.Result(
residual_restriction=checkpoint_state.residual_restrict... | [PairWithRestrictionFn->[process->[ElementAndRestriction]],SplitRestrictionFn->[process->[ElementAndRestriction]],SDFProcessElementInvoker->[invoke_process_element->[Result,CheckpointState,initiate_checkpoint]]] | Invokes the process method of a Splittable DoFn with a given base - number of elements Yields a single element. | This is handled within the PerWindowInvoker already. |
@@ -76,7 +76,7 @@ class Dataset:
def as_arrays(self,
padding_lengths: Dict[str, Dict[str, int]] = None,
- verbose: bool = True) -> Dict[str, List[numpy.array]]:
+ verbose: bool = True) -> Dict[str, Union[numpy.array, Dict[str, numpy.array]]]:
"""
... | [Dataset->[as_arrays->[get_padding_lengths],get_padding_lengths->[get_padding_lengths]]] | This method converts this dataset into a set of numpy arrays that can be used to fill in This method checks whether we were a given a max length for a particular field and padding The type of the field array is not a type but it s a type of the array. | This type should now be `DataArray`, right? |
@@ -101,6 +101,8 @@ int spawn(const char *filename, const std::vector<std::string>& args, bool wait)
// child
if (pid == 0)
{
+ tools::closefrom(3);
+ close(0);
char *envp[] = {NULL};
execve(filename, argv, envp);
MERROR("Failed to execve: " << strerror(errno));
| [No CFG could be retrieved] | finds the next object in the system and returns it s exit code. get the id of the child passage. | Should it close all the descriptors here? I'm not sure there is a good generic behavior here; just wanted to discuss it. |
@@ -456,8 +456,11 @@ define([
break;
}
- // PERFORMANCE_IDEA: sort bins
- frustumCommands.commands[frustumCommands.index++] = command;
+ if (command.pass === Pass.OPAQUE || command instanceof ClearCommand) {
+ frustumCommands.opaqueCommands... | [No CFG could be retrieved] | Creates a new command in the scene s frustum. Potentially visible set. | This is a bit of a hack. Don't you agree? It means that we can inject clear commands during the translucent pass. That's OK for now. |
@@ -15,7 +15,7 @@ namespace System.Windows.Forms.Tests
public void Ctor_Default()
{
var collection = new SubBindingsCollection();
- Assert.Equal(0, collection.Count);
+ Assert.Empty(collection);
Assert.Empty(collection.List);
Assert.False(co... | [BindingsCollectionTests->[SubBindingsCollection->[ClearCore->[ClearCore],OnCollectionChanged->[OnCollectionChanged],OnCollectionChanging->[OnCollectionChanging],RemoveCore->[RemoveCore],AddCore->[AddCore]]]] | This method is called when a Ctor is not available in the current context. | These are not testing the `Count` property explicitely so I followed the xunit analyzer and updated the call |
@@ -414,6 +414,9 @@ public class DefaultMuleContext implements MuleContextWithRegistry, PrivilegedMu
final org.mule.runtime.api.artifact.Registry apiRegistry = getApiRegistry();
listeners.forEach(l -> l.onStop(this, apiRegistry));
+ Optional<ArtifactStoppedListener> optionalArtifactStoppedListener ... | [DefaultMuleContext->[fireNotification->[fireNotification],isInitialising->[isInitialising],isStarting->[isStarting],isDisposing->[isDisposing],disposeManagers->[dispose],isDisposed->[isDisposed],stop->[stop],initialise->[initialise],dispose->[dispose,stop],start->[start],isStopped->[isStopped],isStopping->[isStopping]... | Stop the context and dispose the Mule context if it is not already stopped. | no need to use the intermediate `Optional` just for this. a simple null check will do. |
@@ -1402,7 +1402,14 @@ func CreateRepository(doer, u *User, opts CreateRepoOptions) (_ *Repository, err
}
}
- return repo, sess.Commit()
+ err = sess.Commit()
+
+ // Add to hook queue for created repo after session commit.
+ if u.IsOrganization() {
+ go HookQueue.Add(repo.ID)
+ }
+
+ return repo, err
}
func... | [updateSize->[repoPath],UpdateSize->[updateSize],patchPath->[getOwner],Link->[FullName],DescriptionHTML->[Error,ComposeMetas,HTMLURL],mustOwner->[getOwner,Error],RepoPath->[repoPath],APIURL->[FullName],UploadAvatar->[CustomAvatarPath],generateRandomAvatar->[CustomAvatarPath],CloneLink->[cloneLink],GetAssignees->[getAss... | countRepositories returns number of repositories that are private or mirror. CountRepositories returns number of repositories user owns. | If commit fails repo won't be created |
@@ -556,7 +556,7 @@ func GetBootstrapClusterRoles() []authorizationapi.ClusterRole {
authorizationapi.NewRule("get", "delete").Groups(imageGroup).Resources("images", "imagestreamtags").RuleOrDie(),
authorizationapi.NewRule("get").Groups(imageGroup).Resources("imagestreamimages", "imagestreams/secrets").Rule... | [NormalizeResources,Sprintf,RuleOrDie,NewRule,Names,Convert,Groups,NewString,AllRoles,Resources] | is the base object for all API methods. authorizationapi. NewRuleOrDie. | does this mean we giving up the update rights to registry for images? |
@@ -192,6 +192,15 @@ $.extend(frappe.meta, {
}
},
+ get_print_sizes: function() {
+ return [
+ "A0", "A1", "A2", "A3", "A4", "A5", "A6", "A7", "A8", "A9",
+ "B0", "B1", "B2", "B3", "B4", "B5", "B6", "B7", "B8", "B9", "B10",
+ "C5E", "Comm10E", "DLE", "Executive", "Folio", "Ledger", "Legal",
+ "Letter", ... | [No CFG could be retrieved] | Get the name of the field that the given child is related to. function to get the list of print format names. | Feels like this should be fetched from Print Settings' pdf_page_size field's options instead. Or linked in some way. |
@@ -6,7 +6,7 @@ class PageView < ApplicationRecord
before_create :extract_domain_and_path
- algoliasearch index_name: "UserHistory", per_environment: true, if: :belongs_to_pro_user? do
+ algoliasearch index_name: "UserHistory", per_environment: true, if: :belongs_to_pro_user?, enqueue: :trigger_index_sync do
... | [PageView->[belongs_to_pro_user?->[pro?],extract_domain_and_path->[parse,path,domain],article_searchable_text->[body_text],article_searchable_tags->[cached_tag_list],article_tags->[cached_tag_list_array],attributeForDistinct,attributes,reading_time,year,searchableAttributes,attributesForFaceting,name,algoliasearch,dist... | The page view class Get the array of tags from the cache. | I noticed that we have inconsistent (but similar) naming on the enqueue methods. Most of them are `trigger_index`, but `User` model has `trigger_delayed_index`. What do you think about using `trigger_index` as a name for consistency? |
@@ -138,7 +138,7 @@ public class Orchestrator implements SpecCatalogListener, Instrumentable {
/** {@inheritDoc} */
@Override
public void onAddSpec(Spec addedSpec) {
- _log.info("New Spec detected: " + addedSpec);
+ _log.info("New Topology Spec detected: " + addedSpec);
if (addedSpec instanceof To... | [Orchestrator->[onAddSpec->[onAddSpec],onUpdateSpec->[onAddSpec,onDeleteSpec],onDeleteSpec->[onDeleteSpec]]] | Called when a new Spec is added to the topology. | This can be removed. The logging is below in the if block. |
@@ -30,7 +30,7 @@ func NewPrintNameOrErrorAfter(out, errs io.Writer) func(*resource.Info, error) {
// Create attempts to create each item generically, gathering all errors in the
// event a failure occurs. The contents of list will be updated to include the
// version from the server.
-func (b *Bulk) Create(list *ka... | [Create->[Object,Create,ClientMapperForCommand,InfoForObject,Encode,Refresh,NewHelper],Fprintf] | Create creates a list of objects in the given namespace. | we should return error list so we can inspect the individual errors (dunno if that is happening right now). |
@@ -184,7 +184,7 @@ public class TieredBrokerHostSelector<T> implements HostSelector<T>
brokerServiceName = tierConfig.getDefaultBrokerServiceName();
}
- ServerDiscoverySelector retVal = selectorMap.get(CuratorServiceUtils.makeCanonicalServiceName(brokerServiceName));
+ ServerDiscoverySelector retVa... | [TieredBrokerHostSelector->[start->[start],stop->[stop]]] | Select a broker service name that can be used to load the given query. This method returns the brokerServiceName and the default selector if it is not found. | Integration-tests were failing to discover broker without this change, are there any other fixes somewhere else to handle this ? |
@@ -805,7 +805,7 @@ func TestDiskBlockCacheHomeDirPriorities(t *testing.T) {
ctx := context.Background()
- rand.Seed(time.Now().UnixNano())
+ rand.Seed(1)
t.Log("Set home directories on the cache")
homeTLF := tlf.FakeID(100, tlf.Private)
| [setDiskBlockCache->[Lock,Unlock],DiskBlockCache->[RUnlock,RLock],RemoveAll,Value,Now,Duration,syncBlockCountsAndUnrefsFromDb,TempDir,Delete,evictFromTLFLocked,IDFromBytes,Encode,SetTlfSyncState,EnableDiskLimiter,Add,UpdateMetadata,Put,InEpsilon,FakeID,Error,Seconds,DiskLimiter,setBlockToReturn,NotNil,SetClock,Bytes,Af... | seedTlf seeds the cache with blocks from a given TLF ID. seedTlf is the base function for the blocks which are used in the block seed. | Interesting. We probably weren't even using `rand` before. |
@@ -2065,7 +2065,11 @@ class WindowInto(ParDo):
new_windows = self.windowing.windowfn.assign(context)
yield WindowedValue(element, context.timestamp, new_windows)
- def __init__(self, windowfn, **kwargs):
+ def __init__(self,
+ windowfn,
+ trigger=None,
+ accu... | [NoSideInputsCallableWrapperCombineFn->[merge_accumulators->[_ReiterableChain]],RestrictionProvider->[split_and_size->[restriction_size,split],restriction_size->[create_tracker]],Map->[_fn_takes_side_inputs,FlatMap],CombineValuesDoFn->[process->[merge_accumulators,create_accumulator,add_inputs,extract_output,apply]],Im... | Create a WindowInto object. | Could you add the allowable types for `windowfn` (Windowing and WindowFn?). |
@@ -603,6 +603,7 @@ const (
// hot region.
defaultHotRegionCacheHitsThreshold = 3
defaultSchedulerMaxWaitingOperator = 3
+ defaultLeaderScoreStrategy = "size"
)
func (c *ScheduleConfig) adjust(meta *configMetaData) error {
| [Parse->[Parse],IsDefined->[IsDefined],Adjust->[CheckUndecoded,Parse,IsDefined,Validate,Child],adjustLog->[IsDefined],adjust->[Validate,IsDefined],Parse] | adjust is used to set the default values for the schedule config This function is used to set the default configuration for a configuration object. | how about make count default? |
@@ -30,12 +30,16 @@ def copy_remote_directory_to_local(sftp, remote_path, local_path):
except Exception:
pass
-def create_ssh_sftp_client(host_ip, port, username, password):
+def create_ssh_sftp_client(host_ip, port, username, password, ssh_key_path, passphrase):
'''create ssh client'''
try:
... | [create_ssh_sftp_client->[check_environment],remove_remote_directory->[remove_remote_directory],copy_remote_directory_to_local->[copy_remote_directory_to_local]] | Copy remote directory to local machine. | If users set pkey, the password will be None? |
@@ -183,7 +183,11 @@ class DoctrineListBuilder extends AbstractListBuilder
protected function assignSortFields($queryBuilder)
{
foreach ($this->sortFields as $index => $sortField) {
- $queryBuilder->addOrderBy($sortField->getSelect(), $this->sortOrders[$index]);
+ $sort = ($sort... | [DoctrineListBuilder->[getEntityNamesOfFieldDescriptors->[getJoins],createQueryBuilder->[assignGroupBy],assignJoins->[getJoins],createSubQueryBuilder->[getJoins],getJoins->[getJoins]]] | Assigns the sort fields to the query builder. | Couldn't this ternary operator be avoided if we just always use `$sortField->getName()`? Then we could also get rid of this additional variable. |
@@ -96,7 +96,7 @@ public class GobblinHelixTaskTest {
}
@Test
- public void testPrepareTask() throws IOException {
+ public void testPrepareTask() throws Exception {
// Serialize the JobState that will be read later in GobblinHelixTask
Path jobStateFilePath =
new Path(appWorkDir, TestHelper... | [GobblinHelixTaskTest->[testPrepareTask->[assertTrue,Path,setJobName,setProp,mock,JobState,toString,getAbsolutePath,put,createSourceJsonFile,thenReturn,setJobId,File,serializeState,createNewTask,TaskConfig,absent,exists,createEmpty,GobblinHelixTaskFactory,prepareWorkUnit,newHashMap],testRun->[assertTrue,assertGenericRe... | testPrepareTask - prepare the task that should be run in a test environment This method is called when the application starts. | Please throw a more concrete exception. |
@@ -741,6 +741,17 @@ define([
return visibilityPlaneMask !== CullingVolume.MASK_OUTSIDE;
}
+ function isVisibleAndMeetsSSE(tileset, tile, frameState) {
+ var maximumScreenSpaceError = tileset._maximumScreenSpaceError;
+ var parent = tile.parent;
+ if (!defined(parent)) {
+ ... | [No CFG could be retrieved] | Computes the error of a Cesium3DTile. Get children of a tile. | You may want to check this, but I believe that by the time you call this function in `loadTile`, the results of `getScreenSpaceError` have already been cached in `tile._screenSpaceError` which gets computed in `visitStart`. |
@@ -3115,6 +3115,7 @@ define([
var context = frameState.context;
var scene3DOnly = frameState.scene3DOnly;
+ checkSupportedGlExtensions(model, context);
if (model._loadRendererResourcesFromCache) {
var resources = model._rendererResources;
var cachedResource... | [No CFG could be retrieved] | Creates a unique node in the network. Create vertex arrays and render states for the vertex and render states. | Can we move this call to be next to `checkSupportedExtensions` in `update`? |
@@ -136,7 +136,7 @@ class PDF extends TCPDF
*
* @return void
*/
- public function Download($filename)
+ public function download($filename)
{
$pdfData = $this->getPDFData();
Response::getInstance()->disable();
| [PDF->[Download->[disable,getPDFData],Error->[display],Footer->[SetY,Cell,getAliasNumPage,getAliasNbPages,SetFont],__construct->[AddFont,SetFont,setFooterFont,SetAuthor]]] | Download a single from the PDF file. | As this class bases on TCPDF, I'd probably keep their coding style here... |
@@ -187,6 +187,11 @@ namespace System.Net.Sockets
// Socket handle is going to post a completion to the completion port (may have done so already).
// Return pending and we will continue in the completion port callback.
+ if (_singleBufferHandleState == SingleBufferHandleState.InP... | [SocketAsyncEventArgs->[SetupPinHandlesSendPackets->[FreePinHandles],FreeNativeOverlapped->[FreeNativeOverlapped],HandleCompletionPortCallbackError->[FreeNativeOverlapped],AllocateNativeOverlapped->[AllocateNativeOverlapped],SocketError->[FreeNativeOverlapped,SocketError,RegisterToCancelPendingIO,AllocateNativeOverlapp... | Process an IOCP result. | Probably not an issue, but that this will lead to `_singleBufferHandle.Dispose()` in `Complete`. Also note that after these changes, the only semantical difference between `ProcessIOCPResult` and `ProcessIOCPResultWithSingleBufferHandle` is the pinning of the handle. Isn't it worth to dedupe that code at this point? |
@@ -45,9 +45,15 @@ static inline void select_cpu_clock_hw(int freq_idx, bool release_unused)
/* wait for requested clock to be on */
while ((io_reg_read(SHIM_BASE + SHIM_CLKSTS) &
- status_mask) != status_mask)
+ status_mask) != status_mask && --count)
idelay(PLATFORM_DEFAULT_DELAY);
+ if (!count) {
+ tr_... | [No CFG could be retrieved] | Select the hardware clock for the given CPU. Select the clock for the given frequency. | Where do we trace_err() about the timeout if it happens ? |
@@ -81,10 +81,10 @@ public class StateTransferConfigurationBuilder extends
@Override
public void validate() {
- // certain combinations are illegal, such as state transfer + invalidation
- if (fetchInMemoryState != null && fetchInMemoryState && getClusteringBuilder().cacheMode().isInvalidation())
- ... | [StateTransferConfigurationBuilder->[read->[chunkSize,timeout],timeout->[timeout]]] | Validate that the cache is not allowed to use a sequence number. | I'd prefer exceptions such as these to use Log |
@@ -71,10 +71,10 @@ public class ObjectFieldInfo {
int totalFlatFieldRefBytes = 0;
int totalFlatFieldSingleBytes = 0;
- public static final int NO_BACKFILL_AVAILABLE = -1;
- public static final int BACKFILL_SIZE = U32.SIZEOF;
- public static final int LOCKWORD_SIZE = j9objectmonitor_t_SizeOf;
- public static fi... | [ObjectFieldInfo->[addObjectsArea->[getNonBackfilledObjectCount],calculateFieldDataStart->[getSuperclassObjectSize,getSuperclassFieldsSize],isBackfillSuitableObjectAvailable->[getTotalObjectCount],isBackfillSuitableInstanceSingleAvailable->[getInstanceSingleCount],isBackfillSuitableInstanceObjectAvailable->[getInstance... | Sizeof constants for the object. Get the number of non - zero - indexed fields of an object. | Why not use `com.ibm.j9ddr.vm29.structure.ObjectFieldInfo.OBJECT_SIZE_INCREMENT_IN_BYTES` instead of defining this field? |
@@ -111,7 +111,7 @@ function twitter_api_pagehandler($page) {
*/
function twitter_api_tweet($hook, $type, $returnvalue, $params) {
- if (!elgg_instanceof($params['user'])) {
+ if (!$params['user'] instanceof ElggUser) {
return;
}
| [twitter_api_fetch_tweets->[get],twitter_api_tweet->[getGUID,post]] | twitter_api_tweet - twitter api tweet. | Does this really work? I feel like in the past this has lead to the equivalent of `if (false instanceof ElggUser)` |
@@ -147,6 +147,7 @@ Carver::~Carver() {
}
void Carver::start() {
+ setThreadName("carver");
// If status_ is not Ok, the creation of our tmp FS failed
if (!status_.ok()) {
LOG(WARNING) << "Carver has not been properly constructed";
| [No CFG could be retrieved] | Creates a new carver in the system. Checks if the file is in the carveDir and if it is a subdirectory creates the. | `InternalRunnable`s all have a `name_` value, would it be possible to poll what that value is and use it to name the thread instead of manually naming each? |
@@ -92,12 +92,10 @@ public class ArgumentListBuilder2Test {
}
public String echoArgs(String... arguments) throws Exception {
- String testHarnessJar = Class.forName("hudson.util.EchoCommand")
+ String testHarnessJar = new File(Class.forName("hudson.util.EchoCommand")
.getProte... | [ArgumentListBuilder2Test->[echoArgs->[replaceAll,toWindowsCommand,start,equalTo,ByteArrayOutputStream,toString,join,close,assertThat,StreamTaskListener],ensureArgumentsArePassedViaCmdExeUnmodified->[echoArgs,assumeTrue,isWindows,containsString,format,join,assertThat],slaveMask->[assertTrue,ArgumentListBuilder,println,... | Echo the given arguments. | Could also use `Paths.get( )`, or `Which.jarFile`, but this seems to work well enough. |
@@ -73,6 +73,7 @@ func testDeleteRepoFile(t *testing.T, u *url.URL) {
test.LoadRepoCommit(t, ctx)
test.LoadUser(t, ctx, 2)
test.LoadGitRepo(t, ctx)
+ defer ctx.Repo.GitRepo.Close()
repo := ctx.Repo.Repository
doer := ctx.User
opts := getDeleteRepoFileOptions(repo)
| [EqualError,EqualValues,Error,LoadRepoCommit,SetParams,MockContext,LoadRepo,LoadUser,NotNil,DeleteRepoFile,Run,Nil,LoadGitRepo,PrepareTestEnv] | TestDeleteRepoFile tests delete README. md file TestDeleteRepoFileWithoutBranchNames tests delete repo file with branch names removed. | How about add `MockContext.Close` and close repository there? |
@@ -128,10 +128,12 @@ class GitRepository < Repository::AbstractRepository
# static method that should yield to a git repo and then close it
def self.access(connect_string)
- repo = GitRepository.open(connect_string)
- yield repo
- ensure
- repo&.close
+ begin
+ repo = GitRepository.open(conne... | [GitRevision->[get_entry->[get_entry_hash],entries_at_path->[get_entry],initialize->[get_repos],tree_at_path->[add_entries_info,entries_at_path],changes_at_path?->[entry_changed?],entry_changed?->[get_entry_hash],add_entries_info->[close,entry_changed?,last_modified_date,try_advance_reflog!],directories_at_path->[add_e... | Access repository and delete if it exists. | Style/RedundantBegin: Redundant begin block detected. |
@@ -0,0 +1,7 @@
+FactoryBot.define do
+ factory :level do
+ name { Faker::Lorem.word }
+ description { Faker::Lorem.word }
+ rubric_criteria
+ end
+end
| [No CFG could be retrieved] | No Summary Found. | Be careful with spelling here. You want the singular form, `rubric_criterion`, for the association. |
@@ -41,7 +41,11 @@ class Leaderboard {
return field;
});
}
- this.timespans = ["Week", "Month", "Quarter", "Year", "All Time"];
+ this.timespans = [
+ "This Week", "This Month", "This Quarter", "This Year",
+ "Last Week", "Last Quarter", "Last Year",
+ "All Time", "Select From Date"
+ ];
... | [No CFG could be retrieved] | Create a class which contains the list of all leaderboards that can be shown on the main Constructor for the class. | I think this is missing "Last Month" |
@@ -120,7 +120,7 @@ namespace DotNetNuke.Services.Syndication
if (url.Trim() == "")
{
url = TestableGlobals.Instance.NavigateURL(searchResult.TabId);
- if (url.ToLower().IndexOf(HttpContext.Current.Request.Url.Host.ToLower()) == -1)
+ if (url.ToLo... | [RssHandler->[PopulateChannel->[SearchTypeIds,IsDeleted,Now,NullDate,StartsWith,PortalName,Add,ModuleMetaDataPrefixTag,DefaultLanguage,DisplaySyndicate,Empty,Description,ModuleId,GetRssItem,CanViewPage,NullInteger,MinValue,SearchTypeId,ToDateTime,ActiveTab,IsNullOrEmpty,ToString,MaxValue,AddHTTP,FooterText,EndDate,Star... | This method returns a generic rss item with the fields title description pubDate and guid. | Please use `String#IndexOf(String, StringComparison)` |
@@ -342,6 +342,12 @@ class FineGrainedBuildManager:
self.manager.log_fine_grained('--- update single %r ---' % module)
self.updated_modules.append(module)
+ # builtins and friends could potentially get triggered because
+ # of protocol stuff, but nothing good could possibly come from
+... | [find_targets_recursive->[ensure_deps_loaded],lookup_target->[lookup_target,not_found],reprocess_nodes->[update],refresh_suppressed_submodules->[ensure_deps_loaded],update_module_isolated->[ensure_trees_loaded,restore],find_symbol_tables_recursive->[find_symbol_tables_recursive,update],FineGrainedBuildManager->[trigger... | Updates a single module in the symbol table. Returns the remaining dependencies and the path of the node that was found. | Do we also need to add `abc` here? Also maybe you can re-use `mypy.semanal_main.core_modules` or define a new constant? |
@@ -50,12 +50,14 @@ var (
var (
cpOpts entities.ContainerCpOptions
+ chown bool
)
func cpFlags(cmd *cobra.Command) {
flags := cmd.Flags()
flags.BoolVar(&cpOpts.Extract, "extract", false, "Deprecated...")
flags.BoolVar(&cpOpts.Pause, "pause", true, "Deprecated")
+ flags.BoolVarP(&chown, "archive", "a", t... | [Dir,TempFile,ExactArgs,IsRegular,ContainerExists,Close,MarkHidden,Wrap,Atoi,Put,Copy,Pipe,ContainerCopyToArchive,New,Errorf,GetContext,IsArchivePath,ResolveHostPath,HasSuffix,Debugf,IsAbs,Wrapf,Join,Current,Name,Base,Get,JoinErrors,ContainerStat,IsDir,ContainerInspect,ParseSourceAndDestination,ContainerCopyFromArchive... | var creates a command line for copying the contents of the specified container to the specified cp - cp command for cobra. Command. | On `docker` this is by default false so no `chown` is done. Since `podman` should be drop in replacement for `docker` I made it false by default here, however this might be surprising for current users of `podman`. |
@@ -107,12 +107,12 @@ public class ExtensionListView {
}
@Override
- public void add(T t) {
+ synchronized public void add(T t) {
storage().add(t);
}
@Override
- public boolean remove(T t) {
+ synchroniz... | [ExtensionListView->[createCopyOnWriteList->[toArray->[toArray],getView->[storage],remove->[remove],add->[add],isEmpty->[isEmpty],addAllTo->[storage],iterator->[iterator]],createList->[size->[size],get->[get],remove->[remove],add->[add],iterator->[iterator]]]] | Create a copy of the list that can be used to copy the list of elements of a. | Typical ordering is `public synchronized void` |
@@ -1632,7 +1632,7 @@ vdev_indirect_splits_damage(indirect_vsd_t *iv, zio_t *zio)
}
iv->iv_attempts_max *= 2;
- if (iv->iv_attempts_max > (1ULL << 16)) {
+ if (iv->iv_attempts_max >= (1ULL << 12)) {
iv->iv_attempts_max = UINT64_MAX;
break;
}
| [No CFG could be retrieved] | - - - - - - - - - - - - - - - - - - This function is called when we have read all the data and need to find a combination of. | is this related to the ztest fix? Or is this just making it run faster by not damaging when it would cause more than 2^12 tries? |
@@ -157,7 +157,7 @@ public class ProviderConfig extends AbstractServiceConfig {
@Deprecated
public void setProtocol(String protocol) {
- this.protocols = Arrays.asList(new ProtocolConfig[]{new ProtocolConfig(protocol)});
+ this.protocols = new ArrayList<>(Arrays.asList(new ProtocolConfig[]{new... | [ProviderConfig->[getActives->[getActives],getTimeout->[getTimeout],getLoadbalance->[getLoadbalance],getCluster->[getCluster],isAsync->[isAsync],getRetries->[getRetries],getConnections->[getConnections]]] | Sets the protocol. | This can be simplified as `new ArrayList<>(Arrays.asList(new ProtocolConfig(protocol)))` |
@@ -696,13 +696,6 @@ class GMatrixClient(MatrixClient):
while True:
gevent.wait({response_queue, stop_event}, count=1)
- if stop_event.is_set():
- log.debug(
- "Handling worker exiting, stop is set",
- node=node_address_from_userid(... | [GMatrixClient->[stop_listener_thread->[node_address_from_userid],create_room->[_mkroom,create_room],_handle_message->[node_address_from_userid],_handle_responses->[_mkroom,node_address_from_userid],set_presence_state->[_send],stop->[stop_listener_thread],__init__->[GMatrixHttpApi],listen_forever->[node_address_from_us... | Worker to process messages from the network. This method is called in the order that the messages are queued. | Hummm, why did you move this code bellow? |
@@ -1243,7 +1243,7 @@ namespace Microsoft.Xna.Framework.Graphics
{
FeatureLevel featureLevel;
- if (graphicsDevice == null || graphicsDevice._d3dDevice == null)
+ if (graphicsDevice == null || graphicsDevice._d3dDevice == null || graphicsDevice._d3dDevice.NativePointer == I... | [GraphicsDevice->[Flush->[Flush],PlatformDrawIndexedPrimitives->[PlatformApplyState,PrimitiveTopology],SetRenderTarget->[SetRenderTarget],GetInputLayout->[GetInputLayout],PlatformDrawUserPrimitives->[PlatformApplyState,SetUserVertexBuffer,PrimitiveTopology],PlatformApplyState->[PlatformApplyState],PlatformDispose->[Cle... | PlatformGetHighestSupportedGraphicsProfile This method returns the highest supported graphics profile for the given. | Do we have any clue as to why this happens? Also what is the difference in `Device.FeatureLevel` and `Device.GetSupportedFeatureLevel()`. Why not call the static function all the time instead and avoid this issue entirely? |
@@ -62,7 +62,7 @@ $subject_info = elgg_view('output/url', array(
));
$delete_link = elgg_view("output/url", array(
- 'href' => "action/messages/delete?guid=" . $message->getGUID(),
+ 'href' => "action/messages/delete?guid=" . $message->getGUID() . "&full=$full",
'text' => elgg_view_icon('delete', '... | [getGUID,getURL] | Displays a message in the message list excerpt - Excerpt of message. | $full is a bool here. Don't you have to cast to int to make this work? |
@@ -330,9 +330,7 @@ namespace System.Windows.Forms
private UICuesStates _uiCuesState;
// Stores scaled font from Dpi changed values. This is required to distinguish the Font change from
- // Dpi changed events and explicit Font change/assignment. Caching Font values for each Dpi is complex.
-... | [Control->[OnSystemColorsChanged->[OnSystemColorsChanged,Invalidate],UpdateRoot->[GetTopLevel],OnFontChanged->[GetAnyDisposingInHierarchy,DisposeFontHandle,Font,Invalidate],AccessibilityNotifyClients->[AccessibilityNotifyClients],OnParentFontChanged->[IsFontSet,OnFontChanged],AutoValidate->[AutoValidate],OnParentBackCo... | Private members of a cues control. Reads an integer from the System. in and stores it in the System. out variable. | nit: spell out "monitor" |
@@ -829,6 +829,7 @@ func (e *Event) unpack(data []byte) error {
recoveredErrs = append(recoveredErrs, fmt.Errorf("malformed value for %s at pos %d", extKey, p+1))
(p)--
cs = 28
+ goto _again
goto _again
f17:
| [unpack->[pushExtension,Append,init,Errorf,Combine,Atoi]] | unpack unpacks the event from the input byte slice. This function is called to convert all the data structures into internal structures. parses the data structure and returns the object p This function is used to check if a value is in the list of values in the data This function is used to check if a value is in the l... | does this compile? |
@@ -36,8 +36,16 @@ const COOKIE_EXPIRATION_INTERVAL = COOKIE_MAX_AGE_DAYS * 24 * 60 * 60 * 1000;
/** @const {string} */
const CANARY_EXPERIMENT_ID = 'dev-channel';
-/** @const {!Object<string, boolean>} */
-const EXPERIMENT_TOGGLES = Object.create(null);
+/** @type {Object<string, boolean>} */
+let toggles;
+
+/**
... | [No CFG could be retrieved] | Creates an object that exports a single . Determines if the specified window has a dev - channel binary. | I am a tiny bit worried about this and similar ones ( `templateTagSupported` ) being accessed directly. We should hide them more. Either by scary names ( `uninitializedFoo` , `fooCache` ) or hide them all inside another object |
@@ -18,7 +18,7 @@ class SmsSenderNumberChangeJob < ActiveJob::Base
I18n.t(
'jobs.sms_sender_number_change_job.message',
app: APP_NAME,
- support_url: Figaro.env.support_url
+ support_url: contact_url
)
end
end
| [SmsSenderNumberChangeJob->[number_change->[send_sms],perform->[number_change,new],number_change_message->[t,support_url],queue_as]] | number_change_message - returns message for sms_sender_number_change_. | Do we need to worry about shortening this URL for SMS? |
@@ -294,6 +294,7 @@ describes.realWin('DoubleClick Fast Fetch RTC', {amp: true}, env => {
'data-multi-size-validation': macros['data-multi-size-validation'],
'data-override-width': macros['data-OVERRIDE-width'],
'data-override-height': macros['data-override-HEIGHT'],
+ 'data-json': JSO... | [No CFG could be retrieved] | Create an ethernet ad network doubleclick element and populate it with the real - time config. | does your test coverage handle the case where data-json exists but without targeting key? |
@@ -1124,6 +1124,11 @@ class ReviewFiles(ReviewBase):
class ReviewUnlisted(ReviewBase):
+ def clear_all_needs_human_review_flags(self):
+ """Clear needs_human_review flags, but unlike listed review, only do
+ it on the latest version, not all past versions."""
+ self.clear_specific_needs_hu... | [ReviewUnlisted->[approve_latest_version->[set_files,sign_files,notify_email,log_action],block_multiple_versions->[set_files,log_action],confirm_multiple_versions->[log_action]],ReviewHelper->[set_data->[set_data]],ReviewerQueueTable->[render_addon_name->[increment_item]],ViewUnlistedAllListTable->[render_authors->[saf... | Set an unlisted addon version files to public. | I don't understand why it's necessary to override this to change the behaviour - all of the methods that set the flags are overridden anyway? (maybe just `raise` if it's just for safety) |
@@ -162,6 +162,12 @@ def add_parser(subparsers, _parent_parser):
default=False,
help="Pull cache for subdirectories of the specified directory.",
)
+ pull_parser.add_argument(
+ "--clear-index",
+ action="store_true",
+ default=False,
+ help="Clear local index for t... | [CmdDataFetch->[run->[check_up_to_date]],add_parser->[add_parser,shared_parent_parser],CmdDataPush->[run->[check_up_to_date]],CmdDataPull->[run->[check_up_to_date]]] | Adds a parser to subparsers to pull and push a specified block of cache. Adds command line options for pushing a specified block of data to a remote storage. Adds command line options for the specified . | Desc doesn't match the other ones. Doesn't look like it was intended. |
@@ -197,7 +197,7 @@ free_get_attach_info_resp(Mgmt__GetAttachInfoResp *resp)
mgmt__get_attach_info_resp__free_unpacked(resp, &alloc.alloc);
}
-static void
+void
put_attach_info(struct dc_mgmt_sys_info *info, Mgmt__GetAttachInfoResp *resp)
{
if (resp != NULL)
| [No CFG could be retrieved] | Fill info - structures with the rank of the related objects. Get the attach info for a given name. | instead of this, you probably want to create wrapper functions such as dc_put_attach_info() dc_get_attach_info() that would be publically exposed and call static functions from those wrappers |
@@ -514,9 +514,12 @@ func (g *generator) genConfigVariable(w io.Writer, v *hcl2.ConfigVariable) {
getOrRequire = "Require"
}
- g.Fgenf(w, "%[1]svar %[2]s = config.%[3]s%[4]s(\"%[2]s\")", g.Indent, v.Name(), getOrRequire, getType)
if v.DefaultValue != nil {
+ g.Fgenf(w, "%[1]svar %[2]s = Output.Create(config.%... | [genResource->[resourceArgsTypeName,genResourceOptions,resourceTypeName,makeResourceName,genTrivia]] | genConfigVariable generates code for a config variable. | I think the right part of the `??` expression could have a type of than `Output<T>` too? Could you extend the test program so that both possibilities are tested (e.g. have a config with a fixed default value)? |
@@ -24,12 +24,12 @@ class Sample < ActiveRecord::Base
include_archived,
query = nil,
page = 1,
- current_organization = nil
+ current_team = nil
)
- org_ids =
- Organization
- .joins(:user_organizations)
- .where("user_organizations.user_id = ?", user.id)
+ team_ids =
+ ... | [Sample->[search->[gsub,offset,distinct,where_attributes_like],auto_strip_attributes,include,belongs_to,validates,has_many]] | This method is used to search for a single node in the system. | Prefer single-quoted strings when you don't need string interpolation or special symbols. |
@@ -63,7 +63,7 @@ class Subversion(VersionControl):
"""Export the svn repository at the url to the destination location"""
url, rev = self.get_url_rev()
rev_options = get_rev_options(self, url, rev)
- url = self.remove_auth_from_url(url)
+ url = remove_auth_from_url(url)
... | [Subversion->[get_src_requirement->[get_revision,get_url]]] | Export the svn repository at the url to the destination location. | this removes the auth information that will later be used in the command :-1: |
@@ -1378,3 +1378,15 @@ func (s *Server) SaveTTLConfig(data map[string]interface{}, ttl time.Duration) e
}
return nil
}
+
+func stringsEqual(a, b []string) bool {
+ if len(a) != len(b) {
+ return false
+ }
+ for i := range a {
+ if a[i] != b[i] {
+ return false
+ }
+ }
+ return true
+}
| [SetLabelPropertyConfig->[SetLabelPropertyConfig],GetReplicationModeConfig->[GetReplicationModeConfig],campaignLeader->[createRaftCluster,Name,GetAllocator,stopRaftCluster],GetClusterVersion->[GetClusterVersion],SetClusterVersion->[SetClusterVersion],DeleteLabelProperty->[DeleteLabelProperty,SetLabelProperty],Replicate... | SaveTTLConfig saves a TTL config to the persistent store. | Judge the situation where `len` is all 0, then we can still use `reflect.DeepEqual` directly? |
@@ -628,7 +628,7 @@ public class TestAnnotationEngineForAggregates
}
}
- // @Test - this is not yet supported
+ @Test(enabled = false) // TODO this is not yet supported
public void testSimpleExplicitSpecializedAggregationParse()
{
Signature expectedSignature = new Signature(
| [TestAnnotationEngineForAggregates->[CustomStateSerializerAggregationFunction->[createSerializer->[CustomSerializer]],NotDecomposableAggregationFunction->[createSerializer->[CustomSerializer]],InjectLiteralAggregateFunction->[createSerializer->[CustomSerializer]],InjectTypeAggregateFunction->[createSerializer->[CustomS... | Test simple explicit specialized aggregation. | This test indeed would not pass. |
@@ -58,6 +58,14 @@ public class MockKafkaTopicClient implements KafkaTopicClient {
return Collections.emptyMap();
}
+ @Override
+ public TopicDescription describeTopic(final String topicName) {
+ final Node node = new Node(1, "node", 9092);
+ final TopicPartitionInfo topicPartitionInfo = new TopicPart... | [MockKafkaTopicClient->[listTopicNames->[emptySet],getTopicConfig->[emptyMap],describeTopics->[emptyMap]]] | Get the topic configuration for a given topic. | Rather than hard coding your test requirements into the generic `MockKafkaTopicClient` you might be better of switching your test to use `FakeKafkaTopicClient`, which allows you to set up preconditions, like topics. |
@@ -310,17 +310,8 @@ ds_mgmt_mark_hdlr(crt_rpc_t *rpc)
tc_in->m_mark = in->m_mark;
rc = dss_rpc_send(tc_req);
- if (rc != 0) {
- crt_req_decref(tc_req);
- D_GOTO(out, rc);
- }
- out = crt_reply_get(tc_req);
- rc = out->m_rc;
- if (rc != 0) {
- crt_req_decref(tc_req);
- D_GOTO(out, rc);
- }
+ crt_req_decref(... | [No CFG could be retrieved] | This function decides if the object is a mark on all of the server targets. finds the n - th service in the chain and returns the n - th service in Request for a new request. | the change here looks good to me. But just checked that inside dss_rpc_send() it take one extra ref ("L40 crt_req_addref(rpc);), and no place to dec that ref (seems should decref in its complete cb - rpc_cb(), but it did not do that)? |
@@ -515,14 +515,14 @@ class LocalRemote(BaseRemote):
if download:
func = partial(
- remote.tree.download,
+ _log_exceptions(remote.tree.download, "download"),
dir_mode=self.tree.dir_mode,
file_mode=self.tree.file_mode,
... | [LocalRemoteTree->[copy->[copy,remove],isfile->[isfile],move->[isfile,move,makedirs],symlink->[symlink],_upload->[makedirs],is_symlink->[is_symlink],is_hardlink->[is_hardlink],walk_files->[walk_files],exists->[exists],reflink->[reflink],copy_fobj->[remove,makedirs],remove->[exists,remove],getsize->[getsize],makedirs->[... | Process a single . Push a new to the remote. | Still ugly, but now explicit and tree is not affected by remote logic. Would be nicer to use a contextmanager in the ThreadPool down below, but it is already too crowded there. |
@@ -0,0 +1,10 @@
+module Webhook
+ class EventSerializer
+ include FastJsonapi::ObjectSerializer
+ set_type :webhook_event
+ set_id do |event|
+ "#{event.event_type}_#{event.timestamp}"
+ end
+ attributes :event_type, :timestamp, :payload
+ end
+end
| [No CFG could be retrieved] | No Summary Found. | I see two issues with the current approach: the prefix with the type means that by sorting by it all events are grouped by type which doesn't really help sequencing them. One could say: well, you can use the timestamp, yeah, but there's still the possibility that two events generated by two different Rails processes ha... |
@@ -781,4 +781,10 @@ public interface MuleMessage extends Serializable
* @return the inbound message
*/
MuleMessage createInboundMessage() throws Exception;
+
+ /**
+ * Removes all outbound attachments on this message. Note: inbound attachments are immutable.
+ * {@link org.mule.api.transpo... | [No CFG could be retrieved] | Create a new inbound message. | I don't think it's possible for someone to use a custom MuleMessage implementation but you are assuming that in the code DefaultMuleMessage.copyMessageProperties (since you have logic for a DefaultMuleMessage and a different logic for any other kind of message). Or you add this change to the migration guide or you assu... |
@@ -67,10 +67,14 @@ func (r *TimeoutReader) Next() (reader.Message, error) {
r.running = true
go func() {
for {
- message, err := r.reader.Next()
- r.ch <- lineMessage{message, err}
- if err != nil {
- break
+ select {
+ case <-r.done:
+ return
+ case message, err := r.reader.Next():... | [Next->[Next,Stop,NewTimer],New] | Next returns the next message from the timeout reader. | we need the `r.ch <-` line to be in the select statement. |
@@ -865,6 +865,9 @@ func createFleetServerBootstrapConfig(
if port == 0 {
port = defaultFleetServerPort
}
+ if internalPort <= 0 {
+ port = defaultFleetServerInternalPort
+ }
if len(headers) > 0 {
if es.Headers == nil {
es.Headers = make(map[string]string)
| [enroll->[IsNotExist,NewEnrollCmd,Execute,New,createAgentConfig,Remove,AgentStateStoreFile,Metadata,AgentActionStoreFile],Execute->[Fprintln,M,daemonReload,New,stopAgent,fleetServerBootstrap,NewWithConfig,FixPermissions,enrollWithBackoff,writeDelayEnroll,remoteConfig,Info],daemonReload->[Disconnect,New,Restart,Connect]... | storeAgentInfo stores enrollment information for an agent. if policyID cert key and insecure are optional. | Shouldn't this be `if internalPort > 0 { internalPort = defaultFleetServerInternalPort } `? |
@@ -107,6 +107,16 @@ public class JobExecutionPlanListDeserializer implements JsonDeserializer<List<J
JobExecutionPlan jobExecutionPlan = new JobExecutionPlan(jobSpec, specExecutor);
jobExecutionPlan.setExecutionStatus(executionStatus);
+
+ try {
+ String jobExecutionFuture = serializedJobEx... | [JobExecutionPlanListDeserializer->[deserialize->[RuntimeException,error,JobExecutionPlan,setExecutionStatus,build,withVersion,withTemplate,get,withDescription,getString,getSpecExecutor,getAsString,getAsJsonArray,builder,add,parseString,valueOf,URI]]] | Deserializes a list of JobExecutionPlans from a JSON element. Get the next available execution plan. | Maybe propagate the exception - instead of silently logging and returning? |
@@ -924,8 +924,8 @@ class TorchRankerAgent(TorchAgent):
self.model.eval()
with torch.no_grad():
for vec_batch in tqdm(vec_batches):
- cand_encs.append(self.encode_candidates(vec_batch))
- return torch.cat(cand_encs, 0)
+ cand_encs.append(self.encode_ca... | [TorchRankerAgent->[eval_step->[score_candidates],train_step->[_get_train_preds,score_candidates,_get_batch_train_metrics],set_fixed_candidates->[get_task_candidates_path],_make_candidate_encs->[encode_candidates]]] | Encode candidates from vectors. | I'm not sure we want this. What led you to adding it? Thoughts from @emilydinan, @dexterju? |
@@ -72,8 +72,8 @@ public interface Appenderator extends QuerySegmentWalker, Closeable
* Committer is guaranteed to be *created* synchronously with the call to add, but will actually be used
* asynchronously.
* <p>
- * The add, clear, persist, persistAll, and push methods should all be called from the same... | [add->[add],persistAll->[persist,getSegments]] | This method is called by the Appender and the AppenderAdd methods. The CommitterSupplier is used to supply the committer of the current node. | so, `allowIncrementalPersists` is ignored if `committer` is null ? shouldn't it be the other way around and if `allowIncrementalPersists` is set to false then `committer` is ignored but if `allowIncrementalPersists` is true then a non-null committer must be provided ? |
@@ -17,11 +17,13 @@ with this program; if not, write to the Free Software Foundation, Inc.,
51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
*/
-#include "lua_api/l_object.h"
-#include <cmath>
+#include "database/database.h" // get_player_or_load
+#include "common/c_content.h"
+#include "common/c_convert... | [l_punch->[getobject,checkobject],l_send_mapblock->[getplayer,checkobject],l_set_physics_override->[getobject,checkobject],l_is_player->[getplayer,checkobject],l_get_physics_override->[getobject,checkobject],l_get_clouds->[getplayer,checkobject],l_set_attribute->[getplayersao,checkobject],l_set_animation->[getobject,ch... | function to check the type of a n - tuple object. function to check if udata object is unboxed. | Note to reviewers: This line was added, the others sorted alphabetically. |
@@ -304,11 +304,12 @@ class AssetManager(object): # pylint: disable=too-many-instance-attributes
channel.withdraw_lock(secret)
channels_to_remove.append(channel)
else:
+ # assume our partner dont know the secret and reveal it... | [AssetManager->[has_path->[has_path],register_secret->[register_secret],channel_isactive->[get_channel_by_partner_address],_secret->[register_secret]]] | This function handles the secret message and the lock for the partner. This method is called when a channel is not available in the network. | `dont know` -> `does not know` |
@@ -92,10 +92,12 @@ public class GcsUtilTest {
@Test
public void testGlobTranslation() {
- assertEquals("foo", GcsUtil.globToRegexp("foo"));
- assertEquals("fo[^/]*o", GcsUtil.globToRegexp("fo*o"));
- assertEquals("f[^/]*o\\.[^/]", GcsUtil.globToRegexp("f*o.?"));
- assertEquals("foo-[0-9][^/]*", Gcs... | [GcsUtilTest->[testUploadBufferSizeUserSpecified->[gcsOptionsWithTestCredential],testFileSizeWhenFileNotFoundNonBatch->[gcsOptionsWithTestCredential],testInvalidCopyBatches->[makeStrings],testRecursiveGlobExpansionFails->[gcsOptionsWithTestCredential],testMakeGetBatches->[sumBatchSizes,makeGcsPaths],testBucketAccessibl... | This test method creates a gcsOptions object with a test credential. | I'd expect to see new test cases here for `**`, `**/*`, etc. |
@@ -179,7 +179,7 @@ export default (
inputFillDisabled: themePrimitives.mono200,
inputFillActive: themePrimitives.mono200,
inputFillPositive: themePrimitives.positive50,
- inputTextDisabled: themePrimitives.mono600,
+ inputTextDisabled: themePrimitives.mono800,
inputBorderError: themePrimitives.negative20... | [No CFG could be retrieved] | This function is used to initialize a list of theme objects. Properties of a list of objects that are related to a specific object. | `mono600` is the correct token here that equals `#AFAFAF` per design spec. |
@@ -1523,7 +1523,7 @@ def _softmax(logits, compute_op, dim=-1, name=None):
# shape.
output.set_shape(shape)
- return output
+ return tf.identity(output, name=name)
def softmax(logits, dim=-1, name=None):
| [log_softmax->[_softmax],sparse_softmax_cross_entropy_with_logits->[_ensure_xent_args],xw_plus_b_v1->[bias_add_v1],with_space_to_batch->[adjust],softmax_cross_entropy_with_logits->[_ensure_xent_args,_move_dim_to_end,_flatten_outer_dims],softmax->[_softmax],_softmax->[_swap_axis,_flatten_outer_dims],xw_plus_b->[bias_add... | Helper function for softmax and log_softmax. Reshapes logits into a tensor and performs softmax on the last dimension. | Instead of adding an identity op, how about plumbing name through _swap_axis() to array_ops.tranpose() above? |
@@ -477,6 +477,13 @@ class SubStream(IOBase):
raise IOError("Stream failed to seek to the desired location.")
buffer_from_stream = self._wrapped_stream.read(current_max_buffer_size)
else:
+ absolute_position = self._stream_begin_i... | [_ChunkUploader->[_upload_chunk_with_progress->[_upload_chunk,_update_progress],_upload_substream_block_with_progress->[_update_progress,_upload_substream_block]],IterStreamer->[__len__->[__len__],read->[__next__]],PageBlobChunkUploader->[_upload_chunk->[_is_chunk_empty]],upload_substream_blocks->[_parallel_uploads],Su... | Reads a sequence of bytes from the underlying stream. read the remaining bytes from the buffer and update the position of the next in the buffer. | Why do we fail fast in the case of a lock instead of resetting to absolute position like what you've added? I'm guessing this could potentially mess with where other threads should reposition? |
@@ -301,7 +301,7 @@ func (d *Dispatcher) createAppliance(conf *configuration.Configuration) error {
Value: fmt.Sprintf("-serveraddr=0.0.0.0 -port=%s -port-layer-port=8080 %s", d.DockerPort, d.dockertlsargs)})
spec.ExtraConfig = append(spec.ExtraConfig, &types.OptionValue{Key: "guestinfo.vch/sbin/vicadmin",
V... | [createApplianceSpec->[getNetworkDevices],removeApplianceIfForced->[isVCH],createAppliance->[createApplianceSpec,findAppliance],makeSureApplianceRuns->[waitingForIP]] | createAppliance creates a new appliance on the target VM. GuestInfoControllerKey is a controller for the vCenter. GuestInfoConfig is a spec. Spec for the guestinfo command. This function is called when a component is being set to appliance. | Shouldn't all of these also be in the vch config, so that they can be serialized with the extraconfig package? |
@@ -55,6 +55,11 @@ func resourceAwsApiGatewayAuthorizer() *schema.Resource {
Type: schema.TypeString,
Optional: true,
},
+ "provider_arns": &schema.Schema{
+ Type: schema.TypeList,
+ Optional: true,
+ Elem: &schema.Schema{Type: schema.TypeString},
+ },
},
}
}
| [Printf,Set,Error,GetOk,Sprintf,Contains,HasChange,UpdateAuthorizer,DeleteAuthorizer,Id,String,CreateAuthorizer,Errorf,Int64,SetId,Get,GetAuthorizer,Code] | This function returns a resource that can be used to create an authorizer. returns a specification of the that can be used to find the corresponding . | Minor nitpick: the `&schema.Schema` here (copy paste ) is extra |
@@ -345,6 +345,7 @@ export class AmpAdNetworkAdsenseImpl extends AmpA4A {
this.responsiveState_ != null
? this.responsiveState_.getRafmtParam()
: null,
+ 'gdpr': gdprApplies === true ? '1' : gdprApplies === false ? '0' : null,
'gdpr_consent': consentString,
'pfx': pfx ?... | [No CFG could be retrieved] | Get the consent state of the element. Get url for a specific . | To clarify, a corner case is `gdpr_consent` contains the U.S. privacy string, and the endpoint doesn't have `gdprApplies`, and the fallback `consentRequired` value is used. So you would have both `gdpr`=1 and a `gdpr_consent` U.S. privacy string value. I want to double check that you're aware of this and it will be han... |
@@ -178,7 +178,8 @@ func boxTeamEKForUsers(ctx context.Context, g *libkb.GlobalContext, usersMetadat
RecipientGeneration: metadata.Generation,
Box: box,
}
- boxes = append(boxes, boxMetadata)
+ boxes[i] = boxMetadata
+ i++
if uid == myUID {
myTeamEKBoxed = &keybase1.TeamEkBoxed{
| [DeriveDHKey->[Bytes32],IsMember,ImportKeypairFromKID,UnmarshalAgain,GetUID,GetKID,CWarningf,NaclVerifyAndExtract,DeriveDHKey,Bytes32,SignToString,Put,GetAPI,HashMeta,CDebugf,Marshal,Post,SigningKey,Errorf,CTrace,Ctime,GetTeamEKBoxStorage,Equal,Get,UserVersionByUID,EncryptToString,Unmarshal,TimeFromSeconds,Load] | postNewTeamEKForUsers is called when a new teamEK is published and a new fetchTeamEKStatement fetches the team s from the server. | If you want to do this efficient thing, without needing to introduce the new iteration variable, you can do it with the 3-argument form of `make` to set the capacity. |
@@ -23,7 +23,7 @@ import <%=packageName%>.service.UserService;
import <%=packageName%>.service.dto.UserDTO;
import <%=packageName%>.web.rest.errors.InternalServerErrorException;
-import com.codahale.metrics.annotation.Timed;
+import io.micrometer.core.annotation.Timed;
import org.slf4j.Logger;
import org.slf4j.Lo... | [No CFG could be retrieved] | Produces a resource which represents a single user s account. check if the user is authenticated and return its login if it is authenticated. | I think the imported can be removed (as the methods are not annotated with `@Timed` anymore. |
@@ -140,18 +140,6 @@ async def py_constraints(
transitive_targets.closure, python_setup
)
- if not final_constraints:
- target_types_with_constraints = sorted(
- tgt_type.alias
- for tgt_type in registered_target_types.types
- if tgt_type.class_has_field(Interp... | [py_constraints->[output,TransitiveTargetsRequest,fill,writerow,join,MultiGet,output_stdout,DictWriter,constraints_to_addresses,AllTargetsRequest,PyConstraintsGoal,warning,output_sink,len,DependeesRequest,tuple,print_stderr,sorted,items,zip,Get,indent,str,create_from_targets,defaultdict,has_field,writeheader,class_has_... | Construct a PyConstraints object from the given constraints. A simple example of how to get a single from a list of all targets and their PyConstraintsGoal returns a constraint that can be used to find a constraint that is not found. | This case can no longer occur - we always get at least the global constraints. |
@@ -9,7 +9,7 @@ class Netcdf(Package):
homepage = "http://www.unidata.ucar.edu/software/netcdf/"
url = "ftp://ftp.unidata.ucar.edu/pub/netcdf/netcdf-4.3.3.tar.gz"
- version('4.4.0', 'f01cb26a0126dd9a6224e76472d25f6c')
+ version('4.4.0', 'cffda0cbd97fdb3a06e9274f7aef438e')
version('4.3.3', '5... | [Netcdf->[install->[append,make,join,configure],variant,depends_on,version]] | Creates a class that can be used to create a NetCDF - compatible object. Reads the CPPFLAGS and LDFLAGS for the given object. | Why did you need to change the md5sum of the package? As far as I can tell the old one is still correct. |
@@ -77,14 +77,6 @@ module.exports = webpackMerge(commonConfig({ env: ENV }), {
loaders: 'tslint-loader',
exclude: ['node_modules', new RegExp('reflect-metadata\\' + path.sep + 'Reflect\\.ts')]
},
- {
- test: /\.ts$/,
- loaders: [
- 'angular2... | [No CFG could be retrieved] | Config for the Nagios middleware. Config for all plugin that supports the n - node - middleware. | is this dependency also removed from package.json ? |
@@ -401,9 +401,10 @@ public class ConsoleProxyManagerImpl extends ManagerBase implements ConsoleProxy
return null;
}
- if (vm != null && vm.getState() != State.Starting && vm.getState() != State.Running) {
+ if (vm != null && vm.getState() != State.Starting && vm.getState() != Stat... | [ConsoleProxyManagerImpl->[createProxyInstance->[getDefaultNetworkForCreation],handleResetSuspending->[resumeLastManagementState,stopProxy],isPoolReadyForScan->[isZoneReady],scanPool->[checkCapacity],stopProxy->[stop],allocCapacity->[startNew,startProxy,assignProxyFromStoppedPool],resumeLastManagementState->[getManagem... | This method is used to assign a proxy to a user VM. get a console proxy resource that can be allocated or allocated. | :) a lot of getState()s there |
@@ -126,7 +126,7 @@ class Term_Relationships extends Module {
$items = array_chunk( $objects, $term_relationships_full_sync_item_size );
$last_object_enqueued = $this->bulk_enqueue_full_sync_term_relationships( $items, $last_object_enqueued );
$items_enqueued_count += count( $items );
- $... | [Term_Relationships->[enqueue_full_sync_actions->[prepare,get_results,bulk_enqueue_full_sync_term_relationships],estimate_full_sync_actions->[get_var],bulk_enqueue_full_sync_term_relationships->[bulk_enqueue_full_sync_actions,get_chunks_with_preceding_end]]] | Enqueue all terms that have been fully synced with the taxonomy. Enqueues full sync term relationships. | 'limit' needs to be a number of rows, each item has `$term_relationships_full_sync_item_size` rows. we can't use it as the limit for the query, I think. |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.