patch stringlengths 18 160k | callgraph stringlengths 4 179k | summary stringlengths 4 947 | msg stringlengths 6 3.42k |
|---|---|---|---|
@@ -4235,6 +4235,8 @@ spa_tryimport(nvlist_t *tryconfig)
poolname) == 0);
VERIFY(nvlist_add_uint64(config, ZPOOL_CONFIG_POOL_STATE,
state) == 0);
+ VERIFY(nvlist_add_uint64(config, ZPOOL_CONFIG_IMPORT_TXG,
+ spa->spa_uberblock.ub_txg) == 0);
VERIFY(nvlist_add_uint64(config, ZPOOL_CONFIG_TIMEST... | [No CFG could be retrieved] | Creates and initializes the object. Copy the name of the pool out to the bootfs if it exists. | @ofaaland in order to address the issue @nedbass found we should only add `ZPOOL_CONFIG_IMPORT_TXG` to the config when the activity check passes. The existing code adds it regardless which isn't what was intended. I'd suggest moving this code to the success path of the `spa_activity_check()` function. |
@@ -340,6 +340,10 @@ def parse_pattern(pattern, fallback=FnmatchPattern, recurse_dir=True):
"""Read pattern from string and return an instance of the appropriate implementation class.
"""
+ # Potential optimization for fm, sh, and pf patterns: if recurse_dir is False and the pattern
+ # doesn't do any... | [load_pattern_file->[parse_patternfile_line],PatternBase->[match->[normalize_path],__init__->[normalize_path]],ShellPattern->[_match->[match]],parse_pattern->[get_pattern_class],PatternMatcher->[add_inclexcl->[_add],add_includepaths->[add],match->[match],add->[_add]],ArgparsePatternFileAction->[parse->[load_pattern_fil... | Read pattern from string and return an instance of the appropriate implementation class. | why should we do any "optimization" or transformation? we can rather keep it simple and just do what the user tells borg to do. |
@@ -37,3 +37,4 @@ class Libspatialite(AutotoolsPackage):
depends_on('freexl')
depends_on('iconv')
depends_on('libxml2')
+ depends_on('minizip', when='@5.0.0')
| [Libspatialite->[getcwd,depends_on,version]] | Find all the dependencies of the module. | Presumably newer versions will also require this dependency? |
@@ -62,10 +62,11 @@ class SCMBase(object):
command = "%s %s" % (self.cmd_command, command)
with chdir(self.folder) if self.folder else no_op():
with environment_append({"LC_ALL": "en_US.UTF-8"}) if self._force_eng else no_op():
- if not self._runner:
- re... | [_check_repo->[_run_muted],Git->[check_repo->[_check_repo],get_remote_url->[run,_remove_credentials_url],get_branch->[run],is_pristine->[run],get_tag->[run],is_local_repository->[get_remote_url],get_commit_message->[run],get_repo_root->[run],checkout_submodules->[run],checkout->[run],_fetch->[run],get_commit->[run],clo... | Run command and return a URL. | Adding this ``pyinstaller_bundle_env_cleaned()`` should be the only functional change (and only affecting pyinstaller) in this PR. The rest is a pure refactor. |
@@ -111,10 +111,17 @@ public class KryoTranscoder implements Transcoder<Object> {
this.kryo.register(HashMap.class);
this.kryo.register(LinkedHashMap.class);
this.kryo.register(HashSet.class);
+ Set singletonSet = Collections.singleton("test");
+ this.kryo.register(singletonSet.... | [KryoTranscoder->[encode->[Output,flush,toByteArray,writeClassAndObject,ByteArrayOutputStream,CachedData],decode->[ByteArrayInputStream,Input,getData,readClassAndObject],initialize->[EnumSetSerializer,setRegistrationRequired,setReferences,CollectionsEmptyMapSerializer,UUIDSerializer,URLSerializer,setAutoReset,Collectio... | Initialize the Kryo serialization. Register serializers for all objects in the system. | I'd be happy to redo this bit - but the SingletonSet and SingletonMap classes in Collections are private - to register those all I could think of was to instantiate one of each, and do a getClass() on the results... |
@@ -337,11 +337,16 @@ func (f *Favorites) handleReq(req *favReq) (err error) {
}
// If we weren't explicitly asked to refresh, we can return possibly
// stale favorites rather than return nothing.
+ if err == context.DeadlineExceeded {
+ newCtx, _ := context.WithTimeout(context.Background(),
+ favo... | [loop->[handleReq],RefreshCache->[hasShutdown,Add],Get->[hasShutdown,sendReq],setHomeTLFInfo->[hasShutdown,Add],Delete->[hasShutdown,sendReq],sendReq->[waitOnReq,closeReq],Initialize->[readCacheFromDisk],Add->[hasShutdown,sendReq,waitOnReq,startOrJoinAddReq],AddAsync->[hasShutdown,Add,startOrJoinAddReq,closeReq],ClearC... | handleReq is called when we get a request to fetch a new list of favorites. This function is used to populate the Favorites cache. sendChangesToEditHistory sends changes to the edit history of the user in the cache. | I'm worried that this could trigger a bunch of goroutines. |
@@ -47,7 +47,9 @@ import org.junit.Test;
import java.util.Arrays;
import java.util.Collections;
import java.util.Date;
+import java.util.HashMap;
import java.util.List;
+import java.util.Map;
/**
*/
| [EC2AutoScalerTest->[testIptoIdLookup->[assertTrue,toStringFunction,newArrayList,size,andReturn,replay,EC2AutoScaler,ipToIdLookup,times,fill,asList,assertEquals,transform],testScale->[terminate,verify,size,atLeastOnce,andReturn,replay,EC2AutoScaler,get,provision,createMock,asList,assertEquals],setUp->[createMock,withPr... | Package private for testability. Creates a mock of all the objects that are mocked. | `ImmutableMap.of(k, v)` would be cleaner than the static block |
@@ -1,8 +1,15 @@
module AccountResetHelper
def create_account_reset_request_for(user)
- AccountReset::CreateRequest.new(user).call
- account_reset_request = AccountResetRequest.find_by(user_id: user.id)
- account_reset_request.request_token
+ request = AccountResetRequest.find_or_create_by(user: user)
+... | [cancel_request_for->[id,update,find_by,now],create_account_reset_request_for->[call,request_token,id,find_by],grant_request->[call]] | Creates a new AccountResetRequest for the given user. | What was the rationale for removing the service call and duplicating the code? |
@@ -151,6 +151,16 @@ void FastTransferBetweenModelPartsProcess::TransferWithFlags()
}
}
+ if (num_constraints != 0 && (mEntity == EntityTransfered::ALL || mEntity == EntityTransfered::CONSTRAINTS || mEntity == EntityTransfered::NODESANDCONSTRAINTS)) {
+ #pragma omp for
+ ... | [No CFG could be retrieved] | This function handles the case where the nodes and elements are not in the buffer. This method is called to add elements to the model part. | a small thing for readability : id -> thread_id |
@@ -19,7 +19,7 @@
export const getLoginUrl = () => {
const port = location.port ? `:${location.port}` : '';
- // If you have configured multiple OIDC providers, then, you can update this URL to /login.
+ // If you have configured multiple OIDC providers, then, you can update this URL to /account/login.
// It... | [No CFG could be retrieved] | Get the login URL. | this url is pointing to server side path. please don't update here |
@@ -51,7 +51,7 @@ public class VSizeIndexedIntsWriter extends SingleValueIndexedIntsWriter
)
{
this.ioPeon = ioPeon;
- this.valueFileName = String.format("%s.values", filenameBase);
+ this.valueFileName = StringUtils.safeFormat("%s.values", filenameBase);
this.numBytes = VSizeIndexedInts.getNumByt... | [VSizeIndexedIntsWriter->[getSerializedSize->[getCount],close->[write,close],open->[makeOutputStream,CountingOutputStream],addValue->[write,putInt,array],writeToChannel->[makeInputStream,write,toByteArray,copy,newChannel,wrap,getCount],format,allocate,getNumBytesForMax]] | Open the value file. | Probably should crash if bad format string |
@@ -37,6 +37,7 @@ module Engine
'entity' => entity.id,
'entity_type' => type_s(entity),
'id' => @id,
+ 'master_user' => @master_user,
**args_to_h,
}.reject { |_, v| v.nil? }
end
| [Base->[copy->[from_h],split->[split],to_h->[reject,nil?],from_h->[new,h_to_args,get],attr_reader,include,attr_accessor],require_relative] | Returns a hash with all the keys of the missing node in the order they were found. | user basically, we need to check that the user is not the same as the player |
@@ -0,0 +1,17 @@
+class CreateProofingCosts < ActiveRecord::Migration[5.1]
+ disable_ddl_transaction!
+
+ def change
+ create_table :proofing_costs do |t|
+ t.integer :user_id, null: false
+ t.integer :acuant_front_image_count, default: 0
+ t.integer :acuant_back_image_count, default: 0
+ t.... | [No CFG could be retrieved] | No Summary Found. | Does this need to be concurrent? The table should be empty, right? |
@@ -1862,13 +1862,13 @@ func mockBuildGenerator(buildConfigFunc func(ctx context.Context, name string, o
func TestGenerateBuildFromConfigWithSecrets(t *testing.T) {
source := mocks.MockSource()
- revision := &buildapi.SourceRevision{
- Git: &buildapi.GitSourceRevision{
+ revision := &buildv1.SourceRevision{
+ Gi... | [MockSource,Resource,MockDockerStrategyForEnvs,DeepEqual,MockJenkinsStrategyForEnvs,Clone,IsZero,MockBuildConfig,MockBuilderSecrets,NewDefaultContext,Error,MockSourceStrategyForImageRepository,ValidateBuild,MatchString,GetInputReference,generateBuildFromConfig,MockBuilderServiceAccount,Errorf,resolveImageStreamReferenc... | mockDockerStrategyForDockerImage returns a mock of the build object that can be used to mockCustomStrategyForImageRepository returns a mock of the buildapi. BuildStrategy for the. | Another unnecessary change :stuck_out_tongue_winking_eye: |
@@ -319,6 +319,7 @@ static char *md5crypt(const char *passwd, const char *magic, const char *salt)
|| !EVP_DigestUpdate(md, magic, magic_len)
|| !EVP_DigestUpdate(md, "$", 1)
|| !EVP_DigestUpdate(md, salt_out, salt_len))
+ goto err;
md2 = EVP_MD_CTX_new();
if (md2 == NULL
| [No CFG could be retrieved] | Reads the first N bytes of the first N bytes of the first N bytes of the first check if the given buffer is valid and if so update it. | OMG. Our very own goto fail! :) |
@@ -513,7 +513,8 @@ class QueueBase(object):
operations will fail. Subsequent `dequeue` and `dequeue_many`
operations will continue to succeed if sufficient elements remain
in the queue. Subsequent `dequeue` and `dequeue_many` operations
- that would block will fail immediately.
+ that won't block ... | [StagingArea->[put->[_scope_vals,_check_put_dtypes],get->[__internal_get],peek->[__internal_get],__internal_get->[_get_return_value]],QueueBase->[from_list->[QueueBase],dequeue->[_dequeue_return_value],dequeue_many->[_dequeue_return_value],dequeue_up_to->[_dequeue_return_value],enqueue->[_scope_vals,_check_enqueue_dtyp... | Closes this queue. | Perhaps something like: Subsequently `dequeue` and `dequeue_many` operations that would otherwise block waiting for more elements (if `close` hadn't been called) will now fail immediately. will make it clearer. |
@@ -21,7 +21,12 @@ func Wrap(ctx context.Context, constructor alice.Constructor) alice.Constructor
if constructor == nil {
return nil, nil
}
- handler, err := constructor(next)
+ // we need to start tracing when middleware (provided by `constructor`) starts
+ // and finish when middleware ends, but before ... | [ServeHTTP->[FromContext,Context,ServeHTTP,StartSpan],WithField,GetTracingInformation,FromContext,Debug] | tracing import imports a package into the alice. Constructor. ServeHTTP - serve HTTP request if it s not nil. | Shouldn't we only do these two within the L34-L37 if case? Do we want to return L39 a handler that is a tracefinisher even when the underlying handler is not traceable? |
@@ -343,8 +343,9 @@ def find_paddle_libraries(use_cuda=False):
# pythonXX/site-packages/paddle/libs
paddle_lib_dirs = [get_lib()]
if use_cuda:
- cuda_dirs = find_cuda_includes()
- paddle_lib_dirs.extend(cuda_dirs)
+ cuda_lib_dirs = find_cuda_libraries()
+ print(cuda_lib_dirs)
... | [find_paddle_libraries->[find_cuda_includes],parse_op_info->[instance,load_op_meta_info_and_register_op],_write_setup_file->[is_cuda_file,use_new_custom_op_load_method],_import_module_from_library->[load_op_meta_info_and_register_op],parse_op_name_from->[regex],load_op_meta_info_and_register_op->[load_op_meta_info_and_... | Find all paddle libraries. | You can use `log_v` to log necessary log for users. |
@@ -234,6 +234,9 @@ namespace System.Threading
? AppContextConfigHelper.GetBooleanConfig("System.Threading.ThreadPool.EnableWorkerTracking", false)
: GetEnableWorkerTrackingNative();
+ internal static readonly bool EnableDispatchAutoReleasePool =
+ AppContextConfigH... | [ThreadPool->[EnsureGateThreadRunning->[EnsureGateThreadRunning],UnsafeQueueNativeOverlapped->[PostQueuedCompletionStatus],GetMaxThreads->[GetMaxThreads],GetOrCreateThreadLocalCompletionCountObject->[GetOrCreateThreadLocalCompletionCountObject],NotifyWorkItemComplete->[NotifyWorkItemComplete],SetMinThreads->[SetMinThre... | private static final int WORKER_COUNTER_INDEX = 0 ;. | Do we have a test that sets this AppContext switch to its non-default value? |
@@ -188,6 +188,18 @@ class ConfigStack:
"""
tls = threading.local()
+ @classmethod
+ def top_or_none(cls):
+ """Get the TOS of return None if no config is set.
+ """
+ self = cls()
+ if self:
+ flags = self.top()
+ else:
+ # Note: should this be... | [benchmark->[BenchmarkResult],ConfigStack->[pop->[pop],enter->[pop,push]],stream_list->[sublist_iterator],ConfigOptions->[unset->[set],copy->[copy],__setattr__->[_check_attr],__getattr__->[_check_attr]],unified_function_type->[get_nargs_range,set]] | Initialize the object with a sequence number. | I think perhaps it should be the default so it is always known precisely which flags are in use for a given function. |
@@ -1304,7 +1304,7 @@ module.exports = class kucoinfutures extends kucoin {
'datetime': this.iso8601 (timestamp),
'currency': code,
'amount': amount,
- 'fromAccount': 'futures',
+ 'fromAccount': 'future',
'toAccount': 'spot',
'status... | [No CFG could be retrieved] | Transfer out a specific order from futures to spot wallet Get the next n - block items that are available for a given market. | i don't think we should change this instance, let's only change the `.market` attributes |
@@ -3126,9 +3126,7 @@ void gui_init(struct dt_iop_module_t *self)
gtk_box_pack_start(GTK_BOX(self->widget), GTK_WIDGET(g->notebook), FALSE, FALSE, 0);
g_signal_connect(G_OBJECT(g->notebook), "button-press-event", G_CALLBACK(notebook_button_press), self);
- gtk_container_child_set(GTK_CONTAINER(g->notebook), pa... | [No CFG could be retrieved] | Initialize the tab - view and tab - notebook This is the main entry point for the Bauhaus slider. It is the widget. | this change is equivalent |
@@ -1875,7 +1875,7 @@ class PTransformTypeCheckTestCase(TypeHintTestCase):
(self.p
| beam.Create(range(100)).with_output_types(int)
| 'Num + 1' >> beam.Map(lambda x: x + 1).with_output_types(int)
- | 'TopMod' >> combine.Top.PerKey(1, lambda a, b: a < b))
+ | 'TopMod' >> combine.Top.Pe... | [PTransformLabelsTest->[test_apply_custom_transform_without_label->[CustomTransform],test_label_propogation->[MyDoFn,check_label],test_apply_custom_transform_with_label->[CustomTransform],test_default_labels->[MyDoFn,check_label],test_apply_ptransform_using_decorator->[SamplePTransform]],PTransformTypeCheckTestCase->[t... | Checks that the per - key pipeline checking is not raised. | Should we leave some of these tests for the remaining py2 code? (For Top.PerKey usage) |
@@ -69,7 +69,18 @@ RUNLOOP:
case <-ctx.Done():
refresher.log.WithError(ctx.Err()).Info("Policy refresher exiting")
break RUNLOOP
+ case <-refresher.changeNotifier.C():
+ refresher.log.Info("Received policy change notification")
+ var err error
+ lastPolicyID, err = refresher.refresh(context.Background... | [getRoleMap->[ListRoles,Infof],RefreshAsync->[Background,Warn],getPolicyMap->[ListPolicies,String,Infof],run->[Reset,Stop,Respond,NewTimer,Warn,WithError,Info,refresh,Err,Done],getRuleMap->[Infof],refresh->[Warn,GetPolicyChangeID,WithError,Info,updateEngineStore,WithFields],Refresh->[Err],updateEngineStore->[NewOutgoin... | run runs the policy refresher. It will periodically refresh the policy s anti - entropy. | how is this timer used? it seems like the refresher is both listening for change notifications and also periodically refreshing based on the timer - is that right? are both needed? |
@@ -129,11 +129,13 @@ const files = {
{ file: 'home/_home.component.html', method: 'copyHtml' },
// layouts
'layouts/_index.ts',
+ 'layouts/_layout-routing.module.ts',
'layouts/profiles/_profile.service.ts',
'layouts/pro... | [No CFG could be retrieved] | Private static files that can be accessed by the UA. Missing conditions for the error page. | I think you missed to remove this and add `app.state.ts` back |
@@ -1600,7 +1600,7 @@ class DataSpecProperty(BasicProperty):
class DataSpec(Either):
def __init__(self, typ, default, help=None):
- super(DataSpec, self).__init__(String, Dict(String, Either(String, typ)), typ, default=default, help=help)
+ super(DataSpec, self).__init__(String, Dict(String, Eithe... | [RelativeDelta->[__init__->[Enum]],Property->[serializable_value->[__get__],set_from_json->[__set__]],UnitsSpecProperty->[__set__->[_extract_units],_extract_units->[__set__],set_from_json->[_extract_units]],Either->[from_json->[from_json,DeserializationError],validate->[is_valid],transform->[transform]],Color->[__init_... | Initialize a data spec with a sequence of base_name and default values. | I think this can be more specific, e.g. `Instance(Transform)` |
@@ -33,6 +33,9 @@ import * as describes from '../testing/describes';
// All exposed describes.
global.describes = describes;
+// Increase the before/after each timeout since certain times they have timedout
+// during the normal 2000 allowance.
+const BEFORE_AFTER_TIMEOUT = 5000;
// Needs to be called before the... | [No CFG could be retrieved] | Creates a new instance of the given type of object and populates it with the given values. Called for each test suite in the suite tree. | If this is only for video tests you should be able to just do it for the video tests, no? Maybe inside the describe of the top level. |
@@ -360,7 +360,15 @@ namespace System.Net.Http
protected internal override System.Net.Http.HttpResponseMessage Send(System.Net.Http.HttpRequestMessage request, System.Threading.CancellationToken cancellationToken) { throw null; }
protected internal override System.Threading.Tasks.Task<System.Net.Http.... | [No CFG could be retrieved] | Override this method to allow subclasses to override the sendAsync method. | This may have been discussed in API review. It struck me as a little strange that we dropped the Http from HttpRequestMessage but not the Dns from DnsEndPoint: I'd have expected this to be named EndPoint for consistency. Not a big deal, though. |
@@ -176,8 +176,6 @@ void buffer_free(struct comp_buffer *buffer)
/* In case some listeners didn't unregister from buffer's callbacks */
notifier_unregister_all(NULL, buffer);
- list_item_del(&buffer->source_list);
- list_item_del(&buffer->sink_list);
rfree(buffer->stream.addr);
rfree(buffer->lock);
rfree(bu... | [buffer_params_match->[assert],comp_update_buffer_produce->[audio_stream_produce,buffer_lock,buffer_unlock,audio_stream_get_avail_bytes,dev_comp_type,audio_stream_get_free_bytes,buf_dbg,notifier_event,dev_comp_id],buffer_zero->[dcache_writeback_region,bzero,buf_dbg],buffer_free->[list_item_del,notifier_unregister_all,b... | free a buffer that has no more references to it. | interesting. `list_item_del()` in SOF also does `list_init()`, so, you can delete list items as often as you like. And you can use `list_is_empty()` on list items. So this shouldn't hurt the run-time, although this might be redundant. So firstly I don't understand why valgrind complains, and secondly - are we sure `buf... |
@@ -57,12 +57,9 @@ class OrderQueryset(models.QuerySet):
fulfilled).
"""
statuses = {OrderStatus.UNFULFILLED, OrderStatus.PARTIALLY_FULFILLED}
- payments = Payment.objects.filter(is_active=True).values("id")
- qs = self.annotate(amount_paid=Sum("payments__captured_amount"))
- ... | [OrderLine->[is_digital->[is_digital]],Order->[can_capture->[can_capture,get_last_payment],can_void->[can_void,get_last_payment],get_subtotal->[get_subtotal],can_refund->[can_refund,get_last_payment],update_total_paid->[save]]] | Return orders that can be fulfilled or unfulfilled. | What about Overpaid? They should also be ready to fulfill, right? |
@@ -4058,13 +4058,13 @@ inline void gcode_M17() {
*/
inline void gcode_M31() {
char buffer[21];
- timestamp_t time(print_job_timer.duration());
- time.toString(buffer);
+ duration_t elapsed = print_job_timer.duration();
+ elapsed.toString(buffer);
lcd_setstatus(buffer);
SERIAL_ECHO_START;
- SERIAL_... | [No CFG could be retrieved] | Gcode for specific 4 letters after the M - 3 name. | So `MSG_PRINT_TIME` isn't used anymore, right? Should be removed from language files ASAP (#4395) |
@@ -174,6 +174,7 @@ class TypeAnalyser(SyntheticTypeVisitor[Type]):
return self.analyze_callable_type(t)
elif fullname == 'typing.Type':
if len(t.args) == 0:
+ self.implicit_any('Type without type args', t)
return TypeType(AnyType(),... | [TypeAnalyser->[anal_var_defs->[anal_array],visit_unbound_type->[visit_unbound_type,no_subscript_builtin_alias],bind_function_type_variables->[infer_type_variables],replace_alias_tvars->[get_tvar_name,replace_alias_tvars],tuple_type->[builtin_type]],TypeVariableQuery->[visit_unbound_type->[_seems_like_callable]],flatte... | Visit an unbound type. Returns a type object for the given type. Construct a type object from the given arguments. Create a named tuple or typeddict type if the class does not have a base class. | There doesn's seem to be a test case for this. It's probably worth having one. |
@@ -199,7 +199,9 @@ class ProductVariantsByProductIdAndChannel(DataLoader):
def get_variants_filter(self, products_ids, channel_slugs):
return {
"product_id__in": products_ids,
- "channel_listings__channel__slug__in": channel_slugs,
+ "channel_listings__channel__slug__in... | [CollectionsByVariantIdLoader->[batch_load->[with_variants->[CollectionsByProductIdLoader],ProductVariantByIdLoader]],ProductTypeByVariantIdLoader->[batch_load->[with_variants->[ProductTypeByProductIdLoader],ProductVariantByIdLoader]],VariantsChannelListingByProductIdAndChannelSlugLoader->[batch_load->[with_variants->[... | Return a queryset of all the variants that match the given products. | Could you explain why we need to do `str` on channel_slugs? |
@@ -107,6 +107,9 @@ class ElggMemcache extends \ElggSharedMemoryCache {
if (isset($this->CONFIG->memcache_expires)) {
$this->expires = $this->CONFIG->memcache_expires;
}
+
+ // make sure memcache is reset
+ _elgg_services()->events->registerHandler('cache:flush', 'system', array($this, 'clear'));
}
... | [ElggMemcache->[delete->[delete,makeMemcacheKey],save->[makeMemcacheKey],load->[makeMemcacheKey]]] | Construct the object Initialize the memcache object. | As we here use method called `clear` I'd prefer event to be called `cache:clear` as well. |
@@ -1,4 +1,4 @@
-// Code generated by mockery v2.8.0. DO NOT EDIT.
+// Code generated by mockery v0.0.0-dev. DO NOT EDIT.
package mocks
| [RaiseFlags->[Get,Error,Called],FilterFlagRaised->[Get,Error,Called],WatchOwnershipTransferred->[Get,Error,Called],WatchRaisingAccessControllerUpdated->[Get,Error,Called],ParseOwnershipTransferRequested->[Get,Error,Called],FilterRaisingAccessControllerUpdated->[Get,Error,Called],Owner->[Get,Error,Called],WatchRemovedAc... | AcceptOwnership provides a mock function that provides a mock object with given fields. Address provides a mock function with given fields. | I thought that version mismatch here usually failed CI? |
@@ -0,0 +1,16 @@
+// Copyright 2020 The Gitea Authors. All rights reserved.
+// Use of this source code is governed by a MIT-style
+// license that can be found in the LICENSE file.
+
+package themes
+
+import (
+ "testing"
+
+ "github.com/stretchr/testify/assert"
+)
+
+func TestThemes(t *testing.T) {
+ Init()
+ assert... | [No CFG could be retrieved] | No Summary Found. | Would like to do a full test here but I have no idea how to properly initialize the `setting` module for the test. If I used `models.PrepareTestEnv(t)` it just segfaults during the test. |
@@ -0,0 +1,12 @@
+import textwrap
+import os
+
+import unittest
+
+from conans.test.assets.genconanfile import GenConanfile
+from conans.test.utils.tools import TestClient
+
+
+class CacheWithLayoutTest(unittest.TestCase):
+ # Tests that show how the folders in the cache respond to the declared layout in the recipe
... | [No CFG could be retrieved] | No Summary Found. | You can start using pytest tests, they are simpler to write and more elegant |
@@ -930,9 +930,9 @@ def _mouse_click(event, params):
def _handle_topomap_bads(ch_name, params):
"""Color channels in selection topomap when selecting bads."""
- for type in ('mag', 'grad', 'eeg', 'seeg', 'hbo', 'hbr'):
- if type in params['types']:
- types = np.where(np.array(params['types'... | [_annotation_radio_clicked->[_get_active_radiobutton],tight_layout->[tight_layout],_handle_change_selection->[_set_radio_button],_annotate_select->[_get_active_radiobutton],_onclick_new_label->[_setup_annotation_fig,_set_annotation_radio_button],_helper_raw_resize->[_layout_figure],_mouse_click->[_plot_raw_time,_handle... | Color channels in selection topomap when selecting bads. | I thought we wanted to avoid one-letter vars ;) |
@@ -940,6 +940,13 @@ function _contact_detail_for_template($rr)
$sparkle = '';
}
+ if ($rr['self']) {
+ $dir_icon = 'images/larrow.gif';
+ $alt_text = L10n::t('This is you');
+ $url = $rr['url'];
+ $sparkle = '';
+ }
+
return [
'img_hover' => L10n::t('Visit %s\'s profile [%s]', $rr['name'], $rr['url']),... | [contacts_content->[set_pager_total]] | Returns an array of detail data for a contact template Contact Selection Request. | What a relief, we already use this string :-D |
@@ -149,8 +149,10 @@ void engine_cleanup_add_last(ENGINE_CLEANUP_CB *cb)
if (!int_cleanup_check(1))
return;
item = int_cleanup_item(cb);
- if (item)
- sk_ENGINE_CLEANUP_ITEM_push(cleanup_stack, item);
+ if (item) {
+ if (sk_ENGINE_CLEANUP_ITEM_push(cleanup_stack, item) <= 0)
+ ... | [ENGINE_free->[engine_free_util],int->[sk_ENGINE_CLEANUP_ITEM_new_null],engine_cleanup_int->[sk_ENGINE_CLEANUP_ITEM_pop_free,CRYPTO_THREAD_lock_free,int_cleanup_check],ENGINE_CLEANUP_ITEM->[OPENSSL_malloc],ENGINE_set_name->[ENGINEerr],engine_free_util->[CRYPTO_atomic_add,engine_pkey_asn1_meths_free,CRYPTO_free_ex_data,... | add last cleanup callback. | Should that be tested against NULL? Not worth delaying this PR if it will take awhile to get around to fixing that nit. |
@@ -69,12 +69,14 @@ class WP_Test_Jetpack_Podcast_Helper extends WP_UnitTestCase {
->method( 'load_feed' )
->will( $this->returnValue( $rss ) );
+ $id = wp_unique_id( 'podcast-track-' );
+
$podcast_helper->expects( $this->exactly( 1 ) )
->method( 'setup_tracks_callback' )
->will(
$this->retur... | [WP_Test_Jetpack_Podcast_Helper->[test_get_track_data_feed_error->[get_error_message,assertSame,returnValue,get_error_code,getMock,will,assertWPError,get_track_data],test_get_track_data_find_episode->[get_error_message,assertSame,returnValue,get_error_code,getMock,will,assertWPError,get_track_data]]] | This test test creates mocks for the SimplePie_Item and returns an array of the This method checks if the track data is valid. | I was a bit surprised to see this in here, but \_()_/ |
@@ -304,8 +304,15 @@ class SimpleSeq2Seq(Model):
source_mask = state["source_mask"]
batch_size = source_mask.size()[0]
+ # shape: (batch_size, max_target_sequence_length)
+ target_mask = util.get_text_field_mask(target_tokens)
+ weights = target_mask[:,1:]
if target_t... | [SimpleSeq2Seq->[forward->[_forward_loop,_forward_beam_search,_bleu,_encode,update,_init_decoder_state],_forward_loop->[rand,softmax,size,max,append,_get_loss,cat,_prepare_output_projections,get_text_field_mask,range,new_full,unsqueeze],_forward_beam_search->[search,state],take_step->[_prepare_output_projections,log_so... | Internal loop for the forward pass of the base on the given state. Computes the last prediction and loss of a in a batch. | Calling this `weights` is confusing as this is a mask specifically. Maybe `target_mask_without_start` or `target_mask_shifted`? |
@@ -32,7 +32,7 @@ elgg_push_breadcrumb($title);
$content = elgg_view_entity($page, array('full_view' => true));
$content .= elgg_view_comments($page);
-if (elgg_is_admin_logged_in() || elgg_get_logged_in_user_guid() == $page->getOwnerGuid()) {
+if ($page->canEdit() && $container->canWriteToContainer('object', 'page... | [getOwnerGuid,getContainerGUID] | View a page. | This call to canWriteToContainer doesn't match with the function signature. I think you need a 0 as the first argument. |
@@ -72,9 +72,9 @@ public abstract class AbstractUndoableMovesPanel extends JPanel {
final JPanel items = new JPanel();
items.setLayout(new BoxLayout(items, BoxLayout.Y_AXIS));
// we want the newest move at the top
- m_moves = new ArrayList<>(m_moves);
- Collections.reverse(m_moves);
- final Iter... | [AbstractUndoableMovesPanel->[undoMoves->[undoMoves],initLayout->[paint->[paint]]]] | Initializes the layout of the menu. This method is called when the scroll bar is added to the DOM. It is called when. | Not the scope of this PR, but `!moves.isEmpty()` should be used instead of this iterator |
@@ -38,8 +38,7 @@ public class HoodieBootstrapHandle<T extends HoodieRecordPayload, I, K, O> exten
public HoodieBootstrapHandle(HoodieWriteConfig config, String commitTime, HoodieTable<T, I, K, O> hoodieTable,
String partitionPath, String fileId, TaskContextSupplier taskContextSupplier) {
super(config, c... | [HoodieBootstrapHandle->[addMetadataFields,of]] | Checks if a Hoodie record can be written. | @bvaradar : can you confirm that this change looks good. |
@@ -1010,7 +1010,15 @@ func (b *cloudBackend) GetLatestConfiguration(ctx context.Context,
return nil, err
}
- return b.client.GetLatestConfiguration(ctx, stackID)
+ cfg, err := b.client.GetLatestConfiguration(ctx, stackID)
+ switch {
+ case err == client.ErrNoPreviousDeployment:
+ return nil, backend.ErrNoPrevi... | [GetStack->[GetStack],RenameStack->[RenameStack],createAndStartUpdate->[Name],Close->[Close],GetLogs->[GetStack],CloudConsoleURL->[CloudURL],tryNextUpdate->[CloudURL],CancelCurrentUpdate->[GetStack],GetLatestConfiguration->[GetLatestConfiguration],GetStackTags->[GetStack],DecryptValue->[DecryptValue],Read->[Read],GetSt... | GetLatestConfiguration retrieves the latest configuration for the given stack. | This is a little odd - why can't `GetLatestConfiguration` return `backend.ErrNoPreviousDeployment` itself? Is this due to some module circularity issue? |
@@ -0,0 +1,8 @@
+// Copyright (c) 2019, Frappe Technologies and contributors
+// For license information, please see license.txt
+
+frappe.ui.form.on('Contact Email', {
+ // refresh: function(frm) {
+
+ // }
+});
| [No CFG could be retrieved] | No Summary Found. | delete this file... |
@@ -324,6 +324,11 @@ namespace Microsoft.Xna.Framework.Graphics
}
}
+ /// <summary>
+ /// Blend factor for alpha blending.
+ /// </summary>
+ public Color BlendFactor { get { return _blendFactor; } set { _blendFactor = value; } }
+
public BlendState BlendStat... | [GraphicsDevice->[SetRenderTarget->[SetRenderTarget],DrawUserPrimitives->[DrawUserPrimitives],DrawIndexedPrimitives->[DrawIndexedPrimitives],ApplyRenderTargets->[Clear],Dispose->[Clear,Dispose],SetIndexBuffer,Initialize]] | Sets the color state of the color system. Get the actual blend state object. | This won't work. You can change the blend factor here yet the blend state won't reapply until `_blendStateDirty` is set to true. |
@@ -0,0 +1,17 @@
+module DataUpdateScripts
+ class UpdateEachArticlesPrivilegedUserPointCount
+ def run
+ # This code is "idempotent" in that it's calculating and caching a value stored elsewhere.
+ Article.find_in_batches do |articles|
+ articles.each do |article|
+ # Given that we have a... | [No CFG could be retrieved] | No Summary Found. | Wondering about a guard clause to not do this if the column doesn't exist. |
@@ -276,6 +276,8 @@ public abstract class HudsonTestCase extends TestCase implements RootAction {
*/
protected File explodedWarDir;
+ private boolean origDefaultUseCache = true;
+
protected HudsonTestCase(String name) {
super(name);
}
| [HudsonTestCase->[buildAndAssertSuccess->[assertBuildStatusSuccess],configureMaven31->[configureDefaultMaven],runTest->[runTest],createMavenProject->[createMavenProject],configureMaven3->[configureDefaultMaven],assertBuildStatusSuccess->[assertBuildStatus,assertBuildStatusSuccess],createOnlineSlave->[createSlave,create... | Provides a base class for all of the basic test cases. This method is called by the test code to clean up the legacy instance list. | I generally do not bother patching `HudsonTestCase` any more, especially after most of its usages have already been fixed in core to be `JenkinsRule`, but since you have already done the work |
@@ -388,7 +388,7 @@ public class StatPanel extends AbstractStatPanel {
data[row][col] = "-";
}
}
- final Iterator<TechAdvance> advances = TechTracker.getCurrentTechAdvances(pid, m_data).iterator();
+ final Iterator<TechAdvance> advances = TechTracker.getCurrentTe... | [StatPanel->[initLayout->[print->[print]],setGameData->[setGameData],TechTableModel->[getValueAt->[update],update->[clearAdvances]],getIcon->[getIcon],StatTableModel->[getValueAt->[loadData]],fillPlayerIcons->[getIcon]]] | Update the data based on the current state of the game. | Checkstyle: "Line is longer than 120 characters (found 125)." |
@@ -198,11 +198,16 @@ func (iter *evalSourceIterator) forkRun(opts Options) {
DryRun: iter.src.dryRun,
Parallel: opts.Parallel,
})
+
+ if err == nil && progerr == "A97455BA-8A80-42A5-8639-53CD49E88D75" {
+ return result.Bail()
+ }
+
if err == nil && progerr != "" {
// If the ... | [getProvider->[getProviderReference],handleRequest->[newRegisterDefaultProviderEvent],ReadResource->[getDefaultProviderRef],Invoke->[getProvider,Invoke],getProviderReference->[getDefaultProviderRef],serve->[handleRequest],RegisterResource->[getDefaultProviderRef],serve] | forkRun runs the actual language plugin and waits for it to finish. This method is called when the program exits. It will return nil if the program exits. | Note: i'm only doing this now because my machine is failing to regen protobufs. This should actually just be a bool in the value that `langhost.Run` returns back (see the protobuf change lower in this file) i'll work with someone else on the team to be able to actually do this properly. |
@@ -295,8 +295,8 @@ func (k *Keyrings) GetSecretKeyWithStoredSecret(me *User, secretRetriever Secret
k.G().Log.Debug("- GetSecretKeyWithStoredSecret() -> %s", ErrToOk(err))
}()
ska := SecretKeyArg{
- All: true,
- Me: me,
+ Me: me,
+ KeyType: AllSecretKeyTypes,
}
var skb *SKB
skb, _, err = k.GetSe... | [GetSecretKeyWithPassphrase->[GetSecretKeyLocked],GetSecretKeyWithPrompt->[GetSecretKeyLocked],GetLockedLocalSecretKey->[LoadSKBKeyring],LoadSKBKeyring->[SKBFilenameForUser],GetSecretKeyWithStoredSecret->[GetSecretKeyLocked]] | GetSecretKeyWithStoredSecret returns a secret key that is stored in the secretRetriever. If. | This can be DeviceKeyType since it's the only one where the stored secret makes sense |
@@ -145,3 +145,10 @@ func validatePeriodForGCP(d time.Duration) (err error) {
return nil
}
+
+func (c *config) Validate() error {
+ if c.Region == "" && c.Zone == "" {
+ return errors.New("region and zone in Google Cloud config file cannot both be empty")
+ }
+ return nil
+}
| [Fetch->[Wrapf,Logger,Metrics,Module,Event,eventMapping,Config],eventMapping->[timeSeriesGrouped,NewStackdriverMetadataServiceForTimeSeries,Wrap,Logger,Put],Beta,Seconds,MustAddMetricSet,New,Config,Module,WithCredentialsFile,UnpackConfig] | null - > null. | should we throw an error if both region and zone are provided? What would be the expected behavior there? |
@@ -340,6 +340,17 @@ export class Bookend {
this.toggle_(isActive);
}
+ /**
+ * Reacts to updates to whether sharing UIs may be shown, and updates the UI
+ * accordingly.
+ * @param {boolean} isActive
+ * @private
+ */
+ onCanShowSharingUisUpdate_(canShowSharingUis) {
+ this.getShadowRoot()
+ ... | [Bookend->[constructor->[storyRequestServiceV01,vsyncFor,create,storyStoreServiceV01],initializeListeners_->[BOOKEND_STATE,ESCAPE,preventDefault,DESKTOP_STATE,keyCode,throttle],buildReplayButton_->[buildReplayButtonTemplate,imageUrl,domainName,title,renderAsElement],getStoryMetadata_->[isArray,getAmpdoc,user,documentIn... | On Bookend State Update. | Nit: please wrap the toggle in a mutate block (here and in 1.0) |
@@ -738,7 +738,7 @@ public class AirBattle extends AbstractBattle {
private void removeFromDependents(final Collection<Unit> units, final IDelegateBridge bridge,
final Collection<IBattle> dependents, final boolean withdrawn) {
for (final IBattle dependent : dependents) {
- dependent.unitsLostInPrece... | [AirBattle->[finishBattleAndRemoveFromTrackerHeadless->[makeBattle],determineStepStrings->[canAttackerRetreat,canDefenderRetreat],getAirBattleRolls->[getAirBattleRolls],canDefenderRetreat->[shouldFightAirBattle,shouldEndBattleDueToMaxRounds],retreat->[recordUnitsWereInAirBattle],territoryCouldPossiblyHaveAirBattleDefen... | Remove the unit from the dependent battles. | This method can now be static. |
@@ -0,0 +1,15 @@
+package com.baeldung.reactiveLogging;
+
+import reactor.core.publisher.Flux;
+
+public class ReactiveLogging {
+
+ public static void main(String[] args) {
+ Flux<Integer> reactiveStream = Flux.range(1, 5)
+ .log()
+ .take(3);
+
+ reactiveStream.subscribe();
... | [No CFG could be retrieved] | No Summary Found. | In your article you have multiple examples, any chance we could have all of these included in the code |
@@ -21,6 +21,12 @@ class SuluContentContentNavigation extends ContentNavigation
$this->setName('Content');
+ $this->addNavigationItem($this->getContent());
+
+ $this->addNavigationItem($this->getSeo());
+ $this->addNavigationItem($this->getExcerpt());
+
+ $this->addNavigationIte... | [SuluContentContentNavigation->[generate->[getContent,getSettings,getExcerpt,getSeo]]] | This method is called when the content object is not initialized. | Why the inconsistent spacing? |
@@ -71,7 +71,7 @@ public class GobblinServiceFlowExecutionResourceHandler implements FlowExecution
}
@Override
- public UpdateResponse resume(ComplexResourceKey<FlowStatusId, EmptyRecord> key) {
+ public void resume(ComplexResourceKey<FlowStatusId, EmptyRecord> key) {
String flowGroup = key.getKey().getF... | [GobblinServiceFlowExecutionResourceHandler->[getLatestFlowExecution->[getLatestFlowExecution],get->[get]]] | Resumes a flow. | What's the reason to use ComplexResourceKey<FlowStatusId, EmptyRecord> instead of FlowStatusId directly? |
@@ -354,6 +354,7 @@ public class NiFiProperties extends ApplicationProperties {
public static final String DEFAULT_SECURITY_USER_SAML_HTTP_CLIENT_TRUSTSTORE_STRATEGY = "JDK";
public static final String DEFAULT_SECURITY_USER_SAML_HTTP_CLIENT_CONNECT_TIMEOUT = "30 secs";
public static final String DEFAULT_... | [NiFiProperties->[getFlowConfigurationArchiveMaxTime->[getProperty],getClusterStateProviderId->[getProperty],createBasicNiFiProperties->[size->[size],getProperty->[getProperty],createBasicNiFiProperties,NiFiProperties],getQuestDbStatusRepositoryPath->[getProperty],getEmbeddedZooKeeperPropertiesFile->[getProperty],getHt... | This method is used to set the default values for all cluster properties. This method is used to set the default values for the cluster node protocol threads and flow election. | Maybe usage of ISO 8601 intervals could be part of the NiFi 2.0 date/time effort? |
@@ -97,11 +97,13 @@ func (e *httpEndpoint) Run(ctx v2.Context, publisher stateless.Publisher) error
}
handler := &httpHandler{
- log: log,
- publisher: publisher,
- messageField: e.config.Prefix,
- responseCode: e.config.ResponseCode,
- responseBody: e.config.ResponseBody,
+ log: ... | [Run->[ListenAndServeTLS,Infof,Close,WithFunc,NewServeMux,Errorf,ListenAndServe,With,HandleFunc],Test->[Close,Listen],BuildModuleClientConfig,Unpack,NewInputManager,Sprintf,Validate,LoadTLSServerConfig] | Run starts the HTTP endpoint. | Canonicalize the configured headers somewhere during initialization so that you don't need to repeat the operation for every request. |
@@ -85,9 +85,15 @@ class UserUpdater
save_options = false
- # special handling for theme_key cause we need to bump a sequence number
- if attributes.key?(:theme_key) && user.user_option.theme_key != attributes[:theme_key]
- user.user_option.theme_key_seq += 1
+ # special handling for theme_id cau... | [UserUpdater->[update_muted_users->[empty?,pluck,now,exec,destroy_all,id],format_url->[blank?],update->[fetch,transaction,custom_fields,has_key?,log_name_change,dismissed_banner_key,name,sso_overrides_bio,trigger,location,exists?,theme_key,enable_sso,bio_raw,to_s,profile_background,badge_granted_title,batch_set,key?,we... | Updates the user with the given attributes. find next node in user chain. | wait why do we need another guardian here if the code above already defines one? |
@@ -218,6 +218,17 @@ describe('BrowserWindow module', function () {
w.loadURL('http://127.0.0.1:11111')
})
+ it('should emit did-fail-load event for URL exceeding character limit', function (done) {
+ w.webContents.on('did-fail-load', function (event, code, desc, url, isMainFrame) {
+ asser... | [No CFG could be retrieved] | This function is used to test if a page is loaded and if it is not it will load iframes on did - fail - load handler. | Looks like this could be `const` |
@@ -126,6 +126,8 @@ public class OMKeyDeleteRequest extends OMKeyRequest {
if (omKeyInfo == null) {
throw new OMException("Key not found", KEY_NOT_FOUND);
}
+ // Set the UpdateID to current transactionLogIndex
+ omKeyInfo.setUpdateID(transactionLogIndex);
// Update table cache.... | [OMKeyDeleteRequest->[preExecute->[build,getKeyArgs,checkNotNull,getDeleteKeyRequest,now,setModificationTime],validateAndUpdateCache->[acquireWriteLock,getUserInfo,getDeleteKeyRequest,OMKeyDeleteResponse,setFlushFuture,getVolumeName,getMetrics,createErrorOMResponse,checkKeyAcls,getBucketName,add,auditLog,getOzoneKey,in... | This method checks if the object key is in the cache and updates the cache if it is This method is called when a key is deleted from the database. It will return a response. | I think, we don't need to set updateID, as we delete this entry from KeyTable anyway. (As we set Optional.absent() below, which will be deleted from OM DB eventually when double buffer picks). Or is there any scenario by setting this helps. Example: Create key Key1 - 1, Delete Key Key1 - 2 Create Key Key1 (again) - 3 N... |
@@ -1062,7 +1062,7 @@ int main(void) {
#if !defined(NO_USB_STARTUP_CHECK)
if (USB_DeviceState == DEVICE_STATE_Suspended) {
print("[s]");
- while (USB_DeviceState == DEVICE_STATE_Suspended) {
+ if (USB_DeviceState == DEVICE_STATE_Suspended) {
suspend_power_do... | [No CFG could be retrieved] | The main function of the nagios module. This function is called from the constructor of the nec_usb_config struct. It. | This should be reverted |
@@ -76,8 +76,8 @@ void Thymio2AsebaHub::connectionCreated(Dashel::Stream *stream) {
}
void Thymio2AsebaHub::incomingData(Dashel::Stream *stream) {
- uint16 temp;
- uint16 len;
+ unsigned short int temp;
+ unsigned short int len;
stream->read(&temp, 2);
len = bswap16(temp);
| [connectionCreated->[closeStream,substr,getTargetName,find_first_of],AsebaGetBuffer->[memcpy,size],AsebaSendBuffer->[bswap16,getFailReason,write,flush],stream->[AsebaVMInit,size,resize,str,abort,what],AsebaAssert->[AsebaVMInit],incomingData->[size,resize,bswap16,read,AsebaProcessIncomingEvents],sendEvents->[AsebaVMRun,... | This is a private method for handling incoming events from a Thymio2Aseba. | Was it possible to include `#include <stdint.h>`? |
@@ -396,7 +396,12 @@ export class Resource {
* @return {!../layout-rect.LayoutRectDef}
*/
getLayoutBox() {
- return this.layoutBox_;
+ if (!this.isFixed_) {
+ return this.layoutBox_;
+ }
+ const viewport = this.resources_.getViewport();
+ return moveLayoutRect(this.layoutBox_, viewport.ge... | [No CFG could be retrieved] | Determines if the element has been measured. Checks if the element s layout box overlaps with the specified rect. | Hmm. This is a bit troublesome. The definition of the `getLayoutBox` is that it doesn't change based on the scroll state. We are de-facto changing it here. I'm not sure what downstream issues we maybe expecting from this. The truth is, of course, that fixed element's layout box doesn't change but defined within another... |
@@ -273,9 +273,10 @@ def plot_projs_topomap(projs, layout=None, cmap=None, sensors=True,
if not isinstance(layout, (list, tuple)):
raise TypeError('layout must be an instance of Layout, list, '
'or None, got %s' % (type(layout),))
- if not all(isinstance(l, Layo... | [_init_anim->[set_values,_check_outlines,_hide_frame,_autoshrink,_GridData,_draw_outlines],plot_ica_components->[plot_ica_components,_check_outlines,_prepare_topo_plot,_add_colorbar,plot_topomap,_autoshrink],plot_arrowmap->[_trigradient,_prepare_topo_plot,plot_topomap,_check_outlines],_plot_topomap->[set_locations,_che... | Plot a topographic map of the SSP projections. Plots a single . Plot a list of layout - all entries in layout. Find a missing - layout - based . Plot a topomap plot of the data and the n - ary layout. | Fix: Give more informative error |
@@ -27,11 +27,11 @@ def home(request):
updates = list(Bundle.objects.recent_entries(SECTION_HACKS.updates)[:5])
default_filters = Filter.objects.default_filters()
-
context = {
'updates': updates,
'default_filters': default_filters,
}
+
return render(request, 'landing/homepa... | [robots_txt->[HttpResponse,get_host],FaviconRedirect->[get_redirect_url->[favicon_url]],contribute_json->[serve],home->[list,recent_entries,render,default_filters],maintenance_mode->[redirect,render],promote_buttons->[render],ratelimit] | Home page. | Need to rebase away this whitespace change |
@@ -28,15 +28,17 @@ import org.rstudio.studio.client.common.AutoGlassPanel;
import org.rstudio.studio.client.common.GlobalDisplay;
import org.rstudio.studio.client.common.Timers;
import org.rstudio.studio.client.common.GlobalDisplay.NewWindowOptions;
+import org.rstudio.studio.client.common.dependencies.DependencyMa... | [TutorialPane->[back->[back],onLoad->[onFrameLoaded],onFrameLoaded->[onTutorialLoaded,onPageLoaded,getUrl],forward->[forward],getUrl->[getUrl],runTutorial->[launchTutorial],installLearnr->[invoke->[onConsolePrompt->[onError->[onError]]]],addLoadHandler->[addLoadHandler],onThemeChanged->[onFrameLoaded]]] | Imports the methods defined in the WComponent. export GWT. Handler. | nit: update copyright year in header |
@@ -1167,6 +1167,8 @@ define([
var frameState = scene._frameState;
frameState.commandList.length = 0;
frameState.shadowMaps.length = 0;
+ frameState.brdfLUT = scene._brdfLUT._colorTexture;
+ frameState.cubeMap = scene._cubeMap;
frameState.mode = scene._mode;
fr... | [No CFG could be retrieved] | Defines the environment variables that are used to render the object. The drawing buffer of the underlying GL context. | Add a getter for `colorTexture` inside `BrdfLutProcessor` so we don't access a private variable. |
@@ -2418,14 +2418,16 @@ class SemanticAnalyzer(NodeVisitor):
# Helpers
#
- def lookup(self, name: str, ctx: Context) -> SymbolTableNode:
+ def lookup(self, name: str, ctx: Context, include_globals: bool = True,
+ report: bool = True) -> SymbolTableNode:
"""Look up an unqualified... | [SemanticAnalyzer->[analyze_comp_for->[analyze_lvalue],build_newtype_typeinfo->[named_type],build_typeddict_typeinfo->[named_type,basic_new_typeinfo,object_type,named_type_or_none],visit_for_stmt->[visit_block,visit_block_maybe,analyze_lvalue],add_var->[is_func_scope,qualified_name],add_symbol->[is_func_scope],visit_im... | Look up an unqualified name in all active namespaces. | Would be nice to explain in the docstring what the new Boolean arguments mean. |
@@ -1270,8 +1270,8 @@ function $RootScopeProvider() {
// yes, this code is a bit crazy, but it works and we have tests to prove it!
// this piece should be kept in sync with the traversal in $digest
// (though it differs due to having the extra check for $$listenerCount)
- if (... | [No CFG could be retrieved] | The next event is the next event that is triggered by the given target. Initializes a new phase. | Maybe it should split that complicated expression into more `if`s? But then it will be completely different than traversal in `$digest` |
@@ -152,8 +152,16 @@ def _GetSvdOpTest(dtype_, shape_, use_static_shape_):
# dimension that is equal to one
s_np = np.reshape(s_np, s_tf_val.shape)
+ #print("expected S:", s_np)
+ #print("actual S:", s_tf_val)
+
CompareSingularValues(self, s_np, s_tf_val)
... | [_GetSvdOpTest->[Test->[CheckApproximation,CheckUnitary,CompareSingularVectors,CompareSingularValues]],_GetSvdOpTest] | Returns a function that tests if a missing value is found in the SVD. Compute missing values in the system. Check if a single node in x_np is missing a n - node error. The nanomatch value. | get rid of cruft |
@@ -740,7 +740,8 @@ typedef enum PROTOCOL_choice {
PROTO_XMPP_SERVER,
PROTO_CONNECT,
PROTO_IRC,
- PROTO_POSTGRES
+ PROTO_POSTGRES,
+ PROTO_LDAP,
} PROTOCOL_CHOICE;
static const OPT_PAIR services[] = {
| [No CFG could be retrieved] | Enumerate all known protocol - specific values. Reads the specified key from the system and stores it in the specified destination. | Remove that comma, please |
@@ -507,14 +507,13 @@ abstract class AbstractEpollChannel extends AbstractChannel implements UnixChann
}
@Override
- protected void flush0() {
+ protected final void flush0() {
// Flush immediately only when there's no pending flush.
// If there's a pending fl... | [AbstractEpollChannel->[modifyEvents->[isOpen],newDirectBuffer->[newDirectBuffer],doDisconnect->[doClose],doConnect->[checkResolvable],doConnect0->[setFlag,doClose,connect],doBind->[checkResolvable],doBeginRead->[setFlag,config],isOpen->[isOpen],isAllowHalfClosure->[isAllowHalfClosure],AbstractEpollUnsafe->[epollOutRea... | Flush immediately only if there s no pending flush operation. | @Scottmitch seems like the code is now basically the same as before here... Consider revert the change of the file ? Seems like the only change that is "new" is the final keyword |
@@ -62,6 +62,7 @@ def get_nodes(ids, graphene_type=None):
break
nodes = list(graphene_type._meta.model.objects.filter(pk__in=pks))
+ nodes.sort(key=lambda e: pks.index(str(e.pk))) # preserve order in pks
if not nodes:
raise GraphQLError(
error_msg % ids)
| [filter_by_query_param->[filter,format,Q],get_nodes->[,list,from_global_id,append,len,str,filter,GraphQLError,set,items,format],reporting_period_to_date->[replace,now,ValueError],filter_by_period->[filter,reporting_period_to_date],get_database_id->[AssertionError,get_type,from_global_id],format_permissions_for_display-... | Get a list of nodes with the given ids. | Wouldn't using `order_by` on the query set achieve the same? I also think that this evaluation to list could be removed (it's iterated over under this if) and `nodes.exists()` should be much quicker than `bool(list(nodes))`? Unless I'm missing something here. |
@@ -669,9 +669,9 @@ class Protocol < ApplicationRecord
def update_linked_children
# Increment/decrement the parent's nr of linked children
- if self.parent_id_changed?
- if self.parent_id_was != nil
- p = Protocol.find_by_id(self.parent_id_was)
+ if self.saved_change_to_parent_id?
+ if ... | [Protocol->[deep_clone->[clone_contents],destroy_contents->[space_taken],clone_contents->[deep_clone_assets],space_taken->[space_taken],in_repository?->[in_repository_active?],load_from_repository->[clone_contents],update_parent->[clone_contents],update_from_parent->[clone_contents],deep_clone_my_module->[new_blank_for... | Update the nr of linked children by incrementing the nr of linked children and decrementing the. | Redundant self detected. |
@@ -354,9 +354,13 @@ public abstract class WriteFiles<UserT, DestinationT, OutputT>
PCollection<FileResult<DestinationT>> tempFileResults =
(getComputeNumShards() == null && getNumShardsProvider() == null)
- ? input.apply(
- "WriteUnshardedBundlesToTempFiles",
- ... | [WriteFiles->[withMaxNumWritersPerBundle->[build],WriteUnshardedBundlesToTempFiles->[expand->[getMaxNumWritersPerBundle]],withShardingFunction->[build],ApplyShardingFunctionFn->[processElement->[assignShardKey,getNumShardsProvider]],getDynamicDestinations->[getDynamicDestinations],WriteShardsIntoTempFilesFn->[processEl... | Expands the given PCollection into a new collection of files. Write all sharded bundles to temp files and return a sequence of all temp files. | Probably we should check that auto-sharding is explicitly enabled by performing this call ? |
@@ -0,0 +1,11 @@
+class RssReaderFetchUserWorker
+ include Sidekiq::Worker
+
+ sidekiq_options queue: :medium_priority
+
+ def perform(user_id)
+ user = User.find_by(id: user_id)
+
+ RssReader.new.fetch_user(user) if user&.feed_url.present?
+ end
+end
| [No CFG could be retrieved] | No Summary Found. | Good call not limiting the retries since this is making external requests to another service |
@@ -44,6 +44,7 @@ class Binutils(AutotoolsPackage, GNUMirrorPackage):
variant('interwork', default=False, description='Enable interwork.')
variant('libs', default='shared,static', values=('shared', 'static'),
multi=True, description='Build shared libs, static libs or both')
+ variant('static',... | [Binutils->[install->[working_dir,make],install_headers->[join_path,mkdirp,install,install_tree],setup_build_environment->[append_flags,satisfies],test->[str,run_test,format],flag_handler->[append,satisfies],configure_args->[append,enable_or_disable,satisfies],depends_on,conflicts,version,patch,when,variant,run_after]] | Returns a list of all possible version parameters. Config option for building shared libs static libs or both. | Should this only be applicable when `libs=static`? Should it default to True if they're static? Should it perhaps be rolled into the `libs` option? |
@@ -54,3 +54,7 @@ def send_payment_confirmation(order_pk):
def send_note_confirmation(order_pk):
email_data = collect_data_for_email(order_pk, CONFIRM_NOTE_TEMPLATE)
_send_confirmation(**email_data)
+
+
+def order_send_confirmation(order_pk):
+ send_order_confirmation.delay(order_pk)
| [send_order_confirmation->[collect_data_for_email,_send_confirmation],send_note_confirmation->[collect_data_for_email,_send_confirmation],send_payment_confirmation->[collect_data_for_email,_send_confirmation]] | Sends confirmation email for the given order. | Do you find this function useful? |
@@ -176,10 +176,11 @@ class HTTPServer(BaseHTTPServer.HTTPServer):
class HTTP01Server(HTTPServer, ACMEServerMixin):
"""HTTP01 Server."""
- def __init__(self, server_address, resources, ipv6=False):
+ def __init__(self, server_address, resources, ipv6=False, timeout=30):
+ # type: (Tuple[str, int], ... | [BaseRequestHandlerWithLogging->[handle->[handle,log_message]],simple_tls_sni_01_server->[serve_forever,TLSSNI01Server],HTTP01DualNetworkedServers->[__init__->[__init__]],TLSServer->[server_bind->[_wrap_sock,server_bind],__init__->[__init__]],TLSSNI01DualNetworkedServers->[__init__->[__init__]],HTTP01RequestHandler->[h... | Initialize a new HTTP server. | Would appreciate a hint on how I can get a mypy forward reference to `Set[HTTP01RequestHandler.HTTP01Resource]` instead of the current `Set[Any]` to work. |
@@ -77,7 +77,9 @@ internal static partial class Interop
string targetHost)
{
int ret = SSLStreamSetTargetHostImpl(sslHandle, targetHost);
- if (ret != SUCCESS)
+ if (ret == UNSUPPORTED_API_LEVEL)
+ throw new PlatformNotSupportedException("The opera... | [Interop->[AndroidCrypto->[SSLStreamGetPeerCertificates->[SSLStreamGetPeerCertificates],SSLStreamGetCipherSuite->[SSLStreamGetCipherSuite],SSLStreamSetApplicationProtocols->[SSLStreamSetApplicationProtocols],SSLStreamSetEnabledProtocols->[SSLStreamSetEnabledProtocols],SSLStreamGetApplicationProtocol->[SSLStreamGetAppli... | Sets the target host of the stream. | Should the message go in resources? |
@@ -276,7 +276,7 @@ function cron_poll_contacts($argc, $argv) {
$xml = false;
if($manual_id)
- $contact['last-update'] = '0000-00-00 00:00:00';
+ $contact['last-update'] = NULL_DATE;
if(in_array($contact['network'], array(NETWORK_DFRN, NETWORK_ZOT, NETWORK_OSTATUS)))
$contact['priority'] = 2;... | [cron_clear_cache->[get_basepath],cron_run->[maxload_reached,set_baseurl]] | This function is used to poll for contacts in a cron. This function is used to find all contacts that are blocked or not. This function will check if a site is frequent if it is desired by setting pushpoll This function is called by onecontact. | Standards: Can you please add braces to this condition? |
@@ -174,7 +174,8 @@ public abstract class AbstractHoodieWriteClient<T extends HoodieRecordPayload, I
String commitActionType, Map<String, List<String>> partitionToReplaceFileIds) {
// Create a Hoodie table which encapsulated the commits and files visible
HoodieTable table = creat... | [AbstractHoodieWriteClient->[rollbackInflightCompaction->[rollback],startCommitWithTime->[startCommitWithTime,startCommit],inlineCluster->[scheduleClustering,cluster],startCommit->[startCommit],restoreToSavepoint->[createTable],commitStats->[commit,commitStats],close->[close],scheduleTableServiceInternal->[scheduleClus... | Commit the stats. | so switching to `config.getWriteSchema()` here, would affect hive sync? We use the schema from the commit file to sync to hive. So if the write schema is a subset of the table schema, then we can have an issue here. Did you run into any issues like that? I think we could actually write both into the commit metadata.? |
@@ -44,7 +44,13 @@ export class AmpExperiment extends AMP.BaseElement {
const config = this.getConfig_();
const results = Object.create(null);
const variants = Object.keys(config).map(experimentName => {
- return allocateVariant(this.getWin(), config[experimentName])
+ assertName(experimentName... | [No CFG could be retrieved] | Provides a simple simple AMP - like view of a single node. Adds the given experiment and variant pairs to the body element. | Instead of modifying the object, we could just pass the `grouping` into `allocateVariant`. |
@@ -60,7 +60,7 @@ const (
func New(h p2p.Host, rendezvous p2p.GroupID, peerChan chan p2p.Peer, bootnodes utils.AddrList) *Service {
var cancel context.CancelFunc
ctx, cancel = context.WithTimeout(context.Background(), connectionTimeout)
- dataStore, err := badger.NewDatastore(fmt.Sprintf(".dht-%s-%s", h.GetSelfPee... | [DoService->[Str,FindPeers,findPeers,Msg,Error,NewTicker,Limit,Advertise,Info,Sleep,Err,Logger],findPeers->[ID,IsGlobalUnicast,Msg,Error,Warn,Interface,IsPrivateIP,Sprintf,Contains,Connect,String,GetP2PHost,ParseCIDR,ToNetAddr,Info,Err,Logger],Init->[Warn,GetP2PHost,Info,Done,Add,Int,Bootstrap,Connect,Advertise,Errorf,... | New creates a new service. StartService initializes the service and starts the main loop. | why add a nil for a string format value at all? |
@@ -0,0 +1,15 @@
+import React from "react";
+import { Collapsible } from "yoast-components";
+
+/**
+ * Sidebar Collapsible component with default padding and separator
+ *
+ * @param {object} props The properties for the component.
+ *
+ * @returns {ReactElement} The Collapsible component.
+ */
+const SidebarCollapsi... | [No CFG could be retrieved] | No Summary Found. | `object` should be `Object`. |
@@ -140,6 +140,8 @@ namespace Content.Server.GameTicking
SetStartPreset(_configurationManager.GetCVar(CCVars.GameLobbyDefaultPreset));
+ _roundInitializedTimeUtc = DateTime.UtcNow;
+
RestartRound();
_initialized = true;
| [GameTicker->[ToggleDisallowLateJoin->[UpdateLateJoinStatus],SetStartPreset->[SetStartPreset,TryGetPreset,StartRound],SpawnPlayer->[SpawnPlayer,ApplyCharacterProfile,MakeObserve],Initialize->[Initialize],PlayerStatusChanged->[PlayerStatusChanged],TogglePause->[PauseStart],StartRound->[RestartRound,ReqWindowAttentionAll... | Initialize method. | When you've changed `_roundInitializedTimeUtc` to use `TimeSpan`, this should be set to `_gameTiming.RealTime`. |
@@ -50,4 +50,4 @@
<% end %>
<% end %>
-<%= render 'idv/doc_auth/back', action: 'cancel_link_sent' %>
+<%= render 'idv/doc_auth/back', action: 'cancel_link_sent', class: 'doc_capture_back_link' %>
| [No CFG could be retrieved] | Cancel link sent for the given . | I feel like we have been using more kebab case class names, should we kebab-case this and `doc_capture_continue_button_form` while we're here? (I don't feel strongly) |
@@ -1126,9 +1126,7 @@ void setup() {
*/
void loop() {
- for (;;) {
-
- idle(); // Do an idle first so boot is slightly faster
+ idle();
#if ENABLED(SDSUPPORT)
card.checkautostart();
| [No CFG could be retrieved] | This is the main loop of the Marlin program. It loops through the available commands. | The `for` loop is expected to perform better on AVR, if not on all platforms. |
@@ -647,6 +647,10 @@ func (s *Server) bootstrapCluster(req *pdpb.BootstrapRequest) (*pdpb.BootstrapRe
}, nil
}
+func (s *Server) appendToRootPath(key string) string {
+ return path.Join(s.rootPath, key)
+}
+
func (s *Server) createRaftCluster() error {
if s.cluster.IsRunning() {
return nil
| [SetLabelPropertyConfig->[SetLabelPropertyConfig],GetReplicationModeConfig->[GetReplicationModeConfig],campaignLeader->[createRaftCluster,Name,GetAllocator,stopRaftCluster],GetClusterVersion->[GetClusterVersion],SetClusterVersion->[SetClusterVersion],DeleteLabelProperty->[DeleteLabelProperty,SetLabelProperty],Close->[C... | bootstrapCluster is used to bootstrap a Raft cluster bootstrap failed - try to bootstrap the cluster. | How about moving it to `key_path.go`? |
@@ -16,7 +16,7 @@
See the License for the specific language governing permissions and
limitations under the License.
-%>
-import { browser, element, by, ExpectedConditions as ec } from 'protractor';
+import { browser, element, by, ExpectedConditions } from 'protractor';
import { NavBarPage, SignInPage<%_ if (au... | [No CFG could be retrieved] | Reads an object from the page object and imports it into the page objects. Missing element in page. | Why make this change? I prefer to type `ec` over `ExpectedConditions`. |
@@ -267,6 +267,9 @@ func (n ChainlinkRunner) Run(app chainlink.Application) error {
mode = gin.DebugMode
}
gin.SetMode(mode)
+ gin.DebugPrintRouteFunc = func(httpMethod, absolutePath, handlerName string, nuHandlers int) {
+ app.GetLogger().Debugf("%-6s %-25s --> %s (%d handlers)", httpMethod, absolutePath, hand... | [Patch->[doRequest],Cookie->[Retrieve],Delete->[doRequest],cookiePath->[Join,RootDir],Retrieve->[IsNotExist,Append,ReadFile,New,Cookies,cookiePath,Add],Put->[doRequest],Save->[cookiePath,String,WriteFile],Post->[doRequest],NewApplication->[NewExternalInitiatorManager,SetDB,Eth,DatabaseBackupMode,Wrap,ORMMaxIdleConns,Is... | Run runs the chainlink application. | Moved from init so we can use injected logger. |
@@ -250,7 +250,7 @@ class Stage(params.StageParams):
def changed_stage(self, warn=False):
changed = self.md5 != self.compute_md5()
if changed and warn:
- logger.debug("DVC-file '{}' changed.".format(self.relpath))
+ logger.debug(self._changed_stage_entry())
return c... | [create_stage->[loads_from],Stage->[_status->[status,update],relpath->[relpath],remove->[unprotect_outs,remove,remove_outs],_status_stage->[changed_stage],check_can_commit->[changed_stage,save,_changed_entries],get_all_files_number->[_filter_outs],get_used_cache->[get_used_cache,_filter_outs,update],compute_md5->[compu... | Check if the DVC file has changed. | As we have this on debug, we can make it as `md5 of stage: foo.dvc changed.`. |
@@ -322,6 +322,17 @@ class Parameters(object):
self.set(name, arr.reshape(self.get_shape(name)))
def to_tar(self, f):
+ """
+ Save parameters to a tar file.
+
+ WARNING: Do not use this function to save parameters directly unless you
+ know exactly what you are doing. `pa... | [__copy_parameter_to_gradient_machine__->[__get_parameter_in_gradient_machine__],Parameters->[keys->[keys],__setitem__->[get_shape],to_tar->[names,serialize],names->[keys],init_from_tar->[get,names,set,from_tar],from_tar->[Parameters,deserialize,__append_config__,names],has_key->[keys],get_shape->[has_key],get_grad->[_... | Serialize the object to a tar file. | "unless you know exactly what you are doing. " ? |
@@ -152,3 +152,4 @@ public final class FixedRedisMessagePool implements RedisMessagePool {
return longToByteBufs.get(value);
}
}
+
| [FixedRedisMessagePool->[getByteBufOfInteger->[get],getInteger->[get],getSimpleString->[get],getError->[get],SimpleStringRedisMessage,unreleasableBuffer,unmodifiableBuffer,wrappedBuffer,IntegerRedisMessage,longToAsciiBytes,ErrorRedisMessage,FixedRedisMessagePool,getBytes,put]] | Get the byte buffer of the given integer. | nit: Could be removed |
@@ -38,6 +38,18 @@ def from_payment_app_id(app_gateway_id: str) -> Optional["PaymentAppData"]:
return None
+def from_shipping_app_id(app_shipping_method_id: str) -> Optional["ShippingAppData"]:
+ splitted_id = app_shipping_method_id.split(":")
+ if len(splitted_id) == 3 and splitted_id[0] == APP_ID_PREFI... | [parse_list_payment_gateways_response->[to_payment_app_id],from_payment_app_id->[PaymentAppData]] | Parse a list of payment gateways response. | Instead of repeating this if statement we could create function for that. In any case it will required only one place to change - easier to maintain in the future :) |
@@ -139,7 +139,10 @@ namespace Js
static char16 const funcName[] = _u("function anonymous");
static char16 const genFuncName[] = _u("function* anonymous");
static char16 const asyncFuncName[] = _u("async function anonymous");
- static char16 const bracket[] = _u(" {\012");
+ static char16 const ope... | [No CFG could be retrieved] | Determines if a function can be called with a reserved keyword. This function converts a javascript string like fml1 fml2 fml3 into a. | I can't decide whether I like \012 or \f better.. edit: \n |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.