patch
stringlengths
18
160k
callgraph
stringlengths
4
179k
summary
stringlengths
4
947
msg
stringlengths
6
3.42k
@@ -369,7 +369,7 @@ namespace System.IO case Interop.Error.EACCES: // match Win32 exception throw new IOException(SR.Format(SR.UnauthorizedAccess_IODenied_Path, sourceFullPath), errorInfo.RawErrno); default: - throw Interop.GetExc...
[FileSystem->[ReplaceFile->[LinkOrCopyFile],RemoveDirectoryInternal->[DeleteFile,RemoveDirectoryInternal],MoveFile->[LinkOrCopyFile,MoveFile,CopyFile],CopyFile->[CopyFile],LinkOrCopyFile->[CopyFile],GetLogicalDrives->[GetLogicalDrives]]]
Move a directory.
@tmds, you ok with this? Seems reasonable, if for no other reason than there are two paths involved and we're sort of arbitrarily picking one to include in the error.
@@ -73,7 +73,7 @@ func pods(cmd *cobra.Command, _ []string) error { if cmd.Flag("filter").Changed { psInput.Filters = make(map[string][]string) for _, f := range inputFilters { - split := strings.Split(f, "=") + split := strings.SplitN(f, "=", 2) if len(split) < 2 { return errors.Errorf("filter inp...
[ID->[Id],Less->[After],ContainerStatuses->[Join],Created->[HumanDuration,Since],ContainerNames->[Join],ContainerIds->[Join],InfraID->[InfraId],StringVar,PodPs,MarshalIndent,HasPrefix,Flush,New,AddLatestFlag,Errorf,NewWriter,Execute,StringSliceVarP,Sort,Split,Flag,Println,Background,ContainerEngine,Parse,BoolVarP,Flags...
pods is a command handler for the pod - related command. It is responsible for showing the PodPs runs the PodPs API and returns the last n - th pod.
nice fix, been bit by this elsewhere....
@@ -74,11 +74,12 @@ def test_force_anonymous_session_middleware(rf, settings): @pytest.mark.parametrize( 'host,key,expected', - (('beta', 'BETA_HOST', 'kuma.urls_beta'), - ('beta-origin', 'BETA_ORIGIN', 'kuma.urls_beta'), + (('beta', 'BETA_HOST', None), + ('wiki', 'WIKI_HOST', None), + ('beta-...
[test_slash_middleware_removes_slash->[response,get],test_restricted_whitenoise_middleware->[RestrictedWhiteNoiseMiddleware,append,object,get,middleware],test_restricted_endpoints_middleware->[hasattr,setattr,append,get,middleware,RestrictedEndpointsMiddleware],test_restricted_endpoints_middleware_when_disabled->[raise...
Test that a request has a restricted endpoint.
Note-to-Ryan: This test should be exclusively about the attachments (trusted/untrusted)
@@ -148,7 +148,7 @@ class _PandasFeedFn(object): num_epochs=None): if len(placeholders) != len(dataframe.columns) + 1: raise ValueError("Expected {} placeholders; got {}.".format( - len(dataframe.columns), len(placeholders))) + len(dataframe.columns), len(placeholders))) ...
[_ArrayFeedFn->[__call__->[range,OutOfRangeError],__init__->[len,format,ValueError,seed,randrange]],_PandasFeedFn->[__call__->[dict,OutOfRangeError,zip,range,index],__init__->[len,format,ValueError,seed,randrange]],enqueue_data->[as_dtype,size,scalar,FeedingQueueRunner,int,FIFOQueue,enqueue_many,range,name_scope,warnin...
Initializes the object with the given sequence of missing values.
4 space for continuation after opening param
@@ -203,7 +203,8 @@ func (a *apiServer) getEnterpriseTokenState() (enterpriseclient.State, error) { resp, err := pachClient.Enterprise.GetState(context.Background(), &enterpriseclient.GetStateRequest{}) if err != nil { - return 0, fmt.Errorf("could not get Enterprise status: %s", err.Error()) + return 0, fmt.E...
[GetACL->[LogResp,getEnterpriseTokenState,isAdmin,isActivated,LogReq],GetCapability->[isActivated,LogReq,LogResp],getEnterpriseTokenState->[getPachClient],GetScope->[LogResp,getEnterpriseTokenState,isAdmin,isActivated,LogReq],Authenticate->[isActivated,LogResp,getEnterpriseTokenState],Activate->[LogReq,LogResp,getEnter...
getEnterpriseTokenState returns the current state of the Pachyderm Enterprise token Activate admins.
Using `%s` with `.Error()` is an anti-pattern. You can use `%v` with the `error` type directly.
@@ -79,6 +79,13 @@ public class LogAttribute extends AbstractProcessor { .allowableValues("true", "false") .build(); + public static final PropertyDescriptor LOG_PREFIX = new PropertyDescriptor.Builder() + .name("Log prefix") + .required(false) + .descript...
[LogAttribute->[onTrigger->[processFlowFile,transferChunk]]]
The Log Level. Add log payload and attributes to the list of log descriptors.
Would be good to have this property support NiFi's Expression Language.
@@ -2286,7 +2286,8 @@ namespace System.Globalization if (GlobalizationMode.Invariant) return null!; - return ShouldUseUserOverrideNlsData ? NlsGetLocaleInfo(type) : IcuGetLocaleInfo(type); + // For ListSeparator on Windows, we don't call ICU as we fallback there to ...
[CultureData->[CreateCultureData->[NormalizeCultureName],GetSeparator->[UnescapeNlsString],DateSeparator->[ShortDates]]]
Get the locale info core for a given locale.
One of the goals for defaulting to use ICU was behavioral conformance across OSes; falling back to NLS here to fill in some of the data would seem to go against that goal. Is this something to be concerned about?
@@ -599,6 +599,10 @@ class WikiTablesDecoderStep(DecoderStep[WikiTablesDecoderState]): action_embedding = action_embeddings[group_index, action_embedding_index, :] production_rule = state.possible_actions[batch_index][action][0] new_grammar_state = state.grammar_state[...
[WikiTablesDecoderStep->[_get_action_embeddings->[new,max,size,len,get_mask_from_sequence_lengths,pad_sequence_to_length,Variable,index_select,view,score],_get_actions_to_consider->[considered_actions,max,append,embedded_actions,linked_actions,global_valid_actions,len,get_valid_actions,zip],take_step->[bmm,_dropout,_ge...
Computes the new states for the decoder. The actual action ID is the actual action ID. Get the next state in the state list.
And this one because `if state.checklist_state[group_index] is not None`, and you can remove the `else`.
@@ -258,11 +258,11 @@ public class ParamProcessWorker implements DispatchWorker { } } catch (final IllegalArgumentException e) { - s_logger.error("Error initializing command " + cmd.getCommandName() + ", field " + field.getName() + " is not accessible."); + ...
[ParamProcessWorker->[validateField->[validateNonEmptyString,validateNaturalNumber],translateUuidToInternalId->[validateNaturalNumber],processParameters->[validateField]]]
Process the parameters of the command which are required by the command. Checks if the given command is a key - value command and if so stores the object in Private method to check if the command has access to the entity.
Why do you need to log the stack trace twice? I mean, the exception is re-thrown as a cloudruntime. Wherever it is catch, it will probably be logged. In the Jira ticket you mention that the problem (confusion) is caused by the same message in the stack trace. Why not improve the messaging then, instead of logging print...
@@ -406,6 +406,8 @@ define([ }); } + var fsSource; + // Recompile shader when material changes if ((!this._outerMaterial || (this._outerMaterial !== this.outerMaterial)) || (!this._innerMaterial || (this._innerMaterial !== this.innerMaterial)) ||
[No CFG could be retrieved]
Creates a new VertexArray from the given VertexMesh. Draws a color source from the color source.
Perhaps it is just personal preference, but I wouldn't reuse this for two different shaders; it's not like we are setting this, and then doing something generic with it later. I'd just have separate ones for the color and pick passes. Then when JavaScript introduces the `let` keyword, we'll have block-level scope and b...
@@ -19,6 +19,9 @@ Rails.application.routes.draw do # Twilio Request URL for inbound SMS post '/api/sms/receive' => 'sms#receive' + # Image upload API for doc auth + post '/api/verify/upload' => 'idv/image_upload#upload' + post '/api/service_provider' => 'service_provider#update' match '/api/voice/otp' =...
[allow_piv_cac_login?,redirect,devise_scope,join,put,draw,root,scope,post,enable_usps_verification?,patch,devise_for,each,match,delete,namespace,disallow_ial2_recovery?,get,enable_test_routes]
Routing routes for the OpenID Connect API. Routes for a single user.
Sometimes we try to stick to built-in rails method names/actions to be "RESTful"<sup>1</sup> as much as we can, WDYT of renaming this to `#create`? --- 1. I think "RESTful" is kind of a garbage term and can mean anything... in this case I'm just saying let's use the default names in rails for CRUD verbs
@@ -60,7 +60,11 @@ import org.nuxeo.runtime.test.runner.RuntimeFeature; @Deploy("org.nuxeo.ecm.core.mimetype") public class TestMimetypeRegistryService { - public static final String APPLICATION_OCTET_STREAM = "application/octet-stream"; + /** + * @deprecated since 11.1. Use {@link MimetypeRegistry#DEFAUL...
[TestMimetypeRegistryService->[testGetMimetypeFromFile->[getMimetypeSample],testGetMimetypeFromBlob->[getMimetypeSample],testGetMimetypeFromFilenameWithBlobMimetypeFallback->[getMimetypeSample,getWordBlob],testGetMimetypeFromFilnameAndBlobWithDefault->[getMimetypeSample,getWordMLBlob,getWordBlob],testMimetypeRegistrati...
Package private for unit testing. Creates an instance of MimetypeEntry based on the given mimetypes.
If you deprecate, please update all uses of the deprecated constant. Yet, I think that we can safely remove the constant without deprecating it, and add a static import of `MimetypeRegistry.DEFAULT_MIMETYPE;`. To be checked with the other team members.
@@ -154,6 +154,15 @@ class Gcc(AutotoolsPackage): # See https://gcc.gnu.org/gcc-5/changes.html conflicts('languages=jit', when='@:4') + # NVPTX offloading supported by limited languages + conflicts('languages=ada', when='+nvptx') + conflicts('languages=brig', when='+nvptx') + conflicts('language...
[Gcc->[url_for_version->[Version,format],write_rpath_specs->[join_path,gcc,write,set_install_permissions,startswith,format,warn,open],spec_dir->[glob,format],setup_environment->[join_path,set],patch->[join_path,install,Version,isfile,filter_file,format,mkdirp],configure_args->[satisfies,append,Version,extend,format,joi...
Creates a new object. Find all the patch objects that are available on the system.
we might want to add that the `nvptx` variant only works with GCC 8.2.0 or newer?
@@ -57,6 +57,15 @@ Rails.application.configure do password: Rails.application.secrets.mailer_password } + + # Store uploaded files on the local file system (see config/storage.yml for options) + config.active_storage.service = ENV['ACTIVESTORAGE_SERVICE'] || :local + + # Don't care if the mailer can't send...
[perform_deliveries,mailer_reply_to,check_yarn_integrity,default_options,raise_delivery_errors,preview_path,enable_recaptcha,mailer_authentication,mailer_port,headers,enable_email_confirmations,new_team_on_signup,consider_all_requests_local,root,cache_classes,mailer_address,deprecation,allow_ip!,exist?,enabled,enable_u...
Configure the action_mailer. Allow Better Errors to work on trusted ip.
Layout/EmptyLines: Extra blank line detected.
@@ -456,7 +456,7 @@ function networkFlatView(App $a, $update = 0) $items = q("SELECT %s FROM `item` $sql_post_table %s WHERE %s AND `item`.`uid` = %d ORDER BY `item`.`id` DESC $pager_sql ", - item_fieldlists(), item_joins(), item_condition(), + item_fieldlists(), item_joins($_SESSION['uid']), item_condition()...
[networkThreadedView->[set_pager_page],networkPager->[set_pager_itemspage]]
This function renders the network tabs and views network conversation for network - new.
Why not `local_user()`?
@@ -1381,13 +1381,16 @@ def read_epochs(fname, proj=True, add_eeg_ref=True, verbose=None): epochs.tmax = tmax epochs.name = comment epochs.times = times - epochs.data = data + epochs._data = data epochs.proj = proj - epochs._projector, epochs.info = setup_proj(info, add_eeg_ref) + epochs...
[read_epochs->[Epochs],combine_event_ids->[copy],equalize_epoch_counts->[drop_epochs,drop_bad_epochs],Epochs->[equalize_event_counts->[drop_epochs,copy,_key_match,drop_bad_epochs],_get_data_from_disk->[_get_epoch_from_disk],to_nitime->[copy,get_data],resample->[resample],get_data->[_get_data_from_disk],next->[_is_good_...
Read a file of a specific nent of a file. Read a single n - term tag from the file and return it as a sequence of n Missing data - object.
do we really need this?
@@ -70,6 +70,10 @@ class XcodeDeps(object): self._conanfile = conanfile self.configuration = conanfile.settings.get_safe("build_type") self.architecture = conanfile.settings.get_safe("arch") + + if self.architecture == "armv8": + self.architecture = "arm64" # Xcode uses arm6...
[XcodeDeps->[_content->[_vars_xconfig_file,_conf_xconfig_file,_config_filename,_dep_xconfig_file,_all_xconfig_file]]]
Initialize the object with the given configuration and architecture.
We already have a conversion method, please check: `conan.tools.apple.apple.to_apple_arch`
@@ -1443,9 +1443,11 @@ public class Queue extends ResourceController implements Saveable { } // pending -> buildable for (BuildableItem p: lostPendings) { - LOGGER.log(Level.FINE, + if (LOGGER.isLoggable(Level.FINE)) { + ...
[Queue->[contains->[getItem],getApproximateItemsQuickly->[getItems],BuildableItem->[leave->[all],enter->[all,add],isStuck->[getEstimatedDuration,getAssignedLabel],getCauseOfBlockage->[isEmpty,getAssignedLabel,isBlockedByShutdown]],isBuildBlocked->[isBuildBlocked],getItems->[add],withLock->[call],BuildableRunnable->[run...
Maintains the queue. Checks if there are any items that are blocked and if so processes them. This method is called from the build - thread. It is called from the build - thread Checks if a task can be found in the list of candidates and if so executes it.
Avoid computing `getFullDisplayName` if we do not have to.
@@ -84,7 +84,6 @@ class ConvectionDiffusionSolver(PythonSolver): "input_type": "mdpa", "input_filename": "unknown_name" }, - "computing_model_part_name" : "thermal_computing_domain", "material_import_settings" :{ "materials_filename...
[ConvectionDiffusionSolver->[_ConvectionDiffusionVariablesCheck->[GetDefaultParameters],_create_convergence_criterion->[_get_convergence_criterion_settings],_create_builder_and_solver->[get_linear_solver],_execute_after_reading->[import_materials],Initialize->[Initialize],_create_line_search_strategy->[GetComputingMode...
Returns the default parameters of the KratosMultiphysics class. This default settings object contains all of the configuration options that are used by the network.
May be we can issue a deprecation warning here?
@@ -88,13 +88,14 @@ class AnnotationCategoriesController < ApplicationController last_editor_id: current_user.id ) + @assignment = Assignment.find(params[:assignment_id]) + @annotation_category = @annotation_text.annotation_category if @annotation_text.save flash_now(:success, t('annotat...
[AnnotationCategoriesController->[create_annotation_text->[new],destroy->[destroy],destroy_annotation_text->[destroy],update->[update],create->[new],update_annotation_text->[update],update_positions->[update]]]
create_annotation_text creates a new AnnotationText object and saves it to the database.
These instance variables aren't defined. But also, it's not clear to me that rendering `show` is the best option in this case. We can add a flash message though.
@@ -0,0 +1,17 @@ +package haconfig + +import ( + "io" + + kapi "github.com/GoogleCloudPlatform/kubernetes/pkg/api" +) + +type HAConfiguratorPlugin interface { + GetWatchPort() int + GetSelector() map[string]string + GetNamespace() string + GetService() *kapi.Service + Generate() *kapi.List + Create(out io.Writer) + Del...
[No CFG could be retrieved]
No Summary Found.
Call this package ipfailover
@@ -132,7 +132,7 @@ func (ds *decryptStream) readBlock(b []byte) (n int, lastBlock bool, err error) return n, false, err } -func (ds *decryptStream) tryVisibleReceivers(hdr *EncryptionHeader, ephemeralKey BoxPublicKey) (BoxSecretKey, BoxPrecomputedSharedKey, *SymmetricKey, int, error) { +func (ds *decryptStream) t...
[processEncryptionHeader->[tryHiddenReceivers,tryVisibleReceivers],readBlock->[Read],readHeader->[Read],readHeader]
readBlock reads a single block from the stream and returns the number of blocks read and whether symmetricKeyFromSlice - returns the symmetric key from the payloadKeySlice.
Previously we needed to compute a Box for each payload packet, as part of authentication. Now we compute an HMAC key once, and reuse it for each payload packet. There's no need to save the `beforenm` shared secret anymore, so I've removed it from the return signatures of these two functions.
@@ -53,7 +53,10 @@ def test_info_in_broken_git_repo(tmp_dir, dvc, scm, caplog): assert "Repo: dvc, git (broken)" in dvc_info -def test_caches(tmp_dir, dvc, caplog): +def test_caches(tmp_dir, dvc, caplog, mocker): + from dvc.tree.ssh import SSHTree + + mocker.patch.object(SSHTree, "exists", return_value=F...
[test_fs_info_in_repo->[search,get_dvc_info,mkdir],test_caches->[add_remote,search,edit,get_dvc_info],test_remotes_empty->[get_dvc_info],test_info_in_repo->[init,search,get_dvc_info,mkdir],test_remotes->[add_remote,search,get_dvc_info],test_info_in_subdir->[edit,init,chdir,mkdir,get_dvc_info],test_fs_info_outside_of_re...
Test that the cache is available on the remote server.
now that we will try to load a config file on remote connection, this has to be mocked out for these kinds of tests with a fake remote URL otherwise the test will hang until the network call times out
@@ -89,10 +89,12 @@ var ngIfDirective = ['$animate', function($animate) { compile: function (element, attr, transclude) { return function ($scope, $element, $attr) { var block, childScope; - $scope.$watch($attr.ngIf, function ngIfWatchAction(value) { - - if (toBoolean(value)) { - ...
[No CFG could be retrieved]
- transition - all cubic - bezier 0. 5s 0. 5s 0. 5.
$scope.$eval() will pretty much do this for you, but is it really important to re-$parse every $digest? that seems a bit like overkill since the expression is unlikely to change
@@ -805,7 +805,7 @@ export class AmpList extends AMP.BaseElement { this.positionObserver_.observe(this.container_, PositionObserverFidelity.LOW, ({positionRect, viewportRect}) => { - const ratio = 1.5; + const ratio = 3; if (this.loadMoreSrc_ && ...
[No CFG could be retrieved]
private private methods Provides a URL replacement policy for a given element.
This is a UI change to load items more aggressively.
@@ -1,6 +1,8 @@ # frozen_string_literal: true Rails.application.configure do + # Verifies that versions and hashed value of the package contents in the project's package.json + config.webpacker.check_yarn_integrity = false # Settings specified here will take precedence over those in config/application.rb. ...
[fetch,new,formatter,log_tags,lambda,consider_all_requests_local,asset_host,log_formatter,cache_classes,imgix,deprecation,r301,dump_schema_after_migration,logger,day,fallbacks,enabled,force_ssl,delivery_method,eager_load,default_url_options,service,present?,except,cache_store,perform_caching,split,custom_options,insert...
Configuration for a single application. Config for a single object.
Layout/IndentationWidth: Use 2 (not 4) spaces for indentation.
@@ -613,9 +613,9 @@ public class DagManager extends AbstractIdleService { } ExecutionStatus executionStatus = valueOf(jobStatus.getEventName()); long timeOutForJobStart = DagManagerUtils.getJobStartSla(node); - long jobStartTime = jobStatus.getStartTime(); + long jobOrchestrationTime = jo...
[DagManager->[DagManagerThread->[killJobIfOrphaned->[cancelDagNode],slaKillIfNeeded->[cancelDagNode],cleanUp->[hasRunningJobs,deleteJobState],onJobFinish->[submitNext],getRunningJobsCounter->[toString],cleanUpDag->[cleanUp]],setActive->[createDagStateStore,addDag],createJobStatusMonitor->[createJobStatusMonitor],handle...
Checks if the job is orphaned and kills it if it is.
jobOrchestrationTime -> jobOrchestratedTime.
@@ -0,0 +1,18 @@ +# Copyright (c) 2020 PaddlePaddle Authors. All Rights Reserved. +# +# Licensed under the Apache License, Version 2.0 (the "License"); +# you may not use this file except in compliance with the License. +# You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +...
[No CFG could be retrieved]
No Summary Found.
Better use absolute import, eg, `form paddle.fluid.contrib import mixed_precision `
@@ -19,14 +19,13 @@ import {dev, devAssert} from '#utils/log'; import {findIndex} from '#core/types/array'; import {isConnectedNode} from '#core/dom'; import {matches} from '#core/dom/query'; -import {getWin} from '#core/window'; import {userInteractedWith} from '../../../src/video-interface'; +import {isEnumValue}...
[No CFG could be retrieved]
Imports a specific marker type. A maker that creates a task that can be executed on a media element.
Using tag names directly now, `unsupported` was never required.
@@ -169,7 +169,7 @@ public class ProjectMeasuresIndex extends BaseIndex { .path(FIELD_MEASURES) .subAggregation( AggregationBuilders.filter("filter_" + metricKey) - .filter(termsQuery(FIELD_KEY, metricKey)) + .filter(termsQuery(FIELD_MEASURES_KEY, metricKey)) .subAggr...
[ProjectMeasuresIndex->[addFacets->[of,addRatingFacet,addAggregation,createStickyFacet,createQualityGateFacet,addRangeFacet,contains,isEmpty],search->[addFacets,createFilters,get,setQuery,addSort,boolQuery,forEach,subField],createFilters->[create,termsQuery,getKey,createQueryFilter,ifPresent,boolQuery,termQuery,forEach...
Create a range facet with the given metric key and thresholds.
why the renaming?
@@ -1408,11 +1408,7 @@ void GenericCAO::processMessage(const std::string &data) m_position = readV3F32(is); m_velocity = readV3F32(is); m_acceleration = readV3F32(is); - - if (std::fabs(m_prop.automatic_rotate) < 0.001f) - m_rotation = readV3F32(is); - else - readV3F32(is); + m_rotation = readV3F32(is);...
[getLightPosition->[v3f],clearParentAttachment->[setAttachment,v3f],clearChildAttachments->[setAttachment,v3f],updateLight->[getParent],step->[getSceneNode,update,removeFromScene,translate,v3f,addToScene,updateNodePos,getParent],processInitData->[updateNodePos,processMessage,init], ClientActiveObject->[getType],process...
Process a message received from the server. read a node s attributes read the frame data from the input stream read all the data for a specific animation read a single object from the network Updates the contents of the specified textures.
@SmallJoker Should this if-else block be restored as well?
@@ -49,8 +49,11 @@ var programTests = []programTest{ { Name: "aws-fargate", Description: "AWS Fargate", + + // TODO[pulumi/pulumi#8440] SkipCompile: codegen.NewStringSet("go"), - Skip: codegen.NewStringSet("go", "dotnet"), + + Skip: codegen.NewStringSet("dotnet"), }, { Name: "a...
[NewHost,HasPrefix,WriteFile,Add,Has,BindProgram,ReadFile,Skip,DecomposeToken,Join,Equal,NewParser,NoError,Fatalf,HasErrors,PluginHost,MkdirAll,ParseFile,NewStringSet,NewReader,GenProgram,Check,Getenv,Run,IsExist]
Package - level functions for testing the n - ary code. Returns a description of the last known node - type that is not available on the system.
So this is back to where master was, but now with a note linking that we have an issue. Go code does not compile here on master.
@@ -242,6 +242,10 @@ class GradientDescentTrainer(Trainer): precision training. Must be a choice of `"O0"`, `"O1"`, `"O2"`, or `"O3"`. See the Apex [documentation](https://nvidia.github.io/apex/amp.html#opt-levels-and-properties) for more details. If `None`, Amp is not used. Defaults to `None...
[GradientDescentTrainer->[_validation_loss->[batch_outputs],_train_epoch->[rescale_gradients,train,batch_outputs],train->[_validation_loss,_train_epoch]]]
Initialize a single object. Initializes the variables related to a single node of the AllenNLP model. The Pytorch object is stored in self. _pytorch_model and self.
We are trying to minimize the parameters that need to be passed directly to the trainer. I'm pretty sure you don't even need this, as you can just specify a `DataLoader`. Can you make your data loader class inherit from our `DataLoader`, and register it as something? In this PR, I'd like to see only modifications to da...
@@ -177,7 +177,7 @@ class PoolBuilder return $pool; } - private function loadPackage(Request $request, PackageInterface $package) + private function loadPackage(Request $request, PackageInterface $package, $propagateUpdate = true) { $index = count($this->packages); $this->pa...
[PoolBuilder->[loadPackage->[getRequires,setRootPackageAlias,getName,getConstraint,getAliasOf,setSourceDistReferences,getTarget,getConstraints,getVersion,isFixedPackage],buildPool->[getRequires,getName,dispatch,getUnacceptableFixedPackages,getRepository,getLockedRepository,matches,getFixedPackages,loadPackages,getPacka...
Builds a pool of packages that can be loaded from the given repositories. load packages that are not in the load list and have not yet been loaded from them Loads a package from the pool. get a name constraint that can be loaded.
I think this breaks due to the unset() in unfixPackage below? It'll start potentially reusing indices.
@@ -87,11 +87,9 @@ func newHandle(con *Container) *Handle { committed: false, Container: con, ExecConfig: *con.ExecConfig, - State: new(State), + state: StateUnknown, } - *h.State = con.State - handlesLock.Lock() defer handlesLock.Unlock()
[SetSpec->[Errorf],Create->[SetSpec,Error,Begin,Sprintf,NewLinuxGuest,New,Name,End,Spec,Errorf,LookupIP,Debugf],Commit->[SetSpec,Unix,Commit,MapSink,Now,UTC,OptionValueFromMap,Spec,Encode],Unlock,ReadFull,Begin,New,Remove,End,Lock,Errorf,String,Get,EncodeToString,Add]
ContainerCreateConfig defines the parameters for Create call. ReferenceFromHandle returns the reference of the given handle or nil if the handle is not a.
Shouldn't this be initialized to con.CurrentState()?
@@ -362,8 +362,6 @@ class _TimeViewer(object): # Direct access parameters: self.brain = brain self.brain.time_viewer = self - self.brain._save_movie = self.brain.save_movie - self.brain.save_movie = self.save_movie self.plotter = brain._renderer.plotter self.ma...
[_LinkViewer->[toggle_playback->[toggle_playback]],MplCanvas->[close->[close],show->[show],plot->[plot]],_TimeViewer->[clear_points->[remove_point],clean->[clear_points,close],configure_sliders->[set_slider_style,IntSlider,SmartSlider,BumpColorbarPoints,ShowView,TimeSlider,UpdateColorbarScale],_save_movie->[frame_callb...
Initialize the object with the given brain and optional show_traces. shows the last unknown node in the window.
Ahh, actually this could create a reference cycle that it has trouble resolving
@@ -180,10 +180,10 @@ class Jetpack_My_Community_Widget extends WP_Widget { /** This filter is documented in wp-includes/widgets/class-wp-widget-pages.php */ $title = apply_filters( 'widget_title', $title ); - echo $args['before_widget']; + echo $args['before_widget']; // phpcs:ignore WordPress.Security.Escap...
[Jetpack_My_Community_Widget->[form->[get_field_id,get_field_name],get_community->[fetch_remote_community],widget->[get_community]]]
This function is called when a widget is created.
I note wp-includes/widgets/class-wp-widget-pages.php referenced above does not escape `$title` either. Should we continue to match that behavior?
@@ -64,6 +64,11 @@ void UpdaterClass::_reset() { } bool UpdaterClass::begin(size_t size, int command, int ledPin, uint8_t ledOn) { +#if defined(ERASE_CONFIG_H) && !defined(HOST_MOCK) + // Empty call so erase_config.cpp module to ensure it is built and linked in. + enable_erase_config_at_link_time(); +#endif + ...
[No CFG could be retrieved]
Creates a THandler object from a given object. region Update Filesystem.
ERASE_CONFIG_H always defined, drop the condition (leaving host_mock)
@@ -87,7 +87,7 @@ class Jetpack_Core_Json_Api_Endpoints { register_rest_route( 'jetpack/v4', '/connection/user', array( 'methods' => WP_REST_Server::EDITABLE, 'callback' => __CLASS__ . '::unlink_user', - 'permission_callback' => __CLASS__ . '::link_user_permission_callback', + 'permission_callback' => __...
[Jetpack_Core_Json_Api_Endpoints->[build_connect_url->[build_connect_url]]]
Register all the REST routes that are used by the Jetpack API. Register WordPress REST routes for a WordPress connection This function is used to route a specific module to the core API. Register REST routes for the Jetpack Core API Module Data endpoint register REST routes for the administration interface.
From the pull summary, > Removes `Jetpack_Core_Json_Api_Endpoints::link_user_permission_callback` which is never used. Technically, this change stops using it in lieu of `Jetpack_Core_Json_Api_Endpoints::unlink_user_permission_callback` -- which had previously been unused, and then drops the formerly used one.
@@ -43,7 +43,12 @@ class GeneralizedRCNN(nn.Module): """ if self.training and targets is None: raise ValueError("In training mode, targets should be passed") - original_image_sizes = [img.shape[-2:] for img in images] + original_image_sizes = torch.jit.annotate(List[Tuple[in...
[GeneralizedRCNN->[forward->[backbone,update,rpn,ValueError,isinstance,postprocess,roi_heads,OrderedDict,transform],__init__->[super]]]
Forward computation of the RPN - RPN model.
nit: this works with pytorch `1.4.0.dev20191017`
@@ -274,17 +274,7 @@ class PTransformTest(unittest.TestCase): expected_error_prefix = 'FlatMap and ParDo must return an iterable.' self.assertStartswith(cm.exception.message, expected_error_prefix) - def test_do_fn_with_start_finish(self): - class MyDoFn(beam.DoFn): - def start_bundle(self): - ...
[PTransformLabelsTest->[test_apply_custom_transform_without_label->[CustomTransform],test_label_propogation->[MyDoFn,check_label],test_apply_custom_transform_with_label->[CustomTransform],test_default_labels->[MyDoFn,check_label],test_apply_ptransform_using_decorator->[SamplePTransform]],PTransformTypeCheckTestCase->[t...
This test requires that all the user - defined functions to return an iterable. This test also.
Should there be a test for the error case? (returning from start_bundle)
@@ -1622,7 +1622,7 @@ def save_config(): new_config['General']['config_version'] = CONFIG_VERSION new_config['General']['encryption_version'] = int(ENCRYPTION_VERSION) new_config['General']['encryption_secret'] = ENCRYPTION_SECRET - new_config['General']['log_dir'] = ACTUAL_LOG_DIR if ACTUAL_LOG_DIR e...
[start->[start],restart->[saveAll,initialize,halt],initialize->[restoreCache->[path_leaf],restoreCache,get_backlog_cycle_time]]
Save configuration of current node. This function returns a dictionary of all configuration values. This function is to be used to initialize the configuration. This function returns a new config object with all configuration values set.
why logs and not Logs?
@@ -53,6 +53,7 @@ plugins { id "org.liquibase.gradle" version "2.0.1" <%_ } _%> id "org.sonarqube" version "2.7" + id "org.asciidoctor.convert" version "1.5.9.2" //jhipster-needle-gradle-plugins - JHipster will add additional gradle plugins here }
[No CFG could be retrieved]
Repositories for the Unreal - bundled version of the plugin. The following functions are defined in the gradle package.
@sahbi-ktifa Can you please use version 1.6.1 so it is compatible with java 8+
@@ -14,7 +14,7 @@ from .constants import REST_TIME_OUT, TUNERS_SUPPORTING_IMPORT_DATA, TUNERS_NO_N def validate_digit(value, start, end): '''validate if a digit is valid''' if not str(value).isdigit() or int(value) < start or int(value) > end: - raise ValueError('%s must be a digit from %s to %s' % (v...
[update_concurrency->[update_experiment_profile,validate_digit],import_data->[load_search_space,validate_file,validate_dispatcher],update_experiment_profile->[get_query_type],update_trialnum->[update_experiment_profile,validate_digit],update_duration->[update_experiment_profile],update_searchspace->[update_experiment_p...
Validate that a digit is valid.
it is strange that you add quote on `value`
@@ -146,7 +146,9 @@ define([ case ComponentDatatype.DOUBLE: return Float64Array.BYTES_PER_ELEMENT; default: + //>>includeStart('debug', pragmas.debug); throw new DeveloperError('componentDatatype is not a valid value.'); + //>>includeEnd('debug'); ...
[No CFG could be retrieved]
Gets the ComponentDatatype for the provided TypedArray instance. if - if array is not a short array return the type of the array.
You can move this above the `default:`, since there's no reason to include it if it's empty.
@@ -11,9 +11,7 @@ namespace Sulu\Bundle\AdminBundle\ResourceMetadata\Form; -use Sulu\Bundle\AdminBundle\ResourceMetadata\ResourceMetadataInterface; - -interface FormInterface extends ResourceMetadataInterface +interface FormInterface { public function getForm(): Form; }
[No CFG could be retrieved]
Get the form of the form element.
Why doesn't it extends the `ResourceMetadataInterface` anymore?
@@ -10,6 +10,7 @@ from enum import IntEnum from functools import partial import numpy as np +from numpy.lib import NumpyVersion from llvmlite import ir import llvmlite.llvmpy.core as lc
[_fill_diagonal->[_fill_diagonal_params],_where_inner->[where_impl->[impl],determine_dtype],my_triu->[np_triu_impl_1d->[np_triu_impl_2d,_make_square]],_np_correlate->[impl->[_np_correlate_core],_assert_1d],_fill_diagonal_scalar->[_fill_diagonal_params],np_asarray->[_is_nonelike],_i0->[_chbevl],np_cov_impl_inner->[row_w...
Implementation of math operations on Array objects. Create a function that creates an empty int tuple.
Please use `from numba.numpy_support import version ` or some variant as you see fit.
@@ -35,7 +35,7 @@ def check_processes(dir=root_dir, verbose=True): ok = True curpid = os.getpid() for n in psutil.get_pid_list(): - if n == curpid: # The Python that conda is running is OK + if n == curpid: # The Python that conda is running is OK continue try: ...
[check_processes->[abspath,print,getpid,get_pid_list,join,Process,cmdline],main->[check_processes,confirm,exit],add_parser_yes,ArgumentParser,parse_args,main]
Check if there are processes running.
2 spaces instead of 4?
@@ -161,9 +161,9 @@ public class AsyncQueryForwardingServlet extends AsyncProxyServlet final String defaultHost = hostFinder.getDefaultHost(); request.setAttribute(HOST_ATTRIBUTE, defaultHost); - final boolean isQueryEndpoint = request.getRequestURI().startsWith("/druid/v2"); + final String requestURI...
[AsyncQueryForwardingServlet->[destroy->[destroy],service->[handleException,service],init->[init],rewriteURI->[rewriteURI],MetricsEmittingProxyResponseListener->[onComplete->[onComplete],onFailure->[onFailure]],createHttpClient->[createHttpClient],newProxyResponseListener->[newProxyResponseListener]]]
Service a single request. error message.
This kind of logic strikes me as something that should be able to be handled at a more abstract routing level. Have you had a chance to look for such items?
@@ -117,9 +117,11 @@ public class InputPathHandler { } } - private void tagAsIncrementalOrSnapshot(Path inputPath, String tableName, - HoodieTableMetaClient metaClient, List<String> incrementalTables) { - if (!incrementalTables.contains(tableName)) { + private void tagAsIncrementalOrSnapshot(Path in...
[InputPathHandler->[parseInputPaths->[getTableName,getBasePath,add,getTableMetaClientForBasePath,contains,put,tagAsIncrementalOrSnapshot,info,getFileSystem,values],tagAsIncrementalOrSnapshot->[add,containsKey,put,contains],parseInputPaths,getLogger]]
Parses input paths and adds them to the list of paths that can be used to tag them.
this condition check is pretty hard to read.. can we improve this?
@@ -969,6 +969,12 @@ export class AmpAdNetworkDoubleclickImpl extends AmpA4A { setStyles(this.element, {width: `${size.width}px`}); } + if (this.friendlyIframeEmbed) { + this.friendlyIframeEmbed.whenWindowLoaded().then(() => { + this.expandFluidCreative_(); + }); + } + this.ref...
[AmpAdNetworkDoubleclickImpl->[postTroubleshootMessage->[dev,dict,stringify,now,userAgent],extractSize->[height,extractAmpAnalyticsConfig,dev,get,width],getBlockParameters_->[width,height,dev,isInManualExperiment,serializeTargeting,assign,googleBlockParameters,Number],constructor->[user,extensionsFor],tearDownSlot->[re...
Adds a missing creative header to the current element. finds the next element in the list of available ad - containers.
Rather than exposing the friendly iframe embed object (allowing for other modifications), let's create a new function in AmpA4a = onFriendlyIframeEmbedLoaded
@@ -1311,8 +1311,12 @@ void ServerEnvironment::step(float dtime) block->setTimestampNoChangedFlag(m_game_time); /* Handle ActiveBlockModifiers */ - abmhandler.apply(block); + abmhandler.apply(block, abm_checked, abm_run, abm_not_cached); } + g_profiler->avg("SEnv: active blocks", m_active_blocks...
[No CFG could be retrieved]
v3s16 p2 = 0 - > p2 - > p2 - > do { while ( true ).
Line is too long (> 80 characters)
@@ -36,6 +36,7 @@ namespace System.Net } } + [UnsupportedOSPlatform("browser")] public TimeSpan EntityBody { get => TimeSpan.Zero;
[HttpListenerTimeoutManager->[ValidateTimeout->[ToInt64,MaxValue,TotalSeconds,nameof],MaxValue,Zero,ValidateTimeout,nameof]]
Creates a timeout manager that can be used to manage timeouts on a connection. Validate timeout.
The marked methods in this file also look set specific. Since they are already marked windows-specific, I believe we can just omit these 4 APIs in both the ref file and here.
@@ -60,6 +60,7 @@ class Emoji Discourse.cache.delete(cache_key("standard_emojis")) Discourse.cache.delete(cache_key("aliases_emojis")) Discourse.cache.delete(cache_key("all_emojis")) + Discourse.cache.delete(cache_key("tonable_emojis")) end def self.db_file
[Emoji->[clear_cache->[cache_key],lookup_unicode->[replacement_code],cache_key->[cache_key],unicode_replacements->[replacement_code],load_standard->[create_from_db_item]]]
Returns the next uncommitted emoji object or nil if there is no emoji object in the.
At some point we should start having an array of the cache keys and iterate over them and call `Discourse.cache.delete`
@@ -315,6 +315,9 @@ class _GeneralizationAcrossTime(object): Note. The function updates the ``scorer_``, ``scores_``, and ``y_true_`` attributes. + Note. If `predict_mode` is 'mean-prediction', `score_mode` is + automatically set to `no-cv`. + Parameters ---------- ...
[_GeneralizationAcrossTime->[score->[predict,is_regressor],predict->[_DecodingTime],__init__->[_DecodingTime]],_sliding_window->[_DecodingTime,find_t_idx],TimeDecoding->[score->[predict],_prep_times->[_DecodingTime]],_fit_slices->[fit]]
Score across all epochs by comparing the prediction estimated for each epoch to its true value. Compute the score of a missing node in the model. Get the scores of missing key - value pairs.
use `.. note::` and double-backticks
@@ -78,8 +78,7 @@ public class GobblinMultiTaskAttempt { /** * Commit {@link GobblinMultiTaskAttempt} immediately after running is done. */ - IMMEDIATE, - /** + IMMEDIATE, /** * Not committing {@link GobblinMultiTaskAttempt} but leaving it to user customized launcher. */ CUSTO...
[GobblinMultiTaskAttempt->[runAndOptionallyCommitTaskAttempt->[commit,run,isSpeculativeExecutionSafe],runWorkUnits->[runAndOptionallyCommitTaskAttempt,GobblinMultiTaskAttempt,taskSuccessfulInPriorAttempt],commit->[apply->[call->[commit]]],isSpeculativeExecutionSafe->[isSpeculativeExecutionSafe]]]
Package private for testing purposes. This method is called by Gobblin to perform cleanup on a multi - task attempt.
Is this intentional? Shouldn't the "/**" start on a new line?
@@ -47,6 +47,8 @@ public class WordCount { public static class ExtractWordsFn extends DoFn<String, String> { private final Counter emptyLines = Metrics.counter(ExtractWordsFn.class, "emptyLines"); + private static final String TOKENIZER_PATTERN = "[^\\p{L}]+"; + @ProcessElement public void proces...
[WordCount->[CountWords->[expand->[apply,ExtractWordsFn]],main->[apply,getOutput]]]
Process element of critical tag.
Could you import `import org.apache.beam.examples.common.ExampleUtils;` instead?
@@ -286,10 +286,10 @@ namespace Dynamo.Engine.CodeGeneration NodeModel inputModel = inputTuple.Item2; AssociativeNode inputNode = inputModel.GetAstIdentifierForOutputIndex(outputIndexOfInput); -#if DEBUG - Validity.Assert(inputNode != null, - ...
[AstBuilder->[CompileToAstNodes->[TopologicalSort,CompileToAstNodes],OnAstNodeBuilt->[OnCompiled],CompileCustomNodeDefinition->[CompileToAstNodes],OnAstNodeBuilding->[OnCompiling],BfsTraverse->[BfsTraverse],MarkNode->[MarkNode],TopologicalSortForGraph->[BfsTraverse],TopologicalSort->[MarkNode]]]
CompileToAstNodes compiles the given node into the list of AST nodes. This method builds the AST nodes that can be built by the node in the global scope.
will this print something to the console?
@@ -358,7 +358,7 @@ padlock_cfb_cipher(EVP_CIPHER_CTX *ctx, unsigned char *out_arg, out_arg += chunk; in_arg += chunk; - EVP_CIPHER_CTX_set_num(ctx, nbytes); + EVP_CIPHER_CTX_set_num(ctx, (int)nbytes); if (cdata->cword.b.encdec) { cdata->cword.b.encdec = 0; ...
[No CFG could be retrieved]
private static final int AES_BLOCK_SIZE = 16 ; private static final int AES_BLOCK_SIZE = 16 ;.
maybe check for overflow here?
@@ -15,8 +15,10 @@ const ajv = new Ajv({ allErrors: true }) ajv.addMetaSchema(require('ajv/lib/refs/json-schema-draft-06.json')) ajv.addSchema([ listingSchemaV1, + listingCompleteSchemaV1, listingWithdrawnSchemaV1, offerSchemaV1, + offerCompleteSchemaV1, offerWithdrawnSchemaV1, offerAcceptedSchemaV1,...
[No CFG could be retrieved]
AdapterBase is a base class for all of the schema - specific classes that implement the schema Encodes data before storage.
This file and the next six files are stubbed in code for eventsourcing that will be heavily edited in a future PR. (adapters, schemas, etc)
@@ -91,10 +91,11 @@ struct record { }; int rec_size; int type; + bool snap; }; struct records { - daos_epoch_t eph; + int eph; int records_num; struct record records[MAX_EXT_NUM]; };
[generate_io_conf_dkey->[generate_io_conf_akey],generate_io_conf_obj->[generate_io_conf_dkey],generate_io_conf_rec->[choose_op],main->[generate_io_conf_obj,print_usage],generate_io_conf_akey->[generate_io_conf_rec]]
Create a list of long - notation objects from a list of objects. - o - d - key - a - s - file - name.
(style) please, no space before tabs
@@ -36,8 +36,11 @@ module View elsif @tile.cities.any? render_track_for_curvilinear_city else - @tile.paths.select { |path| path.edges.size == 2 }.map do |path| - h(TrackCurvilinearPath, region_use: @region_use, path: path, color: color_for(path)) + ...
[Track->[color_for->[class,find_index,any?],render_track_for_curvilinear_city->[h,flat_map,color_for,exits,map],render->[h,offboard,lawson?,paths,color_for,any?,paths_for,map],render_track_for_curvilinear_town->[h,flat_map,color_for,exits,map],needs,freeze],require]
render_track_for_curvilinear_city_or_offboard.
can you change this to work with indicies?
@@ -104,7 +104,7 @@ class Command(BaseCommand): tasks.append(remove_git_extraction_entry.si(addon.pk)) log.info( - 'Submitted {} tasks to extract {} versions for add-on ' + 'Submitted {} tasks to git-extract {} versions for add-on ' '"{}".'.format(len(tasks), len(v...
[Command->[extract_addon->[si,chunked,append,chain,update,len,format,versions,info,delete],handle->[error,lock,order_by,extract_addon,format,info,switch_is_active]],getLogger]
This method extracts all the versions of an add - on from the git repository. Attach an error handler to the chain of tasks.
I added a few "git" in this file to ease my life in Stackdriver.
@@ -233,7 +233,8 @@ class User < ActiveRecord::Base end def self.find_by_email(email) - find_by(email: Email.downcase(email)) + user_email = UserEmail.find_by(email: Email.downcase(email)) + user_email.user if user_email end def self.find_by_username(username)
[User->[update_previous_visit->[update_visit_record!,previous_visit_at_update_required?],secure_category_ids->[admin?],update_posts_read!->[visit_record_for,create_visit_record!,update_posts_read!],unread_private_messages->[unread_notifications_of_type],change_trust_level!->[change_trust_level!],suspend_reason->[suspen...
Finds user by email or username.
In Ruby 2.3, you can do something like this, `UserEmail.find_by(email: Email.downcase(email))&.user`
@@ -26,14 +26,14 @@ func Begin(msg string) (string, string, time.Time) { name := runtime.FuncForPC(pc).Name() if msg == "" { - log.Printf("[BEGIN] [%s]", name) + log.Debugf("[BEGIN] [%s]", name) } else { - log.Printf("[BEGIN] [%s] %s", name, msg) + log.Debugf("[BEGIN] [%s] %s", name, msg) } return msg, ...
[Printf,Caller,Name,Now,Sub,FuncForPC]
End returns the message name and time of the last non - zero error.
Hmm I'm not sure about this change, I personally find them useful and they are not necessary for debugging. For example we used to do timing analysis based on this in bonneville code base so I suggest dropping this bit.
@@ -81,7 +81,7 @@ describe('amp-img', () => { beforeEach(() => { el = document.createElement('amp-img'); - el.setAttribute('src', 'test.jpg'); + el.setAttribute('src', 'base/examples/img/ampicon.png'); el.setAttribute('width', 100); el.setAttribute('height', 100); impl = new...
[No CFG could be retrieved]
JS - Functions Creates a mock object that will show the fallback if loading fails.
Is there a need for a leading '/' in the path?
@@ -1,3 +1,4 @@ +import fnmatch import re from conans.errors import ConanException
[RangeResolver->[_resolve_version->[satisfying],_resolve_remote->[_search_remotes]],satisfying->[_parse_versionexpr]]
Parse version expression and return list of version_chunks. returns the maximum version that satisfies the expression.
Not used, right?
@@ -177,10 +177,14 @@ public class HoodieTestTable { return this; } - public HoodieTestTable addReplaceCommit(String instantTime, HoodieRequestedReplaceMetadata requestedReplaceMetadata, HoodieReplaceCommitMetadata metadata) throws Exception { + public HoodieTestTable addReplaceCommit( + String instant...
[HoodieTestTable->[listAllLogFiles->[listAllLogFiles],withMarkerFiles->[withMarkerFiles],of->[HoodieTestTable],withLogFile->[withLogFile],makeIncrementalCommitTimes->[makeIncrementalCommitTimes],listAllBaseFiles->[listAllBaseFiles],withMarkerFile->[withMarkerFile],addRequestedCompaction->[addRequestedCompaction],makeNe...
Add delta commit.
can we set HoodieCommitMetadata to Option< HoodieCommitMetadata > to avoid null
@@ -11,7 +11,7 @@ namespace Pulumi.Automation.Commands internal interface IPulumiCmd { Task<CommandResult> RunAsync( - IEnumerable<string> args, + IList<string> args, string workingDir, IDictionary<string, string?> additionalEnv, Action<str...
[No CFG could be retrieved]
RunAsync - Async version of Run.
Hm, this was an automatically suggested change? I wonder why it did that. It seems to me IEnumerable has fewer assumptions than IList, and if RunAsync does not need random access, the change weakens it? Just curious why it decided to change this.
@@ -52,6 +52,8 @@ Rails.application.configure do # Raises error for missing translations # config.action_view.raise_on_missing_translations = true + config.active_job.queue_adapter = :test + # Install the Timber.io logger, but do not send logs. logger = Timber::Logger.new(nil) logger.level = config.lo...
[new,show_exceptions,level,headers,test_order,consider_all_requests_local,cache_classes,deprecation,logger,enabled,to_i,delivery_method,eager_load,default_url_options,service,allow_forgery_protection,cache_store,perform_caching,log_level,configure]
Installs the Logger and adds a deprecation warning if missing translations.
By enabling the test adapter globally we ensure there's no risk of brittle behavior between using `:inline` (which introduces complications) and `:test` for tests involving ActiveJob
@@ -21,13 +21,18 @@ class PyDask(PythonPackage): variant('bag', default=True, description='Install requirements for dask.bag') variant('dataframe', default=True, description='Install requirements for dask.dataframe') variant('delayed', default=True, description='Install requirements for das...
[PyDask->[import_modules->[append,extend],variant,depends_on,version]]
Creates a new object with the properties of a single object. Requirements for all - python - toolz - 0. 7. 3 and - numpy -.
Is this line needed? It seems to be a subset of the previous line.
@@ -948,13 +948,11 @@ class Trainer: patience = params.pop_int("patience", None) validation_metric = params.pop("validation_metric", "-loss") num_epochs = params.pop_int("num_epochs", 20) - cuda_device = params.pop_int("cuda_device", -1) + cuda_device = params.pop( "cuda_device"...
[Trainer->[_parameter_and_gradient_statistics_to_tensorboard->[add_train_scalar,is_sparse],train->[_enable_activation_logging,_validation_loss,_should_stop_early,_metrics_to_tensorboard,_enable_gradient_clipping,_metrics_to_console,_train_epoch,_get_metrics],_enable_activation_logging->[hook->[add_train_histogram]],_re...
Construct a Trainer from a list of params. Missing parameters.
This parameter still needs to have a default - this is causing a lot of the CI to break.
@@ -1763,7 +1763,7 @@ void BailOutRecord::ScheduleFunctionCodeGen(Js::ScriptFunction * function, Js::S bailOutRecordNotConst->bailOutCount++; Js::FunctionEntryPointInfo *entryPointInfo = function->GetFunctionEntryPointInfo(); - uint8 callsCount = entryPointInfo->callsCount; + uint32 callsCount = entry...
[No CFG could be retrieved]
The main entry point of the function. Checks if an int type spec is not disabled and if so marks it as a thunk.
You can just change this to: uint32 callsCount = MIN(entryPointInfo->callsCount, 255); to retain the previous bailout behavior we had with saturation.
@@ -264,13 +264,14 @@ def create(label, plugin_name, options, description=None): return database.create(source) -def update(source_id, label, options, description): +def update(source_id, label, plugin_name, options, description): """ Updates an existing source. :param source_id: Lemur assign...
[sync->[sync_endpoints,sync_certificates],update->[update],sync_certificates->[find_cert,certificate_create,certificate_update],create->[create],get->[get],get_by_label->[get],delete->[delete],add_aws_destination_to_sources->[get_all,get,create]]
Updates an existing source. with the given parameters.
Function: Changing the plugin selected required updating the `plugin_name` field as well as the options.
@@ -1208,6 +1208,10 @@ SharedBuffer<u8> ConnectionReceiveThread::handlePacketType_Control(Channel *chan m_connection->SetPeerID(peer_id_new); } + // set non legacy mode locally + dynamic_cast<UDPPeer *>(peer)->setNonLegacyPeer(); + + // request the same from the remote side ConnectionCommand cmd; Sh...
[No CFG could be retrieved]
Handle a single packet of type Control or Reliable. finds the next ack in the queue and reports the RTT if it is greater than.
request? so if the remote side does not support this, wouldn't we need to omit the `setNonLegacyPeer()` call?
@@ -1,9 +1,11 @@ class TeamsController < ApplicationController - before_action :load_vars, only: [:parse_sheet, :import_samples, :export_samples] + before_action :load_vars, only: [:parse_sheet, :import_samples, + :export_samples, :export_all] before_action :check_create_sample...
[TeamsController->[import_samples->[import_samples]]]
Get a single node in the worksheet.
Style/SymbolArray: Use %i or %I for an array of symbols.
@@ -203,6 +203,8 @@ class FusedFeedForward(Layer): dim_feedforward (int): The hidden layer size. dropout_rate (float, optional): The dropout probability used in pre-process and post-precess. Default 0.1 + epsilon (float, optional): he small value added to the variance to prevent + ...
[FusedTransformerEncoderLayer->[__init__->[FusedFeedForward,FusedMultiHeadAttention]]]
This function is a wrapper for the fused_multi_head_attention function. Create a random object according to paddle. ParamAttr.
he -> The
@@ -53,6 +53,12 @@ type HeartbeatStreams interface { SendMsg(region *core.RegionInfo, msg *pdpb.RegionHeartbeatResponse) } +// WaitingOperatorStatus is used to limit the count of each kind of operators. +type WaitingOperatorStatus struct { + current uint64 + max uint64 +} + // OperatorController is used to li...
[Put->[Put],exceedStoreLimit->[GetStoreInfluence],Get->[Get],addOperatorLocked->[getNextPushOperatorTime],pollNeedDispatchRegion->[getNextPushOperatorTime],getOrCreateStoreLimit->[newStoreLimit],PushOperators->[pollNeedDispatchRegion,Dispatch]]
NewOperatorController creates a new instance of OperatorController. Dispatch is used to dispatch an operator of a region.
Why do not define it in `waiting_operator.go`? I guess it is specific to waiting operators.
@@ -401,6 +401,12 @@ const EXPERIMENTS = [ spec: 'https://github.com/ampproject/amphtml/issues/20395', cleanupIssue: 'https://github.com/ampproject/amphtml/issues/20394', }, + { + id: 'amp-auto-lightbox-carousel', + name: 'Automatically detects carousels to group in a lightbox.', + spec: 'https:/...
[No CFG could be retrieved]
Check that all AMP - related features of a fixed - layer have a cleanup issue. Builds the table with one row of the table with one row of the table with one row.
sanity check: these github issues are the same as the above. possible copypaste error or intentional?
@@ -14,6 +14,7 @@ */ package org.rstudio.studio.client; +import com.google.gwt.core.client.GWT; import com.google.gwt.inject.client.AbstractGinModule; import com.google.gwt.inject.client.assistedinject.GinFactoryModuleBuilder; import com.google.gwt.user.client.ui.Widget;
[RStudioGinModule->[bindTab->[to],bindPane->[to],configure->[install,to,bindTab,build,asEagerSingleton,in,bindPane]]]
Imports a single from RSTudio. Imports the package containing all the application information.
Not used, remove
@@ -1,4 +1,5 @@ import random +import typing import pytest import responses
[requests_responses->[RequestsMock],netting_channel_state->[NettingChannelStateProperties,create,NettingChannelEndStateProperties,TokenAmount,make_address,make_canonical_identifier,partneraddresses_to_channelidentifiers],token_network_registry_state->[TokenNetworkRegistryState],our_signer->[make_signer],token_id->[make...
A function to create a random object for a single token object. A function to create a token network state object.
Couldn't you do `from raiden.utils.typing import Generator`?
@@ -53,7 +53,7 @@ $msg_box = array(); // Check for install.inc.php if (!file_exists('../config.php') && $_SERVER['PATH_INFO'] != '/install.php') { // no config.php does so let's redirect to the install - header("Location: {$config['base_url']}/install.php"); + header("Location: /install.php"); exit; ...
[No CFG could be retrieved]
Initialize the system Load the settings for Multi - Tenancy.
If install is in a sub dir then this will break those installs.
@@ -55,6 +55,14 @@ class AmpScrollSync extends AMP.BaseElement { config['scale-origin'] = this.element .getAttribute('scale-origin'); scrollSyncEffect = new ScrollSyncScaleEffect(element, config); + } else if (this.effectName_ == 'rotate') { + config['rotate-angle'] = getLengthNumeral(t...
[No CFG could be retrieved]
Adds an AMPScrollSync effect to the window.
Why are we parsing the config in the element instead of the specific implementation?
@@ -135,9 +135,6 @@ export class SafeframeHostApi { /** @private {?Element} */ this.iframe_ = null; - /** @private {?IntersectionObserver} */ - this.intersectionObserver_ = null; - /** @type {?string} */ this.channel = null;
[No CFG could be retrieved]
Provides a class which implements the standard AMP - like interface for handling intersection events. The base class for all of the components.
(Note: this is just a minor cleanup. Does not affect the bug, just not needed anymore)
@@ -285,7 +285,13 @@ func (srv *Server) ListNodes(ctx context.Context, in *reporting.Query) (*reporti // ReadNode returns a node based on id func (srv *Server) ReadNode(ctx context.Context, in *reporting.Id) (*reporting.Node, error) { - node, err := srv.es.GetNode(in.Id) + formattedFilters := formatFilters([]*repor...
[ListSuggestions->[Sprintf,GetSuggestions,Error,FormatErrorMsg],ListProfiles->[GetAllProfilesFromNodes,Error,FormatErrorMsg],ListReports->[GetReports,Error,FormatErrorMsg],ReadNode->[GetNode,FormatErrorMsg],ListNodes->[GetNodes,Error,FormatErrorMsg],Export->[Error],ReadReport->[GetReport,Error,FormatErrorMsg],Strings,N...
ReadNode returns a node by id.
Why call `formatFilters` here and not create an empty `map[string][]string`?
@@ -77,12 +77,7 @@ func newPFSIterator(pachClient *client.APIClient, input *pps.PFSInput) (Iterator // not possible for 2 inputs to have the same path so this is guaranteed to // produce a deterministic order. sort.Slice(result.inputs, func(i, j int) bool { - // We sort by descending size first because it can bo...
[Datum->[Datum],Reset->[Next,Reset],Next->[Reset,Next],DatumN->[Datum,Reset,Next,DatumN,Len],Len->[Len],Next,Datum,Reset]
Reset resets the iterator to the last item in the chain.
just trying to understand, why change the sort order here?
@@ -342,6 +342,9 @@ public class RealtimePlumber implements Plumber schema.getAggregators(), mergedTarget ); + if (!marker.createNewFile()) { + log.makeAlert("Unable to make marker file[%s]! WTF?!", marker).emit(); + } ...
[RealtimePlumber->[persistHydrant->[persist,computePersistDir],getSink->[add],finishJob->[persistAndMerge],persistAndMerge->[doRun->[add]],registerServerViewCallback->[segmentAdded->[abandonSegment]],add->[add],computePersistDir->[computeBaseDir],removeMergedSegment->[computePersistDir],persist->[add],mergeAndPush->[pe...
This method will persist the given hydrant and merge it into the given sink. Abandon the segment if it is not already abandoned.
I think the marker file should be in the details rather than the description.
@@ -12,6 +12,8 @@ features = %i[ annotations alaveteli_pro projects + pro_batch_access + pro_batch_category_ui pro_pricing pro_self_serve ]
[backend,enable,each,public_send,enabled?,disable]
Set up the list of available features and get some defaults for the #.
We set these on a per-actor basis - does it make sense to include them here? I actually think `pro_batch_access` can be done away with entirely. If you're a pro, you should be able to create batches without needing a feature flag set.
@@ -105,6 +105,9 @@ type ShootSpec struct { // +patchStrategy=merge // +optional Tolerations []Toleration `json:"tolerations,omitempty" patchStrategy:"merge" patchMergeKey:"key" protobuf:"bytes,17,rep,name=tolerations"` + // ManagedSeedName is the name of the ManagedSeed resource for this Shoot. + // +optional + ...
[FromInt]
The credentials inside the provider secret will be used to create the shoot in the respective account Gardener JSON description.
This field should be added to the `v1alpha1` version as well
@@ -330,6 +330,9 @@ defineSuite([ Matrix3.multiplyByVector(axes, tang, tang); Matrix3.multiplyByVector(axes, binorm, binorm); Cartesian3.cross(tang, binorm, n); + if (Cartesian3.magnitude(n) === 0) { + return; + } Cartesian3.normal...
[No CFG could be retrieved]
Tests if a sphere intersects a plane. This function is used to test if the plane is inside the box.
Can you use `return undefined;` here for consistency with the rest of the function. The rule we tend to use (but doubt we've ever codified) is that we use `return undefined;` in cases where the function returns actual values sometimes as well.
@@ -145,6 +145,11 @@ class AioHttpTransport(AsyncHttpTransport): :keyword str proxy: will define the proxy to use all the time """ await self.open() + try: + auto_decompress = self.session.auto_decompress + except AttributeError: + # if this is a custom ses...
[AioHttpTransportResponse->[stream_download->[AioHttpStreamDownloadGenerator],__getstate__->[body]],AioHttpTransport->[close->[close],send->[_build_ssl_config,_get_request_data,open],open->[__aenter__]],AioHttpStreamDownloadGenerator->[__anext__->[close]]]
Sends a request using this HTTP sender. Get a response for a single .
`self.session` is supposed to be an `aiohttp.ClientSession`, correct? If so, this will never raise an `AttributeError`.
@@ -54,7 +54,7 @@ class User < ApplicationRecord attr_accessor :_skip_creating_profile # All new users should automatically have a profile - after_create_commit -> { Profile.create(user: self) }, unless: :_skip_creating_profile + after_create_commit :create_user_profile, unless: :_skip_creatin...
[User->[check_for_username_change->[path],send_welcome_notification->[send_welcome_notification],blocked_by?->[blocking?],auditable?->[any_admin?],blocking?->[blocking?],resave_articles->[path]]]
Creates a page with all the methods that are defined in the neccesary section of The default configuration of the theme.
Is there a specific reason for turning this lambda into a method? I wanted to have all temporary profile-related code within this inline concern but apart from that, they are functionally equivalent.
@@ -119,6 +119,10 @@ const EXPERIMENTS = [ 'amp-google-vrview-image/amp-google-vrview-image.md', cleanupIssue: 'https://github.com/ampproject/amphtml/issues/3996', }, + { + id: 'amp-mega-menu', + name: 'AMP extension for a mega menu with expandable items', + }, { id: 'amp-sidebar-v2', ...
[No CFG could be retrieved]
A list of AMP components that should be removed from AMP. A sequence of possible identifiers for a specific node.
Please link to your cleanup issue here
@@ -641,7 +641,7 @@ function $RootScopeProvider(){ * ``` * */ - $digest: function() { + $digest: function(calledByFn) { var watch, value, last, watchers, asyncQueue = this.$$asyncQueue,
[No CFG could be retrieved]
This function is called when a variable is missing listeners. Loop through the asyncQueue and process all the async tasks.
this argument is just a helper which enables a bit better support for mocking --- it could be removed and tests would need to be refactored
@@ -187,7 +187,7 @@ var ( // // ``` // START RequestId: 25e0d1e0-cbd6-11e7-9808-c7085dfe5723 Version: $LATEST -// 2017-11-17T20:30:27.736Z 25e0d1e0-cbd6-11e7-9808-c7085dfe5723 GET /todo +// 2018-11-17T20:30:27.736Z 25e0d1e0-cbd6-11e7-9808-c7085dfe5723 GET /todo // END RequestId: 25e0d1e0-cbd6-11e7-9808-c7085dfe...
[GetLogs->[OperationsProvider,GetChild,Infof,FindStringSubmatch,Name,Assertf,Unmarshal,V,GetLogs],UnixNano,Infof,Assertf,V,Parse,MustCompile,Type,FindAllStringSubmatch]
Takes a log stream and a list of log events and extracts the log message associated with the expects log regexp to always produce at least two capture groups.
Did you mean to change this? Might be benign, but I don't know for sure.
@@ -47,7 +47,7 @@ module Dependabot case new_req[:source][:type] when "git" update_git_declaration(new_req, old_req, content, file.name) - when "registry" + when "registry", "provider" update_registry_declaration(new_req, old_req, content) els...
[FileUpdater->[updated_terraform_file_content->[fetch,raise,update_git_declaration,each,dup,reject,name,update_registry_declaration],git_declaration_regex->[name,escape,terragrunt_file?],updated_dependency_files->[file_changed?,updated_terraform_file_content,raise,content,updated_file,none?,each],dependency->[first],fi...
Update the content of the file with the that was found in the previous_requirements and.
The naming of these still bugs me, they should probably be `registry_module` and `registry_provider`, but then it would also be `git_module` etc and it's quite a big change, so punting on that for now
@@ -134,6 +134,7 @@ class ResultTextsController < ApplicationController saved = @result.save if saved then + TinyMceAsset.update_images(@result_text, params[:result][:tiny_mce_images]) Activity.create( type_of: :edit_result, user: current_user,
[ResultTextsController->[new->[new],create->[new,create],update->[create]]]
update_user_with_params - this method is called when user changes the nag if there is no error - render json.
Metrics/LineLength: Line is too long. [83/80]
@@ -90,3 +90,18 @@ bool proc_handler_call(proc_handler_t *handler, const char *name, return false; } + +bool proc_handler_exists(proc_handler_t *handler, const char *name) +{ + if (!handler) + return false; + + for (size_t i = 0; i < handler->procs.num; i++) { + struct proc_info *info = handler->procs.array + i;...
[proc_handler_create->[da_init,bmalloc],inline->[decl_info_free],proc_handler_destroy->[proc_info_free,da_free,bfree],proc_handler_add->[parse_decl_string,memset,blog,da_push_back],proc_handler_call->[strcmp]]
This function is called by the process handler when a function is called.
Don't use curly braces in a single statement `if`.
@@ -275,7 +275,14 @@ func (sg *stepGenerator) GenerateSteps(event RegisterResourceEvent) ([]Step, *re // Determine whether the change resulted in a diff. d, diffErr := sg.diff(urn, old.ID, oldInputs, oldOutputs, inputs, prov, allowUnknowns) if diffErr != nil { - return nil, result.FromError(diffErr) + ...
[GenerateDeletes->[V,Infof],GenerateSteps->[Analyze,GetProvider,Diag,ParseReference,DependingOn,Analyzer,Errorf,Assert,Olds,issueCheckErrors,diff,IsProviderType,Infof,V,Bail,generateURN,GetAnalyzeResourceFailureError,GetDuplicateResourceURNError,FromError,Replace,Check,NewState,Goal],GenerateReadSteps->[ID,Infof,Provid...
GenerateSteps generates the necessary steps for a checkpoint Check if a resource has a provider reference and if so return it. This function is called by the engine to analyze a resource and perform the necessary actions.
We have the URN of the provider from the provider reference, right? can we issue the warning for that URN and not this resource? I think it would make more sense for this message to be attached to the provider since the message directly pertains to it.
@@ -963,9 +963,10 @@ static int evp_pkey_ctx_set1_octet_string(EVP_PKEY_CTX *ctx, int fallback, return -2; } - /* TODO(3.0): Remove this eventually when no more legacy */ + /* Code below to remove when legacy support is dropped. */ if (fallback) return EVP_PKEY_CTX_ctrl(ctx, -1, op, ...
[No CFG could be retrieved]
-1 - if the given parameters do not match the current parameters -2 - if it Get the signature parameters from the given context.
to **be removed**