patch stringlengths 18 160k | callgraph stringlengths 4 179k | summary stringlengths 4 947 | msg stringlengths 6 3.42k |
|---|---|---|---|
@@ -227,11 +227,12 @@ func newAccessTokenResponse(grant *login.OAuth2Grant, serverKey, clientKey oauth
}
type userInfoResponse struct {
- Sub string `json:"sub"`
- Name string `json:"name"`
- Username string `json:"preferred_username"`
- Email string `json:"email"`
- Picture string `json:"picture"`
+ S... | [Error->[Sprintf],Invalidate,HandleText,SetNonce,PathEscape,ContainsRedirectURI,Alg,CreateJWTSigningKey,Warn,TemplateLookup,GetUserByID,Redirect,Encode,Set,Add,GetOAuth2GrantByID,GetGrantByUserID,HTML,Error,GenerateRedirectURI,ParseToken,Sprint,CreateGrant,Validate,ScopeContains,TimeStampNow,NewEncoder,ValidateClientSe... | newAccessTokenResponse creates an access token response from the given grant. check returns if the user has a reserved token. | Can it be `PreferredUsername` to match the name in json? |
@@ -53,7 +53,7 @@ function lostpass_post(App $a) {
provided and ignore and/or delete this email.
Your password will not be changed unless we can verify that you
- issued this request.'));
+ issued this request.', $user['username'], $sitename));
$body = deindent(t('
Follow this link to verify your identit... | [No CFG could be retrieved] | lostpass_post - Post a password reset request This link will send a message to the user that the password has been reset. | I think you should add the hint that the link is only valid for a limited time. |
@@ -1,11 +1,11 @@
# frozen_string_literal: true
module RepositoryColumns
- class DateTimeColumnsController < BaseColumnsController
+ class DateTimeColumnsController < RepositoryColumnsController
include InputSanitizeHelper
- before_action :load_column, only: %i(update destroy)
+ before_action :load_col... | [DateTimeColumnsController->[create->[call,render,succeed?,column,errors],column_type_param->[require],update->[call,render,succeed?,column,errors],destroy->[call,succeed?,errors,render],repository_column_params->[permit],before_action,include]] | POST - Create a new . | Move it to RepositoryColumnsController |
@@ -28,7 +28,16 @@ class Article < ApplicationRecord
counter_culture :user
counter_culture :organization
- has_many :comments, as: :commentable, inverse_of: :commentable
+ has_many :buffer_updates, dependent: :destroy
+ has_many :comments, as: :commentable, inverse_of: :commentable, dependent: :nullify
+ ha... | [Article->[username->[username],evaluate_front_matter->[set_tag_list],update_notifications->[update_notifications],readable_edit_date->[edited?]]] | A model that can be used to view a single item in a collection. The default configuration for the user. | most of this is me sorting lines |
@@ -1796,13 +1796,13 @@ CSV
csv_contents = load_file_fixture("multiple-locales-same-name.csv")
- errors, notes = PublicBody.import_csv(csv_contents, '', 'replace', true, 'someadmin', ['en', 'es']) # true means dry run
+ errors, notes = PublicBody.import_csv(csv_contents, '', 'replace', true, 'someadmin',... | [set_default_attributes->[last_edit_comment,short_name,last_edit_editor,request_email,name],import_csv_from_file,create,let,tag_string,with_tag,it,to,yield_with_args,change,last_edit_comment,get_request_percentages,each,match,length,context,get_request_totals,find_by_name,reload,with_locale,and_return,internal_admin_bo... | checks that the given header object contains all the fields that should be imported for the given header should return the home page based on the request email domain if it has one. | Line is too long. [108/80] |
@@ -1283,6 +1283,18 @@ void lua_engine::initialize()
* driver.manufacturer
* driver.compatible_with
* driver.default_layout
+ * driver.orientation - screen rotation degree (rot0/90/180/270)
+ * driver.type - machine type (arcade/console/computer/other)
+ * driver.not_working - not considered working
+ * driver.su... | [No CFG could be retrieved] | The images list is a mapping of instance name to device name. A wrapper for the functions that are called by the debugger when a command is not found in. | This isn't necessarily going to give you a meaningful result. Individual screens can also have rotation flags, and some systems have multiple screens with different orientations. |
@@ -1396,7 +1396,14 @@ public class CompositeByteBuf extends AbstractReferenceCountedByteBuf implements
return findComponent(offset).buf;
}
+ // weak cache - check it first when looking for component
+ private Component lastAccessed;
+
private Component findComponent(int offset) {
+ Co... | [CompositeByteBuf->[toByteIndex->[checkComponentIndex],resetWriterIndex->[resetWriterIndex],_setIntLE->[order,_setShortLE],setInt->[setInt],setIndex->[setIndex],_setMedium->[setMedium,_setShort,_setByte,order],resetReaderIndex->[resetReaderIndex],writeZero->[writeZero],retain->[retain],_setMediumLE->[_setByte,order,_se... | Returns the component at the given offset. | oops, I just noticed this should be `la`, will fix |
@@ -11,11 +11,11 @@
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
-// +build windows
package cmdutil
import (
+ "fmt"
"os"
"os/exec"
| [PPid,Pid,Append,FindProcess,Kill,Processes] | KillChildren kills all children of a process. processExistsWithParent returns true if the process with the given pid and ppid exists in. | Is 0 special here or do you just mean that when PID and PPID are equal to ignore them? |
@@ -137,6 +137,11 @@ public class PolygonBound extends RectangularBound
return oddNodes;
}
+ private boolean between(int i, int j, float coords[]) {
+ return (abscissa[i] < abscissa[j] && abscissa[j] > coords[0] && abscissa[i] < coords[0])
+ || (abscissa[i] > abscissa[j] && abscissa[j] < coords... | [PolygonBound->[from->[from,PolygonBound],filter->[apply->[contains],filter]]] | Returns an iterable of points that are contained in the polygon. | `{` should be on the next line |
@@ -112,10 +112,15 @@ KRATOS_CREATE_VARIABLE(double, SHELL_CROSS_SECTION_OUTPUT_PLY_LOCATION)
KRATOS_CREATE_VARIABLE(Matrix, SHELL_ORTHOTROPIC_LAYERS)
// Nodal stiffness for the nodal concentrated element
+KRATOS_CREATE_3D_VARIABLE_WITH_COMPONENTS(INITIAL_DISPLACEMENT)
KRATOS_CREATE_3D_VARIABLE_WITH_COMPONENTS(NOD... | [No CFG could be retrieved] | Create the variables for the given element 3D Variable with components. | This should be renamed to `NODAL_DISPLACEMENT_STIFFNESS` to be consistent It is not a heavily used variable so I would choose consistency over not wanting to break code |
@@ -97,7 +97,7 @@ namespace System.Windows.Forms.PropertyGridInternal
_browsableAttributes = value;
- if (!same && Children is not null && Children.Count > 0)
+ if (!same && ChildCount > 0)
{
DisposeChildren();
}
| [SingleSelectRootGridEntry->[Dispose->[Dispose],CreateChildren->[CreateChildren],ShowCategories->[CreateChildren]]] | The object that is specified by the user. Checks if the object is read - only or not. | Hitting the `Children` property creates the children. `ChildCount` specifically avoids this. Don't want to create children just to dispose of them. |
@@ -67,7 +67,8 @@ public class BucketExtractionFn implements ExtractionFn
}
@Override
- public String apply(String value)
+ @Nullable
+ public String apply(@Nullable String value)
{
try {
return bucket(Double.parseDouble(value));
| [BucketExtractionFn->[equals->[compare,getClass],apply->[bucket,parseDouble,apply,doubleValue],bucket->[valueOf,floor],getCacheKey->[array],toString->[format],hashCode->[doubleToLongBits]]] | Returns the value of the if it is a valid double. | Null is "expected" here, so suggested to check for it explicitly, rather than operate via exception handling, that is an antipattern in java |
@@ -129,8 +129,15 @@ public class SparkSqlInterpreter extends Interpreter {
sc.setLocalProperty("spark.scheduler.pool", null);
}
+ Object rdd = null;
+ try {
+ Method sqlMethod = sqlc.getClass().getMethod("sql", String.class);
+ rdd = sqlMethod.invoke(sqlc, st);
+ } catch (NoSuchMethodE... | [SparkSqlInterpreter->[getProgress->[getJobGroup],getScheduler->[concurrentSQL,getScheduler],getProgressFromStage_1_0x->[getProgressFromStage_1_0x],getProgressFromStage_1_1x->[getProgressFromStage_1_1x],cancel->[getJobGroup],getSparkInterpreter->[open],interpret->[concurrentSQL]]] | Interprets a Zeppelin statement. | Would you elaborate on why we would need to do this? Curious - isn't SQLContext always has the sql() method? |
@@ -108,7 +108,7 @@ func resourceAwsApiGatewayAuthorizerCreate(d *schema.ResourceData, meta interfac
if v, ok := d.GetOk("authorizer_credentials"); ok {
input.AuthorizerCredentials = aws.String(v.(string))
}
- if v, ok := d.GetOk("authorizer_result_ttl_in_seconds"); ok {
+ if v, ok := d.GetOkExists("authorizer_r... | [Difference,GetChange,ForceNew,StringInSlice,CreateAuthorizer,Set,Error,GetOk,HasChange,Errorf,SetId,Contains,UpdateAuthorizer,DeleteAuthorizer,Id,Int64,Get,Split,Printf,Sprintf,List,String,IntBetween,GetAuthorizer] | resourceAwsApiGatewayAuthorizerCreate creates an Authorizer based on the provided data. This function reads the specified API Gateway authorizer and updates the provided resource data. | Nit: since this field has a default value to fall back on we could also directly use `d.Get()` and set the attribute directly during input creation @L96 |
@@ -26,7 +26,11 @@ module View
}
lines = @log.reverse.map do |line|
- h(:div, { style: { transform: 'scaleY(-1)' } }, line)
+ if line.is_a? String
+ h(:div, { style: { transform: 'scaleY(-1)' } }, line)
+ elsif line.is_a? Engine::Action::Message
+ h(:div, { style: ... | [Log->[render->[lambda,h,map],needs]] | Renders a single in a hidden field. | always use parens |
@@ -48,7 +48,7 @@ type EthTx struct {
// GasLimit on the EthTx is always the conceptual gas limit, which is not
// necessarily the same as the on-chain encoded value (i.e. Optimism)
GasLimit uint64
- Error *string
+ Error null.String
// BroadcastAt is updated every time an attempt for this eth_tx is re-se... | [GetError->[New],GetSignedTx->[NewReader,DecodeRLP,Error,NewStream],GetID->[Sprintf]] | GetError returns error if the given block number is not found. GetID returns the string representation of a given EthTx. | minor, and it was already like that, but could be a bit more readable as 'ErrorString' or ErrorNullable' , etc. 'Error' seems to heavily suggest the 'error' type |
@@ -14,6 +14,12 @@ class StudentsController < ApplicationController
def index
@sections = Section.all
+ @section_column = Section.all.size > 0 ?
+ "{
+ id: 'section',
+ content: '" + I18n.t(:'user.section') + "',
+ sortable: true
+ }," : ''
end
def populate
| [StudentsController->[add_new_section->[new],new->[new],create->[new]]] | Displays a list of all nodes that have a node ID. | Avoid multi-line ?: (the ternary operator); use `if`/`unless` instead. |
@@ -29,6 +29,8 @@ import org.immutables.value.Value;
@JsonDeserialize(builder = StepVisitorContext.Builder.class)
public interface StepVisitorContext extends Iterator<StepVisitorContext> {
+ GeneratorContext getGeneratorContext();
+
int getIndex();
Step getStep();
| [hasNext->[isEmpty],next->[getRemaining,remove,build,getIndex]] | Returns the index of the next step in the queue. | Isn't it required that the generatorContext is also propagated in the `next()` step ? |
@@ -957,11 +957,8 @@ namespace System.Runtime.Serialization
/// Safe - marked as such so that it's callable from transparent generated IL. Takes id as parameter which
/// is guaranteed to be in internal serialization cache.
/// </SecurityNote>
-#if USE_REFEMIT
- public static ob... | [No CFG could be retrieved] | Universal - object - based implementation of GetUninitializedObject which is a special case for. | (nit) remove the newline here. |
@@ -0,0 +1,18 @@
+using Robust.Shared.GameObjects;
+using Robust.Shared.GameStates;
+using Robust.Shared.Serialization.Manager.Attributes;
+using Robust.Shared.ViewVariables;
+
+namespace Content.Shared.Light.Component
+{
+ [NetworkedComponent]
+ [RegisterComponent]
+ public class SharedRgbLightControllerCompo... | [No CFG could be retrieved] | No Summary Found. | yuck. Also don't need share prefix if it's not being inherited. |
@@ -139,6 +139,15 @@ public class ScalablePushRegistry {
LOG.error("Interrupted during shutdown", e);
executorService.shutdownNow();
}
+ executorServiceCatchup.shutdown();
+ try {
+ if (!executorServiceCatchup.awaitTermination(5000, TimeUnit.MILLISECONDS)) {
+ executorServiceCatchup... | [ScalablePushRegistry->[latestHasAssignment->[isClosed],runLatest->[onError],latestNumRegistered->[numRegistered,isClosed],isLatestRunning->[isClosed],unregister->[unregister,isClosed],cleanup->[close],create->[ScalablePushRegistry],createLatestConsumer->[close,isWindowed,onError,create],isWindowed->[isWindowed],stopLa... | Closes the scalable push registry. | nit: this pattern can be replaced with `MoreExecutors#shutdownAndAwaitTermination` |
@@ -15,10 +15,14 @@ def validate_storefront_url(url):
parsed_url = urlparse(url)
domain, _ = split_domain_port(parsed_url.netloc)
except ValueError as error:
- raise ValidationError({"redirectUrl": str(error)})
+ raise ValidationError(
+ {"redirectUrl": str(error)}, code=... | [validate_storefront_url->[split_domain_port,str,ValidationError,validate_host,urlparse]] | Validate the storefront URL. | Same as above. We shouldn't import any saleor's modules in core. This is a perfect wat to get more circular imports. If we need to import `AccountErrorCode` it means that this class or `validate_storefront_url` is declared in wrong place. |
@@ -954,12 +954,14 @@ public class RealtimePlumber implements Plumber
try {
int numRows = indexToPersist.getIndex().size();
+ final IndexSpec indexSpec = config.getIndexSpec();
+
indexToPersist.getIndex().getMetadata().putAll(metadataElems);
final File persistedFile = indexMer... | [RealtimePlumber->[persistHydrant->[persist,computePersistDir],persistAndMerge->[doRun->[add]],finishJob->[persistAndMerge],clearDedupCache->[clearDedupCache],addSink->[add],add->[add],computePersistDir->[computeBaseDir],persist->[add],mergeAndPush->[persistAndMerge,clearDedupCache,getAllowedMinTime,add],bootstrapSinks... | Persist the given Hydrant. | Change doesn't belong to this PR |
@@ -57,8 +57,8 @@ cont_t* g_pcont __attribute__((section(".noinit")));
/* Event queue used by the main (arduino) task */
static os_event_t s_loop_queue[LOOP_QUEUE_SIZE];
-/* Used to implement optimistic_yield */
-static uint32_t s_micros_at_task_start;
+/* Used to implement __optimistic_yield */
+static uint32_t s_... | [No CFG could be retrieved] | The main function of the main function. Private methods for locking the NICs. | Suggest a better name for this would be `s_cycles_at_yield_start`. It is holding an absolute cycle count(at), not a delta(since). |
@@ -91,7 +91,7 @@ void HAL_timer_start(const uint8_t timer_num, const uint32_t frequency) {
TimerHandle[timer_num].irqHandle = TC5_Handler;
TimerHandleInit(&TimerHandle[timer_num], (((HAL_TIMER_RATE) / step_prescaler) / frequency) - 1, step_prescaler);
#endif
- HAL_NVIC_SetPriority... | [HAL_timer_disable_interrupt->[__ISB,__DSB,HAL_NVIC_DisableIRQ],HAL_timer_start->[TimerHandleInit,HAL_TIM_Base_Init,HAL_NVIC_SetPriority,HAL_TIM_Base_Start_IT,__HAL_RCC_TIM7_CLK_ENABLE,__HAL_RCC_TIM5_CLK_ENABLE],HAL_timer_enable_interrupt->[HAL_NVIC_EnableIRQ]] | HAL timer start last call to HAL_TIM_Base_Init HAL_TIM_. | Why is one priority set with a per board priority/#define and this one is hard coded? I'm not saying "Don't," I'm just trying to understand why. |
@@ -199,6 +199,17 @@ module DocAuthRouter
# rubocop:enable Layout/LineLength
def self.doc_auth_vendor
+ if IdentityConfig.store.doc_auth_vendor_randomize
+ target_percent = IdentityConfig.store.doc_auth_vendor_randomize_percent
+
+ target_percent = target_percent > 100 ? 100 : target_percent
+ ... | [DocAuthErrorTranslatorProxy->[respond_to_missing?->[respond_to?],translate_generic_errors!->[t,errors],translate_doc_auth_errors!->[doc_auth_vendor,map!,warn,t,each,dup,delete],translate_form_response!->[processed_response,is_a?,translate_doc_auth_errors!,translate_generic_errors!],method_missing->[respond_to?,transla... | doc_auth_vendor - returns false if there is no vendor key. | can we input the user uuid and hash that? so we have something deterministic? otherwise this could flip clip for the same user in the middle of proofing |
@@ -1561,8 +1561,8 @@ int speed_main(int argc, char **argv)
#endif
#ifndef OPENSSL_NO_EC
if (strcmp(*argv, "ecdsa") == 0) {
- for (loop = 0; loop < OSSL_NELEM(ecdsa_choices); loop++)
- ecdsa_doit[ecdsa_choices[loop].retval] = 1;
+ for (loop = 0; loop < OSSL_NELEM(ecdsa_do... | [No CFG could be retrieved] | find the next job that can be executed Main entry point for the async_start_job loop. | Useless indirection through `retval` |
@@ -125,6 +125,12 @@ class FilesystemView(object):
"""
raise NotImplementedError
+ def get_projection_for_spec(self, spec):
+ """
+ Get the projection in this view for a spec.
+ """
+ raise NotImplementedError
+
def get_all_specs(self):
"""
... | [YamlFilesystemView->[unlink_meta_folder->[get_path_meta_folder],remove_specs->[get_all_specs],get_spec->[get_path_meta_folder],link_meta_folder->[get_path_meta_folder,merge],remove_extension->[check_added],check_added->[get_spec],remove_standalone->[unmerge,check_added],add_standalone->[check_added],print_status->[pri... | Remove a standalone package from the view. | I think this is fine but that any user of `YamlFilesystemView` that originally wanted to access `view.root` would now want to use this function. Therefore I think `view.root` should be replaced with `view._root` (i.e. that is now a private and internal detail of the view). Currently I don't think all build system imple... |
@@ -29,7 +29,7 @@ class Elpa(AutotoolsPackage, CudaPackage):
version('2015.11.001', sha256='c0761a92a31c08a4009c9688c85fc3fc8fde9b6ce05e514c3e1587cf045e9eba')
variant('openmp', default=False, description='Activates OpenMP support')
- variant('optflags', default=True, description='Build with optimization ... | [Elpa->[configure_args->[any,append,spec,extend,format],url_for_version->[str,Version,format],headers->[format,find_all_headers,join,satisfies],libs->[find_libraries],variant,depends_on,version]] | This function returns a list of all the sequence IDs that are available on the MCPC Get a list of all libraries and dependencies for a specific version. | Is there a reason for activating `-O2` only for GCC? Even though the optimizations may be different across compilers and versions of the same compiler, `-O2` is supposed to be a generic flag understood by all compilers. |
@@ -27,7 +27,7 @@
#include <stdlib.h>
-static const char *paths[3] = {
+static const char *paths[4] = {
"/usr/lib/x86_64-linux-gnu/libavahi-client.so.3",
"/usr/lib/libavahi-client.so.3",
"/usr/lib64/libavahi-client.so.3",
| [const->[stat,getenv],loadavahi->[dlsym,getavahipath,dlopen]] | This file is part of CFEngine 3 - written and maintained by CFEngine AS. Get the names of the symbols that are available in the Akhi system. | Better to simply leave out the array-size altogether. Then, next time someone adds an entry to the array, forgetting up update this line won't be a problem ! |
@@ -155,6 +155,7 @@ function printArgvMessages() {
firefox: 'Running tests on Firefox.',
ie: 'Running tests on IE.',
edge: 'Running tests on Edge.',
+ 'chrome_canary': 'Running tests on Chrome Canary.',
saucelabs: 'Running integration tests on Sauce Labs browsers.',
saucelabs_lite: 'Running ... | [No CFG could be retrieved] | Prints help messages for all tests. Gulp - related command line interface for running unit tests. | nit: For uniformity, remove quotes around the `chrome_canary` key |
@@ -244,12 +244,12 @@ class SubmissionsController < ApplicationController
def browse
@assignment = Assignment.find(params[:assignment_id])
- @groupings = get_groupings_for_assignment(@assignment, current_user)
+ @groupings = Grouping.get_groupings_for_assignment(@assignment, current_user)
end
de... | [SubmissionsController->[downloads_subdirectories->[downloads_subdirectories]]] | This view shows the nag node for the current user. | Line is too long. [81/80] |
@@ -26,3 +26,11 @@ def test_external_repo(erepo):
assert path_isin(repo.cache.local.cache_dir, repo.root_dir)
assert mock.call_count == 1
+
+
+def test_external_repo_import_without_remote(erepo, dvc_repo):
+ src = erepo.CODE
+ dst = dvc_repo.root_dir
+
+ Repo.get(erepo.root_dir, src, ds... | [test_external_repo->[object,path_isin,read,join,open,external_repo]] | Test if external repository is available. | But `erepo` has default remote setup, so your test doesn't work at all. You need to remove default remote setting logic from erepo fixture, as it won't be needed, since you've introduced it in _external_repo in this PR. |
@@ -191,10 +191,10 @@ class TagsController < ::ApplicationController
discourse_expires_in 1.minute
tag_id = params[:tag_id]
- @link = "#{Discourse.base_url}/tags/#{tag_id}"
+ @link = "#{Discourse.base_url}/tag/#{tag_id}"
@description = I18n.t("rss_by_tag", tag: tag_id)
@title = "#{SiteSettin... | [TagsController->[destroy->[destroy],construct_url_with->[url_method]]] | This action shows a list of all topics with a given tag ID. It shows a list. | Should we use the rails url helper here instead? |
@@ -31,8 +31,12 @@ import org.jasig.cas.authentication.principal.Service;
* @version $Revision$ $Date$
* @since 3.1
*/
-public interface RegisteredService extends Cloneable, Serializable {
-
+public interface RegisteredService extends Cloneable, Serializable {
+ /**
+ * Default username attribute to re... | [No CFG could be retrieved] | Creates a new object that represents a single unique identifier. Returns a list of attributes that can be used to create a new object. | is this an implementation detail or does this actually belong on the interface? Also, for backwards compatibility why aren't we just assuming its empty? |
@@ -224,6 +224,17 @@ func (o *orm) SetPassword(user *User, newPassword string) error {
return o.db.Get(user, sql, hashedPassword, user.Email)
}
+func (o *orm) GenerateAuthToken(user *User) (*auth.Token, error) {
+ newToken := auth.NewToken()
+
+ err := o.SetAuthToken(user, newToken)
+ if err != nil {
+ return nil... | [CreateSession->[FindUser,GetUserWebAuthn],AuthorizedUserWithSession->[FindUser]] | SetPassword sets the password for the user. | Minor: the name of this method suggests that it's pure and not setting anything in the DB (i.e it's just generating a token and not updating a row in the database). Why not call `SetAuthToken(user, auth.NewToken())` instead? |
@@ -81,12 +81,12 @@ namespace System.Windows.Forms.ButtonInternal
return layout;
}
- internal double GetDpiScaleRatio(Graphics g)
+ internal double GetDpiScaleRatio()
{
- return GetDpiScaleRatio(g, Control);
+ return GetDpiScaleRatio(Control);
... | [CheckableControlBaseAdapter->[GetDpiScaleRatio->[GetDpiScaleRatio]]] | protected for testing. | Any thoughts whether the removal of `Graphics.DpiX` could regress printing scenarios? Things like `WM_PRINT` or `Control.DrawToBitmap` come to mind and printers usually use higher DPI. |
@@ -63,14 +63,16 @@ class LobbyModeButton extends AbstractButton<Props, any> {
* @param {Props} ownProps - The own props of the component.
* @returns {Props}
*/
-export function _mapStateToProps(state: Object): $Shape<Props> {
+export function _mapStateToProps(state: Object, ownProps: Props): $Shape<Props> {
... | [No CFG could be retrieved] | Map state to props of the component. | Doesn't is mean that the button will be visible if an explicit visible prop is passed to the button even if the feature should be disabled? Also, I think feature toggling means a more than hiding a button. This way we just replicate the interfaceConfig settings. Can you please consider adding some more checks? |
@@ -18,6 +18,13 @@ from dvc.utils.fs import path_isin
logger = logging.getLogger(__name__)
+class TqdmGit(Tqdm):
+ def update_git(self, op_code, cur_count, max_count=None, message=""):
+ if message:
+ self.set_description_str(message, refresh=False)
+ self.update_to(cur_count, max_count... | [Git->[_verify_dvc_hooks->[_verify_hook],is_dirty->[is_dirty],track_file->[add],ignore->[_ignored,_get_gitignore],has_rev->[resolve_rev],install->[_install_hook],cleanup_ignores->[ignore_remove],commit->[commit],checkout->[checkout],branch->[branch],_verify_hook->[_hook_path],tag->[tag],add->[add],close->[close],ignore... | Manages Git. LIBRARY_PATH - The library path of the package. | Hm, don't we need an `op_code`? It tells us which clone stage we are on. |
@@ -136,6 +136,15 @@ function filterFilter() {
};
} else {
comparator = function(obj, text) {
+ if (obj && text && typeof obj === 'object' && typeof text === 'object') {
+ for (var objKey in obj) {
+ if (objKey.charAt(0) !== '$' && hasOwnProperty.call(obj, objKe... | [No CFG could be retrieved] | Filters an array of objects based on a predicate object. Checks if text is in obj or not. | It would be nicer to add these nested checks as predicates to avoid a stack overflow, but this would be a much more complicated fix |
@@ -230,6 +230,9 @@ public class PrepareCommand extends AbstractTransactionBoundaryCommand {
}
Set<Object> set = new HashSet<>(modifications.length);
for (WriteCommand wc : modifications) {
+ if (wc.hasFlag(Flag.SKIP_LOCKING)) {
+ continue;
+ }
switch (wc.getCom... | [PrepareCommand->[copy->[PrepareCommand],compare->[compare],getAffectedKeysToLock->[getCommandId,getAffectedKeys],getAffectedKeys->[getAffectedKeys],toString->[toString]]] | Returns an array of keys that are affected by this write operation. | I am sorry to piggyback this change on yours. But it seems it would be more efficient to use a TreeSet if sort is true instead of sorting at the very end using the array. |
@@ -221,6 +221,7 @@ void sendAnnounce(AnnounceAction action,
server["damage"] = g_settings->getBool("enable_damage");
server["password"] = g_settings->getBool("disallow_empty_password");
server["pvp"] = g_settings->getBool("enable_pvp");
+ server["mod_channels"] = g_settings->getBo... | [No CFG could be retrieved] | Sends an announcement to the server. The clients_name parameter is a string of client names. | why does the serverlist need to know? |
@@ -1326,12 +1326,15 @@ class DistributeTranspiler(object):
elif op_type == "adamax":
if varkey in ["Moment", "InfNorm"]:
return param_shape
- elif op_type == "momentum":
+ elif op_type in ["momentum", "lars_momentum"]:
if varkey == "Velocity":
... | [DistributeTranspiler->[_append_pserver_ops->[_get_param_block->[same_or_split_var],_get_optimizer_input_shape,_get_param_block],get_startup_program->[_get_splited_name_and_shape->[same_or_split_var],_get_splited_name_and_shape],_create_ufind->[_is_op_connected],_orig_varname->[_get_varname_parts],_get_optimize_pass->[... | Returns the shape for optimizer inputs that need to be reshaped when Param and G. | add a else below to raise an exception? |
@@ -109,8 +109,7 @@ export function getIframe(parentWindow, parentElement, opt_type, opt_context) {
// Chrome does not reflect the iframe readystate.
this.readyState = 'complete';
};
- iframe.setAttribute('data-amp-3p-sentinel', attributes._context[
- sentinelNameChange ? 'sentinel' : 'amp3pSentinel'])... | [No CFG could be retrieved] | Adds data - and - json attributes from the element into the attributes object. Reads data - attribute from element and parses it as JSON. | Wait, we are changing the sentinel name. Shouldn't we do `iframe.setAttribute('data-sentinel`) here. 'data-amp-3p-sentinel` still used in other places. |
@@ -28,6 +28,15 @@ foreach ($plugin_guids as $guid) {
if ($plugin->activate()) {
$activated_guids[] = $guid;
+ $ids = array(
+ 'cannot_start' . $plugin->getID(),
+ 'invalid_and_deactivated_' . $plugin->getID()
+ );
+
+ foreach ($ids as $id) {
+ elgg_delete_admin_notice($id);
+ }
+
} else {
$msg = ... | [getID,getError,activate,getFriendlyName] | Activate a plugin or plugins forward to top of page with a failure. | The delete function checks existence, so this whole diff block could just be two elgg_delete_admin_notice() calls. |
@@ -5,9 +5,8 @@ import (
"log"
"net"
- "google.golang.org/grpc"
-
pb "github.com/harmony-one/harmony/api/services/syncing/downloader/proto"
+ "google.golang.org/grpc"
)
// Constants for downloader server.
| [Start->[Listen,NewServer,JoinHostPort,RegisterDownloaderServer,Fatalf,Serve],Query->[CalculateResponse]] | DownloaderPackageImports imports and starts a server which implements the DownloadInterface. | this will be removed |
@@ -297,6 +297,7 @@ func (l *Logger) Close() {
break
}
}
+ l.lock.Unlock()
for _, l := range l.outputs {
l.Flush()
l.Destroy()
| [Flush->[Flush],Fatal->[Close,writerMsg],Trace->[writerMsg],Info->[writerMsg],Critical->[writerMsg],Error->[writerMsg],Warn->[writerMsg],Close->[Flush],Debug->[writerMsg]] | Close closes all loggers. | Replace this with a defer on the line after the .Lock() call |
@@ -21,7 +21,10 @@ EXPORT_TEMPLATES = {
def send_email_with_link_to_download_file(
export_file: "ExportFile", template_name: str
):
- recipient_email = export_file.created_by.email
+ user = export_file.user
+ if not user:
+ return
+ recipient_email = user.email
send_kwargs, ctx = get_emai... | [send_export_failed_info->[export_failed_info_sent_event,get_email_context,send_templated_mail],send_email_with_link_to_download_file->[build_absolute_uri,get_email_context,export_file_sent_event,send_templated_mail]] | Sends an email with a link to download a file. | In what cases there will be no user? When an app is requesting the export? How would we provide the export results then? |
@@ -1792,6 +1792,9 @@ namespace Dynamo.Wpf.ViewModels.Watch3D
internal void UpdateNearClipPlane()
{
+
+ if (camera == null) return;
+
var near = camera.NearPlaneDistance;
var far = camera.FarPlaneDistance;
| [HelixWatch3DViewModel->[SetSelection->[FindAllGeometryModel3DsForNode],OnSceneItemsChanged->[UpdateSceneItems,OnRequestViewRefresh],OnWorkspaceCleared->[OnWorkspaceCleared],RemoveGeometryForUpdatedPackages->[DeleteGeometryForIdentifier],SaveCamera->[LogCameraWarning],OnWorkspaceSaving->[SerializeCamera],OnNodeProperty... | Updates the near - clip - plane distance and far - clip distance of the camera. | is there any situation for camera to be null? |
@@ -122,8 +122,10 @@ class Token:
}
log.debug('transfer called', **log_details)
+ startgas = 100000
transaction_hash = self.proxy.transact(
'transfer',
+ startgas,
to_checksum_address(to_address),
amount,
)
| [Token->[approve->[,TransactionThrew,debug,pex,poll,critical,balance_of,info,transact,check_transaction_threw,to_checksum_address],allowance->[allowance],balance_of->[balanceOf],__init__->[privatekey_to_address,ContractProxy,get_contract_abi,to_normalized_address,new_contract,is_binary_address,ValueError,check_address_... | Transfer a block of blocks from one node to another. | Can you make this a constant? |
@@ -588,7 +588,7 @@ public final class ByteBufUtil {
dst = alloc.buffer(length);
}
try {
- final ByteBuffer dstBuf = dst.internalNioBuffer(0, length);
+ final ByteBuffer dstBuf = dst.internalNioBuffer(dst.readerIndex(), length);
final int pos = dstBuf.po... | [ByteBufUtil->[writeAscii->[writeAscii],getBytes->[getBytes],appendPrettyHexDump->[appendPrettyHexDump],ThreadLocalDirectByteBuf->[newObject->[ThreadLocalDirectByteBuf],deallocate->[deallocate]],equals->[equals],writeUtf8->[writeUtf8],ThreadLocalUnsafeDirectByteBuf->[newObject->[ThreadLocalUnsafeDirectByteBuf],dealloca... | Encodes a string with a specified capacity. | thats fine that said it should not make any difference as we just allocated the buffer so the readerIndex() must be 0 |
@@ -24,13 +24,15 @@ import javax.validation.constraints.NotNull;
import java.util.List;
import java.util.Optional;
-@DefunctConfig("http.server.authentication.enabled")
+@DefunctConfig({
+ "http.server.authentication.enabled",
+ "http-server.authentication.allow-forwarded-https",
+ "dispatcher.... | [SecurityConfig->[setAuthenticationTypes->[copyOf,orElse],omitEmptyStrings,of]] | Gets the authentication types. | Format with trailing comma ```java "dispatcher.forwarded-header", }) |
@@ -156,6 +156,7 @@ public class S3InitiateMultipartUploadRequest extends OMKeyRequest {
.setReplicationFactor(keyArgs.getFactor())
.setObjectID(objectID)
.setUpdateID(transactionLogIndex)
+ .setFileHandleInfo(objectID)
.build();
omKeyInfo = new OmKeyInfo.Bu... | [S3InitiateMultipartUploadRequest->[preExecute->[getInitiateMultiPartUploadRequest,build,checkNotNull,now,setModificationTime],validateAndUpdateCache->[acquireWriteLock,getMultipartKey,getInitiateMultiPartUploadRequest,getUserInfo,checkNotNull,incNumInitiateMultipartUploadFails,getOmRequest,getVolumeName,incNumInitiate... | This method checks if the given object is in the cache and updates the cache with the object This method is called when multipart upload is initiated. It creates a new key object and stores Initiate multipart upload. | FileHandleInfo in OmMultipartKeyInfo object is not used anywhere. |
@@ -332,6 +332,14 @@ public interface Network extends ControlledEntity, StateObject<Network.State>, I
}
}
+ public enum NetworkFilter {
+ account, // return account networks that have been registered for or created by the calling user
+ domain, // return domain networks t... | [Service->[toString->[toString],containsCapability->[getName],Service],Provider->[toString->[toString],Provider],Capability->[toString->[toString],Capability],IpAddresses->[setMacAddress]] | Replies the state machine of the network. The ip4 address. | convention is to use all capitals for enum values (I think) |
@@ -23,7 +23,7 @@ import {
} from '../../../src/service/variable-source';
import {user, userAssert} from '../../../src/log';
-const WHITELISTED_VARIABLES = [
+const ALLOWED_VARIABLES = [
'AMPDOC_HOST',
'AMPDOC_HOSTNAME',
'AMPDOC_URL',
| [No CFG could be retrieved] | Creates an object that represents a single specific object in the AMP HTML Authors. Provides a variable source for A4A specific variable substitution. | We've been using `allowlist` elsewhere, can we be consistent with this name? `const ALLOWLISTED_VARIABLES = [` |
@@ -64,4 +64,11 @@ public class SourceMetadataTestCase extends MetadataExtensionFunctionalTestCase<
assertExpectedOutput(componentMetadata.getModel(), personType, typeLoader.load(StringAttributes.class));
assertThat(componentMetadata.getMetadataAttributes().getKey().get(), is(PERSON_METADATA_KEY));
}
+
+ ... | [SourceMetadataTestCase->[getSourceDynamicOutputMetadata->[getModel,getComponentDynamicMetadata,get,is,isSuccess,assertThat,assertExpectedOutput,load],getSourceMetadataKeys->[getKeysFromContainer,size,get,getMetadataKeys,hasItems,is,isSuccess,metadataKeyWithId,assertThat],getSourceMetadata,build]] | Checks that the source dynamic output metadata is present. | this doesn't work, classloading issues |
@@ -365,6 +365,16 @@ export class AmpAd3PImpl extends AMP.BaseElement {
return this.uiHandler.createPlaceholder();
}
+ /**
+ * @returns {!Promise<?CONSENT_POLICY_STATE>}
+ */
+ getConsentState() {
+ const consentPolicyId = super.getConsentPolicy();
+ return consentPolicyId
+ ? getConsentPolic... | [No CFG could be retrieved] | Initializes the x - origin iframe handler and calls the appropriate methods to handle the event. Attempt to resize to the requested height. | I can't remember does this change? Trying to think of a clever way to not repeat most of this method above. |
@@ -140,9 +140,12 @@ def find(parser, args):
# Exit early if no package matches the constraint
if not query_specs and args.constraint:
- msg = "No package matches the query: {0}"
+ msg = "No installed package matches the query: {0}"
msg = msg.format(' '.join(args.constraint))
- ... | [query_arguments->[getattr,pretty_string_to_date],find->[msg,packages_with_tags,len,display_specs,format,join,query_arguments,specs,isatty],setup_parser->[add_common_arguments,add_mutually_exclusive_group,add_argument]] | Find a package by name. | Use `{1}` for Python 2.6 support. |
@@ -342,7 +342,7 @@ public class Jenkins extends AbstractCIBase implements DirectlyModifiableTopLeve
/**
* The Jenkins instance startup type i.e. NEW, UPGRADE etc
*/
- private String installStateName;
+ private transient String installStateName;
@Deprecated
private InstallState instal... | [Jenkins->[getUser->[get],_cleanUpShutdownTcpSlaveAgent->[add],setNumExecutors->[updateComputerList],getPlugin->[getPlugin],getCategorizedManagementLinks->[all,add],getViewActions->[getActions],getJDK->[getJDKs,get],setViews->[addView],getCloud->[getByName],getStaplerFallback->[getPrimaryView],getStoredVersion->[get],g... | A base class for all of the items that are related to a single node. Controls what the is handled by Jenkins. | Probably a regression when you restart Jenkins during the setup wizard (can happen when installing a plugin that cannot be dynamically loaded IIRC). |
@@ -11,12 +11,11 @@ namespace Microsoft.Extensions.Hosting.Internal
{
public static void ApplicationError(this ILogger logger, EventId eventId, string message, Exception exception)
{
- var reflectionTypeLoadException = exception as ReflectionTypeLoadException;
- if (reflecti... | [HostingLoggerExtensions->[Stopped->[Stopped],StoppedWithException->[StoppedWithException],Stopping->[Stopping],Starting->[Starting],BackgroundServiceFaulted->[BackgroundServiceFaulted],Started->[Started]]] | Application error. | This change is unnecessary. Can you revert it? Note that they both compile into the exact same IL. |
@@ -206,7 +206,7 @@ class AssignmentsController < ApplicationController
csv << row
end
end
- send_data csv_string, :disposition => 'attachment', :filename => "#{COURSE_NAME}_grades_report.csv"
+ send_data csv_string, disposition: 'attachment', filename: "#{COURSE_NAME}_grades_report.csv"
e... | [AssignmentsController->[new->[new],decline_invitation->[decline_invitation]]] | downloads the grades report of the user that have not been used in any group. | Line is too long. [97/80] |
@@ -320,6 +320,13 @@ ActiveRecord::Schema.define(version: 20190109212351) do
t.index ["reporter_id"], name: "index_feedback_messages_on_reporter_id"
end
+ create_table "flipflop_features", force: :cascade do |t|
+ t.datetime "created_at", null: false
+ t.boolean "enabled", default: false, null: false
+... | [jsonb,bigint,decimal,text,string,add_foreign_key,datetime,integer,enable_extension,create_table,float,boolean,index,define,inet] | Table for the following and feedback messages create a table of following issues. | This table shouldn't exist. It's probably because your development database is behind. |
@@ -148,10 +148,12 @@ public class CxfOutboundMessageProcessor extends AbstractInterceptingMessageProc
MuleException muleException = (MuleException) fault.getCause();
return alwaysReturnMessagingException ? new MessagingException(event, muleException, this) : muleException;
}
- return new ... | [CxfOutboundMessageProcessor->[doSendWithProxy->[getArgs,wrapException],process->[cleanup],doSendWithClient->[handleException->[wrapException],getArgs,wrapException],getBindingOperationFromEndpoint->[getOperation],getOperation->[getOperation,getMethodOrOperationName],wrapException->[wrapException],getMethodFromOperatio... | Wrap exception in a MessagingException. | Why do we need a MessagingException here? |
@@ -14,6 +14,7 @@
*/
package org.apache.zeppelin.jdbc;
+import static javax.swing.plaf.basic.BasicHTML.propertyKey;
import static org.apache.commons.lang.StringUtils.containsIgnoreCase;
import java.io.*;
import java.nio.charset.StandardCharsets;
| [JDBCInterpreter->[setUserProperty->[setUserProperty,getJDBCConfiguration,getUsernamePassword,existAccountInBaseProperty,closeDBPool,getEntityName],completion->[getPropertyKey],getUsernamePassword->[getUsernamePassword],initStatementMap->[initStatementMap],executeSql->[isDDLCommand,getResults,getConnection,close,closeD... | Imports a single object. missing. c ++ code. | Is `javax.swing` really required here? |
@@ -84,8 +84,10 @@ import com.cloud.api.query.vo.TemplateJoinVO;
import com.cloud.api.query.vo.UserAccountJoinVO;
import com.cloud.api.query.vo.UserVmJoinVO;
import com.cloud.api.query.vo.VolumeJoinVO;
-import com.cloud.storage.StoragePoolTagVO;
+import com.cloud.configuration.Resource;
+import com.cloud.domain.Doma... | [ViewResponseHelper->[setParentResourceLimitIfNeeded->[setParentResourceLimitIfNeeded,searchParentDomainUsingBinary],createUserResponse->[createUserResponse],createUserVmResponse->[createUserVmResponse],createProjectAccountResponse->[createUserResponse]]] | Imports a single response object from a service. This class generates response from DB view VO objects. | this file is not changed. better remove the diff from the PR |
@@ -518,14 +518,13 @@ function check_smarty3(&$checks) {
}
function check_htaccess(&$checks) {
- $a = get_app();
$status = true;
$help = "";
if (function_exists('curl_init')){
- $test = fetch_url($a->get_baseurl()."/install/testrewrite");
+ $test = fetch_url(App::get_baseurl()."/install/testrewrite");
... | [what_next->[get_baseurl],install_content->[get_baseurl],install_post->[get_path],install_init->[get_baseurl],check_htaccess->[get_baseurl]] | Checks if the url rewrite is working on the server. | Standards: Could you please add a space before the opening bracket? |
@@ -175,6 +175,9 @@ class CI_Form_validation {
// If the field label wasn't passed we use the field name
$label = isset($row['label']) ? $row['label'] : $row['field'];
+ // Add the custom error message array
+ $error_msg = (isset($row['error_msg']) && is_array($row['error_msg']) ) ? $row['error_msg'] ... | [CI_Form_validation->[set_rules->[set_rules],_execute->[_execute],strip_image_tags->[strip_image_tags],xss_clean->[xss_clean],valid_emails->[valid_email],run->[set_rules],set_checkbox->[set_radio],valid_ip->[valid_ip],prep_for_form->[prep_for_form],_reduce_array->[_reduce_array]]] | Set the rules for a field Build the master array of the field_data. | Picky, but please remove the space between the last two closing parenthesis. :) |
@@ -59,8 +59,12 @@ static int do_sigver_init(EVP_MD_CTX *ctx, EVP_PKEY_CTX **pctx,
ctx->provctx = NULL;
}
- if (ctx->pctx == NULL)
- ctx->pctx = EVP_PKEY_CTX_new(pkey, e);
+ if (ctx->pctx == NULL) {
+ if (libctx != NULL)
+ ctx->pctx = EVP_PKEY_CTX_new_from_pkey(libctx, pke... | [EVP_DigestSign->[EVP_DigestSignFinal,EVP_DigestSignUpdate],EVP_DigestVerify->[EVP_DigestVerifyUpdate,EVP_DigestVerifyFinal]] | Initialize the given key context. if necessary checks if the key is in the system and if so frees the keymgmt if necessary checks if a key is not found in the digest table and if so calls the check if the key is legacy X_set_signature_md - check if the current key is a custom signature -. | And what do you do in the `ctx->pctx != NULL && ctx->pctx->libctx != NULL && libctx != NULL` case? Why is one chosen over the other? Could that be problematic? |
@@ -1035,6 +1035,9 @@ public class InterpreterSettingManager implements NoteEventListener, ClusterEven
}
File localRepoDir = new File(conf.getInterpreterLocalRepoPath() + "/" + id);
+ if (localRepoDir.getAbsolutePath().contains("..")) {
+ return removed;
+ }
FileUtils.deleteDirectory(localRe... | [InterpreterSettingManager->[getDefaultInterpreterSetting->[get,getByName],get->[get],removeInterpreterGroup->[removeInterpreterGroup],getAllResourcesExcept->[getAllInterpreterGroup],close->[close],removeRepository->[saveToFile],onClusterEvent->[inlineRemove,get,inlineSetPropertyAndRestart,inlineCreateNewSetting],resta... | Remove interpreter setting from interpreter groups and local repository. | Any idea why deleting the localRepoDir is not part of the if block? |
@@ -57,10 +57,6 @@ class PythonDistribution(PythonTarget):
def has_native_sources(self):
return self.has_sources(extension=tuple(self.native_source_extensions))
- @property
- def platforms(self):
- return ['current']
-
@property
def setup_requires(self):
return self.payload.setup_requires
| [PythonDistribution->[has_native_sources->[tuple,has_sources],__init__->[Payload,TargetDefinitionException,PrimitiveField,super,maybe_list,add_fields]]] | Returns a list of all native sources. | Note that this is part of removing `PythonDistribution` from `may_have_explicit_python_platform()` in `pex_build_util.py`. |
@@ -133,8 +133,8 @@ public class FlinkJobInvocation implements JobInvocation {
RunnerApi.Pipeline fusedPipeline =
trimmedPipeline.getComponents().getTransformsMap().values().stream()
.anyMatch(proto -> ExecutableStage.URN.equals(proto.getSpec().getUrn()))
- ? pipeline
- ... | [FlinkJobInvocation->[runPipelineWithTranslator->[create],addStateListener->[getState],create->[FlinkJobInvocation],removeDescendants->[removeDescendants],cancel->[onSuccess->[cancel],cancel,getId]]] | Runs the given pipeline with the given translator. | Thanks for spotting. Looks like a bug caused by rebasing to the latest master. CC @robertwb |
@@ -181,6 +181,8 @@ MiddlewareRegistry.register(({ dispatch, getState }) => next => action => {
if (soundID) {
dispatch(playSound(soundID));
}
+
+ APP.API.notifyRecordingStatusChanged(true, mode);
} else if (updatedSessionData.status ===... | [No CFG could be retrieved] | The action that is executed when a new session is created. This method sends a stop event to the JIT server. | @saghul is this ok for mobile? |
@@ -120,7 +120,11 @@ func (d Darwin) homeDir(dirs ...string) string {
return filepath.Join(dirs...)
}
-func (d Darwin) CacheDir() string { return d.homeDir(d.Home(false), "Library", "Caches") }
+func (d Darwin) CacheDir() string { return d.homeDir(d.Home(false), "Library", "Caches") }
+func (d Darw... | [Home->[Split,Join,Unsplit],RuntimeDir->[Home,CacheDir,dirHelper],LogDir->[Join,CacheDir,Home],Join->[Join],homeDir->[Join],CacheDir->[homeDir,Home,dirHelper],Normalize->[Unsplit,Split],dirHelper->[Join,Home],Split->[Split],ConfigDir->[homeDir,Home,dirHelper],DataDir->[ConfigDir,Home,dirHelper],ServiceSpawnDir->[Runtim... | homeDir returns the path to the application s home directory. | Lower case `"keybase"`? |
@@ -2247,8 +2247,8 @@ public class LibvirtComputingResource extends ServerResourceBase implements Serv
if (MapUtils.isNotEmpty(customParams) && customParams.containsKey(GuestDef.BootType.UEFI.toString())) {
guest.setBootType(GuestDef.BootType.UEFI);
guest.setBootMode(GuestDef.BootMode... | [LibvirtComputingResource->[getInterfaces->[getInterfaces],isSnapshotSupported->[executeBashScript],getNetworkStats->[networkUsage],getVifDriver->[getVifDriver],cleanupVMNetworks->[getAllVifDrivers],checkNetwork->[getVifDriver],cleanupNetworkElementCommand->[vifHotUnPlug,VifHotPlug],getVPCNetworkStats->[configureVPCNet... | create a new virtual machine from the given VM specification. Sets the guest architecture. Adds a missing configuration to the VM. Private method for creating a new object. Adds a device that can be found in the system. | should we make assumptions about running on intel platforms and/or would that hurt? cc @wido @rhtyd #raspberryrules |
@@ -1275,11 +1275,10 @@ public abstract class NuxeoLauncher {
gzip ? ".gz" : ""));
}
log.info("Dumping connect report in " + outputpath);
- OutputStream output = Files.newOutputStream(outputpath, StandardOpenOption.TRUNCATE_EXISTING, StandardOpenOption.CREAT... | [NuxeoLauncher->[launch->[start,commandRequiresNoRunningServer,checkNoRunningServer,commandIs],setJSONOutput->[setXMLOutput],initConnectBroker->[getInfo],pkgRemove->[pkgRemove],isRunning->[getPid],logProcessStreams->[start],removeShutdownHook->[removeShutdownHook],configure->[run,checkNoRunningServer],setDebug->[setDeb... | Launches the Nuxeo launcher. This method is called when the user clicks on a command. This method is called when the command is executed. Dump the connect report and exit if command failed. | `GZIPOutputStream` should be closed, `GZIPOutputStream#close` performs additional operations. Extract to a method `OutputStream` instantiation should do the work. |
@@ -2587,7 +2587,7 @@ int s_client_main(int argc, char **argv)
BIO *ldapbio = BIO_new(BIO_s_mem());
CONF *cnf = NCONF_new(NULL);
- if (cnf == NULL) {
+ if (ldapbio == NULL || cnf == NULL) {
BIO_free(ldapbio);
goto end;
}
| [No CFG could be retrieved] | - - - - - - - - - - - - - - - - - - END of function init. | You also need to free `cnf`. |
@@ -93,9 +93,13 @@ Remove it once the issue is closed
"chai-as-promised": "7.1.1",
"chai-string": "1.5.0",
<%_ } _%>
+ "circular-dependency-plugin": "5.0.2",
"codelyzer": "5.1.0",
"copy-webpack-plugin": "5.0.3",
"css-loader": "3.0.0",
+ "eslint": "5.16.0",
+ "eslint-config-prettie... | [No CFG could be retrieved] | The devDependencies of the webpack module. The version of the compiler is the latest version of the compiler. 7. 1. 0. | I believe that the circular dependency issues should be resolved after removing barrel files. Do we still require this plugin? Did you find any circular dependency issues in code after removing barrels? I will prefer to keep build slim and not include by default unless it provides a value add. |
@@ -135,10 +135,10 @@ func resourceComputeInstance() *schema.Resource {
},
"disk": &schema.Schema{
- Type: schema.TypeList,
- Optional: true,
- ForceNew: true,
- Deprecated: "Use boot_disk, scratch_disk, and attached_disk instead",
+ Type: schema.TypeList,
+ Optional: true,
+ ... | [GetChange,NewSet,SetPartial,SetLabels,StringInSlice,SetScheduling,SetTags,Delete,Partial,Set,DeleteAccessConfig,MatchString,GetOk,FindStringSubmatch,IntAtLeast,HasChange,SetMetadata,Errorf,Len,SetId,MustCompile,Bool,Sum256,Do,SetConnInfo,Id,AddAccessConfig,DecodeString,Get,Split,Printf,Sprintf,List,Insert,EncodeToStri... | Elem schema for all resources with no explicit schema. Schema for the n - block header. | I'm okay with this but I just want to point it out. It might be good having it at the same time as the migration fn? That way we're saying "hey we're getting rid of this but hypothetically you don't need to do anything to replace it". I'm a bit nervous that we'll find a bug in the migration and people will be stuck tho... |
@@ -77,7 +77,10 @@ function dol_getImageSize($file, $url = false)
$fichier = $file;
if (!$url)
{
- $fichier = realpath($file); // Chemin canonique absolu de l'image
+ $fichier = realpath(dol_osencode($file)); // Chemin canonique absolu de l'image
+ // if problem with realpath
+ if ($fichier == false)
+ re... | [dol_imageResizeOrCrop->[trans],vignette->[trans]] | Dolique un image . | If you need dol_osencode of $file, you probably need it 3 lines later $dir = dirname($file); don't you ? |
@@ -19,6 +19,7 @@
#endif
#include "prov/provider_util.h"
#include "internal/nelem.h"
+#include "crypto/evp.h"
void ossl_prov_cipher_reset(PROV_CIPHER *pc)
{
| [ossl_prov_macctx_load_from_params->[ossl_prov_set_macctx]] | if ossl_prov_cipher_reset is called this method will free the cipher allocated. | The "fips change" is quite surprising since all the changes below are contained within "ifndef FIPS_MODULE" - but I suppose it is this include that does it. Could we move it inside the "ifndef FIPS_MODULE" above? |
@@ -563,7 +563,7 @@ const (
// there.
var MaxMessageBoxedVersion MessageBoxedVersion = MessageBoxedVersion_V4
var MaxHeaderVersion HeaderPlaintextVersion = HeaderPlaintextVersion_V1
-var MaxBodyVersion BodyPlaintextVersion = BodyPlaintextVersion_V1
+var MaxBodyVersion BodyPlaintextVersion = BodyPlaintextVersion_V2
... | [Matches->[SenderUsername,ChannelMention,Ctime,AtMentionUsernames],GetMaxDeletedUpTo->[GetMessageID,GetExpunge,GetMaxMessage],IsUnreadFromMsgID->[MaxVisibleMsgID],Eq->[Eq,Bytes],Etime->[EphemeralMetadata],Summary->[GetMessageID,GetMessageType],Derivable->[Hash],IsVisible->[GetMessageType],ChannelMention->[IsValid],IsVa... | ParseableVersion returns true if the version of the error is greater than or equal to the. | does the server need this vendored? |
@@ -484,8 +484,8 @@ class TableItem(object):
:ivar str name: The name of the table.
"""
- def __init__(self, name, **kwargs): # pylint: disable=unused-argument
- # type: (str, Dict[str, Any]) -> None
+ def __init__(self, name):
+ # type: (str) -> None
"""
:param str na... | [TableSasPermissions->[__or__->[TableSasPermissions],__add__->[TableSasPermissions]],service_properties_deserialize->[_from_generated],TableAnalyticsLogging->[_from_generated->[_from_generated]],Metrics->[_from_generated->[_from_generated]],TablePropertiesPaged->[_extract_data_cb->[_from_generated]]] | Initialize a missing - argument object with a name. | Can we remove **kwargs here? |
@@ -239,7 +239,7 @@ class GrowthWelcome extends Component {
</div>
</div>
<div
- className={`${isMobile ? 'd-none' : ''} origin-showcase col-10`}
+ className={`${isMobile ? 'd-none' : ''} origin-showcase col-8`}
/>
</div>
</div>
| [No CFG could be retrieved] | Displays a list of all of the elements of a single unique identifier. Renders a hidden element that shows the hidden element and a button to show the hidden element. | Just a thought. We can probably remove the `${isMobile ? 'd-none' : ''}` and do it with CSS media queries. That doesn't have to be in JS if we are just hiding it. May be we can also just skip rendering the element on Mobile. |
@@ -22,7 +22,7 @@ class ResetUserPasswordAndSendEmail
user = User.find_with_email(email)
if user
ResetUserPassword.new(user: user).call
- UserMailer.please_reset_password(email).deliver_now
+ UserMailer.please_reset_password(user).each(&:deliver_now)
Kernel.puts "Email sent... | [ResetUserPasswordAndSendEmail->[reset_password_and_send_email_to_each_affected_user->[call]]] | reset password and send email to affected users. | This should iterate over the email addresses and create a mailer for each one. |
@@ -52,7 +52,7 @@ public class LanguageUtilsTest extends RobolectricTest {
"de", "el", "en", "eo", "es-AR", "es-ES", "et", "eu", "fa", "fi", "fil", "fr", "fy-NL", "ga-IE", "gl", "got",
"gu-IN", "he", "hi", "hr", "hu", "hy-AM", "id", "is", "it", "ja", "jv", "ka", "kk", "km", "ko", "ku",
... | [LanguageUtilsTest->[testNoLanguageIsRemoved->[removeAll,asList,addAll,assertThat,hasItem],localeTwoLetterCodeResolves->[assertThat,is,getDisplayLanguage],localeThreeLetterCodeResolves->[assertThat,is,getDisplayLanguage],testCurrentLanguagesHaveNotChanged->[asList,contains,assertThat],localeThreeLetterRegionalVariantRe... | This test tests the language of a node. Test if the previous languages are removed. | Note to self: This should have required PREVIOUS_LANGUAGES to change as well. |
@@ -163,7 +163,17 @@ namespace System.Security.Cryptography.Dsa.Tests
Assert.Throws<ObjectDisposedException>(
() =>
{
- key.KeySize = 576;
+ try
+ {
+ key.KeySize = 576;
+ }
... | [DSASignVerify_Span->[UseAfterDispose->[UseAfterDispose],VerifyData->[VerifyData]],DSASignVerify_Stream->[VerifyData->[VerifyData],SignData->[SignData],InvalidArrayArguments_Throws->[VerifyData,SignData]],DSASignVerify_Array->[UseAfterDispose->[UseAfterDispose],InvalidStreamArrayArguments_Throws->[VerifyData,SignData],... | This method is called after disposing the DSA object. | Exception filters are problematic in AOT scenarios. I would move this check inside the catch block. |
@@ -300,7 +300,6 @@ class IssueEntryPublicationMetadataForm extends Form {
$publishedArticle = $publishedArticleDao->newDataObject();
$publishedArticle->setId($submission->getId());
$publishedArticle->setIssueId($issueId);
- $publishedArticle->setDatePublished(Core::getCurrentDate());
$publi... | [IssueEntryPublicationMetadataForm->[execute->[getSubmission]]] | This method is called by the controller to handle the request This method is used to create a PublishedArticle object from the current submission This function re - indexes the published article metadata and files for the first time. | What about article that were not scheduled to an issue but are scheduled right now -- their date_published would be empty which is not good I believe -- the current date i.e. the date when an issue is assigned should be there per default, I believe. I can double check, how is it in the current master branch, but I am p... |
@@ -606,7 +606,7 @@ public class FTPTransfer implements FileTransfer {
client.setAutodetectUTF8(useUtf8Encoding);
}
- client.connect(inetAddress, ctx.getProperty(PORT).evaluateAttributeExpressions(flowFile).asInteger());
+ client.connect(remoteHostName, ctx.getProperty(PORT).evalua... | [FTPTransfer->[getRemoteFile->[close],getListing->[getListing],validateProxySpec->[validateProxySpec],ensureDirectoryExists->[ensureDirectoryExists],put->[setAndGetWorkingDirectory],deleteFile->[setWorkingDirectory,deleteFile],getRemoteFileInfo->[newFileInfo],rename->[rename],getClient->[resetWorkingDirectory,close,cre... | Get the FTP client for the given flow file. Get a connection to the server. | This change as-is needs more work. We create the inetAddress in previous lines using this remoteHostName value. This change just ignores all those lines. So we need to understand why those other lines aren't needed anymore and remove them. There is a proxyHostname property available too. Makes me wonder if we're using ... |
@@ -302,6 +302,14 @@ class AmpDailymotion extends AMP.BaseElement {
const implicitParams = getDataParamsFromAttributes(this.element);
iframeSrc = addParamsToUrl(iframeSrc, implicitParams);
+ // In order to support autoplay the video needs to be muted on load so we
+ // dont receive an unmute event whi... | [No CFG could be retrieved] | Sends a command to the player through postMessage. private method to simulate firing of play pause and mute events when video is playing. | What sends the unmute event? |
@@ -113,7 +113,12 @@ public final class ReverseBuildTrigger extends Trigger<Job> implements Dependenc
return false;
}
// This checks Item.READ also on parent folders; note we are checking as the upstream auth currently:
- boolean downstreamVisible = jenkins.getItemByFullName(job.ge... | [ReverseBuildTrigger->[start->[start],buildDependencyGraph->[shouldTriggerBuild->[shouldTrigger]],stop->[stop],RunListenerImpl->[get->[get],calculateCache->[get],onCompleted->[get,calculateCache,shouldTrigger]]]] | Checks if a build should trigger based on the upstream build and the threshold. | downstream is discoverable (visible?), but not readable. There is some terminology mess, which IMHO leads to incorrect messages below in this case. |
@@ -149,7 +149,7 @@ class FormatOptions
*
* @return FormatOptions
*/
- public function setFormatKey($formatKey)
+ public function setFormatKey(string $formatKey): self
{
$this->formatKey = $formatKey;
| [No CFG could be retrieved] | set formatKey - set formatKey. | same as above we can from bc not add new typehints. |
@@ -46,7 +46,7 @@ function currencyFilter($locale) {
var formats = $locale.NUMBER_FORMATS;
return function(amount, currencySymbol){
if (isUndefined(currencySymbol)) currencySymbol = formats.CURRENCY_SYM;
- return formatNumber(amount, formats.PATTERNS[1], formats.GROUP_SEP, formats.DECIMAL_SEP, 2).
+ re... | [No CFG could be retrieved] | - A component that checks if a number is valid and returns it as a string. Rounds the number to the specified number of fractional digits and places a “. | @caitp, this is the primary fix here. The `formatNumber` function below already supported doing the formatting precision based on the pattern already passed here. So, I removed the obviously accidental force to the 2 decimal precision. |
@@ -0,0 +1,7 @@
+require "elasticsearch"
+
+Search = Elasticsearch::Client.new(
+ url: ApplicationConfig["ELASTICSEARCH_URL"],
+ retry_on_failure: 5,
+ request_timeout: 30,
+)
| [No CFG could be retrieved] | No Summary Found. | Since we explicitly install the dependency, I think it makes sense to specify `adapter: :typhoeus` to the options instead of relying on the private ` __auto_detect_adapter` helper method in `Elasticsearch::Transport`. |
@@ -79,8 +79,8 @@ public final class MockSCMHAManager implements SCMHAManager {
* {@inheritDoc}
*/
@Override
- public boolean isLeader() {
- return isLeader;
+ public Optional<Long> isLeader() {
+ return isLeader ? Optional.of((long)0) : Optional.empty();
}
public void setIsLeader(boolean isL... | [MockSCMHAManager->[start->[start],getFollowerInstance->[MockSCMHAManager],getLeaderInstance->[MockSCMHAManager],getInstance->[MockSCMHAManager]]] | This method is called when the node is leader. | another challenge is how to test such change. ideally we can have a minicluster setup with configurable nodes so we can simulate the scenario of split brian. |
@@ -1322,6 +1322,16 @@ func GetMaileableUsersByIDs(ids []int64) ([]*User, error) {
Find(&ous)
}
+// GetUsernamesByIDs returns usernames for all resolved users from a list of Ids.
+func GetUsernamesByIDs(ids []int64) ([]string, error) {
+ ous, err := GetUsersByIDs(ids)
+ unames := make([]string, 0, len(ous))
+ for... | [RealSizedAvatarLink->[CustomAvatarPath,GenerateRandomAvatar],NewGitSig->[GetEmail],AvatarLink->[RelAvatarLink],RelAvatarLink->[SizedRelAvatarLink],GetOrganizationCount->[getOrganizationCount],GetAccessRepoIDs->[GetRepositoryIDs,GetOrgRepositoryIDs],APIFormat->[GetEmail],DeleteAvatar->[CustomAvatarPath],UploadAvatar->[... | checkDupEmail checks whether there is a duplicate email with the user and if it does it deleteUser deletes all beans and user from database. | rename to GetUserNamesByIDs ? |
@@ -1,6 +1,6 @@
# -*- encoding : utf-8 -*-
-class CreateFoiAttachments < ActiveRecord::Migration
+class CreateFoiAttachments < !rails5? ? ActiveRecord::Migration : ActiveRecord::Migration[4.2] # 2.3
def self.up
create_table :foi_attachments do |t|
t.column :content_type, :text
| [CreateFoiAttachments->[up->[column,create_table],down->[drop_table]]] | Create the table for Foi attachments. | Line is too long. [100/80] |
@@ -556,9 +556,12 @@ export class Resource {
* @return {boolean}
*/
isDisplayed() {
- return (this.layoutBox_.height > 0 && this.layoutBox_.width > 0 &&
+ const isFluid = this.element.getLayout() == Layout.FLUID;
+ const hasNonZeroSize = this.layoutBox_.height > 0 &&
+ this.layoutBox_.width >... | [No CFG could be retrieved] | Returns the layout box of the element relative to the viewport. Private method for rendering the underlying element outside of the viewport. | you don't actually need the > here unless you expect a negative value |
@@ -462,12 +462,14 @@ public class RabbitMqIO {
@Override
public boolean advance() throws IOException {
try {
- QueueingConsumer.Delivery delivery = consumer.nextDelivery(1000);
+ Channel channel = connectionHandler.getChannel();
+ // we consume message without autoAck (we want to ... | [RabbitMqIO->[RabbitMQSource->[requiresDeduping->[useCorrelationId]],Read->[withQueueDeclare->[build],expand->[maxReadTime,withMaxNumRecords,maxNumRecords],withExchange->[build],withUri->[build],withMaxReadTime->[maxNumRecords,build],withQueue->[build],withMaxNumRecords->[maxReadTime,build],withUseCorrelationId->[build... | Advances the checkpoint mark. | Important change: previously the caller would wait for up to 1s for a message to be available. This PR's implementation would return `false` immediately (technically after a network hop). The semantics of this change is unclear to me but from what I can tell, this should be "fine" at worst and an improvement at best. |
@@ -9,6 +9,10 @@
<%= label_tag :type, "Type:" %>
<%= select_tag "type_of", options_for_select(%w[Welcome Announcement], selected: @broadcast.type_of) %>
</div>
+<div class="form-group">
+ <%= label_tag :banner_style, "Banner Style:" %>
+ <%= select_tag "banner_style", options_for_select(%w[default brand succes... | [No CFG could be retrieved] | Renders the hidden field in the UI for the national element of the network. | the repetition of the styles reminds me we should put it in a constant in the model |
@@ -19,11 +19,11 @@ namespace System.Threading.Tasks
/// The continuation to invoke when the operation completes, or <see cref="s_completionSentinel"/> if the operation
/// has completed before OnCompleted is called.
/// </summary>
- private Action _continuation;
+ private Actio... | [RendezvousAwaitable->[UnsafeOnCompleted->[OnCompleted]]] | Creates a new object that can be used to run a async operation asynchronously. Get the result of a continuation. | Why `AllowNull`? Why not `default!`? |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.