patch
stringlengths
18
160k
callgraph
stringlengths
4
179k
summary
stringlengths
4
947
msg
stringlengths
6
3.42k
@@ -636,9 +636,13 @@ def purge(): """Remove all build directories in the top-level stage path.""" root = get_stage_root() if os.path.isdir(root): + # TODO: Figure out a "standard" way to identify the hash length + # TODO: Should this support alternate base represenations? + dir_expr ...
[Stage->[check->[check],fetch->[generate_fetchers,fetch],__init__->[get_stage_root]],purge->[get_stage_root],get_stage_root->[_first_accessible_path],StageComposite->[__exit__->[__exit__],__enter__->[__enter__]]]
Remove all build directories in the top - level stage path.
(question) Is this to avoid the issue where the the stage root includes non-spack files/directories?
@@ -219,9 +219,8 @@ type Cortex struct { StoreGateway *storegateway.StoreGateway MemberlistKV *memberlist.KVInitService - // Queryables that the querier should use to query the long - // term storage. It depends on the storage engine used. - StoreQueryables []querier.QueryableWithFilter + Queryable prom_storage.S...
[RegisterFlags->[RegisterFlags],Validate->[Validate]]
New creates a new Cortex object. middleware. ServerUserHeaderInterceptor is a middleware that will be applied to the user header.
Naming it `QueryEngine` could help to avoid ambiguities.
@@ -2533,8 +2533,9 @@ class FunctionSpec(object): """ args = list(self._arg_names) if default_values: - for (i, default) in self._arg_indices_to_default_values.items(): - args[i] += "={}".format(default) + offset = len(args) - len(self._fullargspec.defaults) + for i, default in enum...
[_FirstOrderTapeGradientFunctions->[_forward_and_backward_functions->[_build_functions_for_outputs]],_convert_numpy_inputs->[_is_ndarray,_as_ndarray],Function->[_maybe_define_function->[canonicalize_function_inputs,_create_graph_function,_define_function_with_shape_relaxation,_cache_key],_create_graph_function->[Concre...
Returns a string summarizing this function s signature. .
this offset should be 'len(self._arg_names) - len(self._fullargspec.defaults or [])'. Args here is the one passed during calling execution, self._arg_names is the name in function definition. Your probably want to just put this number inside init function.
@@ -317,12 +317,13 @@ class BlockSubmissionAdmin(admin.ModelAdmin): obj.signoff_by = request.user elif is_reject: obj.signoff_state = BlockSubmission.SIGNOFF_REJECTED - else: - # TODO: something more fine-grained that looks at user counts - if ...
[BlockSubmissionAdmin->[has_signoff_permission->[has_change_permission],change_view->[_get_enhanced_guid_context,has_signoff_permission]],BlockAdmin->[get_form->[get_request_guid,_get_version_choices]]]
Add a log entry to the log_change function.
This would read better without the `check_` prefix.
@@ -401,12 +401,9 @@ final class ApiPlatformExtension extends Extension implements PrependExtensionIn $loader->load('problem.xml'); } - /** - * Registers the GraphQL configuration. - */ - private function registerGraphQlConfiguration(ContainerBuilder $container, array $config, XmlFileLoade...
[ApiPlatformExtension->[registerElasticsearchConfiguration->[load],load->[load],registerBundlesConfiguration->[load],registerHttpCacheConfiguration->[load],registerMetadataConfiguration->[load],getResourcesToWatch->[getBundlesResourcesPaths],registerGraphQlConfiguration->[load],registerSwaggerConfiguration->[load],regi...
Register JSON problem and GraphQL configuration.
Yes, I consider `FOSUserBundle` as legacy. :wink:
@@ -59,8 +59,12 @@ class WPSEO_Sitemaps_Admin { return; } - if ( WP_CACHE ) { - wp_schedule_single_event( ( time() + 300 ), 'wpseo_hit_sitemap_index' ); + if ( WP_CACHE && ! wp_next_scheduled( 'wpseo_hit_sitemap_index' ) ) { + $sitemap_cache = new WPSEO_Sitemaps_Cache(); + + if ( $sitemap_cache->is_en...
[WPSEO_Sitemaps_Admin->[status_transition->[status_transition_bulk]]]
This function is called when a status transition is received. It will also update the post type.
Why not invert this `if` and return earlier?
@@ -313,7 +313,13 @@ func (h *HoleyResultCollector) Holes() int { return h.holes } -func (s *Storage) MaybeNuke(ctx context.Context, force bool, err Error, convID chat1.ConversationID, +func (s *Storage) MaybeNukeLocked(ctx context.Context, force bool, err Error, convID chat1.ConversationID, uid gregor1.UID) Error...
[applyExpunge->[Result,DeleteAssets],ClearAll->[clearUpthrough],clearUpthrough->[Error],FetchUpToLocalMaxMsgID->[fetchUpToMsgIDLocked],getMessage->[Result],PushPlaceholder->[Push],ClearBefore->[clearUpthrough],fetchUpToMsgIDLocked->[ResultCollectorFromQuery,Result,MaybeNuke,Error],IsTLFIdentifyBroken->[Error],Fetch->[f...
Holes clears the whole local storage and the message tracker.
I don't like this name, usually you put `Locked` on the end if you already have the lock. I would make the lower case name have this.
@@ -60,7 +60,7 @@ public class SearchExecutionGuardTest { public void failsForNonPermittedStreams() { final Search search = searchWithStreamIds("ok", "not-ok"); - assertThatExceptionOfType(ForbiddenException.class) + assertThatExceptionOfType(MissingStreamPermissionException.class) ...
[SearchExecutionGuardTest->[searchWithStreamIds->[build,toArray],allowsSearchesWithNoStreams->[searchWithStreamIds,assertSucceeds],searchWithCapabilityRequirements->[build,searchWithStreamIds,requirementsMap],failsForMissingCapabilities->[containsOnlyKeys,satisfies,searchWithCapabilityRequirements],succeedsIfAllStreams...
Checks if all streams are permitted.
We should also check if the exception contains the missing streams.
@@ -127,9 +127,16 @@ public class SCMPipelineManager implements PipelineManager { pipelineFactory.setProvider(replicationType, provider); } + public Set<PipelineID> getOldPipelineIdSet() { + return oldRatisThreeFactorPipelineIDSet; + } + private void initializePipelineState() throws IOException { ...
[SCMPipelineManager->[addContainerToPipeline->[addContainerToPipeline],deactivatePipeline->[deactivatePipeline],removePipeline->[removePipeline],openPipeline->[openPipeline],triggerPipelineCreation->[triggerPipelineCreation],getPipeline->[getPipeline],destroyPipeline->[triggerPipelineCreation,destroyPipeline],close->[c...
This method sets the pipeline provider.
Can we move this logic to SCMSafeModeManager itself? This is currently called via SCMSafeModeManager#exitSafeMode. Also currently startPipelineCreator if called multiple times will create multiple fixed interval tasks for pipeline creation.
@@ -366,6 +366,18 @@ get_attach_info(const char *name, int *npsrs, struct dc_mgmt_psr **psrs) *npsrs = resp->n_psrs; *psrs = p; + strncpy(sy_info->provider, resp->crt_phy_addr_str, + sizeof(sy_info->provider)); + sy_info->provider[sizeof(sy_info->provider)-1] = '\0'; + + strncpy(sy_info->crt_ctx_share_addr, resp...
[No CFG could be retrieved]
get the attach info for a given system name This function is called to get the attach info.
(style) spaces required around that '=' (ctx:VxV)
@@ -65,6 +65,10 @@ public class PollableJmsChannel extends AbstractJmsChannel implements PollableCh if (object == null) { return null; } + if (isCountsEnabled()) { + getMetrics().afterReceive(); + counted = true; + } Message<?> message = null; if (object instanceof Message<?>) { mess...
[PollableJmsChannel->[receive->[receiveAndConvert,preReceive,setReceiveTimeout,size,build,clearReceiveTimeout,receive,receiveSelectedAndConvert,postReceive,getInterceptors,afterReceiveCompletion]]]
This method will receive a message from the JMS template.
Why is it here, rather than outside of `if`, like in the `PollableAmqpChannel` ?
@@ -109,7 +109,7 @@ public class GameRunner { "UI client launcher invoked from headless environment. This is current prohibited by design to " + "avoid UI rendering errors in the headless environment."); - ErrorHandler.registerExceptionHandler(); + Thread.setDefaultUncaughtExceptionHandler...
[GameRunner->[joinGame->[joinGame,showMessageDialog],showConfirmDialog->[showConfirmDialog],Title->[of->[Title]],clientLeftGame->[showMainFrame],showMessageDialog->[showMessageDialog]]]
Main method for the main application.
`Logger#log()` handles a `null` message by simply displaying `null`. In the `null` message case, it seemed redundant to convert the exception to a string and use that as the message, as `ErrorHandler` did. I can change it back if the legacy behavior is preferred.
@@ -193,6 +193,12 @@ export class ProgressBar { this.updateProgressByIndex_(segmentIndex, progress); + // If story was reloaded. + if (!this.activeSegmentIndex_) { + this.updateValuesForReload_(segmentIndex); + this.render_(); + } + // If updating progress for a new segment, update all ...
[No CFG could be retrieved]
Creates a new root element of the progress bar. Updates the segments in the chain.
Isn't this also called on initial render, even on the cover page? Could we rename the `updateValuesForReload_` method so it better indicates what it does, like `getInitialSegmentIndex_`?
@@ -0,0 +1,18 @@ +# Copyright 2013-2020 Lawrence Livermore National Security, LLC and other +# Spack Project Developers. See the top-level COPYRIGHT file for details. +# +# SPDX-License-Identifier: (Apache-2.0 OR MIT) + +from spack import * + + +class PySetproctitle(PythonPackage): + """The setproctitle module allow...
[No CFG could be retrieved]
No Summary Found.
You can remove this line, it's already added by PythonPackage
@@ -78,11 +78,15 @@ ModelPart* GenerateMeshPart(ModelPart &rModelPart, const Element &r_reference_element = KratosComponents<Element>::Get(rElementName); + + // create a new property for the mesh motion + Properties::Pointer p_mesh_motion_property = pmesh_model_part->CreateNewProperties(0); + for (int ...
[CheckJacobianDimension->[IntegrationPoints,size,resize,KRATOS_CATCH,GetDefaultIntegrationMethod],MoveMesh->[Coordinates,size,KRATOS_CATCH,begin,FastGetSolutionStepValue,noalias,GetInitialPosition],GenerateMeshPart->[Create,ElementsBegin,pGetGeometry,Nodes,KRATOS_CATCH,Name,GetModel,Id,push_back,Elements,pGetProperties...
GenerateMeshPart - Generate a new mesh part with the given name.
didn't we discuss to revert the changes here?
@@ -311,12 +311,14 @@ public class PooledTopNAlgorithm @Override public void cleanup(PooledTopNParams params) { - ResourceHolder<ByteBuffer> resultsBufHolder = params.getResultsBufHolder(); + if (params != null) { + ResourceHolder<ByteBuffer> resultsBufHolder = params.getResultsBufHolder(); - i...
[PooledTopNAlgorithm->[makeInitParams->[build],PooledTopNParams->[Builder->[build->[PooledTopNParams]]],makeDimValSelector->[build]]]
Cleanup the results buffer holder if it is not null.
what happens for the other classes that extend the base topn algorithm?
@@ -157,6 +157,12 @@ class StepsController < ApplicationController table.last_modified_by = current_user unless table.new_record? table.team = current_team end + + # gerate a tag that replaces img tag in databases + @step.description = parse_tiny_mce_asset_to_token( + par...
[StepsController->[destroy->[destroy],update->[create],create->[new,create],update_protocol_ts->[update],new->[new],toggle_step_state->[create],extract_destroy_params->[has_destroy_params,extract_destroy_params],checklistitem_state->[create]]]
Updates a single n - node node with the data from the server. check if the user has a node with a name that exists in the system.
Trailing whitespace detected.
@@ -264,8 +264,16 @@ export class Templates { findTemplate(parent, opt_querySelector) { const templateElement = this.maybeFindTemplate(parent, opt_querySelector); user().assert(templateElement, 'Template not found for %s', parent); - user().assert(templateElement.tagName == 'TEMPLATE', - 'Templat...
[No CFG could be retrieved]
Determines if a template element is present inside the parent and renders it as an array of templates Returns the template implementation of the specified child element.
`"Template must defined in a <template> or <script type=text/plain> tag."`
@@ -35,8 +35,7 @@ data-category="thumbsdown" data-reactable-type="<%= @moderatable.class.name %>"> <div class="reaction-button-circle"> - <%= image_tag("emoji/emoji-one-thumbs-down-gray.png", alt: "Thumbs down emoji", class: "emoji-grey") %> - <img class="reacted...
[No CFG could be retrieved]
Displays a hidden box that shows the high and low quality reactions. Vomit reactions are reacted if the user is a moderator or a moderator.
this was the one in the screenshot (thumbs up). Sorry I missed this.
@@ -85,14 +85,8 @@ def to_tensor(pic): img = 255 * torch.from_numpy(np.array(pic, np.uint8, copy=False)) else: img = torch.ByteTensor(torch.ByteStorage.from_buffer(pic.tobytes())) - # PIL image mode: L, LA, P, I, F, RGB, YCbCr, RGBA, CMYK - if pic.mode == 'YCbCr': - nchannel = 3 - ...
[resized_crop->[resize,_is_pil_image,crop],adjust_brightness->[_is_pil_image],vflip->[_is_pil_image],five_crop->[center_crop,crop],pad->[_is_pil_image,pad],crop->[_is_pil_image,crop],adjust_gamma->[_is_pil_image],resize->[resize,_is_pil_image],center_crop->[crop],adjust_saturation->[_is_pil_image],adjust_hue->[_is_pil_...
Convert a PIN image or numpy. ndarray to a tensor. missing - image image.
Thanks to @qfgaohao for pointing out the `Image.getbands()` method in #1777.
@@ -26,7 +26,7 @@ import javax.inject.Qualifier; * RedisClient client; * </pre> */ -@Target({ ElementType.TYPE, ElementType.METHOD, ElementType.FIELD }) +@Target({ ElementType.TYPE, ElementType.METHOD, ElementType.FIELD, ElementType.PARAMETER }) @Retention(RUNTIME) @Documented @Qualifier
[No CFG could be retrieved]
This bean is used to provide a Redis client name for a single .
We need @mkouba opinion. The last time I used a qualifier, I heard him shouting at me and I'm living more than 1000 km away from him :-) It seems ok here, but better check.
@@ -735,6 +735,9 @@ export class AmpA4A extends AMP.BaseElement { const extensions = Services.extensionsFor(this.win); creativeMetaDataDef.customElementExtensions.forEach( extensionId => extensions.preloadExtension(extensionId)); + // Preload any fonts. + (creative...
[AmpA4A->[extractSize->[user,get,Number],constructor->[AmpAdUIHandler,AmpAdXOriginIframeHandler,dev,generateSentinel,platformFor,getBinaryTypeNumericalCode,getBinaryType,now,SAFEFRAME],tearDownSlot->[dev,platformFor,SAFEFRAME],renderViaNameAttrOfXOriginIframe_->[NAMEFRAME,utf8Decode,dev,checkStillCurrent,user,getContex...
Initialize Ad request if necessary. This method returns a single non - null object if there is no such object in the cache Determines if a response contains a missing header and if so stores it in the cache.
Optional style nit: It's a good idea to use braces for imperative side-effecting callbacks, even if they're one-liners.
@@ -48,4 +48,8 @@ class ServiceProviderSessionDecorator private attr_reader :sp, :view_context + + def t(string, options = {}) + view_context.t(string, options) + end end
[ServiceProviderSessionDecorator->[sp_name->[friendly_name,agency],verification_method_choice->[t],sp_logo->[logo],registration_heading->[safe_join,content_tag,html_safe],sp_return_url->[return_to_sp_url],new_session_heading->[t],attr_reader,freeze]]
region ViewContextAttributeReader Methods.
I think you can get around this "uncommunicative method name" reek by using `delegate :t, to: :view_context`
@@ -0,0 +1,18 @@ +from .base_representation import BaseRepresentation + + +class ASRRepresentation(BaseRepresentation): + pass + + +class ASRAnnotation(ASRRepresentation): + def __init__(self, identifier, source='', reference=''): + super().__init__(identifier) + self.source = source + self.r...
[No CFG could be retrieved]
No Summary Found.
your adapter returns CharacterRecognitionPrediction, this class is not used
@@ -1442,7 +1442,7 @@ if (empty($reshook)) { } // Actions to build doc - $upload_dir = $conf->propal->multidir_output[$object->entity]; + $upload_dir = !empty($conf->propal->multidir_output[$object->entity])?:$conf->propal->dir_output; $permissiontoadd = $usercancreate; include DOL_DOCUMENT_ROOT.'/core/action...
[update_price,create,form_multicurrency_rate,selectInputReason,getLinesArray,getNomUrl,setDeliveryDate,select_incoterms,begin,closeProposal,select_comptes,formInputReason,insert_discount,add_contact,setProject,getOutstandingBills,printOriginLinesList,textwithpicto,fetch_optionals,selectDate,transnoentitiesnoconv,query,...
Displays the user add contact or delete a contact Create a new object.
Pb with ?:
@@ -102,6 +102,14 @@ public class TransactionConfigurationBuilder extends AbstractConfigurationChildB @Override void validate() { + if (transactionManagerLookup == null) { + if (!getBuilder().invocationBatching().enabled) { + transactionManagerLookup = new GenericTransactionManagerLook...
[TransactionConfigurationBuilder->[read->[transactionManagerLookup,useEagerLocking,lockingMode,eagerLockingSingleNode,autoCommit,use1PcForAutoCommitTransactions,syncRollbackPhase,syncCommitPhase,transactionSynchronizationRegistryLookup,useSynchronization,cacheStopTimeout,transactionMode,read,recovery],create->[create]]...
Validate the passed in and create a new TransactionConfiguration object.
I am sure this works, since you have a unit test, but where do you specify the BatchModeTransactionManager? :)
@@ -33,7 +33,7 @@ <%= form_with model: @response_template do |f| %> <section class="flex flex-col gap-3"> - <% if @response_template.persisted? %> + <% if @response_template&.persisted? %> <% title = params[:previous_title] || @response_template.title %> <% content = params[:previo...
[No CFG could be retrieved]
Displays a list of all including a hidden input and a form to edit the Displays a hidden section with a description of the template s canton ID.
this is the actual fix :D
@@ -401,6 +401,16 @@ public class ClassicPluginStrategy implements PluginStrategy { public VersionNumber getSplitWhen() { return splitWhen; } + + /** + * Gets the minimum required version for the current version of Jenkins. + * + * @return the minimum requir...
[ClassicPluginStrategy->[createPluginWrapper->[loadLinkedManifest,isLinked],updateDependency->[getShortName],load->[getShortName],parseClassPath->[resolve],createClassLoader->[createClassLoader],AntClassLoader2->[defineClassFromData->[defineClassFromData]],createClassJarFromWebInfClasses->[putNextEntry->[putNextEntry],...
get the splitWhen version number.
:ant: rename to `getRequiredVersion` (and rename field & constructor parameter to match)
@@ -134,5 +134,7 @@ void AddCustomIOToPython(pybind11::module& pymodule) } } // namespace Python. +template class GidIO<>; + } // Namespace Kratos
[WriteMesh->[WriteMesh],WriteNodeMesh->[WriteNodeMesh]]
This module just returns a reference to the object that is not in the list of possible k.
I think he problem comes from the `GidIO<EdgebasedGidGaussPointsContainer,EdgebasedGidMeshContainer>`. I don't have my win machine here right now, I will test it tomorrow
@@ -49,11 +49,15 @@ func (c cloudBackendReference) String() string { curUser = "" } - if c.owner == curUser { + if c.owner == curUser && c.b.currentProject != nil && c.project == string(c.b.currentProject.Name) { return string(c.name) } - return fmt.Sprintf("%s/%s", c.owner, c.name) + if c.b.currentProjec...
[ExportDeployment->[ExportStackDeployment],LastUpdate->[Unix],Name->[QName],Remove->[RemoveStack],String->[Sprintf,Background,GetPulumiAccountName],GetLogs->[GetStackLogs],Preview->[PreviewStack],Destroy->[DestroyStack],ConsoleURL->[StackConsoleURL],Snapshot->[getSnapshot],ImportDeployment->[ImportStackDeployment],Refr...
String returns the string representation of a cloudBackendReference.
Can we combine both of these if-expressions together, just for clarity? ``` // If the project names match, we can elide them. if c.b.currentProject != nil && c.project == string(c.b.currentProject.Name) { if c.owner == curUser { return string(c.name) // Elide owner too, if it is the current user. } return fmt.Sprintf("...
@@ -272,9 +272,12 @@ class TypeList(Type): class AnyType(Type): """The type 'Any'.""" - def __init__(self, implicit: bool = False, line: int = -1, column: int = -1) -> None: + def __init__(self, implicit: bool = False, from_silent_import: bool = False, + line: int = -1, column: int = -1) -...
[TypeQuery->[visit_star_type->[accept],visit_type_type->[accept],visit_overloaded->[items],query_types->[accept],visit_callable_argument->[accept]],TypeStrVisitor->[visit_callable_type->[accept],visit_typeddict_type->[accept,items],visit_star_type->[accept],visit_instance->[name],visit_tuple_type->[accept],visit_type_t...
Initialize a new object with the specified line and column numbers.
Nitpick: if you have to wrap a function def line, put each argument on a line of its own. There's a lot of existing code in mypy which doesn't do this, but it's much easier to read if done this way, so we're trying to do this for new code.
@@ -22,15 +22,12 @@ func (sm *localSnapshotPersister) Invalidate() error { } func (sm *localSnapshotPersister) Save(snapshot *deploy.Snapshot) error { - stack := snapshot.Stack - contract.Assert(sm.name == stack) - - config, _, _, err := sm.backend.getStack(stack) + config, _, _, err := sm.backend.getStack(sm.name)...
[Save->[getStack,saveStack,IsNotExist,Assert]]
Save saves a snapshot to the local backend.
I think that this is essentially the only place this was used. This does feel like a rather low-value assertion.
@@ -825,6 +825,15 @@ export class AmpList extends AMP.BaseElement { return this.loadMoreFailedElement_; } + /** @private */ + getLoadMoreEndElement_() { + if (!this.loadMoreEndElement_) { + this.loadMoreEndElement_ = childElementByAttr( + this.element, 'load-more-end'); + } + return t...
[No CFG could be retrieved]
private private methods for all classes that are defined in the classList_ attribute of the current Provides a callback to load more URL variable when a source is not found.
rules in `amp.css` needs to be updated for `amp-list[load-more-end]` as well. I like to also make `amp.css` smaller, we should move the `amp-list[load-more] > [load-more-*].amp-visible` rules into an amp-list.css files as they can not be trigged until the extension has loaded anyway.
@@ -34,6 +34,12 @@ type Image struct { DockerImageLayers []ImageLayer `json:"dockerImageLayers"` // Signatures holds all signatures of the image. Signatures []ImageSignature `json:"signatures,omitempty"` + // DockerImageSignatures provides the signatures as opaque blobs. This is a part of manifest schema v1. + Do...
[No CFG could be retrieved]
Integrity of a standard object s metadata and a list of all the objects that are part of.
Please mention that this is a part of manifest schema v1.
@@ -190,12 +190,12 @@ class CategorizedEntity(DictMixin): :type category: str :param subcategory: Entity subcategory, such as Age/Year/TimeRange etc :type subcategory: str - :param offset: Start position (in Unicode characters) for the + :param grapheme_offset: Start position (in Unicode characters...
[SentimentConfidenceScorePerLabel->[__init__->[get]],LinkedEntity->[_from_generated->[_from_generated],__init__->[get]],DocumentError->[__getattr__->[RecognizeEntitiesResult,update,DocumentError,ExtractKeyPhrasesResult,RecognizePiiEntitiesResult,AnalyzeSentimentResult,DetectLanguageResult,RecognizeLinkedEntitiesResult]...
A class constructor for a CategorizedEntity. Represents a CategorizedEntity as a string.
> in Unicode characters I'm still wrapping my head around graphemes. Is this description accurate?
@@ -518,7 +518,16 @@ public final class IntrospectionUtils { public static Optional<Field> getField(Class<?> clazz, String name) { Collection<Field> candidates = getAllFields(clazz, withName(name)); - return isEmpty(candidates) ? empty() : Optional.of(candidates.iterator().next()); + if (isEmpty(candida...
[IntrospectionUtils->[injectFields->[injectDefaultEncoding,getFieldSetterForAnnotatedField,injectFieldFromModelProperty],injectDefaultEncoding->[injectFieldFromModelProperty],getMethodsStream->[getMethodsStream],collectRelativeClasses->[visitObject->[getAnnotation]],getMemberName->[getMemberName],getPagingProviderTypes...
Get the first field of the given class with the given name.
this will probably have side effects and doesn't really comply with the intent of this method. Why do you need this? It should be a separate method then (not to mention than doing a getAllFields to then filter by declaring class is very unneficient
@@ -30,7 +30,7 @@ const debugSelector = "synthexec" func SuiteJob(ctx context.Context, suitePath string, params common.MapStr, extraArgs ...string) (jobs.Job, error) { // Run the command in the given suitePath, use '.' as the first arg since the command runs // in the correct dir - newCmd, err := suiteCommandFacto...
[Dir,Warn,Now,Close,Lstat,Buffer,StderrPipe,Info,Done,Add,Marshal,Start,Errorf,Bytes,MustCompile,Wait,NewScanner,Debug,Text,SynthEvents,Match,Join,UnixNano,ExitCode,writeSynthEvent,Kill,StdoutPipe,Scan,Err,Command,NewReader,Sprintf,Unmarshal,Environ,String,Pipe]
SuiteJob creates a new job from a given suite. InlineJourneyJob creates a job that runs the given script as a single journ.
is this a bug?
@@ -52,10 +52,14 @@ frappe.ui.form.Toolbar = Class.extend({ this.set_indicator(); }, is_title_editable: function() { - if (this.frm.meta.title_field==="title" + let title_field = this.frm.meta.title_field; + let doc_field = this.frm.get_docfield(title_field); + + if (title_field && this.frm.perm[0].write...
[No CFG could be retrieved]
Function to set page title and menu Function to handle menu items.
Should explicitly check for fieldtype **Data** here. Options can be set for fieldtype **Data**.
@@ -266,7 +266,7 @@ import {zen} from '../ads/zen'; import {zergnet} from '../ads/zergnet'; import {zucks} from '../ads/zucks'; import {speakol} from '../ads/speakol'; - +import {mgid} from '../ads/mgid'; /** * Whether the embed type may be used with amp-embed tag.
[No CFG could be retrieved]
Imports an object that is a part of the ADS library. Check if the tag type can be used with amp - embed.
Can we put this line (and the one above, my apologies), in alphabetical order?
@@ -34,3 +34,15 @@ function jetpack_require_lib( $slug ) { } trigger_error( "Cannot find a library with slug $slug.", E_USER_ERROR ); } + +function require_lib( $slug ) { + if ( defined( 'ABSPATH' ) && ! defined( 'WP_CONTENT_DIR' ) ) { + define( 'WP_CONTENT_DIR', ABSPATH . 'wp-content' ); // no trailing sl...
[No CFG could be retrieved]
Require a library.
This is a pretty generic name. It might be a good idea to check `function_exists`
@@ -506,7 +506,7 @@ def _build_load_path_and_config(path, config): @switch_to_static_graph def save(layer, path, input_spec=None, **configs): """ - Saves input Layer as ``paddle.jit.TranslatedLayer`` + Saves input Layer or function as ``paddle.jit.TranslatedLayer`` format model, which can be used for ...
[_trace->[create_program_from_desc,extract_vars],_extract_vars->[_extract_vars],_parse_load_config->[_SaveLoadConfig],extract_vars->[_extract_vars],declarative->[decorated->[copy_decorator_attrs],decorated],load->[_build_load_path_and_config,_parse_load_config],TracedLayer->[trace->[_trace,TracedLayer],save_inference_m...
Saves a single non - zero - valued hidden hidden hidden hidden hidden hidden hidden hidden hidden hidden This class is a model that can be used to train a non - zero n - nan This function is called by the save method of the paddle.
Since function cannot save parameters, you should give a Note or Warning and had better explain the reason for users.
@@ -137,9 +137,15 @@ class SchedulerService(PantsService): self._logger.debug('graph len was {}, waiting for initial watchman event'.format(graph_len)) self._watchman_is_running.wait() + session = self._graph_helper.new_session() + with self.fork_lock: - self._graph_helper.warm_product_grap...
[SchedulerService->[warm_product_graph->[warm_product_graph],setup->[_combined_invalidating_fileset_from_globs],run->[_process_event_queue],_handle_batch_event->[_maybe_invalidate_scheduler],_process_event_queue->[_handle_batch_event]]]
Runs an execution request against the captive scheduler.
Does this need to be inside the lock?
@@ -64,9 +64,9 @@ public class RegisterQualityGatesTest { @Test public void register_default_gate() { - MetricDto newBugs = dbClient.metricDao().insert(dbSession, newMetricDto().setKey(NEW_BUGS_KEY).setValueType(INT.name()).setHidden(false)); - MetricDto newVulnerabilities = dbClient.metricDao().insert(db...
[RegisterQualityGatesTest->[register_default_gate->[longValue,any,isNotNull,setHidden,selectByName,insert,start,setDefault,isEqualTo,anyLong,stop,tuple,commit,containsOnly],does_not_register_default_gate_if_already_executed->[LoadedTemplateDto,start,insert,isEmpty,verifyZeroInteractions,commit],QualityGateConditionsUpd...
Register default gate Stop the task if it is a .
how about the readability on the project's page? isn't it a worse experience?
@@ -578,9 +578,7 @@ export class AmpIframe extends AMP.BaseElement { * @private */ looksLikeTrackingIframe_() { - const box = this.element.getLayoutBox(); - // This heuristic is subject to change. - if (box.width > 10 && box.height > 10) { + if (!looksLikeTrackingIframe(this.element.getLayoutBox(...
[No CFG could be retrieved]
Private methods for the methods that are called by the embed - size request. Register action for postMessage.
Might be worth moving the remaining isInContainer logic to the helper as well remove the private `looksLikeTrackingIframe_` specially given you would need to duplicate that logic for video one anyway.
@@ -1786,3 +1786,17 @@ func LockIDFromBytes(data []byte) LockID { sum := sha512.Sum512(data) return LockID(binary.LittleEndian.Uint64(sum[:8])) } + +// MDPriority is the type for the priority field of a metadata put. mdserver +// prioritizes MD writes with higher priority when multiple happen at the same +// time,...
[FindDeviceKey->[Equal],ToTeamID->[String],Compare->[Compare],Match->[IsNil,String],AsUserOrBust->[AsUser],Exists->[IsNil],SecureEqual->[Equal],Eq->[Eq,Equal,String],ToShortIDString->[ToBytes],ToMediumID->[toBytes],UnixMicroseconds->[Time],GetUID->[GetUID],UnixMilliseconds->[Time],SwapLastPart->[Parent,Append],FindKID-...
LockID returns LockID of data.
Why is normal different from the default? You want to start prioritizing new clients over old ones?
@@ -5,6 +5,17 @@ chrome.runtime.onMessage.addListener((message, sender, sendResponse) => { }) const testMap = { + connect () { + let success = false + try { + chrome.runtime.connect(chrome.runtime.id) + chrome.runtime.connect(chrome.runtime.id, { name: 'content-script' }) + chrome.runtime.conn...
[No CFG could be retrieved]
Add event listener to receive message from the browser.
Is this console.log intentional or was it accidentally left in?
@@ -213,7 +213,6 @@ export class AbstractWallet { this.secret = parsedSecret.ExtPubKey; const mfp = Buffer.from(parsedSecret.MasterFingerprint, 'hex').reverse().toString('hex'); this.masterFingerprint = parseInt(mfp, 16); - this.setLabel('Cobo Vault ' + parsedSecret.MasterFingerprint);...
[No CFG could be retrieved]
The base class for the object. getTransactions - get max of coins in the transaction.
do we have any other hints on what kind of HW wallet we are scanning from?
@@ -224,9 +224,15 @@ public class StreamProcessorDescriptor implements Descriptor { .batchPolicy(policyDescriptor.batchCapacity, policyDescriptor.batchThreshold) .continueOnF...
[StreamProcessorDescriptor->[FilterDescriptor->[getFilter->[getId]],getDefaultPolicy->[getComputationPolicy],getComputationPolicy->[getPolicy,getId]]]
Returns the computation policy for the given policy descriptor.
Shouldn't be the opposite? Descriptor should states a value and if none we retrieve from a more global configuration properties. Furthermore you could use `ConfigurationService` instead of `Framework#getProperty,` or this kind of properties are system enough to be in `nuxeo.conf`?
@@ -173,6 +173,13 @@ namespace Dynamo.Graph.Nodes case PortType.Input: return new Point2D(Owner.X, y); case PortType.Output: + if (Owner is CodeBlockNodeModel) + { + // Special cas...
[PortModel->[GetOutPortType->[GetType,Input,FirstOrDefault,Message,ElementAt,Definition,Log,ToString,Item1],GetHashCode->[GetHashCode],GetInputPortType->[GetType,InstanceProperty,Output,Message,InstanceMethod,FirstOrDefault,ClassName,ElementAt,Definition,Log,ToString,Type],DestroyConnectors->[Any,Delete],Equals->[GUID]...
- A type of the port. Controls whether this port is using it s default value or yield a closure.
Is 10.5 here simply some offset value?
@@ -168,9 +168,7 @@ func (r *Runtime) newImageBuildCompleteEvent(idOrName string) { // Build adds the runtime to the imagebuildah call func (r *Runtime) Build(ctx context.Context, options buildahDefine.BuildOptions, dockerfiles ...string) (string, reference.Canonical, error) { if options.Runtime == "" { - // Make ...
[Import->[Import],Build->[newImageBuildCompleteEvent]]
Build builds a container using the provided options.
Could the default runtime ever differ from what's set in the containerConfig structure? If so, I'm not sure we'd want to do this.
@@ -422,6 +422,14 @@ public class DataflowRunner extends PipelineRunner<DataflowPipelineJob> { // Dataflow Streaming runner overrides the SPLITTABLE_PROCESS_KEYED transform // natively in the Dataflow service. } else { + overridesBuilder + // Replace GroupIntoBatches before the state/ti...
[DataflowRunner->[ImpulseTranslator->[translate->[getCoder]],replaceTransforms->[getOverrides],containsUnboundedPCollection->[BoundednessVisitor],getEnvironmentVersion->[hasExperiment],run->[maybeRegisterDebuggee],ReflectiveViewOverrideFactory->[findCreatePCollectionView->[enterCompositeTransform->[enterCompositeTransf...
Returns a list of overrides that can be applied to the given read. Adds a missing override for a specific read type. Adds a missing override for any type of view.
Can you extract whole if/else or contents of if/else cases into separate methods please? First if case is pretty big to be worth moving to separate method/class.
@@ -699,7 +699,7 @@ namespace System.Net.Http private static bool BufferHasPrefix(ArraySegment<byte> buffer, byte[] prefix) { - byte[] byteArray = buffer.Array; + byte[]? byteArray = buffer.Array; if (prefix == null || byteArray == null || prefix.Length > buffer.Co...
[HttpContent->[CreateContentReadStreamAsync->[CreateContentReadStreamAsync],Stream->[TryGetBuffer],ReadBufferedContentAsString->[TryGetBuffer],LimitArrayPoolWriteStream->[WriteByte->[EnsureCapacity],Write->[EnsureCapacity],Dispose->[Dispose],Task->[Write],ValueTask->[Write]],ReadAsStringAsync->[ReadAsStringAsync],GetCo...
Check if the given buffer has a prefix.
The same about ArraySegment.
@@ -108,11 +108,10 @@ public class UnitCategory implements Comparable<UnitCategory> { @Override public String toString() { - final StringBuilder sb = new StringBuilder(); - sb.append("Entry type:").append(type.getName()).append(" owner:").append(owner.getName()).append(" damaged:") - .append(damage...
[UnitCategory->[toString->[toString],getHitPoints->[getHitPoints],equalsIgnoreDamagedAndBombingDamageAndDisabled->[equals]]]
Returns a string representation of the .
Name isn't fitting, no need to assign a variable first
@@ -5,6 +5,9 @@ class ProjectFoldersController < ApplicationController include ProjectsHelper include ProjectFoldersHelper + attr_reader :current_folder + helper_method :current_folder + before_action :load_current_folder, only: %i(new) before_action :load_project_folder, only: %i(edit update) before...
[ProjectFoldersController->[move_params->[new],new->[new],create->[new],update->[update]]]
Creates a new project folder and attaches it to the current folder. move to modal.
Layout/EmptyLinesAroundAttributeAccessor: Add an empty line after attribute accessor.
@@ -128,6 +128,10 @@ namespace UnitsUI } } + public MeasurementInputBase(IEnumerable<PortModel> inPorts, IEnumerable<PortModel> outPorts):base(inPorts, outPorts) { } + + public MeasurementInputBase() : base() { } + internal void ForceValueRaisePropertyChanged() { ...
[MeasurementInputBase->[SerializeCore->[SerializeCore],DeserializeCore->[DeserializeCore],UpdateValueCore->[UpdateValueCore]],AreaFromStringNodeViewCustomization->[CustomizeView->[CustomizeView]],LengthFromStringNodeViewCustomization->[CustomizeView->[CustomizeView]],VolumeFromStringNodeViewCustomization->[CustomizeVie...
Raise the value of a property if it has changed.
API Change : Public constructors have been added to `MeasurementInputBase` to facilitate serialization.
@@ -89,7 +89,7 @@ module.exports = yeoman.Base.extend({ if(file.isDirectory()) { if(shelljs.test('-f', file.name + '/.yo-rc.json')) { var fileData = this.fs.readJSON(file.name + '/.yo-rc.json'); - ...
[No CFG could be retrieved]
Displays a message to the user if the user has provided a non - empty name. This function checks if there is an application in the appsFolders array and if so removes it.
this check is not required if we set a baseName appropriately
@@ -201,8 +201,12 @@ func (eb *EthBroadcaster) monitorEthTxs(k ethkey.Key, triggerCh chan struct{}) { } } -func (eb *EthBroadcaster) ProcessUnstartedEthTxs(key ethkey.Key) error { - return eb.advisoryLocker.WithAdvisoryLock(context.TODO(), postgres.AdvisoryLockClassID_EthBroadcaster, key.ID, func() error { +func (...
[tryAgainWithNewGas->[handleInProgressEthTx],Close->[Close],ethTxInsertTriggerer->[Trigger]]
monitorEthTxs polls the database for any unstarted transaction and updates the advertised.
I misunderstood before, on second review this is a perfectly reasonable approach
@@ -152,11 +152,14 @@ func (c *Create) Flags() []cli.Flag { Value: "172.16.0.0/12", Usage: "The IP range from which bridge networks are allocated", Destination: &c.BridgeIPRange, + Hidden: true, }, + + // client cli.StringFlag{ Name: "client-network, cln", Value: ...
[processNetwork->[Infof,Contains,String,Errorf,LookupIP,ParseIPandMask,Debugf],processInsecureRegistries->[NewExitError,Sprintf,Parse],processBridgeNetwork->[NewExitError,Sprintf,ParseCIDR],processVolumeStores->[End,New,SplitN,Begin],processParams->[HasCredentials,NewExitError,processNetwork,processInsecureRegistries,B...
Flags returns a slice of flags that can be passed to the Create command IP address for the VSphere network port group Provides a description of the flags that are defined in the container - network section of the CLI Command line flags for the virtual container A command line interface to configure a new configuration ...
`organization` for en-US guess this is a candidate for using i18n later
@@ -3006,7 +3006,10 @@ vdev_load(vdev_t *vd) "asize=%llu", (u_longlong_t)vd->vdev_ashift, (u_longlong_t)vd->vdev_asize); return (SET_ERROR(ENXIO)); - } else if ((error = vdev_metaslab_init(vd, 0)) != 0) { + } + + error = vdev_metaslab_init(vd, 0); + if (error != 0) { vdev_dbgmsg(vd, "vdev_lo...
[No CFG could be retrieved]
Magic function for the vdev_load function. region VDEV_LOAD.
nit: two blank lines in a row
@@ -4082,7 +4082,7 @@ p { $this->error = __( 'Cheatin&#8217; uh?', 'jetpack' ); break; case 'access_denied' : - $this->error = __( 'You need to authorize the Jetpack connection between your site and WordPress.com to enable the awesome features.', 'jetpack' ); + $this->error = __( 'Would you mind telling ...
[Jetpack->[sync_reindex_trigger->[current_user_is_connection_owner],verify_json_api_authorization_request->[add_nonce],is_staging_site->[get_cloud_site_options],admin_notices->[opt_in_jetpack_manage_notice,can_display_jetpack_manage_notice],authenticate_jetpack->[verify_xml_rpc_signature],sync_reindex_status->[current_...
This function is called when Jetpack is loaded. It will redirect to the admin page Register and activate a module Jetpack administration page Jetpack unlink action This method is used to display errors in the administration page.
What do you think about splitting the 2 sentences into 2 different strings? This you could move the `br` and `small` tag out of the string, and it would be easier to translate. Since the 2 sentences are not related, I think it's ok to split them.
@@ -679,7 +679,7 @@ class EmailCollector extends CommonObject $flags = '/service=imap'; // IMAP if ($ssl) $flags .= '/ssl'; // '/tls' $flags .= '/novalidate-cert'; - //$flags.='/readonly'; + $flags.='/readonly'; //$flags.='/debug'; if ($norsh || !empty($conf->g...
[EmailCollector->[info->[fetch],getpart->[getpart],fetchAll->[fetch],doCollect->[fetchAll],doCollectOneCollector->[getConnectStringIMAP,fetchActions,update,create,fetch,overwritePropertiesOfObject,fetchFilters]]]
Get Connect String for IMAP.
If we set this flag, i'm afraid that the feature that move the email into the "Mailbox target directory" once processed will won't work anymore, won't it ? May be we should set it only if we don't use the "move email if processed" feature
@@ -475,8 +475,10 @@ const ( RepoRefBranch // RepoRefTag tag RepoRefTag - // RepoRefCommit commit + // RepoRefCommit short or long commit RepoRefCommit + // RepoRefFullCommit long commit only + RepoRefFullCommit // RepoRefBlob blob RepoRefBlob )
[CanCreateBranch->[CanCreateBranch],CanCommitToBranch->[CanEnableEditor],CanEnableEditor->[CanEnableEditor],CanCreateBranch,GetCommitsCount,BranchNameSubURL]
This function is used to set the context variables for the context object. Context for a single branch of a given type.
Don't add a value in the middle of the enums.
@@ -64,7 +64,12 @@ class OeTeacher(Teacher): def __len__(self): return self.len - # return state/action dict based upon passed state + def observe(self, observation): + """Process observation for metrics. """ + if self.lastY is not None: + loss = self.metrics.update(observ...
[OeTeacher->[act->[_image_loader],__init__->[_path]],McTeacher->[act->[_image_loader],__init__->[_path,_setup_data]]]
Length of object.
so we may need to return here too for adam's change?
@@ -90,6 +90,9 @@ class Checkout(models.Model): def __len__(self): return self.lines.count() + def get_customer_email(self): + return self.user.email if self.user else self.email + def is_shipping_required(self): """Return `True` if any of the lines requires shipping.""" ...
[Checkout->[get_shipping_price->[is_shipping_required],get_total->[get_shipping_price,get_subtotal],is_shipping_required->[is_shipping_required]],CheckoutLine->[is_shipping_required->[is_shipping_required]]]
Returns the number of items in the cart.
Do we really need this? Checkout is creating in API and forms. We should just confirm that `email` is always fulfilled. We could explicitly save it `checkout.save()`.
@@ -859,6 +859,11 @@ module.exports = JhipsterGenerator.extend({ this.template('src/main/java/package/config/liquibase/_package-info.java', javaDir + 'config/liquibase/package-info.java', this, {}); } + if (this.authenticationType == 'jwt') { + this.template('src/main/java/pack...
[No CFG could be retrieved]
Template method for all classes This method is called by the jdk to register the JSR310 date converters and.
This seems odd as well
@@ -5,14 +5,16 @@ * Client Server = API Methods the Plugin must respond to */ class Jetpack_Client_Server { + function authorize() { $data = stripslashes_deep( $_GET ); $args = array(); $redirect = isset( $data['redirect'] ) ? esc_url_raw( (string) $data['redirect'] ) : ''; do { - $jetpack = Jetp...
[Jetpack_Client_Server->[get_token->[get_error_message,sign_role,translate_role_to_cap,translate_current_user_to_role],authorize->[get_token,get_error_message,translate_role_to_cap,get_error_code,register,translate_current_user_to_role]]]
This function is called by the Jetpack authorization page. This is the main entry point for the jetpack_auth function. It is called Exception handler for exit.
Calling a static method non-statically is allowed, but is a little odd.
@@ -32,7 +32,7 @@ define("@popperjs/core", ["exports"], function (__exports__) { define("@uppy/core", ["exports"], function (__exports__) { __exports__.default = window.Uppy.Core; - __exports__.Plugin = window.Uppy.Plugin; + __exports__.BasePlugin = window.Uppy.BasePlugin; }); define("@uppy/aws-s3", ["expor...
[No CFG could be retrieved]
Define the default XSS plugin.
Uppy changed from `Plugin` to `BasePlugin`
@@ -156,7 +156,10 @@ namespace Microsoft.Xna.Framework var separator = Path.DirectorySeparatorChar; #endif - return new Uri("file:///" + name).LocalPath.Substring(1).Replace(notSeparator, separator); + var path = new Uri("file:///" + name).LocalPath; + path = path.Substr...
[TitleContainer->[Stream->[Exists,IsPathRooted,Result,OpenRead,GetDirectoryName,GetFileNameWithoutExtension,Open,Combine,GetFilename,GetExtension],OpenStreamAsync->[OpenReadAsync,GetFileAsync,AsStreamForRead,Current],GetFilename->[DirectorySeparatorChar,Replace],Path,Scale,Empty,ResourcePath,BaseDirectory]]
Returns the filename of the file with the given name that was previously created.
What is the intent of this change? I forgot what `Substring(1)` was removing.
@@ -38,6 +38,8 @@ namespace System.IO.Enumeration _rootDirectory = Path.TrimEndingDirectorySeparator(path); _options = options ?? EnumerationOptions.Default; + _remainingDepth = _options.MaxRecursionDepth < 0 ? EnumerationOptions.Default.MaxRecursionDepth : _options.MaxRecursionDe...
[No CFG could be retrieved]
This abstract class is used to implement a file system enumeration interface for a file system enumeration. Return true to continue or throw.
@adamsitnik do you know if it's costly to generate a default `EnumerationOptions` instance just to retrieve the default value of `MaxRecursionDepth`, as opposed to simply using the underlying default value? @iSazonov I don't expect we will ever change the default value of `MaxRecursionDepth`, mainly because it's type (...
@@ -27,7 +27,9 @@ class AddressToDependees: @rule async def map_addresses_to_dependees() -> AddressToDependees: # Get every target in the project so that we can iterate over them to find their dependencies. - all_explicit_targets = await Get(Targets, AddressSpecs([DescendantAddresses("")])) + all_explicit_...
[find_dependees->[Dependees],map_addresses_to_dependees->[AddressToDependees],dependees_goal->[DependeesRequest,DependeesGoal]]
Map all addresses to dependees.
As mentioned offline, I think that it would be cleaner for the `Specs` object to be constructed with the relevant filters by the `SpecsCalculator`... afaict, no other instance will be re-executing the command line specs: they'll always be executing a new/different query, and the filters are intended for a particular qu...
@@ -112,6 +112,10 @@ class TestData(object): def reqfiles(self): return self.root.join("reqfiles") + @property + def complete_paths(self): + return self.root.join("completepaths") + @property def find_links(self): return path_to_url(self.packages)
[_create_test_package_with_subdirectory->[run],need_mercurial->[need_executable],_change_test_package_version->[run],TestPipResult->[assert_installed->[TestFailure]],need_bzr->[need_executable],_vcs_add->[run],TestData->[find_links3->[path_to_url],find_links->[path_to_url],index_url->[path_to_url],find_links2->[path_to...
A path to the reqfiles directory.
Maybe rename this folder and property to `completion_paths`?
@@ -146,7 +146,16 @@ class Jetpack_Gutenberg { self::register( $type, $args, $availability ); } - static function load( $request = null ) { + static function load( $response = null, $handler = null, $request = null ) { + // We display beta blocks in available Gutenberg extensions endpoint requests + $is_availa...
[No CFG could be retrieved]
Adds a block to the list of available block editor blocks.
I am being annoying , what do you think about going with a filter instead?
@@ -418,6 +418,8 @@ func (q *blocksStoreQuerier) selectSorted(sp *storage.SelectHints, matchers ...* storage.EmptySeriesSet() } + stats.Series += len(resSeriesSets) + return series.NewSeriesSetWithWarnings( storage.NewMergeSeriesSet(resSeriesSets, storage.ChainedSeriesMerge), resWarnings)
[fetchLabelNamesFromStore->[LabelNames],fetchLabelValuesFromStore->[LabelValues]]
selectSorted is a convenience method that queries for series in the blocks store that are sorted by EmptySeriesSet - EmptySeriesSet with no series.
`len(resSeriesSets)` is not the number of series, but series set. A single set contains all series returned by 1 store-gateway. We may return the number of series back from store-gateway response (because counting it here would mean iterating the entire set and it's a waste of resources), but this wouldn't be an accura...
@@ -251,6 +251,16 @@ function proxyToAmpProxy(req, res, minify) { }); } +// Returns an html blob with an iframe pointing to the provided url. +function nestResponseInIframe(url) { + return `<!doctype html> + <html style="width:100%; height:100%;"> + <body style="width:98%; height:98%;"> + ...
[No CFG could be retrieved]
Fetches an AMP document from the AMP proxy and replaces JS URLs with the correct URLs This function is called when the page is clicked on the page. It is called when the.
to save space from this rapid growing file, let's just inline this function.
@@ -269,11 +269,7 @@ define([ this._depthCommand = new Command(); this._depthCommand.primitiveType = PrimitiveType.TRIANGLES; - - this._quadH = undefined; - this._quadV = undefined; - - this._fb = undefined; + this._depthCommand.boundingVolume = new BoundingSphere(Cartesi...
[No CFG could be retrieved]
Constructor for the base class. Creates a command list for the AABB shader.
Shouldn't we also remove CentralBodyFSFilter.glsl and friends?
@@ -39,6 +39,10 @@ public final class ElasticsearchTableHandle private final TupleDomain<ColumnHandle> constraint; private final Optional<String> query; private final OptionalLong limit; + // for group by fields + private final List<TermAggregation> termAggregations; + // for aggregation methods...
[ElasticsearchTableHandle->[toString->[toString],equals->[equals]]]
PUBLIC METHODS For Elasticsearch table handles that contain a single this class is used to Get the type of the .
The semantics of aggregations vs constraint/limit/query need to be clarified. Do the aggregations apply before of after the limit? Before or after the constraint? How do they relate to `query`?
@@ -170,6 +170,8 @@ class Reaction < ApplicationRecord end def negative_reaction_from_untrusted_user? + return if user.any_admin? + negative? && !user.trusted end
[Reaction->[reading_time->[reading_time],index_to_algolia->[index!,published],searchable_reactable_path->[path],count_for_article->[fetch,count,hour,where,map],skip_notification_for?->[negative?,receive_notifications,is_a?,user_id],searchable_reactable_tags->[cached_tag_list],async_bust->[perform_async],update_reactabl...
negative_reaction_from_untrusted_user? - removes an action from.
I assume all admins are implicitly trusted, let me know if I should remove this guard.
@@ -80,10 +80,11 @@ class Poller extends BaseValidation private function checkLastPolled(Validator $validator) { + $period = (int)Config::get('rrd.step', 300); // pollers table is only updated by poller-wrapper.py if (dbFetchCell('SELECT COUNT(*) FROM `pollers`')) { $de...
[Poller->[checkDeviceLastPolled->[setList,result,setFix,getBaseURL],validate->[checkDeviceLastPolled,getBaseURL,checkDuplicatePollerEntries,result,warn,checkDevicePollDuration,checkLastPolled,setFix,checkLastDiscovered],checkDuplicatePollerEntries->[warn],checkDevicePollDuration->[setList,result,setFix,getBaseURL],chec...
Checks if the last polled time has not been reached.
Maybe remove the 300, we don't want the value spread everywhere
@@ -498,6 +498,8 @@ DEFAULT_MENUS = {"top_menu_name": "navbar", "bottom_menu_name": "footer"} # Slug for channel precreated in Django migrations DEFAULT_CHANNEL_SLUG = os.environ.get("DEFAULT_CHANNEL_SLUG", "default-channel") +# Set "True" for cloud instances +IS_CLOUD_INSTANCE = get_bool_from_env("IS_CLOUD_INSTANC...
[get_list->[strip,split],get_bool_from_env->[literal_eval,ValueError,format],get_host->[get_current],hasattr,timedelta,join,config,warn,CeleryIntegration,int,init,get_list,iter_entry_points,parse,append,dirname,get_random_secret_key,__import__,setdefault,ignore_logger,format,normpath,Config,ImproperlyConfigured,DjangoI...
The settings for the Celery application. PRIVATE METHODS - Provides a list of all available middleware implementations.
We should provide a better description of what this setting does.
@@ -235,7 +235,7 @@ public interface Appenderator extends QuerySegmentWalker private final int numRowsInSegment; private final boolean isPersistRequired; - AppenderatorAddResult( + public AppenderatorAddResult( SegmentIdWithShardSpec identifier, int numRowsInSegment, boolean...
[add->[add]]
This class is used to manage the case where a segment has not yet been persisted.
Why did you change the access modifier? This should not be called outside the package.
@@ -90,7 +90,7 @@ public class MessageFilter extends AbstractFilteringMessageProcessor implements if (event != null && !VoidMuleEvent.getInstance().equals(event)) { - return filter.accept(event.getMessage()); + return filter.accept(event); } else {
[MessageFilter->[accept->[accept],setFlowConstruct->[setFlowConstruct],setMuleContext->[setMuleContext],stop->[stop],initialise->[initialise],start->[start],dispose->[dispose]]]
Checks if the given event is accepted by the filter.
MessageFilter should be renamed to EventFilter
@@ -83,13 +83,11 @@ namespace Microsoft.Win32 } } - private unsafe RegistryKey CreateSubKeyInternalCore(string subkey, RegistryKeyPermissionCheck permissionCheck, RegistryOptions registryOptions) + private unsafe RegistryKey? CreateSubKeyInternalCore(string subkey, RegistryKeyPermi...
[RegistryKey->[DeleteSubKeyTreeCore->[RegDeleteKeyEx,Win32Error],InternalGetValueCore->[REG_BINARY,Arg_RegGetOverflowBug,REG_DWORD,REG_LINK,REG_NONE,ExpandEnvironmentVariables,ERROR_MORE_DATA,Empty,REG_QWORD,Win32Error,Assert,IsPerfDataKey,Array,REG_DWORD_BIG_ENDIAN,REG_MULTI_SZ,MaxValue,Resize,REG_EXPAND_SZ,Fail,REG_S...
This method flushes the internal state of the RegistryKey and creates a new key if it.
Looks like the return type is annotated as nullable on account of the code path on line 121. But it seems clear by the assertion above that this is not expected to happen unless there is a bug. I think non-nullability should be asserted.
@@ -103,7 +103,7 @@ function buildProviderParams(opt_params) { const attrs = dict(); if (opt_params) { - Object.keys(opt_params || {}).forEach(field => { + Object.keys(opt_params).forEach(field => { attrs[`data-param-${field}`] = opt_params[field]; }); }
[No CFG could be retrieved]
Builds a template for the node with the given id. Generates an AMPHTML element.
This is an error, `undefined` (due to the `=` in the type def) cannot be passed to `Object.keys`.
@@ -121,7 +121,13 @@ def adjust_gamma(img, gamma, gain=1): @torch.jit.unused -def pad(img, padding, fill=0, padding_mode="constant"): +def pad( + img: Image.Image, + padding: Union[int, List[int], Tuple[int, ...]], + fill: Optional[Union[float, List[float], Tuple[float, ...]]] = 0, + padding_mode: str ...
[autocontrast->[autocontrast,_is_pil_image],adjust_brightness->[_is_pil_image],vflip->[_is_pil_image],pad->[_is_pil_image,pad],_get_image_num_channels->[_is_pil_image],crop->[_is_pil_image,crop],adjust_gamma->[_is_pil_image],resize->[resize,_is_pil_image],adjust_saturation->[_is_pil_image],adjust_sharpness->[_is_pil_im...
Pads an image with a new padding. Image with no padding.
This is defined as int on the tensor equivalent method, though it supports both. Do we want them aligned?
@@ -39,8 +39,12 @@ from bokeh.settings import settings __all__ = ( 'check_session_id_signature', + 'check_token_signature', 'generate_secret_key', + 'generate_jwt_token', 'generate_session_id', + 'get_session_id', + 'get_token_payload', ) #----------------------------------------------...
[_signature->[_base64_encode,_ensure_bytes],_base64_encode->[_ensure_bytes],_get_random_string->[_ensure_bytes,_reseed_if_needed],_reseed_if_needed->[_ensure_bytes],_get_sysrandom]
Yields a random string from the session ID.
Do we want to make this configurable?
@@ -1077,6 +1077,7 @@ public class OzoneManagerRequestHandler implements RequestHandler { .setVolumeName(keyArgs.getVolumeName()) .setBucketName(keyArgs.getBucketName()) .setKeyName(keyArgs.getKeyName()) + .setRefreshPipeline(keyArgs.getRefreshPipeline()) .build(); GetF...
[OzoneManagerRequestHandler->[listS3Buckets->[listS3Buckets],completeMultipartUpload->[completeMultipartUpload],allocateBlock->[allocateBlock],deleteBucket->[deleteBucket],abortMultipartUpload->[abortMultipartUpload],getAcl->[getAcl],renameKey->[renameKey],deleteKey->[deleteKey],renewDelegationToken->[renewDelegationTo...
Retrieves the file status of an object in the bucket.
Do we need to set refreshPipeline to true in list status also?
@@ -101,5 +101,8 @@ public @interface Experimental { /** PCollection Schema support in Beam. */ SCHEMAS, + + /** {@code BeamSql}. */ + SQL, } }
[No CFG could be retrieved]
PCollection Schema support in Beam.
My only hesitation is that everything else here is a part of the core SDK and SQL is "just a layer on top". It seems fine, but also it seems fine to just not have a `Kind`. Unless we use it to turn on/off experiments, which I don't think we do. Not sure the kind is ever used.
@@ -235,10 +235,7 @@ namespace Js memset(proerrstr, 0, sizeof(*proerrstr)); *pperrinfo = nullptr; -#ifndef _WIN32 - // xplat-todo: Find out if we can implement richer error info on Linux - return hr; -#else +#if defined(_MSC_VER) && !defined(__clang__) // GetErrorInfo returns ...
[No CFG could be retrieved]
Get the error object of the next type of error. Get the error strings from the IRestrictedErrorInfo object.
AFAIK '_MSC_VER' defined means '__clang__' is not defined. What option we are trying to rule out here?
@@ -660,6 +660,16 @@ export class AmpStoryAutoAds extends AMP.BaseElement { return (Date.now() - this.timeCurrentPageCreated_) > TIMEOUT_LIMIT; } + /** + * Users may put an 'block-ads' attribute on their pages to prevent ads from + * showing in specific slots + * @param {?../../amp-story/0.1/amp-story-...
[No CFG could be retrieved]
Private methods - This function is called by AMP to trigger the event if the last created Register AmpStoryAutoAds.
"in specific slots" => "in next page"
@@ -107,7 +107,7 @@ final class CollectionResolverFactory implements ResolverFactoryInterface $offset = 1 + (int) $after; } - $data = ['edges' => [], 'pageInfo' => ['endCursor' => null, 'hasNextPage' => false]]; + $data = ['totalCount' => 0.0, 'edges' => [], 'pageIn...
[CollectionResolverFactory->[getNormalizedFilters->[getNormalizedFilters],getSubresource->[getSubresource]]]
Returns a callable that can be used to perform a query on a collection of objects. Returns array with data for next node in the collection.
Why do you use a float ?
@@ -605,6 +605,11 @@ void WorldSession::HandleSpellClick(WorldPacket& recvData) if (!unit) return; + if (_player->IsHostileTo(unit)) + { + return; + } + // TODO: Unit::SetCharmedBy: 28782 is not in world but 0 is trying to charm it! -> crash if (!unit->IsInWorld()) ...
[HandleSpellClick->[HandleSpellClick],HandleCastSpellOpcode->[HandleClientCastFlags],HandleUseItemOpcode->[HandleClientCastFlags]]
if we get a non - existent object in world we can get it from the world.
Is there any gob/npc hostile to player with spell click? Just to be sure we are not breaking them. Anyway, nice catch.
@@ -35,6 +35,8 @@ class RBiobase(RPackage): version('2.38.0', commit='83f89829e0278ac014b0bc6664e621ac147ba424') version('2.36.2', commit='15f50912f3fa08ccb15c33b7baebe6b8a59ce075') + version('2.40.0', commit='6555edbbcb8a04185ef402bfdea7ed8ac72513a5') depends_on('r-biocgenerics@0.16.1:', type=('b...
[RBiobase->[depends_on,version]]
Get version of the package.
are these requirements hard? Typically we add the ranges, even though we might not have more versions available right now, they might be added later
@@ -256,7 +256,7 @@ namespace DotNetNuke.UI.Skins else { containerSrc = PaneControl.Attributes["ContainerSrc"]; - if (containerSrc.Contains("/") && !(containerSrc.ToLower().StartsWith("[g]") || containerSrc.ToLower().StartsWith("[l]"))) + if (cont...
[Pane->[LoadContainerFromCookie->[LoadContainerByPath],ProcessPane->[CanCollapsePane],LoadModuleContainer->[LoadContainerFromCookie,LoadContainerFromPane,LoadContainerByPath,LoadNoContainer,LoadContainerFromQueryString],InjectModule->[IsVesionableModule,LoadModuleContainer],LoadContainerFromPane->[LoadContainerByPath],...
LoadContainerFromPane - Load container from pane.
Please use `String#StartsWith(String, StringComparison)`
@@ -288,8 +288,9 @@ func NewKV(cfg KVConfig) (*KV, error) { return nil, err } - if err != nil { - level.Error(util.Logger).Log("msg", "failed to join memberlist cluster", "err", err) + if reached == 0 && cfg.MaxJoinRetries > 0 { + level.Debug(util.Logger).Log("msg", "failed to join memberlist cluster, ke...
[Get->[Get],List->[List],GetBroadcasts->[GetBroadcasts],WatchPrefix->[WatchPrefix,get],MergeRemoteState->[GetCodec,broadcastNewValue,notifyWatchers],NotifyMsg->[GetCodec,notifyWatchers],RegisterFlags->[RegisterFlags],trySingleCas->[get],WatchKey->[get,WatchKey],CAS->[notifyWatchers,CAS]]
GetCodec returns a codec for given codecID or nil if no such codec is available. Stop attempts to leave the memberlist cluster and then shutdown the memberlist client.
Before this PR there was no retry and, in case of failure joining the cluster, the creation of the ring client was failing causing a cascading failure. This PR adds background retries, but in case it fails to join the cluster after all retries, the error is just logged so the system will keep running but not functionin...
@@ -144,7 +144,8 @@ public class SquidUserGuideTest { assertThat(metrics.get("statements").intValue()).isEqualTo(12047); assertThat(metrics.get("complexity").intValue()).isEqualTo(8475 - 80 /* SONAR-3793 */- 2 /* SONAR-3794 */); assertThat(metrics.get("comment_lines").intValue()).isEqualTo(17908); - a...
[SquidUserGuideTest->[init->[scanFile->[scanFile]]]]
This test tests the measures on the project.
We should probably have two tests: one with the value of the property set to true and the other one to false, to actually see the difference.
@@ -759,6 +759,11 @@ const char *ossl_provider_module_path(const OSSL_PROVIDER *prov) #endif } +void *ossl_provider_prov_ctx(const OSSL_PROVIDER *prov) +{ + return prov->provctx; +} + OPENSSL_CTX *ossl_provider_library_context(const OSSL_PROVIDER *prov) { /* TODO(3.0) just: return prov->libctx; */
[No CFG could be retrieved]
Protected methods of Provider Object data END of function ossl_provider_get_operation.
NULL check here maybe?
@@ -2644,7 +2644,7 @@ void dt_develop_blend_process(struct dt_iop_module_t *self, struct dt_dev_pixelp } #ifdef _OPENMP -#if !defined(__SUNOS__) && !defined(__NetBSD__) && !defined(__WIN32__) +#if !defined(__SUNOS__) && !defined(__NetBSD__) && !defined(__WIN32__) && defined(__GLIBC__) #pragma omp parallel for ...
[dt_develop_blend_legacy_params->[dt_develop_blend_params_is_all_zero]]
Checks if there is a missing color in buffer and if so calls the appropriate function to do find the next missing value for a given color get the max values of a color color or blend mask. get the missing mask if there is no mask if no form defined but drawn mask active caveats are filled check if we have a global mask...
Why is the && defined(**GLIBC**) necessary?
@@ -148,6 +148,10 @@ define([ this._resolutionScale = 1.0; this._fogDensity = undefined; + + // TODO : expose these differently + this.shadowMapTexture = undefined; + this.shadowMapMatrix = undefined; } defineProperties(UniformState.prototype, {
[No CFG could be retrieved]
Constructor for UniformState. The UniformState object is a base class for all UniformState methods.
I think it would be fine to just have a `ShadowMap` reference here, and then assign to it each frame when calling `UniformState.update` (pass it as a separate parameter to start, I guess).
@@ -754,6 +754,8 @@ func (b *Beat) registerTemplateLoading() error { return err } elasticsearch.RegisterConnectCallback(callback) + } else if b.Config.ILM.Enabled() { + return errors.New("templates cannot be disable when using ILM") } }
[launch->[InitWithSettings,createBeater],TestConfig->[createBeater,Init],Setup->[createBeater,Init],createBeater->[BeatConfig],configure->[BeatConfig],Init->[InitWithSettings]]
registerTemplateLoading loads template through callback to make sure it is loaded.
Why throwing an error here instead of also overwriting the `b.Config.Template.Enabled` setting, as you overwrite other template settings already?
@@ -179,7 +179,12 @@ abstract class CommandWithUpgrade extends \WP_CLI_Command { } $upgrader = \WP_CLI\Utils\get_upgrader( $this->upgrader ); - $result = $upgrader->bulk_upgrade( wp_list_pluck( $items_to_update, 'update_id' ) ); + + $result = array(); + + // Only attempt to update if there is something to up...
[CommandWithUpgrade->[_list->[get_all_items],update_all->[get_item_list],install->[install,install_from_repo],status->[status_single],status_all->[get_all_items]]]
Update all items in the list.
The idiomatic way would be to check `!empty( $items_to_update )`.