patch stringlengths 18 160k | callgraph stringlengths 4 179k | summary stringlengths 4 947 | msg stringlengths 6 3.42k |
|---|---|---|---|
@@ -36,7 +36,7 @@ namespace Microsoft.Xna.Framework.Graphics
/// <summary>
/// DXT5. Texture format with compression. Surface dimensions must be a multiple 4.
/// </summary>
- Dxt5 = 6,
+ Dxt5,
/// <summary>
/// Signed 16-bit bump-map format for store 8 bits fo... | [No CFG could be retrieved] | VersionInfo for all possible formats of a type of object. Pixel format using 16 bits per channel. | No functional or numeric change to the enum values... this was just a mistake that wasn't necessary. Makes interop with native code more clear. |
@@ -6,12 +6,13 @@ available. This code is being kept for now for backwards compatibility.
"""
import warnings
from typing import * # pylint: disable=wildcard-import, unused-wildcard-import
-from typing import Collection, IO
+from typing import Any
warnings.warn("acme.magic_typing is deprecated and will be remove... | [warn] | Get an attribute of the sequence. | Is this intentionally redundant? |
@@ -52,6 +52,10 @@ public class InfoSubcommand implements Callable<Void> {
@Parameters(description = "Decimal id of the container.")
private long containerID;
+ @CommandLine.Option(names = {"--verbose"},
+ description = "Show detailed info of the container.")
+ private boolean verbose;
+
@Override
... | [InfoSubcommand->[call->[getState,getContainerWithPipeline,createScmClient,checkNotNull,collect,getId,info,joining],buildDatanodeDetails->[getUuidString,getHostName],getLogger]] | Get a from the SCM. | Can we leverage the existing "--verbose" option defined in parent class GenericCli here? |
@@ -1259,7 +1259,7 @@ Spdp::remove_expired_participants()
DiscoveredParticipantIter part = participants_.find(*participant_id);
if (part != participants_.end()) {
const MonotonicTimePoint expr(MonotonicTimePoint::now() -
- rtps_time_to_time_duration(part->second.pdata_.leaseDuration));
+ ... | [No CFG could be retrieved] | The main entry point for the authentication process. - - - - - - - - - - - - - - - - - -. | Please avoid lines that are this long. It is in the guidelines, and our past experience is that someone else comes along later and changes it. |
@@ -384,7 +384,7 @@ if ($action == 'create') {
$sql = 'SELECT l.*';
$sql.= " FROM ".MAIN_DB_PREFIX."fichinterdet as l";
$sql.= " WHERE l.fk_fichinter= ".$object->id;
- $sql.= " AND l.fk_product is null ";
+ //$sql.= " AND l.fk_product is null ";
$sql.= " ORDER BY l.rang";
$result = $db->query($sql);
| [fetch,create,select_projects,form_project,fetch_object,jdate,addline,select_contract,getNomUrl,updateNbGenDone,formSelectContract,editfieldval,setFrequencyAndUnit,load,error,transnoentities,loadLangs,close,setMaxPeriod,delete,getFullName,textwithpicto,selectDate,transnoentitiesnoconv,fetch_name_optionals_label,query,f... | Displays a single sequence number that can be used to generate a sequence number. Print a list of all fichinters in the system. | Using * in to select is forbidden. Can you name each field ? |
@@ -0,0 +1,13 @@
+<?php
+/**
+ * Globally registers the 'social-logos' style and font.
+ *
+ * This ensures any theme or plugin using it is on the latest version of Social Logos, and helps to avoid conflicts.
+ */
+add_action( 'init', 'jetpack_register_social_logos', 1 );
+function jetpack_register_social_logos() {
+ i... | [No CFG could be retrieved] | No Summary Found. | For consistency with the JavaScript coding guidelines, I usually try to leave an extra newline in PHP files as well. In this case, it looks like the issue is also on the WPCOM side, so not sure that we need to fix it in this PR. I'll let you be the judge. |
@@ -134,7 +134,8 @@ int X509_CRL_sort(X509_CRL *c)
void X509_CRL_up_ref(X509_CRL *crl)
{
- CRYPTO_add(&crl->references, 1, CRYPTO_LOCK_X509_CRL);
+ int i;
+ CRYPTO_atomic_add(&crl->references, 1, &i, crl->lock);
}
long X509_CRL_get_version(X509_CRL *crl)
| [X509_CRL_set_issuer_name->[X509_NAME_set],X509_CRL_set_nextUpdate->[ASN1_STRING_dup,ASN1_TIME_free],X509_REVOKED_set_revocationDate->[ASN1_STRING_dup,ASN1_TIME_free],X509_CRL_get_signature_nid->[OBJ_obj2nid],X509_CRL_sort->[sk_X509_REVOKED_value,sk_X509_REVOKED_num,sk_X509_REVOKED_sort],X509_CRL_set_lastUpdate->[ASN1_... | Adds a reference to the given X509_CRL and returns the version of the CRL. | Most of <Type>_up_ref() methods are returning an int, except a few like this one. Is it a matter for a separated PR ? |
@@ -0,0 +1,15 @@
+// Licensed to the .NET Foundation under one or more agreements.
+// The .NET Foundation licenses this file to you under the MIT license.
+// See the LICENSE file in the project root for more information.
+
+using System;
+using System.Runtime.InteropServices;
+
+internal static partial class Interop... | [No CFG could be retrieved] | No Summary Found. | nit: make the return on this `BOOL` |
@@ -219,7 +219,7 @@ public class Queue extends ResourceController implements Saveable {
* to assign a work. Once a work is assigned, the executor actually gets
* started to carry out the task in question.
*/
- public class JobOffer extends MappingWorksheet.ExecutorSlot {
+ public static class Jo... | [Queue->[contains->[getItem],getApproximateItemsQuickly->[getItems],BuildableItem->[leave->[all],enter->[all,add],isStuck->[getEstimatedDuration,getAssignedLabel],getCauseOfBlockage->[isEmpty,getAssignedLabel,isBlockedByShutdown]],isBuildBlocked->[isBuildBlocked],getItems->[add],withLock->[call],BuildableRunnable->[run... | A class that manages the tasks that are being handed over to the executor and that are Checks if the given task can be taken from the node. | No inherited classes, should be fine |
@@ -1126,6 +1126,11 @@ export class AmpA4A extends AMP.BaseElement {
// modified url.
'src': xhrFor(this.win).getCorsUrl(this.win, adUrl),
}, SHARED_IFRAME_PROPERTIES));
+ const attributes = this.generateSentinelAndContext(iframe);
+ iframe.setAttribute('name', JSON.stringify(attrib... | [AmpA4A->[constructor->[AmpAdUIHandler,AmpAdXOriginIframeHandler,dev,platformFor,protectFunctionWrapper,now,SAFEFRAME],renderViaNameAttrOfXOriginIframe_->[NAMEFRAME,utf8Decode,dev,user,getDefaultBootstrapBaseUrl,stringify,assign,SAFEFRAME,reject,length,createElementWithAttributes],verifyCreativeSignature_->[cryptoKey,t... | Renders the content of the iframe using the cached content iframe. | Can you move this logic up so that `'name'` is also set by `createElementWithAttributes`, above? |
@@ -791,7 +791,7 @@ public class DruidCoordinator
public DruidCoordinatorRuntimeParams run(DruidCoordinatorRuntimeParams params)
{
// Display info about all historical servers
- Iterable<DruidServer> servers = FunctionalIterable
+ It... | [DruidCoordinator->[moveSegment->[execute->[execute],execute],dropSegment->[dropSegment,execute],becomeLeader->[start,createNewLeaderLatch],enableDatasource->[enableDatasource],start->[start],getCurrentLeader->[isLeader],removeSegment->[removeSegment],CoordinatorRunnable->[run->[stopBeingLeader,run]],removeDatasource->... | This method is called when the coordinator is starting. Returns a new object that represents a single cluster. | I think this copy needs to get made, then startingLeaderCounter needs to be checked again, then the runnable should run. Otherwise this will be a copy of a bad state. So maybe the runnables need to get split into a prepare() and run()? |
@@ -259,9 +259,12 @@ int ACE_TMAIN(int argc, ACE_TCHAR* argv[])
ACE_INET_Addr spdp(rtps_discovery->get_spdp_port(application_domain, application_participant_id), "127.0.0.1");
ACE_INET_Addr sedp(rtps_discovery->get_sedp_port(application_domain, application_participant_id), "127.0.0.1");
- SpdpHandler spdp_vert... | [No CFG could be retrieved] | region Public API Methods Opens the related handlers for the N - tuple. | Need to cover builds that are have security disabled at compile time using `OPENDDS_SECURITY` preprocessor macro |
@@ -1335,6 +1335,7 @@ function _mapStateToProps(state) {
_desktopSharingDisabledTooltipKey: desktopSharingDisabledTooltipKey,
_dialog: Boolean(state['features/base/dialog'].component),
_feedbackConfigured: Boolean(callStatsID),
+ _hasMultipleCameras: videoInput.length > 1,
_is... | [No CFG could be retrieved] | The default features based on token are enabled by default. | We should check if there are exactly 2, right? |
@@ -38,8 +38,8 @@ public class StripedLock {
* Locks all write locks. Ensure that {@link StripedLock#unlockAll()} is called in a proper finally block
*/
public void lockAll() {
- for (ReadWriteLock rwLock : locks) {
- rwLock.writeLock().lock();
+ for (StampedLock rwLock : locks) {
+ ... | [StripedLock->[unlockAll->[unlock],getLockWithOffset->[ArrayIndexOutOfBoundsException],lockAll->[lock],ReentrantReadWriteLock,findNextHighestPowerOfTwo]] | Lock all read - write locks. | Too bad `unstampedUnlockWrite()` is package-private :) |
@@ -216,6 +216,13 @@ const files = {
templates: [
'shared/reducers/locale.ts'
]
+ },
+ {
+ condition: generator => generator.authenticationType === 'oauth2',
+ path: REACT_DIR,
+ templates: [
+ 'shared/reducers/user... | [No CFG could be retrieved] | This module contains all the necessary tsx files and methods that can be used to generate the Missing modules are required to process JSX files. | please name it as `user-management` as service is used only in context of angular |
@@ -27,6 +27,10 @@ var (
)
func init() {
+ registry.Commands = append(registry.Commands, registry.CliCommand{
+ Mode: []entities.EngineMode{entities.ABIMode, entities.TunnelMode},
+ Command: unpauseCommand,
+ })
registry.Commands = append(registry.Commands, registry.CliCommand{
Mode: []entities.EngineM... | [IsRemote,IsRootless,Println,Background,New,ContainerUnpause,ContainerEngine,Errorf,PrintErrors,BoolVarP,Flags] | ContainerUnpauseImports imports and starts a new container with the given name or ID. nannannannannannannannannannannannannannannannannannan. | nit, it would good to switch the order of lines 36 and 37 to match the other commands. |
@@ -177,8 +177,8 @@ class CommandOutputer(object):
if isinstance(ref, ConanFileReference):
item_data["recipe"] = node.recipe
- if get_env("CONAN_CLIENT_REVISIONS_ENABLED", False) and node.ref.revision:
- item_data["revision"] = node.ref.revision
+ ... | [CommandOutputer->[print_user_set->[info],info->[_grab_info_data],print_dir_list->[info],_grab_info_data->[_read_dates,_add_if_exists],print_user_list->[info],print_revisions->[info],json_nodes_to_build->[_handle_json_output],print_search_packages->[print_search_packages],json_info->[_grab_info_data,_handle_json_output... | Convert deps_graph into consumible information for json and cli Add missing information to the item_data dictionary. Return a list of items with a . | I am reviewing this, seems unused now. |
@@ -164,9 +164,9 @@ class AccountQueries(graphene.ObjectType):
def resolve_staff_users(self, info, query=None, **_kwargs):
return resolve_staff_users(info, query=query)
- @permission_required("account.manage_users")
+ @one_of_permissions_required(["account.manage_staff", "account.manage_users"])
... | [AccountQueries->[resolve_customers->[resolve_customers],resolve_address_validation_rules->[resolve_address_validation_rules],resolve_staff_users->[resolve_staff_users],resolve_service_accounts->[resolve_service_accounts],StaffUserInput,ServiceAccountFilterInput,CustomerFilterInput]] | Resolve staff users. | I don't think we need to check twice the permissions? Through this wrap and then we check again in `resolve_user` |
@@ -792,6 +792,14 @@ def pad_to_bounding_box(image, offset_height, offset_width, target_height,
ValueError: If the shape of `image` is incompatible with the `offset_*` or
`target_*` arguments, or either `offset_height` or `offset_width` is
negative.
+
+ Usage example:
+ ```python
+
+ >... | [resize_image_with_pad_v2->[_resize_fn->[resize_images_v2],_resize_image_with_pad_common],encode_png->[encode_png],_resize_images_common->[_ImageDimensions],resize_bicubic->[resize_bicubic],crop_to_bounding_box->[_assert,_ImageDimensions,_CheckAtLeast3DImage,_is_tensor],resize_image_with_crop_or_pad->[max_->[_is_tensor... | Pads the image with zeros to the specified height and width and then pads it on Get a single in the image. | Assert something about the result to make this a doctest? Like print its shape at least? |
@@ -127,6 +127,9 @@ class CryptoToFiatConverter:
if crypto_symbol == fiat_symbol:
return 1.0
+ if self._cryptomap == {} and self._backoff <= datetime.datetime.now().timestamp():
+ self._load_cryptomap()
+
if crypto_symbol not in self._cryptomap:
# return 0... | [CryptoToFiatConverter->[__new__->[__new__],_find_price->[_is_supported_fiat,get_price]]] | Get the price of the given crypto - currency in the Fiat . | I'm not sure about the impact of this ... it's called from (semi)random spots in the code - so doing 2 calls "inline" might slow down certain points - and if that again runs into the ratelimit - it might not fix anything after all ... |
@@ -1021,11 +1021,11 @@ module Email
body = body.strip.downcase
case body
- when "mute"
+ when "mute", "muted", I18n.t("js.topic.notifications.muted.title").downcase
NotificationLevels.topic_levels[:muted]
- when "track"
+ when "track", I18n.t("js.topic.notifications.trackin... | [Receiver->[extract_from_zimbra->[to_markdown],find_related_post->[sent_to_mailinglist_mirror?],find_or_create_user!->[find_or_create_user],extract_from_exchange->[to_markdown],attachments->[is_allowed?],stage_from_user->[log_and_validate_user],extract_from_outlook->[to_markdown],extract_from_apple_mail->[to_markdown],... | Returns notification level for given body. | Will `I18n.t` here be the author locale or the site locale? |
@@ -266,12 +266,14 @@ void AddProcessesToPython(pybind11::module& m)
;
py::class_<LevelSetConvectionProcess<2,SparseSpaceType,LocalSpaceType,LinearSolverType>, LevelSetConvectionProcess<2,SparseSpaceType,LocalSpaceType,LinearSolverType>::Pointer, Process>(m,"LevelSetConvectionProcess2D")
+ .def(py::... | [CalculateDiscontinuousEmbeddedVariableFromSkinDouble->[CalculateEmbeddedVariableFromSkin],AddProcessesToPython->[,EntityTransfered>,attr,Pointer>,Process>,def],CalculateDiscontinuousEmbeddedVariableFromSkinArray->[CalculateEmbeddedVariableFromSkin],CalculateEmbeddedVariableFromSkinArray->[CalculateEmbeddedVariableFrom... | Adds processes to Python module m. Find NODAL_H - > FindNodalH - > FindNod Magic node. Initialize the objects defined in the model model. Initialize the variational distance calculation processes. Variational distance calculation processes. | Hm this is a lot of individual settings I think a better solution would be a CTor that accepts `Parameters` |
@@ -393,9 +393,9 @@ func (c *Controller) reconcileShoot(shoot *gardencorev1beta1.Shoot, logger *logr
}
}
- if err := c.runReconcileShootFlow(o, operationType); err != nil {
+ if err := c.runReconcileShootFlow(o); err != nil {
c.recorder.Event(shoot, corev1.EventTypeWarning, gardencorev1beta1.EventReconcileErr... | [reconcileShoot->[checkSeedAndSyncClusterResource,durationUntilNextShootSync,reconcileInMaintenanceOnly,updateShootStatusProcessing,respectSyncPeriodOverwrite,updateShootStatusError],durationUntilNextShootSync->[respectSyncPeriodOverwrite,reconcileInMaintenanceOnly],deleteShoot->[checkSeedAndSyncClusterResource,respect... | reconcileShoot attempts to reconcile a given shoot. finalizer to Shoot object ToDate checks if Shoot can be reconciled and if it can be reconciled and if This function is called by the reconcile shim flow to reconcile a Shoot cluster state. | If there is an error during reconcile, it will return an error -> leads to another reconcile -> syncs the Cluster resource containing the Shoot to the Seed. Is that the reason for not syncing the Cluster resource to the Seed here? |
@@ -54,7 +54,12 @@ class PyRequires(object):
try:
return self._pyrequires[item]
except KeyError:
- raise ConanException("'%s' is not a python_require" % item)
+ # https://github.com/conan-io/conan/issues/8546
+ # Transitive pyrequires are accessed by inher... | [PyRequires->[items->[items]],PyRequireLoader->[_resolve_py_requires->[PyRequire,PyRequires,update_transitive],_load_pyreq_conanfile->[_load_pyreq_conanfile]],ConanPythonRequire->[__call__->[_look_for_require],_look_for_require->[_look_for_require]]] | Get a python_require object from the list of python_requires. | Sounds like this class could get a refactor, but lets wait until moving this forward first, if we think it is correct. |
@@ -21,11 +21,10 @@ from ..base.context import context
from ..common.compat import on_win, text_type
from ..core.index import get_index
from ..core.linked_data import linked as install_linked
-from ..exceptions import (CondaEnvironmentNotFoundError,
- CondaIOError, CondaImportError, CondaOSE... | [install->[get_revision,install,check_prefix,print_activate,clone]] | Create a new object from a given environment name. Get the unique identifier for a given prefix. | cmd-option-o does the `\` thing. Switch it back to using parenthesis. |
@@ -1762,7 +1762,8 @@ function constructSRARequest_(a4a, instances) {
Object.assign(
blockParameters,
googPageLevelParameters,
- instances[0].getPageParameters(instances[0].consentState, instances)
+ instances[0].getPageParameters(
+ instances[0].consentState,... | [AmpAdNetworkDoubleclickImpl->[postTroubleshootMessage->[dict,stringify,now,devAssert,userAgent],extractSize->[height,extractAmpAnalyticsConfig,dev,get,width],getBlockParameters_->[width,height,getFlexibleAdSlotData,isInManualExperiment,serializeTargeting,devAssert,googleBlockParameters,Number],constructor->[user,exten... | Get the network id of an element that should be included in the ad request. Resets the tokensToInstances mapping for testing purposes. | No need to pass consentString through like this, instead store on the instance object and access in same manner as currently getting consentState |
@@ -146,15 +146,6 @@ public class LocalSetupPanel extends SetupPanel implements Observer {
layoutComponents();
}
- public String getPlayerType(final String playerName) {
- for (final LocalPlayerComboBoxSelector item : m_playerTypes) {
- if (item.getPlayerName().equals(playerName)) {
- return i... | [LocalPlayerComboBoxSelector->[actionPerformed->[setWidgetActivation],setWidgetActivation],LocalSetupPanel->[getLauncher->[getPlayerType],getPlayerType->[getPlayerType],update->[layoutComponents]]] | Update the component. | The last call to this method appears to have been removed in 6bf3caf (when this class was previously named `LocalPlayerSelectionPanel`). |
@@ -36,7 +36,8 @@ void ERR_print_errors_cb(int (*cb) (const char *str, size_t len, void *u),
data = "";
hex = OPENSSL_buf2hexstr((const unsigned char *)&tid, sizeof(tid));
BIO_snprintf(buf, sizeof(buf), "%s:error:%s:%s:%s:%s:%d:%s\n",
- hex, lib, func, reason, file, li... | [ERR_print_errors_fp->[ERR_print_errors_cb],ERR_print_errors->[ERR_print_errors_cb]] | if cb is NULL - > print all errors. | Same here. _(If you prefer to check `hex == NULL` instead of `hex != NULL` as I did above, that's ok for me too._) |
@@ -78,7 +78,7 @@ class WPCOM_REST_API_V2_Endpoint_Service_API_Keys extends WP_REST_Controller {
'type' => 'object',
'properties' => array(
'code' => array(
- 'description' => __( 'Displays success if the oppration was successfully executed and an error code if it was not', 'jetpack' ),
... | [WPCOM_REST_API_V2_Endpoint_Service_API_Keys->[get_public_item_schema->[add_additional_fields_schema],update_service_api_key->[get_body_params,get_json_params]]] | Get the schema for the public item. | @enejb Should `success` be in quotes since this will be the actual text of `code`? |
@@ -141,7 +141,7 @@ class PathRepository extends ArrayRepository implements ConfigurableRepositoryIn
$this->addPackage($package);
}
- if (count($this->getPackages()) == 0) {
+ if (count($this->getPackages()) == 0 && $this->ignoreEmpty !== true) {
throw new \RuntimeExce... | [PathRepository->[initialize->[addPackage,getUrlMatches,getPackages,guessVersion,load,execute]]] | Initializes the node - package - chains. | That new check should be first as it's less costing than count. |
@@ -451,12 +451,15 @@ void GenericSmallStrainFemDemElement<TDim,TyieldSurf>::IntegrateStressDamageMech
}
const double F = uniaxial_stress - rThreshold;
- if (F <= 0.0) { // Elastic region --> Damage is constant
+ if (F <= tolerance) { // Elastic region --> Damage is constant
rDamage = mDamages[Edge];
} else ... | [No CFG could be retrieved] | This function calculates the equivalent stress and damage for a given element. Calculate average variable on edge of a non - zero element on edge 3 - D. | ...Migrate to SMA... |
@@ -149,13 +149,13 @@ def assert_server_response_ok():
raise AssertionError(str(error)) from error
-def assert_url_is_accessible(url, timeout=5.0):
+def assert_url_is_accessible(url, timeout=30.0):
request = Request(url, headers={"method": "HEAD", "User-Agent": USER_AGENT})
with assert_server_res... | [stl10->[collect_download_configs],kmnist->[collect_download_configs],caltech101->[collect_download_configs],sbu->[collect_download_configs],omniglot->[collect_download_configs],qmnist->[collect_download_configs],log_download_attempts->[add_mock->[add_mock],add_mock],fashion_mnist->[collect_download_configs],sbdataset-... | Assert that the given URL is accessible. | Is this the minimum value that will work? I'm just worried that this has the potential of increasing a lot the run-time of multiple unit-tests. Any other workaround? |
@@ -185,7 +185,7 @@ Note.blueprint do
noteable_type {'Grouping'}
noteable_id {Grouping.make.id}
user {Admin.make}
- notes_message {Faker::Lorem.paragraphs}
+ notes_message { Faker::Lorem.paragraphs[0] }
end
NoLateSubmissionRule.blueprint do
| [line_start,annotation_category,message,level_1_name,assign_graders_to_criteria,grade_entry_item,paragraphs,notes_message,annotation_category_name,level_0_name,grace_credits,out_of,is_remark,deduction,filename,grouping,hours,y1,marking_state,level_2_name,enable_test,group_min,hidden,annotation_number,student_user_name,... | The blueprints for the individual object. Create blueprints for all of the individual - type result objects. | Unnecessary spacing detected. |
@@ -53,7 +53,7 @@ namespace Dynamo.Search.SearchElements
Parameters = parameters.ToString();
}
-
+
FullCategoryName = functionDescriptor.Category;
Description = functionDescriptor.Description;
Assembly = functionDescriptor.Assembly;
| [ZeroTouchSearchElement->[NodeModel->[IsVarArg],GetIconName->[IsOverloaded,IsNullOrEmpty,FunctionName,QualifiedName,TypedParametersToString,NormalizeAsResourceName],GetIconName,UserFriendlyName,IsOverloaded,Count,IsBuiltIn,Add,MangledName,Format,Append,Category,Description,Select,Packaged,ZeroTouch,Join,Name,GetFileNam... | The full name of entry which consists of assembly name and qualified name for function descriptor. Count the number of elements in the list. | We can revert this file - no real changes other than whitespace. |
@@ -122,7 +122,6 @@ import com.cloud.utils.time.InaccurateClock;
**/
public class AgentManagerImpl extends ManagerBase implements AgentManager, HandlerFactory, Configurable {
protected static final Logger s_logger = Logger.getLogger(AgentManagerImpl.class);
- protected static final Logger status_logger = Log... | [AgentManagerImpl->[HandleAgentConnectTask->[runInContext->[handleConnectedAgent]],pullAgentToMaintenance->[findAttache],MonitorTask->[runInContext->[disconnectWithoutInvestigation,disconnectWithInvestigation,create]],reconnect->[findAttache],disconnectWithInvestigation->[disconnectInternal,DisconnectTask],loadDirectly... | Implementation of the AgentManager class. Initialize the agent status. | this seems a functional backwards incompatible change. Did you considder that? |
@@ -89,9 +89,13 @@ func TestClient_CreateJobSpec(t *testing.T) {
nJobs int
errored bool
}{
- {"bad input", 0, true},
+ {"{bad json}", 0, true},
+ {"bad/filepath/", 0, true},
{`{"initiators":[{"type":"web"}],"tasks":[{"type":"NoOp"}]}`, 1, false},
{`{"initiators":[{"type":"runAt","time":"2018-01-08T18... | [Nil,ShowJobSpec,Equal,NewApplicationWithKeyStore,RunNode,GetJobSpecs,Empty,NewClientAndRenderer,NewApplication,NewJob,Parse,NotNil,CreateJobSpec,SaveJob,NewFlagSet,Jobs,True,NewContext] | TestClient_CreateJobSpec tests the creation of a job spec. | I understand we might want to test the `~/some_job.json` but for now lets skip that scenario. We already have coverage and that edge case is handled by `homedir`, no need to test a third party package. |
@@ -351,6 +351,7 @@ export class AmpStoryPage extends AMP.BaseElement {
if (this.isActive()) {
this.advancement_.start();
this.maybeStartAnimations();
+ this.findAndPrepareEmbeddedComponents();
this.checkPageHasAudio_();
this.renderOpenAttachmentUI_();
this.preloadAllMedia_(... | [AmpStoryPage->[setState->[PLAYING,dev,NOT_ACTIVE,PAUSED],pauseCallback->[DESKTOP_PANELS,UI_STATE],constructor->[resolve,timerFor,NOT_ACTIVE,forElement,getStoreService,platformFor,promise,debounce,reject],emitProgress_->[dict,PAGE_PROGRESS,dispatch],unmuteAllMedia->[removeAttribute,unmute,muted],getPreviousPageId->[id,... | Callback for resume of the media. | Should this be done when we preload/prerender the page, when distance is set to `<= 2`, instead of doing it when navigating to the page? |
@@ -147,4 +147,8 @@ public class EnrichedNotificationInfo {
public FlowCallStack getFlowCallStack() {
return flowCallStack;
}
+
+ public TypedValue evaluateExpression(ExpressionManager expressionManager, String script) {
+ return expressionManager.evaluate(script, event);
+ }
}
| [EnrichedNotificationInfo->[createInfo->[createInfo,EnrichedNotificationInfo]]] | Get the flow call stack. | Add a TODO to remove this |
@@ -263,7 +263,10 @@ function collectProps(Ctor, element, defaultProps) {
// Props.
for (const name in propDefs) {
const def = propDefs[name];
- const value = element.getAttribute(def.attr);
+ const value =
+ def.type == 'boolean'
+ ? element.hasAttribute(def.attr)
+ : element.getAtt... | [No CFG could be retrieved] | Collects props of an element with optional children. finds the child element and assigns it to slotProps. | Are these the only rules we have? Is there a rule about "false" string values? |
@@ -1166,10 +1166,12 @@ class LibSolvSolver(Solver):
# This function will populate the pool/repos with
# the current state of the given channels
- channels_urls = [(c.base_url or c.canonical_name) for c in self.channels]
- index = load_channels(pool, channels_urls, repos,
+ # No... | [diff_for_unlink_link_precs->[_add_to_unlink_and_link],LibSolvSolver->[_configure_solver_for_install->[Solver],_configure_solver_for_remove->[Solver]],Solver->[get_constrained_packages->[empty_package_list],_add_specs->[_should_freeze,_package_has_updates],_post_sat_handling->[solve_final_state]]] | Setup the state of a object. | Let's report this to Mamba and see whether it can be fixed upstream |
@@ -133,6 +133,11 @@ class StageLoader(Mapping):
def __contains__(self, name):
return name in self.resolved_data
+ def is_foreach_generated(self, name: str):
+ return (
+ name in self.stages_data and FOREACH_KWD in self.stages_data[name]
+ )
+
class SingleStageLoader(Mappi... | [SingleStageLoader->[__getitem__->[load_stage]],StageLoader->[__getitem__->[load_stage],load_stage->[fill_from_lock]]] | Check if a sequence identifier exists. | Temporary solution for now, will be fixed during optimization. |
@@ -220,10 +220,13 @@ int distort_transform(dt_iop_module_t *self, dt_dev_pixelpipe_iop_t *piece, floa
const int border_size_t = border_tot_height * d->pos_v;
const int border_size_l = border_tot_width * d->pos_h;
+ // nothing to be done if parameters are set to neutral values (no top/left border)
+ if (borde... | [No CFG could be retrieved] | IOP_TAG_DISTORT | IOP_TAG_DECORATION | ort_backtransform - backtransform algorithm. | This seems really wrong to me... If OpenMP is active and we have less than 100 points we do nothing! |
@@ -60,7 +60,13 @@ module Upaya
end
end
- config.middleware.use Rack::Attack if Figaro.env.enable_rate_limiting == 'true'
+ if Figaro.env.enable_rate_limiting == 'true'
+ config.middleware.use Rack::Attack
+ else
+ # Rack::Attack auto-includes itself as a Railtie, so we need to
+ #... | [Application->[new,allow,twilio_auth_token,queue_adapter,join,load_path,lambda,domain_name,log_formatter,use,time_zone,autoload_paths,require,origins,time,migration_error,enable_rate_limiting,per_form_csrf_tokens,resource,default_url_options,default_locale,present?,except,try,custom_options,insert_before,uuid,available... | Check if the resource is well - known and if so configure it. | I guess technically this line is redundant now .... we could just only remove it if not needed? |
@@ -414,10 +414,10 @@ def validate_activation(classifier_activation, weights):
return
classifier_activation = activations.get(classifier_activation)
- if classifier_activation not in [
+ if classifier_activation not in {
activations.get('softmax'),
activations.get(None)
- ]:
+ }:
raise ... | [_preprocess_numpy_input->[floatx,astype,issubclass],preprocess_input->[_preprocess_numpy_input,_preprocess_symbolic_input,str,ValueError,isinstance,image_data_format],_preprocess_symbolic_input->[dtype,cast,ndim,bias_add,constant,array],validate_activation->[ValueError,get],correct_pad->[int_shape,isinstance,image_dat... | Validates that the given classifier_activation is compatible with the given weights. | Why do you want to change this to a dict? |
@@ -92,8 +92,15 @@ module.exports = JhipsterClientGenerator.extend({
defaults: 'jhi'
});
+ // This adds support for a `--skip-user-management` flag
+ this.option('skip-user-management', {
+ desc: 'Skip the user management module during app generation',
+ type:... | [No CFG could be retrieved] | This function provides the options for the given application. The main function that is called when the user is entering the configuration. | Its should be `||` instead of second `=` |
@@ -351,7 +351,8 @@ func TestMasterConfig(t *testing.T) {
AssetConfig: &internal.AssetConfig{
Extensions: []internal.AssetExtensionsConfig{{}},
},
- DNSConfig: &internal.DNSConfig{},
+ DNSConfig: &internal.DNSConfig{},
+ AdmissionPluginConfig: map[string]string{"pluginName": "configFilePath"}, ... | [JSONToYAML,Fatal,Errorf,StringDiff,Encode] | returns a list of possible objects. | I would rather see a list of name/config pairs, rather than a list of names, and a map of config files |
@@ -462,11 +462,11 @@ public class ResourceBuilder {
StringBuilder filter = new StringBuilder();
filter.append("(").append(HostNamespace.HOST_NAMESPACE).append("=").append(bsn).append(")");
- String v = attrs.getVersion();
+ String v = attrs.get(HostNamespace.CAPABILITY_BUNDLE_VERSION_ATTRIBUTE);
if (v != ... | [ResourceBuilder->[addAllExecutionEnvironments->[addExportPackages,addExecutionEnvironment],addProvideCapability->[addCapability0],addExportPackage->[addCapability],addRequireCapability->[addRequirement],addRequirement->[addRequirement],addProvideCapabilities->[addProvideCapabilities],addRequireBundle->[addRequireBundl... | Add a fragment host. | Lets not do a replaceAll. Instead, fix `VersionRange.toFilter()` (or overload it) to take the attribute name as a argument. See OSGi's `VerionRange.toFilterString(String)`. The then call here becomes `range.toFilter(HostNamespace.CAPABILITY_BUNDLE_VERSION_ATTRIBUTE)`. |
@@ -17,6 +17,13 @@
<%= form.label :body_html %> (Only if not using markdown. HTML is dangerous ⚠️)
<%= form.text_area :body_html, class: "form-control" %>
</div>
+ <% unless Rails.env.production? %>
+ <div class="form-group">
+ <%= form.label :local_path %> (Use for local d... | [No CFG could be retrieved] | Displays a list of fields that are related to a user s page. Hides the hidden input and the check box. | If we just defaulted paths, we wouldn't have to store anything in the database! |
@@ -2272,6 +2272,12 @@ class MeanIoU(Metric):
Returns:
Update op.
"""
+
+ # If y_true and y_pred are lists then
+ # they are converted into Tensors
+ y_true = math_ops.cast(y_true, self._dtype)
+ y_pred = math_ops.cast(y_pred, self._dtype)
+
# Flatten the input if its rank > ... | [Reduce->[__init__->[add_weight]],SensitivitySpecificityBase->[__init__->[add_weight]],Precision->[__init__->[add_weight]],AUC->[result->[interpolate_pr_auc],__init__->[add_weight]],MeanIoU->[__init__->[add_weight]],clone_metric->[get_config],Recall->[__init__->[add_weight]],sparse_categorical_accuracy->[dtype],MeanTen... | Accumulates the confusion matrix statistics. | nit: I think we can remove these lines. |
@@ -39,6 +39,7 @@ class SchemaUtils {
.put("DATETIME", FieldType.DATETIME)
.put("DOUBLE", FieldType.DOUBLE)
.put("FLOAT", FieldType.DOUBLE)
+ .put("FLOAT64", FieldType.DOUBLE)
.put("INT32", FieldType.INT32)
.put("INT64", FieldType.INT64)
.put("S... | [SchemaUtils->[getBeamFieldType->[fromColumnsList]]] | This method is used to import a Beam schema from a DataCatalog. Returns a Field object for the given column. | Actually why FLOAT maps to DOUBLE? |
@@ -1193,7 +1193,7 @@ func (mod *modContext) genResource(res *schema.Resource) (string, error) {
if hasStateInputs {
for _, prop := range res.StateInputs.Properties {
- pname := PyName(prop.Name)
+ pname := InitParamName(prop.Name)
ty := mod.typeString(prop.Type, true, true, true, true /*optional*/,... | [resourceType->[modNameAndName],genInit->[hasTypes,genHeader,unqualifiedImportName,submodulesExist,isEmpty,fullyQualifiedImportName],pyType->[pyType,resourceType],isEmpty->[isEmpty],walkSelfWithDescendants->[walkSelfWithDescendants],fullyQualifiedImportName->[fullyQualifiedImportName,unqualifiedImportName],objectType->... | genResource generates the code for a resource Produce a type that can be used to create a resource. Produce a class definition with optional Initialize the object Print out a list of all the possible options for a specific resource. | I think we also need to use `InitParamName` when assigning the param to `__props__.__dict__` below. |
@@ -310,6 +310,11 @@ class ComputedExpression(Expression):
requires_partition_by: The required (common) partitioning of the args.
preserves_partition_by: The level of partitioning preserved.
"""
+ assert preserves_partition_by != partitionings.Nothing(), (
+ "Preserving Nothing() partitioni... | [elementwise_expression->[ComputedExpression],PartitioningSession->[evaluate->[evaluate_with->[is_scalar,evaluate,lookup,Session],is_scalar,evaluate_with]],ComputedExpression->[evaluate_at->[evaluate],placeholders->[placeholders,args],__init__->[proxy]],PlaceholderExpression->[evaluate_at->[lookup]]] | Initialize a ComputedExpression with a . | This assumes we will never have anything between Index and Nothing. Maybe that's a fair assumption. |
@@ -33,7 +33,10 @@ class TestDistMnistNCCL2DGC(TestDistBase):
if fluid.core.is_compiled_with_cuda():
self.check_with_place(
"dist_mnist.py",
- delta=1e-5,
+ # FIXME(wangxi): DGC may need a new unit test because its algo flow
+ # is qui... | [TestDistMnistNCCL2DGCMultiCards->[test_dist_train->[check_with_place_multi_cards,is_compiled_with_cuda]],TestDistMnistNCCL2DGC->[test_dist_train->[check_with_place,is_compiled_with_cuda]],splitext,main] | Check if missing missing data is train. | How to assert when DGC be disabled? |
@@ -1615,7 +1615,7 @@ void ModelPart::RemoveGeometry(
for (SubModelPartIterator i_sub_model_part = SubModelPartsBegin();
i_sub_model_part != SubModelPartsEnd();
- i_sub_model_part++)
+ ++i_sub_model_part)
i_sub_model_part->RemoveGeometry(GeometryId);
}
| [No CFG could be retrieved] | Adds a geometry to the geometry container. Remove a geometry from all levels of the model. | even though this makes sense, please consider opening a separate PR for this. Imagine that for some strange reason this breaks sth, then tracking it down will be much harder if done on the side in an unrelated PR |
@@ -77,6 +77,8 @@ type Config struct {
DatastorePath string
HostPath string
PoolPath string
+
+ VCHFolder *object.Folder
}
// Session caches vSphere objects obtained by querying the SDK.
| [Connect->[Vim25],IsVC->[IsVC],Populate->[IsVC],RoundTrip] | Package private for testing purposes LimitConcurrency limits how many requests can be processed at once. | Even though the name is self-explanatory, a description for this exported field would be helpful - would be nice to note that this stores a different path depending on VC or ESX. |
@@ -49,6 +49,7 @@ export class ValidationBubble {
/** @private @const {!Element} */
this.bubbleElement_ = ampdoc.win.document.createElement('div');
+ toggle(this.bubbleElement_, false);
this.bubbleElement_.classList.add('i-amphtml-validation-bubble');
this.bubbleElement_[OBJ_PROP] = this;
| [No CFG could be retrieved] | Creates a validation bubble component which displays messages in the page. Shows the bubble of the given element with the passed message. | Why switch the default state of these? |
@@ -47,4 +47,11 @@ RSpec.describe "articles/show", type: :view do
expect(rendered).to have_css("form#new_comment")
expect(rendered).to have_css("input#submit-button")
end
+
+ it "shows a note about the canonical URL" do
+ allow(article1).to receive(:canonical_url).and_return("https://example.com/lamas"... | [create_comment->[create,id],create,text,new,let,describe,it,name,decorate,to,before,extend,have_text,require,all?,assign,title,id,have_css,without_partial_double_verification,and_return] | expects the form to be new comment or submit button. | `rendered` is full of newlines and whitespace, so I just match twice. Alternatively we can match on `/\AOriginally published at\s+example.com\z/`, LMK which one you prefer. |
@@ -34,8 +34,7 @@ def check_output_command(file_path, head=None, tail=None):
def kill_command(pid):
"""kill command"""
if sys.platform == 'win32':
- process = psutil.Process(pid=pid)
- process.send_signal(signal.CTRL_BREAK_EVENT)
+ psutil.Process(pid).terminate()
else:
cmds... | [call_pip_uninstall->[call],call_pip_install->[call,_get_pip_install],kill_command->[send_signal,call,str,Process],install_requirements_command->[call,_get_pip_install],check_output_command->[str,check_output,format,print_error,exists,exit],install_package_command->[call,_get_pip_install],_get_pip_install->[append,getu... | kill command with pid. | For windows platform, main.ts monitor `SIGBREAK` signal to trigger stop process, does this terminate() function in win32 trigger `SIGBREAK`? |
@@ -141,7 +141,7 @@ public class StatPanel extends AbstractStatPanel {
}
protected ImageIcon getIcon(final String playerName) {
- final PlayerID player = this.m_data.getPlayerList().getPlayerID(playerName);
+ final PlayerID player = this.gameData.getPlayerList().getPlayerID(playerName);
if (player ==... | [StatPanel->[initLayout->[print->[print]],setGameData->[setGameData],TechTableModel->[getValueAt->[update],update->[clearAdvances]],getIcon->[getIcon],StatTableModel->[getValueAt->[loadData]],fillPlayerIcons->[getIcon]]] | Get the icon for a player. | explicit this is not needed |
@@ -26,11 +26,6 @@ import java.util.List;
import java.util.Map;
import java.util.Properties;
-import lombok.Getter;
-import lombok.Setter;
-import lombok.ToString;
-import lombok.extern.slf4j.Slf4j;
-
import org.apache.commons.lang3.StringUtils;
import org.apache.hadoop.fs.FileSystem;
import org.apache.hadoop.fs... | [HiveDataset->[getPartitionsFromDataset->[sortPartitions]]] | Imports a single - dimensional array of objects. package for testing. | Was this change relevant ? |
@@ -1265,6 +1265,16 @@ public class OmMetadataManagerImpl implements OMMetadataManager {
return tenantUserTable;
}
+ @Override
+ public Table<String, OmDBAccessIdInfo> getTenantAccessIdTable() {
+ return tenantAccessIdTable;
+ }
+
+ @Override
+ public Table<String, OmDBAccessIdInfo> getPrincipalToAcce... | [OmMetadataManagerImpl->[isVolumeEmpty->[startsWith,getVolumeKey],isBucketEmpty->[startsWith,getBucketKey],initializeOmTables->[checkTableStatus],listVolumes->[startsWith,getVolumeKey],listBuckets->[startsWith,getVolumeKey,getBucketKey],loadDB->[loadDB],listKeys->[getOzoneKey,startsWith,getBucketKey],listAllVolumes->[s... | Gets the tenant user and tenant state tables. | Same as above, should be OmDBKerberosPrincipalInfo for the table value? |
@@ -2,5 +2,5 @@
# Licensed under the MIT license.
from .config import *
-from .experiment import Experiment
-from .data import *
+#from .experiment import Experiment
+#from .data import *
| [No CFG could be retrieved] | Copyright 2015 The MIT License. | remove the line if it is not used anymore, or add annotation to annotate why it should keep. |
@@ -73,6 +73,7 @@ def make_app(static_dir: str = None) -> Sanic:
raise ServerError("unknown model: {}".format(model_name), status_code=400)
data = req.json
+ logger.info("model: %s inputs: %s", model_name, json.dumps(data))
# See if we hit or not. In theory this could result in... | [run->[run],make_app->[predict->[_caching_prediction]]] | Create a Sanic application with a specific base path. Get the n - node model and predict the n - node model. | @joelgrus why not log the answer as well? |
@@ -473,7 +473,9 @@ public class DeltaSync implements Serializable {
boolean success = writeClient.commit(instantTime, writeStatusRDD, Option.of(checkpointCommitMetadata));
if (success) {
LOG.info("Commit " + instantTime + " successful!");
-
+ if (this.props.getBoolean(KafkaOffsetGen.Confi... | [DeltaSync->[getHoodieClientConfig->[getHoodieClientConfig],registerAvroSchemas->[registerAvroSchemas],startCommit->[startCommit],syncMeta->[getSyncClassShortName],syncHive->[syncHive],syncOnce->[refreshTimeline],close->[close]]] | Writes the records to the sink. Schedule compaction if needed. | code format `KafkaOffsetGen.Config.ENABLE_KAFKA_COMMIT_OFFSET, KafkaOffsetGen.Config.DEFAULT_ENABLE_KAFKA_COMMIT_OFFSET` |
@@ -58,7 +58,7 @@ class PylintSourcePlugin(Target):
alias = "pylint_source_plugin"
core_fields = (
- *(FrozenOrderedSet(COMMON_PYTHON_FIELDS) - {Dependencies}),
+ *(FrozenOrderedSet(COMMON_PYTHON_FIELDS) - {Dependencies}), # type: ignore[misc]
PylintPluginDependencies,
Pylin... | [PylintSourcePlugin->[FrozenOrderedSet]] | A plugin that is not included in the list of core fields. | MyPy complains about mixing an `AsyncField` with a `PrimitiveField`, from what I grok from the error message. This seems very much like a bug in MyPy. If/when they fix it, MyPy will complain about the unnecessary ignore. |
@@ -150,6 +150,13 @@ HeapCreate(
}
+__attribute__((no_instrument_function, noinline))
+static bool PAL_Initialize_Check_Once()
+{
+ int error = PAL_InitializeChakraCore();
+ return error == ERROR_SUCCESS;
+}
+
/*++
Function:
GetProcessHeap
| [No CFG could be retrieved] | Creates a handle for a specific non - zero non - zero non - zero non - zero Get the handle of a specific noflag. | Why is this code repeated in different files? |
@@ -71,6 +71,15 @@ public class EmbeddedLauncher {
}
}
}
+ throw new RuntimeException("Found Nothing to launch. Maybe no " + EMBEDDED_RUNPATH + " was set");
+ }
+
+ private static void log(String message, Object... args) {
+ System.out.println("[" + EmbeddedLauncher.class.getSimpleName() + "] " + String.f... | [EmbeddedLauncher->[toFileURL->[equalsIgnoreCase,newOutputStream,write,deleteOnExit,toURL,openStream,createTempFile,read,toPath,createDirectories],main->[getValue,methodType,toArray,equals,InvocationTargetException,openStream,findStatic,getClassLoader,nextElement,getResource,getResources,loadClass,invoke,hasMoreElement... | This method is the main method of the embedded launcher. This method extracts the contents of a jar file into a file. This method is called when the process exits. | Why one `equals` and one `contentEquals`? |
@@ -101,6 +101,7 @@ public class MuleArtifactClassLoader extends FineGrainedControlClassLoader imple
@Override
public void dispose() {
+ pathMapping.clear();
try {
createResourceReleaserInstance().release();
} catch (Exception e) {
| [MuleArtifactClassLoader->[findLocalResource->[findLocalResource],createResourceReleaserInstance->[createCustomInstance],dispose->[dispose],toString->[getArtifactId],getLocalResourceLocator->[getLocalResourceLocations]]] | Disposes of the managed resource releaser. | Shouldn't you do a urlClassLoader.close() on each value of the Map? |
@@ -422,7 +422,7 @@ Service_Participant::get_domain_participant_factory(int &argc,
}
}
-#if defined OPENDDS_SAFETY_PROFILE && defined ACE_HAS_ALLOC_HOOKS
+#if OPENDD_POOL_ALLOCATOR
// For non-FACE tests, configure pool
configure_pool();
#endif
| [No CFG could be retrieved] | This function loads the configuration of the given object and returns the object. Initializes the given object. | typo here and below |
@@ -108,6 +108,12 @@ public class Bootstrap extends Main {
if (!properties.containsKey(Server.JGROUPS_BIND_PORT)) {
properties.setProperty(Server.JGROUPS_BIND_PORT, Integer.toString(Server.DEFAULT_JGROUPS_BIND_PORT + offset));
}
+ if (!properties.containsKey(Server.J... | [Bootstrap->[logJVMInformation->[getArguments,getPid,getProperty,getLogger,getInstance,info,getClassLoader,isLoggable,fine,getURLs],help->[serverHelpNodeName,serverHelpClusterAddress,serverHelpPortOffset,serverHelpLoggingConfig,serverHelpClusterStack,serverHelpBindAddress,serverHelpBindPort,toolHelpVersion,serverHelpPr... | Handles the command line arguments. Checks if the next parameter is a . | (I need to test this) if I understand correctly, if the user sets `-Djgroups.fd.port=xxxx` & `--offset=xxxx`, the `jgroups.fd.port` is ignored. is that the intention? |
@@ -557,7 +557,7 @@ public abstract class PluginManager extends AbstractModelObject implements OnMas
});
// All plugins are loaded. Now we can figure out who depends on who.
- requires(PLUGINS_PREPARED).attains(COMPLETED).add("Resolving Dependant Plugins Graph", new Executable() {... | [PluginManager->[createDefault->[create],doPlugins->[getDisplayName],install->[install,getPlugin],dynamicLoad->[run,dynamicLoad],getPlugin->[getPlugin,getPlugins],PluginUpdateMonitor->[ifPluginOlderThenReport->[getPlugin]],addDependencies->[addDependencies],loadDetachedPlugins->[loadPluginsFromWar],getPluginVersion->[g... | Initializes tasks based on the given init strategy. Checks if a cycle is detected. This method is called by the task manager to load the plugin and its dependencies. This method is called when a plugin is not loaded. | IIUC the real issue here is that there is no hard requirement between PLUGINS_STARTED and EXTENSIONS_AUGMENTED. I would argue that this should be `requires(PLUGINS_STARTED).attains(EXTENSIONS_AUGMENTED)` and leave `JOB_LOADED` to attain `COMPLETED` |
@@ -95,13 +95,14 @@ class BatchTuner(Tuner):
def import_data(self, data):
"""Import additional data for tuning
+
Parameters
----------
data:
a list of dictionarys, each of which has at least two keys, 'parameter' and 'value'
"""
- if len(self.value... | [BatchTuner->[is_valid->[isinstance,RuntimeError,len],generate_parameters->[NoMoreTrialError,len],import_data->[info,remove,len],update_search_space->[is_valid]],getLogger] | Import additional data for batch tuning. | The space after `LOGGER` |
@@ -796,8 +796,12 @@ static void ThisAgentInit(void)
*/
snprintf(filename, CF_BUFSIZE, "%s/cfagent.%s.log", GetLogDir(), VSYSNAME.nodename);
+ ToLowerStrInplace(filename);
MapName(filename);
+ const mode_t current_umask = umask(0777); // Gets and changes umask
+ umask(current_umask); // Restore... | [No CFG could be retrieved] | Keep all the control - promise related agents in the system. Parse the lval in the control body. | I don't quite understand what these `ToLower` calls are doing in this commit which is supposed to just make sure the permissions are correct. And shouldn't this be done in `MapName()` if we need it? |
@@ -40,7 +40,8 @@ class Podcast < ApplicationRecord
private
def unique_slug_including_users_and_orgs
- errors.add(:slug, "is taken.") if User.find_by(username: slug) || Organization.find_by(slug: slug) || Page.find_by(slug: slug)
+ slug_exists = User.exists?(username: slug) || Organization.exists?(slug: s... | [Podcast->[admins->[with_role],unique_slug_including_users_and_orgs->[add,find_by],existing_episode->[first,presence,unique_website_url?],bust_cache->[perform_later],all,alias_attribute,published,after_save,validate,scope,validates,where,has_many,select,mount_uploader]] | unique_slug_including_users_and_orgs checks if slug is unique. | here I replaced find_by which loads the entire object in memory, with exists? which only returns a boolean |
@@ -1098,8 +1098,10 @@ class Jetpack {
* Loads the currently active modules.
*/
public static function load_modules() {
- if( !self::is_active() && !self::is_development_mode() ) {
- return;
+ if ( ! self::is_active() && !self::is_development_mode() ) {
+ if ( ! is_multisite() || ! get_site_option( 'jetpa... | [Jetpack->[admin_notices->[opt_in_jetpack_manage_notice,can_display_jetpack_manage_notice],admin_page_load->[disconnect,unlink_user,can_display_jetpack_manage_notice],dashboard_widget_connect_to_wpcom->[build_connect_url],check_identity_crisis->[get_cloud_site_options],register->[generate_secrets,stat,validate_remote_r... | Load all modules Load all module - specific code that is needed even when a module is active even when it. | What is going to happen when this function is called on single sites? |
@@ -267,9 +267,13 @@ def _plot_ica_sources_evoked(evoked, picks, exclude, title, show, labels=None):
for exc_label, ii in zip(exclude_labels, picks):
if exc_label is not None:
- if labels is not None:
- exc_label = exc_label.split(' - ')[1]
- color = label_colors[exc... | [_plot_sources_epochs->[list,_transform_epochs,show,append,get_data,create_info,repeat,_handle_default,min,partial,len,_update_epoch_data,RuntimeError,concatenate,_prepare_mne_browse_epochs,range,pick_types,params],_plot_ica_grid->[get_xticklabels,text,max,partial,vars,enumerate,set_ylim,show,min,_prepare_trellis,plot,... | Plots average over epochs in ICA space. Plots a single on the axes. Plots a single critical node. | So we don't need the `labels is not None` check anymore, right? It looks like we don't based on how it's constructed above, just want to double-check. |
@@ -455,4 +455,9 @@ public class HttpMuleMessageFactory extends AbstractMuleMessageFactory
{
exchangePattern = mep;
}
+
+ protected boolean isHttpMultipartRequest (HttpRequest httpRequest)
+ {
+ return httpRequest.getContentType().contains("multipart/form-data");
+ }
}
| [HttpMuleMessageFactory->[extractPayloadFromHttpMethod->[getResponseBodyAsStream,ReleasingInputStream],getEncoding->[getValue,Header,getElements,getParameterByName,get,toString],extractPayload->[extractPayloadFromHttpRequest,getClass,extractPayloadFromHttpMethod,MessageTypeNotSupportedException],putCookieHeaderInMapAsA... | Sets the message exchange pattern. | Are you sure only form-data applies here? What about mixed? |
@@ -47,7 +47,8 @@ export class HiddenObserver {
/** @const {!Document|!ShadowRoot} */
this.root_ = opt_root || ampdoc.getRootNode();
- const doc = opt_root ? opt_root.ownerDocument : this.root_;
+ const doc = opt_root ? opt_root.ownerDocument :
+ (this.root_.ownerDocument || this.root_);
/... | [No CFG could be retrieved] | Provides a hidden - observer that can be used to observe a single hidden - observer on a Observer s handler. | Oh, it looks like opt_root can be of type `ShadowRoot`, so a similar fix should be applied here as well. |
@@ -18,7 +18,7 @@ def h2oget_timezone():
timezones = h2o.list_timezones()
assert_is_type(timezones, H2OFrame)
- assert timezones.nrow==460, "h2o.get_timezone() returns frame with wrong row number."
+ assert timezones.nrow==468, "h2o.get_timezone() returns frame with wrong row number."
assert time... | [h2oget_timezone->[print,get_timezone,list_timezones,assert_is_type,format],standalone_test,insert,h2oget_timezone] | H2O specific function to check if timezone is in the current time zone. | Ehh, how the change affects this test? |
@@ -52,6 +52,10 @@ import org.infinispan.util.CoreImmutables;
import org.infinispan.util.concurrent.CompletionStages;
import org.infinispan.util.concurrent.WithinThreadExecutor;
+import com.github.benmanes.caffeine.cache.CacheWriter;
+import com.github.benmanes.caffeine.cache.Caffeine;
+import com.github.benmanes.c... | [AbstractInternalDataContainer->[applyListener->[delete->[delete],write->[write]],compute->[getSegmentForKey,getMapForSegment,compute],ValueIterator->[hasNext->[hasNext]],keySet->[size->[size],contains->[containsKey],spliterator->[spliterator]],peek->[get,getSegmentForKey,getMapForSegment,peek],DefaultEvictionListener-... | This class is used to provide a specific internal data container. It is used to provide a ComponentRef for passivator and passivator configuration. | Are we ordering `com` imports after `org` imports now? |
@@ -28,6 +28,13 @@ class IdvController < ApplicationController
private
+ def sp_below_quota_limit?
+ return true unless Db::ServiceProviderQuotaLimit::IsSpOverQuota.call(sp_session[:issuer].to_s)
+ flash[:error] = t('errors.doc_auth.quota_reached')
+ redirect_to account_url
+ false
+ end
+
def v... | [IdvController->[fail->[redirect_to,idv_attempter_throttled?],proof_with_cac?->[cac_proofing_enabled,call,any?],profile_needs_reactivation?->[redirect_to,started?],active_profile?->[present?],index->[redirect_to,active_profile?,idv_attempter_throttled?],verify_identity->[track_event,redirect_to,proof_with_cac?],activat... | check if the user is logged in and if so redirect to the cac or doc auth. | Can we call this something else? Or split it up? I don't expect predicate methods to have side effects like redirecting like this |
@@ -596,6 +596,10 @@ EVENTS: Dict[int, Dict[str, Union[Alert, Callable[[Any, messaging.SubMaster, boo
ET.NO_ENTRY: NoEntryAlert("Gear not D"),
},
+ # This alert is thrown when the calibration angles are outside of the acceptable range.
+ # For example if the device is pointed too much to the left or the rig... | [wrong_car_mode_alert->[NoEntryAlert],calibration_incomplete_alert->[Alert],no_gps_alert->[Alert],startup_fuzzy_fingerprint_alert->[Alert],below_steer_speed_alert->[Alert],NormalPermanentAlert,NoEntryAlert,EngagementAlert,ImmediateDisableAlert,SoftDisableAlert,Alert] | The functions below are defined in the Alert class. The list of all alert objects in the system. | You can point to comma.ai/setup for a proper mounting tutorial here |
@@ -238,7 +238,8 @@ func (r *Runtime) setupRootlessNetNS(ctr *Container) (err error) {
continue
}
if status.Exited() {
- return errors.New("slirp4netns failed")
+ slurp, _ := ioutil.ReadAll(stderr)
+ return errors.Errorf("slirp4netns failed: %s", slurp)
}
if status.Signaled() {
... | [setupNetNS->[configureNetNS],createNetNS->[configureNetNS],configureNetNS->[getPodNetwork],teardownNetNS->[getPodNetwork]] | setupRootlessNetNS configures the rootless network namespace for the container specify the FD to write to when the initialization steps are finished This is a long lived function that is used to read from the sync pipe and check This function is called when slirp4netns exits This function is used to write the data to t... | No reader during running? Writer may block. |
@@ -1599,7 +1599,8 @@ static BOOL FDblToRgbPrecise(double dbl, __out_ecount(kcbMaxRgb) byte *prgb, int
// Do not always push to higherBound
// See Js::NumberUtilities::FDblToStr for the exception
// i.e. we shouldn't push digits beyond interest to higherBound
- ... | [No CFG could be retrieved] | - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -. | This is unrelated to the other changes but the compile time warning this fixes was really annoying me. |
@@ -84,10 +84,10 @@ func (c APIClient) ExtractPipeline(pipelineName string) (*pps.CreatePipelineRequ
if err != nil {
return nil, grpcutil.ScrubGRPC(err)
}
- if op.Op1_11 == nil || op.Op1_11.Pipeline == nil {
+ if op.Op1_12 == nil || op.Op1_12.Pipeline == nil {
return nil, errors.Errorf("malformed response is ... | [ExtractURL->[Extract],ExtractAll->[Extract],RestoreFrom->[Restore,Extract],Extract->[Extract],ExtractPipeline->[ExtractPipeline],RestoreReader->[Restore],ExtractWriter->[Extract],RestoreURL->[Restore],Restore->[Restore],InspectCluster->[InspectCluster]] | ExtractPipeline extracts a pipeline from the cluster and restores it. | This is probably a question for Nitin, but when we change the version of proto that we extract, should we change the version in src/client/version/client.go at the same time? |
@@ -403,6 +403,8 @@ public class RegisterMinionEventMessageAction implements MessageAction {
return;
}
+ MinionList minionTarget = new MinionList(minionId);
+ systemQuery.syncAll(minionTarget);
RegistrationUtils.finishRegistration(minion, activationKey,... | [RegisterMinionEventMessageAction->[registerMinion->[registerMinion],getContactMethod->[getContactMethod],migrateOrCreateSystem->[extractHwAddresses],getOsRelease->[unknownRHELVersion],findMatchingEmptyProfiles->[findMatchingEmptyProfiles]]] | Finalize a minion registration. This method is called when a minion is not available in the minion configuration. It is called key properties - check if saltboot has been called before. | Isn't this doing a synchronous Salt call reaching out to that minion? Someone who is an expert on the registration code and it's scalability should probably approve this at least, I remember that previously we tried to avoid doing synchronous calls to Salt during the registration as there is a risk of blocking a thread... |
@@ -541,7 +541,12 @@ def create_parser(plugins, args):
_create_subparsers(helpful)
- return helpful.parser
+ return helpful.parser, helpful.args
+
+# For now unfortunately this constant just needs to match the code below;
+# there isn't an elegant way to autogenerate it in time.
+VERBS = ["run", "auth", ... | [_plugins_parsing->[add,add_group,add_plugin_args],_create_subparsers->[add_subparser,add_argument,flag_default],auth->[_init_le_client,_find_domains],HelpfulArgumentParser->[add_plugin_args->[add_group],add->[add_argument],__init__->[SilentParser,flag_default]],SilentParser->[add_argument->[add_argument]],install->[_i... | Create a parser for the given options. Add command line options to the command line. Adds a sub - parsers to run the command line interface. Initialize plugins and prepare plugins. | - please don't use the the backslash; this should've been caught by the pylint... - how come you're not able to autogenerate it? just go through the registered subparsers... |
@@ -188,6 +188,8 @@ def process_options(args: List[str],
help="dump type inference stats")
parser.add_argument('--custom-typing', metavar='MODULE', dest='custom_typing_module',
help="use a custom typing module")
+ parser.add_argument('--custom-typeshed-dir', met... | [expand_dir->[expand_dir],process_options->[SplitNamespace]] | Parse command line arguments and return a tuple of build sources and options. Adds command line options to the given parser. Argument parser for typecheck Adds a group of arguments to the command line that will be used to type check a specific why. | I think Jukka had suggested to change this to "custom typeshed _package_ in DIR" ? |
@@ -912,3 +912,14 @@ export function toggleAttribute(element, name, forced) {
return enabled;
}
+
+/**
+ * @param {!Window} win
+ * @return {number} The width of the vertical scrollbar, in pixels.
+ */
+export function getVerticalScrollbarWidth(win) {
+ const {documentElement} = win.document;
+ const windowWidt... | [No CFG could be retrieved] | Is this enabled?. | Does this work cross browser? |
@@ -3,7 +3,7 @@
a hrefs for them.
**/
var urlReplacerArgs = {
- matcher: /^((?:https?:(?:\/{1,3}|[a-z0-9%])|www\d{0,3}[.])(?:[^\s()<>]+|\([^\s()<>]+\))+(?:\([^\s()<>]+\)|[^`!()\[\]{};:'".,<>?«»“”‘’\s]))/gm,
+ matcher: /^((?:https?|(?:\/{1,3}|[a-z0-9%])|www\d{0,3}[.])(?:[^\s()<>]+|\([^\s()<>]+\))+(?:\([^\s()<>]+\... | [No CFG could be retrieved] | Adds a link to a a. | this does not look right to me, the regex semantics heavily changed (and probably incorrectly) here. |
@@ -536,7 +536,7 @@ const nameCache = {};
const mangleIdentifier = {
get(num) {
const charset =
- '$ABCDEFGHIJKLMNOPQRSTUVWXYZ_abcdefghijklmnopqrstuvwxyz0123456789';
+ 'abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ$_0123456789';
let base = 54;
let id = '';
do {
| [No CFG could be retrieved] | Provides a function to mangle a given identifier in a bundle. Terser options for the command. | Later I'd like to verify that we still need this (only b/c I had seen removing it save ~0.5kb) |
@@ -61,6 +61,8 @@ func DefaultConfigRequest() *ConfigRequest {
c.V1.Sys.Ngx.Http.LargeClientHeaderBuffersSize = w.String("8k")
c.V1.Sys.Ngx.Http.Sendfile = w.String("on")
c.V1.Sys.Ngx.Http.SslCiphers = w.String(config.ExternalCipherSuite)
+ c.V1.Sys.Ngx.Http.SslClientCertificateFilename = w.String("root_ca.crt")
... | [SetGlobalConfig->[GetLog,GetV1,GetValue,GetLevel,GetFrontendTls,GlobalLogLevelToNginxLevel],Validate->[AddInvalidValue,GetLog,GetSys,Error,IsEmpty,AddMissingKey,NewInvalidConfigError,GetV1,GetValue,GetLevel,ValidateNginxLogLevel],Listen,Warn,Do,Close,String,Int32,Bool] | Configures the Ngx Events properties. NewNginxConfig creates a new instance of ConfigRequest_V1_System_N. | I wonder, while we are here, do we want to change this default to off? Turning it off will make us compatible with libressl by default and I doubt many people are using client certs at the lb. |
@@ -19,7 +19,7 @@ const (
tenantID = "19590a3f-b1af-4e6b-8f63-f917cbf40711"
resourceGroup = "TestResourceGroup"
computeAPIVersion = "2019-07-01"
- diskAPIVersion = "2019-07-01"
+ diskAPIVersion ... | [RegisterDeleteManagedDisk->[Header,Fprintf,Add,Sprintf,Get,HandleFunc,WriteHeader,Query],RegisterVirtualMachineEndpoint->[Header,Add,Sprintf,Fprint,Get,HandleFunc,WriteHeader,Query],RegisterEnsureDefaultLogAnalyticsWorkspaceCreateNew->[Sprintf,Fprint,Get,HandleFunc,WriteHeader,Query],RegisterGetAvailabilitySetFaultDom... | Creates a new object with all the required properties. This function is used to provide a set of options for the NIC. | Is this related to the compute API bump? |
@@ -450,7 +450,8 @@ export class FixedLayer {
// We shouldn't have too many of `fixed` elements.
break;
}
- this.setupElement_(elements[j], fixedSelector, 'fixed');
+ const el = elements[j];
+ this.setupElement_(el, fixedSelector, 'fixed');
}
}
for (l... | [No CFG could be retrieved] | Setups the critical functions for the elements that match the given selectors. Checks if an element has an element with the given selector and position. | Nit, unnecessary assignments. |
@@ -729,6 +729,13 @@ define([
var i = (billboard._index * 4);
var position = billboard._getActualPosition();
+ if (this._mode === SceneMode.SCENE3D) {
+ var radius = position.subtract(this._baseVolume.center).magnitude();
+ if (radius > this._baseVolume.radius) {
+ ... | [No CFG could be retrieved] | The collection of all Billboards. Write eye offset and scale to the vaf writer. | Perhaps the bounding volume classes should have an expand function to include a point. Here, we are assuming the bounding volume is a sphere, i.e., it has a radius, perhaps we can abstract that away. |
@@ -30,12 +30,14 @@ namespace Microsoft.NET.HostModel.AppHost
/// <param name="appBinaryFilePath">Full path to app binary or relative path to the result apphost file</param>
/// <param name="windowsGraphicalUserInterface">Specify whether to set the subsystem to GUI. Only valid for PE apphosts.</param>... | [HostWriter->[IsBundle->[RetryOnIOError,SearchInFile,CreateFromFile,ReadInt64,CreateViewAccessor],CreateAppHost->[RetryOnWin32Error,Delete,SearchAndReplace,CreateViewAccessor,IsOSPlatform,Windows,GetBytes,CreateFromFile,IsSupportedOS,Create,ToInt32,None,RetryOnIOError,RewriteAppHost,WriteToStream,Read,GetLastWin32Error... | Create an app host with the given parameters. This method writes the data from the source apphost file to the destination file. | Is there a particular reason we want to provide an opt-out? |
@@ -103,9 +103,9 @@ public interface CacheQuery extends Iterable<Object> {
* If the projected field is not a projectable field, null is returned in the object[]
*
* @param fields the projected field names
- * @return {@code this} to allow for method chaining
+ * @return {@code this} to allow for m... | [No CFG could be retrieved] | Cache the query for a projection. | This is the only thing that may break compatibility, but I prefer this version with `Object[]` |
@@ -399,4 +399,4 @@ if ( ! function_exists('nbs'))
}
/* End of file html_helper.php */
-/* Location: ./system/helpers/html_helper.php */
\ No newline at end of file
+/* Location: ./system/helpers/html_helper.php */
| [link_tag->[site_url,slash_item],img->[site_url,slash_item]] | Efficiently find the link to the HTML page. | Again per the style guide, remove the empty line here (you can do this via the github editor, you have to edit locally). |
@@ -66,11 +66,6 @@ export class MraidInitializer {
/** @private {boolean} */
this.fallback_ = false;
- if (getMode().runtime !== 'inabox') {
- dev().error(TAG, 'Only supported with Inabox');
- return;
- }
-
const ampMraidScripts = this.ampdoc_.getHeadNode().querySelectorAll(
's... | [No CFG could be retrieved] | Constructs a class that can be used to initialize a specific . Runs when MRAID reports that it is ready. | Also @jeffkaufman I'm not sure if we will be able to get mraid script within AMP page. And why do we still need the check given that we check it in validator. |
@@ -460,9 +460,9 @@ export class AmpStory extends AMP.BaseElement {
);
});
}
- if (isExperimentOn(this.win, 'amp-story-load-first-page-only')) {
+ if (isExperimentOn(this.win, 'story-load-first-page-only')) {
Services.performanceFor(this.win).addEnabledExperiment(
- 'amp-story-l... | [No CFG could be retrieved] | Removes an attribute from the element and adds it to the DOM. get - Get the current page state. | Nit: This appears a bit strange, why does `amp-story` read for the value of an experiment followed by only setting the same value for elsewhere? |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.