patch stringlengths 18 160k | callgraph stringlengths 4 179k | summary stringlengths 4 947 | msg stringlengths 6 3.42k |
|---|---|---|---|
@@ -83,7 +83,14 @@ func (host *pluginHost) Provider(pkg tokens.Package, version *semver.Version) (p
return nil, nil
}
- prov, err := best.load()
+ load := best.load
+ if load == nil {
+ load = func() (plugin.Provider, error) {
+ return best.loadWithHost(host)
+ }
+ }
+
+ prov, err := load()
if err != nil {... | [CloseProvider->[Lock,Unlock],Provider->[Unlock,LT,Lock,load,GT],SignalCancellation->[SignalCancellation,Lock,Unlock],Analyzer->[New],Log->[Logf,StreamMessage],LogStatus->[Logf,StreamMessage]] | Provider returns a plugin. Provider that can be used to load a plugin from the specified package. | This code exists only because `NewProviderLoaderWithHost` now exists, and in that case load is nil, right? |
@@ -56,12 +56,14 @@
#define TREE_FMT(name, type, feats) \
" " #name ":\n" \
-" node_size: %d\n" \
+" node_size: %d\n" \
" record_msize: %d\n" \
+" single_size: %d\n" \
" order: %d\n"
-#define TREE_PRINT(name, type, feats) \
- name.to_node_size, name.to_record_msize, name.to_order,... | [No CFG could be retrieved] | Creates a summary of the node sizes that can be used by VOS. \ Function to print a list of node - level attributes. | (style) Macros with complex values should be enclosed in parentheses |
@@ -101,6 +101,7 @@ class Python(AutotoolsPackage):
variant('ctypes', default=True, description='Build ctypes module')
variant('tkinter', default=False, description='Build tkinter module')
variant('uuid', default=False, description='Build uuid module')
+ variant('tix', default=False, desc... | [Python->[home->[get_config_var],deactivate->[write_easy_install_pth,python_ignore],libs->[get_config_var],setup_dependent_package->[_load_distutil_vars],headers->[get_config_h_filename,get_config_var],get_config_var->[command,print_string],activate->[write_easy_install_pth,python_ignore],get_config_h_filename->[comman... | Create a new package with a single dependency that can be built. Find all packages that require RPATH. | I would say "Build tix module" |
@@ -32,11 +32,7 @@ public class JButtonBuilder {
this.title = title;
}
- private JButtonBuilder() {}
-
- public static JButtonBuilder builder() {
- return new JButtonBuilder();
- }
+ public JButtonBuilder() {}
/**
* Constructs a Swing JButton using current builder values. Values that must be s... | [JButtonBuilder->[cancelTitle->[title],builder->[JButtonBuilder],actionListener->[actionListener],biggerFont->[biggerFont],okTitle->[title]]] | Create a builder for a JButton. | Unless there's another constructor in this class having a no-op public constructor is redundant |
@@ -373,11 +373,6 @@ var _ = g.Describe("[Feature:Builds][Serial][Slow][Disruptive] alter builds via
o.Expect(err).NotTo(o.HaveOccurred())
checkOCMProgressing(operatorv1.ConditionTrue)
checkOCMProgressing(operatorv1.ConditionFalse)
- checkDSRolloutState(true)
- checkDSRolloutState(false)
- // th... | [Context,CurrentGinkgoTestDescription,KubeClient,By,AppsV1,CoreV1,Expect,JustAfterEach,HaveOccurred,StartBuildAndWait,AdminOperatorClient,FixturePath,BeTrue,DeprecatedInstallWithoutGroup,It,AdminConfigClient,OpenShiftControllerManagers,DumpConfigMapStates,Error,WaitForServiceAccount,Args,AsAdmin,DumpPodLogsStartingWith... | checkDSRolloutState checks the coverage of the build pod StartBuildAndWait starts a build and waits for it to finish. | Do not need to check for leader election - by the time rollout is complete all pods should be running and a leader should be set. |
@@ -185,6 +185,11 @@ public class ComponentAstBasedMetadataCacheIdGenerator implements MetadataCacheI
.orElse(format("(%s):(%s)", getSourceElementName(component), "Unknown Type"))));
}
+ private Optional<MetadataCacheId> resolveDslTagNamespace(ComponentAst elementModel) {
+ ... | [ComponentAstBasedMetadataCacheIdGenerator->[getIdForComponentMetadata->[doResolve],resolveCategoryId->[map],getIdForComponentOutputMetadata->[flatMap,doResolveType,OutputMetadataResolutionTypeInformation],doResolveType->[of,MetadataCacheId,getSourceElementName,getComponentTypeMetadataCacheId,isDynamicType,resolveDslTa... | Resolves a type. | I think the identifier can be null, we should consider that |
@@ -48,7 +48,8 @@ Rails.application.routes.draw do
remote_token http_origin session_hijacking] } })
mount flipper_ui, at: "feature_flags"
- resources :data_update_scripts, only: [:index]
+ resources :data_update_scripts, only... | [new,authenticate,authenticated,redirect,devise_scope,mount,put,draw,freeze,resources,member,root,use,scope,constraints,post,set,controllers,require,secrets,class_eval,use_doorkeeper,resource,url,patch,devise_for,each,production?,enabled?,delete,namespace,collection,get,session_options,tech_admin?,app] | The main entry point for the Sidekiq API. citize all the messages and invitations in a sequence of objects. | We add a show route that we poll for an updated status once the job is run |
@@ -35,6 +35,11 @@ module.exports = {
}],
]);
}
- return defaultPlugins;
+ if (isCommonJsModule) {
+ pluginsToApply = pluginsToApply.concat([
+ [require.resolve('babel-plugin-transform-commonjs-es2015-modules')],
+ ]);
+ }
+ return pluginsToApply;
},
};
| [No CFG could be retrieved] | returns a list of plugins that can be run on the object. | Do we have an open issue for removing this transform when possible? We should migrate over all these dependencies to ESM. |
@@ -985,6 +985,11 @@ func TestIntegration_FluxMonitor_NewRound(t *testing.T) {
require.NoError(t, err)
job.Initiators[0].InitiatorParams.Feeds = cltest.JSONFromString(t, fmt.Sprintf(`["%s"]`, mockServer.URL))
job.Initiators[0].InitiatorParams.PollingInterval = models.MustMakeDuration(15 * time.Second)
+ // NOTE: ... | [CreateExternalInitiatorViaWeb,NewAddress,HandlerFunc,WaitForRuns,JobRunStays,NewTask,MinimumContractPayment,MustReadFile,CreateJobSpecViaWeb,FindExternalInitiator,AddDate,WaitForJobRunToPendConfirmations,UTC,HexToHash,Len,MakeRoundStateReturnData,Bool,NewApplicationWithConfig,NewRunLog,GetStore,MustHash,Parallel,NoErr... | requires that the server respond with 100 for price on initialization and not enough for deviation. eth_sendRawTransaction registers the transaction functions and registers the functions to be called when the. | Can we change this hardcoded time instead? |
@@ -480,6 +480,7 @@ public class Notebook implements NoteEventListener {
if (p.getDateFinished() != null && lastUpdatedDate.before(p.getDateFinished())) {
lastUpdatedDate = p.getDateFinished();
}
+ p.clearRuntimeInfo();
}
Map<String, List<AngularObject>> savedObjects = note.getAn... | [Notebook->[setNoteRevision->[setNoteRevision],renameFolder->[renameFolder],loadAllNotes->[loadNoteFromRepo],close->[close],getJobListByUnixTime->[getUnixTimeLastRunParagraph,reloadAllNotes,getParagraphForJobManagerItem,getAllNotes],onParagraphCreate->[onParagraphCreate],hasFolder->[hasFolder],removeNote->[removeNote],... | Load a note from the notebook repository. add the angularObject to the interpreter group. | Why we need to clear RuntimeInfo when we load note if the runtimeInfo is not stored ? |
@@ -912,4 +912,18 @@ public class ConfigurationKeys {
public static final String GIT_CONFIG_MONITOR_BRANCH_NAME = GIT_CONFIG_MONITOR_PREFIX + "branchName";
public static final String DEFAULT_GIT_CONFIG_MONITOR_BRANCH_NAME = "master";
public static final int DEFAULT_GIT_CONFIG_MONITOR_POLLING_INTERVAL = 60;
+
+... | [ConfigurationKeys->[name,toString,toMillis]] | Default branch name and polling interval. | This set of keys is a copy of the ones above. Can you refactor the logic to share the keys with the defaults encapsulated in the implementations? This allows more of the initialization code to be shared. |
@@ -1123,14 +1123,10 @@ public class TestHoodieMergeOnReadTable extends HoodieClientTestHarness {
HoodieCommitMetadata metadata = HoodieCommitMetadata.fromBytes(
table.getActiveTimeline().getInstantDetails(table.getActiveTimeline().getDeltaCommitTimeline().lastInstant().get()).get(),
Hoodie... | [TestHoodieMergeOnReadTable->[testSimpleInsertsGeneratedIntoLogFiles->[init],testRollingStatsInMetadata->[init],updateAndGetFilePaths->[assertNoWriteErrors],insertAndGetFilePaths->[assertNoWriteErrors],testRollingStatsWithSmallFileHandling->[init],testSimpleInsertAndUpdate->[init],testCOWToMORConvertedTableRollback->[i... | Test rolling stats in metadata. Read from rolling stat metadata and write records. This method checks that the rolling stat metadata is valid. | Also rename this test in the same way. |
@@ -529,7 +529,7 @@ namespace DotNetNuke.Services.Upgrade.Internals
public bool IsSqlServerDbo()
{
string dbo = DataProvider.Instance().Settings["databaseOwner"];
- if (dbo.Trim().ToLower() != "dbo.")
+ if (dbo.Trim().ToLowerInvariant() != "dbo.")
{
... | [InstallControllerImpl->[TestDatabaseConnection->[TestDatabaseConnection]]] | Checks if the current database is a SQL Server Dbo. | Please use `String#Equals(String, StringComparison)` |
@@ -99,10 +99,10 @@ public class WebappMuleXmlConfigurationBuilder extends SpringXmlConfigurationBui
}
@Override
- protected ApplicationContext doCreateApplicationContext(MuleContext muleContext, ConfigResource[] artifactConfigResources, OptionalObjectsController optionalObjectsController)
+ protected... | [WebappMuleXmlConfigurationBuilder->[doConfigure->[doConfigure]]] | create application context. | shouldn't you use the artifact configuration passed on the argument? |
@@ -32,8 +32,11 @@ public class UndertowStaticResourcesBuildStep {
protected static final String META_INF_RESOURCES = "META-INF/resources";
@BuildStep
- void handleGeneratedWebResources(BuildProducer<GeneratedResourceBuildItem> generatedResources,
+ void handleGeneratedWebResources(Capabilities capabi... | [UndertowStaticResourcesBuildStep->[scanStaticResources->[getName,getChildPath,charAt,getLaunchMode,add,getAllApplicationArchives,produce,KnownPathsBuildItem,substring,isEmpty,exists,length,startsWith,collectKnownPaths,consumeAsPaths,emptySet],handleGeneratedWebResources->[GeneratedResourceBuildItem,produce,getName,get... | handleGeneratedWebResources - handle generated web resources. | I wonder if we should add an annotation at the class level instead of having conditions in every build step. @stuartwdouglas do you think that would be worth it? |
@@ -110,10 +110,13 @@ def read(path, repo=None, rev=None, remote=None, mode="r", encoding=None):
@contextmanager
def _make_repo(repo_url, rev=None):
if rev is None and (not repo_url or os.path.exists(repo_url)):
- yield Repo(repo_url)
- else:
- with external_repo(url=repo_url, rev=rev) as repo:
... | [_get_object_spec->[SummonError,read],prepare_summon->[SummonError,_make_repo],_require_dvc->[UrlNotDvcRepoError],summon->[SummonError],read->[read,open]] | Create a repository and return a sequence of objects. | This will fails if `repo_url` is `None`, which means cur dir really. |
@@ -40,6 +40,7 @@ import numbers as _numbers
import numpy as _np
import six as _six
+from tensorflow.python.framework import tensor_shape
from tensorflow.python.util.all_util import remove_undocumented
| [as_text->[decode,TypeError,isinstance],as_str_any->[str,as_str,isinstance],as_bytes->[encode,TypeError,isinstance],remove_undocumented] | Converts either bytes or unicode to bytes using utf - 8 encoding for text. | I don't like this dependency. util should be small utilities which do not depend on any of the concrete tensorflow stuff. I think the other fix is better. |
@@ -863,6 +863,11 @@ namespace System.Runtime.Serialization
return enumerator;
}
+ [UnconditionalSuppressMessage("ReflectionAnalysis", "IL2060:MakeGenericMethod",
+ Justification = "The call to MakeGenericMethod is safe due to the fact that CollectionDataContrac... | [CollectionDataContract->[IsCollection->[IsCollection],IncrementCollectionCount->[IncrementCollectionCount],GetCollectionMethods->[GetTargetMethodWithName,FindCollectionMethodsOnInterface],IsCollectionOrTryCreate->[IsArraySegment,IsCollection],GenericDictionaryEnumerator->[MoveNext->[MoveNext],Reset->[Reset]],Dictionar... | Get the enumerator for a collection. get the element type of the enumerator. | `BuildCreateGenericDictionaryEnumerato` we missing an `r`? #Resolved |
@@ -2573,7 +2573,7 @@ void MarlinSettings::reset() {
//
// TOUCH_SCREEN_CALIBRATION
//
- TERN_(TOUCH_SCREEN_CALIBRATION, touch_calibration.calibration_reset());
+ TERN_(TOUCH_SCREEN_CALIBRATION, touch_calibration.calibration_smart_reset());
//
// Buzzer enable/disable
| [No CFG could be retrieved] | Toolchange settings for a single node. - - - - - - - - - - - - - - - - - -. | We don't need all this crazy logic. This is already solved in COLOR_UI. We just need to port the same logic to the other UIs: if you hold screen for `TOUCH_SCREEN_HOLD_TO_CALIBRATE_MS` (2.5s) on status screen, it will open touch calibration screen even if we have bad calibration values. |
@@ -2745,6 +2745,7 @@ define([
Cartesian3.clone(camera.up, result.up);
Cartesian3.clone(camera.right, result.right);
Matrix4.clone(camera._transform, result.transform);
+ camera.frustum.clone(result.frustum);
return result;
};
| [No CFG could be retrieved] | Creates a clone of the camera object. | You should check what type of frustum the result has. By default, the camera creates a `PerspectiveFrustum`, but it could be an `OrthographicFrustum`. In practice, it'll never be a `PerspectiveOffCenterFrustum`, but that's on the road map. |
@@ -438,6 +438,17 @@ class Trilinos(CMakePackage):
define('MPI_BASE_DIR', spec['mpi'].prefix),
])
+ # Cuda settings
+ options.append(define_tpl_enable('CUDA'))
+ if '+cuda' in spec:
+ cxx_flags.extend([
+ '--expt-extended-lambda'
+ ... | [Trilinos->[cmake_args->[define_tpl_enable,define_trilinos_enable]]] | Get CMake arguments for . Define CMAKE_Fortran_COMPILER and CMAKE_MPI_ Add options for Options for all missing node - seq - n - node - seq - n - node - This function is used to add a new block of CMake TPL options to the block options for all n - node chains Add options to the unknown options list. | This is a NVCC flag: does it belong in the cxx_flags, or is that necessary due to the kokkos compiler wrapper? |
@@ -2172,6 +2172,16 @@ class State:
typemap=self.type_map())
manager.report_file(self.tree, self.type_map(), self.options)
+ self.update_fine_grained_deps(self.manager.fg_deps)
+ self.free_state()
+ if not manager.options.fine_grained_incr... | [find_module_simple->[add_stats],process_graph->[add_stats,trace,log],_build->[BuildSourceSet,BuildResult],write_deps_cache->[deps_to_json,getmtime,log],BuildManager->[trace->[verbosity],log_fine_grained->[verbosity,log],all_imported_modules_in_file->[correct_rel_imp,import_priority],report_file->[is_source],getmtime->... | This method is called after all the parsing passes have been processed. | Is there a reason why we can't do `self.tree = None`? Or maybe doing `self.tree.defs.clear()` or something? |
@@ -4371,7 +4371,14 @@ def hsigmoid(input,
and :math:`D` is the feature size.
label (Variable): The tensor variable contains labels of training data.
It's a tensor with shape is :math:`[N \\times 1]`.
- num_classes: (int), The number of classes, must not be less than 2.
+ ... | [ctc_greedy_decoder->[topk],image_resize->[_is_list_or_turple_],sequence_first_step->[sequence_pool],logical_xor->[_logical_op],elementwise_pow->[_elementwise_op],elementwise_min->[_elementwise_op],elementwise_max->[_elementwise_op],logical_not->[_logical_op],conv2d->[_get_default_param_initializer],logical_and->[_logi... | Hierarchical Sigmoid operator. Hierarchical sigmoid layer where the last node in the network is missing. | What happen if num_classes is None. Should doc |
@@ -314,7 +314,12 @@ public abstract class IncrementalIndex<AggregatorType> extends AbstractIndex imp
for (DimensionSchema dimSchema : dimensionsSpec.getDimensions()) {
ValueType type = TYPE_MAP.get(dimSchema.getValueType());
String dimName = dimSchema.getName();
- ColumnCapabilitiesImpl capabil... | [IncrementalIndex->[loadDimensionIterable->[isEmpty],addNewDimension->[size,add],getColumnNames->[getDimensionNames,getMetricNames],MetricDesc->[getName],getMaxTime->[getMaxTimeMillis,isEmpty],getMinTimeMillis->[getMinTimeMillis],PlainFactsHolder->[persistIterable->[iterator],putIfAbsent->[putIfAbsent,add],keySet->[tim... | Initializes the object. Increment a single unique identifier. | Apologies for the conflicts here, I made some semi disruptive changes to push `ColumnCapabilities` into the `DimensionIndexer` implementations so they can be more accurate. I think the changes should still be workable with your addition of `DimensionHandlerProvider`, just the dimension indexer it provides will need to ... |
@@ -232,14 +232,16 @@ namespace System.Drawing.Drawing2D
throw new NullReferenceException();
if (value.Positions == null)
+#pragma warning disable CA2208 // Instantiate argument exceptions correctly
throw new ArgumentNullException("source");
+#pragma warning ... | [LinearGradientBrush->[ScaleTransform->[ScaleTransform],SetSigmaBellShape->[SetSigmaBellShape],MultiplyTransform->[MultiplyTransform],RotateTransform->[RotateTransform],TranslateTransform->[TranslateTransform],SetBlendTriangularShape->[SetBlendTriangularShape]]] | Creates a managed array of blend factors and positions. Copy the values from the n - tuple into the factors and positions arrays. | Why is "source" correct here? |
@@ -176,12 +176,9 @@ public final class FastBootHibernatePersistenceProvider implements PersistencePr
injectRuntimeConfiguration(persistenceUnitName, hibernateOrmRuntimeConfig, runtimeSettingsBuilder);
}
- for (HibernateOrmIntegrationRuntimeInitListener listener : integrationR... | [FastBootHibernatePersistenceProvider->[getEntityManagerFactoryBuilder->[getEntityManagerFactoryBuilder],generateSchema->[generateSchema]]] | Returns an EntityManagerFactoryBuilder based on the given persistence - unit name and properties. Returns a builder that can be used to build a new entity manager based on the given configuration. | We try to avoid lambdas at runtime. |
@@ -220,7 +220,10 @@ func (ctx *Context) Invoke(tok string, args interface{}, result interface{}, opt
options := &invokeOptions{}
for _, o := range opts {
if o != nil {
- o.applyInvokeOption(options)
+ err := o.applyInvokeOptionAfterAwaitingInputs(ctx.ctx, options)
+ if err != nil {
+ return err
+ }
... | [ReadResource->[ReadResource,DryRun],RegisterComponentResource->[RegisterResource],collapseAliases->[Project,Stack],registerResource->[RegisterResource,DryRun,getResource],Invoke->[Invoke,DryRun],resolve->[resolve],RegisterRemoteComponentResource->[registerResource],prepareResourceInputs->[DryRun],RegisterResourceOutpu... | Invoke invokes the action specified by the given arguments and returns the result. Invoke a service call synchronously. Invoke a method with no arguments. | Introducing a new input await here --^ |
@@ -16,7 +16,7 @@ from pants.backend.shell.target_types import ShellSourceField
from pants.core.util_rules.external_tool import DownloadedExternalTool, ExternalToolRequest
from pants.engine.addresses import Address
from pants.engine.collection import DeduplicatedCollection
-from pants.engine.fs import Digest, Digest... | [infer_shell_dependencies->[ParseShellImportsRequest],find_all_shell_targets->[AllShellTargets],parse_shell_imports->[ParsedShellImports],map_shell_files->[ShellMapping]] | Return a single unique object in the shell. A mapping of Shell file names to their owning file address. | Changes to this file aren't strictly coupled and I can revert them if you'd like. But I noticed it while working on this PR |
@@ -367,6 +367,10 @@ public class PlanNodeDecorrelator
return Optional.empty();
}
+ if (node.getGroupingSetCount() != 1) {
+ return Optional.empty();
+ }
+
Optional<DecorrelationResult> childDecorrelationResultOptional = lookup.resolve(no... | [PlanNodeDecorrelator->[DecorrelationResult->[getConstantSymbols->[copyOf,values],getCorrelatedSymbolMapper->[getValue,toImmutableMap,collect,getLast,SymbolMapper],checkState,values,containsAll],decorrelatedNode->[empty,containsCorrelation,of,DecorrelatedNode],DecorrelatedNode->[getCorrelatedPredicates->[empty,and,of,i... | Visit an AggregationNode. This method will return an Optional of the DecorrelationResult if. | Would it be possible to have a test for this? |
@@ -290,7 +290,8 @@ void WbWrenWindow::flipAndScaleDownImageBuffer(const unsigned char *source, unsi
const int w = sourceWidth / scaleDownFactor;
const int yFactor = scaleDownFactor * sourceWidth;
- // - The `unsigned char *` to `int *` cast is possible assuming that a pixel is coded as four bytes (RGBA) align... | [No CFG could be retrieved] | The main function that is called when a window is opened. region mSnapshotBuffer - Snapshot buffer. | The line cut is not nice here... |
@@ -328,8 +328,8 @@ class Database extends BaseValidation
if (empty($schema_update)) {
$validator->ok('Database schema correct');
} else {
- $result = ValidationResult::fail('We have detected that your database schema may be wrong, please report the following to us on Discord (... | [Database->[addIndexSql->[indexToSql],checkSchema->[addIndexSql,setList,ok,dropTableSql,addColumnSql,dropColumnSql,dropConstraintSql,addTableSql,updateTableSql,result,warn,dropIndexSql,updateIndexSql,addConstraintSql,fail],addColumnSql->[columnToSql],checkCollation->[setList,selectOne,result,select,fail],validate->[che... | Checks the schema for missing tables and columns. get sql for updating columns and indexes Checks if there is an extra constraint or table in the current schema and drops them if necessary. | How about add on most distros you can access mysql with `mysql -u root librenms`? |
@@ -184,7 +184,7 @@ func (a *Autodiscover) handleStart(event bus.Event) bool {
continue
}
- a.configs[hash] = &reload.ConfigWithMeta{
+ a.configs[eventID][hash] = &reload.ConfigWithMeta{
Config: config,
Meta: &dynFields,
}
| [Stop->[Info,Stop],handleStop->[Has,CreateConfig,HashConfig,Debug],worker->[handleStop,handleStart,Events,After,Reload,Debug],Start->[EventFilter,worker,Start,Info,Subscribe],handleStart->[Has,Store,Error,Sprintf,CheckConfig,HashConfig,Wrap,CreateConfig,Debug],NewMap,NewRunnerList,New,BuildProvider,Wrap,Err,Debug] | handleStart is called when a new config is detected. | With this refactor the use of a hash here is now confusing. It seems like we're still using `uint64` hashes to be able to work with `RunnerList` for de-duplication. However, I don't see how we'd get duplicates if we're now using a synthetic PK for the config. Maybe `a.configs` should just be a `map[string][]config` and... |
@@ -23,10 +23,14 @@ import java.util.concurrent.TimeUnit;
/**
* A skeletal {@link Future} implementation which represents a {@link Future} which has been completed already.
*/
-public abstract class CompleteFuture<V> extends AbstractFuture<V> {
+public abstract class CompleteFuture<V> implements Future<V> {
... | [CompleteFuture->[addListeners->[executor],addListener->[executor]]] | Creates a new future which is completed when the given object completes. Notify the listener that the future has been completed. | Can't tell from the PR but can this be `FutureCompletionStage`? |
@@ -48,6 +48,7 @@ public class ProcessProperties {
public static final String PATH_TEMP = "sonar.path.temp";
public static final String PATH_WEB = "sonar.path.web";
+ public static final String SEARCH_CLUSTER_NAME = "sonar.search.clusterName";
public static final String SEARCH_HOST = "sonar.search.host";
... | [ProcessProperties->[defaultPorts->[put],defaults->[put,currentTimeMillis],completeDefaults->[getValue,setDefault,getKey,valueAsInt,set,freePort,entrySet,valueOf]]] | This method is used to lookup the names of the variables that are used by the Son Creates a string that can be used to enable or disable the given . | @simonbrandhof why isn't this property called `sonar.cluster.search.clusterName` ? this property only makes sense if SQ runs as a cluster, therefor it should be prefixed with `sonar.cluster`, right? |
@@ -126,8 +126,7 @@ public class JTextFieldBuilder {
Preconditions.checkArgument(fields.length > 0);
Preconditions.checkNotNull(fields[0]);
- Arrays.asList(fields).forEach(field ->
- field.addKeyListener(SwingAction.keyReleaseListener(listener)));
+ Arrays.asList(fields).forEach(field -> field.... | [JTextFieldBuilder->[builder->[JTextFieldBuilder]]] | Adds a listener to the given fields that receive key events. | Nothing that it's probably faster to use Arrays.stream instead of creating a list |
@@ -468,7 +468,8 @@ CMS_ContentInfo *CMS_sign(X509 *signcert, EVP_PKEY *pkey,
goto err;
merr:
- CMSerr(CMS_F_CMS_SIGN, ERR_R_MALLOC_FAILURE);
+ if (ERR_peek_error() == 0)
+ CMSerr(CMS_F_CMS_SIGN, ERR_R_MALLOC_FAILURE);
err:
CMS_ContentInfo_free(cms);
| [CMS_sign_receipt->[CMS_sign],CMS_compress->[CMS_final],CMS_decrypt->[CMS_decrypt_set1_pkey],CMS_verify_receipt->[CMS_verify]] | - - - - - - - - - - - - - - - - - -. | Wouldn't it be better to push the determination of what kind of error it is down into `CMS_add1_cert()`? Incidentally this could fail to add an error if the error queue is not empty when we enter this function. |
@@ -119,6 +119,16 @@ func (glc *getLogsCmd) validateArgs() (err error) {
return errors.Errorf("error creating output directory (%s)", glc.outputDirectory)
}
}
+ if glc.storageContainerSASURL != "" {
+ url := strings.Split(glc.storageContainerSASURL, "?")
+ if len(url) != 2 {
+ return errors.Errorf("error v... | [Write->[Printf,Repeat],validateArgs->[LoadTranslations,IsNotExist,NormalizeAzureRegion,Join,Dir,Stat,New,Errorf,Wrap,MkdirAll],downloadLogs->[Copy,Join,TeeReader,Println,Sprintf,Close,Start,StdoutPipe,Wrap,OpenFile,NewSession,Debug],loadAPIModel->[LoadContainerServiceFromFile,PublicKeyAuth,SSHClientConfig,New,GetSSHEn... | validateArgs validates the arguments passed to the GetLogsCmd loadAPIModel loads the api model from the specified path. | this message should probably explain what's the expected format |
@@ -115,8 +115,7 @@ module Admin
facebook_key
facebook_secret
invite_only_mode
- allow_email_password_registration
- allow_email_password_login
+ allow_both_email_signup_and_login
require_captcha_for_email_password_registration
primary_brand_color_hex
... | [ConfigsController->[create->[redirect_to,to_h,nil?,empty?,is_a?,strip,each,respond_to?,reject,public_send],raise_confirmation_mismatch_error->[raise,new],confirmation_text->[username],clean_up_params->[each,transform_values!,delete],brand_contrast_too_low->[present?,low_contrast?,dig],validate_inputs->[redirect_to,any... | The main method of the administration interface. Updates the site configuration object. | Seeing as we are no longer passing the `allow_email_password_registration` and `allow_email_password_login` through params, I deleted them from ALLOWED_PARAMS |
@@ -118,9 +118,12 @@ if (empty($reshook))
$error=0;
$permissiontoadd = $user->rights->mymodule->write;
- $permissiontodelete = $user->rights->mymodule->delete || ($permissiontoadd && $object->status == 0);
- if (empty($backtopage)) $backtopage = dol_buildpath('/mymodule/myobject_card.php',1).'?id='.($id > 0 ? $id... | [fetch_optionals,transnoentitiesnoconv,fetch_name_optionals_label,executeHooks,loadLangs,trans,formconfirm,initHooks,showLinkToObjectBlock,close,getOptionalsFromPost,showLinkedObjectBlock,showactions] | Load object action code View a single object in the database. | Why changing rules on $permissiontodelete ? A draft object should always be deletable when you have permission to create. |
@@ -124,7 +124,7 @@ Then('I change {string} with {string} of field {string} of {string} modal window
end
Then(/^I fill in "([^"]*)" in "([^"]*)" field$/) do |text, input_id|
- page.find(input_id).set(text)
+ page.find(input_id).set(text)
end
Then(/^I should see "([^"]*)" in "([^"]*)" input field$/) do |text, c... | [visit,fetch,create,find,have_xpath,manage,have_current_path,join,accept,should,to,have_content,click_button,click_link,set,save_screenshot,dismiss,click,find_by_id,user,sleep,update,execute_script,click_on,id,within,resize_to,within_frame,not_to,send_keys,seed_demo_data,find_by,attach_file] | This method checks that the user has clicked on an alert on the page and then clicks on Drag and Drop on assets input field. | Layout/IndentationWidth: Use 2 (not 1) spaces for indentation. |
@@ -318,13 +318,8 @@ func (v *Validator) network(op trace.Operation, input *data.Data, conf *config.V
// we also need to have the appliance attached to the bridge network to allow
// port forwarding
conf.AddNetwork(bridgeNet)
-
- // make sure that the bridge IP pool is large enough for bridge networks
- err = v.c... | [checkNetworkMembership->[inNetworkHosts],network->[getEndpoint,portGroupConfig,checkPortGroups,checkNetworkConflict,configureSharedPortGroups],networkHelper->[getNetwork],dpgAndOpaqueHelper->[getNetwork],suggestNetwork->[listNetworks]] | network creates a network endpoint This function checks if the user provided IP on all networks and if not it checks if the This function is used to create a network in a bridge NetworkEndpoint - NetworkEndpoint implementation This function checks if the network is in a network that is not in the specified subnet and E... | Any reason to remove this validation? It is used by both create and configure commands. The current code structure put all validations under validate package. |
@@ -270,7 +270,14 @@ class CollectionDelete(ModelDeleteMutation):
@classmethod
def perform_mutation(cls, _root, info, **kwargs):
+ node_id = kwargs.get("id")
+
+ instance = cls.get_node_or_error(info, node_id, only_type=Collection)
+ products = list(instance.products.all())
+
r... | [ProductMediaUpdate->[Arguments->[ProductMediaUpdateInput],perform_mutation->[save,ProductMediaUpdate]],CollectionCreate->[save->[save],Arguments->[CollectionCreateInput],perform_mutation->[CollectionCreate]],CollectionReorderProducts->[perform_mutation->[CollectionReorderProducts]],ProductTypeUpdate->[Arguments->[Prod... | Delete a . | Do you need to convert them to list? What about prefetches? variant, categories, collections, attributes(?) |
@@ -22,7 +22,7 @@ def setup_parser(subparser):
def add(parser, args):
- env = ev.get_env(args, 'add', required=True)
+ env = spack.cmd.require_env('add')
with env.write_transaction():
for spec in spack.cmd.parse_specs(args.specs):
| [add->[write,msg,parse_specs,format,get_env,add,write_transaction],setup_parser->[add_common_arguments,add_argument]] | Add packages to the environment. | See above, and same for all the similar instances. |
@@ -154,4 +154,16 @@ public class DefaultMuleCoreExtensionManager implements MuleCoreExtensionManager
{
this.pluginClassLoaderManager = pluginClassLoaderManager;
}
+
+ /**
+ * Creates a {@link AdaptedDeploymentListener}.
+ *
+ * @param artifactDeploymentListener the artifactDeploymentL... | [DefaultMuleCoreExtensionManager->[start->[start],dispose->[dispose],stop->[stop],initializeCoreExtensions->[initialise]]] | Sets the pluginClassLoaderManager. | Always use interfaces if possible. In this case, and in the test case, use DeploymentListener |
@@ -35,6 +35,7 @@ class Config
'cache-files-ttl' => null, // fallback to cache-ttl
'cache-files-maxsize' => '300MiB',
'discard-changes' => false,
+ 'autoload-suffix' => false,
'prepend-autoloader' => true,
'github-domains' => array('github.com'),
);
| [Config->[all->[getRepositories,get],raw->[getRepositories],process->[get]]] | Creates a new configuration object. Merges the given config with the existing config. | The default value should be `null`, not `false`. This setting is not a boolean |
@@ -51,11 +51,17 @@ class IdentityConfig
config.add(:aamva_verification_url)
config.add(:account_reset_token_valid_for_days, type: :integer)
config.add(:account_reset_wait_period_days, type: :integer)
+ config.add(:acuant_maintenance_window_start)
+ config.add(:acuant_maintenance_window_finish)
+ ... | [IdentityConfig->[add->[raise,nil?,call],build_store->[add,new,written_env],to_s,split,parse,proc,raise,attr_reader]] | Builds the identity store. Adds all configuration options to the configuration object. Config options for all IDV messages. This function is used to configure a single node. This function is used to configure a single node in order to configure a single node. | we should add a type: `Time` or someting that parses these! |
@@ -444,7 +444,7 @@ namespace Js
inlineeOffset = inlinedFrameWalker.GetCurrentInlineeOffset();
}
}
- else if (ScriptFunction::Is(parentFunction) && HasInlinedFramesOnStack())
+ else if (ScriptFunction::Test(parentFunction) && HasInlinedFramesOnStack())
{
... | [No CFG could be retrieved] | This function returns the bytecode offset of the given block context. Checks if the last interpreter frame is from a bailout. | >ScriptFunction::Test( [](start = 17, length = 21) there are couple of other places in `JavascriptObject.cpp`, `FixedFieldInfo.cpp` and `Bailout.cpp` where we do `ScriptFunction::Is`. Can you change those as well? |
@@ -506,12 +506,12 @@ objects_update(double *duration, d_rank_t rank)
static int
dkey_verify(char *dkey, daos_epoch_t *epoch)
{
+ char akey[DTS_KEY_LEN];
+ uint64_t *indices;
+ uint32_t ground_truth; /* NB: Assume TEST_VAL_SIZE == 4 */
+ uint32_t test_string; /* NB: Assume TEST_VAL_SIZE == 4 */
int i;
int ... | [int->[vos_fetch_begin,vos_obj_update,D_GOTO,dts_rand_iarr_alloc_set,d_iov_set,daos_obj_close,D_ASSERT,bio_iod_post,dkey_verify,vos_iter_probe,objects_verify_close,TS_TIME_END,daos_obj_open,DP_RC,fprintf,dts_oid_gen,_vos_update_or_fetch,vos_iter_prepare,daos_update_or_fetch,memcpy,memcmp,vos_iter_finish,ts_reint_server... | verify if akey is in the correct order. | (style) "(foo*)" should be "(foo *)" |
@@ -194,7 +194,7 @@ func MakeOutput(v PropertyValue) PropertyValue {
}
func MakeSecret(v PropertyValue) PropertyValue {
- return NewSecretProperty(Secret{Element: v})
+ return NewSecretProperty(&Secret{Element: v})
}
// NewPropertyValue turns a value into a property value, provided it is of a legal "JSON-like" ... | [TypeString->[IsObject,OutputValue,TypeString,IsSecret,IsNumber,IsComputed,Input,IsBool,IsAsset,IsNull,IsArray,IsOutput,IsString,SecretValue,IsArchive],MapRepl->[ObjectValue,IsComputed,IsOutput,BoolValue,StringValue,IsString,IsObject,ArchiveValue,IsSecret,Input,IsBool,IsArray,SecretValue,OutputValue,AssetValue,IsNull,I... | NewNullProperty - returns a sorted list of all possible property values. InviteInvite returns a Property that returns a boolean if the given value is a known type. | If I understand correctly, we need `NewSecretProperty` to take a pointer to a `resource.Secret` so we can use pointer equality to check if the secret is found in the `cachingSecretsManager`, right? That approach is fine, but I wonder if we should instead -- or perhaps not now but later -- annotate the `resource.Secret`... |
@@ -60,6 +60,13 @@ export const PARTICIPANT_JOINED_SOUND_ID = 'PARTICIPANT_JOINED_SOUND';
*/
export const PARTICIPANT_LEFT_SOUND_ID = 'PARTICIPANT_LEFT_SOUND';
+/**
+ * The identifier of the raise hand notification.
+ *
+ * @type {string}
+ */
+export const RAISE_HAND_NOTIFICATION_ID = 'RAISE_HAND_NOTIFICATION';
+... | [No CFG could be retrieved] | Enumerate all possible XMPP MUC roles for a given node. | Can we have this constant in the notifications feature please? |
@@ -104,10 +104,8 @@ class MenuItem(ChannelContextTypeWithMetadata, CountableDjangoObjectType):
return None
requestor = get_user_or_app_from_context(info.context)
- requestor_has_access_to_all = Collection.objects.user_has_access_to_all(
- requestor
- )
- if reque... | [MenuItem->[resolve_category->[CategoryByIdLoader],resolve_parent->[then,ChannelContext,MenuItemByIdLoader],resolve_menu->[then,ChannelContext,MenuByIdLoader],resolve_page->[has_perm,get_user_or_app_from_context,PageByIdLoader],resolve_collection->[calculate_collection_availability->[calculate_collection_availability_w... | Resolve a collection by ID. | Maybe rename `staff_member` to `is_staff_member` since it's a boolean? |
@@ -673,8 +673,8 @@ class Valve:
actions.extend(valve_of.push_vlan_act(
vlan_table, vlan.vid))
match_vlan = NullVLAN()
- if vlan.loop_protect_external_ports():
- vlan_pcp = 0 if port.loop_protect_external else 1
+ if self.dp.has_externals:
+ ... | [TfmValve->[_add_default_flows->[_pipeline_flows]],Valve->[_add_vlan->[_get_managers,info],_reset_dp_status->[_set_var],port_delete->[ports_delete],_pipeline_change->[_pipeline_flows,table_msgs,info],reload_config->[_inc_var,_notify,_apply_config_changes,info],ofdescstats_handler->[_set_var],_set_port_status->[_set_var... | Add VLAN rules to port. | E501 line too long (122 > 120 characters) |
@@ -13,6 +13,8 @@ public interface TotalPowerAndTotalRolls {
List<Die> getDiceHits(int[] dice);
+ int getDiceSides();
+
int getStrength(Unit unit);
int getRolls(Unit unit);
| [No CFG could be retrieved] | Returns a list of misses for the given dice. | Side-note, this interface I think has lost its cohesion, it is more than total power and total rolls. It's also odds as `TotalPowerAndTotalRolls` would seem to be the name for a value object rather than an interface. This is something that if we can would be good t come back and rename. I almost think this would be an ... |
@@ -128,8 +128,8 @@ function getFiles(testType) {
if (argv.files) {
return files.concat(getFilesFromArgv());
}
- if (argv.saucelabs) {
- return files.concat(testConfig.unitTestOnSaucePaths);
+ if (argv.saucelabs || argv.safari || argv.firefox) {
+ return files.concat(testC... | [No CFG could be retrieved] | Get the list of files to be run based off of the specified test type. Updates the reporters for the specified test type. | I don't think it's safe to assume that having `--safari` or `--firefox` means this is running on GH actions. |
@@ -1702,6 +1702,12 @@ def sort_stages(stages, pipeline_context):
seen = set() # type: Set[Stage]
ordered = []
+ producers = {
+ pcoll: stage
+ for stage in all_stages for t in stage.transforms
+ for pcoll in t.outputs.values()
+ }
+
def process(stage):
if stage not in seen:
see... | [fix_side_input_pcoll_coders->[side_inputs,length_prefix_pcoll_coders],sort_stages->[process->[process],process],union->[union],extract_impulse_stages->[Stage],annotate_downstream_side_inputs->[get_all_side_inputs->[side_inputs],compute_downstream_side_inputs->[compute_downstream_side_inputs],get_all_side_inputs,comput... | Sort stages suitable for sequential execution. | Do we need to traverse into sub-transforms to fetch their inputs, or are we guaranteed that all transforms are leaf transforms? |
@@ -61,7 +61,7 @@ func PipelineRcName(name string, version uint64) string {
// GetRequestsResourceListFromPipeline returns a list of resources that the pipeline,
// minimally requires.
func GetRequestsResourceListFromPipeline(pipelineInfo *pps.PipelineInfo) (*v1.ResourceList, error) {
- return getResourceListFromSpe... | [Error->[Sprintf,WriteString,String],ResourceName,FinishCommit,NewCommit,Warnf,WriteByte,Warningf,Now,Clone,ParseQuantity,Info,NewSystemRepo,SetAuthToken,TagAnySpan,Put,Error,Ctx,VisitInput,Errorf,Bytes,UpdateJobState,Wrapf,GetFile,Infof,Grow,ToLower,TimestampProto,Get,NewRepo,WithCtx,ReadWrite,Sprintf,NewSQLTx,Unmarsh... | GetPipelineRepo returns a string representation of a given pipeline. result returns a map of resource IDs to their quantity if there is no result. | It might be a good idea to check for nil details here. |
@@ -39,7 +39,7 @@ public class ProjectWsRef {
private ProjectWsRef(@Nullable String uuid, @Nullable String key) {
this.uuid = uuid;
this.key = key;
- checkRequest(this.uuid != null ^ this.key != null, "Project id or project key can be provided, not both.");
+ checkRequest(this.uuid != null ^ this.key... | [ProjectWsRef->[newWsProjectRef->[ProjectWsRef],newOptionalWsProjectRef->[ProjectWsRef]]] | New optional. | This line makes line 54 of the same file obsolete. That line should be removed. We do the same check (but written differently) twice. |
@@ -266,13 +266,14 @@ func (plugin *OsdnNode) updateVXLANMulticastRules(subnets hostSubnetMap) {
otx := plugin.ovs.NewTransaction()
// Build the list of all nodes for multicast forwarding
- tun_dsts := ""
+ tun_dsts := make([]string, 0, len(subnets))
for _, subnet := range subnets {
if subnet.HostIP != plugi... | [watchNodes->[deleteNode,clearInitialNodeNetworkUnavailableCondition,addNode],watchSubnets->[updateVXLANMulticastRules,addNode]] | updateVXLANMulticastRules updates OVS VXLAN multicast rules. | If you are going to keep each string in the slice why not handle the commas in the `strings.Join()` and make the fmt a little less finiky? (Not that the fmt is wrong) |
@@ -292,7 +292,7 @@ static struct comp_dev *test_keyword_new(const struct comp_driver *drv,
}
/* build component event */
- ipc_build_comp_event(&cd->event, comp->type, comp->id);
+ ipc_build_comp_event(&cd->event, comp->type, comp->type);
cd->event.event_type = SOF_CTRL_EVENT_KD;
cd->event.num_elems = 0;
| [No CFG could be retrieved] | create a new component object test_keyword_new - test if a message or model is not initialized. | Both ID and type should already be sent by default so this is not needed. |
@@ -25,6 +25,16 @@ class TestPlotting(unittest.TestCase):
r = plt.figure()
self.assertNotEqual(p, r)
self.assertNotEqual(q, r)
+ p = plt.figure(width=100, height=120)
+ self.assertEqual(p.plot_width, 100)
+ self.assertEqual(p.plot_height, 120)
+ p = plt.figure(plot... | [TestPlotting->[test_default_resources_minified->[output_file,assertEqual,reset_output],test_tools->[assertEqual,len,assertIsInstance,enumerate,figure],test_grid->[circle,assertEqual,figure,len],test_axis->[LinearAxis,append,circle,assertEqual,len,set,add,figure],test_xgrid->[circle,assertEqual,figure,len],test_figure-... | Test the figure. | Just a note if you want to strongly ensure that warnings are being raised. In that case you can split the test and decorate the test with @patch('bokeh.plotting.warnings.warn') and then check if warn is being called as you expect. Not saying you should (in this PR or in general) just that you could. ;-) |
@@ -7337,7 +7337,7 @@ public class VmwareResource implements StoragePoolResource, ServerResource, Vmwa
if (targetHyperHost != null) {
ManagedObjectReference morTargetHostDc = targetHyperHost.getHyperHostDatacenter();
if (!morSourceHostDc.getValue().equalsIgnoreCase(morTarg... | [VmwareResource->[getNetworkStats->[networkUsage],ensureDiskControllersInternal->[ensureDiskControllers,ensureScsiDiskControllers],getUnmanageInstanceNics->[compare->[extractInt],getName],connect->[connect],configure->[configure],resizeRootDiskOnVMStart->[appendFileType],canSetEnableSetupConfig->[setBootOptions],execut... | Relocate a virtual machine. find VM through source host and find the missing vm in the target host. This method is called when a migration is required. This method checks if a VM can be migrated to a target host. | `VirtualMachineTO` has a `toString` that prints id, name, uuid and type. We could use the `vmTO.toString()` here and wherever we print `vmName`. |
@@ -2828,6 +2828,11 @@ class Jetpack {
*/
$active = apply_filters( 'jetpack_active_modules', $active );
+ // Manage is an integral part of how Jetpack works. Can't filter this out.
+ if ( ! in_array( 'manage', $active ) ) {
+ $active[] = 'manage';
+ }
+
return array_unique( $active );
}
| [Jetpack->[verify_json_api_authorization_request->[add_nonce],get_locale->[guess_locale_from_lang],admin_notices->[opt_in_jetpack_manage_notice,can_display_jetpack_manage_notice],authenticate_jetpack->[verify_xml_rpc_signature],admin_page_load->[disconnect,unlink_user,can_display_jetpack_manage_notice],wp_rest_authenti... | Get the active modules. | do we need to keep it on the list of modules? |
@@ -0,0 +1,14 @@
+from django.contrib import admin
+
+from .models import Rating
+
+
+class RatingAdmin(admin.ModelAdmin):
+ raw_id_fields = ('addon', 'version', 'user', 'reply_to',)
+ readonly_fields = ('addon', 'version', 'user', 'reply_to', 'ip_address',
+ 'body', 'rating')
+ fields = ... | [No CFG could be retrieved] | No Summary Found. | it's more of a nit, but I find specifying which fields are readonly, rather than which fields are writeable, an annoying opaque way of doing it. In Serializers I took to doing `read_only_fields = tuple(set(fields) - set(writeable_fields))` |
@@ -28,5 +28,12 @@ describe('ngSrcset', function() {
$rootScope.$digest();
expect(element.attr('srcset')).toBe('http://example.com/image1.png 1x,unsafe:javascript:doEvilStuff() 2x');
}));
+
+ it('should not throw an error if undefined', inject(function($rootScope, $compile) {
+ $rootScope.imageUrl = {}... | [No CFG could be retrieved] | expects srcset to be set on element. | I didn't try it, but I am pretty sure this test passes without the fix. Can you confirm that's inded tha case and change the test, so it fails without the fix ? |
@@ -44,6 +44,7 @@ class WP_Test_Jetpack_Shortcodes_Kickstarter extends WP_UnitTestCase {
* @since 4.5.0
*/
public function test_shortcodes_kickstarter_image() {
+ $this->markTestSkipped();
$url = 'https://www.kickstarter.com/projects/peaktoplateau/yak-wool-baselayers-from-tibet-to-the-world';
$content = ... | [WP_Test_Jetpack_Shortcodes_Kickstarter->[test_shortcodes_kickstarter_exists->[assertEquals],test_shortcodes_kickstarter_invalid_url->[assertEquals],test_shortcodes_kickstarter_image->[assertContains],test_shortcodes_kickstarter->[assertNotEquals,assertEquals]]] | Test if there is a Kickstarter image. | I think this is fine to remove now. Tests are passing in other PRs |
@@ -256,9 +256,7 @@ function Browser(window, document, $log, $sniffer) {
// html5 history api - popstate event
if ($sniffer.history) jqLite(window).on('popstate', fireUrlChange);
// hashchange event
- if ($sniffer.hashchange) jqLite(window).on('hashchange', fireUrlChange);
- // polling
- ... | [No CFG could be retrieved] | Register callback function that will be called when url changes. Returns current base href of the . | There's quite a bit of code that's now not used that could be removed. |
@@ -31,6 +31,10 @@ import org.apache.flink.table.runtime.types.InternalSerializers;
import org.apache.flink.table.types.logical.LogicalType;
import org.apache.flink.table.types.logical.RowType;
import org.apache.hadoop.fs.Path;
+import org.apache.hudi.common.table.HoodieTableMetaClient;
+import org.apache.hudi.commo... | [TestData->[checkWrittenData->[checkWrittenData]]] | Creates an object that represents a single unique integer value in the table. Data set for testing. | It would be better to move these lines into `org.apache.hudi.xxx` segments? |
@@ -75,6 +75,9 @@ S_SIZE = 32
NONCE_SIZE = 16
"""byte size of Nonce"""
+PORT = 443
+"""TCP port on which to perform (standalone) challenge"""
+
# Key Sizes
RSA_KEY_SIZE = 2048
"""Key size"""
| [frozenset,join] | The path to the chain file. | There are a lot of different ports, and hence the name is a bit ambiguous to me. Maybe `STANDALONE_CHALLENGE_PORT`? |
@@ -603,6 +603,12 @@ public abstract class FileBasedSink<T> extends Sink<T> {
return result;
}
+ @Override
+ public final void abort() throws Exception {
+ IOChannelUtils.deleteIfExists(filename);
+ close();
+ }
+
/**
* Return the FileBasedWriteOperation that this Writer belo... | [FileBasedSink->[populateDisplayData->[populateDisplayData],FileBasedWriter->[close->[writeFooter],open->[prepareWrite,getSink,getMimeType,buildTemporaryFilename,create,writeHeader]],FileBasedWriteOperation->[generateDestinationFilenames->[getFileExtension],getBaseOutputFilename],getFilenameSuffix]] | Closes the bundle and writes the footer to the file. | For some file systems (like GCS), close is what actually creates the file. you should close first, then delete with failure handling after close finishes. |
@@ -172,7 +172,7 @@ public class UdfCompiler {
method,
functionName,
description);
- LOGGER.trace("Generated class for functionName={}, method={} class{}\n",
+ LOGGER.info("Generated class for functionName={}, method={} class\n{}\n",
functionName,
method.... | [UdfCompiler->[createScriptEvaluator->[setParentClassLoader,getName,setDefaultImports,newScriptEvaluator,setClassName],typeConversionCode->[replaceAll,equals,append,StringBuilder,valueOf],getRawType->[getRawType],createJavaSourceClassLoader->[findResource->[open->[getBytes,ByteArrayInputStream,name],Resource,endsWith],... | Compiles a KsqlAggregateFunction. | why the log level change? I _believe_ it already logs out UFDs at info elsewhere... (though I could be wrong). Can we ensure we're not just spamming the logs here. |
@@ -189,9 +189,9 @@ class Portal
/**
* Adds an environment to this portal.
*
- * @param $environment Environment The environment to add
+ * @param Environment $environment Environment The environment to add
*/
- public function addEnvironment($environment)
+ public function addEnvir... | [Portal->[toArray->[toArray,getEnvironments,getKey,getName,getLocalizations],setEnvironments->[addEnvironment],getLocalization->[getLocalizations]]] | Adds an environment to the list of environments. | Same as above, remove the type here to avoid BC breaks. |
@@ -415,7 +415,7 @@ int tplg_load_one_control(struct snd_soc_tplg_ctl_hdr **ctl, char **priv_data,
ctl_hdr = (struct snd_soc_tplg_ctl_hdr *)malloc(hdr_size);
if (!ctl_hdr) {
fprintf(stderr, "error: mem alloc\n");
- return -EINVAL;
+ return -errno;
}
/* read control header */
| [tplg_load_process->[tplg_read_array],tplg_load_pga->[tplg_read_array],tplg_load_pcm->[tplg_read_array],tplg_load_src->[tplg_read_array],tplg_load_mixer->[tplg_read_array],tplg_load_asrc->[tplg_read_array],get_token_comp_format->[find_format],load_widget->[tplg_load_controls],tplg_load_buffer->[tplg_read_array],tplg_lo... | load one control load mixer control and enum control This function is used to read the private data of an enum control block. endregion region System Methods. | Need to be careful here as some calls dont set errno. It's safe to return -ENOMEM for calloc and friends though. |
@@ -333,6 +333,10 @@ class AmpAccordion extends AMP.BaseElement {
sectionIter.removeAttribute('expanded');
}
sectionIter.children[0].setAttribute('aria-expanded', 'false');
+ this.setRenderSubtreeIfEnabled(
+ sectionIter.children[1],
+... | [No CFG could be retrieved] | private method for handling the logic of the menu item. Expand a section. | I'm pretty sure you will need to add this to the Closure Compiler's browser externs to prevent renaming during compilation. Should either use the attribute (via `setAttribute()`) or use bracket access for now. |
@@ -466,8 +466,12 @@ var inputType = {
* @description
* Input with month validation and transformation. In browsers that do not yet support
* the HTML5 month input, a text element will be used. In that case, the text must be entered in a valid ISO-8601
- * month format (yyyy-MM), for example: `2009-01`. T... | [No CFG could be retrieved] | A component that handles the validation of a key in the month. * - A function to execute when the user enters the element. | I don't like this sentence. (I am not even sure what it means.) |
@@ -1928,6 +1928,10 @@ class Epochs(_BaseEpochs):
warn, if 'ignore' it will proceed silently. Note.
If none of the event ids are found in the data, an error will be
automatically generated irrespective of this parameter.
+ segment_reject : bool
+ Whether to reject based on annotatio... | [EpochsArray->[__init__->[_detrend_offset_decim,drop_bad_epochs]],combine_event_ids->[copy],equalize_epoch_counts->[drop_epochs,drop_bad_epochs],_BaseEpochs->[equalize_event_counts->[drop_epochs,copy,_key_match,drop_bad_epochs],plot_drop_log->[plot_drop_log],_get_data->[_get_epoch_from_raw,_detrend_offset_decim,_is_goo... | Signal the end of the sequence. Get a subset of Epochs object with a subset of the given event. | segment_reject -> reject_by_annotation |
@@ -374,7 +374,7 @@ class KeyVaultCertificate(object):
class CertificateOperation(object):
# pylint:disable=too-many-instance-attributes
- """A certificate operation is returned in case of asynchronous requests.
+ """A certificate operation is returned in case of server-side asynchronous requests.
... | [DeletedCertificate->[_from_deleted_certificate_item->[_from_certificate_item],_from_deleted_certificate_bundle->[_from_certificate_policy_bundle,_from_certificate_item]],CertificateOperationError->[_from_error_bundle->[_from_error_bundle]],CertificateIssuer->[_from_issuer_bundle->[_from_admin_detail,_from_issuer_item]... | A property for the secret id of the certificate. This function is used to check if a csr is present. | Suggest describing these operations as "long running". |
@@ -159,7 +159,7 @@ class WPSEO_Sitemaps_Admin {
return;
}
- $options = WPSEO_Options::get_option( 'wpseo_xml' );
+ $options = WPSEO_Options::get_option( 'wpseo' );
$ping_search_engines = false;
| [WPSEO_Sitemaps_Admin->[delete_sitemaps->[detect_blocking_filesystem_sitemaps],status_transition->[status_transition_bulk]]] | This function is called when the bulk import is finished. | I became a big fan of wrapping dependencies, because this makes it easier to mock without modifying the option data. |
@@ -26,7 +26,14 @@ class Renderer(Model):
generally useful to instantiate on its own.
"""
-class TileRenderer(Renderer):
+
+@abstract
+class DataRenderer(Renderer):
+ """ A base class for data renderer types (e.g. GlyphRenderer). ``DataRenderer`` is not
+ generally useful to instantiate on its own.
+ ... | [GlyphRenderer->[_check_bad_column_name->[sorted,set,dataspecs,isinstance,join,add,properties_with_values],_check_missing_glyph->[str],_check_no_source_for_glyph->[str],String,Enum,Instance,error],TileRenderer->[Float,Bool,Enum,String,Instance],GuideRenderer->[__init__->[append,super],Enum,Instance],DynamicImageRendere... | A base class for renderer types that Bokeh supports. Required parameters for the tile function. | No. Abstract classes can not be instantiated, but I see where this comes from. Please change `Renderer`'s docstring as well. "An abstract base class for ..." should suffice. Also, `GlyphRenderer` should be enclosed with double backticks. |
@@ -267,6 +267,10 @@ class Resolver(object):
# requirements we have to pull the tree down and inspect to assess
# the version #, so it's handled way down.
if not req_to_install.link:
+ if req_to_install.is_pinned:
+ # No need to check the index for a better version.
... | [Resolver->[_resolve_one->[add_req,_get_abstract_dist_for,_check_dist_requires_python],get_installation_order->[schedule->[schedule],schedule],_check_skip_installed->[_set_req_to_reinstall,_is_upgrade_allowed],_get_abstract_dist_for->[_check_skip_installed,_set_req_to_reinstall,_is_upgrade_allowed]]] | Checks if the req_to_install should be skipped. | Should we be checking that the pinned does indeed match the installed version here? I imagine this'll return even if we're at `0.1.0` if pinned on `0.1.1` for example. |
@@ -0,0 +1,18 @@
+using System;
+using System.Collections.Generic;
+using System.Linq;
+using System.Runtime.Serialization;
+using System.Text;
+
+namespace Dynamo.Extensions
+{
+ [DataContract]
+ internal class ExtensionDefinition
+ {
+ [DataMember]
+ public string AssemblyName { get; set; }
+
... | [No CFG could be retrieved] | No Summary Found. | This is Mono Compliant I think - but can you just confirm? |
@@ -697,7 +697,7 @@ module ActsAsXapian
# Before calling writable_init we have to make sure every model class has been initialized.
# i.e. has had its class code loaded, so acts_as_xapian has been called inside it, and
# we have the info from acts_as_xapian.
- model_classes = ActsAsXapianJob.pluck("DI... | [init_query_parser->[stemmer],xapian_destroy->[xapian_document_term],writable_init->[stemmer,bindings_available],xapian_index->[xapian_value,xapian_document_term],Search->[initialize->[initialize_db,initialize_query]],readable_init->[bindings_available],QueryBase->[initialize_db->[readable_init],initialize_query->[valu... | Updates the index of the model classes. This is a hack to avoid the problem with the lock file being removed when we re done. | Pass &:constantize as an argument to map instead of a block.<br>Line is too long. [84/80] |
@@ -85,8 +85,8 @@ time_mask = (times > 0) & (times < 400)
evoked_data = evoked_data[:, time_mask]
times = times[time_mask]
-# The time vector reflects the origininal time points, not the decimated time
-# points returned by single trial powr. Be sure to decimate the time mask
+# The time vector reflects the origin... | [max,permutation_cluster_1samp_test,single_trial_power,log10,imshow,show,dict,get_data,ylim,clf,ylabel,abs,plot,find_events,data_path,mean,subplot,title,ones_like,subplots_adjust,xlabel,zip,Raw,arange,xlim,colorbar,Epochs,pick_types] | Epochs a series of time - vector epochs. Compute statistics of the null hypothesis epochs. | 2 spaces before Be |
@@ -65,8 +65,13 @@ function getElementWidthVisitor(setWidth) {
setWidth(0);
return true;
default:
- // If no layout is provided, we must use getComputedStyle.
- setWidth(parseInt(style.width, 10) || 0);
+ // If no layout is provided, we must use getComputedStyle. Padding is... | [No CFG could be retrieved] | Returns a Dom visitor callback that will set the value of * and the fws Returns the fixed size of the given element or the nearest ancestor that has a fixed. | Just to confirm: do we need to worry about things like margins and borders here? |
@@ -1177,4 +1177,15 @@ export class AmpStoryPage extends AMP.BaseElement {
isAd() {
return this.element.hasAttribute(ADVERTISEMENT_ATTR_NAME);
}
+
+ /**
+ * Sets text styles for descendants of the
+ * <amp-story-page> element.
+ * @private
+ */
+ setDescendentCssTextStyles_() {
+ this.mutateElem... | [AmpStoryPage->[setState->[PLAYING,dev,NOT_ACTIVE,PAUSED],pauseCallback->[DESKTOP_PANELS,UI_STATE],constructor->[resolve,timerFor,NOT_ACTIVE,getAmpdoc,forElement,getStoreService,resourcesForDoc,platformFor,promise,debounce,reject],emitProgress_->[dict,PAGE_PROGRESS,dispatch],unmuteAllMedia->[play,hasAttribute,all,pause... | Checks if the element is an ad. | Nit: the `buildCallback` already runs in a mutate phase, so it's the one exception where you don't need to wrap your DOM mutations in a `mutateElement()` statement |
@@ -15,7 +15,7 @@ export default DiscourseRoute.extend({
},
setupController(controller, model) {
- if (model.get("isNew") || isEmpty(model.get("web_hook_event_types"))) {
+ if (model.get("isNew")) {
model.set("web_hook_event_types", controller.get("defaultEventTypes"));
}
| [No CFG could be retrieved] | Default route for web - hooks. | I'm curious why this line changed? |
@@ -220,6 +220,13 @@ class GeneralNameReplacer(RecordingProcessor):
self.replace_header(response, 'location', old, new)
self.replace_header(response, 'operation-location', old, new)
self.replace_header(response, 'azure-asyncoperation', old, new)
+ self.replace_header(re... | [SubscriptionRecordingProcessor->[process_response->[replace_header_fn]],GeneralNameReplacer->[process_response->[replace_header]]] | Process a response from the Azure API. | @chlowell would this solve your issue? |
@@ -131,6 +131,7 @@ public class HoodieTestTable {
this.basePath = basePath;
this.fs = fs;
this.metaClient = metaClient;
+ testTableState = HoodieTestTableState.of();
}
public static HoodieTestTable of(HoodieTableMetaClient metaClient) {
| [HoodieTestTable->[of->[of,HoodieTestTable],withLogFile->[withLogFile],addInflightCompaction->[addRequestedCompaction],moveInflightCompactionToComplete->[of],deleteFilesInPartition->[listAllFilesInPartition],doSavepoint->[deleteFilesInPartition,getSavepointMetadata],addCommit->[addCommit],addRequestedCompaction->[addRe... | Returns a HoodieTestTable instance for the given meta client. | Where is this used? |
@@ -57,6 +57,16 @@ public class UUIDTestCase extends AbstractMuleTestCase
}
}
+ @Test
+ public void testUUUIDLength() throws Exception
+ {
+ for (int i = 0; i < 1000; i++)
+ {
+ String generatedId = UUID.getUUID();
+ assertThat(generatedId.length(), is(UUID.U... | [UUIDTestCase->[testGenerateUniqueAndIncrementalIds->[compare->[compareTo],sort,get,getUUID,contains,add,assertEquals,valueOf,fail]]] | Test generate unique and incremental ids. | doing it once is enough |
@@ -146,6 +146,14 @@ RESIZE_TYPES = {
}
+INTERPOLATION_TYPES = {
+ 'LINEAR': cv2.INTER_LINEAR,
+ 'CUBIC': cv2.INTER_CUBIC,
+ 'NEAREST': cv2.INTER_NEAREST,
+ 'AREA': cv2.INTER_AREA,
+}
+
+
def nms(x1, y1, x2, y2, scores, thresh, include_boundaries=False, keep_top_k=None):
b = 1 if include_boundari... | [resize_image_letterbox->[resize],resize_image_with_aspect->[resize_image],OutputTransform->[resize->[resize,compute_resolution]],resize_image->[resize]] | Find all nms in a 2D histogram. | nearest and area may be helpful in future |
@@ -724,9 +724,11 @@ class diaspora {
intval($uid),
dbesc($nurl_sql)
);
- if($r)
+ if(dbm::is_result($r)) {
return $r[0];
+ }
+ logger("Haven't found contact for user ".$uid." and handle ".$handle, LOGGER_DEBUG);
return false;
}
| [diaspora->[receive_status_message->[children],message->[getName],verify_magic_envelope->[children,attributes],decode->[children,attributes],receive_request_make_friend->[get_hostname],transmit->[get_curl_code,get_curl_headers],valid_posting->[children,getName],dispatch->[getName]]] | Get contact by handle. | Standards: can you please add a space after the `if` operator? Sorry I didn't catch that on my first pass. |
@@ -28,6 +28,7 @@ public class FunctionCallTerm implements Term {
private final Class<?> resultJavaClass;
private final SqlType resultType;
+ @SuppressFBWarnings(value = "EI_EXPOSE_REP2")
public FunctionCallTerm(
final Kudf kudf,
final List<Term> arguments,
| [FunctionCallTerm->[getValue->[toArray,toList,cast,evaluate,collect]]] | This method is invoked from a base class in order to provide a function call to a specific. | Still need to suppress because of `Class<?> resultJavaClass`... |
@@ -77,8 +77,8 @@ namespace Dynamo.DocumentationBrowser
return;
MonitorDirectory(directoryInfo);
- var files = directoryInfo.GetFiles(fileExtension, SearchOption.AllDirectories);
- TrackDocumentationFiles(files);
+ var files = directoryInfo.GetFiles(FILE_... | [PackageDocumentationManager->[GetAnnotationDoc->[TryGetValue],OnFileRenamed->[Name,Remove,GetFileNameWithoutExtension,ContainsKey,FullPath,OldName,Add],ContainsAnnotationDoc->[ContainsKey],Dispose->[Renamed,Values,Deleted,Created],MonitorDirectory->[Deleted,Path,Renamed,FullName,Created,ContainsKey,Add],TrackDocumenta... | Adds package documentation files. | can we log something about the failure? |
@@ -27,7 +27,7 @@ class RepositoriesController < ApplicationController
def index
respond_to do |format|
format.html do
- render 'empty_index' if @repositories.blank?
+ render 'empty_index' if Repository.accessible_by_teams(current_team).blank?
end
format.json do
rende... | [RepositoriesController->[copy->[copy],update->[update]]] | Returns a list of the node id for the authenticated user. | ins't '.none?' a bit faster? |
@@ -23,6 +23,7 @@ package <%=packageName%>.web.rest;
import <%=packageName%>.AbstractCassandraTest;
<%_ } _%>
import <%=packageName%>.<%= mainClass %>;
+import <%=packageName%>.config.TestSecurityConfiguration;
import <%=packageName%>.domain.Authority;
import <%=packageName%>.domain.<%= asEntity('User') %>;
impor... | [No CFG could be retrieved] | Imports an existing from the given package. Imports the packages that should be used by the MockMvcResultMatchers. | Did you missed the condition if (authenticationType === 'oauth2')....? |
@@ -271,9 +271,9 @@ public class BuildTimeEnabledProcessor {
} else {
// Add @Alternative to the producer
transform.add(DotNames.ALTERNATIVE);
+ transform.remove(s -> s.name().equals(DotNames.ALTERNATIVE_PRIORITY));
}
transform.done... | [BuildTimeEnabledProcessor->[transformBean->[transform],buildProperty->[accept,apply]]] | Check if the bean is vetoed or alternative. | This solution is not ideal, i.e. if a user declares an `@Alternative` producer and enables it via `quarkus.arc.selected-alternatives` then `@UnlessBuildProperty` would have no effect. OTOH it's definitely better than the current solution and we have to think a little how to solve this properly. So +1 for this PR and I'... |
@@ -4181,8 +4181,9 @@ def beam_search(step,
- machine translation : demo/seqToseq/translation/gen.conf \
demo/seqToseq/seqToseq_net.py
- :param name: Name of the recurrent unit that generates sequences.
- :type name: base string
+ :param name: The name of the recurrent unit ... | [seq_concat_layer->[LayerOutput],out_prod_layer->[LayerOutput],img_pool_layer->[LayerOutput],multiplex_layer->[LayerOutput],cross_entropy->[LayerOutput,__cost_input__],multibox_loss_layer->[LayerOutput],gated_unit_layer->[fc_layer,dotmul_operator,mixed_layer],lstm_step_layer->[LayerOutput],clip_layer->[LayerOutput],Mix... | A beam search algorithm that uses a simple RNN algorithm. This function is used to create a LayerOutput from a sequence of Candidates. Missing node - level layer group set. | that generates sequences. --> that is responsible for generating sequences. |
@@ -885,8 +885,12 @@ export class Viewer {
if (eventType == 'viewport') {
if (data['paddingTop'] !== undefined) {
this.paddingTop_ = data['paddingTop'];
+ this.viewportObservable_.fire({
+ paddingTop: this.paddingTop_,
+ duration: data['duration'],
+ curve: data['c... | [No CFG could be retrieved] | This function is called by the viewer when a message arrives from the Viewer. Provides a message delivery mechanism by which AMP document can deliver messages to the viewer. | Why are we not just sending `data`? |
@@ -0,0 +1,16 @@
+module DevelopmentDependencyChecks
+ extend ActiveSupport::Concern
+
+ included do
+ before_action :verify_sidekiq_running, only: %i[index show], if: proc { Rails.env.development? }
+ end
+
+ private
+
+ def verify_sidekiq_running
+ return if Sidekiq::ProcessSet.new.size.positive?
+
+ fl... | [No CFG could be retrieved] | No Summary Found. | **nitpick (non-blocking):** The `html_safe` here is superfluous, as the string contains nothing that needs escaping. |
@@ -501,6 +501,11 @@ func convertV1Resource(resource string) (string, error) {
}
func convertV1Cfgmgmt(terms []string) (string, error) {
+ if len(terms) == 1 {
+ // skip?
+ return "", nil
+ }
+
if terms[1] == "stats" {
return "infra:nodes", nil
}
| [Wrapf,Join,Error,Infof,NewLogger,Sprintf,Split,New,String,Errorf,Wrap,HasPrefix] | customPolicyFromV1 creates a v2 policy from a v1 policy. returns a single resource if there is no resource in terms. | Can we remove the question mark? |
@@ -137,6 +137,12 @@ public final class HoodieMetadataConfig extends HoodieConfig {
.withDocumentation("There are cases when extra files are requested to be deleted from metadata table which was never added before. This config"
+ "determines how to handle such spurious deletes");
+ public static fi... | [HoodieMetadataConfig->[Builder->[HoodieMetadataConfig]]] | Creates a builder for a HoodieMetadataConfig. | this is 0.11.0 |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.