patch stringlengths 18 160k | callgraph stringlengths 4 179k | summary stringlengths 4 947 | msg stringlengths 6 3.42k |
|---|---|---|---|
@@ -36,6 +36,7 @@ class MiniSqlMultisiteConnection < MiniSql::Postgres::Connection
def before_committed!(*); end
def rolledback!(*); end
+ def trigger_transactional_callbacks?; end
end
# Allows running arbitrary code after the current transaction has been committed.
| [MiniSqlMultisiteConnection->[sql_fragment->[encode],raw_connection->[raw_connection]]] | end of method. | is "no transactional callbacks" the default we are after here? |
@@ -52,6 +52,16 @@ func IsBech32Address(s string) bool {
return true
}
+// IsEntryPointAddress returns true if the Address is the ENTRY_POINT Address.
+func (a Address) IsEntryPoint() bool {
+ for i := range a {
+ if a[i] != 0xFF {
+ return false
+ }
+ }
+ return true
+}
+
// Bytes gets the string representat... | [String->[Bech32],MarshalText->[MarshalText,Bytes],SetBytes,Bytes] | Bytes returns the bytes of a Address. | why not just hardcode the entry point address and do byte.compare? |
@@ -13,8 +13,8 @@ using Xunit;
namespace System.Net.Tests
{
- [SkipOnCoreClr("System.Net.Tests are flaky")]
- [SkipOnMono("System.Net.Tests are flaky")]
+ [SkipOnCoreClr("System.Net.Tests may timeout in stress configurations")]
+ [ActiveIssue("https://github.com/dotnet/runtime/issues/2391", TargetFramew... | [HttpListenerAuthenticationTests->[Dispose->[Dispose]]] | Creates a class which creates a HttpListener which implements HTTP Basic HTTP Basic HTTP Basic HTTP Basic Managed implementation connects successfully. | `SkipOnMono` didn't work? Or you're changing it because we're associating with an issue? |
@@ -9,7 +9,15 @@ def assert_installed(script, **kwargs):
(val['name'], val['version'])
for val in json.loads(ret.stdout)
)
- assert set(kwargs.items()) <= installed
+ assert all(item in installed for item in kwargs.items()), \
+ "{!r} not all in {!r}".format(kwargs, installed)
+
+
+d... | [test_new_resolver_can_install_with_version->[assert_installed],test_new_resolver_can_install->[assert_installed],test_new_resolver_installs_dependencies->[assert_installed],test_new_resolver_picks_latest_version->[assert_installed]] | Assert that the package is installed. | nit-ish: Can we keep the set operations here? It's definitely easier to read. |
@@ -30,6 +30,6 @@ namespace NServiceBus.Transport
/// <summary>
/// Disposes all transport internal resources.
/// </summary>
- public abstract Task DisposeAsync();
+ public abstract Task Shutdown();
}
}
\ No newline at end of file
| [TransportInfrastructure->[IMessageReceiver->[SingleOrDefault,Id]]] | Dispose the object. | Would it make sense to make this non abstract and return Task.Completed in the base for transports that do not care about this method? |
@@ -1300,6 +1300,8 @@ function admin_page_site(App $a)
'$abandon_days' => array('abandon_days', t('Accounts abandoned after x days'), Config::get('system','account_abandon_days'), t('Will not waste system resources polling external sites for abandonded accounts. Enter 0 for no time limit.')),
'$allowed_sites' =>... | [admin_page_users_post->[getMessage],admin_page_site_post->[set_baseurl,get_path],admin_page_site->[get_hostname,get_path],admin_page_users->[set_pager_itemspage,set_pager_total],admin_page_contactblock->[set_pager_itemspage,set_pager_total]] | Admin page site get conversation poll choices Displays a list of possible choices for a site A list of all configuration options. Mobile theme configuration. Config getter for user registrations Set default permissions for all new members. | "Comma separated"? :-) |
@@ -456,7 +456,13 @@ if (empty($reshook))
$date_end=$lines[$i]->date_fin_prevue;
if ($lines[$i]->date_fin_reel) $date_end=$lines[$i]->date_fin_reel;
if ($lines[$i]->date_end) $date_end=$lines[$i]->date_end;
-
+ // Extr... | [update_price,create,form_multicurrency_rate,jdate,getNomUrl,select_incoterms,begin,select_comptes,getLibType,setProject,add_contact,showOptionals,printOriginLinesList,textwithpicto,free,transnoentitiesnoconv,query,form_modes_reglement,clear_attached_files,trans,num_rows,hasDelay,showLinkToObjectBlock,getListIdAvoirFro... | Creates an object from the data returned by the API. Adds line with missing missing data. | Because var $extrafields is already defined globally previously, it looks dangerous to use same name here. If you rename into extrafieldsforlines, does you fix still work ? |
@@ -147,8 +147,8 @@ class AnnotationCategoriesController < ApplicationController
# is thrown by Psych in Ruby 2.*.
rescue ArgumentError, Psych::SyntaxError => e
flash[:error] = I18n.t('annotations.upload.syntax_error',
- :error => "#{e}")
- redirect_to :action => 'index', :assignm... | [AnnotationCategoriesController->[get_annotations->[annotation_texts,find],add_annotation_category->[new,find,render,update_attributes,post?,save,assignment],add_annotation_text->[new,find,last_editor_id,render,annotation_category,update_attributes,post?,save,creator_id,id],csv_upload->[redirect_to,utf8_encode,find,emp... | upload a single node in the YAML file. | Align the parameters of a method call if they span more than one line. |
@@ -84,6 +84,9 @@ namespace Content.Server.GameTicking
var timeSpan = _gameTiming.RealTime - startTime;
Logger.InfoS("ticker", $"Loaded map in {timeSpan.TotalMilliseconds:N2}ms.");
+
+ // Start playtime tracking
+ _playtimeManager.Ticking = true;
}
p... | [GameTicker->[RestartRound->[StartRound,PreRoundSetup],UpdateRoundFlow->[StartRound]]] | Setup the initial state of the ticker. The main function that is called when a user has no jobs or if there are no players Called when game is started. | It seems kind of weird to me that the playtime tracking is paused *only* when the *entire server* is in the lobby. |
@@ -147,9 +147,10 @@ public class AvroUtils {
* Common use cases for this method is in traversing {@link Schema} object into nested level and create {@link Schema}
* object for non-root level.
*/
- public static void convertFieldToSchemaWithProps(Map<String,JsonNode> fieldProps, Schema targetSchemaObj) {
-... | [AvroUtils->[removeUncomparableFieldsFromUnion->[removeUncomparableFields],nullifyFieldsForSchemaMerge->[getField],dropRecursiveFields->[SchemaEntry],overrideNameAndNamespace->[convertRecordSchema,switchNamespace,switchName],getFieldHelper->[getField,getFieldHelper],dropRecursive->[dropRecursive,fullyQualifiedType,copy... | Convert field to schema with props. | Shall we preserve the original method still since it is a public static method ? |
@@ -49,6 +49,7 @@ public class NicProfile implements InternalIdentity, Serializable {
URI broadcastUri;
ReservationStrategy strategy;
boolean defaultNic;
+ Integer mtu;
Integer networkRate;
boolean isSecurityGroupEnabled;
| [NicProfile->[toString->[toString],getIPv6Gateway,getReservationStrategy,getIPv6Address,getTrafficType,getReservationId,getBroadcastDomainType,getIPv4Netmask,getInstanceId,getDeviceId,isDefaultNic,getMode,getMacAddress,getUuid,getIPv4Address,getId,getAddressFormat,getIPv6Cidr,getIPv4Gateway]] | Produces a class which represents a single . Get network details. | If I am not mistaken, this variable can be set to private. Could you please set this to private? |
@@ -2215,14 +2215,12 @@ void HMI_PauseOrStop() {
checkkey = Back_Main;
// Wait for planner moves to finish!
if (HMI_flag.home_flag) planner.synchronize();
- card.endFilePrint();
+ card.flag.abort_sd_printing = true;
+ marlin_state = MF_SD_COMPLETE;
... | [No CFG could be retrieved] | Display the HMI window. The Chinese Move example. | With `EVENT_GCODE_SD_ABORT` removed, that means it'll skip any `EVENT_GCODE_SD_ABORT` commands a user adds in `Configuration_adv.h`. |
@@ -49,10 +49,12 @@ namespace MonoGame.Tests.ContentPipeline
get { throw new NotImplementedException(); }
}
+#if !XNA
public override ContentIdentity SourceIdentity
{
get { throw new NotImplementedException(); }
}
+#endif
public override TargetP... | [TestProcessorContext->[TOutput->[GetType,Value,SetValue,GetProperty,IsAssignableFrom,CreateInstance,Process,Key],HiDef]] | Provides a base class for the class. type check for input and output types. | We should remove the SourceIdentity from ContentProcessorContext and leave it as part of the PipelineProcessorContext. The user can get the source/filename with `((PipelineProcessorContext)context).SourceIdentity`. In general whenever we extent on the XNA API this way we should do so with interfaces. like so: `public C... |
@@ -63,6 +63,10 @@ Cancel a secret token invite (like sms):
Name: "f, force",
Usage: "don't ask for confirmation",
},
+ cli.BoolFlag{
+ Name: "r, recursive",
+ Usage: "recursively remove member from subtree as well; invalid with --invite-id",
+ },
},
}
}
| [Run->[GetTerminalUI,Printf,NewNormalizedUsername,GetCurrentStatus,Sprint,Sprintf,G,Background,PromptYesNo,TeamRemoveMember,GetTeamID,Eq,TODO],ParseArgv->[TeamInviteIDFromString,New,String,IsSet,Errorf,F,Bool],NewContextified,ChooseCommand] | ParseArgv parses command line options for TeamRemoveMember. | I would say `cannot be used with` instead of invalid |
@@ -109,7 +109,7 @@ type GeneralOnlyConfig interface {
KeeperRegistrySyncInterval() time.Duration
KeeperRegistrySyncUpkeepQueueSize() uint32
KeyFile() string
- LogLevel() LogLevel
+ LogLevel() zapcore.Level
LogSQLMigrations() bool
LogSQLStatements() bool
LogToDisk() bool
| [P2PV2AnnounceAddresses->[P2PV2ListenAddresses],SessionSecret->[RootDir],OCRContractSubscribeInterval->[getDuration],OCRContractPollInterval->[getDuration],TLSDir->[RootDir],KeyFile->[TLSKeyPath,TLSDir],CreateProductionLogger->[LogLevel,RootDir,CreateProductionLogger,LogToDisk,JSONConsole],SessionOptions->[SecureCookie... | ExplorerSecret returns the secret of the current environment. MaxOpenConns is the maximum number of open connections in the system. | One consequence of having the `config.LogLevel` wrapper type in this interface was that the `logger` package couldn't declare a matching interface method without importing `config`, which was creating a cycle. |
@@ -506,7 +506,10 @@ class Order(CountableDjangoObjectType):
@staticmethod
def resolve_invoices(root: models.Order, info):
- return root.invoices.ready()
+ user = info.context.user
+ if user == root.user or user.has_perm(OrderPermissions.MANAGE_ORDERS):
+ return root.invoices... | [OrderEvent->[resolve_lines->[OrderEventOrderLineObject]],Fulfillment->[resolve_meta->[resolve_meta],resolve_private_meta->[resolve_private_meta]],Order->[resolve_meta->[resolve_meta],resolve_private_meta->[resolve_private_meta]]] | Resolve invoices. | How about the service account? |
@@ -669,6 +669,15 @@ class Jetpack {
return esc_url( sprintf( 'https://wordpress.com/%s/%s/%d', $path_prefix, $site_slug, $post_id ) );
}
+ function point_edit_comment_links_to_calypso( $link, $comment_id, $text ) {
+ $url = wp_parse_url( get_home_url() );
+ $html = sprintf( '<a class="comment-edit-link" href=... | [Jetpack->[verify_json_api_authorization_request->[add_nonce],get_locale->[guess_locale_from_lang],admin_notices->[opt_in_jetpack_manage_notice,can_display_jetpack_manage_notice],authenticate_jetpack->[verify_xml_rpc_signature],admin_page_load->[disconnect,unlink_user,can_display_jetpack_manage_notice],wp_rest_authenti... | Link to the Calypso edit page. This function is not terribly important if the plugin is evicted. | I'm pretty sure this is going to break on Jetpack sites with subfolder installs. I suggest following the existing pattern in `point_edit_post_links_to_calypso` to avoid that: `$site_slug = Jetpack::build_raw_urls( get_home_url() );` |
@@ -185,3 +185,9 @@ func (b *APIBackend) GetPoolTransactions() (types.Transactions, error) {
}
return txs, nil
}
+
+// GetBalance returns balance of an given address.
+func (b *APIBackend) GetBalance(address common.Address) (*hexutil.Big, error) {
+ balance, err := b.hmy.nodeAPI.GetBalanceOfAddress(address)
+ retu... | [SubscribeRemovedLogsEvent->[SubscribeRemovedLogsEvent],SubscribeChainSideEvent->[SubscribeChainSideEvent],SubscribeLogsEvent->[SubscribeLogsEvent],SubscribeChainEvent->[SubscribeChainEvent],SubscribeNewTxsEvent->[SubscribeNewTxsEvent],SubscribeChainHeadEvent->[SubscribeChainHeadEvent]] | GetPoolTransactions returns all transactions in the transaction pool. | is there any risk (balance) be nil? |
@@ -617,7 +617,13 @@ export class SystemLayer {
*/
onPageIndexUpdate_(index) {
this.vsync_.mutate(() => {
+ const lastIndex =
+ this.storeService_.get(StateProperty.PAGE_IDS).length - 1;
this.getShadowRoot().classList.toggle('first-page-active', index === 0);
+ this.getShadowRoot().c... | [No CFG could be retrieved] | Private method for updating the component that is attached to the UI. Handles click events on the audio icon and toggles the dialog. | Can we please prefix these classes with `i-amphtml-`? |
@@ -433,7 +433,7 @@ class TestRobots(TestCase):
settings.TASK_USER_ID)
response = self.client.get('/robots.txt')
assert response.status_code == 200
- assert 'Allow: {}'.format(url) in response.content
+ assert b'Allow: {}'.format(url) in response.content
... | [TestCORS->[test_no_cors->[get],test_cors_api_v3->[get],get->[get],test_no_cors_legacy_api->[get],test_cors_api_v4->[get]],TestVersion->[test_version_json->[get]],TestAtomicRequests->[test_post_requests_are_wrapped_in_a_transaction->[_generate_view],test_get_requests_are_not_wrapped_in_a_transaction->[_generate_view,ge... | Make sure Mozilla collections are allowed. | I'm sure bytes don't have a `.format()` method in python 3. I think you should decode `response.content` instead |
@@ -75,6 +75,7 @@ module.exports = LanguagesGenerator.extend({
this.websocket = this.config.get('websocket') === 'no' ? false : this.config.get('websocket');
this.databaseType = this.config.get('databaseType');
this.searchEngine = this.config.get('searchEngine') === 'no' ? false :... | [No CFG could be retrieved] | The main function that is called when the user presses enter to enter a list of supported Get all supported languages. | Not required as this is a new option and doesnt need backward compatibility |
@@ -256,7 +256,8 @@ func InsecureRegistries() []string {
// syncContainerCache runs once at startup to populate the container cache
func syncContainerCache() error {
- log.Debugf("Updating container cache")
+ op := trace.NewOperation(context.Background(), "")
+ defer trace.End(trace.Begin(op.SPrintf("Updating conta... | [AddContainer,GetContainerEndpoints,NewTicker,InitializeImageCache,Info,Done,Add,CreateImageStore,Error,Stop,SplitHostPort,Ping,New,NewPingParamsWithContext,Errorf,NewGetContainerListParamsWithContext,Wait,Bool,Debugf,ShortVersion,Join,NewCreateImageStoreParamsWithContext,Infof,WithBody,NewService,WithAll,WithHandleOrI... | syncContainerCache runs once at startup to populate the container cache with the VIC containers. Mapping returns a mapping between the container and the backend. | You may want to embed the message you're adding on line 261 to this `New...` call. Second, using `trace` `Begin`/`End` like this with an embedded operation call sounds interesting but is it redundant? If it is useful, we may want to create a helper. Popping up a level, what is your intention for this line (261) that yo... |
@@ -208,4 +208,6 @@ class NavierStokesMPISolver_VMSMonolithic(navier_stokes_solver_vmsmonolithic.Nav
self.main_model_part.ProcessInfo.SetValue(KratosMultiphysics.DYNAMIC_TAU, self.settings["dynamic_tau"].GetDouble())
self.main_model_part.ProcessInfo.SetValue(KratosMultiphysics.OSS_SWITCH, self.setting... | [NavierStokesMPISolver_VMSMonolithic->[AddDofs->[print,super,barrier],AddVariables->[print,AddNodalSolutionStepVariable,super,barrier],Initialize->[,SetValue,TrilinosBlockBuilderAndSolver,TrilinosBlockBuilderAndSolverPeriodic,print,CreateCommunicator,TrilinosPredictorCorrectorVelocityBossakSchemeTurbulent,GetComputingM... | Initialize the object. Initialize the builder and the solver. | you could use what I did in StructuralMechanics: `print_on_rank_zero` I think this is more convenient until the logger works in MPI |
@@ -131,11 +131,9 @@ func (td *OsmTestData) AreRegistryCredsPresent() bool {
func (td *OsmTestData) InitTestData(t GinkgoTInterface) error {
td.T = t
- if len(td.ctrRegistryServer) == 0 {
- td.T.Errorf("Did not read any container registry (is CTR_REGISTRY set?)")
- }
+ Expect(verifyValidInstallType(td.instType)).... | [CreateNs->[AreRegistryCredsPresent,GetTestNamespaceSelectorMap],Cleanup->[DeleteNs,GetTestNamespaceSelectorMap]] | InitTestData initializes the test data. | Should we just return an error here instead if this fails so we can tell which test actually failed from the ginkgo back trace? |
@@ -15,6 +15,7 @@ from django.core.exceptions import ValidationError
from django.contrib.auth.models import User, Group, Permission
from django.contrib.contenttypes.models import ContentType
+from celery.signals import task_postrun
import constance.config
from waffle.models import Switch
| [DocumentTests->[_test_m2m_inheritance->[_objects_eq],_test_int_sets_and_descriptors->[_objects_eq]],PageMoveTests->[test_get_descendants_limited->[_make_doc]]] | Check if a given object is contained in a list of objects. Create a group with the negative permission. | Imported but not used. Did you mean to use this in an assertion in `test_render_stale` ? |
@@ -190,4 +190,8 @@ func (d *Data) CopyNonEmpty(src *Data) {
d.ContainerNetworks = src.ContainerNetworks
}
d.Timeout = src.Timeout
+ if src.HTTPProxy != nil || src.HTTPSProxy != nil {
+ d.HTTPProxy = src.HTTPProxy
+ d.HTTPSProxy = src.HTTPSProxy
+ }
}
| [IsSet->[Empty],CopyNonEmpty->[IsSet],Empty->[Empty]] | CopyNonEmpty copies all non - empty fields from the src object into the dest object. | Just for my understanding: is it ok to update both `d.HTTPProxy` and `d.HTTPSProxy` if only one of them is non-nil? |
@@ -59,7 +59,8 @@ namespace Dynamo.Wpf.UI.GuidedTour
/// This property describe which will be the pointing direction of the tooltip (if is a Welcome or Survey popup then is not used)
/// By default the tooltip pointer will be pointing to the left and will be located at the top
/// </summary>
... | [Content->[NewLine,Replace],Step->[Show->[IsOpen],Hide->[IsOpen],TOP_LEFT,CreatePopup]] | The base class for all the components of the n - th group. Show the in the DynamoUI. | Curious if we have to introduce underscore and a different name in Json, can we unify them as much as possible? |
@@ -10,6 +10,12 @@ public class Constant {
public static final String DATABASE_DIR = "storage.directory";
+ // locate in storageDbDirectory, store the db infos,
+ // now only has the snapshot block number
+ public static final String INFO_FILE_NAME = "info.properties";
+ // the block number that split betwee... | [No CFG could be retrieved] | package for testnet mainnet beta The size of the array of bytes that can be written to a ZC file. | mixed use of `snake_case` and `camelCase` keys. |
@@ -126,8 +126,7 @@ public class DubboConfigBindingBeanPostProcessor implements BeanPostProcessor, A
this.applicationContext = applicationContext;
}
- @Override
- public void afterPropertiesSet() throws Exception {
+ public void init() {
if (dubboConfigBinder == null) {
... | [DubboConfigBindingBeanPostProcessor->[afterPropertiesSet->[setIgnoreInvalidFields,setIgnoreUnknownFields]]] | This method is called after the application context has been set. | If we allow to create sub class of this **DubboConfigBindingBeanPostProcessor ** and some **init method** get override then it might cause issue. So better to make init final or provide. What do you say? |
@@ -74,6 +74,7 @@ module View
end
def add_line(data)
+ data[:created_at] = Time.at(data[:created_at])
store(:log, @log << data)
end
end
| [Chat->[add_line->[store],render->[h,add_line,to_i,unsubscribe,post,color_for,strip,store,lambda,subscribe],needs,include],require] | Add a line to the log and store it if it s not already there. | why is this done here? |
@@ -39,7 +39,14 @@ class ReviewerHandler extends PKPReviewerHandler {
}
import('lib.pkp.classes.security.authorization.SubmissionAccessPolicy');
- $this->addPolicy(new SubmissionAccessPolicy($request, $args, $roleAssignments));
+ $router = $request->getRouter();
+ $this->addPolicy(new SubmissionAccessPolicy(... | [ReviewerHandler->[authorize->[getContext,addPolicy,getSetting,_validateAccessKey],_validateAccessKey->[getById,getReviewerId,getContext,getUserSession,getUserVar,getId,getReviewerSubmission,validateKey,getUserId],__construct->[addRoleAssignment]]] | This method is called by the authorization module to authorize the user. | What does this here do? |
@@ -29,7 +29,7 @@
#include "gui/gtk.h"
#include "gui/presets.h"
#include "iop/iop_api.h"
-#include "iop/svd.h"
+#include "iop/gaussian_elimination.h"
#include "libs/colorpicker.h"
#include <assert.h>
#include <math.h>
| [No CFG could be retrieved] | This file is part of darktable. This function is used to populate checker_Lab array. | so you're not using any svd any more but always gaussian elimination? isn't that a lot slower? and what about numerical robustness? |
@@ -228,11 +228,8 @@ public class DruidMasterRuntimeParams
this.loadManagementPeons = Maps.newHashMap();
this.replicationManager = null;
this.emitter = null;
- this.millisToWaitBeforeDeleting = 0;
this.stats = new MasterStats();
- this.mergeBytesLimit = 0;
- this.mergeSegments... | [DruidMasterRuntimeParams->[Builder->[build->[DruidMasterRuntimeParams]],hasDeletionWaitTimeElapsed->[getMillisToWaitBeforeDeleting,getStartTime]]] | Creates a new instance of the ethernet cluster object. This class is used to initialize the object that contains all the data that is needed to be. | have a default constructor with reasonable default values |
@@ -85,6 +85,10 @@ var (
loop *icmpLoop
)
+func noPingCapabilityError(message string) error {
+ return fmt.Errorf(fmt.Sprintf("Insufficient privileges to perform ICMP ping. %s", message))
+}
+
func newICMPLoop() (*icmpLoop, error) {
// Log errors at info level, as the loop is setup globally when ICMP module... | [Stop->[Lock,Unlock],ping->[Stop,NewTimer,NewTicker,sendEchoRequest,Sub],runICMPRecv->[ParseMessage,Unlock,Add,Timeout,Now,String,Lock,ReadFrom,SetReadDeadline],checkNetworkMode->[New,Errorf],sendEchoRequest->[NewBuffer,Write,Unlock,UnixNano,Marshal,Now,WriteTo,Lock,String,Errorf,Intn,Bytes],ListenPacket,Info,runICMPRe... | New returns a struct that represents the contents of a single . NetworkMode is the main loop for ICMP receive. | Not checking for the error? |
@@ -24,7 +24,8 @@ type Config struct {
func defaultConfig() *Config {
return &Config{
- InCluster: true,
- SyncPeriod: 1 * time.Second,
+ InCluster: true,
+ SyncPeriod: 1 * time.Second,
+ CleanupTimeout: 60 * time.Second,
}
}
| [No CFG could be retrieved] | defaultConfig returns a default configuration for the InCluster flag. | I understand to provide a default values for the cleanup, but do we need to change the locking strategy to fix the issue? |
@@ -167,6 +167,14 @@ static int pkey_sm2_ctrl(EVP_PKEY_CTX *ctx, int type, int p1, void *p2)
EC_GROUP_set_asn1_flag(dctx->gen_group, p1);
return 1;
+ case EVP_PKEY_CTRL_SM2_SET_UID:
+ dctx->uid = OPENSSL_strdup(p2);
+ return (dctx->uid != NULL);
+
+ case EVP_PKEY_CTRL_SM2_GET_UID... | [int->[sm2_ciphertext_size,sm2_plaintext_size,sm2_decrypt,EC_GROUP_new_by_curve_name,OBJ_sn2nid,pkey_sm2_init,OBJ_ln2nid,EC_GROUP_dup,EC_GROUP_free,sm2_sign,OPENSSL_zalloc,sm2_encrypt,SM2err,strcmp,EVP_PKEY_CTX_set_ec_paramgen_curve_nid,EVP_PKEY_CTX_set_ec_param_enc,pkey_sm2_cleanup,EC_curve_nist2nid,EC_GROUP_set_asn1_... | private static final int SM2_PKEY_CTX_CHECK = 0 ;. | What if dctx->uid wasn't NULL? Would it be appropriate to free it? |
@@ -0,0 +1,18 @@
+# Generated by Django 3.1.1 on 2020-09-17 15:46
+
+from django.db import migrations, models
+
+
+class Migration(migrations.Migration):
+
+ dependencies = [
+ ("product", "0124_auto_20200909_0904"),
+ ]
+
+ operations = [
+ migrations.AddField(
+ model_name="productva... | [No CFG could be retrieved] | No Summary Found. | Should we migrete old data? |
@@ -53,6 +53,7 @@ namespace Dynamo.Models
private readonly string geometryFactoryPath;
private readonly PathManager pathManager;
private WorkspaceModel currentWorkspace;
+ private Timer backupFilesTimer;
#endregion
#region events
| [DynamoModel->[InitializeNodeLibrary->[InitializeIncludedNodes],ForceRun->[ResetEngine],Paste->[Copy],RemoveWorkspace->[Dispose],ResetEngine->[ResetEngine],ShutDown->[OnShutdownStarted,OnShutdownCompleted],DumpLibraryToXml->[DumpLibraryToXml],ResetEngineInternal->[RegisterCustomNodeDefinitionWithEngine,Dispose],AddWork... | DynamoModel is a base class for all Dynamo objects. It is a base class OnShutdownStarted - called when the if is started. | I thought `fileBackupTimer` would be a more precise name, what do you think? |
@@ -804,6 +804,15 @@ func (f *flow) toEvent(final bool) (ev mb.Event, err error) {
metricset["euid"] = f.process.euid
metricset["egid"] = f.process.egid
}
+
+ if resolver != nil {
+ if domain, found := resolver.ResolveIP(f.pid, f.local.addr.IP); found {
+ local["domain"] = domain
+ }
+ if d... | [ExpireOlder->[Timestamp],createFlow->[String,mutualEnrich],updateWith->[updateWith,getProcess],OnSockDestroyed->[getProcess],UpdateFlowWithCondition->[updateWith,createFlow,String,mutualEnrich],onFlowTerminated->[isValid,String],remove->[Prev,SetNext,SetPrev,Next],toEvent->[String],add->[Prev,SetNext,SetPrev,Next],Str... | toEvent converts a flow into an event. This function returns a MapStr that represents the state of the network network in which the network missing - event - event - event - event - event - event - event - event -. | So does this enrichment happen at the end of the "connection"? I'm thinking about the case of a long running connection where it does an initial DNS query then keeps the connection open for hours. So it might be better to do the enrichment with domain as soon as we have the endpoints of the socket available? |
@@ -65,12 +65,12 @@ function set_availability() {
'missing_plan',
array(
'required_feature' => 'opentable',
- 'required_plan' => 'premium-plan',
+ 'required_plan' => 'value_bundle',
)
);
}
}
-add_action( 'jetpack_register_gutenberg_extensions', __NAMESPACE__ . '\set_availability' );
+... | [No CFG could be retrieved] | This function is used to set the availability of the extension. | This change isn't required for the fix, but it aligns it with the Calendly block for consistency |
@@ -277,12 +277,12 @@ func (handler *ContainersHandlersImpl) GetContainerListHandler(params containers
}
containerVMs := exec.Containers.Containers(state)
- containerList := make([]models.ContainerInfo, 0, len(containerVMs))
+ containerList := make([]*models.ContainerInfo, 0, len(containerVMs))
for _, contain... | [CreateHandler->[NewContainer,GetBuild,Now,NewCreateOK,Error,New,UTC,End,WithPayload,Errorf,MarshalPKCS1PrivateKey,EncodeToMemory,Debugf,Create,Unix,Infof,GenerateKey,NewCreateNotFound,Begin,Background,String,Parse],ContainerWaitHandler->[NewContainerWaitOK,Error,NewContainerWaitNotFound,Begin,WithTimeout,Sprintf,Secon... | GetContainerListHandler - returns list of containers. | This change is here because of the swagger validation change this PR introduces |
@@ -263,7 +263,7 @@ func (backend *ES2Backend) GetProfile(hash string) (reportingapi.Profile, error)
return profile, errors.Wrap(err, "GetProfile, cannot connect to ElasticSearch")
}
- idsQuery := elastic.NewIdsQuery(mappings.DocType)
+ idsQuery := elastic.NewIdsQuery()
idsQuery.Ids(hash)
searchSource := e... | [StoreProfile->[parseInspecProfile],parseInspecProfile->[setDefaultValues],GetProfile->[convertToInspecProfile]] | GetProfile retrieves a single profile by hash. | Need to ensure this change works correctly |
@@ -369,6 +369,13 @@ s32 ChatBuffer::getBottomScrollPos() const
return formatted_count - rows;
}
+void ChatBuffer::resize(u32 scrollback) {
+ m_scrollback = scrollback;
+ if (m_unformatted.size() > m_scrollback)
+ {
+ deleteOldest(m_unformatted.size() - m_scrollback);
+ }
+}
ChatPrompt::ChatPrompt(const std... | [historyPrev->[replace],step->[deleteByAge,step],formatChatLine->[clear],historyNext->[replace],scrollPageDown->[getRows,scroll],getRecentChat->[getLineCount],deleteByAge->[deleteOldest],nickCompletion->[replace],scrollPageUp->[getRows,scroll],clear->[clear],addMessage->[addLine],ChatLine->[getLineCount],addUnparsedMes... | Get the bottom scroll position of the last record in the buffer. | brace on wrong line |
@@ -666,6 +666,8 @@ func (display *ProgressDisplay) processEndSteps() {
wroteDiagnosticHeader := false
for _, row := range display.eventUrnToResourceRow {
+ wroteResourceHeader := false
+
for id, payloads := range row.DiagInfo().StreamIDToDiagPayloads {
if len(payloads) > 0 {
if id != 0 {
| [filterOutUnnecessaryNodesAndSetDisplayTimes->[filterOutUnnecessaryNodesAndSetDisplayTimes],processEvents->[processNormalEvent,processEndSteps,processTick],processEndSteps->[refreshAllRowsIfInTerminal,writeSimpleMessage,refreshSingleRow,writeBlankLine],handleSystemEvent->[refreshAllRowsIfInTerminal,writeSimpleMessage],... | processEndSteps is called when the end of the processing of the progress steps. This function splits the given message into lines that can be displayed. Write a simple message to the screen. | this was the original intent of the code here. We iterate over each resource so that all the messages are grouped by resource. The intent was that if we then had any diagnostics to show for that resource, we would print out its name once, then all the diags. but my logic was bad (or this got munged around over time), a... |
@@ -185,6 +185,11 @@ func ComputeCurrentSigning(
}
s1, s2 := numeric.NewDecFromBigInt(signed), numeric.NewDecFromBigInt(toSign)
+ if s2.IsNil() || s2.IsZero() {
+ // Shouldn't happen
+ utils.Logger().Debug().Interface("toSign", toSign).Msg("s2 is nil or zero")
+ return computed
+ }
computed.Percentage = s1.Q... | [IndexEnabled,ShardID,LTE,ValidatorWrapper,LastCommitBitmap,Info,Add,NewComputed,Error,Quo,SetMask,Cmp,New,FindCommitteeByID,Sub,Logger,Debug,Sign,ReadValidatorSnapshot,NewMask,BLSPublicKeys,Str,NewDecFromBigInt,Msg,NewDec,ZeroDec,UpdateValidatorWrapper,String,WithCause,Number] | ComputeCurrentSigning returns the current signing number for a given network address. computeForAvailability computes the current signing for a validator. | Should remove this, if this is violated, then we should find out asap and I did from the stack trace last time (that something was iffy) |
@@ -166,4 +166,4 @@ class Predictor(Registrable):
model = archive.model
model.eval()
- return Predictor.by_name(predictor_name)(model, dataset_reader)
+ return Predictor.by_name(predictor_name)(model, dataset_reader)
\ No newline at end of file
| [Predictor->[_batch_json_to_instances->[_json_to_instance],capture_model_internals->[add_output]]] | Instantiate a Predictor from an Archive. | Add newline at end of file. |
@@ -135,9 +135,9 @@ public class TransactionalExecutionTemplateTestCase extends AbstractMuleTestCase
MuleTransactionConfig config = new MuleTransactionConfig(TransactionConfig.ACTION_NONE);
ExecutionTemplate executionTemplate = createExecutionTemplate(config);
Object result = executionTemplate.execute(ge... | [TransactionalExecutionTemplateTestCase->[unbindTransaction->[unbindTransaction],getEmptyTransactionCallback->[getEmptyTransactionCallback],getRollbackTransactionCallback->[getRollbackTransactionCallback]]] | Test action none and tx for rollback. | commit AND rollback? |
@@ -170,7 +170,7 @@ public class TypeAndReferenceSolverTest {
assertThat(annotation5.values().size()).isEqualTo(2);
assertThat(annotation5.values().get(0).name()).isEqualTo("expr1");
assertThat(annotation5.values().get(1).name()).isEqualTo("expr2");
- // TODO(merciesa): check values 'expr1' and 'expr... | [TypeAndReferenceSolverTest->[TestedNodeExtractor->[visitMethod->[visitMethod]]]] | Test for completion of annotation. | This check should be already doable. |
@@ -46,3 +46,6 @@ class BaseRepresentation(abc.ABC):
def set_additional_data_source(self, source):
self.metadata['additional_data_source'] = source
+
+ def set_dataset_metadata(self, source):
+ self.metadata.update(source)
| [BaseRepresentation->[dump->[dump],load->[isinstance,load]]] | Set the additional data source. | on my view better to add key `dataset_meta` and put in this field, in your solution, possible intersection and overriding original meta keys on datasets meta values |
@@ -95,10 +95,10 @@ WRITE8_MEMBER(stlforce_state::oki_bank_w)
void stlforce_state::stlforce_map(address_map &map)
{
map(0x000000, 0x03ffff).rom();
- map(0x100000, 0x1007ff).ram().w(FUNC(stlforce_state::bg_videoram_w)).share("bg_videoram");
- map(0x100800, 0x100fff).ram().w(FUNC(stlforce_state::mlow_videoram_w)).sha... | [No CFG could be retrieved] | region Private functions - > Input Port - > Device. | Does this device have a standard memory layout? Should it expose a device map? |
@@ -54,7 +54,7 @@ void MoveMesh(const ModelPart::NodesContainerType& rNodes) {
for (int i=0; i<num_nodes; i++) {
const auto it_node = nodes_begin + i;
noalias(it_node->Coordinates()) = it_node->GetInitialPosition()
- + it_node->FastGetSolutionStepValue(MESH_DISPLACEMENT);
+ ... | [CheckJacobianDimension->[IntegrationPoints,size,resize,KRATOS_CATCH,GetDefaultIntegrationMethod],MoveMesh->[Coordinates,size,KRATOS_CATCH,begin,FastGetSolutionStepValue,noalias,GetInitialPosition],GenerateMeshPart->[Create,ElementsBegin,pGetGeometry,Nodes,KRATOS_CATCH,Name,GetModel,Id,push_back,Elements,pGetProperties... | MoveMesh - Move mesh from the start to the end of the mesh. | this should be discussed in a separate PR |
@@ -597,8 +597,7 @@ def format_time(t):
def format_timedelta(td):
"""Format timedelta in a human friendly format
"""
- # Since td.total_seconds() requires python 2.7
- ts = (td.microseconds + (td.seconds + td.days * 24 * 3600) * 10 ** 6) / float(10 ** 6)
+ ts = td.total_seconds()
s = ts % 60
... | [get_cache_dir->[write,get_home_dir],BaseFormatter->[format_item->[get_item_data]],Location->[to_key_filename->[get_keys_dir],parse->[replace_placeholders,match],_parse->[match]],open_item->[ChunkIteratorFileWrapper],format_archive->[format_time,to_localtime],dir_is_tagged->[dir_is_cachedir],ChunkIteratorFileWrapper->[... | Format a timedelta in a human friendly format. | now that is embarrassing. :D |
@@ -1927,6 +1927,13 @@ def random_hue(image, max_delta, seed=None):
`max_delta` must be in the interval `[0, 0.5]`.
+ Usage Example:
+ ```python
+ >> import tensorflow as tf
+ >> x = tf.random.normal(shape=(256, 256, 3))
+ >> y = tf.image.random_hue(x, max_delta=0.1)
+ ```
+
Args:
image: RGB imag... | [resize_image_with_pad_v2->[_resize_fn->[resize_images_v2],_resize_image_with_pad_common],encode_png->[encode_png],_resize_images_common->[_ImageDimensions],resize_bicubic->[resize_bicubic],crop_to_bounding_box->[_assert,_ImageDimensions,_CheckAtLeast3DImage,_is_tensor],resize_image_with_crop_or_pad->[max_->[_is_tensor... | Adjust the hue of RGB images by a random factor. | No need for import tensorflow as tf Seed the random operations and use small images so it becomes a valid doctest. |
@@ -1139,9 +1139,9 @@ namespace System.Text.RegularExpressions
Ldloc(_runtextposLocal);
Ldloc(_runtextendLocal);
Beq(l2);
- Ldthisfld(s_runtextField);
+ ... | [RegexCompiler->[Switch->[Switch],Ldstr->[Ldstr],GenerateBacktrackSection->[MarkLabel],Ldloc->[Ldloc],Rightchar->[Ldloc,Call],Stfld->[Stfld],Mul->[Mul],PopStack->[Ldc,Ldloc,LdelemI4,Add,Stloc],Goto->[MarkLabel,AddGoto,BgtFar,Ldloc,Ldc,BrFar,Ble,ReadyPushTrack,DoPush],AddUniqueTrack->[AddUniqueTrack,AddTrack],Ldloca->[L... | GenerateFindFirstChar - Generate the first occurrence of a character in the runtext. Check if there is a node with a matching label in the tree. Returns true if there is no further anchor checks and false if there is no anchor checks. | Does this work? I would have expected this to need to be `Ldloca`? |
@@ -20,8 +20,8 @@ import (
const (
tablePrefix = "cortex_"
chunkTablePrefix = "chunks_"
- tablePeriod = 7 * 24 * time.Hour
- gracePeriod = 15 * time.Minute
+ tablePeriod = model.Duration(7 * 24 * time.Hour)
+ gracePeriod = model.Duration(15 * time.Minute)
maxChunkAge = 12 * time.Hou... | [DescribeScalingPoliciesWithContext->[Float64,Int64],DescribeScalableTargetsWithContext->[String,Int64],Unix,Sprint,NowReset,SyncTables,Background,TimeFromUnix,ExpectTables,NoError,Fatal,NewTableManager,Run,Add,NowForce] | Package that imports a single chunk. baseTable returns a function that creates a chunk. ProvisionConfig object from the given parameters. | As far as I can see this is always cast to a `time.Duration` so why not leave it as that? |
@@ -302,7 +302,12 @@ const Recording = {
if (config.iAmRecorder) {
VideoLayout.enableDeviceAvailabilityIcons(
APP.conference.getMyUserId(), false);
- VideoLayout.setLocalVideoVisible(false);
+
+ // in case of iAmSipGateway keep local video visible
+ ... | [No CFG could be retrieved] | Manages the user interface and user experience. Shows or hides the button of the record button. | Out of curiosity, does this work if you just do VideoLayout.setLocalVideoVisible(config.iAmSipGateway)? It'd be nice to get rid of a conditional statement but I believe there's a bug in LocalVideo#setVisible because it always toggles the hidden class when called, regardless of the boolean value passed in. |
@@ -18,7 +18,7 @@
/**
* @typedef {{
- * type: (string|undefined),
+ * type: (!string),
* endpoint: (string|undefined),
* params: (JsonObject|Object|undefined),
* target: (string|undefined),
| [No CFG could be retrieved] | Component that provides a list of properties that can be used to show a specific . | @dvoytenko I updated this to non-nullable string. Is this what you meant by `strict string`? |
@@ -168,6 +168,7 @@ class ConversionScript(ParlaiScript):
# 3. Map other options
transformer_common_config.update(
{
+ 'datatype': 'valid', # don't save an optimizer
'model': self.opt['model'],
# number of layers
'n_encode... | [ConversionScript->[load_fairseq_checkpoint->[_load_single_fairseq_checkpoint]]] | Parse ParlAI options for parsing fairseq arguments. Get an optional configuration for a single node. | This is a little weird as it doesn't seem obvious that saving datatype as valid will always exclude _only_ the optimizer. And it's not obvious that there won't be any other effects. Is it possible to just explicitly remove the optimizer in `load_fairseq_checkpoint`? |
@@ -1416,7 +1416,10 @@ function PMA_RTN_handleExecute()
$GLOBALS['dbi']->freeResult($result);
- } while ($GLOBALS['dbi']->nextResult());
+ } while ($outcome = $GLOBALS['dbi']->nextResult());
+ }
+
+ if ($outcome) {
$output .= "</fieldset>";
| [PMA_RTN_handleRequestCreateOrEdit->[tryQuery,addParam,setRequestStatus,addHtml,getError,getRoutines,isSuccess,addJSON,getDefinition],PMA_RTN_handleExecute->[getDisplay,setRequestStatus,isError,tryMultiQuery,numRows,getFieldsMeta,getError,fetchAssoc,getAllFunctions,isSuccess,addJSON,nextResult,freeResult,storeResult,mo... | Handle the execute of a single node of a node type This function executes the SQL queries that set or get a single node in the system and returns This function returns HTML code for a object. Handle a failure of a node in the system RTE_getWord return not found node. | $outcome will be always false at the end of this loop, is this really what you wanted to achieve? |
@@ -516,6 +516,11 @@ namespace System.IO.Compression
extraFieldLength = (ushort)bigExtraFieldLength;
}
+ if (_hasUnicodeEntryNameOrComment)
+ _generalPurposeBitFlag |= BitFlagValues.UnicodeFileNameAndComment;
+ else
+ _generalPurposeBit... | [ZipArchiveEntry->[WriteCrcAndSizesInLocalHeader->[SizesTooLarge],Stream->[ThrowIfNotOpenable],WriteLocalFileHeaderAndDataIfNeeded->[WriteLocalFileHeader],IsOpenable->[ToString],DirectToArchiveWriterStream->[Flush->[Flush,ThrowIfDisposed],WriteByte->[Write],Dispose->[WriteCrcAndSizesInLocalHeader,Dispose,WriteDataDescr... | Writes a sequence of bytes representing the header of the central directory file. Private methods. Truncated - writes all the data that is not part of the archive. | OK, I guess this is the reason why you stopped setting this flag in set_FullName. |
@@ -113,8 +113,11 @@ def _fill_info(vtimebase, vfps, vduration, atimebase, asample_rate, aduration):
return meta
-def _align_audio_frames(aframes, aframe_pts, audio_pts_range):
- # type: (torch.Tensor, torch.Tensor, List[int]) -> torch.Tensor
+def _align_audio_frames(
+ aframes: torch.Tensor,
+ aframe... | [_read_video_timestamps_from_memory->[_fill_info],_read_video_timestamps_from_file->[_fill_info],_probe_video_from_memory->[_fill_info],_fill_info->[Timebase,VideoMetaData],_read_video_from_file->[_validate_pts,_fill_info,_align_audio_frames],_read_video_timestamps->[_read_video_timestamps_from_file],_read_video_from_m... | Align audio frames. | Are we sure that's a Tensor and not a tuple of ints? |
@@ -0,0 +1,9 @@
+module SignUp
+ class CompletionsController < ApplicationController
+ def show; end
+
+ def update
+ redirect_to session[:saml_request_url]
+ end
+ end
+end
| [No CFG could be retrieved] | No Summary Found. | Could we add an analytics call here to track how many users see this page, and pass in the `session[:sp][:loa3]` and `@sp_name` attributes? |
@@ -124,7 +124,7 @@ class MyModulesController < ApplicationController
start_date_changes = @my_module.changes[:started_on]
due_date_changes = @my_module.changes[:due_date]
- if @my_module.completed_changed? && !can_complete_my_module?(@my_module)
+ if @my_module.completed_on_changed? && !can_complete_... | [MyModulesController->[results->[results],update_state->[update],log_due_date_change_activity->[due_date],my_module_annotation_notification->[description],update_protocol_description->[description,update],update_description->[description,update],protocol_annotation_notification->[description]]] | update a node node check if the user has a one - day prior in order to show a header or a. | Style/IfUnlessModifier: Favor modifier if usage when having a single-line body. Another good alternative is the usage of control flow &&/||. |
@@ -182,6 +182,10 @@ class RemoteBASE(object):
for checksum in checksums:
entry = dir_info[checksum]
entry[self.PARAM_CHECKSUM] = checksum.result()
+ return dir_info
+
+ def _collect_dir(self, path_info):
+ dir_info = self._get_dir_info(path_info)
... | [RemoteBASE->[all->[path_to_checksum,list_cache_paths],remove->[RemoteActionNotImplemented],changed_cache->[is_dir_checksum,changed_cache_file,_changed_dir_cache],upload->[RemoteActionNotImplemented],copy->[RemoteActionNotImplemented],move->[remove],download->[RemoteActionNotImplemented],gc->[all,checksum_to_path_info,... | Collect all files in a directory and return a list of tuples. Missing checksum. | I don't see a point in splitting this into two functions, especially because the next sorting doesn't make much sense separately. |
@@ -39,7 +39,11 @@
<% element = element.to_s %>
<% if(json_object[element].present?) %>
- <% if element == 'tags' %>
+ <% if element == 'published_on' %>
+ <% translation_string = 'protocols.protocols_io_import.preview.' + element %>
+ <stron... | [No CFG could be retrieved] | XML - Element tag length careful! i think this is a hack!. | Sorry, indent Nazi - probably this block here can be de-indented for 2 spaces? |
@@ -200,14 +200,14 @@ func (r *Registrar) getPreviousFile(newFilePath string, newFileInfo os.FileInfo)
return "", fmt.Errorf("No previous file found")
}
-func (r *Registrar) setState(path string, state *FileState) {
+func (r *Registrar) setState(path string, state FileState) {
r.stateMutex.Lock()
defer r.state... | [setState->[Lock,Unlock],fetchState->[getPreviousFile,IsSameFile,GetFileState,Info,Debug],getPreviousFile->[getStateCopy,GetOSFileState,Errorf,Info,IsSame],getStateCopy->[Lock,Unlock],Stop->[Info],getState->[Lock,Unlock],Init->[Dir,Resolve,Errorf,Info,MkdirAll],processEvents->[setState,GetState,Debug],LoadState->[Info,... | getPreviousFile returns the previous file path that is not the same as the new file path. | map[string]FilesState is behaving like pass-by-reference (pointer). This intended? |
@@ -59,9 +59,14 @@ public class UdfLoaderTest {
private final Metrics metrics = new Metrics();
private final UdfLoader pluginLoader = createUdfLoader(metaStore, true, false);
+ private KsqlConfig ksqlConfig;
+
@Before
public void before() {
pluginLoader.load();
+ PASSED_CONFIG = null;
+
+ ksql... | [UdfLoaderTest->[shouldCreateUdfFactoryWithInternalPathWhenInternal->[getUdfFactory,assertThat,equalTo,getPath],shouldPutKsqlFunctionsInParentClassLoader->[newInstance,equalTo,getActualUdfClassLoader,getUdfFactory,assertThat],shouldCreateUdfFactoryWithJarPathWhenExternal->[getUdfFactory,assertThat,equalTo,getPath],shou... | Test method to load functions in ksql engine. | Can we just initialize this and the `KsqlConfig` at the field level? |
@@ -153,7 +153,7 @@ class Covariance(dict):
"""
check_fname(fname, 'covariance', ('-cov.fif', '-cov.fif.gz',
'_cov.fif', '_cov.fif.gz'))
-
+ fname = _check_fname(fname=fname, overwrite=True)
fid = start_file(fname)
try:
| [make_ad_hoc_cov->[Covariance],compute_raw_covariance->[Covariance,_check_n_samples],_RegCovariance->[score->[score],fit->[fit,Covariance],get_precision->[get_precision]],_smart_eigh->[_get_ch_whitener,_eigvec_subspace,Covariance],write_cov->[save],Covariance->[__iadd__->[_check_covs_algebra],plot_topomap->[plot_topoma... | Save the covariance matrix in a FIF file. | +1 for in this PR changing any of these to `overwrite=overwrite` here and `overwrite=False` in the function signature as a bugfix. But if you don't want to do it here we can do it later with this as a nice template for some places that need it |
@@ -238,7 +238,7 @@ func do(appEnvObj interface{}) error {
var success bool
select {
case <-exitCh:
- return nil
+ return fmt.Errorf("chunk was revoked; restarting")
case success = <-cmdCh:
}
var outputMount *fuse.CommitMount
| [Pull,NewInternalPodAPIClientFromAddress,Exit,RunFixedArgs,Error,NewMounter,New,Go,Tick,NewFromAddress,Errorf,Wait,Main,Join,Execute,StartPod,MkdirAll,Command,Sys,Printf,Fprintf,Println,NewReader,Sprintf,Background,FinishPod,ExitStatus,MultiReader,Unmount,SetLevel,MountAndCreate,ContinuePod,Run,Push] | check if the has already been processed and if so execute it. Returns a reference to the current page. | It seems a little weird that we log this above and returns this as an error, which will presumably lead to it getting logged a second time by the calling code. It seems like if we get an explicit restart then we'll log it twice but if the call to `ContinuePod` errors we'll log it once. Seems a little weird. Also the me... |
@@ -910,7 +910,7 @@ class OptimizerV2(trackable.Trackable):
return value()
if tensor_util.is_tensor(value):
return backend.get_value(value)
- return value
+ return float(value)
def variables(self):
"""Returns variables of this Optimizer based on the order created."""
| [_get_slot_key_from_var->[_var_key],OptimizerV2->[_create_all_weights->[_create_slots],__getattribute__->[_get_hyper],_compute_gradients->[_clip_gradients],get_updates->[apply_gradients,get_gradients],_resource_apply_sparse_duplicate_indices->[_deduplicate_indexed_slices],__setattr__->[_set_hyper],get_gradients->[_clip... | Serialize a hyperparameter that can be a float callable or Tensor. | Not sure why this is included in this PR. |
@@ -221,7 +221,7 @@ public class IntraBundleParallelization {
}
if (failure.get() != null) {
- throw Throwables.propagate(failure.get());
+ throw new RuntimeException(failure.get());
}
executor.submit(new Runnable() {
| [IntraBundleParallelization->[of->[of],Unbound->[withMaxParallelism->[Unbound]],Bound->[populateDisplayData->[populateDisplayData],apply->[of,apply]],MultiThreadedIntraBundleProcessingDoFn->[getInputTypeDescriptor->[getInputTypeDescriptor],getOutputTypeDescriptor->[getOutputTypeDescriptor],processElement->[run->[proces... | Process an element. | Also replace the Throwables.propagateIfPossible on line 234? |
@@ -0,0 +1,13 @@
+package com.baeldung.sparkjava;
+
+import java.util.Collection;
+import java.util.HashMap;
+
+public interface UserService {
+ public void addUser (User user) ;
+ public Collection<User> getUsers () ;
+ public User getUser (String id) ;
+ public User editUser (String id, HashMap userArg) t... | [No CFG could be retrieved] | No Summary Found. | 1. Change HashMap to Map (program to the interface, not to the implementation). Or consider that it is more common in a REST service for the PUT operation to accept an entire JSON object instead of only the fields to be changed like you do here using the Map, and instead you can just implement it as public void User ed... |
@@ -155,7 +155,7 @@ public abstract class TableManipulationConfigurationBuilder<B extends AbstractJd
@Override
public TableManipulationConfiguration create() {
- return new TableManipulationConfiguration(attributes.protect());
+ return new TableManipulationConfiguration(attributes.protect(), batchSi... | [TableManipulationConfigurationBuilder->[read->[attributes,read]]] | Creates a new TableManipulationConfiguration with the specified attributes. | Sadly this didn't come out as well I would have hoped, but it seems a little better. Unfortunately due to the disconnectedness of the builders, there seems to be no way to pass the value back. This is fine though, we just need to make sure to remove this in 10.0 :) |
@@ -778,7 +778,7 @@ func (t *BaseOperations) MountLabel(ctx context.Context, label, target string) e
fi, err := os.Stat(target)
if err != nil {
// #nosec
- if err := os.MkdirAll(target, 0744); err != nil {
+ if err := os.MkdirAll(target, 0755); err != nil {
// same as MountFileSystem error for consistency
... | [RouteDel->[RouteDel],LinkSetAlias->[LinkSetAlias],AddrDel->[AddrDel],LinkSetUp->[LinkSetUp],dhcpLoop->[Apply],RouteAdd->[RouteAdd],AddrAdd->[AddrAdd],RuleList->[RuleList],LinkBySlot->[LinkByName],AddrList->[AddrList],LinkSetDown->[LinkSetDown],LinkSetName->[LinkSetName],LinkByName->[LinkByName],updateNameservers,Route... | MountLabel mounts a device with the specified label on the specified target. Mount filesystem directly if there is no data directory in volume. | if we are changing all of these to `0755` could you make a constant for that value. |
@@ -179,9 +179,6 @@ def setup_logging(
# logging control and we don't need to be the middleman plumbing an option for each python
# standard logging knob.
- log_filename = None
- file_handler = None
-
# A custom log handler for sub-debug trace logging.
def trace(self, message, *args, **kwarg... | [create_native_stderr_log_handler->[NativeHandler],_maybe_configure_extended_logging->[_configure_requests_debug_logging],setup_logging->[_maybe_configure_extended_logging,FileLoggingSetupResult,create_native_pantsd_file_log_handler],create_native_pantsd_file_log_handler->[NativeHandler]] | Configures logging for a given n - node. Setup logging for a specific critical node. | These were unused |
@@ -92,7 +92,7 @@ class AdminConsumerSection(PulpCliSection):
unbind_command.add_option(PulpCliOption('--consumer-id', 'consumer id', required=True))
unbind_command.add_option(PulpCliOption('--repo-id', 'repository id', required=True))
unbind_command.add_option(PulpCliOption('--distributor-id... | [UpdateContent->[run->[update],update->[postponed,rejected,process,update],__init__->[__init__]],AdminConsumerSection->[update->[update],unbind->[unbind],history->[history],unregister->[unregister],install->[install],_parse_notes->[InvalidConfig],__init__->[__init__],search->[search],bind->[bind]],UninstallContent->[un... | Initialize the object Adds commands to list and display a specific consumer. Add history command to list entries. | Needs gettext on the description |
@@ -390,7 +390,7 @@ static void *HandleConnection(ServerConnectionState *conn)
ConnectionInfoProtocolVersion(conn->conn_info));
}
- Log(LOG_LEVEL_INFO, "Connection from %s is closed, terminating thread",
+ Log(LOG_LEVEL_INFO, "Connection closed, terminating thread",
conn->... | [void->[ServerTLSSessionEstablish,strlcpy,ConnectionInfoProtocolVersion,ThreadUnlock,pthread_attr_destroy,ThreadLock,DisableSendDelays,pthread_attr_setdetachstate,ConnectionInfoDestroy,ConnectionInfoSocket,SendTransaction,DeleteItemMatching,pthread_attr_init,GetErrorStr,DeleteConn,cf_closesocket,ConnectionInfoConnectio... | This method is called when a connection is not available in the system. This function checks if a connection is established and if so returns it. If it is closed. | If you're getting rid of the formatter that used it, you should get rid of conn->ipaddr as well ! |
@@ -3488,7 +3488,7 @@ public class UserVmManagerImpl extends ManagerBase implements UserVmManager, Vir
s_logger.debug("Creating network for account " + owner + " from the network offering id=" + requiredOfferings.get(0).getId() + " as a part of deployVM process");
Network newNetwork = _networkMgr.crea... | [UserVmManagerImpl->[removeInstanceFromInstanceGroup->[expunge],applyUserData->[getName],moveVMToUser->[doInTransactionWithoutResult->[getName,resourceCountIncrement,resourceCountDecrement],removeInstanceFromInstanceGroup,resourceLimitCheck,getName,getVmId,getSecurityGroupIdList],getNetworkForOvfNetworkMapping->[getDef... | Create a default network for the given account. | I see most of the calls, routerips are passed _null_ , can you add another public method with routerip params and use it wherever required ? |
@@ -14,7 +14,7 @@
* along with this program. If not, see <http://www.gnu.org/licenses/>.
*/
-#if defined(RGB_BACKLIGHT_ZEAL60) || defined(RGB_BACKLIGHT_ZEAL65) || defined(RGB_BACKLIGHT_M60_A) || defined(RGB_BACKLIGHT_M6_B) || defined(RGB_BACKLIGHT_KOYU) || defined(RGB_BACKLIGHT_HS60) || defined(RGB_BACKLIGHT_NK6... | [No CFG could be retrieved] | Containing functions for the n - tuple types. Hardware related functions. | For consistency with the amended `#if` directive above you should add `, RGB_BACKLIGHT_DAWN60` to the end of this `#error` directive. |
@@ -38,7 +38,7 @@ import org.jboss.logging.annotations.MessageLogger;
* so an INFO message would be 191000 to 191999
*/
@MessageLogger(projectCode = "AMQ")
-public interface ActiveMQVertxLogger extends BasicLogger {
+interface ActiveMQVertxLogger extends BasicLogger {
/**
* The vertx logger.
| [getMessageLogger,getName] | The ActiveMQVertxLogger class provides a way to log a message in the vertx. | I don't see a reason to remove the public here, why? |
@@ -1434,7 +1434,7 @@ class MultiHeadAttention(nn.Module):
out = self.out_lin(attentioned)
- return out, new_incr_state
+ return out, new_incr_state, dot_prod
def reorder_incremental_state(
self, incremental_state: Dict[str, torch.Tensor], inds: torch.Tensor
| [TransformerEncoderLayer->[forward->[_normalize]],MultiHeadAttention->[forward->[prepare_head]],TransformerEncoder->[forward->[_normalize,forward_layers,reduce_output,forward_embedding],__init__->[create_position_codes]],TransformerGeneratorModel->[build_decoder->[TransformerDecoder],reorder_decoder_incremental_state->... | Forward pass of attention. The tensor q k v of the n - heads of the n - heads of the n Output a new state for the key - missing missing weights and attention. Reorder the input incremental - state tensors. | could we maybe make this a flag? i.e. whether to return the dotprod or not? I know you covered most of the cases where this might arise but it might be easier to future proof with a flag (i.e. perhaps there are some internal agents that use MHA and will now break?) |
@@ -5,6 +5,15 @@ require 'lib/hex'
module Lib
module Settings
DARK = `window.matchMedia('(prefers-color-scheme: dark)').matches`.freeze
+ # http://mkweb.bcgsc.ca/colorblind/ 12 color palette
+ ROUTE_COLORS = %i[#A40122 #008DF9 #00FCCF #FF5AAF].freeze
+
+ routes = {}
+ ROUTE_COLORS.each_with_index d... | [included->[needs],setting_for->[dig],freeze,require] | Initialize a new object with a default name and a default value. | can we again not use lower case for constants, and similarly do ROUTES = ROUTE_COLERS.flat_map.with_index do |color, n| [["r#{n}_color, color]...] end.to_h something like that |
@@ -218,12 +218,12 @@ namespace NServiceBus.MessageInterfaces.MessageMapper.Reflection
{
if (!interfaceType.IsVisible)
{
- throw new Exception($"Can only generate a concrete implementation for '{interfaceType}' if '{interfaceType}' is public.");
+ throw n... | [MessageMapper->[GenerateImplementationFor->[Any,GetConstructor,TypeHandle,IsSpecialName,CreateTypeFrom,IsVisible,Name,MethodHandle,EmptyTypes,StartsWith],InnerInitialize->[IsSimpleType,TypeHandle,InitType,MethodHandle,IsGenericTypeDefinition,GetConstructor,IsAssignableFrom,ContainsKey,EmptyTypes,FieldType,GetTypeName,... | GenerateImplementationFor generates a concrete implementation for the given interface type. | writing the unit tests, I noticed that we're using `{interfaceType.Name}` here but just `{interfaceType}` for the private interface exception message on line 221. Should we clarify this and probably use `{interfaceType.Name.FullName}` in both cases? |
@@ -2358,9 +2358,14 @@ public class Processor extends Domain implements Reporter, Registry, Constants,
public static Pattern toFullHeaderPattern(String header) {
StringBuilder sb = new StringBuilder();
- sb.append("^\\s*(").append(header).append(")(\\.[^\\s:=]*)?\\s*[\\s|:|=]\\s*");
+ sb.append("^[ \t]*(").app... | [Processor->[warning->[current],loadProperties->[close,loadProperties,error],replaceAll->[replaceAll],_native_capability->[append,join,getProperty,split],getLoader->[CL],progress->[progress],isOk->[isFailOk],customize->[error],getMergedParameters->[mergeProperties],refresh->[getProperty],join->[join],CL->[loadClass->[l... | This method converts a header string into a pattern that matches all the lines in the header. | Did you mean to leave one "\s" unconverted to " \t"? |
@@ -0,0 +1,10 @@
+package io.netty.channel.uring;
+
+import io.netty.channel.socket.ServerSocketChannelConfig;
+
+public class IOUringServerSocketChannelConfig extends IOUringServerChannelConfig implements ServerSocketChannelConfig {
+
+ IOUringServerSocketChannelConfig(AbstractIOUringServerChannel channel) {
+ ... | [No CFG could be retrieved] | No Summary Found. | Why you can't use DefaultServerSocketChannelConfig ` |
@@ -83,6 +83,15 @@ export class Toolbar {
} else {
this.hideToolbar_();
}
+
+ // Use the placeholder to fill the height of the toolbar
+ this.vsync_.mutate(() => {
+ if (this.placeholder_) {
+ setStyles(this.placeholder_, {
+ 'height': this.toolbarClone_./*REVIEW*/offsetHeigh... | [No CFG could be retrieved] | Private function to build the DOM element for the toolbar. Function to attempt to show the toolbar and hide toolbar - only element in the sidebar. | This should be done in attempt show , you dont want to display the compensatingElement when toolbar is hidden. 1. Check if there is a compensation element , if not create one and assign the height 2. else just assign the height 3. When you close the toolbar this has to be hidden |
@@ -31,10 +31,10 @@ class TestVideoGPUDecoder:
decoder = VideoReader(full_path, device="cuda:0")
with av.open(full_path) as container:
for av_frame in container.decode(container.streams.video[0]):
- av_frames = torch.tensor(av_frame.to_ndarray().flatten())
+... | [TestVideoGPUDecoder->[test_frame_reading->[tensor,_reformat,to_ndarray,mean,decode,join,float,open,VideoReader,next,abs],skipif],skipif,abspath,dirname,join,main] | Test frame reading. | I generally dislike performing the comparisons as the mean over the whole tensor because it can completely allow for having a whole section of the image to be all black / white / random (which is btw an existing issue with the current CPU video reader cc @bjuncek ) I would add a TODO here to try to use a different func... |
@@ -171,13 +171,11 @@ else:
# Note, get_default_urls() and get_rc_urls() return unnormalized urls.
def get_default_urls():
- if isfile(sys_rc_path):
- sys_rc = load_condarc(sys_rc_path)
- if 'default_channels' in sys_rc:
- return sys_rc['default_channels']
-
- return ['http://repo.con... | [get_default_urls->[load_condarc],get_allowed_channels->[get_default_urls,normalize_urls],_pathsep_env->[_default_envs_dirs],normalize_urls->[get_default_urls,normalize_urls,is_url,binstar_channel_alias,get_rc_urls],canonical_channel_name->[hide_binstar_tokens,get_default_urls,remove_binstar_tokens],get_channel_urls->[... | Get default urls for the condarc package. | For the record, I implemented this independently, only without the addition of the default_channels, which is superfluous (a user can add the defaults by adding a `defaults` channel). |
@@ -1176,11 +1176,12 @@ class TestParseSearch(TestCase, amo.tests.AMOPaths):
def test_basics(self):
# This test breaks if the day changes. Have fun with that!
- assert self.parse(), {
+ assert self.parse() == {
'guid': None,
- 'name': 'search tool',
+ 'na... | [TestTrackFileStatusChange->[test_track_stats_on_updated_file->[create_file],test_increment_file_status->[create_file],test_track_stats_on_new_file->[create_file],test_ignore_non_status_changes->[create_file],test_increment_jetpack_sdk_only_status->[create_file]],TestParseAlternateXpi->[test_no_manifest_node->[parse],t... | Test basics. | Yes, that test was almost useless (through `parse()` can raise exceptions, so it was not entirely horrible) |
@@ -30,6 +30,7 @@ public class ParameterDTO {
private Boolean sensitive;
private String value;
private Boolean valueRemoved;
+ private boolean provided;
private Set<AffectedComponentEntity> referencingComponents;
private ParameterContextReferenceEntity parameterContext;
private Boolean ... | [No CFG could be retrieved] | Returns the name of the parameter. | Generally we want to use Boolean objects instead of primitives in DTOs as a way to differentiate between the value being unset and being false. |
@@ -74,9 +74,9 @@ namespace Dynamo.LibraryUI.Handlers
protected virtual object CreateObjectForSerialization(IEnumerable<NodeSearchElement> searchEntries)
{
var data = new LoadedTypeData<LoadedTypeItem>();
- data.loadedTypes = searchEntries
- //.Where(e => !e.Elem... | [NodeItemDataProvider->[T->[GetFullyQualifiedName]]] | Create object for serialization. | ~~why was this condition removed?~~ ~~`!e.ElementType.HasFlag(ElementTypes.Packaged))`~~ |
@@ -33,7 +33,9 @@ class PartnerWelcomeScreen extends Component {
if (this.props.settings.referralCode) {
// We want to direct the user directly to dapp onboarding
const url = new URL(this.props.settings.network.dappUrl)
- url.hash = '/onboard'
+ url.hash =
+ '/onboard?referralCode=' ... | [No CFG could be retrieved] | Component that is used to show a welcome screen on the partner. Get the next n - th referral code from originprotocol. com. | This has been tested to work with hash router? `domain/path#hash?fakeParam=fakevar` is a non-standard URL and those aren't real GET params. |
@@ -252,7 +252,6 @@ class TestAtisWorld(AllenNlpTestCase):
assert set(world.valid_actions['number']) == \
{'number -> ["0"]',
'number -> ["1"]',
- 'number -> ["2400"]',
'number -> ["1200"]',
'number -> ["12"]'}
| [TestAtisWorld->[test_atis_long_action_sequence->[AtisWorld,get_action_sequence],test_atis_simple_action_sequence->[AtisWorld,get_action_sequence],test_atis_local_actions->[AtisWorld,set],test_atis_global_actions->[AtisWorld,set,keys],setUp->[open,super],test_atis_from_json->[get_action_sequence,AtisWorld,len,range,loa... | Test if the local actions are valid. 1991 - 1200 - 1000 - 10. | Don't you actually want this? The person didn't specify 12pm. |
@@ -4083,6 +4083,18 @@ describe UsersController do
.to_not include(private_group.name)
end
+ it "allows plugin to filter by additional scope" do
+ Group.expects(:custom_scope).never
+ get "/u/search/users.json", params: { include_groups: "true", custom_groups_scope: 'cus... | [create_and_like_post->[like,create_post,enable],honeypot_magic->[parsed_body,reverse,get],users_found->[map],stub_secure_session_confirmed->[returns],post_user->[post,merge],create_totp->[post],create_second_factor_security_key->[post,sign_in],email,create,let,discourse_connect_overrides_avatar,user_fields,methods,sta... | This method is used to check the user s groups and their visibility level. It also checks searches for mentionable groups and returns an array of objects. | Is it possible to avoid using mocks here? Is there some state that we can test for to ensure that the method is not called? |
@@ -678,7 +678,7 @@ def do_boundscheck(context, builder, ind, dimlen, axis=None):
"for axis {} with size %d\n".format(axis), ind, dimlen)
else:
printf(builder, "debug: IndexError: index %d is out of bounds "
- "for axis %d with size %d\n".forma... | [for_range_slice->[terminate,increment_index],do_boundscheck->[if_unlikely,_dbg],is_scalar_neg->[_scalar_pred_against_zero],guard_memory_error->[is_null],alloca_once_value->[alloca_once],is_not_null->[get_null_value],snprintf_stackbuffer->[alloca_once,snprintf],hexdump->[printf,for_range,gep],if_zero->[is_scalar_zero],... | Check if the index is out of bounds. | Yeah, this one I am not so sure about... |
@@ -23,6 +23,12 @@ extern "C" {
#include "osquery/core/conversions.h"
+// FIXME: Add enum generation for tables and remove following code
+// Copy of values in disk_encryption.mm
+const std::string kEncryptionStatusEncrypted = "encrypted";
+const std::string kEncryptionStatusUndefined = "undefined";
+const std::st... | [genFDEStatus->[VLOG,at,geteuid,getuid,genFDEStatusForBlockDevice,count],genFDEStatusForBlockDevice->[crypt_get_type,crypt_init_by_name_and_header,VLOG,crypt_get_active_device,c_str,crypt_get_cipher_mode,push_back,crypt_status,crypt_get_cipher,crypt_free,count]] | Generate FDE status for a block device. free a block of data and return it. | Looks like copy-paste from `disk_encryption.mm`. Is here any way to use common code for it? |
@@ -162,12 +162,9 @@ inv = make_inverse_operator(left_auditory.info, fwd, noise_cov, fixed=False,
loose=1.0)
# Show the three dipoles defined at each location in the source space
-dip_dir = inv['source_nn'].reshape(-1, 3, 3)
-dip_dir = dip_dir[:len(dip_pos)] # Only select left hemispher... | [plot_alignment,Dipole,read_cov,create_3d_figure,make_inverse_operator,set_3d_view,quiver3d,convert_forward_solution,read_forward_solution,evokeds,plot,data_path,len,zip,magnitude,plot_dipole_locations,get_peak,read_evokeds,apply_inverse,read_trans,ones,inv] | Plot the left - auditory and the 3 - dipoles defined at each location in the Visualize the in the peak activity plot. | @GuillaumeFavelier you don't use the inv anymore in the tutorial |
@@ -112,7 +112,7 @@ public class TestOzoneManagerHA {
private static final long SNAPSHOT_THRESHOLD = 50;
private static final int LOG_PURGE_GAP = 50;
/* Reduce max number of retries to speed up unit test. */
- private static final int OZONE_CLIENT_FAILOVER_MAX_ATTEMPTS = 5;
+ private static final int OZONE_C... | [TestOzoneManagerHA->[testRemovePrefixAcl->[setupBucket],testFileOperationsWithNonRecursive->[setupBucket],initiateMultipartUpload->[initiateMultipartUpload],testSetKeyAcl->[setupBucket],createKey->[createKey],testListParts->[setupBucket,initiateMultipartUpload],shutdown->[shutdown],testRemoveKeyAcl->[setupBucket],test... | Implementation of the OzoneManager class. zoneConfiguration - Sets up the configuration for the OZONE. | Any particular reason for increasing this number? |
@@ -16,6 +16,13 @@ using System.Reflection;
using System.Runtime.Serialization;
using System.Runtime.Serialization.Formatters.Soap;
using System.Text;
+using ProtoCore.DSASM;
+using ProtoCore.Exceptions;
+using ProtoCore.Lang;
+using ProtoCore.Lang.Replication;
+using ProtoCore.Properties;
+using ProtoCore.Runtime;
... | [CallSite->[FunctionEndPoint->[GetCandidateFunctions],Inherits->[Inherits],StackValue->[UpdateCallsiteExecutionState,ComputeFeps,ArgumentSanityCheck,IsFunctionGroupAccessible],TraceSerialiserHelper->[GetObjectData->[GetObjectData]],ComputeFeps->[IsSimilarOptionButOfHigherRank],SingleRunTraceData->[GetObjectData->[GetOb... | Creates a base - case trace data object. This is a helper class for debugging purposes. It is a utility class to check if a. | You can just remove this `using` as it's referencing the `TraceUtils` class and add `using DynamoServices` instead. Then you won't need to prefix all usages of `TraceUtils` with `DynamoServices` namespace. |
@@ -25,6 +25,8 @@ public class BenchmarkTest {
*/
@Test
public void runSampleBenchmark() throws Exception {
+ assumeFalse(Functions.isWindows());
+
// run the minimum possible number of iterations
ChainedOptionsBuilder options = new OptionsBuilder()
... | [BenchmarkTest->[runSampleBenchmark->[assertTrue,include,getName,get,run,exists]]] | Run the sample benchmark. | benchmarks don't work on windows? |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.