patch stringlengths 18 160k | callgraph stringlengths 4 179k | summary stringlengths 4 947 | msg stringlengths 6 3.42k |
|---|---|---|---|
@@ -256,7 +256,7 @@ func (o *Operator) getApp(p Descriptor) (Application, error) {
return a, nil
}
- specifier, ok := p.(app.Specifier)
+ desc, ok := p.(*app.Descriptor)
if !ok {
return nil, fmt.Errorf("descriptor is not an app.Specifier")
}
| [State->[State],Close->[Close],runFlow->[State],Shutdown->[Shutdown]] | getApp returns an Application object for the given descriptor. | can you align error message as well? |
@@ -38,7 +38,7 @@ import org.apache.beam.sdk.util.WindowedValue;
import org.apache.beam.sdk.util.WindowingStrategy;
import org.apache.beam.sdk.values.PCollectionView;
import org.apache.beam.sdk.values.TupleTag;
-import org.apache.commons.lang.SerializationUtils;
+import org.apache.commons.lang3.SerializationUtils;
... | [PipelineOptionsTest->[TestDoFn->[processElement->[getTestOption]],testDeserialization->[getTestOption]]] | Package for importability. A PipelineOptionsTest class that creates a PipelineOptions object that can be used to test the. | And I moved this to use commons lang3 to align with other modules and beam-parent. Notice that the scope is only test, so no issues. |
@@ -64,8 +64,8 @@ public class MessagePropertiesContext implements Serializable
public MessagePropertiesContext(MessagePropertiesContext previous)
{
- inboundMap = new CopyOnWriteCaseInsensitiveMap<String, Object>(previous.inboundMap);
- outboundMap = new CopyOnWriteCaseInsensitiveMap<String, ... | [MessagePropertiesContext->[getStringProperty->[getStringProperty,getProperty],getDoubleProperty->[getProperty],clearProperties->[clearProperties,getScopedProperties],getProperty->[getProperty],getFloatProperty->[getProperty],getIntProperty->[getProperty],getShortProperty->[getProperty],removeProperty->[removeProperty]... | get the scoped properties. | In general, while this will be functionally correct, how do you know that it doesn't perform worse than the original? We are potentially doing one two map copies per scope per message copied. |
@@ -143,5 +143,6 @@ namespace Dynamo.ViewModels
public DelegateCommand GetBranchVisualizationCommand { get; set; }
public DelegateCommand CheckForLatestRenderCommand { get; set; }
public DelegateCommand DumpLibraryToXmlCommand { get; set; }
+ public DelegateCommand ShowGalleryUICommand... | [DynamoViewModel->[InitializeDelegateCommands->[Copy,Paste,PostUIActivation,CanRunExpression,PublishNewPackage,PublishSelectedNodes,CanPublishSelectedNodes,DumpLibraryToXml,PublishCurrentWorkspace,CanPublishNewPackage,PublishCustomNode,CanDumpLibraryToXml,Log,CanPublishCustomNode,ToString,AddToSelection,CanPublishCurre... | The commands that are executed when the branch visualization is done. | Please remove `ShowGalleryUICommand` command. |
@@ -169,12 +169,13 @@ RtpsSampleHeader::process_iqos(DataSampleHeader& opendds,
using namespace OpenDDS::RTPS;
#if defined(OPENDDS_TEST_INLINE_QOS)
std::stringstream os;
- os << "into_received_data_sample(): " << iqos.length()
- << " inline QoS parameters\n";
+ OPENDDS_STRING output("into_received_data_sam... | [No CFG could be retrieved] | - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -. | int -> str conversion needed |
@@ -38,6 +38,8 @@ class Moab(AutotoolsPackage):
homepage = "https://bitbucket.org/fathomteam/moab"
url = "http://ftp.mcs.anl.gov/pub/fathom/moab-5.0.0.tar.gz"
+ version('5.0.2', '00a6f96f2e6591ab087548839fa3825e',
+ url='ftp://ftp.mcs.anl.gov/pub/fathom/moab-5.0.2.tar.gz')
version('5.0.0... | [Moab->[install->[make],configure_args->[append,extend],variant,conflicts,depends_on,version]] | MISSING - Section Section Section Section Section Section Section Section Section Section Section Section Section Section Section Section Returns true if all of the required elements are true. | you should not need to specify `url`, should be picked up by Spack just fine. |
@@ -243,13 +243,13 @@ class FollowMe {
* unpinned
* @private
*/
- _nextOnStage (smallVideo, isPinned) {
+ _nextOnStage (videoId, isPinned) {
if (!this._conference.isModerator)
return;
var nextOnStage = null;
if(isPinned)
- nextOnStage = smallV... | [No CFG could be retrieved] | Updates the local object. This command is used to send the command to the user. | Redux middleware emits out the id now instead of the small video component. |
@@ -1402,6 +1402,12 @@ public abstract class CitrixResourceBase implements ServerResource, HypervisorRe
vbdr.userdevice = Long.toString(volumeTO.getDeviceId());
vbdr.mode = Types.VbdMode.RW;
vbdr.type = Types.VbdType.DISK;
+ Long deviceId = volumeTO.getDeviceId();
+ ... | [CitrixResourceBase->[isXcp->[callHostPlugin,getConnection,equals],initializeLocalSR->[toString,getLocalLVMSR,getLocalEXTSR],attachConfigDriveToMigratedVm->[getSRByNameLabel,equals],doPingTest->[toString,connect,callHostPlugin],connect->[toString,connect],umountSnapshotDir->[toString,callHostPlugin],getSRByNameLabeland... | Creates a new working VM. vbd - vm - vm - vmdr - vm - vmdr. | Calling `longValue` is unnecessary due to autoboxing. Also, `3` seems like a magic value. What is its significance? |
@@ -1082,6 +1082,8 @@ class Addon(OnChangeMixin, ModelBase):
@cached_property
def current_beta_version(self):
"""Retrieves the latest version of an addon, in the beta channel."""
+ if not waffle.switch_is_active('beta-versions'):
+ return
versions = self.versions.filter(fil... | [watch_disabled->[Addon],AddonManager->[enabled->[get_queryset],valid->[get_queryset],__init__->[__init__],valid_and_disabled_and_pending->[get_queryset],listed->[get_queryset],id_or_slug->[get_queryset],featured->[get_queryset],public->[get_queryset]],Addon->[can_request_review->[find_latest_version],get_required_meta... | Retrieves the latest version of an addon in the beta channel. | Note: since this property is stored in ES and then overwritten in the ES serializer by whatever data was in ES, if we care about its value in the search API (not detail) then we need to reindex every time the switch is toggled. Which is not necessarily a bad thing, as it avoids the cost of checking the waffle for every... |
@@ -79,6 +79,9 @@ class FreqtradeBot(object):
self.config.get('edge', {}).get('enabled', False) else None
self.active_pair_whitelist: List[str] = self.config['exchange']['pair_whitelist']
+ if not self.active_pair_whitelist:
+ raise DependencyException('Whitelist is empty.')
+
... | [FreqtradeBot->[execute_buy->[get_target_bid,_get_min_pair_stake_amount],cleanup->[cleanup],process_maybe_execute_buy->[create_trade],handle_timedout_limit_buy->[handle_buy_order_full_cancel],handle_trade->[get_sell_rate],create_trade->[_get_trade_stake_amount],notify_sell->[get_sell_rate]]] | Initialize all variables and objects for the freqtrade base class. | I think you'll want this on line 198(ish) ... it's only called once here on initialization ... never during "real" operations ... so it won't fix the original problem unless you restart / reconfigure the bot. also there, don't raise, but only log it - the dependencyexception we had was cought in maybe_buy ... it'll bub... |
@@ -499,6 +499,10 @@ export class LightningCustodianWallet extends LegacyWallet {
allowReceive() {
return false;
}
+
+ getPreferredBalanceUnit() {
+ return this.preferredBalanceUnit || BitcoinUnit.SATS;
+ }
}
/*
| [No CFG could be retrieved] | Fetches information about a single block of a specific type from the server. Get a list of all network nodes that have a sequence number. | not needed, we have this in parent |
@@ -1274,8 +1274,14 @@ class PackageBase(six.with_metaclass(PackageMeta, PackageViewMixin, object)):
"""Get the spack.compiler.Compiler object used to build this package"""
if not self.spec.concrete:
raise ValueError("Can only get a compiler for a concrete package.")
- return spack... | [PackageBase->[do_patch->[do_stage],_if_make_target_execute->[_has_make_target],setup_build_environment->[_get_legacy_environment_method],cache_extra_test_sources->[copy],do_stage->[do_fetch],dependency_activations->[extends],do_deactivate->[is_activated,_sanity_check_extension,do_deactivate],do_uninstall->[uninstall_b... | Get the compiler object used to build this package. | Could you wrap `def compiler` in `@llnl.util.memoized` for the same effect but with less new code? |
@@ -729,12 +729,16 @@ namespace Dynamo.PackageManager
private void RefreshPackageContents()
{
- PackageContents = CustomNodeDefinitions.Select(
- (def) => new PackageItemRootViewModel(def))
+ PackageContents.Clear();
+
+ var itemsToAdd ... | [PublishPackageViewModel->[GetFunctionDefinitionWS->[AllDependentFuncDefs,AllFuncDefs],GetAllFiles->[GetFunctionDefinitionWS,AllFuncDefs],GetPythonDependency->[GetFunctionDefinitionWS,AllDependentFuncDefs,AllFuncDefs],GetAllDependencies->[GetFunctionDefinitionWS,AllDependentFuncDefs,AllFuncDefs],SelectMarkdownDirectory... | Refresh the PackageContents from the list of CustomNodeDefinitions Assemblies and AdditionalFiles. | Not sure how this ever worked - `ObservableCollections` cannot be set AFAIK but only update in response to Add, Remove, Replace or Clear. |
@@ -154,6 +154,9 @@ int dma_copy_new(struct dma_copy *dc)
}
#if !CONFIG_DMA_GW
+ /* free previous used channel */
+ if (dc->chan)
+ dma_channel_put(dc->chan);
/* get DMA channel from DMAC0 */
dc->chan = dma_channel_get(dc->dmac, 0);
if (!dc->chan) {
| [dma_sg_elem->[trace_dma_error],dma_copy_new->[dma_get,dma_channel_get,trace_dma_error,dma_set_cb],dma_copy_to_host_nowait->[dma_sg_init,dma_set_config,dma_start,sg_get_elem_at,dma_copy],dma_copy_set_stream_tag->[dma_channel_get,trace_dma_error],void->[ipc_dma_trace_send_position,wait_completed]] | request a new DMA channel from the HDA DMA. | Lets free this directly using reset or a new API (called via IPC DMA trace disable). This is just a hack. |
@@ -33,11 +33,13 @@
<% unless @assignment.submission_rule.type == "NoLateSubmissionRule" || @grouping&.extension&.apply_penalty == false %>
<h3><%= SubmissionRule.model_name.human.capitalize %></h3>
- <p><%= @assignment.submission_rule.class.human_attribute_name(:description) %></p>
+ <p><%= @assignment... | [No CFG could be retrieved] | Renders a single node in the system. The remaining grace credits are relative to the current user s due date. | This warning is no longer relevant (there's no more notion of a "final due date"). I think we *do* want to show the "due date with penalty" (in the else block), but only `unless @assignment.is_timed? && @grouping.start_time.nil?`. |
@@ -309,7 +309,7 @@ func (s *k8sServiceCreatingJobHandler) OnCreate(ctx context.Context, jobInfo *pp
return nil
})
if err != nil {
- logrus.Errorf("could not create service for job %q: %v", jobInfo.Job.ID, err)
+ logrus.Errorf("could not create service for job %q: %v", jobInfo.Job.String(), err)
}
}
| [ServeSidecarS3G->[ServeSidecarS3G],processJobEvent->[OnCreate,OnTerminate]] | OnCreate is called when a new job is created OnTerminate is called when a job is terminated. It deletes the service if it exists. | you don't actually have to call String() here, `Printf` etc will do that automatically |
@@ -94,8 +94,8 @@ func WaitUntilLokiReceivesLogs(ctx context.Context, interval time.Duration, f *f
})
if err != nil {
- d := time.Now().Add(5 * time.Minute)
- dumpLogsCtx, dumpLogsCancel := context.WithDeadline(context.Background(), d)
+ // ctx might have been cancelled already, make sure we still dump logs, s... | [Now,DumpLogsForPodInNamespace,IgnoreAlreadyExists,MinorError,Fields,SevereError,Info,HasPrefix,Add,Atoi,Error,SetResourceVersion,WithDeadline,Marshal,Ok,Errorf,Bool,Until,Create,Infof,Get,Split,TrimLeft,Sprintf,DumpLogsForPodsWithLabelsInNamespace,Background,Client,String,Fail,GetLokiLogs,ServiceType] | GetLokiLogs gets the log from the Loki daemon and dumps it if InNamespace returns a corev1. Namespace that can be used to lookup the object in. | > // ctx might have been cancelled already, make sure we still dump logs, so use context.Background() Can you explain why this is a valid use case? Shouldn't it be the responsibility of the caller to pass a running context and if the passed context is cancelled, then shouldn't dumping the logs also stop? |
@@ -31,9 +31,11 @@ import com.metamx.druid.client.DruidDataSource;
import com.metamx.druid.client.DruidServer;
import com.metamx.druid.client.InventoryView;
import com.metamx.druid.client.indexing.IndexingServiceClient;
+import com.metamx.druid.config.JacksonConfigManager;
import com.metamx.druid.db.DatabaseRuleMan... | [InfoResource->[getDataSources->[apply->[getDataSources]],getDataSource->[apply->[getDataSource]]]] | Reads a single version of a and returns it. This resource is used to provide basic info about a resource. | im fairly sure we can create a dynamic config console without having to add 100 new files. Can you look at just using what is in place right now? All that is needed is a few input boxes and some basic JS |
@@ -135,6 +135,12 @@ function assertTarget(name, target, config) {
user().assert(
pattern.test(variable), '\'%s\' must match the pattern \'%s\'',
variable, pattern);
+ // TODO(clawr): Verify vendor name?
+ user().assert(
+ target.vars[variable]['vendorAnalyticsSource'] ==... | [No CFG could be retrieved] | Check if the variable is a unique identifier. | what do you think about this? Is it worth checking? |
@@ -78,7 +78,8 @@ class VisualStudioBuildEnvironment(object):
# FIXME: Conan 2.0. The libs are being added twice to visual_studio
# one in the conanbuildinfo.props, and the other in the env-vars
def format_lib(lib):
- return lib if os.path.splitext(lib)[1] else '%s.lib' % lib
+ ... | [VisualStudioBuildEnvironment->[vars_dict->[_get_link_list,_get_cl_list],_get_link_list->[format_lib],vars->[_get_link_list,_get_cl_list]]] | Get the list of link flags and libraries. | Do we need to check for `.dll`? |
@@ -124,6 +124,7 @@ public class ElasticsearchClient
private static final JsonCodec<NodesResponse> NODES_RESPONSE_CODEC = jsonCodec(NodesResponse.class);
private static final JsonCodec<CountResponse> COUNT_RESPONSE_CODEC = jsonCodec(CountResponse.class);
private static final ObjectMapper OBJECT_MAPPER = ... | [ElasticsearchClient->[close->[close],parseType->[parseType],clearScroll->[clearScroll]]] | This class imports all the properties of the given object and creates a new ElasticsearchClient. Injects an Elasticsearc object from a node. | Let's also add `data_warm` and `data_cold` here. |
@@ -268,6 +268,10 @@ public class ZeppelinConfiguration extends XMLConfiguration {
return getInt(ConfVars.ZEPPELIN_PORT);
}
+ public String getContextPath() {
+ return getString(ConfVars.ZEPPELIN_CONTEXT_PATH);
+ }
+
public String getKeyStorePath() {
return getRelativeDir(
String.for... | [ZeppelinConfiguration->[getLong->[getLong,getLongValue],useClientAuth->[getBoolean],getRelativeDir->[getRelativeDir,getString],useSsl->[getBoolean],getInt->[getIntValue,getInt],getServerAddress->[getString],getUser->[getString],getNotebookDir->[getString],isType->[checkType],getTrustStorePassword->[getKeyStorePassword... | get server port and keyStore path. | same for naming of this.. |
@@ -984,6 +984,8 @@ public class AddressSettings implements Mergeable<AddressSettings>, Serializable
defaultLastValueQueue = BufferHelper.readNullableBoolean(buffer);
redistributionDelay = BufferHelper.readNullableLong(buffer);
+
+ clusteredQueues = BufferHelper.readNullableBoolean(buffer);
... | [AddressSettings->[getDefaultGroupBuckets->[getDefaultGroupBuckets],merge->[getPageSizeBytes],equals->[equals],getMaxRedeliveryDelay->[getRedeliveryDelay],getDefaultGroupFirstKey->[getDefaultGroupFirstKey],getDefaultConsumersBeforeDispatch->[getDefaultConsumersBeforeDispatch],getDefaultDelayBeforeDispatch->[getDefaultD... | Decode the message header. read properties of the configuration read default group buckets. | must be at the end of the serialisation for compatibility reasons |
@@ -578,8 +578,8 @@ def render(args):
def like_domain_query(term):
domain_query = database.session_query(Domain.id)
domain_query = domain_query.filter(func.lower(Domain.name).like(term.lower()))
- assoc_query = database.session_query(certificate_associations.c.certificate_id)
- assoc_query = assoc_quer... | [export->[export,get],remove_from_destination->[get],render->[get],get->[get],calculate_reissue_range->[get],upload->[create_certificate_roles,get,update],revoke->[get],create_csr->[get],update->[get,update],mint->[get],stats->[get],import_certificate->[get],is_attached_to_endpoint->[get_by_name],get_by_name->[get],cre... | Query for domains that match a string. | I still need to test this - TODO for myself before merging. - [x] Test |
@@ -114,6 +114,7 @@ class MsgDispatcher(MsgDispatcherBase):
data: a list of dictionaries, each of which has at least two keys, 'parameter' and 'value'
"""
for entry in data:
+ entry['value'] = entry['value'] if type(entry['value']) is str else json_tricks.dumps(entry['value'])
... | [MsgDispatcher->[handle_report_metric_data->[_pack_parameter,_create_parameter_id],load_checkpoint->[load_checkpoint],save_checkpoint->[save_checkpoint],_earlystop_notify_tuner->[_handle_final_metric_data],send_trial_callback->[_pack_parameter],_handle_intermediate_metric_data->[_sort_history],handle_add_customized_tri... | Import additional data for tuning data. | better to use `isinstance` instead of `type() is` |
@@ -308,13 +308,11 @@ public abstract class AbstractServerMessenger implements IServerMessenger, NioSo
}
private void notifyPlayerRemoval(final INode node) {
- synchronized (cachedListLock) {
- playersThatLeftMacsLast10.put(node.getName(), cachedMacAddresses.get(node.getName()));
- if (playersThatL... | [AbstractServerMessenger->[notifyPlayerLogin->[scheduleMacUnmuteAt,scheduleUsernameUnmuteAt],ConnectionHandler->[run->[shutDown]],shutDown->[shutDown],messageReceived->[isUsernameMutedInCache,getPlayerMac,isMacMutedInCache],newUnbanTimerTask->[run->[run]],forwardBroadcast->[send],forward->[send],getUniqueName->[isNameT... | Notify listeners that a player has left a mac address and that it has left a mac address. | I feel like this is a NO-OP: I believe `entrySet()` should probably get replaced with `keySet()`, but in this case `playersThatLeftMacsLast10.entrySet().iterator().remove()` might be used as well. |
@@ -38,9 +38,11 @@ public class UpdateAction implements BaseUsersWsAction {
private static final String PARAM_SCM_ACCOUNTS = "scm_accounts";
private final UserService service;
+ private final UserUpdater userUpdater;
- public UpdateAction(UserService service) {
+ public UpdateAction(UserService service, Us... | [UpdateAction->[writeUser->[endObject],writeResponse->[close,getByLogin,beginObject,writeUser],define->[setExampleValue,setHandler],handle->[create,setName,param,paramAsStrings,mandatoryParam,update,setScmAccounts,hasParam,setEmail,setPassword,setPasswordConfirmation,writeResponse]]] | This method defines a missing configuration for a user. | Please replace usage of UserService by Userindex |
@@ -138,10 +138,11 @@ public class GetSolr extends SolrProcessor {
descriptors.add(SOLR_TYPE);
descriptors.add(SOLR_LOCATION);
descriptors.add(COLLECTION);
+ descriptors.add(RETURN_TYPE);
+ descriptors.add(RECORD_WRITER);
descriptors.add(SOLR_QUERY);
- descriptor... | [GetSolr->[onTrigger->[getValue,create,size,equals,process,start,SimpleDateFormat,toString,setBasicAuthCredentials,StringBuilder,info,getTimeZone,QueryResponseOutputStreamCallback,yield,getResults,rollback,getSolrClient,getDuration,writeLastEndDate,getNumFound,getUsername,setRows,set,isEmpty,valueOf,transfer,getPasswor... | Initializes the object. | Is it safe to remove an existing property? The existing code should not sort result anyway, or should store last sorted field value to paginate properly when docs with the same date split more than one page. So I think it's safe.. |
@@ -79,7 +79,7 @@ public abstract class AbstractWriteHelper<T extends HoodieRecordPayload, I, K, O
*
* @param records hoodieRecords to deduplicate
* @param parallelism parallelism or partitions to be used while reducing/deduplicating
- * @return RDD of HoodieRecord already be deduplicated
+ * @retur... | [AbstractWriteHelper->[deduplicateRecords->[deduplicateRecords]]] | Deduplicate records from the given table. | Hi, @yanghua Thanks for raising this pr. LGTM overall. I noticed that there are still two lines contains `RDD` in `hudi-client-common` module. maybe we can improve them together. hudi-client/hudi-client-common/src/main/java/org/apache/hudi/index/HoodieIndexUtils.java:76 hudi-client/hudi-client-common/src/main/java/org/... |
@@ -177,6 +177,9 @@
* /* As of 1.4.4, this must always be set: it signals ngAnimate
* to not accidentally inherit a delay property from another CSS class */
* transition-duration: 0s;
+ * /* if you are using animations instead of transitions you should configure as follows:
+ * animatio... | [No CFG could be retrieved] | A module that supports staggering animations. Missing element in parent element. | Please remove the trailing whitespace in this line |
@@ -435,7 +435,13 @@ def _stage_dataflow_sdk_tarball(sdk_remote_location, staged_path, temp_dir):
_dependency_file_copy(sdk_remote_location, staged_path)
elif sdk_remote_location == 'pypi':
logging.info('Staging the SDK tarball from PyPI to %s', staged_path)
- _dependency_file_copy(_download_pypi_sdk_pa... | [stage_job_resources->[_stage_extra_packages],_stage_dataflow_sdk_tarball->[_dependency_file_download,_dependency_file_copy],_build_setup_package->[_get_python_executable],get_sdk_name_and_version->[get_required_container_version],_download_pypi_sdk_package->[_get_python_executable],_populate_requirements_cache->[_get_... | Stage a Dataflow SDK tarball. | It would make sense to push down this check to `_download_pypi_sdk_package`. This will remove the requirement for importing the same package here again, and you can raise the same RuntimeError there. |
@@ -1052,7 +1052,7 @@ func saveInsufficientEthAttempt(db *gorm.DB, attempt *EthTxAttempt, broadcastAt
// re-org'd out and will be rebroadcast.
func (ec *EthConfirmer) EnsureConfirmedTransactionsInLongestChain(ctx context.Context, head models.Head) error {
if head.ChainLength() < ec.config.EvmFinalityDepth() {
- lo... | [handleInProgressAttempt->[handleInProgressAttempt],EnsureConfirmedTransactionsInLongestChain->[handleAnyInProgressAttempts]] | EnsureConfirmedTransactionsInLongestChain checks all transactions in the given chain are confirmed in Done - > MultiError. | This probably deserves some kind of prize for being the broadest debug message ever |
@@ -14,4 +14,7 @@ class NumericallyAugmentedQaNetTest(ModelTestCase):
@flaky(max_runs=3, min_passes=1)
def test_model_can_train_save_and_load(self):
- self.ensure_model_can_train_save_and_load(self.param_file)
+ self.ensure_model_can_train_save_and_load(
+ self.param_file,
+ ... | [NumericallyAugmentedQaNetTest->[test_model_can_train_save_and_load->[ensure_model_can_train_save_and_load],setUp->[print,set_up_model,super],flaky]] | Ensures that the model can train and load. | I'm always paranoid about test changes in this sort of PR. ;) What's up? |
@@ -38,7 +38,7 @@ public class LocalLauncher extends AbstractLauncher {
ServerGame game = null;
try {
m_gameData.doPreGameStartDataModifications(m_playerListing);
- final IServerMessenger messenger = new DummyMessenger();
+ final IServerMessenger messenger = mock(IServerMessenger.class);
... | [LocalLauncher->[launchInNewThread->[run->[setVisible],ServerGame,loadDefaultGame,ScriptedRandomSource,createPlayers,invokeLater,sleep,useScriptedRandom,Runnable,doPreGameStartDataModifications,logQuietly,doneWait,startGame,DummyMessenger,Messengers,getLocalPlayerTypes,fine,setRandomSource],getLogger,getName]] | Launch a new game in a new thread. | A `DummyMessenger` is a 'do-nothing' object. That is different from a mock. The need for a `DummyMessenger` is actually a code smell. It indicates a lot of code that should not be called, but is. Secondly, it looks to be an inappropriate abstraction. It is overly broad and requires dependencies that are not always used... |
@@ -36,7 +36,6 @@ use Yoast\WP\SEO\Repositories\Indexable_Repository;
* @property int $site_user_id
* @property string $site_represents
* @property array|false $site_represents_reference
- * @property bool $breadcrumbs_enabled
* @property string schema_page_type
* @property string ... | [Meta_Tags_Context->[generate_site_represents_reference->[get_user_schema_id],generate_company_logo_id->[get_attachment_id_from_settings],generate_site_name->[get],generate_schema_page_type->[get],generate_site_url->[find_for_home_page,dynamic_permalinks_enabled,get_permalink_for_indexable],generate_description->[repla... | <?php Create a new instance of the Yoast \ WP \ SEO \ Context The context class for the given meta tags. | Should $breadcrumbs_enabled also be removed from the value object in src/surfaces/values/meta.php? |
@@ -349,7 +349,7 @@ def check_stats_permission(request, addon, for_contributions=False):
raise PermissionDenied
-@addon_view_factory(qs=Addon.with_unlisted.valid)
+@addon_view
@non_atomic_requests
def stats_report(request, addon, report):
check_stats_permission(request, addon,
| [stats_report->[check_stats_permission],zip_overview->[iterator],overview_series->[get_series],sources_series->[csv_fields,get_series],collection_report->[get_report_view],extract->[_extract_value->[extract],_extract_value,extract],site->[_site_query,get_daterange_or_404],usage_series->[get_series],collection_stats->[g... | Show stats for a single . | just checking, not `addon_view_factory(qs=Addon.objects.valid)`? |
@@ -321,7 +321,9 @@ public class DefaultHttpDataFactory implements HttpDataFactory {
List<HttpData> list = e.getValue();
for (HttpData data : list) {
- data.release();
+ if (data.refCnt() > 0) {
+ data.release();
+ }
... | [DefaultHttpDataFactory->[createFileUpload->[checkHttpDataSize,getList],createAttribute->[checkHttpDataSize,getList],cleanAllHttpDatas->[cleanAllHttpData],cleanRequestHttpDatas->[cleanRequestHttpData]]] | cleanAllHttpData - Deletes all HttpData in the requestFileDeleteMap. | I think this is not really correct. We should release if always. If there is an exception it is a bug. |
@@ -324,8 +324,6 @@ class Optimizer(object):
params_grads = append_backward(loss, parameter_list, no_grad_set,
[error_clip_callback])
- params_grads = sorted(params_grads, key=lambda x: x[0].name)
-
params_grads, table_param_and_grad, ta... | [AdamaxOptimizer->[_append_optimize_op->[_get_accumulator,_create_param_lr],_finish_update->[_get_accumulator],_create_accumulators->[_add_accumulator]],MomentumOptimizer->[_append_optimize_op->[_get_accumulator,_create_param_lr],_create_accumulators->[_add_accumulator]],Optimizer->[minimize->[_process_distribute_looku... | Add operations to minimize loss by updating parameter_list and gradient. | Why remove sorted in Python? |
@@ -63,7 +63,7 @@
*/
struct ll_schedule_data {
- struct list_item work[LL_PRIORITIES]; /* list of ll per priority */
+ struct list_item tasks; /* list of ll tasks */
uint64_t timeout; /* timeout for next queue run */
uint32_t window_size; /* window size for pending ll */
spinlock_t lock;
| [No CFG could be retrieved] | Creates a generic work queue with all the necessary data. Schedule a task for execution. | What's the rational behind this ? Why would we want to remove a feature ? |
@@ -26,6 +26,8 @@ namespace Microsoft.Xna.Framework.Graphics
public RenderTarget2D(GraphicsDevice graphicsDevice, int width, int height, bool mipMap, SurfaceFormat preferredFormat, DepthFormat preferredDepthFormat, int preferredMultiSampleCount, RenderTargetUsage usage, bool shared, int arraySize)
: bas... | [RenderTarget2D->[GraphicsDeviceResetting->[GraphicsDeviceResetting]]] | The base class for all 2D objects. | QueryRenderTargetFormat() is called after the base class (Texture2D) is initialized with the preferredFormat. |
@@ -34,12 +34,15 @@ function calculateScriptBaseUrl(location, isLocalDev) {
* Calculate script url for an extension.
* @param {!Location} location The window's location
* @param {string} extensionId
+ * @param {string} extensionVer
* @param {boolean=} isLocalDev
* @return {string}
*/
-export function calcul... | [No CFG could be retrieved] | Calculates the base url for any scripts. | what about make it {string=} and we set it to 0.1 if undefined? |
@@ -161,6 +161,9 @@ public abstract class AbstractWebServiceOutboundGateway extends AbstractReplyPro
this.evaluationContext.setTypeConverter(new StandardTypeConverter(conversionService));
}
this.evaluationContext.addPropertyAccessor(new MapAccessor());
+ Assert.state(this.destinationProvider != null ? Collec... | [AbstractWebServiceOutboundGateway->[onInit->[onInit],setMessageFactory->[setMessageFactory],RequestMessageCallback->[doWithMessage->[doWithMessage]],setMessageSender->[setMessageSender],setMessageSenders->[setMessageSenders],setFaultMessageResolver->[setFaultMessageResolver],setInterceptors->[setInterceptors]]] | This method is called when the application is initialized. | IMHO: it should be just **WARN** as it done in many other Spring places, e.g. in MVC... "uri variables will be ignored" and that's all |
@@ -518,7 +518,13 @@ func (ctx *Context) RegisterResource(
func (ctx *Context) RegisterComponentResource(
t, name string, resource ComponentResource, opts ...ResourceOption) error {
- return ctx.RegisterResource(t, name, nil, resource, opts...)
+ return ctx.RegisterResource(t, name, nil /*props*/, resource, opts..... | [ReadResource->[ReadResource,DryRun],RegisterComponentResource->[RegisterResource],collapseAliases->[Project,Stack],Invoke->[Invoke,DryRun],resolve->[resolve],prepareResourceInputs->[DryRun],RegisterResourceOutputs->[DryRun,endRPC,RegisterResourceOutputs,beginRPC],Close->[Close],RegisterResource->[DryRun,RegisterResour... | RegisterComponentResource registers a component resource with the given name. | @pgavlin, what do you think of this new function? Or did you envision exposing this some other way? |
@@ -41,9 +41,6 @@ public class RestClientOverrideRuntimeConfigTest {
assertTrue(specifiedDefaultValues.isPresent());
assertTrue(specifiedDefaultValues.get().getPropertyNames()
.contains("io.quarkus.restclient.configuration.EchoClient/mp-rest/url"));
- // This config key comes f... | [RestClientOverrideRuntimeConfigTest->[overrideConfig->[assertTrue,getValue,getName,isPresent,getConfigSourceName,contains,echo,getConfigSource,assertEquals,getConfigValue],addAsServiceProvider,setArchiveProducer]] | Test whether the specified config key overrides the default values. | @radcortez FYI - since the "url" property is no longer processed as part of any ConfigRoot, it's not going to be present in the "specifiedDefaultValues" source, so I need to remove this bit. Let me know if you want me to modify this test differently. |
@@ -1693,10 +1693,11 @@ out:
}
void
-vos_dtx_cleanup_dth(struct dtx_handle *dth)
+vos_dtx_cleanup_dth(struct vos_container *cont, struct dtx_handle *dth)
{
- d_iov_t kiov;
- int rc;
+ struct vos_dtx_act_ent *dae;
+ d_iov_t kiov;
+ int rc;
if (dth == NULL || !dth->dth_actived)
return;
| [No CFG could be retrieved] | Removes a DTX handle from the DTX active list and removes it from the DTX. | dth->dth_coh is container handle, so it is unnecessary to add the "cont" parameter. |
@@ -2239,9 +2239,14 @@ fs_copy(struct file_dfs *src_file_dfs,
int dfs_prefix_len,
const char *fs_dst_prefix)
{
- int rc = 0;
- DIR *src_dir;
- struct stat st_dir_name;
+ int rc = 0;
+ DIR *src_dir = NULL;
+ struct stat st_dir_name;
+ char *filename = NULL;
+ char *dst_filename= NULL;
+ char *next_path = NULL;
+ ch... | [No CFG could be retrieved] | Reads a file from the file system and copies it into the destination directory. Reads the n - ary file from the source directory and creates n - ary entries in the. | (style) spaces required around that '=' (ctx:VxW) |
@@ -734,7 +734,8 @@ int dtls1_write_bytes(SSL *s, int type, const void *buf, size_t len,
{
int i;
- OPENSSL_assert(len <= SSL3_RT_MAX_PLAIN_LENGTH);
+ if (!ossl_assert(len <= SSL3_RT_MAX_PLAIN_LENGTH))
+ return -1;
s->rwstate = SSL_NOTHING;
i = do_dtls1_write(s, type, buf, len, 0, written... | [No CFG could be retrieved] | This function is called from the write_bytes function of the first record of type type. The main entry point for writing a fragment. | Should this set some sort of error condition? Perhaps set errno to EINVAL? ... |
@@ -57,6 +57,15 @@ import org.apache.beam.sdk.values.TupleTagList;
/** PTransform that uses BigQuery batch-load jobs to write a PCollection to BigQuery. */
class BatchLoads<DestinationT>
extends PTransform<PCollection<KV<DestinationT, TableRow>>, WriteResult> {
+ // The maximum number of file writers to keep op... | [BatchLoads->[validate->[IllegalArgumentException,checkArgument,getTempLocation,isNullOrEmpty,fromUri,format],expand->[getTempFilePrefix->[resolveTempLocation,getTempLocation,output],getSideInputs,asIterable,newArrayList,of,randomUUIDString,withOutputTags,withSideInputs,asMultimap,apply,setCoder,asSingleton,discardingF... | Imports a single - table PCollection from the current JVM. Constructor for class. | setMaxNumWriters I suppose |
@@ -220,9 +220,9 @@ module.exports = JhipsterClientGenerator.extend({
configureGlobal: function () {
// Application name modified, using each technology's conventions
this.angularAppName = this.getAngularAppName();
- this.camelizedBaseName = _s.camelize(this.baseName);
- ... | [No CFG could be retrieved] | The main function that is called when the user has done the generation. This method is called by the options to set the Hibernate cache. | shouldnt this be cameCase? |
@@ -154,8 +154,8 @@ namespace Dynamo.Engine
/// <summary>
/// Get runtime mirror for variable.
/// </summary>
- /// <param name="variableName"></param>
- /// <returns></returns>
+ /// <param name="variableName">Unique ID of AST node</param>
+ /// <returns>RuntimeMi... | [EngineController->[GetExecutedAstGuids->[GetExecutedAstGuids],ReconcileTraceDataAndNotify->[OnTraceReconciliationComplete],ImportLibrary->[ImportLibrary],UpdateGraph->[UpdateGraph],ShowRuntimeWarnings->[GetRuntimeWarnings],ShowBuildWarnings->[GetBuildWarnings],GetRuntimeWarnings->[GetRuntimeWarnings],RemoveRecordedAst... | Get mirror of a variable. | RuntimeMirror object that... |
@@ -34,6 +34,7 @@ import static org.junit.jupiter.api.Assertions.*;
* @since 6.2.0
*/
@Tag("OIDC")
+@TestPropertySource(properties = "cas.authn.oauth.accessToken.createAsJwt=true")
public class OidcImplicitIdTokenAndTokenAuthorizationResponseBuilderTests extends AbstractOidcTests {
@Test
| [OidcImplicitIdTokenAndTokenAuthorizationResponseBuilderTests->[verifyBuild->[singletonList,getOidcRegisteredService,assertNotNull,getSessionStore,CommonProfile,build,save,getClientId,getType,MockHttpServletResponse,setId,toString,MockHttpServletRequest,JEESessionStore,addParameter,JEEContext,put,setClientName],verifyO... | Verify operation. | I believe OIDC expects JWT ticket, right? Also after this PR createAsJwt have to be set to true to pass the unit test. (Otherwise OidcIdTokenGeneratorService would not be able to get the encoded access token.) |
@@ -82,9 +82,14 @@ function checkForAttachParametersAndConnect(id, password, connection) {
* @returns {Promise<JitsiConnection>} connection if
* everything is ok, else error.
*/
-export function connect(id, password, roomName) {
+export async function connect(id, password, roomName) {
const connectionConfig ... | [No CFG could be retrieved] | Connect to Jitsi MeetJS using provided credentials. Register event listeners for connection establishment and failure. | is there a reason for not caching the getState result into a constant? |
@@ -283,6 +283,7 @@ getent passwd daos_agent >/dev/null || useradd -s /sbin/nologin -r -g daos_agent
%dir %{_sysconfdir}/bash_completion.d
%{_sysconfdir}/bash_completion.d/daos.bash
%{_libdir}/libdaos_common.so
+%{_libdir}/libdaos_common_pmem.so
# TODO: this should move from daos_srv to daos
%{_libdir}/daos_srv/li... | [No CFG could be retrieved] | client - agent agent - service DAO specific configuration. | should we have this in server and the other library in client rather than in common list ? Also, need to address the question about debian |
@@ -21,6 +21,8 @@ import (
"net"
"os/exec"
+ gardencorev1alpha1 "github.com/gardener/gardener/pkg/apis/core/v1alpha1"
+ gardencorev1alpha1helper "github.com/gardener/gardener/pkg/apis/core/v1alpha1/helper"
gardencorev1beta1 "github.com/gardener/gardener/pkg/apis/core/v1beta1"
v1beta1constants "github.com/gard... | [SyncShootCredentialsToGarden->[ComputeGrafanaUsersHost,WithKind,GetAPIServerDomain,Client,NewControllerRef,Enabled,ComputeKibanaHost,CreateOrUpdate],DeploySecrets->[ComputeSecretCheckSum,deployOpenVPNTLSAuthSecret,Unlock,TryUpdateShootAnnotations,Delete,generateBasicAuthAPIServer,Has,generateStaticToken,ShootWantsBasi... | Package that contains all of the functions related to the given sequence number. v1 - > v1 - > v1 - > v1 - > v1. | Double check all your changed files. We don't want to use `v1alpha1` anymore. |
@@ -383,7 +383,7 @@ static void _validate_dimensions(dt_lib_export_t *d)
uint32_t height = atoi(gtk_entry_get_text(GTK_ENTRY(d->height)));
if(width > d->max_allowed_width || height > d->max_allowed_height)
{
- width = width > d->max_allowed_width ? dt_conf_get_int(CONFIG_PREFIX "width"): width;
+ width =... | [No CFG could be retrieved] | _update_dimensions - update dimensions of image - related objects set_storage_by_name - Set image storage by name. | Is a single space before `:` really changing something ? |
@@ -285,6 +285,8 @@ class Addon(OnChangeMixin, ModelBase):
db_column='bayesianrating')
total_reviews = models.PositiveIntegerField(default=0,
db_column='totalreviews')
+ text_reviews = models.PositiveIntegerField(default=0... | [watch_disabled->[Addon],AddonManager->[enabled->[get_queryset],valid->[get_queryset],__init__->[__init__],valid_and_disabled_and_pending->[get_queryset],listed->[get_queryset],id_or_slug->[get_queryset],featured->[get_queryset],public->[get_queryset]],Addon->[can_request_review->[find_latest_version],get_required_meta... | Adds a field to the model that represents a single add - on. Required fields for the HMC. | `text_reviews_count` ? `text_reviews` sound more like a list of text reviews that a count (I wish `total_reviews` was called `reviews_count` but I'm too scared to change it...) |
@@ -406,10 +406,10 @@ class csstidy {
$add = '';
$replaced = false;
- while ($i < strlen($string) && (ctype_xdigit($string{$i}) || ctype_space($string{$i})) && strlen($add) < 6) {
- $add .= $string{$i};
+ while ($i < strlen($string) && (ctype_xdigit($string[$i]) || ctype_space($string[$i])) && strlen($add) ... | [csstidy->[css_new_media_section->[get_cfg],merge_css_blocks->[css_add_property],css_new_selector->[get_cfg],css_new_property->[get_cfg],_add_token->[get_cfg],_unicode->[get_cfg,log],parse->[_add_token,_unicode,get_cfg,log],css_add_property->[get_cfg],property_is_next->[log],set_cfg->[_load_template],property_is_valid-... | Unicode - safe version of the function _unicode. | Since we are editing this, should we take the opportunity to add the proper spacing inside the square brackets? |
@@ -1220,6 +1220,18 @@ def test_render_cancel_fulfillment_page(admin_client, fulfilled_order):
assert response.status_code == 200
+def test_view_edit_order_customer_note(admin_client, order_with_lines):
+ url = reverse(
+ "dashboard:order-edit-customer-note", kwargs={"order_pk": order_with_lines.pk}
... | [test_view_order_shipping_edit_not_draft_order->[post,reverse,Money,create],test_view_order_customer_remove->[reverse,refresh_from_db,post,get_redirect_location],test_view_capture_order_invalid_payment_refunded_status->[reverse,post,get,last],test_view_change_fulfillment_tracking->[post,refresh_from_db,first,reverse,ge... | Test view for adding a note to an order. | Add a check that the event was properly triggered, saved and has the correct data in it |
@@ -84,4 +84,10 @@ class ApplicationController < ActionController::Base
head :forbidden
end
end
+
+ def overrided_root_redirect
+ if !request.env["gobierto_welcome_override"] && request.path == current_site.root_path
+ redirect_to root_path and return false
+ end
+ end
end
| [ApplicationController->[apply_engines_overrides->[engine_overrides?],helpers->[helpers]]] | Raise a module not enabled exception if it is not enabled. | Use && instead of and. |
@@ -39,6 +39,9 @@ public class LdapConfiguration implements Configurable{
private static final ConfigKey<String> ldapProvider = new ConfigKey<String>(String.class, "ldap.provider", "Advanced", "openldap", "ldap provider ex:openldap, microsoftad",
... | [LdapConfiguration->[getReturnAttributes->[getLastnameAttribute,getFirstnameAttribute,getEmailAttribute]]] | END of Class Definition get LDAP basedn bind password. | Please update FS with this config information. |
@@ -81,6 +81,12 @@ class PytorchSeq2VecWrapper(Seq2VecEncoder):
if isinstance(state, tuple):
state = state[0]
+ # We sorted by length, so if there are invalid rows that need to be zeroed out
+ # they will be at the end. Note that at this point batch_size is the second
+ # di... | [PytorchSeq2VecWrapper->[forward->[get_output_dim]]] | Forward computation of the CNN. If we have bidirectional states return a tensor with the last layer state. | Nit: I find this very confusing when there are implicit dimensions in slices - can you add in the extra `:` for the final dimension? |
@@ -846,7 +846,7 @@ Utilization of max. archive size: {csize_max:.0%}
if warning:
set_ec(EXIT_WARNING)
# bsdflags include the immutable flag and need to be set last:
- if not self.nobsdflags and 'bsdflags' in item:
+ if not self.noflags and 'bsdflags' in ... | [ChunksProcessor->[maybe_checkpoint->[write_part_file,info],write_part_file->[write_checkpoint,add_item,as_dict],process_file_chunks->[maybe_checkpoint,show_progress,chunk_processor]],ArchiveChecker->[finish->[info],rebuild_manifest->[valid_msgpacked_dict,valid_archive,info],verify_data->[delete,info],orphan_chunks_che... | Restore filesystem attributes from item. set extended attributes and flags if necessary. | hmm, while we have the less misleading "flags / noflags" on the UI / in the docs, we still have "bsdflags" in the items. not sure whether we should change this or not, maybe needs some thoughts, esp. about compatibility. |
@@ -419,7 +419,7 @@ dtx_dti_classify_one(struct ds_pool *pool, struct pl_map *map, uuid_t po_uuid,
struct daos_obj_md md = { 0 };
struct dtx_cf_rec_bundle dcrb;
d_rank_t myrank;
- int replicas;
+ int tgt_cnt;
int start;
int rc;
int i;
| [No CFG could be retrieved] | Get the number of records from the DAO object. finds the object in the map that is not part of the object list. | grp_size seems to be a better name |
@@ -7312,9 +7312,12 @@ function make_substitutions($text, $substitutionarray, $outputlangs = null, $con
} else {
$value = dol_nl2br("$value");
}
-
$text = str_replace("$key", "$value", $text); // We must keep the " to work when value is 123.5 for example
}
+ if ($key == '__UNSUBSCRIBE__' && (isset(... | [dol_print_url->[trans],dol_print_socialnetworks->[load,trans],img_help->[trans],dol_print_ip->[trans],getBrowserInfo->[isMobile,is,isTablet],img_error->[trans],img_action->[transnoentitiesnoconv],img_allow->[trans],get_htmloutput_mesg->[trans,load],dol_get_fiche_head->[executeHooks,trans],print_fleche_navigation->[tra... | This function is used to make substitution for language keys in a text. This function is used to convert the text of a constant key translation into a translation. Private function to convert user signature to plain text. | The make_substitutions() function is a technical low level method (to make a repacement of strings). We should not find code specific to one feature. So, you must forge the string of the header `List-Unsubscribe: <__UNSUBSCRIBE__>` into the mailing/card.php code (because this is where you need it) and call the make_sub... |
@@ -263,13 +263,13 @@ namespace ReadyToRun.SuperIlc
outputPath.RecreateDirectory();
}
- List<ProcessInfo> compilationsToRun = new List<ProcessInfo>();
- List<KeyValuePair<string, ProcessInfo[]>> compilationsPerRunner = new List<KeyValuePair<string, ProcessInfo[]>>()... | [BuildFolderSet->[WriteBuildStatistics->[WriteJittedMethodSummary,WriteTopRankingProcesses],WriteLogs->[WriteFrameworkExclusions,WriteCombinedLog,WriteBuildLog],Build->[Compile,Execute],WriteBuildLog->[WriteBuildStatistics]]] | Checks if a specific compiler can be run based on the input files and the output files. This method is called when a compilation process is found. It is called by the compiler. Checks if there is a failure to compile the framework. | I don't see that this `excludedAssemblies` variable is used anywhere. |
@@ -60,6 +60,7 @@ class SectionsController < ApplicationController
if @section.has_students?
flash[:error] = I18n.t('section.delete.not_empty')
else
+ @section.section_due_dates.each &:destroy
@section.destroy
flash[:success] = I18n.t('section.delete.success')
end
| [SectionsController->[destroy->[destroy],new->[new],create->[new]]] | destroy a specific section if it has no students. | Ambiguous block operator. Parenthesize the method arguments if it's surely a block operator, or add a whitespace to the right of the `&` if it should be a binary AND. |
@@ -64,6 +64,14 @@ func (h *ruleHandler) GetAllByGroup(w http.ResponseWriter, r *http.Request) {
h.rd.JSON(w, http.StatusOK, rules)
}
+// @Tags rule
+// @Summary List all rules of cluster by region.
+// @Param region path string true "The name of region"
+// @Produce json
+// @Success 200 {array} placement.Rule
+/... | [checkRule->[Wrapf,DecodeBytes,Compare,New,GetConfig,String,DecodeString,Wrap],GetAllByGroup->[Context,Error,GetRulesByGroup,Vars,IsPlacementRulesEnabled,GetRuleManager,JSON],Set->[Context,checkRule,Error,ReadJSONRespondError,IsPlacementRulesEnabled,GetRuleManager,JSON,SetRule],GetAllByKey->[Context,GetRulesByKey,Error... | GetAllByGroup returns all the rules for a given group. | need 404 but no need 500 |
@@ -220,7 +220,7 @@ public abstract class AbstractMessageProcessorTestCase extends AbstractMuleConte
props.put("prop1", "value1");
props.put("port", 12345);
- Service svc = getTestService();
+ Flow svc = getTestFlow();
if (exceptionListener != null)
{
svc... | [AbstractMessageProcessorTestCase->[createTestOutboundEvent->[createTestOutboundEvent],configureMuleContext->[configureMuleContext],createTestOutboundEndpoint->[createTestOutboundEndpoint],createTestInboundEndpoint->[createTestInboundEndpoint],doSetUp->[doSetUp]]] | Creates a test outbound event. | change variable name |
@@ -216,7 +216,14 @@ public class RegistryDirectory<T> extends DynamicDirectory<T> {
if (invokerUrls.isEmpty()) {
return;
}
- Map<URL, Invoker<T>> newUrlInvokerMap = toInvokers(invokerUrls);// Translate url list to Invoker map
+
+ // can't use... | [RegistryDirectory->[destroyUnusedInvokers->[destroyAllInvokers],notify->[notify],mergeUrl->[mergeUrl],subscribe->[subscribe],ReferenceConfigurationListener->[notifyOverrides->[refreshOverrideAndInvoker]],ConsumerConfigurationListener->[notifyOverrides->[refreshOverrideAndInvoker]]]] | refresh invoker. This method is called when the list of invokers is changed. | Please consider load factor. `this.urlInvokerMap.size() / 0.75f + 1` would reduce one time resize. |
@@ -301,7 +301,7 @@ public class UnitSupportAttachment extends DefaultAttachment {
return offence;
}
- public String getBonusType() {
+ public Tuple<Integer, String> getBonusType() {
return bonusType;
}
| [UnitSupportAttachment->[getTargets->[get,getUnitType],setOldSupportCount->[get,setNumber],addTarget->[get,addUnitTypes,addRule],addRule->[setImpArtTech,setFaction,UnitSupportAttachment,getPlayers,setSide,setPlayers,setBonusType,setNumber,setDice,setBonus]]] | Returns true if the node is offence false if it is bonus false if it is. | I'd encourage using lombok here, in that case there would be no need to update the getter. |
@@ -110,7 +110,7 @@ class Index:
yield from stage.outs
@property
- def decorated_outputs(self) -> Iterator["Output"]:
+ def decorated_outs(self) -> Iterator["Output"]:
for output in self.outs:
if output.is_decorated:
yield output
| [Index->[build_graph->[build_graph],slice->[filter],dumpd->[dump->[dumpd],dump],identifier->[dumpd],update->[Index],difference->[Index],discard->[remove],remove->[Index],add->[update],check_graph->[build_graph],filter->[Index,filter],_discard_stage->[remove]],build_graph,Index,update] | Iterate over all decorated outputs. | Trying to keep it consistent with `outs`. |
@@ -296,9 +296,6 @@ func (u *User) GenerateRandomAvatar() error {
if err != nil {
return fmt.Errorf("RandomImage: %v", err)
}
- // NOTICE for random avatar, it still uses id as avatar name, but custom avatar use md5
- // since random image is not a user's photo, there is no security for enumable
- u.Avatar = fmt... | [GenerateRandomAvatar->[CustomAvatarPath],NewGitSig->[getEmail],AvatarLink->[RelAvatarLink],RelAvatarLink->[CustomAvatarPath,GenerateRandomAvatar],GetOrganizationCount->[getOrganizationCount],GetAccessRepoIDs->[GetRepositoryIDs,GetOrgRepositoryIDs],APIFormat->[getEmail],IsPasswordSet->[ValidatePassword],DeleteAvatar->[... | GenerateRandomAvatar generates a random avatar for the user. | This line will fix when u.Avatar is empty, then line 305 `fw, err := os.Create(u.CustomAvatarPath())` will create an avatars file. This bug is reported by #1114. |
@@ -147,7 +147,7 @@ func newManaged(
router,
&pipeline.ConfigModifiers{
Decorators: []pipeline.DecoratorFunc{modifiers.InjectMonitoring},
- Filters: []pipeline.FilterFunc{filters.StreamChecker, modifiers.InjectFleet(rawConfig, sysInfo.Info(), agentInfo)},
+ Filters: []pipeline.FilterFunc{filters.Str... | [Start->[Ack,Warnf,Start,wasUnenrolled,Info,ReloadID],wasUnenrolled->[Type,Actions],Routes->[Routes],Stop->[Shutdown,cancelCtxFn,Info,Stop],Host,Actions,Info,NewPolicyReassign,NewReporter,NewUpgrade,ReplayActions,NewAcker,New,AgentStateStoreFile,AgentCapabilitiesPath,Start,AgentActionStoreFile,Errorf,InjectFleet,NewFro... | Starts the GRPC listener for the managed agent. File returns the last action ID found in the action store. | This seems like it will affect more than just Fleet Server running under Elastic Agent, it will also affect all the other beats, correct? If this does affect the other beats, I don't think we want this, because how will this work when it comes to multiple outputs? I believe it will have the effect that if `--insecure` ... |
@@ -1262,9 +1262,9 @@ cont_epoch_discard_one(void *vin)
if (rc > 0) /* Aborted */
rc = -DER_CANCELED;
- D_DEBUG(DB_EPC, DF_CONT": Discard epoch "DF_U64", hdl="DF_UUID": %d\n",
+ D_DEBUG(DB_EPC, DF_CONT": Discard epoch "DF_U64", hdl="DF_UUID": "DF_RC"\n",
DP_CONT(hdl->sch_pool->spc_uuid, hdl->sch_cont->sc_uuid... | [No CFG could be retrieved] | query one node -DER_NOMEM - DSS_NOMEM - DSS_INVALID_ARGS. | (style) line over 80 characters |
@@ -5,8 +5,8 @@ var packagePath = __dirname;
var Package = require('dgeni').Package;
-// Create and export a new Dgeni package called dgeni-example. This package depends upon
-// the jsdoc and nunjucks packages defined in the dgeni-packages npm module.
+// Create and export a new Dgeni package called angularjs. Th... | [No CFG could be retrieved] | Creates and exports a new Dgeni package called dgeni - example. Register the tag - definitions. | A space is missing after the comma. |
@@ -23,11 +23,14 @@ namespace System.Net.Security.Tests
InvalidClientHello(clientHello, id, shouldPass: false);
}
- [Theory]
- [MemberData(nameof(InvalidClientHelloDataTruncatedBytes))]
- public void SniHelper_TruncatedData_Fails(int id, byte[] clientHello)
+ [Fact]
+... | [TlsFrameHelperTests->[InvalidClientHelloData->[InvalidClientHello],InvalidClientHelloDataTruncatedBytes->[InvalidClientHello]]] | Missing clientHello data. | So now if one of the test fails we won't know which one and also the rest of them won't get executed. If we're fine with this, no problem. I'm just making sure all the side-effects are understood and agreed on. |
@@ -323,7 +323,7 @@ func NewApplication(config *orm.Config, ethClient eth.Client, advisoryLocker pos
Scheduler: services.NewScheduler(store, runManager),
Store: store,
OCRKeyStore: ocrKeyStore,
- SessionReaper: services.NewStoreReaper(store),
+ Sessio... | [NewBox->[NewBox],ArchiveJob->[ArchiveJob],stop->[Stop],Start->[Start],AddServiceAgreement->[AddJob],AddJob->[AddJob]] | Register the application with the chainlink. Connection - connect to the application. | This had a misleading name |
@@ -0,0 +1,10 @@
+module ContentHelper
+ def split_tag(value, delimiter)
+ if value.is_a? Array
+ return value unless value.join.include? delimiter
+ value.flat_map { |str| str.partition(delimiter) }.reject(&:empty?)
+ else
+ value.to_s.partition(delimiter).reject(&:empty?)
+ end
+ end
+end
| [No CFG could be retrieved] | No Summary Found. | Looks like this is not needed. I simplified this to `return value` and all tests passed. This is because the array never includes the delimiter because the array has escaped quotes, but the delimiter does not, which doesn't matter because it works without having to do any further processing. Alternatively, we might wan... |
@@ -2410,7 +2410,13 @@ public abstract class AbstractFlashcardViewer extends NavigationDrawerActivity i
Timber.w("fillFlashCard() called with no card content");
return;
}
- final String cardContent = mCardContent;
+
+ // jsAddonContent assigned in onCreate called getEnab... | [AbstractFlashcardViewer->[MyWebView->[onOverScrolled->[onOverScrolled],onScrollChanged->[onScrollChanged],onTouchEvent->[onTouchEvent],loadDataWithBaseURL->[loadDataWithBaseURL],findScrollParent->[findScrollParent]],LinkDetectingGestureDetector->[executeTouchCommand->[processCardAction],onWebViewCreated->[executeTouch... | fill flash card with content. | efficiency: I think we'll be able to move this to improve the performance hit |
@@ -201,7 +201,7 @@ namespace System.Diagnostics
return null;
}
- private static Stream? TryOpenFile(string? path)
+ private static Stream? TryOpenFile(string path)
{
if (!File.Exists(path))
{
| [StackTraceSymbols->[TryOpenReaderFromAssemblyFile->[TryGetPEReader],TryOpenReaderForInMemoryPdb->[Dispose]]] | Try to open a MetadataReaderProvider from an assembly file. | File.Exists doesn't accept null? If we make this non-nullable, we can remove the `!` from the call to create a new `FileStream` on path. |
@@ -215,7 +215,11 @@ func NewContainerMetadataEnricher(
id := join(pod.GetObjectMeta().GetNamespace(), pod.GetObjectMeta().GetName(), container.Name)
m[id] = meta
+ if s, ok := statuses[container.Name]; ok {
+ PerfMetrics.ContainerID.SetStringVal(cuid, s.ContainerID)
+ }
}
+
},
// delete... | [Start->[Start,Lock,Unlock,Warn],Stop->[Stop,Lock,Unlock],Enrich->[DeepUpdate,RLock,Delete,GetValue,Clone,RUnlock,index],Value,Unlock,NewConfigFrom,GroupVersionKind,GetObjectMeta,NewServiceMetadataGenerator,GetPodMetaGen,ParseQuantity,Info,GetDefaultResourceMetadataConfig,Set,GetKubernetesClient,AddEventHandler,NewReso... | func creates a new metadata object that will store the metadata for the specified pod. getResourceMetadataWatchers returns a function that returns a enricher that will watch the resource. | Wondering if we could avoid using the cache for this and use `meta` directly. |
@@ -4541,7 +4541,13 @@ def relu(x, alpha=0., max_value=None, threshold=0):
Returns:
A tensor.
"""
-
+ if isinstance(x, (ops.Tensor,
+ variables_module.Variable,
+ sparse_tensor.SparseTensor,
+ np.ndarray)):
+ dtype = x.dtype
+ else:
+ dtype =... | [var->[cast],all->[cast],batch_set_value->[get_session,placeholder,dtype,get_graph],gradients->[gradients],argmin->[argmin],set_value->[get_session,placeholder,dtype,get_graph],repeat->[ndim],gather->[gather],binary_crossentropy->[_constant_to_tensor,log],resize_images->[constant,permute_dimensions,shape,int_shape],_br... | Rectified linear unit. | Just curious why we need to do the type check here, shouldn't it always use the input dtype? |
@@ -303,9 +303,7 @@ class TestSubsystem(GoalSubsystem):
help=(
"Additional environment variables to include in test processes. "
"Entries are strings in the form `ENV_VAR=value` to use explicitly; or just "
- "`ENV_VAR` to copy the value of a variable in Pan... | [enrich_test_result->[EnrichedTestResult],run_tests->[Test,materialize],get_filtered_environment->[TestExtraEnv],CoverageReports->[artifacts->[get_artifact],materialize->[materialize]]] | Register options for the test runner. | The last two sentences seem like superfluous details to me. I think most people would expect for spaces to work, right? |
@@ -112,7 +112,7 @@ type VirtualContainerHostConfigSpec struct {
// FIXME: remove following attributes after change to launch through tether
// Networks represents mapping between nic name and network info object. For example: bridge: vmomi object
- Networks map[string]*NetworkInfo `vic:"0.1" scope:"read-only" ke... | [No CFG could be retrieved] | RegistryBlacklist is used to blacklist all of the attributes of a managed object. CustomerExperienceImprovementProgram provides configuration for phone home mechanism. | Why are we doing this? |
@@ -94,12 +94,8 @@ public class MessageEnricher extends AbstractMessageProcessorOwner implements No
}
public void setEnrichmentMessageProcessor(Processor enrichmentProcessor) {
- if (!(enrichmentProcessor instanceof MessageProcessorChain)) {
- this.enrichmentProcessor = MessageProcessors.singletonChain(... | [MessageEnricher->[addMessageProcessorPathElements->[addMessageProcessorPathElements],process->[process],EnricherProcessor->[processResponse->[getSource,getTarget,enrich],processBlocking->[processBlocking]],enrich->[enrich],setMessageProcessor->[setEnrichmentMessageProcessor]]] | Set the enrichment message processor. | Why not use the new method in LifecycleUtils here? |
@@ -533,7 +533,7 @@ namespace ProtoFFI
{
try
{
- targetDict[key] = Convert.ChangeType(d.ValueAtKey(key), valueType);
+ targetDict[key] = d.ValueAtKey(key);
}
catch (Exception e)
{
| [PointerValueComparer->[GetHashCode->[GetHashCode]],CharMarshaler->[CreateType],BoolMarshaler->[CreateType],CLRObjectMarshaler->[UnMarshal->[UnMarshal],CreateCLRObject->[BindObjects],GetUserDefinedType->[CreateType],GeneratePrimaryPropertiesAsXml->[GeneratePrimaryPropertiesAsXml,GetPrimaryProperties],FFIObjectMarshaler... | This method converts a StackValue to a generic IDictionary. | I don't see any necessity for the type conversion in this case. This conversion was throwing the error for the input object (DesignScript.Builtin.Dictionary) not being an IConvertible in the first place. |
@@ -4,7 +4,7 @@ class Api::UserProgramsController < ApplicationController
def index(page: nil)
@programs = current_user.
programs.
- unchecked.
+ unwatched.
work_published.
episode_published.
where('started_at < ?', Date.tomorrow + 1.day + 5.hours).
| [index->[page],before_action] | Returns a list of all nagios that are available for the current user. | Align `unwatched` with `current_user.` on line 5. |
@@ -450,7 +450,7 @@ func (b *Beat) loadMeta() error {
}
metaPath := paths.Resolve(paths.Data, "meta.json")
- logp.Info("Beat metadata path: %v", metaPath)
+ logp.Debug("beat", "Beat metadata path: %v", metaPath)
f, err := openRegular(metaPath)
if err != nil && !os.IsNotExist(err) {
| [launch->[createBeater,Init],TestConfig->[createBeater,Init],Setup->[createBeater,Init],createBeater->[BeatConfig],configure->[Init,BeatConfig]] | loadMeta loads the meta data from the file. | Are you sure you want to also move this one to `Debug`? |
@@ -90,7 +90,7 @@ bio_log_csum_err(struct bio_xs_context *bxc, int tgt_id)
/* Call internal method to get BIO device state from the device owner xstream */
int
-bio_get_dev_state(struct bio_dev_state *dev_state, struct bio_xs_context *xs)
+bio_get_dev_state(struct nvme_health_stats *dev_state, struct bio_xs_context... | [bio_bs_monitor->[collect_raw_health_data,auto_detect_faulty,D_ASSERT,D_ERROR,bio_bs_state_transit],bio_get_dev_state->[spdk_thread_send_msg,ABT_eventual_create,owner_thread,ABT_eventual_wait,ABT_eventual_free,dss_abterr2der],int->[DAOS_FAIL_CHECK,bio_bs_state_set],bio_init_health_monitoring->[spdk_bdev_open,spdk_bdev_... | This function is used to get the dev_state of a bio. | (style) line over 80 characters |
@@ -586,5 +586,16 @@ template class GenericSmallStrainDplusDminusDamage<GenericTensionConstitutiveLaw
template class GenericSmallStrainDplusDminusDamage<GenericTensionConstitutiveLawIntegratorDplusDminusDamage<DruckerPragerYieldSurface<VonMisesPlasticPotential<6>>>, GenericCompressionConstitutiveLawIntegratorDplusDmin... | [No CFG could be retrieved] | VonMisesPlasticPotentials are the real objects of the various types of t. | We need to find the way to do more automatic these combinations. Maybe using some macros magic @roigcarlo ? |
@@ -206,7 +206,8 @@ func LegacyStorage(storage map[schema.GroupVersion]map[string]rest.Storage) map[
case "deploymentConfigs":
restStorage := s.(*deploymentconfigetcd.REST)
store := *restStorage.Store
- restStorage.DeleteStrategy = orphanByDefault(store.DeleteStrategy)
+ store.CreateStrategy = ... | [Has,NewString] | LegacyStorage returns a legacy storage for the given version. GarbageCollectionPolicy returns a garbage collection policy that deletes all resources that are not referenced by. | I have my doubts about if this ever worked - `restStorage` should have been `store` |
@@ -497,8 +497,6 @@ vn_open(char *path, int x1, int flags, int mode, vnode_t **vpp, int x2, int x3)
#ifdef __linux__
flags |= O_DIRECT;
#endif
- /* We shouldn't be writing to block devices in userspace */
- VERIFY(!(flags & FWRITE));
}
if (flags & FCREAT)
| [No CFG could be retrieved] | This function is called from the constructor to get the correct from the system. FREAD and FWRITE can map combinations of * FREAD and FWRITE to. | Out of curiosity, what is this for? Is this related somehow to the rest of the checkpoint changes? |
@@ -96,6 +96,14 @@ var (
Name: "tso",
Help: "Counter of tso events",
}, []string{"type"})
+
+ storeStatusGauge = prometheus.NewGaugeVec(
+ prometheus.GaugeOpts{
+ Namespace: "pd",
+ Subsystem: "schedule",
+ Name: "store_status",
+ Help: "Store status for schedule",
+ }, []string... | [NewCounterVec,NewGaugeVec,ExponentialBuckets,NewHistogramVec,NewCounter,MustRegister] | init registers metrics for the n - node hotspot. | Make it `namespace, store, type`, we need filter stores by namespace. |
@@ -2,6 +2,7 @@
* Originally written by Xinef - Copyright (C) 2016+ AzerothCore <www.azerothcore.org>, released under GNU AGPL v3 license: https://github.com/azerothcore/azerothcore-wotlk/blob/master/LICENSE-AGPL3
*/
+#include "CreatureTextMgr.h"
#include "ScriptMgr.h"
#include "ScriptedCreature.h"
#include "Sp... | [boss_auriaya->[boss_auriayaAI->[UpdateAI->[DoAction],Reset->[Reset]]]] | A list of all the names of the fields of a given header file. Enumerates the properties of a given . The ethernet event type for the ethernet event. | This file shouldn't be included in this pull request. |
@@ -104,6 +104,13 @@ public class ProcessEntryPoint implements Stoppable {
Thread.sleep(20L);
}
+ // this property is set by the agent management-agent.jar enabled by org.sonar.process.monitor.JavaProcessLauncher.
+ String jmxUrl = VMSupport.getAgentProperties().getProperty("com.sun.manageme... | [ProcessEntryPoint->[createForArguments->[getProcessNumber,ProcessEntryPoint,getSharedDir],launch->[getKey],getState->[getState]]] | Launches the process. | this block could be in a method |
@@ -87,7 +87,8 @@ namespace ProtoCore.DSASM
IsExplicitCall = false;
Validity.Assert(core != null);
this.core = core;
- enableLogging = core.Options.Verbose;
+ this.runtimeCore = core.__TempCoreHostForRefactoring;
+ enableLogging = runtimeCore.Runti... | [No CFG could be retrieved] | The interpreter properties for the nested language blocks. Bounce explicit. | I was wondering if we could just name it `RuntimeCore.Options`? |
@@ -845,8 +845,13 @@ namespace ProtoFFI
argumentSignature.AddArgument(paramNode);
}
- argumentSignature.IsVarArg = parameters.Any()
- && parameters.Last().GetCustomAttributes(typeof(ParamArrayAttribute), false).Any();
+ var t = parameters.Any();
+
+ ... | [CLRModuleType->[ParseMethod->[isPropertyAccessor,GetProtoCoreType,isOverloadedOperator],FunctionDefinitionNode->[SupressesImport,GetProtoCoreType],GetProtoCoreType->[GetProtoCoreType],ClassDeclNode->[SetTypeAttributes],ParseArgumentDeclaration->[GetProtoCoreType],RegisterFunctionPointer->[GetFunctionPointers],Supresse... | Parse the argument signature for a given method. | please don't use variable names like this - it makes searching for them in a regular text editor or github ui impossible and makes understanding intent just as hard. Is this used somewhere? |
@@ -81,6 +81,8 @@ class Experiments:
self.experiments[expId]['status'] = 'INITIALIZED'
self.experiments[expId]['fileName'] = file_name
self.experiments[expId]['platform'] = platform
+ self.experiments[expId]['authorName'] = author_name
+ self.experiments[expId]['experimentName']... | [Experiments->[remove_experiment->[write_file],update_experiment->[write_file],add_experiment->[write_file],__init__->[read_file]]] | Add an experiment to the experiment list. | what is `author_name` used for? |
@@ -563,13 +563,13 @@ static void *dh_pkey_export_to(const EVP_PKEY *pk, EVP_KEYMGMT *keymgmt)
return NULL;
ossl_param_bld_init(&tmpl);
- if (!ossl_param_bld_push_BN(&tmpl, OSSL_PKEY_PARAM_DH_P, p)
- || !ossl_param_bld_push_BN(&tmpl, OSSL_PKEY_PARAM_DH_G, g)
+ if (!ossl_param_bld_push_BN(&t... | [DHparams_print->[do_dh_print],int->[EVP_CIPHER_CTX_type,ASN1_STRING_length,i2d_X509_ALGOR,EVP_CIPHER_type,BN_cmp,DH_security_bits,BIO_puts,DH_size,ASN1_STRING_get0_data,EVP_PKEY_CTX_set_dh_kdf_md,BN_to_ASN1_INTEGER,EVP_PKEY_derive_set_peer,EVP_CIPHER_param_to_asn1,BN_dup,BN_get_flags,i2d_DHparams,BN_num_bits,EVP_PKEY_... | This method is called from the export to export the private key to the keymgmt. | Do we really want `OSSL_PKEY_PARAM`s? I realise that there is no option at the moment, but we're trying to move away from PKEY. |
@@ -209,7 +209,7 @@ namespace System.Net.Http.QPack
if (buffer.Length > 0)
{
- int valueLength = separator.Length * (values.Length - 1);
+ int valueLength = separator!.Length * (values.Length - 1);
for (int i = 0; i < values.Length; ++i)
... | [QPackEncoder->[EncodeLiteralHeaderFieldWithoutNameReferenceToArray->[EncodeLiteralHeaderFieldWithoutNameReference],EncodeValueString->[EncodeValueString],Encode->[Encode,EncodeLiteralHeaderFieldWithoutNameReference],EncodeStaticIndexedHeaderFieldToArray->[EncodeStaticIndexedHeaderField],EncodeLiteralHeaderFieldWithSta... | Encode the values of a header list into a string. | The same as for EncodeStringLiterals(). Why is the separator defined as nullable if it is used as non-nullable? |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.