patch stringlengths 18 160k | callgraph stringlengths 4 179k | summary stringlengths 4 947 | msg stringlengths 6 3.42k |
|---|---|---|---|
@@ -70,7 +70,7 @@ echo "
<span class='box-desc'>$desc</span>
</td>
<td>
- <span class='box-desc'>".date('r',$service['service_changed'])."</span>
+ <span class='box-desc'>".date('r',$service['service_checked'])."</span>
</td>
</tr>";
| [No CFG could be retrieved] | It is a table with the last n - th element. | Shouldn't this just be `<span class='box-desc'>$checked</span>`? |
@@ -864,18 +864,6 @@ class Target(AbstractTarget):
"""
return self.closure_for_targets([self], *vargs, **kwargs)
- # TODO(Eric Ayers) As of 2/5/2015 this call is DEPRECATED and should be removed soon
- def add_labels(self, *label):
- self.labels.update(label)
-
- # TODO(Eric Ayers) As of 2/5/2015 this... | [Target->[sources_relative_to_buildroot->[has_sources],strict_dependencies->[_resolve_strict_dependencies],id->[compute_target_id],compute_dependency_specs->[_validate_target_representation_args],create_sources_field->[supports_default_sources,default_sources],exports->[_get_synthetic_target],sources_relative_to_source... | Returns this target s transitive dependencies. | Would it be ok to leave this method here as a noop with a deprecation warning? I suspect that because it was deprecated pre-deprecation warnings, some folks might not have gotten the message. |
@@ -97,8 +97,8 @@ class StorageChangeFeedTest(StorageTestCase):
@GlobalStorageAccountPreparer()
def test_get_change_feed_events_in_a_time_range(self, resource_group, location, storage_account, storage_account_key):
cf_client = ChangeFeedClient(self.account_url(storage_account, "blob"), storage_accoun... | [StorageChangeFeedTest->[test_get_change_feed_events_in_a_time_range->[list,ChangeFeedClient,account_url,datetime,assertIsNot,len,list_changes,next],test_get_change_feed_events_by_page->[assertTrue,list,ChangeFeedClient,assertNotEqual,account_url,one_page,assertEqual,extend,len,list_changes,range,next,merged_two_pages]... | Get change feed events in a time range. | In Java and C# we made these tests playback-only. is it a possibility in python? |
@@ -334,7 +334,6 @@ static void MangleVarRefString(char *ref_str, size_t len)
*ns = CF_MANGLED_NS;
ref_str2 = ns + 1;
upto -= (ns + 1 - ref_str);
- assert(upto >= 0);
}
bool mangled_scope = false;
| [No CFG could be retrieved] | Mangles a variable reference string. Lookup a variable within the given iteration context. | This is a compiler warning, not a user facing change. Please remove the changelog entry. (`Changelog: None`). |
@@ -108,6 +108,11 @@ var (
portMapper portmap.PortMapper
+ // bridge-to-bridge rules, indexed by mapped port;
+ // this map is used to delete the rule once
+ // the container stops or is removed
+ btbRules map[string][]string
+
cbpLock sync.Mutex
containerByPort map[string]string // port:containerID
... | [containerAttach->[Handle],findPortBoundNetworkEndpoint->[defaultScope],containerStart->[Handle,cleanupPortBindings]] | Initialization of the object Count the containers in the system. | Don't we need a mutex to protect this map from concurrent access? |
@@ -1553,6 +1553,8 @@ class SequenceNumericColumnTest(test.TestCase, parameterized.TestCase):
self.assertEqual(column.shape, (2,))
self.assertEqual(column.default_value, 3)
self.assertEqual(column.normalizer_fn(3), 45)
+ with self.assertRaises(ValueError):
+ serialization.serialize_feature_column... | [SequenceCategoricalColumnWithIdentityTest->[test_get_sparse_tensors->[_get_sparse_tensors,_assert_sparse_tensor_value]],SequenceCategoricalColumnWithVocabularyFileTest->[test_get_sparse_tensors->[_get_sparse_tensors,_assert_sparse_tensor_value],test_get_sparse_tensors_dynamic_zero_length->[_get_sparse_tensors,_initial... | Tests that the column can be serialized. | Thanks-- can you use assertRaisesRegex to ensure the error caught is the one expected? |
@@ -45,6 +45,9 @@ public class BulkActionDescriptor implements Descriptor {
@XNode("@httpEnabled")
public Boolean httpEnabled = Boolean.FALSE;
+ @XNode("@sequentialCommands")
+ public Boolean sequentialCommands = Boolean.FALSE;
+
@Override
public String getId() {
return name;
| [No CFG could be retrieved] | Returns the id of the . | Java spliterators use the term "ordered" for that, I think it's better. What do you think? |
@@ -316,6 +316,13 @@ public abstract class HoodieTable<T extends HoodieRecordPayload, I, K, O> implem
return getActiveTimeline().getCleanerTimeline();
}
+ /**
+ * Get rollback timeline.
+ */
+ public HoodieTimeline getRollbackTimeline() {
+ return getActiveTimeline().getRollbackTimeline();
+ }
+
... | [HoodieTable->[getSliceView->[getFileSystemView],deleteInvalidFilesByPartitions->[delete],requireSortedRecords->[getBaseFileFormat],getBaseFileOnlyView->[getFileSystemView],getHoodieView->[getFileSystemView],validateSchema->[getMetaClient],validateUpsertSchema->[validateSchema],validateInsertSchema->[validateSchema],ge... | getCleanTimeline - Gets the clean timeline of the current savepoint timeline. | we should avoid these sort of helpers unless one exists for each of the other actions. if not, lets remove |
@@ -70,10 +70,12 @@ public class DeflectorResource extends RestResource {
@Produces(MediaType.APPLICATION_JSON)
@Deprecated
public DeflectorSummary deprecatedDeflector() throws TooManyAliasesException {
- final IndexSet indexSet = indexSetRegistry.getDefault()
- .orElseThrow(() -> n... | [DeflectorResource->[checkCycle->[isWritable,title,id,BadRequestException],deprecatedCycle->[checkCycle,orElseThrow,write,Activity,NotFoundException,info,cycle,id],deflector->[isUp,getIndexSet,create,getCurrentActualTargetIndex],cycle->[getIndexSet,checkCycle,write,Activity,info,cycle],deprecatedDeflector->[create,orEl... | Get current deflector status. | I would throw an `InternalServerErrorException` here (or simply let the `IllegalStateException` bubble up which results in the same) because it's actually an error in the Graylog system, not a wrong request by the client. |
@@ -54,7 +54,7 @@ module GobiertoCommon
assert has_message?("Vocabulary updated successfully.")
- click_link vocabulary.name
+ find(:xpath, %Q{//a[@href="#{edit_admin_common_vocabulary_path(vocabulary)}"]}).click
assert has_field? "vocabulary_name_tr... | [UpdateVocabularyTest->[site->[sites],test_permissions->[visit,with_signed_in_admin,has_content?,assert_equal,assert,with_current_site],unauthorized_admin->[gobierto_admin_admins],vocabulary->[gobierto_common_vocabularies],test_update_vocabulary->[visit,fill_in,within,with_signed_in_admin,has_message?,click_button,with... | This test is used to test if the vocabulary has an update and not the name translations en. | Use % instead of %Q.<br>%Q-literals should be delimited by ( and ). |
@@ -39,7 +39,7 @@ class NotifyMailerPreview < ActionMailer::Preview
end
def tag_moderator_confirmation_email
- NotifyMailer.tag_moderator_confirmation_email(User.first, Tag.find(1))
+ NotifyMailer.tag_moderator_confirmation_email(User.last, Tag.find(1), nil)
end
def trusted_role_email
| [NotifyMailerPreview->[tag_moderator_confirmation_email->[tag_moderator_confirmation_email],account_deleted_email->[account_deleted_email],new_reply_email->[new_reply_email],unread_notifications_email->[unread_notifications_email],new_mention_email->[new_mention_email],video_upload_complete_email->[video_upload_complet... | Find a tag moderator confirmation email that can be sent to. | Just curious what the reasoning is for changing this to `User.last`. |
@@ -56,11 +56,11 @@ public final class RedisSplit
@JsonProperty("nodes") List<HostAddress> nodes)
{
this.schemaName = requireNonNull(schemaName, "schemaName is null");
- this.tableName = requireNonNull(tableName, "dataFormat is null");
- this.keyDataFormat = requireNonNull(keyDa... | [RedisSplit->[toString->[toString],toRedisDataType,copyOf,requireNonNull]] | Creates a RedisSplit for a given . DataFormat - Json property for a single node. | this one also needs update |
@@ -36,10 +36,10 @@ class Fire(nn.Module):
class SqueezeNet(nn.Module):
- def __init__(self, version='1_0', num_classes=1000):
+ def __init__(self, arch, num_classes=1000):
super(SqueezeNet, self).__init__()
self.num_classes = num_classes
- if version == '1_0':
+ if arch == 's... | [SqueezeNet->[__init__->[Fire]],squeezenet1_1->[_squeezenet],_squeezenet->[SqueezeNet],squeezenet1_0->[_squeezenet]] | SqueezeNet constructor. Missing - model - related parameters. | This is a BC-breaking change. It's fine to do it for `ShuffleNetV2` because it hasn't been in any release yet, but SqueezeNet has been around for a while and this will break user code who relied on `SqueezeNet`. |
@@ -146,7 +146,7 @@
<maven-compiler-plugin.version>3.8.1</maven-compiler-plugin.version>
<maven-javadoc-plugin.version>3.3.1</maven-javadoc-plugin.version>
<maven-eclipse-plugin.version>2.10</maven-eclipse-plugin.version>
- <maven-enforcer-plugin.version>3.0.0</maven-enforcer-plugin.ve... | [No CFG could be retrieved] | Returns a list of all possible versions of the plugin. Find all possible version - dependent components. | Can you point a bug report to show the error. Otherwise we should keep the release version. |
@@ -315,4 +315,4 @@ class _NativeWrite(ptransform.PTransform):
def expand(self, pcoll):
self._check_pcollection(pcoll)
- return pvalue.PDone(pcoll.pipeline)
+ return pvalue.PValue(pcoll.pipeline)
| [NativeSource->[__repr__->[_dict_printable_fields]],NativeSink->[__repr__->[_dict_printable_fields]]] | Expand a pipeline collection. | Perhaps they don't need to return anything at all (i.e. None)? |
@@ -398,7 +398,7 @@ namespace DotNetNuke.Services.Upgrade.Internals
XmlAttribute secureAttrib = settingNode.Attributes["Secure"];
if ((secureAttrib != null))
{
- if (secureAttrib.Value.ToLower() == "tru... | [InstallControllerImpl->[TestDatabaseConnection->[TestDatabaseConnection]]] | Get the install config that is available in the current environment. This function parses the node in the install template and adds it to the configuration object. This function parses the configuration nodes that are not present in the installation tree. | Please use `String#Equals(String, StringComparison)` |
@@ -785,9 +785,9 @@ public class StreamingDataflowWorker {
0,
options.getWindmillHarnessUpdateReportingPeriod().getMillis());
+ refreshWorkTimer = new Timer("RefreshWork");
if (options.getActiveWorkRefreshPeriodMillis() > 0) {
- refreshActiveWorkTimer = new Timer("RefreshActiveWork");
-... | [StreamingDataflowWorker->[MetricsDataProvider->[appendSummaryHtml->[weight,size,printActiveWork]],buildExceptionReport->[buildExceptionReport],buildWorkItemTruncationRequest->[initializeOutputBuilder],getWork->[getWork],schedulePeriodicGlobalConfigRequests->[sleep],callFinalizeCallbacks->[run],streamingCommitLoop->[po... | Starts the thread that will periodically report the current state of the workers and other dataflow workers reportHarnessStartup - Report Harness startup. | might be good to get @dpmills to review this code |
@@ -238,6 +238,12 @@ public class DefaultHttp2ConnectionEncoder implements Http2ConnectionEncoder {
"Stream %d in unexpected state: %s", stream.id(), stream.state()));
}
}
+
+ if (lastDataWrite != null && !endOfStream) {
+ throw ne... | [DefaultHttp2ConnectionEncoder->[Builder->[build->[DefaultHttp2ConnectionEncoder]],writeSettings->[writeSettings],writePriority->[writePriority],newBuilder->[Builder],writeWindowUpdate->[writeWindowUpdate],initialOutboundWindowSize->[initialOutboundWindowSize],configuration->[configuration],writeRstStream->[writeRstStr... | Writes the given headers to the given stream. | What about continuation frames? Do we even send continuation frames or are we queuing up header writes until the endofstream happens somewhere? |
@@ -76,10 +76,10 @@ export default Component.extend({
$target.hasClass("modal-middle-container") ||
$target.hasClass("modal-outer-container")
) {
- // Delegate click to modal close if clicked outside.
- // We do this because some CSS of ours seems to cover
- // the backdrop and makes i... | [No CFG could be retrieved] | On modal modal hide the modal and close the modal. Makes sure the previous subtitle of another modal is not used. | sendAction should be avoided |
@@ -48,4 +48,8 @@ module AssignTagModerator
Rails.cache.delete("user-#{user.id}/tag_moderators_list")
MailchimpBot.new(user).manage_tag_moderator_list
end
+
+ def self.chat_channel_slug(tag)
+ tag.mod_chat_channel&.slug
+ end
end
| [add_to_chat_channels->[create_with_users,mod_chat_channel_id,id,add_users,update_column,uniq,none?,name],remove_tag_moderator->[email_tag_mod_newsletter,manage_tag_moderator_list,remove_role,update,id,delete],add_tag_mod_role->[email_tag_mod_newsletter,manage_tag_moderator_list,update,add_role,id,delete],add_tag_moder... | Remove a tag moderator from a user. | We need to pass the chat channel slug through the email now if there is one to point the user to the new channel that they were added to |
@@ -1135,6 +1135,7 @@ static void KeepPromiseBundles(EvalContext *ctx, const Policy *policy, GenericAg
break;
}
+ const Bundle *bp = NULL;
if ((bp = PolicyGetBundle(policy, NULL, "agent", name)) || (bp = PolicyGetBundle(policy, NULL, "common", name)))
{
Bann... | [No CFG could be retrieved] | Find the n - class entry in the bundlesequence and evaluate it. This function is called from the main function of allclasses. It writes the allclasses cache. | Any chance of splitting after the || here ? Lining up the two conditions would make it easier to see what they have in common and where they differ ... |
@@ -381,6 +381,9 @@ class LivenessVisitor(BaseAnalysisVisitor):
def visit_assign(self, op: Assign) -> GenAndKill:
return set(op.sources()), {op.dest}
+ def visit_set_mem(self, op: SetMem) -> GenAndKill:
+ return set(op.sources()), {op.dest}
+
def analyze_live_regs(blocks: List[BasicBlock],
... | [analyze_maybe_defined_regs->[DefinedVisitor],analyze_live_regs->[LivenessVisitor],analyze_borrowed_arguments->[BorrowedArgumentsVisitor],cleanup_cfg->[get_real_target,get_cfg],analyze_must_defined_regs->[DefinedVisitor],run_analysis->[AnalysisResult],get_cfg->[CFG],analyze_undefined_regs->[UndefinedVisitor],BaseAnalys... | Visits an Assign instruction. | `op.dest` is a pointer so we don't do anything to it, just the memory pointed to by it. Since we don't track properties of memory locations, the second item of the return value should be empty. |
@@ -32,7 +32,7 @@ namespace System.Reflection.TypeLoading
private static readonly Version s_Version0000 = new Version(0, 0, 0, 0);
- public RoAssemblyName(string name, Version version, string cultureName, byte[] publicKeyToken, AssemblyNameFlags flags)
+ public RoAssemblyName(string? name, Ve... | [RoAssemblyName->[Equals->[Equals],GetHashCode->[GetHashCode]]] | Creates an object that represents an object in the system that represents a single object in the system missing public key token. | Isn't assert mean `name` shouldn't be nullable? Which means `Name` non null and below GetHashCode() wouldn't need bang |
@@ -150,9 +150,9 @@ namespace System.Text.RegularExpressions
public RegexNode ReverseLeft()
{
- if (UseOptionR() && NType == Concatenate && Children != null)
+ if (UseOptionR() && Type == Concatenate && ChildCount() > 1)
{
- Children.Reverse(0, Child... | [RegexNode->[Description->[IgnoreCase,Append,MaxValue,RightToLeft,SetDescription,Singleline,Multiline,ExplicitCapture,ToString,CharDescription,InvariantCulture,ECMAScript,IgnorePatternWhitespace],Dump->[Next,Count,WriteLine,Description,Substring,Children,Add,RemoveAt],AddChild->[Next,Reduce,Add],UseOptionR->[RightToLef... | Reverse left. | Is the cast here always safe? `Children` is going from `List<RegexNode>` to `object` now right? It may be safe for now, but `Children` might change in the future? |
@@ -296,8 +296,9 @@ public class JoinNode extends PlanNode implements JoiningNode {
final DataSourceType rightType) {
return joinerMap.getOrDefault(new Pair<>(leftType, rightType), () -> {
- throw new KsqlException("Join between invalid operands requested: left type: "
- + leftType +... | [JoinNode->[SourceJoinKey->[rewriteWith->[SourceJoinKey],of->[SourceJoinKey]],setKeyFormat->[setKeyFormat],validateColumns->[validateColumns],StreamToTableJoiner->[join->[getKeyColumnName,getRight,join,buildStream,buildTable,getLeft]],getPreferredKeyFormat->[getPreferredKeyFormat],SyntheticJoinKey->[getAllViableKeys->[... | Get a joiner for the given left and right data types. | We have a check in the new `verifyJoin` method and thus should never hit this line any longer, ie, the user should never see this error message again. |
@@ -123,6 +123,12 @@ export class LocalSubscriptionPlatformRenderer {
if (expr && evaluateExpr(expr,
/** @type {!JsonObject} */(renderState))) {
candidate.classList.add('i-amphtml-subs-display');
+ if (candidate.hasAttribute('subscriptions-service')) {
+ this.service... | [No CFG could be retrieved] | Determines if there are any actions that should be rendered in the given node. | Attribute could have an empty value. What would happen in this case? |
@@ -74,6 +74,12 @@ T_Address = bytes
AddressHex = HexAddress
+T_UserID = str
+UserID = NewType("UserID", T_UserID)
+
+T_AddressMetadata = Dict[str, Union[UserID, "PeerCapabilities"]]
+AddressMetadata = NewType("AddressMetadata", T_AddressMetadata)
+
T_Balance = int
Balance = NewType("Balance", T_Balance)
| [typecheck->[ValueError,isinstance,type],NewType] | Check if a variable is of the correct type. Create a new type object for the given message. | PeerCapabilities without " ? |
@@ -40,7 +40,7 @@ def list_recipes_cli_formatter(results):
def _list_revisions_cli_formatter(results, ref_type):
for remote_results in results:
_print_common_list_cli_output(remote_results, ref_type)
- reference = remote_results["package_reference" if ref_type == "packages" else "reference"]
+ ... | [list_recipe_revisions->[_add_common_list_subcommands,_get_remotes],list_recipes_cli_formatter->[_print_common_list_cli_output],list_recipe_revisions_cli_formatter->[_list_revisions_cli_formatter],_list_revisions_cli_formatter->[_print_common_list_cli_output],list_package_revisions_cli_formatter->[_list_revisions_cli_f... | List the revisions of a package in the CLI. | This function's name (`_print_common_list_cli_output`) is not very descriptive. How about `_print_remote_header()` or something like that? |
@@ -1,6 +1,8 @@
# frozen_string_literal: true
class PostAlerter
+ USER_BATCH_SIZE = 1000
+
def self.post_created(post, opts = {})
PostAlerter.new(opts).after_save_post(post, true)
post
| [PostAlerter->[notify_group_summary->[group_stats],notify_post_users->[create_notification],allowed_users->[not_allowed?],notify_users->[create_notification],allowed_group_users->[not_allowed?],directly_targeted_users->[allowed_group_users,allowed_users],notify_pm_users->[notify_group_summary,create_notification],indir... | Post created hook. | maybe 100 to keep memory down a tiny bit? |
@@ -33,8 +33,16 @@ internal static partial class Interop
internal int IPAddressCount; // Number of IP addresses in the list
}
+ internal unsafe delegate void GetHostEntryForNameCallback(HostEntry* entry, int status);
+
+ [DllImport(Libraries.SystemNative, EntryPoint = "System... | [Interop->[Sys->[FreeHostEntry->[SystemNative],HostEntry->[Sequential],GetHostEntryForName->[SystemNative]]]] | Finds and frees the host entry for the given host name. | Should this be a function pointer instead? (In the meantime we got C# 9 ). |
@@ -424,4 +424,13 @@ public abstract class AbstractJCache<K, V> implements Cache<K, V> {
protected boolean statisticsEnabled() {
return getConfiguration(CompleteConfiguration.class).isStatisticsEnabled();
}
+
+ @Override
+ public void close() {
+ notifier.close();
+ Closeables.close(this.ex... | [AbstractJCache->[loadAllFromJCacheLoader->[loadAllKeys,setListenerException,setListenerCompletion,filterLoadAllKeys],removeCacheEntryListenerConfiguration->[removeCacheEntryListenerConfiguration],addCacheEntryListenerConfiguration->[addCacheEntryListenerConfiguration],setManagementEnabled->[setManagementEnabled],updat... | Checks if statistics is enabled. | I believe notifier should also be `Closeable`. |
@@ -123,7 +123,7 @@ public class JavaScriptPostAggregator implements PostAggregator
@Override
public Object compute(Map<String, Object> combinedAggregators)
{
- checkAndCompileScript();
+ fn = getCompiledScript();
final Object[] args = new Object[fieldNames.size()];
int i = 0;
for (String ... | [JavaScriptPostAggregator->[checkAndCompileScript->[compile],hashCode->[hashCode],compute->[apply],equals->[equals]]] | Compute the result of the function. | Same as above, either introduce a local variable or just use `getCompiledScript()` in the expression, but don't reassign the volatile field. |
@@ -133,6 +133,9 @@ if ( version_compare( phpversion(), JETPACK__MINIMUM_PHP_VERSION, '<' ) ) {
return;
}
+// Load all the packages.
+require plugin_dir_path( __FILE__ ) . '/vendor/autoload.php';
+
add_filter( 'jetpack_require_lib_dir', 'jetpack_require_lib_dir' );
add_filter( 'jetpack_should_use_minified_assets... | [No CFG could be retrieved] | <?php = > <?php Requires all plugin files. | Would it be an option to use `JETPACK__PLUGIN_DIR` here as well? |
@@ -10,9 +10,12 @@ import (
"errors"
"fmt"
"runtime"
+ "strings"
"time"
"unsafe"
+ "debug/elf"
+
"github.com/coreos/pkg/dlopen"
)
| [close->[Close],my_headerGetString,my_rpmdbNextIterator,my_rpmtsInitIterator,my_rpmtsFree,LockOSThread,my_rpmFreeRpmrc,my_headerFree,New,my_rpmdbFreeIterator,my_headerGetNumber,Errorf,my_rpmsqSetInterruptSafety,Unix,my_rpmtsCreate,UnlockOSThread,close,my_headerLink,GetHandle,GetSymbolPointer,my_rpmFreeMacros,my_rpmRead... | Package private methods Get the next from the RPMDBI_PACKAGES list. | Group this with the other stdlib imports. |
@@ -56,10 +56,10 @@ return [
's3' => [
'driver' => 's3',
- 'key' => 'your-key',
- 'secret' => 'your-secret',
- 'region' => 'your-region',
- 'bucket' => 'your-bucket',
+ 'key' => env('FS_S3_KEY', ''),
+ 'secret' => env('FS_S3_SECRE... | [No CFG could be retrieved] | ViewableViews ethernetViews. | Tempts People to put their secrets directly into the source code that is version controlled. This would be a serious issue. |
@@ -277,6 +277,15 @@ public class HoodieWriteConfig extends DefaultHoodieConfig {
return Integer.parseInt(props.getProperty(HoodieStorageConfig.PARQUET_PAGE_SIZE_BYTES));
}
+ public int getLogFileDataBlockMaxSize() {
+ return Integer.parseInt(props.getProperty(HoodieStorageConfig.LOGFILE_DATA_BLOCK_SIZE_M... | [HoodieWriteConfig->[shouldUseTempFolderForCopyOnWrite->[shouldUseTempFolderForCopyOnWriteForMerge,shouldUseTempFolderForCopyOnWriteForCreate],Builder->[build->[HoodieWriteConfig,getBasePath,build]]]] | This method returns the parquet page size in bytes. | may be `long` to make it future safe? |
@@ -1,6 +1,9 @@
class CourseSummariesController < ApplicationController
include CourseSummariesHelper
+ before_filter :authorize_only_for_admin,
+ only: [:download_csv_grades_report]
+
def index
@assignments = Assignment.all
@marking_schemes = MarkingScheme.all
| [CourseSummariesController->[populate->[render],index->[all],get_marking_scheme_details->[redirect_to,url_for],include]] | This method is called when the user has no permission to access the index for a node. | Unnecessary spacing detected.<br>Put one space between the method name and the first argument. |
@@ -502,8 +502,8 @@ define([
}
// Use of Plane objects will be deprecated.
- // But until then, we have no way of telling if they changed since last frame, so we have to do a full udpate.
- var refreshFullTexture = this._multipleDirtyPlanes || this._containsUntrackablePlanes;
+ ... | [No CFG could be retrieved] | Creates a new image of the specified size with the specified resolution. if we have no nofollow buffer we can use it to fill the buffer with the. | When more than one `ClippingPlane` is updated in between rendered frames, we refresh the entire clipping plane texture instead of just selectively updating a few adjacent pixels. Looks like with the new changes though we can replace all uses of `refreshFullTexture` below with just direct access to `this._multipleDirtyP... |
@@ -1028,6 +1028,11 @@ namespace System.Net.Http
totalBytesRead += bytesRead;
_responseDataPayloadRemaining -= bytesRead;
buffer = buffer.Slice(bytesRead);
+
+ if (_responseDataPayloadRemaining == 0)
+ ... | [Http3RequestStream->[ReadNextDataFrameAsync->[CopyTrailersToResponseMessage],DisposeSyncHelper->[Dispose],OnHeader->[OnHeader],Http3ReadStream->[Read->[ReadResponseContent],Dispose->[Dispose],ReadAsync->[ValueTask,ReadResponseContentAsync],Dispose],Trace->[Trace],Http3WriteStream->[Dispose->[Dispose]],ReadFrameEnvelop... | Reads the response content into the buffer. | ~This is not right. If there are any trailing headers, you'd just leave them in the stream and not read them ever.~ EDIT: I see know that this is called from `Stream.ReadAsync` and will be called multiple times so the trailers will get read eventually. |
@@ -76,7 +76,8 @@ class Dataset:
def as_arrays(self,
padding_lengths: Dict[str, Dict[str, int]] = None,
- verbose: bool = True) -> Dict[str, List[numpy.array]]:
+ verbose: bool = True) -> Dict[str, List[Union[numpy.array,
+ ... | [Dataset->[as_arrays->[get_padding_lengths],get_padding_lengths->[get_padding_lengths]]] | This method converts this dataset into a set of numpy arrays that can be used to fill in This method checks whether we were a given a max length for a particular field and padding The type of the field array is not a type but it s a type of the array. | @joelgrus, is this be another place where generics would work? I'm not sure if it'd be more work than it's worth. Basically, each `Field` would return a `DataArray`, which is either a single array, or a dictionary of arrays, and then this type would be `Dict[str, DataArray]`. |
@@ -64,7 +64,7 @@ static uint64_t get_timer_bits(void);
* macro that might be undefined.
*/
# undef OSSL_POSIX_TIMER_OKAY
-# if defined(_POSIX_TIMERS) && _POSIX_TIMERS > 0
+# if defined(_POSIX_TIMERS) && _POSIX_TIMERS > 0 && !defined(__sun)
# if defined(__GLIBC__)
# if defined(__GLIBC_PREREQ)
# if __GLIBC... | [No CFG could be retrieved] | Macro to convert two thirty two bit values into sixty four bits and convert the two Creates a random number object from the system. | To see the history of the check for `OSSL_POSIX_TIMER_OKAY`, annotate `rand_lib.c`, not `rand_unix.c`. Although git attributes these lines here to me, I only moved them here in 5bc6bcf82d2a. 2b66fd5720c3 Unify timer code (#5231) bed4afa81b9c Fix glibc specific conditional for Mac OS/X (#5269) 4cd58771d838 Fix glibc ver... |
@@ -49,6 +49,9 @@ public class Chat {
private static final String TAG_MODERATOR = "[Mod]";
private final ChatSoundProfile chatSoundProfile;
+ /**
+ * A profile that defines the sounds to use for various chat events.
+ */
public enum ChatSoundProfile {
LOBBY_CHATROOM, GAME_CHATROOM, NO_SOUND
}
| [Chat->[speakerTagUpdated->[addToNotesMap,updateConnections],assertMessageFromServer->[getServerNode],assignNodeTags->[addToNotesMap],slapOccured->[isIgnored,getLocalNode],addChatListener->[updateConnections],getServerNode->[getServerNode],speakerRemoved->[speakerRemoved,assertMessageFromServer,updateConnections],meMes... | private static final int initVersion = - 1 ;. | I would update: "A profile that defines" to "A profile defines" |
@@ -360,8 +360,11 @@ function triggerResizeRequest(width, height) {
nonSensitiveDataPostMessage('embed-size', {width, height});
}
-function triggerRenderStart() {
- nonSensitiveDataPostMessage('render-start');
+/**
+ * {{width, height}=} opt_data
+ */
+function triggerRenderStart(opt_data) {
+ nonSensitiveDataP... | [No CFG could be retrieved] | Registers a callback that will be called when an entity is rendered. VisibilityState - DOM visibility state. | `@param {{width, height}=} opt_data` |
@@ -6643,7 +6643,7 @@ class LinkSaveFlow {
});
}
});
- /** {!Promise<boolean>} */
+ /** @type {!Promise<boolean>} */
return this.dialogManager_.openView(this.activityIframeView_,
/* hidden */ true).then(() => {
return this.activityIframeView_.port().then(port => {
| [ActivityIframeView->[message->[message],onMessage->[onMessage],acceptResult->[acceptResult]],Entitlement->[parseListFromJson->[parseFromJson]],PayStartFlow->[preconnect->[preconnect]],DeferredAccountFlow->[start->[getEntitlementForSource],handleConsentResponse_->[start,complete]],PayCompleteFlow->[configurePending->[s... | Starts the activity iframe view. | are you casting here or just declaring type? |
@@ -133,8 +133,15 @@ func NewPulumiCmd() *cobra.Command {
// Before exiting, if there is a new version of the CLI available, print it out.
jsonFlag := cmd.Flag("json")
isJSON := jsonFlag != nil && jsonFlag.Value.String() == "true"
- if checkVersionMsg := <-updateCheckResult; checkVersionMsg != nil && !isJ... | [StringVar,RawMessage,Dir,Colorize,Executable,Warningf,Now,Encode,HasPrefix,Add,IsTruthy,IgnoreClose,Flush,Stat,ParseTolerant,NewEncoder,New,RunFunc,Diag,StringVarP,NewClient,InitLogging,Run,After,Chdir,AddCommand,LookPath,GetCachedVersionFilePath,Bytes,TrimSpace,AssertNoError,InitProfiling,Join,Wrapf,Infof,Current,Eva... | Check if the version of the command is available and if it is print it out. Flow log settings to child processes. | Not sure if you are still working on it, but I think these changes should now be reverted, right? (It's possible I am incorrect here). |
@@ -498,5 +498,6 @@ export class AmpGwdRuntimeService {
* @param {!Element} element
*/
function reflow(element) {
- element./*OK*/offsetWidth = element./*OK*/offsetWidth;
+ Object.defineProperty(
+ element, 'offsetWidth', {value: element./*OK*/offsetWidth});
}
| [No CFG could be retrieved] | Reflows an element by reflowing its offsetWidth. | This has no chance of working properly. In fact, the original code can't work properly. @dvoytenko |
@@ -133,7 +133,9 @@ public class DoubleLaunchChecker {
String contextPath="";
try {
Method m = ServletContext.class.getMethod("getContextPath");
- contextPath=" contextPath=\""+m.invoke(h.servletContext)+"\"";
+ contextPath = " contextPath=\"" + m.invoke(h.servletCon... | [DoubleLaunchChecker->[schedule->[doRun->[execute],schedule],init->[schedule]]] | Returns a unique identifier for the current Jenkins instance. | I do not get this code |
@@ -48,6 +48,13 @@ public class AfterEachStateMachine extends TriggerStateMachine {
checkArgument(subTriggers.size() > 1);
}
+ @Override
+ public void prefetchOnElement(PrefetchContext c) {
+ for (ExecutableTriggerStateMachine subTrigger : c.trigger().subTriggers()) {
+ subTrigger.invokePrefetchOnEl... | [AfterEachStateMachine->[toString->[toString],inOrder->[AfterEachStateMachine]]] | Returns a trigger state machine in order. | This was one of the cases where I was thinking it only made sense to prefetch the active subtrigger. Of course, I was missing the whole point that you can't know which one that is until you do a fetch. So maybe my whole idea was foolish. |
@@ -71,14 +71,10 @@ describe "When searching" do
end
it "should correctly filter searches for comments" do
- request_via_redirect("get", "/search/requests",
- :query => "daftest",
- :request_variety => ['comments'])
+ get "/search/requests", params: { :query... | [visit,create,describe,with_forgery_protection,eql,it,name,to,before,body,click_button,require,using_session,include,parse,dirname,request_via_redirect,fill_in,redirect_to,context,get,not_to,login,eq,expand_path] | Checks that the number of requests made by Bob Smith are correct. should search for requests made to a tagged set of public authorities. | Line is too long. [100/80]<br>Space missing after comma. |
@@ -244,6 +244,15 @@ SSL_SESSION *ssl_session_dup(SSL_SESSION *src, int ticket)
}
#endif
+ if (src->ticket_appdata != NULL) {
+ dest->ticket_appdata =
+ OPENSSL_memdup(src->ticket_appdata, src->ticket_appdata_len);
+ if (dest->ticket_appdata == NULL)
+ goto err;
+ } els... | [No CFG could be retrieved] | Figure out what the first object in the chain is. The function that creates a session ID. | Don't we also need to set the `ticket_appdata_len` in both of these cases? I'm wondering why we don't zalloc dest to start with, which would at least simplify this. Also, you already explicitly initialised `dest->ticket_appdata` to `NULL` earlier in this function, so this last line looks redundant. |
@@ -62,13 +62,13 @@ describe User, "banning the user" do
it 'does not change the URL name' do
user = FactoryBot.create(:user, :name => 'nasty user 123')
- user.update_attributes(:ban_text => 'You are banned')
+ user.update(:ban_text => 'You are banned')
expect(user.url_name).to eq('nasty_user_123')... | [create_user->[create,merge],email,password_confirmation,minute,create,let,about_me,eql,it,create_user,to,with,it_behaves_like,change,each,match,create_profile_photo,confirm!,context,notify,closed_at,can_make_batch_requests,reload,and_return,close_and_anonymise,be,to_not,expire_requests,set_profile_photo,last_event,sav... | Define a basic configuration for a user object. user creation action. | Use the new Ruby 1.9 hash syntax. |
@@ -205,3 +205,6 @@ def with_metaclass(meta, *bases):
return type.__new__(cls, name, (), d)
return meta(name, bases, d)
return metaclass("NewBase", None, {})
+
+# Silence flake8
+(StringIO, urlparse, urllib_quote, zip, zip_longest)
| [with_metaclass->[metaclass->[__new__->[__new__]],metaclass],TemporaryDirectory->[__del__->[cleanup],__exit__->[cleanup],_rmtree->[_rmtree]],ceil->[ceil]] | Create a base class with a metaclass. | Same here. Can we just use `# NOQA` to silence flake8? |
@@ -25,7 +25,9 @@ var (
containerKubeCommand.GlobalFlags = MainGlobalOpts
return generateKubeYAMLCmd(&containerKubeCommand)
},
- Example: "CONTAINER|POD-NAME",
+ Example: `podman generate kube ctrID
+ podman generate kube podID
+ podman generate kube --service podID`,
}
)
| [Wrapf,IsRootless,LookupPod,GenerateForKube,Println,Marshal,GenerateKubeServiceFromV1Pod,Sprintf,Bool,Shutdown,GetRuntime,LookupContainer,Dependencies,Errorf,SetUsageTemplate,BoolVarP,Flags] | main import imports the cobra command and generates the required values for the n Check if the user provided a container ID or name or latest. | @baude Didn't we remove `--service`? |
@@ -125,12 +125,6 @@ class PMA_SelectServer_Test extends PHPUnit_Framework_TestCase
$html
);
- //PMA_URL_getHiddenInputs
- $this->assertContains(
- '<input type="hidden" name="token" value="token" />',
- $html
- );
-
//labels
$this->as... | [PMA_SelectServer_Test->[testPMASelectServer->[assertContains]]] | testPMASelectServer - test if server selected in PMA select is valid Checks if the list of server items is contained in the current list of server items. | In PMA 4.6 none of these lines exist |
@@ -59,8 +59,7 @@ zpl_lookup(struct inode *dir, struct dentry *dentry, unsigned int flags)
/* If we are a case insensitive fs, we need the real name */
if (zsb->z_case == ZFS_CASE_INSENSITIVE) {
zfs_flags = FIGNORECASE;
- pn.pn_bufsize = ZFS_MAXNAMELEN;
- pn.pn_buf = kmem_zalloc(ZFS_MAXNAMELEN, KM_SLEEP);
+ p... | [No CFG could be retrieved] | - zfs_lookup - zfs_lookup ZFS specific functions. | ~~Why have both pn and ppn?~~ Edit: Never mind, I have bad eye today. |
@@ -112,3 +112,11 @@ class IndexRecord(DictSafeMixin, Entity):
link = ComposableField(Link, required=False)
preferred_env = StringField(default=None, required=False, nullable=True)
+
+ @property
+ def combined_depends(self):
+ from .match_spec import MatchSpec
+ result = {ms.name: ms for... | [IndexRecord->[NoarchField,PriorityField],Link->[LinkTypeField],Link] | Create a ComposableField for a Link. | @mcg1969 This is the only logic I've added to this PR beyond yours, as we discussed today. Is using a dict to dedupe by name the best way to do this here? Do you have other ideas? |
@@ -442,7 +442,10 @@ public class OverlordResource
@GET
@Path("/runningTasks")
@Produces(MediaType.APPLICATION_JSON)
- public Response getRunningTasks(@Context final HttpServletRequest req)
+ public Response getRunningTasks(
+ @QueryParam("type") String taskType,
+ @Context final HttpServletRequest... | [OverlordResource->[asLeaderWith->[apply],getRunningTasks->[apply->[getRunningTasks]],isLeader->[isLeader],getPendingTasks->[apply->[getPendingTasks]]]] | Returns a list of running tasks. | so all the taskType business is added to support this use case ? why did we need this ? |
@@ -80,12 +80,10 @@ Rails.application.configure do
# Supress incorrect warnings from Bullet due to included columns: https://github.com/flyerhzm/bullet/issues/147
Bullet.add_safelist(type: :unused_eager_loading, class_name: "Article", association: :top_comments)
Bullet.add_safelist(type: :unused_eager_lo... | [show_exceptions,after_initialize,queue_adapter,headers,test_order,consider_all_requests_local,cache_classes,deprecation,disallowed_deprecation,require,disallowed_deprecation_warnings,enabled,to_i,delivery_method,eager_load,default_url_options,allow_forgery_protection,enable,cache_store,cache_template_loading,perform_c... | Adds saafelists to the list of records that can be queried by the user. Add a default url option to the last . | While I would have liked to resolve all of the N+1 issues related to profiles in this PR this has proved more difficult than anticipated and there's a lot of other good stuff in this PR that I'd really like to get out, so we can keep this around a bit longer. |
@@ -865,9 +865,11 @@ dma_drop_iod(struct bio_dma_buffer *bdb)
D_ASSERT(bdb->bdb_active_iods > 0);
bdb->bdb_active_iods--;
- ABT_mutex_lock(bdb->bdb_mutex);
- ABT_cond_broadcast(bdb->bdb_wait_iods);
- ABT_mutex_unlock(bdb->bdb_mutex);
+ if (bdb->bdb_waiters) {
+ ABT_mutex_lock(bdb->bdb_mutex);
+ ABT_cond_broadca... | [No CFG could be retrieved] | region bio_dma_buffer private methods finds the first bio that has a buffer that has a buffer that has not yet been. | This 'dbd_mutex' can be removed. The DMA buffer is per-xstream, and SPDK io completion always happen on the same xstream where the io is issued, so the mutex isn't necessary. |
@@ -815,8 +815,8 @@ namespace System.Windows.Forms {
// and when the index of the ListChangedEventArgs == the position in the currency manager
/// <include file='doc\ListManager.uex' path='docs/doc[@for="CurrencyManager.OnCurrentItemChanged"]/*' />
internal protected override void OnCurrentIt... | [CurrencyManager->[Refresh->[List_ListChanged],OnCurrentChanged->[CurrencyManager_PushData],UpdateIsBinding->[ChangeRecordState,OnItemChanged,UpdateIsBinding],List_ListChanged->[ChangeRecordState],AddNew->[AddNew],RemoveAt->[RemoveAt],GetListName->[GetListName],OnItemChanged->[CurrencyManager_PushData],EndCurrentEdit->... | OnCurrentItemChanged - called when the current item is changed. | this could also be shortened to `_onCurrentItemChangedHandler?.Invoke(this, e);` |
@@ -123,7 +123,13 @@ func (m *ppsMaster) newPipelineOp(ctx context.Context, pipeline string) (*pipeli
}
// get latest PipelineInfo (events can pile up, so that the current state
// doesn't match the event being processed)
- if err := m.a.pipelines.ReadOnly(ctx).Get(pipeline, op.pipelineInfo); err != nil {
+ if er... | [scaleUpPipeline->[updateRC],scaleDownPipeline->[updateRC],setPipelineState->[setPipelineState],deletePipelineResources->[deletePipelineResources],restartPipeline->[deletePipelineResources,rcIsFresh,setPipelineState,createPipelineResources]] | newPipelineOp creates a new pipelineOp. | Isn't this a read only transaction? |
@@ -75,6 +75,9 @@ namespace Dynamo.Models
WorkspaceEvents.OnWorkspaceCleared();
}
+ /// <summary>
+ /// Occurs when a workspace is added
+ /// </summary>
public event Action<WorkspaceModel> WorkspaceAdded;
protected virtual void OnWorkspaceAdded(WorkspaceMo... | [DynamoModel->[OnWorkspaceRemoved->[OnWorkspaceRemoved],OnWorkspaceAdded->[OnWorkspaceAdded],OnWorkspaceCleared->[OnWorkspaceCleared],OnWorkspaceRemoveStarted->[OnWorkspaceRemoveStarted],OnEvaluationCompleted->[OnRequestDispatcherBeginInvoke],OnWorkspaceClearing->[OnWorkspaceClearing]]] | This method is called when a workspace is cleared or a workspace is added to a workspace. | Called when a workspace is added. |
@@ -102,7 +102,7 @@ RSpec.describe OpenidConnectTokenForm do
it 'is invalid' do
expect(valid?).to eq(false)
- expect(form.errors[:code]).to include(t('openid_connect.token.errors.invalid_code'))
+ expect(form.errors[:code]).to eq([t('openid_connect.token.errors.expired_code')])
... | [create,new,let,to_not,describe,issuer,attribute_names,ago,end_with,subject,delete_all,it,put,map,to,link_identity,of,save!,before,url_helpers,base64digest,oidc_public_key,let!,t,require,submit,include,to_i,except!,update,have_key,hex,read,session_uuid,delete,context,messages,hash_including,uuid,urlsafe_encode64,access... | It checks that the token is valid and that the form has all the necessary fields. no errors when the sp is set to jwt only mode. | just confirming we have a test later in the file that checks for `invalid_code` |
@@ -256,7 +256,7 @@ public class JobContext {
* @return a {@link Map} from dataset URNs to {@link JobState.DatasetState}s representing the dataset states
*/
Map<String, JobState.DatasetState> getDatasetStatesByUrns() {
- return ImmutableMap.copyOf(this.datasetStatesByUrns.or(Maps.<String, JobState.Dataset... | [JobContext->[handleNewTaskCompletionEvent->[storeJobExecutionInfo],setTaskFailureException->[setTaskFailureException],persistDatasetState->[persistDatasetState]]] | Get the datasetStatesByUrns method. | There should be an empty after `>`. I see this in many places. |
@@ -1415,4 +1415,12 @@ Generator.prototype.filterNumber = function (input, isSigned, isDecimal) {
return NaN;
};
+Generator.prototype.error = function(msg) {
+ return this.env.error(chalk.red.bold('ERROR! ') + msg);
+};
+
+Generator.prototype.warning = function(msg) {
+ return this.env.error(chalk.yellow.... | [No CFG could be retrieved] | Returns NaN if the array contains any element. | This would exit the generator. Do we want to exit for warnings? Imo we should use this.log for warning and only for error we should exit |
@@ -181,6 +181,7 @@ public class AndFilter implements BooleanFilter
private ValueMatcher makeMatcher(final ValueMatcher[] baseMatchers)
{
+ Preconditions.checkState(baseMatchers.length > 0);
if (baseMatchers.length == 1) {
return baseMatchers[0];
}
| [AndFilter->[supportsSelectivityEstimation->[supportsSelectivityEstimation],supportsBitmapIndex->[supportsBitmapIndex],getBitmapIndex->[getBitmapIndex],estimateSelectivity->[estimateSelectivity],makeMatcher->[matches->[matches],makeMatcher,getBitmapIndex]]] | Creates a matcher that matches the given matchers. | Can this support a 0 length array and just return `BooleanValueMatcher.of(false);`? |
@@ -71,7 +71,7 @@ func CollectModuleFiles(modulesDir string) ([]*YmlFile, error) {
func CollectFiles(module string, modulesPath string) ([]*YmlFile, error) {
var files []*YmlFile
- fieldsYmlPath := filepath.Join(modulesPath, module, "_meta", "fields.yml")
+ fieldsYmlPath := filepath.Join(modulesPath, module, "_met... | [IsNotExist,Join,Stat,IsDir,Name,ReadDir,Base] | CollectModuleFiles collects all files under the specified modules directory and returns a list of all the return files that have a sequence of files. | What is the reason you introduced the `/` here? Could break on Windows. Any issues with the previous option? |
@@ -1013,6 +1013,13 @@ app.use('/bind/ecommerce/sizes', (req, res) => {
}, 1000); // Simulate network delay.
});
+//todo:chenshay: accept '?crypto=bla'
+/*
+implement authorizer here.
+this is for local testing.
+
+*/
+
// Simulated subscription entitlement
app.use('/subscription/:id/entitlements', (req, res) =... | [No CFG could be retrieved] | Simulate network delay and adzerk adzerk adzerk adzerk ad Serve AMP extension scripts and source maps. | Please adopt the `TODO` format for AMP. |
@@ -842,6 +842,14 @@ class Instance(ProperType):
# Literal context.
self.last_known_value = last_known_value
+ if (
+ self.type and
+ not self.type.has_readable_member('__bool__') and
+ not self.type.has_readable_member('__len__')
+ ):
+ self... | [TypeVarLikeDef->[__init__->[TypeVarId]],TypeStrVisitor->[visit_callable_type->[accept,get_proper_type],visit_typeddict_type->[accept,item_str,items],visit_star_type->[accept],visit_type_alias_type->[accept,_partial_expansion],visit_tuple_type->[accept],visit_type_type->[accept],visit_overloaded->[accept,items],visit_c... | Initialize a new object with the given arguments and type. This is a hack to make sure that we don t have a type in the expressions. | Do we have to check for Python 2 `__nonzero__`? |
@@ -69,7 +69,7 @@ end
Then(/^I attach a "([^"]*)" file to "([^"]*)" field$/) do |file, field_id|
wait_for_ajax
- find(field_id).attach_file(Rails.root.join('features', 'assets', file))
+ find(field_id, :visible => false).attach_file(Rails.root.join('features', 'assets', file))
# "expensive" operation needs s... | [visit,update_attribute,fetch,create,find,have_xpath,have_current_path,join,should,to,have_content,click_button,click_link,set,click,find_by_id,user,sleep,execute_script,click_on,id,within,within_frame,find_by_email,not_to,send_keys,seed_demo_data,find_by_name,attach_file] | finds all user - related records and checks if they are on the homepage and if they Click on images within element and click on Edit on input field and rich text editor on input. | Style/HashSyntax: Use the new Ruby 1.9 hash syntax. |
@@ -751,6 +751,8 @@ func (s *Stack) runPulumiCmdSync(
args ...string,
) (string, string, int, error) {
var env []string
+ debugEnv := fmt.Sprintf("%s=%s", "PULUMI_DEBUG_COMMANDS", "true")
+ env = append(env, debugEnv)
if s.Workspace().PulumiHome() != "" {
homeEnv := fmt.Sprintf("%s=%s", pulumiHomeEnv, s.Works... | [RefreshConfig->[Name,Workspace,RefreshConfig],Destroy->[Name,Workspace],Info->[Name,Workspace],Refresh->[Name,Workspace],SetConfig->[Name,Workspace,SetConfig],Cancel->[Name,Workspace],History->[Name,Workspace],Outputs->[Name,Workspace],Up->[Name,Workspace],RemoveConfig->[Name,Workspace,RemoveConfig],SetAllConfig->[Nam... | runPulumiCmdSync executes the command synchronously and returns the stdout stderr and error. | Was this intended? |
@@ -36,6 +36,9 @@ def unlock_account_with_passwordfile(
try:
return account_manager.get_privkey(address_hex, password.strip())
+ except KeystoreFileNotFound as e:
+ click.secho(str(e), fg="red")
+ sys.exit(1)
except ValueError:
click.secho(f"Incorrect password for {address... | [prompt_account->[list,prompt,keys,print,len,format,join,enumerate,to_checksum_address],unlock_account_with_passwordprompt->[getpass,get_privkey,print,range,exit,to_checksum_address],unlock_account_with_passwordfile->[get_privkey,read,strip,exit,secho]] | Unlock an account with a password file. | We use `ValueError` in a lot of places, which is thrown by enough different things that it can lead to choosing the wrong error message easily. On the bright side, it might also throw the right error messages in cases you didn't think about due to being rather generic. Generally I would use it more sparingly. |
@@ -36,7 +36,7 @@ class StorageTableTest(AzureTestCase, TableTestCase):
def test_create_properties(self, tables_storage_account_name, tables_primary_storage_account_key):
# # Arrange
account_url = self.account_url(tables_storage_account_name, "table")
- ts = self.create_client_from_credent... | [StorageTableTest->[test_query_tables->[create_client_from_credential,list,account_url,_delete_all_tables,len,isinstance,_create_table,list_tables],test_set_table_acl_too_many_ids->[create_client_from_credential,set_table_access_policy,account_url,delete_table,dict,format,_create_table,raises,range],test_query_tables_w... | Test create properties of table. | If this passes I'd keep it for now, but you can also change it to `credential=tables_primary_storage_account_key`. Small nit |
@@ -123,6 +123,11 @@ module.exports = webpackMerge(commonConfig({ env: ENV }), {
new webpack.WatchIgnorePlugin([
utils.root('src/test'),
]),
+ new AngularCompilerPlugin({
+ mainPath: utils.root('<%= MAIN_SRC_DIR %>app/app.main.ts'),
+ tsConfigPath: utils.root(... | [No CFG could be retrieved] | Plugins that are not installed on the server. | why are we doing aot in dev? I dont think AOT is suitable for incremental builds in yarn start |
@@ -0,0 +1,16 @@
+# -------------------------------------------------------------------------
+# Copyright (c) Microsoft Corporation. All rights reserved.
+# Licensed under the MIT License. See License.txt in the project root for
+# license information.
+# ---------------------------------------------------------------... | [No CFG could be retrieved] | No Summary Found. | I'm assuming this is used in playback mode, however this will likely trigger cred scan warning - have we checked that? |
@@ -20,6 +20,8 @@ import (
userv1client "github.com/openshift/client-go/user/clientset/versioned/typed/user/v1"
authorizationutil "github.com/openshift/origin/pkg/authorization/util"
+
+ "k8s.io/apiserver/pkg/authentication/user"
)
const (
| [CompleteUserWithSA->[innerComplete],AddRole->[newRoleBinding,AddRole,getRoleBinding],Complete->[innerComplete]] | Imports the specified object. Add the edit role to user1 for the current project. | @deads2k I would expect this to fail with an import violation from the server to client. |
@@ -368,10 +368,18 @@ class RawEEGLAB(BaseRaw):
'the .set file')
# can't be done in standard way with preload=True because of
# different reading path (.set file)
+
if eeg.nbchan == 1 and len(eeg.data.shape) == 1:
n_chan, n_times = [1, eeg.da... | [RawEEGLAB->[__init__->[_check_fname,_get_info,_check_mat_struct]],EpochsEEGLAB->[__init__->[_check_fname,_get_info,_check_mat_struct]],_get_info->[_to_loc]] | Initialize the object from a. set file. Initialize the raw EEGLAB object with a sequence of data stored in the. set. | same thing -- if data needs to be transposed, can you do it in the above function so that this one can stay "clean"? |
@@ -144,6 +144,7 @@ $arrayfields = array(
't.credit'=>array('label'=>$langs->trans("Credit"), 'checked'=>1),
't.lettering_code'=>array('label'=>$langs->trans("LetteringCode"), 'checked'=>1),
't.date_export'=>array('label'=>$langs->trans("DateExport"), 'checked'=>1),
+ 't.date_validated'=>array('label'=>$langs->tr... | [fetch,formconfirm,fetch_object,selectyear_accountancy_bookkepping,getDocumentsLink,select_account,multi_select_journal,fetchAllByAccount,getNomUrl,select_journal,deleteByYearAndJournal,get_compte_desc,initHooks,idate,plimit,deleteMvtNum,executeHooks,loadLangs,showCheckAddButtons,close,selectDate,query,transnoentitiesn... | Private function to generate a list of all the fields of a nation object region User Enumerate. | What is this date ? Is it for a feature of lettering enabled by option ACCOUNTING_ENABLE_LETTERING or by something else ? |
@@ -728,6 +728,8 @@ class ArticleDAO extends DAO {
(int) $article->getId()
)
);
+ $article->initializePermissions();
+ $this->updateLocaleFields($article);
unset($article);
}
$this->flushCache();
| [ArticleDAO->[changePubId->[updateSetting],flushCache->[_getCache],insertArticle->[updateLocaleFields],updateArticle->[updateLocaleFields],deleteArticlesByJournalId->[getArticlesByJournalId,deleteArticleById],getArticlesByUserId->[_returnArticleFromRow],deleteAllPubIds->[getArticlesByJournalId],getArticle->[_getCache],... | Delete all permissions for a given journal. | Working on a couple of issues with the permissions reset: deleted values not honored and clicking the reset button after changing (but before saving) setup values. |
@@ -35,9 +35,16 @@ func InitLogging(logToStderr bool, verbose int, logFlow bool) {
// this is the only way to control the way glog runs. That includes poking around at flags below.
flag.Parse()
if logToStderr {
- flag.Lookup("logtostderr").Value.Set("true")
+ err := flag.Lookup("logtostderr").Value.Set("true")... | [Lookup,Itoa,Set,Parse] | This is only used for debugging. | This should just be `contract.Assert(err != nil)`; no need for the `if err != nil`. |
@@ -21,12 +21,13 @@ namespace Kratos
{
namespace RansCheckUtilities
{
-bool CheckIfModelPartExists(const Model& rModel, const std::string& rModelPartName)
+bool CheckIfModelPartExists(
+ const Model& rModel,
+ const std::string& rModelPartName)
{
KRATOS_TRY
- if (!rModel.HasModelPart(rModelPartName)... | [No CFG could be retrieved] | Provides a basic list of all possible nodal variables in the model. - - - - - - - - - - - - - - - - - -. | Can't the `HasModelPart` of the `Model` be used to remove this? |
@@ -112,6 +112,15 @@ def generate_proto_files(force=False):
'%s' % ret_code)
+ if sys.version_info[0] >= 3:
+ ret_code = subprocess.call(
+ ["futurize", "-0", "-wv", "--no-diff", out_dir])
+
+ if ret_code:
+ raise RuntimeError(
+ 'Error applying futurize to generated... | [_install_grpcio_tools_and_generate_proto_files->[generate_proto_files],generate_proto_files] | Creates a new proto file for the given . Checks if grpcio - tools is installed and installs it if it is. | Could you expand the arguments to their long form: `futurize --both-stages --write --verbose --no-diff` ? |
@@ -49,6 +49,10 @@ class TestSanitizeChecksumType(unittest.TestCase):
self.assertEqual(checksum_type, 'sha256')
+ def test_invalid_type_raises_coded_exception(self):
+ self.assertRaises(PulpCodedException,
+ verification.sanitize_checksum_type, 'not_a_real_checksum')
+
... | [TestSanitizeChecksumType->[test_nothing_necessary->[assertEqual,sanitize_checksum_type],test_none->[assertEqual,sanitize_checksum_type],test_sha_to_sha1->[assertEqual,sanitize_checksum_type],test_ShA_to_sha1->[assertEqual,sanitize_checksum_type],test_SHA256_to_sha256->[assertEqual,sanitize_checksum_type]],Verification... | Test that SHA256 is converted to sha256. | You're going to be sorry when my new checksum algorithm, 'not_a_real_checksum', becomes widely accepted and breaks this unit test. |
@@ -45,7 +45,9 @@
<% end %>
</div>
</div>
- <%= javascript_pack_tag "listingForm", defer: true %>
+ <% unless @organizations.present? %>
+ <%= javascript_packs_with_chunks_tag "listingForm", defer: true %>
+ <% end %>
<div class="field">
<%= form.label "location", ... | [No CFG could be retrieved] | Displays a hidden hidden input with the name of the category and a list of all available cred Displays a hidden container for the n - ary unique identifier. | To avoid the issue mentioned above about chunks loading multiple times, I have to check if the user is logged on or not. If they aren't, just load the `"listingForm"` pack. Otherwise, load the `"listingForm"` and `"orgCreditSelector"` packs within the same `javascript_packs_with_chunks_tag` call. I do this in a few oth... |
@@ -932,7 +932,7 @@ function textInputType(scope, element, attr, ctrl, $sniffer, $browser) {
// By default we will trim the value
// If the attribute ng-trim exists we will avoid trimming
// e.g. <input ng-model="foo" ng-trim="false">
- if (toBoolean(attr.ngTrim || 'T')) {
+ if (!attr.ngTrim || att... | [No CFG could be retrieved] | Adds validators to the input element and adds listeners to the input element. Checks if the element has a valid value. | Why not just `if (attr.ngTrim !== 'false') {` ? |
@@ -148,6 +148,18 @@ class ROUGE(Metric):
total_precision += precision
total_f1 += f1
+ if is_distributed():
+ device = predicted_tokens.device
+ _total_recall = torch.tensor(total_recall).to(device)
+ _total_precision = torch.tensor(total_precision).t... | [ROUGE->[__call__->[_get_rouge_l_score,_get_rouge_n_stats],_get_rouge_l_score->[_longest_common_subsequence],get_metric->[reset,_metric_mean]]] | Compute recall precision and f1 statistics for a single . Compute ROUGE statistics for a single . | This ends up returning the sum of the F1 scores? Maybe I'm missing context, but why is it OK to sum up the F1 scores? |
@@ -0,0 +1,6 @@
+class AddShareCheckinToTwitterAndShareCheckinToFacebookToSettings < ActiveRecord::Migration
+ def change
+ add_column :settings, :share_record_to_twitter, :boolean, default: false
+ add_column :settings, :share_record_to_facebook, :boolean, default: false
+ end
+end
| [No CFG could be retrieved] | No Summary Found. | Line is too long. [91/90] |
@@ -48,15 +48,15 @@ namespace Dynamo.Search
entry => entry.Categories);
foreach (var category in root.SubCategories)
- AddCategoryToXml(document.DocumentElement, category);
+ AddCategoryToXml(document.DocumentElement, category, dynamoPath);
fo... | [NodeSearchModel->[Add->[Add],AddCategoryToXml->[AddEntryToXml,AddCategoryToXml]]] | Composes an XmlDocument representing the library tree. | what is the logic for always checking the first InputParameter - shouldn't we be checking the InputParameter at i? |
@@ -149,13 +149,7 @@ irr::gui::IGUIFont *FontEngine::getFont(FontSpec spec, bool may_fail)
/******************************************************************************/
unsigned int FontEngine::getTextHeight(const FontSpec &spec)
{
- irr::gui::IGUIFont *font = getFont(spec);
-
- // use current skin font as fallba... | [getTextWidth->[getFont],getTextHeight->[getFont],initFont->[getFont],initSimpleFont->[getFont],updateFontCache->[getFont],readSettings->[cleanCache],getFont->[getFont],updateSkin->[getFont],getLineHeight->[getFont]] | Get the height of a text in the specified font. | This and other code that assumes `font` can be null can go, `getFont()` *never* returns null |
@@ -1273,6 +1273,16 @@ def renew(config, unused_plugins):
:rtype: None
"""
+ if not sys.stdin.isatty():
+ # Noninteractive renewals include a random delay in order to spread
+ # out the load on the certificate authority servers, even if many
+ # users all pick the same time for renew... | [enhance->[_init_le_client],revoke->[revoke,_delete_if_appropriate,_determine_account],renew_cert->[_init_le_client,_get_and_save_cert],_ask_user_to_confirm_new_names->[_format_list,_get_added_removed],install->[_init_le_client,_install_cert,_find_domains_or_certname],unregister->[_determine_account],certificates->[cer... | Renew previously - obtained certificates. | It's probably safer to put this down in `main` the function, so we catch any subcommand that people might have put in their crontab. |
@@ -13,6 +13,11 @@ const LoginMethod = EmberObject.extend({
return this.title_override || I18n.t(`login.${this.name}.title`);
},
+ @discourseComputed
+ a11yTitle() {
+ return this.title_override || I18n.t(`login.${this.name}.sr_title`);
+ },
+
@discourseComputed
prettyName() {
return this.pre... | [No CFG could be retrieved] | Creates a login method that can be used to login a user in a different context. find all methods in the system. | maybe we go with `screenReaderTitle` now ? |
@@ -613,6 +613,18 @@ class LSTMBlockFusedCell(LSTMBlockWrapper):
share weights, but to avoid mistakes we require reuse=True in such
cases. By default this is "lstm_cell", for variable-name compatibility
with `tf.nn.rnn_cell.LSTMCell`.
+ input_keep_prob: unit Tensor or float between 0 an... | [LSTMBlockCell->[call->[_lstm_block_cell]],LSTMBlockWrapper->[call->[_call_cell]]] | Initialize the LSTM cell. | I'm starting to rethink this. All of these additional arguments are basically just so you can essentially call tf.nn.dropout on the inputs? Is that necessary? Can't the user just call dropout themselves? |
@@ -1147,12 +1147,15 @@ bool Map::isBlockOccluded(MapBlock *block, v3s16 cam_pos_nodes)
v3s16 pos_blockcenter = block->getPosRelative() + (MAP_BLOCKSIZE / 2);
- // Starting step size, value between 1m and sqrt(3)m
- float step = BS * 1.2f;
+ // Starting step size, slightly > sqrt(3),
+ // so that each block is hi... | [No CFG could be retrieved] | Checks if a node is on the light block. - - - - - - - - - - - - - - - - - -. | this initially confused me, it should say "so that each <i>node</i> is hit at most once" |
@@ -554,7 +554,7 @@ public final class KsqlRestApplication implements Executable {
new KsqlSchemaRegistryClientFactory(ksqlConfig, Collections.emptyMap())::get;
final ServiceContext serviceContext = new LazyServiceContext(() ->
RestServiceContextFactory.create(ksqlConfig, Optional.empty(),
- ... | [KsqlRestApplication->[buildApplication->[buildApplication,KsqlRestApplication],displayWelcomeMessage->[getListeners,displayWelcomeMessage],waitForPreconditions->[AbortApplicationStartException],loadSecurityExtension->[initialize],checkPreconditions->[KsqlFailedPrecondition]]] | Build an application from a KsqlRestConfig. | This is already a singleton, so it's not a big savings, but you could use the same vertx object and `KsqlClient` here too, if you wanted. That way it wouldn't have to be optional and I think you might be able to remove some of the `boolean sharedClient`s around. |
@@ -37,6 +37,10 @@ module AdminHelper
PROFILE_ADMIN = { name: "config: profile setup", controller: "profile_fields" }.freeze
+ TECH_MENU_ITEMS = [
+ { name: "data_update_scripts", controller: "data_update_scripts" },
+ ].sort_by { |menu_item| menu_item[:name] }
+
def admin_menu_items
return MENU_ITE... | [admin_menu_items->[insert,enabled?],freeze,sort_by] | Returns the admin menu item that is not part of the menu. | This is a list of tech resources that we add. Eventually we may move things like the Sidekiq page to here as well. |
@@ -116,7 +116,7 @@ class SecurityEventForm
if error_code && error_message
@error_code = error_code
- errors.add(:jwt, error_message)
+ errors.add(:jwt, error_message, type: :"#{error_message.split('.').last}")
else
check_public_key_error(matching_public_key)
end
| [SecurityEventForm->[validate_jwt->[check_public_key_error],user->[user]]] | Check if the next node in the chain is a node with a public key. | maybe it would be better to set a `error_reason` than to try to infer from the translated error emssage? |
@@ -271,6 +271,9 @@ class Query(graphene.ObjectType):
class Mutations(graphene.ObjectType):
+ authorization_key_add = AuthorizationKeyAdd.Field()
+ authotization_key_delete = AuthorizationKeyDelete.Field()
+
assign_navigation = AssignNavigation.Field()
token_create = CreateToken.Field()
| [Query->[resolve_customers->[resolve_customers],resolve_sales->[resolve_sales],resolve_page->[resolve_page],resolve_orders->[resolve_orders],resolve_products->[resolve_products],resolve_menu->[resolve_menu],resolve_vouchers->[resolve_vouchers],resolve_staff_users->[resolve_staff_users],resolve_categories->[resolve_cate... | Resolve all related objects to a single object. Get the fields of the N - ary object. | typo `authotization` -> `authorization` |
@@ -34,9 +34,9 @@ class DarshanRuntime(Package):
systems where you intend to instrument MPI applications."""
homepage = "http://www.mcs.anl.gov/research/projects/darshan/"
- url = "http://ftp.mcs.anl.gov/pub/darshan/releases/darshan-3.1.0.tar.gz"
+ url = "https://xgitlab.cels.anl.gov/darshan/darshan/r... | [DarshanRuntime->[install->[working_dir,Executable,make,configure],setup_environment->[set],variant,depends_on,version]] | Creates a new object with all of the information from the MCS A. Define a function that installs a COBlat job ID. | Why the URL change? Have any of the old checksums changed as well? |
@@ -103,7 +103,13 @@ final class DefaultKsqlClient implements SimpleKsqlClient {
.target(serverEndPoint);
getTarget(target, authHeader)
- .postAsyncHeartbeatRequest(new KsqlHostInfoEntity(host.host(), host.port()), timestamp);
+ .postAsyncHeartbeatRequest(new KsqlHostInfoEntity(host.host()... | [DefaultKsqlClient->[makeKsqlRequest->[postKsqlRequest,empty,target],createClientOptions->[setMaxPoolSize],makeClusterStatusRequest->[getClusterStatus,target],close->[close],getTarget->[orElse],makeQueryRequest->[erroneous,properties,getResponse,empty,postQueryRequest,isErroneous,getStatusCode,getErrorMessage,successfu... | Make a heartbeat request asynchronously. | nit: async heartbeat request? |
@@ -1,10 +1,10 @@
-class ReturnToSpController < ApplicationController
+class ReturnToSpController < Redirect::RedirectController
before_action :validate_sp_exists
def cancel
redirect_url = sp_return_url_resolver.return_to_sp_url
analytics.track_event(Analytics::RETURN_TO_SP_CANCEL, redirect_url: redir... | [ReturnToSpController->[sp_return_url_resolver->[new],validate_sp_exists->[redirect_to,nil?],failure_to_proof->[track_event,redirect_to,failure_to_proof_url],sp_request_params->[present?,params],sp_request_url->[url],idv_location_params->[symbolize_keys],cancel->[track_event,redirect_to,return_to_sp_url],before_action]... | cancel redirect to the first node with idv_location_params. | Probably shouldn't want to double log here. Instead, one of: * Keep `RETURN_TO_SP_FAILURE_TO_PROOF` and do a plain redirect * Remove `RETURN_TO_SP_FAILURE_TO_PROOF` and somehow embed "failure to proof" as an extra logging detail in `redirect_to_and_log` (e.g. keyword arguments) |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.