patch stringlengths 18 160k | callgraph stringlengths 4 179k | summary stringlengths 4 947 | msg stringlengths 6 3.42k |
|---|---|---|---|
@@ -50,3 +50,7 @@ registerUnbound("number", (orig, params) => {
return htmlSafe(result);
});
+
+registerUnbound("value-for-key", (obj = {}, key) => {
+ return obj[key];
+});
| [No CFG could be retrieved] | HTML - safe version of the result. | I sent you a message about this, but I think this can be removed and we can use the `{{get}}` helper instead. |
@@ -17,14 +17,16 @@ Rails.application.configure do
config.action_mailer.asset_host = Figaro.env.mailer_domain_name
config.action_mailer.default_options = { from: Figaro.env.email_from }
+ config.assets.debug = true
+
if ENV.key?('RAILS_ASSET_HOST')
config.action_controller.asset_host = ENV['RAILS_ASSET... | [show_exceptions,after_initialize,queue_adapter,default_options,domain_name,test_order,consider_all_requests_local,asset_host,cache_classes,use,deprecation,enabled,static_cache_control,debug,key?,delivery_method,email_from,bullet_logger,eager_load,default_url_options,raise_on_missing_translations,allow_forgery_protecti... | Initialize the action controller. | Do we hit the line length limit if we use a ternary? |
@@ -81,7 +81,17 @@ class _CliCredentials(object):
def get_azure_cli_credentials(resource=None, with_tenant=False):
"""Return Credentials and default SubscriptionID of current loaded profile of the CLI.
- Credentials will be the "az login" command:
+ *Disclaimer*: This method is not working for CLI install... | [get_azure_cli_credentials->[_CliCredentials,get_cli_profile],_CliCredentials->[get_token->[_get_cred],signed_session->[_get_cred,signed_session]]] | Get Azure CLI credential and default subscription ID of current loaded profile of the CLI. | Is it date based or version based? Can I install an earlier version of the CLI after 3/2021 and it works? This says I can't. Also, 3/2021 is a very custom date moniker. Let's use a standard one. |
@@ -418,6 +418,13 @@ class DatePicker(InputWidget):
Whether the calendar sholud be displayed inline.
""")
+ date_format = String(default="Y-m-d", help="""
+ The desired date format to display on the Calendar when a date is picked.
+
+ .. note::
+ Must contain characters from flatpickr's tabl... | [MultiSelect->[List,Tuple,Int,Either],FileInput->[List,Bool,String,Either],MultiChoice->[Tuple,Int,List,String,Either,Bool],InputWidget->[coerce_value->[int,str,isinstance,lookup,float],String],TextInput->[String],TextAreaInput->[Int],ColorPicker->[ColorHex],Select->[Tuple,Dict,List,String,Either],AutocompleteInput->[L... | Listing of dates that can be selected by the user. | We should drop an explicit link here to make it easier for users find the table (or just copy it) |
@@ -375,7 +375,8 @@ export class SubscriptionService {
// Hide loading animation.
this.renderer_.toggleLoading(false);
- // Track view.
+ // Set Pingback viewer timer
+
this.viewTrackerPromise_ = this.viewerTracker_.scheduleView(2000);
// If the viewer is providing a paywall we don't want ... | [SubscriptionService->[constructor->[installStylesForDoc,timerFor,user,win,cidForDoc,viewerForDoc,getElementById],delegateActionToService->[resolve,dict,STARTED,executeAction,devAssert,ACTION_DELEGATED],start->[STARTED,userAssert,isStoryDocument],decorateServiceAction->[decorateUI,devAssert],fetchEntitlements_->[isPrer... | Process grant state. | This looks like an extra newline |
@@ -18,6 +18,7 @@ import * as dom from '../../src/dom';
import {BaseElement} from '../../src/base-element';
import {createAmpElementForTesting} from '../../src/custom-element';
import {loadPromise} from '../../src/event-helper';
+import {setScopeSelectorSupportedForTesting} from '../../src/css';
import {toArray} fr... | [No CFG could be retrieved] | Package that contains the functions related to AMP HTML Authors and functions defined in the A It should remove all children of the element. | Kinda weird, ideally should mock `isScopeSelectorSupported` instead. |
@@ -1318,6 +1318,16 @@ public abstract class View extends AbstractModelObject implements AccessControll
public static final Permission CONFIGURE = new Permission(PERMISSIONS,"Configure", Messages._View_ConfigurePermission_Description(), Permission.CONFIGURE, PermissionScope.ITEM_GROUP);
public static final Pe... | [View->[getQueueItems->[filterQueue,getItems],getACL->[getACL],doCheckJobName->[getItem],updateByXml->[save],getAllItems->[getItems,getAllItems],doItemCategories->[getItem,getDescription,getDisplayName],PropertyList->[onModified->[getOwner]],doChildrenContextMenu->[getItems,getDisplayName],getAbsoluteUrl->[getUrl],getW... | Get the Item create permission. | import needed as well |
@@ -85,7 +85,10 @@ defineSuite([
var texturedBoxCustomUrl = './Data/Models/Box-Textured-Custom/CesiumTexturedBoxTest.gltf';
var texturedBoxKhrBinaryUrl = './Data/Models/Box-Textured-Binary/CesiumTexturedBoxTest.glb';
var boxRtcUrl = './Data/Models/Box-RTC/Box.gltf';
- var boxesEcefUrl = './Data/Models... | [No CFG could be retrieved] | This function returns the urls of all models that are used by the Box - NoIndices test anim - test - 1 - boxes. | Instead of having three copies of the data, is it reasonable to have one copy (with squashed commits) and just have the test do a small change to the model at load? This will be less test data and easier to update to glTF 2.0. |
@@ -97,8 +97,10 @@ namespace PythonNodeModels
}
else
{
- // In the absence of both a setting and system default, default to deserialization default.
- engine = PythonEngineVersion.IronPython2;
+ // If IronPython2 is available, use that ... | [PythonNodeBase->[UpdateValueCore->[UpdateValueCore]],PythonNode->[SerializeCore->[SerializeCore],DeserializeCore->[DeserializeCore],UpdateValueCore->[UpdateValueCore]],PythonStringNode->[GetInputIndex->[GetInputIndex],RemoveInput->[RemoveInput]]] | Set engine by default. | Any reason CPython3 would not be the default? It is already the case when we create a new PythonScript node in Dynamo now right? |
@@ -1508,7 +1508,7 @@ module.exports = EntityGenerator.extend({
} else if (databaseType == 'cassandra') {
this.entityUrlType = '[0-9a-fA-F]{8}-[0-9a-fA-F]{4}-[0-9a-fA-F]{4}-[0-9a-fA-F]{4}-[0-9a-fA-F]{12}';
}
- this.entityTranslationKey = this.entityInstance;
+ ... | [No CFG could be retrieved] | Common functions for the constructor Private methods - Entity Entity Relationships - Entity Entity - Relationships - Entity. | What about when adding state to menu? |
@@ -42,6 +42,12 @@ public class SmallRyeHealthConfig {
@ConfigItem(defaultValue = "well")
String wellnessPath;
+ /**
+ * Whether the context should be propagated to each health check invocation.
+ */
+ @ConfigItem(defaultValue = "false")
+ boolean contextPropagation;
+
/**
* Smal... | [No CFG could be retrieved] | - A string that represents the path to the wellness health - checking endpoint. | I removed the enforced name here as it's the default that will be generated so no need to define it. |
@@ -209,6 +209,7 @@ module.exports = EntityGenerator.extend({
this.changelogDate = this.fileData.changelogDate;
this.dto = this.fileData.dto;
this.service = this.fileData.service;
+ this.fluentMethods = this.fileData.fluentMethods;
this.pagination = this.fileData.pagination;
... | [No CFG could be retrieved] | Method to load the entity configuration from JSON file. This method is used to generate the entity name for the entity. | may be you can add `--fluentMethods` as an option to sub generator as well when creating entities by hand. dont forget to PR the JDL project as well |
@@ -386,6 +386,7 @@ class OrderAddNote(BaseMutation):
app=info.context.app,
message=cleaned_input["message"],
)
+ transaction.on_commit(lambda: info.context.plugins.order_updated(order))
return OrderAddNote(order=order, event=event)
| [clean_refund_payment->[clean_payment],OrderVoid->[perform_mutation->[OrderVoid,clean_void_payment,try_payment_action]],clean_order_capture->[clean_payment],OrderLineUpdate->[clean_input->[validate_order]],OrderLinesCreate->[perform_mutation->[OrderLinesCreate,validate_order,validate_variants,validate_lines,add_lines_t... | Perform a mutation on a node. | I am not convinced, that adding a note to Order should trigger an event `order updated`. I wouldn't say that this is something which changes an order. |
@@ -1651,9 +1651,17 @@ class BaseRaw(ProjMixin, ContainsMixin, UpdateChannelsMixin, SetChannelsMixin,
def _repr_html_(self, caption=None):
if not isinstance(caption, str):
caption = 'Raw'
+ basenames = [os.path.basename(f) for f in self._filenames]
+ m, s = divmod(self.first_tim... | [_start_writing_raw->[append],BaseRaw->[notch_filter->[notch_filter],_preload_data->[_read_segment],_getitem->[_read_segment,_parse_get_set_params],get_data->[_getitem],__setitem__->[_parse_get_set_params],resample->[get_data,resample],crop->[set_annotations],append->[_read_segment,set_annotations,append],to_data_frame... | Return a string representation of the object in HTML. Update the data with the pick. | Could you turn this into an f-string please? |
@@ -69,9 +69,9 @@ namespace System.Net.Http
public HttpConnection(
HttpConnectionPool pool,
- Socket socket,
- Stream stream,
- TransportContext transportContext)
+ Socket? socket,
+ Stream? stream,
+ TransportContext? transportCo... | [No CFG could be retrieved] | private static final int MAX_CONNECTION_SIZE = 1024 ; This method is called when there is no connection in the event loop. | stream in parameter list should be non-nullable. |
@@ -5,7 +5,7 @@
#include "CommonExceptionsPch.h"
#ifdef _MSC_VER
-__inline
+inline
#endif
void ReportFatalException(
__in ULONG_PTR context,
| [No CFG could be retrieved] | Reports fatal exception in case of a problem. OOM - fatal error handler. | Just remove the inline altogether here. VC does not inline function with try/except anyway. |
@@ -99,6 +99,7 @@ class PullQueryPublisher implements Flow.Publisher<Collection<StreamedRow>> {
PullQueryExecutionUtil.checkRateLimit(rateLimiter);
final Decrementer decrementer = concurrencyLimiter.increment();
+ pullBandRateLimiter.allow(Time.SYSTEM.milliseconds());
PullQueryResult result = null... | [PullQueryPublisher->[subscribe->[of,onCompletionOrException,decrementAtMostOnce,executePullQuery,recordMetrics,PullQuerySubscription,onSubscribe,empty,PullQueryConfigRoutingOptions,ifPresent,PullQueryConfigPlannerOptions,getConfig,increment,getOverrides,checkRateLimit],recordMetrics->[recordLatency,recordRowsProcessed... | Subscribes to the given subscriber. | We're still trying to figure out how to get the bytes here, right? If we just retain the qps and concurrency rate limiter across all endpoints, and we want to fall back on that here, then that might be sufficient, but if we wanted to lift the other rate limiting on the other endpoints in favor of bandwidth, then we cou... |
@@ -199,10 +199,14 @@ const (
SearchOrderBySizeReverse SearchOrderBy = "size DESC"
SearchOrderByID SearchOrderBy = "id ASC"
SearchOrderByIDReverse SearchOrderBy = "id DESC"
- SearchOrderByStars SearchOrderBy = "num_stars ASC"
- SearchOrderByStarsReverse ... | [loadAttributes->[loadAttributes],LoadAttributes->[loadAttributes],loadAttributes,String] | SearchRepositoryCondition creates a query condition for a given user object. if - Limited visibility is not allowed. | should these be here or in `models/user.go`? I think it's neat to have them all grouped together |
@@ -145,8 +145,13 @@ public class DelegatedClientAuthenticationAction extends AbstractAction {
final ClientCredential clientCredential = new ClientCredential(credentials);
final AuthenticationResult authenticationResult =
this.authenticationSystemSupport.handle... | [DelegatedClientAuthenticationAction->[stopWebflow->[Event],saveRequestParameter->[setAttribute,getParameter],doExecute->[size,restoreRequestAttribute,put,getSession,setAttribute,findClient,success,handleAndFinalizeSingleAuthenticationTransaction,getClientNameParameter,putTicketGrantingTicketInScopes,isNotBlank,getCred... | Execute the action. Checks if the current request is an unauthorized authentication and if so redirects to the first URL. | This probably should be catching `Exception`. Right? |
@@ -31,7 +31,7 @@ public abstract class MasterToSlaveCallable<V, T extends Throwable> implements C
public Channel getChannelOrFail() throws ChannelClosedException {
final Channel ch = Channel.current();
if (ch == null) {
- throw new ChannelClosedException(new IllegalStateException("No ... | [MasterToSlaveCallable->[getOpenChannelOrFail->[getChannelOrFail]]] | Returns the channel associated with the thread or throws an exception if no channel is associated with the. | Since ch is null, adding it to the Exception does not make any sense. |
@@ -259,9 +259,6 @@ func (g *Genesis) ToBlock(db ethdb.Database) *types.Block {
ShardStateHash: g.ShardStateHash,
ShardState: shardStateBytes,
}
- if g.GasLimit == 0 {
- head.GasLimit = 10000000000 // TODO(RJ): figure out better solution. // params.GenesisGasLimit
- }
statedb.Commit(false)
statedb.Data... | [Commit->[ToBlock],ToBlock->[Error],MarshalText->[MarshalText],MustCommit->[Commit],MustCommit] | ToBlock converts a genesis block into a block that can be sent to the network. | what is the default gas limit now? |
@@ -392,10 +392,13 @@ class LayerView(View):
self.setLayerViewType(int(float(Preferences.getInstance().getValue("layerview/layer_view_type"))));
- self.setExtruderOpacity(0, float(Preferences.getInstance().getValue("layerview/extruder0_opacity")))
- self.setExtruderOpacity(1, float(Preference... | [LayerView->[event->[enableLegend,disableLegend,getLayerViewType,setLayer,getLayerPass],calculateMaxLayers->[setLayer],_updateCurrentLayerMesh->[resetLayerData,setBusy],_startUpdateTopLayers->[setBusy],_updateWithPreferences->[setExtruderOpacity,setShowSkin,setShowInfill,setShowSupport,setLayerViewType,_startUpdateTopL... | Updates the view with preferences. | So you always set the extruderOpacity of the first extruder? I'm guessing you missed a extruder_nr += 1 somehwere in the loop. |
@@ -298,6 +298,13 @@ class T::Enum
@fully_initialized ||= false
end
+ # Maintains the order in which values are defined
+ sig {params(instance: T.attached_class).void}
+ def self._add_instance(instance)
+ @values ||= []
+ @values << instance
+ end
+
# Entrypoint for allowing people to register ne... | [to_json->[to_json],enums->[_bind_name,serialize],serialize->[serialize],comparison_assertion_failed->[inspect],deserialize->[from_serialized],to_str->[to_s],from_serialized->[try_deserialize],serialize] | Initializes a new Enum object. | Can you call this `_register_value` or `_register_instance`? |
@@ -241,6 +241,11 @@ class TopicViewSerializer < ApplicationSerializer
object.topic.shared_draft.present?
end
+ def is_shared_draft
+ include_destination_category_id?
+ end
+ alias_method :include_is_shared_draft?, :include_destination_category_id?
+
def include_pending_posts?
scope.authentica... | [TopicViewSerializer->[participant_count->[participant_count],draft_key->[draft_key],chunk_size->[chunk_size],highest_post_number->[highest_post_number],current_post_number->[current_post_number],last_read_post_number->[last_read_post_number],include_user_last_posted_at?->[has_topic_user?],message_bus_last_id->[message... | includes all components of a node that are required to create a shared draft. | Could we include this attribute only if it's true? |
@@ -1,4 +1,7 @@
Rails.application.configure do
+ # Verifies that versions and hashed value of the package contents in the project's package.json
+ config.webpacker.check_yarn_integrity = false
+
# Settings specified here will take precedence over those in config/application.rb.
# Code is not reloaded between... | [new,mailer_reply_to,formatter,queue_adapter,default_options,raise_delivery_errors,compile,enable_recaptcha,mailer_authentication,mailer_port,env,enable_email_confirmations,new_team_on_signup,consider_all_requests_local,log_formatter,cache_classes,mailer_address,deprecation,js_compressor,dump_schema_after_migration,log... | Rails configuration for the application. NGINX - varnish or squid - output. | Metrics/LineLength: Line is too long. [97/80] |
@@ -192,6 +192,7 @@ func runInIntegTestEnv(mageTarget string, test func() error, passThroughEnvVars
// compose.EnsureUp needs to know the environment type.
"-e", "STACK_ENVIRONMENT=" + StackEnvironment,
"-e", "TESTING_ENVIRONMENT=" + StackEnvironment,
+ "-e", "GENERATE=" + Generate,
}
args, err = addUidGi... | [Printf,Wrapf,Join,Unlock,Println,Exec,Do,ParseBool,Deps,Lock,Replace,LookupEnv,NewReplacer,Wrap,Getenv,Verbose] | Tests that we actually have a container and docker - compose and mage installed. - e - e - e - e - e - e - e - e - e. | This is a variable that specific to Filebeat (maybe others?) so rather than putting it into the framework I think it should be passed in from the Filebeat magefile.go. `RunIntegTest` accepts a vararg list of variables that should be passed through from the current environment into the container. |
@@ -0,0 +1,14 @@
+// Licensed to the .NET Foundation under one or more agreements.
+// The .NET Foundation licenses this file to you under the MIT license.
+// See the LICENSE file in the project root for more information.
+
+namespace System
+{
+ internal static class Obsoletions
+ {
+ internal const stri... | [No CFG could be retrieved] | No Summary Found. | Why not use regular CamelCase here? |
@@ -899,7 +899,7 @@ public virtual IFileInfo AddFile(IFolderInfo folder, string fileName, Stream fil
var file = DataCache.GetCache(strCacheKey);
if (file == null)
{
- file = CBO.Instance.FillObject<FileInfo>(DataProvider.Instance().GetFileById(fileID, retrieveUnpubl... | [FileManager->[ClearFolderCache->[ClearFolderCache],AddFile->[AddFile],OnFileRenamed->[OnFileRenamed],FileExists->[FileExists],GetContentType->[GetContentType],OnFileAdded->[OnFileAdded],WriteFileToHttpContext->[GetContentType],DeleteFile->[OnFileDeleted,DeleteFile],IFileInfo->[AddFileToFolderProvider,OnFileAdded,AddFi... | Get a file from the cache. | this and below changes same with this shouldn't change, otherwise will break all related unit tests. |
@@ -36,9 +36,16 @@ function replaceInFile (filename, regex, replacement) {
// ---------------------------------------------------------------------------
+const approvedIds = fs.readFileSync ('.ccxt.approve.cfg')
+ .toString ()
+ .split ('\n')
+ ... | [No CFG could be retrieved] | Creates a new file with the given name and replaces the given regular expression with the given replacement The main entry point for the ccxt module. | I hope you don't mind if I edit this a little, also, I'd switch the config to the json format, ok? |
@@ -202,7 +202,8 @@ export type DatepickerPropsT = CalendarPropsT & {
};
export type SharedStylePropsT = {
- $date: Date,
+ // eslint-disable-next-line flowtype/no-weak-types
+ $date: any,
$disabled: ?boolean,
$endDate: ?boolean,
$endOfMonth: ?boolean,
| [No CFG could be retrieved] | Create a calendar header based on a calendar s properties. ContainerStateT - A container state that exports a date in the calendar. | I tried to swap this over to `T` but discovered that all style properties were getting `automatically` typed as `any` anyway, so I just made this any to make it consistent. |
@@ -250,6 +250,7 @@ class Trilinos(CMakePackage):
conflicts('+belos', when='~teuchos')
conflicts('+epetraext', when='~epetra')
conflicts('+epetraext', when='~teuchos')
+ conflicts('+exodus', when='~netcdf')
conflicts('+ifpack2', when='~belos')
conflicts('+ifpack2', when='~teuchos')
conf... | [Trilinos->[cmake_args->[define_tpl_enable,define_trilinos_enable]]] | Define resources for all sequence numbers. Add flags to the sequence number conflict list. | Not really part of this PR. |
@@ -159,17 +159,6 @@ namespace NServiceBus.Features
return;
}
- if (!string.IsNullOrWhiteSpace(unicastConfig.ForwardReceivedMessagesTo))
- {
- var forwardAddress = Address.Parse(unicastConfig.ForwardReceivedMessagesTo);
- context.Contai... | [UnicastBus->[ConfigureMessageRegistry->[DebugFormat,InfoFormat,GetDurableMessagesEnabled,RegisterSingleton,IsDebugEnabled,Count,ToList,Select,IsInfoEnabled,Container,RegisterMessageType,ToString,Settings,Concat,SingleInstance],ConfigureBehaviors->[IsAbstract,IsAssignableFrom,Where,InstancePerCall,ConfigureComponent,Is... | Register message owners and bus addresses. | this code seems to be removed without replacement? Can you give some background on that change? |
@@ -50,7 +50,7 @@ public interface Ids {
int XID_DEADLOCK_DETECTING_GLOBAL_TRANSACTION = 33;
int XID_GLOBAL_TRANSACTION = 34;
- //int IN_DOUBT_TX_INFO = 35;
+ int IN_DOUBT_TX_INFO = 35;
int CACHE_RPC_COMMAND = 36;
| [No CFG could be retrieved] | Enumerates all the possible responses for a given node. Table 4 - > Table 5 - > Table 5 - > Table 6 - > Table 7. | Looks like we can revert these two. |
@@ -173,5 +173,11 @@ class ProductAttributeForm(forms.ModelForm):
exclude = []
+class StockLocationForm(forms.ModelForm):
+ class Meta:
+ model = StockLocation
+ fields = '__all__'
+
+
AttributeChoiceValueFormset = inlineformset_factory(
ProductAttribute, AttributeChoiceValue, exclud... | [ProductImageForm->[save->[save_variant_images]],VariantAttributeForm->[__init__->[CachingModelChoiceField]],VariantBulkDeleteForm->[delete->[delete]],StockBulkDeleteForm->[delete->[delete]],CachingModelChoiceField->[_get_choices->[CachingModelChoiceIterator]]] | Create an inlineformset for the ProductAttribute and AttributeChoiceValue. | It's better to use `exclude = []` |
@@ -76,12 +76,14 @@ class PexRequirements:
file_path: str | None = None,
file_path_description_of_origin: str | None = None,
is_lockfile: bool = False,
+ lockfile_hex_digest: str | None = None,
) -> None:
self.req_strings = FrozenOrderedSet(sorted(req_strings))
s... | [create_pex->[create_pex],parse_repository_info->[iter_dist_info->[PexDistributionInfo],PexResolveInfo,iter_dist_info],rules->[rules],BuildPexResult->[create_pex->[Pex]],PexRequirements->[create_from_requirement_fields->[PexRequirements]],build_pex->[BuildPexResult,generate_pex_arg_list],wrap_venv_prex_request->[VenvPe... | Initialize a NestedNode object. | You can remove `is_lockfile`. If `lockfile_hex_digest` is set, that implies it's a lockfile |
@@ -19,7 +19,8 @@ class Lbann(CMakePackage, CudaPackage):
maintainers = ['bvanessen']
- version('develop', branch='develop')
+ version('develop', preferred=True, branch='develop')
+ version('0.101', sha256='69d3fe000a88a448dc4f7e263bcb342c34a177bd9744153654528cd86335a1f7')
version('0.100', sha256... | [Lbann->[common_config_args->[append,format,join],cmake_args->[dirname,format,extend,satisfies],depends_on,extends,conflicts,version,when,variant]] | Create a new object of type with the given name. Returns a list of all possible version numbers for a given sequence. | I'm hesitant to make a non-checksummable moving target the version we install by default... |
@@ -1513,9 +1513,7 @@ public class MoveValidator {
testMatch = t.and(noImpassableOrRestricted);
}
final Route testRoute = data.getMap().getRoute_IgnoreEnd(start, end, testMatch);
- if (testRoute != null
- && testRoute.getLargestMovementCost(unitsWhichAreNotBeingTransportedOrDependen... | [MoveValidator->[validateTransport->[onlyIgnoredUnitsOnPath,getTerritoryTransportHasUnloadedTo,getEditMode,isLoad],nonParatroopersPresent->[allLandUnitsAreBeingParatroopered],getNeutralCharge->[getNeutralCharge],isNeutralsBlitzable->[isNeutralsImpassable],carrierMustMoveWith->[carrierMustMoveWith],validateParatroops->[... | Get the best route for the given start and end territory. Returns a route if it is possible to get a route with the given conditions. Checks if the route is satisfied or not. get route from testRoute or defaultRoute. | Ditto above question with respect to `testRoute` and `defaultRoute`. |
@@ -791,7 +791,9 @@ func validateBackup(backup *garden.Backup, cloudProvider garden.CloudProvider, f
if backup.Maximum <= 0 {
allErrs = append(allErrs, field.Invalid(fldPath.Child("maximum"), backup.Maximum, "maximum number must be greater than zero"))
}
-
+ if backup.DeletionGracePeriodDays != nil && *backup.De... | [ResourceName,Index,DetermineCloudProviderInProfile,ValidateImmutableField,ParseMaintenanceTime,Duplicate,DeepEqual,Compile,NewPath,Required,Add,Atoi,IsDNS1123Subdomain,Error,MatchString,CompareVersions,Cmp,FindStringSubmatch,NameIsDNSSubdomain,Child,ParseCIDR,Sub,Key,IncMinor,Contains,NotSupported,ValidateObjectMeta,N... | validateRole has the same logic as the above but it validates the role. Policy and the findSecretBinding returns true if the secret binding is found and there is at least one key. | See above, not needed. |
@@ -988,14 +988,15 @@ def parse_options(args: List[str]) -> Options:
parser.add_argument('--py2', action='store_true',
help="run in Python 2 mode (default: Python 3 mode)")
- parser.add_argument('--recursive', action='store_true',
- help="traverse listed modules... | [get_qualified_name->[get_qualified_name],has_return_statement->[ReturnSeeker],ImportTracker->[reexport->[require_name]],main->[walk_packages,generate_stub_for_module],find_module_path_and_all->[CantImport],find_self_initializers->[SelfTraverser],walk_packages->[walk_packages],StubGenerator->[add_coroutine_decorator->[... | Parse command line options and return a tuple of options. Options for the . | Minor nit: maybe use "quality of stubs" instead of "stubs quality". |
@@ -157,7 +157,8 @@ class Trilinos(Package):
'-DTrilinos_ENABLE_CXX11:BOOL=ON',
'-DTPL_ENABLE_Netcdf:BOOL=ON',
'-DTPL_ENABLE_HYPRE:BOOL=%s' % (
- 'ON' if '+hypre' in spec else 'OFF')
+ 'ON' if '+hypre' in spec else 'OFF'),
+ '-DCMAKE_INSTAL... | [Trilinos->[install->[popen,variants_check,satisfies,fix_darwin_install_name,working_dir,cmake,dirname,extend,filter_file,join,make],variants_check->[RuntimeError,satisfies],variant,depends_on,version,patch]] | Installs a cmake - specific . Add options to the list of options that can be passed to the command line. Flags for the generation of a single object. parmetis - parmetis - metis - lib - prefix. lib - prefix Add options for . | this is a substitution to `fix_darwin_install_name()`, removed below. |
@@ -280,6 +280,15 @@ public class JdkZlibDecoder extends ZlibDecoder {
}
}
+ private int inflate(ByteBuf decompressed, int writerIndex, int writable) throws DataFormatException {
+ if (IS_JAVA_11_INFLATER) {
+ return Java11ZlibUtils.inflate(inflater, decompressed.internalNioBuffer(w... | [JdkZlibDecoder->[handlerRemoved0->[handlerRemoved0]]] | Decodes the input buffer. This method is called when the output stream is full. It is called when the output stream. | We have an opportunity to use `ctx.alloc().buffer(preferredSize)` instead of `ctx.alloc().heapBuffer(preferredSize)` for `decompressed` if `IS_JAVA_11_INFLATER` is available. |
@@ -51,6 +51,5 @@ func (h *statusHandler) ServeHTTP(w http.ResponseWriter, r *http.Request) {
Version: versioninfo.PDReleaseVersion,
StartTimestamp: h.svr.StartTimestamp(),
}
-
h.rd.JSON(w, http.StatusOK, version)
}
| [ServeHTTP->[JSON,StartTimestamp]] | ServeHTTP implements the http. Handler interface. | Could you revert this change? |
@@ -113,6 +113,7 @@ class ConanFile(object):
self._conanfile_directory = conanfile_directory
self.package_folder = None # Assigned at runtime
+ self.log_folder = None # Assigned at runtime
self._scope = None
# user specified env variables
| [ConanFile->[__init__->[create_requirements,create_settings,create_options,create_exports]]] | Initialize a object. | Is this variable used somewhere? |
@@ -56,14 +56,10 @@ public class TopNMapFn
return longVal == null ? DimensionHandlerUtils.ZERO_LONG : longVal;
};
- private static Function<Object, Object> FLOAT_TRANSFORMER = input -> {
- final Float floatVal = DimensionHandlerUtils.convertObjectToFloat(input);
- return floatVal == null ? DimensionHan... | [TopNMapFn->[getValueTransformer->[IAE],apply->[createColumnSelectorPlus,cleanup,makeResultBuilder,build,makeInitParams,getDimensionSpec,getColumnSelectorFactory,columnValueSelector,run,getSelector,numValuesPerPass],convertObjectToDouble,TopNColumnSelectorStrategyFactory,convertObjectToLong,convertObjectToFloat,toStrin... | TopN map function. This method creates the top - n parameters for the given . | Could be a method reference? |
@@ -66,6 +66,13 @@ class AdNetworkConfigDef {
* @return {!SizeInfoDef}
*/
getSizing() {}
+
+ /**
+ * Returns the sticky ad attributes that should be applied on sticky ad.
+ * @param {!JsonObject} unusedConfigObj
+ * @return {JsonObject<string, string>} null if there is no sticky ad attributes.
+ */
... | [No CFG could be retrieved] | Creates an instance of the specified network type. The class is used to provide a way to configure the . | Why do you need all of this here? Instead can you put attribute extraction for sticky ads solely within AnchorAdStrategy? All you need is the config which is accessible there. |
@@ -103,10 +103,11 @@ class EthDistributor {
}
})
if (existingTxn) {
- return this.error(res, `Address ${ethAddress} already used this code.`)
+ return this._error(res, `Address ${ethAddress} already used this code.`)
}
// Create a FaucetTxn row in Pending status.
+ ... | [No CFG could be retrieved] | This function checks all existing transactions in the pending status and creates a FaucetTxn Send a transaction to a specific ethernet address. | probably one `await` too much |
@@ -61,7 +61,8 @@ PublisherImpl::~PublisherImpl()
ACE_ERROR((LM_ERROR,
ACE_TEXT("(%P|%t) ERROR: ")
ACE_TEXT("PublisherImpl::~PublisherImpl, ")
- ACE_TEXT("some datawriters still exist.\n")));
+ ACE_TEXT("%d datawriters and %d publications still exist.\n"),
+ datawriter_map_.s... | [No CFG could be retrieved] | region InstanceHandlePublisher DCPS - DCPS This function returns true if the object is found in the DDS. | size_t needs a different logging formatter to avoid 32-bit/64-bit mismatch (also in SubscriberImpl) |
@@ -93,6 +93,15 @@ public class RecommendationAICatalogItemIT {
testPipeline.run().waitUntilFinish();
}
+ @AfterClass
+ public static void tearDownAfterClass() throws Exception {
+ try (CatalogServiceClient catalogServiceClient = CatalogServiceClient.create()) {
+ catalogServiceClient.deleteCatalogI... | [RecommendationAICatalogItemIT->[createCatalogItem->[getCatalogItem],importCatalogItems->[getCatalogItem]]] | Import catalog items. | This should be the project ID from pipeline options, not `matthias-sandbox`. |
@@ -53,6 +53,7 @@ def test_infer_python_imports() -> None:
)
rule_runner.create_file("src/python/str_import/subdir/f.py")
+ rule_runner.create_file("src/python/str_import/subdir/f.pyi")
rule_runner.add_to_build_file("src/python/str_import/subdir", "python_library()")
rule_runner.create_file("... | [test_infer_python_conftests->[run_dep_inference],test_infer_python_inits->[run_dep_inference],test_infer_python_imports->[run_dep_inference]] | Test to infer python imports. Checks if the target is in the correct state. | Is this just to test that the normal rules tests don't explode if given `.pyi` source files? No need to change anything, just wondering. |
@@ -57,10 +57,15 @@ class ConvBNLayer(fluid.dygraph.Layer):
self._batch_norm = BatchNorm(
self.full_name(), num_filters, act=act, momentum=0.1)
+ self._layer_norm = fluid.dygraph.nn.LayerNorm(
+ self.full_name(), begin_norm_axis=1)
def forward(self, inputs):
y =... | [TestSeResNeXt->[get_model->[SeResNeXt]],SeResNeXt->[__init__->[ConvBNLayer,BottleneckBlock]],BottleneckBlock->[__init__->[ConvBNLayer,SqueezeExcitation]]] | A layer which performs a non - zero cross - validation on the hidden layer. | how about delete this? |
@@ -598,6 +598,13 @@ class PrintConstraint(object):
class TypeVarMap(dict):
+ def copy(self):
+ clone = TypeVarMap()
+ clone.set_context(self.context)
+ for k, v in self.items():
+ clone[k] = v
+ return clone
+
def set_context(self, context):
self.context = c... | [CallConstraint->[resolve->[add_type,fold_arg_vars,getone]],_BuildContainerConstraint->[__call__->[add_type]],PairFirstConstraint->[__call__->[add_type]],IntrinsicCallConstraint->[__call__->[resolve]],TypeVar->[union->[add_type]],BuildTupleConstraint->[__call__->[add_type]],TypeVarMap->[__getitem__->[TypeVar]],TypeInfe... | Set the context for the type variables. | I don't see this method used. Am I missing something? |
@@ -303,12 +303,13 @@ public class SimpleChannelPool implements ChannelPool {
}
}
- private static void closeChannel(Channel channel) {
+ private void closeChannel(Channel channel) {
channel.attr(POOL_KEY).getAndSet(null);
channel.close();
+ this.allChannels.remove(channel... | [SimpleChannelPool->[acquire->[acquire],notifyHealthCheck->[acquireHealthyFromPoolOrNew],release->[release],closeAndFail->[closeChannel],close->[close,pollChannel]]] | Release a channel and offer it to the pool. | you can remove `this.` ? |
@@ -37,6 +37,7 @@ const Balances = ({ currencies, title, className, onClose }) => {
className="more-ogn"
onClose={onClose}
onNavigation={onClose}
+ gotowelcomewhennotenrolled="true"
>
<fbt desc="Balances.getMor... | [No CFG could be retrieved] | Create a Balances component. Displays a block of balances for a specific node. | Any reason this has to be all lower case? |
@@ -273,7 +273,7 @@ class Jetpack_React_Page extends Jetpack_Admin_Page {
'dismissedNotices' => $this->get_dismissed_jetpack_notices(),
'isDevVersion' => Jetpack::is_development_version(),
'currentVersion' => JETPACK__VERSION,
- 'is_gutenberg_available' => Jetpack_Gutenberg::is_gutenberg_available(),
+ ... | [Jetpack_React_Page->[page_render->[render_nojs_configurable],add_noscript_head_meta->[add_fallback_head_meta],get_initial_state->[get_dismissed_jetpack_notices]]] | Get the initial state of the API. Get all theme information about the current theme. This function is called from the Jetpack plugin. It is called from the administration This method is used to provide a basic configuration for the Jetpack plugin. | Is there any benefit to leaving this to call the function? |
@@ -130,6 +130,9 @@ function buildAdUrl(
const iframeDepth = iframeNestingDepth(global);
const dtdParam = {name: 'dtd'};
const adElement = a4a.element;
+ if (ValidAdContainerTypes.indexOf(adElement.parentElement.tagName) >= 0) {
+ queryParams.push({name: 'amp_ct', value: adElement.parentElement.tagName});
... | [No CFG could be retrieved] | Builds the URL for an AMP A4A . unboundedQueryParams top window url or domain. | Linear search! Ick! Well, okay, I guess it's just on a list of length two... :-) |
@@ -43,12 +43,10 @@ foreach ($items as $item) {
'is_trusted' => true,
));
$type = elgg_echo($item->type);
- echo <<<HTML
-<li id="$item->shortname" class="clearfix">
- <span class="elgg-icon elgg-icon-drag-arrow elgg-state-draggable"></span>
- <b><span id="elgg-profile-field-{$item->shortname}" class="elgg-state... | [No CFG could be retrieved] | Print a list of all possible missing items. | Our coding standards actually prefer: `"Some {$text} here"` instead of: `"Some " . $text . " here"` |
@@ -339,7 +339,7 @@ int codec_reset(struct comp_dev *dev)
/* Codec reset itself to the initial condition after prepare()
* so let's change its state to reflect that.
*/
- codec->state = CODEC_INITIALIZED;
+ codec->state = CODEC_IDLE;
return 0;
}
| [No CFG could be retrieved] | function to handle the configuration of a specific codec Free all memory requested by a specific codec. | Not following, if we reset() the codec then any configuration via IPC will also be reset like channels, rate, format etc ? |
@@ -1957,8 +1957,14 @@ func (dctx *docGenContext) generatePackage(tool string, pkg *schema.Package) (ma
glog.V(3).Infoln("generating package docs now...")
files := fs{}
- for _, mod := range dctx.modules() {
- if err := mod.gen(files); err != nil {
+ modules := []string{}
+ modMap := dctx.modules()
+ for k := ra... | [getPythonLookupParams->[getLanguageDocHelper],getTSLookupParams->[getLanguageDocHelper],genLookupParams->[getTSLookupParams,getCSLookupParams,getPythonLookupParams,getGoLookupParams],genConstructorGo->[getLanguageDocHelper],getConstructorResourceInfo->[getLanguageModuleName],getPropertiesWithIDPrefixAndExclude->[typeS... | generatePackage generates the package docs. | Oof nice find. Anything else using dctx.modules() like this? |
@@ -76,15 +76,12 @@ public class BulkStatus implements Serializable {
@AvroEncode(using = InstantAsLongEncoding.class)
protected Instant scrollEndTime;
- @Nullable
- protected Long processed;
+ @AvroEncode(using = InstantAsLongEncoding.class)
+ protected Instant completedTime;
@Nullable
... | [BulkStatus->[unknownOf->[BulkStatus],deltaOf->[BulkStatus]]] | A message representing a bulk status of a command. Merges the status of this object with the given status. | I don't really understand the how the code works but I assume it does! Here it looks like you are serialising instants as longs with avro? But elsewhere you have Instants in json, which are serialized as ISO-8601 strings. |
@@ -138,6 +138,7 @@ function isBuildSystemFile(filePath) {
function isValidatorFile(filePath) {
if (filePath.startsWith('validator/')) return true;
if (!path.dirname(filePath).endsWith('0.1') &&
+ !path.dirname(filePath).endsWith('1.0') &&
!path.dirname(filePath).endsWith('test'))
return false;
... | [No CFG could be retrieved] | Determines whether a given file is a well - known flag configuration file that is part of the Determines if the given files are build - targets. | can we make this dynamic then? |
@@ -209,7 +209,9 @@ CONTAINER;
$item_id = esc_js( $item_id );
- if ( $inline ) {
+ if ( Jetpack_AMP_Support::is_amp_request() ) {
+ return sprintf( '<a href="%s" target="_blank">%s</a>', esc_url( $permalink ), esc_html( trim( $title ) ) );
+ } elseif ( $inline ) {
return <<<SCRIPT
<div class="cs-... | [CrowdsignalShortcode->[crowdsignal_shortcode->[compress_it,get_async_code]]] | Crowdsignal shortcode helper This function is used to render the JS for the rating holder. JS for the rating - related section Shortcode - Poll a component for handling missing nodes description = > Generate a link to the survey function to generate the crowd - style - auto - src tag function to generate the async code... | Just a note that we'd need to add in support for this function before merging to WP.com. |
@@ -265,15 +265,11 @@ export class ImageViewer {
* @param {?Element} sourceImage
*/
init(sourceElement, sourceImage) {
- this.sourceWidth_ = this.getSourceWidth_(sourceElement, sourceImage);
- this.sourceHeight_ = this.getSourceHeight_(sourceElement, sourceImage);
+ this.setSourceDimensions_(sourceE... | [No CFG could be retrieved] | Initializes the image viewer and image sizes and positioning. let is the base of the let that is the size of the viewer box. | nit: `e` is a little too ambiguous for this variable name. Is it the `BaseElement` subclass instance? Usually `e` is just for `Event` instances. |
@@ -451,7 +451,6 @@ JhipsterGenerator.prototype.app = function app() {
this.template('src/main/java/package/aop/logging/_LoggingAspect.java', javaDir + 'aop/logging/LoggingAspect.java');
this.template('src/main/java/package/config/apidoc/_package-info.java', javaDir + 'config/apidoc/package-info.java');
- ... | [No CFG could be retrieved] | This method removes all files from the application. This method is used to generate the configuration files. | If you don't generate the file, can you also delete it? There's a section for removing files -> this is for people upgrading from an older version |
@@ -12,7 +12,11 @@ module Metrics
next unless model.const_defined?(:SEARCH_CLASS)
- document_count = model::SEARCH_CLASS.document_count
+ document_count = if model::SEARCH_CLASS.respond_to?("#{model.to_s.underscore}_document_count")
+ model::SEARCH_CLASS.send("#{mode... | [RecordDataCountsWorker->[perform->[gauge,estimated_count,table_name,info,each,const_defined?,document_count],sidekiq_options,include]] | perform_n_seq - computes the count of a node in the database. | `.public_send` is safer than `.send` |
@@ -379,6 +379,14 @@ func setupNodeAndRun(hc harmonyConfig) {
nodeconfig.SetPeerID(myHost.GetID())
+ if hc.Log.VerbosePrints.Config {
+ utils.Logger().Info().Interface("config", rpc_common.Config{
+ HarmonyConfig: hc,
+ NodeConfig: *nodeConfig,
+ ChainConfig: *currentNode.Blockchain().Config(),
+ }).... | [Warn,LastCommitBitmap,SerializeToHexStr,Info,Itoa,Rollback,ReadFile,SetParseErrorHandle,GetBoolFlagValue,New,Maximum,GetShardDownloader,ArchiveModes,SetViewIDs,Fprint,UpdateEthChainIDByShard,SetBeaconGroupID,FindAccount,IsFlagChanged,Split,Seed,UpdateConsensusInformation,RegisterService,Println,AddLogFile,ReshardingEp... | This function is called when a new block is committed. It is called by the network layer Reads the nexus node and starts the necessary services and RPCs. | @LeoHChen Do you prefer `debug` level over `info` level for this? |
@@ -607,10 +607,12 @@ export class UrlReplacements {
* @param {!Object<string, *>=} opt_bindings
* @param {!Object<string, *>=} opt_collectVars
* @param {boolean=} opt_sync
+ * @param {!Object<string, boolean>=} opt_whiteList Optional white list of names
+ * that can be substituted.
* @return {!... | [UrlReplacements->[constructor->[shareTrackingForOrNull,variantForOrNull],getTimingDataAsync_->[whenDocumentComplete,resolve],buildExpr_->[length,join,sort],expand_->[then,split,resolve,user,encodeValue,apply,replace,async,rethrowAsync,catch,sync],getTimingDataSync_->[isFiniteNumber],collectVars->[create],setAsync_->[d... | Expand URL with optional bindings. check if the value is not null and if so encode it. | This is probably ok as a first start, but I think the final API will be drastically different when we need to support the whole table of enabled/disabled/overriden vars. In the meantime, we could even simply call `string.replace('CLIENT_X', value)` to get us past this point and closer to correct implementation. |
@@ -186,14 +186,14 @@ func (sg *stepGenerator) GenerateSteps(event RegisterResourceEvent) ([]Step, err
var analyzer plugin.Analyzer
analyzer, err = sg.plan.ctx.Host.Analyzer(a)
if err != nil {
- return nil, err
+ return nil, result.FromError(err)
} else if analyzer == nil {
- return nil, errors.Errorf... | [GenerateDeletes->[V,Infof],GenerateSteps->[Analyze,GetProvider,New,Diag,ParseReference,DependingOn,Analyzer,Errorf,Assert,Olds,issueCheckErrors,diff,IsProviderType,Infof,V,generateURN,GetAnalyzeResourceFailureError,GetDuplicateResourceURNError,Replace,Check,NewState,Goal],GenerateReadSteps->[ID,Infof,Provider,Name,gen... | GenerateSteps generates the necessary steps for a checkpoint check if a resource has a provider reference This function is called by the engine to analyze a resource and perform the necessary actions. This method is used to create a new resource in place or replace a resource in place. | Should this instead report a diagnostic and then `Bail`? |
@@ -1,6 +1,8 @@
/*
* The MIT License
- *
+ *
+ * Copyright (c) 2019 Intel Corporation
+ *
* Copyright (c) 2004-2012, Sun Microsystems, Inc., Kohsuke Kawaguchi,
* Daniel Dyer, Red Hat, Inc., Tom Huybrechts, Romain Seguy, Yahoo! Inc.,
* Darek Ostolski, CloudBees, Inc.
| [Run->[getIconColor->[getIconColor,isBuilding,getResult],getRootDir->[toString],getACL->[getACL],onLoad->[onLoad],getPreviousBuildInProgress->[getPreviousBuild,_this,isBuilding],getPreviousNotFailedBuild->[getPreviousBuild,getResult],doBuildTimestamp->[getTime],doConsoleText->[getLogInputStream],ArtifactList->[combineL... | Permission for obtaining a single from a Software. Imports all packages that are required by Jenkins. | It is better to modify the copyright below and to just add Intel to the list |
@@ -330,7 +330,7 @@ public class ReliabilityAndSecurityRatingMeasuresVisitorForReportTest {
.setKey(Uuids.create())
.setSeverity(severity)
.setType(type)
- .setCreationDate(DEFAULT_ISSUE_CREATION_DATE);
+ .setCreationDate(new Date(1000l));
}
}
| [ReliabilityAndSecurityRatingMeasuresVisitorForReportTest->[compute_E_reliability_and_security_rating_on_blocker_issue->[visit,newVulnerabilityIssue,newBugIssue,verifyAddedRawMeasure,setRoot,setIssues],compute_new_reliability_rating->[visit,setCreationDate,verifyAddedRawMeasureOnLeakPeriod,setRoot,setResolution,setIssu... | Creates a new issue with the specified severity and type. | why the change of date? |
@@ -14,8 +14,9 @@ class TargetConfigurationTemplate(CMakeDepsFileTemplate):
@property
def filename(self):
- return "{}Target-{}.cmake".format(self.file_name,
- self.cmakedeps.configuration.lower())
+ name = "" if not self.find_module_mode else "module-"... | [TargetConfigurationTemplate->[context->[get_required_components_names,join,get_deps_targets_names],template->[dedent],filename->[format,lower],get_deps_targets_names->[get_target_namespace,append,get_component_alias,format,values],get_required_components_names->[append,get_component_alias,get_sorted_components,items,r... | Returns the filename of the cmake dependency. | I was not aware about this "module" prefix, I thought the .cmake scripts had to be called ``find_zlib.cmake`` or something similar. |
@@ -198,10 +198,13 @@ class StockApp(VBox):
self.ticker2 = new
if obj == self.ticker1_select:
self.ticker1 = new
- self.make_source()
- self.make_plots()
- self.set_children()
- curdoc().add(self)
+
+ # avoid trying to compare same stocks
+ if... | [StockApp->[make_plots->[line_plot],hist_plots->[hist_plot],input_change->[make_source,set_children,make_plots],selection_change->[make_stats,hist_plots,set_children],df->[get_data]],make_object->[create],get_data->[get_ticker_data]] | Called when the user changes the value of the key. | Not sure about this... when I tried it and I did not see any update or any message about I am trying to compare the same stock... seems that the app is not working... I guess I prefer the comparative between the same stock, even if it is redundant... other @bokeh/core thoughs? |
@@ -109,6 +109,11 @@ func (v *VolumeStore) VolumeCreate(op trace.Operation, ID string, store *url.URL
}
u, _ := v.Service.URL()
+ if u.Scheme != "nfs" {
+ op.Errorf("URL from nfs mount target had scheme (%s) instead of nfs for volume store (%s)", u.Scheme, v.Name)
+ return nil, fmt.Errorf("Unexpected scheme (%s... | [VolumesList->[volDirPath],writeMetadata->[volMetadataDirPath],getMetadata->[volMetadataDirPath],VolumeCreate->[volDirPath],VolumeDestroy->[volDirPath,volMetadataDirPath]] | VolumeCreate creates a new nfs volume. | Make nfs string a const and use it here |
@@ -1,6 +1,6 @@
require 'rails_helper'
-describe ClientApi::Users::UsersController, type: :controller do
+describe ClientApi::Users::UsersController, type: :controller, broken: true do
login_user
before do
| [let,to_not,describe,recent_email_notification,eql,first,it,to,before,post,assignments_notification,require,sign_out,system_message_email_notification,recent_notification,have_http_status,assignments_email_notification,get,not_to,eq,save] | on_action = > check_action on all actions responds successfully if time_zone email and password are updated. | Block has too many lines. [207/25] |
@@ -41,14 +41,9 @@ class PerforceTest extends TestCase
$this->createNewPerforceWithWindowsFlag(true);
}
- protected function tearDown()
- {
- $this->perforce = null;
- $this->io = null;
- $this->repoConfig = null;
- $this->processExecutor = null;
- }
-
+ /**
+ ... | [PerforceTest->[testQueryP4UserWithUserSetInP4VariablesWithWindowsOS->[createNewPerforceWithWindowsFlag],testQueryP4PasswordWithPasswordSetInP4VariablesWithWindowsOS->[createNewPerforceWithWindowsFlag],testQueryP4UserStoresResponseToQueryForUserWithoutWindows->[createNewPerforceWithWindowsFlag],testQueryP4PasswordWithP... | Sets up the mock environment and sets up the necessary objects. | All those attributes are written in `setUp`, so reseting them to `null` in a tear down does not make any sense IMO. |
@@ -23,10 +23,10 @@ def send_password_reset_email(context, recipient):
@shared_task
def send_account_delete_confirmation_email(token, recipient_email):
- site = Site.objects.get_current()
delete_url = build_absolute_uri(
reverse('account:delete-confirm', kwargs={'token': token}))
- ctx = {'site_... | [send_password_reset_email->[build_absolute_uri,send_templated_mail,reverse],send_account_delete_confirmation_email->[get_current,send_templated_mail,reverse,build_absolute_uri]] | Sends an email to the user that the user has confirmed the deletion of a node. | I think this URL could use more meaningful name |
@@ -61,8 +61,11 @@ class TraceableObject(object):
if len(frame_records) >= local_offset:
# Negative indexing is one-indexed instead of zero-indexed.
negative_offset = -(local_offset + 1)
- self.filename, self.lineno = frame_records[negative_offset][:2]
- return self.SUCCESS
+ if len(fr... | [TraceableStack->[copy->[TraceableStack],push_obj->[TraceableObject,set_filename_and_line_from_caller]]] | Set filename and line using the caller s stack frame. | Ah sorry I didn't read this logic carefully enough when I first looked. I think you should change L61 to `if len(frame_records) > local_offset`, and if they're equal fall through to the HEURISTIC_USED case below. |
@@ -967,7 +967,7 @@ class Worker
}
/**
- * @brief Call the front end worker
+ * Call the front end worker
* @return void
* @throws \Friendica\Network\HTTPException\InternalServerErrorException
*/
| [Worker->[processQueue->[isMinMemoryReached,isMaxProcessesReached,release,isMaxLoadReached,acquire],execFunction->[reset,saveLog],spawnWorker->[getBasePath,run],workerProcess->[release,acquire],add->[isBackend,release,acquire],execute->[isMaxProcessesReached]]] | Call the frontend worker. | Plz add a blank line between tags and summary for better readability |
@@ -59,9 +59,9 @@ class RenewerConfigurationTest(unittest.TestCase):
@mock.patch('letsencrypt.configuration.constants')
def test_dynamic_dirs(self, constants):
- constants.ARCHIVE_DIR = "a"
+ constants.ARCHIVE_DIR = 'a'
constants.LIVE_DIR = 'l'
- constants.RENEWAL_CONFIGS_DIR =... | [RenewerConfigurationTest->[test_dynamic_dirs->[assertEqual],setUp->[MagicMock,RenewerConfiguration],patch],NamespaceConfigTest->[test_dynamic_dirs->[assertEqual],test_server_path->[split,assertEqual],test_proxy_getattr->[assertEqual],setUp->[NamespaceConfig,MagicMock],patch],main] | Test dynamic directories. | Sorry I pushed this in here... just unifying quotes in the file. |
@@ -0,0 +1,15 @@
+from django import forms
+from django.utils.translation import ugettext_lazy as _
+from ...setting.models import Setting
+
+
+class SettingForm(forms.ModelForm):
+ class Meta:
+ model = Setting
+ exclude = []
+
+ def clean_name(self):
+ name = self.cleaned_data['name']
+ ... | [No CFG could be retrieved] | No Summary Found. | New line is missing. |
@@ -125,12 +125,15 @@ var (
func newAccessController(options map[string]interface{}) (registryauth.AccessController, error) {
log.Info("Using Origin Auth handler")
- realm, ok := options["realm"].(string)
+ realm, ok := options[RealmKey].(string)
if !ok {
// Default to openshift if not present
realm = "ori... | [SetHeaders->[Error],Error->[Error],Clients->[Clients],Authorized->[Add,Empty,wrapErr],SafeClientConfig,Get] | Error returns the error message of the challenge. | why not check for nil here? |
@@ -984,6 +984,7 @@ func (rm *resmon) RegisterResource(ctx context.Context,
// Invoke the provider's Construct RPC method.
options := plugin.ConstructOptions{
Aliases: aliases,
+ Dependencies: dependencies,
Protect: protect,
PropertyDependencies: propertyDependencie... | [ReadResource->[getDefaultProviderRef],handleRequest->[newRegisterDefaultProviderEvent],StreamInvoke->[StreamInvoke],Invoke->[Invoke],serve->[handleRequest],Call->[Call],getDefaultProviderRef,serve] | RegisterResource registers a new resource with the resource manager This function is called by the controller to populate the list of providers that are required to provide This function is called by the resource monitor to register a secret with the resource monitor. | Does this address the "dependencies from the resource options to a remote component were not being respected" issue you called out in Slack? Should we add more coverage that checks that dependencies and property dependencies from a program are showing up in `Construct` as expected? |
@@ -0,0 +1,5 @@
+class AddBannerStyleToBroadcasts < ActiveRecord::Migration[6.0]
+ def change
+ add_column :broadcasts, :banner_style, :string
+ end
+end
| [No CFG could be retrieved] | No Summary Found. | should this have a `null: false` plus default value or it doesn't matter if existing broadcasts don't have a style set? |
@@ -291,9 +291,12 @@ module Discourse
require 'logster/redis_store'
# Use redis for our cache
config.cache_store = DiscourseRedis.new_redis_store
- $redis = DiscourseRedis.new # rubocop:disable Style/GlobalVars
+ Discourse.redis = DiscourseRedis.new
Logster.store = Logster::RedisStore.new(Disc... | [Application->[watchable_args->[root,each,delete],config->[production?,database_config],pbkdf2_algorithm,new,register_mime_type,use_schema_cache_dump,ember_location,register_postprocessor,paths,activate_plugins!,ignore,skip_multisite_middleware,atomic_ln_s,after_initialize,autoloader,load_path,lambda,skip_message_bus_m... | Configure the application s middleware and handlebars. This method is called to set the relative_url_root of the plugin. | Perhaps we should just remove this in the next release so that we at least have a plan for what to do here. |
@@ -680,7 +680,8 @@ def _read_config_file(filename, schema):
try:
tty.debug("Reading config file %s" % filename)
with open(filename) as f:
- data = _mark_overrides(syaml.load(f))
+ base_data = syaml.load(f)
+ data = _mark_overrides(base_data)
if data:
... | [default_modify_scope->[highest_precedence_scope],_mark_overrides->[_mark_overrides],_mark_internal->[_mark_internal],InternalConfigScope->[write_section->[get_section]],ConfigScope->[get_section->[get_section_filename],write_section->[get_section_filename,get_section]],_config->[InternalConfigScope,ConfigScope,_add_pl... | Read a YAML configuration file. | Can you remove the extraneous change separating these lines? |
@@ -836,8 +836,7 @@ static int char2_curve_test(int n)
|| !TEST_true(BN_hex2bn(&p, test->p))
|| !TEST_true(BN_hex2bn(&a, test->a))
|| !TEST_true(BN_hex2bn(&b, test->b))
- || !TEST_true(group = EC_GROUP_new(EC_GF2m_simple_method()))
- || !TEST_true(EC_GROUP_set_curve(group, p, a,... | [No CFG could be retrieved] | An example of how to handle a sequence of tokens. A list of all possible unpredictable words. A u tow n s a van d d d d d d d d d. | Sidenote: do you have thoughts about deprecating also EC_GROUP_set_curve? (as another PR in case it makes sense) |
@@ -527,8 +527,6 @@ func TestEthTxAdapter_Perform_NotConnected(t *testing.T) {
defer cleanup()
store := app.Store
- assert.NoError(t, app.Start())
-
adapter := adapters.EthTx{}
input := models.RunResult{}
data := adapter.Perform(input, store)
| [Context,EthTx,HexToFunctionSelector,NewAddress,NewHash,AnyTimes,Perform,Connected,NewGomegaWithT,TxFrom,False,NewStore,Eventually,Encode,StartAndConnect,BumpGasUntilSafe,Add,PendingConfirmations,JSONFromString,GetAccountAddress,MustDecode,RunResultWithResult,SaveTx,Int,Should,AddTxAttempt,Error,EventuallyAllCalled,New... | TestEthTxAdapter_Perform_NotConnected tests that the EthTx adapter does. | Now that we connect immediately instead of 1 second later, `Start` introduces race conditions. Remove where applicable in tests for pending connection. |
@@ -26,6 +26,8 @@ class IScanner(object):
if not isinstance(self.input_type, dp2.InputType):
raise ValueError("input type should be dataprovider2.InputType")
self.pos = pos
+ self.use_gpu = True if swig_paddle.isUsingGpu() and (
+ swig_paddle.getTrainerCount() == 1) else... | [SparseFloatScanner->[__init__->[__init__]],DenseScanner->[__init__->[__init__]],DataProviderConverter->[__call__->[convert],create_scanner->[SparseFloatScanner,DenseScanner,SequenceScanner,SparseBinaryScanner,IndexScanner],convert->[scan,finish_scan]],SequenceScanner->[finish_scan->[finish_scan],get_size->[get_size],s... | Initialize a sequence of functions. | trainer counter>1MultiGradientMachine?""trainer counter>1? ""NeuralNetworkMultiGradientMachine? |
@@ -205,7 +205,7 @@ function _mapStateToProps(state) {
_bottomSheetStyles: ColorSchemeRegistry.get(state, 'BottomSheet'),
_isOpen: isDialogOpen(state, OverflowMenu_),
_width: state['features/base/responsive-ui'].clientWidth,
- _reactionsEnabled: getFeatureFlag(state, REACTIONS_ENABLED,... | [No CFG could be retrieved] | Map state to props of the Dialog. | Please don't disable them. We want them enabled by default. |
@@ -329,13 +329,13 @@ public class ListView extends View implements Saveable {
}
}
- setIncludeRegex(req.getParameter("useincluderegex"));
+ setIncludeRegex(req.getParameter("useincluderegex"), req.getParameter("includeRegex"));
if (columns == null) {
column... | [ListView->[contains->[contains],includeItems->[getItems,includeItems],jobNamesContains->[contains],getItems->[getItems,getJobFilters],onJobRenamed->[add],add->[add],submit->[getItems,add],doAddJobToView->[add],doCreateItem->[add,doCreateItem]]] | This method is called when the user submit the request. | Check for nullity of useincluderegex should be done here, no need to pass it to the method. |
@@ -202,7 +202,8 @@ class SafeFastPrimitivesCoder(coders.Coder):
# pylint: disable=deprecated-urllib-function
def encode(self, value):
- return quote(coders.coders.FastPrimitivesCoder().encode(value))
+ return quote(coders.coders.FastPrimitivesCoder().encode(value)).encode(
+ 'utf-8')
def deco... | [WriteCache->[expand->[sink]],ReadCache->[expand->[source]],FileBasedCacheManager->[cleanup->[exists],read->[exists,_latest_version,_read_helper],_match->[_glob_path]]] | Encode and decode a . | Do we need to also `s/value/value.decode('utf-8')/` in Line 209 in this case? |
@@ -72,6 +72,7 @@ public final class ObjectCleaner {
if (LIVE_SET.isEmpty() || !CLEANER_RUNNING.compareAndSet(false, true)) {
// There was nothing added after we set STARTED to false or some other cleanup Thread
// was started already so its safe to let this Th... | [ObjectCleaner->[AutomaticCleanerReference->[cleanup->[run],clear->[clear]]]] | This method is run in a thread. It will check if the Thread has a reserved reserved. | This may race with the thread setting the variable in the register method below. |
@@ -282,7 +282,14 @@ class Trainer(TrainerBase):
self._pytorch_model = self.model
def rescale_gradients(self) -> Optional[float]:
- return training_util.rescale_gradients(self.model, self._grad_norm)
+ if self._opt_level is not None:
+ if self._grad_norm:
+ # ... | [Trainer->[_validation_loss->[batch_loss],_train_epoch->[rescale_gradients,batch_loss],rescale_gradients->[rescale_gradients],train->[_validation_loss,_train_epoch]]] | Rescale gradients of the model and return the loss. | Another option here is to add a `use_amp` flag to `rescale_gradients`. Oh, except that then also requires passing in the optimizer... Yeah, I think what you have here is good enough. |
@@ -410,6 +410,11 @@ public class SlaveComputer extends Computer {
return channel.call(new LoadingTime(true));
}
+ @CheckForNull
+ public String getAbsoluteRemoteFs() {
+ return channel == null ? null : absoluteRemoteFs;
+ }
+
static class LoadingCount extends MasterToSlaveCallable<... | [SlaveComputer->[getRetentionStrategy->[getNode,getRetentionStrategy],setNode->[setNode],getClassLoadingTime->[call],getResourceLoadingCount->[call],getNode->[getNode],grabLauncher->[getLauncher],taskCompleted->[taskCompleted],taskCompletedWithProblems->[taskCompletedWithProblems],getIcon->[getIcon],disconnect->[discon... | Get the resource loading time in milliseconds. | Either `@Restricted` or `@since` or not `public`. |
@@ -52,11 +52,14 @@ public class KVMHAVMActivityChecker extends KVMHABase implements Callable<Boolea
cmd.add("-t", String.valueOf(String.valueOf(System.currentTimeMillis() / 1000)));
cmd.add("-d", String.valueOf(suspectTimeInSeconds));
OutputInterpreter.OneLineParser parser = new OutputInterp... | [KVMHAVMActivityChecker->[call->[checkingHB],checkingHB->[execute,OneLineParser,debug,Script,getLine,contains,currentTimeMillis,add,getStandardSeconds,valueOf],getLogger,standardSeconds]] | Checks if there is a KVMHAVM activity in the pool. | @GutoVeronezi may be you can also improve this method name, `checkingHB()` => _checkingHeartBeat()_ |
@@ -73,9 +73,18 @@ public class ComponentRootBuilder {
}
}
+ private ComponentImpl buildProjectComponent(ScannerReport.Component reportComponent, String latestModuleKey) {
+ ComponentImpl.Builder builder = createCommonBuilder(reportComponent, latestModuleKey, latestModuleKey);
+ return builder
+ .... | [ComponentRootBuilder->[createReportAttributes->[build],buildOtherComponent->[build],buildComponent->[build]]] | Creates a component based on the given reportComponent. | it's quite strange to initialise a builder field from another builder field. Usually builders have only setters. In order to remove the need for adding `ComponentImpl.Builder#getUuid()`, I suggest to extract generation of UUID (`uuidSupplier.apply(componentKey)`) from `createCommonBuilder()`. |
@@ -74,7 +74,7 @@ class Listings extends Component {
<DocumentTitle pageTitle={<fbt desc="listings.title">Listings</fbt>} />
<div className="container listings-container">
{this.props.isMobile ? (
- <Search className="search" placeholder />
+ <Search className="search"... | [No CFG could be retrieved] | The component that renders the missing missing node index and the missing node index - > Displays a list of nodes that have a non - empty . | are there any instances of the Search component that don't need showDropdown? |
@@ -98,9 +98,10 @@ namespace System.Xml
return this.prefix.GetHashCode() ^ this.localname.GetHashCode();
}
- public int GetNSHashCode(SecureStringHasher hasher)
+ public int GetNSHashCode()
{
- return hasher.GetHashCode(this.namespaceUri)... | [XmlSqlBinaryReader->[ReadContentAsBoolean->[ReadContentAsBoolean,FinishContentAsXXX,SetupContentAsXXX],ReadContentAsFloat->[ReadContentAsFloat,FinishContentAsXXX,SetupContentAsXXX],ValueAsString->[CheckValueTokenBounds,ParseMB32,GetString,ToString,ValueAsDateTimeString],ReadContentAs->[ToString,FinishContentAsXXX,Read... | Compares this QName with another QName. | Would it be better to do `HashCode.Combine(namespaceUri, localname)` directly here? Avoids layers of indirection. |
@@ -42,8 +42,8 @@ abstract public class AbstractZeppelinIT {
protected final static Logger LOG = LoggerFactory.getLogger(AbstractZeppelinIT.class);
protected static final long MIN_IMPLICIT_WAIT = 5;
protected static final long MAX_IMPLICIT_WAIT = 30;
- protected static final long MAX_BROWSER_TIMEOUT_SEC = 30;... | [AbstractZeppelinIT->[waitForParagraph->[getParagraphXPath],getParagraphStatus->[getParagraphXPath]]] | Sets the text of a paragraph. | I'm not sure why you change it |
@@ -1113,10 +1113,12 @@ define([
}
if (typeof this._vaf === 'undefined' || typeof this._vaf.va === 'undefined') {
- return undefined;
+ return [];
}
- if (typeof this._sp === 'undefined') {
+ var pass = frameState.passes;
+
+ if (pass.color && ty... | [No CFG could be retrieved] | The function that is called when a new element is added to the collection. Creates a shader program for the given object. | Throughout: why not move the shader creation code to the `if (pass.color)` and `if (pass.pick)` to make this function flow better? |
@@ -319,6 +319,7 @@ JINGO_EXCLUDE_APPS = (
'admindocs',
'registration',
'grappelli',
+ 'waffle'
)
TEMPLATE_CONTEXT_PROCESSORS = (
| [JINJA_CONFIG->[MemcachedBytecodeCache,isinstance],lazy_langs->[dict,lower],lazy_language_deki_map->[dict],node,lazy,listdir,join,remove,abspath,dict,replace,%,append,dirname,sorted,tuple,items,path,_,basename,isdir,setup_loader,dumps,lower] | The path component of the path component is optional. - - - - - - - - - - - - - - - - - -. | Does there need to be a comma after this? |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.