patch stringlengths 18 160k | callgraph stringlengths 4 179k | summary stringlengths 4 947 | msg stringlengths 6 3.42k |
|---|---|---|---|
@@ -1415,6 +1415,16 @@ namespace Dynamo.Models
var xmlDoc = new XmlDocument();
xmlDoc.Load(filePath);
+ //save the file before it is migrated to JSON.
+ //if in test mode, don't save the file in backup
+ if (!IsTestMode)
+ {... | [DynamoModel->[InitializeNodeLibrary->[InitializeIncludedNodes],ForceRun->[ResetEngine],Paste->[Paste,Copy],RemoveWorkspace->[Dispose],UngroupModel->[DeleteModelInternal],ResetEngine->[ResetEngine],ShutDown->[OnShutdownCompleted,OnShutdownStarted,ShutDown],OpenXmlFileFromPath->[OnWorkspaceOpening],ResetEngineInternal->... | Opens an XML file from a given path. | no backup required when running from tests. |
@@ -78,7 +78,10 @@ class _TFRecordUtil(object):
Masked crc32c checksum.
"""
- crc = crc32c_fn(value)
+ if isinstance(value, bytes):
+ crc = crc32c_fn(value)
+ else:
+ crc = crc32c_fn(value.encode('utf-8'))
return (((crc >> 15) | (crc << 17)) + 0xa282ead8) & 0xffffffff
@staticm... | [ReadFromTFRecord->[__init__->[_TFRecordSource]],_TFRecordSink->[write_encoded_record->[write_record]],_TFRecordUtil->[write_record->[_masked_crc32c],read_record->[_masked_crc32c]],_TFRecordSource->[read_records->[encoded_num_bytes,read_record]],_create_tfrecordio_source->[_TFRecordSource],WriteToTFRecord->[__init__->[... | Compute a masked crc32c checksum for a given value. | I think we _masked_crc32c should only accept bytes values (which is consistent with the idea of checksumming and how all the other hash functions work in Python). In the code below, we can encode value before it's passed to this function (if we decide that writing unicode to tfrecordio is fine). |
@@ -494,6 +494,18 @@ export class AmpStoryPage extends AMP.BaseElement {
if (this.animationManager_) {
this.animationManager_.cancelAll();
}
+
+ this.story360components_.forEach((componentPromise) => {
+ componentPromise.then((component) => {
+ component
+ .signals()
+ ... | [AmpStoryPage->[setState->[NOT_ACTIVE,BOOKEND_STATE,dev,PAUSED,PLAYING],isAutoplaySupported_->[resetIsAutoplaySupported,getMode,isAutoplaySupported],constructor->[resolve,timerFor,getAmpdoc,NOT_ACTIVE,getStoreService,mutatorForDoc,platformFor,promise,getMediaPerformanceMetricsService,debounce,reject],emitProgress_->[di... | Pause all media in the system. | It'd be great if this would behave like a `HTMLMediaElement` (video or audio). We don't need to wait for it to load to call playback methods. Can we somehow register the `play/pause/rewind()` from the `amp-story-360` class, and perform the right playback operation on load? It'd make the code here much easier. |
@@ -609,7 +609,7 @@ def get_concrete_spec(args):
if spec_str:
try:
- spec = Spec(spec_str)
+ spec = find_matching_specs(spec_str)[0]
spec.concretize()
except SpecError as spec_error:
tty.error('Unable to concrectize spec {0}'.format(args.spec))
| [preview->[find_matching_specs],_createtarball->[find_matching_specs],createtarball->[_createtarball],get_buildcache_name->[get_concrete_spec],install_tarball->[install_tarball],installtarball->[match_downloaded_specs],get_tarball->[download_buildcache_files]] | Get a concrete spec from the command line arguments. | If this isn't working with hashes there's a more serious regression issue somewhere in the codebase, I'm worried this is a bandaid on a missing limb. |
@@ -38,14 +38,7 @@ import java.util.regex.Pattern;
*/
public class MapBasedRow implements Row
{
- private static final Logger log = new Logger(MapBasedRow.class);
- private static final Function<Object, String> TO_STRING_INCLUDING_NULL = new Function<Object, String>() {
- @Override
- public String apply(fin... | [MapBasedRow->[hashCode->[hashCode],compareTo->[getTimestamp,compareTo],equals->[equals]]] | Returns the name of the object. | Could be method ref `String::valueOf` |
@@ -81,6 +81,18 @@ type Diagnostics struct {
// ExitLogs is a best effort record of the time of process death and the cause for
// restartable entities
ExitLogs []ExitLog `vic:"0.1" scope:"read-write" key:"exitlogs"`
+
+ // SyslogConfig holds configuration for connecting to a syslog
+ // server
+ SysLogConfig *Sy... | [No CFG could be retrieved] | ExecutorConfigCommon is a config type that can be used to configure an ExecutorConfigCommon object The default values for the vic are read - only. | Is it viable to have a different log level for rsyslog than for the local logs? Is it desirable? I ask because we pump out a lot of logging at debug level and I'm not sure people will want to have their syslog servers flooded. It could be useful if there's a loginsight analytics package for the debug level output. Also... |
@@ -129,9 +129,10 @@ CHAKRA_API JsDiagStopDebugging(
{
Assert(scriptContext->IsScriptContextInDebugMode());
- if (FAILED(scriptContext->OnDebuggerDetached()))
+ HRESULT hr;
+ if (FAILED(hr = scriptContext->OnDebuggerDetached()))
{
- De... | [No CFG could be retrieved] | This function initializes the breakpoint in the debug container. Gets the current script context. | > return JsErrorFatal; [](start = 16, length = 20) We won't reach here ever, can be simplified as Debugger_AttachDetach_fatal_error(scriptContext->OnDebuggerDetached())? |
@@ -75,13 +75,13 @@ namespace NServiceBus
}
}
- public void Start()
+ public async Task Start()
{
foreach (var receiver in receivers)
{
try
{
- receiver.Start();
+ await recei... | [ReceiveComponent->[AddReceivers->[Create,RecoverabilityPolicy,BuildMessagePump,TransactionMode,RuntimeSettings,Name,SatelliteDefinitions,PushRuntimeSettings,ReceiveAddress,RequiredTransportTransactionMode,InstanceSpecificQueue,LocalAddress,PurgeOnStartup,Add,CreateDefault],BindQueues->[SatelliteDefinitions,ReceiveAddr... | Initializes all receivers and starts the receiver. | @timbussmann we could make this use `Task.WhenAll` just like the `Stop` but I guess that would be a behavior change? |
@@ -45,6 +45,11 @@ class ArchiveManagerTest extends ArchiverTest
public function testArchiveTar()
{
+ // Ensure that git is available for testing.
+ if (!$this->isProcessAvailable('git')) {
+ return $this->markTestSkipped('git is not available.');
+ }
+
$this->setupG... | [ArchiveManagerTest->[testUnknownFormat->[setExpectedException,archive,setupPackage],setupGitRepo->[getErrorOutput,execute],testArchiveTar->[setupGitRepo,assertFileExists,assertFileNotExists,archive,getPackageFilename,getTargetName,setupPackage],testArchiveCustomFileName->[setupGitRepo,assertFileExists,assertFileNotExi... | Test archive tar. | no need to return, as it throws |
@@ -876,11 +876,11 @@ function zen_get_configuration_key_value($lookup)
// show room only
$zc_run = false;
break;
- case (CUSTOMERS_APPROVAL_AUTHORIZATION != '0' and $_SESSION['customer_id'] == ''):
+ case (CUSTOMERS_APPROVAL_AUTHORIZATION != '0' && !zen_is_logged_in()):
// cus... | [zen_check_stock->[notify],zen_has_product_attributes_downloads_status->[RecordCount],zen_get_attributes_options_sort_order->[Execute],zen_get_product_is_always_free_shipping->[Execute],zen_get_products_manufacturers_id->[Execute],zen_get_products_virtual->[Execute],zen_get_categories_name->[Execute],zen_get_products_c... | Check if the node should be run in the Zen environment. | Should this `isset && (int) > 0` just be `empty()` ? |
@@ -2043,6 +2043,16 @@ public abstract class AbstractProject<P extends AbstractProject<P,R>,R extends A
public FormValidation doCheckLabel(@AncestorInPath AbstractProject<?,?> project,
@QueryParameter String value) {
+ return validateLabelExpression(valu... | [AbstractProject->[setAssignedLabel->[save],onLoad->[onLoad,createBuildMixIn],getFirstBuild->[getFirstBuild],removeFromList->[save,updateTransientActions],workspaceOffline->[getWorkspace,getAssignedLabel,isAllSuitableNodesOffline],getRelevantLabels->[getAssignedLabel],doWs->[getSomeWorkspace],removeRun->[removeRun],get... | Checks if a label is typed in the given project. | I wish I had noticed this PR when it was filed, because it should really be taking `Job` not `AbstractProject`. |
@@ -590,17 +590,10 @@ var $AnimateCssProvider = ['$animateProvider', function($animateProvider) {
blockTransitions(node, SAFE_FAST_FORWARD_DURATION_VALUE);
}
- var timings = computeTimings(node, fullClassName, cacheKey);
- var relativeDelay = timings.maxDelay;
- maxDelay = Math.max(rela... | [No CFG could be retrieved] | Adds classes to the element and checks if there is a keyframe animation. Adds a keyframe style to the node. | I am not sure if this expressionis correct, but if it is, it can be simplified to: `options.duration > 0 || hasToStyles && (flags.hasTransitions || flags.hasAnimations)` |
@@ -88,7 +88,7 @@ func main() {
syscall.SIGTERM,
syscall.SIGQUIT)
- if err := svr.Run(); err != nil {
+ if err := svr.Run(sc); err != nil {
log.Fatalf("run server failed: %v", errors.ErrorStack(err))
}
| [InitLogger,Warn,Close,PrepareJoinCluster,NewConfig,CreateServer,Exit,LogPanic,Cause,Notify,PrintPDInfo,ErrorStack,InitHTTPClient,Infof,LogPDInfo,Fatalf,Parse,Fatal,EnableHandlingTimeHistogram,Run,Push] | create server and run server. | why not pass a Context? So we can cancel the running. |
@@ -0,0 +1,9 @@
+class AddExpiredToUspsConfirmationCodes < ActiveRecord::Migration[5.1]
+ disable_ddl_transaction!
+
+ def change
+ add_column :usps_confirmation_codes, :letter_expired_sent_at, :timestamp
+ add_index :usps_confirmation_codes, %i[bounced_at letter_expired_sent_at created_at],
+ algo... | [No CFG could be retrieved] | No Summary Found. | Let's do an experiment where we run migrations before we deploy with this one. |
@@ -806,10 +806,7 @@ class Resource:
else:
# If a provider was specified, add it to the providers map under this type's package
# so that any children of this resource inherit its provider.
- type_components = t.split(":")
- if len(type_compon... | [ResourceOptions->[merge->[ResourceOptions,_depends_on_list]],CustomResource->[__init__->[__init__]],ProviderResource->[__init__->[__init__]],Resource->[__init__->[ResourceTransformationArgs,ResourceOptions,all_aliases]],all_aliases->[inherited_alias_for_child_urn->[inherited_child_alias,urn_type_and_name],inherited_ch... | Initialize a new object with a specific . Returns a new ckey object that can be used to create a new resource. This method is called when a resource is requested. It is called by the parent to inherit. | Aha so provider gets indexed by provider.package (the one it's for), not the <type> package. |
@@ -94,6 +94,11 @@ class AttributeValue(CountableDjangoObjectType):
.then(prepare_reference)
)
+ @staticmethod
+ @traced_resolver
+ def resolve_date(root: models.AttributeValue, info, **_kwargs):
+ return root.date_time
+
class Attribute(CountableDjangoObjectType):
input_... | [SelectedAttribute->[List,Field],AttributeValueInput->[JSONString,ID,Boolean,List,String,NonNull],AttributeInput->[Boolean,List,String,Field],AttributeValue->[resolve_file->[File],resolve_reference->[prepare_reference->[split,to_global_id],AttributesByAttributeId],resolve_input_type->[_resolve_input_type->[has_perm,Per... | Resolve a reference attribute. | IMO, no need to add `traced_resolver` here, looks like simple resolver. @fowczarek Can you confirm? |
@@ -630,7 +630,8 @@ class MNEBrowseFigure(MNEFigure):
else:
last_time = self.mne.inst.times[-1]
# scroll up/down
- if key in ('down', 'up'):
+ if key in ('down', 'up', 'shift+down', 'shift+up'):
+ key = key.split('+')[-1]
direction = -1 if key == 'up'... | [_browse_figure->[_figure,_resize,_update_zen_mode_offsets,_toggle_scrollbars],MNEBrowseFigure->[_update_zen_mode_offsets->[_get_size_px],_toggle_annotation_fig->[_create_annotation_fig],_resize->[_get_size_px],_draw_annotations->[_clear_annotations],_draw_traces->[_hide_scalebars,_show_scalebars],_add_annotation_label... | Handle key press events. Updates the data if the key is a . Updates the nanoseconds in the window based on the key. check for key presses on the key sequence number. | Also to make it so that you can navigate full pages in up/down or left/right while holding shift (without needing to release it) I added an alias here for shift+down to move down |
@@ -470,13 +470,12 @@ func (consensus *Consensus) getLeaderPubKeyFromCoinbase(header *block.Header) (*
func (consensus *Consensus) UpdateConsensusInformation() Mode {
pubKeys := []*bls.PublicKey{}
hasError := false
-
header := consensus.ChainReader.CurrentHeader()
-
epoch := header.Epoch()
- curPubKeys := core... | [verifyViewChangeSenderKey->[IsValidatorInCommittee],SetMode->[SetMode],verifySenderKey->[IsValidatorInCommittee],checkViewID->[SetViewID,SetMode],Mode->[Mode],getLogger->[Mode,String],UpdateConsensusInformation->[getLogger,UpdatePublicKeys,SetEpochNum,getLeaderPubKeyFromCoinbase],signConsensusMessage->[signMessage]] | UpdateConsensusInformation updates consensus information for the current header. This function is used to check if there is a key in the chain that is not the. | Why change the logic to not read for next epoch? |
@@ -428,7 +428,7 @@ namespace Microsoft.Extensions.Primitives
{
int offset = Offset + start;
- if (!HasValue || start < 0 || (uint)offset > (uint)Buffer.Length)
+ if (start < 0 || (uint)offset > (uint)Buffer.Length)
{
ThrowHelper.ThrowArgumentO... | [StringSegment->[IndexOf->[IndexOf],StartsWith->[StartsWith,AsSpan],LastIndexOf->[LastIndexOf],GetHashCode->[GetHashCode,AsSpan],EndsWith->[AsSpan,EndsWith],Compare->[AsSpan],IndexOfAny->[IndexOfAny],AsMemory->[AsMemory],Equals->[Equals,AsSpan],AsSpan->[AsSpan],Substring->[Substring],AsMemory,Equals,AsSpan]] | This method returns the index of the first occurrence of c in this array. | >Buffer [](start = 50, length = 6) It is possible the Buffer can be null when HasValue is false. You need to do the `(uint)offset > (uint)Buffer.Length` check only when HasValue is true. |
@@ -32,6 +32,8 @@ public class HttpListenerConfigFunctionalTestCase extends FunctionalTestCase
"([01]?\\d\\d?|2[0-4]\\d|25[0-5])\\." +
"([01]?\\d\\d?|2[0-4]\\d|25[0-5])\\." +
"([01]?\\d\\d?|2[0-4]\\d|25[0-5])$");
+ private static final int TIMEOUT = 1000;
+ public static fin... | [HttpListenerConfigFunctionalTestCase->[fullConfig->[getValue,getNumber,format,getStatusCode,is,assertThat,execute],listenerConfigOverridesListenerConfig->[getValue,getNumber,format,getStatusCode,is,assertThat,execute],noListenerConfig->[getNumber,format,getStatusCode,is,assertThat,execute],getNonLocalhostIp->[getInetA... | region > httpListenerConfigFunctionalTestCase This method is used to test the empty configuration. | why public in a test case... in either case I would expect the one at NoListenerRequestHandler to be public or protected and this one to don't exist |
@@ -185,8 +185,8 @@ public class EditDelegate extends BaseEditDelegate implements IEditDelegate {
@Override
public String changeTechTokens(final PlayerID player, final int newTotal) {
- String result = null;
- if (null != (result = checkEditMode())) {
+ String result = checkEditMode();
+ if (result ... | [EditDelegate->[start->[start],getProduction->[getProduction],addUnits->[addUnits],removeUnits->[removeUnits]]] | Changes the tech tokens for a player. | Another `final` candidate. |
@@ -33,7 +33,7 @@ module Idv
def reset_doc_auth
user_session.delete('idv/doc_auth')
- user_session['idv'] = { params: {}, step_attempts: { phone: 0 } }
+ user_session['idv'] = {}
end
def cancel_document_capture_session
| [CancellationsController->[new->[call,merge,hybrid_session?,track_event],document_capture_session->[find_by],location_params->[symbolize_keys],reset_doc_auth->[delete],destroy->[track_event,return_to_sp_failure_to_proof_path,clear,hybrid_session?],cancel_document_capture_session->[now,update],before_action,include]] | reset the user session and cancel any pending document capture session. | I think we may want to leave this default setting thing in to keep things smooth during a deploy, with old servers expecting data in the session hash, and new servers ignoring it then follow up with another PR to drop it next deploy |
@@ -40,6 +40,10 @@ abstract class Base {
public function get_many( $args ) {
$items = array();
+ if ( is_string( $args ) ) {
+ $args = (array) $args;
+ }
+
foreach ( $args as $arg ) {
$item = $this->get( $arg );
| [Base->[get_many->[get],get_check->[get]]] | Get many items from the database. | Hmm, this shouldn't be necessary |
@@ -97,6 +97,15 @@ func BecomeRootInUserNS() (bool, int, error) {
var uids, gids []idtools.IDMap
username := os.Getenv("USER")
+ if username == "" {
+ user, err := user.LookupId(fmt.Sprintf("%d", os.Geteuid()))
+ if err != nil && os.Getenv("PODMAN_ALLOW_SINGLE_ID_MAPPING_IN_USERNS") == "" {
+ return false, 0,... | [reexec_in_user_namespace,Fd,Close,Setenv,Getgid,WriteFile,Atoi,int,LockOSThread,NewIDMappings,Notify,GIDs,Errorf,LookPath,reexec_in_user_namespace_wait,Wrapf,UnlockOSThread,Kill,Write,Getuid,Reset,UIDs,Sprintf,Getenv,Run,Pipe] | BecomeRootInUserNS runs a podman process in a new user namespace and writes the setgroups file if it doesn t exist. | Does this work with usernames not in /etc/passwd? |
@@ -1,6 +1,5 @@
"""
Copyright (c) 2019 Intel Corporation
-
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
| [ActionDetection->[generate_prior_box->[float],parameters->[update,BoolField,NumberField,super,StringField,ListField],process->[append,ActionDetectionPrediction,estimate_head_shifts,len,_extract_predictions,DetectionPrediction,enumerate,raw_outputs,prepare_detection_for_id,ContainerPrediction],decode_box->[exp],estimat... | Creates a class that represents the parameters of an action - detection . Required. | This seems wrong. The other files do have this blank line. |
@@ -2129,6 +2129,7 @@ class TestVersionViewSetList(AddonAndVersionViewSetDetailMixin, TestCase):
self.url, data={'filter': 'all_with_unlisted'})
assert response.status_code == 403
+ @override_switch('beta-versions', active=True)
def test_beta_version(self):
self.old_version.file... | [TestAddonSearchView->[test_exclude_addons->[perform_search],test_empty->[perform_search],test_with_session_cookie->[perform_search],test_find_addon_default_non_en_us->[perform_search],test_with_query->[perform_search],test_bad_filter->[perform_search],test_filter_by_guid->[perform_search],test_es_queries_made_no_resul... | Test if all items in the collection are not authorised. | I don't think anyone uses that API parameter, but it should probably return a 400 if the switch is off (and if this is done, the API docs should be updated as well) |
@@ -676,6 +676,9 @@ parse(int argc, char **argv)
save_attach_info = true;
attach_info_path = optarg;
break;
+ case 'p':
+ printf("Got numa node option but ignoreing it for this test\n");
+ break;
default:
usage(argv[0], stderr);
rc = -DER_INVAL;
| [int->[D_GOTO,ABT_init,ABT_cond_create,setenv,max,server_init_state_wait,dss_module_fini,strdup,dss_module_load,ds_iv_fini,daos_fini,getenv,D_ASSERT,ABT_mutex_free,atoi,crt_finalize,getopt_long,crt_init_opt,printf,daos_debug_init,daos_init,d_hhash_set_ptrtype,daos_crt_init_opt_get,daos_errno2der,strlen,abt_init,abt_max... | Parses command line options and returns the number of modules loaded. option - c nvme_conf nvme_shm_id nvme_attach. | (style) line over 80 characters |
@@ -5238,10 +5238,17 @@ parse_fs_perm(fs_perm_t *fsperm, nvlist_t *nvl)
break;
}
- if (nice_name != NULL)
+ if (nice_name != NULL) {
(void) strlcpy(
node->who_perm.who_ug_name,
nice_name, 256);
+ } else {
+ /* User or group unknown */
+ (void) snprintf(
+ ... | [No CFG could be retrieved] | parse who_perm and nvp parse fs_perm_t from nvlist. | I know some similar tools (e.g. `ls -l`) will print only the ID if it can't be translated to a name. e.g. `"%d"` Instead of `"(unknown: %d)"`. One advantage is that it is more parseable since the format is more consistent. Not sure how much of a consideration that is here, but wanted to get your thoughts. |
@@ -1016,10 +1016,18 @@ public class QueryManagerImpl extends MutualExclusiveIdsManagerBase implements Q
sc.setParameters("serviceOfferingId", serviceOffId);
}
+ if(securityGroupId != null) {
+ sc.setParameters("securityGroupId", securityGroupId);
+ }
+
if (disp... | [QueryManagerImpl->[searchForIsosInternal->[searchForTemplatesInternal],buildAffinityGroupSearchCriteria->[buildAffinityGroupViewSearchCriteria,buildAffinityGroupViewSearchBuilder],searchForTemplatesInternal->[searchForTemplatesInternal],searchForServiceOfferingsInternal->[filterOfferingsOnCurrentTags]]] | Internal method to perform a search for user vMs. check if the user is an admin of the current entity populate the search criteria based on the values passed in Method to find all tags in the system. get all unique VM join details get all VMs that are unique. | @GabrielBrascher I guess this is supposed to be isHaEnabled != null ? |
@@ -58,8 +58,6 @@ class ROOTKernel(MetaKernel):
self.Declarer = GetDeclarer()#required for %%cpp -d magic
self.ACLiC = invokeAclic
self.magicloader = MagicLoader(self)
- self.parser = Parser(self.identifier_regex, self.func_call_regex,
- self.magic_pref... | [ROOTKernel->[do_execute_direct->[print_output],__init__->[__init__]],main] | Initialize the object. | Sorry to be picky but, could we also remove the corresponding import of the Parser class? Thanks @dpiparo |
@@ -420,7 +420,10 @@ public class FlowResource extends ApplicationResource {
value = "The producer for flow file metrics. Each producer may have its own output format.",
required = true
)
- @PathParam("producer") final String producer) throws Interrupted... | [FlowResource->[getControllerServiceTypes->[getControllerServiceTypes,authorizeFlow],getFlow->[populateRemainingFlowContent,authorizeFlow],getRegistries->[authorizeFlow],getAction->[getAction,authorizeFlow],getVersions->[authorizeFlow],searchCluster->[authorizeFlow],getControllerServicesFromGroup->[authorizeFlow],getFl... | Get all metrics for a specific producer for a particular node. | These new parameters are helpful, but they appear to be applied only to the JSON format. Instead, they should apply to all output formats, which might require a bit more refactoring to reduce potential duplication. |
@@ -46,7 +46,7 @@ picks = mne.fiff.pick_types(raw.info, meg=True, eeg=False, eog=False,
# between 0 and 1 to select n_components by a percentage of
# explained variance.
-ica = ICA(n_components=0.90, max_n_components=100, noise_cov=None,
+ica = ICA(n_components=0.90, n_pca_components=100, noise_cov=None,
... | [pick_sources_raw,get_sources_raw,where,array,figure,show,extend,ylim,make_grid_layout,sources_as_raw,abs,ylabel,plot,pearsonr,data_path,decompose_raw,time_as_index,title,xlabel,index,Raw,arange,xlim,plot_sources_raw,ICA,pick_types,find_sources_raw,ravel] | Setup the components and plot the raw data. This function is a helper function that iteratively applies the pearson correlation function to sources. | why not 64 here? |
@@ -504,13 +504,13 @@ class Assignment < ActiveRecord::Base
end
# Get a list of subversion client commands to be used for scripting
- def get_svn_export_commands
+ def get_svn_checkout_commands
svn_commands = [] # the commands to be exported
self.groupings.each do |grouping|
submission = gr... | [Assignment->[get_detailed_csv_report_rubric->[total_mark],group_by->[group_assignment?],grade_distribution_as_percentage->[total_mark],get_simple_csv_report->[total_mark],get_detailed_csv_report_flexible->[total_mark],reset_collection_time->[reset_collection_time],median->[average],grouping_past_due_date?->[past_all_d... | Returns an array of svn export commands for all the nodes in the group that have a. | Line is too long. [182/80]<br>Redundant `self` detected. |
@@ -33,7 +33,7 @@ def snapshot():
ps = subprocess.Popen("ps | grep camerad", shell=True, stdout=subprocess.PIPE)
ret = list(filter(lambda x: 'grep ' not in x, ps.communicate()[0].decode('utf-8').strip().split("\n")))
if len(ret) > 0:
- params.put("IsTakingSnapshot", "0")
+ put_nonblocking("IsTakingSnapsh... | [snapshot->[time,list,int,communicate,sleep,send_signal,Params,get,len,filter,Popen,join,dumps,VisionIPC,put,delete],jpeg_write->[fromarray,save],snapshot,print,jpeg_write,open,load] | Get a sequence of images and images from the system. | I don't think we need the asynchronous version here since it's not in a timing critical loop. |
@@ -65,6 +65,14 @@ module T::Props
raw = type.raw_type
if NO_TRANSFORM_TYPES.any? {|cls| raw <= cls}
nil
+ elsif raw <= Float
+ case mode
+ when Deserialize then "#{varname}.to_f"
+ when Serialize then nil
+ else T.absurd(mode)
+ ... | [generate->[size,unsafe,lift_enum,any?,first,name,unwrap_nilable,nil?,values,all?,type,generate,include?,uniq,raw_type,handle_custom_type,keys,singleton_class,handle_serializable_subtype],handle_custom_type->[module_name,absurd,must],module_name->[call],handle_serializable_subtype->[module_name,absurd,must],freeze,any,... | generates a unique identifier for a given type. generates a unique name for a if possible. if we have a deadlock we can do this. | I wasn't super clear on the distinction between `serialize` and `deserialize` here. In my mind, I was pretty sure that I only wanted to call `.to_f` when deserializing, but nearly all the code in this file was agnostic of mode, which I found kind of surprising. I'm happy to call `.to_f` in both places, but it would mea... |
@@ -151,7 +151,13 @@ public class HoodieBloomIndex<T extends HoodieRecordPayload> extends HoodieIndex
for (String partitionPath : recordsPerPartition.keySet()) {
long numRecords = recordsPerPartition.get(partitionPath);
long numFiles = filesPerPartition.containsKey(partitionPath) ? fi... | [HoodieBloomIndex->[findMatchingFilesForRecordKeys->[explodePartitionFilePairRDD,determineParallelism,splitPartitionRecordKeysPairRDD]]] | Compute the sub - partitions. | So the theory is to overpartition and see if its faster? I thought about this back then. There is the additional cost of re-reading bloom filters yet again due to records being split across partitions.. .. I guess we could bet on HDFS parallel reads of same data to be faster.. Anyhow, good to have this configurable.. L... |
@@ -201,7 +201,7 @@ class TestCleanConfigDict(unittest.TestCase):
"""
Ensure that usernames and passwords can contain the '@' symbol.
"""
- mock_config = {'feed': 'http://mock@user:mock@pass@realfeed.com'}
+ mock_config = {'feed': 'http://mock%40user:mock%40pass@realfeed.com'}
... | [TestGetValidImporter->[test_invalid_importer->[assertDictEqual,assertNotEqual,AssertionError,get_valid_importer],test_nonexisent_importer->[assertDictEqual,AssertionError,MissingResource,get_valid_importer],test_as_expected->[assertTrue,get_valid_importer]],TestQueueSetImporter->[test_queued->[assertTrue,Repository,qu... | Test feed with basic auth username and password at symbol. | Hah, it's funny that we even had a unit test that was *so close* to testing the right thing, but just didn't quite make it. Someone was thinking in the right direction though! |
@@ -83,7 +83,7 @@ func (r *ReplicaChecker) Check(region *core.RegionInfo) *Operator {
// SelectBestReplacedPeerToAddReplica returns a new peer that to be used to replace the old peer and distinct score.
func (r *ReplicaChecker) SelectBestReplacedPeerToAddReplica(region *core.RegionInfo, oldPeer *metapb.Peer, filter... | [checkBestReplacement->[selectWorstPeer,selectBestReplacementStore],checkOfflinePeer->[SelectBestReplacedPeerToAddReplica]] | SelectBestReplacedPeerToAddReplica selects a peer that is best replaced with a new replica. | I think we can remove the function `SelectBestReplacedPeerToAddReplica` to prevent we misuse it later. |
@@ -30,7 +30,6 @@ import com.cloud.capacity.CapacityManager;
import com.google.common.base.Preconditions;
public class ImageStoreDetailsUtil {
-
@Inject
protected ImageStoreDao imageStoreDao;
@Inject
| [ImageStoreDetailsUtil->[getNfsVersion->[getGlobalDefaultNfsVersion],getNfsVersionByUuid->[getNfsVersion,getGlobalDefaultNfsVersion]]] | Creates a new object that represents a single global network protocol version which can be used to retrieve Gets the NFS version for the given store ID. | I really like this style but in spite of it looking neater, the removal of the line is a potential conflict before we get a chance to merge. Better have those kind of changes is isolated contributions. |
@@ -3,6 +3,7 @@
import re
import subprocess
import hashlib
+from io import BytesIO
from xml.sax.saxutils import escape
from typing import TypeVar, List, Tuple, Optional, Sequence, Dict
| [read_with_python_encoding->[DecodeError,find_python_encoding]] | Utility functions with no non trivial dependencies. Returns the encoding and line of the file with the given version. | I'd prefer the style `import io` here (in general for stdlib modules, though I'm fine with `escape` below). |
@@ -137,11 +137,12 @@ namespace ProtoCore.Utils
private static Core CodeBlockParserCore()
{
- var core = new Core(new Options());
- core.Options.ExecutionMode = ExecutionMode.Serial;
- core.ParsingMode = ParseMode.AllowNonAssignment;
- core.IsParsingCodeBl... | [ParserUtils->[TryMigrateDeprecatedListSyntax->[FindExprListNodes,ParseWithDeprecatedListSyntax],FindExprListNodes->[Collect],ParseResult->[CreateParser,Parse],GetLHSatAssignment->[FindIdentifiers]]] | This method is used to parse a string of code into a CodeBlockNode. | is ExecutionMode.Serial the default? |
@@ -486,11 +486,12 @@ defineSuite([
var fs =
'#version 100 \n' +
'void main() { gl_FragColor = vec4(1.0); }';
- sp = ShaderProgram.fromCache({
+ var sp = ShaderProgram.fromCache({
context : context,
vertexShaderSource : vs,
fragment... | [No CFG could be retrieved] | ShaderProgram is a program that uses a shader that uses a uniform color. requires that the vertex and fragment shader have been compiled before. | For this and below why destroy the shader program here? |
@@ -16,7 +16,7 @@
<meta property="og:description" content="<%= SiteConfig.community_description %>" />
<meta property="og:site_name" content="<%= community_qualified_name %>" />
- <meta name="twitter:site" content="@<%= SiteConfig.social_networks_handle %>">
+ <meta name="twitter:site" content="@<%= SiteConfi... | [No CFG could be retrieved] | Renders a page with meta tags that can be used to view the community s n - ary The main page of the Heroku app. | Since we make no assumptions about Twitter above, we just loop over social media types, is it assumed that Twitter will always be present? If not, consider checking before rendering Twitter related meta tags. Same question for all Twitter related stuff below. |
@@ -139,6 +139,9 @@ class Stage(object):
"""Shared dict of all stage locks."""
stage_locks = {}
+ """Staging is, in general, managed by Spack."""
+ managed_by_spack = True
+
def __init__(
self, url_or_fetch_strategy,
name=None, mirror_path=None, keep=False, path=None, lo... | [Stage->[check->[check],fetch->[generate_fetchers,fetch],_need_to_create_path->[get_tmp_root],create->[_need_to_create_path,get_tmp_root]],get_tmp_root->[_first_accessible_path],StageComposite->[__exit__->[__exit__],__enter__->[__enter__]]] | Initialize a stage object. This method is called when a branch is created or destroyed. It is called by the constructor. | I'd reword to "for most stage types (except, e.g., DIYStage), staging is managed by spack" |
@@ -248,14 +248,10 @@ class OrderEditVoucherForm(forms.ModelForm):
class OrderNoteForm(forms.ModelForm):
class Meta:
model = OrderNote
- fields = ['content', 'is_public']
+ fields = ['content']
widgets = {
'content': forms.Textarea()}
- labels = {
- '... | [CancelFulfillmentForm->[cancel_fulfillment->[cancel_fulfillment]],CapturePaymentForm->[capture->[try_payment_action]],ReleasePaymentForm->[release->[payment_error,release]],RefundPaymentForm->[refund->[try_payment_action]],CancelOrderForm->[cancel_order->[cancel_order]],ManagePaymentForm->[try_payment_action->[payment... | Send confirmation email if user is not already logged in. | I think that was used for notifying a customer about a new note on his order, could be removed as well |
@@ -198,6 +198,12 @@ class FBetaMeasure(Metric):
precision = precision.mean()
recall = recall.mean()
fscore = fscore.mean()
+ elif self._average == "weighted":
+ weights = true_sum
+ weights_sum = true_sum.sum()
+ precision = (weights * prec... | [_prf_divide->[any],FBetaMeasure->[get_metric->[reset,tolist,mean,sum,RuntimeError,_prf_divide,item],__call__->[,ones_like,unwrap_to_tensors,to,size,max,sum,gold_labels,argmax_predictions,float,zeros,bincount,ConfigurationError],__init__->[ConfigurationError,len]],register] | Returns a tuple of the critical count metrics. | It's possible for this value to be zero, if the metric is called with a completely zero mask - you can use the `_prf_divide` function to guard against this |
@@ -114,8 +114,9 @@ def fetch_all():
def fetch_all_recordio(path):
- for module_name in filter(lambda x: not x.startswith("__"),
- dir(paddle.dataset)):
+ for module_name in [
+ x for x in dir(paddle.dataset) if not x.startswith("__")
+ ]:
if "convert" in d... | [fetch_all_recordio->[must_mkdirs],download->[md5file],convert->[write_data,reader],must_mkdirs] | Fetch all recordio modules from path. | (x for x in ...) |
@@ -76,7 +76,13 @@ namespace Dynamo.Core
IEnumerable<KeyValuePair<Guid, List<string>>> traceData =
workspaceModel.PreloadedTraceData;
workspaceModel.PreloadedTraceData = null; // Reset.
- dynamoModel.EngineController.LiveRunnerCore.SetTraceDataForNod... | [DynamoRunner->[Evaluate->[GenerateGraphSyncData,Eval,Elapsed,OnRunCancelled,Message,LogAnonymousTimedEvent,Stop,Format,Empty,Start,StackTrace,HasPendingGraphSyncData,OnEvaluationCompleted,Log,DynamoModel,IsTestMode,LogAnonymousEvent,Nodes,Length],Eval->[DisplayEngineFailureMessage,DynamoModel,IsUpdated,IsTestMode,OnRu... | Runs the given expression in the given workspace. | Hi @ikeough, a little concern here... although this isn't super critical (since we're shutting down), I'm just wondering if `RunExpression` can be called from another place when `EngineController` being `null`? The reason I mentioned this is, `workspaceModel.PreloadedTraceData` is being reset after it is retrieved from... |
@@ -493,4 +493,14 @@ public class HiveS3Config
this.s3StreamingPartSize = s3StreamingPartSize;
return this;
}
+
+ public String getS3SessionIdentifier() { return s3SessionIdentifier; }
+
+ @Config("hive.s3.session-identifier")
+ @ConfigDescription("The session user prefix to use for S3 c... | [HiveS3Config->[File,value,of,Duration]] | Sets the part size for S3 streaming upload. | Format like ```java public String getS3SessionIdentifier() { return s3SessionIdentifier; } |
@@ -170,7 +170,7 @@ namespace System.Reflection.Metadata
Throw.ArgumentNull(nameof(source));
}
- source.WriteContentTo(ref this);
+ source!.WriteContentTo(ref this);
}
/// <exception cref="ArgumentNullException"><paramref name="source"/> is null.... | [BlobWriter->[WriteDouble->[WriteDouble,Advance],WriteGuid->[Advance,WriteGuid],ToImmutableArray->[ToImmutableArray,ToArray],Align->[WriteBytes,Align],WriteUInt16BE->[Advance,WriteUInt16BE],WriteUInt64->[WriteUInt64,Advance],WriteByte->[Advance],WriteCompressedSignedInteger->[WriteCompressedSignedInteger],WriteBytesUnc... | This method writes the specified number of bytes from the specified stream into this buffer. | After adding `[DoesNotReturn]` attribute on `Throw.ArgumentNull(string);` `!` not needed |
@@ -170,7 +170,7 @@ public class LogRecorder extends AbstractModelObject implements Saveable {
@Restricted(NoExternalUse.class)
transient /*almost final*/ RingBufferLogHandler handler = new RingBufferLogHandler() {
@Override
- public void publish(LogRecord record) {
+ public synchronize... | [LogRecorder->[doConfigSubmit->[enable],load->[enable],SetLevel->[call->[getLogger],broadcast->[call]],doDoDelete->[enable,disable],doAutoCompleteLoggerName->[getAutoCompletionCandidates],doRss->[doRss],Target->[getLogger->[getLogger],enable->[getLogger,getLevel]],ComputerLogInitializer->[preOnline->[SetLevel,call,getL... | Publishes the record to all targets that match the record. | Revert and suppress the warning. This could introduce a performance regression or perhaps even deadlock. The `super` call below should acquire the lock if and when needed. |
@@ -36,13 +36,14 @@ public class PipelineOptionsTest {
@Description("Bla bla bla")
@Default.String("Hello")
String getTestOption();
+
void setTestOption(String value);
}
private static MyOptions options;
private static SerializedPipelineOptions serializedOptions;
- private final static... | [PipelineOptionsTest->[testDeserialization->[getTestOption]]] | This method is called before the pipeline is started. | Why remove this `final` modifier here? |
@@ -142,6 +142,9 @@ public class <%= entityClass %> implements Serializable {
<%_ } else if (relationshipType == 'many-to-one') { _%>
@ManyToOne
+ <%_ if (relationshipValidate == true && relationshipType == 'many-to-one' && relationshipValidateRules.indexOf('required') != -1) { _%>
+ <%- include relat... | [No CFG could be retrieved] | Private functions - functions - functions - functions Private helper method for creating a unique set of other entities in a relationship. | I think you dont have to check the relationship types again as you will set `relationshipValidate` only when thse conditions are met so you can simplify to `<%_ if (relationshipValidate && relationshipValidateRules.indexOf('required') != -1) { %>` also it might be better to set another variable `this.relationshipRequir... |
@@ -1,6 +1,9 @@
from collections import OrderedDict
-from bokeh._legacy_charts import Area, show, output_file
+from bokeh.charts import Area, show, vplot, output_file, defaults
+
+defaults.width = 400
+defaults.height = 400
# create some example data
xyvalues = OrderedDict(
| [output_file,OrderedDict,show,Area] | Create a simple responsive area chart for the n - tuple of unique objects. | I really don't like `xyvalues` either. It looks unusual, it has too many syllables. I'd _really_ like to call these something else, everywhere. Even just generic `data` would be better. |
@@ -6,10 +6,11 @@ require 'rails_helper'
# So I can regain access to protected areas of the site
feature 'Password Recovery' do
def reset_password_and_sign_back_in(user)
- fill_in 'New password', with: 'NewVal!dPassw0rd'
+ password = 'a really long password'
+ fill_in 'New password', with: password
... | [reset_password_and_sign_back_in->[fill_in,email,t,click_button],visit,email,minute,create,feature,reset_password_sent_at,it,support_url,travel,to,have_content,return,before,click_button,reset_password_within,click_link,scenario,t,require,click_email_link_matching,include,generate,update,now,each,fill_in,context,reset_... | Fills in the password and email fields and signs back in if any. | shouldn't 'password' be on our not allowed list? either way, let's remember to follow up with NIST about their dictionary check |
@@ -62,7 +62,7 @@ namespace System.Windows.Forms.Tests.AccessibleObjects
}
AccPropertyGridViewHeight = propertyGridView.AccessibilityObject.Bounds.Height;
- Application.Exit();
+ BeginInvoke(new Action(Application.ExitThread));
}
public TestForm()
| [TestForm->[InitializeComponent->[Size,Add],TestForm_Load->[Height,GetPropEntries,GridItems,SelectedObject,ActiveControl,Exit],InitializeComponent],PropertyGridViewRowsAccessibleObjectTests->[PropertyGridViewRowsAccessibleObject_Ctor_Default->[AccPropertyGridViewHeight,Run,AccRowHeightSum,entriesBorders,True]]] | TestForm_Load event handler. | The usual developer pattern I see is just calling `Close()` and letting the application exit due to the main form being closed. Wasn't sure if the `Application.Exit` had any particular reason, so I'm using the one closer to the original intention. The `BeginInvoke` may be unnecessary, not entirely sure, can try to remo... |
@@ -2635,6 +2635,9 @@ public class Parser implements ConfigurationParser {
case TRANSACTIONAL:
transactional = Boolean.parseBoolean(value);
break;
+ case SEGMENTED:
+ segmented = Boolean.parseBoolean(value);
+ break;
defaul... | [Parser->[parseOffHeapMemoryAttributes->[ignoreAttribute],parseStoreAttribute->[ignoreAttribute],parseJmx->[ignoreAttribute],parseDataContainer->[ignoreAttribute,ignoreElement],parseStackFile->[addJGroupsStackFile],parseStoreWriteBehind->[ignoreAttribute],parseDistributedCache->[parseSharedStateCacheElement,parseSegmen... | Parses a custom store. This method is called to parse store elements. | Could we change `parseStoreAttribute` to parse the base store attributes and let the specific store methods parse the store-specific attributes? There's a bit of duplication, and I'm not sure why so many attributes are parsed but ignored unless the "custom" store is a `SingleFileStore`. |
@@ -19,6 +19,7 @@
import { Injectable } from '@angular/core';
import { Resolve, ActivatedRouteSnapshot, RouterStateSnapshot, Routes } from '@angular/router';
import { JhiResolvePagingParams } from 'ng-jhipster';
+import { map } from 'rxjs/operators';
import { UserRouteAccessService } from 'app/core/auth/user-rout... | [No CFG could be retrieved] | Creates an object that represents a single user in the system. User management section. | This import is unused. |
@@ -34,9 +34,9 @@ var (
// TestnetChainConfig contains the chain parameters to run a node on the harmony test network.
TestnetChainConfig = &ChainConfig{
ChainID: TestnetChainID,
- CrossTxEpoch: big.NewInt(1),
- CrossLinkEpoch: big.NewInt(2),
- StakingEpoch: big.NewInt(3),
+ CrossTxEpoch: big.Ne... | [Rules->[IsEIP155,IsCrossLink,IsS3],GasTable->[IsS3]] | Private functions for the chain IDs. Protected configuration for all chain - specific fields. | why this is TBD? don't we need it to enable the crossshard? |
@@ -72,4 +72,14 @@ class JSchProcessor {
"com.jcraft.jsch.UserAuthPassword",
"com.jcraft.jsch.UserAuthPublicKey");
}
+
+ @BuildStep
+ FeatureBuildItem feature() {
+ return new FeatureBuildItem(FeatureBuildItem.JSCH);
+ }
+
+ @BuildStep
+ ExtensionSslNativeSup... | [JSchProcessor->[runtimeInitialized->[RuntimeInitializedClassBuildItem,getName],reflection->[ReflectiveClassBuildItem],enableAllSecurityServices->[EnableAllSecurityServicesBuildItem]]] | This method is called to build a reflection class for the JSCH. region Private API Methods. | This extension was purposely designed to not produce a FeatureBuildItem since we didn't want to appear in the initialization logs |
@@ -151,6 +151,10 @@ class TestGroupNormOpBigEps3(TestGroupNormOp):
self.attrs['epsilon'] = 0.5
+@skip_check_grad_ci(
+ reason='''This test case is to compare whether the grads computation results between CPU and GPU
+ are consistent when using the same inputs, check_grad is not required.''... | [TestGroupNormOp->[test_check_grad->[do_compare_between_place],setUp->[group_norm_naive]],TestGroupNormAPI_With_NHWC->[test_case1->[group_norm_naive]]] | Initialize the test case. | This test case is used to ensure whether the gradient checking results between CPU and GPU are consistent when using the same inputs, thus, it doesn't need to call check_grad. |
@@ -47,10 +47,14 @@ type HTTP struct {
func NewHTTP(base mb.BaseMetricSet) (*HTTP, error) {
config := struct {
TLS *tlscommon.Config `config:"ssl"`
+ ConnectTimeout time.Duration `config:"connect_timeout"`
Timeout time.Duration `config:"timeout"`
Headers map[string]stri... | [FetchContent->[FetchResponse],FetchScanner->[FetchContent],FetchJSON->[FetchContent]] | NewHTTP creates a new HTTP object from a base metric set. returns an instance of HTTP that can be used to access the resource. | What if someone sets ConnectionTimeout > Timeout or Timeout > Period? Should we allow that or is it an invalid config? |
@@ -1,6 +1,10 @@
# @note When we destroy the related user, it's using dependent:
# :delete for the relationship. That means no before/after
# destroy callbacks will be called on this object.
+#
+# @note When we destroy the related article, it's using dependent:
+# :delete for the relationship. ... | [Mention->[create_all->[name,perform_async,id],permission->[add,valid?],send_email_notification->[present?,perform_async,find,email_mention_notifications],after_create_commit,validate,belongs_to,validates]] | Creates and sends a Mention object asynchronously. | thanks for these notes - the reason to prefer "destroy" over "delete" during development is to guard against someone adding a callback in one of the associated models - these notes provides the best effort guard to help them know not to do that (or to revisit the article deletion plan if they must). |
@@ -169,7 +169,10 @@ import org.slf4j.LoggerFactory;
*
* The {@link SpannerWriteResult SpannerWriteResult} object contains the results of the transform,
* including a {@link PCollection} of MutationGroups that failed to write, and a {@link PCollection}
- * that can be used as a completion signal.
+ * that can be ... | [SpannerIO->[CreateTransaction->[withProjectId->[withProjectId,getSpannerConfig,withSpannerConfig],withSpannerConfig->[build],withDatabaseId->[withSpannerConfig,getSpannerConfig,withDatabaseId],withTimestampBound->[build],withServiceFactory->[withServiceFactory,getSpannerConfig,withSpannerConfig],withInstanceId->[withI... | This method is used to improve the performance of the Cloud Spanner API. This method is used to create the batches from the given bundle. | Do we wait till all output is written before MutationGroups that failed to write are emitted by the DoFn that performed writing ? Otherwise I'm not sure why this will not work in streaming mode. |
@@ -197,8 +197,8 @@ public class InvocationBuilderImpl implements Invocation.Builder {
throw new BlockingNotAllowedException();
}
try {
- return c.get(readTimeoutMs, TimeUnit.MILLISECONDS);
- } catch (InterruptedException | TimeoutException e) {
+ return c.get... | [InvocationBuilderImpl->[cookie->[cookie],buildPost->[build],method->[unwrap,method],get->[get,unwrap],options->[options,unwrap],acceptEncoding->[acceptEncoding],cacheControl->[cacheControl],accept->[accept],buildDelete->[build],acceptLanguage->[acceptLanguage],trace->[trace,unwrap],head->[unwrap,head],buildPut->[build... | Unwrap a CompletableFuture. | This is no longer needed (and is actually incorrect) as the timeout handling is performed by Vert.x |
@@ -16,10 +16,10 @@ package io.prestosql.execution.scheduler;
import com.google.common.collect.ImmutableList;
import com.google.common.collect.ImmutableMap;
import com.google.common.collect.Iterables;
+import io.airlift.units.Duration;
import io.prestosql.client.NodeVersion;
import io.prestosql.connector.CatalogNa... | [TestSourcePartitionedScheduler->[createSqlStageExecution->[createSqlStageExecution]]] | Package for all node versions. Imports all components of the pre - STOSQL object. | squash this commit |
@@ -72,12 +72,17 @@ func runCmd(c *cli.Context) error {
options = append(options, libpod.WithUser(createConfig.User))
options = append(options, libpod.WithShmDir(createConfig.ShmDir))
options = append(options, libpod.WithShmSize(createConfig.Resources.ShmSize))
+ options = append(options, libpod.WithCgroupParent(... | [NewContainer,GetContainerCreateOptions,Index,WithShmSize,WriteFile,Add,Done,Error,Args,Marshal,Init,Start,Errorf,Wait,Debug,Debugf,WithLabels,WithSELinuxLabels,Wrapf,ID,Cleanup,ExitCode,RemoveContainer,Shutdown,Attach,AddArtifact,Printf,WithShmDir,String,WithRootFSFromImage,WithUser] | NewContainer creates a new container with the given image name or ID. attach creates a new object and saves it to the cidfile if it exists. | Can you make this conditional on createConfig.CgroupParent() not being "" |
@@ -303,9 +303,9 @@ module.exports = {
makeExtension.description = 'Create an extension skeleton';
makeExtension.flags = {
- name: ' The name of the extension. Preferable prefixed with `amp-*`',
+ name: ' The name of the extension. Should be prefixed with `amp-*`',
bento: ' Generate a Bento component',
- v... | [No CFG could be retrieved] | Creates an extension skeleton. | @rcebulko I think the `--bento` change makes the prefix required, but correct me if I'm wrong. |
@@ -0,0 +1,14 @@
+# typed: strict
+
+class MyEnum < T::Enum
+ extend T::Sig
+
+ sig {params(x: String, y: String).void}
+ def initialize(x, y); end
+
+ enums do
+ X = new # error: Not enough arguments
+ Y = new('a', 'b')
+ Z = new('a', 0) # error: Expected `String` but found `Integer(0)`
+ end
+end
| [No CFG could be retrieved] | No Summary Found. | Since this is a pattern we don't really want to encourage (subclassing `T::Enum`), especially not without calling `super`, I wonder if this should call `super()` just for show. |
@@ -169,7 +169,7 @@ class BaseServer:
self._tornado.stop(wait)
self._http.stop()
- def unlisten(self) -> None:
+ def unlisten(self) -> Generator[Coroutine[Any, Any, None], None, None]:
''' Stop listening on ports. The server will no longer be usable after
calling this functio... | [BaseServer->[run_until_shutdown->[start,stop],get_sessions->[get_sessions],get_session->[get_session],stop->[stop],start->[start],_atexit->[stop],unlisten->[stop]],Server->[__init__->[start]]] | Stop the server and remove all IOLoop callbacks as well as the HTTPServer. | Why does this code still use `yield`? Perhaps this could be turned into an `async` function? |
@@ -31,6 +31,11 @@ static int do_keyop(EVP_PKEY_CTX *ctx, int pkey_op,
unsigned char *out, size_t *poutlen,
const unsigned char *in, size_t inlen);
+static int do_raw_keyop(int pkey_op, EVP_PKEY_CTX *ctx,
+ const EVP_MD *md, EVP_PKEY *pkey, BIO *in,
+ ... | [No CFG could be retrieved] | Create a new key object. The output file - default stdout - default stderr. | I'd reword this to "Indicate the input data is in raw form" |
@@ -99,7 +99,7 @@ class SquadExample:
self.char_to_word_offset = char_to_word_offset
# Start and end positions only has a value during evaluation.
- if start_position_character is not None and not is_impossible:
+ if start_position_character is not None and not is_impossible and answer... | [SQUADConverter->[_load_examples->[SquadExample],set_max_context->[_is_max_context],convert->[_load_examples]]] | Initialize a nag - value object from the given information. | in which situation answer_text is not None? |
@@ -181,6 +181,9 @@ module View
end
@extra_size = extra.size
+ extra_connection_title = @game.respond_to?(:connection_run) ? [h(:th, th_props[1], 'Conn.')] : []
+ extra_connection_sub = @game.respond_to?(:connection_run) ? [h(:th, '')] : []
+
[
h(:tr, [
... | [Spreadsheet->[num_shares_of->[num_shares_of],render_player_companies->[render_companies],render_corporation->[render_history],render_titles->[render_history_titles]]] | Renders the titles of a missing node in the game hierarchy. Renders the sort_link in the order they are in. | Why the extra-prefix if it's called "connection_run" everywhere else? |
@@ -258,13 +258,13 @@ static void ffmpeg_log_callback(void *param, int level, const char *format,
out.array, ANSI_COLOR_RESET);
fflush(stderr);
}
-
- dstr_free(&out);
#else
- UNUSED_PARAMETER(level);
- UNUSED_PARAMETER(format);
- UNUSED_PARAMETER(args);
+ if (level == AV_LOG_ERROR) {
+ fprintf(stderr, "%s", ... | [No CFG could be retrieved] | This is the main entry point for the ffmpeg_muxer command. It is Parse command line options and set number of audio and video tracks. | If ffmpeg logs `AV_LOG_ERROR` for non-fatal errors then our `stderr` will fill up and block since OBS doesn't read it unless there's a fatal error. Are we sure all paths that hit this are fatal errors? |
@@ -82,6 +82,11 @@ func NewContext() {
// FileNameToHighlightClass returns the best match for highlight class name
// based on the rule of highlight.js.
func FileNameToHighlightClass(fname string) string {
+
+ if name, ok := highlightSpecificNames[fname]; ok {
+ return name
+ }
+
fname = strings.ToLower(fname)
... | [Value,Section,Name,ToLower,Keys,Ext] | FileNameToHighlightClass returns the best match for a given file name or an empty string if. | Maybe we should move these after ignore check. |
@@ -509,7 +509,7 @@ public class BatchModeExecutionContext
CounterCell throttlingMsecs =
container.tryGetCounter(DataflowSystemMetrics.THROTTLING_MSECS_METRIC_NAME);
if (throttlingMsecs != null) {
- totalThrottleTime += TimeUnit.MICROSECONDS.toSeconds(throttlingMsecs.getCumulative());
+ ... | [BatchModeExecutionContext->[StepContext->[getUserStateInternals->[getKey],stateInternals->[getKey]],forTesting->[forTesting,BatchModeExecutionContext],create->[BatchModeExecutionStateRegistry,BatchModeExecutionContext],switchStateKey->[setKey],BatchModeExecutionStateRegistry->[createState->[BatchModeExecutionState]],e... | Extract the throttling time from all the containers. | Can we stick with the TimeUnit class and use TimeUnit.MICROSECONDS.toMillis(throttlingMsecs.getCumulative()) since it helps readability. |
@@ -224,15 +224,6 @@ func (g *Manager) IsChild() bool {
// The order of closure is IsShutdown, IsHammer (potentially), IsTerminate
func (g *Manager) IsShutdown() <-chan struct{} {
g.lock.RLock()
- if g.shutdown == nil {
- g.lock.RUnlock()
- g.lock.Lock()
- if g.shutdown == nil {
- g.shutdown = make(chan struct... | [setState->[Lock,Unlock],IsTerminate->[RUnlock,Lock,Unlock,RLock],setStateTransition->[Lock,getState,Unlock],Done->[RUnlock,Lock,Unlock,RLock],IsShutdown->[RUnlock,Lock,Unlock,RLock],RunAtTerminate->[IsTerminate,Done,Add],WaitForServers->[Wait],WaitForTerminate->[Wait],doShutdown->[doHammerTime,Unlock,doTerminate,WaitF... | IsShutdown returns a channel that will be closed when the manager is shut down. | Please forgive me if I'm too dense, but... is RLock() even needed here? I mean, g.shutdown is a stable struct now (it will not be replaced by another channel for the duration of the manager), and a channel is inherently safe to read in multithreading... |
@@ -146,7 +146,10 @@ class IntelMkl(IntelPackage):
raise InstallError('No MPI found for scalapack')
integer = 'ilp64' if '+ilp64' in self.spec else 'lp64'
- mkl_root = self.prefix.compilers_and_libraries.linux.mkl.lib.intel64
+ if sys.platform != 'darwin':
+ mkl_root = s... | [IntelMkl->[blas_libs->[find_libraries,LibraryList,gcc,Executable,format,find_system_libraries],scalapack_libs->[append,find_libraries,InstallError,format],license_required->[Version],setup_dependent_environment->[append_path,set],setup_environment->[extend,isfile,from_sourcing_file,join],variant,version,provides]] | Find all libraries which are required to be installed in scalapack. | can we please split this into two lines (e.g., with an extra variable) rather than using `noqa`? I think we should ban `noqa` for E501 because it just makes the line *longer*. I know @alalazo loves this thing but I've been trying to squish the remaining uses of it in the code. |
@@ -466,6 +466,10 @@ define([
var polygonHierarchy = polygonGeometry._polygonHierarchy;
var perPositionHeight = polygonGeometry._perPositionHeight;
+ if (polygonHierarchy.positions < 3) {
+ return undefined;
+ }
+
// create from a polygon hierarchy
// Algor... | [No CFG could be retrieved] | Creates a polygon outline geometry that contains the geometric representation of a polygon. This function is called when a hole is not found. It is called by the constructor of. | You can remove this too. |
@@ -148,5 +148,5 @@ export function loadConfig(url: string): Promise<Object> {
return value;
});
- return promise;
+ return timeoutPromise(promise, timeoutMs);
}
| [No CFG could be retrieved] | return a promise that resolves with the value of the last successful sequence number. | Actually, the problem that we're trying to work around with the timeout is the network request. What's being timed out here is not only the network request - `loadScript` - but also the subsequent processing which we technically didn't really set out to time out. |
@@ -298,6 +298,14 @@ return [
'/userexport[/{action}]' => [Module\Settings\UserExport::class, [R::GET, R::POST]],
],
+ '/network' => [
+ '[/]' => [Module\Conversation\Network::class, [R::GET]],
+ '/archive/{from:\d\d\d\d-\d\d-\d\d}[/{to:\d\d\d\d-\d\d-\d\d}]' => [Module\Conve... | [No CFG could be retrieved] | The routes defined in the Diaspora module. List of modules. | Have you changed the `accounttype` value to always have this `/accounttype/` in the path? I would suggest using the widget with the `$_GET` parameter instead. |
@@ -162,14 +162,15 @@ public final class FileOperations extends BaseFileSystemOperations {
* @param targetPath the target directory where the file is going to be copied
* @param createParentDirectories whether or not to attempt creating any parent directories which don't exists.
* @param overwr... | [FileOperations->[list->[doList],write->[doWrite],copy->[doCopy],delete->[doDelete],read->[doRead],rename->[doRename],createDirectory->[doCreateDirectory],move->[doMove]]] | Copies a file in another directory. | we need to shift the wording on the jdocs to be less technical and more user oriented. Rephrase this explaining that if provided, the copy will have this new name. Otherwise, the current name will be honoured. |
@@ -83,6 +83,17 @@ def test_load_includes_run_env(install_mockery, mock_fetch, mock_archive,
assert 'setenv FOOBAR mpileaks' in csh_out
+def test_load_first(install_mockery, mock_fetch, mock_archive, mock_packages):
+ """Test with and without the --first option"""
+ install('libelf@0.8.12')
+ install(... | [test_load_includes_run_env->[install,load],test_load->[install,Spec,dag_hash,load],test_unload_fails_no_shell->[install,unload,Spec,dag_hash],test_unload->[install,unload,Spec,dag_hash],test_load_recursive->[install,dag_hash,reversed,Spec,join,traverse,load],test_load_fails_no_shell->[install,load],SpackCommand] | Test that spack load prints an error message without a shell. | This test would be stronger with a `with pytest.raises(spack.error.SpackError):` context manager instead of `fail_on_errors=False`. |
@@ -273,13 +273,14 @@ namespace Dynamo.PackageManager.Tests
Preferences = CurrentDynamoModel.PreferenceSettings,
};
+
+ CurrentDynamoModel.SearchModel.ClearAllEntries();
loader.LoadAll(loadPackageParams);
Assert.AreEqual(1, loader.LocalPackages.Coun... | [PackageLoaderTests->[GetLibrariesToPreload->[GetLibrariesToPreload]]] | Package loader. Checks that all required packages are imported successfully. | the fact that you need to do this has me a bit worried about loading ZT nodes multiple times into search- a bug that keeps coming back - can you explain it? |
@@ -97,7 +97,8 @@ def _start_rest_server(config: ExperimentConfig, port: int, debug: bool, experim
from subprocess import CREATE_NEW_PROCESS_GROUP
proc = Popen(cmd, cwd=node_dir, creationflags=CREATE_NEW_PROCESS_GROUP)
else:
- proc = Popen(cmd, cwd=node_dir)
+ import os
+ pro... | [_init_experiment->[post,to_cluster_metadata,to_rest_json,put],start_experiment->[suppress,_init_experiment,error,validate,connect,_ensure_port_idle,kill,_start_rest_server,_save_experiment_information,isinstance,_check_rest_server,close,info,Pipe],_ensure_port_idle->[connect_ex,socket,RuntimeError,close],_start_rest_s... | Start a REST server with a specific port. | why `preexec_fn` is not set in the previous version? |
@@ -90,14 +90,15 @@ public class JacksonConfigManager
*
* @param key of the config to set
* @param oldValue old config value. If not null, then the update will only succeed if the insert
- * happens when current database entry is the same as this value. If null, then the insert
- * ... | [JacksonConfigManager->[set->[set],watch->[watch]]] | Sets the value of the specified key to the specified value. | nit: it might be worth calling out why it uses bytes to be resilient across serde instead of the old object |
@@ -30,6 +30,10 @@ def cli():
get List high-level object information
describe Retrieve detailed object descriptions
+ \b
+ Mutation Commands:
+ create Create objects
+
\b
Execution Commands:
execute Execute a flow's environment
| [version->[echo],config->[to_dict,echo],dict,group,add_command,command] | The Prefect CLI for creating managing and inspecting a specific object. | "Mutation Commands" feels like it borrows a little too heavily from GQL's vocabulary, which may not be familiar to users -- I suggest putting this in the `Execution Commands` section and renaming it `Actions` (and the previous section `Queries`) |
@@ -450,11 +450,15 @@ if (empty($reshook)) {
// Do we update also ->entity ?
if (!empty($conf->multicompany->enabled)) { // If multicompany is not enabled, we never update the entity of a user.
if (!empty($conf->global->MULTICOMPANY_TRANSVERSE_MODE)) {
- $object->entity = 1; // all users are in mas... | [fetch,create,select_civility,formconfirm,select_country,lasterror,SetInGroup,send_password,getUserIdentifier,select_all_categories,setstatus,selectyesno,select_ziptown,getCurrencySymbol,selectColor,getNomUrl,selectcontacts,rollback,connect_bind,listGroupsForUser,getInfo,select_dolusers,showCategories,setCategories,beg... | Adds properties like salary extra dateemployment end datestart validity and color to object Try to change the entity of user. | Relying on a property provided as a parameter to decide if an object must be into an admin entity or not means anybody, even not superadmin can set the superadmin flag to any user. |
@@ -661,8 +661,11 @@ static void makeFastFace(const TileSpec &tile, u16 li0, u16 li1, u16 li2, u16 li
TODO: Add 3: Both faces drawn with backface culling, remove equivalent
*/
static u8 face_contents(content_t m1, content_t m2, bool *equivalent,
- const NodeDefManager *ndef)
+ const NodeDefMa... | [getInteriorLight->[getInteriorLight], m_minimap_mapblock->[final_color_blend,get_sunlight_color],void->[getNodeTile,getSmoothLightSolid,getFaceLight],final_color_blend->[final_color_blend,get_sunlight_color],getNodeTile->[getNodeTileN],getFaceLight->[getFaceLight],fill->[fillBlockDataBegin,fillBlockData],animate->[fin... | This method is used to determine if two content_t objects are equivalent or not. | Don't listen to the code checked. The old indents were correct. |
@@ -51,6 +51,7 @@ class SocialPreviewsController < ApplicationController
private
+ # TODO: don't hardcode this
def define_categories
cat_info = {
"collabs": ["Collaborators Wanted", "#5AE8D9"],
| [SocialPreviewsController->[article->[set_respond,social_preview_template,find,published,include?,pluck,where],set_respond->[redirect_to,render,render_to_string,respond_to,fetch_url,png,html],listing->[find],organization->[set_respond,find],user->[where,find,pluck],define_categories->[to_sym],comment->[where,find,pluck... | Define the categories of the n - ary objects. | same note about `# TODO: [thepracticaldev/oss]` |
@@ -0,0 +1,10 @@
+<?php
+
+if ($device['os'] === 'netspire') {
+ echo 'Netspire Memory Pool\n';
+ $usage = str_replace('"', "", snmp_get($device, '1.3.6.1.4.1.1732.2.1.8.0', "-OQv"));
+
+ if (is_numeric($usage)) {
+ discover_mempool($valid_mempool, $device, 0, 'netspire', 'Storage');
+ }
+}
| [No CFG could be retrieved] | No Summary Found. | Can you use the MIB and named OID here please |
@@ -1122,6 +1122,7 @@ MSG_PROCESS_RETURN tls_process_server_hello(SSL *s, PACKET *pkt)
* overwritten if the server refuses resumption.
*/
if (s->session->session_id_length > 0) {
+ s->ctx->stats.sess_miss++;
if (!ssl_get_new_session(s, 0)) {
goto f_e... | [No CFG could be retrieved] | The callback that gets called when a new session secret is received. Reads the session id from the packet and stores it in the session object. | Is there a race condition problem with this? |
@@ -151,7 +151,7 @@ public class UserUpdater implements ServerComponent {
List<String> scmAccounts = sanitizeScmAccounts(newUser.scmAccounts());
if (scmAccounts != null && !scmAccounts.isEmpty()) {
validateScmAccounts(dbSession, scmAccounts, login, email, null, messages);
- userDto.setScmAccounts(... | [UserUpdater->[validateLoginFormat->[checkNotEmptyParam],validateNameFormat->[checkNotEmptyParam],validatePasswords->[checkNotEmptyParam],updateUser->[update]]] | Creates a new userDto based on the newUser object. | convertScmAccountsToCsv should be removed as it's now useless |
@@ -20,6 +20,10 @@ if ( ! defined( 'ABSPATH' ) ) {
exit;
}
+if ( class_exists( 'Jetpack' ) && Jetpack::is_module_active( 'private' ) ) {
+ return;
+}
+
if ( '1' == get_option( 'blog_public' ) ) { // loose comparison okay.
include_once 'sitemaps/sitemaps.php';
}
| [No CFG could be retrieved] | Module for Sitemap. | Would it makes sense to filter the `blog_public` option via pre_get_option and utilize the existing check below? |
@@ -200,7 +200,7 @@ class MyPkg(ConanFile):
self.output.info("Running system requirements!!")
"""})
client.run("create . Pkg/0.1@lasote/testing")
- self.assertIn("Configuration:[settings]", "".join(str(client.out).splitlines()))
+ self.assertIn("Configuration (host machine):[settings]",... | [CreateTest->[keep_build_package_folder_test->[package_layout,dedent,TestClient,assertIn,assertNotIn,replace,ConanFileReference,run,save,listdir,PackageReference],package_folder_build_error_test->[package_layout,dedent,TestClient,assertIn,ConanFileReference,full_repr,run,exists,save,assertFalse,PackageReference],create... | Create a test package with a conan client. | I really think that when we are not using cross build profiles everything should work the same, including that message. Maybe I don't have any idea about cross-building or (very likely) don't about gnu triplet jargon and `(host-machines)` means nothing to me. |
@@ -0,0 +1,15 @@
+# frozen_string_literal: true
+
+require_relative '../base'
+require_relative '../track'
+require_relative 'tracker'
+
+module Engine
+ module Step
+ module G1856
+ class Track < Track
+ include Tracker
+ end
+ end
+ end
+end
| [No CFG could be retrieved] | No Summary Found. | what's the point of this file? should we just delete it? |
@@ -110,11 +110,16 @@ func PruneImages(w http.ResponseWriter, r *http.Request) {
var libpodFilters = []string{}
if _, found := r.URL.Query()["filters"]; found {
+ all, err = strconv.ParseBool(query.Filters["all"][0])
+ if err != nil {
+ utils.InternalServerError(w, err)
+ return
+ }
for k, v := range qu... | [Context,Value,StatusText,InternalServerError,TempFile,Vars,GetImage,NewFromLocal,Close,IsReadOnly,UnsupportedHandler,Wrap,Error,Save,New,Created,GetImages,ImageNotFound,Wrapf,Name,Remove,ImageRuntime,Query,PruneImages,Sprintf,Decode,String,ImageToImageSummary,Open,Inspect,WriteResponse] | PruneImages retrieves all images that are not in the image cache and prunes them. Format is the schema for the object. | You have to return after this Error call |
@@ -17,13 +17,14 @@
package org.apache.gobblin.dataset;
-import java.util.Map;
-
import com.google.common.collect.ImmutableMap;
import com.google.common.collect.Maps;
-
import lombok.Getter;
+import javax.annotation.Nullable;
+import java.util.Map;
+import java.util.Objects;
+
/**
* A {@link Descriptor} ... | [DatasetDescriptor->[hashCode->[hashCode],copy->[DatasetDescriptor],fromDataMap->[DatasetDescriptor,addMetadata,equals],equals->[equals]]] | Creates a new DatasetDescriptor that identifies a dataset and provides its metadata. Creates a copy of this DatasetDescriptor with the specified metadata. | What exactly does clusterName mean? Is this the name of the storage instance that has an instance of a given dataset? If so, I think storageInstance or storageInstanceName would better capture what this field is. |
@@ -123,7 +123,10 @@ public abstract class AbstractNioByteChannel extends AbstractNioChannel {
allocHandle.readComplete();
pipeline.fireChannelReadComplete();
pipeline.fireExceptionCaught(cause);
- if (close || cause instanceof IOException) {
+
+ // If oom wi... | [AbstractNioByteChannel->[isAllowHalfClosure->[isAllowHalfClosure],doWrite->[doWriteInternal],shouldBreakReadReady->[isInputShutdown0],NioByteUnsafe->[closeOnRead->[isAllowHalfClosure,shutdownInput,isInputShutdown0],read->[closeOnRead,shouldBreakReadReady,handleReadException],handleReadException->[closeOnRead]]]] | This method is called when a read exception occurs. Method to handle a nanomsg that is not possible for a read operation. | This change doesn't seem to be related to this pr ... please revert |
@@ -20,6 +20,9 @@
package org.sonar.server.platform;
import com.google.common.collect.Lists;
+import java.util.Arrays;
+import java.util.Collection;
+import java.util.List;
import org.apache.commons.configuration.BaseConfiguration;
import org.sonar.api.config.EmailSettings;
import org.sonar.api.issue.action.Acti... | [ServerComponents->[level3Components->[DatabaseSessionProvider,newArrayList],startLevel4Components->[addComponent,getComponentByType,installExtensions,startComponents,addSingleton],level2Components->[newArrayList],executeStartupTasks->[doPrivileged->[startComponents,notifyStart,execute],stopComponents,createChild,Task,... | SonarQube is free software and is not used by any other program. Imports a single version of the object. | lots of changes on imports. Is that expected ? |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.