patch stringlengths 18 160k | callgraph stringlengths 4 179k | summary stringlengths 4 947 | msg stringlengths 6 3.42k |
|---|---|---|---|
@@ -119,6 +119,16 @@ namespace Dynamo.Core.Threading
}
}
+ if (droppedTasks != null)
+ {
+ // Only notify listeners of dropping tasks here instead of
+ // within CompactTaskQueue method. This way the lock on task
+ // que... | [DynamoScheduler->[Shutdown->[Shutdown,Set],ProcessNextTask->[Reset,ReprioritizeTasksInQueue,ProcessTaskInternal,Count,TaskAvailable,WaitAny,CompactTaskQueue,RemoveAt],ScheduleForExecution->[ProcessTaskInternal,IsTestMode,MarkTaskAsScheduled,Set,Add],schedulerThread,Initialize,Next]] | Process the next task in the task queue. If there are no more tasks in the queue. | Have we put it in the doc that these events are going to be fired on the scheduler thread? |
@@ -84,7 +84,7 @@ namespace System.Drawing.Tests
}
}
- [Fact]
+ [ConditionalFact(Helpers.IsDrawingSupported)]
public void Ctor_NullFormat_ThrowsArgumentNullException()
{
AssertExtensions.Throws<ArgumentNullException>("format", () => new StringFormat(n... | [StringFormatTests->[Clone_Disposed_ThrowsArgumentException->[AssertExtensions,Clone,IsDrawingSupported,Dispose],Alignment_SetValid_GetReturnsExpected->[Equal,Alignment,IsDrawingSupported,Center,Far,Near],FormatFlags_GetSetWhenDisposed_ThrowsArgumentException->[FormatFlags,NoClip,Dispose,AssertExtensions,IsDrawingSuppo... | Tests that StringFormat is compatible with Java StringFormat. | So this indeed fixes: #35917 ? |
@@ -33,7 +33,11 @@ namespace System.Net.Http.Functional.Tests
for (int i = 0; i < _length; i++)
{
buffer[0] = (byte)i;
+#if !NETFRAMEWORK
await stream.WriteAsync(buffer);
+#else
+ await stream.WriteAsync(buffer, 0, buffer.Length);
+#endif
... | [ByteAtATimeContent->[Task->[FlushAsync,Delay,SetResult,WriteAsync],CompletedTask]] | Serialize to stream asynchronously. | Can we use extension methods here and elsewhere to avoid writing `#if` everywhere? |
@@ -139,6 +139,12 @@ namespace Dynamo.Extensions
Log(fullName + " extension cannot be disposed properly: " + ex.Message);
}
+ if (extension is IExtensionStorageAccess storageAccess &&
+ storageAccessExtensions.Find(x => (x as IExtension).UniqueId == extension.Un... | [ExtensionManager->[Log->[Log],UnregisterService->[Remove],Add->[Add],Remove->[Remove],Dispose->[Remove],RegisterService->[Add]]] | Remove an extension from the extension manager. | shouldn't that be not null? I may be coffee deprived. |
@@ -159,8 +159,9 @@ class DevOutSourceFlowTest(unittest.TestCase):
client.save({"conanfile.py": conanfile_out})
client.current_folder = build_folder
- client.run("install ../recipe -g txt")
+ client.run("install ../recipe")
client.current_folder = src_folder
+ client.ru... | [DevOutSourceFlowTest->[child_build_test->[_assert_pkg],parallel_folders_test->[_assert_pkg],insource_build_test->[_assert_pkg]],DevInSourceFlowTest->[child_build_test->[_assert_pkg],parallel_folders_test->[_assert_pkg],insource_build_test->[_assert_pkg]]] | Test for parallel folders. | The conanbuildinfo.txt should be optional for ``conan source``, and could be provided with a --build_folder arg. |
@@ -832,6 +832,8 @@ class While(object):
A new OP :ref:`api_fluid_layers_while_loop` is highly recommended instead of ``While`` if the shape of parameter ``cond`` is [1].
OP :ref:`api_fluid_layers_while_loop` is easier to use and is called with less code but does the same thing as ``While`` .
+ N... | [Switch->[default->[ConditionalBlock,ConditionalBlockGuard],case->[_case_check_args->[],ConditionalBlock,ConditionalBlockGuard]],IfElseBlockGuard->[__exit__->[__exit__],__enter__->[__enter__],__init__->[block]],DynamicRNN->[_parent_block_->[block],block->[array_write,block,increment,less_than,array_to_lod_tensor],stati... | Creates a block guard with completion. create word sequence. | "are similar it" -> "are similar to that" "while in C++, and cannot be referenced externally, As a result" -> "``while`` of C++ and cannot be referenced externally. As a result" "If you want to implement this function" -> "If you would like to access the variable out of ``While``" ''``assign`` interface" -> "``assign``... |
@@ -249,8 +249,9 @@ public abstract class AbstractProcessingStrategyTestCase extends AbstractMuleCon
public AbstractProcessingStrategyTestCase(Mode mode, boolean profiling) {
this.mode = mode;
this.enableProfilingServiceProperty =
- new SystemProperty((MuleRuntimeFeature.ENABLE_PROFILING_SERVICE.get... | [AbstractProcessingStrategyTestCase->[asyncCpuLightConcurrent->[internalConcurrent],process->[process],RejectingScheduler->[submit->[submit]],AnnotatedAsyncProcessor->[getProcessingType->[getProcessingType],apply->[apply],process->[process]],WithInnerPublisherProcessor->[apply->[apply],process->[process]],processFlow->... | Returns the mode parameters. | remove extra parenthesis |
@@ -864,6 +864,11 @@ class Beam(object):
def advance(self, softmax_probs):
voc_size = softmax_probs.size(-1)
+ current_length = len(self.all_scores) - 1
+ if current_length < self.min_length:
+ # penalize all eos probs to make it decode longer
+ for hyp_id in range(so... | [Beam->[get_beam_dot->[get_hyp_from_finished,get_rescored_finished]],TorchAgent->[get_dialog_history->[_add_person_tokens],vectorize->[_vectorize_text,_check_truncate],load->[load],observe->[get_dialog_history,last_reply,vectorize],__init__->[dictionary_class],save->[save],batch_act->[batchify,match_batch],_copy_embedd... | Advance the model by adding the hypotheses to the list of hypotheses and Add a to the finished list. | nit: i'd really love it if we had a NEG_ALMOST_INFINITY constant defined somewhere. Emily and I have both needed it. |
@@ -576,6 +576,13 @@ export class FetchResponseHeaders {
* @return {!Xhr}
*/
export function xhrServiceForTesting(window) {
+ registerServiceBuilder(window, 'ampdoc', function() {
+ return {
+ isSingleDoc() {
+ return false;
+ },
+ };
+ });
installXhrService(window);
return getServic... | [No CFG could be retrieved] | Provides a function to install or update the XHR service depending on the current environment. | This looks weird. Can we do without? |
@@ -88,9 +88,15 @@ class Profile
* @param int $profile int
* @param array $profiledata array
* @param boolean $show_connect Show connect link
+ * @throws InvalidArgumentException Thrown when a parameter is invalid
*/
- public static function load(App $a, $nickname, $profile = 0, $profiledata = ... | [Profile->[load->[set_template_engine,getCurrentTheme],openWebAuthInit->[get_hostname]]] | Load user tags Renders the admin menu Transactional interface for the block object. | Why should there be some exception for just some empty nickname? This isn't the end of the universe. An exception should - from my point of view - mostly be used at some critical part like where data is processed that would otherwise be corrupted. |
@@ -67,7 +67,7 @@ class AppWrapper extends Component {
if (!ready) return null
return (
<ApolloProvider client={client}>
- <HashRouter>
+ <HashRouter history={browserHistory}>
<Analytics>
<App locale={locale} onLocale={this.onLocale} />
</Analytics>
| [No CFG could be retrieved] | Renders the . | Hrm not sure if this will cause unintended side effects... perhaps we can remove this for now and look at it again if the error still isn't fixed with the other changes |
@@ -135,7 +135,9 @@ def resolve_unhydrated_struct(address_family, address):
maybe_append(key, value)
collect_dependencies(struct)
- return UnhydratedStruct(address, struct, dependencies)
+
+ return UnhydratedStruct(
+ filter(lambda build_address: build_address == address, addresses)[0], struct, depen... | [filter_build_dirs->[BuildDirs],address_from_address_family->[_raise_did_you_mean],_hydrate->[ResolvedTypeMismatchError],resolve_unhydrated_struct->[collect_dependencies->[maybe_append],_raise_did_you_mean,collect_dependencies,UnhydratedStruct],filter_buildfile_paths->[match,BuildFiles],hydrate_struct->[consume_depende... | Given an Address and its AddressFamily resolve an UnhydratedStruct. Get a cunique key from dependencies. | is there always guaranteed to be at least one non-filtered address here? if not, the index access here may be unsafe. |
@@ -226,7 +226,17 @@ namespace Dynamo.Tests
var guid = "490a8d54d0fa4782ae18c81f6eef8306";
- AssertPreviewValue(guid, new Dictionary<string, int> { { "abc", 123 }, { "def", 345 } });
+ var nodeModel = ViewModel.Model.CurrentWorkspace.NodeFromWorkspace(guid);
+ var pynod... | [PythonEditTests->[GetLibrariesToPreload->[GetLibrariesToPreload]]] | InputDynamoDictionary_AsDynamoDictionary - This test creates a dictionary with the keys. | Is the workspace in an unsaved state at this stage due to changes to engine property? |
@@ -872,8 +872,16 @@ export class Viewer {
return Promise.resolve('');
}
return this.sendMessageUnreliable_('fragment', undefined, true).then(
- hash => hash || ''
- );
+ hash => {
+ if (!hash) {
+ return '';
+ }
+ /* Strip leading '#' */
+ ... | [No CFG could be retrieved] | Get the base CID from the web page or the viewer. This is the main entry point for all the events that need to be sent to the View. | Can this either always or never come with a leading `#`? |
@@ -1157,6 +1157,11 @@ def parse_editable(editable_req, default_vcs=None):
if '+' not in url:
if default_vcs:
+ warnings.warn(
+ "--default-vcs has been deprecated and will be removed in "
+ "the future.",
+ RemovedInPip10Warning,
+ )
... | [parse_editable->[_strip_postfix],InstallRequirement->[from_path->[from_path],from_line->[_safe_extras,_strip_extras],get_dist->[egg_info_path],install->[prepend_root],ensure_has_source_dir->[build_location],_correct_build_location->[build_location],move_wheel_files->[move_wheel_files],__init__->[_safe_extras],run_egg_... | Parses an editable requirement into a tuple of packages name url extras options_subdir and c Returns the URL of the package that is currently installed. | Any reason for this to be removed in pip 10 instead of pip 11? I'm not opposed just wondering why the accelerated schedule. |
@@ -1,6 +1,10 @@
import django_filters
from graphene_django.filter import GlobalIDMultipleChoiceFilter
+from saleor.graphql.core.filters import EnumFilter
+from saleor.graphql.warehouse.enums import WarehouseClickAndCollectOptionEnum
+from saleor.warehouse import WarehouseClickAndCollectOption
+
from ...warehouse.... | [filter_search_warehouse->[prefech_qs_for_filter]] | This function is a decorator to provide a filter that can be used to filter a queryset by Input method for the StockFilterSet. | It's should be relative imports. |
@@ -545,11 +545,15 @@ export class AnimationManager {
/** @private @const */
this.builderPromise_ = this.createAnimationBuilderPromise_();
+ const storeService = getStoreService(this.ampdoc_.win);
+ const animationDisabled =
+ isExperimentOn(ampdoc.win, 'story-disable-animations-first-page') ||
+... | [AnimationManager->[createRunner_->[create],applyLastFrame->[applyLastFrame],cancelAll->[cancel],animateIn->[start],finishAll->[finish],resumeAll->[resume],pauseAll->[pause],hasAnimationStarted->[hasStarted],applyFirstFrameOrFinish->[applyFirstFrame,applyLastFrame],constructor->[create]],AnimationRunner->[startWhenRead... | private private static final int MAX_ANIMATIONS_LENGTH = 8 ;. | We can rename this var to `firstPageAnimationDisabled` to make it clear that it only impacts the first page |
@@ -397,7 +397,11 @@ func (i *Ingester) v2Push(ctx context.Context, req *client.WriteRequest) (*clien
}
if firstPartialErr != nil {
- return &client.WriteResponse{}, httpgrpc.Errorf(http.StatusBadRequest, wrapWithUser(firstPartialErr, userID).Error())
+ code := http.StatusBadRequest
+ if ve, ok := errors.Cause... | [shipBlocks->[getTSDB],runConcurrentUserWorkers->[getTSDBUsers],getOrCreateTSDB->[getTSDB],compactBlocks->[getTSDB],shipBlocksLoop->[getTSDBUsers,getTSDB],openExistingTSDB->[createTSDB]] | v2Push is the v2 push implementation for the TSDB. This function is used to add a reference to a series in the database. This is a helper function that will check if the given error is a transient error and if succeededSamplesCount - > 0 - > 0 - > 0 - > 0 - >. | I would use `errors.As()` here as well instead of `.(*validationError)` for the same reason suggested by peter. |
@@ -108,7 +108,7 @@ class BLEU(Metric):
return math.exp(1.0 - self._reference_lengths / self._prediction_lengths)
def _get_valid_tokens_mask(self, tensor: torch.LongTensor) -> torch.ByteTensor:
- valid_tokens_mask = torch.ones(tensor.size(), dtype=torch.bool)
+ valid_tokens_mask = torch.on... | [BLEU->[_get_modified_precision_counts->[_ngrams],__call__->[_get_modified_precision_counts,_get_valid_tokens_mask],get_metric->[_get_brevity_penalty,reset]]] | Returns a mask of tokens that are valid for the given tensor. | Using `_like` uses the same device as the input tensor also. |
@@ -211,12 +211,9 @@ class _TransformWatermarks(object):
min_pending_timestamp = WatermarkManager.WATERMARK_POS_INF
has_pending_elements = False
for input_bundle in self._pending:
- # TODO(ccy): we can have the Bundle class keep track of the minimum
- # timestamp so we don't have to d... | [WatermarkManager->[_refresh_watermarks->[get_watermarks,_refresh_watermarks],update_watermarks->[get_watermarks],extract_fired_timers->[extract_fired_timers]]] | Refreshes the watermarks of the input and output bundles. | <!--new_thread; commit:61ae92dcffa98203cbe8f56930802405de2524f0; resolved:0--> Please use 2sp indentation, wrap line to 80 chars. |
@@ -212,7 +212,9 @@ namespace PlatformAgnostic
// * C1_SPACE corresponds to the Unicode Zs category.
// * C1_BLANK corresponds to a hardcoded list thats ill-defined.
// We'll skip that compatibility here and just check for Zs.
- if ((charTypeMask & U_GC_ZS_MASK) != 0)... | [No CFG could be retrieved] | Get the class of the given Unicode character. This function checks if a sequence of characters in sourceString is unique within destString. If. | is it possible to have also `0xFFFE` ? |
@@ -17,6 +17,7 @@
/// </summary>
public SubscriptionMigrationModeSettings(SettingsHolder settings) : base(settings)
{
+ settings.Set("NServiceBus.Subscriptions.EnableMigrationMode", true);
}
/// <summary>
| [SubscriptionMigrationModeSettings->[ThrowOnAddress->[Contains],RegisterPublisher->[nameof,AgainstNull,AgainstNullAndEmpty,Empty,ThrowOnAddress,Add,CreateFromEndpointName],SubscriptionAuthorizer->[AgainstNull,Set,nameof]]] | Creates a new instance of SubscriptionMigrationModeSettings. Publisher is a generic publisher implementation that can be used to publish a single message to a publisher. | hm not sure I like this approach to introduce side effects when calling the constructor. |
@@ -115,14 +115,8 @@ static int asn1_bio_init(BIO_ASN1_BUF_CTX *ctx, int size)
if (ctx->buf == NULL)
return 0;
ctx->bufsize = size;
- ctx->bufpos = 0;
- ctx->buflen = 0;
- ctx->copylen = 0;
ctx->asn1_class = V_ASN1_UNIVERSAL;
ctx->asn1_tag = V_ASN1_OCTET_STRING;
- ctx->ex_buf = ... | [int->[BIO_clear_retry_flags,asn1_bio_init,BIO_next,ASN1_object_size,asn1_bio_flush_ex,OPENSSL_assert,BIO_write,strlen,BIO_copy_next_retry,ASN1_put_object,asn1_bio_write,BIO_ctrl,cleanup,BIO_set_data,BIO_read,BIO_get_data,OPENSSL_malloc,asn1_bio_setup_ex,OPENSSL_free,BIO_gets,setup,BIO_set_init],BIO_asn1_get_suffix->[a... | private static final int ASN1_bio_init_private ;. | nope, don't add this line. |
@@ -317,6 +317,17 @@ public class MetadataMediator
return success(descriptor);
}
+ private MetadataResult<TypeMetadataDescriptor> toTypeMetadataDescritorResult(MetadataResult<MetadataType> result)
+ {
+ TypeMetadataDescriptor descriptor = typeDescriptor().withType(result.get()).build();
+ ... | [MetadataMediator->[getContentMetadata->[getContentMetadata],cloneAndEnrichMetadataKey->[cloneAndEnrichMetadataKey],getOutputMetadata->[getOutputMetadata],getMetadataKeys->[getMetadataKeys]]] | Get the output metadata descriptor for the given key. | how is this change related to the issue? |
@@ -63,8 +63,9 @@ func generateAdminToken(ctx context.Context,
authzV2Client := authz_v2.NewPoliciesClient(authzConnection)
response, err := authnClient.CreateToken(ctx, &authn.CreateTokenReq{
- Description: req.Description,
- Active: true,
+ Id: uuid.Must(uuid.NewV4()).String(),
+ Name: req.Descri... | [GenerateAdminToken->[AddressForService,HasConfiguredDeployment],WithBlock,CreateToken,CreatePolicy,NewOutgoingContext,NewTokensMgmtClient,Close,DialContext,Convert,DeleteToken,Wrap,NewPoliciesClient,Code,NewContext] | generateAdminToken creates an admin token. GenerateAdminTokenResponse returns admin token. | Was this call idempotent before? If so, is it still? I don't know from the top of my head where this method is called, but it might be good to double-check. |
@@ -456,6 +456,13 @@ func setupAppConfig(f *clientcmd.Factory, out io.Writer, c *cobra.Command, args
if config.AllowMissingImages && config.AsSearch {
return cmdutil.UsageError(c, "--allow-missing-images and --search are mutually exclusive.")
}
+
+ if len(config.SourceImage) != 0 && len(config.SourceImagePath) =... | [CACert->[Errorf,ReadFile],IsInvalid,StringVar,Status,SetMapper,StringP,StringSliceVar,NewPrintErrorAfter,Delete,AddObjectLabels,Errors,SplitImageStreamTag,Exit,ScoredComponentMatches,SetClientMapper,RunLog,GetFlagString,Secrets,Ping,IsImage,SetTyper,SelectorFromSet,Errorf,NewString,Run,CheckErr,Bool,Clients,NewHelper,... | setAnnotations sets the annotation and labels for the object isInvalidTriggerError returns true if the given error is a trigger type error. | Shouldn't we check the opposite as well, `--source-image-path` is set while `--source-image` is empty? |
@@ -111,7 +111,8 @@ final class Native {
if (!name.startsWith("mac") && !name.contains("bsd") && !name.startsWith("darwin")) {
throw new IllegalStateException("Only supported on BSD");
}
- NativeLibraryLoader.load("netty_transport_native_kqueue", PlatformDependent.getClassLoader(Na... | [Native->[loadNativeLibrary->[trim,IllegalStateException,contains,getClassLoader,startsWith,load],keventWait->[capacity,memoryAddress,size,newIOException,keventWait],newKQueue->[FileDescriptor,kqueueCreate],evDelete,noteConnReset,evError,noteDisconnected,evfiltSock,evClear,evEOF,evDisable,evfiltRead,evfiltWrite,noteRea... | Load the native library if it is available. | Should this be replaced with calls to PlatformDependent to get this information? And missing ones added there? |
@@ -119,10 +119,6 @@ final class ArrayVarHandle extends VarHandle {
}
/*[ENDIF] Java12 */
- public MethodType accessModeTypeUncached(AccessMode accessMode) {
- throw OpenJDKCompileStub.OpenJDKCompileStubThrowError();
- }
-
/**
* Type specific methods used by array element VarHandle methods.
*/
| [ArrayVarHandle->[populateMHs->[populateMHs],describeConstable->[describeConstable],ArrayVarHandleOperations->[OpLong->[getAcquire->[boundsCheck,computeOffset],getAndAdd->[boundsCheck,computeOffset],compareAndSet->[boundsCheck,computeOffset],getAndBitwiseAndAcquire->[boundsCheck,computeOffset],get->[boundsCheck,compute... | Get the MethodType for the given access mode. | This is changed from `public` to package access which might be problematic. |
@@ -1,5 +1,6 @@
package gobblin.compaction.parser;
+import avro.shaded.com.google.common.base.Joiner;
import gobblin.dataset.FileSystemDataset;
import lombok.AllArgsConstructor;
import org.apache.commons.lang.StringUtils;
| [CompactionPathParser->[parse->[CompactionParserResult]]] | Package private for testing purposes. Parse the result of a parse. | Use unshaded version |
@@ -687,14 +687,14 @@ RtpsDiscovery::Config::discovery_config(ACE_Configuration_Heap& cf)
} else if (name == "UseXTypes") {
const OPENDDS_STRING& value = it->second;
int smInt;
- if (!DCPS::convertToInteger(value, smInt)) {
+ if (!DCPS::convertToInteger(value, smInt) || ... | [No CFG could be retrieved] | Protected set of flags for the discovery config - - - - - - - - - - - - - - - - - -. | For configuration parsing, how about allowing 0 or 1 (for backwards compatibility) or a string value for the enumerator? |
@@ -40,6 +40,16 @@ func (vt VisibleType) IsPrivate() bool {
return vt == VisibleTypePrivate
}
+// VisibilityMode provides the mode string of the visibility type (public, limited, private)
+func (vt VisibleType) VisibilityMode() string {
+ for k, v := range VisibilityModes {
+ if vt == v {
+ return k
+ }
+ }
+ ... | [No CFG could be retrieved] | IsPrivate returns true if the VisibleType is a private type. | I think `Name` or `String` is a better name for the function. |
@@ -276,6 +276,13 @@ public class TestHddsDispatcher {
return hddsDispatcher;
}
+ private void shutdownDispatcher(HddsDispatcher dispatcher){
+ if(dispatcher != null) {
+ dispatcher.shutdown();
+ }
+ ContainerMetrics.remove();
+ }
+
// This method has to be removed once we move scm/TestUtil... | [TestHddsDispatcher->[testContainerNotFoundWithCommitChunk->[assertTrue,captureLogs,getTempPath,getWriteChunkRequest,OzoneConfiguration,getResult,dispatch,getUuidString,getSimpleName,createDispatcher,getContainerID,set,File,randomDatanodeDetails,randomUUID,assertEquals,build,getReadChunkRequest,contains,deleteDirectory... | create a dispatcher for a given datanode. | I am not convinced whether this step to remove the ContainerMetrics belongs to a method called shutdownDispatcher, at least from the name it is not clear it will do so besides shutting down the dispatcher. Shouldn't we separate this two? |
@@ -1,10 +1,18 @@
// Licensed to the .NET Foundation under one or more agreements.
// The .NET Foundation licenses this file to you under the MIT license.
+using System.Runtime.Versioning;
+
namespace System.Threading
{
public partial class Thread
{
internal const bool IsThreadStartSupported = ... | [No CFG could be retrieved] | Integrity checks for a non - null . | Note that threads might be supported in the browser in the future. |
@@ -117,6 +117,7 @@ class AbuseReport(ModelBase):
('UNINSTALL', 1, 'Uninstall'),
('MENU', 2, 'Menu'),
('TOOLBAR_CONTEXT_MENU', 3, 'Toolbar context menu'),
+ ('AMO', 4, 'AMO'),
)
STATES = Choices(
('UNTRIAGED', 1, 'Untriaged'),
| [AbuseReport->[AbuseReportManager],AbuseReportManager->[__init__->[__init__]]] | Define the fields of the catch - all model. Relations for abuse reports. | I wonder if this should rather be "addons.mozilla.org" - but that representation is only used internally right? |
@@ -61,7 +61,7 @@ module SamlIdpAuthConcern
end
def requested_authn_context
- if AppConfig.env.aal_authn_context_enabled == 'true'
+ if IdentityConfig.store.aal_authn_context_enabled
requested_aal_authn_context
else
sp_defined_aal_context = saml_request.requested_aal_authn_context
| [name_id_format->[name_id_format],build_asserted_attributes->[attribute_asserter],requested_aal_authn_context->[requested_aal_authn_context],requested_ial_authn_context->[requested_ial_authn_context]] | return the next unknown authentication context object in the list. | How would you feel if we updated this to add `?` to the end of `type: :boolean` attributes? |
@@ -229,7 +229,9 @@ func Execute(configFile io.Reader) {
app.Config.HTTP.Headers.Set("X-Registry-Supports-Signatures", "1")
app.RegisterHealthChecks()
- handler := alive("/", app)
+ handler := http.Handler(app)
+ handler = limit(readLimiter, writeLimiter, handler)
+ handler = alive("/", handler)
// TODO: tempor... | [RegisterSignatureHandler,Path,WriteHeader,ValidTLSVersions,CombinedLoggingHandler,HandlerFunc,Warnf,NewConfig,Subjects,NewTokenHandler,Info,GetError,Exit,PathPrefix,NewRegistryClient,RegisterRoute,Set,ListenAndServeTLS,Handler,Error,WithRegistryClient,SecureTLSConfig,ReadFile,ServeHTTP,WithLogger,ParseLevel,BytesSize,... | Register the handler. if returns the if specified in REGISTRY_HTTP_TLS_CIP. | The limiter is fine, but this needs to be much more discriminating. Blob HEAD and GET shouldn't be under the same rate limit. This is too broad to solve the existing problem without adding a new one. This needs to only apply to blob upload. |
@@ -123,8 +123,12 @@ def item_tax(item: ProductVariant, discounts: Iterable[DiscountInfo]):
Read more:
https://support.google.com/merchants/answer/6324454
"""
- # FIXME https://github.com/mirumee/saleor/issues/4311
- return "US::%s:y" % zero_money()
+ country = Country(settings.DEFAULT_COUNTRY)
... | [item_attributes->[item_tax,item_google_product_category,item_mpn,item_availability,item_image_link,item_brand,item_condition,item_title,item_sale_price,item_id,item_group_id,item_description,item_price],write_feed->[item_attributes,get_feed_items],update_feed->[write_feed]] | Return item tax. | Since `charge_taxes_on_shipping` doesn't depend on the current `item`, maybe this could be executed outside of `item_tax` function e.g. at the top of the module? Now it would be called for each item in the feed and internally it makes a database query. We could have only one query for the entire feed. |
@@ -75,9 +75,8 @@ func (h *indexerHolder) get() Indexer {
}
var (
- issueIndexerChannel = make(chan *IndexerData, setting.Indexer.UpdateQueueLength)
// issueIndexerQueue queue of issue ids to be updated
- issueIndexerQueue Queue
+ issueIndexerQueue queue.Queue
holder = newIndexerHolder()
)
| [set->[Broadcast,Lock,Unlock],get->[RUnlock,Wait,RLock],Now,Info,Search,NewCond,Error,Init,set,IssueList,LoadDiscussComments,After,Since,RLocker,SearchRepositoryByName,IsChild,GetManager,get,GetIssueIDsByRepoID,Fatal,Issues,Run,Push] | InitIssueIndexer initializes the Indexer for issues. IssueIndexer creates a issue indexer for the given issue type. | Perhaps with these new queues + graceful we don't need the blocking option anymore? |
@@ -158,6 +158,12 @@ def add_parser(subparsers, _parent_parser):
default=False,
help="Pull cache for subdirectories of the specified directory.",
)
+ pull_parser.add_argument(
+ "--drop-index",
+ action="store_true",
+ default=False,
+ help="Drop local index for the... | [CmdDataFetch->[run->[check_up_to_date]],add_parser->[add_parser,shared_parent_parser],CmdDataPush->[run->[check_up_to_date]],CmdDataPull->[run->[check_up_to_date]]] | Adds a parser to subparsers to pull and push a specified block of cache. Adds command line options for pushing a bunch of cache entries to a remote repository. Adds command line options for fetching a specific block of cache. | Not sure about "specified remote" since sync commands don't always receive a -r arg. Maybe just remove the word "specified". Also, "drop index" may not mean anything to a casual user, should this be a little more descriptive? |
@@ -535,6 +535,7 @@ public abstract class
public abstract AppCommand loadServerHome();
// Build
+ public abstract AppCommand clearBuild();
public abstract AppCommand buildAll();
public abstract AppCommand devtoolsLoadAll();
public abstract AppCommand rebuildAll();
| [No CFG could be retrieved] | abstract AppCommand buildAll cleanAll rebuildSourcePackage cleanAll. | Should hide this command when Build pane is not available. Do this in `BuildCommands.java` in `setBuildCommandState()` in same branch that hides `activateBuild`. |
@@ -1083,13 +1083,11 @@ public class Http2MultiplexCodec extends Http2FrameCodec {
return;
}
try {
- // If we are current channelReadComplete(...) call we should just mark this Channel with a flush
- // pending. We will ensure ... | [Http2MultiplexCodec->[DefaultHttp2StreamChannel->[isActive->[isOpen],connect->[connect],write->[write],hashCode->[hashCode],eventLoop->[eventLoop],Http2ChannelUnsafe->[disconnect->[close],flush->[flush0],beginRead->[isActive,recvBufAllocHandle,config,closeForcibly,addChildChannelToReadPendingQueue,flush],recvBufAllocH... | Flush all the channels in the queue if it is not already flushing the channel. | This flush looks (pre-existingly) broken. We're currently in `Unsafe` and this calls flush on the child channel. Shouldn't we be flushing the parent channel instead? |
@@ -206,8 +206,6 @@ namespace System.ServiceModel.Syndication.Tests
public void Clone_NoExtensions_ReturnsExpected()
{
var category = new SyndicationCategory();
- SyndicationElementExtensionCollection elementExtensions = category.ElementExtensions;
-
SyndicationEle... | [SyndicationElementExtensionCollectionTests->[GetReaderAtElementExtensions_InvokeMultipleTimes_ReturnsNewReader->[NotSame,ElementExtensions,GetReaderAtElementExtensions],ItemSet_Get_ReturnsExpected->[Same,Add,ElementExtensions],ReadElementExtensions_NullSerializer_ThrowsArgumentNullException->[AssertExtensions,elementE... | Clone_NoExtensions_ReturnsExpected method. | Rather than not checking the original extention collection, should there be an assertion that this collection is not empty? |
@@ -3,6 +3,9 @@ using NUnit.Framework;
using Dynamo.Utilities;
using Dynamo.Models;
using System.Collections.Generic;
+using Dynamo.Nodes;
+using ProtoCore.Mirror;
+using Dynamo.Nodes;
namespace Dynamo.Tests
{
| [DynamoDefects->[Defect_MAGN_3256->[RunModel,AreEqual,Count,RunExpression,AssertPreviewValue,GetTestDirectory,Combine,Model],T01_Defect_MAGN_110->[Combine,RunModel,SelectivelyAssertPreviewValues,GetTestDirectory],Defect_MAGN_942_GreaterThanOrEqual->[Combine,RunModel,SelectivelyAssertPreviewValues,GetTestDirectory],Defe... | DynamoDefects test cases Defect_MAGN_942_GreaterThanOrEqual and Defect_MAG. | Remove this one or the one from line 6. |
@@ -26,9 +26,13 @@ public final class ErrorResponseUtil {
private ErrorResponseUtil() {
}
- public static Response generateResponse(final Exception e, final Response defaultResponse) {
+ public static Response generateResponse(
+ final Exception e,
+ final Response defaultResponse,
+ final Erro... | [ErrorResponseUtil->[generateResponse->[indexOfType,accessDeniedFromKafka]]] | Generates a response for the exception. | As above, let's move this method into `Errors` and ditch this class. |
@@ -35,6 +35,7 @@ export function BaseCarousel({
const childrenArray = toChildArray(children);
const {length} = childrenArray;
const [curSlide, setCurSlide] = useState(0);
+ const scrollRef = createRef();
const advance = (dir) => {
const container = scrollRef.current;
// Modify scrollLeft is pref... | [No CFG could be retrieved] | A base carousel that displays a single non - menu item. Displays the element. | Where is this ref used? And why is it `createRef` and not `useRef`? |
@@ -372,7 +372,7 @@ CMS_SignerInfo *CMS_add1_signer(CMS_ContentInfo *cms,
ESS_SIGNING_CERT_V2 *sc2 = NULL;
int add_sc;
- if (md == EVP_sha1() || md == NULL) {
+ if (md == NULL || EVP_MD_is_a(md, SN_sha1)) {
if ((sc = ossl_ess_signing_cert_new_init(signe... | [CMS_SignerInfo_cert_cmp->[ossl_cms_SignerIdentifier_cert_cmp],CMS_add1_signer->[ossl_cms_set1_SignerIdentifier],CMS_SignerInfo_get0_signer_id->[ossl_cms_SignerIdentifier_get0_signer_id],ossl_cms_SignedData_final->[CMS_get0_SignerInfos],int->[CMS_add_simple_smimecap],CMS_set1_signers_certs->[CMS_SignerInfo_cert_cmp,CMS... | Adds a signer to the CMS signed data. finds the first non - NULL object in the list of known digest algorithms and if not Adds standard smimecap and smimecap - list of standard smimecap - list if the SignerInfo is not in the list of SignerInfos it is added to the Signer. | Shouldn't EVP_MD_is_a() check if the passed method is NULL, and always return false in that case? |
@@ -176,9 +176,12 @@ namespace MonoGame.Tools.Pipeline
else
SetCursor(CursorType.Default);
+ // On windows craeting a dialog from double click will freeze
+ // the GUI thread until a click occurs so we need to call the
+ // dialog at the end of Paint even... | [PropertyGridTable->[Drawable_MouseLeave->[Drawable_MouseUp],Drawable_Paint->[Clear,DrawGroup,SetCursor],Clear->[Clear],AddEntry->[Color]]] | Draw the missing keyframe. | This sounds crazy... that never happens under regular C# WinForms or even C++ Win32 applications. Is this an Eto bug? |
@@ -1756,11 +1756,11 @@ function admin_page_plugins(App $a)
$idx = array_search($plugin, $a->plugins);
if ($idx !== false) {
unset($a->plugins[$idx]);
- uninstall_plugin($plugin);
+ Addon::uninstallPlugin($plugin);
info(t("Plugin %s disabled.", $plugin));
} else {
$a->plugins[] = $plugi... | [admin_page_users_post->[getMessage],admin_page_site_post->[set_baseurl,get_path],admin_page_site->[get_hostname,get_path],admin_page_users->[set_pager_itemspage,set_pager_total],admin_page_contactblock->[set_pager_itemspage,set_pager_total]] | admin_page_plugins - admin page plugins Administration of plugins Administration plugin administration. | Please rename `$plugin` to `$addon`. |
@@ -433,10 +433,11 @@ def no_binary():
def only_binary():
+ format_control = FormatControl(set(), set())
return Option(
"--only-binary", dest="format_control", action="callback",
- callback=_handle_only_binary, type="str",
- default=FormatControl(set(), set()),
+ callback=form... | [only_binary->[Option,set,FormatControl],_handle_only_binary->[getattr,fmt_ctl_handle_mutual_exclude],exists_action->[Option],trusted_host->[Option],extra_index_url->[Option],make_option_group->[add_option,option,OptionGroup],check_dist_restriction->[CommandError,any,set,FormatControl],constraints->[Option],prefer_bina... | A command line option that allows to filter packages that are not binary. | I don't think this method should be private anymore. |
@@ -425,6 +425,10 @@ func (node *Node) validateNodeMessage(ctx context.Context, payload []byte) (
utils.Logger().Debug().Uint64("receivedNum", block.NumberU64()).
Uint64("currentNum", curBeaconHeight).Msg("beacon block sync message rejected")
return nil, 0, errors.New("beacon block height smaller tha... | [AddPendingTransaction->[tryBroadcast,addPendingTransactions],ShutDown->[Blockchain,StopPubSub,Beaconchain],InitConsensusWithValidators->[Blockchain],addPendingTransactions->[Blockchain],StartPubSub->[validateNodeMessage,validateShardBoundMessage],GetAddresses->[populateSelfAddresses],AddPendingReceipts->[Blockchain],a... | validateNodeMessage validates a message payload and returns the payload and the type of the message. This function is called when a new message is received from the node. payload is the payload of the p2p node. | This is risky. If a node is lagging behind, it will reject all legit beacon block messages, potentially preventing a legit beacon block broadcast to the network. |
@@ -2,6 +2,7 @@ package aws
import (
"fmt"
+ "github.com/hashicorp/terraform/helper/acctest"
"os"
"testing"
| [ParallelTest,GetApp,Meta,Sprintf,TestCheckResourceAttr,RootModule,Setenv,ComposeTestCheckFunc,String,Errorf,Getenv] | TestAccAWSPinpointApp_basic tests if the given is valid. A helper function to create a new object. | Nit: Go imports should be formatted as stdlib imports, new line, third party imports with each section alphabetically sorted. Tooling like `goimports` can help do this automatically in editors. |
@@ -155,7 +155,7 @@ final class DocumentationNormalizer implements NormalizerInterface
if ($parameters = $this->getFiltersParameters($resourceClass, $operationName, $subResourceMetadata, $definitions, $serializerContext)) {
foreach ($parameters as $parameter) {
- ... | [DocumentationNormalizer->[getDefinitionSchema->[normalize],getFiltersParameters->[getType],getType->[getDefinition,getType]]] | Normalizes an object into a JSON - LD array. Compute the response document. | This regex really sucks, it doesn't allow array filters like `?foo[]=bar`, but this pattern is required by API Gateway on Swagger doc import |
@@ -153,7 +153,7 @@ class WPCOM_JSON_API_List_Posts_Endpoint extends WPCOM_JSON_API_Post_Endpoint {
'post_status' => $status,
'post_parent' => isset( $args['parent_id'] ) ? $args['parent_id'] : null,
'author' => isset( $args['author'] ) && 0 < $args['author'] ? $args['author'] : null,
- 's' ... | [WPCOM_JSON_API_List_Posts_Endpoint->[callback->[current_user_can_access_post_type,get_post_by,get_blog_id,is_post_type_allowed,_get_whitelisted_post_types,switch_to_blog_and_validate_user,query_args],handle_date_range->[prepare]]] | Callback for the post_list action. This function is used to query the posts in a post type. Query for posts that are not protected by the current user. This function is used to get all posts that are not in the tree and can be used This function is used to build a taxonomy query. | Not a blocker: could we just use `! empty()` rather than adding an operator? |
@@ -280,6 +280,9 @@ class Server:
result = mypy.build.build(sources=sources,
options=self.options,
alt_lib_path=self.alt_lib_path)
+ # build will clear use_fine_grained_cache if it needs to give up
+ # on do... | [process_start_options->[process_options,exit],Server->[check_default->[stats_summary,get_meminfo,build,append,get_stats,update,join,GcLogger],cmd_hang->[sleep],run_command->[getattr,method],check_fine_grained->[fine_grained_increment,initialize_fine_grained],cmd_status->[get_meminfo,update],cmd_check->[StringIO,create... | Initialize the fine - grained cache and manager. Returns a dict with out err and status. | Style nit: looks like it would be better to move this outside the try statement, since this can't generate a `CompileError` exception. |
@@ -7,6 +7,7 @@ import android.content.Intent;
import android.content.SharedPreferences;
import android.net.Uri;
+
import com.afollestad.materialdialogs.MaterialDialog;
import com.ichi2.anki.analytics.UsageAnalytics;
import com.ichi2.libanki.Utils;
| [Lookup->[lookUp->[replaceAll,startActivity,contentEquals,lookupLeo,show,getSimpleName,getLanguage,trim,parse,Intent,sendAnalyticsEvent,length,putExtra],getSearchStringTitle->[getStringArray,format,getString],lookupLeo->[ComponentName,startActivity,parse,Intent,setComponent,putExtra],initialize->[ComponentName,getShare... | Creates a lookup object. check if the intent is available in the dictionary. | Could you revert unnecessary changes to files |
@@ -4,7 +4,13 @@ from django.templatetags.static import static
from ..core.utils import build_absolute_uri
-def get_email_base_context():
- site = Site.objects.get_current()
+def get_email_bases():
+ site: Site = Site.objects.get_current()
logo_url = build_absolute_uri(static("images/logo-light.svg"))
-... | [get_email_base_context->[get_current,build_absolute_uri,static]] | Returns a base context for email generation. | Let's add a docstring here. |
@@ -172,6 +172,7 @@ class LROPoller(object):
"""
return self._polling_method.status()
+ @distributed_trace
def result(self, timeout=None):
# type: (Optional[int]) -> Model
"""Return the result of the long running operation, or
| [LROPoller->[status->[status],result->[resource],_start->[run],__init__->[finished,initialize]]] | Returns the current status of the long running operation or the result available after the specified timeout. | I thought wait was enough? |
@@ -45,7 +45,7 @@ class BasicPostSerializer < ApplicationSerializer
def ignored
return false unless SiteSetting.ignore_user_enabled?
- object.is_first_post? &&
+ (object.is_first_post? || reply_to_post_number.present?) &&
scope.current_user&.id != object.user_id &&
IgnoredUser.where(user_i... | [BasicPostSerializer->[username->[username],avatar_template->[avatar_template],name->[name]]] | Checks if a user is ignored by the user in the current post or if the user is. | This definitely needs a test |
@@ -320,6 +320,17 @@ class VatlayerPlugin(BasePlugin):
tax = taxes.get(rate_name) or taxes.get(DEFAULT_TAX_RATE_NAME)
return Decimal(tax["value"])
+ @classmethod
+ def validate_plugin_configuration(cls, plugin_configuration: "PluginConfiguration"):
+ """Validate if provided configuratio... | [VatlayerPlugin->[apply_taxes_to_product->[_initialize_plugin_configuration,_skip_plugin],get_tax_rate_type_choices->[_initialize_plugin_configuration],apply_taxes_to_shipping->[_initialize_plugin_configuration,_skip_plugin,_get_taxes_for_country],calculate_order_shipping->[_initialize_plugin_configuration,_skip_plugin... | Return tax rate percentage value for given product type in given country. | Same here about assigning the error to the `active` field. |
@@ -39,7 +39,7 @@ module GobiertoParticipation
end
def find_process_events
- @container_events = ::GobiertoCalendars::Event.events_in_collections_and_container(current_site, current_process)
+ @container_events = ::GobiertoCalendars::Event.events_in_collections_and_container_with_pending(c... | [EventsController->[set_events->[empty?,events_in_collections_and_container,sorted,filter_events_by_date,page,sorted_backwards],find_event->[find_by_slug!],find_issue->[find_by_slug!],filter_events_by_date->[parse,sorted_backwards,sorted,now,by_date],find_process_events->[sorted,events_in_collections_and_container],ind... | find_process_events - finds a in the current_process and all events. | Line is too long. [134/80] |
@@ -71,12 +71,13 @@ func resourceAwsGlueWorkflowCreate(d *schema.ResourceData, meta interface{}) err
func resourceAwsGlueWorkflowRead(d *schema.ResourceData, meta interface{}) error {
conn := meta.(*AWSClient).glueconn
+ ignoreTagsConfig := meta.(*AWSClient).IgnoreTagsConfig
input := &glue.GetWorkflowInput{
... | [GetWorkflow,Printf,StringMap,DeleteWorkflow,GetOk,CreateWorkflow,StringValueMap,Id,String,Errorf,UpdateWorkflow,SetId,Get,Set] | This function creates a new Glue Workflow with the given name and default run properties. This function is used to set the default_run_properties name description and name. | I think we prefer `%s` as the AWS SDK generates `.String()` methods. |
@@ -0,0 +1,18 @@
+// Copyright 2016-2017, Pulumi Corporation. All rights reserved.
+// +build windows
+
+package cmd
+
+import (
+ "fmt"
+
+ "github.com/bgentry/speakeasy"
+)
+
+func readConsoleNoEcho() (string, error) {
+ s, err := speakeasy.Ask("")
+
+ fmt.Println() // echo a newline, since the user's keypress did n... | [No CFG could be retrieved] | No Summary Found. | any chance that Speakeasy works everywhere? |
@@ -5,3 +5,15 @@ angular.module('<%=angularAppName%>')
return $resource('api/account/change_password', {}, {
});
});
+
+angular.module('jhipsterApp')
+ .factory('PasswordResetInit', function ($resource) {
+ return $resource('api/account/reset_password/init', {}, {
+ })
+ });
+... | [factory,function] | Change password of the user. | jhipsterApp should be <%=angularAppName%> Maybe you should consider just chaining the 3 calls to factory(). |
@@ -203,6 +203,9 @@ class ServiceBusMixin(object):
:type max_delivery_count: int
:param enable_batched_operations:
:type: enable_batched_operations: bool
+ :param fail_on_exist: Whether to throw an exception if there is already a subscription with same name
+ already existed.
+... | [BaseClient->[get_properties->[_get_entity]],ServiceBusMixin->[create_queue->[create_queue],create_subscription->[create_subscription],delete_subscription->[delete_subscription],delete_queue->[delete_queue],delete_topic->[delete_topic],create_topic->[create_topic]],SenderMixin->[queue_message->[queue_message]]] | Creates a subscription entity. Creates a subscription for the specified broker. | Grammer nit: "... exception if a subscription with the same name already exists" |
@@ -103,6 +103,10 @@ class NodeActivateCommand(PulpCliCommand):
strategy = kwargs[STRATEGY_OPTION.keyword]
delta = {'notes': {constants.NODE_NOTE_KEY: True, constants.STRATEGY_NOTE_KEY: strategy}}
+ if node_activated(self.context, consumer_id):
+ self.context.prompt.render_success_... | [NodeUnbindCommand->[run->[missing_resources]],NodeBindCommand->[run->[missing_resources]],BindingCommand->[missing_resources->[missing_resources]]] | Run the process of updating a missing node - wide . | No substitution done on ALREADY_ACTIVATED_NOTHING_DONE but one is required. The output will contain the %(n)s |
@@ -123,6 +123,7 @@ define([
*/
Tileset3DTileContent.prototype.applyDebugSettings = function(enabled, color) {
};
+
/**
* Part of the {@link Cesium3DTileContent} interface.
| [No CFG could be retrieved] | Provides a method to handle the creation of a Cesium3DTileContent object. Content of the page. | Remove empty line. |
@@ -651,6 +651,15 @@ func (h *UserHandler) CanLogout(ctx context.Context, sessionID int) (res keybase
})
if err != nil {
+ isRevoked, err2 := isActiveDeviceRevoked(libkb.NewMetaContext(ctx, h.G()))
+ if err2 == nil && isRevoked {
+ // We are revoked, green-light logging out.
+ h.G().Log.CDebugf(ctx, "CanLog... | [LoadUserPlusKeys->[LoadUserPlusKeys],CanLogout->[LoadHasRandomPw],loadPublicKeys->[LoadUser],LoadUser->[LoadUser],FindNextMerkleRootAfterRevoke->[FindNextMerkleRootAfterRevoke],LoadUserByName->[LoadUser],FindNextMerkleRootAfterReset->[FindNextMerkleRootAfterReset]] | CanLogout returns true if the user is logged in and has a passphrase set. | streamline error handling here and make it more go-y. don't have nested-if error conditions |
@@ -765,6 +765,7 @@ class Document(NotificationsMixin, ModelBase):
not self.defer_rendering):
# Attempt an immediate rendering.
self.render(cache_control, base_url)
+ render_done.send(sender=self)
else:
# Attempt to queue a rendering. If celery... | [Attachment->[attach->[save,DocumentAttachment],get_embed_html->[render],AttachmentManager],Document->[_move_tree->[_move_tree,save],get_json_data->[build_json_data],build_json_data->[get_summary],move->[_attr_for_redirect],_attr_for_redirect->[unique_attr->[_existing],unique_attr],get_descendants->[has_children,get_de... | Schedule rendering. | I think this signal is sent in the wrong spot - it should really be in the `render` method, since that's where the thing is actually being done. |
@@ -39,7 +39,7 @@ import static org.testng.Assert.assertTrue;
* @see AbstractTestDistributedQueries
*/
public abstract class AbstractTestIntegrationSmokeTest
- extends AbstractTestQueryFramework
+ extends AbstractTestQueries
{
/**
* Ensure the tests are run with {@link DistributedQueryRun... | [AbstractTestIntegrationSmokeTest->[ensureDistributedQueryRunner->[isGreaterThanOrEqualTo],testExplainAnalyze->[assertExplainAnalyze],testSelectAll->[assertQuery],testDescribeTable->[build,assertEquals,computeActual],testColumnsInReverseOrder->[assertQuery],testInListPredicate->[assertQuery,assertQueryReturnsEmptyResul... | abstract class for testing purposes SELECT SUM(price) FROM nation ORDER BY orderkey. | It is no longer smoke. `BaseIntegrationTest`? |
@@ -305,8 +305,8 @@ class TestReportedSSAIssues(SSABaseTest):
# We have to create a custom pipeline to force a SSA reconstruction
# and stripping.
from numba.core.compiler import CompilerBase, DefaultPassBuilder
- from numba.untyped_passes import ReconstructSSA, IRProcessing
- f... | [TestSSA->[test_argument_name_reused->[check_func],check_undefined_var->[check_func],test_sum_loop_2vars->[check_func],test_sum_2d_loop->[check_func],test_undefined_var->[check_undefined_var],test_if_else_redefine->[check_func],test_sum_loop->[check_func],test_phi_propagation->[check_func]],TestReportedSSAIssues->[test... | Issue 582 - 8. 5. 4. 5. 5. 5. 5. | This is not a revert, it fixes up an invalid import. |
@@ -56,7 +56,7 @@ public class PullQueryExecutorMetricsTest {
when(ksqlEngine.getServiceId()).thenReturn(KSQL_SERVICE_ID);
when(time.nanoseconds()).thenReturn(6000L);
- pullMetrics = new PullQueryExecutorMetrics(ksqlEngine.getServiceId(), CUSTOM_TAGS, time);
+ pullMetrics = new PullQueryExecutorMetr... | [PullQueryExecutorMetricsTest->[shouldRecordRequestRate->[assertThat,recordLatency,getMetricValue,closeTo],shouldRecordLatency->[is,assertThat,recordLatency,getMetricValue],shouldRemoveAllSensorsOnClose->[assertTrue,getSensor,size,nullValue,is,close,forEach,assertThat,name],getMetricValue->[toString,valueOf,getMetrics]... | This method initializes the metrics. | How is this time used if it's not injected in? I suspect the test won't pass. |
@@ -150,6 +150,13 @@ func (p *Provider) loadIngresses(k8sClient Client) (*types.Configuration, error)
continue
}
+ tlsConfigs, err := getTLSConfigurations(i, k8sClient)
+ if err != nil {
+ log.Errorf("Error configuring TLS for ingress %s/%s: %v", i.Namespace, i.Name, err)
+ continue
+ }
+ templateObjec... | [loadIngresses->[EqualFold,GetService,Itoa,Warn,GetIngresses,Contains,Warnf,getPriority,Replace,Errorf,GetEndpoints,TrimSpace,SplitAndTrimString],loadConfig->[Error,GetConfiguration],getPriority->[Errorf,Atoi],newK8sClient->[Sprintf,Getenv,Infof],Provide->[loadIngresses,NewTimer,OperationWithRecover,loadConfig,Go,DeepE... | loadIngresses loads all ingress configuration from Kubernetes This function creates the necessary objects for the template objects. Errorf - Error while retrieving service information This function returns a template object that can be used to render a template object. | Hmm, my IDE is telling me that this line is supposedly missing code coverage. Are we possibly missing a test to validate that we actually skip the Ingress if `getTLSConfigurations` returns an error? |
@@ -39,4 +39,9 @@ public abstract class AbstractBaseOptionsBuilder<BuilderType extends AbstractBas
{
return responseTimeout;
}
+
+ public boolean isOutbound()
+ {
+ return outbound;
+ }
}
| [No CFG could be retrieved] | get the response timeout. | Since this is part of the API we should try not to expose methods that are required to work with transports. |
@@ -43,6 +43,8 @@ import org.apache.gobblin.metastore.StateStore;
import com.google.common.io.Files;
+import static org.junit.Assert.*;
+
/**
* Unit tests for {@link FsDatasetStateStore}.
| [FsDatasetStateStoreTest->[testGetDatasetState->[getJobId,getState,getCompletedTasks,getStartTime,getDuration,getWorkingState,get,getTaskId,getJobName,getDatasetUrn,getId,assertEquals,getEndTime,getLatestDatasetState],testGetPreviousDatasetStatesByUrns->[getJobId,size,getState,getStartTime,getDuration,get,getJobName,ge... | Package private for unit testing. Sets up the state store. | Please use testng.Assert since all the tests are based of testng at the moment |
@@ -81,13 +81,15 @@ class Cli(object):
self._commands = {}
conan_commands_path = os.path.join(os.path.dirname(os.path.abspath(__file__)), "commands")
for module in pkgutil.iter_modules([conan_commands_path]):
- self._add_command("conans.cli.commands.{}".format(module.name), module.... | [Cli->[help_message->[commands],run->[help_message,_print_similar,run]],main->[run,Cli]] | Initialize the object with a conan object. | Is this a Py2.7 thing? If that is the case, I am happy with the check you did in the test to run the test only in Py3 |
@@ -119,10 +119,8 @@ feature 'View personal key' do
click_acknowledge_personal_key
expect_confirmation_modal_to_appear_with_first_code_field_in_focus
-
- press_tab
-
- expect_continue_button_to_be_in_focus
+ expected_button_order = %w[Continue Back]
+ expect(all(:button).map(&:text).... | [click_back_button->[t,click_on],press_shift_tab->[send_keys,find],expect_accordion_content_to_become_visible->[t,to,have_content,have_xpath],expect_continue_button_to_be_in_focus->[t,to,eq],expect_to_be_back_on_manage_personal_key_page_with_continue_button_in_focus->[t,to,eq,have_xpath],expect_accordion_content_to_be_... | expect_accordion_content_to_be_hidden_by_default - Requires that the user has the required key presses and then checks that the user has the. | For some reason, after pressing tab, Chrome didn't see that the continue button was in focus. What we want to test here is that on a mobile device, the continue button appears first, and on a desktop screen, it appears after the Back button. Iterating through all buttons will find them in order, so we check that instea... |
@@ -522,9 +522,10 @@ class MatrixTransport(Runnable):
raise RuntimeError(f"{self!r} already started")
self.log.debug("Matrix starting")
self._stop_event.clear()
- self._starting = True
self._raiden_service = raiden_service
- self._web_rtc_manager.node_address = self... | [populate_services_addresses->[update_services_addresses],_RetryQueue->[enqueue->[_expiration_generator,_MessageData],_check_and_send->[message_is_in_queue],_run->[_check_and_send],enqueue_unordered->[enqueue]],MatrixTransport->[_handle_web_rtc_messages->[_process_raiden_messages,ReceivedRaidenMessage],_send_with_retry... | Starts a single node - level lease. Check if a node in the network has a health check. | Dont you get a lint here for not initialized in __init__ ? |
@@ -346,13 +346,13 @@ class WPSEO_Frontend {
if ( ! is_string( $title ) || ( is_string( $title ) && $title === '' ) ) {
$title = get_bloginfo( 'name' );
$title = $this->add_paging_to_title( $sep, $seplocation, $title );
- $title = $this->add_to_title( $sep, $seplocation, $title, strip_tags( get_bloginfo( '... | [WPSEO_Frontend->[generate_title->[is_home_static_page,get_title_from_options,get_author_title,is_home_posts_page,get_default_title,get_content_title,get_taxonomy_title],show_closing_debug_mark->[head_product_name,show_debug_marker],generate_canonical->[is_posts_page],metakeywords->[is_posts_page,is_home_static_page,is... | Get the default title for the page. | I understand the logic to not strip new lines from the description, but as this is used to build up the `title`, it should strip any new lines. Line 577 also applies `wp_strip_all_tags` but as this method is public, doing it internally as well make sense. |
@@ -42,7 +42,7 @@ public class ValueMatcherColumnSelectorStrategyFactory
@Override
public ValueMatcherColumnSelectorStrategy makeColumnSelectorStrategy(
- ColumnCapabilities capabilities, ColumnValueSelector selector
+ ColumnCapabilities capabilities, ColumnValueSelector selector, int numRows
)
... | [ValueMatcherColumnSelectorStrategyFactory->[ValueMatcherColumnSelectorStrategyFactory]] | Creates a column selector strategy from a sequence of values. | Each param should be on a separate line (and several similar places below in the PR) |
@@ -111,9 +111,10 @@ public class JoinNode extends PlanNode implements JoiningNode {
Optional.empty()
);
- this.schema = buildJoinSchema(joinKey, left, right);
this.joinType = requireNonNull(joinType, "joinType");
this.joinKey = requireNonNull(joinKey, "joinKey");
+ this.schema = buildJo... | [JoinNode->[SourceJoinKey->[rewriteWith->[SourceJoinKey],of->[SourceJoinKey]],setKeyFormat->[setKeyFormat],validateColumns->[validateColumns],StreamToTableJoiner->[join->[getKeyColumnName,getRight,join,buildStream,buildTable,getLeft]],getPreferredKeyFormat->[getPreferredKeyFormat],SyntheticJoinKey->[getAllViableKeys->[... | Construct a JoinNode. Replies the preferred key format for the join. | nit: Why did you move this line? |
@@ -899,6 +899,18 @@ namespace System.Windows.Forms {
short Charset {get;set;}
}
+
+ [DllImport(ExternDll.Gdi32, ExactSpelling = true, CharSet = CharSet.Auto)]
+ [ResourceExposure(ResourceScope.None)]
+ public static extern bool RoundRect(HandleRef hDC, int left, int top, i... | [SafeNativeMethods->[ImageList_Destroy->[IntImageList_Destroy],DeleteObject->[IntDeleteObject],TrackMouseEvent->[_TrackMouseEvent]]] | Charset - Short Name. | Had you verified that we are not duplicating any pinvoke declarations, or is the clean up coming up next ? |
@@ -79,11 +79,6 @@ namespace Internal.JitInterface
table.Add(CorInfoIntrinsics.CORINFO_INTRINSIC_Array_Get, "Get", null, null);
table.Add(CorInfoIntrinsics.CORINFO_INTRINSIC_Array_Address, "Address", null, null);
table.Add(CorInfoIntrinsics.CORINFO_INTRINSIC_Array_Set, "Set", null... | [CorInfoImpl->[IntrinsicKey->[GetHashCode->[GetHashCode]],IntrinsicHashtable->[GetValueHashCode->[GetHashCode],CompareValueToValue->[Equals],CompareKeyToValue->[Equals],GetKeyHashCode->[GetHashCode],Add]]] | Initialize the IntrinsicHashtable. Get the table of correlated information if any. | I couldn't find `System.EETypePtr.EETypePtrOf`, `System.Object.MethodTableOf`, `System.Activator.DefaultConstructorOf` and `System.Activator.AllocatorOf` in the runtime repo. Is `CORINFO_INTRINSIC_GetRawHandle` entirely unused? |
@@ -29,6 +29,7 @@ import java.util.stream.Stream;
* <p>
* ReadOptimizedView - Lets queries run only on organized columnar data files at the expense of latency
* WriteOptimizedView - Lets queries run on columnar data as well as delta files (sequential) at the expense of query execution time
+ *
* @since 0.3.0
... | [No CFG could be retrieved] | This interface is used to view the table file system. Stream all the data files that have a specific in a given partition. | Not sure if all FileSystemView will share an interface.. Atleast in my head, FileSystemView => real time, read optimized , provide different operations.. for eg: ReadOptimized view does not offer groupLatestDataFileWithLogFiles at all |
@@ -333,6 +333,17 @@ class Qt(Package):
else:
config_args.append('-no-freetype')
+ if self.spec.variants['xcb'].value == 'spack':
+ config_args.extend([
+ '-system-xcb',
+ '-I{0}/xcb'.format(self.spec['xcb-util'].prefix.include)
+ ])
+
+... | [Qt->[install->[make],url_for_version->[str,Version,up_to],common_config_args->[append,format,extend,satisfies],build->[make],setup_dependent_build_environment->[set],setup_dependent_package->[join_path,Executable],setup_run_environment->[set],setup_build_environment->[set,format],patch->[repl->[group,get],str,filter_f... | Returns a list of common config arguments based on the current configuration. Add missing configuration options to the config_args list. Return a list of config arguments that can be passed to dbus - config. | What does this option do? Does it build against a vendored copy of xcb? We generally avoid that and only build against Spack packages to avoid different versions in the DAG. |
@@ -459,12 +459,6 @@ initialize_projection(struct dfuse_state *dfuse_state)
if (!fs_handle->fsh_da)
D_GOTO(err, 0);
- common_t.init = close_common_init;
- fs_handle->close_da = dfuse_da_register(&fs_handle->da,
- &common_t);
- if (!fs_handle->close_da)
- D_GOTO(err, 0);
-
entry_t.init = lookup_entry_... | [No CFG could be retrieved] | Register the directory handles and their associated data objects. Register the given file system handle with the DA. | rename this variable to entry (remove _t) same with common_t |
@@ -17,6 +17,8 @@ namespace System.Net.Http
#endif
interface IHttpHeadersHandler
{
+ void OnStaticIndexedHeader(int index);
+ void OnStaticIndexedHeader(int index, ReadOnlySpan<byte> value);
void OnHeader(ReadOnlySpan<byte> name, ReadOnlySpan<byte> value);
void OnHeadersComple... | [No CFG could be retrieved] | on headers complete. | Did @Tratcher chat with you about the issues with these added interface definitions? |
@@ -878,6 +878,7 @@ function createBaseAmpElementProto(win) {
this.implementation_.firstLayoutCompleted();
}
}, reason => {
+ this.loadingError_ = true;
this.toggleLoading_(false, /* cleanup */ true);
throw reason;
});
| [No CFG could be retrieved] | Assigns a callback to the element that will be called when the layout and associated loadings are Set a minimum delay in case the element loads very fast or if it leaves the viewport. | Why wasn't this effective? |
@@ -261,6 +261,8 @@ def analyze_type_type_member_access(name: str,
upper_bound = get_proper_type(typ.item.upper_bound)
if isinstance(upper_bound, Instance):
item = upper_bound
+ elif isinstance(upper_bound, TupleType):
+ item = upper_bound.partial_fallback
elif isin... | [analyze_none_member_access->[_analyze_member_access,builtin_type],analyze_union_member_access->[_analyze_member_access,copy_modified],type_object_type->[builtin_type],analyze_var->[analyze_descriptor_access,not_ready_callback],analyze_type_callable_member_access->[_analyze_member_access],MemberContext->[copy_modified-... | Analyze a type type member access. | I think it will be safer to use `tuple_fallback(upper_bound)` here. |
@@ -252,6 +252,11 @@ func (u *User) HomeLink() string {
return setting.AppSubURL + "/" + u.Name
}
+// HTMLURL returns the user or organization's full link.
+func (u *User) HTMLURL() string {
+ return setting.AppURL + u.Name
+}
+
// GenerateEmailActivateCode generates an activate code based on user information and... | [GenerateRandomAvatar->[CustomAvatarPath],NewGitSig->[getEmail],AvatarLink->[RelAvatarLink],RelAvatarLink->[CustomAvatarPath,GenerateRandomAvatar],GetOrganizationCount->[getOrganizationCount],APIFormat->[getEmail],DeleteAvatar->[CustomAvatarPath],UploadAvatar->[CustomAvatarPath],ValidatePassword->[EncodePasswd],Generat... | HomeLink returns the home link for the user. | Why not use `HomeLink()`? |
@@ -61,13 +61,17 @@ class Arrange:
# If a build volume was set, add the disallowed areas
if Arrange.build_volume:
- disallowed_areas = Arrange.build_volume.getDisallowedAreas()
+ disallowed_areas = Arrange.build_volume.getDisallowedAreasNoBrim()
for area in disallo... | [Arrange->[create->[Arrange],bestSpot->[checkShape]]] | Create a new arrange object. | Is there a reason for not simply altering the `getDisallowedAreas()` function? Seems not so intuitive to add a second method with almost the same name doing almost the same thing. |
@@ -50,8 +50,8 @@ class Voucher(models.Model):
code = models.CharField(max_length=12, unique=True, db_index=True)
usage_limit = models.PositiveIntegerField(null=True, blank=True)
used = models.PositiveIntegerField(default=0, editable=False)
- start_date = models.DateField(default=date.today)
- end_... | [Voucher->[get_discount_amount_for->[get_discount],validate_min_amount_spent->[NotApplicable]]] | Initialize a Voucher object. Additional fields for the Vouchers. | You should consider a different name. `start_date` was good when we operate on DateField. It can be misleading now |
@@ -405,9 +405,8 @@ public class DefaultEventBuilder implements Event.Builder {
}
/**
- * Invoked after deserialization. This is called when the marker interface
- * {@link DeserializationPostInitialisable} is used. This will get invoked after the object
- * has been deserialized passing in the ... | [DefaultEventBuilder->[EventImplementation->[transformMessageToString->[transformMessage,build],initAfterDeserialisation->[initAfterDeserialisation],getCorrelationId->[getCorrelationId],getSecurityContext->[getSecurityContext],getMessageAsString->[getMessageAsString,build],transformMessage->[transformMessage],writeObje... | This method is called after deserialization of the message. This method is called when a FlowConstruct is found in the MuleContext. | Shoudl open an issue to kill DeserializationPostInitialisable or at least move it to comp. |
@@ -297,7 +297,8 @@ const (
defaultMaxBalanceRetryPerLoop = uint64(10)
defaultMaxBalanceCountPerLoop = uint64(3)
defaultMaxTransferWaitCount = uint64(3)
- defaultMaxStoreDownDuration = uint64(60)
+ defaultMaxPeerDownDuration = 30 * time.Minute
+ defaultMaxStoreDownDuration = 60 * time.Second
)
func (... | [setBalanceConfig->[adjust],Parse->[Parse],adjust->[adjust],Parse] | adjust sets all fields to their default values. | the default peer down is 30m, but store down is 60s, too small? |
@@ -163,15 +163,15 @@ class AdminControllerTest extends SuluTestCase
$this->assertObjectHasAttribute('url', $overviewType->form);
$this->assertObjectHasAttribute('article', $overviewType->form);
$this->assertObjectHasAttribute('schema', $overviewType);
- $this->assertCount(1, (array) $... | [AdminControllerTest->[testPagesListMetadataAction->[createAuthenticatedClient,getContent,getResponse,assertHttpStatusCode,assertObjectHasAttribute,jsonRequest,assertEquals],testTeaserConfig->[createAuthenticatedClient,getContent,getResponse,assertHttpStatusCode,assertCount,jsonRequest,assertEquals],testPageExcerptForm... | Test pages form metadata action. Count of all elements in an overview type. Checks if all properties of the ContentOptions are equal. | Why are these changes necessary? |
@@ -165,14 +165,15 @@ WbSimulationWorld::~WbSimulationWorld() {
void WbSimulationWorld::step() {
WbPerformanceLog *log = WbPerformanceLog::instance();
- if (log)
+ if (log) {
log->stepChanged();
+ log->lapTime(WbPerformanceLog::SPEED_FACTOR);
+ }
const double timeStep = basicTimeStep();
if (W... | [No CFG could be retrieved] | This is a private method that is called by the network layer when it is about to delete This function is called from the start of the sleep loop. | Why not merging `lapTime` and `stepChanged` functions? |
@@ -522,7 +522,7 @@ namespace Microsoft.Xna.Framework
/// <returns>Hash code of this <see cref="Vector3"/>.</returns>
public override int GetHashCode()
{
- return (int)(this.X + this.Y + this.Z);
+ return X.GetHashCode() + Y.GetHashCode() + Z.GetHashCode();
}
... | [Vector3->[Max->[Max],Length->[DistanceSquared],CatmullRom->[CatmullRom],SmoothStep->[SmoothStep],Transform->[Length],Hermite->[Hermite],Lerp->[Lerp],Barycentric->[Barycentric],Clamp->[Clamp],TransformNormal->[Length],Normalize->[Distance,Normalize],Min->[Min],ToString->[ToString],LengthSquared->[DistanceSquared]]] | Get hashCode. | Is this shown to be a better hashcode generation? |
@@ -132,7 +132,7 @@ EOT
{
// Open file in editor
if ($input->getOption('editor')) {
- $editor = getenv('EDITOR');
+ $editor = escapeshellcmd(getenv('EDITOR'));
if (!$editor) {
if (defined('PHP_WINDOWS_VERSION_BUILD')) {
$edi... | [ConfigCommand->[listConfiguration->[listConfiguration]]] | Executes the command Get the configuration array from the user input and set it if it is not set. Add a configuration value to the configuration source. This method is used to add a configuration value to the config source. | this check for `false` for the env variable needs to be done **before** escaping |
@@ -122,7 +122,14 @@ class UserInactiveError(SuperdeskApiError):
"""User is inactive, access restricted"""
status_code = 403
payload = {'is_active': False}
- message = 'Account suspended, access restricted.'
+ message = 'Account is inactive, access restricted.'
+
+
+class UserDisabledError(Superdes... | [SuperdeskIngestError->[__init__->[update_notifiers]],SuperdeskApiError->[preconditionFailedError->[SuperdeskApiError],badRequestError->[SuperdeskApiError],forbiddenError->[SuperdeskApiError],notFoundError->[SuperdeskApiError],__init__->[__init__],internalError->[SuperdeskApiError],unauthorizedError->[SuperdeskApiError... | Create a class method for handling errors related to a unique id. Exception class for HTTP 412. | Errors specific to endpoints should be defined in their corresponding package. Now if you remove ingest for example the errors are still there. |
@@ -267,6 +267,7 @@ $@"{nameof(GetClassFactoryForTypeInternal)} arguments:
{
var cxt = ComActivationContext.Create(ref cxtInt);
object cf = GetClassFactoryForType(cxt);
+ Debug.Assert(OperatingSystem.IsWindows());
IntPtr nativeIUnknown = Mar... | [LicenseInteropProxy->[GetLicInfo->[CreateInstance]],ComActivator->[LicenseClassFactory->[RequestLicKey->[RequestLicKey],CreateInstanceInner->[CreateAggregatedObject],GetLicInfo->[GetLicInfo]],GetClassFactoryForTypeInternal->[GetClassFactoryForType],Type->[IsLoggingEnabled,Log],BasicClassFactory->[CreateInstance->[Crea... | Gets the class factory for the given object. | Since this is COM - would it be more appropriate to mark this whole class as only supported on Windows? |
@@ -1349,10 +1349,10 @@ public class KafkaIndexTask extends AbstractTask implements ChatHandler
private Map<String, Object> getTaskCompletionRowStats()
{
Map<String, Object> metrics = Maps.newHashMap();
- if (metricsGetter != null) {
+ if (rowIngestionMeters != null) {
metrics.put(
"b... | [KafkaIndexTask->[assignPartitionsAndSeekToNext->[get,assignPartitions],SequenceMetadata->[canHandle->[isOpen,get],updateAssignments->[get],getSentinelSequenceMetadata->[SequenceMetadata],getPublisher->[toString,get,getStartOffsets]],withinMinMaxRecordTime->[get],getEndOffsetsHTTP->[authorizationCheck],pauseHTTP->[auth... | get the task completion row stats for a given . | the fact that there are some null checks but not others, and I'm not entirely clear if the `rowIngestionMeters` can be accessed in multiple threads, leads me to suggest that the `rowIngestionMeters` be created as `final` in the constructor and accessed everywhere. Is the overhead small enough to where that shouldn't be... |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.