patch stringlengths 18 160k | callgraph stringlengths 4 179k | summary stringlengths 4 947 | msg stringlengths 6 3.42k |
|---|---|---|---|
@@ -108,10 +108,10 @@ func (n *Node) IsUbuntu() bool {
return false
}
-// IsInProfile determines if this node is running on a vm with auditd enabled
-func (n *Node) IsInProfile(profiles []string) bool {
- for _, profile := range profiles {
- if strings.Contains(strings.ToLower(n.Metadata.Name), profile) {
+// Has... | [IsInProfile->[ToLower,Contains],IsUbuntu->[ToLower,IsLinux,Contains],Printf,CombinedOutput,PrintCommand,MatchString,WithTimeout,Split,IsReady,Background,FindStringSubmatch,Unmarshal,Compile,String,Errorf,Sleep,Done,Command] | IsUbuntu returns true if the node is on a ubuntu machine. | Renamed this helper method to more generally express what it actually does |
@@ -305,5 +305,13 @@ define([
return entity;
};
+ EntityCollection.prototype._onEntityDefinitionChanged = function(entity) {
+ var id = entity.id;
+ if (!defined(this._addedEntities.get(id))) {
+ this._changedEntities.set(id, entity);
+ }
+ fireChangedEvent(this... | [No CFG could be retrieved] | Returns the entity or EntityCollection. | This should use `contains`, I think. |
@@ -46,4 +46,18 @@ public interface PValue extends POutput, PInput {
*/
@Deprecated
List<TaggedPValue> expand();
+
+ /**
+ * After building, finalizes this {@code PInput} to make it ready for being used as an input to a
+ * {@link org.apache.beam.sdk.transforms.PTransform}.
+ *
+ * <p>Automatically i... | [No CFG could be retrieved] | Expand the list of tags that are not in the list. | `this {@link PValue}` |
@@ -1398,7 +1398,7 @@ class CertificateRevoke(AuthenticatedResource):
self.reqparse = reqparse.RequestParser()
super(CertificateRevoke, self).__init__()
- @validate_schema(None, None)
+ @validate_schema(certificate_revoke_schema, None)
def put(self, certificate_id, data=None):
""... | [CertificatesReplacementsList->[get->[get]],Certificates->[put->[get],post->[get],delete->[get],get->[get]],CertificateRevoke->[put->[get]],CertificateExport->[post->[get]],CertificatesUpload->[post->[get]],CertificatePrivateKey->[get->[get]]] | Initialize the certificate revoke action. Get certificate id. | should we update the expected input, in terms of `crl_reason`? |
@@ -158,7 +158,7 @@ class LobbyGamePanel extends JPanel {
return;
}
// we sort the table, so get the correct index
- final GameDescription description = gameTableModel.get(selectedIndex);
+ final GameDescription description = gameTableModel.get(gameTable.convertRowIndexToModel(selectedIndex));
... | [LobbyGamePanel->[bootPlayerInHeadlessHostBot->[getLobbyWatcherNodeForTableRow,md5Crypt],isAdmin->[isAdmin],joinGame->[joinGame],hostGame->[hostGame],mutePlayerInHeadlessHostBot->[getLobbyWatcherNodeForTableRow,md5Crypt],shutDownHeadlessHostBot->[getLobbyWatcherNodeForTableRow,shutDownHeadlessHostBot,md5Crypt],stopGame... | Mouse on games list. | This seems like a good candidate for an Extract Method refactoring to avoid accidentally re-introducing this problem in the future. |
@@ -45,7 +45,15 @@ const LockupConfirm = props => {
return (
<div className="text-center p-5 text-muted">
<h1>
- An error occurred confirming your token lockup, has the token expired?
+ An error occurred confirming your token lockup. Please try again or{' '}
+ <a
+ href="mai... | [No CFG could be retrieved] | Displays a hidden hidden hidden hidden hidden hidden hidden hidden hidden hidden hidden hidden hidden hidden hidden hidden. | 99% of the time this will be an expiry, you sure we don't want to mention something about expiry? |
@@ -6,6 +6,16 @@ class Auth::GithubAuthenticator < Auth::Authenticator
"github"
end
+ def enabled?
+ SiteSetting.enable_github_logins
+ end
+
+ def description_for_user(user)
+ info = GithubUserInfo.find_by(user_id: user.id)
+ return nil if info.nil?
+ info.screen_name || ""
+ end
+
class G... | [after_authenticate->[email,create,new,name,failed_reason,t,username,extra_data,user,unshift,present?,each,escape_html,id,detect,retrieve_avatar,find_by_email,find_by,valid?,email_valid,failed],register_middleware->[github_client_id,options,lambda,provider,github_client_secret],GithubEmailChecker->[initialize->[downcas... | name - name . | Are we able to return a blank string here instead? `info&.screen_name ? info.screen_name : ""` |
@@ -117,7 +117,12 @@ def run(argv=None):
if query_result['counters']:
empty_lines_counter = query_result['counters'][0]
logging.info('number of empty lines: %d', empty_lines_counter.committed)
- # TODO(pabloem)(BEAM-1366): Add querying of MEAN metrics.
+
+ word_lengths_filter = MetricsFilter().... | [WordExtractingDoFn->[process->[findall,inc,update,len,strip],__init__->[distribution,super,counter]],run->[WordcountOptions->[_add_argparse_args->[add_value_provider_argument]],hasattr,metrics,PipelineOptions,view_as,ReadFromText,info,sum,GroupByKey,wait_until_finish,run,MetricsFilter,ParDo,WriteToText,Map,Pipeline],g... | Entry point for the wordcount pipeline. No need to do this if we re doing a job creation or a runner. | Should it be an error if a certain type of metrics is expected but not available? |
@@ -14,4 +14,17 @@
# See the License for the specific language governing permissions and
# limitations under the License.
+"""Beam DataFrame API
+
+- For high-level documentation see
+ https://beam.apache.org/documentation/dsls/dataframes/overview/
+- :mod:`apache_beam.dataframe.io`: DataFrame I/Os
+- :mod:`apache... | [No CFG could be retrieved] | This function is used to allow non - parallel operations in a DataFrame. | "Embed DataFrame operations in a Beam pipeline." -> "DataFrame operations for use in a Beam pipeline." |
@@ -61,7 +61,7 @@ public class RemoteFileTemplate<F> implements RemoteFileOperations<F>, Initializ
/**
* the {@link SessionFactory} for acquiring remote file Sessions.
*/
- protected final SessionFactory<F> sessionFactory;
+ protected SessionFactory<F> sessionFactory;
private volatile String temporaryFileSu... | [RemoteFileTemplate->[afterPropertiesSet->[setBeanFactory],sendFileToRemoteDirectory->[exists,append,rename],append->[append],remove->[doInSession->[remove]],get->[get],execute->[doInSession],payloadToInputStream->[exists],send->[send],rename->[doInSessionWithoutResult->[rename]]]] | Creates a new remote file template. Returns a new instance of the class that will be used to create the class. | Should remain `final`, the same for the `SessionFactoryResolver`: or one of another. Of course, the opposite one should be `null` from consturctors. |
@@ -103,7 +103,15 @@ void plan_arc(
mm_of_travel = linear_travel ? HYPOT(flat_mm, linear_travel) : ABS(flat_mm);
if (mm_of_travel < 0.001f) return;
- uint16_t segments = FLOOR(mm_of_travel / (MM_PER_ARC_SEGMENT));
+ const feedRate_t scaled_fr_mm_s = MMS_SCALED(feedrate_mm_s);
+
+ #ifdef ARC_SEGME... | [No CFG could be retrieved] | region Header Functions Small angle approximation may be used to reduce computation overhead further. Small angle approximation may be. | Usage of private-styled macro _RECIP from another module. I have compilation fail here: `Compiling .pio\build\LPC1768\src\src\gcode\motion\G2_G3.cpp.o Marlin\src\gcode\motion\G2_G3.cpp: In function 'void plan_arc(const xyze_pos_t&, const ab_float_t&, uint8_t)': Marlin\src\gcode\motion\G2_G3.cpp:109:41: error: '_RECIP' ... |
@@ -96,12 +96,12 @@ func (op TestOp) RunWithContext(
_, res := op(info, ctx, opts, dryRun)
contract.IgnoreClose(journal)
- if dryRun {
- return nil, res
- }
if validate != nil {
res = validate(project, target, journal.Entries(), firedEvents, res)
}
+ if dryRun {
+ return nil, res
+ }
snap := journal.... | [NewProviderURN->[NewURN],GetTarget->[getNames],Run->[GetProject,Run,GetTarget],NewURN->[NewURN,getNames],GetProject->[getNames]] | RunWithContext runs the test operation with the given context. | Do we need to check `res`? We didn't before, but it seems like we should. |
@@ -210,6 +210,17 @@ func (cfg PeriodConfig) validate() error {
return errInvalidTablePeriod
}
+ switch cfg.Schema {
+ case "v1", "v2", "v3", "v4", "v5", "v6", "v9":
+ case "v10", "v11":
+ if cfg.RowShards == 0 {
+ return fmt.Errorf("Must have row_shards > 0 (current: %d) for schema (%s)", cfg.RowShards, cfg.... | [validate->[CreateSchema,createBucketsFunc],Load->[loadFromFile,Validate]] | validate validates the PeriodConfig. | Even if I guess it doesn't cause any harm, to avoid any misunderstanding/misconfiguration from the user side, shouldn't we ensure the `cfg.RowShards` for these schemas is `0`? Am I missing anything? |
@@ -15,7 +15,8 @@
// specific language governing permissions and limitations
// under the License.
-// +build integration windows
+// +build integration
+// +build windows
package perfmon
| [ReportingFetchV2Error,CollectData,False,Close,StandardizeEvent,Error,Cause,GetFormattedCounterValues,WriteEventToDataJSON,AddCounter,GetValue,Len,NotEqual,EqualValues,HasKey,Equal,Contains,NoError,Log,NewReportingMetricSetV2Error,Read,NotZero,GetCounterPaths,Fatal,Open,Sleep,True] | TestData tests a given object. returns a list of all processes that have an ID. | Without this change this integration test was being run on Linux. Multiple build tags on the same line are combined with a logical OR whereas multiple build tags on different lines are combined with an "AND". We want the latter effect for this test. |
@@ -31,7 +31,7 @@ class SearchIndexer
end
# for user login and name use "simple" lowercase stemmer
- stemmer = table == "user" ? "simple" : Search.long_locale
+ stemmer = table == "user" ? "simple" : Search.ts_config
# Would be nice to use AR here but not sure how to execut Postgres functions
... | [SearchIndexer->[update_users_index->[update_index],update_categories_index->[update_index],index->[update_users_index,update_categories_index,update_topics_index,update_posts_index],update_topics_index->[update_index,scrub_html_for_search],update_posts_index->[update_index,scrub_html_for_search]]] | update_index updates the index with raw_data and id if it exists. | hmm why was this change to use ts_config? I guess long_local may not even be available in pg? |
@@ -779,10 +779,12 @@ public class TestOzoneManagerHA {
OzoneManager ozoneManager = cluster.getOzoneManager(i);
String omHostName = ozoneManager.getOmRpcServerAddr().getHostName();
int rpcPort = ozoneManager.getOmRpcServerAddr().getPort();
+ // Test can pass without this line below
+ conf... | [TestOzoneManagerHA->[testRemovePrefixAcl->[setupBucket],testFileOperationsWithNonRecursive->[setupBucket],initiateMultipartUpload->[initiateMultipartUpload],testSetKeyAcl->[setupBucket],createKey->[createKey],testListParts->[setupBucket,initiateMultipartUpload],shutdown->[shutdown],testRemoveKeyAcl->[setupBucket],test... | This test test tests whether a read request from any proxy should be made to the current leader. | Since this line is redundant now, can we remove it? |
@@ -149,6 +149,8 @@ _FFI.cdef(
ExecutionStat execution_execute(RawScheduler*);
RawNodes* execution_roots(RawScheduler*);
+ void run_validator(RawScheduler*, TypeId*, uint64_t);
+
void nodes_destroy(RawNodes*);
'''
)
| [Native->[buffer->[buffer],new->[new],Factory->[register_options->[_default_native_engine_version],create->[Native,create]],gc->[gc],unpack->[unpack],new_scheduler->[to_key,gc,TypeConstraint,to_id]],extern_store_list->[merged],ExternContext->[vals_buf->[_resize_keys],from_key->[get],from_id->[get],to_id->[put],to_value... | Scheduler destroy method. Get a Value object from a key. | Naming nit... the methods are mostly namespaced. So maybe `validator_run`. |
@@ -22,3 +22,11 @@ class PriceRangeWidget(RangeWidget):
class PhonePrefixWidget(StorefrontPhonePrefixWidget):
template_name = 'dashboard/order/widget/phone_prefix_widget.html'
+
+
+class RichTextEditorWidget(Textarea):
+ def __init__(self, attrs=None):
+ default_attrs = {'class': 'rich-text-editor'}
+... | [DateRangeWidget->[__init__->[super]],PriceRangeWidget->[__init__->[getattr,super,PriceInput]]] | This class shows the phone prefix widget. | Python 3 syntax would be: `super().___init__(default_attrs)`. |
@@ -99,6 +99,10 @@ public class NotebookRestApi {
"Allowed owners: " + allowed.toString() + "\n\n" +
"User belongs to: " + current.toString();
}
+
+ String userNamePermissionError(String userName) throws IOException {
+ return "User： " + userName + " not Exists，Please Check ！";
+ }
... | [NotebookRestApi->[insertParagraph->[insertParagraph],runParagraph->[getParagraph],deleteParagraph->[getParagraph],getParagraph->[getParagraph],cloneNote->[cloneNote],stopParagraph->[getParagraph],createNote->[createNote],moveParagraph->[getParagraph,moveParagraph]]] | This method is used to change permissions of a note. | why do we need a separate method here? |
@@ -71,7 +71,7 @@ class _BearerTokenCredentialPolicyBase(object):
return not self._token or self._token.expires_on - time.time() < 300
-class BearerTokenCredentialPolicy(_BearerTokenCredentialPolicyBase, SansIOHTTPPolicy):
+class BearerTokenCredentialPolicy(_BearerTokenCredentialPolicyBase, SansIOHTTPPolic... | [BearerTokenCredentialPolicy->[on_request->[_update_headers,_enforce_https]]] | Adds a bearer token to the HTTP request headers. Adds a key header for the provided credential. | Then the pipeline will call on_request or send or both? Do we have a design for this scenario? @annatisch |
@@ -821,8 +821,11 @@ namespace Microsoft.Extensions.DependencyInjection.Tests
serviceCollection.AddScoped<IFakeMultipleService, FakeMultipleServiceWithIEnumerableDependency>();
serviceCollection.AddScoped<IFakeService, FakeService>();
}
+ var serviceProvider = C... | [ServiceProviderContainerTests->[ProviderDisposeThrowsWhenOnlyDisposeAsyncImplemented->[Dispose],ProviderAsyncScopeDisposeThrowsWhenOnlyDisposeAsyncImplemented->[Dispose],DisposeServiceProviderInCtorDisposable->[Dispose->[Dispose],Dispose],ProviderDisposePrefersServiceDispose->[Dispose],ProviderScopeDisposeThrowsWhenOn... | This method is used to test if a service is scoped and there is a service in the. | Should we make this assert stronger and assert how many there are? |
@@ -229,6 +229,7 @@ class ThreeMFWorkspaceReader(WorkspaceReader):
# Read definition containers
#
machine_definition_id = None
+ updatable_machines = []
machine_definition_container_count = 0
extruder_definition_container_count = 0
definition_container_files ... | [ThreeMFWorkspaceReader->[read->[getNewId,read],_applyChangesToMachine->[_applyMaterials,_applyDefinitionChanges,_applyUserChanges,_applyVariants,_clearStack],preRead->[MachineInfo,_clearState,ContainerInfo,preRead,QualityChangesInfo,_determineGlobalAndExtruderStackFiles,ExtruderInfo],_processQualityChanges->[Container... | Read some info so we can make decisions. Deserialize a single missing - container or definition - container. Check if any non - readonly materials can be in conflict. Load the container info and add it to the self. | I think you should rename this to updatable_machine_names (since the list doesn't actually contain machines). Also, it's missing typing. |
@@ -28,7 +28,7 @@ ul#strengthBar {
vertical-align: 2px;
}
-.point:last {
+.point:last-child {
margin: 0 !important;
}
.point {
| [No CFG could be retrieved] | Private functions - Section 12. 2. 2. 4. 4. | missing for app.scss.ejs, password-strength-bar.css.ejs and password-strength-bar.scss.ejs |
@@ -25,7 +25,8 @@ type bootstrapSelectProvider struct {
func (b *bootstrapSelectProvider) SelectAuthentication(providers []api.ProviderInfo, w http.ResponseWriter, req *http.Request) (*api.ProviderInfo, bool, error) {
// this should never happen but let us not panic the server in case we screwed up
- if len(provid... | [SelectAuthentication->[SelectAuthentication,HashAndUID],Secrets] | SelectAuthentication is a wrapper around the delegate SelectAuthentication method. | I don't understand the one provider case. Can't the one provider be the BootstrapUser provider, in which case we'd want to validate the secret? |
@@ -121,6 +121,10 @@ public class AggregatorUtil
public static final byte MOMENTS_SKETCH_BUILD_CACHE_TYPE_ID = 0x36;
public static final byte MOMENTS_SKETCH_MERGE_CACHE_TYPE_ID = 0x37;
+ // Datasketches Quantiles sketch aggregator (part 2)
+ public static final byte QUANTILES_DOUBLES_SKETCH_TO_RANK_CACHE_TYPE... | [AggregatorUtil->[makeColumnValueSelectorWithDoubleDefault->[ExpressionDoubleColumnSelector],makeColumnValueSelectorWithLongDefault->[ExpressionLongColumnSelector],makeColumnValueSelectorWithFloatDefault->[ExpressionFloatColumnSelector],condensedAggregators->[pruneDependentPostAgg]]] | This method returns a list of postAggregators that should be pruned after the given postAggregator This method is called from the postAggregatorList in reverse order to find the last calculated aggregate. | Although some of the other sketch postaggs have IDs here, the postagg IDs should really go in `PostAggregatorIds` |
@@ -136,7 +136,7 @@ class Metrics(object):
self.metrics['cnt'] = 0
self.metrics['correct'] = 0
self.metrics['f1'] = 0.0
- self.custom_metrics = ['mean_rank', 'loss']
+ self.custom_metrics = []
for k in self.custom_metrics:
self.metrics[k] = 0.0
... | [_exact_match->[_normalize_answer],Metrics->[update_ranking_metrics->[_lock,_normalize_answer],clear->[_lock],update->[_exact_match,_f1_score,_lock,update_ranking_metrics]],_f1_score->[_score,_normalize_answer],_normalize_answer->[lower->[lower],white_space_fix,remove_articles,remove_punc,lower]] | Initialize the object with the default metrics. | i thought we needed these here for hogwild to work ? @alexholdenmiller |
@@ -102,7 +102,13 @@ public class JoinNode extends PlanNode {
for (final Field field : rightSchema.valueSchema().fields()) {
schemaBuilder.field(field.name(), field.schema());
}
- return LogicalSchema.of(schemaBuilder.build());
+
+ final ConnectSchema keySchema = left.getSchema().withoutAlias().k... | [JoinNode->[StreamToTableJoiner->[join->[getRight,getKeyField,getJoinedKeyField,getSerDeForSource,join,buildStream,buildTable,getLeft]],TableToTableJoiner->[join->[getRight,getOuterJoinedKeyField,getKeyField,getJoinedKeyField,join,buildTable,getLeft]],ensureMatchingPartitionCounts->[getPartitions],StreamToStreamJoiner-... | Build the schema for the left and right nodes. | The key for the join may not be the same as the key for the left hand side if the left hand side key is not the same as the join key. KSQL will repartition the left side stream with a new key and this key will be the key for the result of the join. |
@@ -418,7 +418,7 @@ public class ReferenceConfig<T> extends AbstractReferenceConfig {
throw new IllegalStateException("Failed to check the status of the service " + interfaceName + ". No provider available for the service " + (group == null ? "" : group + "/") + interfaceName + (version == null ? "" : ":" ... | [ReferenceConfig->[destroy->[destroy],finalize->[finalize],createProxy->[get],get->[checkAndUpdateSubConfigs],setInterface->[setInterface]]] | Creates a new instance of the class with a reference to the given interface class. This method is called when a service is not available. Create a new instance of the NagiosNode class. | Here 'dubbo' doesn't mean protocol but 'dubbo service'. Since protocol is in url, I don't think it is necessary to emphasis it. |
@@ -131,13 +131,12 @@ public class Decks extends DeckManager {
+ "\"minInt\": 1,"
+ "\"leechFails\": 8,"
// type 0=suspend, 1=tagonly
- + "\"leechAction\": " + Consts.LEECH_SUSPEND
+ + "\"leechAction\": " + Consts.LEECH... | [Decks->[NameMap->[get->[get],remove->[get,remove],constructor->[NameMap]],parents->[get,parentsNames,add],id->[id,id_for_name,usable_name],_recoverOrphans->[allIds],_ensureParentsNotFiltered->[id_safe,get,path],get->[get],byName->[get],gather->[gather,add],rename->[all,save,remove,add,byName],newDyn->[id,select],updat... | A configuration that is used to configure a single node. A class that quickly caches all names in a deck. | I think a lot of users will like this. Being opinionated is fine in some cases but since the rest of the system is more flexible and less opinionated, users were surprised when a card just went away on leech, lots of support queries on that. |
@@ -34,12 +34,17 @@ with this program; if not, write to the Free Software Foundation, Inc.,
// The maximum number of identical world names allowed
#define MAX_WORLD_NAMES 100
+namespace
+{
+
bool getGameMinetestConfig(const std::string &game_path, Settings &conf)
{
std::string conf_path = game_path + DIR_DELIM ... | [No CFG could be retrieved] | This program is used to determine if a specific node is a node in a game. Find a subgame by its id. | also if you're touching this anyway can you make the function static? it's only used inside subgames.cpp yet global and also defined in the `.h` |
@@ -191,6 +191,7 @@ class Dealii(CMakePackage, CudaPackage):
cxx_flags = []
lapack_blas = spec['lapack'].libs + spec['blas'].libs
+ lapack_blas_headers = spec['lapack'].headers + spec['blas'].headers
options.extend([
'-DDEAL_II_COMPONENT_EXAMPLES=ON',
'-DDEA... | [Dealii->[setup_environment->[set],cmake_args->[upper,satisfies,append,spec,joined,extend,len,format,join,InstallError],depends_on,conflicts,format,version,patch,variant]] | Return a list of arguments for CMake. Options for the . Add flags cuda_arch and cuda_arch to the list of options. add flags to options list Returns a list of options for the object. | Can you rename this variable to `lapack_blas_libs`? |
@@ -83,7 +83,7 @@ class Grouping < ApplicationRecord
has_many :grouping_starter_file_entries, dependent: :destroy
has_many :starter_file_entries, through: :grouping_starter_file_entries
-
+ validate :test_student_grouping_member, if: -> { !self.id.nil? && self.test_students.exists? }
# Assigns a random TA f... | [Grouping->[deletable_by?->[is_valid?],test_runs_instructors->[pluck_test_runs,group_hash_list,filter_test_runs],has_files_in_submission?->[has_submission?],due_date->[due_date],has_non_empty_submission?->[has_submission?],test_runs_students_simple->[filter_test_runs],remove_member->[membership_status],remove_rejected-... | Assign TAs to a list of random groupings and return the last missing TA. | use `new_record?` instead of checking for nil. also, can we do this validation without having a `test_students` association please. also, this validation should be doable even if we have a new record |
@@ -23,6 +23,10 @@ const PARSER_IGNORE_FLAG = '`';
/** @private @const {string} */
const TAG = 'Expander';
+/** A whitelist for replacements whose values should not be %-encoded. */
+/** @const {Object<string, boolean>} */
+export const NOENCODE_WHITELIST = {'ANCESTOR_ORIGIN': true};
+
/** Rudamentary parser to ha... | [No CFG could be retrieved] | A parser that expands a URL into a named variable. Collect all the variables in the given url. | Add a TODO. Let's fix during FixIt. |
@@ -102,10 +102,10 @@ namespace Microsoft.Extensions.Primitives
}
}
- private static void OnChange(object state)
+ private static void OnChange(object? state)
{
- var compositeChangeTokenState = (CompositeChangeToken)state;
- if (compositeChangeTokenS... | [CompositeChangeToken->[OnChange->[Count,Dispose,_callbackLock,Cancel,Assert,_cancellationTokenSource,_disposables],EnsureCallbacksInitialized->[ActiveChangeCallbacks,RegisterChangeCallback,Count,Add],IDisposable->[Register,EnsureCallbacksInitialized],ActiveChangeCallbacks,nameof,IsCancellationRequested,Count,OnChange,... | This method is called when the change token is registered. | This is actually changing behavior since there is a new `null` check getting inserted here. I think it would be better to `Debug.Assert` that `state != null` since the only callers of this method pass `this` for `state`. |
@@ -833,7 +833,7 @@ class Valve:
select_updated = self.switch_manager.lacp_update_port_selection_state(
port, self, other_valves, cold_start=False)
if updated or select_updated:
- if updated:
+ if updated or select_updated:
self._reset_lacp_status(po... | [TfmValve->[_add_default_flows->[_pipeline_flows]],Valve->[_reset_dp_status->[_set_var],port_delete->[ports_delete],reload_config->[_inc_var,notify,_apply_config_changes,info],_pipeline_change->[_pipeline_flows,table_msgs,info],flow_timeout->[flow_timeout],ofdescstats_handler->[_set_var],_set_port_status->[_set_port_va... | Update the port s LACP states enables and disables pipeline processing. | looks like this 2nd if clause is now redundant and can be removed? line 835 does the same thing. |
@@ -123,6 +123,10 @@ define([
* @default false
*/
this.scene3DOnly = false;
+
+ this.fogEnabled = true;
+ this.fogDensity = undefined;
+ this.fogSSE = undefined;
};
/**
| [No CFG could be retrieved] | Determines whether or not to optimized for 3D only or not. | Perhaps put these in one `fog` object like `this.passes` above? |
@@ -33,6 +33,14 @@ class BaseDiscountCatalogueMutation(BaseMutation):
class Meta:
abstract = True
+ @classmethod
+ def recalculate_discounts(cls, products, categories, collections):
+ update_products_minimal_variant_prices_of_catalogues_task.delay(
+ product_ids=[p.pk for p in pr... | [VoucherBaseCatalogueMutation->[Arguments->[CatalogueInput]],VoucherCreate->[Arguments->[VoucherInput]],SaleBaseCatalogueMutation->[Arguments->[CatalogueInput]],SaleCreate->[Arguments->[SaleInput]],SaleAddCatalogues->[perform_mutation->[SaleAddCatalogues,add_catalogues_to_node]],VoucherRemoveCatalogues->[perform_mutati... | Add catalogues to node. | It recalculates prices, not exactly discounts. Am I right? `discounts` associates with `Discount` model |
@@ -34,6 +34,7 @@ class SubmissionsController < ApplicationController
:update_files,
:populate_file_manager_react]
before_filter :authorize_for_user, only: [:download, :downloads]
+ layout "assignment_content", only: [:browse]
def repo_browser
@assignment = ... | [SubmissionsController->[downloads_subdirectories->[downloads_subdirectories]]] | This method is called from the action_missing in the action_addition of the action finds a in the repository and returns it. | Prefer single-quoted strings when you don't need string interpolation or special symbols. |
@@ -8,7 +8,7 @@
<meta property="og:title" content="The DEV Community" />
<meta property="og:image" content="<%= SiteConfig.main_social_image %>">
<meta property="og:description" content="<%= SiteConfig.community_description %>">
-<meta property="og:site_name" content="The DEV Community" />
+<meta property="og:site_n... | [No CFG could be retrieved] | A list of all tags that can be found in the network. | To save typing (well, you've already typed, but still...): what if you define a `community_name` method in `ApplicationHelper` and return the whole blob `ApplicationConfig["COMMUNITY_NAME"]` ? |
@@ -14,9 +14,13 @@
* limitations under the License.
*/
+import * as st from '../../../src/style';
+import * as tr from '../../../src/transition';
+import {Animation} from '../../../src/animation';
import {KeyCodes} from '../../../src/utils/key-codes';
import {Layout} from '../../../src/layout';
import {Service... | [No CFG could be retrieved] | Creates an object that represents a single key code in the response. Checks if the layout is supported. | Import only the functions needed - you need setStyles here as far as I can see. |
@@ -273,15 +273,11 @@ class Product(SeoModel, ModelWithMetadata, PublishableModel):
default=settings.DEFAULT_CURRENCY,
)
- price_amount = models.DecimalField(
- max_digits=settings.DEFAULT_MAX_DIGITS,
- decimal_places=settings.DEFAULT_DECIMAL_PLACES,
- )
- price = MoneyField(amoun... | [ProductVariant->[is_digital->[is_shipping_required],get_first_image->[get_first_image]],AttributeQuerySet->[variant_attributes_sorted->[_get_sorted_m2m_field],product_attributes_sorted->[_get_sorted_m2m_field]],DigitalContent->[create_new_url->[create]],BaseAttributeQuerySet->[get_visible_to_user->[user_has_access_to_... | Get queryset of Product objects related to a given product object. Constructor for a class. | I guess `currency` field could be also dropped. It was used for the compound `price` field, but not sure if it is used anywhere else - we would have to check this. |
@@ -214,6 +214,7 @@ def main(args):
github_access_token_file = parsed_args.githubpat
github_access_token = open(github_access_token_file, 'r').read().rstrip()
+ css = parse_args.css
with tempfile.TemporaryDirectory() as tempdir:
version = download_azure_artifacts(tempdir)
| [main->[download_azure_artifacts,create_github_release,promote_snaps,parse_args],promote_snaps->[assert_logged_into_snapcraft,get_snap_revisions],parse_args->[parse_args],main] | The main entry point for the script. | You may have already picked up on this, but this function automates the process of finding and downloading the unsigned Windows installer for the release. This unsigned installer is not uploaded to GitHub until the `create_github_release` function below AFTER the `scp` command that this PR adds. If this creates a probl... |
@@ -152,7 +152,13 @@ public class LookupDimensionSpec implements DimensionSpec
@Override
public byte[] getCacheKey()
{
- byte[] dimensionBytes = StringUtils.toUtf8(dimension);
+ int totalSize = 0;
+ byte[][] dimensionBytes = new byte[dimensions.size()][];
+ for (int idx = 0; idx < dimensions.size()... | [LookupDimensionSpec->[getCacheKey->[getCacheKey],hashCode->[hashCode,getName,getLookup],preservesOrdering->[preservesOrdering],equals->[equals,getName,getDimension,getOutputName,getLookup]]] | This method creates a cache key for the given dimension extraction function and name. | I've seen something like this above, consider extracting some helper |
@@ -57,6 +57,7 @@ GUIEditBoxWithScrollBar::GUIEditBoxWithScrollBar(const wchar_t* text, bool borde
if (has_vscrollbar) {
createVScrollBar();
+ RelativeRect.LowerRightCorner.X -= m_scrollbar_width + 4;
}
calculateFrameRect();
| [deserializeAttributes->[setTextAlignment,setMax,setWordWrap,setPasswordBox,setMultiLine,setOverrideColor,setWritable,setDrawBorder,enableOverrideColor,setDrawBackground,setAutoScroll],setPasswordBox->[setWordWrap,setMultiLine],setTextRect->[getActiveFont],breakText->[getActiveFont],draw->[draw,getActiveFont],calculate... | Displays a text edit box with a scroll bar. | Could you please move those lines into `createVScrollBar()`? Functionally it's the same but in case someone wants to use the scrollbars for a different feature, they will again run into the very same issue. Moving it into the scrollbar constructor function prevents such problems in the future. |
@@ -52,7 +52,8 @@ public interface Volume extends ControlledEntity, Identity, InternalIdentity, Ba
UploadInProgress("Volume upload is in progress"),
UploadError("Volume upload encountered some error"),
UploadAbandoned("Volume upload is abandoned since the upload was never initiated within a s... | [asList,addTransition] | The state machine for the non - persistent volume. Adds a transition to the creation state machine. | @anuragaw don't change the original state `Attaching` to honour db volume states that may already be in `Attaching` state in db. This may cause usage issues post an upgrade. |
@@ -480,6 +480,16 @@ getent passwd daos_agent >/dev/null || useradd -s /sbin/nologin -r -g daos_agent
%{_libdir}/libdaos_serialize.so
%changelog
+* Mon Sep 27 2021 David Quigley <david.quigley@intel.com> 1.3.105-4
+- Add defusedxml as a required dependency for the test package.
+
+* Wed Sep 15 2021 Li Wei <wei.g.li... | [No CFG could be retrieved] | All of the files in the system that are not part of the system are in fact included Add a single - site - related header to the server - and daos - agent -. | Date is wrong now. |
@@ -46,7 +46,7 @@ unsigned long zfs_initialize_value = 0xdeadbeefdeadbeeeULL;
int zfs_initialize_limit = 1;
/* size of initializing writes; default 1MiB, see zfs_remove_max_segment */
-uint64_t zfs_initialize_chunk_size = 1024 * 1024;
+unsigned long zfs_initialize_chunk_size = 1024 * 1024;
static boolean_t
vdev... | [No CFG could be retrieved] | ZFS initialization functions stop the initializing thread schedule the sync task and free the vdev. | Unrelated to your change, but it seems like this could default to SPA_MAXBLOCKSIZE (on ZoL), like zfs_remove_max_segment. |
@@ -46,9 +46,9 @@ func init() {
// MetricSet that fetches process metrics.
type MetricSet struct {
mb.BaseMetricSet
- stats *process.Stats
- cgroup *cgroup.Reader
- cacheCmdLine bool
+ stats *process.Stats
+ cgroup *cgroup.Reader
+ perCPU bool
}
// New creates and returns a new MetricSet.
| [Fetch->[Get,Wrap,GetStatsForProcess],DefaultMetricSet,Warn,NewReader,MakeDebug,MustAddMetricSet,Init,Module,WithHostParser,Errorf,Wrap,UnpackConfig] | New creates a new metric set that fetches process metrics from the specified base metric set. returns an object that can be used to determine the type of the module. | cacheCmdLine was not used? |
@@ -15,10 +15,6 @@ class SmsSenderOtpJob < ActiveJob::Base
end
def otp_message(code)
- <<-END.strip_heredoc
- You requested a secure one-time password to log in to your #{APP_NAME} Account.
-
- Please enter this secure one-time password: #{code}
- END
+ "#{code} is your #{APP_NAME} one-time p... | [SmsSenderOtpJob->[perform->[send_otp,new],send_otp->[send_sms,otp_message],otp_message->[strip_heredoc],queue_as]] | Generates a message for the user that is not a secure one - time password. | Not sure we even need this method now, maybe just inline into the call-site? (thats what i'm going in another PR I'm working on). |
@@ -15,7 +15,7 @@
*/
import * as Preact from '../../../../src/preact';
-import {StreamGallery} from '../stream-gallery';
+import {StreamGallery} from '../component';
import {mount} from 'enzyme';
describes.sandboxed('StreamGallery preact component', {}, () => {
| [No CFG could be retrieved] | A simple example of how to render a single Show the next . | Please rename this file as `test-component.js` |
@@ -92,6 +92,7 @@ class Product(models.Model):
ProductType, related_name='products', on_delete=models.CASCADE)
name = models.CharField(max_length=128)
description = models.TextField()
+ seo_description = models.CharField(max_length=255, blank=True, null=True)
category = models.ForeignKey(
... | [ProductVariant->[get_absolute_url->[get_slug],get_cost_price->[select_stockrecord],as_data->[get_price_per_item],get_first_image->[get_first_image]],Product->[get_gross_price_range->[get_price_per_item],is_in_stock->[is_in_stock],get_price_range->[get_price_per_item],get_price_per_item->[get_price_per_item]],ProductIm... | Create a Model instance with a many - to - many field for all products. Yields all possible permissions in the collection. | I'd set max_length to 300, as that's the maximum displayed by Google and Facebook |
@@ -8,6 +8,13 @@ from importlib import import_module
def CreateSolverByParameters(model, solver_settings, parallelism):
+ if solver_settings.Has("custom_solver_module"):
+ # this means that the user specified a custom solver
+ solver_module_name = solver_settings["custom_solver_module"].GetString(... | [CreateSolverByParameters->[import_module,Has,solver_settings,Exception],CreateSolver->[custom_settings,CreateSolverByParameters,isinstance,Exception]] | Creates a solver by the specified parameters. This function returns a solver object that can be used to solve a single n - node k. | my idea was even easier than this: if one has a "solver_module" which is not in the wrapper list than it is treated as the name of a python file... what do you think? |
@@ -139,6 +139,11 @@ bool PersistentStore::access_start() {
bool PersistentStore::access_finish() {
if (eeprom_data_written) {
+ #ifdef STM32F4xx
+ // MCU may come up with flash error bits which prevent some flash operations.
+ // Clear flags prior to flash operations to prevent errors.
+ __HAL_... | [No CFG could be retrieved] | Load the current EEPROM from the memory and load the contents of the memory. region Erase functions. | You know, what's interesting is the stm32_eeprom.c has a lot of different `__HAL_FLASH_CLEAR_FLAG` in their `#if defined` soup. I think in `eeprom_buffer_flush` they are doing some clear errors but for the STM32F4xx they have nothing. Strange. I thought I had some error cleaning flags in the FLASH_EEPROM_LEVELING but I... |
@@ -272,8 +272,10 @@ class ResultsController < ApplicationController
submission.assignment.id,
[submission.grouping.group_id])
session[:job_id] = @current_job.job_id
- flash_message(:notice, I18n.t('automated_tests... | [ResultsController->[update_remark_request_count->[update_remark_request_count]]] | run_tests runs the nanomated test test case and stops the test case if. | You can remove this block---it's not wrong, but our code base doesn't generally restrict the request types unless we need to distinguish between multiple format types. |
@@ -4883,7 +4883,7 @@ def plot_events(events, sfreq, first_samp=0, color=None, event_id=None,
----------
events : array, shape (n_events, 3)
The events.
- sfreq : float
+ sfreq : float | None
The sample frequency.
first_samp : int
The index of the first sample. Typically ... | [_make_image_mask->[_inside_contour],tight_layout->[tight_layout],_epochs_navigation_onclick->[_draw_epochs_axes],_plot_ica_sources_evoked->[tight_layout],plot_evoked_topomap->[_check_delayed_ssp,tight_layout],plot_bem->[_plot_mri_contours],plot_source_spectrogram->[tight_layout],_helper_resize->[_layout_raw],plot_topo... | Plot the events to get a visual display of the paradigm. Plots a block of unique events and unique events ids. | If None, the data will be displayed in samples (not seconds). |
@@ -59,10 +59,14 @@ def handle_tokennetwork_new(raiden, event, current_block_number):
for channel_proxy in netting_channel_proxies:
raiden.blockchain_events.add_netting_channel_listener(channel_proxy)
- token_network_state = get_token_network_state_from_proxies(
- raiden,
- manager_prox... | [on_blockchain_event->[handle_channel_new,handle_tokennetwork_new,handle_channel_closed,handle_channel_unlock,handle_channel_settled,handle_channel_new_balance],on_blockchain_event2->[handle_channel_new,handle_tokennetwork_new2,handle_channel_closed,handle_channel_settled,handle_channel_new_balance,handle_secret_reveal... | Handle a new token network. | not really, we could just set it to the empty list in the constructor, same thing for the empty graph |
@@ -31,7 +31,7 @@ class Cifar10CNNBenchmark(tf.test.Benchmark):
(self.x_train, self.y_train), _ = tf.keras.datasets.cifar10.load_data()
self.x_train = self.x_train.astype('float32') / 255
self.y_train = tf.keras.utils.to_categorical(self.y_train, self.num_classes)
- self.epochs = 25
+ self.epochs =... | [Cifar10CNNBenchmark->[benchmark_cnn_cifar10_bs_512->[RMSprop,measure_performance,report_benchmark],benchmark_cnn_cifar10_bs_256->[RMSprop,measure_performance,report_benchmark],benchmark_cnn_cifar10_bs_1024_gpu_2->[RMSprop,measure_performance,report_benchmark],_build_model->[Activation,Sequential,Dense,MaxPooling2D,Con... | Initialize Cifar10 CNN benchmark. Dense and activation layers. | IMO, we can keep it as long as it's not timeout. |
@@ -123,8 +123,6 @@ class ExAuth
*/
private function isUser(array $aCommand)
{
- $a = \get_app();
-
// Check if there is a username
if (!isset($aCommand[1])) {
$this->writeLog(LOG_NOTICE, 'invalid isuser command, no username given');
| [ExAuth->[setHost->[writeLog],readStdin->[isUser,auth,writeLog],__destruct->[writeLog],checkCredentials->[writeLog],checkUser->[getBody,getReturnCode,isSuccess,writeLog],isUser->[checkUser,getHostName,setHost,writeLog],auth->[getHostName,checkCredentials,setHost,writeLog],__construct->[writeLog]]] | Check if a user is a valid user. | Nice catch! I guess `\get_app()` is then deprecated? |
@@ -608,9 +608,9 @@ def _get_eeg_info(vhdr_fname, elp_fname, elp_names, reference, eog):
'kind': kind,
'logno': idx,
'scanno': idx,
- 'cal': cal,
+ 'cal': cal * unit_mul,
'range': 1.,
- ... | [read_raw_brainvision->[RawBrainVision],_get_eeg_info->[_get_elp_locs,_read_vmrk_events]] | Extracts all the information from the given EEG header file. Returns information about a single node in the Brain Vision Data Exchange header. Returns a dictionary of cals and units for a given number of eeg channels. | 0.0 or 1.0 ? |
@@ -109,6 +109,8 @@ func (c *RaftCluster) start() error {
}
c.cachedCluster = cluster
c.coordinator = newCoordinator(c.cachedCluster, c.s.hbStreams, c.s.classifier)
+ regionStats := newRegionStatistics(c.s.scheduleOpt, c.s.classifier)
+ c.cachedCluster.bindRegionStatistics(regionStats)
c.quit = make(chan struct... | [UpdateStoreLabels->[GetStore],putStore->[GetStores,putStore,GetStore],RemoveStore->[putStore,GetStore],SetStoreState->[putStore,GetStore],GetStore->[GetStore],stop->[stop],checkStores->[BuryStore],collectMetrics->[GetStores],runBackgroundJobs->[checkStores,collectMetrics],SetStoreWeight->[putStore,GetStore],BuryStore-... | start starts the Raft cluster. | I think you can just `c.cachedCluster.regionStats = newRegionStatistics(c.s.scheduleOpt, c.s.classifier)`. |
@@ -292,7 +292,7 @@ nvme_test_verify_device_stats(void **state)
/**
*Set single device for rank0 to faulty.
*/
- print_message("NVMe with UUID=%s on host=%s\" set to Faulty\n",
+ print_message("NVMe with UUID=" DF_UUIDF " on host=%s\" set to Faulty\n",
DP_UUID(devices[rank_pos].device_id),
devices[ran... | [bool->[test_pool_get_info,assert_int_equal],run_daos_nvme_recov_test->[MPI_Barrier,run_daos_sub_tests,ARRAY_SIZE],void->[verify_server_log_mask,daos_mgmt_get_bs_state,strdup,srand,MPI_Barrier,atoi,daos_pool_query_target,reset_fail_loc,assert_non_null,verify_state_in_log,dts_oid_gen,rand,dts_buf_render,DP_OID,strlen,io... | This function is used to verify that the device stats are correct for the NVMe test This function is used to set the server config and log files. This function checks if the device is in the system and if it is then tears. | (style) line over 80 characters |
@@ -124,6 +124,13 @@ class ArticlesController < ApplicationController
end
end
+ def toggle_mute
+ @article = Article.find_by(user_id: current_user.id, slug: params[:slug])
+ authorize @article
+ @article.update(receive_notifications: !@article.receive_notifications)
+ redirect_to "/dashboard"
+ ... | [ArticlesController->[create_or_update_job_opportunity->[create,update],preview->[new],new->[new],update->[update]]] | update a single tag. | I think ideally this has a RESTful resource controller like `ArticleMutes` which has `create` and `destroy` (or just an `update` action which sort of acts as a "toggle") Since we have other exceptions, I'd be okay with leaving this for now. But it definitely needs to be changed away from a `GET` as described elsewhere. |
@@ -428,7 +428,10 @@ module.exports = class extends BaseGenerator {
this.isGitInstalled(code => {
if (code === 0) {
this.gitExec('rev-parse --is-inside-work-tree', { trace: false }, (err, gitDir) => {
- if (!gitDir... | [No CFG could be retrieved] | Package generator methods end - get callback for committing files to git. | is the value normally a text `'true'`? |
@@ -743,8 +743,7 @@ static void _update(dt_lib_module_t *self)
dt_lib_cancel_postponed_update(self);
dt_lib_styles_t *d = (dt_lib_styles_t *)self->data;
- const GList *imgs = dt_view_get_images_to_act_on(TRUE, FALSE, FALSE);
- const gboolean has_act_on = imgs != NULL;
+ const gboolean has_act_on = (dt_act_on... | [No CFG could be retrieved] | Constructor for the TableView class _styles_changed_callback - Callback for all components. | ... and this here. And you have a nice refactoring of the act-on in a separate unit I would go even forward and introduce an enum ACT_ON_ANY ACT_ON_ONE ACT_ONE_MULT And have this returned by a new function (`dt_act_on_get_mode()` or systematically return this value in `dt_act_on_get_images()` by using an access to this... |
@@ -53,13 +53,14 @@ describes.realWin(
.then(() => ft);
}
- it('renders', () => {
+ it('renders', async () => {
const text = 'Lorem ipsum';
- return getFitText(text).then((ft) => {
+ return getFitText(text).then(async (ft) => {
const content = ft.querySelector('.i-amphtml... | [No CFG could be retrieved] | A mike - specific AMPHTML plugin for the fit - text - content element. on - one - line - wraps - text calculateFontSize. | If this is moving to an async method, you can use `await` syntax instead of relying on the thenable directly. |
@@ -172,7 +172,8 @@ size_t rand_acquire_entropy_from_cpu(RAND_POOL *pool)
*/
size_t rand_drbg_get_entropy(RAND_DRBG *drbg,
unsigned char **pout,
- int entropy, size_t min_len, size_t max_len)
+ int entropy, size_t min_len, size_t max_len,
+ ... | [RAND_POOL_add_end->[RAND_POOL_entropy_available],RAND_POOL_bytes_needed->[RAND_POOL_entropy_needed],RAND_set_rand_engine->[RAND_set_rand_method],RAND_POOL_add->[RAND_POOL_entropy_available]] | Get entropy from the DRBG. Get entropy by polling system entropy. | Lines 174-176 are not properly indented (not your fault). |
@@ -207,6 +207,13 @@ func (l *LogHandler) logTheRoundTrip(logDataTable *LogData, crr *captureRequestR
} else {
core[Overhead] = total
}
+ if crr != nil && crw != nil {
+ core[ResponseDuration] = crw.processingStart.Sub(crr.processingEnd)
+ } else if crr == nil && crw != nil {
+ core[ResponseDuration] = crw.pro... | [Rotate->[Close],ServeHTTP->[ServeHTTP],Close->[Close]] | logTheRoundTrip logs the response of a request that was not handled by the client. | Won't this lead to a negative number in `ResponseDuration`? Start should be smaller than end. |
@@ -526,12 +526,12 @@ func (c *clusterInfo) handleRegionHeartbeat(region *regionInfo) error {
// Region meta is updated, update kv and cache.
if r.GetVersion() > o.GetVersion() || r.GetConfVer() > o.GetConfVer() {
- log.Infof("update region %v origin %v", region, origin)
+ log.Infof("[region %d] %s, Epoch chang... | [putRegionLocked->[setRegion],getMetaRegions->[getMetaRegions],unblockStore->[unblockStore],handleRegionHeartbeat->[putRegionLocked,setRegion,getRegion],randFollowerRegion->[randFollowerRegion],getStores->[getStores],getRegions->[getRegions],getStoreLeaderCount->[getStoreLeaderCount],searchRegion->[getRegion,searchRegi... | handleRegionHeartbeat handles region heartbeat. | `from %v to %v`, print the protobuf Peer directly. |
@@ -106,6 +106,8 @@ public class HypervisorUtilsTest {
writer.write(chars);
written += chars.length;
}
+ long creationTime = System.currentTimeMillis();
writer.close();
+ return creationTime;
}
}
| [HypervisorUtilsTest->[setupcheckVolumeFileForActivityFile->[createNewFile,write,fill,close,exists,FileWriter,delete],checkVolumeFileForActivityTimeoutTest->[setupcheckVolumeFileForActivityFile,checkVolumeFileForActivity,print,println,File,delete],checkVolumeFileForActivityTest->[setupcheckVolumeFileForActivityFile,che... | This method writes volume file for activity file. | @nlivens How about moving this line one down just to be extremely sure? |
@@ -430,6 +430,17 @@ public class FSUtils {
.map(HoodieLogFile::new).filter(s -> s.getBaseCommitTime().equals(baseCommitTime));
}
+ /**
+ * Get all the log files for the passed in FileId in the partition path.
+ */
+ public static Stream<HoodieLogFile> getAllLogFiles(FileSystem fs, Path partitionPat... | [FSUtils->[getLatestLogVersion->[getAllLogFiles,getLatestLogFile,getWriteTokenFromLogPath],getFs->[getFs,prepareHadoopConf],computeNextLogVersion->[getLatestLogVersion],getPartitionPath->[getPartitionPath],getFileIdFromFilePath->[getFileId,getFileIdFromLogPath],getAllPartitionPaths->[getAllPartitionFoldersThreeLevelsDo... | Get all log files in the partition. | fix the docs? |
@@ -970,3 +970,16 @@ duns_destroy_path(daos_handle_t poh, const char *path)
return 0;
}
+
+int
+duns_destroy_attr(struct duns_attr_t *attrp)
+{
+ if (attrp == NULL)
+ return EINVAL;
+
+ D_FREE(attrp->da_rel_path);
+ D_FREE(attrp->da_pool_label);
+ D_FREE(attrp->da_cont_label);
+
+ return 0;
+}
| [No CFG could be retrieved] | 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0. | nit: Does this function really need to return a status? If the pointer is null, maybe just return early. Then the caller doesn't need to check a rc to determine that it shouldn't have called the function in the first place, or else ignore the rc which is bad form. |
@@ -930,8 +930,11 @@ singv_iter_fetch(struct vos_obj_iter *oiter, vos_iter_entry_t *it_entry,
it_entry->ie_vis_flags = VOS_VIS_FLAG_VISIBLE;
it_entry->ie_epoch = key.sk_epoch;
it_entry->ie_minor_epc = key.sk_minor_epc;
- if (it_entry->ie_epoch <= oiter->it_punched)
- it_entry->ie_vis_flags = VOS_VIS_FLAG_COVER... | [int->[dbtree_iter_empty,dbtree_iter_probe,ci_set_null,vos_ilog_check,evt_iter_delete,recx_get_flags,key_iter_match,vos_cont2hdl,vos_oi_punch,vos_ilog_punch,evt_iter_empty,D_ERROR,dbtree_iter_fetch,evt_extent_width,key_iter_fetch_helper,VOS_TX_LOG_FAIL,singv_iter_probe_epr,recx_iter_fini,vos_obj_release,recx_iter_next,... | fetch the next object in the iterator. | There are four different code snippets for this visibility check (comparing filter's epoch and minor epoch with entry's) in this patch, it's better to unify them and make it into an inline function. |
@@ -446,3 +446,10 @@ type ForwardingTimeouts struct {
DialTimeout flaeg.Duration `description:"The amount of time to wait until a connection to a backend server can be established. Defaults to 30 seconds. If zero, no timeout exists"`
ResponseHeaderTimeout flaeg.Duration `description:"The amount of time to... | [CreateTLSConfig->[Read],Set->[Set],Read->[String],String->[String]] | Timeout for connecting to a backend server. Defaults to 30 seconds. | Why not RequestAcceptGraceTimeout ? |
@@ -216,11 +216,11 @@ class StorageLoggingPolicy(NetworkTraceLoggingPolicy):
_LOGGER.debug(" %r: %r", header, value)
_LOGGER.debug("Request body:")
- # We don't want to log the binary data of a file upload.
- if isinstance(http_request.body, types... | [StorageContentValidation->[on_request->[encode_base64,get_content_md5],on_response->[encode_base64,get_content_md5]],StorageResponseHook->[send->[is_retry,send]],QueueMessagePolicy->[on_request->[urljoin]],StorageRetryPolicy->[send->[configure_retries,sleep,retry_hook,increment,is_retry,send],sleep->[get_backoff_time,... | Add a log entry to the request context if the request is a GET or POST request. Get a from the response. | I'd rather delete this else branch. It's going to produce lot of entries that are not very useful. Instead consider adding logger.debug in ctor/ctors if logging is enabled but body logging is not. so that there's some hint about that option but is not rendered on each request. |
@@ -1151,12 +1151,12 @@ namespace ProtoCore.Lang
bool hasAmountOp,
RuntimeCore runtimeCore)
{
- double startValue = svStart.ToDouble().RawDoubleValue;
- double endValue = sv... | [MapBuiltIns->[MapTo->[Map]],FileIOBuiltIns->[StackValue->[ConvertToString]],RangeExpressionUntils->[GenerateNumericRange->[GenerateRangeByStepNumber,GenerateRangeByAmount,GenerateRangeByStepSize]],ArrayUtilsForBuiltIns->[CountTrue->[CountTrue],IsUniformDepth->[Rank],Exists->[Exists],SomeFalse->[Exists],SomeNulls->[Exi... | GenerateNumericRange - This method generates numeric range based on the given parameters. GenerateRangeByStepNumber - Generate a range of values based on the stepsize and the. | I think `ToDouble` calls are not needed, since `DoubleValue` is doing it internally. If so there are quite a number of `ToDouble()` we can remove in this PR. Same for `ToInteger()` calls. |
@@ -181,7 +181,7 @@ function create(context) {
const matches = [];
let match;
- while ((match = invalid.exec(string))) {
+ while ((match = invalid.exec(string)) && !string.includes('<svg')) {
const [fullMatch, tag] = match;
matches.push({
tag,
| [No CFG could be retrieved] | Determines if a void tag is invalid. JSXExpression node - > JSXExpression object. | Why was this changed? |
@@ -449,6 +449,16 @@ def rank(A, tol=1e-8):
return np.sum(np.where(s > s[0] * tol, 1, 0))
+def _unpack_epochs(epochs):
+ """ Aux Function """
+ if len(epochs.event_id) > 1:
+ epochs = [epochs[k] for k in epochs.event_id]
+ else:
+ epochs = [epochs]
+
+ return epochs
+
+
@verbose
def... | [write_cov->[save],Covariance->[__iadd__->[_check_covs_algebra],__add__->[_check_covs_algebra]],_get_whitener->[rank],whiten_evoked->[prepare_noise_cov],compute_covariance->[Covariance,_check_n_samples],read_cov->[Covariance],compute_whitener->[prepare_noise_cov],prepare_noise_cov->[_get_whitener],compute_raw_data_cova... | Get the eigenvector and eigvec of a single node where the node is not in. | if event_id is an int then this will fail. |
@@ -558,6 +558,10 @@ def check_output(cmd, folder=None, return_code=False, stderr=None):
raise CalledProcessErrorWithStderr(process.returncode, cmd, output=stderr)
output = load(tmp_file)
+ try:
+ logger.info("Output: in file:{}\nstdout: {}\nstderr:{}".format(output, stdout, st... | [get_cross_building_settings->[detected_os,detected_architecture],OSInfo->[detect_windows_subsystem->[uname,OSInfo],get_aix_architecture->[OSInfo],uname->[OSInfo,bash_path],get_win_os_version->[_OSVERSIONINFOEXW],get_aix_conf->[OSInfo]],cpu_count->[CpuProperties],CpuProperties->[get_cpus->[get_cpu_period,get_cpu_quota]... | Check the output of a command and return a object. | why not `logger.error` since it's an error? |
@@ -154,6 +154,10 @@ module.exports = yeoman.Base.extend({
var path = this.destinationPath(this.directoryPath + this.appsFolders[i]+'/.yo-rc.json');
var fileData = this.fs.readJSON(path);
var config = fileData['generator-jhipster'];
+ //t... | [No CFG could be retrieved] | Creates a list of application names to be included in the Docker Compose configuration. Prompts the user which applications do you want to use with clustered databases. | All application type should set the`baseName` and hence this should never happen, for appType `uaa` we should set the basename while generating the app appropriately in server or app generator |
@@ -240,6 +240,13 @@ MACHINE_RESET_MEMBER(atarisy1_state,atarisy1)
}
+WRITE_LINE_MEMBER(atarisy1_state::music_reset_w)
+{
+ // reset the YM2151 and YM3012
+ if (!state)
+ m_ymsnd->reset();
+}
+
/*************************************
*
| [No CFG could be retrieved] | Protected functions for the specific objects. read the next 16 - bit joystick interrupt and set the new interrupt for a. | Is this actually edge-sensitive? If not, the YM devices possibly need a proper `WRITE_LINE` for the input so things can hold them in reset. That's not necessarily something for this PR though. |
@@ -500,6 +500,10 @@ class ProductVariantBulkDelete(ModelBulkDeleteMutation):
.values_list("pk", flat=True)
)
+ product_variants = models.ProductVariant.objects.filter(id__in=pks)
+ for product_variant in product_variants:
+ info.context.plugins.product_variant_deleted(p... | [ProductVariantBulkCreate->[clean_variants->[clean_variant_input,validate_duplicated_sku,validate_duplicated_attribute_values],clean_channel_listings->[clean_price],perform_mutation->[save_variants,ProductVariantBulkCreate,clean_variants,create_variants],save_variants->[save,create_variant_channel_listings],save->[save... | Override perform_mutation to set default_variant for all products. | We should trigger webhook in `transaction.on_commit`. |
@@ -208,7 +208,17 @@ class AdminController
$contexts = $this->adminPool->getSecurityContexts();
$system = $request->get('system');
- $response = isset($system) ? $contexts[$system] : $contexts;
+ $mappedContexts = [];
+
+ foreach ($contexts as $system => $sections) {
+ ... | [AdminController->[bundlesAction->[getJsBundleName,getAdmins],indexAction->[getUser,isGranted,generate,getConfigParams,getLocalizations,serialize,setGroups,renderResponse],configAction->[getConfigParams],contextsAction->[get,getSecurityContexts]]] | Returns a list of all security contexts. | split this function that you dont need to nest foreach loops |
@@ -166,11 +166,13 @@ def main():
for data in train_data():
outs = exe.run(fluid.default_main_program(),
feed=feeder.feed(data),
- fetch_list=[avg_cost])
+ fetch_list=[avg_cost, precision])
avg_cost_val = ... | [db_lstm->[sums,dynamic_lstm,ParamAttr,append,fc,embedding,range],load_parameter->[open,read,fromfile],main->[ParamAttr,default_main_program,load_parameter,test,xrange,shuffle,train_data,default_startup_program,db_lstm,set,locals,print,get_embedding,mean,data,linear_chain_crf,feed,CPUPlace,batch,find_var,str,DataFeeder... | This function creates a network with a n - nan nan nan nan nan nan nan nan nan Train the n - grams and learn the n - grams. | Maybe `recall` and `f1_score` can also be added here. |
@@ -1500,7 +1500,16 @@ int s_server_main(int argc, char *argv[])
case OPT_KEYLOG_FILE:
keylog_file = opt_arg();
break;
-
+ case OPT_MAX_EARLY:
+ max_early_data = atoi(opt_arg());
+ if (max_early_data < 0) {
+ BIO_printf(bio_err, "Invalid val... | [No CFG could be retrieved] | Parse the options and set the error message. Check if we can use - HTTP - www - www - www - dtls or -. | the opt parser guarantees this, because you used 'n' above. |
@@ -252,7 +252,12 @@ public abstract class AbstractMovePanel extends ActionPanel {
if (setCancelButton()) {
add(leftBox(cancelMoveButton));
}
- add(leftBox(new JButton(doneMoveAction)));
+ add(leftBox(new JButton(SwingAction.of("Done", e -> {
+ if (doneMoveAction()) {
+ ... | [AbstractMovePanel->[undoMovesInReverseOrder->[undoMove],setActive->[setActive],undoMove->[cancelMove,updateMoves,undoMove],setUp->[updateMoves],clearStatusMessage->[clearStatusMessage],cleanUp->[disableCancelButton],setStatusWarningMessage->[setStatusWarningMessage],cancelMove->[cancelMoveAction,clearStatusMessage,dis... | Display the move button. | I just noticed that removing the WeakReference was a neccessity. Before the field doneMove held another reference to the listener object which kept it in memory. When removing the field this would have been no longer the case... |
@@ -31,3 +31,15 @@ export const getDetailsForMeta = meta => {
content,
};
};
+
+export const getOgImage = doc => {
+ const ogImages = doc.head.querySelectorAll('meta[property="og:image"]');
+ if (ogImages && ogImages.length > 0) {
+ // If there is more than one og:image, just pick the first
+ const ima... | [No CFG could be retrieved] | content ethernet number. | since you only care about the first one, please use `querySelector` instead of `querySelectorAll` |
@@ -104,7 +104,7 @@ limitations under the License.
"css-loader": "3.5.3",
"eslint": "6.8.0",
"eslint-config-prettier": "6.11.0",
- "eslint-loader": "4.0.2",
+ "eslint-webpack-plugin": "2.1.0",
"eslint-plugin-react": "7.19.0",
"file-loader": "6.0.0",
"fork-ts-checker-webpack-plugin": ... | [No CFG could be retrieved] | The version of the code that is used to provide a list of possible types. The version of the compiler is not guaranteed to be unique. PRETTIER_JAVA_VERSION <%_. | React builds are failing. Probable reason: `eslint-webpack-plugin` version 2 minimal supported ESLint version is 7 but React is still on version 6. |
@@ -25,7 +25,7 @@ namespace System.Net.Sockets
throw new ArgumentNullException(nameof(mcint));
}
- Group = group;
+ _group = group;
LocalAddress = mcint;
}
| [IPv6MulticastOption->[nameof],MulticastOption->[Any,nameof]] | Creates an instance of the ethernet multicast option class. Contains option values for joining an IPv6 multicast group. | Why this change? #Closed |
@@ -368,7 +368,9 @@ class Application extends BaseApplication
}
/**
- * {@inheritDoc}
+ * @param \Exception $exception
+ *
+ * @return void
*/
private function hintCommonErrors($exception)
{
| [Application->[getLongVersion->[getVersion,getName],hintCommonErrors->[getMessage,get,writeError,getComposer,getConfig,getIO],getDefaultInputDefinition->[addOption],getNewWorkingDir->[getParameterOption],getPluginCommands->[getPluginManager,getCommands,getComposer,getPluginCapabilities],getComposer->[areExceptionsCaugh... | Hints common errors. This method is called when an exception occurs while downloading the file. It will write an error. | why not using a native typehint here ? |
@@ -0,0 +1,13 @@
+/*
+ * Copyright The OpenTelemetry Authors
+ * SPDX-License-Identifier: Apache-2.0
+ */
+
+package io.opentelemetry.instrumentation.kafkaclients;
+
+import io.opentelemetry.api.GlobalOpenTelemetry;
+
+abstract class KafkaTracingHolder {
+
+ static final KafkaTracing tracing = KafkaTracing.create(Glob... | [No CFG could be retrieved] | No Summary Found. | this class seems unnecessary, i'd suggest removing it, it's ok to instantiate two `KafkaTracing` instances for the two subclasses (and ideally even better if user can pass in their own `KafkaTracing` to those two subclasses) |
@@ -59,6 +59,8 @@ public class CoGbkResult {
private static final int DEFAULT_IN_MEMORY_ELEMENT_COUNT = 10_000;
+ private static final int DEFAULT_MIN_ELEMENTS_PER_TAG = 100;
+
private static final Logger LOG = LoggerFactory.getLogger(CoGbkResult.class);
/**
| [CoGbkResult->[and->[and,CoGbkResult],UnionValueIterator->[advance->[next,hasNext],hasNext->[hasNext,equals]],empty->[CoGbkResult,empty],getAll->[getAll],CoGbkResultCoder->[encode->[getSchema,encode],of->[CoGbkResultCoder],tagListCoder->[of],equals->[equals],getCoderArguments->[of],hashCode->[hashCode],verifyDeterminis... | Creates a new result object from a given set of tuples. This method creates a TupleWithSizeMap from the given TupleWithSizeMap and the given. | Based upon the code it looks like this is used as a max per tag. |
@@ -87,6 +87,11 @@ func (s *Server) Tso(stream pdpb.PD_TsoServer) error {
if err != nil {
return status.Errorf(codes.Unknown, err.Error())
}
+
+ elapsed := time.Since(start)
+ if elapsed > time.Second {
+ log.Warn("get timestamp too slow", zap.Duration("cost", elapsed))
+ }
response := &pdpb.TsoRespon... | [ScatterRegion->[GetRegion],notBootstrappedHeader->[errorHeader],incompatibleVersion->[errorHeader],GetStore->[GetStore],AskBatchSplit->[GetRegion],RegionHeartbeat->[Send,Recv,GetStore],Send->[Send],AskSplit->[GetRegion],Recv->[Recv],GetRegionByID->[GetRegionByID],PutStore->[GetStore],ScanRegions->[ScanRegions],GetStor... | Tso handles TSO requests and responses from the server. | 1s is too long. Consider 1ms? |
@@ -227,7 +227,7 @@ func (b *Boxer) UnboxMessage(ctx context.Context, boxed chat1.MessageBoxed, conv
keyMembersType := b.getEffectiveMembersType(ctx, boxed, conv.GetMembersType())
nameInfo, err := CtxKeyFinder(ctx, b.G()).FindForDecryption(ctx,
tlfName, boxed.ClientHeader.Conv.Tlfid, conv.GetMembersType(),
- bo... | [unboxV1->[bodyUnsupported,headerUnsupported],assertInTest->[log],box->[preBoxCheck],attachMerkleRoot->[latestMerkleRoot],boxV2->[makeBodyHash],verifyMessageV1->[headerUnsupported],getSenderInfoLocal->[getUsername,getUsernameAndDevice],unversionBody->[bodyUnsupported],CompareTlfNames->[GetMembersType],UnboxMessages->[U... | UnboxMessage implements keybase. MessageUnboxer. Invariants implements the Invariants interface. | Does this come from a signed message? I just want to make sure the server can't convince you to encrypt a message incorrectly by claiming a private conv is public |
@@ -351,12 +351,18 @@ function get_user_by_email($email) {
*/
function find_active_users($options = array(), $limit = 10, $offset = 0, $count = false) {
+ $seconds = 600; //default value
+
if (!is_array($options)) {
elgg_deprecated_notice("find_active_users() now accepts an \$options array", 1.9);
+ if (!$op... | [remove_user_admin->[delete,canEdit],send_new_password_request->[setPrivateSetting,getClientIp],get_user_by_code->[sanitizeString,getTablePrefix,getDataRow,getMessage],execute_new_password_request->[getPrivateSetting],user_create_hook_add_site_relationship->[getGUID],users_pagesetup->[getURL,getIconURL],make_user_admin... | Finds users that are active. | What case is this supposed to handle? |
@@ -150,8 +150,8 @@ func GetConnectionFromContext(ctx context.Context) (*Connection, error) {
if c == nil {
return nil, errors.New("unable to get connection from context")
}
- conn := c.(Connection)
- return &conn, nil
+ conn := c.(*Connection)
+ return conn, nil
}
// FiltersToHTML converts our typical filte... | [makeEndpoint->[Sprintf],DoRequest->[QueryEscape,Sprintf,NewRequest,makeEndpoint,Do,Encode,Add,Query],MarshalToString,Value,DoRequest,Join,QueryEscape,Dial,Sprintf,Background,New,ToLower,WithValue,Parse,Errorf,HasPrefix] | GetConnectionFromContext returns a connection from the context. IsSuccess returns true if the response code is 1 or 2 or 3. | Why not just return the pointer? |
@@ -2,7 +2,7 @@
# A grade entry form has many columns which represent the questions and their total
# marks (i.e. GradeEntryItems) and many rows which represent students and their
# marks on each question (i.e. GradeEntryStudents).
-class GradeEntryForm < ApplicationRecord
+class GradeEntryForm < Assessment
has_m... | [GradeEntryForm->[calculate_total_percent->[out_of_total],export_as_csv->[out_of_total]]] | The grade entry form is a form which can represent a test lab exam etc. Get the total grades of the individual grade_entry_student s. | Metrics/ClassLength: Class has too many lines. [201/100] |
@@ -11,10 +11,13 @@ import os
def buildImage(opt):
dpath = os.path.join(opt['datapath'], 'COCO-IMG')
+ version = '1'
- if not build_data.built(dpath, version_string='1'):
+ if not build_data.built(dpath, version_string=version):
print('[building image data: ' + dpath + ']')
- build_da... | [build->[print,download,built,make_dir,join,remove_dir,mark_done,untar],buildImage->[print,download,built,make_dir,join,remove_dir,mark_done,untar]] | Build the image data. | maybe all these three lines (19-21) could be packed into a clean_dir function of sorts. to reduce boilerplate |
@@ -76,8 +76,10 @@ bool ts_overwrite;
bool ts_zero_copy;
/* verify the output of fetch */
bool ts_verify_fetch;
+/* shuffle the offsets of the array */
+bool ts_shuffle = false;
-daos_handle_t ts_oh; /* object open handle */
+daos_handle_t *ts_ohs; /* all opened objects */
daos_obj_id_t ts_oid... | [show_result->[MPI_Reduce,fprintf],int->[vos_fetch_begin,vos_obj_update,D_GOTO,daos_iov_set,ts_daos_fetch,daos_obj_close,D_ASSERT,bio_iod_post,update_or_fetch_internal,ts_set_value_buffer,vos_iter_probe,ts_daos_update,ts_vos_update_or_fetch,daos_obj_open,fprintf,dts_oid_gen,vos_iter_prepare,dts_time_now,memcpy,memcmp,v... | unused object class to identify VOS test mode Reads the object from the DTS and if necessary updates or fetches the object from the D. | (style) do not initialise globals to false |
@@ -183,9 +183,9 @@ module Engine
def format_currency(val)
# On dividends per share can be a float
# But don't show decimal points on all
- return format('$%.1<val>f', val: val) if val.is_a?(Float) && (val % 1 != 0)
+ return super unless val.is_a?(Float) && (val % 1 != 0)
- ... | [G1817->[interest_owed->[interest_owed_for_loans],can_take_loan?->[maximum_loans],new_auction_round->[format_currency],revenue_for->[option_modern_trains?],take_loan->[format_currency,maximum_loans],short->[format_currency,add_new_share],buying_power->[available_loans],migrate_shares->[convert],unshort->[remove_share]]... | Format a value as a currency value. | don't use unless with multiple values, use an if statement |
@@ -4,6 +4,7 @@
using System.Linq;
using System.Reflection;
+using System.Diagnostics.CodeAnalysis;
namespace Microsoft.Internal
{
| [AttributeServices->[T->[FirstOrDefault],GetAttributes->[GetCustomAttributes],IsAttributeDefined->[IsDefined]]] | This class contains the methods that can be accessed from the. NET Foundation. | Why is this needed? I don't see any nullability attribute being used in this file. |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.