patch stringlengths 18 160k | callgraph stringlengths 4 179k | summary stringlengths 4 947 | msg stringlengths 6 3.42k |
|---|---|---|---|
@@ -488,12 +488,12 @@ public class NotebookRestApi {
* @throws IOException, IllegalArgumentException
*/
@POST
- @Path("job/{notebookId}")
+ @Path("job/{noteId}")
@ZeppelinApi
- public Response runNoteJobs(@PathParam("notebookId") String notebookId)
- throws IOException, IllegalArgumentException {
... | [NotebookRestApi->[insertParagraph->[insertParagraph],runParagraph->[getParagraph],getJobListforNotebook->[getJobListforNotebook],getUpdatedJobListforNotebook->[getJobListforNotebook],deleteParagraph->[getParagraph],getParagraph->[getParagraph],cloneNote->[cloneNote],stopParagraph->[getParagraph],createNote->[createNot... | run all note jobs in a notebook. | throws should be located in front of exceptions. |
@@ -49,7 +49,7 @@ uint16_t HAL_adc_result;
// ------------------------
// Needed for DELAY_NS() / DELAY_US() on CORTEX-M7
-#if (defined(__arm__) || defined(__thumb__)) && __CORTEX_M == 7
+#if (defined(__arm__) || defined(__thumb__)) && WITHIN(__CORTEX_M, 3, 7)
// HAL pre-initialization task
// Force the prein... | [HAL_adc_start_conversion->[analogRead],flashFirmware->[NVIC_SystemReset],HAL_clear_reset_source->[__HAL_RCC_CLEAR_RESET_FLAGS],HAL_get_reset_source->[__HAL_RCC_GET_FLAG],HAL_init->[OUT_WRITE,FastIO_init,__HAL_RCC_PWR_CLK_ENABLE,LL_PWR_IsActiveFlag_BRR,ENABLED,__HAL_RCC_BKPSRAM_CLK_ENABLE,LL_PWR_EnableBkUpRegulator,HAL... | HAL_preinit - pre - initialize HAL object. | WITHIN is defined as : #define WITHIN(N,L,H) ((N) >= (L) && (N) <= (H)) Obviously not what you where going for there? @thinkyhead I don't know if you have another macro to say if __CORTEX_M IN (3,7) which i guess is what was being tried here? |
@@ -295,7 +295,7 @@ class Archiver:
if not args.dry_run:
while dirs and not item[b'path'].startswith(dirs[-1][b'path']):
archive.extract_item(dirs.pop(-1), stdout=stdout)
- self.print_verbose(remove_surrogates(orig_path))
+ logger.info(remove_surr... | [Archiver->[do_debug_put_obj->[open_repository],do_break_lock->[open_repository],do_debug_dump_archive_items->[open_repository],do_change_passphrase->[open_repository],do_prune->[print_error,open_repository,print_verbose],do_debug_get_obj->[open_repository],do_mount->[print_error,open_repository,print_verbose],do_check... | Extract the contents of a file or directory into an archive. Check if any directories have never matched. | note: here you also use logger.info (correct, just for comparison with create) |
@@ -24,6 +24,15 @@ import (
"go.uber.org/zap"
)
+const (
+ storeStatsRollingWindowsSize = 3
+
+ // RegionsStatsObserveInterval is the interval for obtaining statistics from RegionTree
+ RegionsStatsObserveInterval = 30 * time.Second
+ // RegionsStatsRollingWindowsSize is default size of median filter for data from... | [Set->[Set,GetOrCreateRollingStoreStats],Observe->[Observe,GetOrCreateRollingStoreStats],Observe] | StoresStats returns a StoresStats object that represents a hot spot cache. GetOrCreateRollingStoreStats returns a rolling store stats for a given store. | Why use 9? is it too long? |
@@ -31,11 +31,12 @@ public class ModelEditorContextMenu extends AnalyticsDialogFragment {
public Dialog onCreateDialog(Bundle savedInstanceState) {
super.onCreate(savedInstanceState);
- String[] entries = new String[4];
+ String[] entries = new String[5];
entries[FIELD_REPOSITION]... | [ModelEditorContextMenu->[newInstance->[ModelEditorContextMenu]]] | Creates a dialog which shows the menu which is shown when the user clicks on the dialog. | So this adds a new item in the menu. The items in the menu must all be strings since they're within a string array. Maybe a different a collection type is needed if we were to make this entry into a checkbox. Perhaps we could keep it a string,, but just append the current boolean value to the string? We have a few opti... |
@@ -369,6 +369,11 @@ func kubeContainerToCreateConfig(ctx context.Context, containerYAML v1.Container
containerConfig.Image = containerYAML.Image
containerConfig.ImageID = newImage.ID()
containerConfig.Name = containerYAML.Name
+
+ if podName != "" {
+ containerConfig.Name = fmt.Sprintf("%s-%s", podName, contain... | [PlayKube->[WithInfraContainerPorts,Warnf,NewPod,Close,IDMappings,Mkdir,GetNamespaceOptions,IsNotExist,Stat,ReadFile,ValidatePullType,New,InfraContainerID,Start,Errorf,ParseNormalizedNamed,Debugf,WithPodNetworks,WithPodHostNetwork,ID,Wrapf,WithInfraContainer,CreateContainerFromCreateConfig,ToLower,LabelVolumePath,Valid... | kubeContainerToCreateConfig takes a v1. Container and returns a createconfig describing if the image is not in the container. | maybe fail here if podName is not specified? |
@@ -84,8 +84,7 @@ public class QueueManagerImpl extends ReferenceCounterUtil implements QueueManag
}
public static boolean delayCheck(Queue queue) {
- long consumerRemovedTimestamp = queue.getConsumerRemovedTimestamp();
- return consumerRemovedTimestamp != -1 && System.currentTimeMillis() - consume... | [QueueManagerImpl->[isAutoDelete->[isAutoDelete]]] | Checks if the queue is delayed. | Removing the condition `consumerRemovedTimestamp != -1` could change the semantic of the **public** method `delayCheck`. With this change `delayCheck` will return **true** before removing a consumer. |
@@ -45,6 +45,7 @@ using Microsoft.Xna.Framework;
using Microsoft.Xna.Framework.Content;
using Microsoft.Xna.Framework.Input.Touch;
using System.Diagnostics;
+using Microsoft.Xna.Framework.Internal;
#if OPENGL
#if MONOMAC
| [GraphicsDevice->[Flush->[Flush],Clear->[Clear],SetRenderTarget->[SetRenderTarget],SetUserVertexBuffer->[Dispose,SetVertexBuffer],DrawPrimitives->[ApplyState,PrimitiveTopology],Present->[Present,Clear],DrawUserPrimitives->[SetUserVertexBuffer,GraphicsDevice,DrawUserPrimitives,ApplyState,PrimitiveTopology],Initialize->[... | License Section 9. 1. 5. 1 All framebuffer objects. | I think maybe I missed one... this may need the same fix as the other locations. We'll see what the next build says. |
@@ -256,10 +256,14 @@ def cosine_distance(
Raises:
ValueError: If `predictions` shape doesn't match `labels` shape, or
- `dim`, `labels`, `predictions` or `weights` is `None`.
+ `axis`, `labels`, `predictions` or `weights` is `None`.
"""
- if dim is None:
- raise ValueError("`dim` cannot be N... | [_safe_mean->[_safe_div],mean_pairwise_squared_error->[_safe_div,_num_present],compute_weighted_loss->[validate,_safe_mean,_num_present],huber_loss->[compute_weighted_loss],absolute_difference->[compute_weighted_loss],cosine_distance->[compute_weighted_loss],Reduction->[validate->[all]],sigmoid_cross_entropy->[compute_... | Adds a cosine - distance loss to the training procedure. | and don't mention dim here. |
@@ -514,6 +514,8 @@ int dtls1_read_bytes(SSL *s, int type, int *recvd_type, unsigned char *buf,
if (SSL3_RECORD_get_length(rr) == 0)
SSL3_RECORD_set_read(rr);
} else {
+ if (s->options & SSL_OP_CLEANSE_PLAINTEXT)
+ OPENSSL_cleanse(&(SSL3_RECORD_get_data(r... | [No CFG could be retrieved] | region methods region SSL3. 1. 5. | Depending on the read sematics for datagram connections i think the _n_ should be replaced by _SSL3_RECORD_get_length(rr)_ Since when for datagram sockets when reading **up to _n_** bytes from a datagram with a **length larger than _n_**. The remaining bytes are dropped and never delivered to the application. |
@@ -262,12 +262,10 @@ void ClientEnvironment::step(float dtime)
Step active objects and update lighting of them
*/
- g_profiler->avg("CEnv: num of objects", m_active_objects.size());
bool update_lighting = m_active_object_light_update_interval.step(dtime, 0.21);
- for (auto &ao_it : m_active_objects) {
- Clie... | [getFreeClientActiveObjectId->[isFreeClientActiveObjectId],step->[step],processActiveObjectMessage->[getActiveObject],getActiveObjects->[],getSelectedActiveObjects->[,getActiveObjects],removeActiveObject->[getActiveObject],addActiveObject->[getFreeClientActiveObjectId,isFreeClientActiveObjectId,addActiveObject]] | This is the main loop of the client environment. This function handles loops and loops in the game system. This is the main entry point for the lplayer. It is the main entry point for This is the main entry point for the lighting system. | You should be able to pass directly cb_state (same signature than cb, `void(ClientActiveObject *)`) |
@@ -48,7 +48,11 @@ namespace NServiceBus
}
else
{
- var subscriber = distributionPolicy.GetDistributionStrategy(group.First().Endpoint, DistributionStrategyScope.Publish).SelectReceiver(group.Select(s => s.TransportAddress).ToArray());
+ ... | [UnicastPublishRouter->[Route->[Select,MessageHierarchy,SelectDestinationsForEachEndpoint,ConfigureAwait],GetSubscribers->[Select,ConfigureAwait],SelectDestinationsForEachEndpoint->[GroupBy,TransportAddress,Endpoint,SelectReceiver,ToArray,Add,Key],messageMetadataRegistry,subscriptionStorage]] | Select destinations for each endpoint. | so instead of using the provided transport address of the subscription, we're just trying to make that up based on the endpoint name? If you do not configure sender-side distribution, we have no chance of identifying the correct machine or addresses which don't match the endpoint name? |
@@ -91,7 +91,7 @@ public abstract class AbstractAvroToOrcConverter extends Converter<Schema, Schem
/**
* list of partitions that a partition has replaced. E.g. list of hourly partitons for a daily partition
*/
- private static final String REPLACED_PARTITIONS_HIVE_METASTORE_KEY = "gobblin.replaced.partition... | [AbstractAvroToOrcConverter->[convertRecord->[hasConversionConfig]]] | Abstract class for converting a single record of type schema to an ORC table. The base class for the types of the that are required for building the Avro to. | It's probably late for this change but dots.are.not.substitutes.for.spaces. |
@@ -307,10 +307,10 @@ namespace System.ComponentModel.Composition.Hosting
if (reservedMetadataNames.Contains(pi.Name, StringComparers.MetadataKeyNames))
{
- throw ExceptionBuilder.CreateDiscoveryException(SR.Discovery_ReservedMet... | [CompositionServices->[MetadataList->[Add->[Add]],GetTypeIdentityFromExport->[AdjustTypeIdentity],GetImportMetadata->[GetImportMetadata],IsValidAttributeType->[IsValidAttributeType],IsRecomposable->[IsRecomposable]]] | Try to contribute metadata for a given member. missing metadata value - try to contribute metadata value - try to contribute metadata value -. | This is the case where `provider == null` seems this exception handling copied from other case but forgotten to change variable names accordingly, please review @safern @stephentoub |
@@ -195,6 +195,7 @@ public class ECKeyOutputStream extends KeyOutputStream {
currentWriterChunkLenToWrite,
currentChunkBufferLen + currentWriterChunkLenToWrite == ecChunkSize);
checkAndWriteParityCells(pos);
+ off += currentWriterChunkLenToWrite;
int remLen = len - currentWriterChunkLen... | [ECKeyOutputStream->[handleFlushOrClose->[markStreamClosed,handleException],writeToOutputStream->[write],getXceiverClientFactory->[getXceiverClientFactory],handleFlushOrCloseAllStreams->[handleException,markStreamClosed,getStreamEntries],getStreamEntries->[getStreamEntries],Builder->[build->[ECKeyOutputStream]],handleS... | Writes the specified bytes to the underlying output stream. | Note this duplicates the change in #2714 so this change will be removed from here when it is committed (before this one) |
@@ -26,6 +26,12 @@ class DialoGPTDecoder(GPT2Decoder):
This decoder is initialized with the pretrained model from Hugging Face.
"""
+ def __init__(self, opt, dict):
+ super().__init__(opt, dict)
+ if opt.get('batchsize', 1) == 1 and self.END_IDX == self.NULL_IDX:
+ # get around t... | [DialoGPTModel->[_get_decoder->[DialoGPTDecoder]],DialogptAgent->[build_model->[DialoGPTModel]]] | Initialize GPT2Model from pre - trained GPT2. | when is the latter condition not going to be true? if you are inheriting from this model but changing things? |
@@ -217,7 +217,16 @@ func GetBootstrapClusterRoles() []authorizationapi.ClusterRole {
authorizationapi.NewRule("create").Groups(buildGroup).Resources(authorizationapi.JenkinsPipelineBuildResource).RuleOrDie(),
},
},
-
+ {
+ ObjectMeta: kapi.ObjectMeta{
+ Name: StorageAdminRoleName,
+ },
+ Rules: [... | [NormalizeResources,Sprintf,RuleOrDie,NewRule,Names,Convert,Groups,NewString,AllRoles,Resources] | Rules for all the rules in the group. authorizationapi. NewRuleOrDie - Creates a new authorizationapi. | I would not expect global read/write access to these things... I would expect this role to grant the pv/pvc/storageclass permissions, then the user be granted an admin role in a particular namespace if they needed to set up secrets or endpoints for their provisioner. |
@@ -2871,7 +2871,8 @@ void process(struct dt_iop_module_t *self, dt_dev_pixelpipe_iop_t *piece, const
dt_iop_roi_t roo = *roi_out;
roo.x = roo.y = 0;
// roi_out->scale = global scale: (iscale == 1.0, always when demosaic is on)
-
+ gboolean info = (darktable.unmuted & DT_DEBUG_DEMOSAIC);
+
const uint8_t(... | [No CFG could be retrieved] | processing of the given image Checks if a color - related image is available and demosaics is needed. | I *think* this should be combined with `PERF` since you use info to produce perf informations for demosaic |
@@ -27,8 +27,8 @@ class ManifestManager(object):
def _handle_recipe(self, node, verify, interactive):
ref = node.ref
- export = self._cache.export(ref)
- exports_sources_folder = self._cache.export_sources(ref)
+ export = self._cache.package_layout(ref).export()
+ exports_sou... | [ManifestManager->[_handle_manifest->[_check_accept_install]]] | Handle a recipe. | `self._cache.export_sources(ref, short_paths=False)` vs `self._cache.package_layout(ref, short_paths=None).export_sources()` |
@@ -748,6 +748,16 @@ public class Note implements ParagraphJobListener, JsonSerializable {
}
public void persist(AuthenticationInfo subject) throws IOException {
+ if (repo instanceof NotebookRepoSync) {
+ NotebookRepoSync repoManager = (NotebookRepoSync) repo;
+ if (repoManager.isSaveOnRunEnabled(... | [Note->[snapshotAngularObjectRegistry->[getId],equals->[equals],getName->[getId],setInterpreterSettingManager->[setInterpreterSettingManager],onOutputAppend->[onOutputAppend],hashCode->[hashCode],persist->[snapshotAngularObjectRegistry],unpersist->[getId],isTrash->[getName],getFolderId->[getName],toJson->[toJson],clear... | Persist the given authentication info. | Who will call the `persist` method? and what the meaning of the prefix `force` in front of the `forcePersist`? |
@@ -145,8 +145,14 @@ namespace System
{
get
{
- StrongBox<bool> redirected = EnsureInitialized(ref _isStdInRedirected, () => new StrongBox<bool>(ConsolePal.IsInputRedirectedCore()));
+ StrongBox<bool> redirected = Volatile.Read(ref _isStdInRedirected) ?? ... | [Console->[SetWindowSize->[SetWindowSize],Clear->[Clear],ReadLine->[ReadLine],SetCursorPosition->[SetCursorPosition],SetWindowPosition->[SetWindowPosition],Write->[Write],WriteLine->[WriteLine],Read->[Read],MoveBufferArea->[MoveBufferArea],SetBufferSize->[SetBufferSize],ResetColor->[ResetColor],Beep->[Beep]]] | Provides a static utility to read a single key from the console. Gets the size of the cursor. | This `!` shouldn't be needed. Are you getting a warning without it? |
@@ -561,16 +561,7 @@ class Jetpack {
*/
add_action( 'init', array( $this, 'deprecated_hooks' ) );
- /*
- * Enable enhanced handling of previewing sites in Calypso
- */
- if ( self::is_active() ) {
- require_once JETPACK__PLUGIN_DIR . '_inc/lib/class.jetpack-iframe-embed.php';
- add_action( 'init', ar... | [Jetpack->[reset_saved_auth_state->[reset_saved_auth_state],add_remote_request_handlers->[require_jetpack_authentication],admin_page_load->[disconnect],development_mode_trigger_text->[is_development_mode],is_active_and_not_development_mode->[is_development_mode],check_identity_crisis->[is_development_mode],register->[r... | This method is called by the constructor of the class. Jetpack Signature Check Token This is the main entry point for all actions that run checks. This method is used to run all actions that need to be run as late as possible. | do we need the three of these? |
@@ -529,7 +529,7 @@ class ExecDriver < VirtualMachineDriver
# MIGRATE (live) action, migrates a VM to another host creating network
#
def migrate(id, drv_message)
- action = VmmAction.new(self, id, :migrate, drv_message)
+ action = VmmAction.new(self, id, :migrate, drv_message, true)
... | [ExecDriver->[resize_disk->[run],attach_disk->[run],destroy->[run],update_sg->[run],update_conf->[run],detach_nic->[run],disk_snapshot_create->[run],restart->[run],cleanup->[run],detach_disk->[run],save->[run],migrate->[run],attach_nic->[run],restore->[run],deploy->[run]],VmmAction->[execute_steps->[execute_steps]]] | Executes a migrate action on a virtual machine and all of its children. | The `true` can't be hard coded here, it must follow the `delegate_actions`. And, similar change must be for all other actions. |
@@ -294,7 +294,8 @@ class GradientDescentTrainer(Trainer):
num_gradient_accumulation_steps: int = 1,
use_amp: bool = False,
enable_default_callbacks: bool = True,
- run_sanity_checks: bool = True,
+ run_sanity_checks: Optional[bool] = None,
+ run_confidence_checks: bool =... | [GradientDescentTrainer->[_validation_loss->[batch_outputs],_train_epoch->[rescale_gradients,train,batch_outputs],_try_train->[_validation_loss,_train_epoch]]] | Initialize a single object. Initializes the object variables and initializes the object. The Pytorch model object is maintained in the case of distributed training and eval. | Maybe it's better to just check for this in `**kwargs`? Either way works, I just thought we had gone with the "kwargs" approach elsewhere. But I don't feel strongly either way. |
@@ -220,6 +220,7 @@ public class DruidCoordinatorBalancer implements DruidCoordinatorHelper
segmentToMove,
callback
);
+ return true;
}
catch (Exception e) {
log.makeAlert(e, StringUtils.format("[%s] : Moving exception", segmentName)).emit();
| [DruidCoordinatorBalancer->[moveSegment->[moveSegment],balanceTier->[reduceLifetimes]]] | move a segment from one server to another. | Interesting that `DruidCoordinator.moveSegment()` also wraps pretty much it's whole body with `try { ... } catch (Exception e) { ...}`, that will makes `catch (Exception e)` below in *this* method obsolete. I think only one should be left. |
@@ -17,6 +17,11 @@ import { getProviderDisplayName } from 'utils/profileTools'
const User = ({ match }) => {
const id = match.params.id
const vars = { id: match.params.id }
+
+ if (!id) {
+ console.error('Error: User: User ID not provided!')
+ }
+
return (
<div className="container user-profile">
... | [No CFG could be retrieved] | The default user - profile is to display a single user - profile unnamed user - profile Outputs a formatted - text list of the n - ary user in the system. | Instead of this we can just add `skip={!id}` to the `Query` component do the query doesn't even get run if id isn't present |
@@ -666,11 +666,10 @@ public final class NioEventLoop extends SingleThreadEventLoop {
// and thus the SelectionKey could be cancelled as part of the deregistration process, but the channel is
// still healthy and should not be closed.
// See https://github.com/netty/netty/issues/5... | [NioEventLoop->[selectNow->[get,wakeup,selectNow],openSelector->[openSelector,SelectorTuple],newTaskQueue->[newTaskQueue],register0->[register],run->[get,rebuildSelector0],pollTask->[pollTask],selectAgain->[selectNow],select->[get,selectNow,select],wakeup->[wakeup],rebuildSelector0->[openSelector,register],closeAll->[c... | Process a selected key. check if there are any errors. | this `return` can be removed now. |
@@ -966,10 +966,12 @@ class WP_Test_Jetpack_Sync_Full extends WP_Test_Jetpack_Sync_Base {
if ( is_multisite() ) {
$should_be_status['queue']['network_options'] = 1;
$should_be_status['sent']['network_options'] = 1;
+ $should_be_status['sent_total']['network_options'] = -1;
}
$this->assertEquals( ... | [WP_Test_Jetpack_Sync_Full->[test_full_sync_status_should_be_not_started_after_reset->[create_dummy_data_and_empty_the_queue],test_full_sync_status_after_start->[create_dummy_data_and_empty_the_queue],test_full_sync_status_with_a_small_queue->[create_dummy_data_and_empty_the_queue],test_full_sync_sends_theme_updates->[... | This function tests the full sync status after the end of the sync. | Align the `=` with the above lines? |
@@ -32,5 +32,5 @@ func init() {
// AssetKubernetes returns asset data.
// This is the base64 encoded zlib format compressed contents of module/kubernetes.
func AssetKubernetes() string {
- return "eJzsXU9z47aSv8+nQPnkbDk6bG3tYWrrVSWel32zSSZeeyY5bG0pMNmSEFMAA4D26H36VwD4ByQBkBRB2bGlQypjW90/dDeA7kaj8S16gMN79FDcA6cgQbxD... | [SetFields] | AssetKubernetes returns the base64 encoded compressed contents of the asset file. This function is used to determine the current state of the system. This function is used to create a new instance of the class that is used to create a. | This file should not be touched now |
@@ -165,7 +165,7 @@ public class ITJettyWebSocketCommunication {
clientService.registerProcessor(clientId, clientProcessor);
- clientService.connect(clientId);
+ clientService.connect(clientId, Collections.emptyMap());
assertTrue("WebSocket client should be able to fire connected e... | [ITJettyWebSocketCommunication->[testClientServerCommunicationRecovery->[isWindowsEnvironment],testClientServerCommunication->[isWindowsEnvironment],assertConnectedEvent->[isSecure],setupClient->[isSecure],assertConsumeBinaryMessage->[isSecure],assertConsumeTextMessage->[isSecure]]] | Test client server communication. This method asserts that the client and server are able to consume binary message. | If the interface is made backward-compatible, this change can be reverted. |
@@ -1223,6 +1223,18 @@ def swap(repo_path):
path = saved
+@contextlib.contextmanager
+def additional_repository(repository):
+ """Adds temporarily a repository to the default one.
+
+ Args:
+ repository: repository to be added
+ """
+ path.put_first(repository)
+ yield
+ path.remove(re... | [RepoIndex->[_build_index->[create,write,read,update]],RepoPath->[repo_for_pkg->[first_repo,get_full_namespace],remove->[remove],get->[repo_for_pkg],put_last->[put_last],patch_index->[update],put_first->[put_first],__contains__->[exists],get_pkg_class->[repo_for_pkg],dirname_for_package_name->[repo_for_pkg],exists->[ex... | Get a package object from the path. Exception thrown when a package is not found. | Doesn't this need to declare path as a global? |
@@ -74,10 +74,10 @@ class FileSelectWidget(widgets.Select):
option(f, deleted=ver.deleted, channel=channel))
output.append(u'</optgroup>')
- return jinja2.Markup(u''.join(output))
+ return output
-class FileCompareForm(happyforms.Form):
+class FileCompareFor... | [FileCompareForm->[clean->[ugettext,ValidationError,get],__init__->[filter,super,pop,check_unlisted_addons_reviewer],all,ModelChoiceField],FileSelectWidget->[render_options->[option->[sort,append,get_platform_display,update,extend,escape,set,join],,hashes,int,append,get,order_by,len,extend,Markup,filter,defaultdict,esc... | Renders the options for the list of files. Returns a Jinja2 markup of the . | This can't be easily uplifted since the APIs are quite different between 1.11 and 1.8. I'd keep it here tbh |
@@ -329,13 +329,12 @@ class TestAddonManager(TestCase):
collection = self.addon.collections.first()
assert collection.addons.get() == self.addon
- # Addon shouldn't be listed in collection.addons if it's deleted or
- # unlisted.
+ # Addon shouldn't be listed in collection.addons... | [TestSearchSignals->[test_delete->[delete]],TestAddonFromUpload->[test_existing_guid_same_author->[delete],test_existing_guid->[delete]],TestAddonDelete->[test_cascades->[delete],test_review_delete->[delete],test_delete_with_deleted_versions->[delete]],TestAddonWatchDeveloperNotes->[test_has_info_update_whiteboard->[as... | Test for many to many filter. | Not sure I follow this change - it was empty before but now it contains the addon? |
@@ -217,11 +217,11 @@ public class ReactiveMongoOperations {
}
private static Uni<Void> persist(ReactiveMongoCollection collection, Object entity) {
- return collection.insertOne(entity);
+ return collection.insertOne(entity).onItem().ignore().andContinueWithNull();
}
private stati... | [ReactiveMongoOperations->[mongoDatabase->[mongoDatabase],find->[bindQuery,find,mongoCollection],stream->[stream],findByIdOptional->[mongoCollection],listAll->[list],update->[nullUni,update],streamAll->[stream],persistOrUpdate->[persistOrUpdate],count->[count,bindQuery,mongoCollection],findAll->[mongoCollection],delete... | private static method to persist and update an entity in the collection. | Maybe we should also break reactive mongo panache compatibility, by returning a `Uni<InsertOneResult>` here? But we should at least try to be consistent between reactive mongo and reactive panache mongo. |
@@ -79,6 +79,14 @@ namespace Details {
TPETRA_INSTANTIATE_L( TPETRA_DETAILS_FIXEDHASHTABLE_INSTANT_CUDA_INT )
+ // Make sure that KeyType = long, ValueType = int and
+ // KeyType = long long, ValueType = int both get instantiated -
+ // whenever Tpetra is enabled, Xpetra::Epetra_Map depends on both
+ TPETRA_... | [No CFG could be retrieved] | This function is used to create the object from the given base key. | 1. You actually want `int, long`, not the other way around. The macro (see the bottom of `Tpetra_Details_FixedHashTable_def.hpp`) takes arguments `LO, GO, DEVICE`. It reverses `LO` and `GO` as template arguments to `FixedHashTable`. 2. These macro invocations don't belong inside `#ifndef HAVE_TPETRA_INST_INT_INT ... #e... |
@@ -24,12 +24,14 @@ import {dev} from '../log';
*/
export function utf8Decode(bytes) {
if (TextDecoder) {
- return Promise.resolve(new TextDecoder('utf-8').decode(bytes));
+ return new Promise(resolve => {
+ resolve(new TextDecoder('utf-8').decode(bytes));
+ });
}
return new Promise((resolve, ... | [No CFG could be retrieved] | Interprets a byte array as UTF - 8 bytes. Converts a string which holds 8 - bit code points such as the result of atob to. | Just curious: Why is it useful to inject a layer of deferred execution here? |
@@ -111,8 +111,16 @@ class Engine(AbstractClass):
# TODO: See https://github.com/pantsbuild/pants/issues/3912
throw_roots = tuple(root for root, state in result_items if type(state) is Throw)
if throw_roots:
- cumulative_trace = '\n'.join(self._scheduler.trace())
- raise ExecutionError('Receive... | [Engine->[product_request->[ExecutionError,execute],execute->[finished,failure]]] | Executes a request for a singular product type from the scheduler for one or more subjects and. | Need to figure out the appropriate tests here. Also, this implementation feels ugly. I could back out the trace eliding, but that doesn't feel quite right either. |
@@ -133,11 +133,12 @@ def get_extensions():
nvcc_flags = []
else:
nvcc_flags = nvcc_flags.split(' ')
+ nvcc_flags.append('-O3')
else:
define_macros += [('WITH_HIP', None)]
nvcc_flags = []
extra_compile_args = {
- ... | [clean->[run->[run,read]],read->[read],write_version_file,get_extensions,get_dist] | Get extensions for the given extension. Finds all missing objects in test_dir and all models in test_dir and compiles Add extension modules that can be found in the same base directory as the extensions that are found. | On Windows, it should be `-O2`. `-O3` is not a valid flag. |
@@ -443,8 +443,11 @@ public enum CassandraType
case DOUBLE:
case INET:
case INT:
+ case TINYINT:
+ case SMALLINT:
case FLOAT:
case DECIMAL:
+ case DATE:
case TIMESTAMP:
case UUID:
cas... | [buildArrayValue->[buildArrayValue],buildMapValue->[buildMapValue],objectToJson->[buildArrayValue,buildMapValue]] | Checks if this partition key is supported by this partition. | Seems like these two types already had the necessary code implemented? |
@@ -165,13 +165,13 @@ class TestElmoCommand(ElmoTestCase):
assert os.path.exists(self.output_path)
with h5py.File(self.output_path, 'r') as h5py_file:
- assert len(h5py_file.keys()) == 1
- assert set(h5py_file.keys()) == set(sentences)
+ assert len(h5py_file.keys()) ... | [TestElmoCommand->[test_duplicate_sentences->[split,write,keys,get,len,set,exists,open,File,main],test_top_embedding_works->[list,split,write,keys,get,embed_sentence,len,ElmoEmbedder,exists,open,File,main,assert_allclose],test_all_embedding_works->[list,split,write,keys,get,embed_sentence,len,ElmoEmbedder,exists,open,F... | Test if duplicate sentences are present in the H5 file. | is it worth having one test for the sentences-as-keys case? |
@@ -369,6 +369,10 @@ class EngineInitializer:
symbol_table = _legacy_symbol_table(build_file_aliases)
+ # TODO: register this with the SymbolTable/LegacyPythonCallbacksParser so that the aliases
+ # exposed by the Target API are interpreted correctly.
+ registered_target_types = Regis... | [EngineInitializer->[_make_goal_map_from_rules->[GoalMappingError],setup_legacy_graph_extended->[_make_goal_map_from_rules,_legacy_symbol_table,LegacyGraphScheduler]],_make_target_adaptor->[_compute_default_sources_globs],LegacyGraphScheduler->[new_session->[new_session]],_apply_default_sources_globs->[_compute_default... | Construct and return the components necessary for the legacy build graph. Initialize the Rules that are required by the user. Creates a scheduler that runs union of all rules. | It feels like doing this in this PR might make sense? Or is it usable in some other way right now? |
@@ -53,4 +53,5 @@ class PyPyprecice(PythonPackage):
]
def install(self, spec, prefix):
- self.setup_py("install", "--prefix={0}".format(prefix))
+ if self.version <= Version("2.1.1.1"):
+ self.setup_py("install", "--prefix={0}".format(prefix))
| [PyPyprecice->[install->[setup_py,format],variant,depends_on,version,patch]] | Install a package. | Does the default install method not work for some reason? |
@@ -544,6 +544,9 @@ def ssd300_vgg16(pretrained: bool = False, progress: bool = True, num_classes: i
trainable_backbone_layers (int): number of trainable (not frozen) resnet layers starting from final block.
Valid values are between 0 and 5, with 5 meaning all backbone layers are trainable.
"... | [SSD->[forward->[eager_outputs,compute_loss],__init__->[SSDHead]],SSDClassificationHead->[__init__->[_xavier_init]],SSDScoringHead->[forward->[_get_result_from_module_list]],SSDFeatureExtractorVGG->[__init__->[_xavier_init]],_vgg_extractor->[SSDFeatureExtractorVGG],ssd300_vgg16->[SSD,_vgg_extractor],SSDRegressionHead->... | Constructs an SSD model with a VGG16 backbone. Load a checkpoint from the model. | Any particular reason why you didn't use the `IntermediateLayerGetter`? Also, for the future, I think we will want to unify the way we extract features so that we rely on the FX-based feature extractor, which will be more generic. |
@@ -201,6 +201,10 @@ public class XsltPayloadTransformer extends AbstractTransformer implements BeanC
@Override
protected void onInit() throws Exception {
super.onInit();
+ boolean resultFactorySpecified = StringUtils.hasText(this.getResultFactoryName()) || StringUtils.hasText(this.getResultType());
+ if(resul... | [XsltPayloadTransformer->[transformUsingResultFactory->[createSource,transformSource,DOMSource,StringSource],createStreamSourceOnResource->[StreamSource,getInputStream,toString],setBeanClassLoader->[notNull],onInit->[newInstance,createStreamSourceOnResource,onInit,getBeanFactory,createStandardEvaluationContext,newTempl... | Initialize the Jersey. | Do not use `this.` for methods |
@@ -256,6 +256,8 @@ public class SimpleDoFnRunner<InputT, OutputT> implements DoFnRunner<InputT, Out
break;
case PROCESSING_TIME:
+ effectiveTimestamp = stepContext.timerInternals().currentProcessingTime();
+ break;
case SYNCHRONIZED_PROCESSING_TIME:
effectiveTimestamp = ... | [SimpleDoFnRunner->[DoFnFinishBundleContext->[output->[outputWindowedValue,output],pipelineOptions->[getPipelineOptions]],DoFnProcessContext->[pipelineOptions->[getPipelineOptions],sideInput->[sideInput],getNamespace->[window],state->[state,getNamespace],timestamp->[timestamp],outputWithTimestamp->[outputWindowedValue,... | This method is called when a timer is created. | Ah, there is a general problem here. The `effectiveTimestamp` is an event time timestamp for the elements that are output from the `@OnTimer` method. The current processing time is in a different time domain that may be different in arbitrary ways. |
@@ -56,6 +56,10 @@ std::string gob_cmd_update_position(
writeV3F1000(os, acceleration);
// yaw
writeF1000(os, yaw);
+ // pitch
+ writeF1000(os, pitch);
+ // roll
+ writeF1000(os, roll);
// do_interpolate
writeU8(os, do_interpolate);
// is_end_position (for interpolation)
| [gob_cmd_update_animation_speed->[str,writeU8,writeF1000],gob_cmd_update_position->[str,writeU8,writeV3F1000,writeF1000],gob_cmd_update_nametag_attributes->[str,writeU8,writeARGB8],gob_cmd_set_properties->[str,writeU8,serialize],gob_cmd_set_texture_mod->[str,writeU8,serializeString],gob_cmd_set_sprite->[writeF1000,writ... | Gob - Command Update Position. | Only send pitch and roll here if automatic_rotate is below `0.001f` or `GenericCAO::processMessage` will be offset at reading the packet when the automatic rotation is disabled. |
@@ -69,10 +69,7 @@ func startNewApplication(t *testing.T, setup ...func(opts *startOptions)) *cltes
sopts.SetConfig(config)
}
- l := config.CreateProductionLogger().With("testname", t.Name())
- sopts.FlagsAndDeps = append(sopts.FlagsAndDeps, l)
app := cltest.NewApplicationWithConfigAndKey(t, config, sopts.Flag... | [Authenticate->[New],RootDir,Exec,SetConfig,BoolFrom,EvmGasPriceDefault,Find,EmptyCLIContext,TriggerPipelineRun,MustRandomUser,SetDefaultHTTPTimeout,Len,Bool,MustInsertRandomKey,Parallel,NoError,Where,LogSQLStatements,AllExternalInitiators,Unmarshal,EqualError,Helper,NewContext,BridgeResponseURL,CreateUser,IntFrom,SetE... | startOptions is a function which sets up the config options and mocks on the app. withKey returns a function that sets WithKey to true and returns a mocked client that. | Push down into `NewApp*` as the default. |
@@ -6744,7 +6744,10 @@ const byte * InterpreterStackFrame::OP_ProfiledLoopBodyStart(const byte * ip)
// mark the stackFrame as 'in try block'
this->m_flags |= InterpreterStackFrameFlags_WithinTryBlock;
- CacheSp();
+ if (shouldCacheSP)
+ {
+ Ca... | [No CFG could be retrieved] | This function is called from the catch block when a try is thrown. if there is a non - zero exception in the current register we need to save it. | > shouldCacheSP [](start = 16, length = 13) Do we also need flip shouldCacheSP right after this if in case we re-enter ProcessTryFinally? |
@@ -125,14 +125,7 @@ public class IndexerSQLMetadataStorageCoordinator implements IndexerMetadataStor
intervals
);
- return intervals
- .stream()
- .flatMap((Interval interval) -> timeline.lookup(interval).stream())
- .flatMap(timelineObjectHol... | [IndexerSQLMetadataStorageCoordinator->[deletePendingSegments->[inTransaction],insertDataSourceMetadata->[inTransaction],createNewSegment->[getPendingSegmentsForIntervalWithHandle],announceHistoricalSegments->[announceHistoricalSegments],updateSegmentMetadata->[inTransaction],deleteSegments->[inTransaction],updateDataS... | Gets all the used segments for the given data source and intervals. | This can result in a different set of holders. `lookup()` can adjust the first and last holders so that they are aligned with the given interval. |
@@ -80,8 +80,8 @@ if (empty($reshook))
{
$error=0;
- $permissiontoadd = $user->rights->stock->creer;
- $permissiontodelete = $user->rights->stock->supprimer;
+ $permissiontoadd = $user->rights->stock->advance_inventory->create;
+ $permissiontodelete = $user->rights->stock->advance_inventory->write;
$backurlforli... | [fetch_optionals,transnoentitiesnoconv,fetch_name_optionals_label,executeHooks,loadLangs,trans,formconfirm,initHooks,showLinkToObjectBlock,close,getOptionalsFromPost,showLinkedObjectBlock,showactions] | This function is used to search for a specific object in the system. Displays a single object in the system. | If the feature "manage advanced permission" is not on, what is the permission to add or delete ? Currently it should be permission to add/update stock. |
@@ -40,13 +40,16 @@ class SpearmanCorrelation(Metric):
mask : `torch.Tensor`, optional (default = None).
A tensor of the same shape as `predictions`.
"""
- predictions, gold_labels, mask = self.unwrap_to_tensors(predictions, gold_labels, mask)
- # Flatten predictions, gold_l... | [SpearmanCorrelation->[get_metric->[reset,numpy,spearmanr],__call__->[unwrap_to_tensors,view,cat],reset->[zeros],__init__->[zeros,super]],register] | This function is called to add a new missing - block element - wise operation to the model. | Note that at initialization time we don't know the device we should use, but here we move it. If it was already in that device, it's a no-op so it's fine. |
@@ -437,6 +437,7 @@ var $AnimateCssProvider = ['$animateProvider', function($animateProvider) {
var temporaryStyles = [];
var classes = element.attr('class');
+ var computedStyles = $window.getComputedStyle(element[0]);
var styles = packageStyles(options);
var animationClosed;
... | [No CFG could be retrieved] | Initialize the object. Get the event class name from the options. | We should probably not call this twice. It's called anyway in the "init" fn. |
@@ -493,8 +493,9 @@ class ElggSite extends ElggEntity {
}
elgg_register_plugin_hook_handler(
'access:collections:write',
- 'user',
- '_elgg_walled_garden_remove_public_access');
+ 'all',
+ '_elgg_walled_garden_remove_public_access',
+ 9999);
if (!elgg_is_logged_in()) {
// ov... | [ElggSite->[__construct->[initializeAttributes],prepareObject->[getDisplayName]]] | Checks if the walled garden is enabled. | Isn't it theoretically possible that a third-party plugin may want to make an exception to this? What would happen if the default priority were used instead or 9999? Would something stop working? |
@@ -1501,7 +1501,7 @@ func TeamNameFromString(s string) (ret TeamName, err error) {
tmp := make([]TeamNamePart, len(parts))
for i, part := range parts {
if !(len(part) >= 2 && len(part) <= 16) {
- return ret, fmt.Errorf("team name wrong size:'%s' %v <= %v <= %v", part, 2, len(part), 16)
+ return ret, errors.... | [FindDeviceKey->[Equal],ToTeamID->[String],Compare->[Compare],Match->[IsNil,String],AsUserOrBust->[AsUser],Exists->[IsNil],SecureEqual->[Equal],Eq->[Eq,Equal,String],ToShortIDString->[ToBytes],ToMediumID->[toBytes],UnixMicroseconds->[Time],GetUID->[GetUID],UnixMilliseconds->[Time],SwapLastPart->[Parent,Append],FindKID-... | AllUserVersions returns a list of all user - versions in the team. ToTeamID returns a TeamID for the given team name. | ok that one was comically bad |
@@ -28,7 +28,16 @@ class TypeFactoryTest extends TestCase
*/
public function testGetType(array $schema, Type $type): void
{
- $typeFactory = new TypeFactory();
+ $typeFactory = new TypeFactory(new ExtractorResourceNameCollectionFactory(
+ new class() implements ExtractorInterfac... | [TypeFactoryTest->[testGetClassType->[will,prophesize,setSchemaFactory,getType,assertSame,reveal],testGetType->[getType,assertSame]]] | Returns a list of types that can be used to retrieve a value of a given type. | Can't you use `this->prophesize(ResourceNameCollectionFactory::class)` instead? It will make the test easier to read |
@@ -118,8 +118,7 @@ static int null_callback(int ok, X509_STORE_CTX *e)
* to match issuer and subject names (i.e., the cert being self-issued) and any
* present authority key identifier to match the subject key identifier, etc.
*/
-static int x509_self_signed_ex(X509 *cert, int verify_signature,
- ... | [No CFG could be retrieved] | Get the most recent version of a certificate s CRL. Find a match in the store that matches the given certificate. | I wonder why we need this as a separate function now. Can't this just be collapsed into `X509_self_signed()` |
@@ -47,6 +47,8 @@
#define PRINT_RECORD(name, type, feats) \
print_record(buf, #name, &name);
+extern char vos_path[64];
+
static void
print_dynamic(struct d_string_buffer_t *buf, const char *name,
const struct daos_tree_overhead *ovhd)
| [No CFG could be retrieved] | Private methods for the VOS - tree - overhead class. Print the contents of the n - tuple in a buffer. | (style) externs should be avoided in .c files |
@@ -1067,7 +1067,10 @@ public class InterpreterFactory implements InterpreterGroupFactory {
public InterpreterSetting getDefaultInterpreterSetting(String noteId) {
return getDefaultInterpreterSetting(getInterpreterSettings(noteId));
}
-
+
+ public boolean isBinded(String noteId, String replName) {
+ re... | [InterpreterFactory->[getDefaultInterpreterSetting->[getDefaultInterpreterSetting,get,getInterpreterSettings],createRepl->[get],getInterpreterListFromJson->[getInterpreterListFromJson],remove->[saveToFile,remove],get->[get,remove,add],close->[add],removeRepository->[saveToFile],restart->[get],createOrGetInterpreterList... | get default interpreter setting by note id. | I think this can be removed now, in favor of `Note.isBinded()`, no? |
@@ -1937,6 +1937,13 @@ Service_Participant::add_discovery(Discovery_rch discovery)
}
}
+void
+Service_Participant::add_shutdown_listener(ShutdownListener *listener)
+{
+ if (listener)
+ shutdown_listener_ = listener;
+}
+
const Service_Participant::RepoKeyDiscoveryMap&
Service_Participant::discoveryMap() co... | [No CFG could be retrieved] | - > Component of the DCPS - > Service Participant - > Create recorder - > Create Replayer - > Create Replayer - > Create Record. | Is this check necessary? |
@@ -215,7 +215,10 @@ class AbstractOneTurnCrowdsourcingTest(AbstractCrowdsourcingTest):
"""
# Set up the mock human agent
- agent_id = self._register_mock_agents(num_agents=1)[0]
+ if self.config.mephisto.blueprint.get("onboarding_qualification", None):
+ agent_id = self._re... | [AbstractParlAIChatTest->[_test_agent_states->[_register_mock_agents]],AbstractOneTurnCrowdsourcingTest->[_get_agent_state->[_register_mock_agents]]] | Get the final agent state. | is there a better way to check if we should test onboarding? Would it be better to pass an onboarding bool variable? |
@@ -148,6 +148,8 @@ module Search
end.compact
end
+ # Search fields based on a range
+ # https://www.elastic.co/guide/en/elasticsearch/reference/7.10/query-dsl-range-query.html
def range_keys
RANGE_KEYS.filter_map do |range_key|
next unless @params.key? range_key
| [FeedContent->[range_keys->[filter_map,key?],terms_keys_present?->[present?,detect],add_sort->[sort_params_present?],range_keys_present?->[present?,detect],filter_conditions->[concat,range_keys_present?,terms_keys_present?],add_highlight_fields->[each],query_hash->[downcase],scoring_functions->[scoring_filter],build_qu... | returns an object with all the keys of the terms that are missing or missing values. | Here we can leverage Postgres itself, as FTS queries can be combined with other conditions. |
@@ -86,6 +86,11 @@ public class DockerJobBundleFactory implements JobBundleFactory {
IdGenerator stageIdGenerator = IdGenerators.incrementingLongs();
ControlClientPool clientPool = MapControlClientPool.create();
+ // Register standard file systems.
+ // TODO Use actual pipeline options.
+ FileSyste... | [DockerJobBundleFactory->[forStage->[create],WrappedSdkHarnessClient->[wrapping->[WrappedSdkHarnessClient,create]],create->[create,DockerJobBundleFactory],close->[close],SimpleStageBundleFactory->[getBundle->[create]]]] | Create a new DockerJobBundleFactory. | This is a strange place to register filesystems. It's also strange this is necessary in order to make the default set of filesystems available. Is this the only way to do it? |
@@ -17,6 +17,8 @@
package org.apache.zeppelin.notebook;
+import static org.apache.commons.lang.StringUtils.*;
+
import java.io.IOException;
import java.io.Serializable;
import java.util.HashMap;
| [Note->[generateParagraphsInfo->[getId],snapshotAngularObjectRegistry->[getId],onOutputAppend->[onOutputAppend],unpersist->[id],isTerminated->[isTerminated],putDefaultReplName->[getDefaultInterpreterName],run->[getParagraph,getId],setName->[normalizeNoteName],addCloneParagraph->[getId],onOutputUpdate->[onOutputUpdate],... | Imports a single object. Package private for unit test. | static import statement is located at the end of all imports statements. Could you please move it? |
@@ -30,6 +30,10 @@ public class ConsoleProcessInfo extends JavaScriptObject
public static final int CHANNEL_WEBSOCKET = 1;
public static final int CHANNEL_PIPE = 2;
+ public static final int AUTOCLOSE_DEFAULT = 0;
+ public static final int AUTOCLOSE_ALWAYS = 1;
+ public static final int AUTOCLOSE_NEV... | [ConsoleProcessInfo->[getExitCode->[cast,getInteger]]] | Returns the handle of the resource. | Should the value here be 2 or is that intentional? |
@@ -31,6 +31,13 @@ func (m singleValueWithLabelsMap) aggregateFn(labelsKey string, labelValues []st
m[labelsKey] = r
}
+func (m singleValueWithLabelsMap) appendUserLabelValue(user string) {
+ for key, mlv := range m {
+ mlv.LabelValues = append([]string{user}, mlv.LabelValues...)
+ m[key] = mlv
+ }
+}
+
func (m... | [SendSumOfCountersPerUser->[SumCounters],SendSumOfHistograms->[SumHistogramsTo],Add->[AddHistogramData],sumOfSingleValuesWithLabels->[sumOfSingleValuesWithLabels],Collect->[Metric],SendSumOfCountersWithLabels->[WriteToMetricChannel,sumOfSingleValuesWithLabels],SendSumOfSummaries->[SumSummariesTo],SendSumOfGaugesWithLab... | aggregateFn aggregates the values of a key - value pair. | Technically `prependUserLabelValue` would be a more accurate name, cause we add at the beginning. |
@@ -2377,8 +2377,8 @@ public class BoundedEquivalentConcurrentHashMapV8<K,V> extends AbstractMap<K,V>
throw new IllegalArgumentException();
if (initialCapacity < concurrencyLevel) // Use at least as many bins
initialCapacity = concurrencyLevel; // as estimated threads
- long size = (... | [BoundedEquivalentConcurrentHashMapV8->[get->[findIfEntriesNeedEvicting,find,equals,tabAt,hashCode,spread,onEntryHitRead,notifyEvictionListener],toString->[toString],CollectionView->[retainAll->[contains,next,remove,iterator,hasNext],size->[size],toArray->[mappingCount],containsAll->[contains],removeAll->[contains,next... | Compares two objects and returns - 1 if k is less than x or equal to k if ObjectVolatile - internal implementation of the Object. | @wburns Do we even need do keep this constructor around? |
@@ -5592,7 +5592,7 @@ void home_all_axes() { gcode_G28(true); }
r = delta_calibration_radius * 0.1;
z_at_pt[CEN] +=
#if HAS_BED_PROBE
- probe_pt(cos(a) * r + dx, sin(a) * r + dy, stow_after_each, 1)
+ probe_pt(cos(a) * r + dx, sin(a) * r + dy, sto... | [No CFG could be retrieved] | Get the z - coordinate of the nearest bonded point. finds the point on the x - axis that is on the y - axis and the. | printable in G33 should always be false center probe probe_pt(dx, dy, stow_after_each, 1, false) no longer behaves weird; so that one is solved. |
@@ -26,14 +26,13 @@ import javax.ws.rs.*;
import javax.ws.rs.core.Response;
import javax.ws.rs.core.Response.Status;
+import org.apache.commons.lang3.StringUtils;
+import org.apache.zeppelin.display.Input;
import org.apache.zeppelin.interpreter.InterpreterSetting;
import org.apache.zeppelin.notebook.Note;
import... | [NotebookRestApi->[createNote->[createNote],cloneNote->[cloneNote]]] | Imports a single - object object from a base class. rest api endpoint for the notebook. | Please let me know if expansions of import are preferred. |
@@ -225,7 +225,7 @@ public final class Http2CodecUtil {
doneAllocating = true;
if (successfulCount == expectedCount) {
promise.setSuccess();
- return super.setSuccess();
+ return setSuccess();
}
}
... | [Http2CodecUtil->[SimpleChannelPromiseAggregator->[tryFailure->[tryFailure],trySuccess->[trySuccess,allowNotificationEvent],setSuccess->[setSuccess,allowNotificationEvent],setFailure->[setFailure]]]] | This method is called when the channel is done allocating. | This doesn't functionally change anything right? I'm trying to understand your `the doneAllocatingPromises accidentally calls the overridden version of setSuccess` statement. Either way `DefaultChannelPromise.setSuccess()` is called here? |
@@ -35,7 +35,9 @@ public class NettyChannelInitializer<A extends ProtocolServerConfiguration> impl
@Override
public void initializeChannel(Channel ch) throws Exception {
ChannelPipeline pipeline = ch.pipeline();
- pipeline.addLast("stats", new StatsChannelHandler(transport));
+ if(transport != nul... | [NettyChannelInitializer->[initializeChannel->[addLast,enabled,pipeline,SniHandler,equals,build,getDecoder,add,ssl,get,createNettySslContext,forEach,StatsChannelHandler]]] | Initialize the channel pipeline. | Does this mean we can't have stats for multi-tenant servers? |
@@ -17,8 +17,12 @@ class AlaveteliPro::DraftInfoRequestBatch < ActiveRecord::Base
include AlaveteliPro::RequestSummaries
belongs_to :user
- has_and_belongs_to_many :public_bodies,
- -> { reorder('public_bodies.name asc') }
+ has_and_belongs_to_many :public_bodies, -> {
+ I18n.with_locale(I18n.locale) d... | [request_summary_body->[body],request_summary_public_body_names->[join],set_default_body->[new,user,body,blank?,name],request_summary_categories->[draft],has_and_belongs_to_many,include,belongs_to,after_initialize,validates_presence_of,reorder] | This method is used to populate the data structures for a single n - ary object. | Explain why this is needed - tests? - commit message explaining why we need the change. |
@@ -48,12 +48,13 @@ INTERNAL_IPS = get_list(os.environ.get("INTERNAL_IPS", "127.0.0.1"))
DATABASES = {
"default": dj_database_url.config(
- default="postgres://saleor:saleor@localhost:5432/saleor", conn_max_age=600
+ default=os.environ.get("DATABASE_STRING", "postgres://saleor:saleor@localhost:543... | [get_list->[strip,split],get_bool_from_env->[literal_eval,ValueError,format],get_host->[get_current],get_currency_fraction,int,pgettext_lazy,_,parse,append,get_list,dirname,__import__,get,insert,init,config,DjangoIntegration,join,normpath,warn,get_bool_from_env] | Get a list of all the unique identifiers for a given object. _. js nouvelle. | We don't need this, there is already `DATABASE_URL` env variable. |
@@ -130,11 +130,10 @@ export default Component.extend({
if (statusType === "silent_close") {
statusType = "close";
}
-
- if (this.basedOnLastPost) {
- return `topic.status_update_notice.auto_${statusType}_based_on_last_post`;
- } else {
- return `topic.status_update_notice.auto_${status... | [No CFG could be retrieved] | Show the status update notice. | `close_after_last_post` is not a "real" type in the DB, it is just the `based_on_last_post` boolean combined with the `close` timer type. |
@@ -40,6 +40,8 @@ public class SleepWork extends AbstractWork {
protected boolean idempotent = true;
+ protected boolean coalescing = false;
+
/**
* Creates a work instance that does nothing but sleep.
*
| [SleepWork->[work->[RuntimeException,interrupt,doWork],toString->[getId,length,getProgress,getSimpleName],doWork->[suspended,getStartTime,sleep,isCanceled,setProgress,Progress,currentTimeMillis,getId,isSuspending],AtomicInteger,incrementAndGet,setProgress,toString,valueOf]] | Creates a new instance of a sleep work. This method is called by the work thread when it is scheduled to start or finish. | This is false by default, no need to set it. |
@@ -1319,7 +1319,7 @@ public class CardBrowser extends NavigationDrawerActivity implements
Intent getAddNoteIntent() {
Intent intent = new Intent(CardBrowser.this, NoteEditor.class);
intent.putExtra(NoteEditor.EXTRA_CALLER, NoteEditor.CALLER_CARDBROWSER_ADD);
- Long did = getLastDeckId();
... | [CardBrowser->[searchCards->[invalidate],openNoteEditorForCurrentlySelectedNote->[openNoteEditorForCard],MarkCardHandler->[actualOnValidPostExecute->[updateCardsInList]],onResetProgress->[getSelectedCardIds],updateList->[updatePreviewMenuItem],SearchCardsHandler->[actualOnPostExecute->[updatePreviewMenuItem,updateList]... | Get an intent to launch the add note action. | Doesn't this override the value if we change deck, since the extra is never dismissed? |
@@ -14,12 +14,15 @@ if sys.version_info < (3, 2, 0):
# alternative forms of installing, as suggested by README.md).
from setuptools import setup
from setuptools.command.build_py import build_py
-from mypy.version import base_version
+from mypy.version import base_version, __version__
from mypy import git
git.ver... | [find_data_files->[append,walk,glob,join],CustomPythonBuild->[pin_version->[write,mkpath,format,join,open],run->[run,execute]],find_data_files,write,verify_git_integrity_or_abort,append,lstrip,setup,exit] | Creates a new object. Creates a version. py file and executes the mypy pin_version. | We'll need a similar exception for 'sdist'. See the misc/upload-pypy.py script, it runs `python3 setup.py bdist_wheel` and `python3 setup.py sdist`. Otherwise this seems to work and solves my problem, so thanks! |
@@ -55,8 +55,12 @@ public class SchemaRegistry {
}
}
- private final Map<TypeDescriptor, SchemaEntry> entries = Maps.newHashMap();
- private final List<SchemaProvider> providers = Lists.newArrayList();
+ Map<TypeDescriptor, SchemaEntry> entries = Maps.newHashMap();
+ ArrayDeque<SchemaProvider> providers;
... | [SchemaRegistry->[getToRowFunction->[getToRowFunction,getProviderResult],createDefault->[SchemaRegistry],getSchema->[getSchema,getProviderResult],getFromRowFunction->[getProviderResult,getFromRowFunction]]] | Creates a default schema registry. | It doesn't look like anything requires the `private final` to be removed? |
@@ -21,9 +21,12 @@ namespace NServiceBus.Features
{
context.Settings.Get<Conventions>().AddSystemMessagesConventions(t => typeof(ScheduledTask).IsAssignableFrom(t));
- var defaultScheduler = new DefaultScheduler();
- context.Container.RegisterSingleton(defaultScheduler);
+ ... | [Scheduler->[Setup->[RegisterSingleton,Register,AddSystemMessagesConventions,IsAssignableFrom],Settings,EnableByDefault,Prerequisite]] | Initialize the task. | I know `DefaultScheduler` is an `internal` class, but do we have any APIs that would let someone get the instance of it from the container anyway? If there is a way, then removing this would be a breaking behavior change. Not immediately sure how that might be possible without reflection, but we do have other APIs that... |
@@ -396,6 +396,12 @@ myapp_vcxproj = r"""<?xml version="1.0" encoding="utf-8"?>
"""
+vs_versions = [{"vs_version": "15", "msvc_version": "19.1", "ide_year": "2017", "toolset": "v141"}]
+
+if "17" in tools_locations['visual_studio'] and not tools_locations['visual_studio']['17'].get('disabled', False):
+ vs_vers... | [test_exclude_code_analysis->[dedent,TestClient,run,GenConanfile,save,load],test_build_vs_project_with_a->[get_vs_project_files,files,gen_function_cpp,dedent,run_command,TestClient,format,run,GenConanfile,gen_function_h,join,save],MSBuildGeneratorTest->[test_custom_configuration->[dedent,TestClient,assertIn,run,GenCona... | Generate a single unique identifier in MSBuild. Generate a single object. | The functional tests for XXXDeps do not need to be repeated for every compiler version, they are practically independent of the VS version, and they are very slow. The way is to parameterize the test with the default VS version, and run only once. If anything some fast unit-test, that doesn't build anything. |
@@ -361,12 +361,7 @@ def load_world_module(
repo = 'parlai_internal'
task = task[9:]
task_path_list = task.split(':')
- if '.' in task_path_list[0]:
- # The case of opt['task'] = 'parlai.tasks.squad.agents:DefaultTeacher'
- # (i.e. specifying your own path directly, assumes Dialo... | [load_world_module->[_get_default_world],load_agent_module->[_name_to_agent_class],load_task_module->[_get_task_path_and_repo],load_teacher_module->[_get_task_path_and_repo,load_task_module]] | Load the world module for the specific environment. Get the object of the missing - block block. | Wtf why did we lower it |
@@ -29,11 +29,11 @@ namespace DSCore
}
/// <summary>
- /// Produce a random number in the range [lower_number, higher_number).
+ /// Produce a random number in the range (lower_number, higher_number).
/// </summary>
- /// <param name="value1">One end of the rang... | [Math->[Max->[Max],IEEERemainder->[IEEERemainder],Exp->[Exp],Round->[Round],Sin->[Sin],Log10->[Log10],Atan2->[Atan2],Cosh->[Cosh],Log->[Log],Tanh->[Tanh],Asin->[Asin],Sign->[Sign],Equals->[Equals],MapTo->[Map],Sum->[Sum],Sqrt->[Sqrt],Average->[Average],Abs->[Abs],Sinh->[Sinh],Ceiling->[Ceiling],Atan->[Atan],Min->[Min],... | Random number between 0 and 1. | This should be `Lower/Higher end of the range for the random number.` |
@@ -102,6 +102,5 @@ if ( ! function_exists('force_download'))
}
}
-
/* End of file download_helper.php */
-/* Location: ./system/helpers/download_helper.php */
\ No newline at end of file
+/* Location: ./system/helpers/download_helper.php */
| [No CFG could be retrieved] | This function download the ethernet network for a specific ethernet network. | I meant the empty line here (you can't remove it via the github online editor, has to be done locally). |
@@ -139,6 +139,7 @@ namespace System.Runtime.InteropServices
/// this <see cref="ComWrappers" /> instance, the previously created COM interface will be returned.
/// If not, a new one will be created.
/// </remarks>
+ [SupportedOSPlatform("windows")]
public IntPtr GetOrCreateC... | [ComWrappers->[TryGetOrCreateObjectForComInstanceInternal->[TryGetOrCreateObjectForComInstanceInternal],CallComputeVtables->[ComputeVtables],TryGetOrCreateComInterfaceForObjectInternal->[TryGetOrCreateComInterfaceForObjectInternal],CallReleaseObjects->[ReleaseObjects],CallCreateObject->[CreateObject]]] | Get a composite interface for the given object. | Can we just mark the whole type as windows specific? |
@@ -44,6 +44,7 @@ def get_json_content(file_path):
def print_error(*content):
'''Print error information to screen'''
print(Fore.RED + ERROR_INFO + ' '.join([str(c) for c in content]) + Fore.RESET)
+ raise
def print_green(*content):
'''Print information to screen in green'''
| [generate_temp_dir->[generate_folder_name],get_file_lock->[SimplePreemptiveLock],check_tensorboard_version->[print_error]] | Print error information to screen in red and green. | someplace continuous use twice `print_error`, like L26 and L39 in this file. |
@@ -51,7 +51,7 @@ class SuluNodeHelper
{
$languages = array();
foreach ($node->getProperties() as $property) {
- preg_match('/^' . $this->languageNamespace . ':(.*?)-template/', $property->getName(), $matches);
+ preg_match('/^' . $this->languageNamespace . ':(.*?)-title/', ... | [SuluNodeHelper->[getLanguagesForNode->[getProperties,getName],extractWebspaceFromPath->[getPath],extractSnippetTypeFromPath->[getPath]]] | Get languages for a node. | This fixes a refression introduced in the PR last night. Not sure how much it would effect us if we released without it. |
@@ -147,8 +147,9 @@ namespace Dynamo.Controls
ViewModel.RequestShowNodeRename += ViewModel_RequestShowNodeRename;
ViewModel.RequestsSelection += ViewModel_RequestsSelection;
ViewModel.NodeLogic.PropertyChanged += NodeLogic_PropertyChanged;
+
}
-
+
... | [dynNodeView->[inputGrid_Loaded->[Execute],OnPreviewIconMouseLeave->[IsInTransition,Visibility,RefreshPreviewIconDisplay,IsCondensed,TransitionToState,Hidden],NickNameBlock_OnMouseDown->[Execute,ClickCount,ViewModel,WriteLine,Handled,CanExecute],OnDataContextChanged->[ViewModel,NewValue],RefreshPreviewIconDisplay->[IsI... | OnNodeViewLoaded is called when the node view is loaded. It adds the necessary methods. | Hi @ramramps these white spaces unnecessarily include this (and few other) file into the review, it is not too big a deal but the PR would be much nicer without them. |
@@ -97,12 +97,5 @@ module Idv
rescue
nil
end
-
- def result
- {
- success: success,
- errors: errors.messages,
- }
- end
end
end
| [ProfileForm->[ssn_is_duplicate_with_old_key?->[ssn_signature]]] | parse the and return an object with the result. | I don't see any use of analytics here, are we basically throwing away these error messages? Should we be recording these anywhere? |
@@ -144,7 +144,7 @@ void CliRunnable::run()
char commandbuf[256];
command_str = fgets(commandbuf, sizeof(commandbuf), stdin);
#else
- command_str = readline("AC>");
+ char* command_str = readline(CLI_PREFIX);
rl_bind_key('\t', rl_complete);
#endif
| [cli_completion->[rl_bind_key,rl_completion_matches],kb_hit_return->[select,FD_ZERO,FD_ISSET,FD_SET],commandFinished->[fflush,printf],run->[GetOption<bool>,free,add_history,printf,feof,fgets,c_str,rl_bind_key,QueueCliCommand,fflush,consoleToUtf8,readline],command_finder->[strncmp,strdup,strlen,size],utf8print->[strlen,... | This is the entry point for the main CLI loop. if command is not finished or stdin is closed kill it. | `fatal error: redefinition of 'command_str'` you need to remove `char* ` |
@@ -0,0 +1,11 @@
+module ProfileFields
+ class AddBaseFields
+ include FieldDefinition
+
+ field "Display email on profile", :check_box
+ field "Name", :text_field, placeholder: "John Doe"
+ field "Website URL", :text_field, placeholder: "https://yoursite.com"
+ field "Summary", :text_area, placeholder:... | [No CFG could be retrieved] | No Summary Found. | For people who reviewed the draft PR previously: I switched this from inheritance to a mixin, as this isn't really "X is a Y" but "X behaves like a Y". |
@@ -197,6 +197,12 @@ module.exports = class JHipsterClientGenerator extends BaseBlueprintGenerator {
this.loadTranslationConfig();
},
+ checkMicrofrontend() {
+ if (this.microfrontend && !this.clientFrameworkAngular) {
+ throw new Error(`Microfrontend requires ${ANGULAR} client fr... | [No CFG could be retrieved] | Public API method used by the getter and by the blueprints. Get the package. json of the installed JHipster client templates and common package. | if this is a new option, then this should be added to the JDL app validation |
@@ -201,4 +201,14 @@ class Salmon
return (($return_code >= 200) && ($return_code < 300)) ? 0 : 1;
}
+
+ /**
+ * @param string $pubkey public key
+ * @return string
+ */
+ public static function salmonKey($pubkey)
+ {
+ Crypto::pemToMe($pubkey, $m, $e);
+ return 'RSA' . '.' . base64url_encode($m, true) . '.'... | [Salmon->[slapper->[get_curl_code,get_curl_headers]]] | This method is used to send a message to a user that has a salmon private key This function is used to create a new key in the Social Social protocol. This function is used to parse the XML response from the server. | I wanted to ask you to rename this function with its actual function, but I'm actually unable to figure out what it is doing exactly, so I guess we'll leave it at that |
@@ -29,10 +29,11 @@ module IdvHelper
fill_in :idv_phone_form_phone, with: '(703) 555-5555'
end
- def click_idv_continue(wait: false)
- url = current_path
- click_on t('forms.buttons.continue'), match: :first
- expect(page).to_not have_current_path(url, wait: 10) if wait
+ def click_idv_continue
+ ... | [fill_out_phone_form_mfa_phone->[fill_out_phone_form_ok]] | click on idv continue button and click on sms and send confirmation code. | `have_no_ancestor` is the funniest method name I have read in a while But this is a great solution, thanks for adding! |
@@ -117,7 +117,7 @@ public class ServerManager implements QuerySegmentWalker
this.cacheConfig = cacheConfig;
this.segmentManager = segmentManager;
- this.joinableFactory = joinableFactory;
+ this.joinableFactoryWrapper = new JoinableFactoryWrapper(joinableFactory);
this.serverConfig = serverConfi... | [ServerManager->[buildAndDecorateQueryRunner->[segment,withWaitMeasuredFromNow,PerSegmentQueryOptimizationContext,SpecificSegmentSpec,safeBuild,toString,getId,getStart,getDataInterval],getQueryRunnerForSegments->[getQuery,getPreJoinableClauses,isQuery,safeBuild,singletonList,mergeRunners,emit,orElse,AtomicLong,getDataS... | Gets a query runner for the given query and intervals. | `JoinableFactoryWrapper` still doesn't seem quite right. These walkers all take a `JoinableFactory` just to make a `JoinableFactoryWrapper` in the constructor. `JoinableFactoryWrapper` doesn't seem to have any state of its own, why not just make it in the joinable module and inject it directly? Or maybe it didn't reall... |
@@ -671,6 +671,10 @@ function _elgg_login_menu_setup($hook, $type, $return, $params) {
*/
function _elgg_extras_menu_setup($hook, $type, $return, $params) {
+ if (!elgg_is_logged_in()) {
+ return;
+ }
+
if (!_elgg_has_rss_link()) {
return;
}
| [elgg_is_menu_item_registered->[getName],elgg_get_menu_item->[getName],elgg_get_breadcrumbs->[getUrlSegments,getFirstUrlSegment,error],_elgg_widget_menu_setup->[getTitle,canEdit],elgg_register_title_button->[canWriteToContainer],elgg_unregister_menu_item->[getName],_elgg_entity_menu_setup->[getGUID,canDelete,canEdit],_... | Setup the menu. | Fine with this but I guess reportedcontent needs to check it. |
@@ -27,6 +27,8 @@ import java.util.Optional;
public final class Row implements TableRow {
+ public static final Row EMPTY_ROW = new Row();
+
private final LogicalSchema schema;
private final GenericKey key;
private final GenericRow value;
| [Row->[of->[Row],withValue->[Row],equals->[equals]]] | Creates a new instance of Row from a given key value and row time. Time is the last record in the table. | I don't think you need to add this. |
@@ -180,6 +180,7 @@ async def mypy_typecheck_partition(
internal_only=True,
pex_path=pex_path_closure([requirements_pex]),
interpreter_constraints=partition.interpreter_constraints,
+ options_scope_name=mypy.options_scope, # TODO: is this correct?
),
)
| [rules->[rules],mypy_typecheck_partition->[generate_argv,determine_python_files],mypy_typecheck->[MyPyPartition]] | Typecheck a specific node in a partition. Get a missing lease. Get a single from the system. | No, only `mypy.pex` needs it. |
@@ -0,0 +1,17 @@
+<?php
+/*
+ * LibreNMS Dantel Webmon poller module
+ *
+ * This program is free software: you can redistribute it and/or modify it
+ * under the terms of the GNU General Public License as published by the
+ * Free Software Foundation, either version 3 of the License, or (at your
+ * option) any later ... | [No CFG could be retrieved] | No Summary Found. | You don't need the trim, snmp_get already does that. |
@@ -124,14 +124,7 @@ public class ZookeeperMetadataStore implements ListenableMetadataStore, SmartLif
}
catch (@SuppressWarnings(UNUSED) KeeperException.NodeExistsException e) {
// so the data actually exists, we can read it
- try {
- byte[] bytes = this.client.getData().forPath(getPath(key));
- ... | [ZookeeperMetadataStore->[updateNode->[put],getKey->[replace],createNode->[put],stop->[stop],start->[start,addListener],remove->[put],MetadataStoreListenerInvokingPathChildrenCacheListener->[childEvent->[getKey,getPath,remove,getVersion]]]] | This method is used to create a new node in the cluster. | Gary, is this fix OK with you? Because we would need to back-port it anyway. |
@@ -146,4 +146,4 @@ class WikiConfig(AppConfig):
body = render_to_string('wiki/email/spam.ltxt',
{'spam_attempt': instance})
send_mail(subject, body, settings.DEFAULT_FROM_EMAIL,
- ['mdn-spam-watch@mozilla.com'])
+ [config.EMAIL_LIST_F... | [WikiConfig->[on_zone_save->[on_document_save],on_document_save->[invalidate_zone_urls_cache,invalidate_zone_stack_cache]]] | Send a spam email to the user when a document spam attempt is saved. | Huh, didn't see that, I wonder if it would make sense to rename the config variable to better express what this is used for (e.g. `EMAIL_LIST_SPAM_WATCH`). |
@@ -31,11 +31,13 @@ import {isExperimentOn} from './experiments';
installDOMTokenListToggle(self);
installFetch(self);
+installKeyboardEventKey(self);
installMathSign(self);
installObjectAssign(self);
installPromise(self);
installDocContains(self);
installArrayIncludes(self);
+installArrayFrom(self);
// isExp... | [No CFG could be retrieved] | Imports the given object into the module. | Can we selectively install these for amp-date-picker? Array.from is already banned in AMP code via conformance-config.textproto. That should alleviate any bundle size bloat concerns. |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.