patch stringlengths 18 160k | callgraph stringlengths 4 179k | summary stringlengths 4 947 | msg stringlengths 6 3.42k |
|---|---|---|---|
@@ -152,6 +152,8 @@ public class DoubleMeanAggregatorFactory extends AggregatorFactory
return DoubleMeanHolder.fromBytes(StringUtils.decodeBase64(StringUtils.toUtf8((String) object)));
} else if (object instanceof DoubleMeanHolder) {
return object;
+ } else if (object instanceof byte[]) {
+ r... | [DoubleMeanAggregatorFactory->[getCombiningFactory->[DoubleMeanAggregatorFactory],finalizeComputation->[getName],getRequiredColumns->[DoubleMeanAggregatorFactory],combine->[getName]]] | Deserialize double mean holder. | can we make byte[] be the firs if check in both places ? |
@@ -0,0 +1,8 @@
+from celery import task
+
+from pulp.app.models import Publisher
+from pulp.tasking import UserFacingTask
+
+@task(base=UserFacingTask)
+def delete_publisher(repo_name, publisher_name):
+ Publisher.objects.filter(name=publisher_name, repository__name=repo_name).delete()
| [No CFG could be retrieved] | No Summary Found. | Another line of whitespace is needed here for PEP8 |
@@ -2172,8 +2172,9 @@ public class TripleAFrame extends MainGameFrame {
}
public Optional<InGameLobbyWatcherWrapper> getInGameLobbyWatcher() {
- if( ServerGame.class.isAssignableFrom(getGame().getClass())) {
- return Optional.of(((ServerGame) getGame()).getInGameLobbyWatcher());
+ if(ServerGame.class... | [TripleAFrame->[setShowChatTime->[setShowChatTime],waitForEndTurn->[waitForEndTurn],selectKamikazeSuicideAttacks->[run->[propertyChange->[run]]],setScale->[setScale],getInGameLobbyWatcher->[getInGameLobbyWatcher],shutdown->[stopGame],actionPerformed->[showMapOnly,showGame,showHistory,gameDataChanged],leaveGame->[stopGa... | Get InGame Lobby Watcher. | Fix here, note the `ofNullable`, 'getInGameLobbyWatcher' will return null in single player games. |
@@ -324,6 +324,13 @@ namespace Microsoft.Xna.Framework.Graphics
}
}
+ //TODO Implement
+ public Color BlendFactor
+ {
+ get;
+ set;
+ }
+
public BlendState BlendState
{
get { return _blendState; }
| [GraphicsDevice->[ApplyRenderTargets->[Clear],DrawUserPrimitives->[DrawUserPrimitives],Dispose->[Clear,Dispose],SetRenderTarget->[SetRenderTarget],SetIndexBuffer,Initialize]] | Sets the color state of the color system. Get the actual blend state object. | What is this? How is this a warning cleanup? |
@@ -177,7 +177,7 @@ def test_token_expired():
server_folder = temp_folder()
server_conf = textwrap.dedent("""
[server]
- jwt_expire_minutes: 0.01
+ jwt_expire_minutes: 0.001
authorize_timeout: 0
disk_authorize_timeout: 0
disk_storage_path: ./data
| [AuthorizeTest->[test_auth_with_env->[_upload_with_credentials]]] | Test token expired. | I had this value before! It was also failing, in this case, the first upload was failing because it expired too soon, and the upload wasn't fast enough to not get expired the token |
@@ -23,7 +23,7 @@ import { toast } from 'react-toastify';
const addErrorAlert = (message, key?, data?) => {
<%_ if (enableTranslation) { _%>
key = key ? key : message;
- toast.error(translate(key, data));
+ toast.error(translate(key, data), { className: key });
<%_ } else { _%>
toast.error(message);
<... | [No CFG could be retrieved] | Provides a middleware that will show a message if the action is not a promise. finds the first alert in the headers and if it s not found it will show a. | what are the class names for? |
@@ -89,3 +89,14 @@ func (p *pod) GenerateFromName(name string, opts ...FieldOptions) common.MapStr
return nil
}
+
+func (p *pod) fixLabels(in common.MapStr) common.MapStr {
+ labels, err := in.GetValue("pod.labels")
+ if err != nil {
+ return in
+ }
+ in.Put("labels", labels)
+ in.Delete("pod.labels")
+
+ return ... | [Generate->[Generate],GenerateFromName->[Generate]] | GenerateFromName generates a pod from the store by name. | Hmm.. "fix" says nothing about the behavior. Could you rename this method to sth less vague? `movePodLabels`, `extractPodLabel`, etc. |
@@ -384,7 +384,7 @@ public class ElasticsearchClient
String nodeId = entry.getKey();
NodesResponse.Node node = entry.getValue();
- if (node.getRoles().contains("data")) {
+ if (node.getRoles().contains("data") || node.getRoles().contains("data_hot") || node.getRoles().c... | [ElasticsearchClient->[close->[close],parseType->[parseType],clearScroll->[clearScroll]]] | Fetches nodes that are not in the cluster. | Can we capture these roles in a `Set` and do `Set#contains` ? |
@@ -134,11 +134,13 @@ export class AbstractApp extends Component {
if (route) {
return (
- <Provider store = { this._getStore() }>
- {
- this._createElement(route.component)
- }
- </Provider>
+ ... | [No CFG could be retrieved] | Creates a ReactElement from the specified component the specified props with which the component is to be The base component that is used to handle the URL property of a component. | I think this can be simplified by passing the i18n prop to the `Provider` below, since `I18nextProvider` looks like a simple wrapper. |
@@ -169,8 +169,8 @@ public final class ProBattleUtils {
}
public static boolean territoryHasLocalLandSuperiority(
- final Territory t, final int distance, final PlayerId player) {
- return territoryHasLocalLandSuperiority(t, distance, player, new HashMap<>());
+ final ProData proData, final Territo... | [ProBattleUtils->[territoryHasLocalNavalSuperiority->[estimateStrengthDifference],territoryHasLocalLandSuperiority->[estimateStrengthDifference,territoryHasLocalLandSuperiority],territoryHasLocalLandSuperiorityAfterMoves->[estimateStrengthDifference]]] | Checks if a territory has a local land superiority with a given distance. | Method `territoryHasLocalLandSuperiority` has 5 arguments (exceeds 4 allowed). Consider refactoring. |
@@ -32,8 +32,10 @@ class Relion(CMakePackage):
electron cryo-microscopy (cryo-EM)."""
homepage = "http://http://www2.mrc-lmb.cam.ac.uk/relion"
- url = "https://github.com/3dem/relion/archive/2.0.3.tar.gz"
+ url = "https://github.com/3dem/relion"
+ version('2.1', git='https://github.com/... | [Relion->[variant,depends_on,version]] | Creates a object that can be used to build a single object in a system. Add cmake_args to the command line arguments for the object. | Why this commit? |
@@ -77,6 +77,17 @@ class Bind(Model):
('consumer_id',),
)
+ class Action:
+ # enumerated actions
+ BIND = 'bind'
+ UNBIND = 'unbind'
+
+ class Status:
+ # enumerated status
+ PENDING = 'pending'
+ SUCCEEDED = 'succeeded'
+ FAILED = 'failed'
+
d... | [ConsumerGroup->[__init__->[super]],ConsumerHistoryEvent->[__init__->[format_iso8601_datetime,super,now,utc_tz]],Consumer->[__init__->[super]],UnitProfile->[__init__->[super]],Bind->[__init__->[super]]] | Initialize a bind object with the specified consumer repository and distributor IDs. | I don't understand these two classes. Bizarre way of doing namespacing. |
@@ -0,0 +1,14 @@
+package io.quarkus.oidc;
+
+import io.quarkus.security.credential.TokenCredential;
+
+public class RefreshToken extends TokenCredential {
+
+ public RefreshToken() {
+ this(null);
+ }
+
+ public RefreshToken(String refreshToken) {
+ super(refreshToken, "refresh_token");
+ }
+... | [No CFG could be retrieved] | No Summary Found. | Previously the package was `io.quarkus.oidc.runtime` google groups thread mentions change in package - *though in a new package* What's the reason for package change ? |
@@ -24,7 +24,7 @@ class AssetTest(LanghostTest):
expected_resource_count=3)
def register_resource(self, _ctx, _dry_run, ty, name, resource,
- _dependencies):
+ _dependencies, _parent, _custom, _protect, _provider):
self.assertEqual(ty, "test... | [AssetTest->[test_asset->[base_path,run_test,join],register_resource->[assertIsInstance,make_urn,assertEqual,fail]]] | Register a resource in the index. | This (and all related changes to test files) is due to a signature change of `register_resource` in `util.py`, the test harness for Python language host tests. |
@@ -270,11 +270,13 @@ final class StatefulParDoEvaluatorFactory<K, InputT, OutputT> implements Transfo
delegateEvaluator.processElement(windowedValue);
}
- Instant currentInputWatermark = timerInternals.currentInputWatermarkTime();
+ final Instant inputWatermarkTime = timerInternals.currentI... | [StatefulParDoEvaluatorFactory->[StatefulParDoEvaluator->[finishBundle->[getKey,finishBundle],processElement->[getWindow,processElement]],cleanup->[cleanup],createEvaluator->[createEvaluator]]] | Process a windowed element. | It can happen that elements processed inside this bundle set timer, so it is technically better to check this before firing any timer. In practice it probably doesn't matter, because DirectRunner currently apparently doesn't fix bundles with timers and bundles with elements. |
@@ -1,6 +1,14 @@
FactoryGirl.define do
+
factory :grouping do
association :group
association :assignment
end
+
+factory :grouping2, class: Grouping do
+ association :group
+ association :assignment
+ inviter { Student.new(section: Section.new) }
+ end
+
end
| [factory,define,association] | Create a new group - by - group factory. | `end` at 12, 2 is not aligned with `factory :grouping2, class: Grouping do` at 8, 0 |
@@ -4042,7 +4042,10 @@ class ExpressionChecker(ExpressionVisitor[Type]):
return AnyType(TypeOfAny.special_form)
else:
generator = self.check_method_call_by_name('__await__', t, [], [], ctx)[0]
- return self.chk.get_generator_return_type(generator, False)
+ ret_ty... | [ExpressionChecker->[visit_star_expr->[accept],analyze_ordinary_member_access->[analyze_ref_expr],check_overload_call->[check_call,infer_arg_types_in_empty_context],visit_await_expr->[accept],check_any_type_call->[infer_arg_types_in_empty_context],erased_signature_similarity->[check_argument_count,check_argument_types]... | Check that the argument to await is an awaitable and extract the type of value. Check that the generator s item type matches the type yielded by the Generator function. Return the type of the object. | expand `ret_type` before `isinstance` |
@@ -714,7 +714,8 @@ describe('form', function() {
expect(form.$error.maxlength[0].$name).toBe('childform');
inputController.$setPristine();
- expect(form.$dirty).toBe(true);
+ // this assertion prevents to propagate prestine to the parent form
+ // expect(form.$dirty).toBe(true);
... | [No CFG could be retrieved] | It should deregister a child form when its DOM is removed. Plots the input in the form and checks that the parent and child nodes are present. | You should change this to `expect(form.$dirty).toBe(false);` and remove the subsequent call to `form.$setPristine()`. |
@@ -48,11 +48,12 @@ func ExecuteRun(run *models.JobRun, store *store.Store, input models.Output) err
unfinished := run.UnfinishedTaskRuns()
offset := len(run.TaskRuns) - len(unfinished)
prevRun := unfinished[0]
- if err := prevRun.Merge(input); err != nil {
- return wrapError(run, err)
- }
- unfinished[0] = prev... | [Ended,Started,Save,Sprintf,Perform,Infow,Now,Debugw,Errorf,Merge,SetError,HasError,For,ForLogger,NewRun,UnfinishedTaskRuns] | BuildRun creates a new run for the given job and executes all of the task runs in startTa - Start a new task. | This means the taskOverrides are used for every TaskRun, not just the first. This is kind of like the behavior of the next story, but a bit different. Either way, it doesn't break any tests so it works for now. |
@@ -675,6 +675,7 @@ namespace System.Runtime.Intrinsics
/// <param name="e29">The value that element 29 will be initialized to.</param>
/// <param name="e30">The value that element 30 will be initialized to.</param>
/// <param name="e31">The value that element 31 will be initialized to.</para... | [No CFG could be retrieved] | Replies the value that element 20 will be initialized to. 9 - Software Fallback. | Note that these method are not Intel specific. They will correspond to other instructions on other architectures. |
@@ -14,8 +14,8 @@ namespace Content.Server.Commands.Observer
public string Command => "ghost";
public string Description => "Give up on life and become a ghost.";
public string Help => "ghost";
- public bool CanReturn { get; set; } = true;
+ [Obsolete("Call IGameTicker.OnGhost... | [Ghost->[Execute->[Player,OnGhostAttempt,ContentData]]] | Execute method of the ghost command. | Well you can't really `Obsolete` this since this is still used by it being a command. |
@@ -153,6 +153,8 @@ namespace System.Runtime.InteropServices
if (_numBytes == Uninitialized)
throw NotInitialized();
+ pointer = null;
+
bool junk = false;
DangerousAddRef(ref junk);
pointer = (byte*)handle;
| [SafeBuffer->[Write->[DangerousRelease,NotInitialized,Unsafe,SpaceCheck,Memmove,DangerousAddRef],ReleasePointer->[NotInitialized,DangerousRelease],AcquirePointer->[NotInitialized,DangerousAddRef],WriteSpan->[Add,DangerousRelease,NotInitialized,Unsafe,SpaceCheck,GetReference,Memmove,DangerousAddRef,Length],SizeOf->[Unsa... | Acquire a pointer to a free memory block. | Could you add pragma warning around this with reference to the issue? |
@@ -25,8 +25,13 @@ import {
import {waitForRenderStart} from '../../../3p/integration';
import {IntersectionObserver} from '../../../src/intersection-observer';
import {viewerFor} from '../../../src/viewer';
+import {performanceFor} from '../../../src/performance';
import {user} from '../../../src/log';
+const ad... | [No CFG could be retrieved] | Creates an instance of the AMP ad API handler. Private functions to register listeners and unregisters the content handler. | Should this be in `ads/_config.js`? |
@@ -89,4 +89,14 @@ public class GameToLobbyConnection {
public void sendChatMessageToLobby(final ChatUploadParams chatUploadParams) {
lobbyWatcherClient.uploadChatMessage(lobbyClient.getApiKey(), chatUploadParams);
}
+
+ public void playerJoined(final String gameId, final UserName playerName) {
+ AsyncRu... | [GameToLobbyConnection->[checkConnectivity->[checkConnectivity],sendKeepAlive->[sendKeepAlive],updateGame->[updateGame],close->[close],postGame->[postGame]]] | Send a chat message to the lobby. | Similar blocks of code found in 2 locations. Consider refactoring. |
@@ -790,10 +790,10 @@ namespace System.Text.Json.Serialization.Metadata
public static System.Text.Json.Serialization.Metadata.JsonTypeInfo<TCollection> CreateDictionaryInfo<TCollection, TKey, TValue>(System.Text.Json.JsonSerializerOptions options, System.Func<TCollection> createObjectFunc, System.Text.Json.Ser... | [No CFG could be retrieved] | This is a convenience method to get the basic information about a collection of objects. The JavaScript code that is used to generate the JavaScript code. | I presume this is changing APIs added in the first PR? Curious what the motivation is here? |
@@ -6,9 +6,10 @@ import (
// Client is a struct for all components necessary to connect to and maintain state of a Kubernetes cluster.
type Client struct {
- informer cache.SharedIndexInformer
- cache cache.Store
- cacheSynced chan interface{}
+ informer cache.SharedIndexInformer
+ cache cache... | [No CFG could be retrieved] | Imports a class from the k8s. io clientgo. tools. cache module. | I don't think announcements are required right now. Please remove. |
@@ -558,14 +558,6 @@ func (i *UIAdapter) DisplayTrackStatement(libkb.MetaContext, string) error {
}
func (i *UIAdapter) DisplayUserCard(mctx libkb.MetaContext, card keybase1.UserCard) error {
-
- // Do not take the server's word on this! Overwrite with what we got above.
- // Depends on the fact this gets called af... | [plumbUncheckedProof->[rowPartial],setRowStatus->[getColorForValid],displayKey->[getColorForValid,priority],FinishWebProofCheck->[finishRemoteCheck],Finish->[sendResult],Cancel->[sendResult],FinishSocialProofCheck->[finishRemoteCheck],plumbStellarAccount->[makeSigchainViewURL,updateRow,priority,getColorForValid],plumbC... | DisplayUserCard displays a user card. | Get rid of this field completely so we don't accidentally mess this up. |
@@ -790,6 +790,13 @@ def install(config, plugins):
except errors.PluginSelectionError as e:
return str(e)
+ custom_cert = (config.key_path and config.cert_path)
+ if not config.certname and not custom_cert:
+ certname_question = "Which certificate would you like to install?"
+ config... | [enhance->[_init_le_client],revoke->[revoke,_delete_if_appropriate,_determine_account],renew_cert->[_init_le_client,_get_and_save_cert],_ask_user_to_confirm_new_names->[_format_list,_get_added_removed],install->[_init_le_client,_install_cert,_find_domains_or_certname],unregister->[_determine_account],certificates->[cer... | Install a previously obtained cert in a server. | Should also change line 805 to match |
@@ -371,6 +371,13 @@ class RawEEGLAB(BaseRaw):
n_chan, n_times = [1, eeg.data.shape[0]]
else:
n_chan, n_times = eeg.data.shape
+
+ # Seem to have transpose with matlab hdf storage
+ if n_chan != eeg.nbchan and n_times == eeg.nbchan:
+ t... | [RawEEGLAB->[__init__->[_check_fname,_get_info,_check_mat_struct]],EpochsEEGLAB->[__init__->[_check_fname,_get_info,_check_mat_struct]],_get_info->[_to_loc]] | Initialize the raw data from a. set file. Initialize the raw EEGLAB object with a sequence of data with the last sample in. | MATLAB is column-major Python is row-major so this is expected This should happen in the h5py branch in `_get_eeg_data` |
@@ -492,9 +492,7 @@ class Jetpack_Core_Json_Api_Endpoints {
* @return array An array of jitms
*/
public static function get_jitm_message( $request ) {
- require_once( JETPACK__PLUGIN_DIR . 'class.jetpack-jitm.php' );
-
- $jitm = Jetpack_JITM::init();
+ $jitm = new JITM_Manager();
if ( ! $jitm ) {
re... | [Jetpack_Core_Json_Api_Endpoints->[remote_authorize->[remote_authorize],build_connect_url->[build_connect_url],verify_registration->[verify_registration]]] | Get the JITM message from the request. | I think packages should be responsible of registering their API endpoints. I would move all this code to the package, what do you all think? |
@@ -265,10 +265,8 @@ describe SubmissionsController do
old_file_1 = old_files['Shapes.java']
old_file_2 = old_files['TestShapes.java']
- @file_1 = fixture_file_upload(File.join('/files', 'Shapes.java'),
- 'text/java')
- @file_2 = fixture_file_upload... | [create,let,week,post_as,current,submit_file,it,contain_exactly,to,respond_with,flatten,with,read,each,marking_state,context,add,render_template,reload,grader_permission,and_return,manage_submissions,be,to_not,let!,t,last,include,start_with,get_latest_result,with_index,update,repository_folder,id,section,include_exampl... | Checks that the content of a node is in the correct layout. Checks that the contents of the given are updated. | Naming/VariableNumber: Use normalcase for variable numbers. |
@@ -498,6 +498,9 @@ export class AmpAd3PImpl extends AMP.BaseElement {
this.xOriginIframeHandler_.freeXOriginIframe();
this.xOriginIframeHandler_ = null;
}
+ if (this.uiHandler) {
+ this.uiHandler.cleanup();
+ }
return true;
}
| [AmpAd3PImpl->[getFullWidthHeight_->[clamp,round,getMatchedContentResponsiveHeightAndUpdatePubParams],attemptFullWidthSizeChange_->[dev,height,min],getLayoutPriority->[METADATA,ADS],isLayoutSupported->[isLayoutSizeDefined],buildCallback->[dev,round,userAssert],unlayoutCallback->[unobserveWithSharedInOb,unlisten],onLayo... | UnlayoutCallback - called when the layout is unloaded. | do we need to set to null? |
@@ -333,7 +333,9 @@ export class AmpAnalytics extends AMP.BaseElement {
`${TAG}: No friendly parent amp-ad element was found for ` +
'amp-analytics tag with iframe transport.');
- this.iframeTransport_ = new IframeTransport(this.getAmpDoc().win,
+ this.iframeTransport_ = new IframeTransport(
+... | [No CFG could be retrieved] | Adds a trigger to the group if it is not already there. Replace the names of keys in params object with the values in replace map. | @zhaoqin I'm wondering why this change was needed. in the case of inabox, `this.win` is always identical to `this.getAmpDoc().win`. |
@@ -86,6 +86,8 @@ namespace Dynamo.Applications
Regeneration(RegenerationOption.Manual)]
public class DynamoRevit : IExternalCommand
{
+ private static List<Action> actions = new List<Action>();
+
private static ExternalCommandData extCommandData;
private static DynamoViewModel ... | [DynamoRevit->[OnApplicationViewActivated->[HandleRevitViewActivated],RevitDynamoModel->[GetRevitContext,Start,Location,Load,GetDirectoryName,Application,GetFullPath],OnApplicationDocumentClosed->[HandleApplicationDocumentClosed],GetRevitContext->[VersionName,Replace],OnApplicationDocumentClosing->[HandleApplicationDoc... | Creates a DynamoRevit object that can be used to execute an external command on the Initialize the core data models and show the window. | I'd like this to be renamed to `idleActions`. |
@@ -220,10 +220,14 @@ func (ms *Status) update(s string) {
}
// update the migration status message with an error message (private)
-func (ms *Status) updateErr(err, s string) {
- logFatal(err, s)
+func (ms *Status) updateErr(errMessage, s string) {
+ logFatal(errMessage, s)
ms.status = "Error: " + s
ms.finishe... | [migrateBerlinToCurrent->[finish],migrateNodeStateToCurrent->[finish,updateErr,taskCompleted,update]] | updateErr is called when an error occurs while processing the transaction. It is called when the. | The migration lock is removed when the finish is called to prevent background migration from running on two ingest services. |
@@ -84,13 +84,14 @@ function SmallVideo(VideoLayout) {
this.disableUpdateView = false;
/**
- * Statistics to display within the connection indicator. With new updates,
- * only changed values are updated through assignment to a new reference.
+ * The current state of the user's bridge connection... | [No CFG could be retrieved] | Displays a constant of type u. u. u. u. u. u. u Private methods for showing the given object. | I used to jam connection status as part of the stats object to be passed in but I separated them because stats are getting accessed directly by ConnectionIndicator. |
@@ -217,8 +217,11 @@ zfs_mod_supported_feature(const char *name)
* libzpool, always supports all the features. libzfs needs to
* query the running module, via sysfs, to determine which
* features are supported.
+ *
+ * The equivalent _can_ be done on FreeBSD by way of the sysctl
+ * tree, but this has not b... | [No CFG could be retrieved] | Check if the system has the required functionality. Creates an array of node features from the specified node. | Just a thought, and definitely not for now, but maybe in the future, this could be redone as a new shiny ZFS_IOC, instead of all platforms finding their own way to query features? Almost a shame we didn't do that with `zpool version` and it could be extended version information. |
@@ -27,8 +27,9 @@ now = timezone.now
def login(request):
local_host = utils.get_local_host(request)
- ctx = {'facebook_login_url': utils.get_facebook_login_url(local_host),
- 'google_login_url': utils.get_google_login_url(local_host)}
+ ctx = {
+ 'facebook_login_url': utils.get_facebook_l... | [logout->[auth_logout,success,redirect,_],change_email->[auth_logout,is_authenticated,get_full_path,_,save,redirect,get,url,success,now,urlencode,TemplateResponse,delete],oauth_callback->[error,_,redirect,unicode,success,get_local_host,OAuth2CallbackForm,items,is_valid,auth_login,get_authenticated_user],login->[get_goo... | Login view for Facebook and Google. | What is the change here? |
@@ -228,7 +228,7 @@ func DefaultInitParams(ctx Context) InitParams {
DiskCacheMode: DiskCacheModeLocal,
DiskBlockCacheFraction: 0.10,
SyncBlockCacheFraction: 1.00,
- Mode: InitDefaultString,
+ Mode: InitDefaultString,
}
}
| [StringVar,MetadataVer,SetBGFlushPeriod,SetKeyServer,EnableJournaling,Info,HasPrefix,PrefetchWorkers,SetBlockServer,New,SetCrypto,Lookup,MakeBlockMetadataStoreIfNotExists,SetKeyBundleCache,MakeLogger,Uint64Var,GetLogDir,Getenv,SetMDOps,BoolVar,SetKeyManager,SetBGFlushDirOpBatchSize,Exit,IntVar,KBFSServiceEnabled,NewKey... | DefaultInitParams returns a default InitParams with all the default values set. - localuser - local - favorite - storage - where to put favorites ; used. | intentional? did `go fmt` rules change at 1.12 and we're only formatting files as they're committed to? |
@@ -174,6 +174,13 @@ public class CompletionRequester
if (StringUtil.isSubsequence(basename(qname.name), tokenFuzzy, true))
newCompletions.add(qname);
}
+ else if(qname.type == RCompletionType.EMOJI)
+ {
+ // narrowing based on the .source
+ i... | [CompletionRequester->[doGetCompletions->[getCompletions],getDplyrJoinCompletionsString->[onError->[onError],usingCache,getDplyrJoinCompletionsString],usingCache->[usingCache],QualifiedName->[equals->[equals],createSnippet->[QualifiedName],compareTo->[compare,compareTo],hashCode->[hashCode],getIconForFilename->[getIcon... | narrow the completions in the cache. private static final int MAX_DEPTH = 0 ;. | space here: `if (qname.type ...` |
@@ -1107,6 +1107,17 @@ public class DefaultMuleContext implements MuleContext {
return getRegistry().lookupObject(OBJECT_CONFIGURATION_COMPONENT_LOCATOR);
}
+ /**
+ * {@inheritDoc}
+ */
+ @Override
+ public PolicyManager getPolicyManager() {
+ if (policyManager == null) {
+ policyManager = getR... | [DefaultMuleContext->[initialise->[initialise],registerListener->[registerListener],isInitialising->[isInitialising],getId->[getClusterId,getId,getConfiguration],isDisposed->[isDisposed],dispose->[dispose,stop],isStopping->[isStopping],getClusterNodeId->[getClusterNodeId],isStarting->[isStarting],disposeManagers->[disp... | Gets the configuration component locator. | why do we need this getter instead of injecting it? |
@@ -331,7 +331,7 @@ static MACHINE_CONFIG_START( tiamc1, tiamc1_state )
/* video hardware */
MCFG_SCREEN_ADD("screen", RASTER)
- MCFG_SCREEN_RAW_PARAMS(PIXEL_CLOCK, 336, 0, 256, 312, 0, 256) // pixel clock and htotal comes from docs/schematics, the rest is guess (determined by undumped PROM)
+ MCFG_SCREEN_R... | [No CFG could be retrieved] | region System Management Functions Manages the configuration of the specific channel. | It should be "the rest is a guess" or "the rest is guesswork". "the rest is a guesswork" is bad grammar. Also, "originall" is a typo. |
@@ -74,7 +74,7 @@ struct dc_tx {
tse_task_t *tx_epoch_task;
/** Transaction flags (DAOS_TF_RDONLY, DAOS_TF_ZERO_COPY, etc.) */
uint64_t tx_flags;
- uint32_t tx_local:1, /* Local TX. */
+ uint32_t tx_fixed_epoch:1, /** epoch is specified. */
tx_retry:1, /** Retry the commit RPC. */
tx_set_resend... | [No CFG could be retrieved] | The client s handle of the sub - request. The number of sub - requests can be held in the cache. | This is a very good change; the "local" name was rather ambiguous. |
@@ -106,8 +106,15 @@ export class CtaLinkComponent {
const refs = htmlRefs(el);
refs['linkText'].textContent = currentLink['text'];
+ el[AMP_STORY_BOOKEND_COMPONENT_DATA] = {
+ position: data.position++,
+ type: BOOKEND_COMPONENT_TYPES.CTA_LINK,
+ };
+
container.appendChil... | [No CFG could be retrieved] | Add attributes to an element. | Is this how it behaves? - 0 heading - 1 small - 2 small - 3 link - 4 link - 5 link - 6 link - 4 small |
@@ -372,9 +372,8 @@ public class SonarComponentsTest {
assertThat(fileLines).hasSize(5);
assertThat(fileLines.get(0)).hasSize(15);
- // One, and only one call made to inputFile contents for SQ>=6.2
- verify(inputFile, times(1)).contents();
- verify(inputFile, times(1)).inputStream();
+ verify(in... | [SonarComponentsTest->[creation_of_custom_test_checks->[postTestExecutionChecks],creation_of_custom_checks->[postTestExecutionChecks],creation_of_both_types_test_checks->[postTestExecutionChecks]]] | read file content from input file. This method checks if the input file contains a known unknown file and if it does it checks. | And what about usage of `inputStream()` ? not required anymore? |
@@ -174,6 +174,11 @@ class _OverloadedBase(_dispatcher.Dispatcher):
# Ensure no autoscaling of integer type, to match the
# typecode() function in _dispatcher.c.
return types.int64
+
+ elif isinstance(val, np.recarray):
+ return types.Array(types.Record.dtype_cac... | [LiftedLoop->[compile->[add_overload,_compile_lock],__init__->[__init__]],Overloaded->[compile->[add_overload,_compile_lock],__init__->[__init__]],_OverloadedBase->[_compile_for_args->[jit],__init__->[__init__]]] | Resolve the Numba type of Python value. | Should that go into resolve_data_type() instead? |
@@ -698,7 +698,7 @@ class TestAnalyzeSentiment(AsyncTextAnalyticsTest):
@GlobalTextAnalyticsAccountPreparer()
@TextAnalyticsClientPreparer()
async def test_opinion_mining_no_mined_opinions(self, client):
- document = (await client.analyze_sentiment(documents=["today is a hot day"], show_opinion_mi... | [AiohttpTestTransport->[send->[CIMultiDictProxy,get,super,CIMultiDict,isinstance]],TestAnalyzeSentiment->[test_bad_model_version_error->[analyze_sentiment,assertIsNotNone,assertEqual],test_opinion_mining_more_than_5_documents->[analyze_sentiment],test_pass_cls->[analyze_sentiment],test_input_with_all_errors->[assertTru... | Test opinion mining on no mined opinions. | i think this call should still include `show_opinion_mining=True` |
@@ -42,11 +42,13 @@ namespace Pulumi
public readonly struct ResourceTransformationResult
{
+ public string Name { get; }
public ResourceArgs Args { get; }
public ResourceOptions Options { get; }
- public ResourceTransformationResult(ResourceArgs args, ResourceOptions option... | [No CFG could be retrieved] | Replies the transformation result of a . | This is technically a breaking change. I'm fine with it here since .NET is in preview and this is not a heavily used API in .NET yet. But I'm curious if @mikhailshilkov or @CyrusNajmabadi have thoughts on how we will manage changes like this in the future? Should we add an overload of the constructor? |
@@ -161,7 +161,7 @@ class FormatOptions
*
* @return string
*/
- public function getFormatKey()
+ public function getFormatKey(): string
{
return $this->formatKey;
}
| [No CFG could be retrieved] | get format key. | same as above we can from bc not add new typehints. |
@@ -251,7 +251,7 @@ namespace Microsoft.Xna.Framework.Graphics
{
if (this.glRenderTargetFrameBuffer > 0)
{
- GL.DeleteFramebuffers(1, ref this.glRenderTargetFrameBuffer);
+ Framebuffer.Delete(this.glRend... | [GraphicsDevice->[PlatformDrawIndexedPrimitives->[PlatformApplyState],PlatformDrawUserPrimitives->[PlatformApplyState,GraphicsDevice],PlatformApplyState->[PlatformApplyState,ActivateShaderProgram],PlatformDrawPrimitives->[PlatformApplyState],PlatformDrawUserIndexedPrimitives->[PlatformApplyState,GraphicsDevice]]] | PlatformDispose - free any unused programs that are not supported by this context. | The call to GraphicsExtensions.CheckGLError is redundant here as you're already calling it in the FramebufferObject class. There are also several other occurrences of this below. You just seemed to have missed this with the FramebufferObject calls, because I can see that you have cleaned this up for the RenderbufferObj... |
@@ -40,7 +40,8 @@ class Device < ApplicationRecord
subtitle: title,
body: body
},
- "thread-id": Settings::Community.community_name
+ "thread-id": Settings::Community.community_name,
+ sound: "default"
},
data: payload
}
| [Device->[create_notification->[ios?,android?,operational?,ios_notification,android_notification],ios_notification->[call,device_token,new,community_name,save!,data,app,app_bundle],android_notification->[notification,new,registration_ids,save!,data,rpush_app,content_available,app,priority],freeze,belongs_to,enum,keys,v... | ios notification for critical appliance. | **non-blocking suggestion:** Since we're now passing in (possibly) a longer text for the body it might make sense to limit the length of it here to avoid going over the PN payload limit. If we add the restriction here it will cover all PNs implemented in the future, instead of limiting each one individually. Maybe `.tr... |
@@ -1940,6 +1940,10 @@ namespace ProtoScript.Runners
/// <returns></returns>
public IDictionary<Guid, List<ProtoCore.Runtime.WarningEntry>> GetRuntimeWarnings()
{
+ var ret = new Dictionary<Guid, List<ProtoCore.Runtime.WarningEntry>>();
+ if (runtimeCore == null)
+ ... | [LiveRunner->[CompileAndExecute->[Compile,Execute],Compile->[Compile],Execute->[ReInitializeLiveRunner,SetupRuntimeCoreForExecution],ApplyUpdate->[Execute,ApplyUpdate],CompileAndExecuteForDeltaExecution->[ResetForDeltaExecution,CompileAndExecute,PostExecution],SynchronizeInternal->[CompileAndExecuteForDeltaExecution,Up... | Get the warnings that have occurred in the last time the last warning was found. | Thanks for this. Was there a simple workflow to get this bug? Im just curious to know when this is called when the rutnimeCore was null |
@@ -211,6 +211,9 @@ static void _update(dt_lib_module_t *self)
gtk_widget_set_sensitive(GTK_WIDGET(d->clear_metadata_button), act_on_cnt > 0);
gtk_widget_set_sensitive(GTK_WIDGET(d->refresh_button), act_on_cnt > 0);
+
+ gtk_widget_set_sensitive(GTK_WIDGET(d->set_monochrome_button), act_on_cnt > 0);
+ gtk_widg... | [No CFG could be retrieved] | Set widget properties to be case sensitive Callback for all user interface events. | could we refine this ? taking the flags and checking for DT_IMAGE_MONOCHROME_PREVIEW is too slow (this has been tested already). But one there is a single image selected we may want to set active only the button that will do something. At the same time this is a nice feedback about how the image is flagged. How does th... |
@@ -71,6 +71,8 @@ class WPSEO_Admin {
add_action( 'admin_init', array( $this, 'map_manage_options_cap' ) );
+ add_action( 'init', array( $this, 'check_php_version' ) );
+
WPSEO_Sitemaps_Cache::register_clear_on_option_update( 'wpseo' );
WPSEO_Sitemaps_Cache::register_clear_on_option_update( 'home' );
| [WPSEO_Admin->[check_php_version->[show_unsupported_php_message,on_dashboard_page],initialize_cornerstone_content->[register_hooks],enqueue_assets->[enqueue_style],initialize_seo_links->[add_notification,remove_notification],add_action_link->[get_slug,is_activated],localize_admin_global_script->[get_dismiss_url],set_up... | This method is called by the constructor of the admin interface. This is the main entry point for all the administration actions. Initialize all WordPress integration objects. | As this functionality only needs to run in the `admin` area, this should be `admin_init` |
@@ -1487,9 +1487,12 @@ def range(start, limit=None, delta=1, dtype=None, name="range"): # pylint: disa
start, limit = 0, start
with ops.name_scope(name, "Range", [start, limit, delta]) as name:
- start = ops.convert_to_tensor(start, dtype=dtype, name="start")
- limit = ops.convert_to_tensor(limit, dtyp... | [reduce_max->[_ReductionDims],to_double->[cast],reduce_sum->[_ReductionDims],reciprocal_no_nan->[div_no_nan],scalar_mul_v2->[scalar_mul],tensor_equals->[equal],_ReductionDims->[range],reduce_std->[reduce_variance],reduce_all->[_may_reduce_to_scalar,_ReductionDims],accumulate_n->[add_n,_input_error],xlog1py->[xlog1py],t... | Creates a sequence of numbers that begins at start and extends by increments of delta up to Create a range of objects. | convert_to_tensor already is a no-op if the input is a tensor, so what is this doing? |
@@ -198,8 +198,8 @@ def main():
# Prompt the user if there are workers that have not timed out
if filter(lambda worker: (UTCDateTimeField().to_python(datetime.now()) -
- worker['last_heartbeat']).total_seconds() <
- constants.CELERY_TIMEOUT_SECONDS, ... | [main->[parse_args],migrate_database->[DataError],_auto_manage_db->[migrate_database],parse_args->[parse_args]] | This is the main entry point for the protocol. | It's not clear to me that the left side of the `<` operand is a datetime object except by seeing that we were calling `.total_seconds()` on it before. I like this change as a fix to make things happy on el6 again, but would love to see this code get a readability pass at some point. |
@@ -487,8 +487,6 @@ class T5Attention(AttentionModule):
relative_attention_num_buckets=relative_attention_num_buckets,
)
- self.attn = Attention.by_name(self.scoring_func)(scaling_factor=1, normalize=False)
-
def forward( # type: ignore
self,
hidden_states: torch.T... | [AttentionModule->[_get_attention_probs->[_position_bias],_project->[_transpose_for_scores],forward->[_get_attention_probs,_project,_query_layer,AttentionOutput,_output_layer,_get_lengths],_query_layer->[_transpose_for_scores],compute_bias->[_relative_position_bucket]]] | Initialize a attention layer. Forward filter for missing keys. | @AkshitaB, this is where the scaling factor is forced to `1`. |
@@ -23,7 +23,7 @@ module Idv
return false if window_expired?
# too many attempts in the window
- attempts >= idv_max_attempts && !window_expired?
+ attempts >= self.class.idv_max_attempts && !window_expired?
end
def window_expired?
| [Attempter->[reset->[update!],attempts->[idv_attempts],idv_max_attempts->[to_i],window_expired?->[present?,idv_attempted_at,now],idv_attempt_window->[hours],increment->[update!,idv_attempts,now],reset_attempts?->[window_expired?],exceeded?->[window_expired?],attr_reader]] | Checks if a given is exceeded by the IDV. | interesting that you moved to a class method! What's the thinking there? |
@@ -42,6 +42,12 @@ func (r *Runtime) NewContainer(ctx context.Context, rSpec *spec.Spec, options ..
}
ctr.config.StopTimeout = CtrRemoveTimeout
+ // Set namespace based on current runtime namespace
+ // Do so before options run so they can override it
+ if r.config.Namespace != "" {
+ ctr.config.Namespace = r.co... | [GetRunningContainers->[GetContainers],LookupContainer->[LookupContainer],removeContainer->[RemoveContainer],HasContainer->[HasContainer],GetContainersByList->[LookupContainer],GetLatestContainer->[GetAllContainers]] | NewContainer creates a new container Initialize the container root filesystem Add the container to the state. | Minor nit: I think we can set it unconditionally and avoid the string compare. |
@@ -244,3 +244,11 @@ def test_generalization_across_time():
cv=2, clf=clf, predict_type=pt)
gat.fit(epochs, y=y_)
gat.score(epochs, y=y_)
+
+ # Test score without passing epochs
+ gat = GeneralizationAcrossTime()
+ with warnings.cat... | [test_time_generalization->[Raw,read_events,max,keys,time_generalization,catch_warnings,min,len,assert_true,Epochs,pick_types],test_generalization_across_time->[predict,read_events,hasattr,max,catch_warnings,sum,assert_raises,enumerate,shape,min,assert_equal,copy,SVC,GeneralizationAcrossTime,len,isinstance,score,Raw,as... | Test on time generalization within one time period. Missing - time - related data - structures. GeneralizationAcrossTime - GeneralizationAcrossTime method. Fit the model and predict the last non - probabilistic non - probabilistic non Test if a sequence of n - classes is missing. | don't refit for just testing this. It's a waste of test time |
@@ -305,8 +305,10 @@ class doc_generic_order_odt extends ModelePDFCommandes
$contactobject = null;
if (!empty($usecontact))
{
- if ($usecontact && ($object->contact->fk_soc != $object->thirdparty->id && (!isset($conf->global->MAIN_USE_COMPANY_NAME_OF_CONTACT) || !empty($conf->global->MAIN_USE_COMPANY... | [doc_generic_order_odt->[info->[textwithpicto,transnoentitiesnoconv,loadLangs,trans],write_file->[fetch,getMessage,setSegment,exportAsAttachedPDF,get_translations_for_substitutions,get_substitutionarray_each_var_object,setImage,get_substitutionarray_thirdparty,get_substitutionarray_user,get_substitutionarray_contact,in... | Write an odt file This function creates a directory structure and returns - 1 if the directory does not exist. Dodaje dane nur von nur von nur von This function is called by the ODT substitution system. | Th isset was to avoid warning with php8 when param is not set |
@@ -32,9 +32,9 @@ class Rocprim(CMakePackage):
for ver in ['3.5.0', '3.7.0', '3.8.0', '3.9.0', '3.10.0', '4.0.0', '4.1.0',
'4.2.0']:
depends_on('hip@' + ver, type='build', when='@' + ver)
- depends_on('rocm-device-libs@' + ver, type='build', when='@' + ver)
depends_on('com... | [Rocprim->[setup_build_environment->[set],cmake_args->[format],variant,depends_on,version]] | Setup the environment for Hipcc. | can you add depends_on('llvm-amdgpu@' + ver, type='build', when='@' + ver) . this fails to build for 4.2.0, 4.1.0,4.0.0 |
@@ -88,14 +88,14 @@ module Api
unless new_assignment.save
# Some error occurred
- render 'shared/http_status', :locals => {:code => '500', :message =>
- HttpStatusHelper::ERROR_CODE['message']['500']}, :status => 500
+ render 'shared/http_status', locals: {code: '500', message:
... | [AssignmentsController->[create->[nil?,render,new,process_attributes,submission_rule,has_missing_params?,get_submission_rule,find_by_short_identifier,build_assignment_stat,save],show->[nil?,xml,render,respond_to,to_json,fields_to_render,json,to_xml,find_by_id],process_attributes->[nil?,new,post?,each,delete],update->[n... | Creates a new n - node node with the given short identifier. | Align the elements of a hash literal if they span more than one line.<br>Space inside } missing. |
@@ -372,14 +372,12 @@ class RegionProposalNetwork(torch.nn.Module):
# do not backprop throught objectness
objectness = objectness.detach()
objectness = objectness.reshape(num_images, -1)
-
levels = [
torch.full((n,), idx, dtype=torch.int64, device=device)
fo... | [concat_box_prediction_layers->[permute_and_flatten],AnchorGenerator->[forward->[set_cell_anchors,cached_grid_anchors],set_cell_anchors->[generate_anchors],cached_grid_anchors->[grid_anchors]],RegionProposalNetwork->[_get_top_n_idx->[pre_nms_top_n,_onnx_get_num_anchors_and_pre_nms_top_n],forward->[concat_box_prediction... | Filter proposals based on nms and the objectness. Returns the final scores of the boxes. | nit: could you revert the spacing changes? |
@@ -18,8 +18,10 @@ def get_sort_by_url(context, field, descending=False):
@register.inclusion_tag('menu.html', takes_context=True)
-def menu(context, slug, horizontal=False):
+def menu(context, site_menu=None, horizontal=False):
+ if not site_menu:
+ return
menus = context[NAVIGATION_CONTEXT_NAME]
-... | [menu->[all,next],get_sort_by_url->[dict,urlencode],inclusion_tag,Library,simple_tag] | Get menu items by menu slug. | What is the purpose of having nullable `site_menu`? |
@@ -78,8 +78,11 @@ namespace Dynamo.PackageDependency
public void Loaded(ViewLoadedParams viewLoadedParams)
{
- DependencyView = new PackageDependencyView(viewLoadedParams);
- viewLoadedParams.AddToExtensionsSideBar(this, DependencyView);
+ DependencyView = new Packa... | [PackageDependencyViewExtension->[Shutdown->[Dispose]]] | This method is called when the view is loaded. It creates a package dependency view and adds. | Dont think this line is needed, when the Loaded function gets called, it is almost always right after Dynamo initiation so you are always looking at a blank workspace, in that case the check will always be `false`. What do you think? |
@@ -753,8 +753,9 @@ namespace Js
}
}
- if (!isShutdown && unregisteredInlineCacheCount > 0 && !scriptContext->IsClosed())
+ if (unregisteredInlineCacheCount > 0)
{
+ AssertMsg(!isShutdown && !scriptContext->IsClosed(), "Unregistration of ... | [No CFG could be retrieved] | Allocate inline cache - this is called by ScriptFunctionWithInlineCache. uint - > RootObjectBase - > ThreadContext - > RootObjectBase - >. | How is it okay to remove the shutdown and scriptContext closed conditions? |
@@ -59,8 +59,8 @@ class DownloadedPexBin(HermeticPex):
@rule
async def download_pex_bin() -> DownloadedPexBin:
# TODO: Inject versions and digests here through some option, rather than hard-coding it.
- url = 'https://github.com/pantsbuild/pex/releases/download/v1.6.12/pex'
- digest = Digest('ce64cb72cd23d2123dd... | [DownloadedPexBin->[create_execute_request->[list,super]],download_pex_bin->[DownloadedPexBin,Get,UrlToFetch,Digest],dataclass] | Download the pex binary. | I'm totally ok leaving this hardcoded for now, but want to note that it's easy to make into a subsystem whenever that becomes necessary. |
@@ -82,9 +82,9 @@ class CompareTwoFilesCheckProcess(KratosMultiphysics.Process, KratosUnittest.Tes
Please see the respective files for details on the format of the files
"""
- KratosMultiphysics.DataCommunicator.GetDefault().Barrier()
+ KratosMultiphysics.Testing.GetDefaultDataCommunic... | [CompareTwoFilesCheckProcess->[__CompareDatFileVariablesTimeHistory->[__GetFileLines],__CompareVtkFile->[CompareData->[CompareFieldData->[ReadVectorFromLine],CompareFieldData],CompareCellTypes->[ReadVectorFromLine],CompareCells->[ReadVectorFromLine],ComparePoints->[ReadVectorFromLine],CompareData,ComparePoints,CheckHea... | Executes finalization of the comparison. | Just for me to know. Shouldn't we take it from the parallel environment in here? (even though this is normally used for the testing we are out of the scope of a test). |
@@ -117,7 +117,13 @@ class TestTrainer(AllenNlpTestCase):
trainer = Trainer(MetaDataCheckWrapper(self.model), self.optimizer,
multigpu_iterator, self.instances, num_epochs=2,
cuda_device=[0, 1])
- trainer.train()
+ metrics = trainer.train()
+ ... | [TestTrainer->[test_trainer_can_run_multiple_gpu->[MetaDataCheckWrapper->[forward->[forward]],MetaDataCheckWrapper],test_trainer_raises_on_model_with_no_loss_key->[FakeModel],test_trainer_respects_keep_serialized_model_every_num_seconds->[WaitingIterator]]] | Test trainer for training on multiple GPU. | Does it make sense to check if it's above 0? |
@@ -62,11 +62,11 @@ class MockHandler(logging.Handler):
class CertificateClientTests(CertificatesTestCase, KeyVaultTestCase):
- CERT_CONTENT_PASSWORD_ENODED = b"0\x82\t;\x02\x01\x030\x82\x08\xf7\x06\t*\x86H\x86\xf7\r\x01\x07\x01\xa0\x82\x08\xe8\x04\x82\x08\xe40\x82\x08\xe00\x82\x06\t\x06\t*\x86H\x86\xf7\r\x01\x... | [CertificateClientTests->[test_crud_operations->[_validate_certificate_bundle],test_backup_restore->[_validate_certificate_bundle],_validate_certificate_issuer->[_admin_contact_equal],test_crud_issuer->[_validate_certificate_issuer,_validate_certificate_issuer_properties],test_list_certificate_versions->[_import_common... | Import a common certificate. | Suggest using the same certs in both modules and having one import them from the other |
@@ -183,11 +183,12 @@ def norm(input, p='fro', axis=None, keepdim=False, out=None, name=None):
input (Variable): The input tensor could be N-D tensor, and the input data
type could be float32 or float64.
p (float|string, optional): Order of the norm. Supported values are `fro`, `1`, `2`,
... | [cross->[cross],bmm->[bmm],matmul->[__check_input,matmul],norm->[frobenius_norm,vector_norm],histogram->[histogram]] | Normalizes the matrix or vector norm of a given tensor. Computes the frobenius norm along last two dimensions. Calculate the p - order vector norm for certain dimension of Tensor input. calculate vector norm frobenius norm with p - order vector norm with p - order. | input -> x |
@@ -84,7 +84,7 @@ public:
ItemPosCountVec dest;
uint8 msg = player->CanStoreNewItem(NULL_BAG, NULL_SLOT, dest, 11522, 1, NULL);
if (msg == EQUIP_ERR_OK)
- player->StoreNewItem(dest, 11522, 1, true);
+ player->StoreNewItem(dest, 115... | [npc_aquementas->[npc_aquementasAI->[UpdateAI->[SendItem]]]] | Send a new item if it is not already present in the player s list. | Was it an error ? Because `player->StoreNewItem(ItemPosCountVec, uint32, int32, bool)` doesn't exist |
@@ -15,6 +15,18 @@ import (
// Markdown render markdown document to HTML
// see https://github.com/gogits/go-gogs-client/wiki/Miscellaneous#render-an-arbitrary-markdown-document
func Markdown(ctx *context.APIContext, form api.MarkdownOption) {
+ // swagger:route POST /markdown renderMarkdown
+ //
+ // Consumes:
... | [Write,Body,Error,URLJoin,RenderWiki,GetErrMsg,Bytes,Render,RenderRaw,HasAPIError] | Markdown renders a single - line document to HTML or Markdown raw. | Maybe update the doc links while you're at it :) |
@@ -125,10 +125,10 @@ info = mne.create_info(
###############################################################################
# It is necessary to supply an "events" array in order to create an Epochs
-# object. This is of `shape(n_events, 3)` where the first column is the sample
-# number (time) of the event, the ... | [randn,custom_epochs,RawArray,plot,dict,print,EpochsArray,mean,EvokedArray,set_montage,create_info,array] | Create an Epochs object from a given n_events array. This function is used to provide information about the event codes that were specified in the sequence. | there's an extra backtick here after the closing paren |
@@ -431,6 +431,8 @@ type PackageSpec struct {
Homepage string `json:"homepage,omitempty"`
// License indicates which license is used for the package's contents.
License string `json:"license,omitempty"`
+ // Attribution allows freeform text attribution of derived work, if needed.
+ Attribution string `json:"attri... | [bindObjectType->[bindProperties],bindProperties->[bindType],String->[String],bindType->[String,bindType],bindObjectType,bindProperties,String] | is a serializable description of a Pulumi package. | Given how we're using this - I might just rename this to `Notes` to be more generic. |
@@ -936,8 +936,9 @@ func benchmark_1_imageStream(identity, maxTags, sequence int32, round, index int
// updateBuildConfigImages updates the LastTriggeredImageID field on a build config.
func updateBuildConfigImages(bc *buildapi.BuildConfig, tagRetriever trigger.TagRetriever) (*buildapi.BuildConfig, error) {
var upd... | [Instantiate->[Instantiate],ImageChanged->[ImageChanged],Add->[Add],Modify->[Modify],Modify,Get,All,List,Add,Update,ImageStreamTag,Len] | Benchmark_1_imageStream returns a new image stream with random tags alterBuildConfigFromTriggers will alter the incoming build config based on the trigger changes passed to it. | The point of this method is to return "new object with no shared memory, or nil". If bc was mutated, GetInputReference is broken (mutating, and must be fixed) or DeepCopy is broken (mutating, and must be fixed). I don't see how this change helps |
@@ -288,12 +288,13 @@ def piecewise_decay(boundaries, values):
shape=[1], dtype='float32', value=float(values[i]))
with switch.case(global_step < boundary_val):
tensor.assign(value_var, lr)
+ tensor.assign(lr, final_lr)
last_value_var = tensor.fill_cons... | [polynomial_decay->[_decay_step_counter],noam_decay->[_decay_step_counter],exponential_decay->[_decay_step_counter],append_LARS->[_balanced_weight],piecewise_decay->[_decay_step_counter],natural_exp_decay->[_decay_step_counter],inverse_time_decay->[_decay_step_counter]] | Applies piecewise decay to the initial learning rate. This function decay the learning rate of a variable. | why is final_lr assigned here? I think it's enough to do one assign at last? |
@@ -837,4 +837,5 @@ module.exports = {
printNobuildHelp,
watchDebounceDelay,
shouldUseClosure,
+ mangleIdentifier,
};
| [No CFG could be retrieved] | Print the help text for the nobuild. | Why are you exporting this? |
@@ -48,7 +48,10 @@ def setup_args(parser=None):
)
parser.add_argument('--outfile', type=str, default='/tmp/selfchat.json')
parser.add_argument(
- '--format', type=str, default='json', choices={'parlai', 'json'}
+ '--format', type=str, default='jsonl', choices={'parlai', 'jsonl'}
+ )
+ ... | [setup_args->[ParlaiParser,add_cmdline_args,set_defaults,add_argument],self_chat->[time,hasattr,print_args,parley,write,print,create_agent,parse_args,clone,get,WorldLogger,log,create_task,isinstance,seed,float,TimeLogger,display],setup_args,parse_args,self_chat] | Setup command line arguments for self chat with a model. | Is there particularly a reason to need to vary the indent? |
@@ -32,6 +32,9 @@ public interface IEditDelegate extends IRemote, IPersistentDelegate {
@RemoteActionCode(3)
String changePUs(GamePlayer player, int pus);
+ @RemoteActionCode(13)
+ String changeResource(GamePlayer player, String resourceName, int newTotal);
+
@RemoteActionCode(1)
String addTechAdvance(G... | [No CFG could be retrieved] | Add or remove a sequence of technical adversarials. | What's the consideration to keeping the changePU method around? I'd be in favor to remove it in favor of the new updated and more generic method. |
@@ -1254,7 +1254,7 @@ func NewXORMLogService(disableConsole bool) {
if err = os.MkdirAll(path.Dir(logPath), os.ModePerm); err != nil {
panic(err.Error())
}
- logPath = filepath.Join(filepath.Dir(logPath), "xorm.log")
+ logPath = path.Join(filepath.Dir(logPath), "xorm.log")
logConfigs = fmt.Sprint... | [DelLogger,KeysHash,MustCompilePOSIX,Warn,NewWithClaims,TempDir,Info,MapTo,New,ParseIP,Split,MustString,SetUseHTTPS,NewSection,NewXORMLogger,Getenv,Trim,IsFile,Dir,TrimRight,Now,Close,ReadFull,Append,LookPath,Create,Section,GetSection,ToLower,MkdirAll,BinVersion,MustDuration,Minutes,Decode,Keys,Fatal,HomeDir,Count,Must... | Generate log configuration. Missing configuration for log messages. | Why change `filepath` to `path`? |
@@ -530,7 +530,7 @@ static INPUT_PORTS_START( ql )
PORT_BIT( 0x01, IP_ACTIVE_HIGH, IPT_KEYBOARD ) PORT_NAME("ENTER") PORT_CODE(KEYCODE_ENTER) PORT_CHAR(13)
PORT_BIT( 0x02, IP_ACTIVE_HIGH, IPT_KEYBOARD ) PORT_NAME(UTF8_LEFT) PORT_CODE(KEYCODE_LEFT) PORT_CHAR(UCHAR_MAMEKEY(LEFT))
PORT_BIT( 0x04, IP_ACTIVE_HIGH, IPT... | [No CFG could be retrieved] | Write 8 - bit ethernet header fields from 16 - bit address space to 16 - bit region ethernet interface for all 8 - bit keyboard columns. | This one doesn't really need to be de-`char`ified, it doesn't cause signed char to wrap and get extended. ;) |
@@ -118,6 +118,9 @@ public class ZeppelinServer extends Application {
notebook.addNotebookEventListener(heliumApplicationFactory);
notebook.addNotebookEventListener(notebookWsServer.getNotebookInformationListener());
+
+ remoteWorksManager = new RemoteWorksManager(notebook);
+ replFactory.setRemoteCon... | [ZeppelinServer->[setupNotebookServer->[setInitParameter,getWebsocketMaxTextMessageSize,ServletContextHandler,NotebookServer,addServlet,ServletHolder],getSslContextFactory->[getTrustStorePassword,SslContextFactory,getKeyManagerPassword,getKeyStorePassword,getKeyStoreType,setKeyStorePath,setKeyStorePassword,setTrustStor... | Main method for Zeppelin. | `remoteWorksManager.getInstance()` is invoked here only, not anywhere else. That means we don't need singleton pattern here. |
@@ -361,7 +361,7 @@ class DefineWakeProcess3D(KratosMultiphysics.Process):
elem.Id = counter
counter +=1
- from gid_output_process import GiDOutputProcess
+ from KratosMultiphysics.gid_output_process import GiDOutputProcess
output_file = "representation_of_wake"
... | [DefineWakeProcess3D->[__VisualizeWake->[ExecuteInitialize],__ComputeNodalDistancesToWakeAndLowerSurface->[DotProduct],__ComputeLowerSurfaceNormals->[DotProduct],__init__->[DotProduct,__init__]]] | Visualize the wake node. | Please move all the imports to the top part of the file. We experienced some issues with recursive imports in the past. Besides this is a good practise according to the PEP-8 style guide. |
@@ -473,11 +473,12 @@ angular.module('ngAnimate', ['ng'])
function isMatchingElement(elm1, elm2) {
return extractElementNode(elm1) == extractElementNode(elm2);
}
-
+ var $$jqLite;
$provide.decorator('$animate',
- ['$delegate', '$$q', '$injector', '$sniffer', '$rootElement', '$$asyncCallb... | [No CFG could be retrieved] | Provides a decorator to enable or disable the on the root element. Executes the root animation. | PTAL --- I've added a commit which exposes jqLite via a private service. Unfortunately, because of the structure of ngAnimate, not every function has access to it. I found it easier to just put a variable here, but I don't see why these functions need to be outside of the decorator, so it's easy to move them too. What ... |
@@ -97,12 +97,5 @@ module Idv
rescue
nil
end
-
- def result
- {
- success: success,
- errors: errors.messages,
- }
- end
end
end
| [ProfileForm->[ssn_is_duplicate_with_old_key?->[ssn_signature]]] | parse the and return an object with the result. | I don't see any use of analytics here, are we basically throwing away these error messages? Should we be recording these anywhere? |
@@ -328,10 +328,10 @@ class GradientDescentTrainer(Trainer):
self,
model: Model,
optimizer: torch.optim.Optimizer,
- data_loader: torch.utils.data.DataLoader,
+ data_loader: DataLoader,
patience: Optional[int] = None,
validation_metric: str = "-loss",
- ... | [GradientDescentTrainer->[_validation_loss->[batch_outputs],_train_epoch->[rescale_gradients,train,batch_outputs],train->[_validation_loss,_train_epoch]]] | Initialize a single object. Initializes the variables related to a single node of the AllenNLP model. Wraps the Pytorch model object in a DistributedDataParallel object. | There are small parts of the guide that should be updated with this change. Not sure how to keep this in sync with the guide / when to release things. |
@@ -100,6 +100,7 @@ See the @{$python/math_ops} guide.
@@complex
@@conj
@@imag
+@@arg
@@real
@@fft
@@ifft
| [reduce_max->[_ReductionDims],to_double->[cast],reduce_sum->[_ReductionDims],_ReductionDims->[range],reduce_all->[_ReductionDims],_mul_dispatch->[_mul],truediv->[_truediv_python3],_neg->[negative],to_int64->[cast],_as_indexed_slices_list->[_as_indexed_slices,cast],cast->[cast],saturate_cast->[cast],tensordot->[_tensord... | @@def ill - ill - ill - ill - ill - i A function to generate a unique object in a sparse network. | I'd argue we should perhaps only put this in tf.math.arg rather than in the root namespace. It doesn't seem that commonly used. |
@@ -650,3 +650,18 @@ export function checkCorsUrl(url) {
export function tryDecodeUriComponent(component, opt_fallback) {
return tryDecodeUriComponent_(component, opt_fallback);
}
+
+/**
+ * Adds the path to the given url.
+ * @param {string} url
+ * @param {string} path
+ * @return {string}
+ */
+export function ... | [No CFG could be retrieved] | Decode a URI component. | @choumx knows better, but I think you might have to accept the anchor as a parameter as you can't use `self`. |
@@ -61,8 +61,8 @@ public interface PipelineManager extends Closeable, PipelineManagerMXBean,
ReplicationFactor factor, Pipeline.PipelineState state);
List<Pipeline> getPipelines(ReplicationType type, ReplicationFactor factor,
- Pipeline.PipelineState state, Collection<DatanodeDetails> excludeDns,
- ... | [No CFG could be retrieved] | Get the list of pipelines that are in the pipeline. | Can we keep the existing one parameter as Collection which allows passing Set here? |
@@ -75,6 +75,11 @@ if (!file_exists($config['install_dir'].'/config.php')) {
exit;
}
+$git_found = check_git_exists();
+if ($git_found !== true) {
+ print_warn('Unable to locate git. This should probably be installed.');
+}
+
$versions = version_info();
$cur_sha = $versions['local_sha'];
| [format,rewind] | Check if config. php is correctly initialized and if not fails. get - current - user. php. | could you use `if (!$git_found){` instead? |
@@ -17,4 +17,6 @@ class Graphite2(CMakePackage):
version('1.3.13', sha256='dd63e169b0d3cf954b397c122551ab9343e0696fb2045e1b326db0202d875f06')
+ depends_on('python@3.6:')
+
patch('regparm.patch')
| [Graphite2->[version,patch]] | Reference to the version of the Registry ParmPatch. | Is this needed at run-time? Does the library need to be linked to? |
@@ -43,6 +43,9 @@ func (s *StacktraceFrame) Transform(config *pr.Config, service Service) common.M
enhancer.Add(m, "module", s.Module)
enhancer.Add(m, "function", s.Function)
enhancer.Add(m, "vars", s.Vars)
+ if config != nil && config.LibraryPattern != nil && s.LibraryFrame == nil {
+ s.LibraryFrame = s.isLibra... | [applySourcemap->[buildSourcemapId,updateError,Error,Sprintf,Apply,Err],Transform->[NewMapStrEnhancer,applySourcemap,Add],updateError->[Err],buildSourcemapId->[CleanUrlPath]] | Transform returns a copy of the stack trace frame. | `isLibraryFrame` can never return `nil`, so it should return a `bool` instead of `*bool` and then we should store it in a variable here and set `s.LibraryFrame` to the address of that var. |
@@ -69,6 +69,10 @@ public class BeamSqlUnparseContext extends SqlImplementor.SimpleContext {
return super.toSql(program, rex);
}
+ private static String escapeForZetaSql(String input) {
+ return ESCAPE_FOR_ZETA_SQL.translate(input);
+ }
+
private static class SqlByteStringLiteral extends SqlLiteral {
... | [BeamSqlUnparseContext->[SqlByteStringLiteral->[clone->[SqlByteStringLiteral]],ReplaceLiteral->[hashCode->[hashCode],equals->[equals]],toSql->[toSql]]] | Override to handle special cases for literal types. | nit: this function doesn't provide much value, just inline this? |
@@ -24,7 +24,8 @@ var ComplianceRepDate = Mapping{
"min_gram": 2,
"token_chars": [
"letter",
- "digit"
+ "digit",
+ "punctuation"
],
"type": "edge_ngram"
}
| [No CFG could be retrieved] | mappings - The mapping used to create the comp - <version - r - < - > object. | This allows suggestions for the version numbers. |
@@ -324,8 +324,8 @@ func (s *storageClientV1) QueryPages(ctx context.Context, queries []chunk.IndexQ
func (s *storageClientV1) query(ctx context.Context, query chunk.IndexQuery, callback chunk_util.Callback) error {
const null = string('\xff')
- sp, ctx := ot.StartSpanFromContext(ctx, "QueryPages", ot.Tag{Key: "ta... | [query->[StartSpanFromContext,ReadRows,Equal,Finish,Error,PrefixRange,WithStack,String,Open,LogFields,NewRange],Stop->[Close],Validate->[Validate],BatchWrite->[Open,ApplyBulk],RegisterFlags->[DurationVar,StringVar,RegisterFlagsWithPrefix,BoolVar],Delete->[addMutation,DeleteCellsInColumn],QueryPages->[StartSpanFromConte... | query executes a query against the Bigtable table. | Shouldn't we replace `ctx` with the one returned by `spanlogger.New()` here? |
@@ -326,7 +326,14 @@ class LowerYield(object):
0, state_index)
ty = self.gentype.state_types[state_index]
val = self.lower.loadvar(name)
+ # Load and DecRef previously stored value
+ oldval = self.context.unpack_value(self.bu... | [PyGeneratorLower->[lower_finalize_func_body->[get_resume_index_ptr,get_state_ptr]],GeneratorLower->[lower_finalize_func_body->[get_resume_index_ptr,get_arg_ptr,get_state_ptr]],BaseGeneratorLower->[lower_next_func->[get_resume_index_ptr,get_arg_ptr,get_state_ptr],__init__->[from_generator_fndesc]],LowerYield->[lower_yi... | Yields the state where the yield is suspended. | If oldval and val are the same, decref before incref risks destroying the underlying data, no? |
@@ -159,16 +159,4 @@ public class LocalTemplateDownloader extends TemplateDownloaderBase implements T
}
}
}
-
- public static void main(String[] args) {
- String url = "file:///home/ahuang/Download/E3921_P5N7A-VM_manual.zip";
- TemplateDownloader td = new LocalTemplateDownloa... | [LocalTemplateDownloader->[main->[download,LocalTemplateDownloader]]] | Download the specified resource into the specified file. Main method for download. | how about a unit test doing String url = "file:///home/ahuang/Download/E3921_P5N7A-VM_manual.zip"; TemplateDownloader td = new LocalTemplateDownloader(null, url, "/tmp/mysql", TemplateDownloader.DEFAULT_MAX_TEMPLATE_SIZE_IN_BYTES, null); long bytes = td.download(true, null); assertTrue("download failed", bytes > 0); ? |
@@ -19,7 +19,8 @@ RSpec.describe "/admin/invitations", type: :request do
describe "GET /admin/invitations/new" do
it "renders to appropriate page" do
get new_admin_invitation_path
- expect(response.body).to include("Email:")
+ expect(response.body).to include("Email")
+ expect(response.bod... | [create,let,be,describe,it,rand,to,before,post,let!,username,require,count,assert_enqueued_with,change,include,delivery_job,match,array_including,redirect_to,get,not_to,by,sign_in,update_column] | Describe the admin invitations let! creates a new user and checks the invitation is valid. | Our new designs don't use the `:` any longer so I removed it. |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.