patch stringlengths 18 160k | callgraph stringlengths 4 179k | summary stringlengths 4 947 | msg stringlengths 6 3.42k |
|---|---|---|---|
@@ -52,6 +52,7 @@ def register_goals():
task(name='c-for-ctypes', action=CCompile).install('native-compile')
task(name='cpp-for-ctypes', action=CppCompile).install('native-compile')
task(name='shared-libraries', action=LinkSharedLibraries).install('link')
+ task(name='native-binaries', action=LinkBinaries).in... | [register_goals->[task],rules->[create_binutils_rules,create_native_environment_rules,create_gcc_rules,create_native_toolchain_rules,create_llvm_rules,create_xcode_cli_tools_rules],build_file_aliases->[alias,BuildFileAliases]] | Register all of the GOALs that are required by the compile goal. | `binary.native` is probably enough here? |
@@ -12,6 +12,7 @@
</div>
</div>
<% end %>
+
<% if @tag_model && @tag_model.rules_html.present? %>
<div class="widget">
<header>
| [No CFG could be retrieved] | Renders the n - node tag in the sidebar. Displays a hidden box with the number of published and sponsored tags. | @lisasy remove new line |
@@ -841,7 +841,7 @@ class GContact
if ($curlResult->isSuccess() && !empty($curlResult->getBody())) {
$noscrape = json_decode($curlResult->getBody(), true);
- if (!empty($noscrape)) {
+ if (!empty($noscrape) && !empty($noscrape['updated'])) {
$noscrape['updated'] = DateTimeFormat::utc($noscrape['update... | [GContact->[fetchGsUsers->[getBody,isSuccess],updateFromNoScrape->[isTimeout,getBody,isSuccess],updateFromFeed->[query,registerNamespace,getBody,loadXML,isSuccess,item]]] | Update a contact from a NoScrape endpoint. | Just ` !empty($noscrape['updated'])` was necessary. |
@@ -2718,7 +2718,7 @@ public class ActiveMQServerImpl implements ActiveMQServer {
removeAddressInfo(addressName, null);
} else if (addressSettings.getConfigDeleteQueues() == DeletionPolicy.FORCE) {
for (Queue queue : listConfiguredQueues(addressName)) {
- if (!queuesInC... | [ActiveMQServerImpl->[getBrokerCriticalPlugins->[getBrokerCriticalPlugins],getBrokerMessagePlugins->[getBrokerMessagePlugins],callBrokerBridgePlugins->[callBrokerPlugins,getBrokerBridgePlugins],registerBrokerPlugin->[registerBrokerPlugin],deployQueuesFromListCoreQueueConfiguration->[locateQueue,toString,createQueue,dep... | Undeploy addresses and queues not in configuration. | Hash code is not safe unique. Should use equals against actual object doing comparison. |
@@ -105,6 +105,8 @@ class Qt(Package):
# depends_on("ogg", when='+multimedia')
use_xcode = True
+ # parallel build fails on Sierra
+ parallel = False
def url_for_version(self, version):
# URL keeps getting more complicated with every release
| [Qt->[install->[configure],configure->[configure]]] | Returns the URL for a specific version of . | Ouch. This package already takes so long to build. We could turn this into a property that returns True for every OS other than darwin. But I'm surprised it only fails on darwin. Have you tried contacting the developers about this? I've found a lot of developers very open to fixing Makefiles to work in parallel. Also, ... |
@@ -0,0 +1,16 @@
+# Copyright (c) 2018 Ultimaker B.V.
+# Cura is released under the terms of the LGPLv3 or higher.
+from .BaseModel import BaseModel
+
+
+class ClusterMaterial(BaseModel):
+ def __init__(self, guid: str, version: int, **kwargs) -> None:
+ self.guid = guid # type: str
+ self.version = v... | [No CFG could be retrieved] | No Summary Found. | In most cases we add Model as a suffix to all model classes so they're more easily memorable when reading through the code (see file below). Should do that here too. |
@@ -97,8 +97,7 @@ KRATOS_TEST_CASE_IN_SUITE(TotalLagrangian2D3_StaticSensitivity, KratosStructural
smtsss::PrimalTestSolver solver{&primal_model_part, response_node_id};
const double delta = 1e-7;
const double response_value0 = solver.CalculateResponseValue();
- ModelPart& adjoint_model_part =
- ... | [mpAdjointModelPart->[ResponseFunctionFactory],CalculateResponseValue->[ResponseFunctionFactory,CalculateResponseValue],CreateStructuralMechanicsTestModelPart->[CreateStructuralMechanicsTestModelPart]] | Tests case in sensitivity of a node in a 2D 3. | what is the change here? |
@@ -89,9 +89,9 @@ public class AuthenticationTest {
createUser(login, name, password);
// authenticate
- WsClient wsClient = new WsClient(newHttpConnector().url(ORCHESTRATOR.getServer().getUrl()).login(login).password(password).build());
- String response = wsClient.execute(newGetRequest("api/authenti... | [AuthenticationTest->[basic_authentication_based_on_login_and_password->[WsClient,build,isEqualTo,createUser,format,toString,newGetRequest,execute],deactivateUser->[setParam,execute],basic_authentication_does_not_support_utf8_passwords->[WsClient,build,isEqualTo,createUser,format,toString,newGetRequest,execute],delete_... | Basic authentication based on login and password. | - I'd prefer a static method than `HttpConnector.Builder()`, maybe newHttpConnectorBuilder() - +1 for replacing `login(string)` and `passowrd(string)` by `credentials(string, string)` - as discussed, I'd set the url directly in the http connector constructor directly, as a mandatory field. Out of scope of this PR |
@@ -1144,6 +1144,10 @@ public class HoodieWriteClient<T extends HoodieRecordPayload> extends AbstractHo
/**
* Deduplicate Hoodie records, using the given deduplication funciton.
+ *
+ * @param keys RDD of HoodieKey to deduplicate
+ * @param parallelism partitions of RDD
+ * @return RDD of HoodieKey alr... | [HoodieWriteClient->[doRollbackAndGetStats->[rollback],rollbackInflightCompaction->[rollback],startCommitWithTime->[startCommit],runCompaction->[compact,commitCompaction],rollbackInternal->[doRollbackAndGetStats,startContext,finishRollback],startCommit->[startCommit],rollbackPendingCommits->[rollback],bulkInsert->[bulk... | Deduplicate keys. | sorry, its my bad(I only coded this). this param is not required only. can you fix that. |
@@ -123,8 +123,6 @@ class Analytics
ACCOUNT_DELETE_VISITED = 'Account Delete visited'.freeze
ACCOUNT_DELETION = 'Account Deletion Requested'.freeze
ACCOUNT_RESET_VISIT = 'Account deletion and reset visited'.freeze
- ACCOUNT_VERIFICATION_SUBMITTED = 'Account verification submitted'
- ACCOUNT_VERIFICATION_VISI... | [Analytics->[track_mfa_submit_event->[track_event]]] | Returns a list of all browser attributes. Disavowal token invalid. | do we care about querying historical data consistently? if so, I would recommend renaming just the constant and not the value |
@@ -490,6 +490,7 @@ convertNormalToRotationMatrix(const T normal[3], T transverse[3], T binormal[3])
binormal[1] = 0.;
binormal[2] = 0.;
+ // TEUCHOS_ASSERT(false);
}
}
| [No CFG could be retrieved] | region region region region region ISSP Table Section 9. 1. 1. | Can we pull this out? |
@@ -267,7 +267,7 @@ calculate_range(const char *dataset, err_type_t type, int level, char *range,
* size.
*/
if ((err = dmu_objset_own(dataset, DMU_OST_ANY,
- B_TRUE, FTAG, &os)) != 0) {
+ B_TRUE, B_TRUE, FTAG, &os)) != 0) {
(void) fprintf(stderr, "cannot open dataset '%s': %s\n",
dataset, str... | [No CFG could be retrieved] | Reads the n - tuple of objects from the object tree. - translate range into block IDs. | I'm not sure that we actually need any decrypted data here. If we do require it to be decrypted, how does zinject get the keys? |
@@ -122,7 +122,7 @@ class InputFeeder:
identifiers = data_representation.identifier
data = data_representation.data
if not isinstance(identifiers, list) and input_regex is None:
- input_data = data
+ input_data = data if num_of_non... | [InputFeeder->[fill_inputs->[fill_non_constant_inputs],_transform_batch->[calculate_num_splits,separate_data],fill_non_constant_inputs->[_fill_image_info_inputs],_parse_inputs_config->[get_layer_precision],_fill_image_info_inputs->[prepare_image_info]]] | Fill non - constant inputs. | @liyong4x could you please describe the reason of these changes? It breaks general pipeline, so we need to find another solution |
@@ -149,6 +149,17 @@ public class SnapshotObject implements SnapshotInfo {
return physicalSize;
}
+ @Override
+ public void markBackedUp() throws CloudRuntimeException{
+ try {
+ processEvent(Event.OperationNotPerformed);
+ } catch (NoTransitionException ex) {
+ ... | [SnapshotObject->[getCreated->[getCreated],getName->[getName],getUuid->[getUuid],getPhysicalSize->[getPhysicalSize],getDataCenterId->[getDataCenterId],getId->[getId],getsnapshotType->[getsnapshotType],getPath->[getDataStore],getAccountId->[getAccountId],getHypervisorType->[getHypervisorType],getTO->[getTO],getRefCount-... | Get the physical size of the snapshot. | Can you maintain the history of the stack of the exception that is re-thrown here? I mean, it is a matter of using `throw new CloudRuntimeException(<message>, <exception>)` |
@@ -0,0 +1,5 @@
+class ChangeDisplayWhenSignedInColumnName < ActiveRecord::Migration[6.0]
+ def change
+ safety_assured { rename_column :navigation_links, :display_when_signed_in, :display_only_when_signed_in }
+ end
+end
| [No CFG could be retrieved] | No Summary Found. | I felt like this column name didn't make any sense and so I've renamed it. Since this is a brand new feature we dont have datd for it as yet. I haven't created a frontend as yet. |
@@ -64,7 +64,7 @@ namespace Microsoft.Xna.Framework.GamerServices
GC.SuppressFinalize(this);
}
- protected void Dispose(bool disposing)
+ private void Dispose(bool disposing)
{
}
| [GamerProfile->[Dispose->[SuppressFinalize,Dispose],Dispose]] | Disposes the members of this object. | Looks funky, but this is a sealed class, so protected didn't make sense. |
@@ -140,8 +140,8 @@ public final class NarClassLoaders {
/**
* Should be called at most once.
*/
- private InitContext load(final ClassLoader rootClassloader,
- final File frameworkWorkingDir, final File extensionsWorkingDir, final String frameworkNarId)
+ private Init... | [NarClassLoaders->[init->[init],load->[load,InitContext]]] | Load the NARs which are in the framework working directory and which are in the extensions Load a NAR with the specified coordinates. Checks if the nar dependency has already been loaded and if so creates a new NAR This method will load the NARs and check if there is a NAR that is Returns the bundle if it exists. | The `logDetails` boolean flag is not completely clear as it appears up being interpreted as `info` versus `debug`. What do you think about renaming it to `logInfoEnabled` or something similar? |
@@ -199,7 +199,7 @@ public class KafkaProcessor {
String path = root + dir + "/" + snappyNativeLibraryName;
nativeLibs.produce(new NativeImageResourceBuildItem(path));
} else { // otherwise the native lib of the platform this build runs on
- String dir = getOs() + "/" + get... | [KafkaProcessor->[runtimeConfig->[build],withSasl->[build]]] | handleSnappy - handle snappy. | Is getOS and getArch still used? |
@@ -0,0 +1,12 @@
+using System.Reflection;
+using System.Runtime.CompilerServices;
+using System.Runtime.InteropServices;
+
+// General Information about an assembly is controlled through the following
+// set of attributes. Change these attribute values to modify the information
+// associated with an assembly.
+[as... | [No CFG could be retrieved] | No Summary Found. | Ensure that your new projects are using `AssemblySharedInfo.cs`. This will ensure correct version numbering. |
@@ -116,7 +116,7 @@ var _ = g.Describe("[sig-arch][Feature:ClusterUpgrade]", func() {
f.SkipNamespaceCreation = true
f.SkipPrivilegedPSPBinding = true
- g.It("Cluster should remain functional during upgrade [Disruptive]", func() {
+ g.When("Clusters upgrade [Disruptive]", func() {
config, err := framework.Load... | [ExpectNoError,Resource,RetryOnConflict,It,Atoi,NewForConfigOrDie,LoadConfig,ClusterStatusConditionType,Reached,GetName,Errorf,MustParseSemantic,Logf,ConfigV1,PollImmediate,ShouldUpgradeAbort,Output,NestedFieldNoCopy,ParseSemantic,Get,Split,Update,Int31n,Describe,NewDefaultFramework,Fprintf,Sprintf,Disrupt,Background,W... | SetUpgradeAbortAt defines the abort behavior during an upgrade. latestHistory returns the latest update history for the cluster. | panic here. ah ginkgo, what a mess. |
@@ -0,0 +1,8 @@
+
+export const SESSION_CREATED = 'SESSION_CREATED';
+
+export const SESSION_STARTED = 'SESSION_STARTED';
+
+export const SESSION_TERMINATED = 'SESSION_TERMINATED';
+
+export const SESSION_FAILED = 'SESSION_FAILED';
| [No CFG could be retrieved] | No Summary Found. | Let's not add a failed state again. It's a lot easier to work with a single exit point. A session terminates, and in the ancilliary data we'll put the error, if any |
@@ -153,6 +153,9 @@ const generateApplicationFiles = ({ generator, application, withEntities, inFold
const cwd = inFolder ? path.join(generator.pwd, baseName) : generator.pwd;
logger.debug(`Child process will be triggered for ${runYeomanProcess} with cwd: ${cwd}`);
+ if (process.argv.includes('--no-insig... | [No CFG could be retrieved] | Generates the application source code for the applications defined in the Yeoman environment. Generates the files for the given . | This should happen automatically, isn't it working? let me know if it doesnt work. |
@@ -1021,10 +1021,14 @@ class TypeInferer(object):
for var in self._get_return_vars():
self.lock_type(var.name, typ, loc=None)
- def build_constraint(self):
- for blk in self.blocks.values():
- for inst in blk.body:
- self.constrain_statement(inst)
+ def bu... | [IntrinsicCallConstraint->[__call__->[resolve]],TypeInferDebug->[propagate_finished->[_dump_state]],ConstraintNetwork->[propagate->[append],append->[append]],TypedGetItemConstraint->[__call__->[add_type]],StaticGetItemConstraint->[__call__->[add_type],get_call_signature->[get_call_signature]],SetItemConstraint->[__call... | Seed the return value of the function with the given type. | This may need updating WRT the new error handling PR. |
@@ -17,7 +17,7 @@ class StaffForm(forms.ModelForm):
class Meta:
model = User
fields = ['first_name', 'last_name', 'email',
- 'user_permissions', 'is_active']
+ 'user_permissions', 'is_active', 'is_staff', 'is_superuser']
labels = {
'first_na... | [StaffForm->[Meta->[pgettext_lazy],__init__->[get_name_placeholder,super,pop],get_permissions,PermissionMultipleChoiceField,pgettext_lazy]] | Create a form for a user object. | "Superuser" functionality is hidden in UI on purpose and we don't want to reveal that. We think that superusers are convenient for development but normally, regular staff accounts and permission systems should be used. |
@@ -83,7 +83,9 @@ namespace Content.Server.Throw
physComp = thrownEnt.AddComponent<PhysicsComponent>();
var timing = IoCManager.Resolve<IGameTiming>();
- var spd = throwForce / (1f / timing.TickRate); // acceleration is applied in 1 tick instead of 1 second, scale appropriatel... | [ThrowHelper->[Throw->[NextGaussian,Status,MobImpassable,Count,LocalRotation,CollisionMask,IoCManager,throwSourceEnt,GridPosition,Add,CanCollide,ToVec,physComp,FromDegrees,Controller,TryGetComponent,TickRate,IgnoreEntity,IsWeightless,thrownEnt,User,Mass,Impassable,InAir,ToAngle,Push,ToMapPos],ThrowTo->[DefaultThrowTime... | Throw an entity. if we have a collision with the entity we can t do anything. | We should find the existing sources of throw force, multiply them all by 60, then get rid of this in a later PR. |
@@ -57,7 +57,7 @@ class ApplicationController < ActionController::Base
render json: {}, status: :not_found
}
end
- return
+ return true
end
private
| [ApplicationController->[log->[log,error],render_403->[render,html,respond_to,json],generate_intro_tutorial->[from_now,enable_tutorial,update,seed_demo_data,no_tutorial_done?,count],set_time_zone->[time_zone,use_zone],render_404->[render,html,respond_to,json],around_action,include,before_action,layout,protect_from_forg... | Renders a 404 not found exception. | Redundant `return` detected. |
@@ -27,7 +27,6 @@ func (c *CmdDbNuke) Run() error {
return err
}
protocols := []rpc2.Protocol{
- NewLogUIProtocol(),
}
if err = RegisterProtocols(protocols); err != nil {
return err
| [Run->[PromptForConfirmation,DbNuke],ParseArgv->[Bool],ChooseCommand] | Run - Nuke a database. | If empty, then just RegisterProtocols(nil) |
@@ -0,0 +1,12 @@
+public class UselessExtendsCheck { // Compliant
+
+ public class Class1 { // Compliant
+ }
+
+ public class Class2 extends Object { // Noncompliant
+ }
+
+}
+
+public class Class3 extends java.lang.Object { // Noncompliant
+}
| [No CFG could be retrieved] | No Summary Found. | Lack a testcase where the symbol in the extend clause is not known (just use a dummy name) |
@@ -4,6 +4,8 @@
class Simpsons < PackageSpec
# ^^^^^^^^ symbol-search: "Simpsons", name = "Simpsons", container = "(nothing)"
+ # ^^^^^^^^ symbol-search: "Simpsons", name = "Simpsons", container = "Simpsons"
+ # ^^^^^^^^ symbol-search: "Simpsons", name = "Simpsons", container = "<PackageTests>::Simpsons_P... | [Simpsons->[import,test_import,export,export_for_test]] | Create a new instance of the Simpsons class. | Symbol search shows up here rather in an arbitrary export statement. |
@@ -23,7 +23,9 @@
var duplicateNames = entries.GroupBy(item => item.Name)
.Where(group => group.Count() > 1)
+ .Select(group => group.Key)
.ToList();
+
if (duplicateNames.Any())
{
logger.Error("Diagnostics entries... | [WriteStartupDiagnostics->[Task->[ToDictionary,Any,Join,Error,Data,nameof,CustomDiagnosticsWriter,Name,ToList,CompletedTask,SerializeObject,ConfigureAwait,entries],settings,diagnosticsWriter,isCustomWriter,LogManager]] | This method is called when the diagnostic is started. | What led to this change? Seems fine, but also unrelated. |
@@ -83,4 +83,12 @@ public interface XceiverServerSpi {
* @return list of report for each pipeline.
*/
List<PipelineReport> getPipelineReport();
+
+ /**
+ * Get storage report for the XceiverServer instance.
+ * @return list of report for each storage location.
+ */
+ default List<MetadataStorageRepor... | [No CFG could be retrieved] | Get the pipeline report. | It seems to be a good time the remove XceiverServerSpi interface. Originally we had two separated implementation to connect to the datanode. Today we have only one. One interface is used between the client and the datanode, and the other one between datanode and ratis (datanode). As this example shows, the two interfac... |
@@ -315,6 +315,12 @@ module Repository
raise NotImplementedError, "Revision.directories_at_path not yet implemented"
end
+ # Walks all files and subdirectories starting at +path+ and
+ # returns an array of tuples containing [path, revision_object]
+ # for every file and directory discovered in t... | [AbstractRepository->[update_permissions->[get_full_access_users],get_users->[get_full_access_users],update_permissions_after->[update_permissions]]] | Returns directories at given path. | Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols. |
@@ -42,7 +42,17 @@ func checkIntegrationInstalled(
kibanaClient kibana.Client,
esClient elasticsearch.Client,
logger *logp.Logger,
-) error {
+) (err error) {
+ defer func() {
+ if err != nil {
+ // We'd like to include some remediation actions when the APM Integration isn't installed.
+ err = &actionableErr... | [NewDecoder,Status,Infof,Do,Decode,New,Go,WithContext,Close,Send,Errorf,IsError,Wrap,ReadAll,Wait,TrimSpace] | checkIntegrationInstalled checks if the APM integration is installed by querying Kibana and Elasticsearch checkIntegrationInstalledKibana checks if the APM integration package is installed by querying K. | Generally +1 on introducing `actionableError`, but not certain how helpful this exact Remediation note is to users that are not familiar to the term `apm integration` or don't know how to install it. Ideally, if we are confident that doc links don't change frequently, we could link to the docs from here. |
@@ -278,14 +278,14 @@ function $RootScopeProvider(){
- // Using a listener function
+ // Using a function as a watchExpression
var food;
scope.foodCounter = 0;
expect(scope.foodCounter).toEqual(0);
scope.$watch(
- // This is the liste... | [No CFG could be retrieved] | Private methods - This function is called when a variable of type n has been passed to a WatchExpression Expression that is evaluated on each *. | Internally, this function is sometimes called the watchAction, but change listener makes sense in this example. |
@@ -38,7 +38,14 @@ namespace System.PrivateUri.Tests
private string scheme_name;
public TestUriParser() : base() { }
public new string GetComponents(Uri uri, UriComponents components, UriFormat format) => base.GetComponents(uri, components, format);
- public new void InitializeAndValid... | [UriParserTest->[Register_NegativePort->[Register],Resolve_UriNull->[Resolve],GetComponents_Ftp2->[GetComponents],ReRegister->[Register],Register_TooBigPort->[Register],IsWellFormedOriginalString_Null->[IsWellFormedOriginalString],IsWellFormedOriginalString->[IsWellFormedOriginalString],Register->[Register],GetComponen... | This method is used to retrieve the components of a URI. | These tests should also be fixed, I assume override behavior was intended here |
@@ -430,7 +430,14 @@ class ReviewerScore(ModelBase):
'No such version/auto approval summary when determining '
'event type to award points: %r', exception)
weight = 0
- if weight > amo.POST_REVIEW_WEIGHT_HIGHEST_RISK:
+
+ if addon.type == ... | [set_reviewing_cache->[get_reviewing_cache_key],get_reviewing_cache->[get_reviewing_cache_key],RereviewQueueTheme->[RereviewQueueThemeManager],RereviewQueueThemeManager->[__init__->[__init__]],ViewQueue->[flags->[get_flags_for_row]],ReviewerScore->[get_breakdown_since->[get_key],get_breakdown->[get_key],all_users_by_sc... | Return the review event type constant. return None if not found. | Technically... couldn't it be an update ? If auto-approval is disabled on some extension, because of the hack below we're passing `post_review=True`, sure, but that could still be an update right ? |
@@ -38,10 +38,16 @@ import (
"github.com/vmware/vic/lib/install/data"
"github.com/vmware/vic/lib/install/management"
"github.com/vmware/vic/lib/install/validate"
+ "github.com/vmware/vic/lib/install/vchlog"
"github.com/vmware/vic/pkg/ip"
+ viclog "github.com/vmware/vic/pkg/log"
"github.com/vmware/vic/pkg/vers... | [Handle->[Context,StatusCode,Error,NewPostTargetTargetVchDefault,NewPostTargetTargetDatacenterDatacenterVchDefault,NewPostTargetTargetDatacenterDatacenterVchCreated,WithPayload,NewPostTargetTargetVchCreated],NewDispatcher,StringSlice,CheckImagesFiles,Ceil,SharesLevel,ProcessNetwork,ProcessCertificates,Validate,AddDepre... | ----------- Handler creates a VCH object in a datacenter URL returns URL of the target with the given id. | Is `LogFile` used in another pkg? If not, it shouldn't be exported and should be declared as `logFile`. |
@@ -33,11 +33,17 @@ public class ComplexColumnPartSerde implements ColumnPartSerde
@Nullable
private final ComplexMetricSerde serde;
private final Serializer serializer;
+ private static final Logger log = new Logger(ComplexColumnPartSerde.class);
private ComplexColumnPartSerde(String typeName, Serialize... | [ComplexColumnPartSerde->[SerializerBuilder->[build->[ComplexColumnPartSerde]],createDeserializer->[ComplexColumnPartSerde]]] | Create a new serializer for a sequence of complex types. | nit: chosing -> choosing |
@@ -1191,11 +1191,13 @@ export class ResourcesImpl {
// Ensure all resources layout phase complete; when relayoutAll is requested
// force re-layout.
- const relayoutAll = this.relayoutAll_;
+ const {
+ relayoutAll_: relayoutAll,
+ relayoutTop_: relayoutTop,
+ elementsThatScrolled_: ele... | [No CFG could be retrieved] | Private functions - related to the main processing of the object. if r is building or not. | `getState` and `isBuilt` are not necessarily equivalent. I'd avoid drive-by refactoring if I were you. |
@@ -148,7 +148,7 @@ class NetlibLapack(Package):
# build CBLAS and LapackE
cmake_args.extend(['-DCBLAS=OFF'])
cmake_args.extend(['-DLAPACKE:BOOL=OFF'])
-
+
if self.compiler.name == 'xl' or self.compiler.name == 'xl_r':
# use F77 compiler if IBM XL
... | [NetlibLapack->[blas_libs->[sorted,tuple,find_libraries],headers->[join_path,HeaderList],install->[install_one],lapack_libs->[sorted,tuple,find_libraries],install_one->[satisfies,working_dir,cmake,spec,extend,format,join,make],patch->[filter_file,satisfies],depends_on,patch,version,provides,variant]] | Install one of the Cake commands. Check if there is a missing cmake command. | please remove white space, falke8 will complain |
@@ -73,9 +73,10 @@ public class ObserverInfo implements InjectionTargetInfo {
isAsync = context.isAsync();
}
- if (!TransactionPhase.IN_PROGRESS.equals(transactionPhase)) {
+ if (!transactionPhase.equals(TransactionPhase.IN_PROGRESS) && !jtaCapabilities) {
final ClassI... | [ObserverInfo->[ObserverTransformationContext->[transform->[getMethod]],create->[ObserverInfo],initEventParam->[kind]]] | Creates an observer info object. Method to provide information about a managed bean. | I'd keep this warning (with a modified message) when JTA is not available... |
@@ -120,6 +120,9 @@ function writeFiles() {
this.addMavenDependency('org.springframework.cloud', 'spring-cloud-starter-openfeign', null, exclusions);
}
this.addMavenDependency('org.springframework.cloud', 'spring-cloud-starter-oauth2');
+ this.addMav... | [No CFG could be retrieved] | Adds the dependencies needed for the client Add main class to the generated classes. | should be called only if `!enableSwaggerCodegen`, otherwise, it will add twice |
@@ -457,7 +457,7 @@ static ossl_ssize_t checked_uint8(const char **inptr, void *out)
struct tlsa_field {
void *var;
const char *name;
- ossl_ssize_t (*parser)(const char **, void *);
+ ossl_ssize_t(*parser) (const char **, void *);
};
static int tlsa_import_rr(SSL *con, const char *rrdata)
| [No CFG could be retrieved] | Decode an unsigned 8 - bit integer from an OSSL string. Reads the next n - bytes from rrdata and adds them to the list of possible TLS. | This is wrong. You may need to add a line for `ossl_ssize_t` in `util/indent.pro`... |
@@ -497,14 +497,12 @@ class NoVerifyException(spack.error.SpackError):
"""
Raised if file fails signature verification.
"""
- pass
class NoChecksumException(spack.error.SpackError):
"""
Raised if file fails checksum verification.
"""
- pass
class NewLayoutException(spack.er... | [make_package_relative->[read_buildinfo_file],clear_spec_cache->[clear],update_cache_and_get_specs->[get_all_built_specs,update],push_keys->[generate_key_index],read_buildinfo_file->[buildinfo_file_name],write_buildinfo_file->[get_buildfile_manifest,buildinfo_file_name],check_specs_against_mirrors->[needs_rebuild],sele... | Exception class for handling missing or missing key. Return a function that returns the path to the build cache and the name of the binary package. | This seems unrelated to the platform checks? |
@@ -52,3 +52,5 @@ class RDeseq2(RPackage):
depends_on('r-ggplot2', type=('build', 'run'))
depends_on('r-hmisc', type=('build', 'run'))
depends_on('r-rcpp', type=('build', 'run'))
+ depends_on('r@3.4.0:3.4.9', when='@1.16.1', type=('build', 'run'))
+ depends_on('r@3.5.0:3.5.9', when='@1.20.0', type=... | [RDeseq2->[depends_on,version]] | requires_on method for all build - specific functions. | there is no (direct) dependency on `r` for `1.18.1` anymore |
@@ -2201,6 +2201,11 @@ namespace JsRTApiTest
return JsNoError;
}
+ static JsErrorCode CALLBACK Succes_IIMC(_In_opt_ JsModuleRecord referencingModule, _In_opt_ JsValueRef importMetaVar)
+ {
+ return JsNoError;
+ }
+
void ModuleSuccessTest(JsRuntimeAttributes attributes, JsRuntimeHand... | [No CFG could be retrieved] | The main module record is created by the JS code generation. The main module file is parsed by the JSParser. | >Succes [](start = 32, length = 6) nit: Typo |
@@ -19,8 +19,9 @@ import (
)
const (
- interval = time.Second * 1
- retry = time.Second * 5
+ interval = time.Second * 1
+ retry = time.Second * 5
+ cordonDrainTimeout = time.Minute * 10
)
// Compiler to verify QueueMessageProcessor implements OperationsProcessor
| [DeleteNode->[GetKubernetesClient,DeleteNode,Warningf,Warnf,SafelyDrainNodeWithClient,CleanDeleteVirtualMachine],CreateNode->[UnixNano,NewSource,Infof,Format,Sprintf,New,Now,Int31,DeployTemplateSync],Validate->[GetKubernetesClient,Stop,Infof,NewTimer,Reset,GetNode,Warningf,Errorf]] | DeleteNode deletes a node from the list of nodes in the cluster. UpgradeContainerService. Properties. MasterProfile. FQDN. | why 10 minutes? if scale is 1 hour |
@@ -199,7 +199,8 @@ function algoliaPaginate(tag, requiresApproval) {
} else if (homeEl.dataset.feed === "latest") {
paginationArticlesIndex = client.initIndex('ordered_articles_by_published_at_<%= Rails.env %>');
} else {
- searchObj.tagFilters = ('published_at_int > ' + homeEl.dataset.articlesSince);
+ ... | [No CFG could be retrieved] | This function is a helper function that will fetch the next page of articles. function to handle the case where we need to scroll the page. | This was the main issue. Logic had been changed and was wrong in this case. |
@@ -109,7 +109,7 @@ namespace System.Linq.Expressions.Compiler
private static Type MakeNewCustomDelegate(Type[] types)
{
- if (LambdaExpression.CanCompileToIL)
+ if (RuntimeFeature.IsDynamicCodeSupported)
{
Type returnType = types[types.Length - 1]... | [DelegateHelpers->[Type->[Type],IsByRef->[IsByRef]]] | Creates a new delegate type based on the given types. | PRODUCT CHANGE: the existing setting was mechanically propagated from FEATURE_COMPILE, but I think here we should be more nuanced between "IL expression compiler is disabled" and "the platform supports reflection emit". This codepath is not related to compiling IL expressions and we can allow it if emit is otherwise su... |
@@ -349,7 +349,7 @@ namespace DynamoCoreWpfTests
// Filter the node elements using the search field.
searchViewModel.SearchAutoCompleteCandidates("ar");
- Assert.AreEqual(2 , searchViewModel.FilteredResults.Count());
+ Assert.AreEqual(4 , searchViewModel.FilteredResults... | [NodeAutoCompleteSearchTests->[Open->[Open],Run->[Run],SearchNodeAutocompletionSuggestions->[Open],NodeSuggestions_InputPortZeroTouchNodeForProperty_AreCorrect->[Open],NodeSuggestions_InputPortBuiltInNode_AreCorrect->[Open],Start->[Start],NodeSuggestionsAreSortedBasedOnGroupAndAlphabetically->[Open],NodeSuggestions_Def... | This method checks if the node view is available and if it is available and if it is Checks that filtered results are equal. | @zeusongit Looks like the number diff is expected due to? |
@@ -1679,7 +1679,7 @@ compiler:
clang:
version: ["3.3", "3.4", "3.5", "3.6", "3.7", "3.8", "3.9", "4.0",
"5.0", "6.0", "7.0", "7.1",
- "8", "9", "10"]
+ "8", "9", "10", "11"]
libcxx: [None, libstdc++, libstdc++11, libc++, c++_shared, c++_static... | [No CFG could be retrieved] | Returns a list of threads that can be used to find the next sequence number. Return a list of all possible values of the n - tuple. Return a list of tuples containing the CPP standard and CPP standard values for the given. | Not the right place to change it, you need to define a ``settings_1_30_2`` with a new value |
@@ -436,7 +436,7 @@ public class AsyncManagementForwardingServletTest extends BaseJettyTest
JettyServerInitUtils.addExtensionFilters(root, injector);
final HandlerList handlerList = new HandlerList();
- handlerList.setHandlers(new Handler[]{JettyServerInitUtils.wrapWithDefaultGzipHandler(root)});
+... | [AsyncManagementForwardingServletTest->[setup->[setup],tearDown->[reset]]] | Initialize the Jetty server with a servlet that can be used to serve the Jetty server. | Should have used `ServerConfig.DEFAULT_GZIP_INFLATE_BUFFER_SIZE` and `Deflater.DEFAULT_COMPRESSION` instead of magic constants |
@@ -20,7 +20,8 @@ describe 'profile/index.html.slim' do
expect(rendered).not_to have_xpath("//input[@value='Disable']")
end
- it 'contains link to delete account' do
+ xit 'contains link to delete account' do
+ pending 'temporarily disabled until we figure out the MBUN to SSN mapping'
re... | [context,to,have_content,have_xpath,build_stubbed,describe,before,have_link,not_to,with,t,it,require,and_return] | It prints a basic example of how to show how to show how to show how to show. | you don't need both `pending` and `xit`. In this case just `pending` should be fine (better actually i think). |
@@ -48,7 +48,7 @@ IMPORT_CHUNKS = {
def strip_newline(stmt):
- return textwrap.dedent('\n'.join(filter(None, stmt.splitlines())))
+ return textwrap.dedent('\n'.join([_f for _f in stmt.splitlines() if _f]))
def stitch_chunks(newlines, *chunks):
| [ImportOrderTest->[test_multiple_imports_error->[stitch_chunks],test_pairwise_classify->[stitch_chunks],test_classify_import_chunks->[get_import_chunk_types]],stitch_chunks->[strip_newline]] | Strip newline from statement. | I think this can be converted to a generator. Simply remove the `[]`, and we should get minor performance enhancements. |
@@ -137,15 +137,6 @@ public class HoodieHFileInputFormat extends FileInputFormat<NullWritable, ArrayW
@Override
protected boolean isSplitable(FileSystem fs, Path filename) {
// This file isn't splittable.
- return false;
- }
-
- public void setConf(Configuration conf) {
- this.conf = conf;
- }
-
- ... | [HoodieHFileInputFormat->[listStatus->[listStatus],listStatusForIncrementalMode->[listStatus],filterInstantsTimeline->[filterInstantsTimeline]]] | This method is called by the split method to determine if a file is splitable. | Is the splitable property related to whether the log files are included? If not, the literal should be used for better clarity. |
@@ -54,9 +54,12 @@ public class BlockHandleImpl implements BlockHandle {
manager.pushBlock(blockCapsule);
tronNetService.broadcast(blockMessage);
} catch (Exception e) {
+ metricsService.meterMark(MetricsService.NODE_STATUS, 1);
logger.error("Handle block {} failed.", blockCapsule.getBloc... | [BlockHandleImpl->[produce->[generateBlock,error,BlockMessage,broadcast,getString,receiveBlock,fastForward,pushBlock],getState->[equals]]] | Produce a new block from the pool. | There's something wrong with this metric no need NODE_STATUS and NODE_STATUS is not a metric |
@@ -39,7 +39,7 @@ module GobiertoPeople
def fullcalendar_events
starts = Time.zone.parse(params[:start])
ends = Time.zone.parse(params[:end])
- events = @person.attending_events.published.where('starts_at >= ? AND ends_at <= ?', starts, ends)
+ events = @person.owned_attending_e... | [PersonEventsController->[show->[redirect_to,gobierto_people_person_path,new,slug,valid_preview_token?,manage_event?,t],set_calendar_events->[published],find_event->[find_by!],person_events_scope->[attending_events,valid_preview_token?,published],manage_event?->[view?],index->[js,respond_to,published,parse,render,html,... | Returns an array of fullcalendar events that match the given criteria. | Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping. |
@@ -108,6 +108,7 @@ import org.apache.hadoop.fs.FileStatus;
import org.apache.hadoop.fs.FileSystem;
import org.apache.hadoop.fs.Path;
import org.apache.hadoop.hive.metastore.TableType;
+import org.iq80.leveldb.table.TableBuilder;
import org.joda.time.DateTime;
import org.joda.time.DateTimeZone;
import org.testng.... | [AbstractTestHive->[testGetTableSchemaException->[newSession,getMetadata,newTransaction],testGetPartitionSplitsBatchUnpartitioned->[newSession,getMetadata,getTransactionHandle,newTransaction],partitionTargetPath->[newSession,getMetastore,newTransaction],insertData->[getTargetPathRoot,getTransactionHandle,getStagingPath... | Imports an object from the pre - osql package. Imports a single object from the java package. | This was accidentally imported and is causing the build to fail. Please remove it. |
@@ -142,3 +142,15 @@ def gift_cards_activated(
for gift_card_id in gift_card_ids
]
return GiftCardEvent.objects.bulk_create(events)
+
+
+def gift_card_note_added(
+ gift_card: GiftCard, user: UserType, app: AppType, message: str
+) -> GiftCardEvent:
+ return GiftCardEvent.objects.create(
+ ... | [gift_card_expiry_settings_updated->[user_is_valid,create],gift_card_balance_reset->[user_is_valid,create],gift_card_issued_event->[user_is_valid,create],gift_card_sent->[create],gift_card_deactivated->[user_is_valid,create],gift_cards_activated->[user_is_valid,GiftCardEvent,bulk_create],gift_card_activated->[user_is_v... | Create a GiftCardEvent for the given gift cards activated. | `user_is_valid` check is needed. |
@@ -34,6 +34,7 @@ public class MRCompactionTask extends MRTask {
this.suite = CompactionSuiteUtils.getCompactionSuiteFactory (taskContext.getTaskState()).
createSuite(taskContext.getTaskState());
this.dataset = this.suite.load(taskContext.getTaskState());
+ this.needToFail = taskContext.getTas... | [MRCompactionTask->[createJob->[createJob],onMRTaskComplete->[onMRTaskComplete],run->[run]]] | This class is used to run a single MR compaction task. onMRTaskComplete - override to call onCompactionCompleteActions if any of the actions. | I would prefer if this was a different `TaskFactory` that can be used from any flow. |
@@ -30,6 +30,9 @@ type CmdXLogin struct {
func (c *CmdXLogin) Run() error {
protocols := []rpc.Protocol{
NewProvisionUIProtocol(),
+ NewLoginUIProtocol(G),
+ NewSecretUIProtocol(G),
+ NewGPGUIProtocol(G),
}
if err := RegisterProtocols(protocols); err != nil {
return err
| [ParseArgv->[Args,New],Run->[XLogin,TODO],ChooseCommand] | Run implements the Cmd interface for XLogin. | Since `CmdXLogin` is new, care to pass `G` through from the top level? |
@@ -193,6 +193,12 @@ public class SimpleMessageStore extends AbstractMessageGroupStore
if (group == null) {
group = new SimpleMessageGroup(groupId);
this.groupIdToMessageGroup.putIfAbsent(groupId, group);
+ this.groupToUpperBound.putIfAbsent(groupId, new UpperBound(this.groupCapacity));
+ }
+ ... | [SimpleMessageStore->[pollMessageFromGroup->[removeMessagesFromGroup],getGroupMetadata->[getMessageGroup],iterator->[iterator]]] | Add a message to a message group. | We either need a new catch for `InterruptedException` here, or at least we need to fix the message in the `MessagingException` in the outer catch since the interrupt might be here not on the lock acquisition. |
@@ -227,7 +227,7 @@ type WindowsProfile struct {
WindowsSku string `json:"windowsSku"`
WindowsDockerVersion string `json:"windowsDockerVersion"`
Secrets []KeyVaultSecrets `json:"secrets,omitempty"`
- SSHEnabled bool `json:"ssh... | [GetCustomEnvironmentJSON->[IsAzureStackCloud],HasAvailabilityZones->[HasAvailabilityZones],GetUserAssignedID->[UserAssignedIDEnabled],GetVMType->[HasVMSSAgentPool],HasImageGallery->[IsGalleryImage],GetSecondaryNonMasqueradeCIDR->[IsHostedMasterProfile],GetFirstConsecutiveStaticIPAddress->[IsVirtualMachineScaleSets],Is... | RealmPassword is the password used to login to a custom vnet when a custom DNS is. | Do we know if we have data in AKS RP with this value? Will a "false" value in DB cause deserialization error to *bool? |
@@ -20,6 +20,8 @@ import static org.mule.extension.file.common.api.FileDisplayConstants.MATCH_WITH
import static org.mule.runtime.api.i18n.I18nMessageFactory.createStaticMessage;
import static org.mule.runtime.core.api.scheduler.SchedulerConfig.config;
import static org.mule.runtime.core.util.concurrent.ThreadNameHe... | [DirectoryListener->[initialiseClusterListener->[onStart],resolveRootPath->[resolveRootPath]]] | Reads and imports all the fields of the given object. Imports the methods of the MuleRuntimeException. | this is breaking the standard imports order |
@@ -93,11 +93,12 @@ func (kv *etcdKVBase) Save(key, value string) error {
txn := NewSlowLogTxn(kv.client)
resp, err := txn.Then(clientv3.OpPut(key, value)).Commit()
if err != nil {
- log.Error("save to etcd meet error", zap.String("key", key), zap.String("value", value), errs.ZapError(errs.ErrEtcdKVSave, err))
-... | [Commit->[WithLabelValues,Commit,Warn,Error,Seconds,Now,Duration,WithStack,Observe,cancel,Inc,Reflect,Since],Save->[Join,Commit,Error,ZapError,WithStack,OpPut,Then,String],If->[If],Remove->[OpDelete,Join,Commit,Error,ZapError,WithStack,Then,String],Then->[Then],LoadRange->[Join,WithLimit,TrimPrefix,WithRange,EtcdKVGet]... | Save is part of the KV interface. | how about `errors.zapError`? |
@@ -143,6 +143,7 @@ func (hr *headBroadcaster) executeCallbacks() {
wg := sync.WaitGroup{}
wg.Add(len(callbacks))
+ relayLggr := hr.logger.Named("head_relayer")
for _, callback := range callbacks {
go func(trackable httypes.HeadTrackable) {
defer wg.Done()
| [executeCallbacks->[Done,Unlock,WithTimeout,Sprintf,TypeOf,Background,clone,Now,Debugw,Lock,Errorf,OnNewLongestChain,Info,Since,Wait,Add,Retrieve],Start->[StartOnce,Add,run],Close->[StopOnce,Wait,Lock,Unlock],OnNewLongestChain->[Deliver],run->[Notify,Done,executeCallbacks],Subscribe->[Lock,Unlock,Errorf],NewMailbox,Rea... | executeCallbacks executes all callbacks that have been registered for the current head. | Can we keep the name to be `HeadBroadcaster`? I think the `id` here was a mistake |
@@ -58,6 +58,10 @@ namespace Microsoft.Xna.Framework.Graphics
private float maxDepth;
#region Properties
+
+ /// <summary>
+ /// The height of this <see cref="Viewport"/>.
+ /// </summary>
[DataMember]
public int Height
{
| [Viewport->[Vector3->[x,Multiply,width,height,X,maxDepth,y,Transform,Invert,WithinEpsilon,M34,Y,M24,Z,M14,minDepth,M44],WithinEpsilon->[Epsilon],x,height,maxDepth,X,Height,y,Y,minDepth,Width,width]] | Package containing the conditions of a page. - Fields of type float. | We don't need to include `of this <see cref="Viewport"/>` on every summary. Also the link is redundant as it is just linking to the same docs they are already reading. |
@@ -1296,9 +1296,6 @@ func (mod *modContext) genFunctionFileCode(f *schema.Function) (string, error) {
for _, i := range imports {
importStrings = append(importStrings, i.SortedValues()...)
}
- if f.NeedsOutputVersion() {
- importStrings = append(importStrings, "Pulumi.Utilities")
- }
// We need to qualify ... | [genResource->[propertyName,genInputType,isK8sCompatMode,genOutputType,tokenToNamespace,typeString],gen->[genResource,genType,genFunctionFileCode,getImportsForResource,isTFCompatMode,isK8sCompatMode,genEnums,genHeader,details,tokenToNamespace,add,genConfig,genUtilities],genInputTypeWithFlags->[genInputProperty,isK8sCom... | genFunctionFileCode generates code for a function file. | Is this not needed anymore? Is that related to this change? |
@@ -44,7 +44,11 @@ class WPSEO_Link_Watcher {
*
* @return void
*/
- public function save_post( $post_id, WP_Post $post ) {
+ public function save_post( $post_id, $post ) {
+ if ( ! $post instanceof WP_Post ) {
+ return;
+ }
+
// Bail if this is a multisite installation and the site has been switched.
... | [WPSEO_Link_Watcher->[process->[process],delete_post->[get_stored_internal_links,cleanup,update_link_counts],save_post->[is_processable,process]]] | Saves a post. | The method save_post() has a Cyclomatic Complexity of 10. The configured cyclomatic complexity threshold is 10. |
@@ -162,9 +162,6 @@ describe('nativeImage module', () => {
const imageI = nativeImage.createFromBuffer(imageA.toBitmap(),
{width: 538, height: 190, scaleFactor: 2.0})
expect(imageI.getSize()).to.deep.equal({width: 269, height: 95})
-
- const imageJ = nativeImage.createFromBuffer(imageA.toPNG... | [No CFG could be retrieved] | Creates an image from a given data URL. There is no expectation that the imagesData object contains a PNG image. | @codebytere The spec should be rewritten with the new syntax, it shouldn't be removed. |
@@ -206,9 +206,10 @@ def collapse_alias_to_urn(
return create_urn(name, type_, parent, project, stack)
- inputAlias: Output[Union[Alias, str]] = Output.from_input(alias)
+ inputAlias: 'Output[Union[Alias, str]]' = Output.from_input(alias)
return inputAlias.apply(collapse_alias_to_urn_worker)
+... | [ResourceOptions->[merge->[ResourceOptions]],CustomResource->[__init__->[__init__]],ProviderResource->[__init__->[__init__]],Resource->[_convert_providers->[_convert_providers],__init__->[ResourceTransformationArgs,ResourceOptions,inherited_child_alias,collapse_alias_to_urn]],ComponentResource->[__init__->[__init__]]] | collapse an alias into a URN given a set of default data. | Why does this need to be quoted? Haven't we imported `Output` by this point? |
@@ -51,10 +51,6 @@ class GitHub
*/
public function authorizeOAuth($originUrl)
{
- if ('github.com' !== $originUrl) {
- return false;
- }
-
// if available use token from git config
if (0 === $this->process->execute('git config github.accesstoken', $output)) {
... | [GitHub->[authorizeOAuth->[setAuthentication,execute],authorizeOAuthInteractively->[ask,askAndHideAnswer,write,setAuthentication,get,addConfigSetting,getContents,getCode,execute]]] | Check if the user is authorized to access the GitHub API. | As the logic is still specific to Github, you should check it against the github domains |
@@ -384,7 +384,7 @@ namespace System
// Converts a character to lower-case for invariant culture.
public static char ToLowerInvariant(char c)
{
- return CultureInfo.InvariantCulture.TextInfo.ToLower(c);
+ return TextInfo.Invariant.ToLower(c);
}
//
| [Char->[GetNumericValue->[GetNumericValue],ToLowerInvariant->[ToLower],IsLetter->[CheckLetter,IsLatin1],IsSeparator->[IsLatin1,CheckSeparator,IsSeparatorLatin1],ToString->[ToString],ToLower->[ToLower],IsHighSurrogate->[IsInRange,IsHighSurrogate],IsLetterOrDigit->[IsLatin1,CheckLetterOrDigit],CheckPunctuation->[IsInRang... | To lowercase invariant. | I'd assumed I guess incorrectly that devirtualization was kicking in and enabling this to be direct calls... but I guess not? |
@@ -2,4 +2,8 @@ def extra_product_actions(instance, info, **data):
info.context.plugins.product_updated(instance)
-MODEL_EXTRA_METHODS = {"Product": extra_product_actions}
+def extra_user_actions(instance, info, **data):
+ info.context.plugins.customer_updated(instance)
+
+
+MODEL_EXTRA_METHODS = {"Product"... | [extra_product_actions->[product_updated]] | Adds extra_product_actions to the context. | Just to keep in mind. We are going to introduce the separate events for update_meta. Like produc_metaddata_updated, user_medatada_updated. So just remember that it will be dropped. |
@@ -34,6 +34,11 @@ class TestProjectsIntegrationTest(ProjectIntegrationTest):
'testprojects/src/java/org/pantsbuild/testproject/thriftdeptest',
# TODO(Eric Ayers): I don't understand why this fails
'testprojects/src/java/org/pantsbuild/testproject/jvmprepcommand:compile-prep-command',
+ # TODO... | [TestProjectsIntegrationTest->[test_shard_51->[run_shard],run_shard->[targets_for_shard],test_shard_45->[run_shard],test_shard_5->[run_shard],test_shard_46->[run_shard],test_shard_22->[run_shard],test_shard_41->[run_shard],test_shard_49->[run_shard],test_shard_4->[run_shard],test_shard_60->[run_shard],test_shard_19->[r... | A sequence of target names that should be used in the build. region Public API Methods Tests if a specific node in the system has a reserved node. Return the success of the pants run. | I'm not totally sure, but I'm pretty damn sure, the issue here is `allow_prereleases`. The native dists are always prereleases as things stand with their fingerprint version numbering scheme. Pants via pex (like pip), does not resolve prereleases by default - this has to be turned on. I think you'll need come up with a... |
@@ -518,7 +518,7 @@ int OSSL_PARAM_get_uint64(const OSSL_PARAM *p, uint64_t *val)
switch (p->data_size) {
case sizeof(double):
d = *(const double *)p->data;
- if (d >= 0 && d <= INT64_MAX && d == (uint64_t)d) {
+ if (d >= 0 && d == (uint64_t)d) {
*va... | [OSSL_PARAM_get_size_t->[OSSL_PARAM_get_uint32,OSSL_PARAM_get_uint64],OSSL_PARAM->[OSSL_PARAM_locate],OSSL_PARAM_get_time_t->[OSSL_PARAM_get_int64,OSSL_PARAM_get_int32],OSSL_PARAM_set_time_t->[OSSL_PARAM_set_int64,OSSL_PARAM_set_int32],OSSL_PARAM_get_octet_string_ptr->[OSSL_PARAM_get_octet_ptr],OSSL_PARAM_get_utf8_stri... | OSSL_PARAM_get_uint64 get uint64_t from constant buffer. | The original is wrong here too Changing the comparison to `d >= 0 && d < 18446744073709551616.` should work. |
@@ -1026,7 +1026,7 @@ resource "aws_lb" "test" {
}
resource "aws_eip" "lb" {
- count = "${length(data.aws_availability_zones.available.names)}"
+ count = "${length(data.aws_availability_zones.available.names)>2?2:length(data.aws_availability_zones.available.names)}"
}
`, lbName)
}
| [Wrapf,Meta,DescribeLoadBalancers,Test,Sprintf,TestCheckResourceAttrSet,TestMatchResourceAttr,New,TestCheckResourceAttr,RootModule,String,ComposeAggregateTestCheckFunc,Fatalf,Errorf,MustCompile,RandStringFromCharSet] | region Resource names for all resources in the system A list of tags that can be assigned to the AWS ALB. | Are there any regions with only 1 AZ? Seems like this should just be `count = 2` |
@@ -90,7 +90,15 @@ module Engine
"to #{@game.format_currency(new_value)}"
@round.next_entity_index!
- return if new_value.positive?
+ if company.name == 'Big 4'
+ return if new_value > 59
+ elsif company.name == 'Michigan Southern'
+ return if n... | [DraftDistribution->[finished?->[all_blank?],process_bid->[name],action_finalized->[finished?,name,blank?],process_pass->[only_one_company?,name],only_one_company?->[blank?],actions->[only_one_company?,finished?],all_blank?->[blank?],visible?->[only_one_company?],float_minor->[name]]] | Process a that can be used to select a company. | case company.id when 'BIG4' return if new_value >= 60 when 'MS' return if new_value >= 80 else return if new_value.positive? |
@@ -49,7 +49,7 @@ const generateList = () =>
.trim()
.split('\n')
.reduce((list, path) => {
- const name = path.substr('extensions/'.length).split('/').shift();
+ const name = path.substr('extensions/'.length).split('/').shift() ?? '';
return list + (excludeGeneric.includes(name) ? '' : ... | [No CFG could be retrieved] | Generates a list of a single from the current Markdown file. Check if video player list is updated or not. | This change should be nonfunctional as splitting as string will always result in at an array of length >= 1 but the null check seemed cleaner than a type cast. If anyone else feels otherwise I'm totally open to changing this or other places like it. |
@@ -312,6 +312,15 @@ const Navigation = () => (
<RootStack.Screen name="SelectWallet" component={SelectWallet} options={{ headerLeft: null }} />
<RootStack.Screen name="ReceiveDetails" component={ReceiveDetails} options={ReceiveDetails.navigationOptions} />
<RootStack.Screen name="LappBrowser" component=... | [No CFG could be retrieved] | Initializes the Navigator components. | I had to add it otherwise some other error was throwing |
@@ -95,7 +95,7 @@ func (b BuildDefaults) applyPodProxyDefaults(pod *corev1.Pod, isCustomBuild bool
for _, c := range allContainers {
// All env vars are allowed to be set in a custom build pod, the user already has
// total control over the env+logic in a custom build pod anyway.
- externalEnv := make([]corev1... | [ApplyDefaults->[Infof,applyPodProxyDefaults,SetBuildInPod,V,GetBuildFromPod,applyBuildDefaults,applyPodDefaults],applyPodDefaults->[MergeTrustedEnvWithoutDuplicates,ResourceName,Infof,V,Convert,MergeEnvWithoutDuplicates,TrimSpace],applyBuildDefaults->[V,Convert,ResourceName,Infof],applyPodProxyDefaults->[MergeTrustedE... | applyPodProxyDefaults applies proxy defaults to all containers in a pod. | @adambkaplan this is the fix for the custom build extended test error |
@@ -48,8 +48,14 @@ final class DocumentationNormalizer implements NormalizerInterface
private $urlGenerator;
private $filterCollection;
private $nameConverter;
-
- public function __construct(ResourceMetadataFactoryInterface $resourceMetadataFactory, PropertyNameCollectionFactoryInterface $propertyNam... | [DocumentationNormalizer->[getDefinitionSchema->[normalize],getFiltersParameters->[getType],getType->[getType]]] | Initializes the object. | Here (and for `oauthScopes`) too |
@@ -95,7 +95,7 @@ func (d *DockerIntegrationTester) Test(_ string, mageTarget string, env map[stri
}
dockerRepoRoot := filepath.Join("/go/src", repo.CanonicalRootImportPath)
dockerGoCache := filepath.Join(dockerRepoRoot, "build/docker-gocache")
- magePath := filepath.Join("/go/src", repo.CanonicalRootImportPath, ... | [Use->[IsNotExist,Join,Stat],Test->[SplitList,Join,Exec,Sprintf,Do,Verbose],InsideTest->[Join],Println,Exec,Replace,LookupEnv,NewReplacer,Wrap,Sleep,Verbose] | Test tests that the container is running in the mage target. This is a test function that runs docker - compose and docker - rm on the given container. | Tried to figure out where `GOARCH` is set. Should this be `runtime.GOARCH`? |
@@ -397,9 +397,17 @@ namespace Content.Server.Weapon.Ranged.Barrels.Components
var distance = result.Distance;
hitscan.FireEffects(shooter, distance, angle, result.HitEntity);
var dmg = EntitySystem.Get<DamageableSystem>().TryChangeDamage(result.HitEntity, hitscan.Dama... | [ServerRangedBarrelComponent->[Fire->[PeekAmmo,TakeProjectile],EjectCasings->[EjectCasing],OnRemove->[OnRemove],Initialize->[Initialize]]] | Fire hitscan effects. | Move this inside the `if` unless it's needed somewhere else. |
@@ -411,7 +411,7 @@ public class PartitionedDataWriter<S, D> extends WriterWrapper<D> implements Fin
/**
* Get the serialized key to partitions info in {@link #state}
*/
- private static String getPartitionsKey(int branchId) {
+ public static String getPartitionsKey(int branchId) {
return String.forma... | [PartitionedDataWriter->[bytesWritten->[bytesWritten],getFinalState->[getFinalState,bytesWritten,recordsWritten],writeEnvelope->[writeEnvelope],commit->[commit],cleanup->[cleanup],serializePartitionInfoToState->[getPartitionsKey],createPartitionWriter->[isDataWriterWatermarkCapable],getPartitionInfoAndClean->[getPartit... | Get the key for partitioning. | why changing to public ? |
@@ -71,6 +71,12 @@ func (r *logFileReader) Read(buf []byte) (int, error) {
}
for {
+ select {
+ case <-r.done:
+ return 0, nil
+ default:
+ }
+
n, err := r.fs.Read(buf)
if n > 0 {
r.offset += int64(n)
| [wait->[Sleep,Duration],Read->[Seek,Err,Size,Stat,Name,Now,wait,IsSameFile,Read,Info,Since,Continuable,Debug],Seek,New,Now] | Read reads from the underlying file. If the file is truncated or too old close it. If the file is closed it will. | what if we block on Read? Consider closing the file and do check on r.done being closed in EOF checks |
@@ -25,6 +25,8 @@ module Scinote
# Load all model concerns, including subfolders
config.autoload_paths += Dir["#{Rails.root}/app/models/concerns/**/*.rb"]
+ config.i18n.load_path += Dir[Rails.root.join('config', 'locales', '**', '*.{rb,yml}')]
+
config.encoding = 'utf-8'
config.active_job.que... | [Application->[freeze,to_i,root,use,log_formatter,proc,options,file_max_size_mb,swap,require_relative,queue_adapter,load_defaults,layout,to_prepare,encoding,autoload_paths],groups,require_relative,require] | Initialize an application with a single unique identifier. | Metrics/LineLength: Line is too long. [90/80] |
@@ -16,6 +16,10 @@ class ImageUploadPresignedUrlGenerator
end
end
+ def bucket
+ super(prefix: bucket_prefix)
+ end
+
def bucket_prefix
'login-gov-idp-doc-capture'.freeze
end
| [ImageUploadPresignedUrlGenerator->[presigned_image_upload_url->[to_s,doc_auth_enable_presigned_s3_urls,in_datacenter?,test_fake_s3_url],bucket_prefix->[freeze],include]] | Returns presigned_image_upload_url if presigned_image_upload. | Ruby mixins are super weird... I'm a little worried this will mess up the presigned URL generation when that calls bucket with an argument (since now the method doesn't take an argument), what if we made this a different method like `bucket_domain` or `bucket_cors_url` and use that in the initializer? |
@@ -143,7 +143,7 @@ def test_fetch_feed_unchanged(hacks_feed, mocked_parse, enabled):
"""If the ETag matches, the feed is enabled but not processed."""
hacks_feed.last_modified = datetime(2018, 2, 26, 21, 23, 38)
hacks_feed.etag = 'W/"1da1fc6a456fd49c32a9291b38ec31ee-gzip"'
- hacks_feed.title = u'Mozi... | [test_fetch_feed_redirect->[modify_fpd],test_save_entry_long_guid->[modify_fpd],test_fetch_feed_unchanged->[modify_fpd],test_fetch_feed_missing->[modify_fpd]] | Test fetch_feed_unchanged. | This line that stood out to me, so I double-checked. In Python 3, ``feedparser.parser`` returns with a string ``etag``, not a byte stream, so we should be OK. There may be other issues, but not this :) |
@@ -2,7 +2,10 @@ import React, { useState, useEffect } from 'react'
import Fingerprint2 from 'fingerprintjs2'
import memoize from 'lodash/memoize'
-let cachedFingerprintData
+import withWallet from './withWallet'
+
+let cachedFingerprintData, cachedUUID
+const uuidKey = 'rewards_uuid'
const browserPropsWhitelist... | [No CFG could be retrieved] | Creates a function that returns a wrapped component that will be used to fingerprint the browser properties. | Great naming. uuid is a perfect name for this id. |
@@ -1,11 +1,11 @@
-from __future__ import print_function, absolute_import, division # makes KratosMultiphysics backward compatible with python 2.6 and 2.7
+from __future__ import print_function, absolute_import, division # makes KM backward compatible with python 2.6 and 2.7
#import kratos core and applications
-imp... | [ImplicitMechanicalSolver->[AddDofs->[print,contact_settings,super,VariableUtils],_create_contact_newton_raphson_strategy->[get_convergence_criterion,get_builder_and_solver,ResidualBasedNewtonRaphsonContactStrategy,GetComputingModelPart,AddValue,get_solution_scheme,Parameters,get_linear_solver,settings],AddVariables->[... | Creates an implicit mechanical solver. | I think I like your new syntax Avoids the long names and also the opportunity to use different abbreviations (e.g. - `import KratosMultiphysics.StructuralMechanicsApplication` - `import KratosMultiphysics.StructuralMechanicsApplication as KratosStructural`) - ... |
@@ -0,0 +1,7 @@
+from enum import Enum
+
+
+class ExternalNotificationErrorCodes(Enum):
+ CANNOT_ASSIGN_NODE = "cannot_assign_node"
+ GRAPHQL_ERROR = "graphql_error"
+ WRONG_PLUGIN_ID = "wrong_plugin_id"
| [No CFG could be retrieved] | No Summary Found. | Where do you use this error? |
@@ -266,12 +266,15 @@ public class JParser {
}
astParser.setCompilerOptions(options);
+
+ Set<String> jdkJarsNames = new HashSet<>(Arrays.asList("rt.jar", "jrt-fs.jar", "android.jar"));
+ boolean includeRunningVMBootclasspath = classpath.stream().noneMatch(f -> jdkJarsNames.contains(f.getName()));... | [JParser->[convertTypeDeclaration->[addEmptyDeclarationsToList,firstTokenAfter,declaration,firstTokenBefore],superInterfaceTypes->[superInterfaceTypes],convertArguments->[firstTokenAfter],addStatementToList->[declaration,firstTokenAfter],convertModuleDirective->[lastTokenIn,firstTokenIn,convertModuleNames,convertModule... | Parses a CompilationUnitTree from the given version and unit name. converts the AST node to a compilation unit tree and checks if there is a missing type. | While nothing is shown here, eclipse tells me that there extra spaces. Could you drop them? |
@@ -366,7 +366,7 @@ $boxlist .= $resultboxes['boxlista'];
$boxlist .= '</div>'."\n";
$boxlist .= '<div class="secondcolumn fichehalfright boxhalfright" id="boxhalfright">';
-$boxlist .= $lastmodified;
+$boxlist .= empty($lastmodified) ? '' : $lastmodified;
$boxlist .= '<br>';
$boxlist .= $resultboxes['boxlistb'];... | [setShowPercent,SetData,fetch_object,jdate,order,draw,getNomUrl,show,getTypeUrl,initHooks,setShowLegend,load,plimit,executeHooks,setHeight,escape,close,free,query,SetType,getLibStatut,trans,num_rows] | Displays a list of the thirdparties. | $lastmodified is previously set and sometimes not. A better fix would be to initialise to '' at top of file so it is always defined and $boxlist .= $lastmodified; will be enough. |
@@ -185,7 +185,7 @@ func Compute(subComm *shard.Committee, epoch *big.Int) (*Roster, error) {
// Testnet incident recovery
// Make harmony nodes having 70% voting power for epoch 73314
if nodeconfig.GetDefaultConfig().GetNetworkType() == nodeconfig.Testnet && epoch.Cmp(big.NewInt(73305)) >= 0 &&
- epoch.Cmp(big.... | [MarshalJSON->[MustAddressToBech32,Hex,Sprint,Marshal,EncodeToString],String->[Marshal],GetDefaultConfig,IsZero,Add,MustNewDecFromStr,Quo,HarmonyVotePercent,Cmp,New,Sub,Logger,Debug,SliceStable,Equal,Hex,OneDec,GetNetworkType,Str,Msg,NewDec,InstanceForEpoch,ZeroDec,NewInt,ExternalVotePercent,Mul] | Compute creates a roster based on the given committee and epoch. Dec returns a new object. | need to write the logic so that shard 3 turnup happens at a specific epoch. Otherwise, it will happen at the network update time which is rather random and it will cause sync failures for new nodes. |
@@ -427,10 +427,12 @@ def is_local(path):
If we're not in a virtualenv, all paths are considered "local."
+ Caution: this function assumes the head of path has been normalized
+ with normalize_path.
"""
if not running_under_virtualenv():
return True
- return normalize_path(path).sta... | [hide_value->[HiddenText],hide_url->[HiddenText,redact_password_from_url],get_installed_distributions->[editables_only_test->[dist_is_editable],editable_test->[dist_is_editable],user_test,editables_only_test,local_test,editable_test],captured_stdout->[captured_output],unzip_file->[ensure_dir,has_leading_dir,split_leadi... | Checks if path is local or not. | Can we just normalize the head of path here and below? |
@@ -128,7 +128,7 @@ STACK_OF(CONF_VALUE) *i2v_GENERAL_NAME(X509V3_EXT_METHOD *method,
BIO_snprintf(othername, sizeof(othername), "othername: %s:",
oline);
else
- strncpy(othername, "othername:", sizeof(othername));
+ strncpy(other... | [No CFG could be retrieved] | check if the value is a printable string Get the othername from the IA5STRING. | Since it's: char othername[300], this doesn't seem to fix anything. But if you want to fix something, you would need to make sure it's actually NUL terminated. |
@@ -89,11 +89,11 @@ abstract class Abstract_Jetpack_Site extends SAL_Site {
}
function get_jetpack_modules() {
- if ( is_user_member_of_blog() ) {
- return array_values( Jetpack_Options::get_option( 'active_modules', array() ) );
- }
+ return array_values( Jetpack_Options::get_option( 'active_modules', array... | [Abstract_Jetpack_Site->[wp_max_memory_limit->[get_constant],after_render_options->[wp_version,wp_max_memory_limit,main_network_site,is_main_network,max_upload_size,file_system_write_access,is_version_controlled,get_constant,wp_memory_limit,get_jetpack_version],after_render->[get_updates],featured_images_enabled->[curr... | Get all modules that are active in the Jetpack site. | if we remove the check from here we will want to add it in `json-endpoints/class.wpcom-json-api-get-site-endpoint.php` |
@@ -23,8 +23,6 @@
* @author Tony Murray <murraytony@gmail.com>
*/
-if (!$os) {
- if (strpos($sysDescr, 'Huawei Integrated Access Software') !== false) {
- $os = 'smartax';
- }
+if (str_contains('Huawei Integrated Access Software', $sysDescr)) {
+ $os = 'smartax';
}
| [No CFG could be retrieved] | if system descriptor contains Huawei Integrated Access Software. | Wrong way round :) |
@@ -89,7 +89,7 @@ config.run('amp-image-slider', function() {
// layoutCallback is called
// this is the same as CommonSignal.LOAD_END
return !!slider.signals().get('load-end');
- });
+ }, 1000);
}
function createFakeEvent(type, x, y) {
| [No CFG could be retrieved] | Displays a custom event that will be triggered when the user clicks on an amp - image - This function is called when the user clicks on an image slider. It will wait for the. | Suggest monitoring master red for flakes here and see if there are any platforms (e.g. Chrome on Windows) that need to be skipped due to the lower timeout. |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.