patch stringlengths 18 160k | callgraph stringlengths 4 179k | summary stringlengths 4 947 | msg stringlengths 6 3.42k |
|---|---|---|---|
@@ -47,3 +47,14 @@ def make_user_config():
)
click.secho("Config created at {}".format(user_config_path), fg="green")
+
+
+@cli.command()
+@click.argument("environment_file", type=click.Path(exists=True))
+@click.option("--runner_kwargs", default={})
+def run(environment_file, runner_kwargs):
+ """
+... | [make_user_config->[write,dirname,get,isfile,ValueError,format,open,makedirs,secho],cli->[load_serialized_registry_from_path],option,group,add_command,command] | Generates a user configuration file. | Should this print or click.echo? |
@@ -1659,7 +1659,7 @@ class SemanticAnalyzerPass2(NodeVisitor[None],
# False, and we can skip checking '_' because it's been explicitly included.
if (new_node and new_node.module_public and
(not name.startswith('_') or '__all__' in m.names)):
- ... | [infer_condition_value->[infer_condition_value],make_any_non_explicit->[accept],SemanticAnalyzerPass2->[analyze_comp_for->[analyze_lvalue],build_newtype_typeinfo->[named_type],name_not_defined->[add_fixture_note,lookup_fully_qualified_or_none],check_classvar->[is_self_member_ref],visit_lambda_expr->[analyze_function],b... | Visit all ImportAll nodes. | What's the story with this? Was there an existing bug here that just got exposed by one of these test cases, or is this only necessary with fine-grained mode? |
@@ -605,6 +605,12 @@ public class MockNodeManager implements NodeManager {
this.currentState = currentState;
}
+ NodeData(long capacity, long used, long currentState, long healthyVolumes) {
+ this.capacity = capacity;
+ this.used = used;
+ this.currentState = currentState;
+ }
+
... | [MockNodeManager->[getNodesByAddress->[getNodeByUuid],removePipeline->[removePipeline],onMessage->[addDatanodeCommand],getNodeCount->[getNodes,getNodeCount],getContainers->[getContainers],addPipeline->[addPipeline],getPipelines->[getPipelines],getPipelinesCount->[getPipelinesCount]]] | Get or set the capacity of the resource. | Parameter `healthyVolumes` is unused. |
@@ -1149,6 +1149,7 @@ public class CardEditor extends Activity {
case DIALOG_INTENT_INFORMATION:
dialog = createDialogIntentInformation(builder, res);
+ break;
case DIALOG_CONFIRM_DUPLICATE:
builder.setTitle(res.getString(R.string.save_dupli... | [CardEditor->[onStop->[onStop],reloadCollection->[onPostExecute->[onCreate]],onActivityResult->[onActivityResult,closeCardEditor],onPrepareDialog->[createDialogIntentInformation],run->[duplicateCheck],onDestroy->[onDestroy],onOptionsItemSelected->[resetEditFields],onCreate->[onCreate],onCreateDialog->[onClick->[saveNot... | Creates a dialog with the specified id. dialog dialog dialog dialog dialog dialog dialog dialog dialog dialog dialog dialog dialog dialog dialog dialog dialog dialog This method is called when the user clicks on a dialog which has selected a model. | ;-) That's where we might benefit from a static code analysis tool, running as continuous integration. |
@@ -33,7 +33,6 @@ namespace System.Net.Http
private readonly Dictionary<int, Http2Stream> _httpStreams;
- private readonly AsyncMutex _writerLock;
private readonly CreditManager _connectionWindow;
private readonly CreditManager _concurrentStreams;
| [Http2Connection->[RemoveStream->[CheckForShutdown],WriteHeaders->[WriteLiteralHeaderValue,WriteBytes,WriteIndexedHeader,WriteHeaderCollection],WriteHeaderCollection->[WriteLiteralHeader,WriteLiteralHeaderValue,WriteLiteralHeaderValues,WriteBytes],ThrowProtocolError->[ThrowProtocolError],SendHeadersAsync->[SplitBuffer,... | Creates a new Http2Connection object. Close the connection and wait for it to complete. | I believe this was the only place it was used. We can delete it. |
@@ -1132,7 +1132,8 @@ def plot_topomap(data, pos, vmax=None, cmap='RdBu_r', sensors='k,', res=100,
axes = plt.gca()
axes.set_frame_on(False)
- vmax = vmax or np.abs(data).max()
+ vmax = vmax or data.max()
+ vmin = vmin or data.min()
plt.xticks(())
plt.yticks(())
| [tight_layout->[tight_layout],_epochs_navigation_onclick->[_draw_epochs_axes],plot_evoked_topomap->[_check_delayed_ssp,tight_layout],plot_source_spectrogram->[tight_layout],_helper_resize->[_layout_raw],plot_topo->[_check_delayed_ssp,_plot_topo,_mutable_defaults],_mouse_click->[_pick_bad_channels],plot_epochs->[figure_... | Plot a topographic map as an image. Plots a color image of the missing value in the topomap. | here again I prefer the old behavior. For standard topos it's much better I think |
@@ -360,6 +360,8 @@ class Configuration(object):
def _get_environ_vars(self):
# type: () -> Iterable[Tuple[str, str]]
"""Returns a generator with all environmental vars with prefix PIP_"""
+ if 'VIRTUAL_ENV' in os.environ:
+ os.environ['PIP_USER'] = 'no'
for key, val in... | [Configuration->[_load_file->[items],_get_environ_vars->[items],_iter_config_files->[get_configuration_files],_normalized_keys->[_normalize_name],_load_config_files->[items],items->[items],unset_value->[_disassemble_key,items],set_value->[_disassemble_key]]] | Returns a generator with all environmental variables with prefix PIP_. | We should use `pip._internal.utils.virtualenv.running_under_virtualenv` instead - as-is this will break things if executing something like `/usr/bin/python -m pip ...` explicitly while under a virtual environment. I wish our tests would've caught that. :( |
@@ -522,10 +522,14 @@ public class DoFnTester<InputT, OutputT> {
private TestProcessContext<InputT, OutputT> createProcessContext(
OldDoFn<InputT, OutputT> fn,
- InputT elem) {
+ TimestampedValue<InputT> elem) {
+ WindowedValue<InputT> windowedValue = elem.getTimestamp() == null
+ ? Window... | [DoFnTester->[peekOutputElementsWithTimestamp->[apply->[of]],peekOutputElementsInWindow->[of,peekOutputElementsInWindow],processElement->[startBundle,unwrapUserCodeException,processElement],startBundle->[startBundle],finishBundle->[startBundle,finishBundle,unwrapUserCodeException],takeOutputElements->[peekOutputElement... | Creates a new context for the given old doFn and a new element in the global window. | If you're replacing the timestamp with a non-null value you should instead just use the last line here. |
@@ -67,7 +67,9 @@ public class GlobalInboundInvocationHandler implements InboundInvocationHandler
public void handleFromCluster(Address origin, ReplicableCommand command, Reply reply, DeliverOrder order) {
command.setOrigin(origin);
try {
- if (command instanceof CacheRpcCommand) {
+ i... | [GlobalInboundInvocationHandler->[runXSiteReplicableCommand->[exceptionHandlingCommand,shuttingDownResponse],runReplicableCommand->[exceptionHandlingCommand,shuttingDownResponse],handleFromCluster->[exceptionHandlingCommand]]] | Handles a reply from a cluster. | I don't like this reply null, seems like an error when reading, but I don't know if I have any other suggestion or alternative to offer |
@@ -716,6 +716,10 @@ def setup_package(pkg, dirty):
load_module("cce")
load_module(mod)
+ if os.environ.get("CRAY_CPU_TARGET") == "mic-knl":
+ if "cce" not in pkg.compiler.modules:
+ unload_module("cce")
+
if pkg.architecture.target.module_name:
... | [fork->[child_process->[setup_package]],set_module_variables_for_package->[_set_variables_for_single_module],get_rpaths->[get_rpath_deps],_make_child_error->[ChildError],_set_variables_for_single_module->[MakeExecutable],parent_class_modules->[parent_class_modules],setup_package->[load_external_modules,set_module_varia... | Execute all environment setup routines. Load a node - package - specific module. | Should the `cce` module not be loaded at all unless it is in `pkg.compiler.modules`? |
@@ -1672,8 +1672,9 @@ def fused_batch_norm(
# Set a minimum epsilon to 1.001e-5, which is a requirement by CUDNN to
# prevent exception (see cudnn.h).
+
min_epsilon = 1.001e-5
- epsilon = epsilon if epsilon > min_epsilon else min_epsilon
+ epsilon = epsilon if epsilon >= min_epsilon else min_epsilon
... | [weighted_cross_entropy_with_logits->[weighted_cross_entropy_with_logits_v2],depthwise_conv2d_v2->[depthwise_conv2d],sigmoid_cross_entropy_with_logits_v2->[sigmoid_cross_entropy_with_logits],separable_conv2d_v2->[separable_conv2d],_compute_sampled_logits->[_sum_rows],weighted_moments_v2->[weighted_moments],moments_v2->... | r Batch normalization of a single n - dimensional sequence. A 4D or 5D tensor for the normalized scaled and offsetted current batch of the Missing node - count error. | Please don't add new empty lines |
@@ -248,10 +248,12 @@ public class OMPrepareRequest extends OMClientRequest {
"than prepare index %d. Some required logs may not have" +
" been removed.", actualPurgeIndex, prepareIndex));
}
- } catch (Exception e) {
+ } catch (ExecutionException e) {
// Ozone manager error h... | [OMPrepareRequest->[takeSnapshotAndPurgeLogs->[takeSnapshot,getMessage,getStateMachine,get,format,IOException,warn,onSnapshotInstalled],waitForLogIndex->[debug,sleep,getSeconds,getRatisSnapshotIndex,getIndex,getOMNodeId,format,IOException,toMillis,currentTimeMillis,info],validateAndUpdateCache->[getTxnApplyCheckInterva... | Takes snapshot and purges logs that are not yet persisted to the state machine. | need to throw an exception here otherwise the caller may think the method completed successfully. |
@@ -1194,6 +1194,9 @@ function createBaseCustomElementClass(win) {
*/
viewportCallback(inViewport) {
assertNotTemplate(this);
+ if (inViewport) {
+ blankBoxCounter.enterViewport(this.getResource());
+ }
this.isInViewport_ = inViewport;
if (this.layoutCount_ == 0) {
... | [No CFG could be retrieved] | Initializes a resource - level object. Updates the state of the resource in the specified viewport. | Do we want to do this via `viewportCallback`? Or InOb? With viewportCallback we kind of testing against the same tracking system as `layoutCallback` and we could compound errors. |
@@ -517,11 +517,11 @@ function list_bgp(\Illuminate\Http\Request $request)
}
if (!empty($local_address)) {
$sql .= ' AND `bgpPeers`.`bgpLocalAddr` = ?';
- $sql_params[] = $local_address;
+ $sql_params[] = IP::parse($local_address)->uncompressed();
}
if (!empty($remote_address)... | [get_graphs->[route],get_graph_generic_by_hostname->[has,route,get],list_logs->[route,get,getName],get_bgp->[route],list_links->[route,hasGlobalRead],get_network_ip_addresses->[route],create_edit_bill->[getContent],edit_location->[route,getContent],get_bill_history_graphdata->[route,get],add_components->[route,createCo... | List all bgp peers. | This will throw an exception if it isn't a valid IPv6 address |
@@ -410,7 +410,7 @@ func WriteJobInfo(pachClient *client.APIClient, pipelineJobInfo *pps.PipelineJob
return err
}
-func StatsCommit(commit *pfs.Commit) *pfs.Commit {
+func MetaCommit(commit *pfs.Commit) *pfs.Commit {
return client.NewSystemRepo(commit.Branch.Repo.Name, pfs.MetaRepoType).NewCommit(commit.Branch.N... | [Error->[Sprintf,WriteString,String],ResourceName,FinishCommit,NewCommit,Warnf,WriteByte,Warningf,Now,Clone,ParseQuantity,Info,NewSystemRepo,TagAnySpan,Put,Error,Ctx,VisitInput,Errorf,Bytes,Wrapf,GetFile,Infof,UpdatePipelineJobState,Grow,ToLower,TimestampProto,Get,NewRepo,ReadWrite,Sprintf,NewSQLTx,Unmarshal,Replace,St... | WriteJobInfo creates a new PipelineJob with the given name. SidecarS3GatewayService returns the name of the that is used to create. | I've been meaning to ask, are we intending to just drop the word "stats" everywhere in favor of "meta"? |
@@ -361,10 +361,10 @@ func Build(cfg *config.Config, masterSubnetID string, agentSubnetIDs []string, i
}
}
- if config.MSIUserAssignedID != "" {
+ /*if config.MSIUserAssignedID != "" {
prop.OrchestratorProfile.KubernetesConfig.UseManagedIdentity = true
prop.OrchestratorProfile.KubernetesConfig.UserAssigned... | [Write->[Printf,JSONMarshal,WriteFile],HasNetworkPlugin->[Contains],HasNetworkPolicy->[Contains],HasAddon->[Bool],HasWindowsAgents->[HasWindows],GetWindowsTestImages->[GetWindowsSku,HasWindowsAgents,New,Contains],Atoi,Error,ReadFile,IsKubernetesVersionGe,IsAzureStackCloud,IsWindows,Errorf,Process,Bool,LoadTranslations,... | NodeCount returns the number of nodes that should be provisioned for a given agent definition. HasWindowsAgents returns true if there is at least one agent pool and there is at least. | For this repro, we want to make sure we're using system-assigned ID and not user-assigned ID |
@@ -20,6 +20,7 @@ class Icon(AbstractIcon):
"""
+ # TODO this conflicts with PlotObject.name and should be renamed
name = Enum(NamedIcon, help="""
What icon to use. See http://fortawesome.github.io/Font-Awesome/icons/
for the list of available icons.
| [Icon->[Enum,Float,Bool]] | Create an abstract base class for the given . | Perhaps `PlotObject.name` is too generic. Is it even used anywhere? |
@@ -24,5 +24,13 @@ namespace NServiceBus.Transports
/// True if the transport
/// </summary>
public bool RequireOutboxConsent { get; set; }
+
+ /// <summary>
+ /// Gives implementations access to the <see cref="ConfigurationBuilder"/> instance at configuration time.
+ ///... | [No CFG could be retrieved] | Require the . | shouldnt this be abstract? |
@@ -1032,7 +1032,10 @@ public class ClusterCacheStatus implements AvailabilityStrategyContext {
rootCause = cause;
}
- if (trace) log.tracef("Cache %s cancelling conflict resolution due to root cause t=%s", cacheName, rootCause);
+ // TODO Whe... | [ClusterCacheStatus->[cancelConflictResolutionPhase->[completeConflictResolution],doMergePartitions->[getStableTopology],endReadNewPhase->[setCurrentTopology,getCurrentTopology,isTotalOrder,isDistributed],calculateConflictHash->[updateMembers],setRebalanceEnabled->[startQueuedRebalance],completeConflictResolution->[que... | Queues a conflict resolution. | I don't think this is true because we utilise a LimitedExecutor with `maxCurrentTasks == 1` in the DefaultConflictManager to execute CR. |
@@ -51,7 +51,7 @@ public class DefaultMuleEventTestCase extends AbstractMuleContextTestCase {
@Before
public void before() throws Exception {
- flow = getTestFlow();
+ flow = getTestFlow(muleContext);
messageContext = DefaultEventContext.create(flow, TEST_CONNECTOR);
muleEvent = Event.builder(me... | [DefaultMuleEventTestCase->[defaultProcessingStrategyOneWay->[thenReturn,build,equalTo,isTransacted,isSynchronous,spy,assertThat,DefaultFlowProcessingStrategy],before->[getTestFlow,create,build],inboundPropertyForceSyncOneWay->[thenReturn,build,equalTo,isTransacted,isSynchronous,assertThat,spy],setSessionVariableCustom... | This method is called before the test. | Is it preferred to use static method in MuleTestUtils over method in AbstractMuleContextTestCase that does not require MuleContext? The later seems simple.. |
@@ -127,8 +127,9 @@ properties = {
'type': 'object',
'patternProperties': {
# prefix-relative path to be inspected for existence
- r'\w[\w-]*': {
- '$ref': '#/definitions/array_of_strings'}}},
+ r'\w[\w-]... | [No CFG could be retrieved] | The base schema for the module. Schema with metadata for a specific base configuration. | Aaah. Isn't that better? |
@@ -46,14 +46,14 @@ namespace System.ComponentModel.Design
protected override void WndProc(ref Message m)
{
- switch (m._Msg)
+ switch (m.MsgInternal)
{
case User32.WM.KEYDOWN:
_lastKeyDown = m;
... | [CollectionEditor->[FilterListBox->[RefreshItem->[RefreshItem],WndProc->[WndProc]]]] | This method is called when the user presses a key down or a key press. It. | tbh, i did not like this naming convention either. We use `lParam` and `wParam `extensively across VS and .NET repos. why are they not good here? |
@@ -144,6 +144,10 @@ public class InsertValuesExecutor {
final DataSource dataSource = getDataSource(config, metaStore, insertValues);
+ if (!verifyInsertValuesAllowed(insertValues.getColumns(), dataSource)) {
+ throw new KsqlException("Cannot insert into a HEADER column");
+ }
+
final Producer... | [InsertValuesExecutor->[maybeThrowSchemaRegistryAuthError->[defaultIfNull,supportsFeature,getSRSubject,getRootCause,getStatus,KsqlSchemaAuthorizationException],throwIfDisabled->[KsqlException,getBoolean],ensureKeySchemasMatch->[getSchemaRegistryClient,maybeThrowSchemaRegistryAuthError,getName,equals,getFormat,supportsF... | Execute a insert with a . | It'd be good to display the column header name. Perhaps throwing the exception from inside the method would be helpful so you can customize the message. What about renaming the method too `validateInsert()` or `throwIfInsertOnHeadersColumns()`? |
@@ -70,7 +70,7 @@ class SuluSnippetExtension extends Extension implements PrependExtensionInterfac
'sulu_document_manager',
[
'mapping' => [
- 'snippet' => ['class' => SnippetDocument::class, 'phpcr_type' => 'sulu:snippet'],
+ ... | [SuluSnippetExtension->[prepend->[prependExtensionConfig,hasExtension],load->[processConfiguration,setParameter,load]]] | Prepends a configuration with a to the container. | i would refactor the SnippetController to use the metadata to get the form-type |
@@ -1132,8 +1132,8 @@ class AddonReviewerViewSet(GenericViewSet):
def disable(self, request, **kwargs):
addon = get_object_or_404(Addon, pk=kwargs['pk'])
ActivityLog.create(amo.LOG.CHANGE_STATUS, addon, amo.STATUS_DISABLED)
- self.log.info('Addon "%s" status changed to: %s' %
- ... | [beta_signed_log->[context],leaderboard->[context],performance->[_sum,context],review->[perform_review_permission_checks,determine_channel,_get_comments_for_hard_deleted_versions,context],queue_auto_approved->[is_admin_reviewer,_queue],abuse_reports->[context],_queue->[is_admin_reviewer,filter_admin_review_for_legacy_q... | Disable an addon. | hmm? This isn't a `%` substitution? |
@@ -3,9 +3,10 @@ module Api
class GithubReposController < ApiController
def index
client = create_octokit_client
- existing_user_repos = GithubRepo.
- where(user_id: current_user.id, featured: true).pluck(:github_id_code) #=> [1,2,3]
- existing_user_repos = Set.new(existing_u... | [GithubReposController->[fetched_repo_params->[watchers,stargazers_count,id,html_url,to_hash,fork,language,size,permitted_attributes,description,name],create_octokit_client->[new,token],update_or_create->[fetched_repo_params,render,find_or_create,full_messages,featured,touch,valid?],fetch_repo->[parse,detect,id,to_i],i... | This action shows the missing node index for the user. | `.distinct.pluck` tells the DB to select only unique values, so we don't have to use `Set.new` or `.to_set` in memory |
@@ -52,7 +52,7 @@ export class Renderer {
* @private
*/
setState_(type, state) {
- this.vsync_.mutate(() => {
+ this.resources_.mutateElement(this.getRootElement_() , () => {
this.getRootElement_().classList.toggle(
`${CSS_PREFIX}-${type}-unk`,
state === null);
| [No CFG could be retrieved] | A renderer for a single . Sets the state of a node in the grant list. | Please use `this.ampdoc_.getBody()` instead here. |
@@ -210,6 +210,9 @@ public class JobTest {
@LocalData
@Test public void configDotXmlPermission() throws Exception {
+ // legacy behavior re-enabled (could be changed when the webclient will be adapted
+ ApiTokenPropertyConfiguration.get().setTokenGenerationOnCreationEnabled(true);
+
... | [JobTest->[testRenameWithLeadingSpaceTrimsLeadingSpace->[assumeFalse,tryRename,isWindows],JobPropertyImpl->[DescriptorImpl],emptyDescriptionReturnsEmptyPage->[getContent,createWebClient,createFreeStyleProject,setDescription,assertEquals],testRenameWithTrailingSpaceTrimsTrailingSpace->[assumeFalse,tryRename,isWindows],t... | Checks if the user has config. xml permission. | NIT: could be better as a test helper method that is called, so that when the TODO is done it will be easier to change all the test code. |
@@ -43,10 +43,10 @@ public class KsqlGenericRowAvroSerializer implements Serializer<GenericRow> {
public KsqlGenericRowAvroSerializer(
org.apache.kafka.connect.data.Schema schema,
SchemaRegistryClient schemaRegistryClient, KsqlConfig
- ksqlConfig
+ ksqlConfig
) {
String avroSchema... | [KsqlGenericRowAvroSerializer->[serialize->[serialize]]] | package io. confluent. ksql. serde. avro. Serializer This is a helper method that creates an Avro serializer for the . | nit: Bring the `Ksqlconfig` down onto this line. |
@@ -33,7 +33,7 @@ public class DelegateExecutionManager {
* only 1 block can be held (the block is equivalent to the read lock).
*/
private final ReentrantReadWriteLock readWriteLock = new ReentrantReadWriteLock();
- private final ThreadLocal<Boolean> currentThreadHasReadLock = ThreadLocal.withInitial(() ->... | [DelegateExecutionManager->[createInboundImplementation->[invoke->[assertGameNotOver,invoke],assertGameNotOver],createOutboundImplementation->[currentThreadHasReadLock],enterDelegateExecution->[currentThreadHasReadLock]]] | Set game over. | Is there a specific reason the Boolean class objects get replaced with their according primitives that simply get casted back to instances of the Boolean class? |
@@ -281,7 +281,7 @@ func NewCmdRouter(f *clientcmd.Factory, parentName, name string, out, errout io.
cmd.Flags().StringVar(&cfg.ForceSubdomain, "force-subdomain", "", "A router path format to force on all routes used by this router (will ignore the route host value)")
cmd.Flags().StringVar(&cfg.ImageTemplate.Format... | [IsAlreadyExists,StringVar,Status,IsValidIP,Examples,ConstraintAppliesTo,Now,SecurityContextConstraints,BindForOutput,Exit,IsDNS1123Subdomain,IntVar,Add,LabelsFromSpec,Itoa,FormatBool,PrivateKeysFromPEM,LongDesc,New,UTC,Errorf,Int32Var,Services,CheckErr,Bool,Clients,DefaultNamespace,ShouldPrint,Join,UnixNano,Contains,W... | Flags for the HAPROXY router Default certificate file. | Service isn't right is it? It controls what goes into the pod spec. |
@@ -473,7 +473,7 @@ export class VisibilityManagerForDoc extends VisibilityManager {
};
this.unsubscribe(this.viewport_.onScroll(ticker));
this.unsubscribe(this.viewport_.onChanged(ticker));
- setTimeout(ticker);
+ ticker();
return intersectionObserverPolyfill;
}
| [No CFG could be retrieved] | Replies the intersection ratio of an element. Handles the changes of the entry. | I liked `setTimeout` because that's how native API works. The pings are ALWAYS asynchronous. So, this was not accidental :) |
@@ -436,7 +436,8 @@ func (conn *Connection) execHTTPRequest(req *http.Request) (int, []byte, error)
}
if conn.APIKey != "" {
- req.Header.Add("Authorization", "ApiKey "+conn.APIKey)
+ encoded := base64.StdEncoding.EncodeToString([]byte(conn.APIKey))
+ req.Header.Add("Authorization", "ApiKey "+encoded)
}
... | [Test->[Connect],LoadJSON->[Request],getVersion->[Ping],Close] | execHTTPRequest executes the given request and returns the response status code the object and an error. | would it make sense to cache the result in a private variable like `conn.encodedAPIKey` ? |
@@ -449,7 +449,7 @@ Rails.application.routes.draw do
resources :repositories do
post 'repository_index',
- to: 'repositories#repository_table_index',
+ to: 'repository_rows#index', # repository_rows#index repositories#repository_table_index
as: 'table_index',
de... | [draw->[instance_eval,read,join],draw,namespace,collection,resources,member,root,new,match,scope,get,constraints,post,devise_scope,patch,devise_for,require,put,delete] | List of registered protocol types A list of records in a repository. | Line is too long. [99/80] |
@@ -363,6 +363,14 @@ export class AmpStoryInteractive extends AMP.BaseElement {
/** @override */
layoutCallback() {
+ if (
+ isExperimentOn(this.win, 'amp-story-interactive-disclaimer') &&
+ this.element.hasAttribute('endpoint')
+ ) {
+ // Needs to be called after buildCallback to measure p... | [AmpStoryInteractive->[updateToPostSelectionState_->[classList],constructor->[urlForDoc,cidForDoc],handleOptionSelection_->[optionIndex_],adjustGridLayer_->[tagName,dev,classList,closest,parentElement],initializeListeners_->[CURRENT_PAGE_ID,RTL_STATE],getInteractiveId_->[documentInfoForDoc,deduplicateInteractiveIds,bas... | Callback for the layout. | a11y ux: On a screen reader this would be read after reading all of the quiz content. Using `.prepend` can help ensure a screen reader will read this before the quiz content. You may need to add `z-index: 1;` to the disclaimer CSS since this will change the layout order. |
@@ -19,6 +19,13 @@ def test_new_simple(tmp_dir, scm, dvc, exp_stage, mocker):
).read_text() == "foo: 2"
+@pytest.mark.skipif(os.name == "nt", reason="Not supported for Windows.")
+def test_file_permissions(tmp_dir, scm, dvc, exp_stage, mocker):
+ tmp_dir.gen("params.yaml", "foo: 2")
+ dvc.experiments.run... | [test_extend_branch->[,_get_branch_containing,checkout,run,first],test_failed_exp->[StageCmdFailedError,at_level,patch,run,gen],test_checkout->[first,,checkout,run],test_detached_parent->[,reproduce,first,checkout,get_baseline,get_rev,gen,run,add,commit],test_modify_params->[,assert_called_once,run,gen,add,commit,spy],... | Test failed experiment. | NTFS also doesn't have +x, right? Just clarifying. We have some `not supported on windows` tests that are really about ntfs and not windows itself. Just important for us to keep that in mind :slightly_smiling_face: |
@@ -201,6 +201,7 @@ class WP_Test_Jetpack_Sync_Options extends WP_Test_Jetpack_Sync_Base {
'site_user_type' => wp_json_encode( array( 1 => 'pineapple' ) ),
'site_segment' => 'pineapple',
'site_vertical' => 'pineapple',
+ 'jetpack_exclude... | [WP_Test_Jetpack_Sync_Options->[test_don_t_sync_option_if_not_on_whitelist->[do_sync,get_option,assertEquals],test_sync_options_that_use_filter->[do_sync,get_option,assertEquals,update_options_whitelist],test_added_option_is_synced->[get_option,assertEquals],test_deleted_option_is_synced->[do_sync,get_option,assertEqua... | This method is used to set the default options for the sync client This function is used to create a network interface that can be used to create a network interface This function is used to provide a list of all the available packages. | nitpicky - lack of alignment |
@@ -20093,6 +20093,8 @@ void Player::_SaveMail(SQLTransaction& trans)
stmt = CharacterDatabase.GetPreparedStatement(CHAR_DEL_MAIL_ITEM_BY_ID);
stmt->setUInt32(0, m->messageID);
trans->Append(stmt);
+ if(totalMailCount > 0)
+ totalMailCount--;
}
... | [No CFG could be retrieved] | fills in the necessary fields of the mail object. This method is called from the main thread. It is called from the main thread. | missing space after the `if` |
@@ -1068,7 +1068,8 @@ void tool_change(const uint8_t new_tool, bool no_move/*=false*/) {
#endif
#ifdef EVENT_GCODE_AFTER_TOOLCHANGE
- gcode.process_subcommands_now_P(EVENT_GCODE_AFTER_TOOLCHANGE);
+ if (!no_move)
+ gcode.process_subcommands_now_P(PSTR(EVENT_GCODE_AFTER_TOOLCHANGE));
#e... | [No CFG could be retrieved] | Get the list of all components in the system. | Looks like `no_move` has a bigger meaning now. Probably time to rename it to something like "`is_internal`." |
@@ -102,3 +102,17 @@ def rm_conandir(path):
short_path = load(link)
rmdir(os.path.dirname(short_path))
rmdir(path)
+
+
+def hashed_redirect(base, path, min_length=6, attempts=10):
+ max_length = min_length + attempts
+
+ full_hash = sha256(path.encode())
+ assert len(full_hash) > max_len... | [conan_expand_user->[dict,expanduser,get,update,getenv,exists,clear],rm_conandir->[dirname,rmdir,join,exists,load],ignore_long_path_files->[_filter->[relpath,append,len,normpath,join,warn]],path_shortener->[mkdir,mkdtemp,getenv,check_output,rmdir,join,get_env,exists,save,splitdrive,load]] | removes a directory that might contain a link to a short path. | are we running into possible race condition here in case of two CI jobs are trying to create hash redirect? |
@@ -343,7 +343,7 @@ class H2OCache(object):
domain = v['domain'] # Map to cat strings as needed
x = ["" if math.isnan(idx) else domain[int(idx)] for idx in x]
elif t == "time":
- x = ["" if math.isnan(z) else time.strftime("%Y-%m-%d %H:%M:%S", time.localtim... | [H2OCache->[_tabulate->[fill,is_valid],is_valid->[nrows_valid,types_valid,ncols_valid,names_valid,is_empty],flush->[H2OCache]],ExprNode->[_debug_print->[_collapse_sb],_to_string->[_arg_to_expr],_arg_to_expr->[_get_ast_str],_2_string->[_2_string]]] | Pretty tabulate the data and column names of the cached data. | Should it be UTC, or the timezone specified by user? |
@@ -87,3 +87,18 @@ setup(
},
cmdclass={'test': PyTest},
)
+
+
+if NO_VENDOR:
+ print("""
+###########################################################################
+## IMPORTANT IMPORTANT IMPORTANT IMPORTANT IMPORTANT IMPORTANT IMPORTANT ##
+##############################################################... | [find_version->[read],PyTest->[finalize_options->[finalize_options]],find_version,read] | Return an instance of the cmdclass. | I think you left out a "not" here :) |
@@ -281,7 +281,7 @@ class DBConnection(object):
:param tableName: name of table
:return: array of name/type info
"""
- sqlResult = self.select("PRAGMA table_info(%s)" % tableName)
+ sqlResult = self.select("PRAGMA table_info(`%s`)" % tableName)
columns = {}
for... | [restoreDatabase->[dbFilename],SchemaUpgrade->[hasColumn->[tableInfo],incDBVersion->[checkDBVersion,action],checkDBVersion->[checkDBVersion],addColumn->[action],hasTable->[select]],DBConnection->[hasColumn->[tableInfo],action->[execute],selectOne->[action],mass_action->[execute],tableInfo->[select],__init__->[dbFilenam... | Table info on a database table . | @MGaetan89 this does the same thing |
@@ -428,7 +428,12 @@ export default class LargeVideoManager {
ReactDOM.render(
<Provider store = { APP.store }>
<I18nextProvider i18n = { i18next }>
- <PresenceLabel participantID = { id } />
+ <PresenceLabel
+ ... | [No CFG could be retrieved] | Resizes all containers and updates the message of the displayed participant id. Remove the presence label from the DOM. | Passing in new objects as props can cause unnecessary reloads. Are you sure you want to pass in objects as props? Are you doing this so it's re-usable on web and native? |
@@ -69,6 +69,7 @@ public class HoodieTableConfig implements Serializable {
public static final String HOODIE_TIMELINE_LAYOUT_VERSION = "hoodie.timeline.layout.version";
public static final String HOODIE_PAYLOAD_CLASS_PROP_NAME = "hoodie.compaction.payload.class";
public static final String HOODIE_ARCHIVELOG_FO... | [HoodieTableConfig->[getTableName->[getProperty],getBaseFileFormat->[containsKey,valueOf,getProperty],getArchivelogFolder->[getProperty],getBootstrapIndexClass->[getProperty],getTableVersion->[containsKey,versionFromCode,getProperty,parseInt],createHoodieProperties->[Path,create,IllegalArgumentException,equals,mkdirs,D... | This method is used to find all the Hoodie properties. This class is used to configure the Hoodie table. | may I know where do we set default value for this config to false? |
@@ -556,7 +556,7 @@ RSpec.describe Dependabot::Docker::FileParser do
context "with a non-standard filename" do
let(:dockerfile) do
Dependabot::DependencyFile.new(
- name: "custom-name",
+ name: "custom-dockerfile-name",
content: dockerfile_body
)
end
| [new,let,describe,require_common_spec,subject,first,it,its,to,before,require,last,it_behaves_like,parse,fixture,to_json,context,be_a,eq,raise_error,and_return] | The following methods are defined in the section below. missing - context with multiple dockerfiles. | I was confused by the initial test here. A 'dockerfile' with a name 'custom-name' should never have been picked up by the file_fetcher code which, if I understand correctly, is what will feed the parser code. So the string 'dockerfile' should be in the name somewhere to be picked up and that is what this change is doin... |
@@ -211,7 +211,7 @@ public abstract class AbstractCasView extends AbstractView {
final Assertion assertion = getAssertionFrom(model);
final List<Authentication> chainedAuthentications = assertion.getChainedAuthentications();
- for (int i = 0; i < chainedAuthentications.size() - 2; i++) {
+ ... | [AbstractCasView->[getChainedAuthentications->[getChainedAuthentications,getAssertionFrom],getAuthenticationDate->[getAuthenticationDate],getAuthenticationAttribute->[getPrimaryAuthenticationFrom],getPrincipal->[getPrincipal],isRememberMeAuthentication->[getAuthenticationAttributesAsMultiValuedAttributes]]] | Gets the chained authentications. | I'm sure it's not, but this change feels like magic. Any way to improve this source code? Extracting the `chainedAuthentications.size() - 1` code into a meaningful variable? |
@@ -131,6 +131,11 @@ public class BeamFnDataReadRunner<OutputT> {
private final BeamFnDataClient beamFnDataClient;
private final Coder<WindowedValue<OutputT>> coder;
+ private final Object splittingLock = new Object();
+ // 0-based count of the number of elements
+ private long index = -1;
+ // 0-based coun... | [BeamFnDataReadRunner->[Registrar->[getPTransformRunnerFactories->[of,Factory]],blockTillReadFinishes->[get,awaitCompletion,debug],registerInputLocation->[get,receive,of],Factory->[createRunnerForPTransform->[getOnlyElement,error,getCoderId,get,register,isEmpty,getMultiplexingConsumer,values]],forComponents,fromProto,g... | Creates a new instance of the class. Returns a Coder<WindowedValue<OutputT >> if this port has a c. | 0 based index of the current element being processed(?). |
@@ -308,9 +308,15 @@ func (d *driver) getAccessLevel(pachClient *client.APIClient, repo *pfs.Repo) (a
if err != nil {
return auth.Scope_NONE, err
}
- if who.IsAdmin {
- return auth.Scope_OWNER, nil
+
+ if who.AdminGrant != nil {
+ for _, s := range who.AdminGrant.Scopes {
+ if s == auth.AdminGrant_SUPER || s... | [getTreeForOpenCommit->[scratchFilePrefix],finishOutputCommit->[checkIsAuthorizedInTransaction],upsertPutFileRecords->[scratchFilePrefix],deleteFile->[makeCommit,inspectCommit,checkIsAuthorized,checkFilePath],listRepo->[getAccessLevel],scratchFilePrefix->[scratchCommitPrefix,checkFilePath],resolveCommitProvenance->[res... | getAccessLevel returns the current access level for the given repository. | This method lives in the PFS server but it seems like a re-implementation of Authorize in the auth server - especially if we wire up group membership it probably makes sense to consolidate this logic in the auth server. |
@@ -7,10 +7,12 @@
* https://www.openssl.org/source/license.html
*/
-/* This must be the first #include file */
-#include "../async_locl.h"
+#include <openssl/opensslconf.h>
#ifdef ASYNC_NULL
+int ASYNC_is_capable(void);
+void async_local_cleanup(void);
+
int ASYNC_is_capable(void)
{
return 0;
| [No CFG could be retrieved] | if async is capable. | A little strange to see this include go away, but if the null implementation is not actually using anything, it sort-of makes sense. On the other hand, it does provide the prototypes that are being added manually below -- does having it included actually cause problems? |
@@ -71,6 +71,8 @@ public final class OpenSslEngine extends SSLEngine {
private static final AtomicIntegerFieldUpdater<OpenSslEngine> DESTROYED_UPDATER =
AtomicIntegerFieldUpdater.newUpdater(OpenSslEngine.class, "destroyed");
+ private static final long EMPTY_ADDR = Buffer.address(Unpooled.EMPTY_B... | [OpenSslEngine->[closeInbound->[shutdown],unwrap->[shutdown,writeEncryptedData,readPlaintextData],wrap->[readEncryptedData,writePlaintextData,shutdown],closeOutbound->[shutdown]]] | Creates an array of X509Certificates. Private helper methods. | Could you check all your pull requests which keep a static final field of empty direct NIO buffer and use this idiom: `Unpooled.EMPTY_BUFFER.nioBuffer()` so that we do not create multiple 0-capacity direct buffers? |
@@ -43,11 +43,13 @@ public class BootstrapParameters {
* @param userIn user
* @param passwordIn password
* @param activationKeysIn activation keys
+ * @param reactivationKeyIn reactivation key
* @param ignoreHostKeysIn ignore hostIn keys?
* @param proxyIdIn proxy id
*/
publi... | [BootstrapParameters->[createFromJson->[BootstrapParameters]]] | Creates a BootstrapParameters object for the given host IP address password private key and passphrase. Parameters method for creating a new instance of the class. | Why not `Optional<String> reactivationKeyIn` as parameter? It seems to me that it would have been more consistent also for the caller to pass `Optional.empty()` instead of an empty string. Moreover, in the handler we have the method `maybeString()` that can deal with converting an empty string to an empty optional. |
@@ -944,6 +944,15 @@ class Convolution(object):
self.data_format = data_format
self.strides = strides
self.name = name
+ self.conv_op = AtrousConvolution(
+ self.input_shape,
+ filter_shape=self.filter_shape,
+ padding=padding,
+ dilation_rate=dilation_rate,
+ data_f... | [fractional_avg_pool->[fractional_avg_pool],softmax_cross_entropy_with_logits_v2_helper->[_move_dim_to_end,_flatten_outer_dims],_WithSpaceToBatch->[__init__->[build_op]],convolution_v2->[convolution],pool->[_get_strides_and_dilation_rate,with_space_to_batch],bias_add->[bias_add],log_softmax_v2->[_softmax],atrous_conv2d... | Helper function for convolution. Create a batch operation that creates a new batch of objects from the specified configuration. | you need to change convolution itself not to use _WithSpaceToBatch |
@@ -245,7 +245,7 @@ def _read_annotations_brainvision(fname, sfreq='auto'):
The annotations present in the file.
"""
onset, duration, description, date_str = _read_vmrk(fname)
- orig_time = None if date_str == '' else _str_to_meas_date(date_str)
+ orig_time = _str_to_meas_date(date_str)
... | [_aux_vhdr_info->[_check_hdr_version],read_raw_brainvision->[RawBrainVision],_get_vhdr_info->[_aux_vhdr_info,_str_to_meas_date],_read_annotations_brainvision->[_read_vmrk]] | This function reads a BrainVision vrmk file and creates Annotations object. | annotations `orig_time` has to either be `None` or a date. If you pass 'foobar' or '' some tests should be breaking. If its not the case I did not do a good enough job on testing it. |
@@ -35,7 +35,7 @@ class Device extends BaseModel
public $timestamps = false;
protected $primaryKey = 'device_id';
- protected $fillable = ['hostname', 'ip', 'status', 'status_reason', 'sysName', 'sysDescr', 'sysObjectID', 'hardware', 'version', 'features', 'serial', 'icon'];
+ protected $fillable = ['... | [Device->[shortDisplayName->[displayName],name->[displayName],scopeCanPing->[scopeWhereAttributeDisabled]]] | Creates a new device object based on a sequence of objects. Order of device to find the next missing node in the system. | Missing the snmpv3 fileds. Check against the array in createHost() Also, you can make this array vertical (one item per line) |
@@ -82,6 +82,11 @@ func resourceIamBindingRead(newUpdaterFunc newResourceIamUpdaterFunc) schema.Rea
eBinding := getResourceIamBinding(d)
p, err := updater.GetResourceIamPolicy()
if err != nil {
+ if isGoogleApiErrorWithCode(err, 404) {
+ log.Printf("[DEBUG]: Binding for role %q not found for non-existant ... | [Printf,GetResourceId,Get,New,GetResourceIamPolicy,List,Id,Errorf,SetId,Set,Split,DescribeResource] | newResourceIamBindingRead returns a ReadFunc that reads a resource - level policy from state iamBindingImport returns a state func that imports a binding from a given resource ID. | If you want to remove it from the state file, you'll also want to add `d.SetId("")`. Also I realize there are other log statements with it in here but I don't think the extra `\n` is really necessary |
@@ -0,0 +1,17 @@
+package node
+
+// go-ethereum/node/service.go
+
+import (
+ "github.com/ethereum/go-ethereum/event"
+ "github.com/harmony-one/harmony/accounts"
+)
+
+// ServiceContext is a collection of service independent options inherited from
+// the protocol stack, that is passed to all constructors to be option... | [No CFG could be retrieved] | No Summary Found. | where are we using this? |
@@ -282,7 +282,7 @@ class MatrixTransport(Runnable):
def __init__(self, config: dict):
super().__init__()
self._config = config
- self._raiden_service: RaidenService = None
+ self._raiden_service: Optional[RaidenService] = None
if config['server'] == 'auto':
... | [_RetryQueue->[enqueue->[_expiration_generator,_MessageData],_run->[_check_and_send],enqueue_global->[enqueue],_check_and_send->[message_is_in_queue]],MatrixTransport->[_send_with_retry->[enqueue,_get_retrier],_handle_presence_change->[_spawn,UserPresence],_get_retrier->[start,_RetryQueue],stop->[notify],start->[start]... | Initialize a new object with a configuration dict. Initialize the semaphore for any n - node - related locks. | IIRC we said that we won't use `Optional` for arguments that have a default of `None` (since that already expresses the optional-ness) |
@@ -444,7 +444,9 @@ class CloudCache:
)
if not hash_info:
- hash_info = tree.get_hash(path_info, **kwargs)
+ kw = kwargs.copy()
+ kw.pop("download_callback", None)
+ hash_info = tree.get_hash(path_info, **kw)
if not hash_info:
... | [CloudCache->[all->[list_hashes,list_hashes_traverse,_estimate_remote_size],transfer->[_transfer_directory,_transfer_file],_transfer_directory->[_transfer_directory_contents],_estimate_remote_size->[update->[update],list_hashes,_max_estimation_size,_hashes_with_limit],changed_cache->[changed_cache_file,_changed_dir_cac... | Save a node in the tree. | This is temporary, we'll start computing hash on-the-fly in the followup PRs. |
@@ -2339,6 +2339,14 @@ class Archiver:
metavar='PATH', help='restrict repository access to PATH. '
'Can be specified multiple times to allow the client access to several directories. '
... | [main->[get_args,run,Archiver],with_repository->[decorator->[wrapper->[argument]]],Archiver->[_export_tar->[item_to_tarinfo->[print_warning,item_content_stream],build_filter,print_warning,build_matcher,item_to_tarinfo],do_prune->[print_error,write],do_mount->[print_error],do_check->[print_error],do_extract->[build_filt... | Build a parser for the command line. Command line interface for borg - Deduplicate - Backups. command line interface for handling command - line options Initializes a new empty repository. This command can be used to initialize a repository with a specific key. | as we are talking about permissions: s/can/may/ ? |
@@ -14,10 +14,12 @@ namespace System.IO.Strategies
// this type defines a set of stateless FileStream/FileStreamStrategy helper methods
internal static partial class FileStreamHelpers
{
- internal const int ERROR_BROKEN_PIPE = 109;
- internal const int ERROR_NO_DATA = 232;
- private ... | [FileStreamHelpers->[WriteFileNative->[GetLastWin32ErrorAndDisposeHandleIfInvalid],ReadFileNative->[GetLastWin32ErrorAndDisposeHandleIfInvalid],Task->[ReadFileNative],VerifyHandleIsSync->[IsHandleSynchronous]]] | Choose the appropriate strategy for the given file handle. | Consider prefixing this constants with `AsyncCompletionSource_` or something alike since these names are too ambiguous or keep them in their respective classes regardless of them being duplicated. |
@@ -568,7 +568,10 @@ def _get_extra_points(pos, extrapolate, origin, radii):
else:
assert extrapolate == 'head'
# return points on the head circle
- angle = np.arcsin(distance / 2 / np.mean(radii))
+ angle = np.arcsin(distance / np.mean(radii))
+ n_pnts = np.round(2 * np.pi /... | [plot_evoked_topomap->[_make_head_outlines,_plot_topomap,_prepare_topomap_plot],_plot_ica_topomap->[_make_head_outlines,_add_colorbar,plot_topomap,_prepare_topomap_plot],_GridData->[__init__->[_get_extra_points]],_setup_interp->[_GridData],_animate->[_hide_frame],_init_anim->[set_values,_hide_frame,_make_head_outlines,... | Get coordinates of additinal interpolation points. get the new pos and the new pos of the Add points on the head circle where the n - th edge is the distance between the center Compute the new position of the cluster with a random number of points in the middle of the. | At this point I would just do `np.linspace(0, 2 * np.pi, n_pts, endpoint=False)` -- it ensures you get exactly `n_pts` which you are not guaranteed from the `np.arange` operating on `float` due to precision issues, and you don't need to recompute `angle`. |
@@ -2294,13 +2294,15 @@ public class SchedV2 extends AbstractSched {
public void randomizeCards(long did) {
- List<Long> cids = mCol.getDb().queryColumn(Long.class, "select id from cards where did = " + did, 0);
+ List<Long> cids = mCol.getDb().queryColumn(Long.class, "select id from cards where ... | [SchedV2->[_resetRevCount->[_currentRevLimit],_revConf->[_cardConf],haveBuried->[haveBuriedSiblings,haveManuallyBuried],dueForecast->[dueForecast],_fillNew->[_resetNew,_fillNew],suspendCards->[log],resetCards->[log,forgetCards],cardCount->[_deckLimit],counts->[counts],_getLrnCard->[_fillLrn,_maybeResetLrn,getCard,_getL... | randomize cards. | I'll ask whether `queryColumn` is the correct abstraction here. We seem to only be using it to pass in 0, `querySingleColumn` would be more descriptive, and would reduce the surface for bugs. |
@@ -106,8 +106,12 @@ namespace Microsoft.Xna.Framework.Graphics
mesh.Draw();
}
}
-
- public void CopyAbsoluteBoneTransformsTo(Matrix[] destinationBoneTransforms)
+
+ /// <summary>
+ /// Copies bone transforms relative to all parent bones of the each bone from this model... | [Model->[Draw->[Draw],BuildHierarchy->[BuildHierarchy]]] | Creates a new model with the same attributes as this one but with the same parameters. This function is called from the Transform class when it is called from the constructor. | `The array receiving the transformed bones.` |
@@ -35,7 +35,10 @@ namespace DSCoreNodesUI
combo.SelectionChanged += delegate
{
if (combo.SelectedIndex != -1)
- model.OnAstUpdated();
+ {
+ model.OnAstUpdated();
+ }
+
};
... | [DropDownNodeViewCustomization->[combo_DropDownOpened->[PopulateItems],CustomizeView->[PortHeightInPixels,DataContext,SelectionChanged,OnAstUpdated,Add,DropDownClosed,ItemsSourceProperty,Stretch,TwoWay,SetColumn,SelectedIndexProperty,DropDownOpened,SetBinding,Center,SetRow,NaN,model,SelectedIndex]]] | Customize the view with a DropDownBase. | This file should be excluded. |
@@ -418,9 +418,13 @@ void meritum_state::meritum(machine_config &config)
pit.out_handler<2>().set_inputline(m_maincpu, INPUT_LINE_NMI);
i8255_device &mainppi(I8255(config, "mainppi")); // parallel interface
- mainppi.out_pc_callback().set("nmigate", FUNC(input_merger_device::in_w<0>)).bit(7).invert();
+ mainppi.o... | [No CFG could be retrieved] | Configures the MARC input and output handlers. config - i8255 - i8253 - config. | Please make the model 2 machine configuration function call the model 1 machine configuration function then add this. |
@@ -1,10 +1,11 @@
class AccountShow # rubocop:disable Metrics/ClassLength
- attr_reader :decorated_user, :decrypted_pii, :personal_key
+ attr_reader :decorated_user, :decrypted_pii, :personal_key, :locked_for_session
- def initialize(decrypted_pii:, personal_key:, decorated_user:)
+ def initialize(decrypted_pii:... | [AccountShow->[manage_personal_key_partial->[blank?],password_reset_partial->[present?],piv_cac_partial->[enabled?],personal_key_partial->[present?],header_personalization->[email,present?,first_name],verified_account_badge_partial->[identity_verified?],totp_partial->[enabled?],piv_cac_content->[t,enabled?],pending_pro... | Initialize a new object. | looks like `locked_for_session` was added in both places this class is used in the main flow, let's remove the default param? (since the other `AccountShow.new` appear to be all in specs?) |
@@ -64,11 +64,13 @@ import java.util.Map;
public class TopNQueryQueryToolChest extends QueryToolChest<Result<TopNResultValue>, TopNQuery>
{
private static final byte TOPN_QUERY = 0x1;
-
private static final Joiner COMMA_JOIN = Joiner.on(",");
- private static final TypeReference<Result<TopNResultValue>> TYPE_R... | [TopNQueryQueryToolChest->[ThresholdAdjustingQueryRunner->[run->[run]]]] | Package for testing purposes. The base implementation for the feature. | This this typereference needed? |
@@ -452,6 +452,15 @@ class RaidenService(Runnable):
def get_block_number(self):
return views.block_number(self.wal.state_manager.current_state)
+ def pop_payment_status(
+ self,
+ target: typing.TargetAddress,
+ payment_identifier: typing.PaymentID,
+ ) -> typing.O... | [RaidenService->[_register_payment_status->[PaymentStatus],_callback_new_block->[handle_state_change],handle_state_change->[_redact_secret],on_message->[on_message],leave_all_token_networks->[handle_state_change],stop->[stop],_initialize_messages_queues->[_register_payment_status,start_health_check_for],start->[start],... | Get the block number of the node. | This function is not necessary at all, the lock is around an atomic operation `pop` (the first dictionary lookup always succeeds because it's a `defaultdict` |
@@ -247,10 +247,10 @@ public final class XmlFile {
this.encoding = encoding;
}
}
- InputSource input = new InputSource(file.toURI().toASCIIString());
- input.setByteStream(new FileInputStream(file));
- try {
+ try (InputStream in = new FileInputStream... | [XmlFile->[mkdirs->[mkdirs],unmarshal->[unmarshal],write->[write],asString->[toString],writeRawTo->[readRaw],exists->[exists],delete->[delete],sniffEncoding->[startElement->[Eureka],attempt->[Eureka]],toString->[toString]]] | This method tries to detect the encoding of the file. | Could this result in different behavior? And if so, was the previous behavior possibly wrong? I.e. relying on `get` to return what was `set`? |
@@ -131,8 +131,8 @@ foreach (dbFetchRows($host_sql, $host_par) as $device) {
<td><?php echo $devlink?></td>
<td><?php echo $status?></td>
<td><?php echo formatUptime(time() - $service['service_changed'])?></td>
- <td><span class='box-desc'><?php echo nl2br(trim($service['service_messag... | [No CFG could be retrieved] | Displays a list of all services that have a unique id. | Any reason this isn't using clean() |
@@ -280,7 +280,8 @@ void Camera::update(LocalPlayer* player, f32 frametime, f32 busytime,
v3f rel_cam_target = v3f(0,0,1);
v3f rel_cam_up = v3f(0,1,0);
- if (m_view_bobbing_anim != 0 && m_camera_mode < CAMERA_MODE_THIRD)
+ if (m_cache_view_bobbing_amount != 0.0f && m_view_bobbing_anim != 0.0f &&
+ m_camera_mode ... | [step->[event,my_modf,setItem,MYMIN,fabs],successfullyCreated->[empty,clear],f32->[modf],drawNametags->[getProjectionMatrix,getAlpha,utf8_to_wide,multiplyWith1x4Matrix,getScreenSize,end,begin,getFont,getAbsolutePosition,v3f,getViewMatrix],removeNametag->[remove],drawWieldedTool->[,getAbsoluteTransformation,setPosition,... | This is the main entry point for the camera. This function is called from the camera when it is in a lighting state. - - - - - - - - - - - - - - - - - - This function is called from the camera camera when it is drawn. | brace on wrong line |
@@ -121,6 +121,7 @@ const (
forceLogType = "json-file" //Use in inspect to allow docker logs to work
annotationKeyLabels = "docker.labels"
killWaitForExit time.Duration = 2 * time.Second
+ killWaitBeforeForce time.Duration = 10 * time.Second //Time to wait for si... | [AttachStreams->[Wait],Signal->[Wait,Signal,IsRunning]] | Client returns a client. PortLayer object that can be used to access the portlayer s if imageID is not empty returns the unique identifier of the container. | Do we need this anymore? |
@@ -67,9 +67,9 @@ from spack.version import Version
_db_dirname = '.spack-db'
# DB version. This is stuck in the DB file to track changes in format.
-_db_version = Version('0.9.2')
+_db_version = Version('0.9.3')
-# Default timeout for spack database locks is 5 min.
+# Default timeout for spack database locks is... | [InstallRecord->[from_dict->[InstallRecord]],Database->[prefix_write_lock->[prefix_lock],_add->[InstallRecord,_add],_read_from_file->[from_dict,invalid_record,check,_read_spec_from_dict,_assign_dependencies,to_dict],_decrement_ref_count->[_decrement_ref_count],query_one->[query],installed_dependents->[add],_write->[_wr... | The base implementation of this module. The constructor for a list of packages. | maybe just remove this and say "timeout for spack database locks in seconds" |
@@ -8,9 +8,8 @@ from kuma.core.utils import paginate
from ..constants import DOCUMENTS_PER_PAGE
from ..decorators import process_document_path, prevent_indexing
-from ..models import (Document, DocumentTag, Revision, ReviewTag,
+from ..models import (Document, DocumentTag, ReviewTag,
Localiza... | [needs_review->[get_object_or_404,render,filter_for_review,paginate,count],tags->[render,order_by,paginate],revisions->[int,is_authenticated,render,MultiQuerySet,get,paginate,filter,exists,select_related,get_object_or_404],with_localization_tag->[get_object_or_404,render,filter_with_localization_tag,paginate,count],wit... | List wiki documents depending on the optionally given tag. | This was the only user of MultiQuerySet. That code should be deleted if we end up not using it. |
@@ -129,7 +129,13 @@ public abstract class TaskExecutor<T extends TaskExecutor.ActorContext> {
result = rayFunction.getConstructor().newInstance(args);
}
} catch (InvocationTargetException e) {
- LOGGER.error("Execute rayFunction {} failed. actor {}, args {}", rayFunction, actor, args)... | [TaskExecutor->[execute->[getRayFunction,createActorContext,getActorContext,setActorContext],checkByteBufferArguments->[getRayFunction]]] | Executes the ray function. This method is called when a task is executed. It will add the result of the task ContextClassLoader - Thread safe. | I don't think it's reasonable to print task arguments. They may create massive outputs. |
@@ -0,0 +1,15 @@
+<?php
+/*
+ * LibreNMS
+ *
+ * Copyright (c) 2017 Aldemir Akpinar <aldemir.akpinar@gmail.com>
+ * This program is free software: you can redistribute it and/or modify it
+ * under the terms of the GNU General Public License as published by the
+ * Free Software Foundation, either version 3 of the Lice... | [No CFG could be retrieved] | No Summary Found. | Need to shift this MOXA-IK.... |
@@ -491,8 +491,14 @@ class NewSemanticAnalyzer(NodeVisitor[None],
del self.options
def visit_func_def(self, defn: FuncDef) -> None:
- if not defn.is_decorated and not defn.is_overload:
- self.add_func_to_symbol_table(defn)
+ defn.is_conditional = self.block_depth[-1] > 0
+
+ ... | [names_modified_in_lvalue->[names_modified_in_lvalue],NewSemanticAnalyzer->[analyze_comp_for->[analyze_lvalue],refresh_top_level->[add_implicit_module_attrs],name_not_defined->[is_incomplete_namespace,add_fixture_note,record_incomplete_ref,lookup_fully_qualified_or_none],check_classvar->[is_self_member_ref],visit_lambd... | Visit a function definition. | This explanation is not very clear. I would rather say that we don't add function top-level functions when we just enter each of it during second phase of analysis -- processing of functions. Also I would rather explain _why_ this is needed (I agree that this looks reasonable). |
@@ -149,7 +149,7 @@ def runtime_main(test_class):
parser.add_argument('--use_cuda', action='store_true')
parser.add_argument('--use_reduce', action='store_true')
parser.add_argument(
- '--use_reader_alloc', action='store_true', required=False, default=True)
+ '--use_reader_alloc', action='s... | [TestDistRunnerBase->[run_pserver->[get_model,get_transpiler],run_trainer->[get_model,get_transpiler,get_data]],TestDistBase->[_run_cluster->[start_pserver,_wait_ps_ready],check_with_place->[_run_cluster,_run_local],setUp->[_setup_config,_after_setup_config]],runtime_main->[run_pserver,run_trainer]] | Run the test. | This will cause dist_se_resnext test fail |
@@ -21,7 +21,12 @@ logging.getLogger().setLevel(logging.INFO)
root_dir = os.path.abspath(os.path.join(os.path.abspath(__file__), "..", "..", ".."))
IGNORED_SAMPLES = {
- "azure-eventgrid": ["__init__.py"]
+ "azure-eventgrid": [
+ "__init__.py",
+ "consume_cloud_events_from_eventhub.py",
+ ... | [run_samples->[abspath,walk,error,basename,fnmatch,append,run_check_call,get,"Sample,endswith,format,join,info,exit],abspath,add_argument,ArgumentParser,getLogger,parse_args,run_samples,join,info] | Runs all samples in the specified directory. | dumb question for my own learning: why here is a `__init__.py` file to be ignored, I don't see there is a `__init__.py` inside the sample folder? |
@@ -21,7 +21,7 @@ import java.util.Set;
* Interface get a set of incompatible elements for an object
* @see CompatibleSet
*/
-public interface CompatibleElement<T extends CompatibleElement> {
+public interface CompatibleElement<T extends CompatibleElement<T>> {
Set<T> getIncompatibleWith();
}
| [No CFG could be retrieved] | Returns a set of objects that are not compatible with this set. | Just fixing a compiler warning. We were missing the recursive generic parameter. |
@@ -12,6 +12,7 @@ using static Interop;
using static Interop.BCrypt;
using Microsoft.Win32.SafeHandles;
+#nullable enable
namespace Internal.NativeCrypto
{
internal static partial class BCryptNative
| [Cng->[BCryptDecrypt->[BCryptDecrypt],BCryptEncrypt->[BCryptEncrypt]]] | Creates a new BCRYPT algorithm from a given name. Interop layer around Windows CNG api. | This is needed because some other System.*.dll projects that haven't yet been annotated include this file? Let's make sure to follow-up to delete these once they're unnecessary. |
@@ -115,7 +115,12 @@ public class MapCoder<K, V> extends StandardCoder<Map<K, V>> {
Map<K, V> retval = Maps.newHashMapWithExpectedSize(size);
for (int i = 0; i < size; ++i) {
K key = keyCoder.decode(inStream, context.nested());
- V value = valueCoder.decode(inStream, context.nested());
+ V va... | [MapCoder->[decode->[decode],of->[of],registerByteSizeObserver->[registerByteSizeObserver],encode->[encode]]] | Decodes a map of keys and values from the given input stream. | Update to remove the if from the loop: ``` if (size == 0) { return empty map } for (i = 0; i < size - 1; ++i) { decode nested key and value } decode nested key decode value using context passed in |
@@ -231,8 +231,9 @@ class Model(torch.nn.Module, Registrable):
# want the code to look for it, so we remove it from the parameters here.
_remove_pretrained_embedding_params(model_params)
model = Model.from_params(vocab, model_params)
- model_state = torch.load(weights_file, map_locatio... | [Model->[load->[load,from_params]],_remove_pretrained_embedding_params->[_remove_pretrained_embedding_params]] | Instantiates a model based on a specific configuration. get the n - th device from the model if it is a cuda device or cpu. | Alternatively I could handle this by checking whether `Ensemble` is a base class. |
@@ -324,7 +324,7 @@ public class DefaultHttpHeaders extends HttpHeaders {
@Override
public boolean contains(String name, String value, boolean ignoreCase) {
- return contains((CharSequence) name, (CharSequence) value, ignoreCase);
+ return contains(name, value, ignoreCase);
}
@Over... | [DefaultHttpHeaders->[contains->[contains],entries->[add],setInt->[setInt],equals->[equals],HeaderValueConverter->[HeaderValueConverter],hashCode->[hashCode],remove->[remove],get->[get],getInt->[getInt],isEmpty->[isEmpty],addShort->[addShort],copy->[copy,DefaultHttpHeaders],HeaderValueConverterAndValidator->[convertObj... | Checks if the header contains the given name and value. | This is needed as otherwise it will go into an infinite loop. |
@@ -1467,9 +1467,14 @@ func (c *RaftCluster) RegionWriteStats() map[uint64][]*statistics.HotPeerStat {
return c.hotStat.RegionStats(statistics.WriteFlow, c.GetOpts().GetHotRegionCacheHitsThreshold())
}
-// CheckRWStatus checks the read/write status.
-func (c *RaftCluster) CheckRWStatus(region *core.RegionInfo) {
-... | [UpdateStoreLabels->[GetStore],DropCacheRegion->[GetRegion],getRegionStoresLocked->[GetStore],SetAllStoresLimitTTL->[SetAllStoresLimitTTL],GetClusterVersion->[GetClusterVersion],GetRegionStores->[GetRegionStores],GetMetaStores->[GetMetaStores],onStoreVersionChangeLocked->[GetStores],GetStoreLimitByType->[GetStoreLimitB... | RegionWriteStats returns a map of write flow statistics for a given region. | It seems these two functions can be replaced by c.hotStat.xxx directly? |
@@ -10,9 +10,6 @@
#include <sof/platform.h>
#include <ipc/topology.h>
-STATIC_ASSERT(0 == (HEAP_BUF_ALIGNMENT % PLATFORM_DCACHE_ALIGN),
- invalid_heap_buf_alignment);
-
/* Heap blocks for system runtime */
static struct block_hdr sys_rt_block64[HEAP_SYS_RT_COUNT64];
static struct block_hdr sys_rt_block512[... | [BLOCK_DEF,STATIC_ASSERT,ARRAY_SIZE] | region System Runtime Heap Heap memory map for the given . | Why did you remove this? |
@@ -254,7 +254,7 @@ namespace ProtoCore.AST.AssociativeAST
var buf = new StringBuilder();
if (ArrayDimensions != null)
- buf.Append(ArrayDimensions);
+ buf.Append(ArrayDimensions.ToString());
ReplicationGuides.ForEach(x => buf.Append("<" + x.ToStr... | [BinaryExpressionNode->[ToString->[ToString],Equals->[Equals]],PostFixNode->[Equals->[Equals]],CatchFilterNode->[Equals->[Equals]],ReplicationGuideNode->[ToString->[ToString],Equals->[Equals]],CatchBlockNode->[Equals->[Equals]],UnaryExpressionNode->[Equals->[Equals]],AstExtensions->[ToImperativeNode->[CodeBlockNode,ToI... | This method returns a string representation of the object. | Is this needed? |
@@ -407,8 +407,9 @@ class LayerHelper(object):
act_type = act.pop('type')
tmp = input_var
# NOTE(dzhwinter): some activation support inplace compution.
- if not core.IsInplace(act_type):
- tmp = self.create_tmp_variable(dtype=input_var.dtype)
+ # if not core.IsInplace... | [LayerHelper->[create_parameter->[_create_weight_normalize],append_bias_op->[create_tmp_variable,append_op,create_parameter],input_dtype->[multiple_input],_create_weight_normalize->[__reshape_op->[append_op],__norm_op->[append_op],__transpose_op->[append_op],__norm_except_dim->[__reshape_op,__transpose_op,__norm_op],__... | Append an activation to the network. | have you chat with @dzhwinter about this change? It seems inplace activations are disabled? Might not pass CE. |
@@ -5,6 +5,7 @@
#include "ScriptMgr.h"
#include "ScriptedCreature.h"
#include "Player.h"
+#include "mana_tombs.h"
enum ePrince
{
| [boss_nexusprince_shaffar->[boss_nexusprince_shaffarAI->[Reset->[Reset]]]] | External code for the class. This is a helper method for the summons and events methods. | maybe move to first? |
@@ -30,8 +30,11 @@ URL = 'http://ai.stanford.edu/%7Eamaas/data/sentiment/aclImdb_v1.tar.gz'
MD5 = '7c2ac02c03563afcf9b574c7e56c153a'
-# Read files that match pattern. Tokenize and yield each file.
def tokenize(pattern):
+ """
+ Read files that match pattern. Tokenize and yield each file.
+ """
+
w... | [train->[reader_creator],test->[reader_creator],word_dict->[build_dict],reader_creator->[load->[tokenize],reader],build_dict->[tokenize]] | Tokenize the image. | `pattern` ==> `the given pattern` the, a, an `some patterns` |
@@ -198,7 +198,7 @@ static int handle_symlink(const char *filename, const char *fullpath)
*/
static int do_file(const char *filename, const char *fullpath, enum Hash h)
{
- STACK_OF (X509_INFO) *inf = NULL;
+ STACK_OF (X509_INFO) * inf = NULL;
X509_INFO *x;
X509_NAME *name = NULL;
BIO *b;
| [int->[bit_set,OPENSSL_hexchar2int,add_entry,PEM_X509_INFO_read_bio,strerror,strdup,do_file,unlink,bit_isset,sk_OPENSSL_STRING_push,sk_OPENSSL_STRING_pop_free,BIO_new_file,OPENSSL_DIR_end,lstat,symlink,memcpy,memcmp,strlen,handle_symlink,isxdigit,OSSL_NELEM,strncasecmp,BIO_puts,strrchr,app_malloc,sk_X509_INFO_num,sk_OP... | do_file - check if a file can be read and if so return the number of Add missing entry if name or hash is missing. | This should be `STACK_OF(X509_INFO) *inf = NULL` The reason `util/openssl-format-source` didn't fix this is the space between `STACK_OF` and `(X509_INFO)`... it shouldn't have been there. |
@@ -69,7 +69,7 @@ class _RuleVisitor(ast.NodeVisitor):
@memoized
-def subsystem_rule(optionable_factory: Type[OptionableFactory]) -> "TaskRule":
+def SubsystemRule(optionable_factory: Type[OptionableFactory]) -> "TaskRule":
"""Returns a TaskRule that constructs an instance of the subsystem.
TODO: This ... | [goal_rule->[inner_rule],_make_rule->[wrapper->[subsystem_rule,_RuleVisitor,RuleAnnotations,resolve_type,_get_starting_indent]],inner_rule->[wrapper->[rule_decorator],rule_decorator],named_rule->[inner_rule],rule_decorator->[UnrecognizedRuleArgument,RuleAnnotations,_ensure_type_annotation,_make_rule],RuleIndex->[normal... | Returns a TaskRule that constructs an instance of the subsystem. . | This now violates Python naming conventions. You should always use snake_case for function names. But, I argue that we should optimize for the hundreds of call sites we'll have, rather than purity here. We could refactor this to be a class with `__call__` defined. I didn't do that because I don't know how to preserve t... |
@@ -117,8 +117,12 @@ func ValidateHostSubnetUpdate(obj *sdnapi.HostSubnet, old *sdnapi.HostSubnet) fi
func ValidateNetNamespace(netnamespace *sdnapi.NetNamespace) field.ErrorList {
allErrs := validation.ValidateObjectMeta(&netnamespace.ObjectMeta, false, path.ValidatePathSegmentName, field.NewPath("metadata"))
+ i... | [Invalid,Size,Error,Index,Contains,ValidateObjectMetaUpdate,ValidateObjectMeta,Child,ValidVNID,ParseCIDR,ParseIP,NewPath] | ValidateHostNetworkUpdate tests if required fields in the HostNetwork are set. Meta returns the object that will be populated with the fields of the policy. | Unfortunately we're not consistent with that. But most the places I've checked use uppercase ID, so I'd suggest leaving as was. |
@@ -56,10 +56,18 @@ class AvailableThirdPartyArtifacts:
class MutableTrieNode:
+ __slots__ = [
+ "children",
+ "recursive",
+ "addresses",
+ "first_party",
+ ] # don't use a `dict` to store attrs
+
def __init__(self):
self.children: dict[str, MutableTrieNode] = {}
... | [find_artifact_mapping->[find_child],find_all_jvm_artifact_targets->[AllJvmArtifactTargets],MutableTrieNode->[ensure_child->[MutableTrieNode]],UnversionedCoordinate->[from_coord_str->[UnversionedCoordinate]],find_available_third_party_artifacts->[UnversionedCoordinate,AvailableThirdPartyArtifacts],compute_java_third_pa... | Initialize the node with a base node. | If we end up having the `!` syntax for `packages`, we may want to redefine this field for more complicated exclusions, but for now, this will do. |
@@ -157,6 +157,10 @@ export class IframeTransport {
}
ampDoc.body.removeChild(frameData.frame);
delete IframeTransport.crossDomainIframes_[type];
+ if (IframeTransport.performanceObservers_[this.type_]) {
+ IframeTransport.performanceObservers_[this.type_].disconnect();
+ IframeTransport.per... | [No CFG could be retrieved] | Creates a unique value for a specific type of cross - domain iframe or to differentiate messages Sends an AMP Analytics trigger event to a vendor s cross - domain iframe or queues the. | nit: `[type]` , same below |
@@ -363,7 +363,7 @@ func (c *clusterInfo) handleRegionHeartbeat(region *core.RegionInfo) error {
// Mark isNew if the region in cache does not have leader.
var saveKV, saveCache, isNew bool
if origin == nil {
- log.Infof("[region %d] Insert new region {%v}", region.GetId(), region)
+ log.Infof("[region %d] Inse... | [GetLeaderStore->[GetStore],GetFollowerStores->[GetStore],GetStore->[GetStore],handleStoreHeartbeat->[GetStore],handleRegionHeartbeat->[updateStoreStatus,GetRegion],IsRegionHot->[IsRegionHot],RandLeaderRegion->[RandLeaderRegion],AllocPeer->[allocID],GetRegionStores->[GetStore],RandFollowerRegion->[RandFollowerRegion],G... | handleRegionHeartbeat handles a heartbeat from a region. This function is called by the leader to update the state of the cluster. | I think '%v' already contains the `approximateSize`. |
@@ -244,14 +244,16 @@ export class AmpAdNetworkAdsenseImpl extends AmpA4A {
}
/** @override */
- getAdUrl(consentState) {
+ getAdUrl(consentTuple) {
if (
- consentState == CONSENT_POLICY_STATE.UNKNOWN &&
+ !consentTuple ||
+ consentTuple.consentState == CONSENT_POLICY_STATE.UNKNOWN &&
... | [No CFG could be retrieved] | Get the ad client ID for the current ad unit. Private method for generating unique slot id for an AMPA element. | As mentioned previously, do not see how this would ever be nullable and so you can remove this check. Also in general make sure to wrap portions of predicate in parens when mixing or and and operators |
@@ -969,8 +969,9 @@ bool Server::checkInteractDistance(RemotePlayer *player, const f32 d, const std:
else if (max_d < 0)
max_d = BS * 4.0f;
- // cube diagonal: sqrt(3) = 1.732
- if (d > max_d * 1.732) {
+ // Cube diagonal * 1.5 for maximal supported node extents:
+ // sqrt(3) * 1.5 ≅ 2.6
+ if (d > max_d + 2.6f *... | [handleCommand_Interact->[process_PlayerPos,checkInteractDistance],handleCommand_PlayerPos->[process_PlayerPos]] | Checks if a player has interacted the given distance from the hand to the player. | And the `* 1.732`? Why is it gone? |
@@ -60,9 +60,9 @@ public class ErrataOverviewSerializer extends RhnXmlRpcCustomSerializer {
SerializerHelper helper = new SerializerHelper(serializer);
helper.add("id", errata.getId());
- helper.add("issue_date", errata.getIssueDate());
- helper.add("date", errata.getUpdateDate());
- ... | [ErrataOverviewSerializer->[doSerialize->[getUpdateDate,getMetadataValue,getIssueDate,getAdvisorySynopsis,getAdvisoryType,writeTo,SerializerHelper,getId,add,getAdvisoryName]]] | Serializes the errata. | We better would return real date objects which are known by XMLRPC. But that would break all existing code which use this API. So I think this is correct for now. |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.