patch stringlengths 18 160k | callgraph stringlengths 4 179k | summary stringlengths 4 947 | msg stringlengths 6 3.42k |
|---|---|---|---|
@@ -1624,6 +1624,10 @@ function elgg_views_boot() {
'deps' => array('jquery'),
'exports' => 'jQuery.fn.ajaxForm',
));
+ elgg_define_js('jquery.ui', array(
+ 'src' => '/vendors/jquery/jquery-ui-1.10.4.min.js',
+ 'deps' => array('jquery'),
+ ));
$elgg_js_url = elgg_get_simplecache_url('js', 'elgg');
elgg_... | [elgg_does_viewtype_fallback->[doesViewtypeFallback],elgg_view_entity->[getType,getSubtype],elgg_register_viewtype_fallback->[registerViewtypeFallback],elgg_view_layout->[getUrlSegments,getFirstUrlSegment],elgg_view_entity_annotations->[getType],elgg_view->[renderView],elgg_view_exists->[viewExists],_elgg_views_minify-... | Boot the elgg views register all the views This function is used to set the icons of the current image. | Is there an "exports" value you can add here? Or does jquery-ui already declare itself as an AMD module? |
@@ -5,6 +5,7 @@
*
* Copyright (c) 2013-2014 Simon Fraser University Library
* Copyright (c) 2003-2014 John Willinsky
+ * Copyright (c) 2014 Eirik Hanssen
* Distributed under the GNU GPL v2. For full terms see the file docs/COPYING.
*
* @class ArticleHTMLGalley
| [ArticleHTMLGalley->[setStyleFileId->[setData],_handleOjsUrl->[getJournalFilesPath,getSiteFilesPath,getId],getStyleFile->[getData],getHTMLContents->[getIssueIdentification,getArticleId,getImageFiles,getBestGalleyId,getFileId,getOriginalFileName,getLocalizedTitle,getIssueByArticleId,readFile],getImageFiles->[getData],se... | Get the contents of an HTML galley. Replace for Flowplayer and Google Play. | Would you be amenable to adding your name as a contributor without adding it to the copyright? We're trying to keep our formal copyrights as simple as possible e.g. in case we want to relicense to GPL 3.0 in the future. |
@@ -348,10 +348,14 @@ public abstract class GIMMapping extends IndexMapping {
private Map<String, Object> dateField() {
return merge(typeField("date"), Collections.singletonMap(
"format",
- "yyyy-MM-dd HH:mm:ss||yyyy-MM-dd||basic_date_time||basic_date_time_no_millis||epoch_... | [GIMMapping->[notAnalyzedStringWithLowercaseNormalizer->[notAnalyzedString],messageTemplate->[settings]]] | dateField - Date field. | Do we need to add the `8` prefix here as well? Or is it not supported in this format? |
@@ -255,6 +255,9 @@ class ChocolateyTool(BaseTool):
'findstr /c:"1 packages installed."' % package_name, None)
return exit_code == 0
+ def _parse_package(self, package, arch):
+ return package
+
class PacManTool(BaseTool):
def add_repository(self, repositor... | [SystemPackageTool->[add_repository->[add_repository],install->[_get_sysrequire_mode,update],_install_any->[install],update->[_get_sysrequire_mode,update]]] | Check if package is installed. | Can we move this default implementation of `_parse_package` to the parent class (`BaseTool`). It is repeated several times. |
@@ -505,3 +505,9 @@ func (node *Node) initNodeConfiguration() (service.NodeConfig, chan p2p.Peer) {
func (node *Node) AccountManager() *accounts.Manager {
return node.accountManager
}
+
+// SetDNSFlag indicates whether use harmony dns server to get peer info for node syncing
+func (node *Node) SetDNSFlag(flag bool)... | [AddPendingTransaction->[addPendingTransactions],InitShardState->[Beaconchain],addPendingTransactions->[reducePendingTransactions],countNumTransactionsInBlockchain->[Blockchain],getTransactionsForNewBlock->[reducePendingTransactions],Blockchain,Beaconchain] | AccountManager returns the account manager for this node. | This is a debug message, not an info as there is nothing more informative. |
@@ -287,7 +287,7 @@ type HostConfig struct {
ContainerIDFile string `json:"ContainerIDFile"`
LogConfig *LogConfig `json:"LogConfig"` //TODO
NetworkMode string `json:"NetworkMode"`
- PortBindings map[string]struct{} ... | [ID,Wrapf,Args,GetArtifact,GetImage,Unmarshal,Shutdown,LookupContainer,Config,String,Errorf,GetImageInspectInfo,RuntimeName,Writer,Bool,Inspect,Out] | getCgroup returns the name of the cgroup that is associated with the given spec. Spec for missing missing check - type parameters. | Almost certainly not going to end up being this, as we use different structs elsewhere. I would recommend `[]ocicni.PortMapping` as used in libpod |
@@ -477,6 +477,15 @@ final class DocumentationNormalizer implements NormalizerInterface
if (null !== $type && !$type->isCollection() && (null !== $className = $type->getClassName()) && $this->resourceClassResolver->isResourceClass($className)) {
$propertyData['owl:maxCardinality'] = 1;
}
... | [DocumentationNormalizer->[getProperty->[getRange],getHydraOperations->[getPropertyNameCollectionFactoryContext],getHydraProperties->[getPropertyNameCollectionFactoryContext]]] | Returns an array of properties. | Should be yoda style |
@@ -99,6 +99,9 @@ void ObjectProperties::serialize(std::ostream &os) const
writeF1000(os, automatic_face_movement_max_rotation_per_sec);
os << serializeString(infotext);
os << serializeString(wield_item);
+ writeV3F1000(os, selectionbox.MinEdge);
+ writeV3F1000(os, selectionbox.MaxEdge);
+ writeU8(os, !pointable)... | [deSerialize->[readU16,readV2F1000,readV2S16,readARGB8,SerializationError,readF1000,readV3F1000,deSerializeString,push_back,clear,readS16,readU8],dump->[getAlpha,getGreen,PP2,getBlue,str,getRed,PP],emplace_back->[emplace_back],serialize->[writeV3F1000,writeF1000,size,writeU8,writeV2F1000,writeU16,serializeString,writeS... | Serialize all properties of an object into an output stream. | why invert the boolean ? please keep the right value |
@@ -149,14 +149,12 @@ class _NonAtrousConvolution(object):
conv_dims))
if conv_dims == 1:
# conv1d uses the 2-d data format names
- if data_format is None or data_format == "NWC":
- data_format_2d = "NHWC"
- elif data_format == ... | [_WithSpaceToBatch->[__init__->[build_op]],pool->[_get_strides_and_dilation_rate,with_space_to_batch],bias_add->[bias_add],dropout->[_get_noise_shape],atrous_conv2d->[convolution],softmax_cross_entropy_with_logits_v2->[_ensure_xent_args,_move_dim_to_end,_flatten_outer_dims],sparse_softmax_cross_entropy_with_logits->[_e... | Initialize a object. Conv3D convolution op. | Before it only gave a deprecation warning if the user passed "NCHW" or "NHWC" but now it raises an error. Change {"NCW", "NWC"} to {"NCW", "NWC", "NCHW", "CHWC"} |
@@ -230,3 +230,17 @@ export function applySearchAutocomplete($input, siteSettings) {
);
}
}
+
+export function updateRecentSearches(currentUser, term) {
+ let recentSearches = Object.assign(currentUser.recent_searches || A());
+
+ if (recentSearches.length === 5) {
+ if (recentSearches.includes(term)) {
+... | [No CFG could be retrieved] | c onstructor of ect. | Did this not work without the `A`? Usually it's not required. |
@@ -285,6 +285,12 @@ def lcmv(evoked, forward, noise_cov, data_cov, reg=0.05, label=None,
detected automatically. If int, the rank is specified for the MEG
channels. A dictionary with entries 'eeg' and/or 'meg' can be used
to specify the rank for each modality.
+ apply_noise_norm: False | ... | [_lcmv_source_power->[_prepare_beamformer_input,_reg_pinv],lcmv_raw->[_setup_picks,_apply_lcmv],lcmv->[_setup_picks,_apply_lcmv],tf_lcmv->[_setup_picks,_lcmv_source_power],lcmv_epochs->[_setup_picks,_apply_lcmv],_apply_lcmv->[_reg_pinv]] | Linearly Constrained Minimum Variance Iterator over the sequence of minimum - variance objects. | errant `*` at the end? |
@@ -1036,14 +1036,14 @@ int opt_check_rest_arg(const char *expected)
return 1;
opt_printf_stderr("%s: Missing argument: %s\n", prog, expected);
return 0;
- } else if (expected != NULL) {
- return 1;
}
+ if (expected != NULL)
+ return 1;
if (opt_unknown() == N... | [No CFG could be retrieved] | Return the most recent flag parameter and the rest of the arguments after parsing flags. Print the name of the node - free variable. | should we be testing this kind of thing? |
@@ -183,7 +183,7 @@ class ConanSymlink(ConanFile):
os.symlink(symlinked_path, symlink_path)
client.run("export . danimtb/testing")
ref = ConanFileReference("ConanSymlink", "3.0.0", "danimtb", "testing")
- export_sources = client.cache.export_sources(ref)
+ ex... | [SymLinksTest->[package_files_test->[_check],upload_test->[_check],basic_test->[_check],export_and_copy_test->[_check]]] | Test export pattern for conan. | `self._cache.export_sources(ref, short_paths=False)` vs `self._cache.package_layout(ref, short_paths=None).export_sources()` |
@@ -302,7 +302,7 @@ public class FormatterApi extends AbstractFormatService implements ApplicationLi
context.getBean(DataManager.class).increasePopularity(context, String.valueOf(metadata.getId()));
}
writeOutResponse(context, metadataUuid,
- LanguageUtils.local... | [FormatterApi->[isDevMode->[isDevMode],FormatMetadata->[call->[FormatMetadata,loadMetadataAndCreateFormatterAndParams]],copyNewerFilesToDataDir->[visitFile->[visitFile]],getPluginLocResources->[visitFile->[addTranslations,visitFile],getPluginLocResources],createServiceContext->[createServiceContext]]] | Gets a formatted metadata record. Private method to create a key object. This method is called when a user requests a parameter that has extra parameters beyond the standard parameters. | To check with a previous similar code that has been replaced by `isoLanguagesMapper.iso639_2T_to_iso639_2B` (also in the previous file `CatalogApi.java` and other files below) |
@@ -82,6 +82,13 @@ class MediaAdmin extends Admin
(new Route('sulu_media.overview', '/collections/:locale/:id?', 'sulu_media.overview'))
->addOption('locales', $mediaLocales)
->addAttributeDefault('locale', $mediaLocales[0]),
+ (new Route('sulu_media.detail', '/... | [MediaAdmin->[getRoutes->[getLocale,addAttributeDefault,getLocalizations],__construct->[addChild,setPosition,setNavigation,hasPermission,setAction,setIcon]]] | Returns routing array with missing routes. | That sounds strange I would go for `sulu_media.form.detail` (as e.g. in the SnippetBundle) and rename the ResourceTab route to `sulu_media.form`. |
@@ -20,6 +20,7 @@
#include <ctype.h>
static uint8_t input_mode;
+static bool first_flag = false;
uint8_t mods;
void set_unicode_input_mode(uint8_t os_target)
| [register_hex->[unregister_code,register_code,hex_to_keycode],send_unicode_hex_string->[unicode_input_finish,send_string,strcspn,tolower,unicode_input_start,strncpy],void->[wait_ms,unregister_code,register_code,MOD_BIT],set_unicode_input_mode->[eeprom_update_byte]] | set unicode input mode. | This can be made a static local variable inside `prepare_unicode_input_mode` since it isn't needed anywhere else. |
@@ -912,11 +912,11 @@ angular.module('zeppelinWebApp')
var chartEl = d3.select('#p'+$scope.paragraph.id+'_'+type+' svg')
.attr('height', $scope.paragraph.config.graph.height)
- .style('height', height + 'px')
.datum(d3g)
.transition()
.duration(animationDura... | [No CFG could be retrieved] | chart - > draw chart Displays a list of unknown columns in the graph. | This part was actually from a new commit, and should not be removed, my guess is that your branch is not up to date with master. |
@@ -64,7 +64,7 @@ func TestCacheKey(t *testing.T) {
}
func TestCacheKeyFields(t *testing.T) {
- keyJSON, err := cacheKey(kapi.NewContext(), &authorizer.DefaultAuthorizationAttributes{})
+ keyJSON, err := cacheKey(authorizer.AttributesRecord{User: &user.DefaultInfo{Name: "me"}})
if err != nil {
t.Fatalf("unexpe... | [Has,WithNamespace,Method,NumMethod,TypeOf,Unmarshal,NewContext,ToLower,Elem,TrimPrefix,Insert,Errorf,Fatalf,NewString,WithUser] | TestCacheKeyFields tests the cache key fields for the given context. Get the cache entry for the given attribute name. | why was the default user needed? |
@@ -27,7 +27,7 @@ class DependencyAwarePruner(Pruner):
"""
def __init__(self, model, config_list, optimizer=None, pruning_algorithm='level', dependency_aware=False,
- dummy_input=None, **algo_kwargs):
+ dummy_input=None, global_sort=False, **algo_kwargs):
super().__i... | [DependencyAwarePruner->[_dependency_update_mask->[_dependency_calc_mask],_dependency_calc_mask->[calc_mask],calc_mask->[calc_mask]]] | Initialize the object with a base configuration of a node. | Do all the dependency pruners support `global_sort` mode? If not, I'm a little concerned. |
@@ -255,7 +255,7 @@ func SetMachineImages(profile *gardenv1beta1.CloudProfile, images []gardenv1beta
return nil
}
-// SetMachineImages sets imageVersions to the matching imageName in the machineImages.
+// SetMachineImageVersionsToMachineImage sets imageVersions to the matching imageName in the machineImages.
fun... | [GetSecretKeysWithPrefix,Strings,TestEmail,Invalid,Error,CompareVersions,ParseBool,GreaterThan,New,ToLower,ToAggregate,Child,Errorf,NewVersion,ParseInt,CIDR,Split,SplitN] | SetMachineImages sets the machineImages to the matching imageVersions. cloud returns the number of non - nil elements in the array. | Why is this renamed as well? |
@@ -126,6 +126,7 @@ class CI_DB_oci8_forge extends CI_DB_forge {
$sqls[] = $sql.' RENAME COLUMN '.$this->db->escape_identifiers($field[$i]['name'])
.' '.$this->db->escape_identifiers($field[$i]['new_name']);
}
+ $field[$i] = $field[$i]['_literal'];
}
}
| [CI_DB_oci8_forge->[_alter_table->[escape_identifiers,_process_column]]] | Adds alter table statements to alter a single column of a given type. | There needs to be an empty line prior to this one. |
@@ -83,7 +83,6 @@ async def generate_targets_from_junit_tests(
union_membership,
# TODO: This should be set to False once dependency inference can infer same-package dependencies.
add_dependencies_on_all_siblings=True,
- use_source_field=True,
)
| [JavaSourcesGeneratorSourcesField->[tuple],rules->[collect_rules,UnionRule],generate_targets_from_java_sources->[Get,SourcesPathsRequest,generate_file_level_targets],generate_targets_from_junit_tests->[Get,SourcesPathsRequest,generate_file_level_targets]] | Generate targets from JUnit tests. | Now the default |
@@ -273,12 +273,14 @@ class EditPanel extends ActionPanel {
return;
}
final Set<TechAdvance> advance = new HashSet<>();
+ // FIXME: This try-catch block appears to be guarding against a ClassCastException.
+ // It should be removed and the underlying problem fixed.
tr... | [EditPanel->[setActive->[setWidgetActivation,actionPerformed],deselectUnits->[actionPerformed],actionPerformed->[setWidgetActivation,actionPerformed],mouseMoved->[getActive],unitsSelected->[setWidgetActivation,getActive],territorySelected->[actionPerformed],getActive]] | This method is called when the user clicks on a unknown key. | After a second review, I actually think the `ClassCastException` isn't possible. However, I need to research it further, so I added the FIXMEs to address in a follow-up PR. |
@@ -65,3 +65,7 @@ function isLongTaskApiSupported(win) {
'containerName' in win.TaskAttributionTiming.prototype
);
}
+
+if (isLongTaskApiSupported(self)) {
+ detectLongTasks(self);
+}
| [No CFG could be retrieved] | Check if the container name is defined in the task attribution timing. | Any reason this code needed to be moved? |
@@ -450,13 +450,13 @@ class ADDON_UNLISTED(_LOG):
keep = True
-class BETA_SIGNED_VALIDATION_PASSED(_LOG):
+class BETA_SIGNED(_LOG):
id = 131
format = _(u'{file} was signed.')
keep = True
-class BETA_SIGNED_VALIDATION_FAILED(_LOG):
+class BETA_SIGNED_VALIDATION_FAILED(_LOG): # Obsolete.
... | [USER_ENABLE->[_],REMOVE_RECOMMENDED->[_],OBJECT_ADDED->[_],DELETE_ADDON->[_],REQUEST_VERSION->[_],CREATE_ADDON->[_],DELETE_FILE_FROM_VERSION->[_],ADD_APPVERSION->[_],EDIT_CATEGORIES->[_],ADMIN_USER_ANONYMIZED->[_],PRELIMINARY_VERSION->[_],ADD_VERSION->[_],ADD_REVIEW->[_],REMOVE_RECOMMENDED_CATEGORY->[_],ADMIN_USER_EDI... | Displays a list of user - specific strings that can be anonymized. Returns a boolean indicating if a GUID has been deleted. | Can we link to this PR or the relevant ticket explaining why they're obsolete and also explaining why we can't remove them yet (because there are entries in the database...)? |
@@ -90,4 +90,7 @@ public class JmsConfig {
return producerConfig;
}
+ public String getDefaultEncoding() {
+ return muleContext.getConfiguration().getDefaultEncoding();
+ }
}
| [No CFG could be retrieved] | Gets the producer config. | why don't you use the encoding parameter you already defined above? |
@@ -21,7 +21,10 @@ $hwversion = $data['0']['genGroupHWVersion'];
if (! $hwversion) {
$hwversion = $data['1']['rlPhdUnitGenParamHardwareVersion'];
}
-if ($device['sysObjectID'] == '.1.3.6.1.4.1.9.6.1.89.26.1') {
+
+if (preg_match('/\.1\.3\.6\.1\.4\.1\.9\.6\.1\.72\.(....).+/', $device['sysObjectID'], $model)) {
+ ... | [No CFG could be retrieved] | 2015 - 2015 - Mike Rostermund Get the version of the Bootldr and Firmware. | `(....).+` is the same as `.{5,}` would `starts_with($device['sysObjectID'], '.1.3.6.1.4.1.9.6.1.72.')` be appropriate? |
@@ -93,9 +93,10 @@ namespace System.Diagnostics.Tests
}
public static bool Is_LongModuleFileNamesAreSupported_TestEnabled
- => PathFeatures.AreAllLongPathsAvailable() // we want to test long paths
+ => OperatingSystem.IsWindows() // it's specific to Windows
+ && Path... | [ProcessModuleTests->[ModulesAreDisposedWhenProcessIsDisposed->[Equal,nameof,Disposed,Dispose,Modules,CreateDefaultProcess,KillWait,IsSupported],ModuleCollectionSubClass_DefaultConstructor_Success->[Empty],Modules_Get_ContainsHostFileName->[HostRunnerName,Contains,modules,Modules],LongModuleFileNamesAreSupported->[Copy... | Checks if LongPath. dll is present in the binary folder and if it is present. | @JeremyKuhne do you perhaps know about any long path issues specific to x86? |
@@ -1,6 +1,7 @@
-from typing import List, Iterator
+from typing import List, Iterator, Dict, Tuple, Any
import json
from contextlib import contextmanager
+import numpy as np
from allennlp.common import Registrable
from allennlp.common.checks import ConfigurationError
| [Predictor->[_batch_json_to_instances->[_json_to_instance],capture_model_internals->[add_output]]] | A class to handle the AllenNLP model that handles JSON - > JSON predictions. Takes a single line of JSON and returns a dict of the n - ary values. | Just `import numpy`. |
@@ -91,7 +91,8 @@ func (r *TemplateFileSearcher) Search(terms ...string) (ComponentMatches, error)
Object()
if err != nil {
- return nil, err
+ glog.V(5).Infof("Error from template search: %v", err)
+ continue
}
if !isSingular {
| [Search->[Has,Templates,Object,RequireNamespace,Infof,NamespaceParam,Sprintf,Do,FilenameParam,NewBuilder,List,V,IsForbidden,Insert,IntoSingular,NewString,IsNotFound,Errorf]] | Search searches for template objects that match the given terms. | not aborting on an error seems like a mistake. or at least printing it as a warning. Doesn't this mean if the template file the user intended to use has a typo, you're going to silently skip over that file? |
@@ -22,11 +22,12 @@ public class AuthenticatedUser implements Principal {
throw new UnsupportedOperationException("Name lookup is not done on authentication.");
}
- public boolean isAdmin() {
- return userRole.equals(UserRole.ADMIN);
- }
-
- public boolean isModerator() {
- return userRole.equals(Use... | [AuthenticatedUser->[isModerator->[equals],isAdmin->[equals],getName->[UnsupportedOperationException]]] | Returns the name of the user. | Not really understanding this method. It throws an error if the user role is anonymous or if the user has a null user id? Also maybe I'm just not used to seeing it written this way but seems a bit strange to create an optional of an Integer to then just immediately check if its null? Couldn't you just directly check if... |
@@ -4,6 +4,8 @@ module RepositoryDatatableHelper
include InputSanitizeHelper
def prepare_row_columns(repository_rows, repository, columns_mappings, team, options = {})
+ assigned_rows = options[:my_module].repository_rows.where(repository: repository).pluck(:id) if options[:my_module]
+
repository_rows.... | [default_snapshot_table_order_as_js_array->[to_json],default_table_order_as_js_array->[to_json],default_table_columns->[to_json],assigned_row->[positive?,assigned_experiments_count,t,assigned_my_modules_count,assigned_projects_count],can_perform_repository_actions->[can_manage_repository_rows?,can_manage_repository?,ca... | Prepares the row columns for a given repository. | If you have 1_000_000 of assigned records? |
@@ -0,0 +1,12 @@
+<div class="pure-u-1 pure-u-md-1-3">
+ <%= link_to gobierto_participation_process_path(group.slug), class:"content_block light" do %>
+ <h3><%= group.title %></h3>
+ <p><%= group.body %></p>
+ <% if meta %>
+ <div class="meta right">
+ <div class="ib"><i class="fa fa-comment"></i... | [No CFG could be retrieved] | No Summary Found. | Can this be implemented? If not, we use a `<% pending do %> ... <% end %>` helper in the views to hide content temporarily. |
@@ -196,12 +196,14 @@ class ArchiveService(BaseService):
return
if updates.get('publish_schedule'):
+
if datetime.datetime.fromtimestamp(False).date() == updates.get('publish_schedule').date():
# publish_schedule field will be cleared
updates['publi... | [ArchiveService->[on_update->[update_word_count,on_update],on_deleted->[get_subject,on_deleted],duplicate_content->[duplicate_content],on_updated->[get_subject,on_updated],on_create->[update_word_count,on_create],on_created->[get_subject,on_created],on_replaced->[get_subject]]] | Updates an item in the system. Unlock a if it exists. | While already changing this file, I would refactor this `False`to `0`, since semantically timestamps are integers. |
@@ -213,6 +213,12 @@ Exception: WithDeps(Inner(InnerEntry { params: {TypeCheckFailWrapper}, rule: Tas
# `a_typecheck_fail_test` above expects `wrapper.inner` to be a `B`.
self.scheduler.product_request(A, [Params(TypeCheckFailWrapper(A()))])
+ def test_unhashable_failure(self):
+ """Test that unhash... | [transitive_b_c->[B],select_union_a->[a],UnionB->[a->[A]],transitive_coroutine_rule->[D],SchedulerTest->[test_union_rules->[_assert_execution_error,A,UnionB,UnionWrapper,UnionA],_assert_execution_error->[assert_execution_error],test_use_params->[consumes_a_and_b,A,B],test_transitive_params->[C,A,consumes_a_and_b,transi... | Test that Get objects are now type - checked during rule execution. | I would like for this message to check more specifically which object has the unhashable type, but I can't see how to do that easily, so this is definitely specific enough for now. |
@@ -237,6 +237,16 @@ public class Task implements Runnable {
LOG.error("Failed to close all open resources", t);
}
+ for (Map.Entry<Optional<Fork>, Optional<Future<?>>> forkAndFuture : this.forks.entrySet()) {
+ if (forkAndFuture.getKey().isPresent() && forkAndFuture.getValue().isPresent()... | [Task->[addConstructsFinalStateToTaskState->[toString],getBytesWritten->[getBytesWritten],updateRecordMetrics->[updateRecordMetrics],getRecordsWritten->[getRecordsWritten],updateByteMetrics->[updateByteMetrics]]] | This method is invoked when the task is starting. This method submits a new task and then checks if all of the records in the source This method checks if all forks of the task have succeeded and if so publishes the task. | Instead of canceling all forks if one fork fails, can you let all forks finish, record the failed forks and when retrying the task, only re-run the failed forks? |
@@ -2971,14 +2971,15 @@ class TypeAlias(SymbolNode):
within functions that can't be looked up from the symbol table)
"""
__slots__ = ('target', '_fullname', 'alias_tvars', 'no_args', 'normalized',
- 'line', 'column', '_is_recursive', 'eager')
+ 'line', 'column', '_is_r... | [ClassDef->[serialize->[serialize],is_generic->[is_generic],deserialize->[ClassDef,deserialize]],TypeAlias->[serialize->[serialize]],FuncDef->[serialize->[serialize],deserialize->[FuncDef]],Decorator->[serialize->[serialize],deserialize->[Decorator,deserialize]],TypeVarExpr->[serialize->[serialize],deserialize->[TypeVa... | Initialize a object. | You can try to make this just `Expression`. Similar constructs use `TempNode(type, no_rhs=True)`, when there's no `rvalue` |
@@ -125,6 +125,13 @@ async function main() {
const tickIntervalSeconds = 5
let start
+ /**
+ * Make sure we're using the block number from the latest retrieved event. This is set to false
+ * in the graphql contracts initialization that's being used here.
+ */
+ contractsContext.marketplace.eventCache.... | [No CFG could be retrieved] | The main function of the tracking loop. Retrieve all events for the relevant contracts. | Any reason we should not make this the default ? The DApp could probably benefit from not skipping events as well ? |
@@ -55,8 +55,8 @@ class PollingCommandTests(base.PulpClientTests):
sim.install(self.bindings)
task_id = '123'
- state_progression = [STATE_WAITING,
- STATE_WAITING,
+ state_progression = [None,
+ STATE_ACCEPTED,
... | [PollingCommandTests->[test_cancelled_task->[install,assertTrue,get_write_tags,poll,get_all_tasks,add_task_states,TaskSimulator,assertEqual,len,isinstance],test_poll_background->[add_task_state,poll,get_all_tasks,TaskSimulator,assertEqual],test_get_tasks_to_poll_nested_tasks->[_get_tasks_to_poll,add_task_state,get_all_... | Poll for a single task. | Are we dropping the use of STATE_WAITING for None? |
@@ -11,6 +11,11 @@ from mypy.options import Options
from mypy.version import __version__ as mypy_version
from mypy.errorcodes import ErrorCode
from mypy import errorcodes as codes
+from mypy.util import (
+ decode_python_encoding, DecodeError, trim_source_line, DEFAULT_SOURCE_OFFSET,
+ WIGGLY_LINE, DEFAULT_COL... | [Errors->[render_messages->[simplify_path],copy->[Errors],report->[import_context,current_module,ErrorInfo,current_target],current_target->[current_target],reset->[initialize],raise_error->[blocker_module],new_messages->[file_messages],generate_unused_ignore_errors->[import_context,current_module,ErrorInfo,_add_error_i... | The base error message object. Initialize a new object with the given parameters. | I think it would be nice if there was no import from `mypy.fscache` in this file, and instead we'd accept a callback that reads file contents, for example (dependency injection). We could probably also get rid of the `decode_python_encoding` and `DecodeError` imports. |
@@ -70,6 +70,8 @@ export class AmpAdApiHandler {
* @return {!Promise} awaiting load event for ad frame
*/
startUp(iframe, is3p, opt_defaultVisible) {
+ const perf = installPerformanceService(window);
+ perf.tick('ar');
user().assert(
!this.iframe, 'multiple invocations of startup without de... | [No CFG could be retrieved] | Initializes the object that will be used to initialize the ad frame. Triggers event on entity - id and iframe resize API. | We shouldn't be installing performance service here. Is there a way to ask it via `performanceFor`? |
@@ -118,6 +118,10 @@ class ParlaiParser(object):
agent = get_agent_module(model)
if hasattr(agent, 'add_cmdline_args'):
agent.add_cmdline_args(self)
+ if hasattr(agent, 'dictionary_class'):
+ self.parser.add_argument(
+ '-dict_class... | [ParlaiParser->[add_parlai_args->[add_parlai_data_path],print_args->[parse_args],parse_args->[parse_args]]] | Adds model specific arguments to the command line. | two hyphens at start, hyphen instead of underscore like we talked about before: `--dict-class` |
@@ -122,7 +122,7 @@ import static org.springframework.test.web.servlet.result.MockMvcResultMatchers.
*/
@RunWith(SpringRunner.class)
<%_ if (authenticationType === 'uaa' && applicationType !== 'uaa') { _%>
-@SpringBootTest(classes = {SecurityBeanOverrideConfiguration.class, <%= mainClass %>.class})
+@SpringBootTest... | [No CFG could be retrieved] | Tests the class. missing field validation - check for missing field validation - check for missing field validation - check for. | `} ` needs to be placed correctly |
@@ -5680,6 +5680,7 @@ ztest_fletcher(ztest_ds_t *zd, uint64_t id)
while (gethrtime() <= end) {
int run_count = 100;
void *buf;
+ struct abd *abd_data, *abd_meta;
uint32_t size;
int *ptr;
int i;
| [No CFG could be retrieved] | function to handle the creation of the n - ary object. Allocate memory for the n - ary object. | [cstyle] We don't want extra white space in the variable declarations. Please remove. |
@@ -221,6 +221,8 @@ def get_file(fname,
Returns:
Path to the downloaded file
"""
+ if origin is None:
+ raise ValueError("Missing origin")
if cache_dir is None:
cache_dir = os.path.join(os.path.expanduser('~'), '.keras')
if md5_hash is not None and file_hash is None:
| [urlretrieve->[chunk_read],get_file->[_extract_archive,urlretrieve],OrderedEnqueuer->[get->[get,is_running,stop],_run->[_wait_queue,_send_sequence,on_epoch_end],_get_executor_init->[pool_fn->[get_worker_id_queue,get_pool_class]]],next_sample->[next],ThreadsafeIter->[__next__->[next]],validate_file->[_hash_file],Sequenc... | Downloads a file from a URL if it not already in the cache. Download a file if it is not already present. This function is a wrapper around the base download function. It is used by the nginx. | "Please specify the `origin` argument (URL of the file to download)." |
@@ -162,7 +162,7 @@ public class PublishGCPubSub extends AbstractGCPubSubProcessor{
ApiFuture<String> messageIdFuture = publisher.publish(message);
- while (messageIdFuture.isDone()) {
+ while (!messageIdFuture.isDone()) {
Thread.sl... | [PublishGCPubSub->[onScheduled->[build,set,error],onTrigger->[copyFromUtf8,ByteArrayOutputStream,nanoTime,toString,publish,put,yield,getLocalizedMessage,putAllAttributes,exportTo,isEmpty,toMillis,transfer,error,getCause,sleep,asInteger,isDone,send,build,get,add],getSupportedPropertyDescriptors->[of],getRelationships->[... | Trigger a message with a sequence of messages. This method is called by the client when a message is received from the server. It will. | @zenfenan is there a reason to have this loop at all? The next line calls `messageIdFuture.get()`, which is a blocking call. So we should just remove this entire loop, as it's adding up to a half-second delay for each FlowFile. Or am I missing something? |
@@ -709,7 +709,7 @@ def test_trade_close(limit_buy_order_usdt, limit_sell_order_usdt, fee):
assert trade.close_date == new_date
-@pytest.mark.usefixtures("init_persistence")
+@ pytest.mark.usefixtures("init_persistence")
def test_calc_close_trade_price_exception(limit_buy_order_usdt, fee):
trade = Trade(... | [test_calc_close_trade_price_exception->[calc_close_trade_value,Trade,update],test_Trade_object_idem->[type,getattr,issubclass,vars,startswith],test_stoploss_reinitialization->[adjust_stop_loss,init_db,get_open_trades,len,stoploss_reinitialization,add,utcnow,Trade],test_update_limit_order->[round,update,utcnow,clear,lo... | This test is used to test the close trade price exception. | I'd not do that (and i'm not sure which stylesheet you've found this). It looks odd - and is pretty dangerous when trying to find things - as it derives from the general style we're using elsewhere for decorators. |
@@ -736,10 +736,6 @@ func (a *InternalAPIEngine) GetDecode(arg APIArg, v APIResponseWrapper) error {
return nil
}
- if err := a.refreshSession(m, arg, reqErr); err != nil {
- return err
- }
-
m.CDebugf("| API GetDecode %s session refreshed, trying again", arg.Endpoint)
reqErr = a.getDecode(m, arg, v)
| [GetText->[getCommon],PostRaw->[getURL],getDecode->[GetResp,GetAppStatus,checkAppStatus],Get->[getURL,PrepareGet,getCommon],GetHTML->[getCommon],Delete->[getURL,PrepareMethodWithBody],consumeHeaders->[updateCriticalClockSkewWarning],postCommon->[DoRequest,PrepareMethodWithBody],postDecode->[GetAppStatus,postResp,checkA... | GetDecode gets a resource from the server. | are these log messages about session refresh no longer accurate? |
@@ -58,6 +58,14 @@ class RegisterUserEmailForm
@allow && valid? && !email_taken?
end
+ def set_email_taken
+ email_address = EmailAddress.find_with_email(email)
+ email_owner = email_address&.user
+ return false if email_owner.blank?
+ return email_address.confirmed? if email_owner.confirmed?
+ ... | [RegisterUserEmailForm->[build_user_and_email_address_with_email->[email],email->[email]]] | check if the user has a service provider request id and if so add an error if it. | Can we call this `look_up_email_taken` or something? It doesn't have any side effects, so the `set_` is throwing me |
@@ -23,10 +23,7 @@ import java.io.PrintStream;
import java.io.ByteArrayOutputStream;
import java.util.*;
-import org.apache.zeppelin.interpreter.Interpreter;
-import org.apache.zeppelin.interpreter.InterpreterContext;
-import org.apache.zeppelin.interpreter.InterpreterPropertyBuilder;
-import org.apache.zeppelin.in... | [AlluxioInterpreter->[close->[close],splitAndRemoveEmpty->[splitAndRemoveEmpty],completion->[splitAndRemoveEmpty],interpret->[interpret]]] | Creates an Interpreter for the given node. All commands in the Alluxio master. | Would you like to keep import block unchanged here (and the in the other interpreters)? |
@@ -179,3 +179,11 @@ func (host *pluginHost) GetRequiredPlugins(info plugin.ProgInfo,
kinds plugin.Flags) ([]workspace.PluginInfo, error) {
return nil, nil
}
+
+func (host *pluginHost) PolicyAnalyzer(name tokens.QName, path string) (plugin.Analyzer, error) {
+ return nil, errors.New("unsupported")
+}
+
+func (host... | [LogStatus->[isClosed],SignalCancellation->[SignalCancellation],Log->[isClosed]] | GetRequiredPlugins returns a list of plugins that are required for the given plugin. | Nit: it would be nice to have some sort of implementation of this for testing purposes. |
@@ -64,7 +64,7 @@ var ngAriaModule = angular.module('ngAria', ['ng']).
/**
* Internal Utilities
*/
-var nodeBlackList = ['BUTTON', 'A', 'INPUT', 'TEXTAREA', 'SELECT', 'DETAILS', 'SUMMARY'];
+var builtInAriaNodeNames = ['BUTTON', 'A', 'INPUT', 'TEXTAREA', 'SELECT', 'DETAILS', 'SUMMARY'];
var isNodeOneOf = function... | [No CFG could be retrieved] | Provides a way to configure a specific element. Provides a function to configure the angular - Aria module. | NIT: I would call it `nativeAriaNodeNames` :-) |
@@ -474,6 +474,11 @@ INSTALLED_APPS = (
'landing',
'search',
'kuma.users',
+ 'allauth',
+ 'allauth.account',
+ 'allauth.socialaccount',
+ 'allauth.socialaccount.providers.persona',
+ 'allauth.socialaccount.providers.github',
'wiki',
'kuma.events',
| [get_user_url->[reverse],JINJA_CONFIG->[get_cache,MemcachedBytecodeCache,isinstance],lazy_langs->[dict,lower],lazy_language_deki_map->[dict],node,lazy,listdir,join,remove,abspath,dict,replace,%,append,dirname,sorted,tuple,items,path,_,basename,isdir,setup_loader,dumps,lower] | Creates a list of all password hasher objects. Create a list of all the possible content type objects. | Seems like we can avoid some risk here if we install, merge, and push only the `persona` provider first. |
@@ -184,11 +184,11 @@ func marshalInputAndDetermineSecret(v interface{},
destType reflect.Type,
await bool) (resource.PropertyValue, []Resource, bool, error) {
secret := false
+ var deps []Resource
for {
valueType := reflect.TypeOf(v)
// If this is an Input, make sure it is of the proper type and await ... | [IsObject,Index,ElementType,NewArchiveProperty,IsBool,PropertyKey,MapKeys,HasPrefix,NewNumberProperty,New,Len,IsComputed,Bool,ID,TypeOf,IsPath,CanSet,Implements,AssignableTo,SecretValue,IsURI,ConstructProvider,IsValid,IsNumber,Kind,ArchiveValue,Interface,URN,SetUint,IsNull,NewAssetProperty,MakeMap,Construct,TypeString,... | marshalInput marshals an input value and returns its raw serializable value along with any dependencies. Invite the if the input is an Output and await its value. | I assume we could benefit from some deeper testing of this `marshalInputAndDetermineSecret` function? |
@@ -427,6 +427,10 @@ void EventFactory::delay() {
return;
}
+ if (shutdownRequested()) {
+ return;
+ }
+
// Create a thread for each event publisher.
auto& ef = EventFactory::getInstance();
for (const auto& publisher : EventFactory::getInstance().event_pubs_) {
| [No CFG could be retrieved] | Creates a new event type - specific object. The publisher threads. | Could you combine this check and the check in `attachEvents` into a single check within `Initializer::start`? |
@@ -176,6 +176,9 @@ int ACE_TMAIN (int argc, ACE_TCHAR *argv[])
ACE_OS::sleep (1);
}
+ // Let reader acknowledge the data.
+ ACE_OS::sleep (3);
+
// ----------------------------------------------
// Now switch first reader/subscriber from A to B
// and it should be conne... | [No CFG could be retrieved] | This function is called from DDS when a new message arrives. It will wait for This method is called when the listener servant has received more messages than expected messages. | Is there another mechanism we could use here? |
@@ -741,6 +741,13 @@ export class ViewportBindingNatural_ {
this.win.addEventListener('scroll', () => this.scrollObservable_.fire());
this.win.addEventListener('resize', () => this.resizeObservable_.fire());
+ // Override a user-supplied `body{overflow}` to be always visible. This
+ // style is set in... | [No CFG could be retrieved] | Provides a class which can be used to create a new instance of a Natural viewport Updates the paddingTop of the document element. | Would be so much better if this was resolved with the body :) |
@@ -101,7 +101,7 @@ abstract class CommandWithUpgrade extends \WP_CLI_Command {
$slug = stripslashes( $args[0] );
- if ( '.zip' == substr( $slug, -4 ) ) {
+ if ( '.zip' == substr( $slug, strrpos($slug, '.'), 4 ) ) {
$file_upgrader = \WP_CLI\Utils\get_upgrader( $this->upgrader );
if ( $file_upgrader->... | [CommandWithUpgrade->[_list->[get_all_items],update_all->[get_item_list],install->[install,install_from_repo],status->[status_single],status_all->[get_all_items]]] | Installs a package from a repository. | What if the URL doesn't contain `.zip` at all? We need a more reliable check. Maybe a regex that checks if it's a valid plugin/theme slug, i.e. only contains dashes etc. |
@@ -3850,6 +3850,16 @@ class SwitchOrderLayer(LayerBase):
name, 'switch_order', 0, inputs=inputs, **xargs)
self.config.reshape_conf.height_axis.extend(reshape['height'])
self.config.reshape_conf.width_axis.extend(reshape['width'])
+ input_layer = self.get_input_layer(0)
+ if... | [MaxOut->[__init__->[add_keys]],ConcatenateLayer2->[__init__->[config_assert,calc_parameter_dims,calc_output_size,calc_bias_size,set_layer_size,calc_parameter_size,get_input_layer,gen_parameter_name,create_bias_parameter,create_input_parameter]],BlockExpand->[__init__->[add_keys]],parse_image3d->[get_img3d_size],MDLstm... | Initialize a switch order layer. | The input data for SwitchOrderLayer may be five dimensions (NCDHW). |
@@ -193,4 +193,7 @@ public class AttributeSet implements AttributeListener<Object> {
// TODO
}
+ public Collection<Attribute<?>> attributes() {
+ return attributes.values();
+ }
}
| [AttributeSet->[contains->[contains],equals->[equals],reset->[reset],protect->[protect,AttributeSet,read],attribute->[attribute],hashCode->[hashCode],toString->[toString],read->[attribute,read]]] | Called when an attribute has changed. | Probably out of the scope - but could we throw an `UnsupportedOperationException` here? It's better than todo :) |
@@ -266,13 +266,16 @@ frappe.views.TreeView = Class.extend({
v['is_root'] = false;
}
+ d.hide();
+ frappe.dom.freeze(__(`Creating ${me.doctype}`));
+
$.extend(args, v)
return frappe.call({
method: me.opts.add_tree_node || "frappe.desk.treeview.add_node",
args: args,
callback: funct... | [No CFG could be retrieved] | function to show the menu for new node Group node methods. | add unfreeze to `always` |
@@ -18,7 +18,15 @@ abstract class SiteNotificationFactory {
$note->access_id = ACCESS_PRIVATE;
$note->description = $message;
if ($object) {
- $note->setURL($object->getURL());
+ // TODO Add support for setting an URL for a notification about a new relationship
+ switch ($object->getType()) {
+ case '... | [SiteNotificationFactory->[create->[setRead,getURL,setActor,setURL,save]]] | Create a new site notification. | What if the object passed in doesn't have getType()? Should we whitelist types in #7066? |
@@ -329,10 +329,9 @@ public class MergeOnReadInputFormat
this.currentRecord = delete;
return true;
- } else {
- // delete record found, skipping
- return hasNext();
}
+ // skipping if the condition is unsatisfied
+ ... | [MergeOnReadInputFormat->[getLogFileIterator->[hasNext->[hasNext]],Builder->[build->[MergeOnReadInputFormat]],reachedEnd->[reachedEnd],LogFileOnlyIterator->[nextRecord->[next],reachedEnd->[hasNext]],nextRecord->[nextRecord],MergeIterator->[close->[close],reachedEnd->[hasNext,nextRecord,next,reachedEnd]],close->[close],... | Returns an iterator over the log files in the table. private boolean currentRecord = null ;. | Can we delete this directly? |
@@ -760,6 +760,12 @@ class Procedures():
except OSError:
pass
+ try:
+ file_to_remove = os.path.join(main_path, 'flux_data_new.hdf5')
+ os.remove(file_to_remove)
+ except OSError:
+ pass
+
@classmethod
def CreateDirectories(self, main_pa... | [MaterialTest->[MeasureForcesAndPressure->[MeasureForcesAndPressure],Initialize->[MaterialTest,Initialize],PrintChart->[PrintChart],FinalizeGraphs->[FinalizeGraphs],PrintGraph->[PrintGraph],GenerateGraphics->[GenerateGraphics],PrepareDataForGraph->[PrepareDataForGraph]],KratosPrintInfo->[Flush],KratosPrint->[Flush],Kra... | Remove folders with results. Get the post_path data_and_results graphs_path MPI_results. | @farrufat-cimne This file is produced by very specific runs and can be deleted by the specific cases. |
@@ -45,9 +45,11 @@ After your project is created it will be made your default project in your confi
$ %[1]s web-team-dev --display-name="Web Team Development" --description="Development project for the web team."`
)
-func NewCmdRequestProject(name, fullName, ocLoginName, ocProjectName string, f *clientcmd.Factory... | [Run->[Create,ProjectRequests,RunProject,List,Everything],complete->[Args,Help,New,Complete,NewPathOptions,Flags],StringVar,Sprintf,complete,CheckErr,Run,Clients,Flags] | NewCmdRequestProject creates a new command that requests a new project with minimal information. Complete completes the creation of a new project. | Where are you using `options.Name`? |
@@ -364,7 +364,11 @@ public final class AnnotationsBasedDescriber implements Describer
sourceDeclarers.put(sourceType, source);
declareMetadataKeyId(sourceType, source);
- declareSingleParameters(getParameterFields(sourceType), source, MuleExtensionAnnotationParser::parseMetadataAnnotations);... | [AnnotationsBasedDescriber->[declareConfigurationParametersGroups->[declareConfigurationParametersGroups],declareOperation->[checkOperationIsNotAnExtension],declareConnectionProvider->[declareAnnotatedParameters],getMetadataResolverFactoryFromMethod->[getMetadataResolverFactory],getMetadataResolverFactoryFromClass->[ge... | Adds a message source to the given declarer. | I don't think this is the correct place to do this. The declareSingleParameters method should know how to treat fields with this characteristics. Otherwise the feature is not self contained and you have bits and pieces of the solution scattered around |
@@ -1513,7 +1513,7 @@ namespace System.Xml
private void SetEmptyNode()
{
- Debug.Assert(_tmpNode.localName == string.Empty && _tmpNode.prefix == string.Empty && _tmpNode.name == string.Empty && _tmpNode.namespaceUri == string.Empty);
+ Debug.Assert(_tmpNode.localName.Length == ... | [XmlSubtreeReader->[ReadContentAsBoolean->[ReadContentAsBoolean],ReadContentAsFloat->[ReadContentAsFloat],ReadValueChunk->[ReadValueChunk,ReadElementContentAsBase64,ReadElementContentAsBinHex,ReadContentAsBase64,ReadContentAsBinHex],ReadContentAs->[ReadContentAs],MoveToFirstAttribute->[MoveToFirstAttribute],ReadContent... | SetEmptyNode - Set Empty node. | This should be reverted. A tiny perf difference doesn't matter in the context of an assert, and if one of these were to be null, we'd want to get the assert about the failure rather than a null ref. |
@@ -107,8 +107,7 @@ function reportErrorToServer(message, filename, line, col, error) {
if (this && this.document) {
makeBodyVisible(this.document);
}
- const mode = getMode();
- if (mode.localDev || mode.development || mode.test) {
+ if (getMode().localDev || getMode().development || getMode().test) {
... | [No CFG could be retrieved] | Provides a function to report errors to the server. Check if the error is reported or not. | @cramforce PTAL. works but unfortunately I don't detect re-aliasing right now, is there a way to get the type information of a return type? (I'm sure there is I just don't know how to get to it) |
@@ -385,7 +385,7 @@ final class OpenJ9VirtualMachine extends VirtualMachine implements Response {
targetServer = new ServerSocket(0); /* select a free port */
portNumber = Integer.valueOf(targetServer.getLocalPort());
- String key = Integer.toHexString((IPC.getRandomNumber()));
+ String key = IPC.getR... | [OpenJ9VirtualMachine->[equals->[equals],startLocalManagementAgent->[parseResponse],tryAttachTarget->[lockAllAttachNotificationSyncFiles],hashCode->[hashCode],loadAgentLibrary->[createLoadAgentLibrary],loadAgentPath->[createLoadAgentLibrary],toString->[hashCode],startManagementAgent->[parseResponse],loadAgent->[createL... | try to attach to a target. This function is called by the attach API when it is ready to attach to a VM. This method is called when the attach target is successfully attached to the VM. | Is `IPC.getRandomNumber()` used anymore? Can it be deleted? |
@@ -24,12 +24,6 @@ import java.time.Duration;
import org.ehcache.config.builders.*;
import org.ehcache.jsr107.Eh107Configuration;
- <%_ if (enableHibernateCache) { _%>
-import org.hibernate.cache.jcache.ConfigSettings;
- <%_ } _%>
-import io.github.jhipster.config.JHipsterProperties;
-
-<%_ } _%>
<%_ if (cac... | [No CFG could be retrieved] | Imports an object from the JHipster project. Imports all the required packages for JHipster. | From what I understand this block is part of the conditional block `if (cacheProvider === 'ehcache')`, and the other is part of the conditional block `if (cacheProvider === 'caffeine')`, so the imports wont be duplicated and if you use ehcache as cache provider, these imports will be missing. |
@@ -127,3 +127,17 @@ func TestInitRegexp(t *testing.T) {
_, err := InitRegexps([]string{"((((("})
assert.NotNil(t, err)
}
+
+// readLine reads a full line into buffer and returns it.
+// In case of partial lines, readLine does return and error and en empty string
+// This could potentialy be improved / replaced by... | [newLogFileReader,False,Close,Itoa,Int,NotNil,Nil,Create,encodingFactory,Equal,Remove,NoError,Fatalf,Printf,Sync,FindEncoding,Open,Abs,WriteString,True] | t = t = t = t = t = t = t = t = t =. | @ruflin I just noticed that are two mistakes in here "does return an error and an empty string". |
@@ -1,7 +1,7 @@
'use strict';
angular.module('<%=angularAppName%>')
- .controller('<%= entityClass %>ManagementController', function ($scope, $state<% if (fieldsContainBlob) { %>, DataUtils<% } %>, <%= entityClass %><% if (searchEngine == 'elasticsearch') { %>, <%= entityClass %>Search<% } %><% if (pagination !=... | [No CFG could be retrieved] | NgModule angular - module - management - controller. | Where is pagingparam and alerservice used? If not plz remove the injects |
@@ -355,4 +355,13 @@ class AccessControlManager implements AccessControlManagerInterface
}
}
}
+
+ private function getChildrenProviders(string $type): ?DescendantProviderInterface
+ {
+ foreach ($this->descendantProviders as $descendantProvider) {
+ if ($descendantPro... | [AccessControlManager->[getUserObjectPermission->[getPermissions],cumulatePermissions->[mapPermissions],getPermissions->[getPermissions],getRoleSecurityContextPermissions->[getPermissions],setPermissions->[setPermissions],restrictPermissions->[mapPermissions]]] | Returns the AccessControlProvider that supports the given type. | `getChildrenProvider` (only returns a single one, right?) |
@@ -477,10 +477,13 @@ func bytesToHex(data []byte) string {
return utils.AddHexPrefix(hex.EncodeToString(data))
}
-func jobIDFromHexEncodedTopic(log Log) string {
- return string(log.Topics[RequestLogTopicJobID].Bytes())
+// IDToTopic encodes the bytes representation of the ID padded to fit into a
+// bytes32
+fun... | [RunRequest->[Requester],ToDebug->[ForLogger],Validate->[ForLogger]] | jobIDFromHexEncodedTopic returns the job ID of the request log topic. | Suggestion: To help with discoverability, can we make this a method on `models.ID`, called `Topic()`, akin to `String()`? If not, perhaps have the method take `[]byte` instead of `id *ID`. |
@@ -168,6 +168,13 @@ export default class LargeVideoManager {
get id() {
const container = this.getCurrentContainer();
+ // If a user switch for large video is in progress then provide what
+ // wil be the end result of the update.
+ if (this.updateInProcess
+ && this.new... | [No CFG could be retrieved] | Adds hover events to the video. Updates the state of the . | typo: wil -> will ? |
@@ -135,10 +135,17 @@ def test_io_set_raw(fnames, tmpdir):
ch_names = ['F3', 'unknown', 'FPz']
x, y, z = [1., 2., np.nan], [4., 5., np.nan], [7., 8., np.nan]
dt = [('labels', 'S10'), ('X', 'f8'), ('Y', 'f8'), ('Z', 'f8')]
+ nopos_dt = [('labels', 'S10'), ('Z', 'f8')]
chanlocs = np.zeros((3,), dty... | [test_io_set_raw->[filter,savemat,copyfile,join,loadmat,enumerate,warns,assert_array_almost_equal,assert_equal,replace,LooseVersion,_test_raw_reader,range,zeros,SkipTest,assert_array_equal,len,zip,deepcopy,read_raw_eeglab,random,str,raises,array],test_eeglab_read_annotations->[assert_array_almost_equal,read_annotations... | Test that the raw EEGLAB. set file is a valid EEGLAB read eeglab file and check if there is a negative event in the data. read eeglab file with 3 channels and create channel locations structured array with channel positions and test reading EEG. | And these are the lines that fixed the obscure savemat bug |
@@ -93,7 +93,7 @@ public abstract class AbstractProcessingStrategyTestCase extends AbstractReactiv
cpuLight = new TestScheduler(3, CPU_LIGHT);
blocking = new TestScheduler(3, IO);
cpuIntensive = new TestScheduler(3, CPU_INTENSIVE);
- asyncExecutor = newSingleThreadExecutor();
+ asyncExecutor = newC... | [AbstractProcessingStrategyTestCase->[ThreadTrackingProcessor->[process->[getName]],TestScheduler->[submit->[submit]]]] | Initialize the scheduler. | why not use a Scheduler for this? |
@@ -0,0 +1,9 @@
+module DataUpdateScripts
+ class ResaveUsersForImgproxyUpdate
+ def run
+ return if SiteConfig.dev_to?
+
+ User.find_each(&:save)
+ end
+ end
+end
| [No CFG could be retrieved] | No Summary Found. | Are we not worried about it for DEV or do we have a different process for it due to scale? |
@@ -270,7 +270,12 @@ class SaleUpdateMinimalVariantPriceMixin:
def success_response(cls, instance):
# Update the "minimal_variant_prices" of the associated, discounted
# products (including collections and categories).
- update_products_minimal_variant_prices_of_discount_task.delay(instanc... | [VoucherBaseCatalogueMutation->[Arguments->[CatalogueInput]],VoucherCreate->[Arguments->[VoucherInput]],SaleBaseCatalogueMutation->[Arguments->[CatalogueInput]],SaleCreate->[Arguments->[SaleInput]],SaleAddCatalogues->[perform_mutation->[SaleAddCatalogues,add_catalogues_to_node]],VoucherRemoveCatalogues->[perform_mutati... | Update the minimal_variant_prices of the associated discounted products. | Why not `instance.products.exists()`? I think it should be much faster. Also, why not moving this entire check to `update_products_minimal_variant_prices_of_discount_task`? Then we would be sure that it is checked in every case that you actually use this task. |
@@ -503,9 +503,13 @@ final class DocumentationNormalizer implements NormalizerInterface
*/
private function computeDoc(Documentation $documentation, \ArrayObject $definitions, \ArrayObject $paths) : array
{
+ /** @var Symfony\Component\Routing\RequestContext $requestContext */
+ $requestCo... | [DocumentationNormalizer->[getDefinitionSchema->[normalize],getFiltersParameters->[getType],getType->[getType]]] | Computes the documentation. | This works, but is wrong as `UrlGenerator` doesn't have `getContext()`. What would be a better way to do it? /cc @dunglas |
@@ -211,4 +211,8 @@ def test_ratelimit_429(client, db):
assert response.status_code == 429
assert '429.html' in [t.name for t in response.templates]
assert response['Retry-After'] == '60'
- assert response['Cache-Control'] == 'no-cache, no-store, must-revalidate'
+ assert 'Cache-Control' in respons... | [test_sitemaps->[sitemaps],test_sitemap->[sitemaps]] | Custom 429 view is used for Ratelimited exception. | Nit: if ``Cache-Control`` isn't in the response, then the next assertion will fail with a ``KeyError``, so it isn't required to test separately, and a line can be removed. |
@@ -60,6 +60,7 @@ type ConfigReader interface {
GasUpdaterBlockDelay() uint16
GasUpdaterBlockHistorySize() uint16
GasUpdaterTransactionPercentile() uint16
+ InsecureSkipVerify() bool
JSONConsole() bool
KeyFile() string
LinkContractAddress() string
| [No CFG could be retrieved] | DefaultMaxHTTPAttempts is the default number of HTTP attempts that can be made to a specific Returns the path to the host and key files for the given node. | If it's only used in the client does it make sense to put it in the main config struct? Perhaps reading directly from ENV might be better, wdyt? |
@@ -383,7 +383,7 @@ def _read_video(filename, start_pts=0, end_pts=None, pts_unit='pts'):
audio_timebase = info['audio_timebase']
audio_pts_range = get_pts(audio_timebase)
- return _read_video_from_file(
+ vframes, aframes, info = _read_video_from_file(
filename,
read_video_s... | [_read_video_timestamps_from_memory->[_fill_info],_read_video_timestamps_from_file->[_fill_info],_probe_video_from_memory->[_fill_info],_read_video_from_file->[_validate_pts,_fill_info,_align_audio_frames],_read_video_timestamps->[_read_video_timestamps_from_file],_read_video_from_memory->[_validate_pts,_fill_info,_ali... | Read a video file and return a video object. | It seems a few arguments of `_read_video_from_file `, such as `video_width`, `video_height`, `video_min_dimension`, are not used here, and can not be specified in API `_read_video`. Video frame resizing is fast if done inside of video reader. I would like to keep those argument exposed. However, `pyav` backends does no... |
@@ -361,7 +361,7 @@ class SubversionRepositoryTest < ActiveSupport::TestCase
files_to_add.each do |file_name|
assert_not_nil revision.files_at_path('/')[file_name].last_modified_date
- assert (revision.files_at_path('/')[file_name].last_modified_date - Time.now) < 1
+ assert (revision.fi... | [SubversionRepositoryTest->[add_file_helper->[add,commit,read,get_transaction],add_some_files_helper->[read,get_transaction,add,each,commit],create,closed?,new,revision_identifier,set_bulk_permissions,shift,last_modified_date,assert_raises,cp,join,remove,remove_dir,mkdir_p,assert_raise,should,expand_path,add_file_helpe... | should be able to add remove using a single transaction add one more file to the repository and collect a timestamp for later use. | Lint/ParenthesesAsGroupedExpression: (...) interpreted as grouped expression. |
@@ -521,17 +521,7 @@ export class Visibility {
? Date.now() - perf.timing.domInteractive
: '';
- // Calculate the amount element visible at the time page was loaded. To do
- // this, assume that the page is scrolled all the way to top.
- const viewportRect = {top: 0, height: rb.height, left... | [No CFG could be retrieved] | Creates the state object for the callback. Replies the state that need not be public and call callback. | When we set it above, is there any harm in setting it to false if it's `>= 300` since load time? Ie: ```js if (visible > 0) { // ... // Consider it as load time visibility if this happens within 300ms of // page load. if (state[LOAD_TIME_VISIBILITY] == undefined) { state[LOAD_TIME_VISIBILITY] = timeElapsed < 300 ? visi... |
@@ -31,6 +31,7 @@ import (
"github.com/gardener/gardener/pkg/resourcemanager/controller/garbagecollector/references"
appsv1 "k8s.io/api/apps/v1"
autoscalingv1 "k8s.io/api/autoscaling/v1"
+ batchv1 "k8s.io/api/batch/v1"
coordinationv1 "k8s.io/api/coordination/v1"
corev1 "k8s.io/api/core/v1"
rbacv1 "k8s.io/ap... | [Deploy->[MakeUnique,AddAllAndSerialize,Must,CreateForSeed,InjectAnnotations,Int32,String,NewRegistry,MustParse],WaitCleanup->[WithTimeout,WaitUntilDeleted],Wait->[WithTimeout,WaitUntilHealthy],Destroy->[ConfirmDeletion,IsNoMatchError,List,DeleteForSeed,Errorf,IsNotFound,IgnoreNotFound]] | MISSING - INHERITANCE - INHERITANCE API meta - information. | Should not we add package for cronjobs? I see, it's used later for clusterroles: `batchv1beta1 "k8s.io/api/batch/v1beta1"` |
@@ -0,0 +1,7 @@
+module Badges
+ class AwardEightWeekStreak
+ def self.call
+ ::Badges::AwardStreak.call(8)
+ end
+ end
+end
| [No CFG could be retrieved] | No Summary Found. | this is why I prefer keyword arguments, I know `8` can be understood by the name of the class itself, but doesn't `weeks: 8` look much better? |
@@ -2672,7 +2672,10 @@ LABEL1:
{
JavascriptFunction* exceptionFunction = unhandledExceptionObject->GetFunction();
// This is for getcaller in window.onError. The behavior is different in different browsers
- if (exceptionFunction && scriptContext == exceptio... | [No CFG could be retrieved] | Determines if a property can be assigned to a type. Checks if caller is global or eval. If it s eval return null. | Can we assign the value to null on top of this function. GetCallerProperty is called from GetPropertyBuiltIns which is used in JavascriptFunction::GetProperty without checking the return value. |
@@ -47,6 +47,10 @@ public class JobExecutionEngine {
private final JobTriggerUpdates.Factory jobTriggerUpdatesFactory;
private final Map<String, Job.Factory> jobFactory;
private final JobWorkerPool workerPool;
+ private final MetricRegistry metricRegistry;
+ private Counter execution_successful;
+ ... | [JobExecutionEngine->[execute->[execute,cleanup],handleTrigger->[create],executeJob->[execute,create]]] | Creates a new JobExecutionEngine. This method should only be called once. | Can we use camel-case for these as well, please? :smiley: |
@@ -500,6 +500,8 @@ namespace ProtoCore.Lang
throw new ProtoCore.Exceptions.CompilerInternalException("Unknown built-in method. {AAFAE85A-2AEB-4E8C-90D1-BCC83F27C852}");
}
+ GCUtils.GCRetain(ret, core);
+
// Dot operator is a special case and its arguments are... | [StackValueComparerForDouble->[Compare->[Equals],Equals->[Equals]],RangeExpressionUntils->[StackValue->[GenerateRangeByStepNumber,GenerateRangeByAmount,GenerateRangeByStepSize]],FileIOBuiltIns->[StackValue->[ConvertToString]],ArrayUtilsForBuiltIns->[CountTrue->[CountTrue],IsUniformDepth->[Rank],Exists->[Exists],SomeFal... | Execute the method. Method that returns a sequence of values that can be used to construct a MethodID. Method that returns the value of the missing parameter in the array. Remove method. MethodID. kSortWithMode sortIndexByValue reorder insert double and uniform depth. | Ok so i assume the return value was prematurely GC'd in the release here. In which case, yes i think this looks right to retain the ret value before the parameter release |
@@ -186,7 +186,14 @@ class Modal extends React.Component<ModalPropsT, ModalStateT> {
};
getSharedProps(): $Diff<SharedStylePropsArgT, {children?: React.Node}> {
- const {animate, isOpen, size, role, closeable} = this.props;
+ const {
+ animate,
+ isOpen,
+ size,
+ role,
+ closeabl... | [No CFG could be retrieved] | Callback when the component is opened. Get the children of a component. | Do you mind adding a dev warning in `componentDidMount` saying that this will be removed? Hard to find that information without reading the `types.js` file |
@@ -131,8 +131,7 @@ class Worker:
return result
def _process_stopped(self) -> None:
- # Maybe do here something in the future...
- pass
+ self.freqtrade.process_stopped()
def _process_running(self) -> None:
try:
| [Worker->[_process_running->[exception,sleep,process,notify_status,format_exc,warning],_throttle->[time,debug,max,sleep,func],run->[_reconfigure,_worker],_reconfigure->[cleanup,debug,notify,notify_status,_init],exit->[cleanup,notify,debug,notify_status],_worker->[time,debug,notify,notify_status,getpid,_throttle,startup... | Process stopped node. | This will call `cancel_all_open_orders()` at every throttling iteration in the STOPPED state, I do not think it's the intended behavior... This can be fixed/improved either by a flag here or in the Freqtradebot class, or better by introducing the new STOPPING state, which will transit the state from RUNNING to STOPPED.... |
@@ -155,7 +155,7 @@ func (f *GardenletControllerFactory) Run(ctx context.Context) error {
var (
controllerInstallationController = controllerinstallationcontroller.NewController(f.clientMap, f.k8sGardenCoreInformers, f.cfg, f.recorder, gardenNamespace, f.gardenClusterIdentity)
seedController =... | [Run->[NewSeedController,NewBackupBucketController,ReadGlobalImageVectorWithEnvOverride,Shoots,ControllerInstallations,NewShootController,NewFederatedSeedController,RegisterControllerMetrics,Done,Projects,Secrets,Lister,BackupBuckets,Start,Errorf,Key,Informer,Join,APIReader,NewController,Infof,ReadComponentOverwriteFil... | Run starts the controller and waits for all the resources to be ready. This function is called when the cache is ready to be used. Initialize the controller This function is responsible for running all the necessary gardenlets. | Here we still use the statically fetched garden secrets, mainly for the monitoring configuration IISIC. Are there plans to also dynamically fetch those or is this not needed? |
@@ -40,6 +40,11 @@ public class QCOW2Processor extends AdapterBase implements Processor {
private StorageLayer _storage;
+ @Override
+ public FormatInfo process(String templatePath, ImageFormat format, String templateName, long processTimeout) throws InternalErrorException {
+ return process(templateP... | [QCOW2Processor->[process->[getTemplateVirtualSize,InternalErrorException,debug,FormatInfo,error,getName,getFileExtension,exists,getFile,getSize],getTemplateVirtualSize->[FileInputStream,skip,read,IOException,bytesToLong],getVirtualSize->[info,getLocalizedMessage,getTemplateVirtualSize,length],configure->[get,Configura... | Process a QCOW2 file. | this is not right. it closes the door for implementing this for KVM (and other below) If this is really not applicable for any format but the VMware/OVA bit it should not be on the generic interface. If we do expect future implementation teh call hierarchy must be reversed: the specific version calling the more generic... |
@@ -65,10 +65,17 @@ public class DataSourceComponent extends DefaultComponent {
@Override
public void activate(ComponentContext context) {
instance = this;
+ datasources = new HashMap<>();
+ links = new HashMap<>();
}
- public void deactivate() {
+ @Override
+ public voi... | [DataSourceComponent->[bindDataSourceLink->[info,bindSelf,error],bindDataSource->[info,bindSelf,error,getName],applicationStopped->[unbindDataSource,values,unbindDataSourceLink],unbindDataSource->[info,unbindSelf,error],unregisterContribution->[removeDataSourceLink,removeContribution,removeDataSource],registerContribut... | Activate the extension point. | I would say no, if we correctly register/unregister contribution to registries, we don't need to re-init them |
@@ -19,7 +19,7 @@ class GithubIssue < ApplicationRecord
def self.try_to_get_issue(url)
client = Octokit::Client.new(access_token: random_token)
issue = GithubIssue.new(url: url)
- if !!(url !~ /\/issues\/comments/)
+ if url.match?(/re/)
repo, issue_id = url.gsub(/.*github\.com\/repos\//, "").s... | [GithubIssue->[fetch->[raise,try_to_get_issue,include?,message],get_issue_serialized->[to_hash],find_or_fetch->[fetch,find_by_url],get_html->[issue_serialized,markdown],random_token->[test?,token],try_to_get_issue->[to_hash,get_issue_serialized,split,new,processed_html,save!,get_html,issue_serialized,issue_or_pull,cate... | Try to get issue by url. | Not sure how the regexp turned `/re/`. I would consider adding specs for different cases before modifying this code. For this pull request, I suggest reverting and adding an exception in the config or for the block of code. |
@@ -9,6 +9,7 @@ internal static partial class Interop
public const string Comctl32 = "comctl32.dll";
public const string Comdlg32 = "comdlg32.dll";
public const string Gdi32 = "gdi32.dll";
+ public const string Hhctrl = "hhctrl.ocx";
public const string Imm32 = "imm32.dll";
... | [No CFG could be retrieved] | Replies the name of a specific package. | Should this be removed from ExternDll.cs now? |
@@ -4106,6 +4106,9 @@ ROM_END
* Game Drivers *
*************************/
+
+
+
#define MACHINE_FLAGS MACHINE_NOT_WORKING|MACHINE_IMPERFECT_SOUND|MACHINE_IMPERFECT_GRAPHICS
// YEAR NAME PARENT MACHINE INPUT STATE INIT ROT COMPANY FULLNAME ... | [No CFG could be retrieved] | region region of the ARM code Find all possible layout games for ARI - S - MK5. | Please refrain from adding silly amounts of successive empty lines like this. |
@@ -884,7 +884,10 @@ class ICA(ContainsMixin):
# some magic we need inevitably ...
if inst.ch_names != self.ch_names:
- inst = inst.pick_channels(self.ch_names, copy=True)
+ extra_picks = pick_types(inst.info, meg=False, eog=True, ecg=True)
+ ch_names_to_pick = (self... | [run_ica->[fit,ICA,_detect_artifacts],ICA->[_fit->[fit],_sources_as_evoked->[_transform_evoked],_apply_epochs->[_pre_whiten],_transform_raw->[_pre_whiten,_transform],_fit_epochs->[_reset],_transform_epochs->[_pre_whiten,_transform],find_bads_ecg->[get_sources,score_sources],_fit_raw->[_reset],find_bads_eog->[_check_tar... | This method is used to detect ECG related components using a cross - channel averaging. Missing components of a base - block or neuromagnetic recordings. Return the indices of the non - zero non - zero non - zero non - zero non. | why also EOG? |
@@ -36,6 +36,14 @@ import io.quarkus.creator.phase.nativeimage.NativeImageOutcome;
import io.quarkus.creator.phase.nativeimage.NativeImagePhase;
import io.quarkus.creator.phase.runnerjar.RunnerJarOutcome;
+/**
+ * Build a native executable of your application.
+ * It improves the startup time of the application, an... | [NativeImageMojo->[execute->[MojoFailureException,build,MojoExecutionException,resolveOutcome,isDirectory]]] | This class is a base class for all native images. This is a private method that can be used to report errors when a missing or invalid sequence. | I think you should just keep `Build a native executable of your application.`. The rest is too verbose and is not really useful IMHO. |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.