patch
stringlengths
18
160k
callgraph
stringlengths
4
179k
summary
stringlengths
4
947
msg
stringlengths
6
3.42k
@@ -71,7 +71,13 @@ export class BaseCarousel extends AMP.BaseElement { this.prevButton_.setAttribute('role', 'button'); // TODO(erwinm): Does label need i18n support in the future? or provide // a way to be overridden. - this.prevButton_.setAttribute('aria-label', 'Previous item in carousel'); + if...
[No CFG could be retrieved]
Initializes the carousel. Adds the next button to the Carousel.
remove the `// TODO` above since it is done
@@ -1062,12 +1062,9 @@ public class DefaultExecutorService extends AbstractExecutorService implements D @Override public NotifyingFuture<V> attachListener(final FutureListener<V> listener) { - future.attachListener(new FutureListener<Object>() { - @Override - public v...
[DefaultExecutorService->[RunnableAdapter->[call->[run]],getAddress->[getAddress],execute->[doLocalInvoke->[],execute],realShutdown->[shutdown],DistributedTaskPart->[computeTimeoutNanos->[timeout],innerGet->[maxFailoverAttempts,isCancelled],equals->[getOuterType,equals],failoverExecution->[executionFailureLocation->[ge...
Attach a listener to the task part.
Seems this if else block here can just be replaced by `listener.futureDone(this);`
@@ -119,6 +119,8 @@ class TaskStatusManager(object): * traceback * start_time * finish_time + * error + * spawned_tasks Other fields found in delta will be ignored. :param task_id: identity of the task this status corresponds to
[TaskStatusManager->[set_task_failed->[now_utc_timestamp,update_task_status],update_task_status->[items,MissingResource,get_collection],set_task_succeeded->[now_utc_timestamp,update_task_status],find_by_task_id->[get_collection],find_all->[get_collection],find_by_criteria->[get_collection],create_task_status->[append,D...
Updates the status of the task with the given task id.
Did you add _error_ and _spawned_tasks_ to the TaskStatus DB model object. Hard to find in the PR.
@@ -323,6 +323,12 @@ def run_app( ) sys.exit(1) + services_deployment_data = get_contracts_deployed( + chain_id=node_network_id, + version=contracts_version, + services=True, + ) + services_contracts = services_deployment_data['contracts'...
[_setup_udp->[handle_contract_wrong_address,handle_contract_version_mismatch,handle_contract_no_code],run_app->[handle_contract_wrong_address,_setup_udp,_setup_web3,handle_contract_no_code,_assert_sql_version,handle_contract_version_mismatch,_setup_matrix]]
Run the application with the given configuration. Configure the network and network id for the node. Raiden requires private room configuration and contracts. Check if a node is not in the network and if so add it to the network.
AFAIK, this will fail if you run raiden in production-mode. I might be mistaken though
@@ -374,6 +374,9 @@ void disable_all_steppers() { DISABLE_AXIS_X(); DISABLE_AXIS_Y(); DISABLE_AXIS_Z(); + #if ENABLED(SOFTWARE_DRIVER_ENABLE) + planner.axis_enabled = {false}; + #endif disable_e_steppers(); }
[No CFG could be retrieved]
This is a private method that can be called from the main thread. The main entry point for the event probe.
You can probably condense all of these using the `TERN` macros which are used throughout Marlin. There are a few variations of the `TERN` macros. I believe this is the version you will want to use. `TERN_(SOFTWARE_DRIVER_ENABLE, planner.axis_enabled.set(false, false, false));` I believe this will work, although you _mi...
@@ -320,7 +320,7 @@ func (p *PodmanTestIntegration) createArtifact(image string) { } dest := strings.Split(image, "/") destName := fmt.Sprintf("/tmp/%s.tar", strings.Replace(strings.Join(strings.Split(dest[len(dest)-1], "/"), ""), ":", "-", -1)) - fmt.Printf("Caching %s at %s...", image, destName) + fmt.Printf("C...
[RunTopContainerInPod->[RunTopContainerWithArgs],CleanupVolume->[Cleanup],RestoreArtifactToCache]
createArtifact creates a new artifact from the given image.
This is immediately followed by a verbose `podman pull`, which spits out `Running: etc` on the same line. My logformatter does not see this command and does not perform its helpful highlights.
@@ -184,7 +184,9 @@ class ParticipantView extends Component<Props> { _renderVideo: renderVideo, _videoTrack: videoTrack, onPress, - tintStyle + tintStyle, + disableVideo, + _isFakeParticipant } = this.props; // If the...
[No CFG could be retrieved]
Renders the connection info component. A component that renders the video if the video has not already been rendered.
please sort these alphabetically, with the stuff beginning with an underscore going first
@@ -110,7 +110,12 @@ namespace DynamoCoreWpfTests "FFITarget.FFITarget.SecondNamespace.ClassWithNameConflict.PropertyD", "FFITarget.FFITarget.SecondNamespace.ClassWithNameConflict.PropertyE", "FFITarget.FFITarget.SecondNamespace.ClassWithNameConflict.PropertyF", - ...
[NodeAutoCompleteSearchTests->[Open->[Open],Run->[Run],NodeSuggestions_InputPortZeroTouchNode_AreCorrect->[Open],NodeSuggestions_InputPortBuiltInNode_AreCorrect->[Open]]]
This method checks if the input port is built - in and if so the node view is FFITarget. FFITarget. SecondNamespace. ClassWithNameConflict. PropertyE and.
these additional methods now match because they return `string[]`
@@ -37,8 +37,8 @@ namespace NServiceBus return; } - builder.Build<IStartableBus>() - .Dispose(); + builder.Build<IStoppableEndpoint>() + .StopAsync().GetAwaiter().GetResult(); } /// <summary>
[CriticalError->[Raise->[DefaultCriticalErrorHandling]]]
DefaultCriticalErrorHandling - Default critical error handling.
I still hate this code. Can we come up with a better way to shutdown? This is too much magic and reliable on the correct binding/scope of the bus.
@@ -2,6 +2,4 @@ # Copyright (c) Microsoft Corporation. # Licensed under the MIT License. # ------------------------------------ -from .key_vault_client import KeyVaultClient - -__all__ = ["KeyVaultClient"] +__all__ = []
[No CFG could be retrieved]
-------------- Get a list of all key - vault objects in the system.
Let me know whether I'm wrong, but I think we don't need this file anymore because we no longer import directly from `_generated`.
@@ -332,12 +332,12 @@ public abstract class AbstractByteBuf extends ByteBuf { @Override public ByteBuf order(ByteOrder endianness) { - if (endianness == null) { - throw new NullPointerException("endianness"); - } if (endianness == order()) { return this; ...
[AbstractByteBuf->[resetWriterIndex->[writerIndex],setIndex->[checkIndexBounds],resetReaderIndex->[readerIndex],writeShortLE->[ensureWritable0,_setShortLE],writeZero->[ensureWritable,_setLong,_setByte,_setInt],getDouble->[getLong],getUnsignedShortLE->[getShortLE],checkReadableBounds->[readableBytes],asReadOnly->[isRead...
Returns a copy of this buffer with the specified byte order.
this change looks unnecessary, can you revert it?
@@ -48,14 +48,14 @@ class CheckoutQueries(graphene.ObjectType): def resolve_checkout(self, *_args, token): return resolve_checkout(token) - @permission_required(OrderPermissions.MANAGE_ORDERS) + @permission_required(CheckoutPermissions.MANAGE_CHECKOUTS) def resolve_checkouts(self, *_args, **_...
[CheckoutQueries->[resolve_checkout->[resolve_checkout],resolve_checkout_lines->[resolve_checkout_lines],resolve_checkouts->[resolve_checkouts]]]
Resolve a node for a checkout.
It won't work. This method doesn't return anything
@@ -123,13 +123,11 @@ class PoolBuilder $loadNames = array(); foreach ($request->getFixedPackages() as $package) { - $this->nameConstraints[$package->getName()] = null; - $this->loadedNames[$package->getName()] = true; + $this->loadedNames[$package->getName()] = new ...
[PoolBuilder->[warnAboutNonMatchingUpdateAllowList->[getRequires,getPackages,writeError,getName],buildPool->[fixPackage,matches,getTarget,dispatch,getVersion,getRequires,getUpdateAllowList,getUnacceptableFixedPackages,loadPackages,getNames,getStability,warnAboutNonMatchingUpdateAllowList,getLockedRepository,getFixedPac...
Builds a pool of packages from a request. Checks if there are any packages that have not been loaded yet and if so checks if they Returns a new pool of packages that are not yet initialized.
Be careful about that. If we have fixed packages, we should never expand the constraint and mark them as unloaded, otherwise we remove the optimization of partial updates. So you probably need to register an EmptyConstraint here (matching all) rather than an exact-match constraint.
@@ -1657,5 +1657,11 @@ std::string GenericCAO::debugInfoText() return os.str(); } +bool GenericCAO::doShowSelectionBox() +{ + return m_prop.show_selection_box + || (m_client && m_client->getGameUI()->getFlags().show_debug); +} + // Prototype GenericCAO proto_GenericCAO(NULL, NULL);
[getLightPosition->[v3f],clearParentAttachment->[setAttachment,v3f],clearChildAttachments->[setAttachment,v3f],updateLight->[getParent],step->[getSceneNode,update,removeFromScene,translate,v3f,addToScene,updateNodePos,getParent],processInitData->[updateNodePos,processMessage,init], ClientActiveObject->[getType],process...
Debug info for the generic cao.
this kinda breaks the abstraction I suggest moving the show_debug check to `Game::updatePointedThing`
@@ -104,8 +104,8 @@ const MetaRobotsNoIndex = ( { noIndex, onNoIndexChange, editorContext, isPrivate editorContext.postTypeNameSingular, ) } onChange={ onNoIndexChange } - name={ "yoast_wpseo_meta-robots-noindex-react" } - id={ appendLocation( "yoast_wpseo_meta-robots-noindex-react", locati...
[No CFG could be retrieved]
The Meta Robots No - Index component Demonstrates how the Wordpress robots index option should be used.
Reminder for myself to test whether this has an averse effect on the saving of data.
@@ -92,10 +92,10 @@ class Error(jose.JSONObjectWithFields, errors.Error): return code def __str__(self): - return ' :: '.join( - part for part in + return b' :: '.join( + part.encode('ascii', 'backslashreplace') for part in (self.typ, self.description...
[ChallengeBody->[fields_from_json->[from_json],to_partial_json->[to_partial_json]],Authorization->[challenges->[from_json]],NewRegistration->[Resource],Directory->[from_json->[from_json],__getitem__->[_canon_key]],Registration->[phones->[_filter_contact],emails->[_filter_contact]],UpdateRegistration->[Resource],Revocat...
Return a string representation of the object.
Something I forgot to make note of is that when the error in #4273 occurs and this code gets executed, in either Python 2 or 3 (I can't remember which), when the output describing the error/non-ascii domain is printed, it prints literal bytes (e.g. \xBlah\Blah) instead of the domain name. I couldn't find a quick way to...
@@ -186,9 +186,9 @@ var ( // AKSWindowsServer2019OSImageConfig is the AKS image based on Windows Server 2019 AKSWindowsServer2019OSImageConfig = AzureOSImageConfig{ ImageOffer: "aks-windows", - ImageSku: "2019-datacenter-core-smalldisk-2010", + ImageSku: "2019-datacenter-core-smalldisk-2011", ...
[Sprintf]
A list of available images for a sequence of resources. OSImageConfig is the default configuration for the global Azure container image.
Just to confirm we want to keep the WindowsServer2019OSImageConfig values below on the Aug patches right? I think we do and then we can update that with 11B (which should have all the fixes also present in 10C)
@@ -112,7 +112,7 @@ func (factory *BuildControllerFactory) CreateDeleteController() controller.Runna RetryManager: controller.NewQueueRetryManager( queue, cache.MetaNamespaceKeyFunc, - limitedLogAndRetry(factory.BuildUpdater, 30*time.Minute), + controller.RetryNever, kutil.NewTokenBucketRateLimiter(1...
[CreatePod->[Create],List->[List,Get],GetImageStream->[Get],GetPod->[Get],CreateBuildPod->[CreateBuildPod],Watch->[Watch]]
CreateDeleteController creates a build delete controller.
are you sure we don't want to retry on raised errors, now that NotFound errors don't propagate? what will clean up the build pod if not this?
@@ -9,6 +9,9 @@ class ApplicationController < ActionController::Base around_action :set_time_zone, if: :current_user layout 'main' + def test_method + end + def respond_422(message = t('client_api.permission_error')) respond_to do |format| format.json do
[ApplicationController->[current_team->[current_team_id,find_by_id],update_current_team->[id,update,blank?,count],render_403->[render,html,respond_to,json],set_time_zone->[settings,use_zone],respond_422->[t,render,respond_to,json],render_404->[render,html,respond_to,json],around_action,acts_as_token_authentication_hand...
respond to the request with a 422 error.
Style/EmptyMethod: Put empty method definitions on a single line.
@@ -25,6 +25,8 @@ LOOKUP_TABLE_TYPE = "lookup_table" LOOKUP_TABLE_GRAD_TYPE = "lookup_table_grad" RPC_CLIENT_VAR_NAME = "RPC_CLIENT_VAR" +GLOBAL_BLOCK_IDX = 0 + class VarBlock: def __init__(self, varname, offset, size):
[DistributeTranspiler->[_create_table_optimize_block->[_clone_var],_is_op_connected->[_append_inname_remove_beta],_append_pserver_ops->[_get_optimizer_input_shape,same_or_split_var,_orig_varname],get_startup_program->[_get_splited_name_and_shape->[same_or_split_var],_get_splited_name_and_shape],_create_ufind->[_is_op_c...
Initialize a missing variable.
Can remove this line.
@@ -176,6 +176,7 @@ class ManagedIdentityCredential(object): """ return Configuration(**kwargs) + @distributed_trace def get_token(self, *scopes): # type (*str) -> AccessToken """
[EnvironmentCredential->[get_token->[get_token],__init__->[ClientSecretCredential,CertificateCredential]],ChainedTokenCredential->[get_token->[get_token]]]
Creates a configuration object for the HTTP pipeline.
This shouldn't be decorated. It will never be called (likewise for the async version).
@@ -307,8 +307,8 @@ public class DeckAdapter<T extends AbstractDeckTreeNode<T>> extends RecyclerView } - private void processNodes(List<T> nodes) { - for (T node : nodes) { + private void processNodes(List<AbstractDeckTreeNode<T>> nodes) { + for (AbstractDeckTreeNode<T> node : nodes) { ...
[DeckAdapter->[DeckFilter->[performFiltering->[getAllDecks],filterDeckInternal->[filterDeckInternal]],findDeckPosition->[findDeckPosition],onCreateViewHolder->[ViewHolder],processNodes->[processNodes]]]
Recursive method to find the missing deck nodes.
@david-allison-1 Please have a look at the changes in these two lines.
@@ -884,6 +884,13 @@ class WheelBuilder(object): if not buildset: return [] + # Is any wheel build not using the ephemeral cache? + if any(not ephem_cache for _, ephem_cache in buildset): + have_directory_for_build = self._wheel_dir or ( + autobuilding and...
[WheelBuilder->[_clean_one->[_base_setup_args],_build_one_legacy->[_base_setup_args],_build_one_pep517->[replace_python_tag],build->[_build_one,_contains_egg_info]],move_wheel_files->[record_installed->[normpath],get_csv_rows_for_installed->[normpath,rehash],clobber->[record_installed],open_for_csv,root_is_purelib,mess...
Build a new wheels. Build wheels for all packages in the buildset. Add a requirement to the list of requirements that failed to build a .
For future reference, it looks like an alternative way to do this would be to calculate a `needs_ephem_cache` variable (or similarly defined variable) prior to the for loop above. And then check that `ephem_cache` is true inside the for loop prior to appending to the buildset (depending on whether `needs_ephem_cache` i...
@@ -336,6 +336,14 @@ def _enqueue_data(data, "data must be either a numpy array or pandas DataFrame if pandas is " "installed; got {}".format(type(data).__name__)) + pad_data = pad_value is not None + if pad_data and get_feed_fn is not _GeneratorFeedFn: + raise NotImplementedError( + ...
[_PandasFeedFn->[__call__->[_get_integer_indices_for_next_batch]],_OrderedDictNumpyFeedFn->[__call__->[_get_integer_indices_for_next_batch]],_ArrayFeedFn->[__call__->[_get_integer_indices_for_next_batch]]]
Enqueues data from a Pandas array or pandas DataFrame. Get the next n - tuple of the data that can be read from the data queue. all reading the array in order. Use one thread ; if you want multiple threads enable sh Returns the queue of messages to be processed.
+2 space to indent here
@@ -187,11 +187,11 @@ func setupStartOptions(useDefaultPort bool) *start.MasterArgs { } func DefaultMasterOptions() (*configapi.MasterConfig, error) { - return DefaultMasterOptionsWithTweaks(false) + return DefaultMasterOptionsWithTweaks() } -func DefaultMasterOptionsWithTweaks(useDefaultPort bool) (*configapi.M...
[RESTClient,GetAdditionalAllowedRegistries,NewForConfig,APIServices,Info,RoundTrip,Provided,GetClientConfig,New,SetTransportDefaults,DoRaw,GroupVersions,Infof,DefaultSignerName,GetServerCertHostnames,Fatalf,NewDiscoveryClientForConfig,AbsPath,ConvertMasterConfigToKubeAPIServerConfig,CreateMasterCerts,Getenv,Value,NewRe...
DefaultMasterOptions returns a master args object with default values. FindAvailableBindAddress finds the next available bind address and returns it.
Squash both methods together.
@@ -35,6 +35,14 @@ def fakeroot_detected(): return 'FAKEROOTKEY' in os.environ +def user_exists(username): + try: + pwd.getpwnam(username) + return True + except KeyError: + return False + + @unittest.skipUnless(sys.platform.startswith('linux'), 'linux only test') @unittest.skipIf(...
[PlatformDarwinTestCase->[test_access_acl->[get_acl,set_acl]],PlatformLinuxTestCase->[test_default_acl->[get_acl,set_acl],test_access_acl->[get_acl,set_acl],test_non_ascii_acl->[get_acl,set_acl]],fakeroot_detected]
Set up tempfile.
Fix by also catching ValueError (super class of UnicodeXxxError)
@@ -84,8 +84,14 @@ public class DB { * Closes a previously opened database connection. */ public void close() { - mDatabase.close(); - Timber.d("Database %s closed = %s", mDatabase.getPath(), !mDatabase.isOpen()); + try { + mDatabase.close(); + Timber.d("Datab...
[DB->[queryString->[close],queryColumn->[close],update->[update],queryScalar->[queryScalar,close],queryLongScalar->[close],execute->[execute],insert->[insert],close->[close],getPath->[getPath]]]
Closes the database and commits the current transaction if it is in a non - exclusive state.
The support framework throws an exception that requery eats, so when we move to the framework API we have to handle
@@ -47,6 +47,7 @@ public class InterpreterSetting { // always be null in case of InterpreterSettingRef private String group; private transient Map<String, String> infos; + private transient Map<String, Set<String>> noteIdToParaIdsetMap; /** * properties can be either Properties or Map<String, Interpr...
[InterpreterSetting->[getInterpreterGroup->[getId,getInterpreterProcessKey],shutdownAndRemoveInterpreterGroup->[isEqualInterpreterKeyProcessKey,getInterpreterProcessKey],closeAndRemoveInterpreterGroupByUser->[getInterpreterSessionKey,isEqualInterpreterKeyProcessKey,getInterpreterProcessKey],getInterpreterProcessKey->[g...
Creates a new interpreter setting. private final InterpreterGroupFactory interpreterGroup ; private final int interpreterGroupCount ; private final.
Because of every `Note` already has reference to its `Paragraphs`, i don't think it make sense maintaining another noteId - paragraphId map here, according to this variable name. How about change this variable name to `runtimeInfosToCleared` or something similar to describe its purpose better? That may help understandi...
@@ -44,6 +44,18 @@ namespace System.Drawing.Tests yield return new object[] { "16x16_nonindexed_24bit.png", 16, 16, PixelFormat.Format24bppRgb, ImageFormat.Png }; } + [PlatformSpecific(TestPlatforms.AnyUnix)] + [ConditionalFact(typeof(RemoteExecutor), nameof(RemoteExecutor.IsSuppor...
[BitmapTests->[TestStream->[Flush->[Flush],Write->[Write],Seek->[Seek],Read->[Read],SetLength->[SetLength]]]]
This method is used to test the file path of a Ctor.
Why set it if it's false by default? Seems we should test default, and also test when explicitly enabled.
@@ -60,6 +60,12 @@ namespace Microsoft.Xna.Framework.Graphics isTargetCube = false; } + public static implicit operator RenderTargetBinding(RenderTarget2D renderTarget) + { + RenderTargetBinding RenderTargetBinding = new RenderTargetBinding(renderTarget); + return RenderTarg...
[No CFG could be retrieved]
The RenderTarget object that is used to render the .
nit: stick to tabs for indentation, unless the file on the whole uses spaces.
@@ -196,6 +196,9 @@ int ssl3_cbc_digest_record(const EVP_MD *md, return 0; if (EVP_MD_is_a(md, "MD5")) { +#ifdef FIPS_MODULE + return 0; +#else if (MD5_Init((MD5_CTX *)md_state.c) <= 0) return 0; md_final_raw = tls1_md5_final_raw;
[void->[l2n8,u32toLE,l2n],ssl3_cbc_digest_record->[md_final_raw,constant_time_select_8,constant_time_ge_8_s,ossl_assert,EVP_DigestFinal,SHA512_Init,memcpy,SHA256_Init,SHA384_Init,EVP_DigestUpdate,EVP_MD_CTX_free,constant_time_eq_8_s,SHA224_Init,md_transform,EVP_MD_CTX_new,EVP_MD_is_a,EVP_DigestInit_ex,memset,SHA1_Init,...
This function is used to perform a digest record in the SSLv3 standard. MD5 - SHA1 - SHA2 - 256 - SHA384 - SHA512 - MD RFC Section 4. 5. 2. 5. 1 This function is used to determine the number of hash blocks that can be hashed and if so region Private functions if k is greater than 0 we can do a partial read of the data.
Why doesn't this generate a defined but not used error when building FIPS? Both `u32toLE` and `tls1_md5_final_raw()` ought to be conditioned on FIPS.
@@ -115,7 +115,7 @@ public class PooledTopNAlgorithm } @Override - public TopNResultBuilder makeResultBuilder(PooledTopNParams params) + public TopNResultBuilder makeResultBuilder(PooledTopNParams params, TopNQuery query) { return query.getTopNMetricSpec().getResultBuilder( params.getCursor()...
[PooledTopNAlgorithm->[makeInitParams->[build],PooledTopNParams->[Builder->[build->[PooledTopNParams]]],makeDimValSelector->[build]]]
This method is called to create a TopNResultBuilder based on the specified parameters.
I understand why you need this, but having two query variable, one as class member, and one as part of the method is going to be very confusing, especially since this method is not static. Can we find a less confusing workaround?
@@ -50,7 +50,7 @@ class SubmissionFile < ActiveRecord::Base # comment and the second element being the syntax to end a comment. Use #the language's multiple line comment format. case File.extname(filename) - when '.java', '.js', '.c' + when '.java', s'.js', '.c' return %w(/* */) when '...
[SubmissionFile->[convert_pdf_to_jpg->[is_pdf?],get_annotation_grid->[is_supported_image?,is_pdf?]]]
Returns a list of syntax to start and end a comment.
I think there is a typo here.
@@ -84,6 +84,12 @@ class CI_Cache_redis extends CI_Driver */ public function save($id, $data, $ttl = 60, $raw = FALSE) { + if (is_array($data) || is_object($data)) + { + $this->_redis->delete($id); + $data = serialize($data); + $id .= self::KEY_SUFFIX_FOR_SERIALIZATION; + } return ($ttl) ? $this-...
[CI_Cache_redis->[delete->[delete],get->[get],get_metadata->[get]]]
Save a record in the cache.
Use 'OR' instead of '||'.
@@ -521,7 +521,12 @@ class Controls: alerts = self.events.create_alerts(self.current_alert_types, [self.CP, self.sm, self.is_metric]) self.AM.add_many(self.sm.frame, alerts, self.enabled) self.AM.process_alerts(self.sm.frame, clear_event) - CC.hudControl.visualAlert = self.AM.visual_alert + + if se...
[Controls->[controlsd_thread->[step],step->[state_transition,update_events,publish_logs,state_control,data_sample]],main->[Controls,controlsd_thread],main]
Publish logs to the car and the MPC logs. 5s blinker cooldown alert send can can list to can_capnp Reads all the state of a specific node. get next iteration .
Do we really want this steer required using a button? Doesn't seem that useful and adds a bunch of code.
@@ -334,12 +334,15 @@ test_init(void) rc); } - for (i = 0; i < test_g.t_ctx_num; i++) { + /* Start at 1 instead of 0, because we've already created one context + in crtu_srv_start_basic */ + + for (i = 1; i < test_g.t_ctx_num; i++) { test_g.t_thread_id[i] = i; rc = crt_context_create(&test_g.t_crt_ctx...
[No CFG could be retrieved]
This function initializes the CRT and creates the CRT context. create the object.
(style) trailing whitespace
@@ -1,5 +1,6 @@ # frozen_string_literal: true -ENV["BUNDLE_GEMFILE"] ||= File.expand_path("../Gemfile", __dir__) -require "bundler/setup" # Set up gems listed in the Gemfile. -require "bootsnap/setup" # Speed up boot time by caching expensive operations. +ENV['BUNDLE_GEMFILE'] ||= File.expand_path('../Gemfile', __di...
[require,expand_path]
The main method of the class.
Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
@@ -32,7 +32,16 @@ namespace NServiceBus.Timeout.Hosting.Windows if (TimeoutsPersister.TryRemove(timeoutId, out timeoutData)) { - MessageSender.Send(timeoutData.ToTransportMessage(), timeoutData.ToSendOptions(Configure.LocalAddress)); + try + { + ...
[TimeoutDispatcherProcessor->[Start->[Start],Stop->[Stop]]]
Handle a TransportMessage.
Technically this might still loose data since if the `.Add` blows up but this does make it less likely to happen. But there is a chance that both the queuing system and the storage goes bad at the same time. @Particular/nservicebus what do you all think?
@@ -264,6 +264,10 @@ export class ResourcesImpl { } // With IntersectionObserver, we only need to handle viewport resize. if (this.relayoutAll_ || !this.intersectionObserver_) { + // Unfortunately, a viewport size change invalidates all premeasurements. + if (this.intersectionObserver...
[No CFG could be retrieved]
Adds an IntersectionObserver to the AMPDocument which can be used to handle intersection events Schedule a single pass of the AMP document.
Nit: Possible to use a more descriptive name for each member? `r` => `resource`
@@ -161,9 +161,6 @@ void dt_exif_set_exiv2_taglist() { if(exiv2_taglist) return; - Exiv2::XmpParser::initialize(); - ::atexit(Exiv2::XmpParser::terminate); - try { const Exiv2::GroupInfo *groupList = Exiv2::ExifTags::groupList();
[No CFG could be retrieved]
Get the name of the Xmp tags. - - - - - - - - - - - - - - - - - -.
Are those removals really wanted? I'm don't see the relation with the fix below... Just in case I prefer asking.
@@ -5,7 +5,10 @@ namespace System.Threading { public sealed partial class Thread { - private static Exception GetApartmentStateChangeFailedException() => - new InvalidOperationException(SR.Thread_ApartmentState_ChangeFailed); + private static Exception GetApartmentStateChangeFailedEx...
[Thread->[Exception->[Thread_ApartmentState_ChangeFailed]]]
GetApartmentStateChangeFailedException - InvalidOperationException.
It may better to add `throwOnError` argument to `TrySetApartmentStateUnchecked` and throw the exception right from there. The current apartment state is available in that function already. No need to re-fetch it.
@@ -133,12 +133,9 @@ public class BaseDataPublisher extends DataPublisher { this.fss.get(branchId).mkdirs(publisherOutputDir.getParent()); } - if (this.fss.get(branchId).rename(writerOutputDir, publisherOutputDir)) { - LOG.info(String.format("Moved %s to %s", writerOutputDir, publi...
[BaseDataPublisher->[addWriterOutputToExistingDir->[Path,getProp,getName,getPropAsBoolean,listStatus,getPropertyNameForBranch,rename,format,IOException,info,getPath],publishData->[newHashSet,getParent,getPropAsBoolean,setWorkingState,IOException,warn,info,rename,getDataPublisherFinalDir,addWriterOutputToExistingDir,get...
Publish data to the output directories. Checks if there is a in the work unit and if so moves the writerOutputPaths.
This is changing the semantics. I suggest doing something like `renamePath(Path, Path, Function<T, Void> callback)` and wrap `writerOutputPathsMoved.add(writerOutputDir)` into the callback, which will be called upon successful rename.
@@ -106,7 +106,9 @@ public class TimeFormatExtractionFn implements ExtractionFn @Override public byte[] getCacheKey() { - final byte[] exprBytes = StringUtils.toUtf8(format + "\u0001" + tz.getID() + "\u0001" + locale.toLanguageTag()); + final String tzId = tz == null ? "" : tz.getID(); + final String ...
[TimeFormatExtractionFn->[getCacheKey->[getCacheKey],hashCode->[hashCode],apply->[apply],equals->[equals]]]
Get the cache key for a missing node.
if the TZ is explicitly set as UTC this will not match
@@ -306,8 +306,8 @@ public enum CompressionStrategy public static class LZ4Compressor extends Compressor { - private static final LZ4Compressor defaultCompressor = new LZ4Compressor(); - private static final net.jpountz.lz4.LZ4Compressor lz4High = LZ4Factory.fastestInstance().highCompressor(); + privat...
[UncompressedCompressor->[UncompressedCompressor],LZ4Compressor->[compress->[compress],LZ4Compressor],UncompressedDecompressor->[UncompressedDecompressor],LZFCompressor->[LZFCompressor],LZ4Decompressor->[decompress->[decompress],LZ4Decompressor],LZFDecompressor->[LZFDecompressor],getId]
Allocate a buffer that is not yet allocated.
Please call `LZ4_HIGH`
@@ -320,6 +320,14 @@ class SeleniumWebDriverController { return await handle.getElement().click(); } + /** + * @return {!Promise<void>} + */ + refresh() { + return this.driver.navigate().refresh() + .catch(e => {this.logError_(e);}); + } + /** * @param {!ElementHandle<!WebElement>} han...
[SeleniumWebDriverController->[takeElementScreenshot->[takeScreenshot]]]
Click the element.
Should remove curly braces here unless you plan on making this more than one line. This is also confusing since it looks like you are swallowing the error and not propagating it.
@@ -8,7 +8,7 @@ import ( func (mc *MeshCatalog) refreshCache() { log.Info().Msg("Refresh cache...") servicesCache := make(map[endpoint.WeightedService][]endpoint.Endpoint) - serviceAccountsCache := make(map[endpoint.NamespacedServiceAccount][]endpoint.NamespacedService) + serviceAccountToServicesCache := make(map[...
[refreshCache->[ListServicesForServiceAccount,Msg,Unlock,GetID,ServiceName,ListServices,Msgf,String,Lock,ListServiceAccounts,Trace,Info,ListEndpointsForService]]
refreshCache will refresh the cache from the local cache Add new services to the cache.
should the value type for this be a map/set?
@@ -273,6 +273,8 @@ export class VariableService { 'COOKIE': (name) => cookieReader(this.ampdoc_.win, dev().assertElement(element), name), 'CONSENT_STATE': getConsentStateStr(element), + 'CONSENT_METADATA': (key) => + getConsentMetadataValue(element, dev().assertString(key)), }; ...
[VariableService->[getMacros->[CUMULATIVE_LAYOUT_SHIFT,FIRST_VIEWPORT_READY,dev,FIRST_INPUT_DELAY,MAKE_BODY_VISIBLE,performanceFor,isInFie,cookieReader,LARGEST_CONTENTFUL_PAINT_VISIBLE,getConsentStateStr,FIRST_CONTENTFUL_PAINT_VISIBLE],constructor->[round,trim,dict,viewportForDoc,String,toUpperCase,stringToBool,toLower...
Get macros for an element.
I believe not including the key is a user error?
@@ -47,10 +47,10 @@ type Props = { _liveStreamViewURL: ?string, /** - * The number of real participants in the call. If in a lonely call, the + * True if the number of real participants in the call is less than 2. If in a lonely call, the * {@code InfoDialog} will be automatically shown. ...
[No CFG could be retrieved]
The type of the component is the type of the component in the system. The state of the type.
Maybe we should call this `_lonelyCall` instead then? We could also encapsulate the check in some `isLonleyCall` function, IIRC mobile also performs this check.
@@ -57,6 +57,17 @@ func (c *Crawler) Start(r *registrar.Registrar, configProspectors *common.Config }() } + if configModules.Enabled() { + logp.Beta("Loading separate prospectors is enabled.") + + c.reloader = cfgfile.NewReloader(configModules) + // TODO add beatVersion here + factory := fileset.NewFactory(c...
[Start->[NewFactory,startProspector,Beta,NewReloader,Enabled,Info,Run,GetStates],startProspector->[ID,NewProspector,Start,Enabled,Errorf],WaitForCompletion->[Wait],Stop->[Info,WaitForCompletion,Done,Add]]
Start starts the crawler.
I see you pass it above, so you could add it now?
@@ -235,6 +235,12 @@ export class AmpAd3PImpl extends AMP.BaseElement { user().assert(!this.isInFixedContainer_, '<amp-ad> is not allowed to be placed in elements with ' + 'position:fixed: %s', this.element); + /** detect ad containers, add the list to element as a new attribute */ + ...
[No CFG could be retrieved]
Measure the layout box of the iframe if it is not already rendered. Activates the fallback if the ad slot cannot be filled.
does it fit in the previous line?
@@ -2125,7 +2125,10 @@ case_2: Assert(!(callInfo.Flags & CallFlags_New)); - return ToLocaleCaseHelper(args[0], false, scriptContext); + JavascriptString * pThis = nullptr; + GetThisStringArgument(args, scriptContext, _u("String.prototype.toLocaleUpperCase"), &pThis); + + return ...
[No CFG could be retrieved]
Replies the next unique string to be used as the value of a function call. The function below is not thread - safe. It is a bit of a hack to work.
>toLocaleUpperCase [](start = 72, length = 17) These labels are mixed up between the two functions.
@@ -171,12 +171,6 @@ func (d *driver) runTransaction(txnCtx *txncontext.TransactionContext, info *tra err = directTxn.UpdateJobState(request.UpdateJobState) } else if request.StopJob != nil { err = directTxn.StopJob(request.StopJob) - } else if request.DeleteAll != nil { - // TODO: extend this to delete e...
[runTransaction->[deleteAll],deleteAll->[listTransaction],finishTransaction->[runTransaction],appendTransaction->[runTransaction]]
runTransaction runs the transaction and returns the transaction info This is not currently used in the transaction. It is not possible to delete unused transaction -.
seemed unused, makes things easier
@@ -41,7 +41,7 @@ type StreamID string // Meta return the StreamID of the stream func (st *BaseStream) ID() StreamID { - return StreamID(st.raw.ID()) + return StreamID(st.raw.Conn().ID()) } // ProtoID return the remote protocol ID of the stream
[ID->[ID],WriteBytes->[Write],ProtoSpec->[Do,ProtoID],Close->[Reset],ProtoID->[Protocol],ReadBytes->[ReadAll]]
ID returns the StreamID of the underlying stream.
any reason for this change? or just previous one was wrong?
@@ -76,6 +76,16 @@ public class TopologySubcommand extends ScmSubcommand if (nodes != null && nodes.size() > 0) { // show node state System.out.println("State = " + state.toString()); + if (nodeOperationalState != null) { + nodes = nodes.stream().filter( + info -> i...
[TopologySubcommand->[printNodesWithLocation->[getAdditionNodeOutput,formatPortOutput]]]
Execute the HDDs commands.
we should add a guardrail here to throw exception if the nodeState isn't HEALTHY/STALE/DEAD.
@@ -366,11 +366,9 @@ func (i *Image) PullImage(ctx context.Context, image, tag string, metaHeaders ma } // Check if url is contained within set of whitelisted or insecure registries - vchConfig := VchConfig() - insecureOk := RegistrySetContains(vchConfig.InsecureRegistries, hostnameURL) - whitelistOk := RegistryS...
[SearchRegistryForImages->[Errorf],ImagesPrune->[Errorf],ImportImage->[Errorf],Commit->[Errorf],ExportImage->[Errorf],Images->[IncludeImage,Begin,Sprintf,Include,End,GetImages,ImageCache,ValidateImageFilters],ImageHistory->[Errorf],TagImage->[WithTag,WithName,String,ImageCache,Log,Get,AddReference,RepositoryCache],Imag...
PullImage pulls an image from the registry PullImage pulls an image from the registry.
feels a bit weird cause the blacklist check is ignored here
@@ -110,6 +110,18 @@ func (cli *Client) CreateJobSpec(c *clipkg.Context) error { return cli.deserializeResponse(resp, &jobs) } +func fromFile(arg string, cli *Client) (*bytes.Buffer, error) { + dir, err := homedir.Expand(arg) + if err != nil { + return nil, err + } + file, err := ioutil.ReadFile(dir) + if err != ...
[ShowJobSpec->[deserializeResponse,Present,Args,First,BasicAuthGet,New,Close,errorOut],deserializeResponse->[New,Unmarshal,Render,errorOut,ReadAll],RunNode->[Stop,GetStore,Infow,Authenticate,Start,NewApplication,String,errorOut,Run,Bool],GetJobSpecs->[Close,errorOut,BasicAuthGet,deserializeResponse],errorOut->[NewExitE...
CreateJobSpec creates a new job spec.
`fromFile` never uses `cli *Client` so let's remove that parameter.
@@ -17,6 +17,9 @@ class AppFilterInput(FilterInputObjectType): class AppQueries(graphene.ObjectType): + ongoing_apps_installations = PrefetchingConnectionField( + OngoingAppInstallation, description="List of all ongoing apps installations" + ) apps = FilterInputConnectionField( App, ...
[AppQueries->[resolve_apps->[resolve_apps],AppFilterInput]]
Create a Field object for the n - th app.
Is pagination required here?
@@ -17,6 +17,7 @@ use Composer\DependencyResolver\Operation\OperationInterface; use Composer\DependencyResolver\Operation\InstallOperation; use Composer\DependencyResolver\Operation\UpdateOperation; use Composer\DependencyResolver\Operation\UninstallOperation; +use Composer\DependencyResolver\Operation\ReplaceOperat...
[InstallationManager->[install->[install,getInstaller],getInstallPath->[getInstallPath,getInstaller],uninstall->[uninstall,getInstaller],update->[install,update,getInstaller]]]
Creates a new instance of InstallationManager. Returns installer for a specific package type.
should be removed
@@ -1571,6 +1571,10 @@ func GeneratePackage(tool string, pkg *schema.Package, extraFiles map[string][]b return files, nil } +func PrepareOutDir(outDir string) error { + return codegen.CleanDir(outDir, &[]string{"tests"}) +} + const utilitiesFile = ` export function getEnv(...vars: string[]): string | undefined {...
[genResource->[getConstValue,genAlias,getDefaultValue,genPlainType,typeString],genTypes->[genType,sdkImports,getImports,genHeader,details],genType->[details,genPlainType],gen->[genResource,genTypes,sdkImports,genFunction,isReservedSourceFileName,getImports,genHeader,add,genConfig],genFunction->[genPlainType],getTypeImp...
GeneratePackage generates the package metadata and returns the files and the package metadata. Get the number of the node - package - version from the environment.
Not all packages have a `tests` directory--the contents of this set should be left to the caller.
@@ -829,12 +829,12 @@ Java_io_daos_dfs_DaosFsClient_dfsReadDir(JNIEnv *env, jobject client, nr = READ_DIR_BATCH_SIZE; rc = dfs_readdir(dfs, dir, &anchor, &nr, entries); if (rc) { - char *tmp = "Failed to read %d more entries from " \ - "directory after reading %d " \ + char *tmp = "Failed to read %d mo...
[No CFG could be retrieved]
\ param objId pointer to opened fs object \ param maxEntries maximum number of entries to read - dir header.
(style) space required before the open brace '{' (style) space required before the open parenthesis '('
@@ -258,6 +258,7 @@ int main(int argc, char **argv) while (frcd->fs.reached_eof == 0) pipeline_schedule_copy(p, 0); + // should we add pipeline_schedule_copy to the second pipeline? if (!frcd->fs.reached_eof) printf("warning: possible pipeline xrun\n");
[No CFG could be retrieved]
Parse topology and return the number of components. Initialize the n - tuple of sample count objects.
After knowing that pipeline_schedule_copy() is called for not only one pipeline (as explained in pipeline.c), then I start to doubt this code: here we only put pipeline_schdule_copy() for the first pipeline, should we also add the second one?
@@ -47,6 +47,13 @@ module Authentication ) end + def image_url + token = auth_payload.credentials.token + uid = auth_payload.uid + request = HTTParty.get("https://graph.facebook.com/#{uid}?fields=picture.type(small)&access_token=#{token}") + request["picture"]["data"][...
[Facebook->[existing_user_data->[name,now],new_user_data->[email,now,name,image],user_nickname->[join],sign_in_path->[sign_in_path],freeze]]
Returns the path to sign in with the provider name and payload if there is one.
this should likely be moved in a `private` section at the bottom
@@ -267,7 +267,7 @@ def save_vars(executor, def save_params(executor, dirname, main_program=None, filename=None): """ - This function filters out all parameters from the give `main_program` + This operator filters out all parameters from the give `main_program` and then save them to the folder `dirna...
[_load_persistable_nodes->[_exist,load_vars],get_parameter_value_by_name->[get_parameter_value],save_persistables->[save_vars,_save_distributed_persistables],_save_distributed_persistables->[__save_distributed_lookup_tables,save_vars,__exclude_vars,__save_remote_params],load_vars->[_clone_var_in_block_,load_vars],load_...
Saves all parameters from the given main program to the given directory or to the given file.
Say it in an easy English way: This operator saves all parameters from the `main_program` to the folder `dirname` or the file `filename`.
@@ -175,11 +175,10 @@ public class SchemaKSourceFactoryTest { } @Test - public void shouldBuildNonWindowedTable() { + public void shouldBuildV1NonWindowedTable() { // Given: - when(dataSource.getDataSourceType()).thenReturn(DataSourceType.KTABLE); - when(keyFormat.isWindowed()).thenReturn(false); -...
[SchemaKSourceFactoryTest->[shouldBuildNonWindowedStream->[thenReturn,assertValidSchema,getSources,empty,buildSource,is,instanceOf,assertThat,not,getSourceStep],assertValidSchema->[resolve,getSchema,is,assertThat,getSourceStep],shouldBuildNonWindowedTable->[thenReturn,assertValidSchema,empty,buildSource,is,instanceOf,a...
When a windowed table is being built this method will check if the table is already built.
This mock is not necessary. The default mockito return value for boolean methods is false anyway. We can make the tests more readable by only mocking the necessary methods (i.e., the ones where this config returns true).
@@ -77,8 +77,8 @@ class TestConan(ConanFile): exports_sources = "file2.txt" """ ref = ConanFileReference.loads("Hello/1.2@lasote/stable") - export_path = client.cache.export(ref) - export_src_path = client.cache.export_sources(ref) + export_path = client.cache.package_layout(ref).exp...
[ExportMetadataTest->[test_revision_mode_scm->[package_layout,TestClient,assertEqual,create_local_git_repo,format,run,loads],test_revision_mode_invalid->[TestClient,assertIn,format,run,save,loads],test_revision_mode_hash->[package_layout,TestClient,assertEqual,format,run,save,loads],dedent],ExportTest->[test_export_a_n...
Test export read - only. This test tests if the package has the necessary permissions.
`self._cache.export_sources(ref, short_paths=False)` vs `self._cache.package_layout(ref, short_paths=None).export_sources()`
@@ -162,7 +162,8 @@ $sql.= " FROM ".MAIN_DB_PREFIX."societe as s"; $sql.= ", ".MAIN_DB_PREFIX."commande_fournisseur as cf"; if (!$user->rights->societe->client->voir && !$socid) $sql.= ", ".MAIN_DB_PREFIX."societe_commerciaux as sc"; $sql.= " WHERE cf.fk_soc = s.rowid"; -$sql.= " AND s.entity = ".$conf->entity; +$sq...
[setShowPercent,SetData,fetch_object,jdate,getDocumentsLink,draw,getNomUrl,show,setShowLegend,fetch_row,load,plimit,loadLangs,LibStatut,close,free,query,SetType,setWidth,trans,num_rows]
Get statistics for all non - zero n - n - n - n - n - n Print the sequence number of unique ids.
@mapiolca replace with : `$sql.= " AND s.entity IN (".getEntity("societe").")";`
@@ -252,7 +252,7 @@ func main() { maxNumTxsPerBatch := flag.Int("max_num_txs_per_batch", 20000, "number of transactions to send per message") logFolder := flag.String("log_folder", "latest", "the folder collecting the logs of this execution") numSubset := flag.Int("numSubset", 3, "the number of subsets of utxos t...
[Root,SendMessage,Unlock,Warn,GOMAXPROCS,AddNewBlock,ConstructStopMessage,Now,InitLookUpIntPriKeyMap,GetValidators,SetHandler,GetShardIDToLeaderMap,NewConfig,Info,Exit,Add,Done,GetLeaders,FileHandler,Error,Int,UpdateUtxoAndState,AddTestingAddresses,NewOutPoint,Seconds,GetAddressFromInt,New,GetClientPort,GetBytesFromPub...
Add a new block of transactions to the list of block IDs. NewConfig - creates a new setting object from the given config file.
really need to change default value?
@@ -80,7 +80,15 @@ export const saveAccountSettings = account => async dispatch => { successMessage: translate('settings.messages.success') } }); + <%_ if (enableTranslation) { _%> + const accountResult = await dispatch(getSession()); + + if (accountResult && accountResult.value && accountResult.value...
[No CFG could be retrieved]
POST a to the API.
can we get this from the state instead by using `getState()` here as it will be cleaner pattern since it goes through the reducer
@@ -47,6 +47,7 @@ static int FSTAB_EDITS = 0; /* GLOBAL_X */ static Item *FSTABLIST = NULL; /* GLOBAL_X */ +void GetHostAndSource(char *buf, char *host, char *source); static void AugmentMountInfo(Seq *list, char *host, char *source, char *mounton, char *options); static int MatchFSInFstab(char *match); static v...
[DeleteMountInfo->[free,SeqClear,SeqAt,SeqLength],VerifyUnmount->[free,feof,strstr,cfPS,xmalloc,GetErrorStr,CfReadLine,cf_popen,Log,snprintf,PromiseResultUpdate,cf_pclose],int->[strtok,free,xstrdup,strncmp,strcmp],CleanupNFS->[DeleteItemList,Log,RawSaveItemList],LoadMountInfo->[free,signal,feof,strstr,sscanf,strlcpy,al...
Augment mount info with the necessary information. The path to the mount system.
This should be a `static` function.
@@ -22,12 +22,14 @@ Rails.application.routes.draw do post '/sign_up/register' => 'sign_up/registrations#create', as: :sign_up_register get '/sign_up/start' => 'sign_up/registrations#show', as: :sign_up_start get '/sign_up/verify_email' => 'sign_up/emails#show', as: :sign_up_verify_email + get '/sign_u...
[draw,namespace,new,root,match,get,post,devise_scope,mount,put,patch,devise_for,require,enable_test_routes,delete]
Devise handles login itself. route for two - factor authentication.
`patch` verbs typically apply to `#update` methods right? Would it horribly break devise if we tried to do that?
@@ -60,14 +60,15 @@ public class NettyTransport implements Transport { } } + private boolean running; + public NettyTransport(InetSocketAddress address, ProtocolServerConfiguration configuration, String threadNamePrefix, EmbeddedCacheManager cacheManager) { this.addre...
[NettyTransport->[getTotalBytesRead->[getTotalBytesRead],getNumberOfLocalConnections->[getNumberOfLocalConnections],getPort->[getPort],getTotalBytesWritten->[getTotalBytesWritten],getHostName->[getHostName],getNumberOfGlobalConnections->[getNumberOfGlobalConnections]]]
Checks if log4j is available.
volatile? group with other fields?
@@ -50,8 +50,10 @@ import org.apache.calcite.util.Pair; import org.apache.druid.java.util.common.guava.BaseSequence; import org.apache.druid.java.util.common.guava.Sequence; import org.apache.druid.java.util.common.guava.Sequences; +import org.apache.druid.segment.DimensionHandlerUtils; import org.apache.druid.sql....
[DruidPlanner->[close->[close],planWithBindableConvention->[close],EnumeratorIterator->[next->[next],hasNext->[hasNext]]]]
Imports a single object from the System. Creates a Druid planner that parses the given SQL string and returns the result.
Hmm I think we usually use `javax.annotation.Nullable`.
@@ -1031,7 +1031,7 @@ class ClickableImage(object): self.ax = self.fig.add_subplot(111) self.ymax = self.imdata.shape[0] self.xmax = self.imdata.shape[1] - self.im = self.ax.imshow(imdata, aspect='auto', + self.im = self.ax.imshow(imdata, extent...
[_mouse_click->[_plot_raw_time,_handle_change_selection],_annotation_radio_clicked->[_get_active_radiobutton],_change_channel_group->[_set_radio_button],_setup_annotation_fig->[figure_nobar],tight_layout->[tight_layout],ClickableImage->[plot_clicks->[plt_show],__init__->[plt_show]],_process_times->[_find_peaks],_plot_r...
Display the image for clicking.
maybe it should be `aspect='equal'`? Or is that the default?
@@ -665,6 +665,13 @@ public class InterpreterSetting { runtimeInfosToBeCleared = null; } + public String getLauncherPlugin() { + if (group.equals("spark")) { + return "SparkInterpreterLauncher"; + } else { + return "StandardInterpreterLauncher"; + } + } //////////////////////////// I...
[InterpreterSetting->[loadInterpreterDependencies->[run->[getGroup,setErrorReason,getDependencies,setStatus],setErrorReason,setStatus],getInterpreterClassFromInterpreterSetting->[getName],Builder->[InterpreterSetting],getInterpreterGroup->[getInterpreterGroupId],createInterpreters->[getInterpreterInfos,getJavaPropertie...
clear note id and para map.
Cool! Do you have any idea how can we make InterpreterLauncher user configurable?
@@ -389,6 +389,9 @@ func Version() string { } func IsAppStateForeground() bool { + if !isInited() { + return false + } return kbCtx.MobileAppState.State() == keybase1.MobileAppState_FOREGROUND }
[GetServers->[processExternalResult,GetServers],GetServers]
Get the next n bytes of data from the buffer. SetAppStateBackgroundActive updates the mobile app state to active and background active.
This is what was panic'ing before
@@ -70,10 +70,16 @@ void spg2xx_pdc100_game_state::pdc100(machine_config &config) } ROM_START( pdc100 ) - ROM_REGION( 0x8000000, "maincpu", ROMREGION_ERASE00 ) + ROM_REGION( 0x4000000, "maincpu", ROMREGION_ERASE00 ) // only 1st half of this is used "Jumper resistor (0 ohm) that short A25 to ground" // 2nd half ...
[No CFG could be retrieved]
region machine specific functions The game state of the game.
Can you update the hashes please?
@@ -1979,8 +1979,11 @@ int ssl_cipher_get_cert_index(const SSL_CIPHER *c) return SSL_PKEY_DSA_SIGN; else if (alg_a & SSL_aRSA) return SSL_PKEY_RSA_ENC; + else if (alg_a & SSL_aGOST12) + return SSL_PKEY_GOST_EC; else if (alg_a & SSL_aGOST01) return SSL_PKEY_GOST01; + ret...
[No CFG could be retrieved]
Returns the index of the certificate type that corresponds to the given cipher. This is a private function.
Something strange with formatting here
@@ -1,7 +1,7 @@ -/*[INCLUDE-IF Sidecar19-SE-B174]*/ +/*[INCLUDE-IF Sidecar19-SE]*/ /******************************************************************************* - * Copyright (c) 2017, 2017 IBM Corp. and others + * Copyright (c) 2017, 2018 IBM Corp. and others * * This program and the accompanying materials a...
[No CFG could be retrieved]
Listing of availability set elements.
Shouldn't this be `Sidecar19-SE-OpenJ9`? Here and below
@@ -372,6 +372,11 @@ bool DBPrivDelete(DBPriv *db, const void *key, int key_size) Log(LOG_LEVEL_ERR, "Could not commit: %s", mdb_strerror(rc)); } } + else if (rc == MDB_NOTFOUND) + { + Log(LOG_LEVEL_DEBUG, "Entry not found: %s", mdb...
[DBPrivWrite->[mdb_put,mdb_txn_commit,mdb_strerror,Log,mdb_txn_begin,mdb_txn_abort,mdb_cursor_txn],DBPrivWriteCursorEntry->[Log,mdb_strerror,mdb_cursor_put],DBPrivOpenDB->[mdb_strerror,mdb_env_open,mdb_txn_commit,mdb_env_create,free,mdb_open,mdb_env_set_mapsize,Log,mdb_env_close,mdb_txn_begin,xcalloc],DBPrivCloseDB->[f...
DBPrivDelete deletes a key from the database.
(Minor) I would be inclined to turn this chained if...else if...else into a switch(rc). It made sense to use if when the switch would just have had one case and a default, but now that it's got two cases, it's a better representation of the decision being taken here. What we do here depends on the value of rc; if it's ...
@@ -718,7 +718,7 @@ let BindEvaluateExpressionResultDef; /** * Options for Bind.rescan(). - * @typedef {{update: (boolean|undefined), fast: (boolean|undefined), timeout: (number|undefined)}} + * @typedef {{update: (boolean|string|undefined), fast: (boolean|undefined), timeout: (number|undefined)}} */ let BindRe...
[showText,imageUrl,layoutRows,autoplayEnabled,vg,productId,getTargetRect,AMP_CONFIG,extendDefaults,ctaText,isSameDay,AMP_CONTEXT_DATA,isInclusivelyBeforeDay,backgroudColor,extendAliases,ANCHOR_LEFT,BaseTemplate,context,BaseElement,bodyBackgroundColor,__AMP_TAG,pageHidden,changes,layoutScroll,tweetid,spacing,play,hoverO...
A message that can be passed to a worker. MISSING - PARAMS - BINDSETSTATEOPTIONS.
nit: this type is awkward. it could make more sense to only support `string` now that there are three modes.
@@ -520,7 +520,7 @@ export class ManualAdvancement extends AdvancementConfig { if ( this.isInStoryPageSideEdge_(event, pageRect) || - this.isTooLargeOnPage_(target, pageRect) + this.isTooLargeOnPage_(event, target, pageRect) ) { event.preventDefault(); return false;
[No CFG could be retrieved]
Checks if an element has to be descendant of a page or not. Checks if an element is inside of the bottom region of the screen.
For future reference, we could just pass the event and extract the target from there, instead of having to pass both the event and the target.
@@ -1177,7 +1177,17 @@ def _recursive_search(path, pattern): filtered_files = list() for dirpath, dirnames, files in os.walk(path): for f in fnmatch.filter(files, pattern): - filtered_files.append(op.realpath(op.join(dirpath, f))) + # only the following file types are supported ...
[_iterate_trans_views->[_fig_to_img],Report->[_render_forward->[_get_id],add_section->[_get_id,_fig_to_img],_render_trans->[_get_id,_iterate_trans_views],_render_image->[_get_id,_render_array],_render_cov->[_get_id,_fig_to_img],_render_toc->[_is_bad_fname,_get_toc_property],_render_raw->[_get_id],_render_inverse->[_get...
Recursive search for files and directories and return a .
you might want to create a VALID_EXTENSION global used also above to avoid maintaining both
@@ -70,6 +70,9 @@ TO DO : */ #include "emu.h" + +#include "emupal.h" +#include "video/edevices.h" #include "includes/stlforce.h" #include "cpu/m68000/m68000.h"
[No CFG could be retrieved]
16 - bit of IN1 - 0100 - just rte region ethernet address map.
Please `#include` your module header `stlforce.h` immediately after `emu.h` and before other headers - this helps ensure that headers `#include` device headers they need.
@@ -0,0 +1,14 @@ +package org.infinispan.api; + +/** + * Entry point for Infinispan API - client for embedded + * + * @author Katia Aresti, karesti@redhat.com + * @since 10.0 + */ +@Experimental +public class InfinispanEmbedded { + public Infinispan newInfinispan(){ + throw new UnsupportedOperationException("emb...
[No CFG could be retrieved]
No Summary Found.
Is this client for embedded or just embedded mode?
@@ -68,6 +68,7 @@ export default class NavigateSectionListItem extends Component<Props> { className = 'navigate-section-tile-body'> { duration } </Text> + </Container> ); }
[No CFG could be retrieved]
navigate - section - tile - body.
Is NavigateSectionListItem specifically for calendar entries or do you know if it was intended to be something more general? It's markup makes it look like it was specific for calendar entries.
@@ -101,6 +101,7 @@ class box_factures_fourn_imp extends ModeleBoxes $sql .= " AND f.entity = ".$conf->entity; $sql .= " AND f.paye = 0"; $sql .= " AND fk_statut = 1"; + $sql .= " AND f.date_lim_reglement IS NOT NULL"; if (!$user->rights->societe->client->voir && !$user->socid) { $sql .= " AND s....
[box_factures_fourn_imp->[loadBox->[plimit,free,query,getNomUrl,error,trans,num_rows,hasDelay,fetch_object,jdate,getSommePaiement,LibStatut,load]]]
Load all the info boxes Diese un facture_fournisseur d un facture_f Ajoute un objeto Fonction This function returns the NomUrl of the object Adds a read permission not allowed to the box.
If an unpaid invoice has no dead line, it is always an unpaid invoice, isn't it ? So why discarding it ?
@@ -64,6 +64,8 @@ public class SparkDependencyContext { } public Dependency load(String lib) { + Console.println("DepInterpreter(%dep) deprecated. " + + "Load dependency through GUI interpreter menu instead."); Dependency dep = new Dependency(lib); if (dependencies.contains(dep)) {
[SparkDependencyContext->[fetch->[isDist,File,getGroupArtifactVersion,fetchArtifactWithDep,isLocalFsArtifact,add,getFile],addRepo->[add,Repository],fetchArtifactWithDep->[inferScalaVersion,setPolicy,setAuthentication,DependencyRequest,getArtifactResults,addRepository,classpathFilter,getExclusions,getGroupArtifactVersio...
Load a dependency.
Why do you use Console here? Isnt it LOG better? so you can print log like `LOG.warning('deprecated blablalba')`?
@@ -249,6 +249,8 @@ class Openmpi(AutotoolsPackage): default=False, description='Do not remove mpirun/mpiexec when building with slurm' ) + # Variants to use internal packages + variant('internal-hwloc', default=False, description='Use internal hwloc') provides('mpi') provides('...
[Openmpi->[setup_dependent_build_environment->[setup_run_environment],filter_rpaths->[filter_lang_rpaths],test->[_test_examples,_test_bin_ops,_test_check_versions]]]
Create a basic config that can be used to build a specific CUDA container. requires all of the dependencies on the objects.
Usually we try to avoid using vendored dependencies. Since Spack can't track them as node in the graph, it can't grant there won't be inconsistencies in the build. Is the situation somehow different here?
@@ -134,9 +134,10 @@ class TestConfig { return this.skip(this.runOnChrome); } - skipOldChrome() { + skipChromeDev() { return this.skip(() => { - return this.platform.isChrome() && this.platform.getMajorVersion() < 48; + return this.platform.isChrome() && + this.platform.getMajorVersion...
[No CFG could be retrieved]
Provides a list of predicate functions that are called before running each test suite. Adds a function to the list of functions to be skipped when the AMP is run on.
I assume it's guaranteed that the major version is incremented for every Chrome dev release?
@@ -39,6 +39,7 @@ import { } from './3p'; import {urls} from '../src/config'; import {endsWith} from '../src/string'; +import {parseJson} from '../src/json'; import {parseUrl, getSourceUrl, isProxyOrigin} from '../src/url'; import {dev, initLogConstructor, setReportError, user} from '../src/log'; import {dict} fr...
[No CFG could be retrieved]
Package that contains all of the functions that are used to create a new object. Package - level functions.
PR description calls this `jsonParse` while the import is called `parseJson`. I wonder if it's possible (or makes sense) to rename this to `jsonParse`, since it's more likely to show up in autocomplete when someone tries to type `JSON.parse` in an IDE.
@@ -116,9 +116,11 @@ namespace Content.Client.GameObjects.Components.Mobs return; } - Assignments.Reconcile(_ui.SelectedHotbar, ActionStates(), ItemActionStates()); + Assignments.Reconcile(_ui.SelectedHotbar, ActionStates(), ItemActionStates(), _ui.Locked); +#prag...
[ClientActionsComponent->[UpdateUI->[UpdateUI],HandleComponentState->[HandleComponentState],Shutdown->[Shutdown],HandleMessage->[HandleMessage],AfterActionChanged->[UpdateUI]]]
Updates the UI if the action is in a reserved state.
does this need to be done? it wasn't here before and no relevant code has been changed
@@ -53,7 +53,10 @@ class Shop(graphene.ObjectType): Geolocalization, description='Customer\'s geolocalization data.') authorization_keys = graphene.List( - AuthorizationKey, description='List of configured authorization keys.', + AuthorizationKey, + description='''List of con...
[Shop->[resolve_navigation->[Navigation],resolve_domain->[Domain],resolve_geolocalization->[Geolocalization]]]
A class that represents a single domain. Required. Description.
To be precise it's `OAuth2`
@@ -94,7 +94,7 @@ public class MetadataReportService { try { String interfaceName = providerUrl.getParameter(INTERFACE_KEY); if (StringUtils.isNotEmpty(interfaceName)) { - Class interfaceClass = Class.forName(interfaceName); + Class interfaceClass =Thread...
[MetadataReportService->[instance->[MetadataReportService]]]
Publish a provider.
I think this change is not appropriate, the Thread.currentThread().getContextClassLoader().loadClass may cause NullPointerException if calling Thread.currentThread().setContextClassLoader(null) first.
@@ -377,11 +377,15 @@ dtx_10(void **state) req.arg->expect_result = -DER_NONEXIST; punch_dkey_with_flags(dkey2, th, &req, DAOS_COND_PUNCH); - req.arg->expect_result = 0; - punch_dkey_with_flags(dkey, th, &req, DAOS_COND_PUNCH); - + /** Remove the test for the dkey because it can't work with client + * side cach...
[run_daos_dist_tx_test->[MPI_Barrier,run_daos_sub_tests,ARRAY_SIZE],void->[dtx_update_multiple_objs,dtx_handle_resent,daos_fail_loc_set,daos_tx_hdl2epoch,MPI_Barrier,assert_non_null,dts_oid_gen,dts_buf_render,punch_akey_with_flags,insert_single_with_flags,daos_mgmt_set_params,ioreq_fini,daos_tx_commit,skip,test_runable...
DTS - TX 10 punch_dkey_with_flags - punch akey with flags.
Before the subsequent tx_commit(), why "the dkey will have been removed by the akey punch above"? Which error you will hit if you keep punch_dkey_with_flags()?
@@ -2551,6 +2551,16 @@ class ArchiverTestCase(ArchiverTestCaseBase): assert int(csize) < int(size) assert sha256_before == sha256_after + def test_recreate_timestamp(self): + self.create_test_files() + self.cmd('init', '--encryption=repokey', self.repository_location) + archi...
[ArchiverCorruptionTestCase->[test_cache_files->[corrupt,cmd],setUp->[create_test_files,cmd],test_cache_chunks->[corrupt,cmd],test_chunks_archive->[corrupt,cmd],test_old_version_interfered->[cmd]],test_disk_full->[make_files,cmd],get_all_parsers->[discover_level->[discover_level],discover_level],RemoteArchiverTestCase-...
Test recreate of a node with a specific compression.
in case that timestamp is considered local time, please use something later to avoid an underflow in utc.
@@ -4,12 +4,10 @@ package engine import ( - "errors" "fmt" - "time" - "github.com/keybase/client/go/libkb" keybase1 "github.com/keybase/client/go/protocol/keybase1" + "time" ) type PGPPullEngineArg struct {
[Run->[runLoggedOut],runLoggedIn->[processUserWithIdentify,getTrackedUserSummaries]]
Package that contains all of the functions that are responsible for generating the proofs for a given getTrackedUserSummaries returns a list of user summaries that are tracked by the user.
Do we have a policy on import order? I.e. all standard library imports came before our own?
@@ -109,4 +109,14 @@ class Elgg_Notifications_Event { public function getDescription() { return "{$this->action}:{$this->object_type}:{$this->object_subtype}"; } -} \ No newline at end of file +} + +/** + * Notification event + * + * @package Elgg.Core + * @subpackage Notifications + * @since 1.9.0 + */...
[Elgg_Notifications_Event->[__construct->[getType,getSubtype,getGUID]]]
Get description of the object.
Couldn't we add a constructor that would trigger a deprecation warning and then call parent?
@@ -137,8 +137,7 @@ function prepareEntityForTemplates(entityWithConfig, generator) { : entityWithConfig.entityStateName ); - entityWithConfig.reactiveRepositories = - entityWithConfig.reactive && ['mongodb', 'cassandra', 'couchbase', 'neo4j'].includes(entityWithConfig.databaseType); + ...
[No CFG could be retrieved]
Creates a list of all the properties that can be used to create the entity. read relationships from the object.
I think (but probably in another PR since this once is quite big) that we should kill this `reactiveRepositories` config parameter, since it's now equivalent to `reactive`
@@ -75,7 +75,10 @@ public class ArrayContainsKudf implements Kudf { return jsonStringArrayContains(searchValue, (String) args[0]); } else if (args[0] instanceof Object[]) { return ArrayUtil.containsValue(searchValue, (Object[]) args[0]); + } else if (args[0] instanceof Collection) { + return ...
[ArrayContainsKudf->[jsonStringArrayContains->[matches]]]
Evaluates if the specified value is contained in the JSON array.
args[0] should always be either a List or a String
@@ -105,7 +105,12 @@ class WPSEO_Import_Settings { $this->path = $this->upload_dir['basedir'] . DIRECTORY_SEPARATOR . 'wpseo-import' . DIRECTORY_SEPARATOR; if ( ! isset( $GLOBALS['wp_filesystem'] ) || ! is_object( $GLOBALS['wp_filesystem'] ) ) { - WP_Filesystem(); + $url = wp_nonce_url( + self_admin_url(...
[WPSEO_Import_Settings->[import_options->[parse_option_group]]]
Determine the path to the wpseo - import file.
I am not a big fan of abbreviations and in our codebase we try to avoid them as far as possible. Can you change `$creds` into `$credentials`