patch
stringlengths
18
160k
callgraph
stringlengths
4
179k
summary
stringlengths
4
947
msg
stringlengths
6
3.42k
@@ -194,13 +194,17 @@ final class DeadlockDetectingFailOnTimeout extends Statement Thread stuckThread = null; long maxCpuTime = 0; for (Thread thread : threadsInGroup) { - if (thread.getState() == Thread.State.RUNNABLE) { + try { + thread.join(); long threadCpuTime = cpuTime(thr...
[DeadlockDetectingFailOnTimeout->[getStuckThreadException->[getStackTrace],CallableStatement->[call->[evaluate]],getStackTrace->[getStackTrace],getDeadlockedThreadsException->[getStackTrace]]]
Returns the thread that is stuck in the main thread group.
This doesn't make sense to me. If the thread is stuck and we are trying to `join()` it, we are stuck, too.
@@ -39,8 +39,14 @@ raw.annotations = mne.Annotations([0], [10], 'BAD') ############################################################################### # 1) Fit ICA model using the FastICA algorithm. - -# Other available choices are `infomax` or `extended-infomax` +# Other available choices are `picard`, `infomax` o...
[plot_overlay,create_eog_epochs,create_ecg_epochs,filter,dict,read_raw_fif,plot_sources,abs,plot,data_path,find_bads_eog,plot_components,average,ICA,find_bads_ecg,plot_scores,pick_types,fit,Annotations]
Fit the ICA model using the FastICA algorithm. 1. identify bad components by analyzing latent sources and analyzing bad components by.
double-backticks on these names
@@ -11,8 +11,6 @@ from pulp.devel.test_runner import run_tests PROJECT_DIR = os.path.dirname(__file__) subprocess.call(['find', PROJECT_DIR, '-name', '*.pyc', '-delete']) -# Check for style -config_file = os.path.join(PROJECT_DIR, 'flake8.cfg') # These paths should all pass PEP-8 checks paths_to_check = [ 's...
[call,dirname,run_tests,extend,join,exit]
Find and eradicate any existing. pyc files and then eradicate them. This is the entry point for the tests. It runs the tests in order to find the.
You've also assumed CWD by dropping this.
@@ -81,8 +81,17 @@ func (i *Image) Images(filterArgs string, filter string, all bool) ([]*types.Ima return result, nil } +// Docker Inspect. LookupImage looks up an image by name and returns it as an +// ImageInspect structure. func (i *Image) LookupImage(name string) (*types.ImageInspect, error) { - return nil,...
[SearchRegistryForImages->[Errorf],ImportImage->[Errorf],Commit->[Errorf],ExportImage->[Errorf],Images->[Reverse,GetImages,Errorf,Sort],ImageHistory->[Errorf],TagImage->[Errorf],ImageDelete->[Errorf],PushImage->[Errorf],PullImage->[Printf,Println,Update,Start,TempDir,String,Errorf,Wait,Command],LoadImage->[Errorf],Look...
Images returns a list of images that match the filterArgs filter and all.
Could just pass `name` to trace being - allows us to differentiate concurrent requests easily.
@@ -93,6 +93,14 @@ type Config struct { EnableAPI bool `yaml:"enable_api"` } +// Validate config and returns error on failure +func (cfg *Config) Validate() error { + if err := cfg.StoreConfig.Validate(); err != nil { + return errors.Wrap(err, "invalid storage config") + } + return nil +} + // RegisterFlags adds...
[Rules->[getLocalRules],newManager->[getOrCreateNotifier],ServeHTTP->[ServeHTTP],RegisterFlags->[RegisterFlags],loadRules->[ownsRule]]
RegisterFlags registers flags for the config. NotificationQueueCapacity - Number of queue for notifications to be sent to the Alertmanager.
Having to add extra methods to unrelated packages seems weird. I not a fan of this two-step validation pattern.
@@ -6,7 +6,8 @@ follow_cue: @boosted_article.organization&.tag_line || @boosted_article.organization&.tag_line %> <% end %> -<% if @suggested_articles.any? %> +<%# the pattern .present?/.each has the advantage of issuing only a single SQL query to load objects in memory %> +<% if @suggested_articles.pr...
[No CFG could be retrieved]
Renders the page with the necessary information for the given list of suggested articles.
you'll notice the pattern `.present?/.each` many times in this PR
@@ -81,6 +81,18 @@ class PlatformRepository extends ArrayRepository $php->setDescription('The PHP interpreter'); $this->addPackage($php); + if (PHP_DEBUG) { + $phpdebug = new CompletePackage('php-debug', $version, $prettyVersion); + $phpdebug->setDescription('The PHP int...
[PlatformRepository->[addPackage->[getName,findPackage,getDescription,getPrettyVersion,setDescription],initialize->[normalize,addPackage,buildPackageName,setExtra,info,setDescription,getVersion]]]
Initializes the package list. CompletePackage - Builds a complete package with all the packages that are available. Parses the output of a package and returns the version of the package. Adds a package to the list of packages that are not in the list of packages.
Are those consts available since php 5.3? I guess so as it's nothing new but I didn't find any docs on them.
@@ -522,6 +522,11 @@ module.exports = JhipsterServerGenerator.extend({ this.camelizedBaseName = _.camelize(this.baseName); this.slugifiedBaseName = _.slugify(this.baseName); this.lowercaseBaseName = this.baseName.toLowerCase(); + + this.mainClass = _.capital...
[No CFG could be retrieved]
Configuration of the application. The configuration for the jhipster package.
We need to do this check for angular app name ad well, currently we always append App to basename for that
@@ -468,3 +468,15 @@ ALLOWED_STYLES = ['text-align'] DEFAULT_MENUS = { 'top_menu_name': 'navbar', 'bottom_menu_name': 'footer'} + + +NOCAPTCHA = True + +ENABLE_RECAPTCHA = get_bool('ENABLE_RECAPTCHA', False) + +if 'RECAPTCHA_PUBLIC_KEY' in os.environ: + RECAPTCHA_PUBLIC_KEY = os.environ['RECAPTCHA_PUBLIC_...
[get_list->[strip,split],get_host->[get_current],get_currency_fraction,literal_eval,bool,int,_,parse,append,get_list,dirname,insert,get,getenv,config,setdefault,repr,join,normpath]
Default menu settings.
What's the downside of having `None` `RECAPTCHA_PUBLIC_KEY`? Shouldn't we preset some values for local development, or will it pass anyway?
@@ -17,6 +17,7 @@ import spack.cmd.common.arguments as arguments import spack.fetch_strategy as fs import spack.repo import spack.spec +from spack.cmd.test import has_test_method from spack.package import preferred_version description = 'get detailed information on a particular package'
[VariantFormatter->[lines->[default]],print_text_info->[section_title,version,padder,VariantFormatter,pad],info->[print_text_info]]
Creates a basic object. This method expands the column widths based on max line lengths of the header and variants.
If this function is used in multiple command, it might be better to move it in a core module (i.e. a module not starting with `spack.cmd`) and have both commands import that module.
@@ -17,7 +17,7 @@ def stun_socket( ): timeout = socket.gettimeout() socket.settimeout(2) - log.debug('Initiating STUN for %s:%s', source_ip, source_port) + log.debug('Initiating STUN', source_ip=source_ip, source_port=source_port) nat_type, nat = stun.get_nat_type( socket, source...
[stun_socket->[STUNUnavailableException,gettimeout,debug,getsockname,get_nat_type,settimeout,isinstance,warning],get_logger]
Initialize STUN connection with given network connection.
`structlog` doesn't accept *args in `printf()` style, you have to use `%` to concat the message or provide `kwargs` like you did here
@@ -638,6 +638,8 @@ class Addon(OnChangeMixin, ModelBase): file_tasks.hide_disabled_files.delay(addon_id=self.id) self.versions.all().update(deleted=True) + VersionReviewerFlags.objects.filter(version__addon=self).update( + pending_rejection=None) # The...
[AddonUser->[AddonUserManager],watch_disabled->[Addon],AddonManager->[valid->[get_queryset],get_base_queryset_for_queue->[get_queryset],get_pending_rejection_queue->[get_base_queryset_for_queue],__init__->[__init__],get_scanners_queue->[get_base_queryset_for_queue],get_mad_queue->[get_base_queryset_for_queue],id_or_slu...
Delete a single object from the database. Disable all files task or hide disabled files task.
Do we need something similar for addon disable, or is that handled a different way? (I guess the versions get disabled at that point and... somehow the flags get removed...?)
@@ -252,11 +252,11 @@ func renderFile(ctx *context.Context, entry *git.TreeEntry, treeLink, rawLink st } if ctx.Repo.CanEnableEditor() { - ctx.Data["CanEditFile"] = true + ctx.Data["CanEditFile"] = !ctx.Repo.Repository.IsArchived ctx.Data["EditFileTooltip"] = ctx.Tr("repo.editor.edit_this_file") } el...
[Dir,Size,Exists,ValidateCommitWithEmail,FindTopics,IsReadmeFile,ComposeMetas,GetCommitsInfo,SubTree,NotFoundOrServerError,Close,IsWriter,Redirect,HasPrefix,IsImageFile,HTML,ListEntries,Error,CanEnableEditor,GetTreeEntryByPath,GetOwner,NotFound,New,QueryInt,ToUTF8WithFallback,IsLessThan,Errorf,ParseInt,IsPDFFile,Type,T...
ToUTF8WithErr returns a string with content of the file as UTF - 8 encoded Home render repository home page.
Why not just change `ctx.Repo.CanEnableEditor` ?
@@ -212,6 +212,7 @@ func (c *Container) ContainerCreate(config types.ContainerCreateConfig) (types.C return types.ContainerCreateResponse{}, derr.NewRequestNotFoundError(fmt.Errorf("No command specified")) } + log.Printf("ContainerCreate config' = %+v", config) // Call the Exec port layer to create the contain...
[Containers->[NewErrorWithStatusCode,Join,Error,NewGetContainerListParams,WithAll,Errorf,GetContainerList],ContainerRestart->[NewErrorWithStatusCode,containerStop,Begin,End,Errorf,containerStart],ContainerUnpause->[Errorf],containerStart->[Commit,NewRequestNotFoundError,Warnf,NewCommitParams,StateChange,WithID,NewError...
ContainerCreate creates a container ContainerCreate creates a container create a container Container create handler.
This is redundant, no? Is this debug code?
@@ -0,0 +1,13 @@ +# frozen_string_literal: true + +module Api + module V1 + class MyModuleRepositoryRowSerializer < ActiveModel::Serializer + type :task_inventory_rows + attribute :id + attribute :repository_row_id, key: :inventory_row_id + attribute :my_module_id, key: :task_id + belongs_t...
[No CFG could be retrieved]
No Summary Found.
id is included by default, no need to specify it as attribute
@@ -125,6 +125,11 @@ func ReadManifest(file string) ([]map[string]string, error) { return manifest.Dashboards, nil } +func exitWithError(format string, a ...interface{}) { + fmt.Fprintf(os.Stderr, "ERROR: "+format+"\n", a) + os.Exit(1) +} + var indexPattern = false var quiet = false
[Dir,NewRequest,Close,Encode,Exit,WriteFile,Add,Put,Usage,GetValue,Errorf,Join,LoadFile,Unpack,Do,MkdirAll,Printf,Unmarshal,RemoveIndexPattern,String,StringToPrint,Parse,ReadAll,BoolVar]
decodeValue reads the object id from the input data and returns the object id. Reads a list of dashboards from a yaml file.
For a script like this you might want to try the `log` package. Just initialize it with `log.SetFlags(0)` at startup. Then you can use `log.Fatalf` which exits and you don't need to worry about newlines since it adds them.
@@ -9,6 +9,14 @@ Annict::Application.routes.draw do mount LetterOpenerWeb::Engine, at: '/low' end + if Rails.env.test? + # テスト実行時にDragonflyでアップロードした画像を読み込むときに呼ばれるアクション + get ':image_size/:image_path', + to: 'application#dummy_image', + image_size: /[0-9]+x[0-9]+c*/, + image_path: %r([0-9...
[admin?,authenticate,devise_scope,mount,lambda,draw,resources,member,root,post,require,resource,patch,devise_for,development?,delete,namespace,collection,get]
Initialize the routes View a single node.
Align the parameters of a method call if they span more than one line.
@@ -191,7 +191,9 @@ class TestCustomForms(FormRecognizerTest): poller = fr_client.begin_recognize_custom_forms(model.model_id, myfile, content_type=FormContentType.IMAGE_JPEG) form = poller.result() - self.assertEqual(form[0].form_type, "form-"+model.model_id) + self.assertEqual(form[0...
[TestCustomForms->[test_custom_form_multipage_labeled->[assertFormPagesHasValues,assertEqual,begin_training,read,result,items,open,assertIsNotNone,get_form_recognizer_client,begin_recognize_custom_forms],test_custom_form_multipage_vendor_set_labeled_transform->[callback->[append,prepare_form_result,_deserialize],assert...
Test custom form with labeled values.
Could also verify that `form[0].model_id == model.model_id` ?
@@ -115,6 +115,7 @@ namespace Content.Client.Voting } @new = true; + SoundSystem.Play(Filter.Local(), "/Audio/Effects/voteding.ogg"); // New vote from the server. var vote = new ActiveVote(voteId)
[VoteManager->[SetPopupContainer->[ClearPopupContainer],ClientOnRunLevelChanged->[Initialize,ClearPopupContainer]]]
Receive a vote data from the server. update popup data if any.
pretty sure this only plays the sound to the player that calls the vote, since you're using Filter.Local()
@@ -397,16 +397,6 @@ func (d *Distributor) Push(ctx context.Context, req *client.WriteRequest) (*clie continue } - metricName, _ := extract.MetricNameFromLabelAdapters(ts.Labels) - samples := make([]client.Sample, 0, len(ts.Samples)) - for _, s := range ts.Samples { - if err := validation.ValidateSample(d...
[AllUserStats->[AllUserStats],Stop->[Stop],sendSamples->[Push],MetricsForLabelMatchers->[forAllIngesters,MetricsForLabelMatchers],Push->[tokenForLabels,validateSeries,checkSample],UserStats->[forAllIngesters,UserStats],Validate->[Validate],LabelNames->[forAllIngesters,LabelNames],RegisterFlags->[RegisterFlags],LabelVal...
Push is the main entry point for the client. Do not call this directly. This function is called by the client to populate the request with the necessary information. This function is called by the client to process all the samples in the request.
What happened here? Don't we need this code?
@@ -93,7 +93,7 @@ def copy_variable_to_graph(org_instance, to_graph, scope=''): trainable, name=new_name, collections=collections, - validate_shape=False) + validate_shape=True) return new_var
[copy_variable_to_graph->[TypeError,append,as_default,Session,VariableV1,str,initialized_value,isinstance,items,get_collection,run,index],copy_op_to_graph->[TypeError,get_tensor_by_name,deepcopy,dict,append,copy_op_to_graph,_set_device,add_to_collection,_record_op_seen_by_control_dependencies,str,Operation,isinstance,i...
Copies a variable from one graph to another. Returns a copy of an Operation from another Graph and returns a copy of it from another Graph This function creates a new tensor or node_def based on the name of the node.
This change might break existing users. I think instead you should add a validate_shape argument to copy_variable_to_graph
@@ -79,8 +79,6 @@ func ConfigToFlags(kubeAPIServerConfig *kubecontrolplanev1.KubeAPIServerConfig) // request-timeout // runtime-config // service-account-api-audiences - // service-account-issuer - // service-account-key-file // service-account-max-token-expiration // stderrthreshold // storage-versions
[Write,Join,AuditFlags,SplitHostPort,SetIfUnset,Sprintf,TempFile,Name,StringKeySet,Close,List,WriteYAML,ArgsWithPrefix,ToFlagSlice]
missing - flags - flags - args - args - admission plugins AuditFlags provides a convenience method to set audit related flags.
this commit needs a proper `UPSTREAM: <carry>: ...` commit msg.
@@ -94,9 +94,7 @@ class AutotestRunJob < ApplicationJob else markus_address = host_with_port + Rails.application.config.action_controller.relative_url_root end - server_host = MarkusConfigurator.autotest_server_host server_path = MarkusConfigurator.autotest_server_dir - server_username = Mar...
[AutotestRunJob->[enqueue_test_run->[export_group_repo,repo_files_available?],perform->[enqueue_test_run]]]
Enqueue a single test run. Finds a node in the system that matches the given submission path. If no server is running.
Layout/AlignHash: Align the elements of a hash literal if they span more than one line.
@@ -1276,7 +1276,7 @@ if (zen_not_null($action)) { $zc_address_book_count_list = zen_get_customers_address_book($customer['customers_id']); $zc_address_book_count = $zc_address_book_count_list->RecordCount(); ?> - <td class="dataTableContent ...
[MoveNext,perform,bindVars,Execute,display_count,add_session,notify,display_links,RecordCount,format,infoBox,execute]
This function prints the group name of the customer. <?php Shows the information for a specific element in the table.
Looks like the final ` . </a>` that is added to all entries could come out of this line as well. This is based on considering that `TEXT_INFO_ADDRESS_BOOK_COUNT` contains the full html for the link, `TEXT_INFO_ADDRESS_BOOK_COUNT_SINGLE` doesn't contain any html and the mentioned content would be applied to whichever in...
@@ -209,9 +209,9 @@ class Conduit(Package): raise RuntimeError(msg) cmake_exe = cmake_exe.path - host_cfg_fname = "%s-%s-%s.cmake" % (socket.gethostname(), - sys_type, - spec.compiler) + ...
[Conduit->[create_host_config->[cmake_cache_entry]]]
This method creates a host - config file that specifies all of the options used to configure and Write cmake cache entries for a specific block of cmake block. write cmake cache entries for a specific object if spack generated conduit host - config file is not present return name of host.
Was this rename required? Or was it just cosmetic?
@@ -1392,7 +1392,7 @@ function PMA_countQueryResults( // "Showing rows..." message // $_SESSION['tmpval']['max_rows'] = 'all'; $unlim_num_rows = $num_rows; - } elseif ($is_select) { + } elseif ($is_select || $analyzed_sql_results['is_subquery']) { // c o u n t q u...
[PMA_getDefaultSqlQueryForBrowse->[addParam,addMessage],PMA_getNumberOfRowsAffectedOrChanged->[affectedRows,numRows],PMA_countQueryResults->[tryQuery,fetchValue],PMA_setColumnOrder->[getString,addJSON,isSuccess,setUiProp],PMA_handleQueryExecuteError->[isSuccess,addJSON],PMA_getHtmlForSqlQueryResults->[getDisplay],PMA_s...
count query results for a specific unknown key if count_query is not in the query it will be run the query and return the.
Even thought "SELECT COUNT(*) FROM (SELECT 1) AS TB" is a select query, the function PMA_SQP_analyze($arr) wasn't making the $is_select attribute is true for this query. To fix that, this line was added.
@@ -25,6 +25,9 @@ var KnownValidationExceptions = []reflect.Type{ reflect.TypeOf(&authorizationapi.IsPersonalSubjectAccessReview{}), // only an api type for runtime.EmbeddedObject, never accepted reflect.TypeOf(&authorizationapi.SubjectAccessReviewResponse{}), // this object is only returned, never accepted ref...
[TypeOf,PkgPath,Contains,PtrTo,KnownTypes,Errorf,HasSuffix]
TestCoverage tests the types of objects that are not expected to be returned. Types returns the types of the object.
These are all accepted, right? We POST them and they have a bunch of data.
@@ -204,6 +204,11 @@ def semantic_analyze_target(target: str, return [], analyzer.incomplete +def process_patches(graph: 'Graph', scc: List[str]) -> None: + for module in scc: + graph[module].semantic_analysis_apply_patches() + + def check_type_arguments(graph: 'Graph', scc: List[str], errors: E...
[semantic_analysis_for_scc->[process_top_levels,process_abstract_status,check_type_arguments,process_functions],process_top_levels->[list,all,semantic_analyze_target,pop,update,prepare_file,discard,reversed,clear],process_abstract_status->[calculate_abstract_status],semantic_analyze_target->[file_context,infer_decorato...
Check that the type arguments are valid.
I would add a motivational docstring explaining why we do mini-passes for one things, and patches for other. My understanding that there will be quite few tuple types in a typical program, but quite a lot instances, so we a make a traverser for the latter. Also there is an option to combine these two in a single type f...
@@ -64,7 +64,11 @@ class OpenidConnectAuthorizeForm end def ial2_requested? - ial == 2 + ial == 2 && !service_provider.liveness_checking_required + end + + def ial2_strict_requested? + ial == 22 || (ial == 2 && service_provider.liveness_checking_required) end def ialmax_requested?
[OpenidConnectAuthorizeForm->[validate_privileges->[ialmax_requested?,ial2_service_provider?,ial2_requested?],scopes->[ialmax_requested?,ial2_requested?],check_for_unauthorized_scope->[ial2_service_provider?,verified_at_requested?,ial2_requested?]]]
Checks if the IAL2 requested is requested or not.
I honestly think it would be worth it for us to migrate away from this int column into a varchar Failing that, can we make a constant for IAL2_STRICT_INT or something? Because 22 is not intuitive to me
@@ -192,6 +192,8 @@ public abstract class BaseCmd { public AlertService _alertSvc; @Inject public UUIDManager _uuidMgr; + @Inject + public AnnotationService annotationService; public abstract void execute() throws ResourceUnavailableException, InsufficientCapacityException, ServerApiExceptio...
[BaseCmd->[isDisplay->[isDisplay],getParamFields->[getAllFieldsForClass],getAllFieldsForClass->[getAllFieldsForClass]]]
Execute the task.
I would avoid injecting annotationservice in baseCmd, but instead inject only in relevant API cmd classes.
@@ -997,8 +997,9 @@ def _compute_covariance_auto(data, method, info, method_params, cv, cov_methods = [c.__name__ if callable(c) else c for c in method] runtime_infos, covs = list(runtime_infos), list(covs) my_zip = zip(cov_methods, runtime_infos, logliks, covs, estimators) - for this_method, runtime_...
[_undo_scaling_array->[_apply_scaling_array,_invert_scalings],regularize->[copy],_ShrunkCovariance->[score->[get_precision],fit->[fit],get_precision->[get_precision]],compute_whitener->[_get_whitener],_undo_scaling_cov->[_apply_scaling_cov,_invert_scalings],make_ad_hoc_cov->[Covariance],Covariance->[__iadd__->[_check_c...
Compute the covariance of a single node. fit the n - rank model with the n - ranks covariance. fit the n - rank model and return the log - likelihood of the missing objects.
why the variable name change? if it only lives in this scope. No need for this diff, change back both lines.
@@ -505,10 +505,9 @@ def generate_gitlab_ci_yaml(env, print_summary, output_file, if not custom_spack_ref: custom_spack_ref = 'master' before_script = [ - ('git clone "{0}" --branch "{1}" --depth 1 ' - '--single-branch'.format(custom_spack_repo, custom_spack_ref)), ...
[get_spec_dependencies->[_add_dependency],stage_spec_jobs->[remove_satisfied_deps,get_spec_dependencies],find_matching_config->[spec_matches],write_cdashid_to_mirror->[TemporaryDirectory],compute_spec_deps->[append_dep,spec_deps_key_label,get_spec_string],get_job_name->[is_main_phase],format_job_needs->[get_job_name],i...
Generate a gitlab - ci yaml file from the environment. Generate pipeline of all n - branch chains and tasks. Get a list of all necessary configuration objects for a single n - node node. Returns a dict of variables that can be used to build a single node.
@tgamblin @opadron This way of cloning made it impossible to provide a SHA rather than a named branch or tag. Yet I feel we need the ability to specify a SHA so that we can avoid situations like what happened recently with a `develop` pipeline, where a job later in the pipeline got something different because `develop`...
@@ -1860,11 +1860,15 @@ namespace Js Assert(segment != nullptr); const uint32 offset = segment->getDestAddr(); const uint32 size = segment->getSourceSize(); - if (offset > maxSize || UInt32Math::Add(offset, size) >= maxSize) + ...
[No CFG could be retrieved]
The next block of code for the next block of code. creates the functions that are needed by the module.
More a spec question, but I wonder if 0 size data segment should be considered compilation error?
@@ -239,8 +239,6 @@ func (repo *Repository) GetTags() ([]string, error) { return nil }) - version.Sort(tagNames) - // Reverse order for i := 0; i < len(tagNames)/2; i++ { j := len(tagNames) - i - 1
[GetAnnotatedTag->[getTag,GetTagType],GetTag->[getTag,GetTagID],GetTagInfos->[GetTag]]
GetTags returns a list of all tags in the repository sorted by tag name.
if we are removing sort above, then is this for loop needed?
@@ -17,6 +17,7 @@ require_once JETPACK__PLUGIN_DIR . '_inc/lib/admin-pages/class-jetpack-redux-sta * @package Automattic\Jetpack\Search */ class Jetpack_Search_Dashboard_Page extends Jetpack_Admin_Page { + const JETPACK_SEARCH_PLANS = array( 'jetpack_search', 'jetpack_complete' ); /** * Show the settings page...
[Jetpack_Search_Dashboard_Page->[get_page_hook->[get_link_offset,should_add_sub_menu],page_admin_scripts->[load_admin_scripts,load_admin_styles],render->[page_render]]]
Creates a page hook that creates a menu item and adds it to the admin menu. Renders the page with the .
Where is this used?
@@ -21,6 +21,6 @@ class AddressBookForm(forms.ModelForm): user_id=self.instance.user_id, alias=self.cleaned_data.get('alias') ).exclude(address=self.instance.address_id).exists(): self._errors['alias'] = self.error_class( - ['You are already using such alias for another...
[AddressBookForm->[clean->[error_class,filter,super]]]
Check if there is a duplicate alias for this user or if there is another alias for this.
Alias is a poor name for this field. I am not really sure we need the field at all (the UI does its best to always show you the full address).
@@ -50,6 +50,9 @@ __all__ = [ "TooManyRedirectsError", "ODataV4Format", "ODataV4Error", + "StreamConsumedError", + "StreamClosedError", + "ResponseNotReadError", ]
[ErrorMap->[get->[get]],ODataV4Format->[__init__->[get]],HttpResponseError->[__init__->[get]],AzureError->[__init__->[get]],map_error->[get],ODataV4Error->[__init__->[get]]]
Raise an exception with a specified traceback.
I've added the access errors of `azure.core.rest.HttpResponse` to azure.core.exceptions. I don't think I can mark this as provisional, do we want to add it to `azure.core.rest` first, and then eventually move it over to exceptions?
@@ -158,6 +158,15 @@ export class Xhr { user().assert(false, `Response must contain the` + ` ${ALLOW_SOURCE_ORIGIN_HEADER} header`); } + + // If the `AMP-Redirect-To` header is set. Redirect the user to the + // given URL. + const redirectTo = response.headers.get(REDIRECT_TO...
[No CFG could be retrieved]
Fetches a single object from the server and checks that the response contains the correct headers. Fetches a single from the AmpCors server.
Maybe wrap these two asserts and throw a single good custom error message?
@@ -71,6 +71,10 @@ public abstract class AbstractServerChannel extends AbstractChannel implements S throw new UnsupportedOperationException(); } + public EventLoopGroup getChildGroup() { + return childGroup; + } + private final class DefaultServerUnsafe extends AbstractUnsafe { ...
[AbstractServerChannel->[doDisconnect->[UnsupportedOperationException],newUnsafe->[DefaultServerUnsafe],DefaultServerUnsafe->[reject->[setFailure,UnsupportedOperationException],connect->[reject],write->[reject,release]],doWrite->[UnsupportedOperationException],ChannelMetadata]]
This method is called when a message is written to the channel.
`childEventLoopGroup()` might be better?
@@ -271,6 +271,11 @@ def test_ica_additional(): with warnings.catch_warnings(record=True): ica.fit(raw, picks=None, start=start, stop=stop2) + # test corrmap + ica2 = deepcopy(ica) + corrmap([ica, ica2], (0, 0), threshold=0.99, inplace=True) + assert_true(ica.labels["bads"] == ica2.labels["b...
[test_ica_reject_buffer->[Raw,_TempDir,set_log_file,dict,dirname,catch_warnings,assert_equal,assert_true,len,ICA,join,open,pick_types,fit],test_ica_twice->[Raw,catch_warnings,assert_equal,apply,ICA,pick_types,fit],test_run_ica->[Raw,run_ica,catch_warnings,product,slice,simplefilter],test_ica_full_data_recovery->[averag...
Test ICA functionality for additional ICA functionality fit a single ICA with a single sample of data read ICA data from the source file and check if there are no missing missing components. Best scoring for missing components.
what are the possible labels?
@@ -319,7 +319,7 @@ def display_data(opt): return (train_output.getvalue(), valid_output.getvalue(), test_output.getvalue()) -def display_model(opt) -> Tuple[str, str]: +def display_model(opt) -> Tuple[str, str, str]: """ Run display_model.py.
[skipIfCircleCI->[is_this_circleci],capture_output->[TeeStringIO],eval_model->[eval_model,capture_output],TeeStringIO->[write->[write]],download_unittest_models->[capture_output],display_model->[display_model,capture_output],display_data->[capture_output,display_data],train_model->[capture_output,tempdir],git_ls_dirs->...
Run display_model. py.
nit: in line below, return value is incorrect
@@ -93,7 +93,16 @@ public class I18n implements RootAction { String language = request.getParameter("language"); String country = request.getParameter("country"); String variant = request.getParameter("variant"); - + // https://www.w3.org/International/questions/qa-lang-priorities + ...
[I18n->[doResourceBundle->[getMessage,getBundle,okJSON,getLocale,getParameter,Locale,errorJSON]]]
Returns a resource bundle with the specified base name language country and variant.
I think you meant `language.length() >= 5`, right? See the following call to `substring` as it assumes the string is length 5.
@@ -190,7 +190,7 @@ def Print(input, message="The content of some_layer: ") ''' helper = LayerHelper('print', **locals()) - out = helper.create_tmp_variable(dtype=helper.input_dtype()) + out = helper.create_tmp_variable(dtype=helper.input_dtype(), stop_gradient=True) helper.append_op...
[Switch->[default->[ConditionalBlock,ConditionalBlockGuard],case->[ConditionalBlock,ConditionalBlockGuard]],IfElseBlockGuard->[__exit__->[__exit__],__enter__->[__enter__],__init__->[block]],DynamicRNN->[_parent_block_->[block],block->[array_write,block,increment,less_than,array_to_lod_tensor],static_input->[_assert_in_...
Print a single n - th element of a tensor. Returns the out object.
I think we shouldn't disable the ability of printing gradients.
@@ -887,6 +887,10 @@ class ICA(ContainsMixin): scores : np.ndarray of float, shape (``n_components_``) The correlation scores. + See also + -------- + find_bads_eog + References ---------- [1] Dammers, J., Schiek, M., Boers, F., Silex, C., Zvyagint...
[_find_sources->[get_score_funcs],run_ica->[fit,ICA,_detect_artifacts],get_score_funcs->[_make_xy_sfunc],ICA->[_pick_sources->[_get_fast_dot],_fit->[fit],_sources_as_evoked->[_transform_evoked],_apply_epochs->[_pre_whiten],_transform_raw->[_pre_whiten,_transform],_fit_epochs->[_reset],_transform_epochs->[_pre_whiten,_t...
This method is used to detect ECG related components using a cross - channel averaging. Missing node - level related information. This function returns the indices of the missing non - zero non - zero non - zero non.
might need to be `ICA.find_bads_eog`, did you check this one renders okay?
@@ -134,8 +134,7 @@ func NewAuthServer( public bool, requireNoncriticalServers bool, watchesEnabled bool, -) (APIServer, error) { - +) (*apiServer, error) { oidcStates := col.NewEtcdCollection( env.GetEtcdClient(), path.Join(oidcAuthnPrefix),
[SetConfiguration->[LogReq,LogResp],RestoreAuthToken->[LogResp],ModifyMembers->[LogReq,LogResp],GetRobotToken->[LogReq,LogResp],GetOIDCLogin->[LogReq,LogResp],isActive->[getClusterRoleBinding],expiredEnterpriseCheck->[getEnterpriseTokenState],deleteExpiredTokensRoutine->[DeleteExpiredAuthTokens],GetPermissionsForPrinci...
LogReq logs the request and response to the parent object. Return a list of all members and groups in the system.
Shouldn't this return an `auth.APIServer` (from `iface.go`)?
@@ -60,6 +60,8 @@ class SiteSettings(models.Model): company_address = models.ForeignKey( "account.Address", blank=True, null=True, on_delete=models.SET_NULL ) + # FIXME these values are configurable from email plugin. Not needed to be placed + # here default_mail_sender_name = models.CharF...
[SiteSettingsTranslation->[__repr__->[type],CharField,ForeignKey],AuthorizationKey->[ForeignKey,TextField,CharField],email_sender_name_validators->[RegexValidator,MaxLengthValidator],SiteSettings->[available_backends->[values_list],default_from_email->[str,ImproperlyConfigured,Address,parseaddr],CharField,email_sender_...
Required fields for creating a Header. Provides access to the name of the object in the site.
Do we have task for this?
@@ -352,7 +352,7 @@ define([ va.push({ va : this._context.createVertexArray(attributes, indexBuffer), - indicesCount : 1.5 * ((k !== (numberOfVertexArrays - 1)) ? sixtyFourK : (this._size % sixtyFourK)) + indicesCount : (typeof indicesCount =...
[No CFG could be retrieved]
The base class for all of the vertex array objects that can be indexed by a single index This method is called when a vertex buffer is not created.
I'm not sure that this improvement is general enough. It is still hardcoded to default to the billboard collection's specific needs. Perhaps we can move that logic out to the billboard collection?
@@ -26,10 +26,7 @@ import java.util.Map; import java.util.function.Function; public final class BytesUtils { - private static final Base64.Encoder BASE64_ENCODER = Base64.getMimeEncoder(); - private static final Base64.Decoder BASE64_DECODER = Base64.getMimeDecoder(); - - enum Encoding { + public enum Encoding ...
[BytesUtils->[encode->[from],getByteArray->[getByteArray],hexEncoding->[encode],hexDecoding->[decode],base64Decoding->[decode],decode->[from]]]
Creates a new instance of BytesUtils that converts a string into a base64 - encoded string Replies the encodings and decoders for the given .
Do any usages of these utils rely on or assume the MIME-based encoding? IIUC, the line breaks are used in that scheme in order to make the bytes more human-readable
@@ -1,4 +1,4 @@ -<% num_views = @articles.sum(&:page_views_count) %> +<% _num_views = @articles.sum(&:page_views_count) %> <div class="dashboard-analytics-header-wrapper"> <div class="dashboard-analytics-header">
[No CFG could be retrieved]
Displays a header showing the total number of non - negative reactions and a sub - indicator showing.
The underscores before the variable names can be removed now since we disabled the "unused variable assignment" cop for the views. Such variable names are used for the unused variables, so your fix is technically correct. But actually, the variables are used. So the cop seems to not work correctly and I've disabled it ...
@@ -34,6 +34,16 @@ #define engine_devcrypto_id "devcrypto" +/* + * Use session2_op on FreeBSD which permits requesting specific + * drivers or classes of drivers at session creation time. + */ +#ifdef CIOCGSESSION2 +typedef struct session2_op session_op_t; +#else +typedef struct session_op session_op_t; +#endif + ...
[No CFG could be retrieved]
ONE global file descriptor for all sessions. Get the status of the device cryptographic operation.
This is a bit gross. However, using an #ifdef in all the places that use `struct session_op` is also gross. Another alternative might be to define a local typedef (e.g. `session_op_t`) that is defined to either `struct session_op` or `struct session2_op`
@@ -90,8 +90,9 @@ def get_files_in_commit(git_folder, commit_id="HEAD"): return output.splitlines() def get_diff_file_list(git_folder): - """List of unstaged files. + """List of new files. """ repo = Repo(str(git_folder)) - output = repo.git.diff("--name-only") + repo.git.add("sdk") + o...
[checkout_create_push_branch->[checkout_and_create_branch],do_commit->[checkout_and_create_branch]]
Get list of files that are not in unstaged.
I really want to keep this file git generic, if you do a "git add" here you add side effect to a generic method, and this lib becomes unusable outside of the automation work
@@ -215,8 +215,16 @@ namespace Dynamo.Controls tab.Tag = viewExtension.GetType(); tab.HeaderTemplate = tabDynamic.FindResource("TabHeader") as DataTemplate; - // setting the extension window to the current tab content - tab.Content = contentControl.Conte...
[DynamoView->[DynamoView_Unloaded->[UnsubscribeNodeViewCustomizationEvents],OnCollapsedRightSidebarClick->[updateCollapseIcon],DynamoViewModelRequestShowPackageManagerSearch->[DisplayTermsOfUseForAcceptance],Log->[Log],WindowClosing->[PerformShutdownSequenceOnViewModel],OnCollapsedLeftSidebarClick->[updateCollapseIcon]...
Adds a tab item if the extension window is not added to the right - side bar.
`if (contentControl is UserControl)`, you can compare type directly?
@@ -102,6 +102,7 @@ public final class OmBucketInfo extends WithObjectID implements Auditable { * @param usedBytes - Bucket Quota Usage in bytes. * @param quotaInBytes Bucket quota in bytes. * @param quotaInNamespace Bucket quota in counts. + * @param bucketType Bucket Types. */ @SuppressWarnings("...
[OmBucketInfo->[removeAcl->[removeAcl],copyObject->[addAcl],toAuditMap->[isLink],Builder->[build->[OmBucketInfo]],getProtobuf->[setSourceVolume,build,setQuotaInNamespace,setSourceBucket],getFromProtobuf->[setSourceVolume,setObjectID,getFromProtobuf,setBucketEncryptionKey,getQuotaInNamespace,addAllMetadata,setQuotaInNam...
private constructor for OmBucketInfo. private class this.
typo: `Bucket Types.` -> `Bucket Type.`
@@ -423,8 +423,9 @@ func (c *RaftCluster) SetStorage(s *core.Storage) { c.storage = s } -// AddSuspectRegions adds regions to suspect list. -func (c *RaftCluster) AddSuspectRegions(ids ...uint64) { +// AddHighPriorityScheduleRegions adds regions to be scheduled with high priority. +// it implements HighPriority.Ad...
[GetClusterVersion->[GetClusterVersion],GetMaxMergeRegionSize->[GetMaxMergeRegionSize],IsMakeUpReplicaEnabled->[IsMakeUpReplicaEnabled],SetStoreState->[SetStoreState,GetStore],SetStoreLimit->[SetStoreLimit],IsLocationReplacementEnabled->[IsLocationReplacementEnabled],GetMergeScheduleLimit->[GetMergeScheduleLimit],OnSto...
SetStorage sets the storage for all suspect regions.
Does it need to be changed?
@@ -628,14 +628,6 @@ func GetDockerClient() (dockerhelper.Interface, error) { glog.Infof("DOCKER_CERT_PATH=%s", dockerCertPath) } } - // FIXME: Workaround for docker engine API client on OS X - sets the default to - // the wrong DOCKER_HOST string - if runtime.GOOS == "darwin" { - dockerHost := os.Getenv("DOC...
[Check->[printProgress],determineAdditionalIPs->[OpenShiftHelper],determineIP->[OpenShiftHelper,DockerHelper],Start->[printProgress],ClusterAdminKubeConfigBytes->[GetKubeAPIServerConfigDir]]
negotiate the correct API version with the server checkExistingOpenShiftContainer checks the state of an OpenShift container. If the container is.
@deads2k @csrwng seems like not needed anymore... this was confusing detection of "real" remote docker....
@@ -15,8 +15,8 @@ */ import * as Preact from './index'; -import {CanPlay, CanRender, LoadingProp} from '../contextprops'; -import {dev} from '../log'; +import {CanPlay, CanRender, LoadingProp} from './contextprops'; +import {devAssert} from '../core/assert'; import {rediscoverChildren, removeProp, setProp} from '...
[No CFG could be retrieved]
Creates a VNode that is a child of the given element. Provides a function to use for slot context.
These removes the only restricted dependencies, so this file was removed from the allowlist.
@@ -193,12 +193,9 @@ spring: <%_ } _%> <%_ if (searchEngine === 'elasticsearch') { _%> elasticsearch: - cluster-name: - cluster-nodes: localhost:9300 properties: path: - logs: <%= BUILD_DIR %>elasticsearch/log - ...
[No CFG could be retrieved]
cache configuration for missing cache entries Configuration of a specific application.
as this is a Spring Data Elasticsearch property, is this being used by Jest also?
@@ -78,6 +78,7 @@ class PostDestroyer def staff_recovered @post.recover! + recover_public_post_actions if @post.topic && !@post.topic.private_message? if author = @post.user
[PostDestroyer->[remove_associated_notifications->[delete_all],recover->[topic_id,trigger,deleted_at,update_statistics,find,staff?,log_topic_delete_recover,recover!,is_first_post?,user_id,slice,id],make_previous_post_the_last_one->[highest_post_number,created_at,last_post_user_id,topic,save!,user_id,first,present?,last...
This method is called when a user has seen a non - message record in the database that.
I think this needs to happens in the same transaction as `@post.recover!`.
@@ -43,6 +43,12 @@ class SRConverter(BaseFormatConverter): 'data_dir': PathField( is_directory=True, description="Path to folder, where images in low and high resolution are located." ), + 'lr_dir_suffix': StringField( + optional=True, description="Su...
[MultiTargetSuperResolutionConverter->[convert->[get_index->[],SuperResolutionAnnotation,list,ContainerAnnotation,append,replace,glob,format,items,ConverterReturn],parameters->[PathField,keys,update,super,format,join,StringField,DictField],configure->[Path,get,get_value_from_config,exists,ConfigError]],SRConverter->[co...
Returns a dictionary of configuration parameters for the class.
it is not present in the original dataset but used in some cases, please provide also opportunity to set directory for upsample images
@@ -186,6 +186,9 @@ def lcmv(evoked, forward, noise_cov, data_cov, reg=0.01, label=None, The regularization for the whitened data covariance. label : Label Restricts the LCMV solution to a given label + pick_ori : None | 'normal' + If 'normal', rather than pooling the orientations by ta...
[lcmv->[_apply_lcmv],lcmv_epochs->[_apply_lcmv],lcmv_raw->[_apply_lcmv]]
Linearly Constrained Minimum Variance on a given data.
option not explained here?
@@ -543,7 +543,16 @@ def ensure_executables_in_path_or_raise(executables, abstract_spec): b = _make_bootstrapper(current_config) try: if b.try_search_path(executables, abstract_spec): - return + # Additional environment variables needed + env_m...
[_config_path->[_root_path],get_executable->[_raise_error,spack_python_interpreter],ensure_bootstrap_configuration->[_bootstrap_config_scopes,spack_python_interpreter,_add_compilers_if_missing],gnupg_root_spec->[_root_spec],ensure_gpg_in_path_or_raise->[gnupg_root_spec,ensure_executables_in_path_or_raise],_store_path->...
Ensure that some executables are in path or raise a RuntimeError.
Can we avoid this duplicated load logic? It's not entirely correct as it adds environment modifications for build deps and their dependencies too, as I understand.
@@ -204,12 +204,14 @@ class BilinearSeqAttn(nn.Module): Wy = self.linear(y) if self.linear is not None else y xWy = x.bmm(Wy.unsqueeze(2)).squeeze(2) xWy.data.masked_fill_(x_mask.data, -float('inf')) + self.xWy = xWy if self.training: # In training we output log-s...
[weighted_avg->[unsqueeze],LinearSeqAttn->[forward->[linear,softmax,size,masked_fill_,float,view],__init__->[Linear,super]],StackedBRNN->[_forward_unpadded->[append,cat,transpose,range,dropout],forward->[_forward_unpadded,_forward_padded,sum],__init__->[append,super,ModuleList,rnn_type,range],_forward_padded->[list,sor...
Forward computation of the NLL - NLL.
just curious, why this change?
@@ -66,6 +66,7 @@ public class WebClientTracingFilter implements ExchangeFilterFunction { }) .doOnCancel( () -> { + TRACER.onCancel(span); TRACER.end(span); }); }
[WebClientTracingFilter->[addFilter->[addFilter,WebClientTracingFilter]]]
Filter the request using the last non - null response.
this call was accidentally lost during conversion from decorator to tracer
@@ -121,6 +121,12 @@ concretizer = DefaultConcretizer() #----------------------------------------------------------------------------- _config = spack.config.get_config('config') +# Check if user_config paths are enabled, add it to the config scope if it is. +if _config.get('user_config', True): + user_config_pa...
[editor_not_found->[EnvironmentError],expanduser,Executable,canonicalize_path,which,PackageTesting,join_path,RepoPath,die,set,get_config,append,cpu_count,FileCache,ABI,Version,DefaultConcretizer,get,ancestor,FsCache]
Initialize various data structures & objects at the core of Spack. Check if the is set in the configuration. If it is set to false sp.
I don't know enough about the internal workings of spack, but this may interfere with multiple people trying to access it at the same time. I'm not really sure which kind of information is stored in the misc-cache anyways, though...
@@ -681,7 +681,7 @@ USER bin`, BB) }) It("podman run device-read-bps test", func() { - SkipIfRootless("FIXME: Missing /sys/fs/cgroup/user.slice/user-14467.slice/user@14467.service/cgroup.subtree_control") + SkipIfRootless("FIXME: requested cgroup controller `io` is not available") SkipIfRootlessCgroupsV1("Se...
[Unlock,IsRootless,AddImageToRWStore,Hour,Now,Close,Setenv,Mkdir,GenerateNonCryptoID,Podman,PodmanSystemdScope,Exit,WriteFile,NumberOfContainers,ShouldNot,IsNotExist,PodmanExtraFiles,WaitWithDefaultTimeout,Itoa,CreateSeccompJson,Atoi,Should,Stat,ReadFile,To,Setup,UserOwnsCurrentSystemdCgroup,SeedImages,LookPath,Wait,Tr...
Expect - Wait until the command exits or the timeout expires. - > CgroupsV2 - > CGROUPSV2 - > CGROUPSV2.
This is the new error message as of this writing.
@@ -139,7 +139,6 @@ class Manager { } } - add_action( 'jetpack_clean_nonces', array( $this, 'clean_nonces' ) ); if ( ! wp_next_scheduled( 'jetpack_clean_nonces' ) ) { wp_schedule_event( time(), 'hourly', 'jetpack_clean_nonces' ); }
[Manager->[generate_secrets->[get_secret_callable],verify_secrets->[delete_secrets,get_secrets],sign_role->[get_access_token],xmlrpc_options->[is_active],jetpack_getOptions->[get_connected_user_data],is_registered->[is_active],set_min_time_limit->[get_max_execution_time],register->[api_url]]]
Setup XML - RPC handlers This is the main filter for all XML - RPC methods.
Should we move the `wp_next_scheduled()`/`wp_schedule_event()` calls up too?
@@ -5,7 +5,8 @@ import { __ } from "@wordpress/i18n"; import PropTypes from "prop-types"; /* Yoast dependencies */ -import { BaseButton } from "@yoast/components"; +import { Button } from "@yoast/components/src/button"; +import { ButtonStyledLink } from "@yoast/components"; /* Internal dependencies */ import { ...
[No CFG could be retrieved]
Creates a component that displays a modal with the related key phrases. Yoast related keyphrases modal.
Wondering whether these two imports can be merged in just one import. [Edit] I see now why this is necessary, maybe the related exports should be improved in the JS repo though.
@@ -86,15 +86,9 @@ const unminified3pTarget = 'dist.3p/current/integration.js'; const maybeUpdatePackages = isTravisBuild() ? [] : ['update-packages']; -// Used to start and stop the Closure nailgun server -let nailgunRunnerReplacer; -const nailgunRunner = - require.resolve('./third_party/nailgun/nailgun-runner...
[No CFG could be retrieved]
Creates a list of all the required AMP_CONFIG files. Provides a list of tasks that should be run when the nailgun starts.
Why do we need two ports?
@@ -197,9 +197,9 @@ AC_ARG_ENABLE(debug, AM_CONDITIONAL([NDEBUG], [test x"$debug" = x"no"]) if test x"$debug" = x"yes"; then - CFLAGS="$CFLAGS -g3 -O0 $ENV_CFLAGS" + CFLAGS="-g3 -O0 $CFLAGS" else - CFLAGS="$CFLAGS -O2 -DNDEBUG $ENV_CFLAGS" + CFLAGS="-O2 -DNDEBUG $CFLAGS" fi dnl ########################...
[No CFG could be retrieved]
- - - - - - - - - - - - - - - - - - necessary for some cases where pg_config is not available for native builds.
I believe these two need to stay. autoconf adds some automatic flags to CFLAGS whether you want it or not, and we want all our flags, whether from environment or not, to come after those.
@@ -183,12 +183,7 @@ class TaskTest(TaskTestBase): def _write_build_file(self): self.add_to_build_file( '', - ''' -files( - name = "t", - sources = ["{filename}"], -) -'''.format(filename=self._filename) + f'''\nfiles(\n name = "t",\n sources = ["{self._filename}"],\n)\n''' ) def ...
[TaskTest->[test_fingerprint_transitive->[_synth_fp],test_incremental->[_create_clean_file,_task,execute,_write_build_file,assertContent],test_execute_cleans_invalid_result_dirs->[_run_fixture],test_ignore->[_run_fixture,_cache_ignore_options],test_cache_hit_short_circuits_incremental_copy->[_toggle_cache,_create_clean...
Write a build file with a sequence of missing nodes.
Either remove triple quotes or restore multiline
@@ -45,8 +45,11 @@ export class RequestHandler { */ constructor(ampAnalyticsElement, request, preconnect, transport, isSandbox) { + /** @const {!../../../src/service/ampdoc-impl.AmpDoc} */ + this.ampdoc_ = ampAnalyticsElement.getAmpDoc(); + /** @const {!Window} */ - this.win = ampAnalyticsElement...
[No CFG could be retrieved]
A RequestHandler for AMP requests. The batch plugin that is being used.
while since you changed the analyticsElement to ampDoc in #expandPostMessage. Could you switch here as well.
@@ -291,10 +291,8 @@ migrate_pool_tls_destroy(struct migrate_pool_tls *tls) DP_UUID(tls->mpt_pool_uuid), tls->mpt_version); if (tls->mpt_pool) ds_pool_child_put(tls->mpt_pool); - if (tls->mpt_svc_list.rl_ranks) D_FREE(tls->mpt_svc_list.rl_ranks); - if (tls->mpt_done_eventual) ABT_eventual_free(&tls->m...
[No CFG could be retrieved]
insert the object under the container if it exists else insert it under the container if it does region MIGRATE_POOL_TLS Implementation.
More whitespace only changes.
@@ -37,6 +37,7 @@ public class WindowData { ) { this.start = start; this.end = end; + this.size = size(); this.type = Type.valueOf(requireNonNull(type, "type").toUpperCase()); }
[WindowData->[start,end,window,toUpperCase,toString,valueOf]]
List of window data.
why are we storing the size in a field, when we have a method to calculate it?
@@ -303,7 +303,7 @@ class Quantizer(Compressor): raise NotImplementedError('Quantizer must overload quantize_input()') - def _instrument_layer(self, layer, config): + def _wrap_modules(self, layer, config): """ Create a wrapper forward function to replace the original one. ...
[QuantGrad->[backward->[quant_backward]],Compressor->[detect_modules_to_compress->[LayerInfo],compress->[detect_modules_to_compress]],Pruner->[_instrument_layer->[new_forward->[calc_mask]],export_model->[detect_modules_to_compress]]]
Instrument a single layer. Get the last in the layer.
`_wrap_modules` is not a proper name for Quantizer, and it need to return a wrapper
@@ -156,6 +156,7 @@ createTask('e2e', e2e); createTask('firebase', firebase); createTask('get-zindex', getZindex); createTask('integration', integration); +createTask('init-bento-component', initBentoComponent); createTask('lint', lint); createTask('make-extension', makeExtension); createTask('performance', perfo...
[No CFG could be retrieved]
Create all the tasks. Create all of the tasks that are registered with the Nodos plugin.
Usability nit: The gulp task that creates boilerplate for a new extension is called `make-extension`. Maybe call this task `make-bento-component` for uniformity? (I have no strong preference here.)
@@ -91,8 +91,7 @@ export class AccessService { installStyles(this.win.document, $CSS$, () => {}); /** @const @private {boolean} */ - this.isExperimentOn_ = (isExperimentOn(this.win, EXPERIMENT) || - isDevChannel(this.win)); + this.isExperimentOn_ = true; const accessElement = document.ge...
[No CFG could be retrieved]
Provides a class which implements the AMP access system. Replies the URL replacements for the given window.
any reason why we're leaving the flag in? just temporary?
@@ -143,5 +143,13 @@ class UtilsTest extends PHPUnit_Framework_TestCase { ) ) ); } + public function testMaybePreviewEnv() { + if ( 0 === strncasecmp( 'WIN', PHP_OS, 3 ) ) { + $this->assertSame( 'cmd', Utils\maybe_prefix_env( 'cmd' ) ); + $this->assertSame( 'cmd', Utils\maybe_prefix_env( '/usr/bin/env cmd' ...
[UtilsTest->[testAssocArgsToString->[assertEquals],testGetSemVerWP->[assertEmpty,assertEquals],testParseStrToArgv->[assertEquals],testIncrementVersion->[assertEquals],testParseSSHUrl->[assertEquals],testGetSemVer->[assertEmpty,assertEquals]]]
This method is used to test if the passed assoc args are valid strings.
Conditions within tests are somewhat dangerous, because you can never be certain which tests are actually running. Should we allow for an environmental override in `is_windows()`, so we can have our tests cover both scenarios by setting the environmental variable?
@@ -0,0 +1,18 @@ +# frozen_string_literal: true + +class GobiertoBudgets::IndicatorsController < GobiertoBudgets::ApplicationController + before_action :load_year + + def index + end + + private + + def load_year + if params[:year].nil? + redirect_to gobierto_budgets_indicators_path(GobiertoBudgets::Search...
[No CFG could be retrieved]
No Summary Found.
Put empty method definitions on a single line.
@@ -1160,6 +1160,13 @@ namespace System.Net.Sockets { try { + if (_currentSocket!.SocketType != SocketType.Stream) + { + // With connectionless sockets, regular connect is used instead of ConnectEx, + // attempting to...
[SocketAsyncEventArgs->[SetupPinHandlesSendPackets->[FreePinHandles],FreeNativeOverlapped->[FreeNativeOverlapped],HandleCompletionPortCallbackError->[FreeNativeOverlapped],AllocateNativeOverlapped->[AllocateNativeOverlapped],SocketError->[FreeNativeOverlapped,SocketError,RegisterToCancelPendingIO,AllocateNativeOverlapp...
Finish operation connect.
@antonfirsov @scalablecory also give this condition some thought. Personally, I'm fine if CI passes. You may have a better understanding of what `SO_UPDATE_CONNECT_CONTEXT` does to decide if this is the most appropriate check.
@@ -66,7 +66,7 @@ public class PGPKeyRingImpl implements PGPKeyRing, Initialisable private void readPublicKeyRing() throws Exception { InputStream in = IOUtils.getResourceAsStream(getPublicKeyRingFileName(), getClass()); - PGPPublicKeyRingCollection collection = new PGPPublicKeyRingCollection(...
[PGPKeyRingImpl->[readPrivateKeyBundle->[hasNext,getKeyRings,getSecretKeys,getSecretKey,InitialisationException,next,StringBuilder,append,noSecretKeyFoundButAvailable,getResourceAsStream,getSecretKeyRingFileName,PGPSecretKeyRingCollection,getKeyID,getSecretAliasId,toString,close,getClass,valueOf],initialise->[getMessag...
read public key ring.
Move this thread safe instance to a constant.
@@ -123,7 +123,7 @@ public abstract class AbstractPoolMonitor extends AbstractNamedMonitor<PoolStatu * * @param monitor the monitor */ - public Validator(final AbstractPoolMonitor monitor) { + Validator(final AbstractPoolMonitor monitor) { this.monitor = monitor;...
[AbstractPoolMonitor->[Validator->[call->[checkPool]]]]
Check if a is available in the pool.
Same question about the `public` keyword removal here and in other spots...
@@ -1,9 +1,14 @@ <?php /** * @package Installer - * @copyright Copyright 2003-2013 Zen Cart Development Team + * @copyright Copyright 2003-2015 Zen Cart Development Team * @license http://www.zen-cart.com/license/2_0.txt GNU Public License V2.0 * @version $Id: */ -list($adminDir, $documentRoot, $adminServer, ...
[No CFG could be retrieved]
Missing node ID.
How about `if ($request_type=='SSL')`, since $request_type is already set in `application_top`
@@ -34,7 +34,7 @@ class PyNotebook(PythonPackage): depends_on('py-nbformat', type=('build', 'run')) depends_on('py-nbconvert', type=('build', 'run')) depends_on('py-ipykernel', type=('build', 'run')) - depends_on('py-ipykernel@5.1.0:', when='@4.2.0:', type=('build', 'run')) + depends_on('py-ipykern...
[PyNotebook->[depends_on,version]]
This function is used to register dependencies for all built - in modules. requires that all build - specific dependencies are available on the system.
This is required for both Python 2 and 3
@@ -130,9 +130,17 @@ class Order(ModelWithMetadata): related_name="orders", on_delete=models.SET_NULL, ) + collection_point = models.ForeignKey( + "warehouse.Warehouse", + blank=True, + null=True, + related_name="orders", + on_delete=models.SET_NULL, + ) ...
[OrderLine->[is_digital->[is_digital]],Order->[can_capture->[can_capture,get_last_payment],can_void->[can_void,get_last_payment],get_subtotal->[get_subtotal],can_refund->[can_refund,get_last_payment],update_total_paid->[save]]]
Model fields for related objects. Adding fields to the object that are used to store the details of a specific node in the.
I don't recall if we discussed it - do we somehow handle the case when a warehouse is deleted from the system, but it was selected as a collection point in some existing orders?
@@ -115,6 +115,12 @@ _t_default_settings_yml = Template(textwrap.dedent(""" <<: *visual_studio apple-clang: <<: *apple_clang + intel-cc: + version: ["2021.1", "2021.2", "2021.3"] + mode: ["icx", "classic", "dpcpp"] + libc...
[ConanClientConfigParser->[hooks->[_get_conf],logging_level->[get_item],request_timeout->[get_item],print_commands_to_output->[get_item],default_python_requires_id_mode->[get_item],cacert_path->[get_item],download_cache->[get_item],default_profile->[get_item],storage_path->[_get_conf],client_cert_path->[get_item],retry...
Return a list of all possible values of the n - tuple in the order of their creation Create a TANGO client configuration from a list of objects. DES d e fecture.
Do we want to model the runtime as the ``msvc`` more modern one? (dynamic/static)? Cause it is less confusing and it needs to keep in sync with build_type.
@@ -40,6 +40,9 @@ const ( // PurgeIncoming is used to clear a channel of bytes prior to handshaking func PurgeIncoming(conn net.Conn) { + if tracing { + defer trace.End(trace.Begin("")) + } buf := make([]byte, 255) // read until the incoming channel is empty
[Write,ReadFull,Add,Error,Infof,Sprintf,Debug,Compare,Begin,New,Now,Duration,Deadline,End,Errorf,Read,SetReadDeadline,Debugf]
PurgeIncoming is used to clear a channel of bytes prior to handshaking read the SYN - ACK and ACK from the connection.
BTW, you could modify `trace.newTrace`, make it public, and wrap this `if() { trace... }` in function with an appropriate skip (3 looks right).
@@ -59,6 +59,11 @@ public class KsqlRestConfig extends RestConfig { private static final String KSQL_WEBSOCKETS_NUM_THREADS_DOC = "The number of websocket threads to handle query results"; + public static final String COMMAND_RETRY_LIMIT_CONFIG = "command.retry.limit"; + private static final String COMMAN...
[KsqlRestConfig->[getKsqlConfigProperties->[getOriginals],getPropertiesWithOverrides->[getOriginals],getCommandConsumerProperties->[getPropertiesWithOverrides],getCommandProducerProperties->[getPropertiesWithOverrides]]]
Creates a config def for the command consumer and command topic. KsqlRestConfig constructor.
If not retrying indefinitely may cause servers to diverge, why are we making it configurable? :D
@@ -791,12 +791,12 @@ end # # if it does not exist # def create_test_repo(assignment) # # Create the automated test repository -# unless File.exists?(MarkusConfigurator.markus_config_automated_tests_repository) +# unless File.exist?(MarkusConfigurator.markus_config_automated_tests_repository) # ...
[run_ant_file->[short_identifier,system,each_line,new,exists?,cd,create,id,raise,pwd,now,join,close,parse_test_output,exitstatus,t,open,l],delete_test_repo->[exists?,markus_config_automated_tests_repository,rm_rf,repo_name,join],add_parser_file_link->[new,render,link_to_function,escape_javascript,t],export_repository->...
Create a repository for the test scripts and test support files. Create the automated test repository for the given assignment.
Line is too long. [85/80]
@@ -130,7 +130,7 @@ func NewLevelDb(g *GlobalContext, filename func() string) *LevelDb { Contextified: NewContextified(g), filename: path, dbOpenerOnce: new(sync.Once), - cleaner: newLevelDbCleaner(g, filepath.Base(path)), + cleaner: newLevelDbCleaner(NewMetaContext(context.TODO(), g), filepath...
[Discard->[Discard],OpenTransaction->[OpenTransaction],Nuke->[GetFilename,closeLocked],Get->[doWhileOpenAndNukeIfCorrupted],Delete->[doWhileOpenAndNukeIfCorrupted],Commit->[Commit],Lookup->[doWhileOpenAndNukeIfCorrupted],closeLocked->[Close,GetFilename],Stats->[doWhileOpenAndNukeIfCorrupted],nukeIfCorrupt->[isCorrupt,N...
Open implements LevelDB.
There are `NewMetaContextTODO(g)` and `NewMetaContextBackground(g)` functions btw
@@ -584,7 +584,9 @@ class User_Command extends \WP_CLI\CommandWithDBObject { $role = false; } elseif ( is_null( get_role( $role ) ) ) { WP_CLI::error( "Invalid role: $role" ); + $role = false; } + return $role; } }
[User_Command->[add_role->[add_role],remove_cap->[remove_cap],set_role->[set_role],add_cap->[add_cap],remove_role->[remove_role]]]
Validate a role.
Note that this line will never be reached, since `WP_CLI::error()` will stop the script.
@@ -86,7 +86,8 @@ class ResultRenderer(object): cv2.imshow("Action Recognition", frame) - if cv2.waitKey(1) & 0xFF == ord('q'): + key = cv2.waitKey(1) & 0xFF + if key == ord('q') or key == ord('Q') or key == 27: return -1
[ResultRenderer->[render_frame->[update_timers]],decode_output->[get]]
Renders the n - k tag in the frame. Initialize a sequence of n_frames missing - 1 in case of a wait key.
You can simplify this to `if key in {...}:`
@@ -27,6 +27,14 @@ * This example will override the normal action of `$exceptionHandler`, to make angular * exceptions fail hard when they happen, instead of just logging to the console. * + * <hr /> + * Note, that code executed in event-listeners (even those registered using jqLite's `on`/`bind` + * methods) doe...
[No CFG could be retrieved]
Catch all angular exceptions and log them to the console.
Perhaps add in the detail from @gkalpak that anything executed outside the AJS context will run into this issue...here's my quick edit: Note, code executed outside of the Angular context, most commonly DOM event listeners (even those registered using jqLite's `on`/`bind` methods), will not delegate exceptions to the {@...
@@ -64,11 +64,14 @@ define(function() { * @memberof LagrangePolynomialApproximation * */ - LagrangePolynomialApproximation.interpolateOrderZero = function(x, xTable, yTable, yStride) { + LagrangePolynomialApproximation.interpolateOrderZero = function(x, xTable, yTable, yStride, result) { + ...
[No CFG could be retrieved]
This function returns an array of interpolated values of the given number of non - zero Returns the LagrangePolynomialApproximation of the n - tuple.
I noticed while looking at this that the doc for this function is pretty wrong, as a result of evolution. It talks about a "specified degree" even though there isn't one. Up to you if you want to consider that part of this pull request.
@@ -1210,6 +1210,16 @@ static gboolean checker_button_press(GtkWidget *widget, GdkEventButton *event, self->gui_update(self); return TRUE; } + else if((event->button == 1) && + ((event->state & GDK_MOD1_MASK) == GDK_MOD1_MASK) && + (self->request_color_pick == DT_REQUEST_COLORPICK_MODULE...
[No CFG could be retrieved]
finds the correct target and source array for a given patch number - left while colour picking.
I'm wondering if this is the right option. Maybe we should also match the L channel to have the correct color and let user adjust if necessary? It seems easier this way than letting the user try to adjust the L channel to match the color.
@@ -580,12 +580,15 @@ public class MethodHandles { */ public MethodHandle findSpecial(Class<?> clazz, String methodName, MethodType type, Class<?> specialToken) throws IllegalAccessException, NoSuchMethodException, SecurityException, NullPointerException { nullCheck(clazz, methodName, type, specialToken); - ...
[No CFG could be retrieved]
Finds a special method handle. Check if the ac is valid.
I'm not sure I follow this logic. The specialToken could be a subclass of the accessClass. I would still expect it to have to be assignable in that case.
@@ -79,6 +79,7 @@ public abstract class ViewDescriptor extends Descriptor<View> { */ @Restricted(DoNotUse.class) public AutoCompletionCandidates doAutoCompleteCopyNewItemFrom(@QueryParameter final String value, @AncestorInPath ItemGroup<?> container) { + // TODO do we need a permissions check her...
[ViewDescriptor->[getDisplayName->[getDisplayName]]]
This method is used to copy a new item from a top - level item group to another.
@daniel-beck IMO, yes. `Item.CREATE`
@@ -49,13 +49,16 @@ func newConfigLsCmd() *cobra.Command { return getConfig(stackName, key) } - return listConfig(stackName) + return listConfig(stackName, showSecrets) }), } lsCmd.PersistentFlags().StringVarP( &stack, "stack", "s", "", "Target a specific stack instead of all of this proje...
[Value,ExactArgs,Secure,Wrap,HasPrefix,Strings,RunFunc,StringVarP,Errorf,AddCommand,Contains,QName,ParseModuleMember,NewSecureValue,NewValue,Printf,Sprintf,EncryptValue,RangeArgs,String,ModuleMember,MaximumNArgs,PersistentFlags]
NewConfigCmd returns a Command instance for the new command NewConfigTextCmd returns a command to set a specific stack s configuration key.
This is probably fine. But I imagine we'll want all of our flag descriptions to be complete sentences? e.g. ending with a period?
@@ -3,6 +3,15 @@ class RepositorySnapshotDatatableService < RepositoryDatatableService private + def create_columns_mappings + index = @repository.default_columns_count + @mappings = {} + @repository.repository_columns.order(:parent_id).each do |column| + @mappings[column.id] = index.to_s + in...
[RepositorySnapshotDatatableService->[process_query->[sort_rows,fetch_rows,preload,build_conditions],build_sortable_columns->[times],fetch_rows->[group,repository_rows,or,where_attributes_like,where,each,present?,count]]]
Process query missing key exception.
What happens if column is no longer in original repository.
@@ -33,12 +33,13 @@ Translations *g_client_translations = &client_translations; void Translations::clear() { m_translations.clear(); + m_plural_translations.clear(); } const std::wstring &Translations::getTranslation( const std::wstring &textdomain, const std::wstring &s) { - std::wstring key = textdomain +...
[clear->[clear],wstring->[at,wide_to_utf8],loadTranslation->[trim,append,resize,str_starts_with,str_split,utf8_to_wide,wide_to_utf8,str,empty,good,length,put]]
This method is called by the translation system when a translation is found in the translations table.
Is this an optimization to avoid constructing another string object?
@@ -143,11 +143,13 @@ function getToggleThumbColor(props) { const getToggleCheckMarkStyles = props => { const {$checked, $theme, $disabled} = props; const {animation, colors} = $theme; + const backgroundColor = $disabled ? colors.mono500 : 'white'; + const toggleThumbColor = getToggleThumbColor(props); cons...
[No CFG could be retrieved]
A component that renders a check mark. Config for the missing color color.
use `colors.white` instead of a `'white'` string