patch stringlengths 18 160k | callgraph stringlengths 4 179k | summary stringlengths 4 947 | msg stringlengths 6 3.42k |
|---|---|---|---|
@@ -288,7 +288,8 @@ public class ActivityTrackingController implements Closeable {
}
// Write the batch..
- jsonDB.update("/activity", Json.writer().writeValueAsBytes(batch));
+// jsonDB.update("/activity", Json.writer().writeValueAsBytes... | [ActivityTrackingController->[dbGet->[dbGet],watchLog->[watchLog],schedule->[schedule]]] | Process the event queue until the queue is empty or until the current thread is stopped. | so if I understand correctly, you are inserting directly into the DB here, bypassing jsondb. Wouldn't it make more sense to add a 'writeActivities()' method to jsondb and call it ? This would free this class from having internal knowledge of jsondb table structure and handling. |
@@ -222,6 +222,17 @@ class PythonPackage(PackageBase):
self.setup_py('install', *args)
+ rpaths = []
+ rpaths.append(spec.prefix)
+ for d in spec.dependencies(deptype=('link', 'run')):
+ if re.match('^py-', d.name):
+ rpaths.append(d.prefix)
+
+ mkdirp(... | [PythonPackage->[install->[setup_py],sdist->[setup_py],_setup_command_available->[setup_file,python],build_scripts->[setup_py],register->[setup_py],setup_py->[setup_file,python],upload->[setup_py],install_headers->[setup_py],build_ext->[setup_py],check->[setup_py],build_py->[setup_py],bdist->[setup_py],bdist_dumb->[set... | Install everything from build directory. | is this sufficient for all python dependencies? There are packages which do `extends('python')` but are not named `py-` |
@@ -41,6 +41,10 @@ export type DefaultPropsT = {
};
export type PropsT = {
+ /** Id of element which contains a related caption */
+ 'aria-describedby'?: string,
+ /** Id of element which contains a related error message */
+ 'aria-errormessage'?: string,
/** Component or String value for label of checkbox. ... | [No CFG could be retrieved] | Props for a group of checkboxes. Passed to the native OS when creating a checkmark. | should we add it to the TS definitions too? |
@@ -156,7 +156,7 @@ func (c *defaultControl) ScheduleShoot(ctx context.Context, obj *gardencorev1bet
}
schedulerLogger.Infof("Shoot '%s' (Cloud Profile '%s', Region '%s') successfully scheduled to seed '%s' using SeedDeterminationStrategy '%s'", shoot.Name, shoot.Spec.CloudProfileName, shoot.Spec.Region, seed.Nam... | [reconcileShootKey->[Infof,ScheduleShoot,SplitMetaNamespaceKey,Shoots,IsNotFound,Get,Debugf],ScheduleShoot->[NewAlreadyScheduledError,DeepCopy,Infof,Sprintf,NewFieldLogger,GardenCore,TryUpdateShoot,reportSuccessfulScheduling,reportFailedScheduling,WithField],reportSuccessfulScheduling->[reportEvent],reportFailedSchedul... | ScheduleShoot schedules a shoot This function is called when a shoot is successfully scheduled. | Why did you remove this event? I think it makes sense to keep it, just like the `Scheduled` event from the `kube-scheduler`. |
@@ -226,7 +226,7 @@ def _determine_eq_order(ctx: 'mypy.plugin.ClassDefContext') -> bool:
order = eq
if eq is False and order is True:
- ctx.api.fail("eq must be True if order is True", ctx.reason)
+ ctx.api.fail('eq must be True if order is True', ctx.reason)
return order
| [_analyze_class->[expand_typevar_from_subtype,deserialize],_attribute_from_auto_attrib->[Converter,Attribute],_parse_converter->[Converter,_parse_converter],_add_init->[argument],_attribute_from_attrib_maker->[Attribute],Attribute->[serialize->[serialize],deserialize->[Converter,Attribute]],attr_class_maker_callback->[... | Determines the effective order of a based on the arguments passed to the decorator. | You could undo this quote change but I don't feel strongly |
@@ -4580,7 +4580,7 @@ namespace DotNetNuke.Services.Upgrade
bool settingIsSecure = false;
if ((secureAttrib != null))
{
- if (secureAttrib.Value.ToLower() == "true")
+ if (secureAttrib.Value.... | [Upgrade->[UpgradeToVersion520->[AddModuleDefinition,AddModuleToPage,AddModuleControl,GetModuleDefinition],UpgradeToVersion720->[AddModuleDefinition,AddModuleControl,Upgrade],UpgradeToVersion600->[RemoveModuleControl,AddIconToAllowedFiles,FavIconsToPortalSettings,AddDefaultModuleIcons,GetModuleDefinition,RemoveModule,A... | Initialise the host settings from the template.
- > any. | Please use `String#Equals(String, StringComparison)` |
@@ -476,13 +476,6 @@ int DTLSv1_listen(SSL *s, BIO_ADDR *client)
return -1;
}
- /*
- * We only peek at incoming ClientHello's until we're sure we are going to
- * to respond with a HelloVerifyRequest. If its a ClientHello with a valid
- * cookie then we leave it in the BIO for accept to h... | [No CFG could be retrieved] | This function is called when a client receives a new message and the server receives a new message Reads an array of bytes from the init buffer. | Since you remove all users of BIO_CTRL_DGRAM_SET_PEEK_MODE, should we get rid of it too? Though, I don't whether BIO_CTRL_DGRAM_SET_PEEK_MODE is part of the public visiable ABI. |
@@ -1,4 +1,8 @@
module ApplicationHelper
+ def impactful_shell_version
+ 0
+ end
+
def user_logged_in_status
user_signed_in? ? "logged-in" : "logged-out"
end
| [cloudinary->[exclude?,development?,blank?,positive?],view_class->[action_name],org_bg_or_white->[bg_color_hex],user_colors_style->[darker_color],icon_url->[fetch],cloud_cover_url->[call],title_with_timeframe->[fetch,title,blank?],cache_key_heroku_slug->[blank?],sanitize_rendered_markdown->[html_safe,sanitize,new],curr... | Returns the nag - status string for the user. | is this effectively our version control for the shell version? in other words, am i right in assuming that, in order to change the shell, you'd need to go into the code and increment this? |
@@ -125,11 +125,11 @@ export default class MetaDescriptionLengthAssessment extends Assessment {
}
if ( descriptionLength > this._config.maximumLength ) {
- return i18n.sprintf(
+ return sprintf(
/* Translators: %1$s and %2$s expand to links on yoast.com, %3$s expands to the anchor end tag,
%4$d ex... | [No CFG could be retrieved] | Displays the meta description of a block tag. | This should be a single line string, ideally with arguments on their own lines. |
@@ -121,12 +121,12 @@ module Email
incoming_email
end
- def ensure_valid_address_lists
+ def self.ensure_valid_address_lists(mail)
[:to, :cc, :bcc].each do |field|
- addresses = @mail[field]
+ addresses = mail[field]
if addresses&.errors.present?
- @mail[fiel... | [Receiver->[extract_from_zimbra->[to_markdown],find_related_post->[sent_to_mailinglist_mirror?],find_or_create_user!->[find_or_create_user],extract_from_exchange->[to_markdown],attachments->[is_allowed?],extract_from_outlook->[to_markdown],extract_from_apple_mail->[to_markdown],embedded_email_raw->[fix_charset],to_mark... | Finds an existing message_id and updates it if it is missing. | If that methods is changing `mail`, it should end with a `!` to indicate it has side effects |
@@ -173,6 +173,12 @@ func (s *balanceRegionScheduler) Schedule(cluster opt.Cluster) []*operator.Opera
schedulerCounter.WithLabelValues(s.GetName(), "region-hot").Inc()
continue
}
+ // Check region whether have leader
+ if region.GetLeader() == nil {
+ log.Debug("region have no leader", zap.String("... | [Schedule->[GetName],EncodeConfig->[EncodeConfig],transferPeer->[GetName]] | Schedule returns a list of operators that can be used to schedule a balance region. This function is used to select a region from the cluster and transfer it to the other region. | it may be `warn`? |
@@ -128,10 +128,6 @@ public abstract class AbstractWebServiceOutboundGateway extends AbstractReplyPro
}
}
- public void setReplyChannel(MessageChannel replyChannel) {
- this.setOutputChannel(replyChannel);
- }
-
/**
* Specify whether empty String response payloads should be ignored.
* The default is <co... | [AbstractWebServiceOutboundGateway->[onInit->[onInit],setMessageFactory->[setMessageFactory],RequestMessageCallback->[doWithMessage->[doWithMessage]],setMessageSender->[setMessageSender],setMessageSenders->[setMessageSenders],setFaultMessageResolver->[setFaultMessageResolver],setInterceptors->[setInterceptors],prepareU... | Set the uri variable expressions. | While I understand why you did this, it seems like an unnecessary breaking change - at the very least it needs to be added to the migration guide. |
@@ -463,7 +463,13 @@ def find_events(raw, stim_channel=None, verbose=None, output='onset',
the first.
min_duration : float
The minimum duration of a change in the events channel required
- to consider it as an event (in seconds).
+ to consider it as an event (in seconds). By default... | [_find_events->[_find_stim_steps],read_events->[pick_events,_read_events_fif],find_stim_steps->[_find_stim_steps],find_events->[_find_events]] | This function finds events in a sequence of events in a stimulated time series or a stim Find events at a specific node in a stim channel. | this is not true anymore. |
@@ -1,8 +1,8 @@
package io.quarkus.elytron.security.oauth2.runtime.auth;
-import io.undertow.security.idm.Credential;
+import io.quarkus.elytron.security.runtime.UndertowTokenCredential;
-public class Oauth2Credential implements Credential {
+public class Oauth2Credential implements UndertowTokenCredential {
... | [No CFG could be retrieved] | package io. quarkus. security. oauth2. runtime. auth. Credential. | Just noticed that in both cases the package name is linked to Undertow. Will it work too on top of VertX (with all the latest HTTP related changes) ? Will I open an issue to follow up on this one ? |
@@ -382,6 +382,11 @@ class Database(object):
desc='database')
self._data = {}
+ # For every installed spec we keep track of its install prefix, so that
+ # we can answer the simple query whether a given path is already taken
+ # before installing a differ... | [InstallRecord->[install_type_matches->[canonicalize],from_dict->[InstallRecord],__init__->[_now]],ForbiddenLock->[__getattribute__->[ForbiddenLockError]],InstallStatuses->[InstallStatus],Database->[_read_from_file->[from_dict,invalid_record,check,_read_spec_from_dict,_assign_dependencies,to_dict],query_one->[query],_w... | Initialize a new Database object. Initialize the object with a missing node - key exception. Set the _write_transaction_impl _read_transaction_impl and _record_. | Can you call this `self._installed_prefixes`? |
@@ -223,9 +223,11 @@ def to_pil_image(pic, mode=None):
pic = np.expand_dims(pic, 2)
npimg = pic
- if isinstance(pic, torch.FloatTensor) and mode != 'F':
+ if pic.is_floating_point() and mode != 'F':
pic = pic.mul(255).byte()
if isinstance(pic, torch.Tensor):
+ if pic.devic... | [resized_crop->[resize,crop],adjust_brightness->[adjust_brightness],vflip->[vflip],five_crop->[_get_image_size,center_crop,crop],pad->[pad],crop->[crop],adjust_gamma->[adjust_gamma],resize->[resize],center_crop->[_get_image_size,crop],adjust_saturation->[adjust_saturation],adjust_hue->[adjust_hue],scale->[resize],to_te... | Convert a torch. Tensor or np. ndarray to PIL Image. - The base Reads a sequence of images from a 1D array. | This breaks support for `np.ndarray` as it doesn't have support for `is_floating_point` |
@@ -162,10 +162,9 @@ public class YarnHelixUtils {
* Get environment variables in a {@link java.util.Map} used when launching a Yarn container.
*
* @param yarnConfiguration a Hadoop {@link Configuration} object carrying Hadoop/Yarn configuration properties
- * @param config a {@link Config} object carryin... | [YarnHelixUtils->[getAppWorkDirPath->[Path,toString,getHomeDirectory],getHostname->[getHostName],writeTokenToFile->[Credentials,getService,addToken,writeTokenStorageFile],addFileAsLocalResource->[getName,getModificationTime,setType,getLen,getFileStatus,setResource,newRecord,setVisibility,put,setSize,setTimestamp,getYar... | Get environment variables. | This change is causing build failure. |
@@ -1354,6 +1354,7 @@ namespace ProtoScript.Runners
HandleWarnings();
}
+
/// <summary>
/// Handle warnings that will be reported to the frontend
/// </summary>
| [LiveRunner->[CompileAndExecute->[Compile,Execute],ApplyUpdate->[Execute,ApplyUpdate,ForceGC],Execute->[ReInitializeLiveRunner,SetupRuntimeCoreForExecution],CompileAndExecuteForDeltaExecution->[ResetForDeltaExecution,CompileAndExecute,PostExecution],SynchronizeInternal->[ResetForDeltaExecution,Apply,CompileAndExecuteFo... | This method is called after the execution of the method. | I think we should just revert this file. |
@@ -153,6 +153,9 @@ type ProgramTestOptions struct {
ExpectRefreshChanges bool
// SkipRefresh indicates that the refresh step should be skipped entirely.
SkipRefresh bool
+ // SkipStackRemoval indicates that the stack should not be removed. (And so the test's results could be inspected
+ // in the Pulumi Service ... | [testLifeCycleDestroy->[GetStackNameWithOwner,GetDebugUpdates,runPulumiCommand],testEdit->[previewAndUpdate,query],testPreviewUpdateAndEdits->[GetDebugUpdates,runPulumiCommand],prepareNodeJSProject->[runYarnCommand],pipenvCmd->[getPipenvBin],performExtraRuntimeValidation->[GetStackName,runPulumiCommand],copyTestToTempo... | Checks if a given resource is in the target cloud and if it does it will be run StackName allows to be explicitly prohibited. | Not pushing back on adding this, but did you intend to use it anywhere? |
@@ -96,7 +96,7 @@ def dagpath():
return os.path.expanduser('~/.ethash/full-R23-0000000000000000')
-@pytest.fixture(scope='session', autouse=True)
+@pytest.fixture(autouse=True)
def pregenerate_dag(request, blockchain_type, dagpath):
missing_dag = (
not os.path.exists(dagpath) or
| [blockchain_backend->[genesis_path_from_testfunction],cached_genesis->[_token_addresses],token_addresses->[_token_addresses],blockchain_services->[cached_genesis]] | Generate a DAG if it doesn t exist. | Why did you remove the `session` scope here? |
@@ -147,6 +147,10 @@ public class GcsClient {
return actorTableData.getNumRestarts() != 0;
}
+ public byte[] getActorAddress(ActorId actorId) {
+ return globalStateAccessor.getActorAddress(actorId);
+ }
+
public JobId nextJobId() {
return JobId.fromBytes(globalStateAccessor.getNextJobID());
}
| [GcsClient->[getAllPlacementGroupInfo->[getAllPlacementGroupInfo],getNodeToConnectForDriver->[getNodeToConnectForDriver],getPlacementGroupInfo->[getPlacementGroupInfo],getInternalKV->[getInternalKV],getAllNodeInfo->[getAllNodeInfo]]] | Returns true if the given actor was currently restarted. | I wanted to use the existing getActorInfo method and extract the actor rpc address. But I couldn't find how to use it in JNI. Any suggestions? |
@@ -143,7 +143,17 @@ class Dataset:
# Finally, we combine the arrays that we got for each instance into one big array (or set
# of arrays) per field.
for field_name, field_array_list in field_arrays.items():
- if isinstance(field_array_list[0], (list, tuple)):
+ if isins... | [Dataset->[as_arrays->[get_padding_lengths],get_padding_lengths->[get_padding_lengths]]] | This method converts this dataset into a set of numpy arrays that can be used to fill in This method checks whether we were a given a max length for a particular field and padding The type of the field array is not a type but it s a type of the array. | I kind of think we should remove this possibility. Any one `Field` should just return one array, except for `TextField`. |
@@ -50,8 +50,8 @@ class TestPretrainedTransformerTokenizer(AllenNlpTestCase):
",",
"[MASK]",
"Allen",
- "##NL",
- "##P",
+ "NL",
+ "P",
"sentence",
".",
"[SEP]",
| [TestPretrainedTransformerTokenizer->[test_intra_word_tokenize->[intra_word_tokenize_sentence_pair,intra_word_tokenize,PretrainedTransformerTokenizer,split],test_token_idx_bert_uncased->[PretrainedTransformerTokenizer,tokenize],test_from_params_kwargs->[from_params,Params],test_token_idx_roberta->[PretrainedTransformer... | Test splits cased BERT. | Why were these wrong? |
@@ -579,8 +579,9 @@ public class HadoopDruidIndexerConfig
public void verify()
{
Preconditions.checkNotNull(schema.getDataSchema().getDataSource(), "dataSource");
+ Preconditions.checkNotNull(schema.getDataSchema().getParser(), "inputRowParser");
Preconditions.checkNotNull(schema.getDataSchema().getP... | [HadoopDruidIndexerConfig->[getIndexSpec->[getIndexSpec],fromFile->[fromMap],isLogParseExceptions->[isLogParseExceptions],makeIntermediatePath->[getDataSource,getWorkingPath],verify->[getDataSource,getGranularitySpec,getWorkingPath],isOverwriteFiles->[isOverwriteFiles],setShardSpecs->[getPathSpec],fromConfiguration->[f... | Checks that all required fields are set. | Checking this one for null seems redundant |
@@ -203,7 +203,7 @@ func (d *Delegator) updateLocalState(linkid LinkID) (err error) {
return d.Me.localDelegateKey(d.NewKey, d.sigID, d.getExistingKID(), d.IsSibkey(), d.isEldest)
}
-func (d Delegator) post(lctx LoginContext) (err error) {
+func (d *Delegator) post(lctx LoginContext) (err error) {
var pub string... | [Run->[CheckArgs],updateLocalState->[getExistingKID,IsSibkey],post->[getSigningKID]] | updateLocalState updates the local state of the delegator post a n - node to the server. | we need to stash the args we made into the actual object and not a copy |
@@ -256,6 +256,7 @@ public class CLITest {
}
}
+ @Ignore("TODO sometimes fails, in CI & locally")
@Test
@Issue("JENKINS-54310")
public void readInputAtOnce() throws Exception {
| [CLITest->[readInputAtOnce->[tempHome,grabCliJar],strictHostKey->[tempHome],reportNotJenkins->[tempHome,grabCliJar],interrupt->[tempHome,grabCliJar],CliProxyAction->[getTarget->[doDynamic]],redirectToEndpointShouldBeFollowed->[tempHome,grabCliJar]]] | Redirects to the specified endpoint if the user is running on a remote machine. - auth - jar jar - s list - plugins. | #3708 does not seem to have worked reliably. |
@@ -104,12 +104,12 @@ public class JavaProcessLauncher {
propertiesFile = File.createTempFile("sq-process", "properties");
Properties props = new Properties();
props.putAll(javaCommand.getArguments());
- props.setProperty(ProcessEntryPoint.PROPERTY_PROCESS_KEY, javaCommand.getKey());
- pr... | [JavaProcessLauncher->[close->[close],buildPropertiesFile->[close]]] | Build a temporary file for the given command. | `ProcessEntryPoint.*` could be statically imported |
@@ -32,13 +32,15 @@ const Routes = ({ match }) => (
<>
<Switch>
<%_ if (!readOnly) { _%>
- <ErrorBoundaryRoute exact path={`${match.url}/:id/delete`} component={<%= entityReactName %>DeleteDialog} />
<ErrorBoundaryRoute exact path={`${match.url}/new`} component={<%= entityReactName %>Update} ... | [No CFG could be retrieved] | Routes - Route mapping. | not so sure about that one... if the point of having the deletion modal on top of the entity list page is what matters, then there may be a better way to achieve that |
@@ -2,15 +2,17 @@
// The .NET Foundation licenses this file to you under the MIT license.
using System;
+using System.Diagnostics.CodeAnalysis;
using System.Text.Json;
namespace SerializerTrimmingTest
{
/// <summary>
- /// Tests that the enum converter factory is linker-safe.
+ /// Tests that the en... | [Program->[Main->[Serialize]]] | Main method for the test. | No pushback here following discussions on this and given the source-gen APIs as an alternative, but it's a bit jarring to see that the props have to be manually rooted here. |
@@ -52,6 +52,10 @@ FINGERPRINTS = {
{
2: 5, 42: 6, 346: 6, 347: 5, 348: 8, 349: 7, 386: 8, 397: 8, 398: 8, 520: 2, 523: 6, 548: 8, 634: 7, 645: 8, 658: 8, 665: 8, 666: 8, 674: 2, 682: 8, 683: 8, 689: 8, 723: 8, 758: 3, 772: 8, 773: 6, 774: 7, 775: 8, 776: 6, 777: 7, 778: 6, 783: 3, 851: 8, 855: 5, 1001: 6, ... | [dbc_dict] | ROGUE and ALGIMA are special and are not supported. Sequence of objects in the NISIAN system. | merge your fingerprint with the existing one |
@@ -8,6 +8,7 @@ public class Program
public static int Main(string[] args)
{
Console.WriteLine("Hello, Android!"); // logcat
- return 42;
+ int result = ((string)AppContext.GetData("System.Threading.ThreadPool.MinThreads")).Equals("4") ? 42 : 1;
+ return result;
}
}
\ No ne... | [Program->[Main->[WriteLine]]] | Main method of the test. | I wonder if it's better to set and test some more arbitrary property, since `System.Threading.ThreadPool.MinThreads` will probably have a an affect on something real in the threadpool |
@@ -27,7 +27,7 @@ import io.confluent.ksql.parser.tree.QueryContainer;
import io.confluent.ksql.parser.tree.SetProperty;
import io.confluent.ksql.parser.tree.Statement;
import io.confluent.ksql.parser.tree.UnsetProperty;
-import io.confluent.ksql.rest.util.ProcessingLogConfig;
+import io.confluent.ksql.processing.lo... | [StandaloneExecutor->[start->[start],handlePersistentQuery->[start]]] | Reads a variable number from a database. Produces a SLF4J version checker agent. | nit: can we switch this around to `logging.processing`, then we can have other logging stuff under `logging.blah` etc. |
@@ -16,3 +16,14 @@ CREATE TABLE IF NOT EXISTS identity.users (
`)
return err
}
+
+// CreateConfigTable sets up the postgres table which stores IDP configuration
+func CreateConfigTable(ctx context.Context, tx *sqlx.Tx) error {
+ _, err := tx.ExecContext(ctx, `
+CREATE TABLE IF NOT EXISTS identity.config (
+ id INT ... | [ExecContext] | Check if an object is an object and if so return it. | I think this lets you remove `IdentityServerConfig` from `src/identity/identity.proto` too? |
@@ -12,6 +12,10 @@ import (
type SCTeamName string
type SCTeamID string
+func (s SCTeamID) ToTeamID() keybase1.TeamID {
+ return keybase1.TeamID(s)
+}
+
// A (username, seqno) pair.
// The username is adorned with "%n" at the end
// where n is the seqno IF the seqno is not 1.
| [MarshalJSON->[UserVersion,Quote,PercentForm],UnmarshalPayload->[New,Unmarshal],PayloadHash->[Sum256],UnmarshalJSON->[Unquote],Unmarshal] | Imports a single - valued sequence of words from a user s system. EncKID is the encryption KID for the given user. | this should probably check format using `keybase1.TeamIDFromString` |
@@ -292,6 +292,12 @@ export const adConfig = {
prefetch: 'https://cdn.gmossp-sp.jp/ads/amp.js',
},
+ gumgum: {
+ prefetch: [
+ 'https://g2.gumgum.com/javascripts/ad.js',
+ ],
+ },
+
holder: {
prefetch: 'https://i.holder.com.ua/js2/holder/ajax/ampv1.js',
preconnect: 'https://h.holder.... | [No CFG could be retrieved] | A list of all possible scopes for AMP. The list of all possible urls for a given sequence number. | no need for array with only one prefetch url. |
@@ -1099,6 +1099,16 @@ func testAccCheckComputeInstanceHasGuestAccelerator(instance *computeBeta.Instan
}
}
+func testAccCheckComputeInstanceHasMinCpuPlatform(instance *computeBeta.Instance, minCpuPlatform string) resource.TestCheckFunc {
+ return func(s *terraform.State) error {
+ if instance.MinCpuPlatform != m... | [SetMachineType,Meta,Stop,Test,Get,Sprintf,Do,Contains,RandString,RootModule,ComposeTestCheckFunc,Errorf,MustCompile,Getenv,HasSuffix] | testAccCheckComputeInstanceHasMultiNic returns a function that checks if the given instance testAccComputeInstance_update_deprecated_network - test for deprecated network. | Go vet caught an error here about using `%d` instead of `%s` |
@@ -856,14 +856,14 @@ public class AstBuilder extends SqlBaseBaseVisitor<Node> {
}
WithinExpression withinExpression = null;
- if (context.joinWindow() != null && context.joinWindow().withinExpression() != null) {
+ if (context.joinWindow() != null) {
withinExpression = (WithinExpression) visit... | [AstBuilder->[visitCreateStream->[processTableProperties],baseTypeToString->[getIdentifierText],visitRegisterTopic->[processTableProperties],visitCreateTableAs->[processTableProperties],getLocation->[getLocation],visitTableName->[processTableProperties],getType->[getIdentifierText,getType],visitCreateStreamAs->[process... | Visit a JOINRelation node. Returns a new AliasedRelation with the same attributes as this relation but with a unique child. | Same here, we need to keep the criteria optional. |
@@ -4323,7 +4323,10 @@ RtpsUdpDataLink::RtpsReader::deliver_held_data(const RepoId& src)
const SequenceNumber ca = wi->second->recvd_.cumulative_ack();
const WriterInfo::HeldMap::iterator end = wi->second->held_.upper_bound(ca);
for (WriterInfo::HeldMap::iterator it = wi->second->held_.begin(); it != end... | [No CFG could be retrieved] | - - - - - - - - - - - - - - - - - - deliver all data in to_deliver. | This seems like something that should be a getter in `DataSampleHeader`. This along with a setter that would be used `deliver_sample_i`. |
@@ -77,9 +77,9 @@ class CarInterface(CarInterfaceBase):
events = self.create_common_events(ret)
if self.CS.lkas_enabled:
- events.append(create_event('invalidLkasSetting', [ET.PERMANENT]))
+ events.add(car.CarEvent.EventName.invalidLkasSetting)
- ret.events = events
+ events.to_msg(ret)
... | [CarInterface->[apply->[update],update->[update]]] | Update the courtesy state of the car. | I don't like this pattern everywhere, you really shouldn't modify what you pass in. ret.events = events.to_msg() is a lot more readable |
@@ -323,7 +323,8 @@ class Document(NotificationsMixin, models.Model):
sections_to_hide = ('Quick_Links', 'Subnav')
doc = parse_content(html)
for sid in sections_to_hide:
- doc = doc.replaceSection(sid, '<!-- -->')
+ doc = doc.replaceSection(sid, '')
+ doc = do... | [Document->[_get_new_parent->[valid_slug_parent],get_full_url->[get_absolute_url],get_redirect_document->[from_url,get_redirect_url],_raise_if_collides->[_existing],acquire_translated_topic_parent->[save],parent_trees_watched_by->[tree_is_watched_by],render->[regenerate_cache_with_fields],_post_move_redirects->[Documen... | Return the body of the page as a string. | The tests pass for me without the second line ``doc = doc.removeSection(sid)``. I suspect it isn't doing anything. |
@@ -24,6 +24,6 @@ var (
func init() {
mb.Registry.MustAddMetricSet("openmetrics", "collector",
- collector.MetricSetBuilder("openmetrics"),
+ collector.MetricSetBuilder("openmetrics", collector.DefaultPromEventsGeneratorFactory),
mb.WithHostParser(hostParser))
}
| [WithHostParser,Build,MustAddMetricSet,MetricSetBuilder] | init initializes the metric set. | This metricset is not released yet, what do you think about using the other implementation from the beginning? |
@@ -5,6 +5,7 @@ class IdvController < ApplicationController
before_action :confirm_two_factor_authenticated
before_action :confirm_idv_needed, only: [:fail]
before_action :profile_needs_reactivation?, only: [:index]
+ before_action :sp_context_needed?, only: [:index]
def index
if decorated_session.r... | [IdvController->[fail->[redirect_to,idv_attempter_throttled?],proof_with_cac?->[cac_proofing_enabled,call,any?],profile_needs_reactivation?->[redirect_to,started?],liveness_upgrade_required?->[includes_liveness_check?],active_profile?->[present?],sp_over_quota_limit?->[call,to_s],index->[redirect_to,idv_attempter_throt... | Checks if the user has an identity node and if so redirects to the correct page. | Since this only applies to `:index`, and only the root `IdvController`, what would happen if I navigate to `/verify/doc_auth` or `/verify/doc_auth/welcome` ? Or are we primarily concerned with the base `/verify` path? |
@@ -99,7 +99,7 @@ public class JavaScriptAggregatorFactory extends AggregatorFactory
@Override
public BufferAggregator factorizeBuffered(final ColumnSelectorFactory columnSelectorFactory)
{
- checkAndCompileScript();
+ compiledScript = getCompiledScript();
return new JavaScriptBufferAggregator(
... | [JavaScriptAggregatorFactory->[getMergingFactory->[getCombiningFactory],equals->[equals],getCombiningFactory->[JavaScriptAggregatorFactory],makeAggregateCombiner->[fold->[combine]],combine->[combine],getRequiredColumns->[apply->[JavaScriptAggregatorFactory]]]] | Factorizes the buffer aggregators by putting all the field names in a buffer and then concaten. | Still reassign. Also other occurrences in this PR. |
@@ -33,7 +33,8 @@ from mypy.types import Void, Type, Callable, AnyType, UnboundType
from mypy.parsetype import (
parse_type, parse_types, parse_signature, TypeParseError
)
-
+from mypy.annotations import Annotation, IgnoreAnnotation
+from mypy.parseannotation import parse_annotation
precedence = {
'**': ... | [unwrap_parens->[unwrap_parens],token_repr->[repr],parse->[parse],Parser->[skip_until_break->[current,skip],skip_until_next_line->[current,skip,skip_until_break],eol->[current],parse_type_comment->[parse_error_at],parse_try_stmt->[parse_block],parse_tuple_expr->[parse_expression],parse_decorated_function_or_class->[par... | The main entry point for the n - tuple protocol. Parse a MypyFile object and return a MypyFile object. | Missing empty line |
@@ -133,6 +133,12 @@ class ProductVariantTranslatableContent(CountableDjangoObjectType):
class ProductTranslation(BaseTranslationType):
+ description = graphene.String(
+ description="Description for the product translation.",
+ deprecation_reason="Use the `descriptionJson` field instead.",
+ ... | [MenuItemTranslatableContent->[TranslationField,Field],CollectionTranslatableContent->[resolve_collection->[visible_to_user],TranslationField,Field],CategoryTranslatableContent->[TranslationField,Field],SaleTranslatableContent->[permission_required,TranslationField,Field],BaseTranslationType->[resolve_language->[Langua... | This class is used to create a translation field for a product variant. Get a single node from the database. | It's not the description of a translation, but the translated description of a product. It should be: "Translated description of the product". Please correct other descriptions below accordingly. |
@@ -118,6 +118,16 @@ func (a *APIServerHandler) doPostJSON(rawarg keybase1.PostJSONArg) (res keybase1
return a.convertRes(ires), nil
}
+func (a *APIServerHandler) doDelete(arg keybase1.DeleteArg) (res keybase1.APIRes, err error) {
+ a.G().Trace("APIServerHandler::Post", func() error { return err })()
+ var ires *l... | [doPost->[Post,setupArg],doPostJSON->[setupArg,PostJSON],doGet->[setupArg,Get]] | doPostJSON posts a JSON payload to the server and returns the response. | Changed this to `Delete` |
@@ -322,7 +322,7 @@ $reshook = $hookmanager->executeHooks('printFieldListSelect', $parameters); // N
$sql .= $hookmanager->resPrint;
$sql .= ' FROM '.MAIN_DB_PREFIX.'product as p';
-$sql .= ' LEFT JOIN '.MAIN_DB_PREFIX.'product_stock as s ON p.rowid = s.fk_product';
+$sql .= ' LEFT JOIN '.MAIN_DB_PREFIX.'product_st... | [fetch,create,fetch_object,lasterror,addline,load_stats_commande_fournisseur,get_buyprice,order,getNomUrl,rollback,begin,initHooks,plimit,select_product_fourn_price,executeHooks,loadLangs,escape,getDefaultLang,close,showFilterAndCheckAddButtons,load_stock,free,query,ifsql,trans,num_rows,selectWarehouses,fetch_thirdpart... | Select all products in the system. This function is used to show products that have a certain number of products. | This for the "special test case" detailed in the description of the ticket. |
@@ -212,12 +212,12 @@ static int aes_wrap_cipher(void *vctx,
if (outsize < inl) {
ERR_raise(ERR_LIB_PROV, PROV_R_OUTPUT_BUFFER_TOO_SMALL);
- return -1;
+ return 0;
}
len = aes_wrap_cipher_internal(ctx, out, in, inl);
- if (len == 0)
- return -1;
+ if (len <= 0)
+ ... | [void->[ossl_prov_is_running,OPENSSL_zalloc,ossl_cipher_generic_initkey,OPENSSL_clear_free,ossl_cipher_generic_reset_ctx],int->[ossl_prov_is_running,ossl_cipher_generic_initiv,AES_set_decrypt_key,aes_wrap_init,OSSL_PARAM_get_size_t,AES_set_encrypt_key,aes_wrap_set_ctx_params,aes_wrap_cipher_internal,ERR_raise,OSSL_PARA... | aes_wrap_cipher - function to read and write AES - wrapping cipher. | Should this be `len < 0` or just `len == -1`? I would argue 0 is a valid return value from `aes_wrap_cipher_internal`, as it means the input/output is empty. |
@@ -18,8 +18,8 @@ from .filter import resample, detrend, FilterMixin
from .fixes import in1d
from .utils import check_fname, logger, verbose, object_hash, _time_mask
from .viz import (plot_evoked, plot_evoked_topomap, plot_evoked_field,
- plot_evoked_image, plot_evoked_topo)
-from .viz.evoked import... | [Evoked->[detrend->[detrend],resample->[resample]],read_evokeds->[Evoked,_get_evoked_node],grand_average->[copy]] | Creates a new object from a base object. Evoked data from a FIF file. | Remove ',' at the end |
@@ -140,7 +140,8 @@ func TestCreatingStackWithArgsSpecifiedFullNameSucceeds(t *testing.T) {
err := runNew(args)
assert.NoError(t, err)
- assert.Equal(t, fullStackName, loadStackName(t))
+ assert.Equal(t, stackName, loadStackName(t))
+ removeStack(t, stackName)
}
func TestCreatingProjectWithDefaultName(t *test... | [RemoveAll,TempDir,LoadProject,RemoveStack,Settings,NewObjectValue,Error,New,Short,Skip,Chdir,GetStack,Equal,Contains,CurrentUser,Parallel,NoError,Base,NewValue,MustMakeKey,Sprintf,Background,DetectProjectPathFrom,ParseStackReference,String,Run] | TestCreatingStackWithArgsSpecifiedFullNameSucceeds tests the creation of a stack with TestCreatingProjectWithArgsSpecifiedName - test creation of a unique project with arguments. | Why did we expect to get the full name back and now we expect to get the short name? |
@@ -78,6 +78,8 @@ class Analytics
MULTI_FACTOR_AUTH_ENTER_OTP_VISIT = 'Multi-Factor Authentication: enter OTP visited'.freeze
MULTI_FACTOR_AUTH_ENTER_PERSONAL_KEY_VISIT = 'Multi-Factor Authentication: enter personal key visited'.freeze
MULTI_FACTOR_AUTH_MAX_ATTEMPTS = 'Multi-Factor Authentication: max attempts... | [Analytics->[track_event->[except,merge!,track],browser_attributes->[user_agent,os_full_version,bot?,os_name,device_name,device_type,name,full_version],uuid->[uuid],request_attributes->[merge!],browser->[user_agent,new],ahoy->[test?,new],attr_reader,freeze]] | Return a string describing the state of the IDV. Get a list of all the messages that have occurred during password reset. | How about 'Multi-Factor Authentication: option submitted'? |
@@ -123,7 +123,7 @@ class GrammarState:
new_lambda_stacks[(lambda_type, lambda_variable)] = []
for production in reversed(productions):
- if self._is_nonterminal(production):
+ if types.is_nonterminal(production):
new_stack.append(production)
... | [GrammarState->[_get_productions_from_string->[production_string],take_action->[split,GrammarState,deepcopy,NotImplementedError,_get_productions_from_string,append,pop,len,reversed,set,items,add,values,_is_nonterminal],_is_nonterminal->[production,startswith,len],set]] | Takes an action in the current grammar state returning a new grammar state with whatever updates are necessary Returns a GrammarState with the top - level nonterminal and lambda stacks removed. | Can you add a TODO here that this should be dependent on the `World`? We need to take that an as input argument. |
@@ -72,9 +72,8 @@ public final class MacOSDnsServerAddressStreamProvider implements DnsServerAddre
}
private static void loadNativeLibrary() {
- String name = SystemPropertyUtil.get("os.name").toLowerCase(Locale.UK).trim();
- if (!name.startsWith("mac")) {
- throw new IllegalStateEx... | [MacOSDnsServerAddressStreamProvider->[nameServerAddressStream->[retrieveCurrentMappings,nameServerAddressStream],ensureAvailability]] | loadNativeLibrary - load native library if not loaded on macOS. | I don't think this is behavioral change because `DnsServerAddressStreamProviders` uses `PlatformDependent.isOsx()` check before trying to load `MacOSDnsServerAddressStreamProvider`. |
@@ -42,6 +42,10 @@ class Pythia6(CMakePackage):
# the Pythia6 library.
variant('root', default=False,
description='Build extra (non OEM) code to allow use by Root.')
+ variant('sft', default=False,
+ description='Apply extra patch provided by CERN EP-SFT group')
+
+ conflicts('+s... | [Pythia6->[cmake_args->[format],setup_build_environment->[append_flags,satisfies],patch->[dirname,copy,filter_file,format,join],basename,resource,iteritems,format,version,patch,variant,urlparse],_is_integral->[int,isinstance]] | Creates a new object with the given name. A tool to show the sequence of unique identifiers. | Why is this patch only allowed in `+root` builds? The random number generator part looks quite generic anyway. So the question also is: Why a variant at all? |
@@ -3,9 +3,10 @@ class AnalyticsController < ApplicationController
before_action :confirm_two_factor_authenticated
def create
- unless analytics_saved?
- session[:platform_authenticator] = true
- analytics.track_event(Analytics::PLATFORM_AUTHENTICATOR, results.to_h)
+ results.each do |event, res... | [AnalyticsController->[results->[new],create->[track_event,head,to_h,analytics_saved?],skip_before_action,before_action]] | Creates a new object. | I thought the plan was to have one event and to track all the analytics we gather under that single event. |
@@ -1179,6 +1179,7 @@ export class AmpStoryPage extends AMP.BaseElement {
promises.push(mediaPool.play(mediaEl));
}
+ this.pauseAllMedia_(true /** rewindToBeginning */);
this.playAudioElementFromTimestamp_ = null;
}
| [AmpStoryPage->[setState->[PLAYING,dev,NOT_ACTIVE,PAUSED],isAutoplaySupported_->[isAutoplaySupported],constructor->[resolve,timerFor,getAmpdoc,NOT_ACTIVE,getStoreService,mutatorForDoc,platformFor,promise,getMediaPerformanceMetricsService,debounce,reject],emitProgress_->[dict,PAGE_PROGRESS,NOT_ACTIVE,dispatch],setPageDe... | Unmutes a media element. | This should go L544? |
@@ -25,7 +25,7 @@ def test_close_regression(raiden_network, deposit, token_addresses):
channel_list = api1.get_channel_list(registry_address, token_address, app1.raiden.address)
channel12 = channel_list[0]
- token_proxy = app0.raiden.proxy_manager.token(token_address)
+ token_proxy = app0.raiden.proxy... | [test_close_regression->[get_channel_list,token,Timeout,wait_for_received_transfer_result,PaymentID,make_secret_with_hash,str,TargetAddress,RaidenAPI,transfer_and_wait,PaymentAmount,balance_of,ValueError,channel_close,wait_for_settle],parametrize] | Test the close of a channel with a wrong balance proof. This function is called from the client code to check that the balance of the token is correct. | Can we be sure here that `node1_balance_before` is equal to the internal state of `appX`, because that is a number of blocks behind? |
@@ -206,7 +206,8 @@ public class HoodieInputFormat extends MapredParquetInputFormat implements Confi
* Read the table metadata from a data path. This assumes certain hierarchy of files which should
* be changed once a better way is figured out to pass in the hoodie meta directory
*/
- protected static Hood... | [HoodieInputFormat->[listStatus->[listStatus],getTableMetaClient->[getConf],getRecordReader->[getRecordReader]]] | Get the table meta client for the given data path. | I'm guessing this method is not called anywhere else so the extra throws IOException doesn't matter ? |
@@ -1414,3 +1414,18 @@ class CoregFrame(HasTraits):
def _view_options_fired(self):
self.view_options_panel.edit_traits()
+
+ def save_config(self, home_dir=None):
+ "Write configuration values"
+ set_config('MNE_COREG_GUESS_MRI_SUBJECT',
+ str(self.model.guess_mri_subj... | [CoregPanel->[_fits_fid_fired->[fit_scale_fiducials],_reset_params_fired->[reset],_fits_hsp_points_fired->[fit_scale_hsp_points],_load_trans_fired->[load_trans],_fit_hsp_points_fired->[fit_hsp_points],_fit_ap_fired->[fit_auricular_points],_fits_ap_fired->[fit_scale_auricular_points],_fit_fid_fired->[fit_fiducials],_sav... | Called when the view options is changed. | triple-quotes, end with period |
@@ -69,6 +69,8 @@ def initialize_worker(sender, instance, **kwargs):
:param kwargs: Other params (unused)
:type kwargs: dict
"""
+ from pulp.tasking.services.worker_watcher import delete_worker
+
# Delete any potential old state
delete_worker(sender, normal_shutdown=True)
| [initialize_worker->[create_worker_working_directory,delete_worker,delete_worker_working_directory,startswith,get_resource_manager_lock],get_resource_manager_lock->[_,sleep,TaskLock,startswith,save_heartbeat,custom_sigterm_handler,get_or_create,info,save],custom_sigterm_handler->[sigterm_handler->[info,delete_worker,ex... | Initializes a worker with a reserved reserved resource. This function is called when a task is being executed. It deletes any potential old state . | I really want to avoid this, but I'm not sure how. Any ideas? |
@@ -1579,8 +1579,8 @@ ds_cont_tgt_force_close(uuid_t cont_uuid)
{
int rc;
- D_DEBUG(DF_DSMS, DF_CONT": Force closing all handles for container "
- DF_UUID"\n", DP_CONT(NULL, NULL), cont_uuid);
+ D_DEBUG(DF_DSMS, "Force closing all handles for container "
+ DF_UUID"\n", DP_UUID(cont_uuid));
rc = dss_thread_co... | [No CFG could be retrieved] | cont_close_all - close all container handles for a given thread This function is called by dss_collective to close the containers associated with this thread. | This is the cause of the most recent error, we were logging a raw uuid as a string. This code is about five months old, so I can only conclude something else has landed elsewhere where we're now taking this code-path where we weren't before. |
@@ -160,8 +160,10 @@ public class ZetaSQLQueryPlanner implements QueryPlanner {
SqlUserDefinedFunction udf = (SqlUserDefinedFunction) call.op;
if (udf.function instanceof ZetaSqlScalarFunctionImpl) {
ZetaSqlScalarFunctionImpl scalarFunction = (ZetaSqlScalarFunctionImpl) ud... | [ZetaSQLQueryPlanner->[createPlanner->[ZetaSQLQueryPlanner],getDefaultTimezone->[getDefaultTimezone],convertToBeamRel->[convertToBeamRel],setDefaultTimezone->[setDefaultTimezone],getLanguageOptions->[getLanguageOptions]]] | Checks if there is only Java UDF in the projects. | Is it guaranteed that none of the `RexNode` in `call.getOperands()` contains any subexpression? |
@@ -15,6 +15,7 @@ using ILCompiler;
using ILCompiler.DependencyAnalysis;
using DependencyList = ILCompiler.DependencyAnalysisFramework.DependencyNodeCore<ILCompiler.DependencyAnalysis.NodeFactory>.DependencyList;
+using Internal.TypeSystem.Interop;
#if SUPPORT_JIT
using MethodCodeNode = Internal.Runtime.JitSupp... | [CorInfoImpl->[getCallInfo->[ComputeLookup,IsTypeSpecForTypicalInstantiation],embedGenericHandle->[ComputeLookup],expandRawHandleIntrinsic->[ComputeLookup]]] | Creates a CorInfo object that represents a single unboxing method. Reads the code node that is needed to compile the n - ary object. | I think this is now unnecessary |
@@ -139,8 +139,15 @@ public class DefaultSensitiveStringCodec implements SensitiveDataCodec<String> {
public String decode(String secret) throws Exception {
SecretKeySpec key = new SecretKeySpec(internalKey, "Blowfish");
- BigInteger n = new BigInteger((String) secret, 16);
- byte[] e... | [DefaultSensitiveStringCodec->[BlowfishAlgorithm->[encode->[init],decode->[init]],verify->[verify],main->[DefaultSensitiveStringCodec,init,encode],decode->[decode],PBKDF2Algorithm->[encode->[getSalt]],encode->[encode]]] | Decodes a secret string. | I think it would also be worth logging the original exception at debug level. Be sure to wrap the log statement in `if (logger.isDebugEnabled())`. |
@@ -147,6 +147,7 @@ feature 'LOA3 Single Sign On', idv_job: true do
click_button(t('idv.buttons.mail.resend'))
+ expect(user.events.usps_mail_sent.size).to eq 2
expect(current_path).to eq(verify_come_back_later_path)
end
| [perform_id_verification_with_usps_without_confirming_code] | loa3_sp_session show_idv_session show_idv_ expects the user to be able to verify phone. | Implements the expectation suggested previously. |
@@ -277,6 +277,12 @@ func newTSDBState(bucketClient objstore.Bucket, registerer prometheus.Registerer
Help: "The total time it takes to purge the TSDB series reference cache for a single tenant.",
Buckets: prometheus.DefBuckets,
}),
+
+ idleTsdbChecks: promauto.With(registerer).NewCounter(prometheus.Coun... | [v2LabelValues->[Close,Querier],Head->[Head],Blocks->[Blocks],Close->[Close],createTSDB->[Compact,setLastUpdate],PreCreation->[Head],numSeriesInTSDB->[Head],v2LifecyclerFlush->[shipBlocks,compactBlocks],closeAllTSDB->[Close],v2QueryStream->[Close,Querier],shipBlocks->[getTSDBUsers,getTSDB],StartTime->[StartTime],v2Labe... | NewV2 returns a new Ingester that uses Cortex block storage instead of chunks if creates a new instance of the object that can be used to track the number of. | I'm not sure this metric is worth it. It looks redundant to me, b ecause it's equal to `sum(cortex_ingester_idle_tsdb_check_results_total)`. |
@@ -15,6 +15,7 @@ public class CompletionStageResponseHandler implements ServerRestHandler {
result.handle((v, t) -> {
if (t != null) {
+ requestContext.serverResponse().clearResponseHeaders();
requestContext.handleException(t);
} ... | [CompletionStageResponseHandler->[handle->[handle]]] | Handle a response that is not a CompletionStage. | Can you explain why this (and similar calls in other places) is needed please? Asking because it is not apparent why it's needed and it seems that it was added just to make something specific work. Furthermore, this could have performance implications |
@@ -211,6 +211,10 @@ def deserialize_keras_object(identifier,
raise ValueError('Unknown ' + printable_module_name + ':' +
function_name)
return fn
+ elif isinstance(identifier, list):
+ return [deserialize_keras_object(sub_identifier, module_objects,
+ ... | [func_load->[ensure_value_to_cell],Progbar->[add->[update]],custom_object_scope->[CustomObjectScope],deserialize_keras_object->[class_and_config_for_serialized_keras_object,CustomObjectScope],serialize_keras_object->[serialize_keras_class_and_config]] | Deserialize a Keras object from a Keras object. | I think it would be preferable to have the list handling in `hdf5_format.py` above rather than here. `deserialize` is meant to handle single objects. The code duplication is minimal (one line). |
@@ -51,11 +51,10 @@ namespace System.Net.Http
private void RegisterCancellation(CancellationToken cancellationToken)
{
_cancellationToken = cancellationToken;
- _registration = cancellationToken.UnsafeRegister(static s =>
+ _registration = cancellationToken.UnsafeReg... | [CreditWaiter->[GetResult->[GetResult],OnCompleted->[OnCompleted]]] | Register a cancellation token. | We can get rid of _cancellationToken now, right? |
@@ -75,7 +75,9 @@ public abstract class AbstractKerberosUser implements KerberosUser {
// other classes may be referencing an existing subject and replacing it may break functionality of those other classes after relogin
this.subject = new Subject();
}
- ... | [AbstractKerberosUser->[logout->[logout],doAs->[doAs],login->[login],checkTGTAndRelogin->[logout,login]]] | Logs the user in. | It looks like the name `KerberosUser` has special meaning and is reused elsewhere in this class, it would be helpful to pull it out to a static variable. |
@@ -115,8 +115,8 @@ $sql = "SELECT";
if ($agentid > 0) $sql.= " s.rowid as socid, s.nom as name, s.code_client, s.client,";
$sql.= " u.rowid as agent, u.login, u.lastname, u.firstname,";
$sql.= " sum(d.total_ht) as selling_price,";
-$sql.= " sum(".$db->ifsql('d.total_ht < 0','d.qty * d.buy_price_ht * -1','d.qty * d.... | [fetch,getFullName,free,query,getNomUrl,ifsql,select_dolusers,trans,num_rows,fetch_object,close,order,idate,load,select_date] | This function returns a table with the data of the date range. query for facts. | Do you have value into database buy_price_ht negative into your database ? (may be on old record ?) All rest of code works with the following rule in mind: the field to store buy/cost price is always positive into database. |
@@ -56,6 +56,10 @@ class WebHook < ActiveRecord::Base
end
def self.enqueue_object_hooks(type, object, event, serializer = nil)
+ if type == :flag
+ Discourse.deprecate("The flags webhook is deprecated. Please use reviewable instead.")
+ end
+
if active_web_hooks(type).exists?
payload = We... | [WebHook->[enqueue_object_hooks->[enqueue_hooks],enqueue_topic_hooks->[enqueue_hooks],enqueue_post_hooks->[enqueue_hooks]]] | Enqueue object hooks for the given object. | Will this end up flooding our logs in production since it is still being used? Also, I think it'll be helpful to include the version that we're removing this method in. |
@@ -73,12 +73,12 @@ const uint16_t PROGMEM keymaps[][MATRIX_ROWS][MATRIX_COLS] = {
* | | | | | | | |MsLeft|MsDown| MsUp |MsRght|
* `-----------------------------------------------------------------------------------'
*/
- [FUN] = {
- {KC_F1, KC_F2,... | [No CFG could be retrieved] | ----------------------------------------------------------------------------------- ethernet ethernet ethernet ethernet Checks if a keycode is found in a user - specified record. | I think you accidentally renamed this layer. Was named `FUN` in the previous revision, and the previous layer here is already named `RSE`. |
@@ -67,6 +67,9 @@ public class PrestoPreparedStatement
extends PrestoStatement
implements PreparedStatement
{
+ private static final Pattern topLevelTypeRegexPattern = Pattern.compile("^(.+?)\\((.+)\\)$");
+ private static final Pattern timestampTimeZonePrecisionRegexPattern = Pattern.compile("... | [PrestoPreparedStatement->[setNull->[setNull],getExecuteSql->[formatParametersTo],setBigDecimal->[setNull],typedNull->[typedNull],setString->[setNull],setTimestamp->[setNull],setNString->[setString],setBytes->[setNull],setObject->[setShort,setInt,setBoolean,setNull,setBigDecimal,setString,setTimestamp,setFloat,setBytes... | This method imports all the fields from the given SQL statement. Execute a prepared statement. | We should name these all uppercase since they are constants. The "regex" part can be dropped since it is redundant, so `TOP_LEVEL_TYPE_PATTERN` |
@@ -15,8 +15,9 @@ class User < ActiveRecord::Base
has_many :grade_entry_students
has_many :groupings, through: :memberships
has_many :notes, as: :noteable, dependent: :destroy
- has_many :accepted_memberships, class_name: 'Membership', conditions: {membership_status: [StudentMembership::STATUSES[:accepted], S... | [User->[generate_csv_list->[student?],revoke_repository_permissions->[student?,repo_config],maintain_repository_permissions->[student?,repo_config],grant_repository_permissions->[student?,repo_config]]] | Creates a user object from a given user object. Authenticates login against its password through a script specified by VALIDATE_FILE. | Line is too long. [123/80] |
@@ -316,11 +316,14 @@ public abstract class FieldAccessDescriptor implements Serializable {
return toBuilder().setFieldInsertionOrder(true).build();
}
- /** Return the field ids accessed. Should not be called until after {@link #resolve} is called. */
- public Set<Integer> fieldIdsAccessed() {
+ /**
+ * ... | [FieldAccessDescriptor->[withFieldNames->[withFieldNames],union->[union,getFieldsAccessed,withAllFields,withFields,getAllFields],nestedFieldsById->[getFieldId],withOrderByFieldInsertionOrder->[build],builder->[setNestedFieldsAccessed],create->[build],withFieldIds->[withFieldIds],resolve->[getAllFields,build],validateFi... | Returns a new FieldAccessDescriptor with the same fields and ordering as this one but with field. | maybe instead we should make getFieldsAccessed return a List, instead of storing it as a set internally? |
@@ -138,8 +138,8 @@ public final class KsqlRestApplication extends Application<KsqlRestConfig> imple
final StatusResource statusResource,
final StreamedQueryResource streamedQueryResource,
final KsqlResource ksqlResource,
- final VersionCheckerAgent versionCheckerAgent
- ) {
+ final Vers... | [KsqlRestApplication->[start->[start],buildApplication->[buildApplication,KsqlRestApplication],stop->[stop],displayWelcomeMessage->[getListeners,displayWelcomeMessage]]] | Creates a new instance of the commands stream. Register the application configuration. | nit: this is a factory right? maybe name it serviceContextBinderFactory |
@@ -323,7 +323,11 @@ public abstract class AbstractProject<P extends AbstractProject<P,R>,R extends A
builds = buildMixIn.getRunMap();
triggers().setOwner(this);
for (Trigger t : triggers()) {
- t.start(this, Items.currentlyUpdatingByXml());
+ try {
+ t.st... | [AbstractProject->[setAssignedLabel->[save],onLoad->[onLoad,createBuildMixIn],getFirstBuild->[getFirstBuild],removeFromList->[save,updateTransientActions],workspaceOffline->[getWorkspace,getAssignedLabel,isAllSuitableNodesOffline],getRelevantLabels->[getAssignedLabel],doWs->[getSomeWorkspace],removeRun->[removeRun],get... | Called when the ItemGroup is loaded from disk. | Wouldn't `Throwable` be better here? |
@@ -235,8 +235,8 @@ class RequestController < ApplicationController
params[:outgoing_message][:body],
params[:public_body_ids])
- @info_request = InfoRequest.create_from_attributes(params[:info_request],
- ... | [RequestController->[get_attachment_internal->[new],check_batch_requests_and_user_allowed->[new],authenticate_attachment->[new],get_attachment_as_html->[new],render_new_compose->[new],make_request_summary_file->[new,assign_variables_for_show_template]]] | Displays a new batch of unknown nodes. redirect to info_request_batch_path if no batch exists. | Line is too long. [83/80] |
@@ -314,12 +314,13 @@ public class Iterators {
* <p>
* That is, this creates {A,B,C,D} from {A,B},{C,D}.
*/
+ @SafeVarargs
public static <T> Iterable<T> sequence( final Iterable<? extends T>... iterables ) {
return new Iterable<T>() {
public Iterator<T> iterator() {
- ... | [Iterators->[FlattenIterator->[next->[next,hasNext],hasNext->[expand,hasNext]],readOnly->[next->[next],hasNext->[hasNext]],sequence->[iterator->[remove->[],expand->[iterator],next->[],hasNext->[]],sequence],removeNull->[filter],FilterIterator->[fetch->[next,hasNext],remove->[remove],next->[fetch],hasNext->[fetch]],limi... | Returns an iterable that iterates over the given iterables. | Not really related but figured I would solve some other compiler warnings while I was here. |
@@ -445,7 +445,9 @@ class Installer
if (!$operations) {
$this->io->write('Nothing to install or update');
}
-
+
+ // check operations, build executs
+ $executes = array();
foreach ($operations as $operation) {
// collect suggestions
... | [Installer->[disableCustomInstallers->[disableCustomInstallers]]] | Installs the package. Install packages that are not in the lock file or are not in the current installed repository. Checks if packages are not installed or updateable and if so updates them if necessary. | Please don't add trailing whitespaces |
@@ -44,6 +44,7 @@ class DvcTree(BaseTree): # pylint:disable=abstract-method
return outs
def _get_granular_checksum(self, path, out, remote=None):
+ assert isinstance(path, PathInfo)
if not self.fetch and not self.stream:
raise FileNotFoundError
dir_cache = out.get_... | [DvcTree->[isfile->[exists,isdir],get_file_hash->[_get_granular_checksum,_find_outs],_walk->[_walk,_add_dir],exists->[_find_outs],isdvc->[_find_outs],walk->[_walk,_add_dir,exists,_find_outs,isdir],isdir->[exists,_get_granular_checksum,_find_outs],open->[_get_granular_checksum,open,_find_outs]],RepoTree->[isfile->[isfil... | Get the checksum of a file or directory. | Another reason to use type checks :slightly_smiling_face: Soon. |
@@ -61,5 +61,14 @@ gradleEnterprise {
publishAlways()
}
}
+
+buildCache {
+ local { enabled = true }
+ remote(HttpBuildCache) {
+ push = true
+ enabled = false // Disabled as this might not always desired
+ url = '<%= gradleEnterpriseHost %>/cache/' // note the trailing slash!
... | [No CFG could be retrieved] | publish always - > publish rootProject. | Why not always enable it? |
@@ -106,7 +106,7 @@ func (o *VersionOptions) Run() error {
versionInfo Version
)
- clientVersion := getKubectlVersion()
+ clientVersion := version.Get()
versionInfo.ClientVersion = &clientVersion
if !o.ClientOnly && o.discoveryClient != nil {
| [Validate->[New],Run->[Invalidate,Fprintf,Fprintln,Marshal,Sprintf,MarshalIndent,Errorf,ServerVersion],Complete->[ToDiscoveryClient,IsEmptyConfig],Flags,Examples,Validate,StringVarP,CheckErr,Run,T,Complete,BoolVar] | Run executes the command. | Why are we patching this? |
@@ -0,0 +1,12 @@
+namespace Pulumi.Automation
+{
+ public enum UpdateKind
+ {
+ Update,
+ Preview,
+ Refresh,
+ Rename,
+ Destroy,
+ Import,
+ }
+}
| [No CFG could be retrieved] | No Summary Found. | The name feels odd... do we use it in other language SDKs too? |
@@ -90,9 +90,10 @@ void MarlinUI::_goto_previous_screen(TERN_(TURBO_BACK_MENU_ITEM, const bool is_b
is_back ? 0 : sh.top_line,
sh.items
);
- }
- else
+ } else {
return_to_status();
+ }
+ defer_status_screen(false);
}
////////////////////////////////////////////
| [No CFG could be retrieved] | MenuEditItemBase - MenuEditItemBase constructor EditItemInfo_int3 - Edit interface for MenuItems. | There is no guarantee that the previous screen from any arbitrary screen is not also deferring the status screen. Consider the case where something like a mesh editor has to run a select screen. So While this supports the case for screen handlers that want to defer the status screen calling `defer_status_screen` conti... |
@@ -168,6 +168,11 @@ main(int argc, char **argv)
}
}
+ if (!dfuse_info->di_foreground && getenv("PMIX_RANK")) {
+ DFUSE_LOG_WARNING("Not running in background under orterun");
+ dfuse_info->di_foreground = true;
+ }
+
if (!dfuse_info->di_mountpoint) {
DFUSE_LOG_ERROR("Mountpoint is required");
D_GOTO(o... | [int->[fuse_session_loop,DFUSE_LOG_ERROR,fuse_session_loop_mt],main->[D_GOTO,dfuse_destroy_fuse,DFUSE_TRA_DOWN,daos_fini,dfs_mount,getopt_long,daos_pool_connect,daos_init,daos_cont_close,DFUSE_LOG_INFO,fuse_session_destroy,DFUSE_LOG_ERROR,D_FREE,dfs_umount,daos_rank_list_parse,DFUSE_TRA_ROOT,uuid_parse,daos_pool_discon... | - DVERBOSE - START dfuse_info is a reference to the dfuse_info object D - Der - DOS - DAOS - DAOS - DAOS DAOS error handling. | we shouldn't have any dependency on PMIX or any MPI implementation / launcher. we could be using slurm or pmi 1 or 2 for launchers, and we would bypass this check in this case anyway. |
@@ -244,6 +244,10 @@ function get_graph_generic_by_hostname()
rrdtool_initialize(false);
include 'includes/graphs/graph.inc.php';
rrdtool_close();
+
+ if ($vars['output'] === 'base64') {
+ api_success(['image' => $base64_output, 'content-type' => get_image_type()], 'image');
+ }
}
| [authToken->[getUser,get],get_graphs->[getParams],get_graph_generic_by_hostname->[getParams,set],list_logs->[getParams,getName],get_bgp->[getParams],list_locations->[getParams],check_is_read->[hasGlobalRead],get_bill_history_graphdata->[getParams,hasGlobalRead],get_graph_by_port_hostname->[getParams,set],add_components... | This function returns a generic graph type given a hostname. Get all locations that are not null. | Do you need to add this to the other functions which return graphs? |
@@ -85,7 +85,7 @@ namespace Js
Currently we lock Both the Type and the Type Handler in the following cases:
1. When a type is Shared.
2. Snapshot Enumeration: DynamicType::PrepareForTypeSnapshotEnumeration()
- To support snapshot enumetation we need to remember the type handler at the start of the enu... | [No CFG could be retrieved] | Locks the type. | Just noticed there's also: "enumetation" -> "enumeration" |
@@ -1,3 +1,4 @@
+# type: ignore
"""
General conftest for pytest execution of all integration tests lying
in the certbot_integration tests package.
| [pytest_configure->[_setup_primary_node,_print_on_err,hasattr],_setup_primary_node->[add_cleanup,print,start,DNSServer,check_output,ValueError,format,range,ACMEServer],pytest_addoption->[addoption]] | The standard conftest module for the given node. Context manager to print on error. | Why all the `conftest.py` files in particular? |
@@ -104,8 +104,8 @@ public class AlphaNumericTopNMetricSpecTest
+ " \"previousStop\": \"test\"\n"
+ "}";
ObjectMapper jsonMapper = TestHelper.makeJsonMapper();
- TopNMetricSpec actualMetricSpec = jsonMapper.readValue(jsonMapper.writeValueAsString(jsonMapper.rea... | [AlphaNumericTopNMetricSpecTest->[testSerdeAlphaNumericTopNMetricSpec->[makeJsonMapper,AlphaNumericTopNMetricSpec,writeValueAsString,assertEquals,readValue],testComparator->[assertTrue,newArrayList,of,sort,compare,assertEquals]]] | This test serde contains a JSON spec that contains a alphaNumeric top - n metric spec. | are all these test changes meant to be in this PR? |
@@ -113,7 +113,7 @@ func CreateEdgeRoute(f *clientcmd.Factory, out io.Writer, cmd *cobra.Command, ar
return err
}
- wildcardpolicy := kcmdutil.GetFlagString(cmd, "wildcardpolicy")
+ wildcardpolicy := kcmdutil.GetFlagString(cmd, "wildcard-policy")
if len(wildcardpolicy) > 0 {
route.Spec.WildcardPolicy = api.... | [MarkFlagRequired,Examples,ClientMapperFunc,Resource,AddDryRunFlag,InsecureEdgeTerminationPolicyType,AddPrinterFlags,Routes,DefaultSubCommandRun,GetFlagString,LongDesc,InfoForObject,Errorf,UnsecuredRoute,CheckErr,AddCommand,Clients,DefaultNamespace,Create,GetFlagBool,AddValidateFlags,WildcardPolicyType,MarkFlagFilename... | CreateEdgeRoute creates a new edge route getRouteSpec - gets the route spec from command line. | would it be worth checking to see if a user provided one of the supported wildcard-policy types? What happens if the flag is `--wildcard-policy="invalid"`? |
@@ -69,6 +69,12 @@ public final class JRadiusServerImpl implements RadiusServer {
.loadAttributeDictionary("net.jradius.dictionary.AttributeDictionaryImpl");
}
+ /**
+ * Instantiates a new j radius server impl.
+ *
+ * @param protocol the protocol
+ * @param clientFactory the client f... | [JRadiusServerImpl->[authenticate->[authenticate]]] | Creates a new instance of the class that implements RADIUS authentication. PreventedException is a non - blocking call to the client. | I would also say : _JRadius_ as it's the official name... |
@@ -1017,6 +1017,13 @@ class Toolbox extends Component<Props, State> {
key = 'stats'
onClick = { this._onToolbarOpenSpeakerStats }
text = { t('toolbar.speakerStats') } />,
+ this._shouldShowButton('embedmeeting')
+ && <OverflowMenu... | [No CFG could be retrieved] | Displays a menu item if the user has permission to record a shared video. Renders a list of buttons that are moved to the overflow menu. | Is this something we really want? We don't have 2 ways to trigger the password setting procedure, thus I'd expect this button not to exist and just be part of the invite dialog. Can you please double check? |
@@ -1494,6 +1494,17 @@ class Embedding(layers.Layer):
self._w = value
def forward(self, input):
+ if in_dygraph_mode():
+ attrs = {
+ 'is_sparse': self._is_sparse,
+ 'is_distributed': self._is_distributed,
+ 'remote_prefetch': self._remote_p... | [Conv3D->[_build_once->[_get_default_param_initializer]],NCE->[__init__->[_init_by_numpy_array]],Conv2D->[_build_once->[_get_default_param_initializer]]] | Computes the missing node index from the sequence. | Some suggestions: move some common codes outside `if in_dygraph_modes()` for better maintainability in the future. Seems too many duplicate codes. |
@@ -213,7 +213,7 @@ func (cs *ContainerService) setAddonsConfig(isUpdate bool) {
defaultIPMasqAgentAddonsConfig := KubernetesAddon{
Name: IPMASQAgentAddonName,
- Enabled: to.BoolPtr(DefaultIPMasqAgentAddonEnabled),
+ Enabled: to.BoolPtr(DefaultIPMasqAgentAddonEnabled && o.KubernetesConfig.NetworkPlugin != N... | [setAddonsConfig->[Itoa,HasNSeriesSKU,BoolPtr,GetAzureCNICidr,IsKubernetesVersionGe,HasCoreOS,GetCloudSpecConfig,GetNonMasqueradeCIDR],BoolPtr,IsKubernetesVersionGe,GetAddonContainersIndexByName,Bool,IsAzureCNI] | setAddonsConfig sets the addons config Spec for the cluster - spec AddonConfig - A plugin to configure the necessary configuration for a new add - on. This function returns a list of KubernetesContainerSpec objects that can be used to create a new This is the default configuration for the cluster. | Carried this additional default gate over from the "last mile" "concatenate addons string" business logic area. |
@@ -492,7 +492,7 @@ public class HiveMetaStoreBasedRegister extends HiveRegister {
}
}
- private void addOrAlterPartition(IMetaStoreClient client, Table table, HivePartition partition)
+ private void addOrAlterPartitionWithPushMode(IMetaStoreClient client, Table table, HivePartition partition)
throws... | [HiveMetaStoreBasedRegister->[createOrAlterTable->[call->[ensureHiveTableExistenceBeforeAlternation],ensureHiveTableExistenceBeforeAlternation],getPartitionWithCreateTime->[getPartitionWithCreateTime],addOrAlterPartition->[addOrAlterPartition],ensureHiveTableExistenceBeforeAlternation->[updateSchema],createTableIfNotEx... | Add or alter a partition. | Not a blocker for this PR. But if "pull" mode is the way to go, maybe we should remove the "push" mode in future. Same for skipping diff computations on partitions. Not sure if it is needed. |
@@ -92,9 +92,12 @@ set_property(TARGET {name}::{name}
targets_props = self.target_properties.format(name=name)
+ deps_cpp_cmake = DepsCppCmake(cpp_info)
+ build_paths = deps_cpp_cmake.build_paths
+
tmp = self.config_xxx_template.format(name=name,
... | [CMakeFindPackageMultiGenerator->[content->[get_safe,upper,format,DepsCppCmake,_find_for_dep,lower],_find_for_dep->[find_dependency_lines,format,join]]] | Find for dependency. | `self.config_xxx_template` have no `build_paths` placeholder, right? |
@@ -15,8 +15,9 @@
*/
import * as Preact from '../../../src/preact';
import {ArrowNext, ArrowPrev} from './arrow';
+import {InlineGalleryContext} from '../../amp-inline-gallery/1.0/inline-gallery';
import {Scroller} from './scroller';
-import {toChildArray, useRef, useState} from '../../../src/preact';
+import {toC... | [No CFG could be retrieved] | A base carousel that displays a single element in the menu. Displays the hidden . | What do you think if we reversed this relationship: instead we would define carousel and carousel context. And then bunch of other components can provide and use it. Basically it'd simply mean moving this context to a different package. |
@@ -210,6 +210,9 @@ const targetMatchers = {
file.startsWith('build-system/test-configs')
);
},
+ [Targets.JSON_FILES]: (file) => {
+ return file.endsWith('.json');
+ },
[Targets.LINT]: (file) => {
if (isOwnersFile(file)) {
return false;
| [No CFG could be retrieved] | Filters files that are not minimally matched by the given pattern. Checks if a file is a reserved file. | Because there are only a few json files with schemas (6/133) this seems a bit broad. Perhaps narrow this down a bit. |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.