patch stringlengths 18 160k | callgraph stringlengths 4 179k | summary stringlengths 4 947 | msg stringlengths 6 3.42k |
|---|---|---|---|
@@ -359,9 +359,6 @@ func TestPurger_Restarts(t *testing.T) {
// load in process delete requests by calling Run
require.NoError(t, services.StartAndAwaitRunning(context.Background(), newPurger))
- // there must be 1 pending delete request
- require.Equal(t, float64(1), testutil.ToFloat64(newPurger.metrics.pendingD... | [StartAndAwaitRunning,StopAndAwaitTerminated,pullDeleteRequestsToPlanDeletes,Now,SetupTestChunkStore,buildDeletePlan,listUsersWithFailedRequest,InDelta,NewTableManager,Slice,retryFailedRequests,Add,Put,NewMockStorage,executePlan,AddDeleteRequest,Stop,ParseMetricSelector,Error,StopAsync,Poll,NotNil,CreateChunks,PanicsWi... | Deleting chunks is a simple example of how to delete chunks from a chunk store. TestPurger_Metrics tests the metrics of delete requests. | This is a cause of flakyness. When this code is executed, the pending request may have already been picked up. |
@@ -84,6 +84,7 @@ public class ReplicatedPolicy implements HAPolicy<LiveActivation> {
this.quorumSize = quorumSize;
this.voteRetries = voteRetries;
this.voteRetryWait = voteRetryWait;
+ this.quorumVoteWait = quorumVoteWait;
}
public ReplicatedPolicy(boolean checkForLiveServer,
| [ReplicatedPolicy->[getReplicaPolicy->[setClusterName]]] | This class is used to create a new instance of the class. Check if the failback should be allowed. | Please perform some basic validation on the new parameter |
@@ -54,7 +54,7 @@ func (c *Context) Reset(w http.ResponseWriter, r *http.Request) {
c.Logger = nil
c.TokenSet = false
c.Authorized = false
-
+ // TODO i guess i should not do reset the rate limit manager ??
c.Result.Reset()
c.w = w
| [Header->[Header],Write->[Header,MultipleWriteAttempts],writePlain->[Write,writeJSON],Reset->[Reset]] | Reset resets the context. | It needs to be reset. The middleware ensures the rate limiter is set for every request. The context is reused for any other request. What if it is reused for a request to a different endpoint with a different rate limiter? |
@@ -28,11 +28,11 @@ namespace System.Net.Mail
if (headers == null)
throw new ArgumentNullException(nameof(headers));
- foreach (string? key in headers) // TODO-NULLABLE: https://github.com/dotnet/csharplang/issues/3214
+ foreach (string key in headers)
... | [MailWriter->[WriteHeaders->[GetValues,WriteHeader,nameof],Close->[Close,Flush,Append],OnClose->[Flush,Assert]]] | Writes the headers in the given name - value collection. | NIT: not related to this PR change, but i think we can remove `!` from `headers!` |
@@ -43,14 +43,9 @@ func (s *Server) enableLeader(b bool) {
atomic.StoreInt64(&s.isLeaderValue, value)
- if !b {
- // if we lost leader, we may:
- // 1, close all client connections
- // 2, close all running raft clusters
- s.closeAllConnections()
-
- s.cluster.stop()
- }
+ // Reset connections and cluster.
+... | [leaderCmp->[getLeaderPath],campaignLeader->[enableLeader,getLeaderPath,isEtcdLeader],watchLeader->[getLeaderPath],GetLeader->[getLeaderPath],resignLeader->[getLeaderPath]] | enableLeader enables or disables the leader. | Why removing etcd leader check? Is that useless? |
@@ -67,8 +67,8 @@ DECLARE_TR_CTX(hdma_tr, SOF_UUID(hda_dma_uuid), LOG_LEVEL_INFO);
#define HDA_STATE_RELEASE BIT(0)
/* DGMBS align value */
-#define HDA_DMA_BUFFER_ALIGNMENT 0x20
-#define HDA_DMA_COPY_ALIGNMENT 0x20
+#define HDA_DMA_BUFFER_ALIGNMENT 0x8
+#define HDA_DMA_COPY_ALIGNMENT 0x8
#define HDA_DMA_BUFFER_... | [inline->[dma_chan_reg_write,dma_chan_reg_read],dma_chan_data->[spin_unlock_irq,tr_err,spin_lock_irq,tr_dbg,atomic_add],void->[notifier_unregister,hda_dma_inc_fp,hda_dma_inc_link_fp,spin_unlock_irq,atomic_sub,hda_dma_channel_put_unlocked,notifier_unregister_all,spin_lock_irq,dma_chan_get_data,pm_runtime_put,scheduler_g... | Define the fields of a single - channel which are used to create the HDA This function is used to output hardware DMA pointers and the HDA DMA pointers. | @juimonen wait a second. The manual says the alignment should be either 32/64 bits or bytes? We need to clarify this in the commit message. Because now we are chaning alignment from 0x20 to 0x8 and it doesn't makes sense according to the commit message. |
@@ -9,7 +9,9 @@ defineSuite([
defines : ['A', 'B', '']
});
- var shaderText = source.createCombinedVertexShader();
+ var shaderText = source.createCombinedVertexShader({
+ webgl2: false
+ });
expect(shaderText).toContain('#define A');
expect(shad... | [No CFG could be retrieved] | Define a suite of shaders that use the . creates a pick shader with a varying color. | To reduce clutter, create a `mockContext` variable at the top instead and pass that to each `createCombinedVertexShader` call. |
@@ -1424,9 +1424,10 @@ uncertainty_check_exec_one(struct io_test_args *arg, int i, int j, bool empty,
daos_epoch_t pe = ae - 1;
memcpy(pp, wp, strlen(wp));
- print_message(" update(%s, "DF_U64") (expect 0): ", pp, pe);
+ print_message(" update(%s, "DF_U64") (expect DER_SUCCESS): ",
+ pp, pe);
rc ... | [No CFG could be retrieved] | Check if a single uncertainties condition is observed. Update the fields of the ethernet header. | I wish we could remove DER_SUCCESS and just use 0 consistently everywhere. But never mind. |
@@ -1273,7 +1273,7 @@ def sequence_conv(input,
return helper.append_activation(pre_act)
-def sequence_softmax(input, param_attr=None, bias_attr=None, use_cudnn=True):
+def sequence_softmax(input, param_attr=None, bias_attr=None, use_cudnn=False):
"""
This function computes the softmax activation amon... | [dice_loss->[reduce_sum,one_hot,reduce_mean],ctc_greedy_decoder->[topk],conv2d->[_get_default_param_initializer],sequence_first_step->[sequence_pool],matmul->[__check_input],image_resize->[_is_list_or_turple_],sequence_last_step->[sequence_pool],resize_bilinear->[image_resize],lstm_unit->[fc],image_resize_short->[image... | This function computes the softmax activation among all time - steps for each sequence of all time - Returns the softmax_out function if the node is missing. | Note: for sequence_softmax, the implementation of cudnn is slow, because the number of call cudnn is equal to the number of squence, it is time-consuming. |
@@ -278,10 +278,10 @@ MSG_PROCESS_RETURN tls_process_cert_verify(SSL *s, PACKET *pkt)
EVP_PKEY *pkey = NULL;
const unsigned char *data;
#ifndef OPENSSL_NO_GOST
- unsigned char *gost_data = NULL;
+ unsigned char *gost_data = NULL;
#endif
int al = SSL_AD_INTERNAL_ERROR, ret = MSG_PROCESS_ERROR;
- ... | [No CFG could be retrieved] | Digest the signature and return the message. The list of possible types of keys that can be used to process the TLS - 13 T. | Hmm, just noticed Travis complains here. Seems like it's a hard space, would you mind just rewriting those spaces? |
@@ -1,5 +1,5 @@
<nav class='nav-branded vertical-align bg-light-blue center relative'>
- <%= image_tag(asset_url('logo.svg'), height: 15, width: 111, alt: '',
+ <%= image_tag(asset_url('logo.svg'), height: 15, width: 111, alt: 'Login.gov',
class: 'inline-block text-middle') %>
<div class='px-12p ... | [No CFG could be retrieved] | The main navigation for the NavNode. | we have an `APP_NAME` constant, let's use that here? |
@@ -125,9 +125,16 @@ public class TcpNetConnection extends TcpConnectionSupport implements Scheduling
@Override
public Object getPayload() {
+ InputStream inputStream;
+ try {
+ inputStream = inputStream();
+ }
+ catch (IOException e1) {
+ throw new UncheckedIOException(new SoftEndOfStreamException("Socke... | [TcpNetConnection->[close->[close],shutdownInput->[shutdownInput],shutdownOutput->[shutdownOutput],getPort->[getPort]]] | Get the payload from the input stream. | Can we make a `SoftEndOfStreamException` as an `UncheckedIOException` to avoid this wrapping? i don't mind for other branches, but at least for the `master`. Thanks |
@@ -364,8 +364,8 @@ class Archiver:
manager.export_paperkey(args.path)
else:
if not args.path:
- self.print_error("output file to export key to expected")
- return EXIT_ERROR
+ print(manager.get_keyfile_data())
+ return EXIT_... | [main->[get_args,run,Archiver],with_repository->[decorator->[wrapper->[argument]]],Archiver->[do_debug_search_repo_objs->[print_error,print_finding],_export_tar->[item_to_tarinfo->[print_warning,item_content_stream],build_filter,print_warning,build_matcher,item_to_tarinfo],do_prune->[print_error],do_mount->[print_error... | Export the key for backup. | we are getting closer, but still, we are not there yet... now we have the strange situation that the code in 367/368 implements just another behaviour (based on absence of a path, but it does not care about whether qr.args is given or not) in parallel to the behaviour in 370..373 (which is different based on whether ar... |
@@ -196,6 +196,11 @@ bool EncapsulationHeader::to_encoding(
return true;
}
+void EncapsulationHeader::set_encapsulation_options(Message_Block_Ptr& mb)
+{
+ mb->rd_ptr()[padding_marker_byte_index] |= ((Encoding::ALIGN_XCDR2 - mb->length() % Encoding::ALIGN_XCDR2) & 0x03);
+}
+
OPENDDS_STRING EncapsulationHeader:... | [No CFG could be retrieved] | Get the encoding of a header. - - - - - - - - - - - - - - - - - -. | I don't think `ALIGN_XCDR2` should be used, see previous conversion. |
@@ -783,6 +783,10 @@ function createBaseAmpElementProto(win) {
* @final @this {!Element}
*/
ElementProto.attachedCallback = function() {
+ this.classList.add('-amp-element');
+ this.classList.add('-amp-notbuilt');
+ this.classList.add('amp-notbuilt');
+
if (!isTemplateTagSupported() && this.isI... | [No CFG could be retrieved] | Changes the size of the element. missing - method. | Element can be attached any number of times. So, we should do this either: 1. When the element attached the first time (see `this.everAttached`) 2. When it's not built yet (see `this.built_`) 3. Or both :) |
@@ -61,6 +61,9 @@ class CloudFlowRunner(FlowRunner):
flow=flow, task_runner_cls=CloudTaskRunner, state_handlers=state_handlers
)
+ def __repr__(self) -> str:
+ return "<{}: {}>".format(type(self).__name__, self.flow.name)
+
def _heartbeat(self) -> None:
try:
... | [CloudFlowRunner->[call_runner_target_handlers->[debug,Failed,set_flow_run_state,get,update,ENDRUN,repr,super,format,prepare_state_for_cloud],initialize_run->[debug,Failed,get,update,ENDRUN,get_flow_run_info,setdefault,repr,format,super],__init__->[super,Client],_heartbeat->[format,get,update_flow_run_heartbeat,warn]]] | Initialize a CloudTaskRunner with a given flow. | This repr is actually unnecessary, as it will inherit the `__repr__` method from the parent `FlowRunner` class |
@@ -510,14 +510,11 @@ func validateNonBootstrapSpec(m toml.MetaData, spec offchainreporting.OracleSpec
return nil
}
-func validateExplicitlySetKeys(m toml.MetaData, expected map[string]struct{}, notExpected map[string]struct{}, peerType string) error {
+func validateExplicitlySetKeys(tree *toml.Tree, expected map[... | [ForEach,MinimumServiceDuration,Now,Duration,MaximumServiceDuration,Merge,Wrap,IsInstant,Add,MinimumContractPayment,EnableExperimentalAdapters,DefaultHTTPTimeout,NewTaskType,Error,NewMultiaddr,MatchString,Append,FindNativeAdapterFor,Cmp,New,CoerceEmptyToNil,IsDefined,NewLink,Errorf,Address,MustCompile,After,Bytes,FindE... | validateExplicitlySetKeys validates that the keys in the metadata are set. | Same here, mind making a story and explaining what this gets us? |
@@ -3,6 +3,10 @@ import functools
import multiprocessing
import os
import unittest
+try:
+ import fcntl
+except ImportError:
+ fcntl = None # type: ignore
import mock
| [LockFileTest->[test_unexpected_lockf_err->[_call],test_locked_repr->[_call],test_unexpected_stat_err->[_call],test_race->[_call],test_released_repr->[_call],test_removed->[_call]]] | Tests for certbot. lock. Test that the lock file is locked and that it is released. | This is probably overkill, but can we do something similar to what we do in `lock.py` of setting a `bool` here? I just like avoiding these `type: ignore` lines because unlike disabling linter checks, disabling type checking on a variable will disable additional checks around where the variable is used and I'd like us t... |
@@ -232,6 +232,18 @@ module Email
email_log
end
+ def find_user
+ return @user if @user
+ if @email_type.to_s == "confirm_new_email"
+ user = EmailChangeRequest.find_by(
+ new_email: to_address,
+ change_state: EmailChangeRequest.states[:authorizing_new]
+ )&.u... | [Sender->[to_address->[first,presence,try],header_value->[header,value],send->[header_value,post_id,bounceable_reply_address?,end_with?,new,text_part,topic,staff?,strip_avatars_and_emojis,base_url,charset,first,order,name,inline_secure_images,map,html_part,bounce_address,trigger,nil?,add_attachments,deliver_now,set_rep... | Sends a single message with a random key. Add a message in the message log if it doesn t exist yet This method is used to find a node in the tree that can be found in the system RFC 3339 section 3. 2. 2 finds a node in the message chain and sends it if it finds one. | What happens if there are multiple `EmailChangeRequest` rows? I can imagine it happening like - admin1 changes email to test@example.com - admin1 changes email to test2@example.com - admin2 changes email to test@example.com Now there will be two EmailChangeRequest rows for test@example.com. One for `admin1`, and one fo... |
@@ -951,6 +951,11 @@ void Player::UpdateWeaponSkill(Unit* victim, WeaponAttackType attType)
uint32 weapon_skill_gain = sWorld->getIntConfig(CONFIG_SKILL_GAIN_WEAPON);
Item* tmpitem = GetWeaponForAttack(attType, true);
+ if (item && item != tmpitem && !item->IsBroken())
+ {
+ tmpitem = item;
+ ... | [UpdateZone->[UpdateLocalChannels,UpdateArea],UpdateFishingSkill->[getProbabilityOfLevelUp],UpdateWeaponSkill->[UpdateSkill],UpdateCombatSkills->[UpdateWeaponSkill,UpdateDefense],UpdateAllRatings->[UpdateRating],UpdateVisibilityOf->[GetInitialVisiblePackets],UpdateAchievementCriteria->[UpdateAchievementCriteria],Update... | Updates the skill of a weapon based on the current state of the player. | This caused the server to crash |
@@ -90,7 +90,11 @@ public class ExpressionTransform implements Transform
if (column.equals(ColumnHolder.TIME_COLUMN_NAME)) {
return row.getTimestampFromEpoch();
} else {
- return row.getRaw(column);
+ Object raw = row.getRaw(column);
+ if (raw instanceof List) {
+ return Expressio... | [ExpressionTransform->[getValueFromRow->[getTimestampFromEpoch,getRaw,equals],equals->[getClass,equals],getRowFunction->[parse,ExpressionRowFunction,checkNotNull],ExpressionRowFunction->[eval->[value]],hashCode->[hash],checkNotNull]] | Gets the value from the row. | Is it fair to assume that all Lists are Lists of Strings? What if the expression selector returns a long array? |
@@ -105,8 +105,8 @@ func TestIngest(t *testing.T) {
}
client := getTestingElasticsearch(t)
- if strings.HasPrefix(client.Connection.version, "2.") {
- t.Skip("Skipping tests as pipeline not available in 2.x releases")
+ if client.Connection.version.Major < 5 {
+ t.Skip("Skipping tests as pipeline not available ... | [PipelineExists,Index,Ingest,Delete,HasPrefix,TestingSetup,Errorf,Skip,apiCall,DeletePipeline,Equal,CreatePipeline,Fatalf,SearchURI,Sprintf,Unmarshal,Fatal,Getpid,SearchURIWithBody,WithSelectors] | TestIngest tests if a specific index has a specific number of hits. _ - creates a new pipeline and checks if it s created. | Hopefully we can clean up this code one day as we should not test anymore against 2.x I think in the future. |
@@ -255,6 +255,14 @@ class Openmpi(AutotoolsPackage):
else:
config_args.append('--disable-mpi-thread-multiple')
+ # CUDA support
+ if spec.satisfies('@1.6:'):
+ if '+cuda' in spec:
+ config_args.append('--with-cuda={0}'.format(spec['cuda'].prefix))
+ ... | [Openmpi->[configure_args->[_verbs_dir],_verbs_dir]] | Configure the command line arguments for the command. Return a list of config options that can be passed to the command line. Filters out all flags that are not needed by the compiler. | is it always `lib64`? in the past we had various issues where hardcoding `lib` or `lib64` lead to problems. If `cuda` contains a single library named `libcuda.so` or alike, then the default interface to `libs` by @alalazo should work and you would be able to do `spec['cuda'].libs.directories` to get what you need. |
@@ -295,6 +295,12 @@ class TorchGeneratorAgent(TorchAgent):
agent.add_argument(
'--topp', type=float, default=0.9, help='p used in nucleus sampling'
)
+ agent.add_argument(
+ '--output-token-losses',
+ action='store_true',
+ hidden=True,
+ ... | [TorchGeneratorAgent->[_init_cuda_buffer->[_dummy_batch],compute_loss->[_model_input],eval_step->[decode_forced,reorder_encoder_states,compute_loss,_v2t,_model_input],train_step->[_init_cuda_buffer,compute_loss],_generate->[_treesearch_factory,reorder_encoder_states,_model_input,reorder_decoder_incremental_state]],Tree... | Add command line arguments to the TorchGeneratorAgent. This method is called when a new object is created. It is called by the constructor of if buffers is false this method will reset the buffers and reset the buffer to the last block. | use `type='bool'` instead, you can't override it later when loading from disk. |
@@ -120,7 +120,10 @@ class GraphQLView(View):
return render(
request,
"graphql/playground.html",
- {"api_url": request.build_absolute_uri(str(API_PATH))},
+ {
+ "api_url": request.build_absolute_uri(str(API_PATH)),
+ "plugins_url": f... | [obj_set->[get_key,obj_set,get_shallow_property],GraphQLView->[execute_graphql_request->[check_if_query_contains_only_schema,parse_query,get_root_value],handle_query->[_handle_query]]] | Renders a single object. | Wouldn't it work to pass `"/plugins/"` to `build_absolute_uri`? |
@@ -170,6 +170,13 @@ evoked_l_aud.plot_topo(title=title % evoked_l_aud.comment,
mne.viz.plot_evoked_topo(evoked, title=title % 'Left/Right Auditory/Visual',
background_color='w')
+###############################################################################
+# We can also plot the activat... | [tight_layout,plot_joint,plot_topo,join,plot_image,show,plot_evoked_topo,dict,set_title,plot_field,replace,make_field_map,plot,print,data_path,evoked_dict,zip,plot_topomap,read_evokeds,arange,subplots,plot_compare_evokeds,pick_types] | Plot the activations of a single . Plot a single MEG estimate for a list of maps. | not **actual** current flow, right? |
@@ -312,8 +312,14 @@ public class PubsubUnboundedSource<T> extends PTransform<PBegin, PCollection<T>>
reader.ackBatch(batchSafeToAckIds);
}
} finally {
- checkState(reader.numInFlightCheckpoints.decrementAndGet() >= 0,
+ int remainingInFlight = reader.numInFlightCheckpoints.decr... | [PubsubUnboundedSource->[PubsubReader->[pull->[pull,InFlightState,now],retire->[now],stats->[now],getWatermark->[now],getCurrent->[apply],extend->[InFlightState,extendBatch,now],close->[close],advance->[pull,retire,stats,now,extend],newFun],expand->[apply],StatsFn->[populateDisplayData->[populateDisplayData]],createRan... | Finalizes the checkpoint by acking all the acks that were not in - flight. | optional suggest: move all the checks into `maybeCloseClient()` and just call it unconditionally upon finalize checkpoint or reader close. |
@@ -137,7 +137,7 @@ public class CalciteQueryTest extends BaseCalciteQueryTest
ImmutableList.of(Druids.newTimeseriesQueryBuilder()
.dataSource(CalciteTests.DATASOURCE1)
.intervals(querySegmentSpec(Filtration.eternity()))
- ... | [CalciteQueryTest->[testGroupByLong->[testQuery,build,of],testExactCountDistinctUsingSubqueryWithWhereToOuterFilter->[testQuery,replaceWithDefault,build,of],testGroupByExtractYear->[testQuery,cannotVectorize,build,of],testUnplannableExactCountDistinctQueries->[of,assertQueryIsUnplannable],testCountStarWithTimeAndDimFil... | This test creates a query with count - start conditions. No - op if no nonexistent bucket exists. | This means that instead of casting `0` to `"0"` the planner is now casting `dim2` to numeric. Performance will be worse but it is technically more correct. (What if `dim2` was `"0.0"`?) So, it sounds good to me. |
@@ -563,6 +563,8 @@ module.exports = class livecoin extends Exchange {
throw new InvalidOrder (this.id + ': Unable to block funds ' + this.json (response));
} else if (error === 503) {
throw new ExchangeNotAvailable (this.id + ': Exchange is not ava... | [No CFG could be retrieved] | Get a list of all order blocks. | Hi) Thx as always for your participation in this ) Quick question on this line: is this a HTTP code or their API error code? ;) |
@@ -78,7 +78,9 @@ static SPISettings spiConfig;
case SPI_SPEED_6: delaySPIFunc = &delaySPI_2000; break; // desired: 250,000 actual: ~210K
default: delaySPIFunc = &delaySPI_4000; break; // desired: 125,000 actual: ~123K
}
- SPI.begin();
+ #ifndef STM32G0B1xx
+ SPI... | [spiRec->[HAL_SPI_STM32_SpiTransfer_Mode_3],spiSend->[HAL_SPI_STM32_SpiTransfer_Mode_3],spiRead->[spiRec],spiSendBlock->[spiSend]] | Initialize the delay SPI function. | In fact, this is not for `STM32G0B1xx`, but for all STM32 software SPI. When I first adapted `STM32G0B1xx` to Marlin, in order to reduce the impact of `Arduino_Core_STM32` library, I used the software SPI and found the problem here, detail in #23064, I think it should be deleted directly here, and I test it in Octopus ... |
@@ -0,0 +1,10 @@
+module Zxcvbn
+ class Tester
+ attr_accessor :data_path
+ def initialize
+ @data_path = File.expand_path("#{Rails.root}/node_modules/zxcvbn/dist/zxcvbn.js", __FILE__)
+ src = File.open(@data_path || DATA_PATH, 'r').read
+ @context = ExecJS.compile(src)
+ end
+ end
+end
| [No CFG could be retrieved] | No Summary Found. | I can't tell if we are using this outside of specs, but if we're using it prod, I'd put this in a file called `zxcvbn/tester.rb` in one of the directories in `app/` to match Rails autoloader expectations |
@@ -183,6 +183,9 @@ public abstract class FulltextExtractorWork extends AbstractWork {
if (blob == null) {
continue;
}
+ if (StringUtils.isNotEmpty(mimeType) && StringUtils.isNotEmpty(blob.getMimeType())) {
+ mimeType = blob.getMim... | [FulltextExtractorWork->[cleanUp->[cleanUp],convert->[convert]]] | Converts a list of blobs into a fulltext. | Don't you mean `StringUtils.isEmpty(mimeType)` ? |
@@ -84,6 +84,12 @@ public class TaskMonitor<T extends Task>
private int numRunningTasks;
private int numSucceededTasks;
private int numFailedTasks;
+ // This metric is used only for unit tests because the current taskStatus system doesn't track the killed task status.
+ // Currently, this metric only represe... | [TaskMonitor->[MonitorEntry->[withNewRunningTask->[MonitorEntry]]]] | Creates a map of subtaskSpecIds to their corresponding TaskHistory objects. The entry point for the monitor. | I did not understand this annotation here, since `numKilledTasks` is private. |
@@ -20,12 +20,17 @@ namespace System.Globalization
{
LoadAppLocalIcu(icuSuffixAndVersion);
}
- else if (Interop.Globalization.LoadICU() == 0)
+ else if (Interop.Globalization.LoadICU() == 0 && !OperatingSystem.IsBrowser())
... | [GlobalizationMode->[GetGlobalizationInvariantMode->[TryGetAppLocalIcuSwitchValue,FailFast,LoadAppLocalIcu,GetInvariantSwitchValue,LoadICU],LoadAppLocalIcuCore->[Length,LoadLibrary,Concat,InitICUFunctions,CreateLibraryName],GetGlobalizationInvariantMode]] | This method is called from the initialization code. | Won't this always enable invariant mode on browser? |
@@ -96,9 +96,3 @@ def staticproperty(func):
func = staticmethod(func)
return ClassPropertyDescriptor(func, doc)
-
-
-# TODO: look into merging this with `enum` and `ChoicesMixin`, which describe a fixed set of
-# singletons, to decouple the enum interface from the implementation as a `datatype`.
-# Extend Sin... | [classproperty->[ClassPropertyDescriptor],staticproperty->[ClassPropertyDescriptor],ClassPropertyDescriptor->[__get__->[__get__]],SingletonMetaclass] | Use as a decorator on a method or a staticmethod to make it a class - level. | Is it possible to leave this behind, but deprecate it? |
@@ -404,6 +404,14 @@ nfs_disable_share_one(const char *sharepath, const char *host,
argv[2] = hostpath;
argv[3] = NULL;
+#if DEBUG >= 2
+ int i;
+ fprintf(stderr, "CMD: ");
+ for (i = 0; i < 3; i++)
+ fprintf(stderr, "%s ", argv[i]);
+ fprintf(stderr, "\n");
+#endif
+
rc = libzfs_run_process(argv[0], argv, 0);... | [int->[fork,strdup,unlink,libzfs_run_process,nfs_enable_share,fprintf,nfs_available,strcat,strlen,malloc,strchr,nfs_disable_share,fcntl,mkstemp,foreach_nfs_shareopt,sprintf,foreach_nfs_host,waitpid,strcmp,foreach_shareopt,FSINFO,close,WEXITSTATUS,free,realloc,get_linux_shareopts,get_linux_hostspec,add_linux_shareopt,ex... | This function disables a shared file or directory on the host specified by host. | Drop or convert to dprintf() |
@@ -131,7 +131,9 @@ class Proxy extends BaseModule
// Store original image
if ($direct_cache) {
// direct cache , store under ./proxy/
- file_put_contents($basepath . '/proxy/' . ProxyUtils::proxifyUrl($request['url'], true), $image->asString());
+ $filename = $basepath . '/proxy/' . ProxyUtils::proxifyUr... | [Proxy->[init->[isValid,getBasePath,scaleDown,getReturnCode,getType,getBody,asString],setupDirectCache->[getBasePath],responseImageHttpCache->[getType,asString,isValid]]] | Initialize the cache This function is called when a request is not here. It will fetch the requested image from This function is called when a request is received from the browser. It will reduce the quality. | Since you defined the default value in `static/defaults.config.php`, it shouldn't be set here as well. There's a risk of changing the default in only one of the three places you hard-coded the default value. |
@@ -142,6 +142,7 @@ int EVP_CipherInit_ex(EVP_CIPHER_CTX *ctx, const EVP_CIPHER *cipher,
if (tmpcipher->prov == NULL) {
switch(tmpcipher->nid) {
+ case NID_undef:
case NID_aes_256_ecb:
case NID_aes_192_ecb:
case NID_aes_128_ecb:
| [No CFG could be retrieved] | The main entry point for the system. NID_aes_128_cfb128 NID_aes_128_cf. | Why do we still have this switch? Wouldn't it be more sensible (and less error prone, because *you* might remember to fill this in, but others might not) to try to fetch, and only fall back to legacy if that fails? might be subject for another PR... |
@@ -119,13 +119,13 @@ class Jetpack_Email_Subscribe {
// We allow for overriding the presentation labels.
$data = shortcode_atts(
array(
- 'title' => '',
+ 'title' => __( 'Join my email list', 'jetpack' ),
'email_placeholder' => __( 'Enter your email', 'jetpack' ),
- 'sub... | [Jetpack_Email_Subscribe->[parse_shortcode->[get_blog_id,is_set_up,get_site_slug],init_hook_action->[register_scripts_and_styles,register_shortcode]]] | Parse the shortcode Renders a hidden hidden input that allows users to enter a hidden input. esc_html function for show warning block. | This was omitted, not sure why. @artpi ? |
@@ -113,7 +113,6 @@ func (b *Monitor) EnrichArgs(process, pipelineID string, args []string, isSideca
logFile = fmt.Sprintf("%s-json.log", logFile)
appendix = append(appendix,
"-E", "logging.json=true",
- "-E", "logging.ecs=true",
"-E", "logging.files.path="+loggingPath,
"-E", "logging.files.name="+l... | [generateLoggingPath->[generateLoggingFile],MetricsPath->[WatchMetrics,generateMonitoringEndpoint],LogPath->[WatchLogs,generateLoggingFile],MetricsPathPrefixed->[MetricsPath],Prepare->[generateLoggingPath],EnrichArgs->[generateLoggingPath,generateMonitoringEndpoint],monitoringDrop->[generateMonitoringEndpoint]] | EnrichArgs adds additional arguments to the command line for the monitor. | I am confused? If this is removed then what is added the ecs.version to the events? |
@@ -50,6 +50,11 @@ define([
*
* @param {Object} [options] Object with the following properties:
* @param {Cartesian3} [options.radii=Cartesian3(1.0, 1.0, 1.0)] The radii of the ellipsoid in the x, y, and z directions.
+ * @param {Cartesian3} [options.innerRadii=options.radii] The inner radii of th... | [No CFG could be retrieved] | Constructs a geometry object that represents a single . Parse the command line options and return an object with the values set. | Please use radians throughout to be consistent with the rest of Cesium. |
@@ -269,7 +269,7 @@ export class AmpAdXOriginIframeHandler {
// unlayout already called
return;
}
- this.freeXOriginIframe(this.iframe.name.indexOf('_master') >= 0);
+ this.freeXOriginIframe(this.iframe.name.includes('_master'));
this.uiHandler_.setDisplayState(AdDisplayState.LOADED_NO_CON... | [No CFG could be retrieved] | Private methods for the base class. Handle resize of a . | `String#includes` is not supported in IE. |
@@ -18,9 +18,10 @@ import unittest
import numpy as np
from op_test import OpTest
import paddle.fluid.core as core
+from paddle.fluid.op import Operator
-class TestFillOp(OpTest):
+class TestFillOp1(OpTest):
def setUp(self):
self.op_type = "fill"
val = np.random.random(size=[100, 200])
| [TestFillOp->[test_check_output->[check_output],setUp->[astype,flatten,int,random]],main] | Sets up the operator. | `all close` is enough why not `array_equal` ? |
@@ -111,7 +111,7 @@ class ImageTester(unittest.TestCase):
encode_jpeg(torch.empty((100, 100), dtype=torch.uint8))
def test_write_jpeg(self):
- for img_path in get_images(IMAGE_ROOT, ".jpg"):
+ for img_path in get_images(ENCODE_JPEG, ".jpg"):
data = read_file(img_path)
... | [ImageTester->[test_write_jpeg->[get_images],test_encode_jpeg->[get_images],test_decode_jpeg->[get_images],test_decode_image->[get_images],test_encode_png->[get_images],test_write_png->[get_images],test_decode_png->[get_images]]] | Test write jpeg with quality 75. | Another problematic test. See above. |
@@ -147,8 +147,9 @@ def upload_block_blob( # pylint: disable=too-many-locals
validate_content=validate_content,
headers=headers,
tier=tier.value if tier else None,
+ blob_tags_string=blob_tags_string,
**kwargs)
- except StorageErrorException as error:
+... | [upload_page_blob->[_any_conditions,_convert_mod_error],upload_block_blob->[_any_conditions,_convert_mod_error]] | Upload a block of data from a stream. Upload a file or stream of bytes to the server. | Given that there's been some updates to error handling - do any of out live tests deal with errors raised from Storage? It shouldn't be an issue, but would be nice to know we have coverage :) |
@@ -203,7 +203,7 @@ CACHE_PANTS_RUN = {
# We include the lmdb_store to include a local process cache, so that hopefully we don't
# need to re-run processes (particularly tests) which have already run.
# TODO(#8041): Prune this directory before storing the cache.
- '${HOME}/.cache/pants/lmdb_st... | [linux_shard->[default_stage,_linux_before_install],Stage->[all_entries->[condition]],integration_tests_v2->[linux_shard],build_wheels_linux->[_build_wheels_env,linux_shard,docker_build_travis_ci_image,docker_run_travis_ci_image,_build_wheels_command],build_wheels_osx->[_build_wheels_command,_build_wheels_env,osx_shard... | The cache directory where pants is stored. Provides a class to be used as a dependency on the system. | Why delete this in this PR? Although I agree we should not cache it, this seems better for a dedicated PR. |
@@ -1347,9 +1347,10 @@ func CreateExecPodOrFail(client corev1client.CoreV1Interface, ns, name string) s
// CheckForBuildEvent will poll a build for up to 1 minute looking for an event with
// the specified reason and message template.
func CheckForBuildEvent(client corev1client.CoreV1Interface, build *buildv1.Build,... | [AssertFailure->[DumpLogs],AssertSuccess->[DumpLogs]] | ParseLabelsOrDie returns a selector that can be used to find a unique identifier for a given CheckForBuildEvent polls a build for an event with the specified reason and message template. | @mfojtik trying this to get away from legacyscheme |
@@ -1657,7 +1657,12 @@ bool TextureSource::generateImagePart(std::string part_of_name,
blit_with_interpolate_overlay(img, baseimg, v2s32(0,0), v2s32(0,0), dim, ratio);
img->drop();
}
- else if (part_of_name.substr(0,19) == "[autoupscaleformesh") {
+ else if (str_starts_with(part_of_name, "[applyfiltersform... | [No CFG could be retrieved] | Creates a render target texture from a cube mesh. finds the image of the render target that is not needed by the render system. | bracket on same line please |
@@ -147,7 +147,7 @@ public class HoodieTestSuiteJob {
long startTime = System.currentTimeMillis();
WriterContext writerContext = new WriterContext(jsc, props, cfg, keyGenerator, sparkSession);
writerContext.initContext(jsc);
- DagScheduler dagScheduler = new DagScheduler(workflowDag, writerCon... | [HoodieTestSuiteJob->[runTestSuite->[createWorkflowDag]]] | Runs the test suite. | @nsivabalan Can we avoid introducing these high level arguments numRound and delayMins to the dagScheduler ? This messes with a simpler design and adds unnecessary overloading to the constructor. Instead, we could do something like this Introduce a top level yaml change around this dag_name: dag_rounds: dag_intermitten... |
@@ -100,9 +100,7 @@ class UnusableUnpickledDeferredBase(object):
class DeferredFrame(DeferredBase):
- @property
- def dtypes(self):
- return self._expr.proxy().dtypes
+ pass
class _DeferredScalar(DeferredBase):
| [_proxy_method->[name_and_func],_DeferredScalar->[apply->[wrap]],with_docs_from->[wrap->[format_section]],wont_implement_method->[_prettify_pandas_type],_proxy_function->[wrapper->[wrap]],not_implemented_method->[_prettify_pandas_type],DeferredBase->[wrap->[get,wrap]]] | A function that returns a new object with the result of applying the function to the object and. | @robertwb do you know why we had dtypes defined in `DeferredFrame`, is this just because it predates `DeferredDataFrameOrSeries`? |
@@ -60,6 +60,7 @@ public interface Constants {
String PROJECTION_OF_POWER = "Projection of Power";
String ALL_ROCKETS_ATTACK = "All Rockets Attack";
String ROCKETS_CAN_FLY_OVER_IMPASSABLES = "Rockets Can Fly Over Impassables";
+ String TARGET_ROCKETS_SEQUENTIALLY_AND_AFTER_SBR = "Target Rockets Sequentialy an... | [getPuIncomeBonus->[getName],getIncomePercentageFor->[getName]] | A string that can be used to describe a failure in a unit. All individual rules from a game. | Sequentialy is misspelled. Also what exactly do you mean by sequentially? Also do the rockets fire after SBR or just after scrambling? |
@@ -48,6 +48,17 @@ func getZone(d TerraformResourceData, config *Config) (string, error) {
return GetResourceNameFromSelfLink(res.(string)), nil
}
+func getParent(d TerraformResourceData, config *Config) (string, error) {
+ res, ok := d.GetOk("portal")
+ if !ok {
+ if config.Zone != "" {
+ return config.Zone, n... | [LastIndex,Unlock,Duration,HasPrefix,NonRetryableError,GetOk,Lock,Errorf,Len,SetId,RetryableError,TrimSpace,GetType,Do,Contains,ContainsType,Printf,Sprintf,List,Retry] | getRegionFromZone returns the region from a zone for Google cloud. getProjectFromInstanceState returns the project attribute from the InstanceState. | I don't think this gets used anywhere |
@@ -306,12 +306,12 @@ module Repository
end
# Returns all the files under +path+ (but not in subdirectories) in this revision of the repository.
- def files_at_path(path)
+ def files_at_path(path, with_attrs: true)
raise NotImplementedError, "Revision.files_at_path not yet implemented"
end... | [AbstractRepository->[update_permissions->[get_full_access_users],get_users->[get_full_access_users],update_permissions_after->[update_permissions]]] | Returns a that can be used to find a revision at a given path. | Lint/UnusedMethodArgument: Unused method argument - path. If it's necessary, use _ or _path as an argument name to indicate that it won't be used. You can also write as directories_at_path(*) if you want the method to accept any arguments but don't care about them.<br>Lint/UnusedMethodArgument: Unused method argument -... |
@@ -84,7 +84,6 @@ RAM: 512K on CPU card, 128K on a piggyback card and a memory expansion board
Bus: Passive backplane, ISA
Video: Paradise EGA on another piggyback board
Mass storage: Floppy: 5.25" 1.2MB, MFM HDD
-
Lion 3500C/T
==========
Info: BIOS saved according to http://mess.redump.net/dumping/dump_bios_usin... | [No CFG could be retrieved] | A list of all possible errors of a n - tuple. The list of all possible objects. | And still another. |
@@ -507,7 +507,7 @@ int tls_parse_ctos_key_share(SSL *s, PACKET *pkt, X509 *x, size_t chainidx,
int group_nid, found = 0;
unsigned int curve_flags;
- if (s->hit)
+ if (s->hit && (s->ext.psk_kex_mode & TLSEXT_KEX_MODE_FLAG_KE_DHE) == 0)
return 1;
/* Sanity check */
| [tls_construct_stoc_etm->[SSLerr,WPACKET_put_bytes_u16],tls_parse_ctos_supported_groups->[PACKET_memdup,PACKET_remaining,PACKET_as_length_prefixed_2],tls_parse_ctos_ems->[PACKET_remaining],tls_parse_ctos_status_request->[PACKET_get_1,sk_OCSP_RESPID_new_null,PACKET_get_length_prefixed_2,d2i_OCSP_RESPID,d2i_X509_EXTENSIO... | Parse a key share packet. Get the net2 key share from the encoded packet. This function is called when the key is shared by another peer. | Is it worth defines for TLS_IS_KEX_MODE_DHE(s) et al? |
@@ -61,6 +61,7 @@ public class Http11To2UpgradeHandler extends ApplicationProtocolNegotiationHandl
private void configureHttp1(ChannelPipeline pipeline) {
final HttpServerCodec httpCodec = new HttpServerCodec(MAX_INITIAL_LINE_SIZE, MAX_HEADER_SIZE, restServer.getConfiguration().maxContentLength());
pi... | [Http11To2UpgradeHandler->[maxContentLength->[maxContentLength],configurePipeline->[configurePipeline]]] | Configure the HTTP 1 pipeline. | Is there any reason why we can't inline it here? I believe we don't need to reference. And could you please confirm if it works with HTTP/2? |
@@ -363,7 +363,14 @@ void StartServer(EvalContext *ctx, Policy **policy, GenericAgentConfig *config)
}
ThreadUnlock(cft_server_children);
}
-
+ if (LSD_MAXREADERS < CFD_MAXPROCESSES)
+ {
+ int rc = UpdateLastSeenMaxReaders(CFD_MAXPROCESSES);
+ if (r... | [No CFG could be retrieved] | Loop until a connection is found or until a connection is found. Check if the service request is working and if so return the value of the . | Shouldn't this happen inside UpdateLastSeenMaxReaders() ? If something other than this code calls that function, we've changed the maxreaders value but not changed the global LSD_MAXREADERS. Worse, if something has already called the function with a value bigger than either LSD_MAXREADERS or CFD_MAXPROCESSES, but the f... |
@@ -1133,9 +1133,13 @@ class ICA(ContainsMixin):
The name of the channel to use for ECG peak detection.
The argument is mandatory if the dataset contains no ECG
channels.
- threshold : float
+ threshold : float | str | None
The value above which a featur... | [read_ica_eeglab->[_update_mixing_matrix,ICA],_find_sources->[get_score_funcs],get_score_funcs->[_make_xy_sfunc],corrmap->[get_components,_find_max_corrs],_sort_components->[copy],ICA->[_sources_as_evoked->[_transform_evoked],_transform_raw->[_pre_whiten,_transform],find_bads_ecg->[get_sources,_find_bads_ch],_fit_raw->... | This method is used to detect ECG related components. - scoring method. - ctps is an absolute correlation threshold with a range of 0 Compute the missing - nanomaton scores given the threshold. | I think we should deprecate the None option and move to 'auto' in next versions. In 0.21 we get a warning to set it to auto to avoid warning and in 0.22 we make 'auto' the default and deprecate None. |
@@ -0,0 +1 @@
+package distributor
| [No CFG could be retrieved] | No Summary Found. | Do we not need the code that was here? Or was it lost as part of the rebase? |
@@ -282,11 +282,11 @@ export class Performance {
/**
- * Calls the "flushTicks" function on the viewer.
+ * Ask the viewer to flush the ticks
*/
flush() {
if (this.isMessagingReady_ && this.isPerformanceTrackingOn_) {
- this.viewer_.flushTicks();
+ this.viewer_.sendMessageCancelUnsent('... | [No CFG could be retrieved] | The functions below are used to measure the time it took to do something yourself. Adds a tick to the queue if it is not already there. | Ditto, const arguments need annotating. |
@@ -77,8 +77,6 @@ public class JwsAnnotationsInstrumentation implements TypeInstrumentation {
Context parentContext = currentContext();
request = new JaxWsRequest(target.getClass(), methodName);
- ServerSpanNaming.updateServerSpanName(
- parentContext, CONTROLLER, JaxWsServerSpanNaming.SER... | [JwsAnnotationsInstrumentation->[typeMatcher->[named,or,isAnnotatedWith],transform->[methodIsDeclaredByType,applyAdviceToMethod,hasSuperMethod,getName,inheritsAnnotation,named,and],classLoaderOptimization->[hasClassesNamed],JwsAnnotationsAdvice->[stopSpan->[decrementAndGet,end,close],startSpan->[start,shouldStart,curre... | Start a new span. | This would have been relevant only when request is handled by a jax-ws framework that we don't have integration with (or when framework instrumentation is disabled or when there is a bug that prevents it from working properly) because jax-ws framework instrumentation runs before it and already sets the name. |
@@ -175,6 +175,7 @@ public class NewIndex {
private final NewIndexType indexType;
private final String fieldName;
private boolean sortable = false, wordSearch = false, gramSearch = false, docValues = false, disableSearch = false;
+ private SortedMap<String, Object> subFields = Maps.newTreeMap();
... | [NewIndex->[NestedObjectBuilder->[build->[setAttribute,setProperty]],createType->[NewIndexType],StringFieldBuilder->[build->[setProperty]],NewIndexType->[createIntegerField->[setProperty],createDynamicNestedField->[setProperty],createShortField->[setProperty],createLongField->[setProperty],createByteField->[setProperty... | This method is used to get a property from the properties map. This field is not searchable but index at all. | out of curiosity, why a SortedMap here? |
@@ -720,7 +720,7 @@ func (c *Config) Client() (interface{}, error) {
r.Retryable = aws.Bool(true)
}
- if r.Operation.Name == "CreateIPSet" || r.Operation.Name == "CreateRegexPatternSet" || r.Operation.Name == "CreateRuleGroup" {
+ if r.Operation.Name == "CreateIPSet" || r.Operation.Name == "CreateRegexPatter... | [PartitionHostname->[Sprintf],RegionalHostname->[Sprintf],Client->[Copy,Printf,StringValue,Println,HasPrefix,IsDebugOrHigher,DefaultPartitions,New,PushBack,String,GetSessionWithAccountIDAndPartition,ValidateAccountID,DNSSuffix,Bool,Code,PartitionForRegion,ValidateRegion],String,DescribeAccountAttributes,Errorf] | Client returns a client for the AWS Hashi Corp API. Found for provider. Creates a new instance of the applicationstream. List all the connections that are managed by the Cloudtrail service. Creates an instance of the Data Exchange service. | Nit: line getting a bit long here, do you mind wrapping onto a newline? |
@@ -21,7 +21,7 @@
<div class="slanty-accent"></div>
<div class="tag-or-query-header-container tag-edit-tag">
<h1> Editing:
- <a href="/t/<%= @tag.name %>" style="color: <%= @tag.text_color_hex %>;text-decoration: underline;"><%= @tag.name %></a>
+ <a href="/t/<%= URL.tag @tag %>" style="color: <%= ... | [No CFG could be retrieved] | Displays a widget for editing a tag. Displays a hidden field with a hidden field with a label and a color field with a text. | forgot to highlight the bug :D this is going to hardcode `/t/` twice |
@@ -243,6 +243,7 @@ public abstract class ExprEval<T>
public final int asInt()
{
if (value == null) {
+ assert NullHandling.replaceWithDefault();
return 0;
}
| [ExprEval->[LongExprEval->[castTo->[asString,of,asDouble],asBoolean->[asLong,asBoolean]],StringExprEval->[castTo->[asLong,of,asDouble],asBoolean->[asBoolean]],of->[of],DoubleExprEval->[castTo->[asLong,asString,of],asBoolean->[asDouble,asBoolean]]]] | Returns the value or 0 if the value is null. | Also need check in line 257 |
@@ -179,7 +179,7 @@ class ReviewablesController < ApplicationController
end
def perform
- args = { version: params[:version].to_i }
+ args = { version: params[:version].to_i, reject_reason: params[:reject_reason], send_email: params[:send_email] == "true" }
result = nil
begin
| [ReviewablesController->[perform->[perform,to_i,new,render_json_error,to_sym,message,raise,success?,render_serialized,claim_error?,t],find_reviewable->[first,raise,new,blank?],show->[claimed_hash,topic_id,serializer,render_serialized],ensure_can_see->[ensure_can_see_review_queue!],explain->[render_serialized,explain_sc... | This action will perform the action specified by action_id and version. | I would prefer if these arguments were only added if they exist and that is the correct reviewable type. |
@@ -126,9 +126,15 @@ def load_pair_history(pair: str,
:param exchange: Exchange object (needed when using "refresh_pairs")
:param fill_up_missing: Fill missing values with "No action"-candles
:param drop_incomplete: Drop last candle assuming it may be incomplete.
+ :param startup_candles: Additional c... | [refresh_backtest_ohlcv_data->[pair_data_filename,download_pair_history],load_data->[load_pair_history],_load_cached_data_for_updating->[load_tickerdata_file],download_trades_history->[store_trades_file,load_trades_file],download_pair_history->[_load_cached_data_for_updating,store_tickerdata_file],load_pair_history->[_... | Load the historical data for a given pair. | `if startup_candles > 0 and` ? -- this will ignore negative values passed |
@@ -596,6 +596,11 @@ class DataflowRunner(PipelineRunner):
debug_options.add_experiment(
'min_cpu_platform=' + worker_options.min_cpu_platform)
+ if pipeline.contains_external_transforms:
+ # All Dataflow multi-language pipelines use portable job submission by
+ # default.
+ debug_... | [_DataflowIterableAsMultimapSideInput->[__init__->[_side_input_data]],_DataflowIterableSideInput->[__init__->[_side_input_data]],DataflowRunner->[run_Flatten->[_get_encoded_output_coder,_add_step],run_Impulse->[_get_encoded_output_coder,_add_step],poll_for_job_completion->[rank_error],run_Read->[_get_cloud_encoding,_ad... | Remotely executes entire pipeline or parts reachable from node. Unified worker. Creates a new node object based on the passed in configuration. Get a object from the job and pipeline. Get a node ID from the pipeline and set its options. | Just to check, this implies runner v2, right? |
@@ -31,7 +31,7 @@ import java.nio.channels.ScatteringByteChannel;
* recommended to use {@link Unpooled#unmodifiableBuffer(ByteBuf)}
* instead of calling the constructor explicitly.
*/
-final class ReadOnlyByteBuf extends AbstractByteBuf implements Unsafe {
+public class ReadOnlyByteBuf extends AbstractByteBuf imp... | [ReadOnlyByteBuf->[getLong->[getLong],duplicate->[ReadOnlyByteBuf],getBytes->[getBytes],slice->[slice,ReadOnlyByteBuf],isDirect->[isDirect],getInt->[getInt],hasNioBuffers->[hasNioBuffers],getByte->[getByte],hasNioBuffer->[hasNioBuffer],copy->[copy],internalNioBuffer->[internalNioBuffer],capacity->[capacity],order->[ord... | Creates a new read - only buffer which can be used to store a single non - empty Checks if the buffer is direct or not. | Why not final ? |
@@ -84,10 +84,10 @@ func BuildKubernetesNodeConfig(options configapi.NodeConfig) (*NodeConfig, error
ClusterDomain: options.DNSDomain,
ClusterDNS: dnsIP,
- VolumeDir: options.VolumeDirectory,
- NetworkContainerImage: options.NetworkContainerImage,
- AllowDisabledDocker: options.AllowDisabled... | [ParseIP,CertPoolFromFile,UseTLS,Errorf,GetKubeClient] | ClusterDomain - returns config object for the specified . | Why not expand to the name right here? Does the node resolve other images? |
@@ -18,6 +18,7 @@ module Idv
log_vendor(vendor, results, stage)
proofer_result = vendor.proof(@applicant)
results = merge_results(results, proofer_result)
+ results[:timed_out] = true if proofer_result.timed_out?
break unless proofer_result.success?
end
| [Agent->[log_vendor->[class,vendor_name,inspect,push],proofer_attribute?->[attribute?],proof->[new,success?,log_vendor,each,merge_results,proof],merge_results->[merge,to_h],initialize->[symbolize_keys]]] | Returns a list of results for a in the applicant. | Style: another option would be `results[:timed_out] = proofer_result.timed_out?` (assuming `#timed_out?` always returns `true` or `false`). |
@@ -16,9 +16,6 @@ import games.strategy.util.MD5Crypt;
public class DbUserControllerIntegrationTest {
- private static final DbTestConnection DERBY =
- new DbTestConnection(Database::getDerbyConnection, new DbUserController());
-
private static final DbTestConnection POSTGRES =
new DbTestConnection... | [DbUserControllerIntegrationTest->[testCreate->[testCreate],testGet->[givenUser,testGet],testDoesUserExistPostgres->[testDoesUserExist],testLoginPostgres->[testLogin],testDoesUserExist->[testDoesUserExist,givenUser],testUpdate->[givenUser,testUpdate],testCreatePostgres->[testCreate],testGetPostgres->[testGet],testLogin... | package for testing purposes only Example of how to create a database with a specific . | This test should probably be renamed to `UserControllerIntegrationTest`. |
@@ -100,15 +100,15 @@ func newIAMUpgradeToV2Cmd() *cobra.Command {
"skip-policy-migration",
false,
"Do not migrate policies from IAM v1.")
+
+ // this flag is deprecated and does nothing but we don't wanna error on it
cmd.PersistentFlags().BoolVar(
&iamCmdFlags.betaVersion,
"beta2.1",
false,
"Upg... | [Title,StringVar,Titlef,ExactArgs,OpenConnection,UpgradeToV2,PoliciesClient,MarkHidden,Wrap,UpdateV2AdminsPolicyIfNeeded,Code,ApplyV2DataMigrations,GetPolicyVersion,ResetToV1,New,MustCompile,EnsureTeam,AddCommand,SplitN,TrimSpace,UpdateV1AdminsPolicyIfNeeded,GetReports,Failf,CloseConnection,ToLower,Successf,Convert,Bod... | newIAMCommand returns a command that will upgrade to a new version of IAM and then reset V1Cmd returns a new cobra. Command for the v1 command. | Only non-testing related changes are in this file. |
@@ -93,6 +93,8 @@ public class DefaultMuleEvent implements MuleEvent, ThreadSafeAccess, Deserializ
private CopyOnWriteCaseInsensitiveMap<String, Object> flowVariables = new CopyOnWriteCaseInsensitiveMap<String, Object>();
+ private MessagingExceptionHandler exceptionHandler;
+
// Constructors
... | [DefaultMuleEvent->[transformMessageToString->[transformMessage],getEncoding->[getEncoding],initAfterDeserialisation->[initAfterDeserialisation],newThreadCopy->[newThreadCopy,DefaultMuleEvent],writeObject->[getFlowConstruct,writeObject],copy->[getSession,newThreadCopy,DefaultMuleEvent,resetAccessControl],equals->[equal... | Creates a new event object with a Universally Unique ID. | This is horrible. Having the exception handler inside the MuleEvent is bad. The MuleEvent doesn't has (or at least shouldn't have) anything to do with the processing context of the message. The MuleEvent should only be a context for the message content and not for the behaviour. At least not for a behaviour that can be... |
@@ -3652,8 +3652,9 @@ class SemanticAnalyzerPass2(NodeVisitor[None]):
Assume that the name is defined. This happens in the global namespace -- the local
module namespace is ignored.
+
+ NOTE: This is only supported for names known to be defined.
"""
- assert '.' in name
... | [infer_condition_value->[infer_condition_value],make_any_non_explicit->[accept],SemanticAnalyzerPass2->[analyze_comp_for->[analyze_lvalue],build_newtype_typeinfo->[named_type],name_not_defined->[add_fixture_note,lookup_fully_qualified_or_none],refresh_class_def->[refresh_class_def],check_classvar->[is_self_member_ref],... | Lookup a fully qualified name. | This note seems to repeat what the start of the previous paragraph also states. |
@@ -1676,7 +1676,8 @@ void Server::SendAddParticleSpawner(session_t peer_id, u16 protocol_version,
pkt.putLongString(texture);
- pkt << id << vertical;
+ pkt << id;
+ pkt << true; // Dummy value for vertical
pkt << collision_removal;
pkt << attached_id;
// This is horrible but required
| [No CFG could be retrieved] | Send to other peer. Send an packet to a specific player. | since the default is `vertical = false`, it should probably be used here instead (since old clients will still interpret this value) |
@@ -2,6 +2,11 @@
#include <stdbool.h>
#include "eeprom.h"
#include "eeconfig.h"
+#include "hal.h"
+
+#ifdef STM32F303xC
+#include "eeprom_stm32.h"
+#endif
/** \brief eeconfig initialization
*
| [eeconfig_update_audio->[eeprom_update_byte],eeconfig_read_default_layer->[eeprom_read_byte],eeconfig_read_audio->[eeprom_read_byte],eeconfig_read_debug->[eeprom_read_byte],eeconfig_update_default_layer->[eeprom_update_byte],eeconfig_read_backlight->[eeprom_read_byte],eeconfig_update_debug->[eeprom_update_byte],eeconfi... | Updates the values of the n - word eeprom with the values from the n - \brief eeconfig_read_debug eeprom_read_byte eeprom. | Looks like this is causing issues. |
@@ -2162,7 +2162,7 @@ def is_jpeg(contents, name=None):
name: A name for the operation (optional)
Returns:
- A scalar boolean tensor indicating if 'contents' may be a JPEG image.
+ A scalar boolean tensor indicating if 'contents' maybe a JPEG image.
is_jpeg is susceptible to false positives.
... | [resize_image_with_pad_v2->[_resize_fn->[resize_images_v2],_resize_image_with_pad_common],resize_bicubic->[resize_bicubic],_resize_images_common->[_ImageDimensions],crop_to_bounding_box->[_assert,_ImageDimensions,_CheckAtLeast3DImage,_is_tensor],resize_image_with_crop_or_pad->[max_->[_is_tensor],equal_->[_is_tensor],mi... | Checks if the contents of a file is a JPEG image. | This should be "may be". Similar in other places downwards |
@@ -344,6 +344,7 @@ namespace System.Runtime.Caching
private MemoryCache()
{
_name = "Default";
+ _disposedName = typeof(MemoryCache).FullName + $"({_name})";
Init(null);
}
| [MemoryCache->[Set->[Set,Dispose,Add,ValidatePolicy],CacheItem->[GetInternal,AddOrGetExistingInternal],Get->[GetInternal],AddOrGetExisting->[AddOrGetExistingInternal],GetValues->[GetInternal],UpdateConfig->[UpdateConfig],SentinelEntry->[OnCacheEntryRemovedCallback->[IsPolicyValid]],Init->[InitDisposableMembers],Contain... | Component which caches the given object. This method is used to create a new cache entry. | You already have the `_name` field so you can construct this string at any time. I suggest creating a `ThrowIfDisposed` method which checks the `IsDisposed` property and the `_throwOnDisposed` field, then constructs the name there. It's only ever used when throwing, so no need to keep it around for the life of the obje... |
@@ -38,9 +38,10 @@ class Opus::Types::Test::Props::ConstructorTest < Critic::Unit::UnitTest
end
it 'raises on unknown props' do
- assert_raises(ArgumentError) do
- MyStruct.new(notathing: 4)
+ err = assert_raises(ArgumentError) do
+ MyStruct.new(name: "Alex", notathing: 4)
end
+ assert_e... | [MyStruct->[nilable,any,prop],Inner->[prop],Outer->[prop],new,assert_equal,message,foo,assert_raises,require_relative,greeting,it,name,map] | check unknown props do not populates props do throw on unknown props do check types do check. | This test was passing but for the wrong reason. An ArgumentError was being raised but because of a `Missing required prop` argument error since `name` was missing. I fixed the test and explicitly tested the error message to ensure this is testing the right thing. |
@@ -82,10 +82,11 @@ class BearerTokenCredentialPolicy(_BearerTokenCredentialPolicyBase, SansIOHTTPPo
def on_request(self, request):
# type: (PipelineRequest) -> None
- """Adds a bearer token Authorization header to request and sends request to next policy.
+ """Called before the policy sen... | [BearerTokenCredentialPolicy->[on_request->[_update_headers,_enforce_https]]] | Adds a bearer token Authorization header to request and sends request to next policy. | How do you think about moving _enforce_https into shared utils? |
@@ -175,7 +175,9 @@ public class DefaultFileSystem implements FileSystem {
@Override
public Iterable<File> files(FilePredicate predicate) {
doPreloadFiles();
- return Iterables.transform(inputFiles(predicate), InputFile::file);
+ return () -> StreamSupport.stream(inputFiles(predicate).spliterator(), fa... | [DefaultFileSystem->[inputDir->[inputDir],files->[inputFiles],Cache->[add->[doAdd]],add->[add],MapCache->[doAdd->[add]],languages->[languages]]] | Returns files that match the given predicate. | Do you really need "() -> " ? |
@@ -501,6 +501,8 @@ class ApproximateQuantilesCombineFn(CombineFn, Generic[T]):
weighted: (optional) if set to True, the combiner produces weighted
quantiles. The input elements are then expected to be tuples of input
values with the corresponding weight.
+ batch_input: (optional) if set to True, ... | [ApproximateQuantilesCombineFn->[merge_accumulators->[create_accumulator,_comparator,_collapse_if_needed,_add_unbuffered,is_empty],create_accumulator->[_QuantileState],_collapse_if_needed->[_collapse],add_inputs->[_comparator,is_empty,_add_unbuffered],_interpolate->[sized_iterator],add_input->[_comparator,is_empty,_add... | This function is used to evaluate the quantiles of a given number of elements in a data Initialize a _QuantileState object from a sequence of _QuantileState objects. | Re: line 766: could you please clarify what is N in the docstring Also, can you please note that the algorithm referenced in the paper is generalized to compute weighted quantiles. |
@@ -99,7 +99,9 @@ public class PhysicalPlanBuilder {
throw new RuntimeException("Unexpected output node for query");
}
- public QueryMetadata buildPhysicalPlan(final LogicalPlanNode logicalPlanNode) {
+ public QueryMetadata buildPhysicalPlan(
+ final LogicalPlanNode logicalPlanNode,
+ final Servic... | [PhysicalPlanBuilder->[buildStreamsProperties->[updateListProperty],buildPhysicalPlan->[computeQueryId]]] | Compute the query id for a logical plan. Node creates a new node from the given node logical node output node and persistance query prefix. | nit: `serviceContext` doesn't seem to be used. |
@@ -171,18 +171,8 @@ class OddsCalculatorPanel extends JPanel {
updateDefender(null);
updateAttacker(null);
}
- if (OddsCalculatorPanel.percentageOfFreeMemoryAvailable() < 0.4) {
- System.gc();
- System.runFinalization();
- System.gc();
- }
calculator = new ConcurrentOddsCal... | [OddsCalculatorPanel->[PlayerRenderer->[getListCellRendererComponent->[getListCellRendererComponent]],updateAttacker->[getAttacker],shutdown->[shutdown],UnitPanel->[addChangeListener,notifyListeners],setupListeners->[mouseMoved->[freeMemoryAvailable,percentageOfFreeMemoryAvailable],getDefender,shutdown,getSwapSides,get... | Sets the selected item in the odds calculator panel. private static method to calculate free memory available. | This delayed enabling of the button is actually not working, because setGameData is a blocking method AFAIK and therefore this JFrame is getting displayed after the gamedata has been loaded EDIT: The setGameData method of ConcurrentOddsCalculator is not blocking it seems, so the behaviour is slightly altered. Not sure ... |
@@ -16,7 +16,7 @@ includedir=${prefix}/include
Name: my-project
Description: Some brief but informative description
Version: 1.2.3
-Libs: -L${libdir} -lmy-project-1 -linkerflag -Wl,-rpath=${libdir}
+Libs: -L${libdir} -lmy-project-1 -linkerflag
Cflags: -I${includedir}/my-project-1
Requires: glib-2.0 >= 2.40 gio-2.0... | [PkgConfigGenerator->[content->[_get_components]]] | A class that provides a function to generate a package - level configuration. Get the public dependencies of the package. | The thing is that if this is here, it was probably requested by some users, and it might be breaking for them. Maybe it would be better to not touch the ``pkg_config`` and only change ``PkgConfigDeps`` Also taking into account that other generators, like autotools (both the legacy and the new ``conan.tools.gnu`` ones) ... |
@@ -49,9 +49,9 @@ namespace System.Reflection.TypeLoading
// Equality - this compares every bit of data in the RuntimeAssemblyName which is acceptable for use as keys in a cache
// where semantic duplication is permissible. This method is *not* meant to define ref->def binding rules or
// ass... | [RoAssemblyName->[Equals->[Equals],GetHashCode->[GetHashCode]]] | Equals returns true if this name is equal to the given name version and locale. | :memo: not sure what to do here #Resolved |
@@ -145,6 +145,7 @@ def write_buildinfo_file(prefix, workdir, rel=False):
prefix, spack.store.layout.root)
buildinfo['relocate_textfiles'] = text_to_relocate
buildinfo['relocate_binaries'] = binary_to_relocate
+ buildinfo['relocate_links'] = link_to_relocate
filename = buildinfo_file_name(wor... | [make_package_relative->[read_buildinfo_file],make_package_placeholder->[read_buildinfo_file],tarball_path_name->[tarball_name,tarball_directory_name],build_tarball->[tarball_name,checksum_tarball,NoOverwriteException,tarball_directory_name,tarball_path_name,sign_tarball,write_buildinfo_file,generate_index],read_buildi... | Write buildinfo data to disk. | I'm curious why this data is retained to be handled later, after the binary cache is unpacked. The binaries/textfiles, may contain absolute links, they are currently maintained as such, so therefore this bookkeeping is necessary. Is there any reason the binary cache cannot be created with the symlinks relative-ized? |
@@ -32,7 +32,7 @@ import games.strategy.triplea.Constants;
import games.strategy.triplea.ResourceLoader;
import games.strategy.triplea.image.UnitImageFactory;
import games.strategy.ui.Util;
-import games.strategy.util.PointFileReaderWriter;
+import tools.map.making.PointFileReaderWriter;
/**
* contains data abo... | [MapData->[getBoundingRect->[getBoundingRect,scrollWrapY,scrollWrapX,getMapDimensions],getKamikazeMarkerLocation->[getCenter],getTerritoryEffectPoints->[getCenter],close->[close],getCapitolMarkerLocation->[getCenter],getDefaultUnitCounterOffsetWidth->[getDefaultUnitWidth],getBoundingRectWithTranslate->[scrollWrapX,scro... | Imports the data of the map. region PropertyNames for hotspot. | Thoughts on MapData importing from tools package? Any clean way to avoid that? |
@@ -1440,8 +1440,15 @@ module.exports = class bitfinex2 extends bitfinex {
}
tag = this.safeString (data, 3);
type = 'withdrawal';
- } else {
+ } else if (transactionLength === 22) {
id = this.safeString (transaction, 0);
+ if (currency !== un... | [No CFG could be retrieved] | Parse a single transaction record. Return the object that represents the next block of block. | Comparing the size of the array to 22 doesn't look totally right to me. Is this intentional? Or what is the logic behind it? |
@@ -649,6 +649,7 @@ class Flow(Serializable):
downstream_tasks: Iterable[object] = None,
keyword_tasks: Mapping[str, object] = None,
validate: bool = None,
+ mapped_tasks=None,
) -> None:
"""
Convenience function for adding task dependencies on upstream tasks.
| [Flow->[copy->[copy],upstream_tasks->[edges_to],update->[add_edge,add_task],reference_tasks->[terminal_tasks],chain->[add_edge],edges_to->[all_upstream_edges],set_dependencies->[add_edge,add_task],run->[parameters,run],edges_from->[all_downstream_edges],generate_local_task_ids->[all_upstream_edges,sorted_tasks,copy,ser... | Convenience function for adding task dependencies on upstream tasks. key = key validate = validate. | As above, validate should be the last argument in the signature |
@@ -337,7 +337,7 @@ zfs_sa_upgrade(sa_handle_t *hdl, dmu_tx_t *tx)
SA_ADD_BULK_ATTR(sa_attrs, count, SA_ZPL_SIZE(zsb), NULL,
&zp->z_size, 8);
SA_ADD_BULK_ATTR(sa_attrs, count, SA_ZPL_GEN(zsb),
- NULL, &zp->z_gen, 8);
+ NULL, &(ZTOI(zp)->i_generation), 8);
SA_ADD_BULK_ATTR(sa_attrs, count, SA_ZPL_UID... | [No CFG could be retrieved] | Adds bulk layout number attributes to the layout header. count - number of unique attributes in ZFS - ACL - cached Access control list. | This is wrong, i_generation is only 4 bytes long. This will corrupt the inode. |
@@ -2451,6 +2451,14 @@ class ExpressionChecker(ExpressionVisitor[Type]):
else:
return result
+ # We finish invoking above operators and no early return happens. Therefore,
+ # we check if either the LHS or the RHS is Instance and fallbacks to Any,
+ # if so, we also ... | [ExpressionChecker->[visit_star_expr->[accept],analyze_ordinary_member_access->[analyze_ref_expr],check_overload_call->[check_call,infer_arg_types_in_empty_context],visit_await_expr->[accept],check_any_type_call->[infer_arg_types_in_empty_context],erased_signature_similarity->[check_argument_count,check_argument_types]... | Checks if a given operation is reversible. Get the full name of the node where the node is missing. This method is called to filter out all non - existent operators and return a list of all This method is called in the Python interpreter to order the missing CNV objects in the system. | I'm not sure if `special_form` is the right thing here but I'm not totally sure what else to do. `from_another_any` is correct but digging out the other any is almost certainly not worth bothering. |
@@ -424,7 +424,7 @@ class PaddingUtils(object):
using valid_inds.
report_freq -- how often we report predictions
"""
- predictions = predictions.cpu()
+ predictions = predictions.cpu().data
for i in range(len(predictions)):
# map the predictions back ... | [PaddingUtils->[pad_text->[valid]],ProgressLogger->[log->[humanize,time],__init__->[time]],round_sigfigs->[round_sigfigs],maintain_dialog_history->[parse],Timer->[time->[time]],NoLock] | Map predictions back to appropriate indices in the batch_reply using valid_inds. | does there need to be some check whether you are cpu or gpu or this doesnt affect performance for cpu? |
@@ -3,10 +3,14 @@
# Licensed under the MIT License. See License.txt in the project root for license information.
# --------------------------------------------------------------------------------------------
+from typing import TYPE_CHECKING, Union, Any # pylint: disable=unused-import
from threading import Lock
... | [get_connection_manager->[_SeparateConnectionManager,_SharedConnectionManager]] | Creates a connection object for the given object. Returns a connection object that can be used to access the network. | Same, all uamqp import should be tried with uamqp in the path, or start mypy with --ignore-missing-imports |
@@ -27,8 +27,16 @@ export default DropdownSelectBoxComponent.extend({
name: I18n.t("post.bookmarks.actions.edit_bookmark.name"),
description: I18n.t("post.bookmarks.actions.edit_bookmark.description"),
},
+ {
+ id: "pin",
+ icon: "thumbtack",
+ name: I18n.t(`post.bookm... | [No CFG could be retrieved] | Events for the bookmarks. | Might be worth having const for these string identifiers |
@@ -127,10 +127,12 @@ function jetpack_photon_url( $image_url, $args = array(), $scheme = null ) {
$image_host_path = $image_url_parts['host'] . $image_url_parts['path'];
- // Figure out which CDN subdomain to use
- srand( crc32( $image_host_path ) );
- $subdomain = rand( 0, 2 );
- srand();
+ // Figure out which ... | [No CFG could be retrieved] | Photon image url processing Photon specific image processing Photon can use query strings in a different way. Photon can use query Photon server dependent. | This file is synced on wp.com in mu-plugins, so need to do something WP.com-safe. `Jetpack_Options:get_option( 'id')` will return `false` / `0` for all sites. |
@@ -18,7 +18,7 @@ public class UnpooledOffHeapMemoryAllocator implements OffHeapMemoryAllocator {
private static final Log log = LogFactory.getLog(UnpooledOffHeapMemoryAllocator.class, Log.class);
private static final boolean trace = log.isTraceEnabled();
private static final OffHeapMemory MEMORY = OffHeapM... | [UnpooledOffHeapMemoryAllocator->[allocate->[allocate],deallocate->[deallocate]]] | Injects the nanoseconds into the offHeapEntryFactory. | This is a good step, but I wonder if we could eliminate it completely when the data container is configured with MEMORY eviction. |
@@ -1007,7 +1007,7 @@ class Dataset(object):
return ParallelMapDataset(self, map_func, num_parallel_calls)
def flat_map(self, map_func):
- """Maps `map_func` across this dataset and flattens the result.
+ """Maps `map_func` across this dataset and flattens the result. Will produce identical results to... | [TakeDataset->[_as_variant_tensor->[_as_variant_tensor,flat_structure]],SkipDataset->[_as_variant_tensor->[_as_variant_tensor,flat_structure]],RangeDataset->[_as_variant_tensor->[flat_structure]],StructuredFunctionWrapper->[_defun_args->[zip],__init__->[tf_data_structured_function_wrapper->[_as_variant_tensor,zip,_Vari... | Maps map_func across this dataset and flattens the result. a is raised. | I think this change might confuse readers. The output of `Dataset.flat_map()` is only identical to `Dataset.interleave()` when `cycle_length=1` (which is an unusual configuration, since it doesn't actually interleave any inputs!). I'm not sure it's worth introducing that concept to readers here. Additional nits: * By P... |
@@ -37,7 +37,8 @@ from tensorflow.python.framework import ops
from tensorflow.python.framework import sparse_tensor
from tensorflow.python.ops import array_ops
from tensorflow.python.ops import control_flow_ops
-from tensorflow.python.ops import logging_ops
+#from tensorflow.python.ops import logging_ops
+from tenso... | [_class_id_labels_to_indicator->[_assert_labels_rank],_MultiLabelHead->[create_model_fn_ops->[_create_model_fn_ops,_logits,_transform_labels],_transform_labels->[_sparse_labels_to_indicator,_to_labels_tensor]],_LossOnlyHead->[create_model_fn_ops->[_loss_fn]],_streaming_precision_at_threshold->[_float_weights_or_none],_... | Implementation of the base class for all objects in a model. This is a helper method for the MCI of the MCI trees. | please remove entirely if not needed. |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.