patch stringlengths 18 160k | callgraph stringlengths 4 179k | summary stringlengths 4 947 | msg stringlengths 6 3.42k |
|---|---|---|---|
@@ -11,7 +11,8 @@ var minErr = function minErr (module, constructor) {
};
};
-var $q = qFactory(process.nextTick, function noopExceptionHandler() {});
+var noop = function() {};
+var $q = qFactory(noop, process.nextTick, noop);
exports.resolved = $q.resolve;
exports.rejected = $q.reject;
| [No CFG could be retrieved] | Create a promise - like object that can be used to resolve or reject a promise. | this doesn't look right. qFactory signature is `function qFactory(nextTick, exceptionHandler) {` no? |
@@ -251,6 +251,9 @@ public class ITAutoCompactionTest extends AbstractIndexerTest
null);
compactionResource.submitCompactionConfig(compactionConfig);
+ // Wait for compaction config to persist
+ Thread.sleep(2000);
+
// ... | [ITAutoCompactionTest->[forceTriggerAutoCompaction->[forceTriggerAutoCompaction],deleteCompactionConfig->[deleteCompactionConfig],updateCompactionTaskSlot->[updateCompactionTaskSlot],submitCompactionConfig->[submitCompactionConfig]]] | Submits a compaction config to the compaction resource. | nit: it would be better to check the compaction config is set by calling the compaction config API. |
@@ -513,11 +513,13 @@ func (h *Handler) AddTransferRegionOperator(regionID uint64, storeIDs map[uint64
}
peers := make(map[uint64]*metapb.Peer)
- for id := range storeIDs {
- peers[id] = &metapb.Peer{StoreId: id}
+ roles := make(map[uint64]placement.PeerRoleType)
+ for id, role := range storeIDsAndRoles {
+ pee... | [AddLabelScheduler->[AddScheduler],AddRandomMergeScheduler->[AddScheduler],GetHistory->[GetOperatorController,GetHistory],GetOperatorsOfKind->[GetOperators],GetSchedulerConfigHandler->[GetRaftCluster],GetHotReadRegions->[GetRaftCluster,GetHotReadRegions],GetHotBytesReadStores->[GetRaftCluster],AddAddPeerOperator->[GetO... | AddTransferRegionOperator creates a move region operator for a given region and stores. | I think we can add some check to make sure there is at most 1 "leader" and there are at least 1 "leader" or "voter". |
@@ -59,6 +59,13 @@ def test_uninstall_namespace_package():
the namespace and everything in it.
"""
+ # This test is skipped on Python 3 because the installation fails.
+ # The reason it fails is that distribute has a bug: setuptools/extension.py
+ # has the line "from dist import _get_unpatched". T... | [test_uninstallpathset_no_paths->[get_distribution,assert_any_call,patch,remove,UninstallPathSet],test_uninstall_as_egg->[abspath,str,run_pip,join,reset_env,assert_all_changes],test_uninstall_from_reqs_file->[dedent,local_checkout,run_pip,write_file,reset_env,assert_all_changes],test_uninstall_editable_with_source_outs... | Test uninstalls a namespace package without clobbering it. | was this failing in travis? not following why this would have only failed in your branch? |
@@ -31,7 +31,9 @@ class Subversion(Package):
url = 'http://archive.apache.org/dist/subversion/subversion-1.8.13.tar.gz'
version('1.8.13', '8065b3698d799507fb72dd7926ed32b6')
+ version('1.8.17', 'd1f8d45f97168d6271c58c5b25421cc32954c81b')
version('1.9.3', 'a92bcfaec4e5038f82c74a7b5bbd2f46')... | [Subversion->[install->[join_path,satisfies,append,working_dir,perl,configure,which,make],variant,depends_on,version,extends]] | Creates a new object with all the necessary information. Package that contains the necessary dependencies for the NI - specific packages. | Can you put these in order from newest to oldest? |
@@ -195,8 +195,7 @@ class TokenNetwork:
block_identifier=block,
)
if channel_created:
- return True, 'Channel with given partner address already exists'
- return False, ''
+ raise DuplicatedChannelError('Channel with given partner address already exists')
... | [TokenNetwork->[all_events_filter->[events_filter],_check_channel_state_before_settle->[detail_channel],update_transfer->[channel_is_settled,_update_preconditions,detail_channel],new_netting_channel->[_new_channel_preconditions,_new_channel_postconditions],_check_channel_state_after_settle->[_check_channel_state_before... | Internal method to check the postconditions for a new channel. This method is called from the channel_open_channel method. | Looks good, but since you changed the semantics of this function to not return but raise can you also change the returned type? |
@@ -4,6 +4,7 @@ define([
'../Core/IndexDatatype',
'../Core/RuntimeError',
'../ThirdParty/draco-decoder-gltf',
+ '../ThirdParty/GltfPipeline/byteLengthForComponentType',
'./createTaskProcessorWorker'
], function(
ComponentDatatype,
| [No CFG could be retrieved] | Define the functions that are used to decode the . This method is used to determine the maximum value. | It doesn't matter in terms of functionality, but use the Cesium version instead: `ComponentDatatype.getSizeInBytes` |
@@ -51,7 +51,7 @@ class EmbeddedFormulation(object):
self.condition_name = "NavierStokesWallCondition"
self.level_set_type = formulation_settings["level_set_type"].GetString()
self.element_integrates_in_time = True
- self.element_has_nodal_properties = True
+ self.element_has_no... | [NavierStokesEmbeddedMonolithicSolver->[__UpdateFMALEStepCounter->[_FmAleIsActive,__IsFmAleStep],__CreateDistanceModificationProcess->[__GetDistanceModificationDefaultSettings],Initialize->[SetProcessInfo,Initialize],__init__->[EmbeddedFormulation],__SetVirtualMeshValues->[__GetFmAleUtility,__IsFmAleStep],__UndoFMALEOp... | Sets up the classic embedded NavierStokes. | Do you still need this in embedded solver? All of them get these from elemental properties ryt? |
@@ -253,6 +253,8 @@ public class TransformQuantifiedComparisonApplyToCorrelatedJoin
case GREATER_THAN:
case GREATER_THAN_OR_EQUAL:
return false;
+ default:
+ // Caller guarantees no other cas... | [TransformQuantifiedComparisonApplyToCorrelatedJoin->[Rewriter->[rewriteUsingBounds->[combineDisjuncts,of,getBoundComparisons,combineConjuncts,GenericLiteral,SearchedCaseExpression,toSymbolReference,NullLiteral,apply,toSqlType,getQuantifier,WhenClause,SimpleCaseExpression,ComparisonExpression,Cast],shouldCompareValueWi... | Checks if the given quantifier and operator are equal with a lower bound. | does this mean we should throw here? |
@@ -301,8 +301,12 @@ namespace System.Diagnostics
if (pi[j].ParameterType != null)
typeName = pi[j].ParameterType.Name;
sb.Append(typeName);
- sb.Append(' ');
- sb.Append(pi[j... | [StackTrace->[TryResolveStateMachineMethod->[StateMachineType,GetDeclaredMethods,Public,candidateMethod,DeclaredOnly,NonPublic,GetMethods,Assert,DeclaringType,Static,Instance],ToString->[GetFileLineNumber,ShowInStackTrace,Word_At,TrailingNewLine,TryResolveStateMachineMethod,StackTrace_InFileLineNumber,IsGenericMethod,A... | Append the string representation of this state machine. Append the name of the unknown type. Append the contents of the stack trace that is not part of the exception stack trace. | Possible future improvement: I vaguely remember discussing this: Would it make sense to add RUC onto the `ParameterInfo.Name`? I know it can be null even without trimming, but it is an observable difference with trimming. |
@@ -75,8 +75,10 @@ namespace Dynamo.PackageManager
throw new Exception(Properties.Resources.PackageEmpty);
}
- var packagesDirectory = dynamoModel.PathManager.DefaultPackagesDirectory;
- var installedPath = BuildInstallDirectoryString(packagesDirectory);
+ ... | [PackageDownloadHandle->[Extract->[BuildInstallDirectoryString],Error->[Error]]] | Extract a package from the given DynamoModel. | For `string`, use `String.IsNullOrEmpty(installDirectory)` instead. |
@@ -1210,6 +1210,15 @@ define([
return globeDepth;
}
+ function getPickDepth(scene, context, index) {
+ var pickDepth = scene._pickDepths[index];
+ if (!defined(pickDepth)) {
+ pickDepth = new PickDepth(context);
+ scene._pickDepths[index] = pickDepth;
+ }
+... | [No CFG could be retrieved] | Creates a potential visible set of commands. get user culling volume minus the far plane. | We don't need to pass `context`, right? Just use `scene.context`. |
@@ -55,6 +55,18 @@ func (v *Vars) Replace(value string) (Node, error) {
}
set := false
for _, val := range vars {
+ for name, provider := range v.fetchContextProviders {
+ if varPrefixMatched(val.Value(), name) {
+ fetchProvider := provider.(composable.FetchContextProvider)
+ fval, _ := fet... | [Replace->[Value,String,FindAllSubmatchIndex,Errorf],Lookup->[Lookup],Contains,IsSpace,Errorf,MustCompile,SplitN] | Replace replaces all variables in the given string with the corresponding nodes. Returns a new object that can be used to create a new object. | I think this should ensure that the value did exist before setting `set` to true. We would want the `ErrNoMatch` to be raised if that secret didn't exist. If the template is okay with it not matching it could provide a default to ensure that the `ErrNoMatch` doesn't occur. |
@@ -80,7 +80,6 @@ define([
ClearCommand,
PassState) {
"use strict";
- /*global ArrayBuffer,Uint8Array,Uint32Array*/
function _errorToString(gl, error) {
var message = 'OpenGL Error: ';
| [No CFG could be retrieved] | The functions below are defined in the spec. Creates a function that throws an error if the GL function is not supported. | Yeah I didn't think we needed this, but we did at some point. What changed? |
@@ -1,6 +1,8 @@
class YoutubeTag < LiquidTagBase
PARTIAL = "liquids/youtube".freeze
- REGISTRY_REGEXP = %r{https?://(www\.)?youtube\.(com|be)/(embed|watch)?(\?v=)?(/)?[a-zA-Z0-9_-]{11}((\?t=)?(\d{1,})?)?}
+ # rubocop:disable Layout/LineLength
+ REGISTRY_REGEXP = %r{https?://(www\.)?(youtube\.com|youtu\.be)?/(emb... | [YoutubeTag->[render->[render],valid_id?->[match?],translate_start_time->[fetch,split,to_i,match?,each_with_index],extract_youtube_id->[raise,nil?,split],parse_id_or_url->[valid_id?,zero?,include?,raise,extract_youtube_id,translate_start_time,delete],initialize->[strip,parse_id_or_url],freeze],register,register_tag] | Creates a new YouTube tag. Check if the given ID is a valid tag. | nitpick: change the youtube urls seems like it's not related to the vimeo embed changes, this could have been a second PR (or included separate instructions to test the change with a YT link)? the issue fixed here appears to be youtu.be/ urls were not matched correctly. |
@@ -146,6 +146,8 @@ namespace DSCPython
public static class CPythonEvaluator
{
private const string DynamoSkipAttributeName = "__dynamoskipconversion__";
+ private const string DynamoPrintFuncName = "__dynamoprint__";
+ private const string NodeName = "__pythonnodename__";
stat... | [DynamoCPythonHandleComparer->[Equals->[Equals],GetHashCode->[GetHashCode]],CPythonEvaluator->[ProcessAdditionalBindings->[Equals],GetTraceBack->[ToString],DynamoCPythonHandle->[ToString->[],Dispose->[],ToString],ToString,Equals],DynamoCPythonHandle->[ToString->[ToString],Dispose->[ToString]]] | Creates a new object which can be used to evaluate a Python script with a specific name. region Thread - local functions. | Can we name this `__dynamonodename__` instead? That way it is consistent with the other variables we are adding. |
@@ -470,11 +470,14 @@ These Fields are not added below (yet). They are here to for bug search.
* @brief SQL join for contacts that are needed for displaying items
*/
function item_joins() {
- return "STRAIGHT_JOIN `contact` ON `contact`.`id` = `item`.`contact-id` AND
- (NOT `contact`.`blocked` OR `contact`.`pendi... | [best_link_url->[get_hostname],localize_item->[attributes],get_responses->[getId],conversation->[getTemplateData,addParent]] | Joins the contact - related records for all items. | Please include a check for "self" - because otherwise you won't see your own postings anymore. (The "self" contact has got an undefined "rel" value) |
@@ -227,6 +227,7 @@ namespace Dynamo.Controls
TabItem tab = new TabItem();
tab.Header = viewExtension.Name;
tab.Tag = viewExtension.GetType();
+ tab.Uid = viewExtension.UniqueId;
tab.HeaderTemplate = tabDynamic.FindResource("TabHeader") ... | [DynamoView->[DynamoView_Unloaded->[UnsubscribeNodeViewCustomizationEvents],CloseTab->[CloseTab],OnCollapsedRightSidebarClick->[updateCollapseIcon],DynamoViewModelRequestShowPackageManagerSearch->[DisplayTermsOfUseForAcceptance],Log->[Log],WindowClosing->[PerformShutdownSequenceOnViewModel],OnCollapsedLeftSidebarClick-... | Adds a tab item if it is not already present in the right - side bar. | are we going to stick to name or use this? |
@@ -65,12 +65,12 @@ public abstract class ExtensionComponent implements MuleContextAware, MetadataAw
@Inject
private MuleMetadataManager metadataManager;
- protected ExtensionComponent(RuntimeExtensionModel extensionModel, RuntimeComponentModel componentModel, String configurationProviderName, ExtensionM... | [ExtensionComponent->[getConfigurationProvider->[getConfigurationProvider],getMetadata->[getMetadata],getConfiguration->[getConfiguration],getMetadataKeys->[getMetadataKeys]]] | Creates an extension component that can be used to manage a Mule instance. | why should the Mediator be exposed like this? |
@@ -90,8 +90,8 @@ public class GrizzlyServer implements Server
return this.listenerRegistry.addRequestHandler(this, requestHandler, listenerRequestMatcher);
}
- public void cleanIdleConnections()
+ public void setCleanIdleConnections()
{
- transport.setKeepAlive(false);
+ should... | [GrizzlyServer->[addRequestHandler->[addRequestHandler]]] | Add a request handler to the listener. | Is this the only case where this method is used? |
@@ -192,12 +192,16 @@ public abstract class AbstractListProcessor<T extends ListableEntity> extends Ab
" However additional DistributedMapCache controller service is required and more JVM heap memory is used." +
" See the description of 'Entity Tracking Time Window' property fo... | [AbstractListProcessor->[listByTrackingTimestamps->[getKey,persist],customValidate->[customValidate],migrateState->[getPersistenceFile],listByTrackingEntities->[createAttributes,performListing,getStateScope]]] | This strategy tracks the latest timestamp of listed entity to determine new or updated entities. | I'd probably try to be even more descriptive here... I think it's worth saying that the same files will be listed at each execution of this processor, and that it's recommended to change the default run schedule value. |
@@ -209,8 +209,14 @@ export class ViewportImpl {
// https://github.com/ampproject/amphtml/issues/30838 for more details.
// The solution is to make a "fake" scrolling API call.
const isIframedIos = Services.platformFor(win).isIos() && isIframed(win);
- if (isIframedIos) {
- this.ampdoc.whenReady(... | [No CFG could be retrieved] | Adds classes i - amphtml - embedded i - amphtml - standalone i - iframe - This method is used to set the visibility of the resource. | Can we just check if `ampdoc.isSingleDoc()`? |
@@ -222,7 +222,7 @@ MIN_TAG_LENGTH = 2
MAX_CATEGORIES = 2
VALID_CONTRIBUTION_DOMAINS = (
'donate.mozilla.org', 'micropayment.de', 'patreon.com', 'paypal.com',
- 'paypal.me',
+ 'paypal.me', 'opencollective.com'
)
# Icon upload sizes
| [compile,_,namedtuple] | A slug to ID map for the search API. Return a dictionary of all the items in the n - tuple that can be used to display. | We should start sorting this alphabetically, to be honest, otherwise, this looks good. |
@@ -165,3 +165,7 @@ end
Then("I wait for {int} sec") do |sec|
sleep sec
end
+
+Given("default screen size") do
+ page.driver.browser.manage.window.resize_to(1920,1080) if defined?(page.driver.browser.manage)
+end
| [visit,update_attribute,fetch,create,find,have_xpath,have_current_path,join,should,to,have_content,click_button,click_link,set,click,find_by_id,user,sleep,execute_script,click_on,id,within,within_frame,find_by_email,not_to,send_keys,seed_demo_data,find_by_name,attach_file] | Wait for a number of seconds. | Layout/SpaceAfterComma: Space missing after comma. |
@@ -136,6 +136,15 @@ void AddCustomProcessesToPython(pybind11::module& m)
.def("ComputeFlowOverBoundary", &MassConservationCheckProcess::ComputeFlowOverBoundary)
;
+ py::class_<ShockDetectionProcess, ShockDetectionProcess::Pointer, Process>
+ (m, "ShockDetectionProcess")
+ .def(py::init < ModelPart... | [AddCustomProcessesToPython->[]] | Add custom processes to Python module. Order of initialization in order to avoid circular dependency. Magic number. | It is a process, so you should use the functions of the process, not add new ones to the API (i mean, otherwise it would be an utility) |
@@ -370,13 +370,7 @@ def monkey_patch_variable():
setattr(Variable, method_name, method_impl)
else:
import paddle.tensor
- variabel_methods = paddle.tensor.linalg.__all__ + \
- paddle.tensor.math.__all__ + \
- paddle.tensor.logic.__al... | [monkey_patch_variable->[create_tensor_with_batchsize->[create_new_tmp_var,current_block],_binary_creator_->[__impl__->[create_tensor_with_batchsize,current_block,create_new_tmp_var,create_scalar,astype,safe_get_dtype,create_tensor]],_scalar_add_->[_scalar_op_],_scalar_div_->[_scalar_op_],current_block->[current_block]... | Monkey patch Variable to provide a non - constant non - constant value. This function creates a new variable with a new data type if the variable is not in the Add a non - zero - valued non - zero - valued non - zero - valued non can only guarantee the numerical accuracy of 6 digits after the decimal point. | Only some of the methods of `paddle.Tensor` is created by `_binary_creator_` (those listed above as `variable_methods`), other methods are just the independent functions with the same name. These may not be binary methods. I suggest changing the name. |
@@ -201,6 +201,18 @@ class Theme < ActiveRecord::Base
expire_site_cache!
end
+ def self.allowed_remote_theme_ids
+ return nil if GlobalSetting.allowed_theme_repos.blank?
+
+ @allowed_remote_theme_ids ||= begin
+ urls = GlobalSetting.allowed_theme_repos.split(",").map(&:strip)
+ Theme
+ ... | [Theme->[add_relative_theme!->[clear_cache!],all_theme_variables->[transform_ids],set_field->[targets],clear_default!->[expire_site_cache!],component_validations->[default?],resolve_baked_field->[compiler_version,update_javascript_cache!],theme_ids->[get_set_cache],transform_ids->[get_set_cache,is_parent_theme?],switch... | Returns all theme ids that are not default theme. | I think this class-level memoized value is still going to be shared between different databases in a multisite cluster? Maybe we could use Theme.cache? (Uses DistributedCache, which has built-in multisite logic) Or alternatively we could memoize it per-db. IIRC we do this for the value of `Discourse.system_user` Also, ... |
@@ -83,8 +83,7 @@ func readFrameHeader(data []byte) (ret *AmqpFrame, err bool) {
logp.Warn("Missing frame end octet in frame, discarding it")
return nil, true
}
- frame.Type = data[0]
- frame.channel = binary.BigEndian.Uint16(data[1:3])
+ frame.Type = frameType(data[0])
if frame.size == 0 {
//frame content... | [decodeHeaderFrame->[Uint64,Warn],amqpMessageParser->[decodeHeaderFrame,decodeBodyFrame,decodeMethodFrame,Warn],decodeMethodFrame->[Uint16,Warn,Debug],handleAmqp->[handleAmqpResponse,IPPort,handlePublishing,FindProcessesTuple,handleDelivering,mustHideCloseMethod,handleAmqpRequest],Unix,Warn,Format,Uint64,Uint16,Uint32] | Read a method header from the input stream and return a new message. Returns true if the message was received false if it was not. | What happened to this line? |
@@ -169,6 +169,9 @@ function adoptShared(global, opts, callback) {
/**
* Registers an extended element and installs its styles.
+ * @param {string} name
+ * @param {!Function} implementationClass
+ * @param {string=} opt_css
* @const
*/
global.AMP.registerElement = opts.registerElement.bind(nu... | [No CFG could be retrieved] | Registers an extended element and installs its styles. Sets the function to forward tick events to. | is this right? or `function(new: T)`? |
@@ -18,6 +18,7 @@ import (
"github.com/cortexproject/cortex/pkg/querier/series"
"github.com/cortexproject/cortex/pkg/tenant"
+ sl "github.com/cortexproject/cortex/pkg/util/spanlogger"
)
const (
| [test->[Err,Select,Next],LabelNames->[matrix],Next->[Next],At->[At],LabelValues->[matrix],Select->[matrix],test,Err,LabelNames,Warnings,LabelValues,Select,Querier] | Tenantfederation imports a mockTenantQueryableWithFilter from cipd. matrix returns a matrix of the mock s . | I think I wouldn't rename the import necessarily. What is your thinking there? |
@@ -660,6 +660,12 @@ public class SaltUtils {
String key = result.keySet().iterator().next();
serverAction.setResultMsg(result.get(key).getAsJsonObject().get("comment").getAsString());
}
+ else if (action instanceof BaseVirtualizationPoolAction) {
+ // Tell VirtNotif... | [SaltUtils->[updateSystemInfo->[updateSystemInfo],createImagePackageFromSalt->[createImagePackageFromSalt,parsePackageEvr],prerequisiteIsCompleted->[prerequisiteIsCompleted],decodeSaltErr->[decodeStdMessage],applyChangesFromStateApply->[applyChangesFromStateModule],packageToKey->[packageToKey],SaltUtils]] | Updates the server action with the given parameters. Create the result of the action based on the action status. This method is called when the action is executed successfully. This method is called when a channel task is executed. | How big is typically the job result (in case of both success and error)? (I suppose it's pretty small.) |
@@ -457,6 +457,9 @@ class TrainLoop:
except KeyboardInterrupt:
pass
+ def _safe_report(self, report):
+ return {k: v.value() if isinstance(v, Metric) else v for k, v in report.items()}
+
def _save_train_stats(self, suffix=None):
fn = self.opt['model_file']
... | [TrainLoop->[train->[_maybe_load_eval_worlds,save_model,validate,log,run_eval],_average_dicts->[_average_dicts],validate->[_maybe_load_eval_worlds,_save_best_valid,save_model,run_eval],_sync_training_metrics->[_average_dicts],_nice_format->[_nice_format],log->[_nice_format,_compute_eta,_cleanup_inaccurate_metrics,_sync... | Save the model to disk possibly with a suffix. | This might be more generally useful as a helper function beyond train_model.py, I wonder |
@@ -167,6 +167,8 @@ def remove_redundant_nrt_refct(ll_module):
Note: non-threadsafe due to usage of global LLVMcontext
"""
+ if config.EXPERIMENTAL_REFPRUNE_PASS:
+ return ll_module
# Early escape if NRT_incref is not used
try:
ll_module.get_function('NRT_incref')
| [_remove_redundant_nrt_refct->[_prune_redundant_refct_ops->[_examine_refct_op],_process_function,_extract_functions],remove_redundant_nrt_refct->[_remove_redundant_nrt_refct]] | Remove redundant nrt refct operations from the given LLVM module and return a new LL. | Should this perhaps be moved up to the call site for `remove_redundant_nrt_refct` such that it's obvious as to whether this is running. Am wondering if having this is potentially hiding state on something that's quite important? e.g. do this sort of thing in codegen? ```python def add_llvm_module(self, ll_module): self... |
@@ -107,7 +107,7 @@ def build_argparser():
args.add_argument('-h', '--help', action='help', default=SUPPRESS, help='Show this help message and exit.')
args.add_argument('-m', '--model', help='Required. Path to an .xml file with a trained model.',
required=True, type=Path)
- args.add_... | [SegmentationVisualizer->[overlay_masks->[apply_color_map]],get_model->[SegmentationVisualizer,SaliencyMapVisualizer],main->[build_argparser,get_model,overlay_masks],main] | Build the argument parser for the command. Parse command line options for a specific . | Could you make it required instead? -at corresponds to -m and it is strange to make assumptions about -at and not about -m. |
@@ -132,6 +132,7 @@ namespace System.IO
case Interop.Errors.ERROR_NETWORK_ACCESS_DENIED:
case Interop.Errors.ERROR_INVALID_HANDLE: // eg from \\.\CON
case Interop.Errors.ERROR_FILENAME_EXCED_RANGE: // Path is too long
+ case Interop.Errors.... | [No CFG could be retrieved] | Check if a is valid. | The error looks very generic. No false positives could be for the error in the context? |
@@ -69,7 +69,7 @@ class Repeat(nn.Module):
assert repeat <= len(blocks), f'Not enough blocks to be used. {repeat} expected, only found {len(blocks)}.'
blocks = blocks[:repeat]
if not isinstance(blocks[0], nn.Module):
- blocks = [b() for b in blocks]
+ blocks = [b(i) for ... | [NasBench201Cell->[forward->[append,op,sum,stack,enumerate],_make_dict->[str,OrderedDict,enumerate,isinstance],__init__->[append,generate_new_label,super,_make_dict,ModuleList,items,OrderedDict,range,cls,LayerChoice]],Repeat->[__new__->[get_fixed_value,Sequential,_replicate_and_instantiate,super],forward->[block],_repl... | Replicate and instantiate blocks. | how can you make sure `i` is the input argument of a block? |
@@ -48,12 +48,12 @@ describe Comment do
describe '.embargoed' do
before(:each) do
- @info_request = FactoryGirl.create(:info_request)
- @request_comment = FactoryGirl.create(:comment,
- :info_request => @info_request)
- @embargoed_request = FactoryGirl... | [last_report,create,persisted?,new,let,be,all,describe,it,for_admin_event_column,to,of,comment_url,before,info_request_events,url_helpers,body,destroy,select,destroy_all,require,last,include,dirname,report!,now,title,match,id,be_a,build,eq,domain,log_event,reload,expand_path] | Describe the comments of a single n - node object. Declares the comments on the request and the embargos on the embargoed request. | Align the parameters of a method call if they span more than one line. |
@@ -30,10 +30,13 @@ namespace Content.Server.Explosion
[UsedImplicitly]
public sealed class TriggerSystem : EntitySystem
{
+ [Dependency] private readonly IGameTiming _gameTiming = default!;
+
public override void Initialize()
{
base.Initialize();
Subscr... | [TriggerSystem->[HandleTimerTrigger->[Trigger],Initialize->[Initialize]]] | Initialize method. | Should early-out if it's not enabled. |
@@ -1414,8 +1414,9 @@ class TestUploadDetail(BaseUploadTest):
@mock.patch('olympia.devhub.tasks.run_addons_linter')
@mock.patch('olympia.files.utils.get_signer_organizational_unit_name')
def test_mozilla_signed_allowed(self, mock_get_signature, mock_validator):
- user_factory(email='redpanda@mozil... | [TestRemoveLocale->[test_remove_version_locale->[post],test_bad_request->[post],test_delete_default_locale->[post],test_success->[post]],TestUpload->[test_create_fileupload->[post],test_fileupload_metadata->[post],test_upload_unlisted_addon->[post],test_redirect->[post],test_fileupload_validation->[post],test_login_req... | Test mozilla signed access. | As above, would it make sense to change the domain of the email address? |
@@ -0,0 +1,18 @@
+/*
+ * Copyright The OpenTelemetry Authors
+ * SPDX-License-Identifier: Apache-2.0
+ */
+
+package io.opentelemetry.javaagent.instrumentation.cassandra.v3_0;
+
+import java.util.concurrent.Executor;
+
+class DirectExecutor implements Executor {
+
+ static final Executor INSTANCE = new DirectExecutor(... | [No CFG could be retrieved] | No Summary Found. | Is there an advantage of class vs lambda? |
@@ -129,14 +129,14 @@ static void color_picker_helper_4ch_parallel(const dt_iop_buffer_dsc_t *dsc, con
static void color_picker_helper_4ch(const dt_iop_buffer_dsc_t *dsc, const float *const pixel,
const dt_iop_roi_t *roi, const int *const box, float *const picked_color,
- ... | [dt_color_picker_helper->[color_picker_helper_bayer,dt_unreachable_codepath,color_picker_helper_4ch,color_picker_helper_xtrans],void->[fmaxf,free,color_picker_helper_xtrans_seq,color_picker_helper_bayer_parallel,FCxtrans,malloc,color_picker_helper_4ch_seq,color_picker_helper_bayer_seq,dt_get_num_threads,color_picker_he... | color_picker_helper_4ch - color - picking helper for 4 - channel find the max color in the list of colors and normalize it if necessary. | const dt_iop_colorspace_type_t cst_to |
@@ -181,9 +181,6 @@ void HyperElasticIsotropicNeoHookean3D::CalculateMaterialResponseCauchy (Constit
void HyperElasticIsotropicNeoHookean3D::InitializeMaterialResponsePK1(ConstitutiveLaw::Parameters& rValues)
{
-// rValues.Set(ConstitutiveLaw::INITIALIZE_MATERIAL_RESPONSE);
-// HyperElasticIsotropicNeoHooke... | [CalculatePK2Stress->[GetStrainSize,WorkingSpaceDimension,IdentityMatrix],CalculateAlmansiStrain->[prod,trans,GetDeformationGradientF],CalculateKirchhoffStress->[size,WorkingSpaceDimension,IdentityMatrix],CalculateConstitutiveMatrixKirchhoff->[clear,rConstitutiveMatrix],GetLawFeatures->[push_back,GetStrainSize,Set,Work... | Initialize material response PK1. | if this is empty, you can leave out the implementation |
@@ -29,7 +29,16 @@ import static java.util.Objects.requireNonNull;
public class ReflectionWindowFunctionSupplier<T extends WindowFunction>
extends AbstractWindowFunctionSupplier
{
+ @SuppressWarnings("unchecked")
+ private enum ConstructorType
+ {
+ NO_INPUTS,
+ INPUTS,
+ INPUTS... | [ReflectionWindowFunctionSupplier->[newWindowFunction->[RuntimeException,newInstance,isEmpty],getDescription->[getAnnotation,value],RuntimeException,Signature,getConstructor,getDescription,getTypeSignature,requireNonNull,isEmpty,transform]] | Creates a new instance of WindowFunctionSupplier that can be used to create a new instance of Creates a new instance of the class. | Remove this `@SuppressWarnings` as it's not needed |
@@ -224,7 +224,7 @@ public final class NarClassLoaders {
// see if this class loader is eligible for loading
ClassLoader narClassLoader = null;
if (narDependencyCoordinate == null) {
- narClassLoader = createNarClassLoader(narDetail.g... | [NarClassLoaders->[init->[init],load->[InitContext]]] | load the bundles which are in the framework working directory and which are in the extensions working directory Load a NAR with the specified coordinates. Load the NAR dependencies. Checks if any of the nar directories can be loaded and if so creates a new Init. | I think we should make this line consistent with the logic below around line 390... In this case we are saying, if no dependency then the parent is always the root class loader. In the other case we are saying, if no dependency and if jetty bundle exists (which currently it always does), then make jetty bundle the pare... |
@@ -173,7 +173,11 @@ public class HoodieLogFileCommand implements CommandMarker {
HoodieTableMetaClient client = HoodieCLI.getTableMetaClient();
FileSystem fs = client.getFs();
List<String> logFilePaths = Arrays.stream(fs.globStatus(new Path(logFilePathPattern)))
- .map(status -> status.getPath().... | [HoodieLogFileCommand->[showLogFileCommits->[getValue,Path,size,listStatus,toString,containsKey,put,_3,Exception,ObjectMapper,addTableHeaderField,getKey,requireNonNull,writeValueAsString,hasNext,newReader,print,HoodieLogFile,readSchemaFromLogFile,close,next,getLogBlockHeader,entrySet,getBlockType,toList,_1,get,convert,... | Show log records from a specified log file. Scans the log files and returns the next N records. | Do we need to sort this data set? |
@@ -2422,7 +2422,10 @@ public abstract class Run <JobT extends Job<JobT,RunT>,RunT extends Run<JobT,Run
private static class DefaultFeedAdapter implements FeedAdapter<Run> {
public String getEntryTitle(Run entry) {
- return entry.getDisplayName()+" ("+entry.getBuildStatusSummary().message+")"... | [Run->[getIconColor->[getIconColor,isBuilding,getResult],getRootDir->[toString],getACL->[getACL],onLoad->[onLoad],getPreviousBuildInProgress->[getPreviousBuild,_this,isBuilding],getPreviousNotFailedBuild->[getPreviousBuild,getResult],writeLogTo->[getLogInputStream],doBuildTimestamp->[getTime],doConsoleText->[getLogInpu... | Get the entry title. | Project name will lost if custom build name will set |
@@ -216,6 +216,9 @@ class TestReviewHelper(TestCase):
helper = self.get_helper()
assert helper.actions == {}
+ helper = self.get_helper(content_review_only=True)
+ assert helper.actions == {}
+
def test_type_nominated(self):
assert self.setup_type(amo.STATUS_NOMINATED) ==... | [TestReviewHelper->[test_email_links->[get_data],test_nomination_to_public_mozilla_signed_extension->[setup_data],test_request_more_information_deleted_addon->[test_request_more_information],test_nomination_to_public->[_check_score,check_log_count,setup_data],test_actions_public_post_reviewer->[get_review_actions],test... | Test that no request is available. | maybe add `content_review_only=False` to this one to be explicit |
@@ -74,15 +74,16 @@ class CbtfKrell(Package):
description="Build mpi experiment collector for mpich MPI.")
# Dependencies for cbtf-krell
- depends_on("cmake@3.0.2", type='build')
+ depends_on("cmake@3.0.2:", type='build')
# For binutils service
depends_on("binutils@2.24+krellpatch"... | [CbtfKrell->[install->[set_mpi_cmakeOptions,adjustBuildTypeParams_cmakeOptions]]] | Create a list of variants that can drive the data collection at HPC levels of scale. Adds required dependencies to the cmake options for the given n - node object. | if it is not needed, please remove |
@@ -185,6 +185,17 @@ class JvmdocGen(JvmTask):
pool.terminate()
self.context.log.debug("End multiprocessing section")
+ def _doc_classpath(self, lang_predicate, targets):
+ """Classpath including jar library targets and targets matching the language predicate."""
+ # NB: Javadoc gets conf... | [JvmdocGen->[register_options->[jvmdoc],generate_doc->[jvmdoc,find_jvmdoc_targets],product_types->[jvmdoc],_handle_create_jvmdoc_result->[jvmdoc]]] | Generate individual JVMDOC files. Raises TaskError if there is no such task in the context. | Will excluding these libraries cause broken links in cases where they reference one another? |
@@ -28,13 +28,15 @@ module Db
end
def edit
+ @series = Series.find(params[:id])
authorize @series, :edit?
end
- def update(series)
+ def update
+ @series = Series.find(params[:id])
authorize @series, :update?
- @series.attributes = series
+ @series.attributes... | [SeriesController->[destroy->[destroy],new->[new],create->[new],activities->[new]]] | if the user has permission to edit the nag record this will be called in the admin. | Similar blocks of code found in 3 locations. Consider refactoring. |
@@ -47,10 +47,10 @@ namespace DotNetNuke.Tests.Web.Api
[Test]
- [TestCase("mfn", "url", 0, "DesktopModules/mfn/API/url")]
- [TestCase("mfn", "url", 1, "{prefix0}/DesktopModules/mfn/API/url")]
- [TestCase("mfn", "url", 2, "{prefix0}/{prefix1}/DesktopModules/mfn/API/url")]
- [Test... | [PortalAliasRouteManagerTests->[GetRouteUrl->[GetRouteUrl],GetRouteUrlThrowsOnBadArguments->[GetRouteUrl]]] | Get route url with specified count. | Same thing here; keep URL formats (old and new) to test for backward compatibility. |
@@ -52,12 +52,7 @@ import org.joda.time.DateTime;
import org.joda.time.Interval;
import javax.annotation.Nullable;
-import java.util.Arrays;
-import java.util.Iterator;
-import java.util.LinkedHashMap;
-import java.util.List;
-import java.util.Map;
-import java.util.Set;
+import java.util.*;
import java.util.concu... | [IncrementalIndex->[getDimensionIndex->[get],getMetricType->[get],getDimVals->[size,get,add],getDimension->[get,isEmpty],getMetricIndex->[get],iterableWithPostAggregations->[iterator->[apply->[get],iterator]],TimeAndDims->[compareTo->[compareTo]],getMaxTime->[getMaxTimeMillis,isEmpty],getInterval->[getMaxTimeMillis,isE... | Imports the given object as an IncrementalIndex. private static final int MAX_INDEX_SIZE = 1000 ;. | no wildcard imports please, configure your IDE to explicitly import every class. |
@@ -346,6 +346,7 @@ public class OmMetadataManagerImpl implements OMMetadataManager {
.addCodec(S3SecretValue.class, new S3SecretValueCodec())
.addCodec(OmPrefixInfo.class, new OmPrefixInfoCodec())
.addCodec(OmDirectoryInfo.class, new OmDirectoryInfoCodec())
+
.addCodec(OMTransaction... | [OmMetadataManagerImpl->[isVolumeEmpty->[startsWith,getVolumeKey],isBucketEmpty->[startsWith,getBucketKey],initializeOmTables->[checkTableStatus],listVolumes->[startsWith,getVolumeKey],listBuckets->[startsWith,getVolumeKey,getBucketKey],loadDB->[loadDB],listKeys->[getOzoneKey,startsWith,getBucketKey],listAllVolumes->[s... | Adds the OOM tables and codecs to the given builder. | Nit: Remove this empty line. |
@@ -474,10 +474,15 @@ public class GroupByQueryQueryToolChest extends QueryToolChest<Row, GroupByQuery
{
if (input instanceof MapBasedRow) {
final MapBasedRow row = (MapBasedRow) input;
- final List<Object> retVal = Lists.newArrayListWithCapacity(2);
+ fi... | [GroupByQueryQueryToolChest->[mergeResults->[run->[run]],getCacheStrategy->[mergeSequences->[getOrdering]],mergeGroupByResults->[run,mergeGroupByResults],makePostComputeManipulatorFn->[apply->[apply],makePreComputeManipulatorFn],preMergeQueryDecoration->[run->[run]]]] | Returns a cache strategy that caches the results of a GroupBy query. This is a private method that returns a function that will pull the data from the cache and. | are we using the dimension name or the output name at this level? |
@@ -1029,6 +1029,7 @@ class AttentionWrapper(rnn_cell_impl.RNNCell):
cell,
attention_mechanism,
attention_layer_size=None,
+ attention_layer=None,
alignment_history=False,
cell_input_fn=None,
output_attention=T... | [_BaseAttentionMechanism->[__init__->[_maybe_mask_score,_prepare_memory]],LuongMonotonicAttention->[__call__->[_luong_score]],BahdanauMonotonicAttention->[__call__->[query_layer,_bahdanau_score]],AttentionWrapper->[state_size->[AttentionWrapperState,_item_or_tuple],call->[_batch_size_checks,_item_or_tuple,_compute_atte... | Constructs a base class for the AttentionWrapper. A base class for the attention mechanism. Initializes the object with missing data. Initializes the attention layer and the cell. | Can you move this towards the end of the function signature to avoid breaking existing users? |
@@ -1,10 +1,11 @@
package org.infinispan.factories;
-import org.infinispan.commons.marshall.Marshaller;
+import org.infinispan.commons.marshall.StreamAwareMarshaller;
import org.infinispan.commons.marshall.StreamingMarshaller;
import org.infinispan.factories.annotations.DefaultFactoryFor;
import org.infinispan.fa... | [MarshallerFactory->[construct->[of,getName,equals,GlobalMarshaller,marshaller]]] | package org. infinispan. marshall. MarshallerFactory. | Factories shouldn't cache components |
@@ -435,7 +435,10 @@ class LayerHelper(object):
act_type = act.pop('type')
tmp = input_var
# NOTE(dzhwinter): some activation support inplace compution.
- if not core.IsInplace(act_type):
+ # NOTE(minqiyang): currently, we don't support inplace in imperative mode
+ if not... | [LayerHelper->[create_parameter->[_create_weight_normalize],to_variable->[to_variable],iter_inputs_and_params->[multiple_input,multiple_param_attr],append_bias_op->[create_variable_for_type_inference,append_op,create_parameter],input_dtype->[multiple_input],_create_weight_normalize->[__reshape_op->[append_op],__norm_op... | Append an activation to the network. | should we delete this inplace and rely on inplace pass? @dzhwinter |
@@ -53,7 +53,7 @@
<p>We support native
<a href="https://shopify.github.io/liquid/" target="_blank" rel="noopener">Liquid tags</a> in our editor, but have created our own custom tags listed below:
</p>
- <h3><strong>dev.to Article/Post Embed</strong></h3>
+ <h3><strong><%= community_name %> Articl... | [No CFG could be retrieved] | This is a simple example of how to find a sequence number that can be used to find Liquid tags are not supported in the editor but they are not in the editor. | @rhymes or @lightalloy any ideas or suggestions on what we can do about these example links in the editor guide? |
@@ -13,6 +13,9 @@ pytestmark = [
"cli_tests_contracts_version", [RAIDEN_CONTRACT_VERSION], scope="module"
),
pytest.mark.parametrize("environment_type", [Environment.DEVELOPMENT], scope="module"),
+ # This is a bit awkward, the default `chain_id` for the `raiden_testchain` and
+ # `local_matrix... | [test_cli_manual_account_selection->[expect_cli_successful_connected,expect_cli_until_account_selection,raiden_spawner],test_cli_full_init_dev->[expect_cli_normal_startup,raiden_spawner],parametrize] | Test that the command line is full startup with the development environment. | what does "don't align" mean? |
@@ -211,6 +211,10 @@ function compile(
}
externs.push('build-system/externs/amp.multipass.extern.js');
+ /**
+ * TODO(#28387) write a type for this.
+ * @type {*}
+ */
/* eslint "google-camelcase/google-camelcase": 0*/
const compilerOptions = {
compilation_level: options.comp... | [No CFG could be retrieved] | Adds the necessary files to the build file. This function will generate the js files for the given node - module. | Perhaps `Object` might work for now? |
@@ -796,6 +796,17 @@ define([
* @return {Array} The modified Array parameter or a new Array instance if one was not provided.
*
* @exception {DeveloperError} matrix is required.
+ *
+ * @example
+ * //converts a matrix of order 4 to an array
+ * // m = [10.0, 11.0, 12.0, 13.0]
+ * ... | [No CFG could be retrieved] | Creates a matrix that transforms from normalized device coordinates to window coordinates. - - - - - - - - - - - - - - - - - -. | These examples look good. Thanks @nobelium. Can we just do a minor wording tweak to make them a bit more friendly to non-math folks by changing "matrix of order 4" to "Matrix4" or "4x4 matrix?" |
@@ -152,4 +152,14 @@ public class MultiWorkUnit extends WorkUnit {
public static MultiWorkUnit createEmpty() {
return new MultiWorkUnit();
}
+
+ public void removeWorkUnits(WorkUnitStream workUnitsToRemove) {
+ for (WorkUnit workUnit : workUnitsToRemove.getMaterializedWorkUnitCollection()) {
+ this.... | [MultiWorkUnit->[readFields->[readFields],createEmpty->[MultiWorkUnit],setPropExcludeInnerWorkUnits->[setProp],equals->[equals],write->[write],hashCode->[hashCode],setProp->[setProp]]] | Creates an empty MultiWorkUnit. | Please don't use `getMaterializedWorkUnitCollection`, it prevents optimizations in the Gobblin flow. Instead, you should use a lambda on the `WorkUnitStream`. |
@@ -1,6 +1,5 @@
"""
Copyright (c) 2019 Intel Corporation
-
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
| [ActionDetection->[generate_prior_box->[float],parameters->[update,BoolField,NumberField,super,StringField,ListField],process->[append,ActionDetectionPrediction,estimate_head_shifts,len,_extract_predictions,DetectionPrediction,enumerate,raw_outputs,prepare_detection_for_id,ContainerPrediction],decode_box->[exp],estimat... | Creates a class that represents the parameters of an action - detection . Required. | This seems wrong. The other files do have this blank line. |
@@ -61,7 +61,7 @@ func NewConfigBlacklist(cfg ConfigBlacklistSettings) (*ConfigBlacklist, error) {
}
// Detect an error if any of the given config blocks is blacklisted
-func (c *ConfigBlacklist) Detect(configBlocks api.ConfigBlocks) Errors {
+func (c *ConfigBlacklist) Detect(configBlocks ConfigBlocks) Errors {
v... | [Detect->[isBlacklisted,Errorf],isBlacklisted->[Split,Contains,ConfigWithMeta,HasPrefix,isBlacklistedBlock],Unpack->[Flatten,Sprintf,MapStr,Errorf],isBlacklistedBlock->[IsDict,CountField,MatchString,GetFields,IsArray,Child,String,isBlacklistedBlock],Wrap,Compile,Sprintf] | Detect returns a list of errors if any of the blocks in configBlocks are blacklisted. | @ph @blakerouse Can we remove the filtering for output types (and others) from libbeat as well? These have been introduced in the context of Central Management, in order to disallow some potential risky setting. Agent should disallow the `console` and `file` input? Filebeat modules should not be configurable anyways. F... |
@@ -328,8 +328,8 @@ public class ServerMessenger implements IServerMessenger, NioSocketListener {
private void bareBonesSendChatMessage(final String message, final INode to) {
final List<Object> args = new ArrayList<>();
- final Class<? extends Object>[] argTypes = new Class<?>[1];
args.add(message);
... | [ServerMessenger->[socketError->[removeConnection],notifyPlayerLogin->[isLobby,scheduleMacUnmuteAt,scheduleUsernameUnmuteAt],forwardBroadcast->[send],getUsernameUnmuteTask->[isLobby,isUsernameMuted,isGame],isNameTaken->[getNodes],removeConnection->[notifyPlayerRemoval,notifyConnectionsChanged],forward->[send],Connectio... | Send a message to a bare bones channel. | This assignment could be inlined even |
@@ -339,12 +339,7 @@ class CookedPostProcessor
width, height = ImageSizer.resize(width, height)
end
- # if the upload already exists and is attached to a different post,
- # or the original_sha1 is missing meaning it was created before secure
- # media was enabled. we want to re-thumbnail and re-... | [CookedPostProcessor->[grant_badges->[has_emoji?],convert_to_link!->[get_size_from_image_sizes,get_size_from_attributes,limit_size!],create_icon_node->[create_node],downloaded_images->[downloaded_images],post_process_oneboxes->[add_image_placeholder!,limit_size!],create_span_node->[create_node],post_process_images->[ad... | Convert image to link if necessary finds the next non - nil image node that can be used to generate the thumbnail. | This is a nice change. I agree there is no need to prevent thumbnail generation for copied secure uploads |
@@ -14,7 +14,7 @@ module.exports = class hitbtc3 extends Exchange {
'pro': true,
'has': {
'cancelOrder': true,
- 'CORS': false,
+ 'CORS': undefined,
'createOrder': true,
'editOrder': true,
'fetchB... | [No CFG could be retrieved] | HIP HIP HIP HIP HIP HIP HIP HIP HIP This file contains all urls that are used to generate a hitbtc resource. | In this case, we should test the CORS-capability of the exchange API and set this to its real value. |
@@ -14,11 +14,15 @@ module.exports = class ndax extends Exchange {
return this.deepExtend (super.describe (), {
'id': 'ndax',
'name': 'NDAX',
- 'countries': [ 'US' ], // United States
+ 'countries': [ 'CA' ], // Canada
'rateLimit': 1000,
... | [No CFG could be retrieved] | Provide a base class for the NAX exchange. Return a map of all of the urls urls urls urls urls urls urls urls urls urls urls. | Why would we include `transferOut` and not `transferIn` nor `transfer` ? |
@@ -326,6 +326,10 @@ public final class TestSecureOzoneCluster {
scmStore.setScmId(scmId);
// writes the version file properties
scmStore.initialize();
+ if (!SCMHAUtils.isSCMHAEnabled(conf)) {
+ SCMRatisServerImpl.initialize(clusterId, scmId,
+ SCMHANodeDetails.loadSCMHAConfig(conf).get... | [TestSecureOzoneCluster->[testSecureOMInitializationFailure->[initSCM,testCommonKerberosFailures],testDelegationTokenRenewal->[stop],testSecureOmInitializationSuccess->[initSCM],stop->[stop],testSCMSecurityProtocol->[stop],testSecureScmStartupFailure->[initSCM],testGetS3Secret->[setupOm],testSecureOmInitSuccess->[initS... | Initialize the SCM. | Question: Why do we need this step here? |
@@ -678,6 +678,17 @@ export class SystemLayer {
});
}
+ /**
+ * Handles click events on the paused and play buttons.
+ * @param {boolean} paused Specifies if the story is being paused or not.
+ * @private
+ */
+ onPausedClick_(paused) {
+ if (this.storeService_.get(StateProperty.PAGE_HAS_PLAYABLE... | [No CFG could be retrieved] | Private methods - Mute and unmute are only called on the UI for RTL or private method for handling events on the info dialog and toggles the sidebar. | This is confusing to screen readers and not accessible. Please use the `disabled` CSS attribute on the button instead, that should make the button unclickable. |
@@ -246,6 +246,10 @@ def _classify_patterns(patterns):
excluded.append(p[1:])
else:
included.append(p)
+
+ # FIXME: This is weird, as the test_package folder could be named different... do we want it?
+ # it was previously hardcoded at FileCopier
+ excluded.append("tes... | [export_source->[_classify_patterns],export_recipe->[_classify_patterns],calc_revision->[_detect_scm_revision]] | Classify patterns into a list of classes and files to be excluded from the CWL. | Actually, current implementation only excludes ``test_package/build``, not ``test_package`` |
@@ -176,7 +176,8 @@ class DuplicativeCertsTest(renewer_test.BaseRenewableCertTest):
def tearDown(self):
shutil.rmtree(self.tempdir)
- def test_find_duplicative_names(self):
+ @mock.patch("letsencrypt.le_util.make_or_verify_dir")
+ def test_find_duplicative_names(self, unused): # pylint: disabl... | [DetermineAccountTest->[test_no_accounts_email->[_call],test_single_account->[_call],test_no_accounts_no_email->[_call],test_args_account_set->[_call],test_multiple_accounts->[_call]],CLITest->[test_plugins->[_call],test_config_changes->[_call],test_rollback->[_call]]] | Tear down the test suite. | I think you should be fine without local disable |
@@ -107,5 +107,5 @@ QueryData genShims(QueryContext& context) {
return results;
}
-}
-}
+} // namespace tables
+} // namespace osquery
| [genShims->[substr,INTEGER,find,queryKey,at,push_back,length,count]] | genShims - Generate all shim keys. get all keys in the system that match the key. | Are we doing this now? Or is this just my `clang-format` freakin out? |
@@ -36,11 +36,11 @@ namespace Dynamo
preloader = null;
DynamoSelection.Instance.ClearSelection();
- if (this.CurrentDynamoModel == null)
- return;
-
- this.CurrentDynamoModel.ShutDown(false);
- this.CurrentDynamoModel = ... | [DynamoModelTestBase->[Setup->[Setup],Cleanup->[Cleanup]]] | Cleanup method. | In the earlier code, `base.Cleanup()` would have been skipped if `CurrentDynamoModel == null` (but this has nothing to do with the test failure fix). |
@@ -52,14 +52,14 @@ namespace DynamoCoreUITests
public void CanHideConsoleWhenShown()
{
Vm.ToggleConsoleShowingCommand.Execute(null);
- Ui.Dispatcher.BeginInvoke(DispatcherPriority.ApplicationIdle, (Action)(() => Assert.False(Ui.ConsoleShowing)));
+ Assert.False(Vm.C... | [CoreUserInterfaceTests->[CanFitView->[FitViewInternal,X,HasUnsavedChanges,CurrentSpaceViewModel,Zoom,Y,_model,CreateNodeOnCurrentWorkspace,AreNotEqual],PreferenceSetting->[ToggleConsoleShowing,RestartTestSetup,ConnectorType,Save,FullscreenWatchShowing,ConsoleHeight,AreEqual,IsUsageReportingApproved,SetUsageReportingAg... | Can hide console when shown. | Minor formatting issue here with spacing. Anyway, the pull request cannot be merged, you will need to do a `git pull upstream master` to get all the latest changes into your local machine, and then push it up to your `origin` again (i.e. `git push origin MAGN-4130`). |
@@ -0,0 +1,17 @@
+// Licensed to the .NET Foundation under one or more agreements.
+// The .NET Foundation licenses this file to you under the MIT license.
+
+using System.Threading;
+
+namespace System.Net.Http
+{
+ /// <summary>
+ /// Additional default values used used only in this assembly.
+ /// </summary... | [No CFG could be retrieved] | No Summary Found. | We should use `TimeSpan.InfiniteTimeout` as the "off" mode. That said, I feel like it'd be fine to have this default to on. @JamesNK do you know what a reasonable default delay is? would 60 seconds be too long? |
@@ -114,6 +114,14 @@ def autocomplete():
options = [(x, v) for (x, v) in options if x not in prev_opts]
# filter options by current input
options = [(k, v) for k, v in options if k.startswith(current)]
+ # get completion type given cwords and available subcommand options
+ compl... | [parseopts->[create_main_parser],main->[parseopts,check_isolated,autocomplete,main]] | Command and option completion for the main parser and its subcommands. filter options by current input . | :art: move the `)` to the next line with 1 level less indent and add a trailing comma. |
@@ -50,6 +50,17 @@ func resourceAwsEMRInstanceGroup() *schema.Resource {
Required: true,
ForceNew: true,
},
+ "configurations_json": {
+ Type: schema.TypeString,
+ Optional: true,
+ ForceNew: false,
+ ValidateFunc: validation.ValidateJsonString,
+ DiffSuppr... | [ListInstanceGroupsPages,Set,ModifyInstanceGroups,GetOk,Marshal,HasChange,Errorf,SetId,Bool,PutAutoScalingPolicy,AddInstanceGroups,Id,Int64,Get,Split,Printf,StringValue,Sprintf,Unmarshal,WaitForState,List,String] | requires that the resource - level schema has the required fields Config for EBS cluster. | Nit: `ForceNew: false` is extraneous |
@@ -16,7 +16,10 @@ namespace System.IO.Tests
private static string driveFormat = PlatformDetection.IsInAppContainer ? string.Empty : new DriveInfo(Path.GetTempPath()).DriveFormat;
protected static bool isHFS => driveFormat != null && driveFormat.Equals(HFS, StringComparison.InvariantCultureIgnoreCas... | [BaseGetSetTimes->[SettingUpdatesProperties->[TimeFunctions],DoesntExist_ReturnsDefaultValues->[TimeFunctions],TimesIncludeMillisecondPart_HFS->[TimeFunctions],TimesIncludeMillisecondPart->[TimeFunctions],ValidateSetTimes->[TimeFunctions]]] | Get the path to an existing item or missing item. | This seems to be unnecessary |
@@ -116,6 +116,8 @@ require('react-styl')(`
background-image: url('images/growth/github-icon.svg')
&.linkedin
background-image: url('images/growth/linkedin-icon.svg')
+ &.telegram
+ background-image: url('images/growth/website-icon.svg')
.badge-label
position: abso... | [No CFG could be retrieved] | Displays a block of disabled components. 9rem - 900. | Replace with telegram-icon.svg |
@@ -278,7 +278,8 @@ public abstract class ParameterizedJobMixIn<JobT extends Job<JobT, RunT> & Param
* Uses {@link #BUILD_NOW_TEXT}.
*/
public final String getBuildNowText() {
- return isParameterized() ? Messages.ParameterizedJobMixIn_build_with_parameters() : AlternativeUiTextProvider.get(BUIL... | [ParameterizedJobMixIn->[scheduleBuild->[scheduleBuild],doCancelQueue->[asJob],doBuildWithParameters->[asJob],getBuildNowText->[asJob,isParameterized],scheduleBuild2->[scheduleBuild2],doBuild->[asJob]]] | Get the build now text. | Shouldn't this rather have a new variant `BUILD_WITH_PARAMETERS_TEXT`? The difference IIUC is that "Build Now" indicates an immediate action, while the other does not (like when in many applications some actions have a trailing ` ` and others don't). |
@@ -133,10 +133,6 @@ class StructuredTensor(composite_tensor.CompositeTensor):
self._fields[key] = value
# Check the static TensorShape for this StructuredTensor.
- shape = tensor_shape.as_shape(shape)
- rank = shape.ndims
- if rank is None:
- raise ValueError("StructuredTensor's shape mus... | [StructuredTensorSpec->[_unbatch->[StructuredTensorSpec,_unbatch],_batch->[StructuredTensorSpec,_batch],_from_components->[StructuredTensor]],StructuredTensor->[__repr__->[_is_eager],_from_pydict->[from_pyval,StructuredTensor],_from_pylist_of_value->[_from_pylist_of_dict],from_row_splits->[from_row_splits],to_pyval->[_... | Creates a StructuredTensor from a static information about the shape of the given StructuredTensor Check if all the fields in the StructuredTensor have a . | This is a duplicate error message from the same check above |
@@ -28,12 +28,12 @@ import io.confluent.ksql.rest.entity.KsqlStatementErrorMessage;
import javax.ws.rs.core.HttpHeaders;
import javax.ws.rs.core.Response;
-public final class Errors {
+public class Errors {
private static final int HTTP_TO_ERROR_CODE_MULTIPLIER = 100;
public static final int ERROR_CODE_BAD_... | [Errors->[serverErrorForStatement->[serverErrorForStatement],badStatement->[badStatement]]] | This method imports all errors from the given HTTP response. ERROR CODE - SERVICE UNAVAILABLE. | nit: can now be `final` again. |
@@ -0,0 +1,15 @@
+package org.infinispan.server.integration;
+
+public enum ArquillianServerType {
+
+ NONE, TOMCAT9, WILDFLY18;
+
+ public static ArquillianServerType current() {
+ ArquillianServerType type = ArquillianServerType.NONE;
+ final String launchType = System.getProperty("infinispan.server.int... | [No CFG could be retrieved] | No Summary Found. | We should remove the version from the identifiers. |
@@ -82,7 +82,7 @@ class BokehRenderer(Renderer):
plot_width=self.width,
plot_height=self.height)
- _plot.title = ""
+ _plot.title = Title()
# and add new tools
_tool_objs = _process_tools_arg(_p... | [BokehRenderer->[multiline_props->[get_alpha,list,get_linewidth,get_linestyle,get_props_cycled,convert_color,convert_dashes,map,tuple,add,get_colors,rgb2hex],close_axes->[append,getattr,convert_color,len,get_axis_bgcolor],make_line_collection->[ColumnDataSource,multiline_props,MultiLine,add_glyph,xkcd_line,len,transpos... | Complete the plot. Add layout r to right of plot. | Plots have a default Title object. You can just set _plot.title.text no need to create a new Title |
@@ -661,7 +661,12 @@ exec(compile(open(__file__).read().replace('\\r\\n', '\\n'), __file__, 'exec'))
except pkg_resources.DistributionNotFound:
return False
except pkg_resources.VersionConflict:
- self.conflicts_with = pkg_resources.get_distribution(self.req.project_name)
+ ... | [parse_requirements->[parse_requirements,from_line,from_editable],RequirementSet->[cleanup_files->[remove_temporary_source],install->[remove_temporary_source,rollback_uninstall,install,uninstall,values,commit_uninstall],uninstall->[values,commit_uninstall,uninstall],create_bundle->[_clean_zip_name,bundle_requirements],... | Check if a node - package exists. | I would rather pass a `user_site` flag explicitly to each `InstallRequirement` rather than give `InstallRequirement` awareness of the `RequirementSet`. |
@@ -118,8 +118,9 @@ class ProjectsOverviewService
}
end
- def sort(records, params)
- order = params[:order]&.values&.first
+ def sort(records)
+ order_state = @view_state.state['table']['order'][0]
+ order = @params[:order]&.values&.first
if order
dir = order[:dir] == 'desc' ? 'DESC' :... | [ProjectsOverviewService->[search->[where_attributes_like],fetch_dt_records->[group,from,is_admin_of_team?,where,id,joins],project_cards->[where,order],sort->[first,order],fetch_records->[limit,from,is_admin_of_team?,where,left_outer_joins,select,id],projects_datatable->[search,to_i,dig,where,per,present?]]] | Sort records by sequence number and return them in order. | Is this line totally correct? In default state, the order is like this: `order: [2, 'asc']`, but here, it changes to `order: [[2, 'asc'], 'asc']`. |
@@ -142,6 +142,7 @@ Summary: The DAOS test suite
Requires: %{name}-client = %{version}-%{release}
Requires: python-pathlib
Requires: fio
+Requires: json-c
%if (0%{?suse_version} >= 1315)
Requires: libpsm_infinipath1
%endif
| [No CFG could be retrieved] | The package needed to run a DAOS server with a specific sequence number. Package needed to build a DAOS library with the DAOS development library. | I think you need something in the spec file for Build..ask Brian if that's needed or if it will figure it out automatically. |
@@ -115,9 +115,14 @@ type ProvisionConfig struct {
func (cfg *TableManagerConfig) RegisterFlags(f *flag.FlagSet) {
f.BoolVar(&cfg.ThroughputUpdatesDisabled, "table-manager.throughput-updates-disabled", false, "If true, disable all changes to DB capacity")
f.BoolVar(&cfg.RetentionDeletesEnabled, "table-manager.rete... | [partitionTables->[HasPrefix,ListTables],deleteTables->[DeleteTable,Log,Err,Info,Set,Add],createTables->[CreateTable,Log,Err,Info,Set,Add],SyncTables->[partitionTables,deleteTables,createTables,calculateExpectedTables,Log,updateTables,Info],bucketRetentionIteration->[Error,Now,DeleteChunksBefore,Log,Add],loop->[NewHist... | RegisterFlags registers flags for TableManagerConfig. | why is this required? |
@@ -29,8 +29,11 @@ type NetworkEndpoint struct {
// Common.ID - pci slot of the vnic allowing for interface identifcation in-guest
Common
- // IP address to assign - nil if DHCP
- Static *net.IPNet `vic:"0.1" scope:"read-only" key:"staticip"`
+ // Whether this endpoint's IP was specified by the client (true if it... | [No CFG could be retrieved] | The object represents a single non - virtual machine or a container. Network scope for the IP. | should we change the key to ip here and make the next one assigned? |
@@ -49,6 +49,7 @@ class AutoToolsBuildEnvironment(object):
# Set the generic objects before mapping to env vars to let the user
# alter some value
self.libs = copy.copy(self._deps_cpp_info.libs)
+ self.libs.extend(copy.copy(self._deps_cpp_info.system_libs))
self.include_paths ... | [AutoToolsBuildEnvironment->[vars_dict->[_get_vars,append],install->[make],_get_vars->[append->[append],append],vars->[_get_vars]]] | Initialize the object with basic information about the node. Flags for missing - cflags. | It is ok to have libs mixed with system_libs in order to avoid breaking users, but I would like to have a dedicated `SYSTEM_LIBS` var added to the output of the generator so users can have the system libs separated from all the values |
@@ -50,6 +50,15 @@ class ModelArg:
return str(context.dl_dir / context.model_info[self.name]["subdirectory"] / self.precision / (self.name + '.xml'))
+class ModelDirArg:
+ def __init__(self, model_name, file_name):
+ self.model_name = model_name
+ self.file_name = file_name
+
+ def reso... | [image_retrieval_arg->[TestDataArg],DataDirectoryOrigFileNamesArg->[resolve->[resolve]],image_net_arg->[TestDataArg],DataPatternArg->[resolve->[resolve]],brats_arg->[TestDataArg],DataDirectoryArg->[resolve->[resolve],__init__->[DataPatternArg]]] | Initialize the sequence name. | This wouldn't be a bad addition, but the model that required it no longer exists. |
@@ -124,8 +124,11 @@ class SlimPruner(OneshotPruner):
Optimizer used to train model
"""
- def __init__(self, model, config_list, optimizer=None):
- super().__init__(model, config_list, pruning_algorithm='slim', optimizer=optimizer)
+ def __init__(self, model, config_list, trainer, train... | [_StructuredFilterPruner->[_dependency_update_mask->[_dependency_calc_mask],_dependency_calc_mask->[calc_mask]],OneshotPruner->[calc_mask->[calc_mask]]] | Initialize the slim pruner. | Why we never need an optimizer in this pruner? |
@@ -78,7 +78,7 @@ import static org.springframework.core.annotation.AnnotationUtils.getAnnotationA
import static org.springframework.util.ClassUtils.resolveClassName;
/**
- * {@link BeanFactoryPostProcessor} used for processing of {@link Service @Service} annotated classes. it's also the
+ * {@link BeanFactoryPostP... | [ServiceClassPostProcessor->[resolveClass->[resolveClass],addPropertyReference->[addPropertyReference]]] | Method to import a single object from the System. Deprecated in Dubbo 1. 7. 3. | Does `@Service` have to be changed to `@DubboService`? |
@@ -563,11 +563,11 @@ class DigitalTwinsClient(object): # type: ignore #pylint: disable=too-many-publi
@distributed_trace
def upsert_event_route(self, event_route_id, event_route, **kwargs):
- # type: (str, "models.EventRoute", **Any) -> None
+ # type: (str, "DigitalTwinsEventRoute", **Any) ->... | [DigitalTwinsClient->[query_twins->[get_next->[query_twins]],list_relationships->[list_relationships],delete_relationship->[delete_relationship],get_component->[get_component],list_incoming_relationships->[list_incoming_relationships],update_component->[update_component],update_relationship->[update_relationship]]] | Create or update an event route. | In docstrings, you should use the fully qualified name to enable hyper-linking: `:param ~azure.digitaltwins.DigitalTwinsEventRoute:` |
@@ -142,6 +142,16 @@ Please pass a config file as the only argument to this command.`))
if err != nil {
fail(errors.Wrap(err, "could not initialize storage"))
}
+ err = project_purge.RegisterTaskExecutors(manager, "teams", service.Storage)
+ if err != nil {
+ fail(errors.Wrap(err, "could not register project pu... | [NewFactory,ExactArgs,StringP,SetConfigFile,Wrap,Exit,Error,PGURIFromEnvironment,Dial,Stat,New,Errorf,NewPoliciesClient,GRPC,Wrapf,Execute,FixupRelativeTLSPaths,NewLogger,NewSubjectPurgeClient,Fprint,PersistentFlags,WithVersionInfo,BindPFlags,NewPostgresService,IsDir,Sprintf,ReadInConfig,Unmarshal,NewGlobalTracer,Close... | MustBeADirectory creates a new migration service. | I suppose this is where the teams-service starts its project purge, but I don't see any new code in teams-service to actually do the project purge. Can you explain what is happening? (And similar question for the domain services--I don't see any files in the PR to instrument them at all.) |
@@ -426,10 +426,6 @@ def eth_run_nodes(
os.makedirs(logdir, exist_ok=True)
- password_path = os.path.join(base_datadir, "pw")
- with open(password_path, "w") as handler:
- handler.write(DEFAULT_PASSPHRASE)
-
cmds = eth_nodes_to_cmds(
nodes_configuration, eth_node_descs, base_datadir,... | [run_private_blockchain->[eth_node_config_set_bootnodes,eth_node_config,parity_generate_chain_spec,eth_check_balance,geth_generate_poa_genesis,eth_run_nodes,parity_create_account],geth_prepare_datadir->[geth_init_datadir],parity_generate_chain_spec->[parity_extradata],eth_nodes_to_cmds->[geth_create_account,geth_prepar... | Runs the given list of Ethereum nodes and returns a ContextManager for the executors. | I moved this closer to where the configuration is set, the idea is that it should be easier to understand the flow of the data. |
@@ -385,5 +385,17 @@ namespace System.Windows.Forms
FDEOR_ACCEPT = 0x00000001,
FDEOR_REFUSE = 0x00000002
}
+
+ [DllImport(ExternDll.Shell32, CharSet = CharSet.Unicode)]
+ private static extern int SHCreateItemFromParsingName([MarshalAs(UnmanagedType.LPWStr)] string pszPa... | [FileDialogNative->[SetFileName->[LPWStr],SetDefaultExtension->[LPWStr],OnFolderChanging->[Interface],AddPlace->[Interface],SetCollectedProperties->[Interface],SetFileTypes->[LPArray],Close->[Error],SetFolder->[Interface],OnFileOk->[Interface],OnOverwrite->[Interface],GetParent->[Interface],FileOpenDialogRCW->[FCanCrea... | Flags for the FDEOR_ACCEPT and FDEOR_REFUSE flags. | nit: This is an internal class and it looks like everything else in this class members and types inside it internal as well (since that's what it effectively is) |
@@ -250,6 +250,7 @@ final class ApiLoader extends Loader
[$operation['method']],
$operation['condition'] ?? ''
);
+ $name = RouteNameGenerator::generate($operationName, $resourceShortName, $operationType);
$routeCollection->add(RouteNameGenerator::generate($operation... | [ApiLoader->[addRoute->[getAttribute,getIdentifiersFromResourceClass,resolveOperationPath,getShortName,has,add],loadExternalFiles->[addDefaults,load,addCollection],load->[addResource,getAttribute,create,getItemOperations,getCollectionOperations,getShortName,loadExternalFiles,has,add,addRoute],__construct->[locateResour... | Adds a route to the route collection. This function is used to generate a route for a given API operation. | is this really needed? |
@@ -514,7 +514,7 @@ int EncryptCopyRegularFileNet(const char *source, const char *dest, off_t size,
char *buf, in[CF_BUFSIZE], out[CF_BUFSIZE], workbuf[CF_BUFSIZE], cfchangedstr[265];
unsigned char iv[32] =
{ 1, 2, 3, 4, 5, 6, 7, 8, 1, 2, 3, 4, 5, 6, 7, 8, 1, 2, 3, 4, 5, 6, 7, 8, 1, 2, 3, 4, 5, 6, 7,... | [ServerConnection->[TLSConnect],CopyRegularFileNet->[EncryptCopyRegularFileNet]] | Copy a regular file from server to server dest using encryption type and session key. if we can send a message to the server and not yet complete the message return false if any of the two files are not found in the file system return false ;. | AFAICT this leaks in the next two or three error returns. |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.