patch stringlengths 18 160k | callgraph stringlengths 4 179k | summary stringlengths 4 947 | msg stringlengths 6 3.42k |
|---|---|---|---|
@@ -228,7 +228,7 @@ func submitAnswer(t *testing.T, p answerParams) {
}
type maliciousFluxMonitor interface {
- XXXTestingOnlyCreateJob(t *testing.T, jobSpecId *models.ID,
+ CreateJob(t *testing.T, jobSpecId *models.ID,
polledAnswer decimal.Decimal, nextRound *big.Int) error
}
| [Commit,MemoryLogTestingOnly,CreateMemoryTestLogger,FilterSubmissionReceived,NewGomegaWithT,WaitForRuns,Duration,Close,MustMakeDuration,NewConfig,WatchSubmissionReceived,Blockchain,Transfer,Eventually,FilterOracleAdminUpdated,StartAndConnect,Set,MinimumContractPayment,JSONFromString,ToInt,Submit,RequestNewRound,MustRea... | currentBalance returns the current balance of the FM and checks that all the logs emitted by NewApplicationWithConfigAndKeyOnSimulatedBlockchain creates a new application with a config. | This seems like a functional change... |
@@ -7,8 +7,11 @@ these widgets.
from __future__ import absolute_import
from ...core.properties import abstract
+from ...core.properties import String, List
from ..component import Component
@abstract
class Widget(Component):
""" A base class for all interactive widget types. """
+
+ css_classes = List(... | [No CFG could be retrieved] | A base class for all interactive widget types. | It would be convenient to allow space separated strings as well. Use `.accepts(String, lambda str: [ s.trim() for s in str.split("\s+") ])`. |
@@ -46,6 +46,12 @@ public class InboundChannelAdapterAnnotationPostProcessor extends
super(beanFactory, environment);
}
+ @Override
+ public boolean shouldCreateEndpoint(Method method, List<Annotation> annotations) {
+ String channel = MessagingAnnotationUtils.resolveAttribute(annotations, "value", String.class... | [InboundChannelAdapterAnnotationPostProcessor->[generateHandlerBeanName->[replaceFirst],postProcess->[hasText,generateHandlerBeanName,SourcePollingChannelAdapter,resolveAttribute,setOutputChannel,configurePollingEndpoint,setObject,registerSingleton,setMethod,initializeBean,setSource,getParameterTypes,getReturnType,reso... | This method is called after the bean is created. | Don't we need `getInputChannelAttribute()` here? |
@@ -15,6 +15,7 @@ namespace System.Xml
// it will replace special characters with entities whenever necessary.
internal sealed class XmlTextEncoder
{
+ private const int ChunkSize = 256;
//
// Fields
//
| [XmlTextEncoder->[WriteStringFragment->[Write],Write->[WriteSurrogateChar,Write],WriteRawWithSurrogateChecking->[Write],WriteSurrogateCharEntity->[Write],WriteRaw->[Write],WriteCharEntityImpl->[WriteCharEntityImpl,Write],WriteEntityRefImpl->[Write]]] | Creates an instance of the class that implements the standard XML text encoder interface. Write the surrogate pair of the attribute value. | This is only used by `WriteStringFragment` so I'd just define it as a local there. |
@@ -80,9 +80,9 @@ public class JettyHandlerAdvice {
if (!req.isAsyncStarted() && activated.compareAndSet(false, true)) {
DECORATE.onResponse(span, resp);
DECORATE.beforeFinish(span);
- span.finish(); // Finish the span manually since finishSpanOnClose was false
+ span.end(); // Fi... | [JettyHandlerAdvice->[stopSpan->[setAttribute,getUserPrincipal,getName,onError,AtomicBoolean,setError,compareAndSet,onResponse,isAsyncStarted,beforeFinish,getStatus,span,finish,close,TagSettingAsyncListener,addListener],onEnter->[getAttribute,setAttribute,getMethod,getName,onRequest,onConnection,afterStart,extract,acti... | Stop a span. | once we have a real `SpanWithScope`, it makes sense to add a `close()` method to it, I think. |
@@ -45,10 +45,8 @@ module TwoFactorAuthenticatable
def handle_second_factor_locked_user(type)
analytics.track_event(Analytics::MULTI_FACTOR_AUTH_MAX_ATTEMPTS)
-
- sign_out
-
render 'two_factor_authentication/shared/max_login_attempts_reached', locals: { type: type }
+ sign_out
end
def requi... | [handle_invalid_otp->[handle_second_factor_locked_user],generic_data->[personal_key_unavailable?]] | This is a helper method that handles the second factor authentication attempt. It is called when a. | NOTE this order change -- I needed to do this, otherwise was getting a nil error on `current_user.decorate` -- I think it was working before because we memoized `decorated_user` |
@@ -678,7 +678,7 @@ def test_refund_transfer_no_more_routes():
)
assert iteration.new_state, 'payment task should not be deleted at this lock expired'
# should not be accepted
- assert not events.must_contain_entry(iteration.events, SendProcessed, {})
+ assert search_for_item(iteration.events, Send... | [test_state_wait_secretrequest_invalid_amount->[setup_initiator_tests],test_state_wait_secretrequest_invalid_amount_and_sender->[setup_initiator_tests],test_initiator_handle_contract_receive_secret_reveal->[setup_initiator_tests],test_state_wait_unlock_invalid->[setup_initiator_tests],test_initiator_lock_expired->[make... | Test that a transfer is not able to be refunded. This function is called when a channel is created. process the lock expiration and the next block missing state_change channel_map prng expiry_block. | I did change some of `not ...` to `... is None`, but to limit the changes and make reviews easier I stopped |
@@ -175,9 +175,9 @@ public class ProjectTest {
public void testGetAssignedLabelString() throws Exception{
FreeStyleProject p = j.createFreeStyleProject("project");
Slave slave = j.createOnlineSlave();
- assertNull("Project should not have any label.", p.getAssignedLabelString());
+ ... | [ProjectTest->[TransientActionFactoryImpl->[createFor->[TransientAction]],waitForStart->[waitForStart],isBuildable->[isBuildable]]] | Test that the project has the assigned label string. | at first glance this appears wrong - so the message should be clearer. A project with no node assigned and a Jenkins with **no slaves** should have the jenkins master label. A project with no node assigned and a Jenkins with nodes should not have a label assigned - as canRoam should be `true` OT: Now looking at this cl... |
@@ -193,11 +193,11 @@ public class TopWikipediaSessions {
double samplingThreshold = 0.1;
- p.apply(TextIO.Read
- .from(options.getInput())
- .withCoder(TableRowJsonCoder.of()))
- .apply(new ComputeTopSessions(samplingThreshold))
- .apply("Write", TextIO.Write.withoutSharding().to(opti... | [TopWikipediaSessions->[ComputeTopSessions->[expand->[FormatOutputDoFn]],main->[getOutput]]] | Main entry point for the pipeline. | I believe you should not need the `withOutputType` here if you simply make `ParseTableRowJson` above a `SimpleFunction`. |
@@ -313,6 +313,9 @@ define([
gl.bindTexture(target, this._texture);
gl.generateMipmap(target);
gl.bindTexture(target, null);
+
+ // The mipmap adds approximately 1/3 of the original texture size
+ this._sizeInBytes = Math.floor(this._sizeInBytes * 4 / 3);
};
CubeMap.... | [No CFG could be retrieved] | Generates a MIPMAP for the given object. | A user could call `generateMipmap` more than once. Either save the original size and recompute here, or just compute every time in the `get` function based on if this is mipmapped. |
@@ -1065,7 +1065,8 @@ public abstract class SeekableStreamIndexTaskRunner<PartitionIdType, SequenceOff
log.error(t, "Error while publishing segments for sequenceNumber[%s]", sequenceMetadata);
handoffFuture.setException(t);
}
- }
+ },
+ sequencePersistExecutor
... | [SeekableStreamIndexTaskRunner->[pause->[isPaused],getEndOffsetsHTTP->[authorizationCheck],pauseHTTP->[authorizationCheck],maybePersistAndPublishSequences->[publishAndRegisterHandoff],getStartTime->[authorizationCheck],getRowStats->[authorizationCheck],getLiveReport->[authorizationCheck],setEndOffsets->[isPaused,getLas... | Publish segments for the given sequence and register handoff future. This method is called when a sequence number is not published. It is called when the sequence. | I withdraw from analyzing execution flows and thread pool relationships here. @jihoonson could you please vet this? |
@@ -63,5 +63,10 @@ func (m *SmapMapper) Apply(id Id, lineno, colno int) (*Mapping, error) {
}
func (m *SmapMapper) NewSourcemapAdded(id Id) {
+ _, err := m.Accessor.Fetch(id)
+ if err == nil {
+ logp.NewLogger("sourcemap").Warnf("Overriding sourcemap for service %s version %s and file %s",
+ id.ServiceName, id.S... | [NewSourcemapAdded->[Remove],Apply->[Sprintf,Fetch,Source,String]] | NewSourcemapAdded is called when a new sourcemap has been added to the mapper. | I think this should be done after `m.Accessor.Remove(id)` as we use negative caching. The cache should first be emptied for this entry, otherwise it could happen that a `nil` value is read from cache (no error) although no entry is there. |
@@ -387,6 +387,11 @@ class FileClient(StorageAccountHostsMixin):
max_connections=1, # type: Optional[int]
timeout=None, # type: Optional[int]
encoding='UTF-8', # type: str
+ file_attributes="none", # type: Union[str, NTFSAttributes]
+ file_creation_time="n... | [FileClient->[upload_range_from_url->[_upload_range_from_url_options,upload_range_from_url],upload_file->[_upload_file_helper],resize_file->[set_http_headers],abort_copy->[abort_copy],clear_range->[upload_range],upload_range->[upload_range],set_http_headers->[set_http_headers]]] | Uploads a new file. Encode data into a sequence of bytes. | Move these new parameters ahead of both `timeout` and `encoding` |
@@ -45,13 +45,14 @@ public class IndexerStartupTask {
* {@link org.sonar.server.issue.index.IssueIndexer}
*/
public IndexerStartupTask(TestIndexer testIndexer, IssueAuthorizationIndexer issueAuthorizationIndexer, IssueIndexer issueIndexer,
- UserIndexer userIndexer, ViewIndexer viewIndexer,
+ UserIndex... | [IndexerStartupTask->[execute->[info,index,getBoolean],get]] | This method is called when the index is enabled. | is theren't a way to inherit all the Indexer with a markup interface like we do in WsActions ? |
@@ -287,11 +287,14 @@ public abstract class AbstractCorrelatingMessageHandler extends AbstractMessageP
}
/**
- * Set {@code releasePartialSequences} on an underlying
- * {@link SequenceSizeReleaseStrategy}.
+ * Set {@code releasePartialSequences} on an underlying default
+ * {@link SequenceSizeReleaseStrategy... | [AbstractCorrelatingMessageHandler->[completeGroup->[completeGroup],afterRelease->[afterRelease],expireGroup->[discardMessage],discardMessage->[getDiscardChannel],onInit->[onInit],setTaskScheduler->[setTaskScheduler],scheduleGroupToForceComplete->[run->[scheduleGroupToForceComplete],scheduleGroupToForceComplete],forceC... | Set the flag to indicate if the sequence should be released partially. | `if (!this.releaseStrategySet && releasePartialSequences) {` I don't see reason to override `SimpleSequenceSizeReleaseStrategy` if we are not going to use `releasePartialSequences` feature. At least that is your assertion in the commit message: > Change the aggregator to use a `SimpleSequenceSizeReleaseStrategy` by def... |
@@ -233,7 +233,17 @@ func (d *Dispatcher) ensureRollbackReady(conf *config.VirtualContainerHostConfig
log.Infof("Roll back finished - Appliance is kept in powered off status")
return nil
}
- return d.startAppliance(conf)
+ if err = d.startAppliance(conf); err != nil {
+ return err
+ }
+
+ ctx, cancel := contex... | [tryCreateSnapshot->[WaitForResult,Begin,CreateSnapshot,End,UpgradeInProgress,Errorf],rollback->[RevertToSnapshot,WaitForResult,Infof,Begin,Sprintf,End,Errorf,ensureRollbackReady],Upgrade->[deleteSnapshot,Infof,Begin,WithTimeout,Sprintf,uploadImages,FolderName,deleteUpgradeImages,Background,update,rollback,End,IsNil,Da... | ensureRollbackReady checks that the VM is ready to be rolled back and reconfigures it err - if err - if err - if err . | You don't need to check if err == deadline exceeded here? you do so in other places. |
@@ -50,6 +50,9 @@ func addDefaultingFuncs(scheme *runtime.Scheme) {
// The final value of OAuthConfig.MasterCA should never be nil
obj.OAuthConfig.MasterCA = &s
}
+ if obj.KubernetesMasterConfig.KubernetesEtcdClientInfo == nil {
+ obj.KubernetesMasterConfig.KubernetesEtcdClientInfo = &obj.EtcdClientI... | [AddConversionFuncs,Has,Meta,IsNotRegisteredError,ConvertToVersion,Decode,DefaultConvert,NewCodecFactory,String,LegacyCodec,NewString,AddDefaultingFuncs,Encode] | Populates the fields of the object that are not set in the object. Config - Config object. | KubernetesMasterConfig could be nil |
@@ -396,12 +396,8 @@ class FlinkBatchTransformTranslators {
// construct a map from side input to WindowingStrategy so that
// the DoFn runner can map main-input windows to side input windows
Map<PCollectionView<?>, WindowingStrategy<?, ?>> sideInputStrategies = new HashMap<>();
- List<PCollec... | [FlinkBatchTransformTranslators->[Concatenate->[mergeAccumulators->[createAccumulator]],GroupByKeyTranslatorBatch->[translateNode->[getCurrentTransformName]],ReadSourceTranslatorBatch->[translateNode->[getCurrentTransformName]],ParDoTranslatorBatch->[translateNode->[getCurrentTransformName,rejectSplittable]],CombinePer... | Translate a node in the batch. This method is called to find a free slot in the input and output data set. This method is used to reduce the values of the input data set and create a new output. | Since we no longer have side inputs in Combine, can you go ahead and remove all references to side inputs in this function? |
@@ -18,7 +18,7 @@ namespace ProtoCore.DSASM
TX = 9
}
- public enum AddressType
+ public enum AddressType: int
{
Invalid,
Register,
| [DebugInfo->[InitializeDebugInfo],StackValue->[IsInvalid->[Invalid],IsFunctionIndex->[FunctionIndex],IsObject->[Pointer],IsMemberVariableIndex->[MemVarIndex],IsArrayKey->[ArrayKey],IsNull->[Null],IsFunctionPointer->[FunctionPointer],IsBlockIndex->[BlockIndex],IsVariableIndex->[VarIndex],IsClassIndex->[ClassIndex],IsCal... | Enumerates all the fields of the object that are specified by the specification. Creates a new object from the given object. | Why do you want an explicit backing type here? |
@@ -94,15 +94,15 @@ public class HoodieDefaultTimeline implements HoodieTimeline {
}
@Override
- public HoodieTimeline filterInflightsExcludingCompaction() {
+ public HoodieTimeline filterPendingExcludingCompaction() {
return new HoodieDefaultTimeline(instants.stream().filter(instant -> {
- return i... | [HoodieDefaultTimeline->[filterInflightsExcludingCompaction->[HoodieDefaultTimeline],findInstantsInRange->[HoodieDefaultTimeline],lastInstant->[nthInstant,countInstants,empty],nthInstant->[countInstants,empty],filterCompletedInstants->[HoodieDefaultTimeline],filterInflightsAndRequested->[HoodieDefaultTimeline],filterIn... | Filter inflights excluding compaction. | wont this provide both inflight and requested? |
@@ -62,7 +62,9 @@ class ModelChanged(TypedDict):
model: Ref
attr: str
new: Unknown
- hint: DocumentPatched | None
+
+ # mypy does not support recursive types https://github.com/python/mypy/issues/731
+ hint: DocumentPatched | None # type: ignore
class MessageSent(TypedDict):
kind: Liter... | [getLogger] | Package base for all non - standard non - object objects. Returns the document changang. | I would not mind making this better in 3.0 e.g. maybe by allowing events to adapt themselves into more specialized sub-events in flight, rather than by tacking a "hint" on to themselves. But if you have any better ideas for this now, please lmk. |
@@ -83,8 +83,6 @@ def download_url(
md5 (str, optional): MD5 checksum of the download. If None, do not check
max_redirect_hops (int, optional): Maximum number of redirect hops allowed
"""
- import urllib
-
root = os.path.expanduser(root)
if not filename:
filename = os.path.b... | [extract_archive->[_is_zip,_is_tar,_is_targz,_is_gzip,_is_tgz,_is_tarxz],check_md5->[calculate_md5],download_url->[_get_google_drive_file_id,gen_bar_updater,_get_redirect_url,check_integrity],download_and_extract_archive->[extract_archive,download_url],verify_str_arg->[iterable_to_str],check_integrity->[check_md5],down... | Download a file from a url and place it in a directory. Check if file is not corrupted. | `urllib` is part of the standard library so there is no reason to import it lazily. |
@@ -62,6 +62,7 @@ var (
"security.openshift.io/SCCExecRestrictions",
"route.openshift.io/IngressAdmission",
"quota.openshift.io/ClusterResourceQuota",
+ "scheduling.openshift.io/RestrictPodTolerations",
}
// additionalDefaultOnPlugins is a list of plugins we turn on by default that core kube does not.
| [RegisterSCCExecRestrictions,UnsortedList,List,Delete,RegisterRestrictedEndpoints,NewString,Register,RegisterExternalIP] | NewOrderedKubeAdmissionPlugins returns a list of plugins that should be applied to the given NewDefaultOffAdmissionPluginsFunc returns a list of plugin names that can be used to. | nothing comes after quota |
@@ -461,3 +461,9 @@ def get_installed_packages(paths = None):
ws = WorkingSet(paths) if paths else working_set
return ["{0}=={1}".format(p.project_name, p.version) for p in ws]
+def get_package_properties(setup_py_path):
+ """Parse setup.py and return package details like package name, version, whether... | [filter_for_compatibility->[parse_setup_requires],clean_coverage->[cleanup_folder],parse_setup_requires->[parse_setup],process_glob_string->[filter_for_compatibility],install_package_from_whl->[run_check_call],find_packages_missing_on_pypi->[is_required_version_on_pypi,parse_setup,parse_require]] | Get installed packages in default or lib paths . | So it's a new SDK if the package is azure-core, azure-mgmt-core, or if any of the requirements are one of those? I'm super confused. `is_new_sdk` must not be what i am thinking based on the name. |
@@ -159,12 +159,14 @@ func raiseFdLimits() error {
func getHarmonyConfig(cmd *cobra.Command) (harmonyConfig, error) {
var (
- config harmonyConfig
- err error
+ config harmonyConfig
+ err error
+ migratedFrom string
+ configFile string
)
if cli.IsFlagChanged(cmd, configFlag) {
- conf... | [Warn,LastCommitBitmap,SerializeToHexStr,Info,Itoa,Rollback,ReadFile,SetParseErrorHandle,GetBoolFlagValue,New,Maximum,GetShardDownloader,ArchiveModes,SetViewIDs,Fprint,UpdateEthChainIDByShard,SetBeaconGroupID,FindAccount,IsFlagChanged,Split,Seed,UpdateConsensusInformation,RegisterService,Println,AddLogFile,ReshardingEp... | getHarmonyConfig returns a config object for the given command. applyRootFlags applies all flags that are not specified in the config to the given config. | Can we add a timeout to the `Scanf` to better support `node.sh`? The shell script was recommended to run in tmux session long time ago, and we need to take std input timeout as the corner case for backward compatibility. Also, I would appreciate if you can refactor this piece of code to a different function. |
@@ -1028,7 +1028,7 @@ namespace Dynamo.Tests
RunModel(openPath);
// check all the nodes and connectors are loaded
- Assert.AreEqual(3, CurrentDynamoModel.CurrentWorkspace.Nodes.Count);
+ Assert.AreEqual(3, CurrentDynamoModel.CurrentWorkspace.Nodes.Count());
Assert.AreEqual(3, CurrentDynamoModel.Curren... | [ListTests->[GetLibrariesToPreload->[GetLibrariesToPreload]]] | DSCore_LaceLongest - Lace Longest Negative test. | LOL so many parentheses. |
@@ -227,3 +227,11 @@ class Binance(Exchange):
f"{arrow.get(since_ms // 1000).isoformat()}.")
return await super()._async_get_historic_ohlcv(
pair=pair, timeframe=timeframe, since_ms=since_ms, is_new_pair=is_new_pair)
+
+ def funding_fee_cutoff(self, d: datetime):
+ ... | [Binance->[_async_get_historic_ohlcv->[info,_async_get_candle_history,super,get],stoploss_adjust->[float],fill_leverage_brackets->[Path,load_leverage_brackets,DDosProtection,TemporaryError,items,OperationalException,float,open,load],stoploss->[InvalidOrderException,amount_to_precision,create_dry_run_order,_lev_prep,pri... | Get the historical OHLV of a pair. | Do i understand this correctly - that binance still applies the fee if the trade is opened within the first 15 seconds of the "funding" hour? won't we need to be careful here as it'll not apply to 13:00, but only to 12:00, 16:00, ... as binance only applies fees every 4 hours? (could be wrong though) |
@@ -268,8 +268,8 @@ namespace Dynamo.ViewModels
case "Center":
RaisePropertyChanged("Center");
break;
- case "DefaultValueEnabled":
- RaisePropertyChanged("DefaultValueEnabled");
+ case "DefaultValue":
+ ... | [PortViewModel->[OnRectangleMouseLeftButtonDown->[MouseLeftButtonDown],_node_PropertyChanged->[RaisePropertyChanged,PropertyName],ChangeLevel->[Format,ExecuteCommand,Index,Empty,GUID],_port_PropertyChanged->[RaisePropertyChanged,PropertyName],Connect->[HandlePortClicked,DynamoViewModel,CurrentSpaceViewModel],OnRectangl... | port_PropertyChanged - port_PropertyChanged. | what was the reason to get rid of this? |
@@ -833,6 +833,15 @@ namespace System.Diagnostics.Tests
// process still exists, wait some time.
await Task.Delay(100);
}
+
+ DateTime now = DateTime.UtcNow;
+ if (start.Millisecond + Helpers.PassingTestTimeoutM... | [ProcessTests->[WriteScriptFile->[chmod],Task->[Process],GetGroups->[getgroups]]] | Kills a non - direct child process. | consider putting `Assert.True(false, "test timed out");` in the if statement instead to not repeat the condition |
@@ -728,12 +728,12 @@ func (c *ChainLink) verifyPayloadV2() error {
prev := c.getPrevFromPayload()
curr := c.getPayloadHash()
linkType, err := c.GetSigchainV2Type()
-
if err != nil {
return err
}
+ seqType := c.unpacked.seqType
- if err := ol.AssertFields(version, seqno, prev, curr, linkType); err != nil... | [ToEldestKID->[GetKID],verifyPayloadV2->[getPayloadHash,getPrevFromPayload],NeedsSignature->[NeedsSignature,IsStubbed],GetMerkleHashMeta->[IsStubbed],MatchFingerprint->[Eq],getSigPayload->[getFixedPayload,IsStubbed],HasRevocations->[GetRevokeKids,GetRevocations],IsInCurrentFamily->[ToEldestKID],Store->[VerifyLink,Strin... | verifyPayloadV2 checks that the payload is valid for the outer chain link. | make an accessor like the above? |
@@ -86,7 +86,7 @@ def test_real_query(user_api_client, product, channel_USD):
__typename
}
products(first: $first, sortBy: $sortBy, filter: {categories: [$categoryId],
- attributes: $attributesFilter}, channel: $channel) {
+ attributes: $attributesFilter,channel: $ch... | [test_get_nodes->[append,pop,format,to_global_id,get_nodes,raises,Mock],test_jwt_middleware->[partial,api_client_post,json,isinstance,reverse],test_middleware_dont_generate_sql_requests->[get,reverse,assert_num_queries],test_real_query->[first,post_graphql,to_global_id,get_graphql_content],test_filter_by_query_param->[... | This is a test method that uses the real query that returns a list of all the products query for a single node in a category. | Not needed change. |
@@ -9,10 +9,8 @@ import (
func (s *APIServer) registerPodsHandlers(r *mux.Router) error {
// swagger:operation GET /libpod/pods/json pods ListPods
- //
- // List Pods
- //
// ---
+ // summary: List pods
// produces:
// - application/json
// parameters:
| [registerPodsHandlers->[Handle,Methods]] | registerPodsHandlers registers the handlers for the Pod types swagger - operation force delete swagger - specification - specification swagger - specification Unpause a pod. | I know libpodListPods is not required. But it would be more consistent. |
@@ -31,8 +31,11 @@ namespace System.Net.WebSockets
WebSocketHandle.CheckPlatformSupport();
_state = (int)InternalState.Created;
+#if TARGETS_BROWSER
+ _options = new ClientWebSocketOptions();
+#else
_options = new ClientWebSocketOptions() { Proxy = DefaultWebProxy.Ins... | [ClientWebSocket->[Dispose->[Dispose],Abort->[Abort],ReceiveAsync->[ReceiveAsync]]] | Creates a new instance of the class that implements the standard WebSocket interface for a single object. get - Get the WebSocket state of the connection. | You could if-def Proxy setting only |
@@ -216,8 +216,7 @@ public class HttpObjectAggregator
protected void handleOversizedMessage(final ChannelHandlerContext ctx, HttpMessage oversized) throws Exception {
if (oversized instanceof HttpRequest) {
// send back a 413 and close the connection
- ChannelFuture future = ctx.wr... | [HttpObjectAggregator->[AggregatedFullHttpMessage->[protocolVersion->[protocolVersion],release->[release],getDecoderResult->[decoderResult],refCnt->[refCnt],retain->[retain],touch->[touch],setDecoderResult->[setDecoderResult],headers->[headers],setProtocolVersion->[setProtocolVersion],decoderResult->[decoderResult]],Ag... | Handles an oversized message. | just make this one listener which always close after logging the error ? No need to have to listeners and at worst have both call close. After this I will merge. @bryce-anderson thanks! |
@@ -83,8 +83,10 @@ RSpec.describe "UserBlock", type: :request do
end
it "raises ActiveRecord::RecordNotFound error if UserBlock not found" do
+ missing_id = blocked.id
+ blocked.destroy
expect do
- delete "/user_blocks/#{blocked.id}", params: { user_block: { blocked_id: blocked.id + ... | [sign_out,create,to,let,raise_error,describe,before,get,update,post,eq,sign_in,delete_all,username,it,require,id,delete] | It renders not - logged - in when logged in and doesn t get any more messages endregion region region. | I think `blocker` and `blocked` should be recreated with `let!` at the top, as by destroying the object we are making sure that if we ever switch on the random order, another test won't have the objects we destroyed in another one. |
@@ -138,6 +138,11 @@ func Commit(ctx context.Context, sess *session.Session, h *Handle, waitTime *int
if s.ExtraConfig != nil && h.TargetState() == StateStopped && h.Runtime.PowerState != types.VirtualMachinePowerStatePoweredOff {
detail := fmt.Sprintf("Reconfigure: collision of concurrent operations - expecte... | [Warn,start,Now,Warnf,CreateChildVM,Reconfigure,TargetState,DisableDestroy,refresh,Put,WaitForResult,ReloadConfig,Fault,IsVC,New,UTC,End,Container,Errorf,Debugf,NewVirtualMachine,Infof,RefreshFromHandle,stop,Spec,Begin,Sprintf,CreateVM] | Reconfigure attempts to reconfigure the container if it can continue without a change version Error if we failed to update due to concurrent access. | Ad @dougm suggested we should add %T here |
@@ -48,6 +48,8 @@ import org.springframework.test.context.junit4.SpringJUnit4ClassRunner;
import org.springframework.web.context.request.RequestAttributes;
import org.springframework.web.context.request.RequestContextHolder;
+import groovy.lang.GroovyObject;
+
/**
* @author Dave Syer
| [GroovyControlBusTests->[testFailOperationWithCustomScope->[assertTrue,send,getMessage,build,getCause,contains,getClass,fail],MockRequestAttributes->[getAttribute->[get],setAttribute->[put]],FooAdvice->[doInvoke->[execute]],testFailOperationOnAbstractBean->[assertTrue,send,getMessage,build,getCause,contains,getClass,fa... | Imports a single object in the Java model. A class that tests if a message is not a reserved word. | Moving this looks like a difference between our STS and your IDEA setup. Will move back during merge. LGTM; merging. |
@@ -108,14 +108,6 @@ public class GameProperties extends GameDataComponent {
return (String) value;
}
- public Object get(final String key, final Object defaultValue) {
- final Object value = get(key);
- if (value == null) {
- return defaultValue;
- }
- return value;
- }
-
public void ad... | [GameProperties->[applyByteMapToChangeProperties->[streamToIEditablePropertiesList],get->[get],applyListToChangeProperties->[get],getEditableProperties->[get]]] | Get the value of a property. | Are you positive this isn't used anywhere by reflection or anything? |
@@ -9,10 +9,10 @@ using Robust.Shared.ViewVariables;
namespace Content.Shared.Gravity
{
[RegisterComponent]
+ [NetworkedComponent]
public sealed class GravityComponent : Component
{
public override string Name => "Gravity";
- public override uint? NetID => ContentNetIDs.GRAVITY;
... | [GravityComponent->[HandleComponentState->[HandleComponentState]]] | Creates a class that implements the GravityComponent interface. | I noticed some of them don't have (), is that intentional? |
@@ -493,8 +493,12 @@ class Version(OnChangeMixin, ModelBase):
return bool(self.source)
@property
- def admin_review(self):
- return self.addon.admin_review
+ def needs_admin_code_review(self):
+ return self.addon.needs_admin_code_review
+
+ @property
+ def needs_admin_content_r... | [update_status->[update_status],Version->[was_auto_approved->[is_public],is_public->[is_public],transformer->[rollup,_compat_map],is_allowed_upload->[compatible_platforms],inherit_nomination->[reset_nomination_time],from_upload->[VersionCreateError,from_upload],transformer_activity->[rollup],delete->[save],VersionManag... | A function to return a dictionary of admin_review_nids. | Can we drop these two properties? Seems like they are unnecessary shortcuts. |
@@ -465,6 +465,12 @@ def plot_trans(info, trans='auto', subject=None, subjects_dir=None,
.. versionadded:: 0.14
+ bem : list of dict | Instance of ConductorModel | None
+ Can be either the BEM surfaces (list of dict), a BEM solution or a
+ sphere model. If not None, ``source`` must be None... | [_plot_mpl_stc->[_handle_time,_limits_to_control_points,_smooth_plot],plot_source_estimates->[_plot_mpl_stc,_limits_to_control_points,_handle_time],_sensor_shape->[_make_tris_fan],_dipole_changed->[_plot_dipole],plot_trans->[_fiducial_coords,_create_mesh_surf]] | Plots the head sensor and source space alignment in 3D. Plot a single - part of a sequence of CNA - specific objects. Missing nanomagical index. Return a object if the source spaces have a non - zero n - node cycles. | don't add param to deprecated function |
@@ -73,9 +73,9 @@ func mustNewSolanaKeyFromRaw(raw []byte) solanaKeyBundle {
return kb
}
-// PublicKeyAddressOnChain returns public component of the keypair used on chain
-func (kb *solanaKeyBundle) PublicKeyAddressOnChain() string {
- return kb.solanaKeyring.SigningAddress().Hex()
+// OnChainPublicKey returns pub... | [Raw->[Marshal],Unmarshal->[Unmarshal],Marshal->[Marshal]] | PublicKeyAddressOnChain returns the public key address on the chain. | could we have any solana public keys that are converted into string as base58 encoded (solana expected format)? here, and also for the solana transmitter key |
@@ -392,13 +392,13 @@ class BuildReferenceMapAdapter<R> implements SortedMap<Integer,R> {
}
private Entry<Integer,BuildReference<R>> _wrap(Entry<Integer,R> e) {
- return new MapEntry(e.getKey(),wrap(e.getValue()));
+ return new AbstractMap.SimpleEntry<>(e.getKey(),wrap(e.getVal... | [BuildReferenceMapAdapter->[headMap->[headMap],equals->[equals],hashCode->[hashCode],get->[get,unwrap],remove->[remove,unwrap],comparator->[comparator],isEmpty->[isEmpty],tailMap->[tailMap],lastKey->[lastKey],keySet->[keySet],firstKey->[firstKey],values->[values],containsKey->[containsKey],CollectionAdapter->[size->[si... | Wrap the given entry in a MapEntry if it is not found in the cache. | The only actual change of substance in this PR. `groovy.util.MapEntry` seemed like an odd implementation of a map entry, as it is meant for use by Groovy and just happens to be on the classpath. This is also the only import from `groovy.util` in `src/main/` and seemed like an oversight. The implementation in `AbstractM... |
@@ -343,6 +343,8 @@ class Params(MutableMapping):
----------
quiet: bool, optional (default = False)
Whether to log the parameters before returning them as a dict.
+ infer_type_and_cast : bool, optional (default = False)
+ If True, we infer types and cast (e.g. things lo... | [with_fallback->[merge->[with_fallback,merge],merge],parse_overrides->[_environment_variables,unflatten,evaluate_snippet],infer_and_cast->[infer_and_cast],_environment_variables->[_is_encodable],pop_choice->[Params],Params->[pop->[pop],pop_choice->[pop],as_flat_dict->[recurse->[recurse],recurse],from_file->[with_fallba... | Returns a dictionary of the parameters of the object. | s/things look like/things that look like/ |
@@ -38,11 +38,9 @@ class Scalasca(Package):
homepage = "http://www.scalasca.org"
url = "http://apps.fz-juelich.de/scalasca/releases/scalasca/2.1/dist/scalasca-2.1.tar.gz"
- version('2.2.2', '2bafce988b0522d18072f7771e491ab9',
- url='http://apps.fz-juelich.de/scalasca/releases/scalasca/2.2/dist... | [Scalasca->[install->[make,configure],depends_on,version]] | Creates a new object from a list of objects in the GNU General Public 2. 1 - > install - configure Cube and ScoreP. | You don't actually need to split this line into two. We automatically exempt lines containing `https?:` from the flake8 line length checks. |
@@ -10,3 +10,9 @@ arrowParens: avoid
# jsx and tsx rules:
jsxBracketSameLine: false
+
+# java rules:
+overrides:
+ - files: "*.java"
+ options:
+ tabWidth: 4
| [No CFG could be retrieved] | JSX and TSX rules. | This should be added conditionally: it's not useful if skipServer is true |
@@ -891,11 +891,9 @@ def _document_api_PUT(request, document_slug, document_locale):
expected_etags = parse_etags(if_match)
except ValueError:
expected_etags = []
- current_etag = calculate_etag(doc.get_html(section_id))
- if settings.DJANGO_1_11:
- ... | [repair_breadcrumbs->[repair_breadcrumbs],document_api->[_add_kuma_revision_header],children->[_make_doc_structure],document->[_apply_content_experiment,_get_html_and_errors,_filter_doc_html,_document_redirect_to_create,_add_kuma_revision_header,_default_locale_fallback,_get_seo_parent_title,_document_deleted,_get_doc_... | Handle PUT requests for the document_api view. This function is called when a user requests a new node in the database. It will return. | I was hoping it would be resolved this way at this point, so thanks! |
@@ -65,7 +65,8 @@ class ParamAttr(object):
regularizer=None,
trainable=True,
gradient_clip=None,
- do_model_average=False):
+ do_model_average=False,
+ distributed=False):
self.name = name
self.initia... | [ParamAttr->[_set_default_bias_initializer->[_set_default_initializer],_to_attr->[ParamAttr,_to_attr],_set_default_param_initializer->[_set_default_initializer]]] | Initialize a object. | do you have example for distributed=True? I wonder is it possible to inference the value of distributed through op type? |
@@ -569,6 +569,17 @@ DBPriv *DBPrivOpenDB(const char *const dbpath, const dbid id)
}
goto err;
}
+#ifndef __MINGW32__
+ if (p_euid == 0)
+ {
+ rc = setgid(current_gid);
+ if (rc)
+ {
+ Log(LOG_LEVEL_ERR, "Could not set group id back to previous value.");
+ ... | [DBPrivClean->[mdb_strerror,mdb_env_get_userctx,Log,GetWriteTransaction,mdb_drop,assert],DBPrivCloseDB->[free,mdb_env_get_userctx,AbortTransaction,pthread_key_delete,mdb_env_close,assert],inline->[HandleLMDBCorruption],DBPrivCommit->[mdb_strerror,mdb_txn_commit,free,pthread_setspecific,CheckLMDBCorrupted,mdb_env_get_us... | Open a database handle. private int dbpath_maxreaders ; open - open database dbpath - path of the database in which we are currently in the. | This should be done right after `LmdbEnvOpen()` or in the `err:` section to make sure it also happens if the database fails to be opened. |
@@ -361,7 +361,7 @@ public class JMSMappingOutboundTransformerTest {
assertNotNull(amqp.getBody());
assertTrue(amqp.getBody() instanceof AmqpValue);
assertTrue(((AmqpValue) amqp.getBody()).getValue() instanceof Binary);
- assertEquals(0, ((Binary) ((AmqpValue) amqp.getBody()).getValue()).getLe... | [JMSMappingOutboundTransformerTest->[createObjectMessage->[createObjectMessage],createTextMessage->[createTextMessage]]] | This method converts an empty object message to an AMQP message with an empty value body. | At first glance this looks wrong as I'd have expected the sender to have sent a zero length Binary and so the resulting message should also contain a zero length Binary as the value in the encoded AmqpValue. |
@@ -49,8 +49,8 @@ public class DruidDataSource
this.name = name;
this.properties = properties;
- this.partitionNames = Maps.newHashMap();
- this.segmentsHolder = new ConcurrentSkipListSet<DataSegment>();
+ this.idToSegmentMap = new HashMap<>();
+ this.segmentsHolder = new HashSet<>();
}
... | [DruidDataSource->[hashCode->[hashCode],toString->[toString],isEmpty->[isEmpty],equals->[equals]]] | Gets the name of the . | is concurrency not needed? |
@@ -91,6 +91,16 @@ module Engine
def or_set_finished
depot.export! if %w[2 3 4].include?(@depot.upcoming.first.name)
end
+
+ def float_corporation(corporation)
+ super
+
+ return unless players.size == 2
+
+ @log << "#{corporation.name}'s remaining shares are transferred... | [G18Chesapeake->[columbia->[name,find],baltimore->[name,find],cornelius->[name,find],action_processed->[check_special_tile_lay],stock_round->[new],operating_round->[new],or_set_finished->[export!,name,include?],setup->[name,add_ability,new],check_special_tile_lay->[closed?,hexes,entity,include?,name,remove_ability,id,a... | if there is a finished node with this node set it as finished node. | return super unless players |
@@ -722,6 +722,8 @@ public class SparkCombineFn<InputT, ValueT, AccumT, OutputT> implements Serializ
WindowedAccumulator.create(this, toValue, windowingStrategy, windowComparator);
accumulator.add(value, this);
return accumulator;
+ } catch (RuntimeException ex) {
+ throw ex;
} cat... | [SparkCombineFn->[getWindow->[getWindow],createCombiner->[create,add],WindowedAccumulatorCoder->[decode->[isMapBased,create,decode],encode->[isMapBased,isEmpty,encode]],ctxtForWindows->[forInput,SparkCombineContext],MapBasedWindowedAccumulator->[isEmpty->[isEmpty],add->[toValue]],create->[create],extractOutputStream->[... | Create a combiner for the given value. | This is exactly what fixes `ViewTest.testNonSingletonSideInput`. Some internal runners-core stuff throw `RuntimeException`s like `IllegalArgumentException` and the tests expect those, so we should not be re wrapping those in a different kind. |
@@ -733,7 +733,7 @@ export class AmpAnalytics extends AMP.BaseElement {
*/
expandTemplateWithUrlParams_(spec, expansionOptions) {
return this.variableService_
- .expandTemplate(spec, expansionOptions)
+ .expandTemplate(spec, expansionOptions, this.element)
.then(key =>
Services.url... | [No CFG could be retrieved] | Checks if the given spec is enabled. Returns expansion options for the given tag - level objects. | Since we pass the binding info to `expandUrlAsync`, do we want to pass the same to `expandTemplate`? |
@@ -244,6 +244,11 @@ class PathDownloader extends FileDownloader implements VcsCapableDownloaderInter
return ': Mirroring from '.$package->getDistUrl();
}
+ /**
+ * @param mixed[] $transportOptions
+ *
+ * @return array{int, non-empty-list<int>}
+ */
private function computeAllow... | [PathDownloader->[install->[symlink,getDistUrl,mirror,isAbsolutePath,getInstallOperationAppendix,normalizePath,computeAllowedStrategies,writeError,junction,getTransportOptions,findShortestPath,removeDirectory],getVcsReference->[dump,guessVersion],download->[getName,getDistUrl],getInstallOperationAppendix->[getTransport... | Returns a string describing the strategy and the allowed strategies for the install operation. | I would even add `@phpstan-return array{self::STRATEGY_*, non-empty-list<self::STRATEGY_*>}` as it is not arbitrary integers |
@@ -2,10 +2,9 @@ class Report < ActiveRecord::Base
include SearchableModel
validates :name,
- presence: true,
- length: { minimum: 2, maximum: 30 },
+ length: { minimum: NAME_MIN_LENGTH, maximum: NAME_MAX_LENGTH },
uniqueness: { scope: [:user, :project], case_sensitive: false }
- validates :descr... | [Report->[save_json_element->[save_json_element]]] | Creates an instance of Report with the given attributes. Save the report elements including the contents of the report elements. | Align the parameters of a method call if they span more than one line. |
@@ -60,6 +60,13 @@ public class CommitManager {
log.tracef("Tracking is disabled. Clear tracker: %s", tracker);
}
tracker.clear();
+ } else {
+ for (Iterator<Map.Entry<Object, DiscardPolicy>> iterator = tracker.entrySet().iterator();
+ iterator.hasNext(); ) {
+... | [CommitManager->[isEmpty->[isEmpty],commit->[apply->[commit],commit]]] | Stop tracking the state transfer. | I think I said this before, but maybe it would have been simpler to use two separate maps :) |
@@ -169,3 +169,16 @@ class TestRemoteShouldHandleUppercaseRemoteName(TestDvc):
ret = main(["push", "-r", self.upper_case_remote_name])
self.assertEqual(ret, 0)
+
+
+def test_large_dir_progress(repo_dir, dvc):
+ from dvc.utils import LARGE_DIR_SIZE
+ from dvc.progress import progress
+
+ # C... | [TestRemoteRemoveDefault->[test->[assertTrue,ConfigObj,keys,assertEqual,get,format,join,main]],TestRemoteRemove->[test->[main,assertEqual]],TestRemoteShouldHandleUppercaseRemoteName->[test->[get_local_storagepath,main,assertEqual]],TestRemoteDefault->[test->[ConfigObj,assertEqual,get,join,main]],TestRemote->[test_faile... | Test if there is a missing node in the system. | Please use os.path.join. I know that in this case python is able to handle posix relpath even on windows correctly, but we try to generally use join instead to prevent potential errors in the future. |
@@ -76,11 +76,11 @@ public class BeamFnDataGrpcClient implements BeamFnDataClient {
* (signaled by an empty data block), the returned future is completed successfully.
*/
@Override
- public <T> CompletableFuture<Void> forInboundConsumer(
+ public <T> CompletableFuture<Void> receive(
Endpoints.ApiSer... | [BeamFnDataGrpcClient->[forOutboundConsumer->[debug,getOutboundObserver,getInstructionId,getTarget,getClientFor],forInboundConsumer->[debug,getInstructionId,complete,getTarget,getClientFor],getClientFor->[computeIfAbsent,apply,BeamFnDataGrpcMultiplexer,newStub],getLogger]] | Registers a consumer for the given input location with the given coder and exception handling. | I never thought the BeamFnDataInboundObserver would need to be responsible for closing the consumers as the consumers were expected to be stateless. The only one that needed some state was the outbound consumer since it needs a signal of when the bundle processing is done. This is why the ThrowingConsumer / CloseableTh... |
@@ -49,9 +49,12 @@ public class PieChart implements Drawable, Legendable {
//mValues = new double[] {5,5,5,5,5,5,5,5,5,5,5,5,5,5,5,5,5,5,5,5,5};
mPercent = new double[mValues.length];
for(double v: mValues) mSum +=v;
- mPercent[0]= mValues[0]/ mSum;
+
+ double denominator = (mSum == 0) ? 1 : mSum;
+
+ ... | [PieChart->[paint->[round,getFrameThickness,cos,max,drawArc,stringWidth,drawString,min,getColor,getFontMetrics,getHeight,ColorWrap,sin,setColor,fillRect,getClipBounds,fillArc],ColorWrap]] | Creates a chart from a list of color - based values. Paints the . | Sorry I missed this in the first review, but in AnkiDroid we don't like to use `if` / `else` without curly braces; we prefer the one line form: `double denominator = (mSum == 0) ? 1 : mSum;` |
@@ -14741,6 +14741,7 @@ GAME( 1979, galaxianbl, galaxian, galaxian, galaxianbl, galaxian_state, init_
GAME( 1979, galaxbsf2, galaxian, galaxian, galaxian, galaxian_state, init_galaxian, ROT90, "bootleg", "Galaxian (bootleg, set 3)", ... | [No CFG could be retrieved] | GAME constants for all Galaxian bootroms. Find all bootlegs that are not part of the Galaxy. | Make new clone set names by appending characters to the parent set name. |
@@ -312,6 +312,9 @@ public class HiveWriterFactory
.map(HiveTypeName::toString)
.collect(joining(":")));
+ schema.setProperty("hive.serialization.extend.nesting.levels", "true");
+ schema.setProperty("hive.serialization.extend.additional.... | [HiveWriterFactory->[validateSchema->[getColumnTypes,PrestoException,toMap,difference,size,getHiveType,equals,getColumnNames,get,format,collect,isEmpty,identity,keySet],DataColumn->[requireNonNull],getFileExtension->[PrestoException,equals,get,asSubclass,getDefaultExtension,getOutputFormat,getBoolVar],computeBucketedFi... | Creates a writer for the given page. Write to a new partition or an existing unpartitioned table. Checks if an existing partition is append to an existing partitioned table and if so updates the creates a file writer for the given partition and adds it to the partition. | can we have a constant for these? |
@@ -228,6 +228,12 @@ class CollectionCreate(ModelMutation):
if cleaned_input.get("background_image"):
create_collection_background_image_thumbnails.delay(instance.pk)
+ @classmethod
+ def post_save_action(cls, info, instance, cleaned_input):
+ products = instance.products.all()
+ ... | [ProductMediaUpdate->[Arguments->[ProductMediaUpdateInput],perform_mutation->[save,ProductMediaUpdate]],CollectionCreate->[save->[save],Arguments->[CollectionCreateInput],perform_mutation->[CollectionCreate]],CollectionReorderProducts->[perform_mutation->[CollectionReorderProducts]],ProductTypeUpdate->[Arguments->[Prod... | Save a instance. | Should we prefetch any data? |
@@ -341,6 +341,11 @@ describe Email::Receiver do
end
it "works" do
+ handler_calls = 0
+ handler = proc { |_| handler_calls += 1 }
+
+ DiscourseEvent.on(:topic_created, &handler)
+
expect { process(:text_reply) }.to change { topic.posts.count }
expect(topic.posts.last.raw).to eq... | [process->[process!],receive->[process!],process_mail_with_message_id->[process!],reply_as_group_user->[create,id,last],email,round,create,let,process,freeze_time,eq_time,it,contain_exactly,to,with,topic_levels,types,change,height,block_auto_generated_emails,approve_unless_trust_level,auto_generated_allowlist,select_bo... | checks that all the fields of a topic are set correctly automatically elides gmail quotes. | Sorry I know it's not on you, but what does "works" mean? Can we elaborate in the description? |
@@ -319,10 +319,14 @@ func SerializeProperties(props resource.PropertyMap, enc config.Encrypter) (map[
func SerializePropertyValue(prop resource.PropertyValue, enc config.Encrypter) (interface{}, error) {
// Skip nulls and "outputs"; the former needn't be serialized, and the latter happens if there is an output
//... | [OperationType,IsObject,NewNullProperty,NewArrayProperty,ArrayValue,NewArchiveProperty,Mappable,Assertf,DeserializeAsset,ValueOf,Encrypter,PropertyKey,OfType,Wrap,NewNumberProperty,IsNotEmpty,NewAssetProperty,Serialize,Marshal,insert,ParseTolerant,New,DeserializeArchive,Errorf,UpToDeploymentV2,Assert,StableKeys,Decrypt... | SerializeProperties serializes a resource object so that it can be serialized. Asset returns the serialized version of the asset or archive. | Note that these changes are unrelated to the secrets bits, but are necessary in order to properly serialize input properties that contain unknown values. The deserializer has also been updated to understand the unknown sentinel. |
@@ -89,7 +89,7 @@ public final class InitialFlowSetupAction extends AbstractAction {
logger.debug("Placing service in FlowScope: " + service.getId());
}
- context.getFlowScope().put("service", service);
+ context.getFlowScope().put(CentralAuthenticationService.PROTOCOL_PARAMETER_SE... | [InitialFlowSetupAction->[doExecute->[hasText,debug,getService,getHttpServletRequest,retrieveCookieValue,getContextPath,put,result,isDebugEnabled,info,setCookiePath,valueOf,getId]]] | Execute the action. | the CAS protocol parameter and the value we put in the flow scope are two different thiings. This muddles the parameters. |
@@ -84,10 +84,7 @@ public class ComponentCleanerService {
}
private void deleteFromIndices(String projectUuid) {
- issueIndexer.deleteProject(projectUuid);
- testIndexer.deleteByProject(projectUuid);
- projectMeasuresIndexer.deleteProject(projectUuid);
- componentIndexer.deleteByProjectUuid(projectU... | [ComponentCleanerService->[hasNotProjectScope->[scope,equals],isNotDeletable->[getBooleanProperty,get,qualifier],deleteFromIndices->[deleteByProject,deleteByProjectUuid,deleteProject],delete->[hasNotProjectScope,IllegalArgumentException,isNotDeletable,uuid,closeQuietly,getByKey,deleteFromIndices,deleteProject,openSessi... | This method deletes all indices for the given project. | If the order of indexers is relevant use `forEachOrdered`. Otherwise make the field a Collection instead of a List. |
@@ -4,4 +4,4 @@
# license information.
# --------------------------------------------------------------------------
-VERSION = "12.0.3"
+VERSION = "12.1.0b1"
| [No CFG could be retrieved] | License information. | I will make it 12.1.0b, let me know if you feel it's weird, I just feel not confident about Jumbo blob feature, since with max_single_put_size equals 64MB, user always get timeout .... I feel panic about max_single_put_size equals 5GB |
@@ -52,12 +52,11 @@ import static java.util.Collections.singletonList;
SuppressWarningTest.class,
SonarLintTest.class,
ExternalReportTest.class,
- DuplicationTest.class,
- JspTest.class
+ DuplicationTest.class
})
public class JavaTestSuite {
- static final FileLocation JAVA_PLUGIN_LOCATION = FileLocati... | [JavaTestSuite->[getMeasureAsDouble->[getMeasure],getComponent->[getComponent],getMeasureAsInteger->[getMeasure]]] | Imports a single component. This method is used to create a key for the issue. | ohlala, nop, we just dropped a test here. |
@@ -354,7 +354,7 @@ public class InterceptedStaticMethodsProcessor {
ResultHandle interceptorInstane = createInterceptor(interceptorBean, init, creationalContext);
return init.invokeStaticMethod(
MethodDescriptors.INTERCEPTOR_INVOCATION_AROUND_INVOKE,
- interceptorBean,... | [InterceptedStaticMethodsProcessor->[InterceptedStaticMethodsMethodVisitor->[visitEnd->[visitEnd]],InterceptedStaticMethodsClassVisitor->[visitMethod->[visitMethod]],callInitializer->[callInitializer]]] | Create interceptor invocation. | we need to keep default constructor instead... |
@@ -30,7 +30,7 @@ namespace System.Text.Json.Serialization
/// <summary>
/// Can the converter have $id metadata.
/// </summary>
- internal virtual bool CanHaveIdMetadata => true;
+ internal virtual bool CanHaveIdMetadata => false;
internal bool CanBePolymorphic { get... | [JsonConverter->[CreateObject->[NodeJsonObjectCustomConverterNotAllowedOnExtensionProperty],ReadElementAndSetProperty->[NodeJsonObjectCustomConverterNotAllowedOnExtensionProperty],ShouldFlush->[FlushThreshold,BytesPending]]] | Creates a base type that can be converted to or from JSON. for debugging. | What impact will this have for 3rd-party JsonConverter-derived types? |
@@ -294,7 +294,7 @@ public class TaskToolbox
return indexMergerV9;
}
- public File getFirehoseTemporaryDir()
+ public File getIndexingTmpDir()
{
return new File(taskWorkDir, "firehose");
}
| [TaskToolbox->[publishSegments->[apply->[getInterval],copyOf,SegmentInsertAction,values,index,submit],getPersistDir->[File],getQueryRunnerFactoryConglomerate->[get],getFirehoseTemporaryDir->[File],getMergeDir->[File],fetchSegments->[getSegmentFiles,newLinkedHashMap,put],checkNotNull,setObjectMapper]] | get the indexMergerV9 object. | Perhaps rename the temporary directory as well |
@@ -51,7 +51,7 @@ public class ListBucketHandler extends Handler {
private int maxBuckets;
@Option(names = {"--start", "-s"},
- description = "The first bucket to start the listing")
+ description = "The listing will start from bucket after the startBucket.")
private String startBucket;
@Optio... | [ListBucketHandler->[call->[hasNext,OzoneAddress,createClient,ensureVolumeAddress,IllegalArgumentException,printObjectAsJson,listBuckets,createOzoneConfiguration,isVerbose,getVolume,printf,next,getVolumeName]]] | Handler for listing a list of buckets in a volume. Reads the list of objects from the specified volume. | Suggestion: The bucket to start the listing from. This will be excluded from the result. |
@@ -89,6 +89,14 @@ public class DistributingExecutor {
.apply(executionContext, securityContext.getServiceContext())
.inject(statement);
+ if (injected.getStatement() instanceof InsertInto) {
+ throwIfInsertOnInternalTopic(
+ statement.getConfig(),
+ executionContext.getMet... | [DistributingExecutor->[checkAuthorization->[checkAuthorization]]] | Executes a command with the given identifier. | This ignores property overrides associated with the request, right? I'm wondering about the situation where a user has a valid reason to `INSERT INTO` an topic marked as internal by default, issues the request and sees an error, and now wants to override the `SYSTEM_INTERNAL_TOPICS_CONFIG` config to enable their use ca... |
@@ -66,12 +66,12 @@ module.exports = class extends BaseGenerator {
} else {
this.log(chalk.bold('\nInstalling App Engine Java SDK'));
this.log(`... Running: gcloud components install ${component} --quiet`);
- c... | [No CFG could be retrieved] | Load configuration options for the application engine. This function return all the properties of the prod database. | I think the error message here should prompt the user to run `gcloud components install` manually. The `gcloud` sdk install was already checked previously. |
@@ -42,6 +42,12 @@ export class AmpSelector extends AMP.BaseElement {
/** @private {?../../../src/service/action-impl.ActionService} */
this.action_ = null;
+
+ /** @private {number} */
+ this.focusedIndex_ = 0;
+
+ /** @private {!KEYBOARD_SELECT_MODES} */
+ this.kbSelectMode_ = KEYBOARD_SELECT_... | [No CFG could be retrieved] | Creates an AMP selector that uses a single element to select an option or a list of Handle mutations of the selected attribute. | this should be NONE or ideally null |
@@ -639,6 +639,8 @@ class CallablePTransform(PTransform):
def ptransform_fn(fn):
"""A decorator for a function-based PTransform.
+ For internal use only; no backwards-compatibility guarantees.
+
Args:
fn: A function implementing a custom PTransform.
| [_PValueishTransform->[visit_tuple->[visit],visit_dict->[visit],visit_list->[visit]],_ZipPValues->[visit_tuple->[visit_list],visit->[visit],visit_dict->[visit],visit_list->[visit]],PTransform->[type_check_inputs_or_outputs->[_ZipPValues],__ror__->[_MaterializePValues,_SetInputPValues],_extract_input_pvalues->[_dict_tup... | A function - based PTransform class decorator. A custom PTransform class provides a simple wrapper. | Not for internal use, just note that it's expiremental (and, yes, not backwards compatible). |
@@ -25,8 +25,7 @@
{
if (Debugger.IsAttached)
{
- string reason;
- if (Licensing.LicenseExpirationChecker.HasLicenseExpired(Licensing.LicenseManager.License, out reason))
+ if (Licensing.LicenseManager.HasLicenseExpired())
{... | [InvokeHandlersBehavior->[DispatchMessageToHandlersBasedOnType->[GetType,MessageType,DebugFormat,Warn,ForEach,Name,GetDispatcherFactoryFor,ToList,Instance,dispatch,Invocation],Invoke->[context,HasLicenseExpired,IsAttached,Builder,MessageHandler,License,FatalFormat,DispatchMessageToHandlersBasedOnType,next],IMessageDisp... | This method is called when a message is not available in the context. | How about we register a behaviour that does this logging so we don't pollute `InvokeHandlersBehavior` ? Also the registration could be a bit dynamic and only register if not a valid license ? |
@@ -282,8 +282,9 @@ namespace Content.Client.Arcade
_highscoresRootContainer.AddChild(menuInnerPanel);
- var menuContainer = new VBoxContainer()
+ var menuContainer = new BoxContainer
{
+ Orientation = LayoutOrientation.Vertical,
Horizonta... | [BlockGameMenu->[KeyBindUp->[KeyBindUp],KeyBindDown->[KeyBindDown]]] | Creates a container that contains the menu and the menu s high scores. Add a back button to the menu. | ok the indentation is just fucked on most of these so im just not gonna mention it further |
@@ -146,7 +146,15 @@ export const login = (username, password, rememberMe = false) => async (dispatch
type: ACTION_TYPES.LOGIN,
payload: axios.post('api/authentication', data, { headers: { 'Content-Type': 'application/x-www-form-urlencoded' } })
});
+ <%_ if (enableTranslation) { _%>
+ const accountResult... | [No CFG could be retrieved] | The login function private function to handle authentication. | please get this from the state instead by using `getState()` here as it will be cleaner pattern since it goes through the reducer |
@@ -75,12 +75,6 @@ import (
"sigs.k8s.io/controller-runtime/pkg/controller/controllerutil"
)
-type byName []corev1.ConfigMap
-
-func (a byName) Len() int { return len(a) }
-func (a byName) Swap(i, j int) { a[i], a[j] = a[j], a[i] }
-func (a byName) Less(i, j int) bool { return a[i].ObjectMeta.Name <... | [GetIngressFQDNDeprecated->[Sprintf,IngressDomain],Build->[seedObjectFunc],GetIngressFQDN->[Sprintf,IngressDomain],GetValidVolumeSize->[String,ParseQuantity,Cmp],CheckMinimumK8SVersion->[Version,CompareVersions,Errorf],WithSeedObjectFromLister->[Get],Status,DeleteReserveExcessCapacity,OpDestroyAndWait,DeleteDeployments... | Len returns the length of the array. | Thanks for cleaning this up! Actually, I wanted to do this as well while introducing the generic sorter, but then forgot about it. |
@@ -1805,16 +1805,4 @@ public class Util {
private static PathRemover newPathRemover(@NonNull PathRemover.PathChecker pathChecker) {
return PathRemover.newFilteredRobustRemover(pathChecker, DELETION_RETRIES, GC_AFTER_FAILED_DELETE, WAIT_BETWEEN_DELETION_RETRIES);
}
-
- /**
- * If this flag is ... | [Util->[intern->[intern],getMethod->[getMethod],ifOverridden->[isOverridden],getDigestOf->[getDigestOf],getHostName->[getHostName],isSymlink->[isSymlink],getPastTimeString->[getTimeSpanString],tokenize->[tokenize],fixNull->[fixNull],rawEncode->[encode],loadFile->[loadFile],fixEmptyAndTrim->[fixEmpty],createSymlinkAtomi... | New PathRemover with a roust Remover. | Is this still relevant? (I think we can probably go without, but looks like it deserves some investigation if you haven't yet.) |
@@ -831,9 +831,8 @@ namespace System.Reflection
else if (right == null)
return false;
- // This assembly should work in netstandard1.3,
- // so we cannot use MemberInfo.MetadataToken here.
- // Therefore, it compare... | [DispatchProxyGenerator->[ProxyAssembly->[EnsureTypeIsVisible->[GenerateInstanceOfIgnoresAccessChecksToAttribute]],ProxyBuilder->[MethodInfoEqualityComparer->[Equals->[Equals],GetHashCode->[GetHashCode]],AddInterfaceImpl->[EnsureTypeIsVisible],ParametersArray->[EndSet->[Stind,Convert]],Stind->[GetTypeCode],Convert->[Ge... | Checks if two MethodInfos are equal. | Is there an issue tracking this? |
@@ -144,6 +144,7 @@ process_credential_response(Drpc__Response *response,
if (response->status != DRPC__STATUS__SUCCESS) {
/* Recipient could not parse our message */
+ D_ERROR("Response status is: %d\n", response->status);
return -DER_MISC;
}
| [char->[getenv],dc_sec_request_creds->[process_credential_response,drpc__response__free_unpacked,request_credentials_via_drpc],int->[security_credential__unpack,D_ALLOC,daos_iov_set,memcpy,drpc_close,drpc__call__free_unpacked,new_credential_request,drpc_call,get_agent_socket_path,drpc_connect,sanity_check_credential_re... | This function processes a credential response. | Since it is a D_ERROR, it should really be more explicit. |
@@ -318,9 +318,12 @@ public class OMFailoverProxyProvider implements
if (!currentProxyOMNodeId.equals(newLeaderOMNodeId)) {
if (omProxies.containsKey(newLeaderOMNodeId)) {
currentProxyOMNodeId = newLeaderOMNodeId;
+ lastAttemptedOM = currentProxyOMNodeId;
currentProxyIndex = omNodeI... | [OMFailoverProxyProvider->[createOMProxyIfNeeded->[createOMProxy]]] | This method is used to update the current leader node ID and the index of the current proxy. | We are updating lastAttemptedOM to the new OM which will be tried after failover. The assignment should happen before the currentProxyOMNodeId is updated with newLeaderOMNodeId. |
@@ -57,11 +57,13 @@ namespace System.Net
public int ActiveLength => _availableStart - _activeStart;
public Span<byte> ActiveSpan => new Span<byte>(_bytes, _activeStart, _availableStart - _activeStart);
- public ReadOnlySpan<byte> ActiveReadOnlySpan => new ReadOnlySpan<byte>(_bytes, _activeSta... | [ArrayBuffer->[Commit->[Assert],EnsureAvailableSpace->[Rent,Return,Assert,Length,BlockCopy],Grow->[EnsureAvailableSpace],Dispose->[Return],Discard->[Assert],Auto,Length,Rent]] | Discards a chunk of data from the ring buffer. | I believe @wfurt added `ActiveReadOnlySpan` recently for `SslStream`. Is it no longer used there? |
@@ -113,7 +113,7 @@ def test_voucher_query(
]
-def test_sale_query(staff_api_client, sale, permission_manage_discounts):
+def test_sale_query(staff_api_client, sale, permission_manage_discounts, channel_USD):
query = """
query sales {
sales(first: 1) {
| [test_voucher_add_no_catalogues->[exists,post_graphql,to_global_id,get_graphql_content],voucher_countries->[save],test_query_vouchers_with_filter_discount_type->[Voucher,len,post_graphql,get_graphql_content,bulk_create],test_create_voucher->[isoformat,get,post_graphql,get_graphql_content,now,timedelta,Decimal],test_sal... | Test that a sale is in the correct state. | Maybe we should use in this test `sale_with_many_channels` and check channelListing for at least 2 channels? |
@@ -79,13 +79,4 @@ RSpec.describe OpenidConnect::TokenController do
end
end
end
-
- describe '#options' do
- it 'is empty so it can be used as a pre-flight request' do
- process :options, 'OPTIONS'
-
- expect(response).to be_ok
- expect(response.body).to be_empty
- end
- end
end
| [create,new,let,with_indifferent_access,to_not,describe,process,subject,it,to,link_identity,url_helpers,post,let!,with,require,include,to_i,have_key,hex,read,session_uuid,context,hash_including,encode] | is empty so it can be used as a pre - flight request. | does 5.1 no longer support sending OPTIONS requests? I really like having this spec because it makes sure we handle the OPTIONS which is important for CORS |
@@ -566,8 +566,10 @@ func parseCreateOpts(c *cli.Context, runtime *libpod.Runtime, imageName string,
}
// WORKING DIRECTORY
- workDir := c.String("workdir")
- if workDir == "" {
+ workDir := "/"
+ if c.IsSet("workdir") {
+ workDir = c.String("workdir")
+ } else if data.ContainerConfig.WorkingDir != "" {
workD... | [NewContainer,InitLabels,GetContainerCreateOptions,Pull,IsContainer,GetLocalImageName,Port,StringSlice,GetImage,Close,DisableSecOpt,SplitProtoPort,StringInSlice,GetImageInspectInfo,RAMInBytes,GetFQName,WithShmSize,IsSet,WriteFile,Atoi,IsNotExist,ShmDir,Itoa,ParsePortRange,Error,Stat,ParsePortSpecs,Args,Marshal,IsHost,S... | finds the next unique identifier for the container and returns it. returns the unique identifier for the container. | It's OK/safe to default to "/" rather than leaving it blank and then throwing an error if we don't hit on any of the if's below? I think it's fine, but thought I'd throw it up there. |
@@ -3658,9 +3658,9 @@ describe InfoRequest do
context 'when there is a value stored in the database' do
it 'returns the date a response is very overdue after' do
- time_travel_to(Date.parse('2014-12-31')) do
+ time_travel_to(Time.zone.parse('2014-12-31')) do
expect(info_request.da... | [apply_filters->[request_list,map],create_old_unclassified_no_user->[awaiting_description,save,create],create_old_unclassified_holding_pen->[awaiting_description,save,create],create_old_unclassified_described->[create],create_old_unclassified_request->[awaiting_description,save,create],create_recent_unclassified_reques... | adds some tests to the system that expect the date a response is required by and the date missing date a response is required by. | Place the . on the previous line, together with the method call receiver. |
@@ -241,6 +241,9 @@ def save_inference_model(dirname,
"fetch_var_names": fetch_var_names
}, f, -1)
+ prepend_feed_ops(inference_program, feeded_var_names)
+ append_fetch_ops(inference_program, fetch_var_names)
+
# Save only programDesc of inference_program in binary format
# in a... | [get_parameter_value_by_name->[get_parameter_value],save_persistables->[save_vars],load_persistables_if_exist->[_is_presistable_and_exist_->[is_persistable],load_vars],load_vars->[_clone_var_in_block_,load_vars],load_inference_model->[load_persistables_if_exist],load_persistables->[load_vars],save_vars->[save_vars,_clo... | Save a model of a n - node model for inference. Writes the last unknown param to a file. | We can remove `Line 265 - 270` now, and change the implementation of `load_inference_model`. |
@@ -29,6 +29,7 @@ import io.netty.util.internal.PlatformDependent;
import java.io.IOException;
import java.util.Map;
+import static io.netty.channel.ChannelOption.*;
import static io.netty.channel.sctp.SctpChannelOption.*;
/**
| [DefaultSctpChannelConfig->[setMaxMessagesPerRead->[setMaxMessagesPerRead],getSendBufferSize->[getOption],getOptions->[getOptions],setAllocator->[setAllocator],setInitMaxStreams->[setOption],setWriteBufferLowWaterMark->[setWriteBufferLowWaterMark],getInitMaxStreams->[getOption],setConnectTimeoutMillis->[setConnectTimeo... | Creates a new instance of the DefaultSctpChannelConfig class for a given SCT Get the options for the channel. | What is this change about ? |
@@ -43,10 +43,12 @@ public class GoogleCloudStorageInputSource extends CloudObjectInputSource<Google
private static final int MAX_LISTING_LENGTH = 1024;
private final GoogleStorage storage;
+ private final GoogleAccountConfig config;
@JsonCreator
public GoogleCloudStorageInputSource(
@JacksonInj... | [GoogleCloudStorageInputSource->[withSplit->[GoogleCloudStorageInputSource]]] | Produces an InputSource for reading a list of objects from a Google Cloud Storage. Creates a new input source that splits this input source into two CloudStorage objects. | This variable is not used anymore. |
@@ -29,8 +29,12 @@ class PyPbr(PythonPackage):
"""PBR is a library that injects some useful and sensible default
behaviors into your setuptools run."""
homepage = "https://pypi.python.org/pypi/pbr"
- url = "https://pypi.python.org/packages/source/p/pbr/pbr-1.8.1.tar.gz"
+ url = "https:... | [PyPbr->[depends_on,version]] | PBR is a library that injects some useful and sensible default behaviors. | @tgamblin Can you look at this? How do we depend on `py-enum34` for only certain versions of Python? |
@@ -40,7 +40,7 @@ public class StreamPublisher<T> extends BufferedPublisher<T> {
end -= 1;
}
}
- if (responseLine.getByte(end) == (byte) ',') {
+ if (end > 0 && responseLine.getByte(end) == (byte) ',') {
end -= 1;
}
return responseLine.slice(start, end + 1);
| [StreamPublisher->[toJsonMsg->[slice,length,getByte],close->[close],closeHandler,endHandler,newDelimited,complete]] | This method extracts the JSON message from the given response line. | Another small bug. The prior couple of modifications may strip off the square brackets. If those are the only thing in the buffer, we're left with an empty string, and we were getting an out-of-bounds exception here. Simple enough to avoid checking if an empty buffer ends in a comma. |
@@ -57,7 +57,8 @@ setup(
'schema',
'PythonWebHDFS',
'colorama',
- 'sklearn'
+ 'sklearn',
+ 'pyyaml'
],
entry_points = {
| [read->[open],find_packages,setup,read] | Provides a list of entry points for the n - tuple module. | We have already required `ruamel.yaml`. Should not add another YAML library. |
@@ -496,6 +496,17 @@ HTML;
if ( ! empty( self::$ad_location_ids[ $location ] ) ) {
$loc_id = self::$ad_location_ids[ $location ];
}
+ if ( class_exists( 'Jetpack_AMP_Support' ) && Jetpack_AMP_Support::is_amp_request() ) {
+ $amp_section_id = self::get_amp_section_id();
+ $site_id = $this->params->blog_id... | [WordAds->[insert_adcode->[option],insert_header_ad_special->[option],should_bail->[option],insert_custom_adstxt->[option],insert_header_ad->[option],insert_ad->[option],get_ad->[option],insert_inline_ad->[option]]] | Returns a snippet that can be used to render an ADS. | We may want to consider extracting this into a separate `is_amp` function to include support for various versions of AMP solutions self-hosted sites might use. Unless we're firm on only supporting the Jetpack_AMP_Support version, then nevermind :) |
@@ -34,5 +34,6 @@ __all__ = [
'ServiceBusSender',
'ServiceBusSharedKeyCredential',
'TransportType',
- 'AutoLockRenew'
+ 'AutoLockRenew',
+ 'AutoComplete'
]
| [No CFG could be retrieved] | Get a list of all the services that are available to be sent to the bus. | I see it being quite likely that a customer would use these together. We should have samples/tests for that and see if there's any obvious ways to optimize for that experience. |
@@ -341,12 +341,14 @@ dfuse_cb_lookup(fuse_req_t req, struct dfuse_inode_entry *parent,
ie->ie_name[NAME_MAX] = '\0';
atomic_store_relaxed(&ie->ie_ref, 1);
- if (S_ISDIR(ie->ie_stat.st_mode)) {
+ if (S_ISFIFO(ie->ie_stat.st_mode)) {
rc = check_for_uns_ep(fs_handle, ie);
DFUSE_TRA_DEBUG(ie,
"check_for_u... | [No CFG could be retrieved] | - > 0 - > 0 - > 0 - > 0 - > 0 - > 0. | Does this need a sort of `backend_dfuse` check similar to `duns_create_path`? Or maybe I misunderstand this. |
@@ -298,10 +298,10 @@ public class KafkaLookupExtractorFactory implements LookupExtractorFactory
return !started.get();
}
started.set(false);
- executorService.shutdownNow();
+ executorService.shutdown();
final ListenableFuture<?> future = this.future;
if (future != null) ... | [KafkaLookupExtractorFactory->[getCompletedEventCount->[get],start->[getKafkaTopic,getKafkaProperties],get->[getCacheKey->[get],isInjective,get],replaces->[getKafkaTopic,getConnectTimeout,isInjective,getKafkaProperties],close->[getKafkaTopic]]] | Closes a if it is possible to close the Kafka broker. | Introduced a race? `future` could become done after `isDone()` and before `cancel()`. |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.