patch stringlengths 18 160k | callgraph stringlengths 4 179k | summary stringlengths 4 947 | msg stringlengths 6 3.42k |
|---|---|---|---|
@@ -86,7 +86,7 @@ public class ElasticsearchIOTest extends ESIntegTestCase implements Serializable
}
@Before
- public void setup() {
+ public void setup() throws IOException {
if (connectionConfiguration == null) {
connectionConfiguration =
ConnectionConfiguration.create(fillAddresses()... | [ElasticsearchIOTest->[testWriteWithIndexFn->[testWriteWithIndexFn],testSizes->[testSizes],testWriteWithMaxBatchSizeBytes->[testWriteWithMaxBatchSizeBytes],testDefaultRetryPredicate->[testDefaultRetryPredicate],setup->[fillAddresses],testWriteRetry->[testWriteRetry],testRead->[testRead],testReadWithMetadata->[testReadW... | Setup the connection configuration and elasticsearchIOTestCommon. | throw in unneeded, please remove it |
@@ -232,7 +232,8 @@ export function validateData(data, mandatoryFields, opt_optionalFields) {
allowedFields = allowedFields.concat(field);
} else {
userAssert(
- data[field],
+ // Allow zero values for height, width etc.
+ data[field] != null,
'Missing attribute for %s: ... | [No CFG could be retrieved] | Validate given data and add callbacks to the tasks array. Validates that the given data contains at least one of the fields in the given embed type. | Sounds like `false` value would be deemed invalid in the past. Strange that no one noticed. |
@@ -530,7 +530,7 @@ namespace Pulumi.Automation
/// <summary>
/// Gets the current set of Stack outputs from the last <see cref="UpAsync(UpOptions?, CancellationToken)"/>.
/// </summary>
- private async Task<ImmutableDictionary<string, OutputValue>> GetOutputAsync(CancellationToken can... | [WorkspaceStack->[GetConfigValueAsync->[GetConfigValueAsync],Dispose->[Dispose],GetConfigAsync->[GetConfigAsync],RefreshConfigAsync->[RefreshConfigAsync],InlineLanguageHost->[ValueTask->[Dispose],GetPortAsync->[Task]]]] | Asynchronously gets the output of the stack. | Do we want to keep the singular name `GetOutputAsync` or use plural `GetOutputsAsync`? Other APIs have `outputs` |
@@ -25,9 +25,10 @@ type noopConnection struct{}
func (*noopConnection) CreateStream(headers http.Header) (httpstream.Stream, error) {
return nil, nil
}
-func (*noopConnection) CloseChan() <-chan bool { return nil }
-func (*noopConnection) Close() error { return nil }
-func (*noopConnection) Se... | [Stop,Error,Contains,New,Start,Fatal,Errorf,Done] | CreateStream creates a stream with no timeout. | Should this method be included in this PR? |
@@ -1979,6 +1979,10 @@ class ModelAverage(Optimizer):
@signature_safe_contextmanager
def apply(self, executor, need_restore=True):
"""Apply average values to parameters of current model.
+
+ Args:
+ executor(fluid.Executor): current executor.
+ need_restore(bool): If you ... | [AdamaxOptimizer->[_append_optimize_op->[_get_accumulator,_create_param_lr],_finish_update->[_get_accumulator],_create_accumulators->[_add_accumulator]],MomentumOptimizer->[_append_optimize_op->[_get_accumulator,_create_param_lr],_create_accumulators->[_add_accumulator]],Optimizer->[apply_gradients->[_create_optimizati... | Apply average values to current model. | Please say the default value of `need_restore ` in this doc. |
@@ -10,8 +10,6 @@
* the source code distribution for details.
*/
-if (!$os) {
- if (strstr($sysObjectId, '1.3.6.1.4.1.2.3.51.3')) {
- $os = 'ibm-imm';
- }
+if (starts_with($sysObjectId, '.1.3.6.1.4.1.2.3.51.3')) {
+ $os = 'ibm-imm';
}
| [No CFG could be retrieved] | Replies the source code distribution for details. | Add this as an elseif rather than separate. |
@@ -80,12 +80,12 @@ func TestAuthBasic(t *testing.T) {
activateAuth(t)
defer deactivateAuth(t)
require.NoError(t, tu.BashCmd(`
- echo "{{.alice}}" | pachctl auth login
- pachctl create repo {{.repo}}
- pachctl list repo \
- | match {{.repo}}
- pachctl inspect repo {{.repo}}
- `,
+ echo "{{.alice}}" | pac... | [YesError,Unlock,Getenv,Now,Exit,Error,Format,New,Short,Lock,Skip,TrimSpace,Output,Contains,Matches,NoError,NewTestingBackOff,EncodeToString,NewReader,Sprintf,BashCmd,Cmd,GetTestEnterpriseCode,String,UniqueString,RetryEvery,Sleep,Run,Retry,Helper] | TestWhoAmI - test for the case where Pachyderm auth is TestCheckGetSet tests the individual components of the pach auth command. | I don't really object but why the extra spacing? Should we be doing this in general? |
@@ -117,7 +117,7 @@ function maybeAddConfigSubtype() {
}
/**
- * @param {string} type
+ * @param {string|null} type
* @param {string} action
* @return {Promise<void>}
*/
| [No CFG could be retrieved] | Infer test type from the passed in params. Reports a single to GitHub. | It is currently possible for this value to be null but maybe it shouldn't be? I think it would make sense to throw an error on line 81 to prevent that situation but I would rather keep functional changes out of this PR. |
@@ -176,7 +176,7 @@ namespace System.Reflection.Internal
{
try
{
- return (Encoding_GetString)getStringInfo.CreateDelegate(typeof(Encoding_GetString), null);
+ return getStringInfo.CreateDelegate<Encoding_GetString>(null);
... | [EncodingHelper->[GetStringPortable->[AcquireBuffer,GetString,ReleaseBuffer]]] | LoadGetStringPlatform - load a string from the platform. Determines if a string can be read from the system or null if it can t be read. | This will need to be reverted. |
@@ -315,11 +315,14 @@ namespace System.Windows.Forms
}
// Supported OS scenario.
- foreach (ParkingWindow p in _parkingWindows)
+ foreach (ParkingWindow? p in _parkingWindows)
{
- if (User32.AreDpiAwarenessContextsEqua... | [Application->[ThreadContext->[ExitCommon->[Dispose],ApartmentState->[GetState],OnAppThreadExit->[Dispose],GetMessageLoop->[GetMessageLoop],Terminate->[Dispose],OnThreadException->[Dispose,GetState],RunMessageLoopInner->[EndModalMessageLoop,Dispose,BeginModalMessageLoop],DisposeThreadWindows->[Dispose,DisposeParkingWin... | Returns a ParkingWindow for the given context. | `p == null` is an error condition and should not be ignored. |
@@ -25,7 +25,7 @@ class DependencyType(Enum):
# TODO(#8762) Get this rule to feature parity with the dependencies task.
class DependenciesOptions(LineOriented, GoalSubsystem):
- """Print the target's dependencies."""
+ """List the transitive dependencies of the input targets."""
name = "dependencies2"
... | [dependencies->[Addresses,get,FrozenOrderedSet,update,str,sorted,print_stdout,Dependencies,set,from_iterable,Targets,has_field,add,line_oriented],DependenciesOptions->[register_options->[register,super]]] | Register options for the command. | Not necessarily transitive. We default to `--no-transitive`. |
@@ -39,6 +39,7 @@ public class IntegrationHandlerResultHandler implements HandlerResultHandler, Or
@Override
public boolean supports(HandlerResult result) {
+ Assert.notNull(result, "'result' must not be null");
Object handler = result.getHandler();
return handler instanceof HandlerMethod
&& WebFluxIn... | [IntegrationHandlerResultHandler->[handleResult->[getReturnValue],supports->[isAssignableFrom,getBeanType,getHandler]]] | Checks if the given handler result supports the WebFluxInboundEndpoint interface. | I don't think we need this assert; Spring will never call this with a null result. |
@@ -611,7 +611,7 @@ Any pachctl command that can take a Commit ID, can take a branch name instead.`,
return errors.Errorf("cannot use provenance and triggers on the same branch")
}
if (trigger.CronSpec != "" || trigger.Size_ != "" || trigger.Commits != 0) &&
- trigger.Branch != "" {
+ trigger.Branch ... | [StringVar,Pull,PrintDetailedCommitInfo,TempFile,TempDir,SubscribeCommit,Acquire,HasPrefix,CreateRepo,DeleteCommit,UintVar,Walk,RunFixedArgs,Flush,New,CreateDocsAlias,NewPutFileClient,PrintDetailedBranchInfo,StartCommit,NewWriter,GetFile,MarkFlagCustom,Split,PutFile,Println,Stdin,AddFlagSet,Finish,IntVarP,SameFlag,Push... | Magic commands for the command line interface shell. RegisterCompletionFunc registers a command to delete a commit ID on a branch. | I discovered while writing docs that this cond was inverted. |
@@ -44,10 +44,10 @@ if (Auth::user()->hasGlobalAdmin()) {
<select class="form-control input-sm" id="device" name="device" onchange="getInterfaceList(this)">
<option value=''>Select a device</option>
<?php
- $... | [hasGlobalAdmin] | Displays a modal with the network network network network network network network network network network network network network Private function to render the nagios. | Please replace direct calls to the hostname element by format_hostname($device) |
@@ -334,12 +334,14 @@ int main(int argc, char *argv[])
// rank-1
RCP<MV> one = MVT::Clone(*S,1);
MVT::MvRandom(*one);
+ SerialDenseMatrix<int,ST> scaleS(sizeS, 1);
+ Anasazi::randomSDM(scaleS);
// put multiple of column 0 in columns 0:sizeS-1
for (int i=0; i<sizeS; i++) {
... | [No CFG could be retrieved] | missing - range multivector finds the non - zero non - zero non - zero non - zero non - zero. | I've seen this pattern above before; it might make sense to factor out into a separate test function. |
@@ -856,12 +856,8 @@ define([
var sceneOffset = byteOffset;
var binOffset = sceneOffset + sceneLength;
- // If sceneFormat isn't 0 (JSON) then we are using the CESIUM_binary_glTF extension
- // This means the last 2 integers of the header are jsonOffset & jsonLength
if (sceneF... | [No CFG could be retrieved] | Creates a model from a binary GLTF asset. This method provides a wrapper around the. gltf file which is the. glt. | We should probably improve this error, such as `CESIUM_binary_glTF is no longer supported, use KHR_binary_glTF instead.` |
@@ -99,6 +99,10 @@ public abstract class RestrictionTracker<RestrictionT, PositionT> {
*/
public abstract void checkDone() throws IllegalStateException;
+ public boolean isBounded() throws NotImplementedException {
+ throw new NotImplementedException("isBounded is not implemented.");
+ }
+
/**
* Al... | [RestrictionTracker->[Progress->[from->[IllegalArgumentException,format,AutoValue_RestrictionTracker_Progress]]]] | Check if the task is done. | If we want to make this optional, we should follow the `HasProgress` style and use an interface like `HasBoundedness` We could also make this a required method and update the changelog stating that this is a breaking change. This would remove the "default" inference on the `@UnboundedPerElement`/`@BoundedPerElement` an... |
@@ -349,6 +349,7 @@ type CloudProviderConfig struct {
CloudProviderRateLimitQPSWrite string `json:"cloudProviderRateLimitQPSWrite,omitempty"`
CloudProviderRateLimitBucket int `json:"cloudProviderRateLimitBucket,omitempty"`
CloudProviderRateLimitBucketWrite int `json:"cloudProviderRateLimitBucketWrit... | [GetCustomEnvironmentJSON->[IsAzureStackCloud],HasAvailabilityZones->[HasAvailabilityZones],GetUserAssignedID->[UserAssignedIDEnabled],HasImageGallery->[IsGalleryImage],GetSecondaryNonMasqueradeCIDR->[IsHostedMasterProfile],GetFirstConsecutiveStaticIPAddress->[IsVirtualMachineScaleSets],IsUbuntu->[IsUbuntu1804,IsUbuntu... | Username is the username of the user. | `Snat` instead of `SNAT` ? |
@@ -20,9 +20,11 @@ namespace System.Net.Quic
public IPEndPoint RemoteEndPoint => throw null;
public QuicStream OpenUnidirectionalStream() => throw null;
public QuicStream OpenBidirectionalStream() => throw null;
+ public long GetMaximumBidirectionalStreamCount() => throw null;
+ ... | [No CFG could be retrieved] | This method returns a stream that can be used to read and write values from the stream. | We'll want to tweak the names for these; each side has their own maximums, so something like remote vs local. Also, we need an event on the connection to get MAX_STREAMS updates. |
@@ -2157,8 +2157,8 @@ define([
var savedCamera = Camera.clone(camera, scene._cameraVR);
var near = camera.frustum.near;
- var fo = near * 5.0;
- var eyeSeparation = fo / 30.0;
+ var fo = near * defaultValue(scene.focalLength, 5.0);
+ var eyeSeparat... | [No CFG could be retrieved] | Initializes the framebuffer camera frustum and transforms. This function is called when the scene is in a non - pass state. It updates the. | Are you sure this should be done here and not at initialization like Cesium does everywhere else? Is it valid to set this back to `undefined`? |
@@ -128,11 +128,11 @@ public abstract class AbstractNonInvalidationTest extends SingleNodeTest {
awaitOrThrow(preFlushLatch);
}
s.flush();
- } catch (OptimisticLockException e) {
+ } catch (StaleStateException e) {
log.info("Exception thrown: ", e);... | [AbstractNonInvalidationTest->[startUp->[startUp],shutdown->[shutdown],assertSingleCacheEntry->[assertCacheContains],addSettings->[addSettings]]] | Remove flush wait. | please use `OptimisticLockException | StaleStateException e` |
@@ -59,8 +59,13 @@ public class WordCountIT {
/**
* Options for the WordCount Integration Test.
+ *
+ * Define expected output file checksum to verify WordCount pipeline result with customized input.
*/
public interface WordCountITOptions extends TestPipelineOptions, WordCountOptions {
+ @Default... | [WordCountIT->[WordCountOnSuccessMatcher->[readLines->[readLines]]]] | Example of how to test E2E word count. | missing <p> tag for second paragraph |
@@ -65,13 +65,14 @@ public class MergeTask extends MergeTaskBase
this.aggregators = Preconditions.checkNotNull(aggregators, "null aggregations");
this.rollup = rollup == null ? Boolean.TRUE : rollup;
this.indexSpec = indexSpec == null ? new IndexSpec() : indexSpec;
+ this.customIndexMerger = customInd... | [MergeTask->[merge->[apply->[loadIndex,propagate],toArray,size,transform,copyOf,mergeQueryableIndex,values,getIndexMergerV9],checkNotNull,IndexSpec]] | Merge the given segments into the given output directory. | What is the differences between loadSegment().asQueryableIndex() and just loadIndex()? I noticed there still exists plenty usage of loadIndex(), should they also be changed? |
@@ -59,6 +59,16 @@
}
}
+ function addOptionalBanner(query, displayBanner, jobsUrl) {
+ if (query) {
+ var lowerCaseQuery = query.toLowerCase();
+
+ if (displayBanner && lowerCaseQuery.includes("job")) {
+ document.getElementById("banner-section").innerHTML = '<div class="crayons-notice cr... | [No CFG could be retrieved] | function to search for hashtags in the query region Private functions. | Just curious about this function. Is this for our own internal job postings? Also, I'd remove the `if(query)` from this function and put it down below in the Promise's then since the job of this function is to display a banner, not check if it should before it does. |
@@ -33,7 +33,9 @@ class PartnerWelcomeScreen extends Component {
if (this.props.settings.referralCode) {
// We want to direct the user directly to dapp onboarding
const url = new URL(this.props.settings.network.dappUrl)
- url.hash = '/onboard'
+ url.hash =
+ '/onboard?referralCode=' ... | [No CFG could be retrieved] | Component that is used to show a welcome screen on the partner. Get the next n - th referral code from originprotocol. com. | This has been tested to work with hash router? `domain/path#hash?fakeParam=fakevar` is a non-standard URL and those aren't real GET params. |
@@ -151,10 +151,6 @@ class Jetpack_Gutenberg {
* @return bool
*/
public static function should_load_blocks() {
- if ( ! Jetpack::is_active() ) {
- return false;
- }
-
/**
* Filter to disable Gutenberg blocks
*
| [No CFG could be retrieved] | Check if Gutenberg blocks should be loaded. | This seems problematic though, since we now have blocks available even when Jetpack is not connected to WordPress.com. |
@@ -278,11 +278,11 @@ namespace DotNetNuke.Services.Installer.Installers
protected override void UnInstallFile(InstallFile scriptFile)
{
//Process the file if it is an UnInstall Script
- var extension = Path.GetExtension(scriptFile.Name.ToLower());
+ var extension = Path.GetE... | [ScriptInstaller->[ProcessFile->[ProcessFile,IsCorrectType],InstallScriptFile->[IsValidScript,ExecuteSql],Commit->[Commit],UnInstallFile->[IsValidScript,UnInstallFile,ExecuteSql],UnInstall->[UnInstall],Install->[InstallScriptFile],Rollback->[Rollback]]] | Override UnInstallFile to execute the script if it is an UnInstall script. | Please use `String#StartsWith(String, StringComparison)` |
@@ -29,6 +29,7 @@ import org.glassfish.grizzly.strategies.AbstractIOStrategy;
*/
public class ExecutorPerServerAddressIOStrategy extends AbstractIOStrategy
{
+ protected final static String UNAVAILABLE_ATTRIBUTE = "__reject_request__";
private final static EnumSet<IOEvent> WORKER_THREAD_EVENT_SET =
... | [ExecutorPerServerAddressIOStrategy->[WorkerThreadRunnable->[run->[run0]]]] | Package that imports CPAL resources and performs IO operations on a server. Replies if the given ioEvent is an . | You could use `org.glassfish.grizzly.attributes.Attribute<Boolean>` here, but up to you. |
@@ -119,8 +119,12 @@ public class MySQLPoolRecorder {
}
if (dataSourceReactiveMySQLConfig.cachePreparedStatements.isPresent()) {
+ log.warn("cache-prepared-statements is not specific to a database kind, configure it at the parent level");
mysqlConnectOptions.setCachePreparedS... | [MySQLPoolRecorder->[configureMySQLPool->[getValue,legacyInitialize,instance,addShutdownTask,initialize],legacyToPoolOptionsLegacy->[setMaxSize,PoolOptions],legacyInitialize->[pool,legacyToPoolOptionsLegacy,legacyToMySQLConnectOptions],toMySQLConnectOptions->[find,fromUri,configurePemKeyCertOptions,configurePfxKeyCertO... | toMySQLConnectOptions - converts DataSourceRuntimeConfig to MySQLConnectOptions. Present method to configure the mysql connection options. | If you include the key name in the message it's even more helpful. |
@@ -105,6 +105,17 @@ class AzfsResourceId implements ResourceId {
return GLOB_PREFIX.matcher(blob).matches();
}
+ String getBlobNonWildcardPrefix() {
+ Matcher m = GLOB_PREFIX.matcher(getBlob());
+ checkArgument(
+ m.matches(), String.format("Glob expression: [%s] is not expandable.", getBlob())... | [AzfsResourceId->[getCurrentDirectory->[fromComponents,isDirectory],equals->[equals],getFilename->[isDirectory],fromUri->[fromComponents],resolve->[equals,fromUri,isDirectory,fromComponents,toString],fromComponents->[AzfsResourceId]]] | Returns true if the resource is a wildcard resource. | is it possible to have `blob == null` and also `container == null` so that it's an account? |
@@ -47,9 +47,13 @@ class ShardedDatasetReader(DatasetReader):
"""
Just delegate to the base reader text_to_instance.
"""
- return self.reader.text_to_instance(*args, **kwargs) # type: ignore
+ return self.reader.text_to_instance(*args, **kwargs)
+
+ @overrides
+ def ensur... | [ShardedDatasetReader->[text_to_instance->[text_to_instance]]] | A function to read the text file and return an instance of the class. | Why remove the type annotation? |
@@ -689,9 +689,12 @@ InfoRepoDiscovery::add_subscription(DDS::DomainId_t domainId,
dr_remote_obj, qos, transInfo, subscriberQos,
filterClassName, filterExpr, params);
- ACE_GUARD_RETURN(ACE_Thread_Mutex, g, this->lock_, D... | [No CFG could be retrieved] | Adds a subscription to a given topic. Remove a subscription from the DDS. | I don't see why this change is needed. |
@@ -63,6 +63,7 @@ namespace Content.Server.Entry
_voteManager = IoCManager.Resolve<IVoteManager>();
IoCManager.Resolve<IChatManager>().Initialize();
+ IoCManager.Resolve<IChatSanitizationManager>().Initialize();
var playerManager = IoCManager.Resolve<IPlayerManager>... | [EntryPoint->[PostInit->[PostInit],Init->[Init],Update->[Update]]] | Initialize the system. | initialize before chatmanager IMO |
@@ -136,4 +136,13 @@ class Yoast_Dashboard_Widget {
private function filter_items( $item ) {
return 0 !== $item['count'];
}
+
+ /**
+ * Get the user ID
+ *
+ * @return integer
+ */
+ private function get_user_id() {
+ return get_current_user_id();
+ }
}
| [Yoast_Dashboard_Widget->[display_dashboard_widget->[statistic_items],statistic_items->[get_bad_seo_post_count,get_good_seo_post_count,get_no_index_post_count,get_ok_seo_post_count,get_poor_seo_post_count,get_no_focus_post_count]]] | Filter items. | Why adding wrapper for existing WordPress function? This method doesn't add anything new. |
@@ -1058,6 +1058,17 @@ public class PipelineOptionsFactory {
validateGettersHaveConsistentAnnotation(
methodNameToAllMethodMap, descriptors, AnnotationPredicates.DEFAULT_VALUE);
+ // Verify that there is no getter with a mixed @JsonDeserialize annotation.
+ validateGettersHaveConsistentAnnotation(... | [PipelineOptionsFactory->[ClassNameComparator->[ClassNameComparator],parseObjects->[getPropertyDescriptors],getRequiredGroupNamesToProperties->[create],as->[as],validateMethodAnnotations->[create],MethodToDeclaringClassFunction->[MethodToDeclaringClassFunction],register->[register],withValidation->[withValidation],desc... | Validate that the given methods have consistent annotations. | Does it make sense that if `@JsonDeserialize` is on the getter then we must also have `@JsonSerialize` and vice versa? |
@@ -41,6 +41,11 @@ register.function(dict)
register.function(utils.randslice)
+@register.function
+def switch_is_active(switch_name):
+ return waffle.switch_is_active(switch_name)
+
+
@register.filter
def link(item):
html = """<a href="%s">%s</a>""" % (item.get_url_path(),
| [timesince->[timesince],currencyfmt->[_get_format],breadcrumbs->[page_name],Paginator->[range->[range]],_site_nav->[sorted_cats],static->[cache_buster],impala_breadcrumbs->[page_name],media->[cache_buster],shuffle->[shuffle],page_title->[page_name],services_url->[url],numberfmt->[_get_format]] | Return link to the item with a name. | huh, weird we didn't have this already |
@@ -51,6 +51,9 @@ public class PropertiesStorage implements StorageComponent {
@Override
public synchronized void persist(String key, String value) {
+ if (!loadFromFile(_file)) {
+ s_logger.warn("Failed to load changes and then write to them");
+ }
_properties.setProperty(... | [PropertiesStorage->[persist->[error,flush,FileOutputStream,closeQuietly,setProperty,store,close],get->[getProperty],configure->[error,get,loadFromFile,findConfigFile,createNewFile,File,getAbsolutePath],getLogger,Properties]] | Persist a key - value pair to the properties file. | the loadFromFile allready logs errors on failures. is this warn really what we (all) want to do here? I'd expect a return or even a throw of some sort. |
@@ -42,6 +42,16 @@ class EnvValues(object):
ret = EnvValues()
if not text:
return ret
+ if isinstance(text, dict):
+ for k, v in text.items():
+ package = None
+ if ":" in k:
+ package, name = k.split(":", 1)
+ ... | [EnvValues->[loads->[load_value,EnvValues,unquote],copy->[EnvValues],dumps->[append_vars],update->[copy,add]],DepsEnvInfo->[loads->[EnvInfo,DepsEnvInfo,update],update_deps_env_info->[update],update->[merge_lists]],EnvInfo->[__setattr__->[_adjust_casing],__getattr__->[_adjust_casing]]] | Parse a string containing a . | Better create a ``from_dict()`` static method or something. |
@@ -77,7 +77,7 @@ class GroupsControllerCsvUploadTest < AuthenticatedControllerTest
context 'should be able to upload groups using CSV file upload, and repos' do
setup do
# We want to be repo admin
- MarkusConfigurator.stubs(:markus_config_repository_admin?).returns(true)
+ ... | [GroupsControllerCsvUploadTest->[new,cd,post_as,pwd,fixture_file_upload,join,should,map,teardown,assert_equal,repository_name,returns,glob,to_s,sort,touch,rm_r,make,id,length,context,chdir,mkdir,setup,assert_recognizes],include,dirname,join,require,expand_path] | upload non admin groups and repos using CSV file upload and admin group should be able to upload groups using CSV file upload and repos. | Line is too long. [95/80]<br>Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping. |
@@ -20,12 +20,9 @@ class MarksGradersController < ApplicationController
@grade_entry_form = GradeEntryForm.find(params[:grade_entry_form_id])
@section_column = ''
if Section.all.size > 0
- @section_column = "{
- id: 'section',
- content: '" + I18n.t(:'user.section') + "',
- sort... | [MarksGradersController->[global_actions->[nil?,render,find,size,t,assign_all_graders,unassign_graders,randomly_assign_graders],students_with_assoc->[includes],download_grader_students_mapping->[nil?,send_data,find,user_name,generate,grade_entry_form_id,each,id,push],csv_upload_grader_groups_mapping->[redirect_to,nil?,... | This action shows the missing node in the database. | Align the operands of an expression in an assignment spanning multiple lines. |
@@ -158,6 +158,7 @@ namespace System.Net
string hostString = host.Host;
+#pragma warning disable CA1416 // Validate platform compatibility, TODO: its need browser specific implementation
if (IPAddress.TryParse(hostString, out IPAddress? hostAddress))
{
return ... | [WebProxy->[IsMatchInBypassList->[UpdateRegexList],IsBypassed->[IsMatchInBypassList,IsLocal]]] | Checks if a URI is local or not. | Does anything from this assembly meaningfully work on browser? I'd have thought the whole assembly would be marked unsupported. |
@@ -111,6 +111,9 @@ public final class LifecycleAwareConfigurationInstance extends AbstractIntercept
@Inject
private ConfigurationProperties configurationProperties;
+ @Inject
+ private MuleContext muleContext;
+
private volatile Lock testConnectivityLock;
private volatile boolean initialized = false;... | [LifecycleAwareConfigurationInstance->[stop->[stop],initialise->[initialise],dispose->[dispose],start->[start],testConnectivity->[doWork->[testConnectivity]]]] | Provides a configuration instance that is lifecycle aware. | Where are we using this? |
@@ -218,4 +218,12 @@ export class Header extends React.Component<IHeaderProps, IHeaderState> {
}
}
-export default Header;
+const mapStateToProps = ({ applicationProfile }) => ({
+ ribbonEnv: applicationProfile.ribbonEnv,
+ isInProduction: applicationProfile.inProduction,
+ isSwaggerEnabled: applicationProfile... | [No CFG could be retrieved] | Header for a VObjectSequence. | If we are using connect here then we can fetch all the props passed down from app.tsx from redux state as well, else fetch the profile related props from the parent app.tsx and pass it down as props to the header so that header remains a dumb component. I would prefer the latter |
@@ -69,6 +69,16 @@ int ModApiClient::l_display_chat_message(lua_State *L)
return 1;
}
+// send_chat_message(message)
+int ModApiClient::l_send_chat_message(lua_State *L)
+{
+ if(!lua_isstring(L,1))
+ return 0;
+ std::string message = luaL_checkstring(L, 1);
+ getClient(L)->sendChatMessage(utf8_to_wide(message));
... | [l_get_last_run_mod->[lua_rawgeti,lua_pop,getScriptApiBase,lua_tostring,lua_pushstring],l_get_node_or_nil->[read_v3s16,getClient,lua_pushnil,pushnode],l_set_last_run_mod->[lua_pushboolean,lua_tostring,getScriptApiBase,lua_isstring],l_get_node->[read_v3s16,getClient,pushnode],l_get_current_modname->[lua_rawgeti],l_show_... | This function is called when a user enters a chat message. It is called by the. | `if (!lua_isstring(L, 1))` (spaces) |
@@ -21,6 +21,8 @@ import (
"fmt"
"time"
+ "github.com/elastic/beats/libbeat/common/kubernetes/metadata"
+
"github.com/gofrs/uuid"
v1 "k8s.io/api/core/v1"
k8s "k8s.io/client-go/kubernetes"
| [GenerateHints->[GenerateHints],Stop->[Stop],Start->[Start]] | NewNodeEventer creates a new eventer that can be used to publish and process events Creates an Eventer for the node. | nit: probably this import should be next to the other libbeat import blocks |
@@ -231,7 +231,7 @@ class PrefixDag(object):
class Node(object):
def __init__(self, dag, record):
- self.record = record
+ self.record = proxy(record)
self._constrains = tuple(MatchSpec(s).name for s in record.constrains)
self._depends = tuple(MatchSpec(s).name for s in record.de... | [Node->[all_ascendants->[_all_descendants],all_descendants->[_all_descendants]],PrefixDag->[remove_node_and_children->[remove_node_and_children,order_nodes_leaves_last],open_url->[format_url],remove_leaf_nodes_with_specs->[remove],prune->[remove_leaves_one_pass],remove->[remove],dot_repr->[get_nodes_ordered_from_roots]... | Initialize a node in the DAG. | This is the `proxy` use. Hopefully fixes the random segfault issue. |
@@ -958,11 +958,13 @@ void kill_screen(const char* lcd_msg) {
}
void _lcd_mesh_edit() {
+ lcdDrawUpdate = LCDVIEW_REDRAW_NOW;
_lcd_mesh_fine_tune(PSTR("Mesh Editor"));
}
float lcd_mesh_edit() {
lcd_goto_screen(_lcd_mesh_edit_NOP);
+ lcdDrawUpdate = LCDVIEW_REDRAW_NOW;
... | [No CFG could be retrieved] | Synchronize with the current screen. - - - - - - - - - - - - - - - - - -. | `lcd_goto_screen` sets `lcdDrawUpdate` to `LCDVIEW_REDRAW_NEXT`, which is then converted by the drawing loop to `LCDVIEW_REDRAW_NOW`, so this line should not be needed. Did you find that this line causes the behavior to change somehow? It should have zero effect. |
@@ -97,6 +97,9 @@ func New(beatVersion string, beatName string, esVersion string, config TemplateC
func (t *Template) load(fields common.Fields) (common.MapStr, error) {
+ dynamicTemplates = nil
+ defaultFields = nil
+
var err error
if len(t.config.AppendFields) > 0 {
cfgwarn.Experimental("append_fields is ... | [LoadFile->[load],Generate->[GetPattern],LoadBytes->[load]] | load loads the template from the given fields. | With this function being called each time that a client connects to Elasticsearch I would expect that this could lead to data races (especially if the number of workers is greater than 1). So because these are globals I think a mutex is required for reads and writes. |
@@ -47,7 +47,8 @@ shared_examples 'back image step' do |simulate|
attach_image
click_idv_continue
- expect(page).to have_current_path(idv_doc_auth_back_image_step) unless simulate
+ expect(page).to have_current_path(idv_doc_auth_front_image_step) unless simulate
+ expect(page).to have_con... | [it_behaves_like,to,include,have_content,create,before,feature,shared_examples,have_current_path,complete_doc_auth_steps_before_back_image_step,t,it,require,and_return] | adds features does not proceed to the next page with result = 2. | Do we need to also modify the tests for doc capture and the recover flows? |
@@ -7563,7 +7563,7 @@ Case0:
{
return res;
}
- if (JavascriptArray::Is(args[0]))
+ if (JavascriptArray::Is(args[0]) && !JavascriptArray::FromVar(args[0])->IsCrossSiteObject())
{
#if ENABLE_COPYONACCESS_ARRAY
JavascriptLibrary::CheckAndConvertCopyOnAcces... | [No CFG could be retrieved] | This is the main entry point for the array - handling of missing values. This function checks if the array is non - native and if so checks that it is not. | Looks like this is still present in this change? |
@@ -208,7 +208,7 @@ func NewAdmissionChains(
admissionPluginConfigFilename = tempFile.Name()
}
- admissionPluginNames := CombinedAdmissionControlPlugins
+ admissionPluginNames := openshiftAdmissionControlPlugins
admissionPluginNames = fixupAdmissionPlugins(admissionPluginNames)
admissionChain, err := newAd... | [TempFile,ValueOf,Close,Has,NewChainHandler,Validate,IsNil,ReadYAML,WriteYAML,NewString,NewBuffer,ReadAdmissionConfiguration,Name,Remove,Write,StringKeySet,List,Insert,ReadAll,NewFromPlugins] | newAdmissionChain returns a new admission chain that will be used to configure the admission plugin missing - plugin. | make an issue indicating that we need to fix this entire method and assign it to me. |
@@ -269,7 +269,7 @@ function _elgg_admin_init() {
elgg_register_simplecache_view('css/admin');
elgg_register_simplecache_view('js/admin');
$url = elgg_get_simplecache_url('js', 'admin');
- elgg_register_js('elgg.admin', $url);
+ elgg_register_js('elgg.upgrades', 'js/lib/upgrades.js');
elgg_register_js('jquery.j... | [_elgg_admin_markdown_page_handler->[getAvailableTextFiles,getName],_elgg_add_admin_widgets->[getGUID,move],_elgg_robots_page_handler->[getPrivateSetting],elgg_delete_admin_notice->[delete],_elgg_admin_sort_page_menu->[setChildren,getName,getChildren],_elgg_admin_maintenance_handler->[getPrivateSetting],_elgg_admin_plu... | Initialize the administration elgg_register_menu_item registers menu items register menu items register all widgets and events for admin. | Why are we no longer registering the admin js? |
@@ -201,7 +201,7 @@ PromiseResult VerifyPackagesPromise(EvalContext *ctx, const Promise *pp)
break;
case PACKAGE_PROMISE_TYPE_OLD:
Log(LOG_LEVEL_VERBOSE,
- "Using old package promise. Please note that this will be obsolete in 3.8");
+ "Using old package p... | [No CFG could be retrieved] | VerifyPackagesPromise - Checks if the given package has a non - old or new package promise Executes single package promise with single package promise attribute. | Very long line, should be split. Also, don't say that it will continue to work, say that it is deprecated and may be removed in a future version, since that is what we ultimately want to do, and we don't want to give people the impression it will be around forever. |
@@ -99,10 +99,7 @@ public final class ClientLoginValidator implements ILoginValidator {
if (hashedMac == null) {
return ErrorMessages.UNABLE_TO_OBTAIN_MAC;
- } else if (hashedMac.length() != 28
- || !hashedMac.startsWith(MD5Crypt.MAGIC + "MH$")
- || !hashedMac.matches("[0-9a-zA-Z$./]+")) ... | [ClientLoginValidator->[authenticate->[authenticate]]] | Verify connection. sleeps if a node is dead. | Looks like this change got blown away during merge resolution. It fixes an Error Prone warning (see #2417). |
@@ -388,10 +388,11 @@ class Notifier
$relay_list_stmt = DBA::p(
"SELECT
- `batch`,
- ANY_VALUE(`id`) AS `id`,
- ANY_VALUE(`name`) AS `name`,
- ANY_VALUE(`network`) AS `network`
+ `batch`,
+ ANY_VALUE(`id`) AS `id`,
+ ANY_VALUE(`name`) AS `name`,
+ ... | [Notifier->[execute->[getHostName]]] | Execute a delivery action on a target object. Select the first item that matches the given condition. This function is used to create a PuSH object. This function is used to determine if a node is a node that is a node that is This function is used to determine if a message should be delivered to the followup contact... | Why the change of indentation? Readability as the indented part is the "select" part of the query? |
@@ -577,4 +577,14 @@ public class TestMySqlTypeMapping
{
return dataType("double precision", DoubleType.DOUBLE, Object::toString);
}
+
+ private static DataType<byte[]> binaryDataType()
+ {
+ return dataType(
+ "varbinary(50)",
+ VARBINARY,
+ ... | [TestMySqlTypeMapping->[prestoCreateAsSelect->[prestoCreateAsSelect]]] | mysqlDoubleDataType - return double data type if any. | prefix the name with "mysql" |
@@ -1454,7 +1454,7 @@ main(int argc, char *argv[])
rc = daos_init();
if (rc != 0) {
- fprintf(stderr, "failed to initialize daos: %d\n", rc);
+ fprintf(stderr, "failed to initialize daos: " DF_RC "\n", DP_RC(rc));
return 1;
}
| [int->[cont_set_attr_hdlr,cont_get_acl_hdlr,uuid_generate,cont_del_attr_hdlr,daos_prop_free,ARGS_VERIFY_PATH_NON_CREATE,daos_str2csumcontprop,cont_op_parse,strcpy,pool_del_attr_hdlr,cont_create_uns_hdlr,cont_destroy_snap_hdlr,daos_rank_list_parse,uuid_parse,daos_obj_id_parse,pool_list_containers_hdlr,strnlen,ARGS_VERIF... | Main entry point for the DAOS command - line interface. Parse command line arguments and call resource - specific handler. | (style) line over 80 characters |
@@ -20,6 +20,9 @@ logger = logging.getLogger(__name__)
logger.debug('Included module rpc.telegram ...')
+MAX_TELEGRAM_MESSAGE = 4096
+
+
def authorized_only(command_handler: Callable[..., None]) -> Callable[..., Any]:
"""
Decorator to check if the message comes from the correct chat_id
| [authorized_only->[wrapper->[int,exception,command_handler,get,info]],Telegram->[_count->[debug,tabulate,str,_rpc_count,_send_msg,format,items],_stop->[_send_msg,_rpc_stop,format],_reload_conf->[_rpc_reload_conf,_send_msg,format],_stopbuy->[_send_msg,format,_rpc_stopbuy],_status->[_rpc_trade_status,append,_status_table... | Decorator to check if the message comes from the correct chat_id. | this can be confused by number of message. `MAX_MESSAGE_LENGTH` would be better. also maybe we want to include it in RPC as a cross messaging constant instead of here. |
@@ -107,6 +107,7 @@ func (m *Manager) Get(storeName, configName string) (*tls.Config, error) {
domainToCheck := types.CanonicalDomain(clientHello.ServerName)
if isACMETLS(clientHello) {
+ acmeTLSStore := m.getStore(tlsalpn01.ACMETLS1Protocol)
certificate := acmeTLSStore.GetBestCertificate(clientHello)
... | [UpdateConfigs->[Str,FromContext,Unlock,getStore,Lock,Errorf,GetLevel,GetTruncatedCertificateName,With,AppendCertificate,Set,Debugf],GetCertificates->[Get,ParseCertificate],GetStore->[RUnlock,getStore,RLock],getStore->[Background],Get->[GetBestCertificate,RLock,getStore,CanonicalDomain,Errorf,WithoutContext,RUnlock,Deb... | Get returns the TLS configuration for the given config name. If the config name is unknown it. | two things worry me, related to the fact that there's a mutex guarding m for the whole duration of Get. 1) if you're moving m.getStore into the GetCertificate closure, you're taking it out of the mutex protection, therefore potentially introducing a race. 2) (unrelated to your change) since the very first call to getSt... |
@@ -77,7 +77,7 @@ class Yoast_Social_Facebook {
}
}
- return json_encode(
+ return WPSEO_Util::json_encode(
array(
'success' => $success,
'html' => $response_body,
| [Yoast_Social_Facebook_Form->[show_user_admins->[get_admin_link],show_buttons->[add_button]],Yoast_Social_Facebook->[show_form->[show_form]]] | Add a new admin. | This should be `WPSEO_Utils` |
@@ -86,6 +86,7 @@ public class LoadQueuePeon
private final Object lock = new Object();
private volatile SegmentHolder currentlyProcessing = null;
+ private boolean stopped = false;
LoadQueuePeon(
CuratorFramework curator,
| [LoadQueuePeon->[entryRemoved->[actionCompleted,doNext],doNext->[run->[doNext]],stop->[executeCallbacks],actionCompleted->[run->[executeCallbacks]],failAssign->[actionCompleted,doNext],SegmentHolder->[toString->[toString]]]] | Provides a class which implements the LoadQueuePeon interface. getAndResetFailedAssignCount This method returns the number of failed assign segments and resets the. | should this be volatile? |
@@ -41,6 +41,17 @@ public class PlayerID extends NamedAttachable implements NamedUnitHolder {
m_technologyFrontiers = new TechnologyFrontierList(data);
}
+ @Override
+ public void setGameData(final GameData gameData) {
+ super.setGameData(gameData);
+
+ m_productionFrontier.setGameData(gameData);
+ ... | [PlayerID->[getTechAttachment->[getAttachment],getRulesAttachment->[getAttachment],getPlayerAttachment->[getAttachment],isAi->[equalsIgnoreCase],currentPlayers->[getPlayers,split,put,getName],toString->[getName],amNotDeadYet->[unitCanProduceUnits,unitCanMove,anyMatch,equals,getTerritories,unitIsLand,unitHasAttackValueO... | Get the optional flag. | This is an example of an overridden `setGameData()` method. Here, we flow down the `GameData` instance to all immediate child `GameDataComponent`s. |
@@ -343,6 +343,10 @@ define([
this.batchTable.setAllColor(color);
};
+ Batched3DModel3DTileContent.prototype.applyWireframe = function(enabled) {
+ this._model.debugWireframe = enabled;
+ };
+
/**
* Part of the {@link Cesium3DTileContent} interface.
*/
| [No CFG could be retrieved] | The main method of the Cesium3DTileContent class. Updates the model of the object with the new data. | Instead of adding this function to every content type, it would be shorter to model `debugWireframe` after how `shadows` are set in `Instanced3DModel3DTileContent` and `Batched3DModel3DTileContent`. It looks like you modeled it after `applyDebugSettings`. The reason that one is its own function is because it can be a q... |
@@ -135,7 +135,12 @@ const config = {
// Allow the use of the real filename of the module being executed. By
// default Webpack does not leak path-related information and provides a
// value that is a mock (/index.js).
- __filename: true
+ __filename: true,
+
+ // Emscrip... | [No CFG could be retrieved] | Provides a preset that can be used to compile a dependency list into a JSX file. Config for the module. | Can you please pass it only on the rnnoise bundle? |
@@ -84,6 +84,7 @@ describes.realWin('DoubleClick Fast Fetch Fluid', realWinConfig, env => {
multiSizeImpl.getLayout = getLayout;
multiSizeImpl.isLayoutSupported('fluid');
impl.experimentalNonAmpCreativeRenderMethod_ = 'safeframe';
+ multiSizeImpl.experimentalNonAmpCreativeRenderMethod_ = 'safeframe';
... | [No CFG could be retrieved] | Creates an AMP element that can be used to display a doubleclick . Checks that the layout is supported by the library. | Nit: I'd move line 86 to be immediately after line 83, to group the impls together and the multiSizeImpls together |
@@ -767,7 +767,7 @@ rebuild_destroy_container(void **state)
{
test_arg_t *arg = *state;
test_arg_t *args[2] = { 0 };
- daos_obj_id_t oids[OBJ_NR * 100];
+ daos_obj_id_t oids[OBJ_NR];
int i;
int rc;
| [run_daos_rebuild_test->[MPI_Barrier,run_daos_sub_tests,ARRAY_SIZE],rebuild_setup->[test_setup],void->[daos_obj_layout_get,daos_kill_server,rebuild_change_leader_cb,test_get_leader,rebuild_io_obj_internal,D_ASSERT,MPI_Barrier,test_teardown,rebuild_destroy_pool_internal,test_pool_get_info,dts_oid_gen,DP_OID,daos_add_ser... | rebuild_destroy_container rebuilds the object pool and all the pools ranks. | I'm OK to decrease the number of objects by default, but can we have an option to run larger object numbers? |
@@ -202,14 +202,14 @@ pool_get_prop_hdlr(struct cmd_args_s *ap)
rc = daos_pool_query(ap->pool, NULL, NULL, prop_query, NULL);
if (rc != 0) {
- fprintf(stderr, "failed to query properties for pool "DF_UUIDF
+ fprintf(ap->errstream, "failed to query properties for pool "DF_UUIDF
": %s (%d)\n", DP_UUID(ap->p_u... | [No CFG could be retrieved] | - DAOS_PROP_NOT_FOUND - DAOS_PROP_NOT The function to connect to the DAO pool and connect to the DAO pool. | (style) line over 80 characters |
@@ -21,7 +21,7 @@ package org.apache.zeppelin.interpreter;
*
*/
public class InterpreterOption {
- boolean remote;
+// boolean remote;
boolean perNoteSession;
boolean perNoteProcess;
| [No CFG could be retrieved] | Construct a new object that represents an object that represents a single . This is the only property that is set if the user is per - note - process or. | I think it's better keep this field for a while (with mark @deprecated or something) Without this field exist with 'true' value assigned, when previous version of Zeppelin read notebook created from newer version, previous version of Zeppelin will assume remote = 'false' and some interpreters will not work. (e.g. spark... |
@@ -81,14 +81,12 @@ foreach (dbFetchRows($sql, $param) as $interface) {
$speed = humanspeed($interface['ifSpeed']);
$type = humanmedia($interface['ifType']);
- if ($_POST['search_type'] == 'ipv6') {
- list($prefix, $length) = explode('/', $interface['ipv6_network']);
- $address ... | [No CFG could be retrieved] | Get the number of network interfaces that can be used to create a network network. Get the array of the nation objects for a given node. | Think this is muddled up. Two checks for mac and no ipv4_network now. |
@@ -491,7 +491,7 @@ namespace Dynamo.Models
internal static OpenFileCommand DeserializeCore(XmlElement element)
{
XmlElementHelper helper = new XmlElementHelper(element);
- string xmlFilePath = TryFindFile(helper.ReadString("XmlFilePath"), element.OwnerDocument.... | [DynamoModel->[CreateAnnotationCommand->[SerializeCore->[SerializeCore]],AddModelToGroupCommand->[SerializeCore->[SerializeCore]],DeleteModelCommand->[SerializeCore->[SerializeCore]],MakeConnectionCommand->[SerializeCore->[SerializeCore],setProperties],UpdateModelValueCommand->[SerializeCore->[SerializeCore]],ApplyPres... | Deserialize a Core. | hmm, a little worried here, won't this stop old xml files from loading correctly as they have a "XmlFilePath" attribute? |
@@ -147,3 +147,9 @@ class Povray(AutotoolsPackage):
extra_args.append('--without-x')
return extra_args
+
+ def test(self):
+ povs = find(self.prefix.share, 'biscuit.pov')[0]
+ copy(povs, '.')
+ self.run_test('povray', options=['biscuit.pov'])
+ copy('biscuit.png', '..'... | [Povray->[configure_args->[append,getuser,enable_or_disable,getfqdn,format],run_prebuild_script->[join_path,which,prebuild_script],depends_on,conflicts,run_before,version,patch,variant]] | Configure the command line arguments for the object. Returns a list of extra arguments to pass to the sdl2 command. | What is the purpose of this line? How does it contribute to the smoke test? |
@@ -35,7 +35,7 @@ uint64_t daos_fail_value;
uint64_t daos_fail_num;
void
-daos_reset_fail_loc()
+daos_fail_loc_reset()
{
daos_fail_loc_set(0);
D_DEBUG(DB_ANY, "*** fail_loc="DF_X64"\n", daos_fail_loc);
| [daos_fail_check->[DAOS_FAIL_GROUP_GET,d_should_fail,d_fault_attr_lookup,D_DEBUG],daos_fail_init->[d_fault_inject_fini,d_fault_attr_set,d_fault_inject_init],daos_fail_loc_set->[DAOS_FAIL_GROUP_GET,d_fault_attr_set,D_ASSERT,D_DEBUG],daos_reset_fail_loc->[D_DEBUG,daos_fail_loc_set],daos_fail_fini->[d_fault_inject_fini]] | if fail_loc is set to 0 reset fail_loc to 0. | (void) parameter list? I guess it's not required since you have it in the prototype |
@@ -400,9 +400,10 @@ class CauchyTest(test.TestCase):
def testCauchyNegativeLocFails(self):
with self.cached_session():
- cauchy = cauchy_lib.Cauchy(loc=[1.], scale=[-5.], validate_args=True)
- with self.assertRaisesOpError("Condition x > 0 did not hold"):
- cauchy.mode().eval()
+ with s... | [CauchyTest->[testParamStaticShapes->[_testParamStaticShapes],testParamShapes->[_testParamShapes],testFiniteGradientAtDifficultPoints->[assertAllFinite]],try_import] | Test cauchy negative locFails. | Unused variable 'cauchy' [unused-variable] |
@@ -87,9 +87,9 @@ class ServiceBusMixin(object):
dead_lettering_on_message_expiration=dead_lettering_on_message_expiration,
duplicate_detection_history_time_window=duplicate_detection_history_time_window,
max_delivery_count=max_delivery_count,
- enable_batched_operation... | [BaseClient->[get_properties->[_get_entity]],ServiceBusMixin->[create_queue->[create_queue],create_subscription->[create_subscription],delete_subscription->[delete_subscription],delete_queue->[delete_queue],delete_topic->[delete_topic],create_topic->[create_topic]],SenderMixin->[queue_message->[queue_message]]] | Creates a new queue entity based on the given configuration. Creates a queue with the given name and properties. Check if queue exists in service namespace. | This probably merits a docstring as well, at the risk of nitpicking :) (Broadly PR looks fine, if I'm really playing the overkill game we could also validate that this flag gets plumbed properly in a unit test.) |
@@ -544,8 +544,9 @@ function $RouteProvider() {
* @name $route#$routeUpdate
* @eventType broadcast on root scope
* @description
- * The `reloadOnSearch` property has been set to false, and we are reusing the same
- * instance of the Controller.
+ * Any of the `reloadOnSearch` and `reloadOn... | [No CFG could be retrieved] | Component which broadcasts on a controller and view when a route changes. The reload event is called when the user changes the state of the object. | I would change this to something like `This event is fired if we are reusing the same instance ... because any of ... |
@@ -23,12 +23,11 @@ const styles = StyleSheet.create({
const WalletXpub = () => {
const { wallets } = useContext(BlueStorageContext);
- const { walletID } = useRoute().params;
+ const { walletID, xPub } = useRoute().params;
const wallet = wallets.find(w => w.getID() === walletID);
const [isLoading, setIsL... | [No CFG could be retrieved] | Imports a component with a specific state. This is a function that can be called when the user enters a block that has been. | bad idea to have untypical casing. its `xpub` across the app, or, worst case, `Xpub`. this might bite you in the ass later |
@@ -163,12 +163,18 @@ export class ConsentUI {
/** @private {boolean} */
this.enableBorder_ = DEFAULT_ENABLE_BORDER;
+ /** @private {boolean} */
+ this.lightboxEnabled_ = false;
+
/** @private {boolean} */
this.isActionPromptTrigger_ = false;
/** @private @const {!Function} */
th... | [No CFG could be retrieved] | Initializes the object. Checks if a child element of the prompt element is a child of the parent element of the. | 1. You're mixing naming styles (`enableBorder_` and `lightboxEnabled_`), make them consistent. 2. Explain what `lightbox` means here. The term `lightbox` is already overloaded in our codebase (`amp-lightbox` vs. `amp-lightbox-gallery`), which might make it confusing. Consider using `modal` instead. |
@@ -1845,7 +1845,8 @@ class Parser:
elif isinstance(tok, Indent) or isinstance(tok, Dedent):
msg = 'Inconsistent indentation'
else:
- msg = 'Parse error before {}'.format(token_repr(tok))
+ reason = " due to: {}".format(reason) if reason else ""
+ msg = 'P... | [parse->[parse],Parser->[skip_until_break->[current,skip],skip_until_next_line->[current,skip,skip_until_break],eol->[current],parse_type_comment->[parse_error_at],parse_try_stmt->[parse_block],parse_tuple_expr->[parse_expression],parse_decorated_function_or_class->[parse_class_def],parse_conditional_expr->[parse_expre... | Parse error at the given token. | I'd remove "due to" here. I think the ":" alone corresponds a bit better to standard error messaging. |
@@ -199,7 +199,8 @@ del CT_orig
# - Load the two scans from the command line using
# ``freeview $MISC_PATH/seeg/sample_seeg/mri/T1.mgz
# $MISC_PATH/seeg/sample_seeg_CT.mgz``
-# - Navigate to the upper toolbar, go to ``Tools>>Transform Volume...``
+# - Navigate to the upper... | [plot_overlay->[imshow,subplots,suptitle,tight_layout,invert_yaxis,axis,apply_orientation,enumerate,quantile,take],plot_overlay,text,add_sensors,tight_layout,asarray,apply_trans,show_view,join,read_raw,set_montage,figs,resample,dict,warp_montage_volume,annotate,apply_volume_registration,estimate_head_mri_t,project_sens... | This function takes a period of 10 minutes and runs it on the system. The data object of the given object is resampled to the hyperintense sk. | why only this one? There is a `Tools -> transform volume` above as well as `Freeview -> Preferences -> General -> Cursor style -> Long` (again, both in the "aligning to ACPC" section) |
@@ -205,6 +205,11 @@ func (prometheusCodec) DecodeRequest(_ context.Context, r *http.Request) (Reques
result.Query = r.FormValue("query")
result.Path = r.URL.Path
+
+ if r.Header.Get(cachecontrolHeader) == noCacheValue {
+ result.NoCache = true
+ }
+
return &result, nil
}
| [Less->[minTime],UnmarshalJSON->[FromMetricsToLabelAdapters,Unmarshal],MarshalJSON->[Marshal,FromLabelAdaptersToMetric],DecodeRequest->[ParseTime,FormValue],EncodeRequest->[WithContext,Encode,String,Errorf],DecodeResponse->[Error,Finish,Int,New,Unmarshal,Errorf,LogFields,ReadAll],EncodeResponse->[StartSpanFromContext,N... | DecodeRequest decodes a request from the HTTP client. u is the url of the request that the client is expecting to reply to. | Even if a bad practice, the request may contain multiple `Cache-Control` values including `no-store`. To make it more robust, I would check `strings.Contains(r.Header.Get(cachecontrolHeader), noCacheValue)`. Also, would you mind renaming `noCacheValue` to `noStoreValue`? Because `Cache-Control` also supports `no-cache`... |
@@ -161,8 +161,13 @@ def test_generalization_across_time():
# Test start stop training & test cv without n_fold params
y_4classes = np.hstack((epochs.events[:7, 2], epochs.events[7:, 2] + 1))
- gat = GeneralizationAcrossTime(cv=LeaveOneLabelOut(y_4classes),
- train_times... | [test_decoding_time->[make_epochs,predict],test_generalization_across_time->[make_epochs,SVC_proba]] | Test time generalization across time. missing - 1 - 1 - 1 - 1 - 1 - 1 - 1 - 1 - Missing key - value pairs. Test for the case where the scores are not equal to the epochs and the test times are Score a single node in the model with a sequence of epochs. | I would just use `check_version` everywhere |
@@ -783,6 +783,7 @@ ActiveRecord::Schema.define(version: 2021_01_25_085442) do
t.string "email"
t.string "github_username"
t.datetime "last_article_at", default: "2017-01-01 05:00:00"
+ t.datetime "latest_article_updated_at"
t.string "location"
t.string "name"
t.string "nav_image"
| [jsonb,bigint,string,text,citext,add_foreign_key,datetime,integer,enable_extension,create_table,float,boolean,index,define,inet] | Table for all the organizations and the users XML Schema Abstraction. | This is just reordered, probably due to the recent switch from fix-db-schema-conflicts to strong-migrations. |
@@ -11,6 +11,7 @@ import (
"code.gitea.io/gitea/modules/setting"
)
+// TemplatePreview render only on DEV mode for preview the template
func TemplatePreview(ctx *context.Context) {
ctx.Data["User"] = models.User{Name: "Unknown"}
ctx.Data["AppName"] = setting.AppName
| [TplName,HTML,Params] | TemplatePreview renders a template preview of a given language. | This function always renders if asked, `RUN_MODE` is checked elsewhere |
@@ -2,16 +2,12 @@ package aws
import (
"context"
- "fmt"
"github.com/aws/aws-sdk-go/aws"
"github.com/aws/aws-sdk-go/aws/awserr"
- "github.com/aws/aws-sdk-go/service/applicationautoscaling"
- "github.com/aws/aws-sdk-go/service/applicationautoscaling/applicationautoscalingiface"
"github.com/aws/aws-sdk-go/se... | [ListTables->[backoffAndRetry],DescribeTable->[backoffAndRetry],CreateTable->[backoffAndRetry],enableAutoScaling->[backoffAndRetry],disableAutoScaling->[backoffAndRetry],UpdateTable->[backoffAndRetry]] | Package that imports a single and registers it with the prometheus. dynamoTableClient creates a new DynamoDb table client from the given URL. | This is really `PostCreateTable`, right? |
@@ -127,9 +127,9 @@ class RuleWatchGraph
*
* The rule node's watched literals are updated accordingly.
*
- * @param $fromLiteral mixed A literal the node used to watch
- * @param $toLiteral mixed A literal the node should watch now
- * @param $node mixed The rule node to be moved
+ * @... | [RuleWatchGraph->[propagateLiteral->[next,getLiterals,getOtherWatch,current,valid,isDisabled,conflict,getRule,rewind,moveWatch,satisfy,decide],insert->[isAssertion,unshift],moveWatch->[remove,moveWatch,unshift]]] | Move a watch from one literal to another. | literals of the solver are integers |
@@ -52,6 +52,9 @@ public final class OmKeyInfo extends WithMetadata {
private HddsProtos.ReplicationType type;
private HddsProtos.ReplicationFactor factor;
private FileEncryptionInfo encInfo;
+ private long objectID;
+ private long updateID;
+
/**
* ACL Information.
*/
| [OmKeyInfo->[removeAcl->[removeAcl],Builder->[build->[OmKeyInfo]],copyObject->[addOmKeyLocationInfoGroup,setFileEncryptionInfo,addMetadata,getType,build,addAcl],getProtobuf->[setFileEncryptionInfo,build],getFromProtobuf->[build],equals->[equals],appendNewBlocks->[appendNewBlocks],updateLocationInfoList->[getLatestVersi... | This class is used to create an object from an object in the OOM protocol. in - progress check for the version of the key location info group. | Is 0 an invalid object ID and update id? |
@@ -432,14 +432,9 @@ class BaseZincCompile(JvmCompile):
"execution".format(dep)
)
- if scala_path:
- # TODO: ScalaPlatform._tool_classpath should capture this and memoize it.
- # See https://github.com/pantsbuild/pants/issues/6435
- snapshots.append(
- se... | [BaseZincCompile->[write_extra_resources->[_write_scalac_plugin_info,_write_javac_plugin_info],_maybe_get_plugin_name->[process_info_file],__init__->[validate_arguments],compile->[javac_classpath,relative_to_exec_root,_get_zinc_arguments,scalac_classpath],_verify_zinc_classpath->[is_outside],validate_arguments->[valida... | Compile a Zinc compiler. Add arguments to zinc to run a . Returns a list of all options that can be passed to the zinc command. Executes the Zinc command. Returns a directory entry for the given node in the Zinc distribution. | Drop the if here? `extend` on an empty list is a no-op, which is fine :) |
@@ -79,10 +79,10 @@ function display_init(App $a)
// Is it an item with uid=0?
if (!DBA::isResult($item)) {
- $item = Item::selectFirstForUser(local_user(), $fields, ['guid' => $a->argv[1], 'private' => [0, 2], 'uid' => 0]);
+ $item = Item::selectFirst($fields, ['guid' => $a->argv[1], 'private' => [0, 2], '... | [display_content->[removeBaseURL]] | Display the user s private feed and the item that is not private This function is called when the user is a user and the user is a private item. loading profile with default profile. | Why this change? The "selectFirstForUser" respects possibly hidden public content for the given user. |
@@ -105,10 +105,13 @@ static void *get_method_from_store(OPENSSL_CTX *libctx, void *store,
*/
if ((name_id = methdata->name_id) == 0) {
OSSL_NAMEMAP *namemap = ossl_namemap_stored(libctx);
+ const char *names = methdata->names;
+ const char *q = strchr(names, NAME_SEPARATOR);
+ ... | [evp_generic_do_all->[ossl_algorithm_do_all],evp_generic_fetch->[inner_generic_fetch],int->[method_id,ossl_namemap_name2num,ossl_namemap_stored,ossl_method_store_add,get_default_method_store],uint32_t->[ossl_assert],EVP_set_default_properties->[ossl_method_store_set_global_properties,EVPerr,get_default_method_store],OS... | This method tries to find a method in the store that matches the given parameters. | maybe use the same notation as above l = (q == NULL ? ...); |
@@ -89,10 +89,13 @@ class SettingOverrideDecorator(SceneNodeDecorator):
def isNonPrintingMesh(self):
return self._is_non_printing_mesh
+ def evaluateIsNonPrintingMesh(self):
+ return any(bool(self._stack.getProperty(setting, "value")) for setting in self._non_printing_mesh_settings)
+
def... | [SettingOverrideDecorator->[__deepcopy__->[SettingOverrideDecorator],setActiveExtruder->[_updateNextStack],getActiveExtruderPosition->[getActiveExtruder]]] | Check if the node is a non - printing mesh. | This is quite interesting, it works fine for general settings. But if you set setting per model setting, I expect cura starts slicing. Can you check it? |
@@ -61,12 +61,12 @@ func resourceAwsCodeArtifactRepository() *schema.Resource {
},
"external_connections": {
Type: schema.TypeList,
- Computed: true,
+ Optional: true,
Elem: &schema.Resource{
Schema: map[string]*schema.Schema{
"external_connection_name": {
Type: sche... | [Printf,StringValue,GetOk,HasChange,Print,TrimPrefix,UpdateRepository,String,Errorf,Id,DeleteRepository,SetId,Get,Parse,Split,Set,DescribeRepository,CreateRepository] | Update - Updates a CodeArtifact Repository with the given parameters. EC2 API returns a CodeArtifactRepositoryInput for creating a CodeArtifact. | Is a change from `Computed` to `Optional` a breaking change? If users had configured external connections outside Terraform they will now be removed unless configured in the Terraform code. I think a change to `Computed` and `Optional` will solve this. |
@@ -86,6 +86,8 @@ class TestBidirectionalLanguageModel(TestUnidirectionalLanguageModel):
self.expected_embedding_shape = (2, 8, 14)
self.bidirectional = True
+ self.result_keys = {"loss", "forward_loss", "backward_loss", "lm_embeddings",
+ "noncontextual_token_embed... | [TestBidirectionalLanguageModel->[setUp->[set_up_model,super]],TestBidirectionalLanguageModelUnsampled->[setUp->[set_up_model,super]],TestUnidirectionalLanguageModel->[test_forward_pass_runs_correctly->[tuple,result,set,as_tensor_dict,model,assert_almost_equal],test_mismatching_contextualizer_unidirectionality_throws_c... | Set up the object attributes for the missing node. | `self.result_keys.add("backward_loss")` might call attention to the difference a bit better, but this is fine too. |
@@ -203,6 +203,10 @@ define([
var vertexFormat = cylinderGeometry._vertexFormat;
var slices = cylinderGeometry._slices;
+ if ((length <= 0) || ((topRadius <= 0) && (bottomRadius <= 0))) {
+ return;
+ }
+
var twoSlices = slices + slices;
var threeSlices = sl... | [No CFG could be retrieved] | Creates a geometry that represents the geometric representation of a cylinder including its vertices indices and region Cesium functions. | Small logic error here. We want to throw if both top and bottom radius is zero, or if either top or bottom radius is less than zero. Right now the cylinder will render if topRadius = -10, bottomRadius = 10 |
@@ -324,6 +324,11 @@ namespace Microsoft.Xna.Framework.Graphics
}
}
+ /// <summary>
+ /// Blend factor for alpha blending.
+ /// </summary>
+ public Color BlendFactor { get { return _blendFactor; } set { _blendFactor = value; } }
+
public BlendState BlendStat... | [GraphicsDevice->[SetRenderTarget->[SetRenderTarget],DrawUserPrimitives->[DrawUserPrimitives],DrawIndexedPrimitives->[DrawIndexedPrimitives],ApplyRenderTargets->[Clear],Dispose->[Clear,Dispose],SetIndexBuffer,Initialize]] | Sets the color state of the color system. Get the actual blend state object. | This won't work. You can change the blend factor here yet the blend state won't reapply until `_blendStateDirty` is set to true. |
@@ -186,7 +186,7 @@ type TaskRunResults []TaskRunResult
// FinalResult pulls the FinalResult for the pipeline_run from the task runs
// It needs to respect the output index of each task
-func (trrs TaskRunResults) FinalResult() FinalResult {
+func (trrs TaskRunResults) FinalResult(l logger.Logger) FinalResult {
v... | [Scan->[UnmarshalJSON],Value->[MarshalJSON],FinalResult->[IsTerminal]] | FinalResult returns the final result of the task run. | This one is a little unusual, but it keeps things clean. |
@@ -54,6 +54,7 @@ import {GOOGLEADWORDS_CONFIG} from './vendors/googleadwords';
import {GOOGLEANALYTICS_CONFIG} from './vendors/googleanalytics';
import {GTAG_CONFIG} from './vendors/gtag';
import {IBEATANALYTICS_CONFIG} from './vendors/ibeatanalytics';
+import {INFONLINE_ANONYMOUS_CONFIG} from './vendors/infonline_... | [No CFG could be retrieved] | Imports a sequence of configuration objects. Imports all configuration objects from the package. | We recent refactored this file, you no longer need to make any change to this file : ) |
@@ -19,8 +19,8 @@ package org.apache.gobblin.source.extractor.extract.kafka;
import java.nio.charset.Charset;
import java.nio.charset.StandardCharsets;
-import java.util.Map;
+import org.apache.gobblin.kafka.serialize.GsonDeserializerBase;
import org.apache.kafka.common.serialization.Deserializer;
import com.... | [KafkaGsonDeserializer->[deserialize->[fromJson,String],Gson]] | Produces a new instance of a Kafka that deserializes its data into a JsonElement. | Import order. Gobblin should be after com. |
@@ -201,6 +201,15 @@ func (r *registrations) sendLog(log types.Log, orm ORM, latestHead *models.Head,
continue
}
+ if len(metadata.filters) > 0 && len(log.Topics) > 1 {
+ logger.Tracew("LogBroadcaster: Checking filters")
+ topicValues := log.Topics[1:]
+ if !filtersContainValues(topicValues, metadata.fi... | [sendLog->[IsV2Job,Done,IsInChain,Add,Errorw,JobIDV2,HandleLog,CopyLog,Wait,ParseLog,JobID],removeSubscriber->[Address,resetHighestNumConfirmations,Topic],addSubscriber->[Address,maybeIncreaseHighestNumConfirmations,Topic],sendLogs->[sendLog],IsInChain,Sprintf,ChainLength,Debugw,ChainHashes] | sendLog sends a log to all listeners that have received it. broadcasts all events to all jobs. | As in your previous PR I would definitely suggest not logging every log that comes in (could explode in production or make debugging very difficult) |
@@ -149,6 +149,11 @@ func createBridge(name string, options entities.NetworkCreateOptions, runtimeCon
ipMasq = false
}
+ mtu, err := parseMTU(options.Options["mtu"])
+ if err != nil {
+ return "", err
+ }
+
// obtain host bridge name
bridgeDeviceName, err := GetFreeDeviceName(runtimeConfig)
if err != nil ... | [Wrapf,Join,IsRootless,WriteFile,Current,Sprintf,Contains,releaseCNILock,MarshalIndent,String,Errorf,StringInSlice,MkdirAll] | Determines if the network is used or IPv6 flag is used. Add plugin to the list of plugins that should be installed if the container is rootless and. | We should be parsing all options and return and error for unknown ones. `podman network create -o bogus` should not work. |
@@ -91,6 +91,18 @@ float tone_qwerty[][2] = SONG(QWERTY_SOUND);
bool process_record_user(uint16_t keycode, keyrecord_t *record) {
switch (keycode) {
+ case QWERTY:
+ if (record->event.pressed) {
+ set_single_persistent_default_layer(_QWERTY);
+ }
+ return false;
+ break;
+ cas... | [No CFG could be retrieved] | PRIVATE METHODS - DEPRECATED check if a record has an . | `break` after `return` is dead code. If you want a keycode handled here to continue being processed by QMK (for example for One-Shot stuff), you should either `break` or `return true` in each `case`. Otherwise, just the `return false` will do. |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.