patch stringlengths 18 160k | callgraph stringlengths 4 179k | summary stringlengths 4 947 | msg stringlengths 6 3.42k |
|---|---|---|---|
@@ -158,7 +158,7 @@ func (s *memorySeries) head() *desc {
return s.chunkDescs[len(s.chunkDescs)-1]
}
-func (s *memorySeries) samplesForRange(from, through model.Time) ([]model.SamplePair, error) {
+func (s *memorySeries) samplesForRange(from, through model.Time, deletedInterval []model.Interval) ([]model.SamplePai... | [isStale->[IsStaleNaN],add->[Equal,head,New,Now,Errorf,add,Inc,Add],slice->[Slice],setChunks->[Errorf],samplesForRange->[RangeValues,Before,NewIterator,After,Search],Value,Now,NewIterator,NewCounter,Scan,MustRegister,Err] | head returns the first chunk in the series that starts after from and after through. | Why do we have any changes in the ingester? As far as I understand, the tombstones are loaded in the querier only. |
@@ -188,13 +188,13 @@ class ElggMenuBuilder {
switch ($sort_by) {
case 'text':
- $sort_callback = array('ElggMenuBuilder', 'compareByText');
+ $sort_callback = array('\ElggMenuBuilder', 'compareByText');
break;
case 'name':
- $sort_callback = array('ElggMenuBuilder', 'compareByName');
+ $s... | [ElggMenuBuilder->[getMenu->[sort,setupTrees,findSelected,setupSections,selectFromContext],sort->[getChildren,sortChildren,setData],setupTrees->[addChild,getName,getData,setParent,getParentName],compareByText->[getText,getData],compareByPriority->[getPriority,getData],compareByWeight->[getPriority,getData],findSelected... | Sort the menu. | It's not obvious that this still works. I am pretty sure it does, but not 100% confident. Needs tests... |
@@ -64,6 +64,7 @@ abstract class AbstractEventContext implements BaseEventContext {
private transient final FlowExceptionHandler exceptionHandler;
private transient final CompletableFuture<Void> externalCompletion;
private transient List<BiConsumer<CoreEvent, Throwable>> onResponseConsumerList = new ArrayList<... | [AbstractEventContext->[onComplete->[signalConsumerSilently],getResponsePublisher->[isTerminated],onResponse->[signalConsumerSilently],error->[success],signalConsumerSilently->[error],tryComplete->[tryComplete],detailedToString->[basicToString],forEachChild->[forEachChild],ResponsePublisher->[accept->[success,error,onR... | Creates a base class for all events in a sequence of child contexts. | declare this list before `onResponseConsumerList` |
@@ -102,6 +102,13 @@ class ConsoleIO extends BaseIO
return sprintf('[%.1fMB/%.2fs] %s', $memoryUsage, $timeSpent, $message);
}, (array) $messages);
}
+
+ if (true === $stderr && $this->output instanceof ConsoleOutputInterface) {
+ $this->output->getErrorOutput()-... | [ConsoleIO->[askAndHideAnswer->[write,ask],isDecorated->[isDecorated],write->[write],askAndValidate->[askAndValidate],ask->[ask],askConfirmation->[askConfirmation],isInteractive->[isInteractive],overwrite->[write,isDecorated]]] | Writes a message to the output stream. | Why are you taking this shortcut here @alcohol? It prevents self-updating progress, for instance, with `composer install 2>&1 | somepipethatdecoratesoutput`; you get many newlines instead (331425b and #3818 are symptoms of that). Is there a particular reason why you don't want any overwriting behavior when piping? IMO ... |
@@ -131,11 +131,18 @@ public class IPythonClient {
@Override
public void onError(Throwable throwable) {
try {
+ interpreterOutput.getInterpreterOutput().write(ExceptionUtils.getStackTrace(throwable));
interpreterOutput.getInterpreterOutput().flush();
} catch (IOExcept... | [IPythonClient->[stop->[stop],main->[IPythonClient,status,block_execute],status->[status],complete->[complete],cancel->[cancel]]] | Streaming execute. Called when the stream_execute is completed. | that's great! just tested and glad to see errors are now getting its way to the fronted, without making spark interpreter appear "hanging". |
@@ -31,7 +31,15 @@ BuildStrategy = core.ParallelExecutor.BuildStrategy
class ParallelExecutor(object):
"""
- ParallelExecutor can run program in parallel.
+ ParallelExecutor is designed for data parallelism, which focuses on distributing
+ the data across different nodes and every node operates on the ... | [ParallelExecutor->[run->[run],__init__->[ParallelExecutor]]] | Creates a new object. ParallelExecutor of the n - node training and n - node test runs. | Should add all args docs for parallel executor python api |
@@ -583,8 +583,7 @@ namespace System.IO.Compression
Debug.Assert((archiveComment == null) || (archiveComment.Length <= ZipFileCommentMaxLength));
writer.Write(archiveComment != null ? (ushort)archiveComment.Length : (ushort)0); // zip file comment length
- if (archiveComment != nu... | [Zip64ExtraField->[],ZipGenericExtraField->[WriteAllBlocks->[WriteBlock],ParseExtraField->[TryReadBlock]],ZipCentralDirectoryFileHeader->[TryReadBlock->[ParseExtraField]],ZipLocalFileHeader->[GetExtraFields->[RemoveZip64Blocks,ParseExtraField]]] | Write a block of data from the specified stream. Reads the header of the Central Directory with respect to the starting disk number. | Why not keep the check to avoid call write when is not needed? |
@@ -195,9 +195,14 @@ router.post('/', (req, res) => {
process.env.TWITTER_ORIGINPROTOCOL_USERNAME.toLowerCase()
) {
followCount++
- const key = `twitter/follow/${event.source.screen_name}`
- redisBatch.set(key, JSON.stringify(event), 'EX', 60 * 30)
- logger.debug(`Pushing t... | [No CFG could be retrieved] | POST a single Pushes a single to the Redis batch. | Do you know what is the max number of events Twitter may send at once ? Not awaiting will cause as many DB connections to get created so that could potentially overload the DB if it is a very large number (like thousands). Could be safer to process in batches of X events on our side to control. |
@@ -167,7 +167,7 @@ class User < ActiveRecord::Base
def get_large_avatar_image(provider, image_url)
url = case provider
when 'twitter' then image_url.sub('_normal', '')
- when 'facebook' then "#{image_url}?type=large"
+ when 'facebook' then "#{image_url.sub("http://", "https://")}?... | [User->[hide_checkin_comment?->[hide_checkin_comment?]]] | get large avatar image. | Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.<br>Prefer single-quoted strings inside interpolations. |
@@ -1,11 +1,13 @@
<?php
-
/**
* Layout content filter
*
- * @uses $vars['filter'] An optional array of filter tabs
- * Array items should be suitable for usage with
- * elgg_register_menu_item()
+ * @uses $vars['filter'] - false or '' for no filt... | [No CFG could be retrieved] | Content filter of a page. | This broke my filters. In BC filters, it was possible to set the custom filter view. In 3.x logic, a string was meant to signify the filter type, which was then used as the handle for the filter menu hook. |
@@ -34,10 +34,14 @@ namespace System.Threading
// Threadpool specific initialization of a new thread. Used by OS-provided threadpools. No-op for portable threadpool.
internal static void InitializeForThreadPoolThread() { }
+#pragma warning disable IDE0060
internal static bool CanSetMinIOCom... | [ThreadPool->[GetMaxThreads->[GetMaxThreads],GetOrCreateThreadLocalCompletionCountObject->[GetOrCreateThreadLocalCompletionCountObject],NotifyWorkItemComplete->[NotifyWorkItemComplete],SetMinThreads->[SetMinThreads],GetMinThreads->[GetMinThreads],SetMaxThreads->[SetMaxThreads],NotifyThreadBlocked->[NotifyThreadBlocked]... | InitializeForThreadPoolThread static method. | Some of the similar cases are partial methods. Is there are reason why these are `Conditional("unnecessary")` and not partial methods? |
@@ -314,8 +314,14 @@ public class GobblinMetrics {
return;
}
+ // Add a suffix to file name if specified in properties.
+ String metricsFileSuffix = properties.getProperty(ConfigurationKeys.METRICS_FILE_SUFFIX, "");
+ if(!Strings.isNullOrEmpty(metricsFileSuffix) && !metricsFileSuffix.st... | [GobblinMetrics->[get->[GobblinMetrics,get],remove->[remove],buildFileMetricReporter->[getName,get]]] | This method builds the file metric reporter. | Since you check `ifNullOrEmpty` on `metricsFileSuffix`, there's no need to provide a default of empty string here. |
@@ -64,11 +64,11 @@ import org.jboss.msc.service.ServiceName;
*/
public enum ThreadPoolResource implements ResourceDefinition, ThreadPoolDefinition {
- ASYNC_OPERATIONS("async-operations", 25, 25, 1000, 60000),
- LISTENER("listener", 1, 1, 100000, 60000),
- REMOTE_COMMAND("remote-command", 25, 25, 100000,... | [pathElement->[pathElement],getPathElement->[pathElement]] | Get the path element for the thread - pool with the given name. | Huh, I thought this would be much harder :) Please move this to a separate commit `ISPN-10040 Embedded and server thread pool defaults should be the same` |
@@ -4383,9 +4383,12 @@ def hsigmoid(input,
is not set, the bias is initialized zero. Default: None.
name (str|None): A name for this layer(optional). If set None, the layer
will be named automatically. Default: None.
+ is_costum: (bool|False)using user defined binary tree ins... | [ctc_greedy_decoder->[topk],image_resize->[_is_list_or_turple_],sequence_first_step->[sequence_pool],logical_xor->[_logical_op],elementwise_pow->[_elementwise_op],elementwise_min->[_elementwise_op],elementwise_max->[_elementwise_op],logical_not->[_logical_op],conv2d->[_get_default_param_initializer],logical_and->[_logi... | Hierarchical Sigmoid operator. Hierarchical sigmoid layer where the last node in the network is missing. | if set, the gradient of xx and xx will be sparse. |
@@ -262,14 +262,14 @@ class Repository:
if 'repository' not in self.config.sections() or self.config.getint('repository', 'version') != 1:
self.close()
raise self.InvalidRepository(path)
- self.max_segment_size = self.config.getint('repository', 'max_segment_size')
+ sel... | [Repository->[prepare_txn->[prepare_txn,open,open_index,check_transaction],_update_index->[CheckNeeded],get_transaction_id->[get_index_transaction_id,check_transaction],get->[ObjectNotFound,get_transaction_id,open_index],check_transaction->[CheckNeeded,get_index_transaction_id],close->[close],write_index->[open],__cont... | Open a log file. | here, you read 'max_segment_size' from the config - which works for current configs, but won't work for configs created by line 171, which would have 'peripheral_segment_size'. So, this has misc. problems: - it does not work - names are less consistent now than before - "peripheral_segment_size" is not really a better ... |
@@ -116,6 +116,8 @@ type Comment struct {
Assignee *User `xorm:"-"`
OldTitle string
NewTitle string
+ OldBranch string
+ NewBranch string
DependentIssueID int64
DependentIssue *Issue `xorm:"-"`
| [CheckInvalidation->[checkInvalidation],CodeCommentURL->[HashTag,LoadIssue,HTMLURL],IssueURL->[LoadIssue,HTMLURL],LoadReactions->[loadReactions],APIFormat->[IssueURL,HTMLURL,PRURL,APIFormat],LoadReview->[loadReview],PRURL->[LoadIssue,HTMLURL],MustAsDiff->[AsDiff],HTMLURL->[LoadIssue,HTMLURL],UnsignedLine,loadReview,API... | CommentTypeAddDependency - Add a line of code of code of code of code of ReviewID is invoked from XORM after the object is deleted. | The length default is `VARCHAR(255)`. Is this enough for git branch name? |
@@ -1306,8 +1306,7 @@ function admin_page_users(&$a){
$sql_order = "`".str_replace('.','`.`',$order)."`";
$sql_order_direction = ($order_direction==="+")?"ASC":"DESC";
- $users = q("SELECT `user`.*, `contact`.`name`, `contact`.`url`, `contact`.`micro`, `user`.`account_expired`,
- (SELECT MAX(`changed`) FROM `i... | [admin_page_logs->[get_baseurl],admin_page_summary->[get_baseurl],admin_page_dbsync->[get_baseurl],admin_page_plugins->[get_baseurl],admin_page_users_post->[get_baseurl],admin_page_site_post->[get_baseurl,set_baseurl,get_path],admin_page_themes->[get_baseurl],admin_page_site->[get_baseurl,get_hostname,get_path],admin_p... | admin_page_users - admin page users a. pager = a. pager ; a. pager_itemspage = 100 ; This function is used to extract all the user data from the admin list. This function renders the administration administration page. | [standards] Please fix SQL query indentation (two tabs instead of one expected) |
@@ -208,7 +208,12 @@ public class StatefulDoFnRunner<InputT, OutputT, W extends BoundedWindow>
// make sure this fires after any window.maxTimestamp() timers
gcTime = gcTime.plus(GC_DELAY_MS);
timerInternals.setTimer(
- StateNamespaces.window(windowCoder, window), GC_TIMER_ID, gcTime, Time... | [StatefulDoFnRunner->[processElement->[processElement],startBundle->[startBundle],finishBundle->[finishBundle],getFn->[getFn],onTimer->[onTimer,isLate],TimeInternalsCleanupTimer->[currentInputWatermarkTime->[currentInputWatermarkTime]]]] | Sets the timer for the given window. | default namespace to empty string |
@@ -218,12 +218,8 @@ class Vtk(CMakePackage):
])
else:
prefix = spec['opengl'].prefix
-
opengl_include_dir = prefix.include
- opengl_library = os.path.join(prefix.lib, 'libGL.so')
- if 'darwin' in spec.architecture:
- opengl_include_di... | [Vtk->[url_for_version->[up_to,format],setup_environment->[set],cmake_args->[satisfies,append,Version,spec,extend,format,join],depends_on,extends,conflicts,version,patch,variant]] | Returns a list of arguments for the Cake CLI. Add flags to cmake_args to allow missing cmake options. Add optional arguments to the CMake command line. Adds flags to the list of arguments to use for the n - ary c ++ compiler. | This needs to be using the `gl` virtual package instead of `opengl`. `opengl` is a dummy package intended to let the system-provided OpenGL drivers to be be used. `gl` is a virtual package provided by both `mesa` and `opengl` and is what downstream packages should be depending on. |
@@ -211,6 +211,18 @@ public enum ClientSetting implements GameSetting {
}
}
+ private static Preferences getPreferences() {
+ return Optional.ofNullable(preferencesRef.get())
+ .orElseThrow(() -> new IllegalStateException("ClientSetting framework has not been initialized. "
+ + "Did you ... | [saveAndFlush->[save,flush],resetAndFlush->[saveAndFlush],flush->[flush]] | Flush all the settings. | this is a cleanup of method on line 180, and also moved it to be below its first line of usage. |
@@ -64,12 +64,14 @@ class RawBrainVision(_BaseRaw):
@verbose
def __init__(self, vhdr_fname, montage=None,
eog=('HEOGL', 'HEOGR', 'VEOGb'), misc=(),
- scale=1., preload=False, response_trig_shift=0, verbose=None):
+ scale=1., preload=False, response_trig_shift=... | [read_raw_brainvision->[RawBrainVision],_get_vhdr_info->[_read_vmrk_events]] | Initialize a raw BrainVision object from a file. | we try to avoid mutable defaults so let's go with `None` here. Or is there a difference between `dict()` and `None`? |
@@ -124,7 +124,7 @@ public class MergeOnReadRollbackActionExecutor extends BaseRollbackActionExecuto
case HoodieTimeline.COMMIT_ACTION:
LOG.info("Rolling back commit action. There are higher delta commits. So only rolling back this instant");
partitionRollbackRequests.add(
- ... | [MergeOnReadRollbackActionExecutor->[generateAppendRollbackBlocksAction->[toMap,equals,checkArgument,toList,collect],generateRollbackRequests->[getBasePath,max,size,getTimestamp,min,getRollbackParallelism,getFs,getAllPartitionPaths,collect,shouldAssumeDatePartitioning],executeRollback->[error,generateRollbackRequests,i... | Generates rollback requests for the given instant. This method is called when a delta commit is being rolled back. It is called by the This method is used to determine if a base parquet file has been deleted. | there is no rollback plan that gets serialized etc.. so this should be fine |
@@ -153,8 +153,12 @@ public class SiteToSiteBulletinReportingTask extends AbstractSiteToSiteReporting
attributes.put("reporting.task.type", this.getClass().getSimpleName());
attributes.put("mime.type", "application/json");
- final byte[] data = jsonArray.toString().getBytes(Standa... | [SiteToSiteBulletinReportingTask->[getSupportedPropertyDescriptors->[getSupportedPropertyDescriptors]]] | On trigger. Send the current batch of Bulletins to destination nodes. | The first one you did also has a customValidate method, can we put that logic into the base class (not necessarily in the exact customValidate() method but something all of these can call)? If we add the property to the base class, then it could be in the base class's customValidate(), your call :) |
@@ -64,10 +64,12 @@ typedef struct {
static const struct option OPTIONS[] =
{
+ {"address", required_argument, 0, 'a'},
{"debug", no_argument, 0, 'd'},
{"file", required_argument, 0, 'f'},
{"help", no_argument, 0, 'h'},
{"inform", no_argument, 0, 'I'},
+ ... | [void->[CFTestD_TLSSessionEstablish],bool->[CFTestD_GetServerQuery],CFTestD_CheckOpts->[CFTestD_ConfigInit,CFTestD_Help],main->[CFTestD_CheckOpts,CFTestD_ConfigDestroy,CFTestD_StartServer]] | This function is used to add a new policy to a server. Print basic information about what cf - testd does. | why are address and port required? They weren't before. |
@@ -593,6 +593,11 @@ def _download_url(resp, link, content_file):
break
yield chunk
+ def written_chunks(chunks):
+ for chunk in chunks:
+ content_file.write(chunk)
+ yield chunk
+
progress_indicator = _progress_indicator
if link.netloc... | [get_file_content->[get],PipSession->[__init__->[MultiDomainBasicAuth,SafeFileCache,InsecureHTTPAdapter,LocalFSAdapter,user_agent]],_download_url->[resp_read,_check_hash],_check_download_dir->[_get_hash_from_file,_check_hash],PipXmlrpcTransport->[__init__->[__init__]],_download_http_url->[_download_url,get],is_vcs_url-... | Download a file from a URL. Yields a from the download_hash and content_file. | The naming of this is a bit weird, this function isn't written chunks, it's something that writes (and yields) chunks. |
@@ -468,8 +468,16 @@ class VertxWebProcessor {
.setModifiers(ACC_PRIVATE | ACC_FINAL);
}
- implementConstructor(bean, invokerCreator, beanField, contextField, containerField);
- implementInvoke(desc, bean, method, invokerCreator, beanField, contextField, containerField, tra... | [VertxWebProcessor->[ParameterInjector->[toString->[toString],Builder->[matchType->[matchType],skipType->[skipType],build->[ParameterInjector]]]]] | Generate a handler. implementConstructor implementInvoke and implementConstructor. | The field is accessed from another class (a callback). Made it public final after discussion with @mkouba |
@@ -137,8 +137,9 @@ namespace System.Text.RegularExpressions.Tests
private int GetCachedItemsNum()
{
- return (int)typeof(Regex)
- .GetField("s_cacheCount", BindingFlags.NonPublic | BindingFlags.Static)
+ return (int)typeof(Regex).Assembly
+ .GetTy... | [RegexCacheTests->[GetCachedItemsNum->[GetValue],Ctor_Cache_Shrink_cache->[Dispose],Ctor_Cache_Second_drops_first->[Dispose],Ctor_Cache_Promote_entries->[Dispose],Ctor_Cache_Uses_culture_and_options->[Dispose],CacheSize_Set->[CacheSize,Equal],CacheSize_Set_NegativeValue_ThrowsArgumentOutOfRangeException->[AssertExtensi... | Get the number of items that are cached in the cache. | Why add `BindingFlags.Public`? The field is still private. |
@@ -417,10 +417,12 @@ namespace System.Net.Quic.Implementations.MsQuic
internal override void AbortRead(long errorCode)
{
ThrowIfDisposed();
+ Debug.Assert(errorCode != 0);
lock (_state)
{
_state.ReadState = ReadState.Aborted;
+ ... | [MsQuicStream->[Shutdown->[StartShutdown],Dispose->[Dispose],CleanupSendState->[Dispose],ValueTask->[StartShutdown,CleanupSendState,HandleWriteFailedState],Dispose]] | Abort read. | What's wrong with 0? How do we know the user app doesn't use 0 as something relevant? |
@@ -100,7 +100,12 @@ frappe.msgprint = function(msg, title) {
if(data.message instanceof Array) {
data.message.forEach(function(m) {
- frappe.msgprint(m);
+ const msg = {
+ message: m,
+ indicator: data.indicator,
+ title: data.title
+ }
+ frappe.msgprint(msg);
});
return;
}
| [No CFG could be retrieved] | function to show dialog with message and message Show a message dialog. | this was already handled in `frappe.msgprint` which is called recursively @gshmu please check manually before you send such contributions! |
@@ -202,7 +202,7 @@ class SMACTuner(Tuner):
converted_dict[key] = np.exp(challenger_dict[key])
# convert categorical back to original value
elif key in self.categorical_dict:
- idx = challenger_dict[key]
+ idx = int(challenger_dict[key])
... | [SMACTuner->[generate_multiple_parameters->[convert_loguniform_categorical],generate_parameters->[convert_loguniform_categorical],update_search_space->[_main_cli]]] | Convert the values of type loguniform back to their initial range Also convert categorical values back. | why challenger_dict[key] is not int? |
@@ -164,7 +164,7 @@ class Build(build):
class Develop(develop):
def finalize_options(self):
- self.user = True # always use `develop --user`
+ self.user = False # always use `develop --user`
super().finalize_options()
def run(self):
| [Build->[run->[islink,super,isfile]],Clean->[run->[_clean_temp_files,super,clean,rmtree],finalize_options->[super]],Develop->[run->[build,super],finalize_options->[super]],_find_python_packages->[append,replace,walk,sorted],BuildTs->[run->[build]],_clean_temp_files->[isfile,glob,islink,remove,rmtree],_find_node_files->... | Set up options for the command. | I suggest to explicitly check conda/venv/virtualenv. Pip will not fallback to `--user` when python directory is protected, and the error message will not hint to do so either. If you don't want to do the check anyway, just remove this function. Forcing to `False` will make it impossible to install as normal user withou... |
@@ -301,7 +301,14 @@ public abstract class AbstractOSGiLaunchDelegate extends JavaLaunchDelegate {
StringBuilder builder = new StringBuilder();
Collection<String> runVM = getProjectLauncher().getRunVM();
for (Iterator<String> iter = runVM.iterator(); iter.hasNext();) {
- builder.append(iter.next());
+ Stri... | [AbstractOSGiLaunchDelegate->[launch->[getProjectLauncher,launch],getClasspath->[getClasspath],getMainTypeName->[getMainTypeName],getVMInstall->[getVMInstall],finalLaunchCheck->[getLauncherStatus],getClasspathAndModulepath->[getClasspath,getClasspathAndModulepath],buildForLaunch->[getRunMode,initialiseBndLauncher,build... | Get the arguments for the VM. | Would it be simpler to quote the entire string? And wouldn't it be safe to do this for all args? And wouldn't it be better to use single quotes rather than double (in case there are any cases in the quoted string that will start getting interpolated)? And if we quote with a single quote, we should also escape any singl... |
@@ -25,8 +25,8 @@
package jenkins.telemetry.impl.java11;
import com.google.common.annotations.VisibleForTesting;
-
import edu.umd.cs.findbugs.annotations.NonNull;
+
import java.util.Arrays;
import java.util.Collections;
import java.util.List;
| [MissingClassEvents->[put->[getOccurrences,unmodifiableList,MissingClassEvent,size,incrementAndGet,setOccurrences,getStackTrace,setTime,get,AtomicLong,set,compute,asList,clientDateString]]] | This class is used to provide a list of missing class events. Stores a new exception in the store. | Please avoid diff hunks unrelated to a fix. |
@@ -30,10 +30,10 @@ type DeviceStatus struct {
type Device struct {
ID keybase1.DeviceID `json:"id"`
- Type string `json:"type"`
Kid keybase1.KID `json:"kid,omitempty"`
- Description *string `json:"description,omitempty"`
+ Description *string `json:"na... | [Merge->[Exists],Export->[NewWrapper],DeviceIDFromSlice,Sprintf,UnmarshalAgain] | NewDeviceID imports a new key device from a JSON object. Export returns a JSON representation of the device. | Can we change the Go variable to be `Name` also? |
@@ -187,6 +187,13 @@ public class KsqlConfig extends AbstractConfig {
public static final Collection<CompatibilityBreakingConfigDef> COMPATIBLY_BREAKING_CONFIG_DEFS
= ImmutableList.of();
+ public static final String KSQL_SHUTDOWN_TIMEOUT_MS_CONFIG =
+ "ksql.streams.shutdown.timeout.ms";
+ public stat... | [KsqlConfig->[buildConfigDef->[defineLegacy,defineCurrent],ConfigValue->[isResolved->[isResolved]],buildStreamingConfig->[applyStreamsConfig],getAllConfigPropsWithSecretsObfuscated->[getKsqlConfigPropsWithSecretsObfuscated],overrideBreakingConfigsWithOriginalValues->[KsqlConfig],cloneWithPropertyOverwrite->[KsqlConfig,... | Config to enable or disable transient pull queries on a specific KSQL cluster. This validator is used to validate a single config definition. | I thought to go with a more conservative default of 5 minutes made sense, to make sure everything has time to shut down properly. Let me know if another value is preferred. |
@@ -18,7 +18,7 @@ class TestCase extends Illuminate\Foundation\Testing\TestCase
{
$app = require __DIR__.'/../bootstrap/app.php';
- $app->make(Illuminate\Contracts\Console\Kernel::class)->bootstrap();
+ $app->make(\Illuminate\Contracts\Console\Kernel::class)->bootstrap();
return... | [TestCase->[createApplication->[bootstrap]]] | Create application. | You could also import `\Illuminate\Contracts\Console\Kernel` |
@@ -477,6 +477,12 @@ public class TestPipeline extends Pipeline implements TestRule {
}
}
+ public PipelineRunner toPipelineRunner() {
+ PipelineOptions updatedOptions =
+ MAPPER.convertValue(MAPPER.valueToTree(options), PipelineOptions.class);
+ return PipelineRunner.fromOptions(updatedOptions)... | [TestPipeline->[newProvider->[getProviderRuntimeValues],testingPipelineOptions->[create],enableAutoRunIfMissing->[enableAutoRunIfMissing],PipelineAbandonedNodeEnforcement->[verifyPipelineExecution->[isEmptyPipeline,recordPipelineNodes],afterPipelineExecution->[afterPipelineExecution,recordPipelineNodes],recordPipelineN... | Converts the given pipeline options into a command line options that can be used to run a pipeline Returns an array of strings that can be used to generate a new list of strings. | This method feels very out of place. I would instead simply ignore the provided pipeline in your testRunPTransform and create a new one from scratch. |
@@ -390,7 +390,7 @@ class Notify
$outputlangs->setDefaultLang($obj->default_lang);
}
- $subject = '['.$mysoc->name.'] '.$outputlangs->transnoentitiesnoconv("DolibarrNotification");
+ $subject = '['.$mysoc->name.']['.$proj->title.'] '.$outputlangs->transnoentitiesnoconv("DolibarrNotification")... | [Notify->[send->[getFullName,fetch,query,transnoentitiesnoconv,transnoentities,executeHooks,setDefaultLang,sendfile,num_rows,fetch_object,initHooks,escape,lasterror,idate,load],confirmMessage->[trans,getNotificationsArray,load],getNotificationsArray->[fetch,query,num_rows,fetch_object,lasterror]]] | send a notification to the user This method is used to check if a contact has a notification or not. Notification couple defined products - related emission of the contact description of function This function is called to generate a notification message. | If object is not linked to a project, proj->title is not defined, even $proj is not defined |
@@ -134,6 +134,17 @@ RSpec.describe BookmarkManager do
expect(result[:topic_bookmarked]).to eq(true)
end
+ context "if the bookmark is the last one bookmarked in the topic" do
+ before do
+ TopicUser.create(user: user, topic: bookmark.post.topic, bookmarked: true)
+ end
+ it "mark... | [create_bookmark->[create,id],update_bookmark->[id,update],notifications_for_user->[types,where,id],send_reminder_notification,create,new,let,describe,topic,destroy_for_topic,ago,eq_time,subject,trash!,it,cache_pending_at_desktop_reminder,to,before,let!,destroy,t,require,last,reminder_types,from_now,include,fab!,update... | end of class CaboosePrivateCategory missing context - > check if user has pending at desktop reminders for another bookmark. | why put this in a before block just for one test? |
@@ -94,6 +94,7 @@ export class DocInfo {
pageViewId,
linkRels,
metaTags,
+ replaceParams,
};
}
}
| [No CFG could be retrieved] | Provides a list of link tags and their associated meta tags. Get the links rels from the head of the document. | given we don't really 'replace' existing params, we should just call it `extraParams` |
@@ -131,6 +131,7 @@ import org.apache.nifi.util.FlowFilePackagerV3;
@WritesAttribute(attribute = "merge.bin.age", description = "The age of the bin, in milliseconds, when it was merged and output. Effectively "
+ "this is the greatest amount of time that any FlowFile in this bundle remained waiting in thi... | [MergeContent->[FragmentComparator->[compare->[compare]],BinaryConcatenationMerge->[getDelimiterFileContent->[readContent]],TarMerge->[merge->[process->[getPath],createFilename]],FlowFileStreamMerger->[merge->[process->[],createFilename]],ZipMerge->[merge->[process->[getPath],createFilename]]]] | The base class for the MergeContent class. Get the current state of the plugin. | It would probably be helpful here to add a description that explains that the content itself is not stored in memory but rather the FlowFiles' attributes and that the configuration for max bin size, etc. will influence how much heap is used. Would also call out that if merging together many small FlowFiles, a two-stage... |
@@ -162,7 +162,7 @@ struct options {
};
};
-void do_prepare_file_names(const std::string& file_path, std::string& keys_file, std::string& wallet_file)
+void do_prepare_file_names(const std::string& file_path, std::string& keys_file, std::string& wallet_file, std::string &mms_file)
{
keys_file = file_path;
... | [No CFG could be retrieved] | Provides a way to configure the daemon. Calculates the fee of a single key in the wallet. | I don't think it's good idea to make such intrusive dependency into `wallet2` module |
@@ -485,7 +485,7 @@ class TestGetOwnedDependencies(TestSetupPyBase):
sources=[],
dependencies=[':bar-resources', 'src/python/foo/bar/baz:baz2'],
)
- resources(name='bar-resources')
+ resources(name='bar-resources', sources=[])
... | [TestGetRequirements->[test_get_requirements->[assert_requirements],assert_requirements->[tgt]],TestGetSources->[assert_sources->[tgt],test_get_sources->[assert_sources]],TestGetOwnedDependencies->[test_owned_dependencies->[assert_owned],assert_owned->[tgt]],TestGetAncestorInitPy->[test_get_ancestor_init_py->[assert_an... | Test owned dependencies. | `resources` must define the `sources` field. It doesn't make sense to have a `resources` target without sources in it. |
@@ -1350,7 +1350,8 @@ def _submit_upload(request, addon, channel, next_details, next_finish,
data = form.cleaned_data
if version:
- is_beta = version.is_beta
+ is_beta = (version.is_beta and
+ waffle.switch_is_active('beta-versions'))
for plat... | [upload_for_version->[upload],submit_version_details->[_submit_details],upload->[handle_upload],upload_image->[ajax_upload_image],upload_detail->[get_fileupload_by_uuid_or_404,_compat_result,json_upload_detail],submit_version_upload->[_submit_upload],submit_addon_theme_wizard->[_submit_upload],submit_version_auto->[_su... | Submit a new upload. Override the validation of the add - on. Return a dict of all the configuration values that are not found in the system. | You don't want this, IMO. If a developer did find a way to get into the submission flow for a beta version to add a new `File` then the new `File` would be non-beta but the other `File`s would still be beta and mixing beta and non-beta `File` in a single `Version` is "a bad thing". |
@@ -1545,7 +1545,8 @@ def conv2d(input,
filter_shape = [num_filters, int(num_filter_channels)] + filter_size
def _get_default_param_initializer():
- std = (2.0 / (filter_size[0]**2 * num_channels))**0.5
+ filter_num_elem = filter_size[0] * filter_size[1] * num_channels
+ std = (2.0 / (f... | [ctc_greedy_decoder->[topk],image_resize->[_is_list_or_turple_],sequence_first_step->[sequence_pool],logical_xor->[_logical_op],elementwise_pow->[_elementwise_op],elementwise_min->[_elementwise_op],elementwise_max->[_elementwise_op],logical_not->[_logical_op],conv2d->[_get_default_param_initializer],logical_and->[_logi... | 2 - D convolution layer which calculates the output based on the input filter filter strides padd Parameters for the Deep CNN layer. Missing non - linear or non - convolution layer. Adds a non - zero filter to the network. | Is this a bug fix? seems quite bad. Can you put it in another PR and test the case? same for the one below. |
@@ -328,6 +328,16 @@ class RPC(object):
self._freqtrade.state = State.RELOAD_CONF
return {'status': 'reloading config ...'}
+ def _rpc_stopbuy(self) -> Dict[str, str]:
+ """
+ Handler to stop buying, but handle open trades gracefully.
+ """
+ if self._freqtrade.state =... | [RPC->[_rpc_status_table->[RPCException],_rpc_trade_status->[RPCException],_rpc_forcesell->[RPCException,_exec_forcesell],_rpc_balance->[RPCException],_rpc_trade_statistics->[RPCException],_rpc_forcebuy->[RPCException],_rpc_count->[RPCException],_rpc_daily_profit->[RPCException]]] | Internal method to handle reload_conf. Get the next node in the list of nodes. | this message doesn't have to be technical in my opinion. it can be "No more buy will occur from now. to resume buys run /reload_conf." but up to you ... |
@@ -5,9 +5,9 @@ through a model.
import logging
from collections import defaultdict
-from typing import Dict, List, Union, Iterator, Iterable
+from typing import Dict, Iterable, Iterator, List, Union
-import numpy
+import numpy as np
import torch
from allennlp.common.checks import ConfigurationError
| [Batch->[as_tensor_dict->[as_tensor_dict,get_padding_lengths],print_statistics->[get_padding_lengths],get_padding_lengths->[get_padding_lengths]]] | A batch of Instances that can be fed into a model. This function is used to convert a into a consistent length array. | Please don't do this. If you're writing code that uses numpy, I won't complain if you import it like this. But don't go changing all of the imports in the code to use this contraction. |
@@ -52,7 +52,12 @@ public class LobbyFrame extends JFrame {
chatPlayers.setChat(chat);
chatPlayers.setPreferredSize(new Dimension(200, 600));
chatPlayers.addActionFactory(this::newAdminActions);
- final LobbyGamePanel gamePanel = new LobbyGamePanel(this.client.getMessengers());
+
+ final LobbyGameT... | [LobbyFrame->[windowClosing->[shutdown],confirm->[getFrameForComponent,showConfirmDialog],connectionToServerLost->[showMessageDialog],newAdminActions->[getLocalNode,of,getName,equals,prompt,copyOf,confirm,emptyList,getRemote,isAdmin,toInstant,add,banUser,boot],shutdown->[dispose,start,setVisible],setShowChatTime->[setS... | The LobbyFrame class. Add the main split to the main window and add the necessary components to the chat message panel. | Before LobbyGameTableModel had an inner object that was an instance of the listener class, the model class tooke as parameter messengers and then registered the inner listener with the messengers. This violates IOC principle, and secondly the inner listener class is not needed when the game table model can implement th... |
@@ -343,10 +343,10 @@ namespace System.Reflection.Emit
public EnumBuilder DefineEnum(string name, TypeAttributes visibility, Type underlyingType)
{
ITypeIdentifier ident = TypeIdentifiers.FromInternal(name);
- if (name_cache.ContainsKey(ident))
+ if (name != null && ... | [ModuleBuilder->[GetArrayMethodToken->[GetMethodToken],IsDefined->[IsDefined],ResolveField->[ResolveField],ResolveMethod->[ResolveMethod],GetMethods->[GetMethods],TypeBuilder->[AddType],ResolveSignature->[ResolveSignature],MethodBuilder->[addGlobalMethod],GetFields->[GetFields],GetMaybeNested->[search_nested_in_array],... | Define an enum with the specified name and visibility. | I suspect that we will likely see more instances of breaks like this one in the code out there. Do we need to file a breaking change notification for this change? |
@@ -98,6 +98,10 @@ FINGERPRINTS = {
# Taiwanese Prius Prime
{
36: 8, 37: 8, 166: 8, 170: 8, 180: 8, 295: 8, 296: 8, 426: 6, 452: 8, 466: 8, 467: 8, 550: 8, 552: 4, 560: 7, 562: 6, 581: 5, 608: 8, 610: 8, 614: 8, 643: 7, 658: 8, 713: 8, 740: 5, 742: 8, 743: 8, 800: 8, 810: 2, 814: 8, 824: 2, 829: 2, 830: 7, 8... | [dbc_dict] | Taiwanese Prius Prime © 2007 Corolla - Corolla - Corolla. 8 - bit . | 835 is missing... seems like this fingerprint was collected with DSU disconnected and EON off. |
@@ -382,6 +382,14 @@ export class AmpIframe extends AMP.BaseElement {
return;
}
+ if (height < 100) {
+ user.warn(TAG_,
+ 'ignoring embed-size request because the resize height is ' +
+ 'less than 100px',
+ this.element);
+ return;
+ }
+
let newHeight, newWi... | [No CFG could be retrieved] | Updates the element s dimensions to accommodate the iframe s requested dimensions. Determines if the element has embed - size request. | we should also mention this in the .md file. also should this be a warning or an error/assert? |
@@ -249,8 +249,9 @@ class User < ApplicationRecord
end
def calculate_score
- score = (articles.where(featured: true).size * 100) + comments.sum(:score)
- update_column(:score, score)
+ user_reaction_points = Reaction.user_vomits.where(reactable_id: id).sum(:points)
+ calculated_score = (badge_achiev... | [User->[check_for_username_change->[path],send_welcome_notification->[send_welcome_notification],blocked_by?->[blocking?],auditable?->[any_admin?],blocking?->[blocking?],resave_articles->[path]]] | Calculates the score of a node in the database based on the number of articles and comments. | We are currently not using this at all, despite it being present. This allows us to start caring about user score for spam prevention or other quality control. |
@@ -97,9 +97,11 @@ void Servo::write(int value)
if (value < _minUs) {
// assumed to be 0-180 degrees servo
value = constrain(value, 0, 180);
- // writeMicroseconds will contrain the calculated value for us
+ // writeMicroseconds will contain the calculated value for us
// for any user defined mi... | [attach->[attach],write->[improved_map],read->[improved_map],detach->[detach]] | This is a private method to write a value into the neccessary bit field. | constrain was the original word I believe they meant |
@@ -2725,6 +2725,7 @@ bulk_update_transfer_done_aux(const struct crt_bulk_cb_info *info)
} else if (update_rc == 0) {
/* If sync was bi-directional - trasnfer value back */
+/* SAB Need to get version and pass it down ?? */
if (sync_type->ivs_flags & CRT_IV_SYNC_BIDIRECTIONAL) {
rc = transfer_back_to_chil... | [No CFG could be retrieved] | This function is called by the ivu_bulk_desc - > buc_bulk This function is called when a key is found in the system. | version checks are not needed on the response path |
@@ -2576,7 +2576,14 @@ function $CompileProvider($provide, $$sanitizeUriProvider) {
break;
case '&':
+ // Don't assign Object.prototype method to scope
+ if (!attrs.hasOwnProperty(attrName) && optional) break;
+
parentGet = $parse(attrs[attrName]);
+
+ ... | [No CFG could be retrieved] | Private functions - Assigns the parent to the destination object. Normalizes all accepted directives format into proper directive name. | This will only happen if a non-string/function is passed to `$parse`. When would that happen? |
@@ -603,9 +603,12 @@ class TopicView
@filtered_posts = unfiltered_posts
if SiteSetting.ignore_user_enabled
- @filtered_posts = @filtered_posts.where.not("user_id IN (?) AND id <> ?",
- IgnoredUser.where(user_id: @user.id).select(:ignored_user_id),
- ... | [TopicView->[relative_url->[relative_url],participant_count->[participant_count],title->[title],setup_filtered_posts->[summary,has_deleted?],initialize->[chunk_size,print_chunk_size],filter_posts_by_ids->[filter_post_types],image_url->[image_url],unfiltered_posts->[filter_post_types],filter_posts_by_post_number->[get_s... | This method is called by the post_filter_handler when a user has no post_. | @eviltrout is that what you were thinking of? |
@@ -259,18 +259,6 @@ class DataflowRunnerTest(unittest.TestCase, ExtraAssertionsMixin):
PipelineOptions(self.default_properties)) as p:
_ = p | beam.io.Read(beam.io.BigQuerySource('some.table'))
- def test_biqquery_read_fn_api_fail(self):
- remote_runner = DataflowRunner()
- for f... | [DataflowRunnerTest->[expect_correct_override->[_find_step],test_read_create_translation->[expect_correct_override],test_gbk_translation->[_find_step],test_cancel->[MockDataflowRunner],test_wait_until_finish->[MockDataflowRunner],test_read_bigquery_translation->[expect_correct_override],test_remote_runner_display_data-... | Test that BigQuery reads fail. Checks that the number of uncovered records in the display data is equal to the number. | Wouldn't we still want an error most fo the time? (E.g. this is still broken on OSS runners.) |
@@ -14,7 +14,14 @@ func formatDefaultBridge(remoteConn *remoteclientconfig.RemoteConnection, logLev
if port == 0 {
port = 22
}
+ options := ""
+ if remoteConn.IdentityFile != "" {
+ options += " -i " + remoteConn.IdentityFile
+ }
+ if remoteConn.IgnoreHosts {
+ options += " -q -o StrictHostKeyChecking=no -o Us... | [Sprintf] | returns a string that can be used to create a in the remote machine. | Out of curiosity: Why enabling the quite mode only here? |
@@ -30,10 +30,10 @@ namespace System.Net.Quic.Tests
{
using QuicListener listener = CreateQuicListener();
using QuicConnection clientConnection = CreateQuicConnection(listener.ListenEndPoint);
+ Task<QuicConnection> serverTask = listener.AcceptConnectionAsync().AsTask();
+ ... | [MsQuicTests->[CreateReadOnlySequenceFromBytes->[CreateSegments,ToArray,Add,Array],WriteData->[Enum,ToArray],Task->[Status,Fill,ConnectAsync,SequenceEqual,ChainElementStatus,nameof,IsCompletedSuccessfully,GenerateCertificates,PingPong,ListenEndPoint,Build,Collect,GatheredSequence,CustomRootTrust,WriteLine,ServerAuthent... | This method checks the number of unidirectional streams and the number of unidirectional streams. | SInce this is a common, repeated pattern, I wonder if we should have a helper method for it, like CreateClientAndServer or something like that. Or EstablishConnection or something. We have RunClientServer, but that's not really the same. |
@@ -371,9 +371,11 @@ public class JdbcMessageStore extends AbstractMessageGroupStore implements Messa
return new SimpleMessageGroup(groupId);
}
Assert.state(date.get() != null, "Could not locate created date for groupId=" + groupId);
+ Assert.state(updateDate.get() != null, "Could not locate updated date for... | [JdbcMessageStore->[completeGroup->[getQuery],addMessageToGroup->[getQuery,addMessage],setLastReleasedSequenceNumberForGroup->[getQuery],getMessageCountForAllMessageGroups->[getQuery],getMessageCount->[getQuery],getMessage->[getQuery],markMessageGroup->[getQuery,getMessageGroup],getMessageGroupCount->[getQuery],pollMes... | This method returns a message group with the given groupId. | updateDate.get() can return null can't it? (thought I saw DEFAULT NULL in the schema) |
@@ -49,7 +49,7 @@ var interfaceConfig = {
TOOLBAR_BUTTONS: [
'microphone', 'camera', 'closedcaptions', 'desktop', 'fullscreen',
'fodeviceselection', 'hangup', 'profile', 'info', 'chat', 'recording',
- 'livestreaming', 'etherpad', 'sharedvideo', 'settings', 'raisehand',
+ 'etherpad',... | [No CFG could be retrieved] | Initialize the toolbar with the given options. Displays the settings for a specific . | Why on earth do we have to remove `livestreaming`? |
@@ -727,6 +727,13 @@ namespace Dynamo.Models
LibraryServices.MessageLogged += LogMessage;
LibraryServices.LibraryLoaded += LibraryLoaded;
+ EngineController = new EngineController(
+ LibraryServices,
+ geometryFactoryPath,
+ DebugSettings.Ver... | [DynamoModel->[InitializeNodeLibrary->[InitializeIncludedNodes],ForceRun->[ResetEngine],LoadNodeLibrary->[LoadNodeLibrary],Paste->[Paste,Copy],RemoveWorkspace->[Dispose],UngroupModel->[DeleteModelInternal],ResetEngine->[ResetEngine],ShutDown->[OnShutdownCompleted,OnShutdownStarted,ShutDown],OpenXmlFileFromPath->[OnWork... | When an extension is added to the dynamo load it alerts late. Dynamo - Dynamo - Build. | This is already being initialized in `ResetEngineInternal`. |
@@ -452,8 +452,7 @@ class InstallRequirement(object):
dist_in_site_packages(existing_dist)):
raise InstallationError(
"Will not install to the user site because it will "
- "lack sys.path precedence to %s in %s" %
- ... | [InstallRequirement->[from_path->[from_path],prepare_metadata->[warn_on_mismatching_name,_set_requirement],_get_archive_name->[_clean_zip_name],get_dist->[_get_dist],install->[prepend_root],load_pyproject_toml->[load_pyproject_toml],archive->[_get_archive_name],ensure_has_source_dir->[ensure_build_location]]] | Checks if a node - level constraint exists. | This should be split across multiple lines. |
@@ -0,0 +1,16 @@
+using System;
+using System.Collections.Generic;
+using System.Linq;
+using System.Text;
+using Dynamo.PackageManager;
+
+namespace Dynamo.Extensions
+{
+ /// <summary>
+ /// Handles loading extensions given an extension definition file
+ /// </summary>
+ internal interface IExtensionLoad... | [No CFG could be retrieved] | No Summary Found. | The expected relationship between this and the Manager is unclear to me. |
@@ -20,4 +20,16 @@ module GobiertoCalendars
sync_range_start..sync_range_end
end
+ def self.sync_range_start_ibm_notes
+ DateTime.now - 2.days
+ end
+
+ def self.sync_range_end_ibm_notes
+ DateTime.now + 10.months
+ end
+
+ def self.sync_range_ibm_notes
+ sync_range_start_ibm_notes..sync_range_e... | [sync_range_start->[now],sync_range_end->[now,months]] | Sync range sequence number. | Prefer Date or Time over DateTime. |
@@ -17,7 +17,6 @@ DEPENDENCIES = [
'pytest>=3.5.1',
# 'azure-devtools>=0.4.1' override by packaging needs
'readme_renderer',
- 'azure-storage-blob',
'azure-storage-file<2.0',
'azure-storage-common<1.4.1',
'pyopenssl',
| [find_packages,setup] | Creates a new package with the given name and version. | I assume we removed blob because it wasn't being used in the tools? I suppose we don't have the same convenience for files? |
@@ -389,7 +389,7 @@ class Jetpack_XMLRPC_Server {
return $this->error( new Jetpack_Error( 'verify_secrets_incomplete', 'Verification secrets are incomplete', 400 ), $tracks_failure_event_name, $user );
}
- if ( ! hash_equals( $verify_secret, $secrets['secret_1'] ) ) {
+ if ( ! hash_equals( $verify_secret, $s... | [Jetpack_XMLRPC_Server->[error->[tracks_record_error]]] | Verify an action This function checks if the secrets are valid and deletes them if they are. | Do we still need to ignore this with the additions to `functions.compat.php?` |
@@ -39,6 +39,10 @@ export default DiscourseRoute.extend({
sort_order: meta.sort_order,
additionalFilters: meta.additional_filters || {},
});
+
+ controller.reviewables.forEach((reviewable) => {
+ reviewable.set("stale", false);
+ });
},
activate() {
| [No CFG could be retrieved] | The default DiscourseRoute class. Register the user s claimed count. | Suggestion: `controller.reviewables.setEach("stale", false)` is a little simpler. |
@@ -173,9 +173,9 @@ func getMatchingSecretKey(g *libkb.GlobalContext, secretUI libkb.SecretUI, arg k
}
g.Log.Debug("getMatchingSecretKey: acquiring lock")
- getMatchMu.Lock()
+ getKeyMu.Lock()
defer func() {
- getMatchMu.Unlock()
+ getKeyhMu.Unlock()
g.Log.Debug("getMatchingSecretKey: lock released")
}()... | [Unlock,GetDeviceSubkey,GetKID,GetUnlockedPaperEncKey,SignToString,CachedSecretKey,PaperDevices,GetSecretKeyWithPrompt,ED25519PublicKey,Lock,Trace,Debug,Sign,Equal,GetComputedKeyFamily,GetComputedKeyInfos,LoadMe,NewPaperKeyPhraseCheckVersion,SigKey,NewLoadUserArg,Account,LoginState,GetPaperKeyForCryptoPassphrase,ED2551... | unboxBytes32 unboxs the given ciphertext and returns the corresponding key and index. getMatchingSecretKey checks the device and paper keys for this user. | I think this is why CI failing. `Keyh` |
@@ -68,10 +68,7 @@ async def bandit_lint_partition(
output_filename="bandit.pex",
internal_only=True,
requirements=PexRequirements(bandit.all_requirements),
- interpreter_constraints=(
- partition.interpreter_constraints
- or PexInterpreter... | [rules->[rules],bandit_lint->[BanditPartition],bandit_lint_partition->[generate_args]] | Run Bandit on a given partition. Checks if a is found. | The only situation where this could be triggered is if you didn't set `compatibility` anywhere and you went out of your way to set `interpreter_constraints = []`. Imo, it's deceptive to have the option because almost always it has no impact on behavior. |
@@ -162,6 +162,16 @@ namespace ILCompiler.DependencyAnalysis
nativeDebugDirectoryEntryNode = nddeNode;
}
+ if (node is ImportThunk importThunkNode)
+ {
+ // All the import thunks are in a single contiguous run
+... | [ReadyToRunObjectWriter->[EmitObject->[EmitPortableExecutable]]] | Emit a specific object that can be used to build a portable executable PE. Private method to emit a node in the DebugDirectory. This method is called when a new object is generated. It will try to generate a new. | Could you add a check to ensure that this is a contiguous run of imports nodes? This is the sort of thing that might break as we adjust sorting for improved memory layout, and I'd like to have the compiler checking for this. |
@@ -20,6 +20,6 @@ import retrofit2.Call;
import retrofit2.http.POST;
public interface RemoteDeflectorResource {
- @POST("/system/deflector/cycle")
+ @POST("system/deflector/cycle")
Call<Void> cycle();
}
| [No CFG could be retrieved] | Cycle through all nodes in the system. | Are these changes strictly necessary, or rather can we catch this in a central place? I'm worried that plugins that implement a ProxiedResource will forget to make the path relative and thus break at runtime. |
@@ -490,7 +490,7 @@ class TrainModel(Registrable):
return self.trainer.train()
def finish(self, metrics: Dict[str, Any]):
- if self.evaluation_data_loader and self.evaluate_on_test:
+ if self.evaluation_data_loader is not None and self.evaluate_on_test:
logger.info("The model ... | [TrainModel->[finish->[dump_metrics,evaluate,join,items,info],run->[train],from_partial_objects->[index_with,construct,cls,get,is_master,read_all_datasets,values,items,join,from_instances,save_to_files,ConfigurationError]],train_model_from_file->[train_model,from_file],_train_worker->[from_params,int,prepare_global_log... | Finishes the training process. | Need this so `len()` is not called. |
@@ -10,6 +10,7 @@ class SubmissionsController < ApplicationController
before_filter :authorize_only_for_admin,
except: [:server_time,
:populate_file_manager,
+ :populate_file_manager_react,
:browse,
:index,
... | [SubmissionsController->[downloads_subdirectories->[downloads_subdirectories]]] | The main method of the administration interface. Generate a revisions history with date and num. | Align the elements of an array literal if they span more than one line.<br>Tab detected. |
@@ -525,7 +525,14 @@ Chunk index: {0.total_unique_chunks:20d} {0.total_chunks:20d}"""
def cleanup_outdated(ids):
for id in ids:
- os.unlink(mkpath(id))
+ cleanup_cached_archive(id)
+
+ def cleanup_cached_archive(id):
+ os.unlink(mkpath(id))
+ ... | [CacheConfig->[load->[recanonicalize_relative_location],create->[exists],__init__->[cache_dir],exists->[exists],_check_upgrade->[close]],Cache->[sync->[create_master_idx->[cleanup_outdated,lookup_name,mkpath,repo_archives,cached_archives,fetch_and_build_idx],cleanup_outdated->[mkpath],fetch_and_build_idx->[mkpath],crea... | Re - synchronize chunks cache with known backup archive indexes. Add missing chunks to the cache and create a master index. Fetch archive index and build index for chunk. | fname = mkpath(id) then reuse that twice. |
@@ -236,6 +236,7 @@ public interface TimerInternals {
STRING_CODER.encode(timer.getTimerId(), outStream);
STRING_CODER.encode(timer.getNamespace().stringKey(), outStream);
INSTANT_CODER.encode(timer.getTimestamp(), outStream);
+ INSTANT_CODER.encode(timer.getOutputTimestamp(), outStream);
... | [TimerDataCoder->[decode->[of,decode],verifyDeterministic->[verifyDeterministic],of->[TimerDataCoder],encode->[getTimestamp,getTimerId,encode],of],TimerData->[of->[of],compareTo->[getTimerId,getNamespace]]] | Encodes the given timer data into the given output stream. | @kennknowles do you know how this coder is used? Does this change break update? |
@@ -761,6 +761,16 @@ func (c *Container) ContainerRm(name string, config *types.ContainerRmConfig) er
if state.Status == "Starting" {
return derr.NewRequestConflictError(fmt.Errorf("The container is starting. To remove use -f"))
}
+
+ handle, err := c.Handle(id, name)
+ if err != nil {
+ return err
+ }
... | [ContainerExecStart->[Handle,TaskWaitToStart,TaskInspect],TaskWaitToStart->[Handle],findPortBoundNetworkEndpoint->[defaultScope],ContainerExecInspect->[TaskInspect],containerAttach->[Handle],ContainerExecCreate->[Handle,TaskInspect],TaskInspect->[Handle],containerStart->[Handle,cleanupPortBindings]] | ContainerRm removes a container from the container cache ContainerRemoveDefault - remove a running container. | Is this a docker-typed error? |
@@ -137,7 +137,7 @@ func (c *baseClient) leaderLoop() {
}
if err := c.updateLeader(); err != nil {
- log.Error("[pd] failed updateLeader", zap.Error(err))
+ log.Error("[pd] failed updateLeader", zap.Error(errs.ErrGRPCSend.FastGenByArgs()), zap.NamedError("cause", err))
}
}
}
| [updateURLs->[Strings,Info,GetClientUrls,DeepEqual],updateLeader->[updateURLs,Error,Warn,WithTimeout,switchLeader,WithStack,GetMembers,String,Errorf,GetClientUrls,getMembers,Done,GetLeader],getOrCreateGRPCConn->[GetClientConn,Unlock,WithTimeout,Target,RLock,Close,WithStack,ToTLSConfig,Lock,String,RUnlock,GetState,Debug... | leaderLoop is the main loop that checks for a leader and updates the leader in the cluster. | `updateLeader` error is not necessarily a grpc send error. What about creating a new error type to solve the function with too many possible error sources? |
@@ -3867,7 +3867,7 @@ void ByteCodeGenerator::StartEmitFunction(ParseNode *pnodeFnc)
// outer function's arguments directly.
sym = funcInfo->GetArgumentsSymbol();
Assert(sym);
- if (sym->GetHasNonLocalReference() || autoCapturesAllScope.OldCapturesAll())... | [No CFG could be retrieved] | Private helper functions. Checks if a parse node is a variable - let or constant and if it is put in. | EnsureScopeSlot() also does a NeedsSlotAlloc check. |
@@ -120,8 +120,9 @@ class AmpBridPlayer extends AMP.BaseElement {
this.feedID_ = user().assert(
(this.element.getAttribute('data-video') ||
- this.element.getAttribute('data-playlist')),
- 'Either the data-video or the data-playlist ' +
+ this.element.getAttribute('data-playlist') |... | [No CFG could be retrieved] | Gets the video iframe source. Adds an iframe to the window. | nit: `one of the ...` since now there is more than two and `either` won't be right. |
@@ -94,6 +94,8 @@ class CarState(object):
self.shifter_values = self.can_define.dv["GEAR_PACKET"]['GEAR']
self.left_blinker_on = 0
self.right_blinker_on = 0
+ self.offset = 0.
+ self.isoffset = 0
# initialize can parser
self.car_fingerprint = CP.carFingerprint
| [get_cam_can_parser->[CANParser],CarState->[__init__->[KF1D,CANDefine],update->[bool,int,any,mean,parse_gear_shifter,update,float,abs]],get_can_parser->[append,CANParser]] | Initialize object with a CAR object. | this should be a bool called: `is_offset_set` I think |
@@ -163,8 +163,8 @@ class Contribution(amo.models.ModelBase):
annoying = models.PositiveIntegerField(default=0,
choices=amo.CONTRIB_CHOICES,)
is_suggested = models.BooleanField(default=False)
- suggested_amount = DecimalCharField(max_digits=254, decimal_places=2,... | [Contribution->[date->[date],mail_thankyou->[_switch_locale,ContributionError]],ThemeUpdateCount->[ThemeUpdateCountManager],ClientData->[get_or_create->[get_or_create]]] | Return a unicode string of the add - on. | Moving from 254 to 9 might cause us issues if there's bad data in the DB, do we have a way to make sure that'll be ok for the migration? |
@@ -537,6 +537,10 @@ func resourceAwsLaunchTemplateRead(d *schema.ResourceData, meta interface{}) err
d.Set("user_data", ltData.UserData)
d.Set("vpc_security_group_ids", aws.StringValueSlice(ltData.SecurityGroupIds))
+ if ltData.EbsOptimized != nil {
+ d.Set("ebs_optimized", strconv.FormatBool(aws.BoolValue(ltDa... | [StringLenBetween,StringValueSlice,GetChangedKeysPrefix,DescribeLaunchTemplates,NewSet,UniqueId,SetPartial,BoolValue,IsNewResource,StringInSlice,Partial,HasPrefix,Set,Add,DeleteLaunchTemplate,CreateLaunchTemplate,Itoa,Error,Int64Value,Format,GetOk,Sequence,Errorf,Len,SetId,Bool,ComputedIf,Time,PrefixedUniqueId,Id,TimeV... | AccountID - The account ID of the launch template. GpuSpecifications sets all the fields of the LTSData object to their respective values. | We should probably additionally call `d.Set("ebs_optimized", "")` before this `if` to handle ensure Terraform catches the scenario where the attribute is set to "unspecified" out of band. |
@@ -76,6 +76,6 @@ public class BoundedSideInputJoinModel extends NexmarkQueryModel<Bid> {
@Override
protected Collection<String> toCollection(Iterator<TimestampedValue<Bid>> itr) {
- return toValueTimestamp(itr);
+ return toValue(itr);
}
}
| [BoundedSideInputJoinModel->[simulator->[Simulator]]] | Returns a collection of strings representing the timestamps in the given iterator. | @apilloud I think you did the most on these models. In SQL the timestamp itself is not really observable. The next GROUP BY will have some windowing expression (or not) and the timestamp is specified according to the arguments to the windowing function. |
@@ -3,7 +3,7 @@
* draytek.inc.php
* @author Jason Cheng <sanyu3u@gmail.com>
*/
-preg_match('/Router Model: ([\w ]+), Version: ([\w\.]+)/', $poll_device['sysDescr'], $tmp_draytek);
+preg_match('/Router Model: ([\w ]+), Version: ([\S\w\.]+),/', snmp_get($device, '.1.3.6.1.2.1.1.1.0', '-OQv'), $tmp_draytek);
$h... | [No CFG could be retrieved] | - read from Draytek. | If you use `$device['sysDescr']` does it work? It would be really helpful if you provided the sysDescr from the device. |
@@ -170,13 +170,13 @@ public class OMDirectoryCreateRequest extends OMKeyRequest {
// Need to check if any files exist in the given path, if they exist we
// cannot create a directory with the given key.
+ // Verify the path against prefix table
OMFileRequest.OMPathInfo omPathInfo =
- ... | [OMDirectoryCreateRequest->[dirKeyInfoBuilderNoACL->[addTrailingSlashIfNeeded,setUpdateID],validateAndUpdateCache->[acquireWriteLock,getCreateDirectoryRequest,getUserInfo,getAclsList,resolveBucketLink,getDirectoryResult,getOmRequest,OMDirectoryCreateResponse,getVolumeName,getMetrics,of,createErrorOMResponse,checkKeyAcl... | This method is used to validate the given key and update the cache. Creates a directory with the given key. This method releases the write lock on the object store and creates a new directory. | As we store the dir in prefix table now, we need to acquire PREFIX_LOCK instead of BUCKET_LOCK. ` acquiredLock = omMetadataManager.getLock().acquireWriteLock(BUCKET_LOCK, volumeName, bucketName); ` |
@@ -871,7 +871,7 @@ rebuild_ec_parity_multi_group(void **state)
}
#define SNAP_CNT 20
-#define EC_CELL_SIZE 1048576
+#define EC_CELL_SIZE DAOS_EC_CELL_DEF
static void
rebuild_ec_snapshot(void **state, daos_oclass_id_t oclass, int shard)
{
| [void->[daos_cont_destroy_snap,get_rank_by_oid_shard,daos_shard_fail_value,daos_fail_loc_set,ec_verify_parity_data,daos_pool_set_prop,verify_ec_full,insert_recxs,reintegrate_single_pool_rank,write_ec_partial_full,get_tgt_idx_by_oid_shard,ioreq_fini,malloc,strlen,test_runable,rebuild_pools_ranks,insert_single,assert_int... | rebuild_ec_snapshot - rebuild the ec snapshot by oid shard. | EC_CELL_SIZE is defined multiple times in this file, though not this patch issue. |
@@ -122,11 +122,12 @@ public class PendingTaskBasedWorkerProvisioningStrategy extends AbstractWorkerPr
public synchronized boolean doProvision()
{
Collection<Task> pendingTasks = runner.getPendingTaskPayloads();
+ log.info("Pending tasks: %d %s", pendingTasks.size(), pendingTasks);
Collecti... | [PendingTaskBasedWorkerProvisioningStrategy->[PendingProvisioner->[doProvision->[get],getWorkersNeededToAssignTasks->[get],doTerminate->[get,getWorkerNodeIDs]]]] | This method is called when a new worker is available. clear the provisioning queue. | These need to be debug, these can be HUGE |
@@ -95,6 +95,7 @@ public abstract class AbstractJDBCDriver {
synchronized (connection) {
if (sqlProvider.closeConnectionOnShutdown()) {
try {
+ connection.setAutoCommit(true);
connection.close();
} catch (SQLException e) {
logger.e... | [AbstractJDBCDriver->[start->[connect,prepareStatements,createSchema],stop->[error,close,appendSQLExceptionDetails,closeConnectionOnShutdown,StringBuilder],connect->[error,setNetworkTimeout,IllegalStateException,appendSQLExceptionDetails,connect,Properties,getConnection,isEmpty,StringBuilder,warn,getDriver],createTable... | Stop the connection. | this is dangerous.. isn't? why did you need it? |
@@ -26,7 +26,7 @@ define([
'use strict';
var TileBoundingSphere = function(center, radius) {
- this.boundingSphere = new BoundingSphere(center, radius);
+ this._boundingSphere = new BoundingSphere(center, radius);
};
defineProperties(TileBoundingSphere.prototype, {
| [No CFG could be retrieved] | Define the functions related to the object. Replies the distance between the camera and the bounding sphere in meters. | Since we changed all the other constructors to the newer format, might as well change this one too. |
@@ -1008,11 +1008,12 @@ def read_protocol_cache(manager: BuildManager,
log_error='Could not load protocol metadata: ')
if meta_snapshot is None:
return None
- current_meta_snapshot = {} # type: Dict[str, str]
- for id in graph:
- meta = graph[id].meta
- ... | [FindModuleCache->[_find_module->[_get_site_packages_dirs,find_lib_path_dirs],find_modules_recursive->[BuildSource,find_module,find_modules_recursive],clear->[clear]],process_graph->[add_stats,trace,log],_build->[compute_lib_path,BuildSourceSet,BuildResult],process_fine_grained_cache_graph->[load_fine_grained_deps],Bui... | Read and validate protocol cache. Read and validate protocol dependencies cache. | Looks like a typo: the -> they? |
@@ -20,4 +20,4 @@
package ecs
// Version is the Elastic Common Schema version from which this was generated.
-const Version = "1.0.1"
+const Version = "1.1.0"
| [No CFG could be retrieved] | Package variables for the ecs . | @andrewkroh Will the events have `ecs.version=1.1.0` based on this? Or is there another constant to be changed somewhere? |
@@ -290,3 +290,13 @@ func (ary UntrustedBytes) SafeByteSlice(start int, end int) ([]byte, error) {
}
return ary[start:end], nil
}
+
+// ChainlinkEthLogFromGethLog returns a copy of l as an eth.Log. (They have
+// identical fields, but the field tags differ, and the types differ slightly.)
+//
+// A better place fo... | [MarshalJSON->[String],Value->[Bytes],WithoutPrefix->[String],SetBytes] | SafeByteSlice returns a slice of bytes from the UntrustedBytes slice. | Pretty sure I already wrote something identical to this already... try `toCLEthLog` |
@@ -752,6 +752,8 @@ namespace System.Runtime.Loader
[UnconditionalSuppressMessage("ReflectionAnalysis", "IL2026:RequiresUnreferencedCode",
Justification = "Satellite assemblies have no code in them and loading is not a problem")]
+ [UnconditionalSuppressMessage("Single file", "IL3000: Avo... | [AssemblyLoadContext->[InitiateUnload->[RaiseUnloadEvent],ContextualReflectionScope->[Dispose->[SetCurrentContextualReflectionContext],SetCurrentContextualReflectionContext],ResolveUsingLoad->[Load],ResolveUsingEvent->[GetFirstResolvedAssemblyFromResolvingEvent],IntPtr->[Load],GetFirstResolvedAssemblyFromResolvingEvent... | Resolves the satellite assembly given the name of the parent assembly. | So the Justification is that this should never get called for single-file bundled assemblies, right? |
@@ -124,4 +124,8 @@ public class UniqueIdTest {
IdUtil.concatIds(objectIds).array()), objectHexCompareStr);
}
+ @Test
+ void testJobId() {
+ System.out.println(JobId.fromLong(1L).toString());
+ }
}
| [UniqueIdTest->[testUniqueIdsAndByteBufferInterConversion->[randomId,getUniqueIdsFromByteBuffer,assertEquals,concatIds],testComputeReturnId->[assertEquals,toString,computeReturnId,fromHexString],testConstructUniqueId->[assertTrue,equals,fromByteBuffer,toLowerCase,toString,wrap,fromHexString,getBytes,parseHexBinary,asse... | Test concate ids. | What's the purpose of this test? |
@@ -552,8 +552,8 @@ class RemoteBASE(object):
if not hasattr(self, "_upload"):
raise RemoteActionNotImplemented("upload", self.scheme)
- if to_info.scheme != self.scheme:
- raise NotImplementedError
+ # if to_info.scheme != self.scheme:
+ # raise NotImplemente... | [RemoteBASE->[_check_requires->[get_missing_deps,RemoteMissingDepsError],all->[cache_checksums],_estimate_cache_size->[update->[update],cache_checksums,_checksums_with_limit,_max_estimation_size],_download_dir->[walk_files],cache_checksums->[path_to_checksum,list_cache_paths],_cache_object_exists->[exists_with_progress... | Upload a from one filesystem to another. | I suppose this PR is WIP? In that case, please add `[WIP]` prefix :slightly_smiling_face: These lines shouldn't be removed in the final PR, unless there is a really good reason for it. |
@@ -182,6 +182,14 @@ define([
}
};
+ QuadtreePrimitive.prototype.addTileLoadedCallback = function(callback) {
+ this._callbacksAdded.push(callback);
+ };
+
+ QuadtreePrimitive.prototype.removeTileLoadedCallback = function(callback) {
+ this._callbacksRemoved.push(callback);
+ }... | [No CFG could be retrieved] | Updates the primitive. Checks if the object is destroyed. | Are you sure we should use callbacks here, not events? |
@@ -184,13 +184,10 @@ func (j JSON) Merge(j2 JSON) (JSON, error) {
cleaned[k] = v.Value()
}
- b, err := json.Marshal(cleaned)
- if err != nil {
- return JSON{}, err
- }
-
+ b, _ := json.Marshal(cleaned)
var rval JSON
- return rval, gjson.Unmarshal(b, &rval)
+ gjson.Unmarshal(b, &rval)
+ return rval
}
// E... | [UnmarshalText->[UnmarshalText],Scan->[setString],Hex->[ToInt],MarshalText->[MarshalText],ToStrings->[Hex],Value->[ToStrings,String],Delete->[Delete],CanStart->[Unstarted,Pending],Add->[Merge],Pending->[PendingBridge,PendingSleep,PendingConfirmations,PendingConnection],MarshalJSON->[MarshalJSON,MarshalText],Merge->[Val... | Merge merges two JSON objects and returns a new JSON object. | Seems problematic to drop this error. Something I'm missing? |
@@ -340,6 +340,9 @@ const config = {
},
],
},
+ 'toaster-focus': {
+ skip: true,
+ },
'modal-select': {
interactions: [
{
| [No CFG could be retrieved] | Dropdowns dropdowns for all items in the page. Get the config from the page. | that's the reason for skipping it? |
@@ -94,7 +94,12 @@ public class JsonExtractor extends Extractor {
@Override
protected Result[] run(String value) {
- final Map<String, Object> extractedJson = extractJson(value);
+ final Map<String, Object> extractedJson;
+ try {
+ extractedJson = extractJson(value);
+ ... | [JsonExtractor->[parseValue->[parseKey,parseValue]]] | Run the filter on the given value. | Instead of introducing a "special" Result to transport the exception, we could re-throw the exception as a (subclass of) RuntimeException and catch it in `Extractor`. |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.