patch stringlengths 18 160k | callgraph stringlengths 4 179k | summary stringlengths 4 947 | msg stringlengths 6 3.42k |
|---|---|---|---|
@@ -276,6 +276,10 @@ public interface MethodUtils {
Method method = findMethod(type, methodName, parameterTypes);
T value = null;
+ if (method == null) {
+ throw new IllegalStateException("method is null");
+ }
+
try {
ReflectUtils.makeAccessible(method... | [getAllDeclaredMethods->[getMethods],findOverriddenMethod->[getAllMethods,overrides],getAllMethods->[getMethods],invokeMethod->[findMethod],getMethods->[getMethods],findMethod->[findMethod],getDeclaredMethods->[getMethods]] | Invoke a method on an object. | how about make log more friendly? |
@@ -114,6 +114,16 @@ public class RegisterRules implements Startable {
}
}
+ private void persistRepositories(DbSession dbSession, List<RulesDefinition.Repository> repositories) {
+ dbClient.ruleRepositoryDao().truncate(dbSession);
+ List<RuleRepositoryDto> dtos = repositories
+ .stream()
+ .... | [RegisterRules->[mergeDebtDefinitions->[mergeDebtDefinitions],update->[update]]] | Register all rules in the system. | Do we really want to remove them all at each startup ? Could be done later, but maybe we should only add new repos and remove no more existing ones. |
@@ -234,7 +234,7 @@ class FreqtradeBot:
return trades_created
- def get_buy_rate(self, pair: str, tick: Dict = None) -> float:
+ def get_buy_rate(self, pair: str, refresh: bool = False, tick: Dict = None) -> float:
"""
Calculates bid target between current ask price and last price
... | [FreqtradeBot->[execute_buy->[get_buy_rate,_get_min_pair_stake_amount],_check_available_stake_amount->[_get_available_stake_amount],_notify_sell->[get_sell_rate],cleanup->[cleanup],handle_trailing_stoploss_on_exchange->[create_stoploss_order],handle_stoploss_on_exchange->[create_stoploss_order],_calculate_unlimited_sta... | Enter positions for all active trades. Get the used rate of a . | If any, i'd default this to True (so the current behaviour is kept). I noticed that `get_sell_rate()` did not set a default though - so maybe we should force explicit decision? (In the end, this is not a function a user will call manually - control all ocurances... |
@@ -50,7 +50,7 @@ window.APP = {
UI
};
-// TODO The execution of the mobile app starts from react/index.native.js.
+// TODO The execution of the mobile app starts from react/index.js.
// Similarly, the execution of the Web app should start from react/index.web.js
// for the sake of consistency and ease of und... | [No CFG could be retrieved] | The main entry point for the UI. | Undo this pl |
@@ -40,11 +40,14 @@ public class TokenWebApplicationServiceResponseBuilder extends WebApplicationSer
val registeredService = this.servicesManager.findServiceBy(service);
RegisteredServiceAccessStrategyUtils.ensureServiceAccessIsAllowed(service, registeredService);
val tokenAsResponse = Regist... | [TokenWebApplicationServiceResponseBuilder->[buildInternal->[buildInternal]]] | Build internal. | Fix the formatting issues here. Spaces between operators, and also fix the indentation please. |
@@ -829,6 +829,14 @@ public class WatermarkManager<ExecutableT, CollectionT> {
@GuardedBy("refreshLock")
private final Set<ExecutableT> pendingRefreshes;
+ /**
+ * A set of executables with currently extracted timers, that are to be processed. Note that, due
+ * to consistency, we can have only single extr... | [WatermarkManager->[extractFiredTimers->[extractFiredTimers],getTransformWatermark->[AppliedPTransformInputWatermark,SynchronizedProcessingTimeInputWatermark,SynchronizedProcessingTimeOutputWatermark,get,AppliedPTransformOutputWatermark],updateWatermarks->[create],FiredTimers->[toString->[toString]],TimerUpdate->[withC... | Creates a new WatermarkManager. Constructor for the UpdateQueue. | Consistency should only be per (key, window) pair. |
@@ -181,6 +181,8 @@ set_akey(uint64_t i, char *path, daos_key_t *akey)
{
uint64_t key = (i << 32) + path[L_A];
+ D_ASSERT(L_A < strlen(path));
+ key = (i << 32) + path[L_A];
D_ASSERT(akey->iov_buf_len >= sizeof(key));
*(uint64_t *)akey->iov_buf = key;
akey->iov_len = sizeof(key);
| [bool->[strncmp,min,strlen,strcmp,ARRAY_SIZE,we_minus_re],int->[read_ts_o,is_r,read_ts_d,stop_tx,ARRAY_SIZE,tx_list,punchd_with_flags,D_ASSERT,overlap,tx_update,set_oid,is_rw,update_f,memcpy,strlen,tx_fetch,set_path,puncho_with_flags,is_excluded,setup_io,vos_obj_punch,D_FREE,print_message,vos_obj_fetch_ex,tx_punch,vos_... | This method is called from DAO to set the key of the node in the DAO. | (style) Comparisons should place the constant on the right side of the test |
@@ -320,8 +320,8 @@ class TestISO(cloudstackTestCase):
"Check display text of updated ISO"
)
self.assertEqual(
- iso_response.bootable,
- self.services["bootable"],
+ str(iso_response.bootable).lower(),
+ str(self.services["bootable"]).lower(),
... | [TestISO->[test_07_list_default_iso->[get_iso_details]]] | Test edit ISO missing values. | @borisstoyanov I am very worried the we are hiding issues this way. A test that has been passing for about five years suddenly fails and then we fix the test? I realize this *might* not be a issue with the code/system. Do we have any clue as to when and why it started failing? |
@@ -191,14 +191,8 @@ class Activator(object):
yield self.run_script_tmpl % script
def build_activate(self, env_name_or_prefix):
- test_path = expand(env_name_or_prefix)
- if isdir(test_path):
- prefix = test_path
- if not isdir(join(prefix, 'conda-meta')):
- ... | [main->[execute,Activator],iteritems->[iteritems],Activator->[reactivate->[_finalize],deactivate->[_finalize],_replace_prefix_in_path->[_get_path_dirs,_get_starting_path_list],_add_prefix_to_path->[_get_path_dirs,_get_starting_path_list],_parse_and_set_args->[Help],activate->[_finalize]],main] | Activate a node in the system. Returns a dict of all configuration options that can be used to generate a new configuration. | What was this doing. I don;t follow |
@@ -56,7 +56,6 @@ describe('runtime', () => {
history: {},
navigator: {},
setTimeout: () => {},
- location: parseUrl('https://acme.com/document1'),
Object,
HTMLElement,
services: {
| [No CFG could be retrieved] | The main function of the package. Checks that the cursor is visible on the document element on the device. | This one would have one out. |
@@ -96,6 +96,17 @@ type ControllerManagerControllerConfiguration struct {
ManagedSeedSet *ManagedSeedSetControllerConfiguration `json:"managedSeedSet,omitempty"`
}
+// BastionControllerConfiguration defines the configuration of the Bastion
+// controller.
+type BastionControllerConfiguration struct {
+ // Concurre... | [No CFG could be retrieved] | ITSControllerConfig defines the configuration of the ACSController. | Should this be optional and defaulted? |
@@ -31,11 +31,7 @@ public class MapMerger implements Merger<Map<?, ?>> {
return Collections.emptyMap();
}
Map<Object, Object> result = new HashMap<Object, Object>();
- for (Map<?, ?> item : items) {
- if (item != null) {
- result.putAll(item);
- ... | [MapMerger->[merge->[emptyMap,isEmpty,putAll]]] | Merge the given items into a new map. | `forEach` is designed for side effect, a chained stream seems better to me. |
@@ -217,6 +217,8 @@ namespace System.Text.Json
public System.Text.Json.Serialization.JsonIgnoreCondition DefaultIgnoreCondition { get { throw null; } set { } }
public System.Text.Json.JsonNamingPolicy? DictionaryKeyPolicy { get { throw null; } set { } }
public System.Text.Encodings.Web.JavaSc... | [No CFG could be retrieved] | The base class for all the options that are used by the JSON serializer. Reads the values of the nanomata field from the header. | This is going to impact folks who target `net5.0` and use this API. Prior to this change, only folks using the package will have seen the obsolete attribute. Have you identified all the places upstack that will need to change as a result of this and made sure folks are ready to react to the change? |
@@ -344,6 +344,8 @@ public class DistributionManagerImpl implements DistributionManager {
log.problemApplyingStateForKey(ee.getMessage(), e.getKey());
}
}
+ } else {
+ log.warnf("Received a key that doesn't map to this node: %s, mapped to %s", e.getKey(... | [DistributionManagerImpl->[applyState->[applyStateMap],getLocality->[getReplCount],locate->[getReplCount,locate],markNodePushCompleted->[markRehashCompleted],isLocatedLocally->[isLocal],isLocal->[isLocal],locateAll->[getReplCount,locateAll],locateKey->[locate],retrieveFromRemoteSource->[locate]]] | Apply the state map to the cache. | Any messages that are WARN or above need to be defined in org.infinispan.util.logging.Log as explicit method calls so that they can be internationalized. There're plenty of examples in the code base... |
@@ -131,6 +131,8 @@ def upload_handler(end_event):
current=False
)
upload_queue.put_nowait(item)
+ cache_upload_queue(upload_queue)
+
cur_upload_items[tid] = None
for _ in range(RETRY_DELAY):
| [takeSnapshot->[b64jpeg],scan_dir->[scan_dir],main->[backoff,handle_long_poll],listDataDirectory->[scan_dir],log_handler->[get_logs_to_send_sorted],reboot->[do_reboot->[reboot]],main] | Handler for the upload_queue. | also save the queue in the successful case. |
@@ -524,13 +524,7 @@ void gui_post_expose(dt_lib_module_t *self, cairo_t *cr, int32_t width, int32_t
// if the user points at this image, we really want it:
if(!img) img = dt_image_cache_get(darktable.image_cache, imgid, 'r');
- int zoom = 1;
- float imgwd = 0.90f;
- if(zoom == 1)
- {
- img... | [No CFG could be retrieved] | This function is called after the GUI is exposed. - - - - - - - - - - - - - - - - - -. | Indeed, looks like a code after refactoring :) |
@@ -38,6 +38,10 @@ VENV_NAME = "regressionenv"
AZURE_SDK_FOR_PYTHON_GIT_URL = "https://github.com/Azure/azure-sdk-for-python.git"
TEMP_FOLDER_NAME = ".tmp_code_path"
+CUSTOM_REGRESSION_INSTALLED_PACKAGES = [
+ 'msrestazure'
+]
+
logging.getLogger().setLevel(logging.INFO)
| [RegressionContext->[initialize->[clear_venv],__init__->[create,CustomVirtualEnv]],RegressionTest->[_run_test->[initialize,deinitialize]],run_main->[RegressionContext,RegressionTest,init_for_pkg,find_package_dependency],run_main] | Initialize the venv with the given path. | unused or for future reference? |
@@ -272,7 +272,7 @@ public class CoordinatorDynamicConfigTest
0,
false,
false,
- Integer.MAX_VALUE
+ 0
);
actual = CoordinatorDynamicConfig.builder().withDecommissioningNodes(ImmutableSet.of("host1")).build(actual);
| [CoordinatorDynamicConfigTest->[testSerdeWithKillAllDataSources->[assertTrue,of,getCause,assertConfig,writeValueAsString,readValue,fail],testSerdeHandleInvalidMaxNonPrimaryReplicantsToLoad->[assertTrue,getCause,writeValueAsString,readValue,fail],testBuilderDefaults->[build,of,assertConfig],testDeserializeWithoutMaxSegm... | Tests the configuration of a node with decommissioning parameters. if we have reached max node count we can get it from the pool. | any specific reasoning behind flipping this value around in some of the tests? |
@@ -1834,6 +1834,17 @@ public class StorageManagerImpl extends ManagerBase implements StorageManager, C
handleRemoveChildStoragePoolFromDatastoreCluster(childDatastoreUUIDs);
}
+ private StoragePoolVO getExistingPoolByUuid(String uuid){
+ if(!uuid.contains("-")){
+ UUID poolUuid = n... | [StorageManagerImpl->[createChildDatastoreVO->[getStoragePoolTags],updateStoragePool->[enablePrimaryStoragePool,disablePrimaryStoragePool,updateStoragePool],sendToPool->[getUpHostsInPool,sendToPool],canHostAccessStoragePool->[canHostAccessStoragePool],discoverImageStore->[getName],createCapacityEntry->[createCapacityEn... | Synchronize child datastore storage pools with the datastore cluster. This method checks if the child datastores are added to the datastore cluster and if so updates Throws a CloudRuntimeException if the datastoreClusterPool is not empty and the dataStoreVO is not. | We could invert this `if` to reduce indentation. |
@@ -0,0 +1,5 @@
+class AddUserPasswordCost < ActiveRecord::Migration
+ def change
+ add_column :users, :password_cost, :string
+ end
+end
| [No CFG could be retrieved] | No Summary Found. | we'll need to backfill cost for old rows, should that be a separate migration? |
@@ -27,5 +27,6 @@ class SuluCoreBundle extends Bundle
$container->addCompilerPass(new StructureExtensionCompilerPass());
$container->addCompilerPass(new RegisterContentTypesCompilerPass());
$container->addCompilerPass(new RegisterLocalizationProvidersPass());
+ $container->addCompilerP... | [SuluCoreBundle->[build->[addCompilerPass]]] | Adds all the PHP code passes to the container. | `RemoveContextualServicesPass`, `ResolveContextualServicesPass` ? Although Foreign is ok. |
@@ -92,6 +92,7 @@ type worker struct {
prev *prevChanSet
next *nextChanSet
stats *stats
+ noUpload bool
}
func (w *worker) run(dataSet *dataSet) error {
| [flushDataReaders->[rollDataReader],Write->[Write],Copy->[writeDataSet,finishTag],rollDataReader->[roll],Close->[writeDataSet],atSplit->[numBytesRolled],writeDataSet->[run,finishTag]] | run runs the worker. | What's the purpose of `noUpload`? It seems like a `Writer` wouldn't be of much use if it didn't upload, but I assume I'm misunderstanding what this does in some way. |
@@ -218,6 +218,10 @@ func (s *Identify3Session) expire(mctx MetaContext) {
mctx.CWarningf("failed to get an electron UI to expire %s: %s", s.id, err)
return
}
+ if cli == nil {
+ mctx.CWarningf("failed to get an electron UI to expire: got nil", s.id)
+ return
+ }
err = cli.Identify3TrackerTimedOut(mctx.Ctx(... | [expireSession->[expire],OnLogout->[makeNewCache],pokeExpireThread->[isShutdown],lockAndPut->[getLocked,ID]] | expire is called when the ID3 session is expired. | panic was on this line |
@@ -100,14 +100,17 @@ import java.util.stream.Collectors;
<&_ } -&>
<%_ } -%>
+<% Commented out until N1qlJoin support is fixed */%>
<&_ if (fragment.classAdditionalRelationshipsSection) { -&>
<%_ for (const relationship of relationships) { _%>
- <%_ if (!relationship.id) { _%>
+ <%_ if (!relation... | [No CFG could be retrieved] | This method is used to determine the unique identifier for a relation. set relationship. | Since you reverted back to underscored field names, shouldn't we do the same for relationships also ? |
@@ -61,8 +61,7 @@ class RemoteInterfaceHelper {
}
final Class<?>[] t1 = o1.getParameterTypes();
final Class<?>[] t2 = o2.getParameterTypes();
- // both null
- if (t1 == t2) {
+ if ((t1 == null) && (t2 == null)) {
return 0;
}
if (t1 == null) {
| [RemoteInterfaceHelper->[getNumber->[getMethods,sort,equals,IllegalStateException,getParameterTypes,asList,isLoggable,fine],getMethodInfo->[getMethods,of,sort,getName,getParameterTypes,asList,isLoggable,fine],getName,equals,getLogger,compareTo,getParameterTypes]] | Sorts the methods in the order they are declared. | This complete method/lambda can be replaced with ```java Comparator.comparing(Method::getName) .thenComparing(Method::getParameterTypes, Comparator.comparing(o -> o == null) .thenComparingInt(a -> a.length) .thenComparing((o1, o2) -> {/*insert for-loop array comparison*/}); |
@@ -2743,6 +2743,11 @@ public class QueueImpl extends CriticalComponentImpl implements Queue {
private Message makeCopy(final MessageReference ref,
final boolean expiry,
final boolean copyOriginalHeaders) throws Exception {
+ if (ref == null) {
+ ... | [QueueImpl->[getDurableDeliveringCount->[getDurableMessageCount],scheduleDepage->[getName],configureExpiry->[getExpiryAddress],addConsumer->[debug],deleteAllReferences->[deleteAllReferences],configureSlowConsumerReaper->[equals,getName,cancel,debug],getMessageCount->[getMessageCount],getDeliveringCount->[getMessageCoun... | Makes a copy of the message given a message reference. | Was this an accident? WEren't you supposed to use NULL_REF.createException here? |
@@ -113,6 +113,12 @@ class OpenidConnectAuthorizeForm
errors.add(:scope, t('openid_connect.authorization.errors.unauthorized_scope'))
end
+ def validate_prompt
+ return if prompt == 'select_account'
+ return if prompt == 'login' && service_provider.allow_prompt_login
+ errors.add(:prompt, t('openid_... | [OpenidConnectAuthorizeForm->[validate_privileges->[ial,ial2_requested?],scopes->[ial2_requested?],check_for_unauthorized_scope->[ial2_requested?]]] | Check if the user has an authorized scope and if so add an error if not add the. | Should this add an error if the `prompt` param is nil? It looks like it will. The validation for `prompt` on line 32 looks like it validates presence, but also looks like it has `allow_nil: true`. That is confusing to me. If we don't allow it to be blank is there any reason to not to pull the `allow_nil` out of that va... |
@@ -260,7 +260,9 @@ func (b *localBackend) removeStack(name tokens.QName) error {
func backupTarget(bucket Bucket, file string) string {
contract.Require(file != "", "file")
bck := file + ".bak"
- err := renameObject(bucket, file, bck)
+ err := bucket.Delete(context.TODO(), bck)
+ contract.IgnoreError(err)
+ err =... | [getHistory->[historyDirectory],addToHistory->[stackPath,historyDirectory],renameHistory->[historyDirectory]] | out the checkpoint file since it may contain resource state updates. Get the backup directory and write out the new checkpoint file. | This is the part I least like about this PR, but I think it should not cause problems. This `Delete` is here so we don't have stale `.json.bak` next to newer `.json.gz.bak` and inversely. |
@@ -8,6 +8,11 @@ def home(request):
products = products_for_homepage()[:8]
products = products_with_availability(
products, discounts=request.discounts, local_currency=request.currency)
+ # TODO: Get rid of url parameters
+ if request.GET.get('action') == 'impersonate':
+ msg = pgettext_... | [styleguide->[TemplateResponse],home->[TemplateResponse,products_with_availability,products_for_homepage]] | Show a template with a single . | How about some constant here? Not a fan of hard-coding values |
@@ -37,8 +37,10 @@ class REdger(RPackage):
homepage = "https://bioconductor.org/packages/edgeR/"
git = "https://git.bioconductor.org/packages/edgeR.git"
+ version('3.22.3', commit='e82e54afc9398ac54dc4caba0f7ae5c43e572203')
version('3.18.1', commit='101106f3fdd9e2c45d4a670c88f64c12e97a0495')
... | [REdger->[depends_on,version]] | This file contains all the information that is needed for the edge - R package. | Any idea what range of versions require which range of R versions? |
@@ -67,7 +67,7 @@ public enum ErrorMessage {
.toolTip("Shows the error console window with full error details.")
.actionListener(() -> {
hide();
- ErrorConsole.showConsole();
+ ClientSetting.SHOW_CONSOLE.saveAndFlush("true");
... | [windowClosing->[hide],hide->[set,setVisible],show->[setText,invokeLater,compareAndSet,setLocationRelativeTo,setVisible,pack],addWindowListener,setModalExclusionType,AtomicBoolean,build,WindowAdapter,JFrame,setAlwaysOnTop,add] | Displays the error message. This function packs the windowReference and displays it. | When we open the console window explicitly, TripleA will now remember that decision. There is similar tear down code to remember for it to be closed when we close the console. |
@@ -66,9 +66,10 @@ class MeanAbsoluteError(Metric):
mean_absolute_error = self._absolute_error / self._total_count
if reset:
self.reset()
+ assert isinstance(mean_absolute_error, float)
return {"mae": mean_absolute_error}
@overrides
- def reset(self):
+ def re... | [MeanAbsoluteError->[__call__->[tensor,numel,detach_tensors,is_distributed,sum,item,all_reduce,abs],get_metric->[reset]],register] | Returns the mean absolute error of the sequence. | Since we have this assertion covered in the tests, let's remove it here. |
@@ -207,7 +207,7 @@ namespace DotNetNuke.Modules.Admin.Sales
RoleInfo objRoleInfo = RoleController.Instance.GetRole(intPortalID, r => r.RoleID == intRoleID);
float rolePrice = objRoleInfo.ServiceFee;
float trialPrice = objRoleInfo.TrialFee;
- ... | [PayPalIPN->[OnInit->[OnInit,InitializeComponent],OnLoad->[OnLoad]]] | load the neccesary data from the request This function is used to verify the source and postback to verify the source. if the user subscription or the payment payment is approved update the user s expiration date and the. | Please use `String#Equals(String, StringComparison)` |
@@ -301,13 +301,13 @@ public class Note implements Serializable, JobListener {
Map<String, String> info = new HashMap<>();
info.put("id", p.getId());
info.put("status", p.getStatus().toString());
- info.put("started", p.getDateStarted().toString());
- info.put("finished", p.getD... | [Note->[generateParagraphsInfo->[getId],completion->[getParagraph,completion],snapshotAngularObjectRegistry->[getId],run->[getParagraph],persist->[snapshotAngularObjectRegistry],unpersist->[id],isLastParagraph->[getId]]] | Generate paragraphs info. | Could you please explain, what will `null` represent in the started of finished field of the `paragraphsInfo` in case of paragraphs that "never run" / "first run but not finished"? Will this create a new places in code, we need to check for null's now? |
@@ -92,6 +92,12 @@ def dict_methods_fast_path(
if not (len(expr.args) == 1 and expr.arg_kinds == [ARG_POS]):
return None
arg = expr.args[0]
+ if isinstance(arg, GeneratorExpr):
+ val = preallocate_space_helper(builder, arg,
+ empty_op_llbuilder=builder.... | [translate_set_from_generator_call->[translate_set_comprehension,isinstance,len],translate_all_call->[any_all_helper,unary_op,isinstance,len],translate_dataclasses_field_call->[AnyType],translate_next_call->[gen_inner_stmts->[accept,assign,goto],node_type,list,BasicBlock,Unreachable,RaiseStandardError,add,len,comprehen... | Fast path for dict methods. | Should also consider `[ ]` form, which is in `transform_list_comprehension` |
@@ -415,9 +415,9 @@ module Engine
end
end
- @nodes = @paths.map(&:node).compact.uniq
- @branches = @paths.map(&:branch).compact.uniq
- @stops = @paths.map(&:stop).compact.uniq
+ @nodes = @paths.flat_map(&:nodes).compact.uniq
+ @branches = @paths.flat_map(&:branches).compact.un... | [Tile->[compute_city_town_edges->[compute_loc],add_reservation!->[add_reservation!],from_code->[decode],paths->[rotate],restore_borders->[restore_borders],paths_are_subset_of?->[rotate]]] | Separate parts into groups of parts with a single . | i believe none of these should need compact, can you check? |
@@ -468,7 +468,12 @@ namespace Microsoft.Xna.Framework
}
-
+ /// <summary>
+ /// Creates a new <see cref="Matrix"/> which contains the rotation moment around specified axis.
+ /// </summary>
+ /// <param name="axis">The axis of rotation.</param>
+ /// <param name="angle">... | [Matrix->[GetHashCode->[GetHashCode],Equals->[Equals],CreateFromYawPitchRoll->[CreateFromQuaternion,CreateFromYawPitchRoll],CreateScale->[CreateScale],Add]] | Creates a constrained billboard given the object position and camera position and the rotation axis and Creates a new matrix that represents the cross product of the given axis and angle. | Whenever we have an angle parameter we need to specify if it is in radians or degrees. A very common bug that occurs when the docs are not specific. |
@@ -345,9 +345,10 @@ kubectl %v port-forward "$pod" %d:8080
eg.Go(func() error {
fmt.Printf("Forwarding the dash (Pachyderm dashboard) UI port to http://localhost:%v ...\n", uiPort)
stdin := strings.NewReader(fmt.Sprintf(`
-pod=$(kubectl %v get pod -l app=dash | awk '{if (NR!=1) { print $1; exit 0 }}')
+p... | [StringVar,TempFile,Now,Warningf,SprintFunc,Close,StartReportAndFlushUserAction,PrettyPrintVersionNoAdditional,Encode,IsNotExist,RunFixedArgs,Flush,CombinedOutput,Error,RunIO,NewBufferString,ListRepo,Dial,NewEncoder,SetPidfilePath,New,Go,ListPipeline,StringVarP,NewAPIClient,GetAddressFromUserMachine,Errorf,AddCommand,W... | forward the dash port to the local port Flags for the server to bind to. | Is this debug output? Or something we want the user to see? |
@@ -307,6 +307,18 @@ module.exports = {
'Key': false,
},
},
+ {
+ 'files': [
+ '**/test-*',
+ '**/_init_tests*',
+ '**/*_test.js',
+ '**/testing/**',
+ '**/storybook/*.js',
+ ],
+ 'rules': {
+ 'local/no-forbidden-terms': [2, forbiddenTerms... | [No CFG could be retrieved] | JSDoc - specific rules A list of all tags that should be marked as missing. | Maybe use the js extension for this one? |
@@ -127,7 +127,7 @@
*/
function filterFilter() {
return function(array, expression, comparator) {
- if (!isArray(array)) {
+ if (!isArrayLike(array)) {
if (array == null) {
return array;
} else {
| [No CFG could be retrieved] | Private functions - functions - functions - functions Creates predicate function for array. | This is not sufficient. We are using `array.filter`, which `isArrayLike` does not guarrantee to exist. Maybe we could change `array.filter(...)` with something like `isArray(array) ? array.filter(...) : Array.prototype.filter.call(array, ...)`. It might even be better to always use the latter form regardless of the typ... |
@@ -115,6 +115,8 @@ type Config struct {
DisabledTenants flagext.StringSliceCSV `yaml:"disabled_tenants"`
RingCheckPeriod time.Duration `yaml:"-"`
+
+ RulerEnableQueryStats bool `yaml:"enable_query_stats"`
}
// Validate config and returns error on failure
| [Rules->[getLocalRules],Validate->[Validate],getLocalRules->[GetRules],ServeHTTP->[ServeHTTP],RegisterFlags->[RegisterFlags]] | Validate validates the configuration. | [nit] No need to prefix it with `Ruler`. It's a field of the ruler's `Config`. |
@@ -338,8 +338,8 @@ public interface Expr
{
Set<IdentifierExpr> moreScalars = new HashSet<>();
for (Expr expr : scalarArguments) {
- final IdentifierExpr stringIdentifier = expr.getIdentifierExprIfIdentifierExpr();
- if (stringIdentifier != null) {
+ final boolean isIdentiferExpr... | [LambdaExpr->[eval->[eval],getIdentifier->[toString],visit->[LambdaExpr,visit],analyzeInputs->[analyzeInputs,removeLambdaArguments]],BinaryEvalOpExprBase->[eval->[eval]],UnaryNotExpr->[eval->[eval],copy->[UnaryNotExpr]],BinEqExpr->[copy->[BinEqExpr]],BinModuloExpr->[copy->[BinModuloExpr]],BinMinusExpr->[copy->[BinMinus... | With scalar arguments. | does this change really contribute to perf? if not then older version is more conventional IMHO. |
@@ -0,0 +1,8 @@
+# -*- coding: utf-8 -*-
+from __future__ import unicode_literals
+
+from django.apps import AppConfig
+
+
+class ContributionsConfig(AppConfig):
+ name = 'kuma.contributions'
| [No CFG could be retrieved] | No Summary Found. | It may make sense to add an "enabled" function here to consolidate the ``MDN_CONTRIBUTIONS`` check, so that the waffle flag is just here as well. |
@@ -47,7 +47,8 @@ def rescale(data, times, baseline, mode, verbose=None, copy=True):
if copy:
data = data.copy()
- valid_modes = ['logratio', 'ratio', 'zscore', 'mean', 'percent']
+ valid_modes = ['logratio', 'ratio', 'zscore', 'mean', 'percent',
+ 'zlogratio']
if mode not i... | [rescale->[int,log10,mean,len,copy,std,where,info,Exception]] | Rescale a base on a time series and a baseline correction. empty slice warning . | for good practice reasons use tuple to communicate to the reader that this is a fixed set of options that will not be dynamically changed by the code below. Use parentheses instead of brackets. |
@@ -0,0 +1,14 @@
+package org.infinispan.marshall.core.internal;
+
+final class InternalIds {
+
+ static final int NULL = 0x00; // null
+ static final int INTERNAL = 0x01; // internal, including primitives
+ static final int PREDEFINED = 0x02; // predefined foreign externalizers... | [No CFG could be retrieved] | No Summary Found. | Assuming we can't eliminate these, shouldn't they be in the `MarshallableType` enum? |
@@ -1109,15 +1109,8 @@ namespace Js
if (callInfo.Count < 2)
{
- if (pNew == nullptr)
- {
- // No arguments passed to Array(), so create with the default size (0).
- pNew = CreateArrayFromConstructor(function, 0, scriptContext);
- }
- ... | [No CFG could be retrieved] | Creates an array of objects with the same size as the original array. Determines if the first argument is an int tagged int and if it is an int - tagged. | >if (pNew == nullptr) [](start = 12, length = 20) what happens to the != nullptr cases ? You recreate new array everytime ? When is pNew not nullptr ? #WontFix |
@@ -116,7 +116,7 @@ class DictionaryAgent(Agent):
dictionary.add_argument(
'--dict-maxtokens', default=DictionaryAgent.default_maxtokens,
type=int,
- help='max number of tokens to include in sorted dict')
+ help='max number of tokens to includ... | [find_ngrams->[find_ngrams],DictionaryAgent->[add_to_dict->[add_token],bpe_tokenize->[tokenize],keys->[keys],load->[add_token,unescape],tokenize->[find_ngrams],__setitem__->[add_token],finalize->[finalize,tokenize],shutdown->[save],save->[escape],txt2vec->[tokenize],max_freq->[keys],act->[add_to_dict,tokenize],span_tok... | Adds command line arguments to the dictionary. Add options related to nltk and spacy. | should we make a similar note for minfreq? |
@@ -62,7 +62,15 @@ public class SegmentLoaderLocalCacheManager implements SegmentLoader
this.config = config;
this.jsonMapper = mapper;
- this.locations = Lists.newArrayList();
+ this.locations = Sets.newTreeSet(new Comparator<StorageLocation>()
+ {
+ @Override
+ public int compare(Storag... | [SegmentLoaderLocalCacheManager->[cleanup->[findStorageLocationIfLoaded],cleanupCacheFiles->[cleanupCacheFiles],getSegmentFiles->[findStorageLocationIfLoaded],withConfig->[SegmentLoaderLocalCacheManager]]] | Creates a cache manager which loads segments from the local storage. Returns the files of the given segment. | It should better be standard `java.lang.Long.compare(right.available(), left.available())`. Sorry that I didn't suggested you this form before. |
@@ -257,13 +257,12 @@ public class RulesDefinitionTest {
}
@Test
- public void warning_if_duplicated_rule_keys() {
+ public void fail_if_duplicated_rule_keys_in_the_same_repository() {
+ expectedException.expect(IllegalArgumentException.class);
+
RulesDefinition.NewRepository findbugs = context.create... | [RulesDefinitionTest->[load_rule_html_description_from_file->[getResource,done,rule,isEqualTo,createRepository,setHtmlDescription],fail_if_no_rule_description->[hasMessage,done,createRepository,setName,fail],fail_if_duplicated_rule_param_keys->[createParam,createRule,hasMessage,fail],define_rule_parameter_with_empty_de... | Checks if duplicate rule keys are declared multiple times on the rule. | @julienlancelot and I find it a better practice to declare the expectedException right before the statement supposed to throw it It avoids catching an exception raised by another statement and not have a test failure when we should and it's also better for readability of the UT (it shows where the exception is expected... |
@@ -1,7 +1,7 @@
// Copyright 2015 Keybase, Inc. All rights reserved. Use of
// this source code is governed by the included BSD license.
-// +build !darwin,!windows
+// +build !darwin,!windows ios
package install
| [No CFG could be retrieved] | KeybaseFuseStatus returns a FuseStatus object for the given bundle version. | Is this file related to the build break, or did it sneak into the commit? |
@@ -176,7 +176,17 @@ class RemoteRepository:
if version != RPC_PROTOCOL_VERSION:
raise Exception('Server insisted on using unsupported protocol version %d' % version)
try:
- self.id = self.call('open', self.location.path, create, lock_wait, lock)
+ # Because of proto... | [cache_if_remote->[RepositoryNoCache,RepositoryCache],RemoteRepository->[destroy->[call],delete->[call],break_lock->[call],__len__->[call],load_key->[call],save_key->[call],commit->[call],get_many->[call_many],call_many->[handle_error->[InvalidRPCMethod,PathNotAllowed,RPCError],ConnectionClosed,fetch_from_cache,handle_... | Initialize a new object with a specific location. This method is called when a node is not found in the repository. | Just `raise` is enough - it will re-raise the currently handled exception (here in `err`) if no exception is specified. You can also leave the else: away if you like, since the if: block raises, when executed. |
@@ -2698,7 +2698,7 @@ use \Friendica\Core\Config;
$closed = (($a->config['register_policy'] == REGISTER_CLOSED) ? 'true' : 'false');
$private = ((Config::get('system', 'block_public')) ? 'true' : 'false');
$textlimit = (string) (($a->config['max_import_size']) ? $a->config['max_import_size'] : 200000);
- if($... | [api_oauth_access_token->[fetch_access_token,getMessage],api_oauth_request_token->[fetch_request_token,getMessage],api_friendica_notification->[getAll],api_error->[getMessage],api_friendica_notification_seen->[getByID,setSeen],api_statusnet_config->[get_hostname],api_statuses_mediap->[purify,set],api_statuses_update->[... | API Statusnet Config N_PROTOCOL_VERSION n_protocol_version n_protocol_version n_protocol. | Standards: Please add braces to this condition. |
@@ -41,9 +41,8 @@ def get_keys_dir():
"""Determine where to repository keys and cache"""
keys_dir = os.environ.get('BORG_KEYS_DIR', os.path.join(get_config_dir(), 'keys'))
- if not os.path.exists(keys_dir):
- os.makedirs(keys_dir)
- os.chmod(keys_dir, stat.S_IRWXU)
+ if ensure_dir(keys_d... | [os_open->[O_],get_cache_dir->[get_base_dir],get_config_dir->[get_base_dir],dir_is_tagged->[dir_is_cachedir],O_] | Get the keys directory and cache directory. | guess the logging is not needed. if it did not raise an exception it had worked. unix tools are usually silent if "it worked". |
@@ -12,14 +12,13 @@ from azure.core.configuration import Configuration
from azure.core.pipeline import policies
from azure.mgmt.core.policies import ARMHttpLoggingPolicy
-from ._version import VERSION
-
if TYPE_CHECKING:
# pylint: disable=unused-import,ungrouped-imports
from typing import Any
from... | [ApiManagementClientConfiguration->[__init__->[pop,setdefault,super,ValueError,format,_configure],_configure->[UserAgentPolicy,ProxyPolicy,get,BearerTokenCredentialPolicy,RetryPolicy,HeadersPolicy,ARMHttpLoggingPolicy,RedirectPolicy,CustomHookPolicy,NetworkTraceLoggingPolicy]]] | Creates an instance of the ApiManagementClient class. | Need add package_version back in readme.python.md so that `VERSION` is not `unknown`. |
@@ -983,7 +983,7 @@ namespace System.Net.Http
while (buffer.Length != 0)
{
// Sync over async here -- QUIC implementation does it per-I/O already; this is at least more coarse-grained.
- if (_responseDataPayloadRemaining <= 0 && !ReadNextDataFram... | [Http3RequestStream->[ReadNextDataFrameAsync->[CopyTrailersToResponseMessage],DisposeSyncHelper->[Dispose],OnHeader->[OnHeader],Http3ReadStream->[Read->[ReadResponseContent],Dispose->[Dispose],ReadAsync->[ReadResponseContentAsync,Task],Dispose],Trace->[Trace],Http3WriteStream->[Dispose->[Dispose]],ReadFrameEnvelopeAsyn... | Reads the response content into the buffer. | What makes the original incorrect? |
@@ -130,6 +130,8 @@ define([
}
this._viewerRequestVolume = viewerRequestVolume;
+ this._commandsLength = 0;
+
/**
* The error, in meters, introduced if this tile is rendered and its children are not.
* This is used to compute Screen-Space Error (SSE), i.e., the er... | [No CFG could be retrieved] | The computed transform of the . A list of objects that are this tile s children. | This should have a readonly property getter. Up to you, but this and the other "length" properties for rendering debugging output could be prefixed like `_debugCommandsLength` |
@@ -25,4 +25,7 @@ class OrderErrorCode(Enum):
class InvoiceErrorCode(Enum):
+ EMPTY_URL = "empty_url"
+ EMPTY_NUMBER = "empty_number"
URL_OR_NUMBER_NOT_SET = "url_or_number_not_set"
+ NOT_FOUND = "not_found"
| [No CFG could be retrieved] | The error code for an invoice. | In other mutations we use `REQUIRED = "required" code in cases when a field is required. Then we don't have to create an error code per field - information about which input param is related to the error is available in `field`. |
@@ -1,13 +1,12 @@
namespace NServiceBus.InMemory.Outbox
{
using System;
- using Configuration.AdvancedExtensibility;
- using Features;
using NServiceBus.Outbox;
/// <summary>
/// Contains InMemoryOutbox-related settings extensions.
/// </summary>
+ [ObsoleteEx(Message = "!!!", Trea... | [InMemoryOutboxSettingsExtensions->[OutboxSettings->[Set,AgainstNegativeAndZero,TimeToKeepDeduplicationEntries,nameof]]] | Flags that control how long the outbox should keep message data in storage and how long the. | Move this class to obsoletes.cs |
@@ -89,10 +89,16 @@ class AioHttpTransport(AsyncHttpTransport):
loop=self._loop,
trust_env=self._use_env_settings,
cookie_jar=jar,
+ )
+ self._non_decompress_session = aiohttp.ClientSession(
+ loop=self._loop,
+ trust... | [AioHttpTransportResponse->[stream_download->[AioHttpStreamDownloadGenerator],__getstate__->[body]],AioHttpTransport->[close->[close],send->[_build_ssl_config,_get_request_data,open],open->[__aenter__]],AioHttpStreamDownloadGenerator->[__anext__->[close]]] | Opens the connection. | We have to maintain separate sessions? Why did the tests not catch this earlier? |
@@ -55,6 +55,12 @@ RSpec.configure do |config|
VendorValidatorJob.perform_now(*args)
end
end
+
+ config.around(:each, user_flow: true) do |example|
+ Capybara.current_driver = :rack_test
+ example.run
+ Capybara.use_default_driver
+ end
end
Sidekiq::Testing.inline!
| [server_middleware,configure,calls,infer_spec_type_from_file_location!,to,before,require,load_seed,include,use_transactional_fixtures,receive,each,locale,messages,perform_now,inline!,add,maintain_test_schema!,and_return,expand_path] | Initialize the middleware chain. | this is the opposite of our `js: true` -- don't some of our user flow tests use JS? |
@@ -0,0 +1,10 @@
+import unittest
+
+from certbot.compat import os
+
+
+class OsTest(unittest.TestCase):
+ """Unit tests for os module."""
+ def test_forbidden_methods(self):
+ for method in ['chmod']:
+ self.assertRaises(RuntimeError, getattr(os, method))
| [No CFG could be retrieved] | No Summary Found. | Can we add the usual `if __name__ == "__main__"` here? |
@@ -39,6 +39,9 @@ function initPlayer(data) {
container: '#c',
desiredOffset: 50,
gid: data.gid,
+ onError: () => {
+ window.context.noContentAvailable();
+ },
};
// eslint-disable-next-line no-undef
SeedrPlayer(config);
| [No CFG could be retrieved] | Seed the object with the current data. | please pass down the `window` from caller (`global`) |
@@ -207,6 +207,13 @@ class ContentUploadManager(object):
try:
result = importer_instance.upload_unit(transfer_repo, unit_type_id, unit_key,
unit_metadata, file_path, conduit, call_config)
+ if not result['success_flag']:
+ ... | [ContentUploadManager->[import_uploaded_unit->[is_valid_upload]]] | Import an uploaded unit into the repository. Upload a single uploaded unit to the repository. | Unfortunately, I noticed that at least one plugin (`pulp_docker`) does not return a dictionary as it should. It return `None`. That's been ok so far, because nothing has ever checked the value of `result` here or down the stack. One option is to just fix pulp_docker, and check the other plugins to make sure they return... |
@@ -48,6 +48,7 @@ from pip._internal.vcs import vcs
try:
import ssl # noqa
+
HAS_TLS = True
except ImportError:
HAS_TLS = False
| [PipSession->[__init__->[MultiDomainBasicAuth,SafeFileCache,InsecureHTTPAdapter,LocalFSAdapter,user_agent]],_download_url->[resp_read,written_chunks],PipXmlrpcTransport->[__init__->[__init__]],_download_http_url->[_download_url,get],is_vcs_url->[_get_used_vcs_backend],unpack_http_url->[_copy_file],unpack_file_url->[is_... | Get a single object from the network. Return a string representing the user agent. | These newline changes seem unrelated... Could you remove them or is there some reason I'm not seeing? |
@@ -2,11 +2,13 @@ module AssignmentsHelper
def add_assignment_file_link(name, form)
link_to_function name do |page|
- assignment_file = render(partial: 'assignment_file', locals: {form: form, assignment_file: AssignmentFile.new})
+ assignment_file = render(partial: 'assignment_file', locals: {form... | [add_penalty_period_link->[new,render,link_to_function,escape_javascript,t],add_penalty_decay_period_link->[new,render,link_to_function,escape_javascript,t],add_assignment_file_link->[escape_javascript,new,render,link_to_function],add_grace_period_link->[new,render,link_to_function,escape_javascript,t]] | Adds a link to the assignment file and grace period of a submission rule. | Line is too long. [119/80]<br>Use 2 (not 4) spaces for indentation.<br>Space inside { missing.<br>Space inside } missing. |
@@ -747,6 +747,9 @@ vdev_queue_io(zio_t *zio)
vdev_queue_t *vq = &zio->io_vd->vdev_queue;
zio_t *nio;
+ if (!zio->io_timestamp)
+ zio->io_timestamp = gethrtime();
+
if (zio->io_flags & ZIO_FLAG_DONT_QUEUE)
return (zio);
| [No CFG could be retrieved] | finds the first matching object in the vdev queue and then finds the first object in ZIO - related functions. | this should probably be explicit about checking for zero: `if (zio->io_timestamp == 0)` |
@@ -62,7 +62,7 @@ const commonFiles = {
],
},
{
- condition: generator => generator.enableI18nRTL,
+ condition: generator => generator.enableI18nRTL && !generator.clientFrameworkReact,
path: CLIENT_MAIN_SRC_DIR,
templates: ['content/scss/rtl.scss'],
},
| [No CFG could be retrieved] | Package common files. | Why do we skip this? Is it all handled by the post-rtlcss plugin now? |
@@ -40,9 +40,9 @@ class CommentController < ApplicationController
end
if authenticated?(
- :web => _("To post your annotation"),
- :email => _("Then your annotation to {{info_request_title}} will be posted.",:info_request_title=>@info_request.title),
- :email_subject => _("Confirm your ... | [CommentController->[new->[new],handle_spam_comment->[block_spam_comments?,new]]] | Creates a new object. if the user is logged in and there is no other object in the transaction add a comment. | Use the new Ruby 1.9 hash syntax.<br>Space missing after comma.<br>Line is too long. [119/80] |
@@ -75,6 +75,10 @@ const strings = {
'Label for a button that allows the user to change their ' +
'choice to consent to providing their cookie access.',
},
+ [LocalizedStringId.AMP_STORY_CLOSE_BUTTON_LABEL]: {
+ string: 'Close',
+ description: 'Label for a button that closes the story after they... | [No CFG could be retrieved] | Possible values for AMPStoryTitle and AMPStoryFooterTitle are the labels A dialog that shows the user the domain from which the story is served. | Nit: translators might not know what a story is. It's worth adding context here, communicating the fact that users open a full page experience and that clicking here will close it and go back to where they were originally |
@@ -1362,7 +1362,12 @@ LOGGING = {
},
'z': {
'handlers': ['mozlog'],
- 'level': logging.DEBUG,
+ 'level': logging.INFO,
+ 'propagate': False
+ },
+ 'z.addons': {
+ 'handlers': ['mozlog'],
+ 'level': logging.INFO,
... | [path->[join],get_raven_release->[fetch_git_sha,get,read,join,exists,open,loads],read_only_mode->[get,Exception],get_db_config->[update,db],,gethostname,join,env,dict,Env,r'^,bool,list,datetime,dirname,format,items,exists,float,read_env,Queue,path,keys,get,get_db_config,get_raven_release,lower] | A dictionary of logging. Messages that can be logged by Django s security. CSRF. A dictionary of all the configuration options that define a single object. | I suppose this is the default config now (inherited from `root`) so we could probably remove this entry. |
@@ -35,8 +35,8 @@ async function getListing(rootPath, basepath) {
}
try {
- if ((await fs.statAsync(path)).isDirectory()) {
- return fs.readdirAsync(path);
+ if (fs.statSync(path).isDirectory()) {
+ return fs.promises.readdir(path);
}
} catch (unusedE) {
/* empty catch for fallbacks... | [No CFG could be retrieved] | - - - - - - - - - - - - - - - - - -. | So this is an `async` function that returns a `Promise`? Making its return type `Promise<Promise<string>>`? |
@@ -100,10 +100,9 @@ func RUMV3Processor(cfg *config.Config) *Processor {
}
}
-func (p *Processor) readMetadata(metadata *model.Metadata, reader *streamReader) error {
- var rawModel map[string]interface{}
- err := reader.Read(&rawModel)
- if err != nil {
+func (p *Processor) readMetadata(reader *streamReader, met... | [HandleStream->[readMetadata,readBatch],readBatch->[HandleRawModel]] | readMetadata reads the next block of metadata from the stream and populates the given metadata object. | Nit: could you please move this below readBatch, where it's used? |
@@ -105,8 +105,10 @@ export class ShareMenu {
this.isBuilt_ = true;
+ this.ampdoc_ = getAmpdoc(this.parentEl_);
+
this.isSystemShareSupported_ = this.shareWidget_.isSystemShareSupported(
- getAmpdoc(this.parentEl_)
+ this.ampdoc_
);
this.isSystemShareSupported_
| [No CFG could be retrieved] | Initializes the components. Private methods for handling the AMPSocialSystemShareTemplate. | Nit: I think it'd be better to keep doing `getAmpDoc()` from `buildForSystemSharing_()`, we never know how the code will evolve and it's hard to rely on the fact that a method runs before another one. Line `141` is already calling `getAmpDoc()` so I think we should just re-use this. |
@@ -221,6 +221,12 @@ def options(func: Callable) -> Callable:
show_default=True,
type=click.FloatRange(min=0.1),
),
+ option(
+ "--claims-file-path",
+ type=click.Path(exists=True, dir_okay=False, resolve_path=True),
+ help="Path to a claims fil... | [smoketest->[append_report],run->[write_stack_trace]] | Decorator to add common options to a command. Options for the Raiden network. Add options for the given group. Register options for the path finding service. Options for raiden debug. Save a stack of n - ary tokens to a file. | Hm yeah good question. Probably removing the default is better. |
@@ -41,6 +41,8 @@ public interface RealtimeSplit extends InputSplitWithLocationInfo {
*/
List<String> getDeltaLogPaths();
+ List<FileStatus> getDeltaLogFileStatus();
+
/**
* Return Max Instant Time.
* @return
| [readFromInput->[setHoodieVirtualKeyInfo,setBasePath,setMaxCommitTime,setDeltaLogPaths],writeToOutput->[getBasePath,getDeltaLogPaths,getMaxCommitTime]] | Get the list of log paths that should be included in the delta log. | Since FileStatus already includes the path, do we still need this API? If not, maybe we can take it up as a follow up task as removing it might require some more testing. |
@@ -378,7 +378,7 @@ public class PAssertTest implements Serializable {
+ " but the message was \""
+ exc.getMessage()
+ "\"",
- expectedPattern.matcher(exc.getMessage()).find());
+ expectedPattern.matcher(Throwables.getStackTraceAsString(exc)).find());
}
@Tes... | [PAssertTest->[testWindowedIsEqualTo->[of,apply],testNotEqualTo->[of,apply],testGlobalWindowContainsInAnyOrder->[of,apply],testContainsInAnyOrderNotSerializable->[of,NotSerializableObject],testWindowedContainsInAnyOrder->[apply],testIsEqualTo->[of,apply],testContainsInAnyOrderFalse->[of,apply],NotSerializableObjectCode... | Checks if the pipeline contains any element in any order. | Can this be tightened? I'd like for the case where I don't provide an auxiliary message to be unchanged, and for the new case to have the detailed cause immediately nested. |
@@ -856,6 +856,11 @@ def events_from_annotations(raw, event_id=None, regexp=None, use_rounding=True,
annotations = raw.annotations
+ if event_id == 'auto' and hasattr(raw, 'auto_event_id'):
+ event_id = raw.auto_event_id()
+ else:
+ event_id = None
+
event_sel, event_id_ = _select_anno... | [_combine_annotations->[Annotations],_annotations_starts_stops->[_sync_onset],Annotations->[delete->[delete],__getitem__->[Annotations],append->[append,_check_o_d_s],__init__->[_check_o_d_s]],_read_annotations_txt_parse_header->[_is_iso8601,_handle_meas_date,is_orig_time],_sync_onset->[_handle_meas_date],_read_annotati... | Get events and event_id from a Annotations object. description - description of events in chunk_duration - chunk_onset - chunk_duration. | It would be good to make this private rather than public as `_auto_event_id` |
@@ -14,6 +14,17 @@ import (
. "github.com/onsi/gomega"
)
+var unknownKindYAML = `
+apiVerson: v1
+kind: UnknownKind
+metadata:
+ labels:
+ app: app1
+ name: unknown
+spec:
+ hostname: unknown
+`
+
var yamlTemplate = `
apiVersion: v1
kind: Pod
| [InspectImageJSON,Close,Podman,Exit,WriteFile,WaitWithDefaultTimeout,CreateSeccompJson,New,To,SeedImages,InspectContainerToJSON,Create,Join,Execute,Cleanup,ExitCode,Remove,Base,Println,OutputToString,Parse,Setup] | - config version 1. 0 - config version 1. 0 - config version 1. 0 generateKubeYaml generates a kube yaml file with the specified options. | nit: I would probably change this to `podYAMLTemplate` now |
@@ -1170,6 +1170,7 @@ static int dmic_set_config(struct dai *dai, struct sof_ipc_dai_config *config)
switch (dmic_prm[di]->fifo_bits) {
case 0:
case 16:
+ case 24:
case 32:
break;
default:
| [int->[OUT_GAIN_LEFT_A_GAIN,interrupt_unmask,find_min_int16,trace_dmic_error,MIC_CONTROL_CLK_EDGE,interrupt_disable,ipm_helper2,OUTCONTROL1_IPM,DC_OFFSET_LEFT_B_DC_OFFS,OUTCONTROL1_OF,FIR_COEF_B,MIC_CONTROL_PDM_EN_B,CIC_CONTROL_STEREO_MODE,interrupt_get_irq,pm_runtime_get_sync,OUTCONTROL1_IPM_SOURCE_1,memcpy_s,fir_coef... | Set dmic configuration DMI controller specific functions DMI controller configuration This function is called from dmic_set_config. It finds the optimal decim This function is called to configure the HW registers in the system. | Just curious, and can be fixed late if needed, but why is 0 treated in the switch alongside supported and valid formats ? |
@@ -207,7 +207,8 @@ def model_iteration(model,
val_samples_or_steps = validation_steps
else:
# Get num samples for printing.
- val_samples_or_steps = val_inputs and val_inputs[0].shape[0] or None
+ vals = val_inputs.values() if isinstance(val_inputs, dict) else val_inputs
+ val_samples_or_steps = ... | [_prepare_feed_values->[get_distributed_inputs->[_prepare_feed_values],get_distributed_inputs],_make_execution_function->[_make_execution_function],model_iteration->[model_iteration]] | Loop function for arrays of data with modes TRAIN and TEST. A function to perform validation on a sequence of data. user_data and set reset_dataset_after_each_epoch as an anc Get the step function and the validation data for a single node - level . | probably skip the dict check and use nest.flatten(vals)[0].shape[0] here. |
@@ -41,6 +41,7 @@ type config struct {
HarvesterLimit uint32 `config:"harvester_limit" validate:"min=0"`
IgnoreOlder time.Duration `config:"ignore_older"`
IgnoreInactive ignoreInactiveType `config:"ignore_inactive"`
+ Rotation *common.ConfigNamespace `config:"rotation"`
}... | [Validate->[Errorf]] | TYPE IS DEPRECATED. Config for a N - tuple of n - tuple of lines. | we might want to find another name here. `rotation` suggests that the input is capable of rotating the file by itself. |
@@ -152,6 +152,17 @@ def target_init(transfer: LockedTransfer):
return init_target_statechange
+class PaymentType(enum.Enum):
+ DIRECT = 1
+ MEDIATED = 2
+
+
+class PaymentStatus(typing.NamedTuple):
+ payment_type: PaymentType
+ payment_identifier: typing.PaymentID
+ payment_done: AsyncResult
+
... | [RaidenService->[_callback_new_block->[handle_state_change],handle_state_change->[_redact_secret],stop->[stop],start->[start],mediate_mediated_transfer->[mediator_init,handle_state_change],sign->[sign],target_mediated_transfer->[target_init,start_health_check_for,handle_state_change],close_and_settle->[leave_all_token_... | Initialize a new object with the given parameters. Initialize the lock file and lock file. | Perhaps add a short docstring for this named tuple? |
@@ -1086,6 +1086,13 @@ const adConfig = jsonConfiguration({
'seedingalliance': {},
+ 'seedtag': {
+ prefetch: 'https://config.seedtag.com/omid/bridge/bridge.js',
+ preconnect: ['https://s.seedtag.com'],
+ consentHandlingOverride: true,
+ renderStartImplemented: true,
+ },
+
'sekindo': {
ren... | [No CFG could be retrieved] | Provides a list of urls to preload and preload a list of urls to preload and preload a Provides a list of urls to the AMP API. | did you mean to add this? |
@@ -101,7 +101,7 @@ namespace Content.Server.GameObjects.Components.MachineLinking
{
base.Shutdown();
- foreach (var transmitter in _transmitters)
+ foreach (var transmitter in _transmitters.ShallowClone())
{
if (transmitter.Deleted)
... | [SignalReceiverComponent->[Interact->[Subscribe,Unsubscribe],Subscribe->[Subscribe],Initialize->[Initialize],Unsubscribe->[Unsubscribe],InteractUsing->[Interact],Shutdown->[Shutdown,Unsubscribe]]] | Shutdown method. | Just traverse backwards instead of cloning |
@@ -93,6 +93,11 @@ Rails.application.routes.draw do
get '/account/verify_phone' => 'users/verify_profile_phone#index', as: :verify_profile_phone
post '/account/verify_phone' => 'users/verify_profile_phone#create'
+ if FeatureManagement.piv_cac_enabled?
+ get '/piv_cac' => 'users/piv_cac_authenticati... | [new,redirect,devise_scope,mount,join,put,draw,root,scope,post,require,enable_usps_verification?,enable_identity_verification?,rotation_path_suffix,enable_saml_cert_rotation?,patch,devise_for,match,delete,namespace,get,enable_test_routes] | Non - devise - controller routes. Route to update phone settings. | It looks like the `new` action does more than just show a page to the user. It also makes changes to the user. Per our pull request checklist, we should not use a GET request for actions that change the user's state. |
@@ -432,11 +432,8 @@ void VtkOutput::WriteConditionResultsToFile(const ModelPart& rModelPart, std::of
const auto& r_local_mesh = rModelPart.GetCommunicator().LocalMesh();
Parameters condition_results = mOutputSettings["condition_data_value_variables"];
- int num_elements = static_cast<int>(r_local_mesh.N... | [WriteModelPartWithoutNodesToFile->[WriteModelPartToFile],PrintOutput->[PrepareGaussPointResults]] | Write condition results to file. | just wondering if it would not make sense to have a usigned int version of this |
@@ -360,12 +360,12 @@ ds_pool_lookup_create(const uuid_t uuid, struct ds_pool_create_arg *arg,
ABT_mutex_unlock(pool_cache_lock);
if (rc != 0) {
if (arg == NULL && rc == -DER_NONEXIST)
- D_DEBUG(DF_DSMS, DF_UUID": pure lookup failed: %d\n",
- DP_UUID(uuid), rc);
+ D_DEBUG(DF_DSMS, DF_UUID": pure lookup fa... | [No CFG could be retrieved] | finds the next object in the list of objects that can be deleted The following methods are defined in the spec. | (style) line over 80 characters |
@@ -63,7 +63,13 @@ def test_locale_middleware_picker(accept_language, locale, client, db):
def test_locale_middleware_fixer(original, fixed, client, db):
'''The LocaleStandardizerMiddleware redirects non-standard locale URLs.'''
response = client.get('/%s/' % original)
- assert response.status_code == 302... | [test_locale_middleware_fixer->[get,assert_shared_cache_header],test_locale_middleware_legacy_404s->[get],test_lang_selector_middleware->[get,load,assert_shared_cache_header],test_locale_middleware_picker->[get,assert_shared_cache_header],test_lang_selector_middleware_no_change->[get,assert_shared_cache_header],test_lo... | Test locale middleware fixes. | So we are testing the URL `//`? WEIRD |
@@ -373,6 +373,11 @@ public class StandardProcessGroupDAO extends ComponentDAO implements ProcessGrou
if (flowFileOutboundPolicy != null) {
group.setFlowFileOutboundPolicy(flowFileOutboundPolicy);
}
+
+ group.setDefaultFlowFileExpiration(processGroupDTO.getDefaultFlowFileExpiration... | [StandardProcessGroupDAO->[getProcessGroups->[getProcessGroups],enableComponents->[findConnectable],createProcessGroup->[createProcessGroup],scheduleComponents->[findConnectable],findConnectable->[findConnectable,getProcessGroup],disconnectVersionControl->[disconnectVersionControl]]] | Updates a ProcessGroup with the given data. Locate a process group and add it to the version control information. | When the position is changed, all other fields in the DTO are null. When `getDefaultFlowFileExpiration()` is null, `setDefaultFlowFileExpiration()` sets the system default. These method calls should check for null like the code right above it, and not call `set` if the value is null (but leave the defensive code in Sta... |
@@ -39,6 +39,7 @@ public class EventhubBatch extends Batch<JsonObject>{
private final long creationTimestamp;
private final long memSizeLimit;
private final long ttlInMilliSeconds;
+ public static final int overheadSizeInByte = 15;
public EventhubBatch (long memSizeLimit, long ttlInMilliSeconds) {
t... | [EventhubBatch->[getRecords->[getRecords],append->[append],hasRoom->[hasRoom],getCurrentSizeInByte->[getByteSize]]] | Creates an EventhubBatch which saves records in the given memory limit and TTL. Returns true if the record is not null and has enough memory to hold the record. | `static final` variables should have names in all caps `OVERHEAD_SIZE_IN_BYTES` |
@@ -0,0 +1,11 @@
+using System;
+namespace Content.Server.GameObjects.Components.Mobs.Body
+{
+ public class Human : BodyTemplate
+ {
+ public override void Life(float frameTime)
+ {
+ base.Life(frameTime);
+ }
+ }
+}
| [No CFG could be retrieved] | No Summary Found. | You can probably remove this. |
@@ -94,6 +94,8 @@ import (
"k8s.io/kubernetes/pkg/util/rlimit"
"k8s.io/kubernetes/pkg/version"
"k8s.io/kubernetes/pkg/version/verflag"
+
+ "github.com/openshift/origin/pkg/cmd/server/origin"
)
const (
| [OutOrStdout,NewContainerManager,ApplyOOMScoreAdj,NewForConfig,SetNormalizeFunc,JoinHostPort,NewMainKubelet,WriteKey,StartLogging,Info,Events,Acquire,Done,CurrentNodeName,Itoa,StartRecordingToSink,NewChaosRoundTripper,New,Usage,UTC,ValidateKubeletFlags,BoolP,LoadClientCert,NewBroadcaster,Infof,UpdateTransport,SetFromMa... | This module is used to provide a list of possible components that are not available in the cluster NewKubeletCommand creates a new command object that can be used to run a node agent on. | You can't have this dependency. kube depending on origin will make a cycle we can't reasonably resolve during a rebase. |
@@ -626,7 +626,7 @@ int req_main(int argc, char **argv)
" Your key size is %ld! Larger key size may behave not as expected.\n",
OPENSSL_RSA_MAX_MODULUS_BITS, newkey);
-#ifndef OPENSSL_NO_DSA
+#if !defined(OPENSSL_NO_DSA) || !defined(OPENSSL_NO_DEPRECATED_3_0)
... | [No CFG could be retrieved] | Load the private key from the specified file. Generate a private key. Larger key size may be not as expected. | Why is this change needed? |
@@ -182,10 +182,11 @@ class Config(ABC):
class _ConfigValues(ABC):
"""Encapsulates resolving the actual config values specified by the user's config file.
- Beyond providing better encapsulation, this allows us to support alternative config file formats
- in the future if we ever decide to support formats other... | [_IniValues->[get_value->[get],sections->[sections],defaults->[defaults],has_option->[has_option],options->[options],has_section->[has_section]],_ChainedConfig->[get_source_for_option->[get_source_for_option,has_option],get_value->[has_section,get_value],sections->[sections],sources->[sources],has_option->[has_option],... | Returns the sections in this config. | Futureproofing that actually worked! Wooho! |
@@ -1829,3 +1829,7 @@ func FormatProdFQDNByLocation(fqdnPrefix string, location string, cloudName stri
FQDNFormat := AzureCloudSpecEnvMap[targetEnv].EndpointConfig.ResourceManagerVMDNSSuffix
return fmt.Sprintf("%s.%s."+FQDNFormat, fqdnPrefix, location)
}
+
+func (p *Properties) isKubernetesAndNotAzureStack() bool ... | [GetCustomEnvironmentJSON->[IsAzureStackCloud],HasAvailabilityZones->[HasAvailabilityZones],GetUserAssignedID->[UserAssignedIDEnabled],IsMetricsServerEnabled->[isAddonEnabled],GetFirstConsecutiveStaticIPAddress->[IsVirtualMachineScaleSets],IsUbuntu->[IsUbuntu1804,IsUbuntu1604],IsPrivateCluster->[IsKubernetes],GetUserAs... | FQDNFormat - the FQDN prefix for the resource manager. | I assume this is already unit tested through the other functions' unit tests? |
@@ -47,8 +47,8 @@ func newTableManagerMetrics(r prometheus.Registerer) *tableManagerMetrics {
m.tableCapacity = prometheus.NewGaugeVec(prometheus.GaugeOpts{
Namespace: "cortex",
- Name: "dynamo_table_capacity_units",
- Help: "Per-table DynamoDB capacity, measured in DynamoDB capacity units.",
+ Name... | [partitionTables->[HasPrefix,ListTables],UnmarshalYAML->[Duration],deleteTables->[DeleteTable,Log,Err,Info,Set,Add],createTables->[CreateTable,Log,Err,Info,Set,Add],SyncTables->[partitionTables,deleteTables,createTables,calculateExpectedTables,SetToCurrentTime,Log,updateTables,Info],Validate->[Duration],bucketRetention... | newTableManagerMetrics returns a new tableManagerMetrics instance with all the metrics for a given TableManagerSync returns a config for a table manager. | We discussed this in #2307, it is actually dynamodb specific. |
@@ -561,7 +561,11 @@ angular.module('zeppelinWebApp')
if (isNaN(timeMs) || timeMs < 0) {
return ' ';
}
- return 'Took ' + (timeMs/1000) + ' seconds';
+ var desc = 'Took ' + (timeMs/1000) + ' seconds.';
+ if (pdata.textSaved !==undefined && Date.parse(pdata.textSaved) > Date.parse(pdata.da... | [No CFG could be retrieved] | Adds key bindings to the command scope. on show . | in this flow, should it show the (outdated) text even if it has never been run (ie. timeMs NaN or 0)? because it is returning above at line 567 |
@@ -130,6 +130,18 @@ func initIntegrationTest() {
if _, err = db.Exec("CREATE DATABASE testgitea"); err != nil {
log.Fatalf("db.Exec: %v", err)
}
+ case setting.UseMSSQL:
+ host, port := models.ParseMSSQLHostPort(models.DbCfg.Host)
+ db, err := sql.Open("mssql", fmt.Sprintf("server=%s; port=%s; database=%s;... | [MakeRequest->[Join,SetCookies,AddCookie,NoError,Parse,Cookies,Add],GetCookie->[Parse,Cookies],RemoveAll,Dir,Exec,NewRequest,Find,Close,CopyDir,Encode,Exit,Add,Stat,NewBufferString,Marshal,ServeHTTP,SetCookies,New,InitFixtures,NewRecorder,Cookies,NewMacaron,Bytes,IsAbs,Text,NewBuffer,EqualValues,Join,LoadFixtures,NewDo... | prepareTestEnv creates a test environment for the given environment. GetCookie returns a cookie with the given name. | The `defer` should be after the err check because db maybe nil before that. And the above databases code also have the problem. |
@@ -148,15 +148,16 @@ public class HttpSnoopServerHandler extends SimpleChannelInboundHandler<Object>
// Decide whether to close the connection or not.
boolean keepAlive = HttpUtil.isKeepAlive(request);
// Build the response object.
+ final byte[] bytes = buf.toString().getBytes(UTF_8)... | [HttpSnoopServerHandler->[appendDecoderResult->[append,isSuccess,cause,decoderResult],channelReadComplete->[flush],messageReceived->[getValue,parameters,appendDecoderResult,setLength,toString,writeResponse,QueryStringDecoder,headers,getAll,send100Continue,getKey,isEmpty,uri,append,content,entrySet,is100ContinueExpected... | Write the response. | nit: Why not directly write via `writeCharSequence` ? This way you will remove one allocation |
@@ -70,6 +70,12 @@ type UpdateMetadata struct {
Environment map[string]string `json:"environment"`
}
+// LocalPolicyPack contains information about the locally specified Policy Packs ran with
+// an update.
+type LocalPolicyPack struct {
+ Path string `json:"path"`
+}
+
// UpdateProgramResponse is the result of a... | [No CFG could be retrieved] | UpdateOptions is the options for a single lease token. strin g strin g strin g strin g strin g strin g. | Maybe include a note about the path being potentially truncated? |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.