patch stringlengths 18 160k | callgraph stringlengths 4 179k | summary stringlengths 4 947 | msg stringlengths 6 3.42k |
|---|---|---|---|
@@ -64,6 +64,11 @@ func (c *ClientStopConfig) Stop(out io.Writer) error {
return err
}
helper := dockerhelper.NewHelper(client, nil)
+ glog.V(4).Infof("Killing previous socat tunnel")
+ err = openshift.KillExistingSocat()
+ if err != nil {
+ glog.V(1).Infof("error: cannot kill socat: %v", err)
+ }
glog.V(4).I... | [Stop->[Infof,ListContainerNames,ParseDockerName,StopContainer,RemoveContainer,V,getDockerClient,StopAndRemoveContainer,TrimLeft,NewHelper],getDockerClient->[ErrNoDockerClient,GetClient,NewHelper],StringVar,Stop,Sprintf,CheckErr,Flags] | Stop stops all containers in the cluster. | should we abort at this point instead of continuing/eating the error? |
@@ -8,11 +8,17 @@ import (
"github.com/pachyderm/pachyderm/v2/src/internal/pachhash"
)
-var (
+const (
// ChunkSize is the size of file chunks when resumable upload is used
ChunkSize = int64(512 * 1024 * 1024) // 512 MB
// EmptyStr is included in the description of output commits from failed jobs.
EmptyStr... | [FullID->[Sprintf],EncodeToString,New,DecodeString] | FullID returns the full ID of the commit. | Given the PFS-wide nature of these consts, I think the names should indicate that this is specifically a repo type, so maybe `UserRepoType`, etc? |
@@ -43,6 +43,13 @@ type ContainerBasicConfig struct {
// image's configuration.
// Optional.
Command []string `json:"command,omitempty"`
+ // EnvHost indicates that the host environment should be added to container
+ // Optional.
+ EnvHost bool `json:"env_host,omitempty"`
+ // EnvHTTPProxy indicates that the http... | [New] | Config is a set of basic parts of a container. StopTimeout is a timeout between the container s stop signal and SIGKILL being sent. | Why are we sourcing this from the server, instead of the host? This doesn't make sense, IMO |
@@ -1293,4 +1293,4 @@ class CI_Loader {
}
/* End of file Loader.php */
-/* Location: ./system/core/Loader.php */
\ No newline at end of file
+/* Location: ./system/core/Loader.php */
| [CI_Loader->[dbutil->[database],_ci_load_class->[_ci_load_class],library->[library],dbforge->[database],_ci_autoloader->[database,library,model,driver,add_package_path],model->[model],helpers->[helper],driver->[driver,library]]] | End of file Loader. php. | Could you remove this empty line? |
@@ -5,6 +5,17 @@ import (
"github.com/elastic/beats/libbeat/beat"
"github.com/elastic/beats/packetbeat/beater"
+
+ // import support protocol modules
+ _ "github.com/elastic/beats/packetbeat/protos/amqp"
+ _ "github.com/elastic/beats/packetbeat/protos/dns"
+ _ "github.com/elastic/beats/packetbeat/protos/http"
+ _... | [Exit,Run,New] | main import imports the and runs it. | We should automate this in the future. Also on my list for metricbeat, so perhaps we will be able to use the same script. |
@@ -337,14 +337,13 @@ void LocalExec(const ExecConfig *config)
free(line);
cf_pclose(pp);
- Log(LOG_LEVEL_DEBUG, "Closing fp");
- fclose(fp);
-
Log(LOG_LEVEL_VERBOSE,
complete ? "Command is complete" : "Terminated command");
if (count)
{
+ Log(LOG_LEVEL_DEBUG, "Closing... | [bool->[TwinFilename,xmalloc,ThreadUnlock,unlink,ThreadLock,pcre_compile,pcre_exec,recv,strlen,GetErrorStr,IsExecutable,LinkOrCopy,pcre_study,pcre_free,GetWorkDir,select,stat,SeqAt,strstr,UnexpectedError,FD_ZERO,strcmp,FD_ISSET,Log,free,send,LineIsFiltered,fclose,SeqLength,FD_SET,CfReadLine,safe_fopen,snprintf,StringMa... | This function is called by CF daemon when it is not available. Reads the command line from the agent and returns it. if line is entirely blank and not null send mail to syslog if not send mail. | Why is this moved? |
@@ -724,6 +724,7 @@ final class DocumentationNormalizer implements NormalizerInterface, CacheableSup
}
}
+ /** @deprecated schema key should be used instead */
$key = $v3 ? 'openapi' : 'swagger';
if (isset($data[$key])) {
... | [DocumentationNormalizer->[addRequestBody->[addSchemas],updatePutOperation->[addSchemas],addSubresourceOperation->[addSchemas,addPaginationParameters],updateGetOperation->[addSchemas],getPathOperation->[getPath],updatePostOperation->[addSchemas]]] | Returns the parameters of the filters. | We need to trigger deprecation errors instead. This phpdoc is unnecessary. |
@@ -124,9 +124,12 @@ public class MetricsReader {
private <T> void checkIfMetricResultIsUnique(String name, Iterable<MetricResult<T>> metricResult)
throws IllegalStateException {
+ int resultCount = Iterables.size(metricResult);
Preconditions.checkState(
- Iterables.size(metricResult) == 1,
-... | [MetricsReader->[getStartTimeMetric->[getDistributionMetric,getTimestampMetric],getTimestampMetric->[getMillis,abs],getDistributionMetric->[getDistributions,error,build,queryMetrics,getMin,checkIfMetricResultIsUnique,next,getMax],getCounterMetric->[error,build,getAttempted,queryMetrics,getCounters,checkIfMetricResultIs... | Checks if the given metric result is unique. | Actually this should be just `checkState(resultCount <= 1, "..", name, namespace, resultCount)` so that it does not execute the String.format when the check passes. |
@@ -39,7 +39,7 @@ func (out *fileOutput) init(config config) error {
out.rotator.Path = config.Path
out.rotator.Name = config.Filename
if out.rotator.Name == "" {
- out.rotator.Name = config.Index
+ out.rotator.Name = out.beatName
}
logp.Info("File output path set to: %v", out.rotator.Path)
logp.Info("Fil... | [init->[Info,CheckIfConfigSane,CreateDirectory],PublishEvent->[SigCompleted,Sig,Critical,Marshal,WriteLine,Err],init,SetInt,Unpack,RegisterOutputPlugin] | init initializes the file output with the given configuration. | this means we can remove 'Index' from file config? |
@@ -762,7 +762,7 @@ class TestNativeTextFileSink(unittest.TestCase):
def test_write_native(self):
pipeline = TestPipeline()
- pcoll = pipeline | beam.core.Create('Create', self.lines)
+ pcoll = pipeline | 'Create' >> beam.core.Create(self.lines)
pcoll | 'Write' >> beam.Write(fileio.NativeTextFileSi... | [TestFileSink->[test_file_sink_writing->[close,MyFileSink,open],test_file_sink_io_error->[close,MyFileSink],test_empty_write->[MyFileSink,open],test_fixed_shard_write->[MyFileSink,open],test_file_sink_display_data->[MyFileSink],test_file_sink_multi_shards->[close,MyFileSink,open]],MyFileSink->[close->[close],open->[ope... | Test write native file. | These are already named 'Create' (and 'Write') |
@@ -236,7 +236,7 @@ final class ApiPlatformParser implements ParserInterface
return $data;
}
- $data['subType'] = $subProperty['subType'];
+ $data['subType'] = $subProperty['dataType'];
if (isset($subProperty['children'])) {
... | [ApiPlatformParser->[parseProperty->[parseProperty,parseResource],getGroupsForItemAndCollectionOperation->[getGroupsContext]]] | Parse a property. Missing node - node - node - node - node - node - node - node - node. | Feels wrong, maybe `$subProperty['subType'] ?? $subProperty['dataType']` but we need to check the consequences. |
@@ -23,12 +23,12 @@ def pants_release():
.format(version=pants_version()))
-def get_buildroot():
- """Returns the pants build root, calculating it if needed.
+def get_buildroot(*, sentinel_filename: str = "pants") -> str:
+ """Returns the Pants build root, calculating it if needed.
:API: public
... | [get_default_pants_config_file->[get_buildroot],pants_release->[pants_version]] | Returns the pants build root. | It would be good to explain that this is only settable for unit testing, or to make it more explicitly settable. If we have essentially changed things to make the sentinel value to look for mutable, maybe we should have an explicit `set_sentinel` method that resets the buildroot and forces it to be recomputed? |
@@ -807,7 +807,7 @@ public class JdbcCommon {
throw new ParseException("Unable to parse binary data using the formatter `" + valueFormat + "`.",0);
}
- stmt.setBinaryStream(parameterIndex, new ByteArrayInputStream(bValue), bValue.length);
+ ... | [JdbcCommon->[createSchema->[createSchema,addNullableField,build],convertToAvroStream->[convertToAvroStream],AvroConversionOptions->[Builder->[build->[AvroConversionOptions]]]]] | Method addParameter. Private method for parsing parameter values. This method is called to retrieve binary data. | How about we try the `setBinaryStream` first, then if it throws a `SQLFeatureNotSupportedException` we try `setBytes`? This might prevent a regression if there is some other driver (not Phoenix) that supports setBinaryStream and not setBytes. This code is used by many folks with many different drivers/DBs, so I'd like ... |
@@ -194,7 +194,7 @@ func installPlugin(plugin workspace.PluginInfo) error {
// that the engine uses to determine which version of a particular provider to load.
//
// it is critical that this function be 100% deterministic.
-func computeDefaultProviderPlugins(languagePlugins, allPlugins pluginSet) map[tokens.Package... | [Union->[Add],Add->[String],Values,GetPluginPath,Assertf,GetProviderVersion,Add,Download,Go,GetRequiredPlugins,Type,Wait,SortedPluginInfo,Package,IsProviderType,Infoln,Infof,Failf,Sort,V,GT,GetProviderPackage,Install,EnsurePlugins,String] | computeDefaultProviderPlugins computes the default set of plugins that the language host should serve as. | Why are we returning an error now that we never return an error? |
@@ -50,12 +50,12 @@ DT_MODULE_INTROSPECTION(1, dt_iop_graduatednd_params_t)
typedef struct dt_iop_graduatednd_params_t
{
- float density; // $MIN: -8.0 $MAX: 8.0 $DEFAULT: 1.0 The density of filter 0-8 EV
- float hardness; // $MIN: 0.0 $MAX: 100.0 $DEFAULT: 0.0 0% = soft and 100% = hard
- float rotation; ... | [No CFG could be retrieved] | Protected from abstract. h private int _graduatedndm_global_data_t _iop_. | This one has no UI element, but it does not harm to add it. |
@@ -342,11 +342,13 @@ class RandomResizedCrop(object):
self.ratio = ratio
@staticmethod
- def get_params(img):
+ def get_params(img, scale, ratio):
"""Get parameters for ``crop`` for a random sized crop.
Args:
img (PIL Image): Image to be cropped.
+ scal... | [RandomRotation->[__call__->[get_params]],ColorJitter->[__call__->[get_params],get_params->[Compose,Lambda]],RandomResizedCrop->[__call__->[get_params]],RandomCrop->[__call__->[get_params]]] | Get parameters for a random sized crop. | I think this commit sneaked in by mistake? |
@@ -1020,14 +1020,6 @@ crt_context_req_untrack(struct crt_rpc_priv *rpc_priv)
tmp_rpc = d_list_entry(epi->epi_req_waitq.next,
struct crt_rpc_priv, crp_epi_link);
tmp_rpc->crp_state = RPC_STATE_INITED;
- crt_set_timeout(tmp_rpc);
-
- D_MUTEX_LOCK(&crt_ctx->cc_mutex);
- rc = crt_req_timeout_track(tmp_rpc);... | [No CFG could be retrieved] | process a number of requests find the next request in the queue and send it to the epi. | is this intentional change to start tracking timeout from the moment rpc was submitted by user vs rpc being on a wire? |
@@ -212,6 +212,6 @@ class BlockChainService:
return self.identifier_to_payment_channel[dict_key]
@property
- @ttl_cache(ttl=30)
+ @ttl_cache(ttl=300) # Check if the underlying eth network changed every 5 mins
def network_id(self) -> int:
return int(self.client.web3.version.network)
| [BlockChainService->[block_number->[block_number],estimate_blocktime->[block_number],wait_until_block->[block_number],next_block->[block_number],is_synced->[block_number],payment_channel->[token_network]]] | Get the network id of the client. | My question here is that, and according to the linked conversation: Would the network/chain_id change while Raiden is running? if the assumption is that the user restarts geth/parity and switches chains then Raiden would have crashed and would need to be restarted. Unless i am missing something here. |
@@ -17,12 +17,17 @@
import {Services} from '../../../src/services';
import {childElementByTag} from '../../../src/dom';
import {getAmpdoc, registerServiceBuilder} from '../../../src/service';
+import {getChildJsonConfig} from '../../../src/json';
+import {isProtocolValid} from '../../../src/url';
import {once} from... | [No CFG could be retrieved] | Creates a new instance of AmpStoryRequestService that can be used to send X load from a child element of a story element with name - AMP. | Nit: `@const {string}`, remove `export` |
@@ -156,6 +156,9 @@ public class WSQueryEndpoint {
return;
}
try {
+ // Check if the user has authorization to access this Websocket endpoint
+ checkEndpointAuthorization(session.getUserPrincipal(), "onOpen");
+
validateVersion(session);
final KsqlRequest request = parseReques... | [WSQueryEndpoint->[onOpen->[getMessage,debug,waitForCommandSequenceNumber,validate,closeSilently,validateVersion,parseStatement,getStatement,isAcceptingStatements,SessionAndRequest,getMetaStore,parseRequest,getId,info,getClass,handle],handlePrintTopic->[getSchemaRegistryClient,IllegalArgumentException,start,getKsqlStre... | Invoked when a session is opened. | hard-coding `onOpen` is very fragile. does it refer to the method name? the annotation on the method name? some magic constant? If I were a user implementing this, how would I know what to implement? as it stands, I need to examine the code? |
@@ -585,6 +585,9 @@ zfs_replay_remove(void *arg1, void *arg2, boolean_t byteswap)
error = SET_ERROR(ENOTSUP);
}
+#ifdef __FreeBSD__
+ VOP_UNLOCK(ZTOV(dzp), 0);
+#endif
zrele(dzp);
return (error);
| [void->[byteswap_uint64_array,xva_getxoptattr,ASSERT,bcopy,strlen,ZFS_TIME_DECODE,byteswap_uint32_array,IS_EPHEMERAL,XVA_ISSET_REQ,bzero],int->[zfs_replay_swap_attrs,zfs_init_vattr,SET_ERROR,BP_GET_LSIZE,ZIL_ACE_LENGTH,sa_update,zfs_space,dmu_tx_wait,ZTOI,gethrestime,SA_ZPL_SIZE,ZIL_XVAT_SIZE,bzero,dmu_tx_assign,zfs_se... | zfs_replay_remove - the function for removing a node from a zfs. | How does `VOP_UNLOCK()` locks work compared to `zrele()` locks, so that you need both in FreeBSD? |
@@ -109,12 +109,12 @@ public class AvroSchemaIOProvider implements SchemaIOProvider {
}
@Override
- public PTransform<PCollection<Row>, POutput> buildWriter() {
+ public PTransform<PCollection<Row>, WriteFilesResult<?>> buildWriter() {
PTransform<PCollection<Row>, PCollection<GenericRecord>> wr... | [AvroSchemaIOProvider->[AvroSchemaIO->[buildReader->[expand->[toRows,apply]],buildWriter->[expand->[withoutSharding,apply],build]],configurationSchema->[build],from->[AvroSchemaIO]]] | Build a writer that writes all records in the input collection to the output location. | This looks good, here the change has less issues since this class is `@Internal` CC @TheNeuralBit for awarenes. |
@@ -42,6 +42,10 @@ namespace System.Resources
ReadResources();
}
+ [UnconditionalSuppressMessage("ReflectionAnalysis", "IL2026:RequiresUnreferencedCode",
+ Justification = "InitializeBinaryFormatter will get trimmed out when AllowCustomResourceTypes is set to false. " +
+ ... | [ResourceReader->[ValidateReaderType->[IsDefaultType,ResReaderTypeName],DeserializeObject->[BinaryFormatter_SerializationDisallowed,GetType,BadImageFormat_ResType_SerBlobMismatch,FindType,InitializeBinaryFormatter,Format,FullName,BaseStream,Read,NotSupported_ResourceObjectSerialization],InitializeBinaryFormatter->[GetT... | Deserialize an object of the specified type. | (nit) Might as well put this check first, since everything after it can be trimmed. |
@@ -154,15 +154,17 @@ class Cp2k(Package):
'-D__SCALAPACK'
])
fcflags.extend([
+ # spec['elpa:fortran'].cppflags
'-I' + join_path(
spec['elpa'].prefix,
'include',
... | [Cp2k->[install->[join_path,find_libraries,deepcopy,write,copytree,append,working_dir,extend,str,format,join,open,make,getcwd],variant,depends_on,version]] | Install a single in the specified path. adds missing libraries and missing dependencies to libs and files This function is called when a module is loaded from a different library. Copy all the binary files from exe to prefix. | I assume this particular interface isn't ready yet? |
@@ -41,6 +41,9 @@ class Pumi(CMakePackage):
description="Enable Simmetrix SimModSuite Support: 'base' enables "
"the minimum set of functionality, 'kernels' adds CAD kernel "
"support to 'base', and 'full' enables all functionality.")
+ variant('simmodsuite_version_check', defa... | [Pumi->[cmake_args->[append,satisfies],variant,depends_on,version]] | Create a tag with all of the attributes that are part of the entity id. Add cmake arguments to the c ++ command. | This needs an extra space after the period or a shorter description. |
@@ -600,7 +600,15 @@ func (s *ReadStep) Apply(preview bool) (resource.Status, StepCompleteFunc, error
}
}
+ // If there is no such resource, return an error indicating as such.
+ if result.Outputs == nil {
+ return resource.StatusOK, nil, errors.Errorf("resource '%s' does not exist", id)
+ }
s.new.Outp... | [Apply->[Plan,Type,New,URN],Prefix->[Color],Plan,Type,Provider,URN] | Apply performs the read step. | Even though we are failing, we are returning resource.StatusOK - is that Intended? |
@@ -132,7 +132,7 @@ func showTrustCmd(c *cli.Context) error {
if err := json.Unmarshal(policyContent, &policyContentStruct); err != nil {
return errors.Errorf("could not read trust policies")
}
- policyJSON, err := trust.GetPolicyJSON(policyContentStruct, systemRegistriesDirPath)
+ policyJSON, showOutputMap, err... | [RegistriesDirPath,GetGPGId,StringSlice,Warnf,MarshalIndent,Writer,Wrap,IsValidImageURI,IsSet,WriteFile,IsNotExist,Strings,Stat,ReadFile,Args,GetRuntime,Errorf,DefaultPolicyPath,Bool,GetPolicyJSON,Wrapf,SystemContext,Out,Write,Sprintf,Unmarshal,String] | if returns the unique identifier for the current user. checks if the user has a unique id in the policy. | This is much better than the `repoval["type"].(string)` accesses before, but still the backend `trust` subpackage is asked to provide the formatting for both variants. It would be conceptually clearer if the backend subpackage provided the data (in well-typed structs), and this subpackage provided the formatting conver... |
@@ -128,7 +128,10 @@ func (c *client) Publish(batch publisher.Batch) error {
if rest != nil {
c.stats.Failed(len(rest))
batch.RetryEvents(rest)
+ return err
}
+
+ batch.ACK()
return err
}
| [makePublish->[makePublishRPUSH,makePublishPUBLISH],Connect->[makePublish,Close,NewConn,Connect],makePublishRPUSH->[FindSubmatch,Do,New,publishEventsPipeline,Bytes,Atoi,publishEventsBulk,IsConst],Close->[Close],publishEventsPipeline->[Flush,Select,Acked,Send,Err,Receive,Dropped],Publish->[RetryEvents,Failed,NewBatch,pu... | Publish publishes the events to Redis. | Question so I would undestand: what does publish only return event if an error occured? |
@@ -138,6 +138,9 @@ FINGERPRINTS = {
CAR.PALISADE: [{
67: 8, 127: 8, 304: 8, 320: 8, 339: 8, 356: 4, 544: 8, 549: 8, 576: 8, 593: 8, 608: 8, 688: 6, 809: 8, 832: 8, 854: 7, 870: 7, 871: 8, 872: 8, 897: 8, 902: 8, 903: 8, 905: 8, 909: 8, 913: 8, 916: 8, 1040: 8, 1042: 8, 1056: 8, 1057: 8, 1064: 8, 1078: 4, 1107:... | [dbc_dict,set] | CAR. KIA_OPTIMA_H - > [ Assignments of the neccesary components of the neccesary components of the n return list of ethernet ethernet ethernet ethernet ethernet and firmware version in a. | add `CAR.VELOSTER` to the ignored fingerprints |
@@ -308,7 +308,7 @@ sched_info_init(struct dss_xstream *dx)
struct sched_info *info = &dx->dx_sched_info;
int rc;
- info->si_cur_ts = daos_getntime_coarse() / 1000000;
+ info->si_cur_ts = daos_getntime_coarse() / NSEC_PER_MSEC;
D_INIT_LIST_HEAD(&info->si_idle_list);
D_INIT_LIST_HEAD(&info->si_sleep_list);
... | [No CFG could be retrieved] | finds the n - th key in the d_hash_table and checks if the Purge list of items from the list of pools. | or you could add another inline getmsec |
@@ -172,6 +172,15 @@ public class HoodieMetrics {
}
}
+ public void updateIndexMetrics(final String action,final long durationInMs) {
+ if (config.isMetricsOn()) {
+ logger.info(String
+ .format("Sending index metrics (%s.duration, %d)",action, durationInMs));
+ Metrics.registerGauge(ge... | [HoodieMetrics->[getCommitCtx->[createTimer],getFinalizeCtx->[createTimer],getRollbackCtx->[createTimer],getCompactionCtx->[createTimer],getDeltaCommitCtx->[createTimer],getCleanCtx->[createTimer]]] | Update the finalize write metrics. | nit: single space after comma and next argument? `action, final long` ? (I am surprised checkstyle does not have this. hmm.. @bvaradar ) |
@@ -413,6 +413,11 @@ AVAILABLE_CLI_OPTIONS = {
metavar='INT',
default=750,
),
+ "skip_trades": Arg(
+ '--skip-trades',
+ help='Skip using trades file from backtesting and DB.',
+ action='store_true',
+ ),
"trade_source": Arg(
'--trade-source',
hel... | [check_int_nonzero->[ArgumentTypeError,int],check_int_positive->[ArgumentTypeError,int],Arg] | Options for the n - tuple - based hyperopt. Options for hyperopt. | Personally, i would prefer to use `--no-trades`. While technically the trades loading is skipped, no-trades seems more intuitive to me - but it's a personal preference - so if you prefer skip-trades that's fine, too |
@@ -34,9 +34,6 @@ public interface WorkbenchList
void remove(String item);
void clear();
- // status
- boolean contains(String item);
-
// change handler
HandlerRegistration addListChangedHandler(ListChangedHandler handler);
}
| [No CFG could be retrieved] | Clear the list. | @jjallaire I had added this in the previous incantation of this PR, but it was misguided as one should be listening on ListChangedEvents to ensure they get an up-to-date MRU list. I've now taken it out and am properly listening for the event. |
@@ -14,6 +14,13 @@ defineSuite([
expect(viewModel.maxHeightOffset(0)).toBeDefined();
});
+ it('sets title', function() {
+ var safeString = '<p>This is a test.</p>';
+ var viewModel = new InfoBoxViewModel();
+ viewModel.titleText = safeString;
+ expect(viewModel.titleText)... | [new,isCameraTracking,toBeDefined,defineSuite,function,var,toBe,description,it,enableCamera,cameraIconPath] | The InfoBoxViewModel is a simple suite of functions that can be used to create a. | What is the goal of this test? It passes in master without any of your changes because `titleText` is the same no matter what, it's how it's parsed that changes in this branch (if security is disabled). |
@@ -802,7 +802,7 @@ class MultidocManager {
} else {
// Non-src version of script.
const type = n.getAttribute('type') || 'application/javascript';
- if (type.indexOf('javascript') == -1) {
+ if (!type.includes('javascript')) {
shadow... | [No CFG could be retrieved] | finds node in the DOM tree and adds it to the list of extension ids. Broadcasts a message asynchronously to all extension roots. | `String#includes` is not supported in IE. |
@@ -423,8 +423,8 @@ func (c *RaftCluster) SetStorage(s *core.Storage) {
c.storage = s
}
-// AddSuspectRegions adds regions to suspect list.
-func (c *RaftCluster) AddSuspectRegions(ids ...uint64) {
+// AddHighPriorityScheduleRegions adds regions to suspect list.
+func (c *RaftCluster) AddHighPriorityScheduleRegion... | [GetClusterVersion->[GetClusterVersion],GetMaxMergeRegionSize->[GetMaxMergeRegionSize],IsMakeUpReplicaEnabled->[IsMakeUpReplicaEnabled],SetStoreState->[SetStoreState,GetStore],SetStoreLimit->[SetStoreLimit],IsLocationReplacementEnabled->[IsLocationReplacementEnabled],GetMergeScheduleLimit->[GetMergeScheduleLimit],OnSto... | SetStorage sets the storage for all suspect regions. | This function name is inconsistency with the other two. |
@@ -144,6 +144,7 @@ func RunCmdRouter(f *clientcmd.Factory, cmd *cobra.Command, out io.Writer, cfg *
return cmdutil.UsageError(cmd, "You may not pass negative labels in %q", cfg.Labels)
}
label = valid
+ nodeSelector = label
}
image := cfg.ImageTemplate.ExpandOrDie(cfg.Type)
| [StringVar,NewDefaultClientConfig,PrintObj,AddPrinterFlags,IntVar,LabelsFromSpec,ReadFile,Errorf,Services,Namespace,PrinterForCommand,CheckErr,Bool,Clients,Create,AddServices,ContainerPortsFromString,Get,Split,NewDefaultImageTemplate,LoadTLSFiles,ExpandOrDie,ClientConfig,Object,Fprintf,Sprintf,List,UsageError,Fatal,IsN... | loadDefaultCert loads the default certificate for the router IsNotFound returns error if router is not found. | Is this always true? What if I want a node selector that doesn't match what I'm labeling my router with? This is probably best added as a new, optional flag. |
@@ -143,4 +143,10 @@ public class ParameterizedQueryTemplateFactoryBean implements FactoryBean<QueryT
{
return false;
}
+
+ private String buildNotDefinedInParamErrorMessage(String name)
+ {
+ return format("Parameter with name %s, used in the query text, does not match any defined query... | [ParameterizedQueryTemplateFactoryBean->[getObject->[remove,QueryTemplate,getName,parse,IllegalStateException,buildUnresolvedParamErrorMsg,add,findOverriddenParam,getSqlText,getType,overrideParam,isEmpty,getParams],buildUnresolvedParamErrorMsg->[append,insert,toString,StringBuilder,length],findOverriddenParam->[evaluat... | Returns true if the node is a singleton node. | Parameter with name %s, used in the query text, does not match any defined query parameter name > Parameter with name '%s', used in the query text, does not match any defined query parameter name defined in the query template |
@@ -149,9 +149,7 @@ function settings_post(App $a)
check_form_security_token_redirectOnErr('/settings/oauth', 'settings_oauth');
$key = $_POST['remove'];
- q("DELETE FROM tokens WHERE id='%s' AND uid=%d",
- dbesc($key),
- local_user());
+ dba::delete('tokens', ['id' => $key]);
goaway(System::baseUrl(tr... | [settings_content->[get_hostname,get_path],settings_post->[discover]] | POST settings for the user Update a client s security token. This function is called when the user is on the Ostatus page. Updates the mailaccount table if it exists. User settings update - - - - - - - - - - - - - - - - - - Updates user settings This function is called when user relocations. | There's no previous ownership test, I believe the `uid` condition should be kept in place. |
@@ -43,6 +43,8 @@ namespace System.Xml.Xsl
_parameters.Add(qname, parameter);
}
+ [RequiresUnreferencedCode("The stylesheet may have calls to methods of the extension object passed in which cannot be statically analyzed " +
+ "by the trimmer. Ensure all methods that may be call... | [XsltArgumentList->[Clear->[Clear],AddExtensionObject->[CheckArgumentNull,Add,nameof],AddParam->[CheckArgumentNull,Verify,Add,nameof],RemoveExtensionObject->[Remove],RemoveParam->[Remove]]] | Adds a parameter with the specified name namespace uri and object extension. | Don't forget to update the `ref` code as well. #Closed |
@@ -269,3 +269,6 @@ AAP_MM_PASSWORD = env('AAP_MM_PASSWORD', None)
# Defines the maximum value of Publish Sequence Number after which the value will start from 1
MAX_VALUE_OF_PUBLISH_SEQUENCE = 9999
+
+# Defines default value for Source to be set for manually created articles
+DEFAULT_SOURCE_VALUE_FOR_MANUAL_ARTICL... | [env->[get,len],env,int,append,lstrip,endswith,format,timedelta,join,loads,urlparse,crontab] | Defines the maximum value of Publish Sequence Number after which the value will start from 1. | I think we should read this from system env so we can deploy for other envs without code changes. |
@@ -258,6 +258,8 @@ class BasePublishService(BaseService):
package_item = super().find_one(req=None, _id=guid)
subscribers = self._get_subscribers_for_package_item(package_item)
+ PackageService().update_field_in_package(updates, package_item[config.ID_FIELD],
+ ... | [ArchivePublishService->[get_subscribers->[_get_subscribers_for_previously_sent_items,filter_subscribers]],CorrectPublishService->[get_subscribers->[_get_subscribers_for_previously_sent_items,filter_subscribers]],KillPublishService->[get_subscribers->[_get_subscribers_for_previously_sent_items],_publish_kill_for_takes-... | Publishes all items of a package recursively and updates the package itself. Returns a list of subscribers for a given package item. | Shouldn't it be `_current_version` instead of `version` as the request parameter `version` points to `_current_version`? Please use the constant `config.VERSION` reason being if we change the name then this will fail. |
@@ -5,7 +5,7 @@ if (Auth::user()->hasGlobalRead()) {
$data['up'] = array('query' => "SELECT COUNT(*) FROM ports AS I, devices AS D WHERE I.`deleted` = '0' AND D.`device_id` = I.`device_id` AND I.`ignore` = '0' AND D.`ignore` = '0' AND I.`ifOperStatus` = 'up'",);
- $data['down'] = array('query' => "SELECT CO... | [hasGlobalRead] | This function returns an array of count of the n - th node in the system. Count the number of ports down and up. | Can now handle state like lowerLayerDown |
@@ -82,6 +82,14 @@ trait ListViewBuilderTrait
$route->setOption('routerAttributesToListMetadata', $newRouterAttributesToListMetadata);
}
+ private function addFormMetadataToView(View $route, array $formMetadata): void
+ {
+ $oldFormMetadata = $route->getOption('formMetadata');
+ $new... | [setAddViewToView->[setOption],addLocalesToView->[setOption,getOption],addResourceStorePropertiesToListRequestToView->[setOption,getOption],setResourceKeyToView->[setOption],addRouterAttributesToListMetadataToView->[setOption,getOption],setUserSettingsKeyToView->[setOption],setTitleToView->[setOption],setBackViewToView... | Adds routerAttributesToListMetadata and locales to the view. | Wouldn't make that more sense on the `FormViewBuilderTrait`? Then we could also reuse that function for normal `FormView`s. |
@@ -102,7 +102,7 @@ public class SparkShinyInterpreterTest extends ShinyInterpreterTest {
Thread.sleep(5 * 1000);
// extract shiny url
List<InterpreterResultMessage> resultMessages = context2.out.toInterpreterResultMessage();
- assertEquals(1, resultMessages.size());
+ assertEquals(resultMessages +... | [SparkShinyInterpreterTest->[testSparkShinyApp->[assertTrue,size,Thread,start,matches,getType,matcher,toString,compile,isSpark1,put,toInterpreterResultMessage,group,code,getResource,sleep,getData,printStackTrace,assertEquals,fail,interpret,getStatus,contains,getBody,getInterpreterContext,asString],tearDown->[close],set... | Launch a spark shiny app. Checks if the response contains a non - zero status code and the spark version. | The result seems be the same as `resultMessages.toString()`, but wouldn't it be better to use a consistent expression with other code? |
@@ -83,9 +83,10 @@
</div>
<div class="crayons-field mt-6 align-left">
- <fieldset aria-describedby="section-description">
+ <fieldset aria-describedby="terms-description">
<legend class="crayons-field__label mb-2">Finally, please agree to the following:</legend>
<div>
+ <p id="terms-subtitle" class="... | [No CFG could be retrieved] | A list of all components of the n - node node that are part of the n -. | I'm a bit confused by the change to `aria-describedby` (and the original value). I'm looking at the DOM and I don't see an element with the ID `terms-description`. That's not a blocker for this change, but perhaps an accessibility issue. |
@@ -148,6 +148,11 @@ func ResourceVPC() *schema.Resource {
validation.IsCIDRNetwork(VPCCIDRMaxIPv6, VPCCIDRMaxIPv6)),
),
},
+ "ipv6_cidr_block_network_border_group": {
+ Type: schema.TypeString,
+ Optional: true,
+ RequiredWith: []string{"AmazonProvidedIpv6CidrBlock"},
+ },
"ipv6_ipam_p... | [DescribeRouteTables,GetChange,ForceNew,ModifyVpcAttribute,CreateVpc,BoolValue,ModifyVpcTenancy,StringSlice,IsNewResource,StringInSlice,DescribeSecurityGroups,SetNewComputed,ErrMessageContains,TagsSchema,DisableVpcClassicLinkDnsSupport,NonRetryableError,Set,Code,DisassociateVpcCidrBlock,TagsSchemaComputed,GetOk,TimedOu... | Demonstrates how to validate a resource in the ec2 schema. resourceVPCCreate creates a resource vpc with the specified tags. | this should be `assign_generated_ipv6_cidr_block`. when interacting directly with the SDK you will use the Camel Cased names but when not working with the SDK you should use snake casing |
@@ -487,7 +487,7 @@ bool MarlinUI::get_blink() {
* This is very display-dependent, so the lcd implementation draws this.
*/
-#if ENABLED(LCD_PROGRESS_BAR)
+#if ENABLED(LCD_PROGRESS_BAR) && DISABLED(TFTGLCD_PANEL)
millis_t MarlinUI::progress_bar_ms; // = 0
#if PROGRESS_MSG_EXPIRE > 0
millis_t MarlinUI::... | [No CFG could be retrieved] | The keypad is a bit of a hack to make it easy to do it with the Updates the status screen with the message blinking and expiration. | Does `TFTGLCD_PANEL` disable everything about `LCD_PROGRESS_BAR`? If so, we can just add a safety check, or even undef the `LCD_PROGRESS_BAR` when `TFTGLCD_PANEL` is enabled |
@@ -52,6 +52,7 @@ final class LimitedSequence<T> extends YieldingSequenceBase<T>
return new LimitedYielder<>(subYielder, limitedAccumulator);
}
+ @SuppressWarnings("InnerClassMayBeStatic") // False alarm: flagged by IDEA inspections, but can't actually be static.
private class LimitedYielder<OutType> impl... | [No CFG could be retrieved] | region > LimitedSequence Returns true if the subYielder is done. | Would be nice to describe the explanation in your PR in here so someone in the future can remove the suppression if the inner class it depends on becomes static |
@@ -1272,6 +1272,12 @@ void MapblockMeshGenerator::drawRaillikeNode()
} else {
tile_index = rail_kinds[code].tile_index;
angle = rail_kinds[code].angle;
+
+ // Fix angle for fallback end texture
+ if (tile_index == end && angle >= 180 &&
+ f.tiledef[end].name == f.tiledef[straight].name) {
+ angle -= 180... | [blendLightColor->[blendLight],drawRaillikeNode->[drawQuad,isSameRail,useTile],prepareLiquidNodeDrawing->[getSpecialTile],drawPlantlikeRootedNode->[drawPlantlike,getSmoothLightFrame,useTile],drawTorchlikeNode->[drawQuad,useTile],drawNode->[drawGlasslikeNode,drawNodeboxNode,drawAllfacesNode,getSmoothLightFrame,drawSignl... | Draws a rail - like node. | Can't this be fixed ahead of time by rotating the texture in the nodedef? (we have a modifier for that) |
@@ -7,6 +7,7 @@ module Engine
class Base
include Passer
attr_accessor :acted
+ attr_reader :company
ACTIONS = [].freeze
| [Base->[entity_index->[entity_index],skip!->[log_skip],process_pass->[log_pass],current_actions->[actions],entities->[entities],buying_power->[buying_power]]] | Initialize a new object with a . | does this need to be in base? |
@@ -16,6 +16,7 @@ DIRECTORIES = {
'plotting-file' : '../../examples/plotting/file',
'plotting-notebook': '../../examples/plotting/notebook',
'server' : '../../examples/plotting/server',
+ 'webgl' : '../../examples/plotting/webgl',
'compat' : '../../examples/compat... | [main->[get_session,save_session],get_parser,clean_session,depend_check,main] | Creates a parser that will be used to parse the given n - node node. Adds command line options for the Parser object. | being picky :) alignment is one space off |
@@ -574,7 +574,7 @@ namespace Dynamo.ViewModels
/// </summary>
protected virtual void RefreshPortColors()
{
- PortBackgroundColor = node.IsVisible ? PortBackgroundColorDefault : PortBackgroundColorPreviewOff;
+ PortBackgroundColor = PortBackgroundColorDefault;
... | [PortViewModel->[NodePropertyChanged->[RaisePropertyChanged,nameof,IsVisible,RefreshPortColors,PropertyName],PlacePortContextMenu->[ActualHeight,Height,Index,Input,None,Zoom,ActualWidth,PortType,HeaderHeight,Width],ChangeLevel->[Format,ExecuteCommand,Index,Empty,GUID],WorkspacePropertyChanged->[RaisePropertyChanged,Pro... | This method refreshes the port colors. | if the background is always being set to the same color just set it once. |
@@ -50,15 +50,7 @@ public class JLabelBuilder {
public JLabel build() {
Preconditions.checkState(text != null || icon != null);
- final String truncated;
- if (text != null) {
- Preconditions.checkState(!text.trim().isEmpty());
- truncated = Ascii.truncate(text, maxTextLength, "...");
- } e... | [JLabelBuilder->[builder->[JLabelBuilder],html->[text]]] | Build the label. | I'm curious to know what lead to this change in behaviour. |
@@ -129,13 +129,9 @@ class TestAdjointSensitivityAnalysisBeamStructureNodalReaction(AdjointSensitivit
def perform_additional_checks(self):
adjoint_model_part = self.adjoint_analysis.model.GetModelPart(self.model_part_name)
- reference_values = [-0.31249774999397384, -1.249]
- sensitivities... | [TestAdjointSensitivityAnalysisBeamStructureLocalStress->[perform_additional_checks->[GetModelPart,Conditions,append,assertAlmostEqual,Elements]],TestAdjointSensitivityAnalysisBeamStructureStrainEnergy->[perform_additional_checks->[GetModelPart,Conditions,append,assertAlmostEqual,Elements]],TestAdjointSensitivityAnalys... | Checks the sensitivities of the model part. | I erased the check of I22_SENSITIVITY because it is already checked by `from_json_check_result_process` |
@@ -69,13 +69,13 @@ export function isAdPositionAllowed(el, win) {
* This is called during layout measure.
* @param {!Element} el
* @param {!Window} win
- * @return {?Element}
+ * @return {?string}
*/
export function getAdContainer(el) {
do {
el = el.parentNode;
if (CONTAINERS[el.tagName]) {
- ... | [No CFG could be retrieved] | Returns the blessed container element if the ad is contained by one. | need to update the description as well |
@@ -619,7 +619,7 @@ describe Grouping do
@grouping.group.access_repo do |repo|
txn = repo.get_transaction('markus')
begin
- txn.add(File.join(@assignment.repository_folder, @file.filename), 'ShapesTest content', 'text/plain')
+ txn.add(File.join(@assignment.assignmen... | [expect_updated_criteria_coverage_count_eq->[update_criteria_coverage_counts,reload,to,eq],add_tas,replace_submission_rule,create,let,calculate_collection_time,have_many,it,to,message,time_delta,with,filename,each,hours,missing_assignment_files,context,apply_submission_rule,unassign_tas,raise,add,reload,be,match_array,... | Initialize a transaction for all missing nodes. create a new submission object and check it s last submission added to the grouping. | Metrics/LineLength: Line is too long. [135/120] |
@@ -204,6 +204,8 @@ static void sdma_init_c0(struct dma *dma)
pdata->ccb = sdma_pdata->ccb_array;
pdata->hw_event = -1;
dma_chan_set_data(c0, pdata);
+
+ dma_reg_write(dma, SDMA_CHNPRI(0), SDMA_MAXPRI);
}
static int sdma_boot(struct dma *dma)
| [dma_chan_data->[memset,trace_sdma_error,dma_get_drvdata,sdma_set_overrides,dma_chan_set_data,tracev_sdma],void->[dma_reg_update_bits,memset,BIT,SDMA_CHNENBL,dma_chan_get_data,dma_get_drvdata,dma_interrupt,dma_chan_set_data,sdma_set_overrides,sdma_clear_event,tracev_sdma],int->[dma_reg_update_bits,dma_start,BIT,sdma_se... | This is the main entry point for the sdma_init function. | I think commit title should specify that it's SDMA on this one as well? |
@@ -619,9 +619,7 @@ TEMPLATES = [
'extensions': [
'jinja2.ext.do',
'jinja2.ext.loopcontrols',
- 'jinja2.ext.with_',
'jinja2.ext.i18n',
- 'jinja2.ext.autoescape',
'puente.ext.i18n',
'django_jin... | [pipeline_one_scss->[pipeline_scss],_get_locales->[path],path,_get_locales,pipeline_scss] | Component initialization. Handles User Bans - Allauth - account. auth_backends. Authentication. | In TravisCI, the locales are built with the current Docker image, which means it is breaking on this change that requires the updated requirements are used. I'm going to add a new commit to change the ``locale`` build to act more like the ``py27``, so the updated requirements will be used. |
@@ -23,10 +23,6 @@ module Profiles
if update_successful?
@success = true
@user.touch(:profile_updated_at)
- # TODO: @citizen428 Preserving a DEV specific feature for now, we should
- # probably remove this sooner than later as it may not make much sense
- # for other commun... | [Update->[call->[call,update_successful?,full_messages,dev_to?,concat,touch,add_field],update_successful?->[update!,transaction],update_profile->[attributes,save!,extract!,assign_attributes,slice!,any?],verify_profile_image->[valid_image_file?,valid_filename?],conditionally_resave_articles->[core_profile_details_change... | Check if a citizen - 2 tag exists and if so add it to the. | I dream of the day we can remove `.dev_to?` altogether! We are getting so close |
@@ -52,6 +52,10 @@ public class CuratorConfig
@JsonProperty("authScheme")
private String authScheme = "digest";
+ @JsonProperty("terminateDruidProcess")
+ private boolean terminateDruidProcess = false;
+
+
public String getZkHosts()
{
return zkHosts;
| [CuratorConfig->[setEnableCompression->[checkNotNull],getZkPwd->[getPassword],setEnableAcl->[checkNotNull],DefaultPasswordProvider]] | Returns the Zookeeper hosts for the given . | I meant "terminateDruidProcessOnConnectFail", just replace "quit" part with "terminateDruidProcess" |
@@ -1445,7 +1445,6 @@ def range(start, limit=None, delta=1, dtype=None, name="range"): # pylint: disa
`range(n) = range(0, n)`.
For example:
-
>>> start = 3
>>> limit = 18
>>> delta = 3
| [reduce_max->[_ReductionDims],to_double->[cast],reduce_sum->[_ReductionDims],reciprocal_no_nan->[div_no_nan],scalar_mul_v2->[scalar_mul],tensor_equals->[equal],_ReductionDims->[range],reduce_std->[reduce_variance],reduce_all->[_may_reduce_to_scalar,_ReductionDims],accumulate_n->[add_n,_input_error],truediv->[_truediv_p... | Creates a sequence of numbers that begins at start and extends by increments of delta up to Create a range of objects. | The empty line above this should be kept. |
@@ -227,7 +227,7 @@ func (t *TeamsNameInfoSource) Lookup(ctx context.Context, name string, public bo
if err != nil {
return res, err
}
- return t.makeNameInfo(ctx, team, public)
+ return t.makeNameInfo(ctx, team, nil, public)
}
func (t *TeamsNameInfoSource) EncryptionKeys(ctx context.Context, name string, te... | [EncryptionKeys->[loadTeam,makeNameInfo],EphemeralEncryptionKey->[loadTeam],makeNameInfo->[identify],Lookup->[transformTeamDoesNotExist,makeNameInfo],LookupUntrusted->[transformTeamDoesNotExist],EphemeralDecryptionKey->[loadTeam],DecryptionKeys->[makeNameInfo],loadTeam] | Lookup returns a name info for the given team. | do we ever call `#Lookup` on the way into chat? |
@@ -2662,10 +2662,10 @@ module.exports = class okex extends Exchange {
parseMyTrade (pair, market = undefined) {
// check that trading symbols match in both entries
- const first = pair[0];
- const second = pair[1];
- const firstMarketId = this.safeString (first, 'instrument_id');
-... | [No CFG could be retrieved] | parse transaction data to get withdrawal or deposit id Get the data for a single entry. | @ndubel i'm not sure about these two lines - namely, the user's trade could be either the first in the pair or the second in the pair, and we have to determine which one is "ours". |
@@ -743,7 +743,7 @@ function render_content(&$a, $items, $mode, $update, $preview = false) {
}
if(local_user() && link_compare($a->contact['url'],$item['author-link']))
- $edpost = array($a->get_baseurl($ssl_state)."/editpost/".$item['id'], t("Edit"));
+ $edpost = array(App::get_baseurl($ssl_state).... | [content_content->[get_baseurl],render_content->[get_baseurl]] | Renders the content of an item call_hooks - related functions This function is used to render a single item in the contact table. The function that creates an object that represents a profile item. Display a single item in a context This function is used to map all the has - node - comments and the has - node Squash al... | Standards: Can you please add brackets to this whole conditional statement? |
@@ -640,10 +640,17 @@ define([
var camera = new Camera(this);
this._camera = camera;
- this._cameraClone = Camera.clone(camera);
this._screenSpaceCameraController = new ScreenSpaceCameraController(this);
this._mapMode2D = defaultValue(options.mapMode2D, MapMode2D.INFINITE_SC... | [No CFG could be retrieved] | Creates a new object. Depth plane object. | Should this depend on `logarithmicDepthFarToNearRatio`? |
@@ -55,14 +55,6 @@ describe AdminRequestController, "when administering requests" do
describe 'when fully destroying a request' do
- it 'expires the file cache for that request' do
- info_request = double(InfoRequest, :id => 'fake_request', :url_title => 'test')
- info_request.stub(:user)
- exp... | [make_request->[post],create,find,describe,stub,it,name,to,before,post,double,with,require,include,dirname,mock_model,receive,match,id,delete,deliveries,redirect_to,get,not_to,basic_auth_login,info_requests,eq,reload,and_return,expand_path] | expires the request cache when saving edits to it redirects after destroying a request with incoming_messages. | Is the removal of this intentional? |
@@ -14,10 +14,7 @@ import hudson.model.View;
import java.io.ByteArrayOutputStream;
import java.io.PrintStream;
-import java.util.Arrays;
-import java.util.Collection;
-import java.util.HashSet;
-import java.util.List;
+import java.util.*;
import jenkins.model.Jenkins;
| [ListJobsCommandTest->[failForNonexistingName->[getMessage,thenReturn,containsString,empty,is,assertThat,runWith,fail],job->[thenReturn,mock],getJobsFromView->[job,assertThat,thenReturn,equalTo,empty,is,listsJobs,asList,runWith,view],view->[mock,thenCallRealMethod],empty->[matchesSafely->[isEmpty],describeTo->[appendTe... | Package private for testability. Sets up the mock. | Even if this test code, probably discouraged to use star imports. |
@@ -31,6 +31,7 @@ namespace Dynamo.Tests
libraryCore.ParsingMode = ParseMode.AllowNonAssignment;
var pathResolver = new TestPathResolver();
+ pathResolver.AddPreloadLibraryPath("ProtoGeometry.dll");
pathResolver.AddPreloadLibraryPath("DSCoreNodes.dll");
... | [LibraryTests->[Setup->[Setup],Cleanup->[Cleanup]]] | Setup method. | @yeexinc please remove this line |
@@ -378,8 +378,9 @@ func (a KubernetesAddon) GetAddonPoolIndexByName(poolName string) int {
// PrivateCluster defines the configuration for a private cluster
type PrivateCluster struct {
- Enabled *bool `json:"enabled,omitempty"`
- JumpboxProfile *PrivateJumpboxProfile `json:"jumpboxProfile,... | [GetCustomEnvironmentJSON->[IsAzureStackCloud],HasAvailabilityZones->[HasAvailabilityZones],GetUserAssignedID->[UserAssignedIDEnabled],GetVMType->[HasVMSSAgentPool],HasImageGallery->[IsGalleryImage],GetSecondaryNonMasqueradeCIDR->[IsHostedMasterProfile],GetFirstConsecutiveStaticIPAddress->[IsVirtualMachineScaleSets],Is... | GetAddonContainersIndexByName returns the index of the KubernetesAddon containers with the name containerName or QPS limit for Cloud Provider. | so you only need this line of change and the one in pkg/api/defaults.go |
@@ -49,10 +49,14 @@ module Users
protected
+ def email
+ params[:password_reset_email_form][:email]
+ end
+
def handle_valid_email
- RequestPasswordReset.new(downcased_email).perform
+ RequestPasswordReset.new(email).perform
- session[:email] = downcased_email
+ session[:e... | [ResetPasswordsController->[update->[new],build_user->[new],edit->[new],create->[new],new->[new]]] | if the user has a lease for the user then redirect to the forgot password page otherwise. | no need to `downcase.strip` here? |
@@ -356,6 +356,15 @@ class PostAlerter
end
end
+ # Don't alert same user about the same post
+ # i.e. skip duplicate alerts on a revised post (when editing post triggers a new type of notification like a mention or a quote)
+ existing_alert = user.notifications
+ .order("notifications.id DES... | [PostAlerter->[notify_group_summary->[group_stats],notify_post_users->[create_notification],allowed_users->[not_allowed?],notify_users->[create_notification],allowed_group_users->[not_allowed?],directly_targeted_users->[allowed_group_users,allowed_users],notify_pm_users->[notify_group_summary,create_notification],indir... | create a notification of the given type on the given post Returns true if a notification should be sent to the user previous to the given post. Creates a notification alert if the user doesn t have a lease. | It seems to me you could query this once, and use it for the other check too, since it's a subset of this one. (You could use ruby code to check for the type in the resulting array.) |
@@ -131,7 +131,6 @@ feature 'doc capture document capture step' do
it 'proceeds to the next page with valid info and logs analytics info' do
allow(Analytics).to receive(:new).and_return(fake_analytics)
- expect(Analytics).to receive(:new).with(hash_including(user: user))
attach_and_submit_im... | [submit_empty_form->[visit,put],visit,new,let,mock_general_doc_auth_client_error,reset!,feature,reset_session!,have_current_path,it,travel,requested_at,to,have_content,save!,before,let!,mock_response!,with,t,last,require,attach_file,from_now,include,to_i,complete_doc_capture_steps_before_first_step,store_result_from_re... | complete_doc_capture_steps_before_next_step - complete list of steps It reports that the page is on the correct_page and shows the document upload options. | Can we otherwise ensure in this spec that the analytics hash includes the user? From what I can tell, it's not currently. I think it's because the controller's FlowStateMachine mixins are assuming to have been able to make use of the previous `analytics_user`. Is there another way we could make sure those analytics tra... |
@@ -249,8 +249,8 @@ var (
Ubuntu: SovereignCloudsUbuntuImageConfig,
RHEL: DefaultRHELOSImageConfig,
CoreOS: DefaultCoreOSImageConfig,
- AKS: SovereignCloudsUbuntuImageConfig,
- AKSDockerEngine: SovereignCloudsUbuntuImageConfig,
+ AKS: DefaultAKSOSIm... | [Sprintf] | DCOS190BootstrapDownloadURL is the URL of the DCOS 1970 bootstrap. | @karataliu Are those images available now on Mooncake? |
@@ -683,6 +683,10 @@ class FuncDef(FuncItem, SymbolNode, Statement):
def name(self) -> str:
return self._name
+ @property
+ def is_module_level_func(self) -> bool:
+ return self.info == FUNC_NO_INFO
+
def accept(self, visitor: StatementVisitor[T]) -> T:
return visitor.visit_fu... | [ClassDef->[serialize->[serialize],is_generic->[is_generic],deserialize->[ClassDef,deserialize]],TypeAlias->[serialize->[serialize]],FuncDef->[serialize->[serialize],deserialize->[FuncDef]],Decorator->[serialize->[serialize],deserialize->[Decorator,deserialize]],TypeVarExpr->[serialize->[serialize],deserialize->[TypeVa... | Return the name of the function definition. | @JukkaL my instinct was to "hide" the use of `FUNC_NO_INFO`. I'm not sure if that was a good instinct. |
@@ -90,8 +90,8 @@ public class DefaultConflictManager<K, V> implements InternalConflictManager<K,
@Inject Configuration cacheConfiguration;
@Inject CommandsFactory commandsFactory;
@Inject DistributionManager distributionManager;
- @Inject @ComponentName(ASYNC_TRANSPORT_EXECUTOR)
- ExecutorService trans... | [DefaultConflictManager->[restartVersionRequests->[start],isStateTransferInProgress->[isStateTransferInProgress],stop->[stop],VersionRequest->[start->[start],start],getConflicts->[getConflicts,stop],resolveConflicts->[stop,resolveConflicts]]] | Creates a new instance of the DefaultConflictManager class. cache name local address. | Do we need a different name for this executor if it's going to be used for non-peristence related executions? |
@@ -32,7 +32,9 @@ class Chat extends AbstractChat<Props> {
headerProps = {{
headerLabelKey: 'chat.title'
}}
- modalId = { CHAT_VIEW_MODAL_ID }>
+ modalId = { CHAT_VIEW_MODAL_ID }
+ onClose = { this.props._onToggleChat }>... | [No CFG could be retrieved] | Renders the with JitsiModal. | This won't work, you need to pass a function which returns true for the modal to close, as it stands it will remain open. |
@@ -265,7 +265,7 @@ class USBPrinterOutputDevice(PrinterOutputDevice):
if match[2]:
extruder.updateTargetHotendTemperature(float(match[2]))
- bed_temperature_matches = re.findall(b"B: ?(\d+\.?\d*) ?\/?(\d+\.?\d*) ?", line)
+ bed_temperature_... | [USBPrinterOutputDevice->[connect->[connect],cancelPrint->[_sendCommand],_sendNextGcodeLine->[_sendCommand],_update->[sendCommand,_sendCommand],close->[close]]] | Update the hotend temperature and target temperature values. Handle a single line of a BED file or a BED file. | To make it work with both formats, maybe we can use something more like this: r"B: ?(\d+\.?\d*)\s+?\/?(\d+\.?\d*)?\s*" I've changed the single space into `\s+` and still allow the space at the end. |
@@ -114,14 +114,14 @@ public class DistributionRetryTest extends AbstractRetryTest {
remoteCache.put(key, "v");
assertOnlyServerHit(getAddress(hotRodServer2));
- TcpTransportFactory tcpTp = (TcpTransportFactory) ((InternalRemoteCacheManager) remoteCacheManager).getTransportFactory();
+ Channel... | [DistributionRetryTest->[testContains->[containsKey,resetStats,generateKeyAndShutdownServer,assertEquals],testGetWithVersion->[getValue,generateKeyAndShutdownServer,getVersioned,resetStats,assertEquals],getCacheConfig->[hotRodCacheConfiguration,numOwners,getDefaultClusteredCacheConfig],ByteKeyGenerator->[getStringObjec... | generate key and shutdown server. | Looking how `ChannelFactory` is being used I think it may be beneficial to call it Netty (or Channel if you wish) Transport Factory. |
@@ -24,13 +24,10 @@ using namespace Windows::Globalization;
using namespace PlatformAgnostic::Resource;
#define U_STATIC_IMPLEMENTATION
#define U_SHOW_CPLUSPLUS_API 0
-#pragma warning(push)
-#pragma warning(disable:4995) // deprecation warning
#include <unicode/ucol.h>
#include <unicode/udat.h>
#include <unicode/... | [No CFG could be retrieved] | ----- Public API of the type handler. Create a list of all - core - intl - related objects. | how did this warning get resolved? |
@@ -53,6 +53,11 @@ class Route
$this->view = $view;
}
+ public function getName(): string
+ {
+ return $this->name;
+ }
+
public function addOption(string $key, $value): self
{
$this->options[$key] = $value;
| [No CFG could be retrieved] | Initialize a new node. | ` public function mergeOptions(array $options): self` ??? |
@@ -510,6 +510,17 @@ All jobs created by a pipeline will create commits in the pipeline's output repo
if err != nil {
return err
}
+ if jobID != "" {
+ ji, err := client.InspectJob(jobID, false)
+ if err != nil {
+ return err
+ }
+ jci, err := client.InspectCommit(ji.OutputCommit.Repo.Nam... | [StringVar,Message,TempFile,PrintDetailedDatumInfo,PipelineReqFromInfo,NextCreatePipelineRequest,RunFixedArgs,Flush,PrintPipelineInfo,NewPipelineManifestReader,CreateDocsAlias,NewWriter,DeletePipeline,MarkFlagCustom,ReadString,PrintDetailedJobInfo,ListJobF,BuildImage,ReadPassword,Split,WithCtx,Println,AddFlagSet,Getenv... | Commands to stop a job and restart a job listDatum returns the list of the datums in a job. | Do this server-side instead, it's liable to be something we want to be able to call from other clients like the dash. Also it'll allow you to write a test case for it. |
@@ -232,15 +232,13 @@ class WPSEO_Post_Type_Sitemap_Provider implements WPSEO_Sitemap_Provider {
continue;
}
- $posts_to_exclude = explode( ',', $options['excluded-posts'] );
-
foreach ( $posts as $post ) {
if ( WPSEO_Meta::get_value( 'meta-robots-noindex', $post->ID ) === '1' ) {
continue... | [WPSEO_Post_Type_Sitemap_Provider->[get_post_type_archive_link->[get_options,get_page_for_posts_id],calculate_priority->[get_page_on_front_id,get_page_for_posts_id],get_sitemap_links->[get_page_on_front_id,get_options,get_page_for_posts_id],is_valid_post_type->[get_options],get_url->[get_home_url,get_options],get_first... | Get the links for a given post type. Filter URL entry before it gets added to the sitemap. | If we are touching this line, please move it above the previous conditional, as this is much easier to check than doing a meta value check. |
@@ -893,6 +893,8 @@ class Trade(_DECL_BASE, LocalTrade):
buy_tag = Column(String(100), nullable=True)
timeframe = Column(Integer, nullable=True)
+ trading_mode = Column(Enum(TradingMode))
+
# Leverage trading properties
leverage = Column(Float, nullable=True, default=1.0)
is_short = Column... | [LocalTrade->[recalc_open_trade_value->[_calc_open_trade_value],calc_profit->[calc_close_trade_value],update_order->[update_orders],get_open_trades->[get_trades_proxy],adjust_stop_loss->[_set_stop_loss],stoploss_reinitialization->[get_open_trades,adjust_stop_loss],calc_profit_ratio->[calc_close_trade_value],calc_close_... | Required to store the values of the missing - missing - missing - missing - missing - missing Recalculates the open trade value for the order. | Based on the migrations used (setting this column to null), this should be `nullable=True` (defaults to False) ... otherwise it may fail (maybe not on sqlite, but other databases are more strict). |
@@ -456,6 +456,7 @@ async function esbuildCompile(srcDir, srcFilename, destDir, options) {
incremental: !!options.watch,
logLevel: 'silent',
external: options.externalDependencies,
+ mainFields: ['module', 'browser', 'main'],
write: false,
});
} else {
| [No CFG could be retrieved] | Splits up the wrapper to compute the banner and footer for the and builds the n Reads the file and writes it to the destination. | Let's update the test running with this, too. |
@@ -0,0 +1,18 @@
+# frozen_string_literal: true
+
+class QueueInternalOneboxRebake < ActiveRecord::Migration[6.1]
+ def up
+ # Prior to this fix, internal oneboxes were bypassing the CDN for avatar URLs.
+ # If a site has a CDN, queue up a rebake in the background
+ if GlobalSetting.cdn_url
+ execute <<~... | [No CFG could be retrieved] | No Summary Found. | For sites with alot of posts, wouldn't this migration lock up many rows and could potentially cause problems? I feel like we should err on the safe side here even though not many posts will match the filter here. |
@@ -413,9 +413,11 @@ namespace System
{
throw new ThrowsException(typeof(E), exception);
}
+
+ return exception;
}
- public static void AssertThrows<E, T>(Span<T> span, AssertThrowsAction<T> action) where E : Exception
+ public static Except... | [AssertExtensions->[LessThanOrEqualTo->[AddOptionalUserMessage],Exception->[Throws],LessThan->[AddOptionalUserMessage],GreaterThan->[AddOptionalUserMessage],Throws->[Throws,AssertExtensions],ThrowsAny->[ThrowsAnyInternal],Contains->[Contains],GreaterThanOrEqualTo->[AddOptionalUserMessage]]] | AssertThrows<E T > throws an exception in a read - only manner. | Can't these return E as a stronger return type? |
@@ -62,9 +62,14 @@ func (v *Validator) ResourcePoolHelper(ctx context.Context, path string) (*objec
pool, err := v.Session.Finder.ResourcePool(ctx, path)
if err != nil {
- log.Debugf("Failed to look up compute resource as absolute path %q: %s", path, err)
- if _, ok := err.(*find.NotFoundError); !ok {
- // we... | [ResourcePoolHelper->[Reference,Begin,New,ResourcePool,Name,End,Client,Properties,Errorf,suggestComputeResource,NewComputeResource,ComputeResource,Debugf],suggestComputeResource->[Infof,Begin,Name,End,ComputeResourceList,Info],ValidateCompute->[Infof,Begin,End,compute,ListIssues],compute->[End,ResourcePoolHelper,NoteIs... | ResourcePoolHelper returns a resource pool if it exists The object that holds the resource in the cluster. | I think the error returned from here gets used as a "pretty" or at least hopefully helpful message at the end of the installer output - can we wrap the raw govmomi finder err as with the error return in the clause above. |
@@ -105,6 +105,10 @@ public class StandaloneExecutor implements Executable {
public void start() {
try {
udfLoader.load();
+ ProcessingLogServerUtils.maybeCreateProcessingLogTopic(
+ serviceContext.getTopicClient(),
+ processingLogConfig,
+ ksqlConfig);
executeState... | [StandaloneExecutor->[start->[start],handlePersistentQuery->[start]]] | Starts the server. | Is there anything that prevents a user from configuring `processing.log.stream.auto.create=on` in headless mode? Not sure why someone would want to do this (unless they wanted to write queries against the processing log stream...?) but in the event that someone tries, silent failure seems like poor UX. Then again, the ... |
@@ -662,6 +662,8 @@ public class TcpNioConnection extends TcpConnectionSupport {
TcpNioConnection.this.socketChannel.write(buffer);
remaining = buffer.remaining();
}
+ selector.close();
+ selector = null;
}
}
| [TcpNioConnection->[shutdownInput->[shutdownInput],doClose->[close],doRead->[allocate],shutdownOutput->[shutdownOutput],getPort->[getPort],isOpen->[isOpen],ChannelInputStream->[close->[close],read->[read]],readPacket->[doRead],allocate->[allocate],ChannelOutputStream->[close->[doClose],doWrite->[write]]]] | This method writes the given buffer to the socket. | And why do we need to close selector after each write? You said yourself in the PR description: > Closing/destroying `ChannelOutputStream` object does not close the selector I don't see that you close a `ChannelOutputStream` in this write operation, so I believe it is done somehow externally. Therefore that `ChannelOut... |
@@ -5,6 +5,16 @@ import (
"github.com/harmony-one/bls/ffi/go/bls"
"github.com/harmony-one/harmony/internal/common"
+ "github.com/harmony-one/harmony/internal/ctxerror"
+)
+
+// Define validator staking related const
+const (
+ MaxNameLength = 70
+ MaxIdentityLength = 3000
+ MaxWebsiteLength ... | [No CFG could be retrieved] | Package for a given number of non - negative integer . | How you picked these magic numbers |
@@ -180,6 +180,16 @@ class RepositoryRowsController < ApplicationController
end
end
+ def assigned_task_list
+ my_modules = @repository_row.my_modules.joins(experiment: :project)
+ .search_by_name(current_user, current_team, params[:query])
+ .... | [RepositoryRowsController->[create->[call,render,succeed?,escape_input,log_activity,name,errors,each,t,id,repository_row,record_annotation_notification],load_vars->[find_by_id],update_params->[to_h],selected_params->[to_h],log_activity->[call,id],load_repository->[find_by_id,can_read_repository?],record_annotation_noti... | This action shows the list of available rows in the PDF repository. If there are no rows. | Model has special method for one partial? |
@@ -1,3 +1,18 @@
+"""
+State is the main currency in the Prefect platform. It is used to represent the current
+status of a task. This class is a series of State objects with relevant metadata that
+represents the current state of something.
+
+Every task is initialized with the `Pending` state meaning that it is waiti... | [Scheduled->[__init__->[super]],Pending->[__init__->[super]],CachedState->[__init__->[super]],State->[is_failed->[isinstance],is_running->[isinstance],is_pending->[isinstance],__hash__->[id],__eq__->[type,getattr,object,startswith,isinstance],__repr__->[,type],is_successful->[isinstance],is_finished->[isinstance],__ini... | Create a new object that represents a specific . Checks if a task has failed. | This sentence confuses me a little; are you saying "This module is a collection of State objects..." or something about the base State class? |
@@ -279,6 +279,7 @@ public final class FilePath implements Serializable {
* @param rel a path which if relative will be resolved against base
*/
public FilePath(@Nonnull FilePath base, @Nonnull String rel) {
+ assert base != null;
this.channel = base.channel;
this.remote = normali... | [FilePath->[UntarFrom->[invoke->[extract]],unzip->[FilePath,unzip],AbstractInterceptorCallableWrapper->[call->[call],getClassLoader->[getClassLoader]],ValidateAntFileMask->[invoke->[equals],hasMatch->[isCaseSensitive->[isCaseSensitive,Cancel]]],UnzipLocal->[invoke->[getRemote,unzip]],copyTo->[copyTo,write,act],LastModi... | readResolve - readResolve method. | something is wrong with indenting here and below |
@@ -84,6 +84,9 @@ namespace Dynamo.Extensions
return result;
}
+ /// <summary>
+ /// Logs messages
+ /// </summary>
public event Action<ILogMessage> MessageLogged;
private void Log(ILogMessage obj)
| [ExtensionLoader->[Log->[Info,Log,MessageLogged],IExtension->[GetElementsByTagName,Message,Count,Name,Combine,AssemblyPath,InnerText,ChildNodes,Log,CreateInstance,GetDirectoryName,TypeName,StackTrace,LoadFrom,Load],LoadDirectory->[GetFiles,Add,Exists,Load]]] | Load all extensions in the specified directory. | This event is used for logging messages. |
@@ -316,13 +316,13 @@ function qFactory(nextTick, exceptionHandler, errorOnUnhandledRejections) {
if (isUndefined(onFulfilled) && isUndefined(onRejected) && isUndefined(progressBack)) {
return this;
}
- var result = new Deferred();
+ var result = new Promise();
this.$$state.pen... | [No CFG could be retrieved] | Creates a promise manager which can be used to resolve or reject a task which will finish in Simple bind function that takes a context and a function that will be called when a value is. | This was here before but why are `catch` and `finally` defined with strings and `then` is not? |
@@ -1,4 +1,4 @@
-/* Copyright 2019 MechMerlin
+/* Copyright 2020 Flexerm
*
* This program is free software: you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
| [No CFG could be retrieved] | Macro for the keymaps Macro to handle the color layout. ______ = > _______. | lol, i'd appreciate if you just add your name rather than removing mine. |
@@ -1581,13 +1581,7 @@ namespace Internal.TypeSystem.Interop
class AnsiStringMarshaller : Marshaller
{
- internal override bool CleanupRequired
- {
- get
- {
- return true;
- }
- }
+ const int MAX_LOCAL_BUFFER_LENGTH = 256; // TODO:... | [No CFG could be retrieved] | Package protected for testing purposes. 9 - 10. | tried to mimic stub for `ILCSTRMarshaler` from ilmarshallers.cpp, where its marked with no CleanupRequired. |
@@ -1,8 +1,9 @@
package io.quarkus.agroal.runtime;
import io.quarkus.arc.Arc;
-import io.quarkus.arc.runtime.BeanContainer;
-import io.quarkus.arc.runtime.BeanContainerListener;
+import io.quarkus.datasource.runtime.DataSourcesBuildTimeConfig;
+import io.quarkus.datasource.runtime.DataSourcesRuntimeConfig;
+import ... | [AgroalRecorder->[configureRuntimeProperties->[setRuntimeConfig],addDataSource->[created->[setBuildTimeConfig,disableSslSupport,instance],BeanContainerListener]]] | package for agroal. | This is now longer used anymore as far as I can tell |
@@ -96,7 +96,7 @@ public class ArtifactFactoryUtils {
* @since 4.2
*/
public static Optional<MuleContext> getMuleContext(DeployableArtifact artifact) {
- return artifact != null ? artifact.getRegistry().lookupByType(MuleContext.class) : empty();
+ return artifact != null && artifact.getRegistry() != nu... | [ArtifactFactoryUtils->[getDeploymentFile->[MuleRuntimeException,createStaticMessage,format,exists,File],validateArtifactLicense->[getName,getProvider,build,validatePluginLicense,forEach,ifPresent],isConfigLess->[isEmpty],withArtifactMuleContext->[ifPresent],getMuleContext->[empty,lookupByType]]] | Get the MuleContext for the given artifact. | is this something that can really happen? |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.