patch stringlengths 18 160k | callgraph stringlengths 4 179k | summary stringlengths 4 947 | msg stringlengths 6 3.42k |
|---|---|---|---|
@@ -0,0 +1,14 @@
+class CreateAuthAppConfigurations < ActiveRecord::Migration[5.1]
+ def change
+ create_table :auth_app_configurations do |t|
+ t.integer :user_id, null: false
+ t.string :encrypted_otp_secret_key, null: false
+ t.string :name, null: false
+ t.integer :totp_timestamp
+ t.ti... | [No CFG could be retrieved] | No Summary Found. | not sure if this encrypted_otp_secret_key index is needed |
@@ -550,7 +550,8 @@ def analyze_var(name: str,
return mx.chk.handle_partial_var_type(typ, mx.is_lvalue, var, mx.context)
if mx.is_lvalue and var.is_property and not var.is_settable_property:
# TODO allow setting attributes in subclass (although it is probably an error)
- mx... | [analyze_none_member_access->[_analyze_member_access,builtin_type],analyze_union_member_access->[_analyze_member_access,copy_modified],type_object_type->[builtin_type],analyze_var->[analyze_descriptor_access,not_ready_callback],analyze_type_callable_member_access->[_analyze_member_access],MemberContext->[copy_modified-... | Analyze a variable via a Var node. A function which returns a if A1 < = B1. | how about `if '__setattr__' not in info.names:` |
@@ -654,7 +654,7 @@ struct comp_driver comp_keyword = {
},
};
-static void sys_comp_keyword_init(void)
+UT_STATIC void sys_comp_keyword_init(void)
{
comp_register(&comp_keyword);
}
| [No CFG could be retrieved] | region System Component Keyword. | Looks like this + changes in src/include/sof/audio/detect_test.h are fix for making symbol accessible from tests. Can it be done in separate commit? First fix then refactor? |
@@ -129,8 +129,15 @@ public class SparkSqlInterpreter extends Interpreter {
sc.setLocalProperty("spark.scheduler.pool", null);
}
+ Object rdd = null;
+ try {
+ Method sqlMethod = sqlc.getClass().getMethod("sql", String.class);
+ rdd = sqlMethod.invoke(sqlc, st);
+ } catch (NoSuchMethodE... | [SparkSqlInterpreter->[getProgress->[getJobGroup],getScheduler->[concurrentSQL,getScheduler],getProgressFromStage_1_0x->[getProgressFromStage_1_0x],getProgressFromStage_1_1x->[getProgressFromStage_1_1x],cancel->[getJobGroup],getSparkInterpreter->[open],interpret->[concurrentSQL]]] | Interprets a Zeppelin statement. | Would you elaborate on why we would need to do this? Curious - isn't SQLContext always has the sql() method? |
@@ -446,6 +446,8 @@ class Scaffold_Command extends WP_CLI_Command {
if ( isset( $assoc_args['activate'] ) ) {
WP_CLI::run_command( array( 'plugin', 'activate', $plugin_slug ) );
+ } else if ( isset( $assoc_args['activate-network'] ) ) {
+ WP_CLI::run_command( array( 'plugin', 'activate', $plugin_slug), arra... | [Scaffold_Command->[plugin->[create_file,maybe_create_plugins_dir],plugin_tests->[chmod,copy,create_file,init_wp_filesystem,mkdir],post_type->[_scaffold],_s->[maybe_create_themes_dir,init_wp_filesystem],create_file->[put_contents,init_wp_filesystem,mkdir],package_tests->[run],child_theme->[create_file,maybe_create_them... | Plugin main function. | Why is this code in this PR? |
@@ -109,6 +109,7 @@ public abstract class HoodieBackedTableMetadataWriter implements HoodieTableMeta
protected boolean enabled;
protected SerializableConfiguration hadoopConf;
protected final transient HoodieEngineContext engineContext;
+ protected final List<MetadataPartitionType> enabledPartitionTypes;
... | [HoodieBackedTableMetadataWriter->[bootstrapCommit->[commit],update->[processAndCommit],processAndCommit->[convertMetadata],bootstrapFromFilesystem->[initTableMetadata],close->[close]]] | Abstract class for writing a single record to the Hoodie table. | We should track `enabledPartitions` not just partition types. i.e this layer should have the ability for writers to create even multiple bloom filter partitions, to track say a secondary key's bloom filters as well |
@@ -7,7 +7,7 @@ module Engine
class TileLay < Base
attr_reader :hexes, :tiles, :free, :discount, :special, :connect, :blocks, :reachable
- def setup(hexes:, tiles:, free: false, discount: nil, special: nil,
+ def setup(tiles:, hexes: nil, free: false, discount: nil, special: nil,
... | [TileLay->[setup->[nil?],attr_reader],require_relative] | Sets up the object with the given parameters. | How is this change tied to the PR? |
@@ -63,7 +63,11 @@ namespace Microsoft.Xna.Framework.Audio
// Only used from XACT WaveBank.
internal SoundEffect(MiniFormatTag codec, byte[] buffer, int channels, int sampleRate, int blockAlignment, int loopStart, int loopLength)
- {
+ {
+ Initialize();
+ if (_sys... | [SoundEffect->[Play->[Play,Pitch,Pan,Volume,GetPooledInstance],TimeSpan->[Zero,FromSeconds],GetSampleSizeInBytes->[FromMilliseconds,TotalSeconds,Zero],Dispose->[PlatformDispose,StopPooledInstances,SuppressFinalize,Dispose],SoundEffectInstance->[PlatformSetupInstance,_isPooled,GetInstance,_effect,SoundsAvailable],Platfo... | Creates a new sound effect from a byte array. This method creates a SoundEffect object for a single . | These should maybe throw? |
@@ -1252,7 +1252,9 @@ class ServiceBusQueueAsyncTests(AzureMgmtTestCase):
message_1st_received_cnt = 0
message_2nd_received_cnt = 0
while message_1st_received_cnt < 20 or message_2nd_received_cnt < 20:
- messages = await receiver.receive_messages(max... | [ServiceBusQueueAsyncTests->[test_async_queue_receive_batch_without_setting_prefetch->[message_content]]] | Test async queue receive batch without prefetching. | Actually the intention of this test case is to test the method `receive_messages` to see batch receiving is working as expected. I think it should not be causing errors in CI after I tweaked it last time, or it's still failing consistently? |
@@ -91,8 +91,8 @@ def test_walk_files(remote):
def test_copy_preserve_etag_across_buckets(cloud, dvc):
cloud.gen(FILE_WITH_CONTENTS)
rem = _get_odb(dvc, cloud.config)
- s3 = rem.fs
- s3.fs.mkdir("another/")
+ s3 = rem.fs.s3
+ s3.create_bucket(Bucket="another")
config = cloud.config.copy()
... | [test_isdir->[isdir],test_walk_files->[list,walk_files],test_exists->[exists],test_isfile->[isfile],test_download_dir->[,PathInfo,list,isdir,download,len,str,walk_files],test_copy_preserve_etag_across_buckets->[_get_odb,S3FileSystem,PATH_CLS,copy,gen,mkdir,info],remote->[_get_odb,gen],parametrize,lazy_fixture] | Test copy preserve etag across buckets. | The `s3.fs.mkdir` was failing locally for me, though I am not sure why. I replaced this with the one that shares the intention in a better way, which passes both locally and in CI. |
@@ -299,7 +299,7 @@ func GetBootstrapClusterRoles() []authorizationapi.ClusterRole {
{Verbs: sets.NewString("get"), Resources: sets.NewString("users"), ResourceNames: sets.NewString("~")},
{Verbs: sets.NewString("list"), Resources: sets.NewString("projectrequests")},
{Verbs: sets.NewString("list", "get")... | [NormalizeResources,Sprintf,AllRoles,NewString] | Rules for the given policy. Status checker role. | Does this mean that only a basic user can watch projects? |
@@ -697,6 +697,14 @@ dsl_scan_setup_sync(void *arg, dmu_tx_t *tx)
ASSERT(!dsl_scan_is_running(scn));
ASSERT(*funcp > POOL_SCAN_NONE && *funcp < POOL_SCAN_FUNCS);
bzero(&scn->scn_phys, sizeof (scn->scn_phys));
+
+ /*
+ * If we are starting a fresh scrub. We erase error scrub information
+ * from disk.
+ */
+ bz... | [No CFG could be retrieved] | Setup the DSS scan Initialize the DDT scans. Returns true if the current user is a member of the list of user s users. | "If we are starting a fresh scrub, we erase error scrub information from disk." |
@@ -59,11 +59,11 @@ export default class TableData extends Dataset {
if (i === 0) {
columnNames.push({name: col, index: j, aggr: 'sum'});
} else {
- let valueOfCol;
- if (!isNaN(valueOfCol = parseFloat(col)) && isFinite(col)) {
- col = valueOfCol;
+ let... | [No CFG could be retrieved] | This function is used to create a n - ary object from the data in the table. | not sure - if valueOfCol is returned by Number, would it be outside of range of `valueOfCol > Number.MAX_SAFE_INTEGER || valueOfCol < Number.MIN_SAFE_INTEGER`? |
@@ -270,8 +270,14 @@ cont_iv_ent_update(struct ds_iv_entry *entry, struct ds_iv_key *key,
int rc;
D_ASSERT(dss_get_module_info()->dmi_xs_id == 0);
- memcpy(&root_hdl, entry->iv_value.sg_iovs[0].iov_buf, sizeof(root_hdl));
+ if (entry->iv_class->iv_class_id == IV_CONT_CAPA) {
+ rc = cont_iv_capa_ent_update(entr... | [No CFG could be retrieved] | - - - - - - - - - - - - - - - - - - find the entry in the dbtree that matches the specified key. | (style) trailing whitespace |
@@ -508,10 +508,10 @@ namespace Content.Server.GameTicking
return false;
}
- _roundStartTimeUtc += time;
+ _roundStartTimeTicks += time.Ticks;
var lobbyCountdownMessage = _netManager.CreateNetMessage<MsgTickerLobbyCountdown>();
- lobbyCount... | [GameTicker->[ToggleDisallowLateJoin->[UpdateLateJoinStatus],SetStartPreset->[SetStartPreset,TryGetPreset,StartRound],SpawnPlayer->[SpawnPlayer,ApplyCharacterProfile,MakeObserve],Initialize->[Initialize],PlayerStatusChanged->[PlayerStatusChanged],TogglePause->[PauseStart],StartRound->[RestartRound,ReqWindowAttentionAll... | Delays the start of the round. | At this point, just change that to use `TimeSpan`... |
@@ -25,6 +25,7 @@ const Mocha = require('mocha');
const tryConnect = require('try-net-connect');
const {cyan} = require('ansi-colors');
const {execOrDie, execScriptAsync} = require('../../exec');
+const {reportTestStarted} = require('../runtime-test/status-report');
const {watch} = require('gulp');
const HOST = ... | [No CFG could be retrieved] | Creates a new and launches a web server if it is not already running. Function to create a promise that resolves when the is found. | nit: move `status-report.js` file out of `tasks/runtime-test` |
@@ -54,7 +54,7 @@ class ExportDirtyTest(unittest.TestCase):
self.client.run("export . lasote/stable")
self.client.run("install Hello0/0.1@lasote/stable --build")
ref = ConanFileReference.loads("Hello0/0.1@lasote/stable")
- source_path = self.client.cache.source(ref)
+ source_pat... | [SourceDirtyTest->[test_keep_failing_source_folder->[source,TestClient,assertEqual,assertIn,replace,run,join,save,loads,listdir,load]],ExportDirtyTest->[test_install_remove->[system,assertIn,run,close,assertFalse],test_export_remove->[system,assertIn,run,close,assertFalse],setUp->[assertTrue,system,files,source,write,T... | Sets up the necessary files for the test. | `self._cache.source(ref, short_paths=False)` vs `self._cache.package_layout(ref, short_paths=None).source()` |
@@ -556,6 +556,9 @@ func (d *Service) hourlyChecks() {
d.G().Log.Debug("+ hourly check loop")
d.G().Log.Debug("| checking tracks on an hour timer")
libkb.CheckTracking(d.G())
+ d.G().Log.Debug("| checking if ephemeral keys need to be created or deleted")
+ ekLib := d.G().GetEKLib()
+ ekLib.KeygenIfNee... | [GetExclusiveLock->[GetExclusiveLockWithoutAutoUnlock,ReleaseLock],stopProfile->[Stop],OnLogout->[stopChatModules],OnLogin->[identifySelf,runBackgroundIdentifierWithUID,startChatModules,runTLFUpgrade],writeServiceInfo->[ensureRuntimeDir],StartStandaloneChat->[createChatModules,startChatModules,startupGregor],GetExclusi... | hourlyChecks is a long running routine that checks for a device and logs in if it. | It looks like this happens an hour after startup. Should we be more aggressive? |
@@ -19,8 +19,9 @@ from parlai.core.params import ParlaiParser
from parlai.agents.repeat_label.repeat_label import RepeatLabelAgent
from parlai.core.worlds import create_task
from parlai.core.utils import msg_to_str
-
import random
+import tempfile
+from tqdm import tqdm
def dump_data(opt):
| [main->[add_argument,ParlaiParser,parse_args,set_defaults,seed,dump_data],dump_data->[write,parley,print,RepeatLabelAgent,close,epoch_done,get,msg_to_str,create_task,acts,open,range],main] | dump data from repeat label agent to file. | what was wrong with /tmp/dump? what does this do? |
@@ -52,6 +52,11 @@ import org.jboss.logging.Logger;
* consumers */
public class CoreMessage extends RefCountMessage implements ICoreMessage {
+ // We use properties to establish routing context on clustering.
+ // However if the client resends the message after receiving, it needs to be removed
+ private st... | [CoreMessage->[getDoubleProperty->[checkProperties,getDoubleProperty],getObjectProperty->[checkProperties,getObjectProperty],getPropertyKeysPool->[getPropertyKeysPool],putCharProperty->[checkProperties,messageChanged,putCharProperty],getPropertyNames->[checkProperties,getPropertyNames],getShortProperty->[checkPropertie... | Imports the given message. The message is not a message itself but it is a message itself. | @clebertsuconic Do you know of any other way (faster) to know if a `CoreMessage` it is seen for the first time ie not a resent message? |
@@ -131,7 +131,7 @@ public class NuageVspGuestNetworkGuru extends GuestNetworkGuru {
public NuageVspGuestNetworkGuru() {
super();
- _isolationMethods = new IsolationMethod[] {IsolationMethod.VSP};
+ _isolationMethods = new IsolationMethod[] {new IsolationMethod("VSP")};
}
@Over... | [NuageVspGuestNetworkGuru->[deallocate->[deallocate],implement->[implement],shutdown->[shutdown],reserve->[implement],allocate->[allocate],design->[design],getDefaultHasDns->[networkHasDns],trash->[trash]]] | Override design to set broadcast domain type to VSP if offering is not supported on the. | I would prefer defining the IsolationMethod as a constant instead, so we can replace PhysicalNetwork.IsolationMethod.VSP.name() with VSP_ISOLATION.getMethodPrefix() |
@@ -311,11 +311,14 @@ class WikiTablesSemanticParser(Model):
@classmethod
def from_params(cls, vocab, params: Params) -> 'WikiTablesSemanticParser':
- source_embedder_params = params.pop("source_embedder")
- source_embedder = TextFieldEmbedder.from_params(vocab, source_embedder_params)
+ ... | [WikiTablesSemanticParser->[from_params->[from_params]]] | Constructs a new SemanticParser from a set of params. | You can pass size to `new`. |
@@ -185,6 +185,9 @@ def _cwt_fft(X, Ws, mode="same", decim=1):
"""Compute cwt with fft based convolutions
Return a generator over signals.
"""
+ if mode not in ['same', 'valid', 'full']:
+ raise ValueError("`mode` must be 'same', 'valid' or 'full', "
+ "got %s instead." ... | [AverageTFR->[plot->[_preproc_tfr],__iadd__->[_check_compat],__isub__->[_check_compat],__add__->[_check_compat],__sub__->[_check_compat],plot_topo->[_preproc_tfr]],_induced_power_cwt->[morlet],_time_frequency->[_cwt_fft,_cwt_convolve],tfr_morlet->[AverageTFR,_induced_power_cwt,_get_data],tfr_multitaper->[_prepare_picks... | Compute cwt with fft based convolutions Return a generator over signals. | Since I changed L211, the mode isn't explicit. I added the check to ensure an explicit mode. |
@@ -49,7 +49,7 @@ class MissingNonce(NonceError):
def __str__(self):
return ('Server {0} response did not include a replay '
- 'nonce, headers: {1}'.format(
+ 'nonce, headers: {1}\n(This may be a service outage)'.format(
self.response.request.method, se... | [BadNonce->[__str__->[],__init__->[super]],PollError->[__repr__->[],__init__->[super],timeout->[bool]],MissingNonce->[__str__->[format],__init__->[super]]] | Return a string representation of the response. | nit: I think we should remove the newline. None of the other exceptions in the `acme` library contain a newline and I think it is a bit odd to have it there. We don't really want the newline in log files for example. Also, we could potentially catch `MissingNonce` errors at a higher level in the client and provide a be... |
@@ -1768,6 +1768,17 @@ export class AmpA4A extends AMP.BaseElement {
isVerifiedAmpCreative() {
return this.isVerifiedAmpCreative_;
}
+
+ /**
+ * Returns a promise that will resolve when the friendly iframe's window's
+ * `onload` event has been emitted.
+ * @return {!Promise}
+ */
+ onFriendlyIfram... | [AmpA4A->[extractSize->[user,get,Number],tryExecuteRealTimeConfig_->[user,RealTimeConfigManager],constructor->[AmpAdUIHandler,AmpAdXOriginIframeHandler,dev,generateSentinel,getBinaryTypeNumericalCode,getBinaryType,now],tearDownSlot->[dev],renderViaNameAttrOfXOriginIframe_->[NAMEFRAME,utf8Decode,dev,checkStillCurrent,us... | isVerifiedAmpCreative - check if the sequence number is a creative. | Apologies, I'm changing my mind on this as I want to make sure this function is only called at the appropriate point in the lifecycle. Can you instead modify onCreativeRender to provide an additional parameter which is an onLoadPromise. You can decide if you want that to be populated if FIE and non-FIE (just listen for... |
@@ -142,14 +142,12 @@ namespace System.ComponentModel.Design
{
if (disposing && _serviceProvider != null)
{
- IDesignerHost host = (IDesignerHost)_serviceProvider.GetService(typeof(IDesignerHost));
- if (host != null)
+ if (_serviceProvider... | [DesignerActionService->[Clear->[Clear,Add],Add->[Add],GetComponentDesignerActions->[Add],Contains->[Contains],Remove->[Remove,OnDesignerActionListsChanged,Add,Contains],Dispose->[Dispose]]] | This method is called when the component is removed from the system. | #817 and below |
@@ -876,10 +876,6 @@ public class InvokeHTTP extends AbstractProcessor {
int statusCode = responseHttp.code();
String statusMessage = responseHttp.message();
- if (statusCode == 0) {
- throw new IllegalStateException("Status code unknown, connection ... | [InvokeHTTP->[convertAttributesFromHeaders->[csv],OverrideHostnameVerifier->[verify->[verify]]]] | This method is called when a request cycle is triggered. This method retrieves the response from the server and stores it in the session. This method creates a new object and stores the response body into the response flowfile. | Not sure why but I imagine this was here for some reasons. Do we think this is safe to remove? |
@@ -22,8 +22,10 @@ from nni.algorithms.hpo.pbt_tuner import PBTTuner
from nni.algorithms.hpo.regularized_evolution_tuner import RegularizedEvolutionTuner
from nni.runtime.msg_dispatcher import _pack_parameter, MsgDispatcher
-if sys.platform != 'win32':
+smac_imported = False
+if sys.platform != 'win32' and sys.vers... | [BuiltinTunersTestCase->[test_gp->[search_space_test_all,import_data_test],test_smac->[search_space_test_all,import_data_test],search_space_test_one->[send_trial_result,send_trial_callback],test_random_search->[search_space_test_all,import_data_test],test_metis->[search_space_test_all,import_data_test],test_dngo->[sear... | Creates a class which can be used to test a single object. This function is a decorator that receives the parameter_id parameters and metrics from the nas. | SMAC only works under 3.9? |
@@ -78,8 +78,12 @@ func NewProvider(host Host, ctx *Context, pkg tokens.Package, version *semver.Ve
})
}
- plug, err := newPlugin(ctx, ctx.Pwd, path, fmt.Sprintf("%v (resource)", pkg),
- []string{host.ServerAddr()}, nil /*env*/)
+ args := []string{host.ServerAddr()}
+ for k, v := range options {
+ args = appen... | [DiffConfig->[label,DiffConfig],Check->[label,getClient,Check],Create->[label,Create,getClient],Delete->[label,Delete,getClient],Invoke->[label,Invoke,getClient],StreamInvoke->[label,StreamInvoke,getClient],Update->[label,Update,getClient],GetPluginInfo->[label,GetPluginInfo],CheckConfig->[label,CheckConfig],GetSchema-... | NewProvider creates a new instance of a resource provider. ConfigLogicallyUnimplemented returns true when an rpc is unimplemented. | To make this work for dynamic providers in Python, I needed some way to pass the `virtualenv` runtime option to the `pulumi-resource-pulumi-python` provider plugin. This change passes along all runtime options as command line flags to providers. Are we OK doing this? (I looked and all _our_ providers should be able to ... |
@@ -18,6 +18,12 @@ import {adConfig} from '../../ads/_config';
describe('test-ads-config', () => {
+ it('should have all ad networks configured', () => {
+ window.ampTestRuntimeConfig.adTypes.forEach(adType => {
+ expect(adConfig, `Missing config for [${adType}]`).to.contain.key(adType);
+ });
+ });
+... | [No CFG could be retrieved] | Plots an example of what is unique within the AMP HTML Authors. check duplicates. | I removed the check for `_ping_` because I think that's not important at all, itself is for test only. |
@@ -404,6 +404,14 @@ func (dc *deployCmd) run() error {
return errors.Wrapf(err, "in SetPropertiesDefaults template %s", dc.apimodelPath)
}
+ // Validate image
+
+ err = dc.validateDependencies(context.Background())
+
+ if err != nil {
+ return errors.Wrapf(err, "Validating dependencies %s", dc.apimodelPath)
+ ... | [validateArgs->[LoadTranslations,IsNotExist,NormalizeAzureRegion,Stat,New,Usage,Errorf,Wrap],loadAPIModel->[LoadContainerServiceFromFile,SetCustomCloudProfileEnvironment,UnixNano,NewSource,ReadFile,IsAzureStackCloud,New,Now,getAuthArgs,validateAuthArgs,getClient,Wrap],validateAPIModelAsVLabs->[Validate,ConvertContainer... | run runs the deployment Unmarshal takes a template and parameters and attempts to deploy it. | nit: less vert spacing. Again, spaces after braces. |
@@ -2068,12 +2068,11 @@ namespace System.Reflection.Metadata
void System.IDisposable.Dispose() { }
}
}
- [System.ComponentModel.EditorBrowsableAttribute(System.ComponentModel.EditorBrowsableState.Never)]
public static partial class PEReaderExtensions
{
public static Syst... | [ManagedPEBuilder->[ILOnly],PEReaderExtensions->[Never],PEHeaderBuilder->[TerminalServerAware,NoSeh,Unknown,Dll,DynamicBase,NxCompatible,WindowsCui],MetadataReaderProvider->[FromMetadataStream->[Default],GetMetadataReader->[Default],FromPortablePdbStream->[Default]],BlobEncoder->[MethodSignature->[Default]],MethodBodyS... | Get the metadata reader. | Might not intended change |
@@ -375,6 +375,12 @@ class PTransform(WithTypeHints, HasDisplayData):
p = pipeline.Pipeline(
'DirectRunner', PipelineOptions(sys.argv))
else:
+ if any(getattr(p, 'is_ephemeral', False) for p in pipelines):
+ raise ValueError(
+ 'Re-using PCollection(s) from previous implici... | [get_nested_pvalues->[_GetPValues],_ZipPValues->[visit->[visit],visit_dict->[visit],visit_sequence->[visit]],PTransform->[register_urn->[register],type_check_inputs_or_outputs->[_ZipPValues],__ror__->[_MaterializePValues,_SetInputPValues],_extract_input_pvalues->[_dict_tuple_leaves->[_dict_tuple_leaves],_dict_tuple_lea... | This function is used to perform a non - PTransform operation on a list of PValues. | should this be `True`? |
@@ -1825,11 +1825,12 @@ class ApacheConfigurator(common.Configurator):
######################################################################
# Enhancements
######################################################################
- def supported_enhancements(self):
+ def supported_enhancements(self) ... | [ApacheConfigurator->[perform->[restart,perform],get_virtual_hosts_v1->[_create_vhost],install_ssl_options_conf->[pick_apache_config],prepare->[_prepare_options],add_vhost_id->[_find_vhost_id],_add_name_vhost_if_necessary->[save,is_name_vhost,add_name_vhost],_enable_redirect->[save],_set_http_header->[save],cleanup->[r... | Returns a list of supported enhancements. | `options` should be `Optional[str]`. |
@@ -216,7 +216,7 @@ public class KafkaIndexTaskClient
}
catch (IOException | InterruptedException e) {
log.error("Exception [%s] while pausing Task [%s]", e.getMessage(), id);
- throw Throwables.propagate(e);
+ throw new RuntimeException(e);
}
}
| [KafkaIndexTaskClient->[getStatusAsync->[call->[getStatus]],pause->[pause],resumeAsync->[call->[resume]],getStartTimeAsync->[call->[getStartTime]],getCurrentOffsetsAsync->[call->[getCurrentOffsets]],getCheckpointsAsync->[getCheckpoints],setEndOffsetsAsync->[call->[setEndOffsets]],submitRequest->[TaskNotRunnableExceptio... | Pause a task. can be called from a thread that has not started a task. | it is odd to log and throw. Such a thing usually leads to double logging. Would it make more sense just to put the log message in the `RuntimeException`? |
@@ -15,6 +15,13 @@ import torch.nn.functional as F
import torch.optim as optim
from torchvision import datasets, transforms
+# Temporary patch this example until the MNIST dataset download issue get resolved
+# https://github.com/pytorch/vision/issues/1938
+import urllib
+
+opener = urllib.request.build_opener()
+o... | [train->[train],main->[Net,train,test],get_params,main] | Deep MNIST classifier using convolutional layers. Train and test functions. | do we still need this fix? |
@@ -81,9 +81,10 @@ class SiteConfig < RailsSettings::Base
field :rate_limit_reaction_creation, type: :integer, default: 10
field :rate_limit_image_upload, type: :integer, default: 9
field :rate_limit_email_recipient, type: :integer, default: 5
- field :rate_limit_article_update, type: :integer, default: 150
+... | [SiteConfig->[cache_prefix,available,field,table_name]] | Fields of the report that are not part of the report. Protected get - email - digest - frequency - frequency. | Just a thought, are we not able to read the default from rate_limit_checker_helper.rb here, so that they stay in sync? |
@@ -186,7 +186,7 @@ static int codec_adapter_prepare(struct comp_dev *dev)
*/
uint32_t buff_size; /* size of local buffer */
- comp_info(dev, "codec_adapter_prepare() start");
+ comp_dbg(dev, "codec_adapter_prepare() start");
/* Init sink & source buffers */
cd->ca_sink = list_first_item(&dev->bsink_... | [No CFG could be retrieved] | This function prepares a single component of type codec_adapter_type. Check if the given component has already been prepared. | do we really want these not very frequent logs to be dbg? I would keep it as it is. |
@@ -40,6 +40,7 @@ if TYPE_CHECKING:
from azure.core.pipeline import Pipeline
from azure.core.pipeline.transport import HttpRequest
from azure.core.configuration import Configuration
+T = Optional[Union[BearerTokenCredentialPolicy, SharedKeyCredentialPolicy]]
_LOGGER = logging.getLogger(__name__)
| [AsyncTransportWrapper->[send->[send]],AsyncStorageAccountHostsMixin->[__aexit__->[__aexit__],__aenter__->[__aenter__],close->[close]]] | Creates a Pipeline from a SharedKey object. Sets the credential policy. | Rename it to something more explicit, it gives the impression that it's a generic, but it's not. Example `OptionalStorageCredentials` |
@@ -42,4 +42,8 @@ from . import simulation
from . import stats
from . import tests
from . import time_frequency
-from . import viz
\ No newline at end of file
+from . import viz
+
+# deal with logging
+set_log_level()
+set_log_file()
| [No CFG could be retrieved] | Imports the n - tuple from. | It would be nice to be able to use environment variable, e.g., MNE_LOG_LEVEL, to set the default log level, WDYT? |
@@ -29,8 +29,8 @@ type Team struct {
keyManager *TeamKeyManager
- me *libkb.User
- rotated bool
+ meForSignature libkb.UserForSignatures
+ rotated bool
}
func NewTeam(ctx context.Context, g *libkb.GlobalContext, teamData *keybase1.TeamData) *Team {
| [Generation->[chain],IsPublic->[IsPublic,chain],HasActiveInvite->[chain,HasActiveInvite],getAdminPermission->[traverseUpUntil,chain],rotateBoxes->[EncryptionKey,IsSubteam,Members],postInvite->[IsSubteam,HasActiveInvite],EncryptionKey->[EncryptionKey,getKeyManager],InviteSeitanV2->[Name],isAdminOrOwner->[chain],downgrad... | Teams like NewTeam but returns a new Team object. Get the key manager for the current generation. | This field still starts out unset. Make it a pointer. Having `nil` is less likely to be accidentally used than a blank `libkb.UserForSignatures` |
@@ -142,7 +142,7 @@ class Order(models.Model, ItemSet):
Price(0, currency=settings.DEFAULT_CURRENCY))
def send_confirmation_email(self):
- email = self.get_user_email()
+ email = self.user_email
payment_url = build_absolute_uri(
reverse('order:details', kwa... | [OrderedItem->[change_quantity->[save,get_total_quantity,change_status,get_items],OrderedItemManager],DeliveryGroup->[can_ship->[is_shipping_required],change_status->[save]],Payment->[get_purchased_items->[get_items],send_confirmation_email->[get_user_email],PaymentManager],Order->[send_confirmation_email->[get_user_em... | Send confirmation email to user. | Not sure about this change. There is no way to change this email for logged in users. |
@@ -46,12 +46,12 @@ public final class NettyClientInstrumenterFactory {
.newClientInstrumenter(new HttpRequestHeadersSetter());
}
- public NettyConnectInstrumenter createConnectInstrumenter() {
+ public NettyConnectionInstrumenter createConnectionInstrumenter() {
NettyConnectNetAttributesExtractor ... | [NettyClientInstrumenterFactory->[createConnectInstrumenter->[alwaysInternal,newInstrumenter,NettyConnectNetAttributesExtractor,NettyConnectInstrumenterImpl,NettyErrorOnlyConnectInstrumenter,alwaysClient],createHttpInstrumenter->[NettyHttpClientAttributesExtractor,NettyNetClientAttributesExtractor,HttpRequestHeadersSet... | Creates a new HTTP instrumentation. | I sort of see these as two different instrumenters, one for resolve and one for connect, but ok with this too |
@@ -59,6 +59,14 @@ class Payment(models.Model):
order = models.ForeignKey(
"order.Order", null=True, related_name="payments", on_delete=models.PROTECT
)
+ create_order = models.BooleanField(
+ blank=True,
+ null=True,
+ help_text=(
+ "Indicates whether a payment sho... | [Transaction->[get_amount->[Money],CharField,JSONField,DateTimeField,ForeignKey,DecimalField,Decimal,BooleanField],Payment->[get_last_transaction->[all,attrgetter,max],Meta->[GinIndex],get_total->[Money],get_authorized_amount->[Money,all,any,zero_money],get_captured_amount->[Money],CharField,PositiveIntegerField,MinVal... | Required field for editing a specific . Creates a CharField for all Header - related fields. | It seems to duplicate `complete_order` that I added earlier on? |
@@ -241,7 +241,7 @@ namespace System.Xml.Xsl.Qil
protected virtual QilNode VisitReference(QilNode n)
{
if (n == null)
- return VisitNull();
+ return VisitNull()!;
return n.NodeType switch
{
| [QilVisitor->[QilNode->[VisitRawTextCtor,VisitBranchList,Or,VisitAfter,AttributeCtor,RtfCtor,VisitFunctionList,GlobalParameterList,VisitLiteralDecimal,VisitXPathNamespace,XmlContext,Minimum,NamespaceDecl,VisitNamespaceUriOf,XsltCopyOf,VisitAncestor,Divide,VisitSubtract,NodeType,Maximum,VisitError,Conditional,Sequence,V... | Visit a reference node in the tree. | I already mentioned this on overrides. Why `!` instead of returning/accepting `QilNode?`? |
@@ -61,8 +61,7 @@ def update_ema(biased_ema, value, decay, step):
float, float
"""
biased_ema = biased_ema * decay + (1 - decay) * value
- unbiased_ema = biased_ema / (1 - decay ** step) # Bias correction
- return biased_ema, unbiased_ema
+ return biased_ema
def update_quantization_param(... | [DoReFaQuantizer->[quantize_weight->[get_bits_length]],QAT_Quantizer->[quantize_weight->[get_bits_length,_quantize,_dequantize,update_quantization_param],quantize_output->[get_bits_length,_dequantize,update_ema,_quantize,update_quantization_param]]] | Update the EMA of a node. Missing zero point in the range of the zero - point. | It seems we no longer need `step`, remove it from parameter? And just curious, compared with before, don't using `unbiased_ema` will cause something different situation? |
@@ -154,6 +154,12 @@ def make_app(build_dir: str = None, demo_db: Optional[DemoDatabase] = None) -> F
if request.method == "OPTIONS":
return Response(response="", status=200)
+ # Do log if no argument is specified
+ record_flag = not request.args.get("record", "true").lower() == "f... | [make_app->[predict->[_caching_prediction,ServerError],permadata->[ServerError],handle_invalid_usage->[to_dict]],ServerError->[__init__->[__init__]]] | Create a Flask application with a single object. This route handles the prediction of a single n - ary object. Get the n - node node id from the model. This action returns a list of all the verbs of a model that has semantic parses. | `!=` would be more idiomatic (and more readable) than `not ==` |
@@ -95,9 +95,13 @@ class BooleanAccuracy(Metric):
accuracy = float(self._correct_count) / float(self._total_count)
else:
accuracy = 0.0
+ if world_size > 1:
+ accuracy_tensor = torch.tensor(accuracy).to(cuda_device)
+ dist.all_reduce(accuracy_tensor, op=di... | [BooleanAccuracy->[__call__->[,size,detach_tensors,sum,eq,ValueError,ones,view],get_metric->[float,reset]],register] | Returns the accumulated accuracy. | This is only correct if each worker has the same `self._total_count`, right? Can we rely on that? |
@@ -28,7 +28,7 @@ namespace System
// abstractions where reasonably possible.
Span<char> buffer = stackalloc char[32];
- int length = Interop.Kernel32.GetEnvironmentVariable(environmentName, buffer);
+ uint length = Interop.Kernel32.GetEnvironmentVariable(environmentNam... | [CLRConfig->[GetBoolValueWithFallbacks->[GetBoolValue]]] | This method is a specialized version of GetBoolValue that uses the fallbacks to determine if. | Out of interest, why did you use `GetPinnableReference` and not `MemoryMarshal.GetReference` as we know `buffer`'s length is > 0, so no null-ref will occur? IMHO the code as you wrote is more readable (with the instance method), and perf-wise there won't be any measurable difference. |
@@ -173,9 +173,8 @@ class CUB200(Dataset):
)
image_files_dp = CSVParser(image_files_dp, dialect="cub200")
- image_files_map = dict(
- (image_id, rel_posix_path.rsplit("/", maxsplit=1)[1]) for image_id, rel_posix_path in image_files_dp
- )
+ ima... | [CUB200->[_2011_classify_archive->[Path],_2011_segmentation_key->[Path,with_suffix],resources->[HttpResource],_make_info->[dict,DatasetInfo],_2010_load_ann->[int,read_mat,Feature,dict,BoundingBox],_2011_load_ann->[decoder,Feature,dict,BoundingBox,float],_2010_split_key->[rsplit],_generate_categories->[path_comparator,r... | Create a data pipe from a list of resource DPS and a list of segmentation DPs Returns a Mapper that maps all the keys in the nanoseconds table to the corresponding data in. | What we can do here is a `in_memory_cache` over `image_files_dp`. Then, we could add an API to convert a `IterDataPipe` to a lazy loaded `MapDataPipe` to represent the `LazyDict`. If we use `LazyDict` here, I have concern that `image_files_map` would be missing from the DataLoader graph. cc: @VitalyFedyunin |
@@ -92,6 +92,12 @@ func (s *Store) Start() error {
return s.TxManager.ActivateAccount(acc)
}
+// Stop shuts down all of the working parts of the store.
+func (s *Store) Stop() error {
+ close(s.RunChannel)
+ return s.Close()
+}
+
// AfterNower is an interface that fulfills the `After()` and `Now()`
// methods.
... | [After->[After],EthSubscribe->[EthSubscribe],Now->[Now],Dial->[Dial],Dial] | Start initializes the store. | This will likely panic unless you can be certain that all the `Perform` goroutines are finished. |
@@ -50,7 +50,6 @@
// Builders and solvers
#include "solving_strategies/builder_and_solvers/builder_and_solver.h"
#include "solving_strategies/builder_and_solvers/residualbased_block_builder_and_solver.h"
-#include "solving_strategies/builder_and_solvers/residualbased_block_builder_and_solver_with_constraints.h"
#in... | [AddCustomStrategiesToPython->[,>]] | Includes methods related to the various strategies. - Contact residual - elimination builder - Contact residual - elimination builder - Contact residual -. | Please replace it with the new one instead of removing it |
@@ -230,9 +230,16 @@ func (a *apiServer) AddCluster(ctx context.Context, req *lc.AddClusterRequest) (
}, nil
}
+func stripSecretFromRequest(req *lc.HeartbeatRequest) *lc.HeartbeatRequest {
+ r := *req
+ r.Secret = ""
+ return &r
+}
+
func (a *apiServer) Heartbeat(ctx context.Context, req *lc.HeartbeatRequest) (re... | [GetActivationCode->[LogReq],DeleteCluster->[LogReq],AddCluster->[validateClusterConfig,checkLicenseState,LogReq],Activate->[LogReq],UpdateCluster->[validateClusterConfig,LogReq],checkLicenseState->[getLicenseRecord],Heartbeat->[LogReq],DeleteAll->[LogReq],ListClusters->[LogReq]] | AddCluster adds a new cluster to the license This is a long running routine that is called by the heartbeat goroutine. | based on the code in the Heartbeat method below, I'm making the assumption that a nil check on the request isn't necessary. Does that seem right @actgardner ? |
@@ -25,6 +25,8 @@ CT_POLICY_EVAL_CTX *CT_POLICY_EVAL_CTX_new(void)
return NULL;
}
+ // time(NULL) shouldn't ever fail, so don't bother checking for -1.
+ ctx->epoch_time_in_ms = (time(NULL) + SCT_CLOCK_DRIFT_TOLERANCE) * 1000;
return ctx;
}
| [CT_POLICY_EVAL_CTX_set1_issuer->[X509_up_ref],CT_POLICY_EVAL_CTX_free->[OPENSSL_free,X509_free],CT_POLICY_EVAL_CTX_new->[OPENSSL_zalloc,CTerr],CT_POLICY_EVAL_CTX_set1_cert->[X509_up_ref]] | Get a new CT_POLICY_EVAL_CTX object. | This will fail on 32-bit system _today_. Because all involved numbers are 32-bit integers. One of them has to be converted to uint64_t prior multiplication. |
@@ -1470,10 +1470,7 @@ class Archiver:
subparser.add_argument('--save-space', dest='save_space', action='store_true',
default=False,
help='work slower, but using less space')
- subparser.add_argument('--last', dest='last',
- ... | [main->[get_args,setup_signal_handlers,run,Archiver],with_repository->[decorator->[wrapper->[argument]]],Archiver->[do_debug_get_obj->[write],do_prune->[print_error,write],run->[_setup_topic_debugging,prerun_checks,_setup_implied_logging],do_diff->[contents_changed->[sum_chunk_size,fetch_and_compare_chunks],compare_arc... | Build the argument parser for the command line interface. command line interface for handling command line options This function is called when a user has deduplicated data from zero or more archives. command line interface to initialize a repository with a specific . | where is this prefix_spec? it is not in this changeset. |
@@ -339,6 +339,11 @@ class WPSEO_Sitemaps_Renderer {
return home_url( 'main-sitemap.xsl' );
}
+ //Fallback in case the plugin url is on a different (sub)domain.
+ if ( strpos( plugins_url(), home_url() ) !== 0 ) {
+ return home_url( 'main-sitemap.xsl' );
+ }
+
return plugin_dir_url( WPSEO_FILE ) . 'css... | [WPSEO_Sitemaps_Renderer->[sitemap_url->[encode_url_rfc3986,format_date],get_index->[sitemap_index_url],sitemap_index_url->[format_date],get_sitemap->[sitemap_url],__construct->[get_xsl_url]]] | Get the XSL url for the main - sitemap. | Please fix the codestyle of this line (missing space after `//`). |
@@ -212,10 +212,16 @@ class MediaManager implements MediaManagerInterface
return $mediaEntity;
}
- public function getByIds(array $ids, $locale)
+ public function getByIds(array $ids, $locale, UserInterface $user = null, $permission = null)
{
$media = [];
- $mediaEntities = $t... | [MediaManager->[modifyMedia->[save,getProperties,getEntityById],buildData->[save,getProperties],setDataToMedia->[get],getProperties->[get],addFormatsAndUrl->[getProperties],getCurrentUser->[getUser],getFormatUrls->[getByIds],delete->[getEntityById]]] | Get media by ids. | I would not explode the MediaManager currently with `$permission` as at current state we only need to check for Read Permission which I would directly set do in the `MediaRepository` where we call the AccessControlEnhancer. |
@@ -141,8 +141,9 @@ class AccountFileStorage(interfaces.AccountStorage):
"""
def __init__(self, config):
self.config = config
- util.make_or_verify_dir(config.accounts_dir, 0o700, compat.os_geteuid(),
- self.config.strict_permissions)
+ account_dir = co... | [AccountFileStorage->[_find_all_for_server_path->[_find_all_for_server_path],load->[_load_for_server_path],_save->[_account_dir_path,_key_path,_metadata_path,RegistrationResourceWithNewAuthzrURI,_regr_path],_load_for_server_path->[_symlink_to_accounts_dir,_key_path,_load_for_server_path,_regr_path,_metadata_path,_accou... | Initialize a missing - key object. | With the change in `configuration.py`, why do we need this? |
@@ -78,8 +78,8 @@ class InfoRequest < ActiveRecord::Base
belongs_to :info_request_batch,
:inverse_of => :info_requests
- validates_presence_of :public_body_id, :message => N_("Please select an authority"),
- :unless => Proc.new { |info_request| info_request.is... | [InfoRequest->[request_summary_categories->[embargo_expiring?],move_to_public_body->[log_event,update_counter_cache],is_old_unclassified?->[is_external?],download_zip_dir->[download_zip_dir],apply_masks->[apply_masks],user_json_for_api->[is_external?],make_zip_cache_path->[download_zip_dir],user_name->[is_external?],di... | Validate that the request s summary is valid. Has many models for user info request. | Line is too long. [116/80] |
@@ -42,6 +42,7 @@ public class OracleDbConnection extends DefaultDbConnection
private Method createArrayMethod;
private boolean initialized;
+ private Map<String, Map<Integer, ResolvedDbType>> resolvedDbTypesCache= new HashMap<>();
/**
* {@inheritDoc}
| [OracleDbConnection->[createStruct->[createStruct],createArrayOf->[createArrayOf],resolveLobs->[resolveLobs]]] | Creates an array of objects from the given array of objects. create array of type name and elements. | this cache should never be created here. It must always be received in the constructor |
@@ -99,7 +99,7 @@ class OptimizedImage < ActiveRecord::Base
# store the optimized image and update its url
File.open(temp_path) do |file|
- url = Discourse.store.store_optimized_image(file, thumbnail)
+ url, thumbnail.etag = Discourse.store.store_optimized_image(file, thumb... | [OptimizedImage->[crop_instructions->[prepend_decoder!,ensure_safe_paths!],migrate_to_new_scheme->[migrate_to_new_scheme,destroy],calculate_filesize->[local?],ensure_safe_paths!->[safe_path?],crop_instructions_animated->[ensure_safe_paths!],resize_instructions->[prepend_decoder!,ensure_safe_paths!],create_for->[lock],d... | Returns a new thumbnail object if it exists. If it does not exist it will create a create an optimized image and store it in the store. | I wouldn't worry about checking optimized image. As long as we have the original copy intact, we can regenerate the optimized image. |
@@ -2925,8 +2925,9 @@ ds_pool_query_info_handler(crt_rpc_t *rpc)
D_ERROR(DF_UUID": Failed to get rank:%u, idx:%d\n, rc:%d",
DP_UUID(in->pqii_op.pi_uuid), in->pqii_rank,
in->pqii_tgt, rc);
+ pool_svc_put_leader(svc);
D_GOTO(out, rc = -DER_NONEXIST);
- } else {
+ } else {
rc = 0;
}
| [No CFG could be retrieved] | get the target state from the pool get the from the target. | Possible change, but very minor, up to you. Suggest defining a new label out_svc just before the existing pool_svc_put_leader() call at the end of the function, and changing the D_GOTO here to specify out_svc. |
@@ -0,0 +1,15 @@
+require "rails_helper"
+
+RSpec.describe Search::ArticleSerializer do
+ let(:user) { create(:user) }
+ let(:organization) { create(:organization) }
+ let(:article) { create(:article, user: user, organization: organization) }
+
+ it "serializes an article" do
+ data_hash = described_class.new(ar... | [No CFG could be retrieved] | No Summary Found. | These serializer specs are less about checking all the fields and more about making sure every field we ask for from an article is present and we dont raise an error trying to get it. I used this spec to figure out some fields that were actually only on podcasts and not on articles. |
@@ -830,12 +830,12 @@ module.exports = class gateio extends Exchange {
// "33184.47" // Open price
// ]
//
- const timestamp = this.safeTimestamp (ohlcv, 0);
+ const timestamp = this.safeTimestamp (ohlcv, 0) || this.safeTimestamp (ohlcv, 't');
con... | [No CFG could be retrieved] | fetch Candlesticks Trades and Trades Get the order data for a given order ID. | we could use safeNumber2 here? |
@@ -0,0 +1,13 @@
+# frozen_string_literal: true
+class AddRevokedAtToApiKey < ActiveRecord::Migration[5.2]
+ def change
+ add_column :api_keys, :revoked_at, :datetime
+ add_column :api_keys, :description, :text
+
+ execute "INSERT INTO site_settings(name, data_type, value, created_at, updated_at)
+ ... | [No CFG could be retrieved] | No Summary Found. | technically I am not sure this is correct given this is a reversable migration, maybe just define the up and throw an exception on down? |
@@ -75,6 +75,7 @@ type ChainScopedConfig interface {
ChainScopedOnlyConfig
Validate() error
Configure(config evmtypes.ChainCfg) error
+ PersistedConfig() evmtypes.ChainCfg
}
var _ ChainScopedConfig = &chainScopedConfig{}
| [EvmGasBumpThreshold->[logEnvOverrideOnce],BlockHistoryEstimatorBlockDelay->[logPersistedOverrideOnce,logEnvOverrideOnce],Validate->[Validate],EvmGasPriceDefault->[logPersistedOverrideOnce,logEnvOverrideOnce],EvmHeadTrackerMaxBufferSize->[logPersistedOverrideOnce,logEnvOverrideOnce],BlockEmissionIdleWarningThreshold->[... | NewChainScopedConfig creates a new instance of the evm. Config type that is used Validate returns a config object that can be used to validate a chain. | Can this one be made private? |
@@ -115,6 +115,11 @@ define([
* @param {GetFeatureInfoFormat[]} [options.getFeatureInfoFormats] The formats in which to get feature information at a
* specific location when {@see UrlTemplateImageryProvider#pickFeatures} is invoked. If this
* ... | [No CFG could be retrieved] | Provides a description of the resource. A URL for a naturalearthii image. | Shouldn't mention WMS here. It's also worthwhile to mention that this parameter is ignored if `options.pickFeaturesUrl` is undefined. |
@@ -176,6 +176,18 @@ public final class Reflections {
}
}
+ public static <T> T getEnumConstant(String name, Class<T> clazz) {
+ Optional<T> found = Stream.of(clazz.getEnumConstants())
+ .filter(e -> name.equals(e.toString()))
+ .findFirst();
+
+ if (found.... | [Reflections->[newInstance->[findConstructor,newInstance],findFieldInternal->[findFieldInternal],getRawType->[getRawType],FieldKey->[equals->[equals],hashCode],getBound->[getRawType],MethodKey->[equals->[equals]]]] | Invoke a method on an object. | I don't think it makes sense to add this in ArC. Better keep it in the substitution class. |
@@ -941,12 +941,7 @@ public class Executor extends Thread implements ModelObject {
return null;
}
for (Computer computer : jenkins.getComputers()) {
- for (Executor executor : computer.getExecutors()) {
- if (executor.getCurrentExecutable() == executable) {
- ... | [Executor->[completedAsynchronous->[finish2,finish1],getEstimatedRemainingTimeMillis->[getElapsedTime],interruptForShutdown->[interrupt],doStop->[interrupt],of->[getCurrentExecutable],getEstimatedDurationFor->[getEstimatedDurationFor],getTimestampString->[getElapsedTime],run->[call->[resetWorkUnit],resetWorkUnit],start... | Returns an executor that is the current executor or null if it is not a child of the. | It causes some performance degradation (getOneOffExecutors() always happens + collection merge), so maybe we want to keep the original implementation |
@@ -80,7 +80,7 @@ def get_link_flags():
if not _MONOLITHIC_BUILD:
flags.append('-L%s' % get_lib())
if is_mac:
- flags.append('-l:libtensorflow_framework.%s.dylib' % ver)
+ flags.append('-ltensorflow_framework.%s' % ver)
else:
flags.append('-l:libtensorflow_framework.so.%s' % ver)
r... | [get_compile_flags->[get_include],get_link_flags->[get_lib]] | Get the link flags for custom operators. | Should we do a similar change on the `else:` branch? |
@@ -56,11 +56,13 @@ evoked = epochs.average()
forward = mne.read_forward_solution(fname_fwd)
forward = mne.convert_forward_solution(forward, surf_ori=True)
-# Compute regularized noise and data covariances
-noise_cov = mne.compute_covariance(epochs, tmin=tmin, tmax=0, method='shrunk',
- ... | [read_events,pick_channels,argmax,plt_show,add_foci,dict,read_forward_solution,convert_forward_solution,compute_covariance,apply_lcmv,read_raw_fif,axhline,set,make_lcmv,abs,list,plot,append,print,data_path,zip,time_as_index,normalize_proj,average,subplots,legend,get_color,Epochs,pick_types] | Setup for reading the raw data of the . Compute the unit - noise - gain beamformer and source - reconstruct the evoked data. | If possible can you clarify why it's better to do it manually in the beamformer rather than let the advanced, cross-validated estimators (e.g., `shrunk`) automatically choose the best reg, or even manually do `mne.cov.regularize`? If it's not clear why it works but you have experienced that it does, I'm okay with mergi... |
@@ -3816,7 +3816,7 @@ namespace System.Net.Sockets
}
if (e.HasMultipleBuffers)
{
- throw new ArgumentException(SR.net_multibuffernotsupported, "BufferList");
+ throw new ArgumentException(SR.net_multibuffernotsupported, nameof(e));
}
... | [Socket->[DoBeginSendTo->[SocketError],SetIPProtectionLevel->[SetIPProtectionLevel],SetLingerOption->[SetLingerOption],DoBind->[Bind],Send->[Send],ConnectAsync->[Connect,ConnectAsync,CanUseConnectEx,CanTryAddressFamily],Shutdown->[Shutdown],UpdateStatusAfterSocketError->[SetToDisconnected,UpdateStatusAfterSocketError],... | Accept a socket asynchronously. | This is another example of a case where perfect is the enemy of the good. How does someone know in this case that they're getting an ArgumentException because e.BufferList was invalid? They used to get an exception that called it out "Param name: BufferList"... now they'll just get "Param name: e". Such changes are mak... |
@@ -145,7 +145,7 @@ namespace System.Dynamic
void System.Collections.Generic.IDictionary<string, object?>.Add(string key, object value) { }
bool System.Collections.Generic.IDictionary<string, object?>.ContainsKey(string key) { throw null; }
bool System.Collections.Generic.IDictionary<string, ... | [DynamicAttribute->[Struct,Field,Class,Parameter,ReturnValue,Property]] | This method checks if a key is present in the System. Collections. | Why did this change? |
@@ -89,7 +89,7 @@ namespace System.Text.Json
}
}
- GetPolicies(ignoreCondition, isReferenceType: default(T) == null);
+ GetPolicies(ignoreCondition, defaultValueIsNull: default(T) == null);
}
public override JsonConverter ConverterBase
| [JsonPropertyInfo->[SetExtensionDictionaryAsObject->[Assert],ReadJsonAsObject->[HandleNull,TokenType,TypeToConvert,TryRead,CanUseDirectReadOrWrite,Null,Read,IsContinuation,CanBeNull,ThrowJsonException_DeserializeUnableToConvertValue],ReadJsonAndSetMember->[HandleNull,TokenType,TypeToConvert,TryRead,CanUseDirectReadOrWr... | Initialize the object. | Could it be better `DeclaredPropertyType.IsValueType`? |
@@ -25,7 +25,7 @@ class Regcm(AutotoolsPackage):
# producing a so-called fat binary. Unfortunately, gcc builds only the last
# architecture provided (in the configure), so we allow a single arch.
extensions = ('knl', 'skl', 'bdw', 'nhl')
- variant('extension', default=None, values=extensions, multi=Tr... | [Regcm->[configure_args->[append,format,endswith],flag_handler->[extend,endswith],variant,depends_on,version]] | Construct a RegCM object from a single object. Configures the arguments for the n - tuple of flags. | So this doesn't actually support multiple options? |
@@ -244,7 +244,14 @@ inner_evp_generic_fetch(OPENSSL_CTX *libctx, int operation_id,
* we can't create any new method.
*/
if (name_id != 0 && (meth_id = evp_method_id(name_id, operation_id)) == 0)
- return NULL;
+ goto end;
+
+ /*
+ * If we haven't found the name yet, chances are th... | [int->[EVP_set_default_properties],EVP_set_default_properties->[evp_set_default_properties_int]] | Internal method to fetch a method from the EVP. This function deallocates the evp method store and creates a new evp method. | INVALID_NAME_ID and NO_SUCH_METHOD. |
@@ -403,6 +403,9 @@ public abstract class AbstractAmqpOutboundEndpoint extends AbstractReplyProducin
}
protected Duration getConfirmTimeout() {
+ if (this.confirmTimeout == null) {
+ return DEFAULT_CONFIRM_TIMEOUT;
+ }
return this.confirmTimeout;
}
| [AbstractAmqpOutboundEndpoint->[CorrelationDataWrapper->[setReturnedMessage->[setReturnedMessage],getFuture->[getFuture]],start->[getConfirmNackChannel],buildReturnedMessage->[prepareMessageBuilder],handleConfirm->[getConfirmNackChannel,getConfirmAckChannel],addDelayProperty->[setDelay]]] | This method is called by the constructor to get the confirm timeout. | Can't we have a `confirmTimeout` initialized with `DEFAULT_CONFIRM_TIMEOUT` by default? I see there is a logic where `if (this.confirmTimeout != null)` though, but why then just don't return that `null` with an appropriate `@Nullable` on this method instead? I think that way we would have a consistency with the current... |
@@ -1,5 +1,5 @@
module RepositoryHelper
- include SubmissionsHelper
+ include FileHelper
# Add new files or overwrite existing files in this open +repo+. +f+ should be a
# ActionDispatch::Http::UploadedFile object, +user+ is the user that is responsible for
| [add_folder->[nil?,to_s,new,user_name,get_transaction,join,add_path,commit_transaction],remove_files->[nil?,revision_identifier,new,user_name,split,to_s,sanitize_file_name,get_transaction,join,remove,each,commit_transaction],remove_folders->[path,nil?,revision_identifier,new,user_name,to_s,reverse,is_a?,empty?,remove_d... | Adds new files or overwrite existing files in a repository. check if filename is not nil. | I believe that all files under `app/lib` should be automatically loaded, so I think you should be able to remove this include (and the one below). |
@@ -418,12 +418,15 @@ public class SqlToJavaVisitor {
return new Pair<>(expr, Schema.OPTIONAL_BOOLEAN_SCHEMA);
}
+ // CHECKSTYLE_RULES.OFF: CyclomaticComplexity
@Override
protected Pair<String, Schema> visitCast(final Cast node, final Void context) {
+ // CHECKSTYLE_RULES.ON: CyclomaticC... | [SqlToJavaVisitor->[formatExpression->[process],Formatter->[visitArithmeticUnary->[process],visitCast->[process],visitBetweenPredicate->[process],visitComparisonExpression->[visitBytesComparisonExpression,visitBooleanComparisonExpression,visitStringComparisonExpression,process,visitScalarComparisonExpression,nullCheckP... | Visit a ComparisonExpression node. This method will return a Pair of the left and right values get the string representation of the fold fold fold fold fold fold fold fold fold fold fold fold. | Noooooo........ this rule is generally a clear indication the logic of the function is too complex to easily grok. Don't disable the rule, instead refactor, e.g. move your decimal handling into `visitDecimalCast`, or better still replace the switch with code that looks up the handler from a static map. `SqlToJavaVisito... |
@@ -82,6 +82,18 @@ class ExceptionsLoaderTest(base.PulpClientTests):
self.assertEqual(TAG_FAILURE, self.prompt.get_write_tags()[0])
self.prompt.tags = []
+ code = self.exception_handler.handle_exception(WrongHost('expected', 'actual'))
+ self.assertEqual(code, handler.CODE_WRONG_HOST)
... | [ExceptionsLoaderTest->[test_not_found->[handle_not_found,NotFoundException,assertEqual,assertTrue],test_permission->[assertTrue,get_write_tags,handle_permission,assertEqual,PermissionsException],test_server_error->[handle_server_error,assertTrue,assertEqual,PulpServerException],test_handle_exception->[get_write_tags,P... | Tests that the high level call that branches based on exception type. This method checks if the prompt has all tags set and if it has the correct number of. | I really think this should be a separate test from the WrongHost test above it, but then I looked at the whole file and saw the pattern. Ugh. It would be a big improvement to make individual tests for each, although I don't blame you for not including that in the scope of this change. |
@@ -159,7 +159,13 @@ namespace System.Text.Json
if (converter.ConstructorIsParameterized)
{
- converter.CreateConstructorDelegate(options);
+ // Create and cache the constructor delegate for this type.
+ ... | [JsonClassInfo->[GetPropertyWithUniqueAttribute->[GetCustomAttribute,Values,PropertyInfo,Assert,ThrowInvalidOperationException_SerializationDuplicateTypeAttribute],JsonConverter->[ThrowNotSupportedException_SerializationNotSupported,IsAssignableFrom,RuntimeType,DetermineConverter,Assert,IsInterface],JsonParameterInfo->... | Creates a new object property from the given JSON property info. Creates a cache of parameters. | Is the first converter created and this method called (delegate assigned) before the converter instance is added to the cache on the JsonSerializerOptions instance? If not, then it is possible to return the converter with no delegate which may be used by a different thread (and likely cause other issues). |
@@ -194,6 +194,11 @@ class Grass(AutotoolsPackage):
else:
args.append('--without-geos')
+ if '+x' in spec:
+ args.append('--with-x')
+ else:
+ args.append('--without-x')
+
return args
# see issue: https://github.com/spack/spack/issues/11325
| [Grass->[url_for_version->[up_to,format],fix_iconv_linking->[FileFilter,filter],configure_args->[append,format],variant,run_after,depends_on,version]] | Configure the arguments for the command line with the options. args = args. append (. | This was causing linking errors like "no library found: -liconv-liconv", so I assume it was fixed in 7.8.0. |
@@ -311,7 +311,7 @@ public class ProMatches {
};
}
- public static Match<Territory> territoryHasInfraFactoryAndIsLand(final PlayerID player) {
+ public static Match<Territory> territoryHasInfraFactoryAndIsLand() {
return new Match<Territory>() {
@Override
public boolean match(final Territ... | [ProMatches->[unitIsOwnedNotLand->[match->[match]],territoryCanMoveLandUnits->[match->[match]],unitIsEnemyAir->[match->[match]],territoryIsPotentialEnemyOrHasPotentialEnemyUnits->[match->[match,territoryIsPotentialEnemy,territoryHasPotentialEnemyUnits]],territoryHasNeighborOwnedByAndHasLandUnit->[match->[match]],territ... | Returns a territory that is either an enemy or has enemy units or. | This is now the only `Match` factory method in this class that takes zero parameters. I wasn't sure if the same convention used in `Matches` applies here. That is, to use a field instead of a method since it doesn't require additional configuration when it is instantiated. Please advise if it should be converted to a f... |
@@ -51,11 +51,12 @@ public class JmsMessageDrivenChannelAdapterParserTests {
assertNotNull(history);
Properties componentHistoryRecord = TestUtils.locateComponentInHistory(history, "messageDrivenAdapter", 0);
assertNotNull(componentHistoryRecord);
- JmsMessageDrivenEndpoint o = context.getBean("messageDriven... | [JmsMessageDrivenChannelAdapterParserTests->[testGatewayWithIdleTaskExecutionLimit->[getPropertyValue,start,stop,getBean,assertEquals,getClass,ClassPathXmlApplicationContext],adapterWithMessageSelector->[assertNotNull,locateComponentInHistory,getComponentType,println,get,receive,read,getBean,getPayload,assertEquals,get... | This test method adapt a message to a JMS message driven endpoint using a message selector. | Is there a reason to use System.out rather than using a proper Logger? |
@@ -39,8 +39,9 @@ public class GrizzlyHttpRequestAdapter implements HttpRequest
private HttpEntity body;
private ParameterMap headers;
- public GrizzlyHttpRequestAdapter(HttpRequestPacket request, InputStream content, int contentLength)
+ public GrizzlyHttpRequestAdapter(FilterChainContext filterChain... | [GrizzlyHttpRequestAdapter->[getInputStreamEntity->[getHeaderValue],getEntity->[getHeaderValue],getProtocol->[getProtocol]]] | Package that implements the GrizzlyHttpAdapter interface. Replies the protocol path and method. | There isn't a need to pass InputStream here, given you are already passing the request. so given this is grizzly specific I'd rather not pass this and only wrap content with inputStream when needed. |
@@ -476,6 +476,13 @@ public class JobScheduler extends AbstractIdleService {
throw new JobExecutionException(t);
}
}
+
+ @Override
+ public void interrupt()
+ throws UnableToInterruptJobException {
+ log.info("Job was interrupted");
+
+ }
}
/**
| [JobScheduler->[scheduleJob->[scheduleJob],scheduleGeneralConfiguredJobs->[scheduleJob],NonScheduledJobRunner->[run->[runJob]],runJob->[runJob],GobblinJob->[execute->[runJob]]]] | Execute a single unknown job. | Does this need to do anything other than the logging? |
@@ -1762,7 +1762,11 @@ typeobject_generator::generate(AST_Type* node, UTL_ScopedName* name)
gti.endArgs();
const OpenDDS::XTypes::TypeIdentifier ti = get_minimal_type_identifier(node);
be_global->impl_ <<
- " static const XTypes::TypeIdentifier ti = " << ti << ";\n"
+ " static XTypes::TypeIde... | [get_minimal_type_object->[get_minimal_type_object],strong_connect->[consider],get_minimal_type_identifier->[get_minimal_type_identifier],generate->[strong_connect,tag_type,get_minimal_type_identifier],generate_minimal_type_identifier->[,to_long,extensibility_to_type_flag,try_construct_to_member_flag],operator<<->[Enum... | Checks if a node has a missing type object. | Move lock within the `if`? |
@@ -767,6 +767,10 @@ class Processor
$ldactivity['thread-completion'] = true;
$ldactivity['from-relay'] = Contact::getIdForURL($relay_actor);
+ if (!empty($relay_actor) && !self::acceptIncomingMessage($ldactivity, $object['id'])) {
+ return '';
+ }
+
ActivityPub\Receiver::processActivity($ldactivity, jso... | [Processor->[removeImplicitMentionsFromBody->[get],postItem->[get]]] | Fetches an activity from the server. This function is called when an activity is fetched from the server. It will return the id. | When interpolating a variable in a regular expression, you should use `preg_quote()` to avoid errors. |
@@ -227,6 +227,11 @@ namespace Microsoft.Xna.Framework.Graphics
"MonoGame requires either ARB_framebuffer_object or EXT_framebuffer_object." +
"Try updating your graphics drivers.");
}
+
+ // Force reseting states
+ this.BlendState.PlatformApp... | [GraphicsDevice->[PlatformDrawIndexedPrimitives->[PlatformApplyState],PlatformDrawUserPrimitives->[PlatformApplyState,GraphicsDevice],PlatformApplyState->[PlatformApplyState,ActivateShaderProgram],RenderTargetBindingArrayComparer->[GetHashCode->[GetHashCode]],PlatformDrawPrimitives->[PlatformApplyState],PlatformDrawUse... | Initializes the objects that need to be cleared. Clear all colors stencil depth and stencil buffers. | I think it would be better to change these to `_actualBlendState`, etc. That will use the `GraphicsDevice`-specific instances of static state objects. I can see why it works, as it is now - because it happens that we don't create any device-specific objects in `BlendState.OpenGL.cs`. But that might change in the future... |
@@ -2532,6 +2532,9 @@ public class KafkaSupervisorTest extends EasyMockSupport
private void addSomeEvents(int numEventsPerPartition) throws Exception
{
+ //create topic manually
+ AdminUtils.createTopic(zkUtils, topic, NUM_PARTITIONS, 1, new Properties(), RackAwareMode.Enforced$.MODULE$);
+
try (fina... | [KafkaSupervisorTest->[testNoInitialState->[getTopic],testDiscoverExistingPublishingTask->[getTopic],setupTest->[getTopic],testDiscoverExistingPublishingTaskWithDifferentPartitionAllocation->[getTopic],testBeginPublishAndQueueNextTasks->[getTopic],testFailedInitializationAndRecovery->[getTopic],testDiscoverExistingPubl... | Add some events to the Kafka producer. | Hmm, would you tell me why this is needed? |
@@ -58,7 +58,7 @@ namespace System.Net.Http.Headers
{
if (!_from.HasValue)
{
- return "-" + _to.Value.ToString(NumberFormatInfo.InvariantInfo);
+ return "-" + _to!.Value.ToString(NumberFormatInfo.InvariantInfo);
}
else if (!_to.H... | [RangeItemHeaderValue->[ToString->[ToString],GetHashCode->[GetHashCode]]] | ToString method for String. | We could add assert here. |
@@ -43,9 +43,12 @@
#include "daos_api.h"
#include "daos_fs.h"
#include "daos_uns.h"
+#include "daos_prop.h"
#include "daos_hdlr.h"
+#define MAX_PROP_NAME_LEN (64)
+
static int
parse_acl_file(const char *path, struct daos_acl **acl);
| [No CFG could be retrieved] | Creates a new object and returns it. query the pool. | daos_parse_properties() function defines a variable char name[20]. Maybe if the code is going to have separate processing for single property handling for set-prop while supporting multiple properties at container create time they could use a common constant for the maximum property name length? |
@@ -40,7 +40,7 @@ import static org.testng.Assert.assertTrue;
* so some test cases are overridden from the base class and slightly modified to add an additional UUID column.
*/
public class TestAccumuloDistributedQueries
- extends AbstractTestDistributedQueries
+ extends AbstractConnectorReadWriteTes... | [TestAccumuloDistributedQueries->[testCreateTableAsSelect->[assertTrue,assertCreateTableAsSelect,tableExists,assertFalse,assertTableColumnNames,getSession,assertUpdate],testCreateTableEmptyColumns->[assertQuery,assertUpdate],createQueryRunner->[of,createAccumuloQueryRunner],testSelectNullValue->[assertQuery,assertUpdat... | Creates a new accumulator query runner for the given . | There seem to be much more than just read writes in `AbstractTestDistributedQueries` test, e.g `coercions, aggregation pushdown, sessions, create tables`. Should this be called `AbstractConnectorIntegrationTest`? Seems like some tests are not needed here, e.g: `io.prestosql.testing.AbstractTestDistributedQueries#testSe... |
@@ -165,7 +165,7 @@ class CompressorTestCase(TestCase):
config_list = [{'sparsity': 0.6, 'op_types': ['BatchNorm2d']}]
model.bn1.weight.data = torch.tensor(w).float()
model.bn2.weight.data = torch.tensor(w).float()
- pruner = torch_pruner.SlimPruner(model, config_list)
+ pruner ... | [CompressorTestCase->[test_torch_slim_pruner->[TorchModel],test_torch_quantizer_validation->[TorchModel],test_torch_fpgm_pruner->[TorchModel],test_torch_level_pruner->[TorchModel],test_torch_quantizer_export->[TorchModel],test_torch_taylorFOweight_pruner->[TorchModel],test_torch_QAT_quantizer->[TorchModel],test_torch_q... | Test the Torch slim pruner. Check if there is a batch norm op in the model. | Too complicated, please use the default value to simplify the usage. Thanks~ |
@@ -1243,7 +1243,7 @@ class BaseEpochs(ProjMixin, ContainsMixin, UpdateChannelsMixin, ShiftTimeMixin,
return _drop_log_stats(self.drop_log, ignore)
@copy_function_doc_to_method_doc(plot_drop_log)
- def plot_drop_log(self, threshold=0, n_max_plot=20, subject='Unknown',
+ def plot_drop_log(self, thr... | [BaseEpochs->[equalize_event_counts->[drop,drop_bad],plot_drop_log->[plot_drop_log],_get_data->[_get_epoch_from_raw,_detrend_offset_decim,_is_good_epoch,_project_epoch],drop_bad->[_reject_setup],get_data->[_get_data],crop->[_set_times],to_data_frame->[copy,get_data],reset_drop_log_selection->[_check_consistency],__init... | Plot the drop log of the current epochs. | This is for consistency with `viz.plot_drop_log()` |
@@ -145,7 +145,14 @@ namespace Content.Server.GameObjects
Deny();
return;
}
+
Open();
+
+ if (user.TryGetComponent(out HandsComponent hands) && hands.Count == 2)
+ {
+ EntitySystem.Get<AudioSystem>().PlayFromEntity("/Audio/... | [ServerDoorComponent->[Open->[Open,SetAppearance],TryClose->[CanClose],CheckCrush->[Open],OnUpdate->[Open,Close,CanClose],OnRemove->[OnRemove],Initialize->[Initialize],CanOpen->[CanOpen],ExposeData->[ExposeData],Activate->[ActivateImpl],Deny->[Open,SetAppearance,Deny],CanClose->[CanClose],TryOpen->[CanOpen],Close->[Set... | Try to open a door. | > `hands.Count == 2` > no hands :thinking: |
@@ -930,9 +930,8 @@ void Peer::DecUseCount()
delete this;
}
-void Peer::RTTStatistics(float rtt, std::string profiler_id,
- unsigned int num_samples) {
-
+void Peer::RTTStatistics(float rtt, std::string profiler_id)
+{
if (m_last_rtt > 0) {
/* set min max values */
if (rtt < m_rtt.min_rtt)
| [No CFG could be retrieved] | protected int m_usage = 0 ; checks if a node has a neutral value at the beginning of the loop. | std::deque cannot be better than a list here ? |
@@ -651,9 +651,14 @@ public final class OzoneManagerRatisServer {
Parameters parameters = new Parameters();
if (conf.isSecurityEnabled() && conf.isGrpcTlsEnabled()) {
+ ArrayList< X509Certificate > listCA = new ArrayList<>();
+ listCA.add(caClient.getCACertificate());
+ if (caClient.getRootCA... | [OzoneManagerRatisServer->[start->[start],stop->[stop],newOMRatisServer->[OzoneManagerRatisServer],getLastAppliedTermIndex->[getLastAppliedTermIndex]]] | Creates a server TLS parameters based on the given ca client. | This needs to include the ROOT ca certificate with getCaCertPemList. |
@@ -271,6 +271,8 @@ class TransformExecutor(_ExecutorService.CallableTask):
self._side_input_values = {}
self.blocked = False
self._call_count = 0
+ self._retry_count = 0
+ self._MAX_RETRY_PER_BUNDLE = 4
def call(self):
self._call_count += 1
| [_CompletionCallback->[handle_result->[handle_result]],Executor->[start->[start],await_completion->[await_completion]],_ExecutorServiceParallelExecutor->[await_completion->[shutdown],schedule_consumption->[parallel,schedule,serial,TransformExecutor],__init__->[_CompletionCallback,_TransformExecutorServices,_ExecutorSer... | Initializes the object. Finishes the evaluation of a sequence of tags and returns a object. | <!--new_thread; commit:eb2acfa855db99ab4b826344656ec29dcdb175e3; resolved:0--> You can factor out this to be a constant outside TransformExecutor, or as a class constant. |
@@ -79,7 +79,8 @@ def parse_annotation_mutable_layers(code, lineno, nas_mode):
fields['optional_inputs'] = True
elif k.id == 'optional_input_size':
assert not fields['optional_input_size'], 'Duplicated field: optional_input_size'
- assert type(value) is ast.... | [test_variable_equal->[test_variable_equal],parse_annotation_function->[parse_annotation],parse_nni_function->[parse_annotation_function],parse_nni_variable->[parse_annotation_function],replace_variable_node->[test_variable_equal,parse_nni_variable],parse->[Transformer,parse,visit],Transformer->[visit->[replace_variabl... | Parse the string of mutable layers in annotation. Generate ast. Call for the mutable layer. Build node for node with missing node. | suggest switching to a new line after `ast.List,` |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.