patch stringlengths 18 160k | callgraph stringlengths 4 179k | summary stringlengths 4 947 | msg stringlengths 6 3.42k |
|---|---|---|---|
@@ -120,6 +120,7 @@ export default function UserMenuComponent(props: {|
{...userMenuProps}
/>
)}
+ autoFocus={false}
dismissOnEsc={true}
dismissOnClickOutside={true}
onOpen={() => setIsOpen(true)}
| [No CFG could be retrieved] | Creates a new . | There are multiple instances throughout the repo where we've used `Popover` in ways that assume autoFocus is false, when really it is true by default but just wasn't working correctly. In these cases we need to explicitly pass in `autoFocus={false}` to preserve existing functionality. |
@@ -2470,6 +2470,7 @@ BIO *app_http_tls_cb(BIO *bio, void *arg, int connect, int detail)
SSL *ssl;
BIO *sbio = NULL;
+ /* TODO adapt after fixing callback design flaw, see #17088 */
if ((info->use_proxy
&& !OSSL_HTTP_proxy_connect(bio, info->server, info->port,
... | [No CFG could be retrieved] | HTTP callback that supports TLS connection. finds the network block of the network block that can be read from the network buffer. | Please remove the TODO |
@@ -907,13 +907,15 @@ def _get_task_world(opt):
world_class = getattr(my_module, world_name)
except Exception:
# Defaults to this if you did not specify a world for your task.
- world_class = DialogPartnerWorld
- task_agents = _create_task_agents(opt)
+ if len... | [MultiWorld->[share->[share],reset->[reset],reset_metrics->[reset_metrics],num_examples->[num_examples],num_episodes->[num_episodes],epoch_done->[epoch_done],display->[getID,display],parley->[parley_init,update_counters]],World->[update_counters->[epoch_done,num_examples],reset->[reset],reset_metrics->[reset_metrics],_... | Returns a task world and a list of task_agents. get a single task - world or batch world based on options. | nice--while we're here, we should also do this when `'.' in sp[0]` (line 896). |
@@ -29,6 +29,14 @@ public final class StaticConfigurationInstanceProvider<T> implements Configurati
providerDelegate = new FirstTimeProviderDelegate<>();
}
+ /**
+ * Returns {@link #configurationInstance}. The first time this method is invoked, the instance
+ * is registered on the {@code reg... | [StaticConfigurationInstanceProvider->[FirstTimeProviderDelegate->[provide->[registerNewConfigurationInstance]],get->[provide,MuleRuntimeException]]] | Get a managed object from the provider. | Add "<p\>" before "The first time..." |
@@ -72,7 +72,7 @@ class ApplicationController < ActionController::Base
# the user to after a successful log in
def after_sign_in_path_for(resource)
if current_user.saw_onboarding
- path = request.env["omniauth.origin"] || stored_location_for(resource) || dashboard_path
+ path = stored_location_for(... | [ApplicationController->[rate_limiter->[rate_limiter]]] | after_sign_in_path_for returns onboarding_path if user is. | Moved up in priority (if available) the use of Devise's `stored_location_for` for redirecting back to the correct location |
@@ -55,6 +55,9 @@ class ConanRequester(object):
kwargs["proxies"] = self.proxies
if self._timeout_seconds:
kwargs["timeout"] = self._timeout_seconds
+ if not kwargs.get("headers"):
+ kwargs["headers"] = {}
+ kwargs["headers"]["User-Agent"] = "Conan/%s (Py... | [ConanRequester->[post->[post,_add_kwargs],get->[get,_add_kwargs],put->[put,_add_kwargs],delete->[delete,_add_kwargs],_add_kwargs->[_should_skip_proxy]]] | Add kwargs to url. | Better use `platform.python_version()` it automatically extracts the python version |
@@ -106,8 +106,9 @@ def construct_pipeline(renames):
p.visit(SnippetUtils.RenameFiles(renames))
# [START pipelines_constructing_running]
- p.run()
+ result = p.run()
# [END pipelines_constructing_running]
+ result
def model_pipelines(argv):
| [examples_wordcount_debugging->[FilterTextFn,RenameFiles],pipeline_monitoring->[CountWords->[expand->[FormatCountsFn,ExtractWordsFn]],CountWords,RenameFiles],examples_wordcount_minimal->[RenameFiles],construct_pipeline->[ReverseWords,RenameFiles],pipeline_logging->[ExtractWordsFn],examples_wordcount_wordcount->[FormatA... | A simple pipeline that creates a single wordcount pipeline. Reads a single from input and processes it. | Is this just to silence lint? Could that be done more explicitly? |
@@ -18,13 +18,18 @@ class GlobalStacksModel(ListModel):
HasRemoteConnectionRole = Qt.UserRole + 3
ConnectionTypeRole = Qt.UserRole + 4
MetaDataRole = Qt.UserRole + 5
+ SectionNameRole = Qt.UserRole + 6 # For separating local and remote printers in the machine management page
def __init__(self,... | [GlobalStacksModel->[_update->[getName,sort,append,getMetaDataEntry,getMetaData,getInstance,getId,setItems],_updateDelayed->[start],_onContainerChanged->[_updateDelayed,isinstance],__init__->[QTimer,_updateDelayed,addRoleName,setInterval,connect,getInstance,super,setSingleShot]]] | Initialize the object with the base name id metadata and filter. | Perhaps rename this to `DiscoverySourceRole`? |
@@ -45,12 +45,15 @@ namespace System.Net.Test.Common
public static string EchoClientCertificateRemoteServer => GetValue("DOTNET_TEST_HTTPHOST_ECHOCLIENTCERT", "https://corefx-net-tls.azurewebsites.net/EchoClientCertificate.ashx");
public static string Http2ForceUnencryptedLoopback => GetValue(... | [Configuration->[Http->[RemoteServer->[Uri->[BasicAuthUriForCreds,EscapeDataString,PathAndQuery,AbsoluteUri],UriSchemeHttps,Scheme],Version11,GetPortValue,Select,GetValue,ToArray]]] | Get the remote server and the http2 server. This class is used to provide a list of URIs to verify the upload server. | nit: RemoteLoop to match casing above |
@@ -610,6 +610,14 @@ namespace Js
pfuncScript = library->GetGlobalObject()->EvalHelper(scriptContext, argString->GetSz(), argString->GetLength(), moduleID,
grfscr, Constants::EvalCode, doRegisterDocument, isIndirect, strictMode);
+ if (debugEvalScriptContext != nullptr && Cros... | [No CFG could be retrieved] | Evaluates a key in the evalmap. This function is called from the script engine when it is not possible to use the debugger source. | Can you disable useEvalMap with debugEvalScriptContext |
@@ -59,6 +59,14 @@ class Payment(models.Model):
order = models.ForeignKey(
"order.Order", null=True, related_name="payments", on_delete=models.PROTECT
)
+ create_order = models.BooleanField(
+ blank=True,
+ null=True,
+ help_text=(
+ "Indicates whether a payment sho... | [Transaction->[get_amount->[Money],CharField,JSONField,DateTimeField,ForeignKey,DecimalField,Decimal,BooleanField],Payment->[get_last_transaction->[all,attrgetter,max],Meta->[GinIndex],get_total->[Money],get_authorized_amount->[Money,all,any,zero_money],get_captured_amount->[Money],CharField,PositiveIntegerField,MinVal... | Required field for editing a specific . Creates a CharField for all Header - related fields. | It seems to duplicate `complete_order` that I added earlier on? |
@@ -108,7 +108,7 @@ var _ = Describe("Podman start", func() {
start := podmanTest.Podman([]string{"start", "-l"})
start.WaitWithDefaultTimeout()
Expect(start.ExitCode()).To(Not(Equal(0)))
-
+ time.Sleep(2 * time.Second)
numContainers := podmanTest.NumberOfContainers()
Expect(numContainers).To(BeZero())
... | [WaitWithDefaultTimeout,Cleanup,ExitCode,OutputToString,To,SeedImages,Podman,Exit,Setup,NumberOfContainers] | PodmanTest returns a test that waits for all containers to start and returns an expectation that NumberOfContainers should not be running with no container. | Why not do a wait := podmanTest.Podman([]string{"wait", "-l"}) |
@@ -118,14 +118,13 @@ class StructureMediaSearchSubscriber implements EventSubscriberInterface
$medias = $data->getData('de');
// old ones an array ...
} else {
- if (!isset($data['ids'])) {
- throw new \RuntimeException(
- \sprintf('Was expect... | [StructureMediaSearchSubscriber->[handlePreIndex->[getValue,setImageUrl,getName,getMetadata,getDocument,getFieldEvaluator,getLocale,getImageUrlField,getImageUrl,getSubject],getImageUrl->[getThumbnails,getData,get]]] | Returns the image URL for the given data. | Will `$data['id']` not return an int and so !is_array will always fail? |
@@ -12,8 +12,14 @@ namespace Microsoft.Xna.Framework.Graphics
internal void ClearTargets(GraphicsDevice device, RenderTargetBinding[] targets)
{
- ClearTargets(targets, device._d3dContext.VertexShader);
- ClearTargets(targets, device._d3dContext.PixelShader);
+ if (_... | [TextureCollection->[ClearTargets->[ClearTargets]]] | Clear the texture if it has no other texture. | @tgjones - I wonder if we're better off just passing the DX pixel shader or vertex shader context on construction of the TextureCollection. At least that cuts out some of the extra branches at runtime. |
@@ -13,6 +13,7 @@ type logstashConfig struct {
LoadBalance bool `config:"loadbalance"`
BulkMaxSize int `config:"bulk_max_size"`
Timeout time.Duration `config:"timeout"`
+ Pipelining int `config:"pipelining" validate:"min=... | [No CFG could be retrieved] | Package logsstash_missing_node logstash_missing_node_logstash. | This should probably also be added to the libbeat.yml file and the docs? |
@@ -26,6 +26,10 @@ type ARMResource struct {
DependsOn []string `json:"dependsOn,omitempty"`
}
+// DeploymentARMResource is an alias for the ARMResource type to avoid MarshalJSON override
+type DeploymentARMResource ARMResource
+
+// MarshalJSON is the custom marshaler for an ARMResource.
func (arm ARMR... | [MarshalJSON->[Marshal]] | MarshalJSON - encodes ARMResource to JSON. | doing this fixes the stack overflow panic due to the `MarshalJSON` override |
@@ -94,8 +94,9 @@ var karma = {
'SL_Safari_8',
'SL_Safari_9',
'SL_Edge_latest',
- // TODO(#895) Enable these.
- //'SL_iOS_9_1',
+ 'SL_iOS_8_4',
+ 'SL_iOS_9_1',
+ 'SL_iOS_10_0',
//'SL_IE_11',
],
})
| [No CFG could be retrieved] | Create an instance of the karma module. Requires the dependencies of the dependency. | how about 9.3 instead or 9.1? |
@@ -940,11 +940,16 @@ class _BaseRaw(ProjMixin, ContainsMixin, PickDropChannelsMixin,
raw data effectively jitters trigger timings. It is
generally recommended not to epoch downsampled data,
but instead epoch and then downsample, as epoching
- ... | [_start_writing_raw->[append],ToDataFrameMixin->[to_data_frame->[_get_check_picks]],_check_update_montage->[append],_write_raw->[_write_raw],_BaseRaw->[notch_filter->[notch_filter],apply_function->[_check_fun],_preload_data->[_read_segment],crop->[_update_times],__setitem__->[_parse_get_set_params],resample->[_update_t... | Resample the data channels. Resample the data to the next block of the object and replace the data with the. | Sorry to be a pest about this, but saying `Alternatively` after the warning makes it sound like this method will fix the issue, but it won't. So please move elsewhere (and fix `Aternatively` spelling) |
@@ -308,6 +308,11 @@ class BorrowedArgumentsVisitor(BaseAnalysisVisitor):
return set(), {op.dest}
return set(), set()
+ def visit_set_mem(self, op: SetMem) -> GenAndKill:
+ if op.dest in self.args:
+ return set(), {op.dest}
+ return set(), set()
+
def analyze_borro... | [analyze_maybe_defined_regs->[DefinedVisitor],analyze_live_regs->[LivenessVisitor],analyze_borrowed_arguments->[BorrowedArgumentsVisitor],cleanup_cfg->[get_real_target,get_cfg],analyze_must_defined_regs->[DefinedVisitor],run_analysis->[AnalysisResult],get_cfg->[CFG],analyze_undefined_regs->[UndefinedVisitor],BaseAnalys... | Visits an Assign operation. | This should be similar to `visit_register_op`, since we don't modify `op.dest`, but the value pointed to by it. |
@@ -1812,14 +1812,10 @@ export default {
},
/**
- * Toggles the local "raised hand" status, if the current state allows
- * toggling.
+ * Toggles the local "raised hand" status.
*/
maybeToggleRaisedHand() {
- // If we are the dominant speaker, we don't enable "raise hand".
- ... | [No CFG could be retrieved] | Adds a promise to the list of local devices that have been added to the list of devices Log an event to callstats and analytics. | We should rename this method, because now it will always toggle the raise hand. |
@@ -502,6 +502,9 @@ function installContextUsingStandardImpl(win) {
nextTick(win, () => cb([initialIntersection]));
return unlisten;
};
+ win.context.observePosition = cb => {
+ return observePosition(cb);
+ };
win.context.onResizeSuccess = onResizeSuccess;
win.context.onResizeDenied = onResizeD... | [No CFG could be retrieved] | Installs the standard context object for the given window. Triggers a render - start postMessage if the postMessage is not rendered yet. | can you just `win.context.observePosition = observePosition` or does the context/this preservation matter here? |
@@ -156,7 +156,7 @@ namespace System.Collections.Immutable
public bool IsEmpty
{
[NonVersionable]
- get { return this.Length == 0; }
+ get { return this.array!.Length == 0; }
}
/// <summary>
| [ImmutableArray->[As->[array],IEnumerator->[ThrowInvalidOperationIfNotInitialized,Create,array],CopyTo->[Copy,ThrowNullRefIfNotInitialized,Length,array],GetHashCode->[GetHashCode,array],CastUp->[array],GetEnumerator->[ThrowInvalidOperationIfNotInitialized,Create,array],ThrowNullRefIfNotInitialized->[Length],ItemRef->[a... | Replies a read - only reference to the specified element in the list. - A value indicating if the array is empty or uninitialized. | Could you please also submit this fix (in same or different PR)? |
@@ -93,7 +93,10 @@ class PushQueryPublisher implements Flow.Publisher<Collection<StreamedRow>> {
queryMetadata.setLimitHandler(this::setDone);
queryMetadata.setUncaughtExceptionHandler(
- (thread, e) -> setError(e)
+ e -> {
+ setError(e);
+ return StreamsUncaughtE... | [PushQueryPublisher->[PushQuerySubscription->[close->[close]]]] | poll method. | For Push queries should we retry or just shutdown? |
@@ -206,6 +206,11 @@ class InstallCommand(RequirementCommand):
install_options.append('--user')
install_options.append('--prefix=')
+ # If --user or --global is not passed, use some heuristic to determine
+ # whether the installations should be user or global.
+ if optio... | [InstallCommand->[_handle_target_dir->[remove,distutils_scheme,any,append,isdir,ensure_dir,startswith,move,join,islink,exists,warning,listdir,rmtree],__init__->[only_binary,no_deps,make_option_group,progress_bar,ignore_requires_python,no_clean,global_options,install_options,constraints,add_option,require_hashes,require... | Run the command. Installs a missing package or wheels if it is not installed. Check if a missing node - version or a missing node - version is installed and if so. | doesnt this have to go above to ensure the sanity check and the install option fixup? |
@@ -577,7 +577,7 @@ function decodeBase64(string, encoding = 'utf-8') {
}
function loadYoRc(filePath = '.yo-rc.json') {
- if (!jhiCore.FileUtils.doesFileExist(filePath)) {
+ if (!FileUtils.doesFileExist(filePath)) {
return undefined;
}
return JSON.parse(fs.readFileSync(filePath, { encoding:... | [No CFG could be retrieved] | Get the object properties from the given base64 string to the given object. Generates a base64 secret from given value or random hex string. | Use `fs.existsSync` instead. |
@@ -155,9 +155,9 @@ public class ConfigFilesConvertor {
}
if (type.equals(JBOSS_CACHE3X)) {
- transformFromJbossCache3x(sourceName, destinationName);
+ transformFromJbossCache3x(sourceName, destinationName, ConfigFilesConvertor.class.getClassLoader());
} else {
- transform... | [ConfigFilesConvertor->[mustExist->[help],transformFromJbossCache3x->[parse,ConfigFilesConvertor],main->[help],parse->[parse],transformFromNonJBoss->[parse,ConfigFilesConvertor],getInputDocument->[parse]]] | Main method of the transformation system. | Just a question to clarify my understanding: So here since the XSLT to load comes from us, we simply use our own cache loader cos the file should be there. For any classes that are loaded coming potentially from the user, use TCCL, right? |
@@ -111,7 +111,7 @@ class ResultsController < ApplicationController
end
end
- group_order = reviewer_access ? 'grouping.id' : 'group_name'
+ group_order = reviewer_access ? 'groups.id' : 'group_name'
all_groupings = assignment.groupings.joins(:group).order(group_order)
if current_user.ta?
... | [ResultsController->[update_remark_request_count->[update_remark_request_count]]] | This method is called when a user changes the neccesary key in the params hash Initialize a new instance of the NestedMark class. This action shows the top tags of a group and its usage. | It looks like both `group_order` and `all_groupings` are only used in the "else" case below. If so, this conditional is not necessary (just use `group_name`) and move both assignments into the `else`. |
@@ -98,7 +98,8 @@ import org.slf4j.LoggerFactory;
/**
* An unbounded source and a sink for <a href="http://kafka.apache.org/">Kafka</a> topics.
- * Kafka version 0.9 and above are supported.
+ * Kafka version 0.9 and above are supported. It's supported to replace with Kafka client 0.10
+ * for external authenticat... | [KafkaIO->[TypedWithoutMetadata->[expand->[apply]],KafkaWriter->[setup->[getProducerFactoryFn,apply],teardown->[close],processElement->[getTopic],getKeyCoder,getProducerConfig,getValueCoder],UnboundedKafkaSource->[generateInitialSplits->[getConsumerConfig,getTopics,build,apply,getTopicPartitions],validate->[validate],g... | Imports a single - valued partition partition and offset from Kafka. Topics to consume. | Its not clear what this implies to user. "It's supported to replace with Kafka client for external authentication.". We can remove it or rephrase it. This PR makes ensures 'Kafka version 0.9 and above are supported.'. It was not accurate earlier. |
@@ -10,6 +10,9 @@ if my_python < min_python:
print("Borg requires Python %d.%d or later" % min_python)
sys.exit(1)
+# Are we building on ReadTheDocs?
+on_rtd = os.environ.get('READTHEDOCS', None) == 'True'
+
# msgpack pure python data corruption was fixed in 0.4.6.
# Also, we might use some rather recent ... | [detect_lz4->[exists,open,read,join],Sdist->[make_distribution->[super,extend],__init__->[super,glob,compile,Exception]],detect_openssl->[exists,open,read,join],,detect_lz4,all,join,Exception,insert,detect_openssl,replace,startswith,Extension,append,print,read,exists,open,get,ImportError,setup,exit] | Creates a class which can be used to build a Borg package. Creates a distribution object for the given package. | None is the default default for .get(). |
@@ -121,7 +121,17 @@ Js::FunctionInfo *InliningDecider::InlineCallSite(Js::FunctionBody *const inline
Js::FunctionInfo *functionInfo = GetCallSiteFuncInfo(inliner, profiledCallSiteId, &isConstructorCall, &isPolymorphicCall);
if (functionInfo)
{
- return Inline(inliner, functionInfo, isConstructorC... | [HasCallSiteInfo->[HasCallSiteInfo],GetConstantArgInfo->[GetConstantArgInfo],INLINE_FLUSH->[INLINE_FLUSH],DeciderInlineIntoInliner->[CanRecursivelyInline],InlineCallSite->[GetConstantArgInfo,GetCallSiteFuncInfo]] | InlineCallSite - inline a function call site. no inlinees as it s not seen in the function body. | >false [](start = 45, length = 5) How do we guarantee at this point that it's not a constructor call? |
@@ -143,6 +143,12 @@ class Status {
}
}
+ // @todo Remove function_exists when WP 5.5 is the minimum version.
+ // Use Core's environment check, if available. Added in 5.5.0 / 5.5.1 (for `local` return value)
+ if ( function_exists( 'wp_get_environment_type' ) && 'local' === wp_get_environment_type() ) {
+... | [Status->[is_single_user_site->[get_var],is_offline_mode->[is_local_site],is_multi_network->[get_var],is_development_mode->[is_offline_mode]]] | Checks if the current site is a local site. | We could move this above the regex above, so if it's true, we don't cycle through the list of local URLs. |
@@ -694,7 +694,7 @@ func execNativeInstallerWithArg(arg string, runMode libkb.RunMode, log Log) erro
}
// AutoInstallWithStatus runs the auto install and returns a result
-func AutoInstallWithStatus(context Context, binPath string, force bool, log Log) keybase1.InstallResult {
+func AutoInstallWithStatus(context Co... | [GetRunMode,Dir,CheckPlist,Statfs,MakeParentDirs,WaitForStatus,Executable,ListServices,GetRuntimeDir,StatusFromCode,SplitPath,Count,Lstat,CombineErrors,Info,WaitForServiceInfoFile,HasPrefix,Mode,ComponentName,GetServiceInfoPath,Uninstall,IsNotExist,CombinedOutput,Error,Stat,FormatBool,Warning,Clean,NewEnvVar,Errorf,Mak... | AutoInstall runs the native installer with the given arguments. AutoInstall returns a componentResults slice with the latest version of the service label. If the. | Where does the `timeout` argument get used here? |
@@ -464,13 +464,13 @@ function db_definition($charset) {
);
$database["cache"] = array(
"fields" => array(
- "k" => array("type" => "varchar(255)", "not null" => "1", "primary" => "1"),
+ "k" => array("type" => "varbinary(255)", "not null" => "1", "primary" => "1"),
"v" => array("type" => "text"... | [db_create_table->[q],update_structure->[q,server_info]] | Define the database definition Database schema for all auth_codes Database schema for all records in the database. Database schema for all user - defined relations Table of data for a given language in the database. | Any reason why this is no longer around? |
@@ -706,15 +706,12 @@ namespace Dynamo.PackageManager
RemoveItemCommand = new Dynamo.UI.Commands.DelegateCommand(RemoveItem);
ToggleMoreCommand = new DelegateCommand(() => MoreExpanded = !MoreExpanded, () => true);
Dependencies.CollectionChanged += DependenciesOnCollectionChanged;... | [PublishPackageViewModel->[GetFunctionDefinitionWS->[AllDependentFuncDefs,AllFuncDefs],GetAllFiles->[GetFunctionDefinitionWS,AllFuncDefs],GetPythonDependency->[GetFunctionDefinitionWS,AllDependentFuncDefs,AllFuncDefs],GetAllDependencies->[GetFunctionDefinitionWS,AllDependentFuncDefs,AllFuncDefs],SelectMarkdownDirectory... | PackageContentsOnCollectionChanged - Refresh package contents and dependencies on collection changed. | Unnecessary since it's an ObservableCollection so removing |
@@ -19,4 +19,8 @@ def run():
if __name__ == "__main__":
+ # First, let Pytorch's multiprocessing module know how to create child processes.
+ # Refer https://docs.python.org/3.7/library/multiprocessing.html#multiprocessing.set_start_method
+ torch.multiprocessing.set_start_method("spawn")
+
run()
| [run->[main],abspath,insert,dirname,get,basicConfig,join,run] | This is the main function of the interpreter. | Can you add a note to the Trainer that setting this is required if you aren't using allennlp as the entry point? |
@@ -166,7 +166,8 @@ public class JoinFilterAnalyzer
normalizedJoinTableClauses,
null,
enableFilterPushDown,
- enableFilterRewrite
+ enableFilterRewrite,
+ new HashMap<>()
);
}
| [JoinFilterAnalyzer->[getCorrelationForRHSColumn->[getCorrelationForRHSColumn],splitVirtualColumns->[areSomeColumnsFromJoin],areSomeColumnsFromJoin->[isColumnFromJoin],areSomeColumnsFromPostJoinVirtualColumns->[isColumnFromPostJoinVirtualColumns]]] | Compute a JoinFilterPreAnalysis for the given list of joinable clauses and virtual columns. Determines candidates for RHS column rewrites. This method finds correlated base table columns and correlated values for the given RHS column This method creates a new JoinFilterPreAnalysis object with all the necessary informat... | Can use `Collections.emptyMap()`. |
@@ -351,6 +351,10 @@ const adConfig = jsonConfiguration({
prefetch: 'https://static.clmbtech.com/ad/commons/js/colombia-amp.js',
},
+ 'conative': {
+ renderStartImplemented: true,
+ },
+
'connatix': {
renderStartImplemented: true,
},
| [No CFG could be retrieved] | Provides a mapping of urls to urls to beopinion s pre - connection and pre A list of urls for all resources of a specific type. | verified `renderStart` is being called. |
@@ -17,6 +17,7 @@ var (
RunE: func(cmd *cobra.Command, args []string) error {
attachCommand.InputArgs = args
attachCommand.GlobalFlags = MainGlobalOpts
+ attachCommand.Remote = remoteclient
return attachCmd(&attachCommand)
},
Example: `podman attach ctrID
| [StringVar,Wrapf,SetHelpTemplate,Shutdown,GetRuntime,Attach,Errorf,SetUsageTemplate,BoolVarP,Flags,BoolVar] | main import imports the given container ID and name into the container. attachCmd processes attach - keys and detach - values commands. | Why isn't this just a global flag? |
@@ -36,6 +36,8 @@ namespace Content.Client.UserInterface
{
IoCManager.InjectDependencies(this);
+ _configManager.OnValueChanged(CCVars.HudTheme, UpdateHudTheme, invokeImmediately: true);
+
AddChild(_guiContainer = new HBoxContainer
{
Separati... | [HandsGui->[UpdatePanels->[TryGetHands],FrameUpdate->[FrameUpdate,UpdatePanels],_OnStoragePressed->[TryGetHands],HandKeyBindDown->[TryGetHands],UpdateHandIcons->[TryGetHands,AddHand,Texture]]] | Displays the hands GUI. region HandLocation Methods. | Read my review above, you should correct the value if it's incorrect in `UpdateHudTheme` |
@@ -71,8 +71,8 @@ class Scaler(TransformerMixin):
exclude='bads')
picks_list['grad'] = pick_types(self.info, meg='grad', ref_meg=False,
exclude='bads')
- picks_list['eeg'] = pick_types(self.info, eeg='grad', ref_meg=False,
... | [PSDEstimator->[transform->[_psd_multitaper,ValueError,isinstance,type],fit->[ValueError,isinstance,type]],EpochsVectorizer->[inverse_transform->[reshape,ValueError,isinstance,type],transform->[type,atleast_3d,ValueError,isinstance,reshape],fit->[ValueError,isinstance,type]],Scaler->[inverse_transform->[type,atleast_3d... | Standardizes data across channels and returns the modified Scaler . | I _think_ that's what it's supposed to do, right? |
@@ -105,8 +105,8 @@ class keyboard_input(object):
"""If termios was avaialble, restore old settings."""
if self.old_cfg:
import termios
- termios.tcsetattr(
- self.stream.fileno(), termios.TCSADRAIN, self.old_cfg)
+ with background_safe(): # change it... | [Unbuffered->[write->[write],writelines->[writelines]],log_output->[_writer_daemon->[keyboard_input,write,_strip],__exit__->[write],__enter__->[Unbuffered,_file_descriptors_work],force_echo->[write]]] | If termios was avaialble restore old settings. | (question) It appears that `self.old_cfg` is only set if `not is_background()` in `__enter__`, so is this required? |
@@ -26124,7 +26124,7 @@ namespace System.Windows.Forms
}
}
- private void RealeaseMouse()
+ private void ReleaseMouse()
{
Cursor.Clip = Rectangle.Empty;
Capture = false;
| [DataGridView->[OnInsertedRows_PostNotification->[OnAddedRows_PostNotification],OnFontChanged->[OnColumnHeadersDefaultCellStyleChanged,OnDefaultCellStyleChanged,OnFontChanged],SetSelectedCellCoreInternal->[IsInnerCellOutOfBounds,SetCurrentCellAddressCore,ScrollIntoView,RemoveIndividuallySelectedCells,SetSelectedCellCor... | This method refreshes the rows in the grid view. EndUpdateInternal - end of RealeaseMouse. | This is a function, but it's private, so, it shouldn't be a big deal. |
@@ -112,6 +112,18 @@ uint16_t mcp4728_getVout(uint8_t channel) {
}
*/
+/* Returns DAC values as a 0-100 percentage of drive strength */
+uint16_t mcp4728_getDrvPct(uint8_t channel) {return (uint16_t)(.5+(((float)mcp4728_values[channel]*100)/DAC_STEPPER_MAX));}
+
+/* Recieves all Drive strengths as 0-100 percent val... | [mcp4728_eepromWrite->[highByte,write,endTransmission,beginTransmission,lowByte],mcp4728_init->[requestFrom,begin,available,read,word],mcp4728_setGain_all->[endTransmission,write,beginTransmission],mcp4728_setVref_all->[endTransmission,write,beginTransmission],mcp4728_simpleCommand->[endTransmission,write,beginTransmis... | This function is used to set the gain of all registers in the device. | With `driverPercent` as an array, this could take the single argument `uint16_t percent[XYZE]`. Note also that these values should be `uint16_t` instead of `float`. (The `mcp4728_values` array is `uint16_t`.) |
@@ -120,11 +120,12 @@ class RulesSanityTest {
.collect(Collectors.toList());
assertThat(errorLogs)
- .hasSize(6)
+ .hasSize(8)
.allMatch(log -> log.getFormattedMsg().toLowerCase().contains("parse"));
assertThat(parsingErrorFiles)
- .hasSize(3)
- .allMatch(log -> log.contain... | [RulesSanityTest->[getClassPath->[add,getClassPath,File,addAll],isNotParsingErrorFile->[contains],sonarComponents->[forSonarLint,create,SonarComponents,add,setSensorContext,setProperty,fileSystem,forEach,setSettings,setRuntime],inputFile->[build,IllegalStateException,format,File,getAbsolutePath],getJavaInputFiles->[toL... | Test if all the checks fail. Private method for getting the string representation of a failure. | In test for Java 8 `yield()` method is allowed to be outside of switch expression, while in the recent versions of Java it doesn't parse. |
@@ -1422,6 +1422,7 @@ class SourceEstimate(_BaseSourceEstimate):
clim=clim, cortex=cortex, size=size,
background=background,
foreground=foreground,
+ initial_time=ini... | [SourceEstimate->[center_of_mass->[_center_of_mass],expand->[copy,_remove_kernel_sens_data_],__init__->[__init__],to_original_src->[SourceEstimate],in_label->[_hemilabel_stc,SourceEstimate],save->[_write_stc,_write_w],extract_label_time_course->[extract_label_time_course]],save_stc_as_volume->[save],_BaseSourceEstimate... | Plots a single Brain object with a series of source analyses. Displays a curvature window. Return a BrainEstimate from the current source to the original subject. Get the source estimate for a given node. | This was just added to `PySurfer`, right? So now people have to run `master` to do any brain plots? If so, that's not what we want -- you could do some introspection with `_get_args` and use `set_time_index` if the argument is not available in the constructor. |
@@ -80,7 +80,10 @@ namespace System.Net.Http
if (GZipEnabled && last == Gzip)
{
- response.Content = new GZipDecompressedContent(response.Content);
+ if(await CheckContentSignatureAsync(await response.Content.ReadAsStreamAsync(cancellationToken),... | [No CFG could be retrieved] | Send a request with a specific header and content. Reads the response headers from the original content and stores them in the _originalContent. | I'm not convinced the concept here is something we should try to make work... But that aside, this implementation won't work. It's consuming multiple bytes from the stream. If it is actually gzip, then having consumed the header the gzip lib won't see it as gzip because it lacks the header. If it isn't actually gzip, t... |
@@ -35,18 +35,7 @@ class KeyViewsTest(TestCase):
self.key3 = Key(user=self.user2, description='Test Key 3')
self.key3.save()
- self.client = Client()
-
- def tearDown(self):
- self.user.delete()
- self.user2.delete()
- self.key1.delete()
- self.key2.delete()
- ... | [KeyViewsTest->[test_key_history->[find,append,get,login,log,eq_,pq,eq,ok_,reverse,range],test_delete_key->[find,get,login,post,pq,eq_,filter,ok_,reverse],test_list_key->[find,get,login,pq,eq_,reverse],setUp->[Client,User,set_password,save,Key],tearDown->[delete],test_new_key->[find,get,check_secret,login,post,pq,eq_,f... | Initialize all the components of the authkey object. Check if a key is present on the result page. | Redundant and moved to `setUp()` |
@@ -56,12 +56,12 @@ public class ServerCookieDecoderTest {
@Test
public void testDecodingGoogleAnalyticsCookie() {
String source =
- "ARPT=LWUKQPSWRTUN04CKKJI; " +
- "kw-2E343B92-B097-442c-BFA5-BE371E0325A2=unfinished_furniture; " +
- "__utma=48461872.1094088325.12581... | [ServerCookieDecoderTest->[testDecodingGoogleAnalyticsCookie->[hasNext,next,value,assertFalse,decode,iterator,assertEquals,name],testRejectCookieValueWithSemicolon->[assertTrue,decode,isEmpty],testDecodingMultipleCookies->[assertNotNull,size,value,decode,iterator,assertEquals,next],testDecodingLongValue->[size,value,de... | Test decoding of a cookie. Checks if there is a next node in the iterator with a name that is not a finished. | please revert formatting changes |
@@ -154,6 +154,8 @@ class MSBuild(object):
if use_env:
command.append('/p:UseEnv=true')
+ else:
+ command.append('/p:UseEnv=false')
if msvc_arch:
command.append('/p:Platform="%s"' % msvc_arch)
| [MSBuild->[_get_props_file_contents->[format_macro]]] | Get the command to build a single node configuration. Generate the command to create a object. | Mhhh, so the default of the `msbuild` is `/p:UseEnv=true`? |
@@ -95,7 +95,8 @@ public class WebServiceEngine implements LocalConnector, Startable {
public void execute(Request request, Response response) {
try {
ActionExtractor actionExtractor = new ActionExtractor(request.getPath());
- WebService.Action action = getAction(actionExtractor.getController(), act... | [WebServiceEngine->[call->[DefaultLocalResponse,LocalRequestAdapter,execute],getAction->[controller,format,action,BadRequestException],sendErrors->[reset,writeJson,of,beginObject,output,endObject,OutputStreamWriter,stream,close,setStatus,setMediaType],ActionExtractor->[extractController->[substringBeforeLast,substring,... | Executes the action. | remark (not linked to your work): the Request class hierarchy would deserve to be simplified, it's very hard to understand what's called and where |
@@ -227,10 +227,11 @@ class BidirectionalLanguageModel(Model):
forward_targets[:, 0:-1] = token_ids[:, 1:]
backward_targets[:, 1:] = token_ids[:, 0:-1]
+ # shape (batch_size, timesteps + 2, embedding_size)
embeddings = self._text_field_embedder(source)
# Apply LayerNorm if... | [BidirectionalLanguageModel->[_compute_loss->[_get_target_token_embedding],forward->[_compute_loss],__init__->[_SoftmaxLoss]]] | Computes the averaged forward and backward LM loss from the batch of tokens. Computes the loss and loss of a single node node node node node node node node node node. | Just to double check, did you mean to add layer norm both here and at the output of the `HighwayCnnEncoder`? I can see that might be useful for someone, but you probably don't want both these layernorms happening simultaneously. |
@@ -230,6 +230,12 @@ public class RemoteInterpreterProcess implements ExecuteResultHandler {
}
}
+ public void setMaxPoolSize(int size) {
+ if (clientPool != null) {
+ //Size + 2 for progress poller , cancel operation
+ clientPool.setMaxTotal(size + 2);
+ }
+ }
/**
* Called when angul... | [RemoteInterpreterProcess->[dereference->[releaseClient,getClient],updateRemoteAngularObject->[releaseClient,getClient]]] | Get the number of idle clients in the pool. | I suggest not limit the thrift client pool size. RemoteInterpreter's maximum concurrency is already limited (1 on FIFO, maxPoolSize on Parallel scheduler), so i think it'll generally safe without limiting thrift clientpool size. Also limiting two different concurrency parameters (one concurrency of job in scheduler, th... |
@@ -76,14 +76,15 @@ namespace NServiceBus.Hosting.Helpers
{
if (!assembly.IsDynamic)
{
- ScanAssembly(AssemblyPath(assembly), results, processed);
+ ScanAssembly(assembly, results, processed);
}... | [AssemblyScanner->[ReferencesNServiceBus->[ReferencesNServiceBus,IsRuntimeAssembly],IsRuntimeAssembly->[IsRuntimeAssembly]]] | Scan all assemblies in the base directory and return a list of all the handlers that. | `AssemblyPath` tries to get the assemblies file location which we don't need at all for already loaded assemblies |
@@ -350,7 +350,6 @@ namespace ProtoImperative
if (!isAccessible)
{
- type = lefttype = realType;
string message = String.Format(ProtoCore.Properties.Resources.kMethodIsInaccessible, procName);
... | [CodeGen->[EmitFunctionCallNode->[TraverseFunctionCall],DfsTraverse->[EmitFunctionCallNode,EmitIdentifierNode,EmitLanguageBlockNode,EmitIfStmtNode,EmitForLoopNode,EmitInlineConditionalNode,EmitRangeExprNode,EmitBreakNode,EmitWhileStmtNode,EmitContinueNode,EmitIdentifierListNode,EmitBinaryExpressionNode,EmitUnaryExpress... | Traverse a function call. This method is called to determine if a method is a static or a constructor. Determines the type of the node that is referenced by the given parameter. Returns null if no function is found. | This assignment is already happening outside the `if` block. |
@@ -58,7 +58,8 @@ public class VisitorsBridgeForTests extends VisitorsBridge {
}
public VisitorsBridgeForTests(Iterable<? extends JavaCheck> visitors, List<File> projectClasspath, @Nullable SonarComponents sonarComponents) {
- super(visitors, projectClasspath, sonarComponents, SymbolicExecutionMode.getMode(I... | [VisitorsBridgeForTests->[TestJavaFileScannerContext->[createAnalyzerMessage->[createAnalyzerMessage]]]] | Creates a new scanner context for the given sequence of Java files. | I think it might be simpler to write a new method in SymbolicExecutionMode accepting an Iterable instead of an array. |
@@ -194,12 +194,11 @@ namespace Kratos
template<std::size_t TDim>
double CalculateDistanceToSkinProcess<TDim>::DistancePositionInSpace(const Node<3> &rNode)
{
- typedef Element::GeometryType intersection_geometry_type;
- typedef std::vector<std::pair<double, intersection_geometry_type*> > intersections_co... | [No CFG could be retrieved] | region Element - based FindIntersectedObjectsProcess Method Get the intersections of a ray. | do you need to make a copyhere? isn't a reference enough? |
@@ -21,7 +21,7 @@ def test_check_ignore(tmp_dir, dvc, file, ret, output, caplog):
"file,ret,output",
[
("file", 0, "{}:1:f*\tfile\n".format(DvcIgnore.DVCIGNORE_FILE)),
- ("foo", 0, "{}:2:!foo\tfoo\n".format(DvcIgnore.DVCIGNORE_FILE)),
+ ("foo", 1, ""),
(
os.path.jo... | [test_check_ignore_default_dir->[main],test_check_ignore->[main,gen],test_check_ignore_dir->[main,gen],test_check_ignore_sub_repo->[join,main,format,gen],test_check_sub_dir_ignore_file->[chdir,format,join,gen,main],test_check_ignore_details_all->[main,format,gen],test_check_ignore_stdin_mode->[main,gen,patch],test_chec... | Test the presence of a specific in a log. Test that the check - ignore option is not matching. | It is a feature that follows the result from `Git`, in which `0` and `1` are used to distinguish if any pattern either an include one or an exclude one matches. But I think it is more reasonable to use them to distinguish `include` and `exclude`. Maybe our help doc needs to be updated with this. |
@@ -1,7 +1,7 @@
# Copyright (c) 2015 Ultimaker B.V.
# Cura is released under the terms of the AGPLv3 or higher.
-from . import USBPrinterManager
+from . import USBPrinterOutputDeviceManager
from PyQt5.QtQml import qmlRegisterType, qmlRegisterSingletonType
from UM.i18n import i18nCatalog
i18n_catalog = i18nCatalo... | [getMetaData->[i18nc],register->[getInstance,qmlRegisterSingletonType],i18nCatalog] | Returns metadata about the last N - tuple. | How does this work? Is this a missing file? Because it is not in this review. |
@@ -1387,6 +1387,8 @@ function createBaseCustomElementClass(win) {
this.actionQueue_ = [];
}
devAssert(this.actionQueue_).push(invocation);
+ // Schedule build sooner.
+ this.build();
} else {
this.executionAction_(invocation, false);
}
| [No CFG could be retrieved] | This method is called when a new element is created and notifies its owner. Executes the action immediately if the action is not already executed. | FMI: This line attempts to give priority to an element if it has an action queued on it? I'm guessing this is a new behavior? It makes sense to me |
@@ -33,6 +33,7 @@ public abstract class AggregateFunctionFactory {
.add(ImmutableList.of(Schema.OPTIONAL_INT32_SCHEMA))
.add(ImmutableList.of(Schema.OPTIONAL_INT64_SCHEMA))
.add(ImmutableList.of(Schema.OPTIONAL_FLOAT64_SCHEMA))
+ .add(ImmutableList.of(DecimalUtil.builder(1, 1).build()))
... | [AggregateFunctionFactory->[eachFunction->[getProperAggregateFunction],getDescription->[getDescription],getName->[getName],isInternal->[isInternal],getVersion->[getVersion],getPath->[getPath],getAuthor->[getAuthor]]] | Creates an AggregateFunctionFactory which creates a new object from a UdfMetadata object. Get the description of the object. | Hummm.... doesn't this strictly mean that the factories support binaries only if the have scale and precision of `1`? |
@@ -1212,7 +1212,7 @@ class StatementAnalyzer
if (!metadata.schemaExists(session, new CatalogSchemaName(name.getCatalogName(), name.getSchemaName()))) {
throw semanticException(SCHEMA_NOT_FOUND, table, "Schema '%s' does not exist", name.getSchemaName());
}
- ... | [StatementAnalyzer->[Visitor->[hasBoundedCharacterType->[hasNestedBoundedCharacterType],createScopeForView->[analyzeFiltersAndMasks],visitLateral->[analyze,StatementAnalyzer],visitExcept->[visitSetOperation],visitQuery->[process],tryProcessRecursiveQuery->[process],analyzeParameterAsRowCount->[analyzeExpression],visitE... | Visit a table. Returns a scope for the given materialized view or logical view. Analyze the given field and return a scope that can be used to find the next missing field. | if we want to go in this direction, we would need to update schema check above, and perhaps others also, this should be test covered (eg to make sure the actual exception comes from here, and not some oither place) |
@@ -288,6 +288,8 @@ class Server:
return {'restart': 'plugins changed'}
except InvalidSourceList as err:
return {'out': '', 'err': str(err), 'status': 2}
+ except SystemExit as e:
+ return {'out': '', 'err': stderr.getvalue(), 'status': e.code}
retur... | [daemonize->[_daemonize_cb],Server->[find_changed->[find_changed],update_changed->[update_changed]]] | Check a list of files and trigger a restart if needed. | I just stumbled upon another edge case: `dmypy run -- --help` will exit without any output. This is because argparse intercepts `--help` (and `-h` etc.) and prints the full help text to stdout and exits with zero status. I'm not sure what to do about this -- I suppose you could catch stdout too? Or ignore the issue? |
@@ -2668,7 +2668,7 @@ def classification_cost(input, label, name=None,
return LayerOutput(name, LayerType.COST, parents=[input, label])
def conv_operator(input, filter_size, num_filters,
- num_channel=None, stride=1, padding=0,
+ num_channel=None, stride=1, padding=0, groups=1,... | [recurrent_group->[memory,identity_projection,mixed_layer,is_single_input],fc_layer->[LayerOutput],scaling_layer->[LayerOutput],last_seq->[LayerOutput],regression_cost->[LayerOutput],img_cmrnorm_layer->[__img_norm_layer__],conv_shift_layer->[LayerOutput],slope_intercept_layer->[LayerOutput],out_prod_layer->[LayerOutput... | A function to create a convolution operator. MissingNetworkError - A version of the above. | suggest to split input into two parameters: image and kernel to make the interface clearer |
@@ -56,7 +56,7 @@ static int gcm_init(void *vctx, const unsigned char *key, size_t keylen,
return 0;
}
ctx->ivlen = ivlen;
- memcpy(ctx->iv, iv, ctx->ivlen);
+ memcpy(ctx->iv, iv, ivlen);
ctx->iv_state = IV_STATE_BUFFERED;
}
| [gcm_stream_final->[gcm_cipher_internal],int->[setkey,cipherupdate,ctr64_inc,OPENSSL_cleanse,setiv,memcpy,rand_bytes_ex,gcm_tls_cipher,gcm_iv_generate,oneshot,cipherfinal,aadupdate,ERR_raise],gcm_deinitctx->[OPENSSL_cleanse],gcm_set_ctx_params->[OSSL_PARAM_get_octet_string,gcm_tls_init,OSSL_PARAM_get_size_t,gcm_tls_iv_... | Initializes a GCM context. | Is there a reason not to call `cipher_generic_initiv` here? |
@@ -19,12 +19,12 @@ def create():
\b
Examples:
- $ prefect create project "My Project"
- My Project created
+ $ prefect create project "Hello, World!"
+ Hello, World! created
\b
- $ prefect create project My-Project --description "My description"
- My-Project... | [project->[format,secho,Client],option,group,argument,command] | Create commands that refer to mutations of Prefect API metadata. | To make the presence/absence of quotes for CLI things more transparent, should we default to a name that wouldn't need to be quoted? Perhaps `hello-world` or something similar? No strong thoughts, happy either way. |
@@ -404,10 +404,10 @@ define([
this.look(this._camera.direction, -amount);
};
- var appendTransformPosition = Cartesian4.clone(Cartesian4.UNIT_W);
- var appendTransformUp = Cartesian4.clone(Cartesian4.ZERO);
- var appendTransformRight = Cartesian4.clone(Cartesian4.ZERO);
- var appendTransfor... | [No CFG could be retrieved] | Twist the camera clockwise around its direction vector by amount in radians. cartesian3 - > Vector3. | You can remove all of these now and use the world coordinate directions and position directly. |
@@ -102,6 +102,8 @@ class Alpgen(MakefilePackage):
@when('recipe=cms')
def build(self, spec, prefix):
+ copy(join_path(os.path.dirname(__file__), 'cms_build.sh'), 'cms_build.sh')
+ copy(join_path(os.path.dirname(__file__), 'cms_install.sh'), 'cms_install.sh')
bash = which('bash')
... | [Alpgen->[install->[walk,set_install_permissions,working_dir,which,make,bash],url_for_version->[rsplit,up_to,format],build->[which,working_dir,make,bash],cmake->[abspath,append,working_dir,cmake_x,which,cmake_args],build_directory->[join],patch->[join_path,satisfies,dirname,copy,filter_file],build_dirname->[dag_hash],s... | Build and install modules. | These two copies seem better suited for a `patch` method since they change the files in the stage area. |
@@ -6806,6 +6806,13 @@ int main(int argc, char* argv[])
else
{
tools::signal_handler::install([&w](int type) {
+#ifdef HAVE_READLINE
+ if (simplewallet_suspend_readline::is_in_password())
+ {
+ MDEBUG("in_password, not exiting");
+ return;
+ }
+#endif
#ifdef WIN32
if (typ... | [No CFG could be retrieved] | Check if the user has specified a specific . | This will always be racy unless the lock is acquired in the signal handler and held throughout the entire call. That would violate the behavior that can be done in a signal handler, which means this patch is violating signal handler rules in this function call (and several existing issues below remain). Also, my `atomi... |
@@ -247,10 +247,11 @@ namespace MonoGame.Framework
{
_window.Dispose();
_window = null;
- Window = null;
- }
- Microsoft.Xna.Framework.Media.MediaManagerState.CheckShutdown();
+ Window = null;
... | [WinFormsGamePlatform->[Present->[Present],RunLoop->[RunLoop],BeforeInitialize->[BeforeInitialize],Dispose->[Dispose],BeforeRun->[BeforeRun]]] | Override Dispose to perform the necessary cleanup after the window is disposed. | We set the List on Keyboard, so we should release it. |
@@ -2,6 +2,12 @@
# Copyright (c) Microsoft Corporation.
# Licensed under the MIT License.
# ------------------------------------
+# pylint: skip-file
+
+from enum import Enum, EnumMeta
+from six import with_metaclass
+
+import msrest
class CommunicationUserIdentifier(object):
"""
| [No CFG could be retrieved] | Creates an object that represents a communication user identifier. | do we need to add these in ...n/azure-communication-administration/azure/communication/administration/_shared/models.py? |
@@ -30,8 +30,8 @@ module Rack
track_and_return_ip(request.env["HTTP_FASTLY_CLIENT_IP"])
end
- throttle("message_throttle", limit: 2, period: 1) do |request|
- if request.path.starts_with?("/messages") && request.post?
+ throttle("message_tag_throttle", limit: 2, period: 1) do |request|
+ i... | [Attack->[track_and_return_ip->[to_s,add_field,blank?],put?,env,starts_with?,add_field,delete?,post?,get?,present?,track_and_return_ip,throttle],throttled_response_retry_after_header] | track and return ip if it is not in the cache. | I wonder if 2 will be a problem with mods who accesses `/t/tag/edit` but we can raise it if it becomes a problem |
@@ -104,6 +104,11 @@ func (s *Sender) ParsePayments(ctx context.Context, uid gregor1.UID, convID chat
s.Debug(ctx, "ParsePayments: failed to getConvParseInfo %v", err)
return nil
}
+ replyToUID, err := s.handleReplyTo(ctx, uid, convID, replyTo)
+ if err != nil {
+ s.Debug(ctx, "ParsePayments: failed to handleR... | [DescribePayments->[paymentsToMinis,getConvFullnames],ParsePayments->[validConvUsername,getRecipientUsername,getConvParseInfo]] | ParsePayments parses a single payment from the chat. Package private for testing. | What if I specify someone with @? |
@@ -393,6 +393,7 @@ namespace ViewExtensionLibraryTests
Assert.AreEqual(3, model.NumElements);
Assert.IsTrue(resetevent.WaitOne(timeout*100));
+ resetevent.Dispose();
controller.Verify(c => c.RaiseEvent(libraryDataUpdated), Times.Once);
var spec = customization.... | [TestNodeSearchElement->[Split,Add],LibraryResourceProviderTests->[EventControllerCallback->[On,Object,Returns,ExecuteAsync,Verify,DetailsViewContextData],PackagedCustomNodeSearchElementLoadedType->[Object,fullyQualifiedName,Url,AreEqual,Empty,keywords,contextData,iconUrl,ToString,NewGuid,provider],NodeSearchElementLoa... | Tests if libraryDataUpdated is raised. Missing element in libraryDataUpdated. | hmm why are these indented? |
@@ -105,7 +105,11 @@ def geth_create_account(datadir, privkey):
"""
keyfile_path = os.path.join(datadir, 'keyfile')
with open(keyfile_path, 'w') as handler:
- handler.write(hexlify(privkey))
+ handler.write(hexlify(privkey).decode())
+
+ password_path = os.path.join(datadir, 'pw')
+ w... | [geth_create_blockchain->[geth_bare_genesis,geth_create_account,geth_init_datadir,geth_to_cmd,geth_wait_and_check],geth_bare_genesis->[clique_extradata]] | Create a new account in datadir with private key privkey. | The file handle is missing the binary option. |
@@ -53,6 +53,11 @@ namespace Dynamo.PackageManager
get { return Path.Combine(RootDirectory, "extra"); }
}
+ public string NodeDocumentaionDirectory
+ {
+ get { return Path.Combine(RootDirectory, "doc"); }
+ }
+
public bool Loaded { get; internal set; }
... | [Package->[Log->[Log],UninstallCore->[MarkForUninstall]]] | PackageManager provides a namespace for the node package manager. Contents - > keywords. | please add ///summary. |
@@ -394,7 +394,7 @@ public class AugmentPhase implements AppCreationPhase<AugmentPhase>, AugmentOutc
for (BiFunction<String, ClassVisitor, ClassVisitor> i : visitors) {
visitor = i.apply(className, visitor);
... | [AugmentPhase->[getPropertiesHandler->[setConfigDir],doProcess->[setBuildSystemProperties]]] | This method will process the application. Writes a single class file. This method is called when a class is being transformed. It will copy all the contents of This method is called when the application archive is not present in the application archive. | Hmmm, tbh, I'm not sure it is the right fix. I would expect all the additional visitors to be ignored if we do it this way. |
@@ -32,11 +32,11 @@ const files = {
'.eslintrc.json',
'tsconfig.json',
'tsconfig.test.json',
- 'webpack/logo-jhipster.png',
'webpack/webpack.common.js',
'webpack/webpack.dev.js',
'webpack/webpack.prod.js... | [No CFG could be retrieved] | This function is responsible for generating the file. Get all the files that are needed by the . | `npm run lint-fix` to fix error, I think comma is missing at the end of the line |
@@ -13,15 +13,15 @@ class PyMypy(PythonPackage):
pypi = "mypy/mypy-0.740.tar.gz"
version('0.910', sha256='704098302473cb31a218f1775a873b376b30b4c18229421e9e9dc8916fd16150')
+ version('0.900', sha256='65c78570329c54fb40f956f7645e2359af5da9d8c54baa44f461cdc7f4984108')
version('0.800', sha256='e0202e37... | [PyMypy->[variant,depends_on,version]] | Package name is the package name of the package. | The error is that you forgot an `@` here, but the error message was not great! |
@@ -1773,6 +1773,8 @@ class MNEBrowseFigure(MNEFigure):
if 'raw' in (self.mne.instance_type, self.mne.ica_type):
return self.mne.inst[:, start:stop]
else:
+ if not self.mne.inst.preload:
+ self.mne.inst.load_data()
data = np.concatenate(self.mne.inst... | [MNEBrowseFigure->[_toggle_annotation_fig->[_create_annotation_fig],_resize->[_get_size_px],_draw_annotations->[_clear_annotations],_draw_traces->[_hide_scalebars,_show_scalebars],_add_annotation_label->[_update_annotation_fig,_set_active_button,_radiopress],_check_update_hscroll_clicked->[_update_hscroll],_toggle_scal... | Retrieve the bit of data we need for plotting. | Better than this would probably be `get_data` geting just the part you need. It can drastically reduce memory requirements. I think it's worth going through the indexing gymnastics to figure it out. In particular you probably need to do something like `mne.inst.drop_bad()` then look at `len(inst)` and `len(epochs.times... |
@@ -854,7 +854,7 @@ tse_task_complete(tse_task_t *task, int ret)
if (done)
tse_task_complete_locked(dtp, dsp);
} else {
- tse_task_decref_locked(dtp);
+ tse_task_decref_free_locked(task);
}
D_MUTEX_UNLOCK(&dsp->dsp_lock);
| [No CFG could be retrieved] | This function waits for all in - flight tasks to complete. Adds a task to the scheduler list if it is not already done. | here the task should at least have one refcount right? because the last one refcount suppose to be dropped in below tse_sched_process_complete(). |
@@ -2127,9 +2127,9 @@ class Manager {
return new \WP_Error( 'no_token', 'Error generating token.', 400 );
}
- $is_master_user = ! $this->is_active();
+ $is_connection_owner = false === $this->get_connection_owner();
- Utils::update_user_token( $current_user_id, sprintf( '%s.%d', $token, $current_user_id )... | [Manager->[generate_secrets->[get_secret_callable],get_token->[api_url],verify_secrets->[delete_secrets,get_secrets],sign_role->[get_access_token],xmlrpc_options->[is_active],is_connection_owner->[get_connection_owner_id],authorize->[get_token,is_active],add_stats_to_heartbeat->[is_active],reconnect->[disconnect_site_w... | This function is called when the user is authorized to perform the action. This function is called when a user is authorized. | The `Manager` class has 2 methods that might be more appropriate here (not sure) `is_connection_owner` - which has the same name as the variable, and checks if the current user is the connection owner `has_connection_owner` - that only checks if the connection is owned by someone and returns a boolean... it's basically... |
@@ -130,6 +130,9 @@ class WithdrawExpired(SignedRetrieableMessage):
def _data_to_sign(self) -> bytes:
return pack_data(
+ (self.cmdid.value, "uint8"),
+ (b"\x00" * 3, "bytes"), # padding
+ (self.nonce, "uint256"),
(self.token_network_address, "address"),
... | [WithdrawRequest->[_data_to_sign->[pack_data],from_event->[cls]],WithdrawConfirmation->[_data_to_sign->[pack_data],from_event->[cls]],WithdrawExpired->[_data_to_sign->[pack_data],from_event->[cls]],dataclass] | Return the data to sign. | If the goal is to differentiate the signature shouldn't the `cmdid` and perhaps also `nonce` be added to all other withdraw message types? Why only have it in `WithdrawExpired`? What is special about this message? Is it the only one that does not go in the contracts? It looks a bit odd to only have it here. |
@@ -40,10 +40,8 @@ class Article < ApplicationRecord
has_many :rating_votes, dependent: :destroy
has_many :top_comments,
lambda {
- where(
- "comments.score > ? AND ancestry IS NULL and hidden_by_commentable_user is FALSE and deleted is FALSE",
- 10,
- ... | [Article->[username->[username],evaluate_front_matter->[set_tag_list],update_notifications->[update_notifications],readable_edit_date->[edited?]]] | The comments are touched along with all its articles. Validate the main image. | Rewriting this in standard `ActiveRecord` DSL, no string query necessary. Note that ranges are inclusive of their beginning, so the original `> 10` is now `>= 11`. |
@@ -129,7 +129,9 @@ public final class QuerySchemas {
final Set<String> keyLoggerNames = kvLoggerNames.getOrDefault(true, ImmutableSet.of());
if (keyLoggerNames.size() != 1) {
- throw new IllegalStateException("Multiple key logger names registered for topic."
+ final String result = keyLoggerNames... | [QuerySchemas->[SchemaInfo->[merge->[SchemaInfo],equals->[equals]],trackSerde->[equals],equals->[equals]]] | Get the schema info for a given topic. | Why not throw an exception any longer? -- What about the case of `zero` that we now consider valid? Why that? |
@@ -78,7 +78,7 @@ class TestConfigCLI(TestDvc):
self.assertEqual(ret, 251)
ret = main(["config", "core.remote", "myremote"])
- self.assertEqual(ret, 0)
+ self.assertEqual(ret, 251)
ret = main(["config", "core.non_existing_field", "-u"])
self.assertEqual(ret, 251)
| [TestConfigCLI->[test_local->[_do_test],test->[_do_test],_do_test->[_contains]]] | Test non existing section and field. | All other config settings failed in this function. |
@@ -26,7 +26,7 @@ public class BonusIncomeUtils {
if (resource.getName().equals(Constants.PUS)) {
puIncomeBonus = Properties.getPuIncomeBonus(player, bridge.getData());
}
- int bonusIncome = (int) Math.round(((double) amount * (double) (incomePercent - 100) / 100)) + puIncomeBonus;
+ fi... | [BonusIncomeUtils->[addBonusIncome->[round,addChange,changeResourcesChange,getName,equals,getQuantity,append,getData,replace,getInt,startEvent,getIncomePercentage,toString,StringBuilder,getPuIncomeBonus,keySet]]] | Add bonus income. | Checkstyle: "Line is longer than 120 characters (found 121)." |
@@ -168,10 +168,10 @@ function updateReporters(config) {
config.reporters.push('coverage-istanbul');
}
- if (isTravisPushBuild() && JSON_REPORT_TEST_TYPES.has(config.testType)) {
+ if (argv.report) {
config.reporters.push('json-result');
config.jsonResultReporter = {
- outputFile: `results_${... | [No CFG could be retrieved] | Creates a new instance of the karma spec. The browserify config function. | Would rather see `result-reports/${testType}.json` here instead of exporting a function from the report upload task. The function is simple enough, and this helps keep the gulp task modular. |
@@ -42,6 +42,7 @@ public class EGViewer {
private static final ActionParser<Tree> PARSER = JavaParser.createParser(StandardCharsets.UTF_8);
private final Viewer viewer;
+ private static final boolean SHOW_CACHE = true;
EGViewer(Viewer viewer) {
this.viewer = viewer;
| [EGViewer->[buildEG->[newArrayList,parse,get,getEg,createFor],egToDot->[indexOf,joining,keySet,collect],analyse->[setText,egToDot,buildEG,getEngine,executeScript,buildCFG,toString],getEg->[ExplodedGraphWalker,visitMethod,MethodBehavior,symbol,getExplodedGraph],createParser]] | Imports a single from a source file. Reads the source code for an and returns it as a string. | Naming! notion of cache should probably not appear anywhere except for the walker : this is implementation detail. |
@@ -55,7 +55,10 @@ public class HeliumOnlineRegistry extends HeliumRegistry {
public HeliumOnlineRegistry(String name, String uri, File registryCacheDir) {
super(name, uri);
registryCacheDir.mkdirs();
- this.registryCacheFile = new File(registryCacheDir, name);
+
+ UUID registryCacheFileUuid = UUID.n... | [HeliumOnlineRegistry->[getAll->[fromJson,getMessage,error,getContent,build,HttpGet,close,writeToCache,InputStreamReader,getType,getStatusCode,readFromCache,toString,BufferedReader,uri,addAll,values,execute],writeToCache->[exists,toJson,writeStringToFile,delete],readFromCache->[fromJson,getMessage,error,isFile,getType,... | Gets all packages in the cache. | sounds like `UUID.nameUUIDFromBytes` hashes consistently - ie. given the same uri it will return the same uuid? |
@@ -122,6 +122,18 @@ public class HoodieWriteConfig extends DefaultHoodieConfig {
private static final String MERGE_DATA_VALIDATION_CHECK_ENABLED = "hoodie.merge.data.validation.enabled";
private static final String DEFAULT_MERGE_DATA_VALIDATION_CHECK_ENABLED = "false";
+
+ public static final String ORC_STRIP... | [HoodieWriteConfig->[resetViewStorageConfig->[setViewStorageConfig],Builder->[build->[HoodieWriteConfig,validate,setDefaults]]]] | This class defines the properties of a single object that can be used to determine if the data This is a static property that can be used to specify the external record and schema transformation. | we could move these to `HoodieStorageConfig` along with other parquet options? |
@@ -288,6 +288,11 @@ public class BigQueryStorageStreamSource<T> extends BoundedSource<T> {
source.stream.getName(),
fraction);
+ if (fraction <= 0.0 || fraction >= 1.0) {
+ LOG.info("BigQuery Storage API does not support splitting at fraction {}", fraction);
+ return null;
+ ... | [BigQueryStorageStreamSource->[BigQueryStorageStreamReader->[close->[close],getFractionConsumed->[getFractionConsumed],splitAtFraction->[fromExisting]],populateDisplayData->[populateDisplayData],toString->[toString],fromExisting->[BigQueryStorageStreamSource]]] | This method is called when a new source is split at a specific fraction of the current source This method is called when a split operation is successful. It can be called by the split. | What values did you observe ? It's surprising if you receive negative values here for example. |
@@ -196,6 +196,13 @@ bool EncapsulationHeader::to_encoding(
return true;
}
+static const int FOUR_BYTE_ALIGNMENT = 4;
+
+void EncapsulationHeader::set_padding_marker(char& options, size_t size)
+{
+ options |= ((FOUR_BYTE_ALIGNMENT - size % FOUR_BYTE_ALIGNMENT) & 0x03);
+}
+
OPENDDS_STRING EncapsulationHeader::... | [No CFG could be retrieved] | Get the encoding of a header. - - - - - - - - - - - - - - - - - -. | Could this be one of the existing constants in Serializer.h? Maybe `ALIGN_XCDR2`? |
@@ -49,7 +49,16 @@ namespace System.Security.Cryptography
}
[System.Diagnostics.CodeAnalysis.SuppressMessage("Microsoft.Security", "CA5351", Justification = "This is the implementation of DSACryptoServiceProvider")]
- public override byte[] CreateSignature(byte[] rgbHash) => _impl.CreateSigna... | [DSACryptoServiceProvider->[VerifySignature->[VerifySignature],FromXmlString->[FromXmlString],HashData->[HashData],TrySignData->[TrySignData],CreateSignature->[CreateSignature],SignHash->[CreateSignature],ImportParameters->[ImportParameters],ImportEncryptedPkcs8PrivateKey->[ImportEncryptedPkcs8PrivateKey],VerifyData->[... | Override this method to provide a signature. | This is also a breaking change; but it makes DSACryptoServiceProvider consistent across all platforms. |
@@ -495,6 +495,7 @@
#include <string.h>
#include <pgmspace.h>
+#define _UMM_MALLOC_CPP
#include "umm_malloc.h"
#include "umm_malloc_cfg.h" /* user-dependent */
| [No CFG could be retrieved] | The excess and add it to the free list. Creates a macro to place constant strings into PROGMEM and print them properly. | Drop this define, as mentioned elsewhere. |
@@ -27,7 +27,8 @@ type KubeConnectionArgs struct {
}
func BindKubeConnectionArgs(args *KubeConnectionArgs, flags *pflag.FlagSet, prefix string) {
- flags.Var(&args.KubernetesAddr, prefix+"kubernetes", "The address of the Kubernetes server (host, host:port, or URL). If specified, no Kubernetes components will be sta... | [GetKubernetesAddress->[GetExternalKubernetesClientConfig]] | BindKubeConnectionArgs binds the given flags to the given object and returns a pointer to a GetKubernetesAddress returns the address of the Kubernetes node that the client is using. | call it deprecated, and tell them to use --kubeconfig instead (same message as if they use it) |
@@ -989,7 +989,7 @@ class Spec(object):
self.architecture = None
self.compiler = None
self.external_path = None
- self.external_module = None
+ self.external_modules = None
self.compiler_flags = FlagMap(self)
self._dependents = DependencyMap()
self._de... | [colorize_spec->[insert_color],save_dependency_spec_yamls->[to_yaml,format,from_yaml,traverse,write],DependencySpec->[copy->[DependencySpec]],ConflictsInSpecError->[__init__->[format,tree]],SpecParser->[check_identifier->[format],spec->[_add_default_platform,_dup,_set_compiler,_add_versions,satisfies,Spec,_add_flag,spe... | Initialize a new object with all the fields from the passed in object. Check if spec_like is None. | (question) should this default to being an empty list? |
@@ -444,15 +444,15 @@ public class HoodieAvroUtils {
/**
* Obtain value of the provided field as string, denoted by dot notation. e.g: a.b.c
*/
- public static String getNestedFieldValAsString(GenericRecord record, String fieldName, boolean returnNullIfNotFound) {
- Object obj = getNestedFieldVal(record,... | [HoodieAvroUtils->[bytesToAvro->[bytesToAvro],addMetadataFields->[isMetadataField,addMetadataFields],rewriteRecord->[isMetadataField],createHoodieWriteSchema->[createHoodieWriteSchema],getRecordColumnValues->[getNestedFieldVal,getRecordColumnValues,getNestedFieldValAsString]]] | This method returns the value of the named nested field in the given record. | @codope @nsivabalan folks, i don't believe this is the right fix to address the problem: bubbling down this config value we're now exposing every user of this API to be aware of it, which, very likely, will have very little to do with it. |
@@ -1503,7 +1503,9 @@ def read_meas_info(fid, tree, clean_bads=False, verbose=None):
info['custom_ref_applied'] = custom_ref_applied
info['xplotter_layout'] = xplotter_layout
info['kit_system_id'] = kit_system_id
- info._check_consistency()
+
+ info._unlocked = False
+
return info, meas
| [write_info->[write_meas_info],write_meas_info->[_check_dates,_rename_comps,_check_consistency],create_info->[_update_redundant,_check_consistency],anonymize_info->[_add_timedelta_to_stamp,_check_dates,_check_consistency],_ensure_infos_match->[_check_consistency],_empty_info->[Info,_update_redundant,_check_consistency]... | Read the measurement info. read_tag - read the next tag. Read the next N - tuple of the next tag. Reads a specific from the file descriptor. Reads a n - node tag from a file. Reads all data in the file and returns it as a dict. | why removing this one |
@@ -2948,15 +2948,12 @@ if ($action == 'create')
print '</div></div>';
// Next situation invoice
- $opt = $form->selectSituationInvoices(GETPOST('originid'), $socid);
print '<div class="tagtr listofinvoicetype"><div class="tagtd listofinvoicetype">';
$tmp='<input type="radio" name="type" value="5"' ... | [update_price,create,form_multicurrency_rate,get_OutstandingBill,jdate,getLinesArray,setValueFrom,getVentilExportCompta,getNomUrl,select_incoterms,begin,select_comptes,insert_discount,getLibType,setProject,add_contact,showOptionals,printOriginLinesList,textwithpicto,fetch_optionals,free,transnoentitiesnoconv,query,form... | Print the sequence number of conditions renders the element of the form that is used to replace an invoice with a new invoice. | Where are the < select > around the < option > now ? |
@@ -383,7 +383,13 @@ public class HoodieFlinkWriteClient<T extends HoodieRecordPayload> extends
protected List<WriteStatus> compact(String compactionInstantTime, boolean shouldComplete) {
// only used for metadata table, the compaction happens in single thread
try {
- List<WriteStatus> writeStatuses =... | [HoodieFlinkWriteClient->[getTableAndInitCtx->[getTableAndInitCtx],getPartitionToReplacedFileIds->[getHoodieTable],compact->[compact,commitCompaction],upsert->[upsert],createIndex->[createIndex],delete->[delete],insert->[insert],insertOverwriteTable->[insertOverwriteTable],insertOverwrite->[insertOverwrite]]] | Compacts the given time and returns the list of write statuses. | A better way is moving the `new RunCompactionActionExecutor` execution into the `HoodieFlinkTable` impl `#compact` |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.