patch stringlengths 18 160k | callgraph stringlengths 4 179k | summary stringlengths 4 947 | msg stringlengths 6 3.42k |
|---|---|---|---|
@@ -366,9 +366,10 @@ export class Viewport {
/** @private */
resize_() {
- let oldWidth = this.width_;
- this.width_ = this.getSize().width;
- this.changed_(oldWidth != this.width_, 0);
+ let oldSize = this.size_;
+ this.size_ = null; // Need to recalc.
+ let newSize = this.getSize();
+ th... | [No CFG could be retrieved] | The ViewportBinding class is used to implement the scroll functionality for the Viewport. Registers a callback for resize and scroll events. | Why not immediately do `this.size_ = this.getSize()` since it's read anyway? |
@@ -139,7 +139,7 @@ def _get_dvc_repo_info(repo):
if repo.root_dir != repo.scm.root_dir:
return "dvc (subdir), git"
- return "dvc, git"
+ return "dvc + git"
def add_parser(subparsers, parent_parser):
| [_get_dvc_repo_info->[get],add_parser->[add_parser,set_defaults,append_doc_link],CmdVersion->[get_linktype_support_info->[link,append,is_link,uuid4,str,unlink,items,join,remove,open],get_fs_type->[disk_partitions,Path,chain],get_supported_remotes->[append,get_missing_deps,join],run->[relpath,abspath,append,python_versi... | Get the DVC repo info. | We need to make this uniform, either we should make it all commas or all plus-es. Could just use comma for now. |
@@ -542,7 +542,7 @@ class RemoteLOCAL(RemoteBASE):
def _create_unpacked_dir(self, checksum, dir_info, unpacked_dir_info):
self.makedirs(unpacked_dir_info)
- for entry in progress(dir_info, name="Created unpacked dir"):
+ for entry in Tqdm(dir_info, desc="Creating unpacked dir", unit="dir")... | [RemoteLOCAL->[pull->[_process],isfile->[isfile],unprotect->[exists,_unprotect_dir,isdir,_unprotect_file],push->[_process],_unprotect_file->[remove],remove->[exists,remove],_create_unpacked_dir->[_link,makedirs],_unprotect_dir->[_unprotect_file],move->[isfile,move,makedirs],_group->[get],_changed_unpacked_dir->[get,_ge... | Create the unpacked directory. | Unit is `file` here. |
@@ -110,7 +110,7 @@ class AnalyticsController extends AbstractRestController implements ClassResourc
$entity = $this->analyticsManager->create($webspace, $data);
$this->entityManager->flush();
- $this->cacheClearer->clear();
+ $this->cacheClearer->clear($webspace);
return $t... | [AnalyticsController->[getAction->[view,find,handleView],cdeleteAction->[handleView,flush,get,clear,removeMultiple,view],cgetAction->[findAll,view,handleView],deleteAction->[handleView,flush,remove,clear,view],postAction->[create,all,buildContent,handleView,flush,clear,view],getSecurityContext->[getCurrentRequest,get],... | Creates a new entity. | think should be an array now or? |
@@ -243,13 +243,12 @@ public class InGameLobbyWatcher {
}
void setGame(final IGame game) {
- if (this.game != null) {
- this.game.removeGameStepListener(gameStepListener);
- }
this.game = game;
if (game != null) {
- game.addGameStepListener(gameStepListener);
- gameStepChanged(gam... | [InGameLobbyWatcher->[newInGameLobbyWatcher->[InGameLobbyWatcher],setGameStatus->[postUpdate,setGame],setPassworded->[postUpdate],shutDown->[shutDown,cleanUpGameModelListener],setGameComments->[postUpdate],setGameSelectorModel->[gameSelectorModelUpdated]]] | Sets the game. | This alone makes it worth making the listeners dependent on the GameData instance. |
@@ -16,6 +16,7 @@ class PyPyproj(PythonPackage):
maintainers = ['citibeth', 'adamjstewart']
import_modules = ['pyproj']
+ version('2.6.0', sha256='977542d2f8cf2981cf3ad72cedfebcd6ac56977c7aa830d9b49fa7888b56e83d')
version('2.2.0', sha256='0a4f793cc93539c2292638c498e24422a2ec4b25cb47545addea07724... | [PyPyproj->[setup_build_environment->[set],depends_on,version]] | Creates a new object of type n - tuple with the name of the object and the name Setup the build environment for the project. | For dependencies, it looks like the latest version requires Python 3.5+ and Cython 0.28.4+. |
@@ -179,14 +179,16 @@ public class BigQueryTornadoes {
BigQueryIO.readTableRows()
.fromQuery(options.getInputQuery())
.usingStandardSql()
- .withMethod(Method.DIRECT_READ));
+ .withMethod(Method.DIRECT_READ)
+ ... | [BigQueryTornadoes->[CountTornadoes->[expand->[ExtractTornadoesFn,FormatCountsFn]],runBigQueryTornadoes->[getReadMethod],main->[runBigQueryTornadoes]]] | Runs BigQuery to read the n - th row from the input table and write the result to. | Hm. So `BigQueryIO.readTableRows()` will fail now if `.withFormat()` isn't specified? This is a breaking change to the API. I think instead we should just default to use AVRO when format isn't specified. |
@@ -22,6 +22,11 @@ namespace Content.Server.GameObjects.Components.Cargo
_cargoOrderDataManager.AddComponent(this);
}
+ public int[] GetCapacity()
+ {
+ return new int[2] {Database.CurrentOrderSize,Database.MaxOrderSize};
+ }
+
public override ComponentSt... | [CargoOrderDatabaseComponent->[Initialize->[Initialize]]] | Initialize the component. | It looks like the capacity array is always the same size. I think you probably want to use a tuple type like `(int, int)` instead - it's a fixed length, and makes it clearer how many values you intend to have. |
@@ -143,6 +143,9 @@ public class PersistentAuditEvent implements Serializable {
@Transient
<%_ } _%>
<%_ } _%>
+ <%_ if (databaseType === 'neo4j') { _%>
+ @Transient
+ <%_ } _%>
private Map<String, String> data = new HashMap<>();
<%_ if (databaseType === 'sql') { _%>
| [No CFG could be retrieved] | private Long id ; This class is used to provide a map of data for the given object. | Right now mapping of maps is not part of SDN/RX (on purpose). So let's make it transient for now. As we plan to remove the audit feature (and neo is still in beta) I would say thats okay. |
@@ -60,9 +60,11 @@ public class MemcachedCache implements Cache
.setHashAlg(DefaultHashAlgorithm.FNV1A_64_HASH)
.setLocatorType(ConnectionFactoryBuilder.Locator.CONSISTENT)
.setDaemon(true)
- ... | [MemcachedCache->[deserializeValue->[get],get->[get],create->[MemcachedCache],getBulk->[put,deserializeValue,get]]] | Creates a new MemcachedCache with the specified configuration. | This technically means that at the limit, we could experience timeout \* 2 delay, correct? I.e. it could wait on the OpQueue right until timeout, when it gets taken out and runs, only to wait until timeout on the actual operation. This is not necessarily a problem, just want to understand if these are additive or if th... |
@@ -3,7 +3,7 @@ from nose.tools import assert_raises
from numpy.testing import assert_array_almost_equal
from distutils.version import LooseVersion
-from mne.time_frequency import dpss_windows, multitaper_psd
+from mne.time_frequency.multitaper import dpss_windows, _psd_multitaper
from mne.utils import requires_ni... | [test_multitaper_psd->[assert_array_almost_equal,randn,multitaper_psd,multi_taper_psd,zip,assert_raises,LooseVersion],test_dpss_windows->[assert_array_almost_equal,int,dpss_windows]] | Test computation of DPSS windows. | It might actually be a better idea to test `psd_multitaper` so that you fully test the user facing function. So, if anything fails between the start of this function and the call to the private method, it will get caught ... |
@@ -295,7 +295,12 @@ public class PresentationPane extends WorkbenchPane implements Presentation.Disp
refreshButton_.setVisible(true);
progressButton_.setVisible(false);
}
-
+
+ @Override
+ public void setFocus()
+ {
+ slideNavigationMenu_.focus();
+ }
private final native voi... | [PresentationPane->[prev->[prev],home->[home],next->[next],clear->[clear]]] | Hide a missing key. | There's a repeated pattern here where we set focus to what (presumably) is the first focusable command/button. I worry a little that this is going to be tricky to maintain, because if you permute the order of the commands you're going to wind up making F6 sending command to some random place in the middle, and you won'... |
@@ -592,7 +592,7 @@ def searchProviders(show, episodes, manualSearch=False, downCurQuality=False):
logger.log(u"Seeing if we want to bother with multi-episode result " + _multiResult.name, logger.DEBUG)
- # Filter result by ignore/required/whitelist/blacklist/quality, etc
+ # Filter result ... | [snatchEpisode->[_downloadResult],searchProviders->[isFinalResult,pickBestResult],searchForNeededEpisodes->[wantedEpisodes,pickBestResult]] | Search for a specific n - ary object in all available randomize providers. This function will return a object from the DB. This function returns a list of TVEpisodes objects that can be used to find the add a for each ep in individualResults and add it to the list of found results finds all episodes that are covered ... | This looks wrong |
@@ -351,5 +351,11 @@ module.exports = {
'google-camelcase/google-camelcase': 0,
},
},
+ {
+ 'files': ['src/base-element.js'],
+ 'rules': {
+ 'local/no-private-props': 2,
+ },
+ },
],
};
| [No CFG could be retrieved] | google - camelcase is a special case for the google - camelcase library. | This should be moved out of the root `.eslintrc.js` and into `src/.eslintrc.js`. |
@@ -62,7 +62,9 @@ namespace System.Net
CheckSentHeaders();
if (value == EntitySendFormat.Chunked && HttpListenerRequest.ProtocolVersion.Minor == 0)
{
+#pragma warning disable CA1416 // Validate platform compatibility
throw new ProtocolViolationExce... | [HttpListenerResponse->[Redirect->[Redirect],Dispose->[Dispose]]] | private _statusDescription _httpContext _responseContext _responseHeaders _contentLength ; Replies if the response code is missing or not. | System.Net.Requests assembly is unsupported, called in multi-targeted context |
@@ -150,9 +150,12 @@ int EVP_CipherInit_ex(EVP_CIPHER_CTX *ctx, const EVP_CIPHER *cipher,
skip_to_init:
#endif
/* we assume block size is a power of 2 in *cryptUpdate */
- OPENSSL_assert(ctx->cipher->block_size == 1
- || ctx->cipher->block_size == 8
- || ctx->cipher->block... | [No CFG could be retrieved] | region Private Cipher Functions 15. 2. 5. 4. | Same argument as above, assert alone should be sufficient. BTW, the fact that error is pushed kind of emphasizes point behind "unless one start arguing that it's indication of memory corruption". I mean what application is actually supposed to do? You kind of say "yeah, you know, this structure is all screwed up, but h... |
@@ -339,7 +339,7 @@ public final class DecimalCasts
public static Slice smallintToLongDecimal(long value, long precision, long scale, BigInteger tenToScale)
{
try {
- Slice decimal = multiply(unscaledDecimal(value), unscaledDecimal(tenToScale));
+ Slice decimal = multiply(unscal... | [DecimalCasts->[realToLongDecimal->[realToLongDecimal],doubleToLongDecimal->[doubleToLongDecimal],shortDecimalToReal->[shortDecimalToReal],longDecimalToDouble->[longDecimalToDouble],longDecimalToReal->[longDecimalToReal],doubleToShortDecimal->[doubleToShortDecimal],realToShortDecimal->[realToShortDecimal]]] | SmallintToLongDecimal - casts a SMALLINT to DECIMAL. | unscaledDecimal and others - method names should start with imperative |
@@ -238,12 +238,9 @@ int run_test(int argc, ACE_TCHAR *argv[], Args& my_args)
int ACE_TMAIN(int argc, ACE_TCHAR *argv[])
{
Args my_args;
-
- int result = run_test(argc, argv, my_args);
- if (result == my_args.expected_result_) {
- return 0;
- } else {
+ if (run_test(argc, argv, my_args) != my_args.expected_... | [No CFG could be retrieved] | Main entry point for ACE_T. | I think I originally expected to have the Perl script be more aware of the returned error codes for determining where the errors occurred (compiling lists of error locations for multiple scenarios), but after adding the "expected value" stuff in order to check for expected / required failures, it became moot since the ... |
@@ -63,8 +63,13 @@ if ($user && ($group instanceof ElggGroup)) {
$url,
), $owner->language);
+ $params = [
+ 'action' => 'membership_request',
+ 'object' => $group,
+ ];
+
// Notify group owner
- if (notify_user($owner->guid, $user->getGUID(), $subject, $body)) {
+ if (notify_user($owner->guid, $u... | [getURL,getOwnerEntity,getGUID,isPublicMembership,canEdit] | Request a group node. | Need to add $params here |
@@ -147,14 +147,15 @@ namespace Revit.Elements
}
// transform geometry from dynamo unit system (m) to revit (ft)
- geometry = geometry.InHostUnits();
+ var newGeometry = geometry.InHostUnits();
var translation = Vector.ByCoordinates(0, 0, 0);
- ... | [ImportInstance->[InternalSetImportInstance->[InternalUniqueId,UniqueId,InternalElementId,Id,InternalImportInstance],InternalUnpinAndTranslateImportInstance->[IsZeroLength,EnsureInTransaction,Pinned,MoveElement,Id,TransactionTaskDone],Robustify->[AsVector,Reverse,Dispose,Translate,Solid,ByGeometry,Length],GetElement,Pa... | Import a object from a Dynamo unit system to a SAT file. | You may consider about unify these two functions. |
@@ -625,7 +625,6 @@ func CopyTestToTemporaryDirectory(t *testing.T, opts *ProgramTestOptions) (dir s
pioutil.MustFprintf(opts.Stdout, "pulumi: %v\n", opts.Bin)
pioutil.MustFprintf(opts.Stdout, "yarn: %v\n", opts.YarnBin)
- // Copy the source project
stackName := string(opts.GetStackName())
targetDir, err := i... | [Write->[Write],PulumiCmd,GetStackName,GetDebugUpdates] | testUpdates tests if the update is successful. performExtraRuntimeValidation is a function that performs extra runtime validation on the given object. | I believe the line above should be `sourceDir` instead of `dir` as well? (named ret vals are causing confusion here - are they needed?) |
@@ -248,8 +248,16 @@ public class OpenWireConnection extends AbstractRemotingConnection implements Se
//tells the connection that
//some bytes just sent
- public void bufferSent() {
- lastSent = System.currentTimeMillis();
+ private void bufferSent() {
+ //much cheaper than a volatile set if con... | [OpenWireConnection->[checkDataReceived->[checkDataReceived],isSuppressInternalManagementObjects->[isSuppressInternalManagementObjects],physicalSend->[bufferSent],setUpTtl->[checkInactivity],tempQueueDeleted->[getContext],createInternalSession->[getPassword],lookupTX->[lookupTX],CommandProcessor->[processAddConsumer->[... | Called when a buffer is received from the server. | dedicated log message method, please add to the logger. |
@@ -240,6 +240,10 @@ export class ImageViewer {
// Set src provisionally to the known loaded value for fast display.
// It will be updated later.
this.image_.setAttribute('src', sourceImage.src);
+ } else {
+ // Most browsers show a gray border for images with alt but no src
+ // If we... | [No CFG could be retrieved] | Initializes the image viewer and image sizes and positioning. This is a hack to reduce the small expansions that often look like a stutter. | How does it get set initially? Is it only through `updateSrc_`? |
@@ -19,6 +19,6 @@ public interface ConsumerType {
/**
* @return {@code true} if this a consumer for {@link Topic}s
*/
- boolean isTopic();
+ boolean topic();
}
| [No CFG could be retrieved] | Returns true if the current node is a topic. | this solves the "consumer shows isTopic" bug |
@@ -0,0 +1,12 @@
+<?php
+
+if ($device['os'] == 'xos') {
+ echo 'EXTREME-SOFTWARE-MONITOR-MIB';
+
+ $total = str_replace('"', "", snmp_get($device, "1.3.6.1.4.1.1916.1.32.2.2.1.2.1", '-OvQ'));
+ $avail = str_replace('"', "", snmp_get($device, "1.3.6.1.4.1.1916.1.32.2.2.1.3.1", '-OvQ'));
+
+ if ((is_numeric(... | [No CFG could be retrieved] | No Summary Found. | I've not looked at the mempool code much but where is $total and $avail used? |
@@ -195,14 +195,14 @@ public abstract class RetryOnFailureOperation<T> extends HotRodOperation<T> impl
}
protected void logAndRetryOrFail(Throwable e, boolean canSwitchCluster) {
- if (retryCount < channelFactory.getMaxRetries() && channelFactory.getMaxRetries() >= 0) {
+ if (retryCount < channelFac... | [RetryOnFailureOperation->[channelInactive->[updateFailedServers],reset->[cancel],handleException->[updateFailedServers],fetchChannelAndInvoke->[fetchChannelAndInvoke],logAndRetryOrFail->[reset,retryIfNotDone]]] | Log an exception and retry if necessary. | I assume this is removed as it isn't required since retryCount starts at 0 and therefore the extra check is redundant or is there something else? |
@@ -183,3 +183,5 @@ if (shouldMainBootstrapRun) {
internalRuntimeVersion()
);
}
+
+console./*OK*/ log('trigger bundle size');
| [No CFG could be retrieved] | Get the internal runtime version. | Assuming this is unintentional? |
@@ -8,6 +8,9 @@ from allennlp.data.tokenizers.token import Token
from allennlp.data.token_indexers.token_indexer import TokenIndexer, IndexedTokenList
+_DEFAULT_VALUE = "THIS IS A REALLY UNLIKELY VALUE THAT HAS TO BE A STRING"
+
+
@TokenIndexer.register("single_id")
class SingleIdTokenIndexer(TokenIndexer):
... | [SingleIdTokenIndexer->[count_vocab_items->[getattr,lower],__init__->[super,Token],tokens_to_indices->[get_token_index,append,getattr,chain,lower]],register] | Initialize a single - id token object. Count the number of items in the vocabulary for a given token. | The way `_DEFAULT_VALUE` is used now, it could just be `None`, with no surprising strings like this one. |
@@ -57,8 +57,13 @@ def get_supported(versions=None, noarch=False):
impl = get_abbr_impl()
abis = []
+
+ try:
+ soabi = sysconfig.get_config_var('SOABI')
+ except IOError as e: # Issue #1074
+ warnings.warn("{0}".format(e.message), RuntimeWarning)
+ soabi = None
- soabi = ... | [get_platform->[get_platform],get_supported->[get_platform,get_abbr_impl],get_supported] | Returns a list of supported tags for each version specified in versions. Returns a list of supported version of the current Python interpreter. | e.message was deprecated in py2.6. fails in py3. see the failing travis builds exceptions auto-convert to strings when substituted or use `repr()` explicitly |
@@ -64,3 +64,18 @@ class TestListCommand(TestCase):
context.prompt.render_title.assert_called_once_with(ListCommand.TITLE)
context.server.content_source.get_all.assert_called_once_with()
context.prompt.render_document_list.assert_called_once_with(response.response_body)
+
+
+class TestCatalog... | [TestMainSection->[test_init->[MainSection,Mock,assert_called_once_with],patch],TestSourcesSection->[test_init->[assert_called_once_with,Mock,SourcesSection],patch],TestInitialization->[test_init->[assert_called_once_with,Mock,initialize],patch],TestListCommand->[test_run->[ListCommand,assert_called_once_with,_run,Mock... | Test run of the get_all command. | Were you trying to assert something with the mock response? I don't see it used |
@@ -96,7 +96,8 @@ class TestOneHotOp_exception(OpTest):
block.append_op(
type='one_hot',
inputs={'X': x},
- attrs={'depth': self.depth},
+ attrs={},
+ inputs_or_attr={'depth': self.depth},
outputs={'Out': one_ho... | [TestOneHotOp_exception->[test_check_output->[run->[run]]]] | Checks that the output of the n - hot filter is met. | What's the meaning of `inputs_or_attr `? |
@@ -92,13 +92,12 @@ public class UserScoreTest implements Serializable {
/** Test the {@link ParseEventFn} {@link org.apache.beam.sdk.transforms.DoFn}. */
@Test
public void testParseEventFn() throws Exception {
- DoFnTester<String, GameActionInfo> parseEventFn = DoFnTester.of(new ParseEventFn());
+ PColl... | [UserScoreTest->[testUserScoresBadInput->[via,getUser,of,apply,getScore,empty,waitUntilFinish,withCoder],testTeamScoreSums->[of,ExtractAndSumScore,apply,waitUntilFinish,withCoder,containsInAnyOrder],testUserScoreSums->[of,ExtractAndSumScore,apply,waitUntilFinish,withCoder,containsInAnyOrder],testParseEventFn->[getUser,... | Test parse event function. | I'd add `@Category(ValidatesRunner.class)` here |
@@ -35,7 +35,7 @@ class Fmt(CMakePackage):
values=('98', '11', '14', '17'),
multi=False,
description='Use the specified C++ standard when building')
- variant('pic', default=True, description='Enable generation of position-independent code')
+ variant('shared', default=False... | [Fmt->[cmake_args->[append,format,extend],depends_on,conflicts,version,patch,variant]] | Return a list of version numbers. Create a list of variants for a single sequence number. Deprecated. Use with caution!. | Most packages seem to default to `True`, which makes sense in my opinion. Any reason we want to disable shared libraries by default? |
@@ -267,7 +267,7 @@ func (p *Provider) loadConfigurationFromIngresses(ctx context.Context, client Cl
conf.HTTP.Services[serviceName] = service
conf.HTTP.Services[serviceName] = service
- routerKey := strings.TrimPrefix(provider.Normalize(rule.Host+pa.Path), "-")
+ routerKey := strings.TrimPrefix(provi... | [newK8sClient->[FromContext,Infof,Sprintf,Parse,Errorf,Getenv],loadConfigurationFromIngresses->[Str,FromContext,Normalize,Error,GetIngresses,updateIngressStatus,TrimPrefix,String,Errorf,With,WithField],updateIngressStatus->[GetService,New,Errorf,UpdateIngressStatus,Split,Debugf],Provide->[Hash,Duration,WatchAll,newK8sC... | loadConfigurationFromIngresses loads the configuration from the given client. This function is used to create a new rule in the ingress status. It is used to loadRouter loads the router configuration and creates the routerKey in the HTTP. | Usually the order is name -> namespace for k8s things. Do you think we could use this here? |
@@ -856,6 +856,16 @@ public class QueryStateMachine
return canceled;
}
+ private boolean setQueryStateIf(QueryState newState, Predicate<QueryState> predicate)
+ {
+ return queryState.setIf(new QueryStateHolder(newState), oldState -> predicate.test(oldState.getState()));
+ }
+
+ privat... | [QueryStateMachine->[recordHeartbeat->[recordHeartbeat],beginAnalysis->[beginAnalysis],getExecutionStartTime->[getExecutionStartTime],addStateChangeListener->[addStateChangeListener],pruneQueryInfo->[getSetSessionProperties,getQueryStats,getDeallocatedPreparedStatements,getAddedPreparedStatements,isScheduled,getSession... | transitionToCanceled - transition to canceled. | rename `oldState` to `currentState` |
@@ -126,10 +126,10 @@ public class PutKudu extends AbstractProcessor {
.build();
protected static final PropertyDescriptor INSERT_OPERATION = new Builder()
- .name("Insert Operation")
+ .name("Kudu Operation Type")
.description("Specify operationType for this processor. Insert-Ign... | [PutKudu->[insertRecordToKudu->[getSchema,newInsert,buildPartialRow,getRow],createClient->[getLogger,getPrincipal,loginKerberosUser,buildClient,getKeytab,execute],onScheduled->[getValue,createClient,debug,asInteger,valueOf,asControllerService],onTrigger->[trigger,getLogger,get,isEmpty,execute],getSupportedPropertyDescr... | This service is used to provide a record reader for a kudu session. description The maximum number of FlowFiles to process in a single execution. | Changing the name will break existing processors. Instead add `.displayName("Kudu Operation Type")` to change the displayed name without changing the property name. |
@@ -8,12 +8,9 @@ internal static partial class Interop
{
internal static partial class Kernel32
{
-#if DLLIMPORTGENERATOR_ENABLED
- [GeneratedDllImport(Libraries.Kernel32, SetLastError = true)]
- internal static partial bool CloseHandle(IntPtr handle);
-#else
+#pragma warning disable DLLIMPORTG... | [Interop->[Kernel32->[CloseHandle->[Kernel32]]]] | Closes a previously generated handle. | Why it does not support QCalls? |
@@ -15,7 +15,7 @@ import test_kratos_parameters
import test_materials_input
import test_geometries
import test_linear_solvers
-import test_eigen_solvers
+import test_linear_solvers
import test_condition_number
import test_processes
import test_properties
| [AssembleTestSuites->[VariableRedistributionTest,addTest,TestLoader,addTests],AssembleTestSuites,runTests,GetDefaultOutput] | Imports the given unittest and imports the tests. Assemble the test suites for a given set of test cases. | this is not correct |
@@ -58,10 +58,12 @@ class IntervalTreeBasedGlobalIndexFileFilter implements IndexFileFilter {
}
@Override
- public Set<String> getMatchingFiles(String partitionPath, String recordKey) {
- Set<String> toReturn = new HashSet<>();
- toReturn.addAll(indexLookUpTree.getMatchingIndexFiles(recordKey));
- toR... | [IntervalTreeBasedGlobalIndexFileFilter->[getMatchingFiles->[addAll,getMatchingIndexFiles],forEach,getMaxRecordKey,KeyRangeLookupTree,KeyRangeNode,toList,insert,add,getFileId,collect,getMinRecordKey,shuffle,hasKeyRanges]] | This method returns a set of files that match the given record key. | can we try to use java8 collect() APIs to implement these. |
@@ -477,8 +477,12 @@ public abstract class AbstractBuild<P extends AbstractProject<P,R>,R extends Abs
return wsl.allocate(n.getWorkspaceFor((TopLevelItem)getProject()), getBuild());
}
- public Result run(BuildListener listener) throws Exception {
- Node node = getCurrentNode();... | [AbstractBuild->[_getUpstreamBuilds->[getUpstreamRelationship],getNextBuild->[getNextBuild],doStop->[doStop],addAction->[addAction],getEnvironment->[getWorkspace,getEnvironment],getDownstreamBuilds->[getDownstreamRelationship],getBuildVariableResolver->[getBuildVariables],AbstractBuildExecution->[performAllBuildStep->[... | This method is called to decide the workspace to use. Checks if a node has a node in the system and if so runs the task. | If we get here there is a logic error, I think, so a localized message is inappropriate; I would just go with an `IllegalStateException`. |
@@ -391,7 +391,7 @@ if ($resql)
// Delivery date
print '<td align="right">';
- print dol_print_date($db->jdate($objp->date_delivery), 'day');
+ print dol_print_date($db->jdate($objp->date_livraison), 'day');
print '</td>';
// Amount HT
| [fetch,fetch_object,jdate,getDocumentsLink,select_salesrepresentatives,getNomUrl,select_dolusers,initHooks,idate,load,plimit,executeHooks,LibStatut,escape,close,free,query,transnoentitiesnoconv,trans,num_rows,select_year] | Print a list of all possible objects. Print a table of all possible conditions for a customer. | Should be better to keep english name and correct other occurrence. And may be 'delivery_date' would be even better ;) |
@@ -324,10 +324,17 @@ function _connectionFailed({ dispatch, getState }, next, action) {
* @private
* @returns {Object} The value returned by {@code next(action)}.
*/
-function _conferenceSubjectChanged({ getState }, next, action) {
+function _conferenceSubjectChanged({ dispatch, getState }, next, action) {
... | [No CFG could be retrieved] | The action to not emit recoverable action caused by a nonrecoverable . This is the redux action that is invoked when a is being dispatched in the. | Your answer to my previous question may answer this as well, but why undefined if we check for subject previously? |
@@ -174,8 +174,15 @@ func DeserializeResource(res Resource) (*resource.State, error) {
return nil, err
}
+ // If this is an old checkpoint that still had defaults, merge the inputs into the defaults.
+ //
+ // NOTE: we will remove support for defaults entirely in the future. See #637.
+ if inputs != nil && defau... | [IsObject,NewNullProperty,ArrayValue,NewArchiveProperty,Mappable,Assertf,DeserializeAsset,ValueOf,PropertyKey,NewNumberProperty,NewAssetProperty,Serialize,DeserializeArchive,StableKeys,Assert,IsComputed,Failf,IsAsset,HasValue,AssetValue,NewStringProperty,NewBoolProperty,IsArchive,ObjectValue,ArchiveValue,IsArray,NewObj... | DeserializeResource deserializes a single object or a resource object into its usual form. case - > string - > array - > nil. | Really nice that you did this. Should we tag with a work item to remove this, say, in M11, when we're certain the coast is clear? Also maybe tag the now-deprecated `Defaults` field on checkpoint resources? |
@@ -1025,7 +1025,6 @@ func (ss *StateSync) SyncLoop(bc *core.BlockChain, worker *worker.Worker, isBeac
if err := ss.addConsensusLastMile(bc, consensus); err != nil {
utils.Logger().Error().Err(err).Msg("[SYNC] Add consensus last mile")
}
- consensus.SetMode(consensus.UpdateConsensusInformation())
}
ss.pu... | [GetBlocks->[GetBlocks],getMaxConsensusBlockFromParentHash->[ForEachPeer],CreateSyncConfig->[CloseConnections,AddPeer],AddPeer->[IsEqual],SyncLoop->[purgeAllBlocksFromCache,getMaxPeerHeight,purgeOldBlocksFromCache,RegisterNodeInfo,ProcessStateSync],AddNewBlock->[FindPeerByHash],ProcessStateSync->[generateStateSyncTaskQ... | SyncLoop is the main loop for the state sync addConsensusLastMile adds all blocks from the last mile to the chain. | double check that removing this unlocked update is ok. |
@@ -21,11 +21,14 @@ package io.druid.segment.indexing;
import com.fasterxml.jackson.annotation.JsonCreator;
import com.fasterxml.jackson.annotation.JsonProperty;
+import com.google.api.client.util.Sets;
import io.druid.data.input.impl.InputRowParser;
import io.druid.query.aggregation.AggregatorFactory;
import io... | [DataSchema->[withGranularitySpec->[DataSchema],UniformGranularitySpec]] | Creates a DataSchema object that represents a single in a column store. The data source and parser are not serializable. | don't we generally use `com.google.common.collect.Sets`? |
@@ -162,10 +162,11 @@ public class NiFiReceiver extends Receiver<NiFiDataPacket> {
}
final List<NiFiDataPacket> dataPackets = new ArrayList<>();
+ InputStream inStream =null;
do {
// Read the... | [NiFiReceiver->[onStart->[Thread,start,ReceiveRunnable,setDaemon,setName],ReceiveRunnable->[run->[isStopped,reportError,createTransaction,build,sleep,confirm,getData,add,fillBuffer,receive,complete,store,iterator,close,getAttributes,StandardNiFiDataPacket,restart,getSize]]]] | This method is run in a loop until the server is stopped. | While generally it is indeed necessary to close the resources to avoid unnecessary memory leaks, this is not the right place to do that since NiFiReceiver is not the creator/owner of the stream and if another handle exist for such stream it could lead to unexpected results. We should probably investigate where this str... |
@@ -24,7 +24,7 @@ import static org.junit.Assert.assertFalse;
import static org.junit.Assert.assertTrue;
import static org.junit.Assert.fail;
-@Test(groups = "functional", testName = "query.remote.ProtobufMetadataManagerInterceptorTest")
+@Test(groups = "functional", testName = "query.remote.impl.ProtobufMetadataMa... | [ProtobufMetadataManagerInterceptorTest->[testValidateReplace->[assertTrue,size,getCause,get,replace,contains,isEmpty,assertNoTransactionsAndLocks,assertEquals,put,fail,cache],createCacheManagers->[makeCfg,addClusterEnabledCacheManager,waitForClusterToForm],testStatusAfterPut->[assertTrue,assertFalse,get,containsKey,is... | create cluster - enabled cache managers. | TestNG test names don't need to match the package name exactly, I'd rather leave out the `impl` part. |
@@ -0,0 +1,18 @@
+from conans.errors import InvalidConanSettingField
+
+
+def preprocess(settings, output):
+ fill_runtime(settings, output)
+
+
+def fill_runtime(settings, output):
+ try:
+ if settings.compiler == "Visual Studio":
+ if settings.get_safe("compiler.runtime") is None:
+ ... | [No CFG could be retrieved] | No Summary Found. | The usage of this Exception type seems a bit weak to me. I would have used just safe checks of settings, no Exception capture: Just an opinion, not really sure about best approach. |
@@ -32,12 +32,13 @@ const TIMEOUT_VALUE = 10000;
export class AmpAdApiHandler {
/**
- * @param {!AMP.BaseElement} baseInstance
+ * @param {!./amp-ad-3p-impl.AmpAd3PImpl|../../amp-a4a/0.1/amp-a4a.AmpA4A} baseInstance
* @param {!Element} element
* @param {function()=} opt_noContentCallback
*/
con... | [No CFG could be retrieved] | Creates an AMP ad API handler for a specific base element. Private functions to register and unregister listeners for a given node. | The duplicated type hint here shouldn't be necessary. |
@@ -59,6 +59,16 @@ dfuse_reply_entry(struct dfuse_projection_info *fs_handle,
&ie->ie_htl);
if (rlink != &ie->ie_htl) {
+ dfs_obj_t *obj;
+ struct dfuse_inode_entry *existing;
+
+ existing = container_of(rlink, struct dfuse_inode_entry,
+ ie_htl);
+
+ obj = ie->ie_obj;
+ ie->ie_obj = ex... | [dfuse_reply_entry->[D_GOTO,atomic_fetch_sub,DFUSE_REPLY_ERR_RAW,DFUSE_REPLY_ENTRY,DFUSE_TRA_INFO,dfs_obj2id,d_hash_rec_find_insert,D_ASSERT,dfs_release,DFUSE_REPLY_CREATE,dfuse_lookup_inode,ie_close],dfuse_cb_lookup->[D_GOTO,dfs_ostat,DFUSE_REPLY_ERR_RAW,D_FREE,strerror,dfuse_reply_entry,DFUSE_TRA_INFO,dfs_lookup_rel,... | dfuse_reply_entry - reply entry Create a new object in the tree. | (style) code indent should use tabs where possible |
@@ -208,7 +208,7 @@ void ossl_provider_free(OSSL_PROVIDER *prov)
int ref = 0;
#ifndef HAVE_ATOMICS
- CRYPTO_DOWN_REF(&prov->refcnt, &ref, provider_lock);
+ CRYPTO_DOWN_REF(&prov->refcnt, &ref, prov->refcnt_lock);
#else
CRYPTO_DOWN_REF(&prov->refcnt, &ref, NULL);
#endif
| [No CFG could be retrieved] | Returns the provider store object for the given name. Initialize a new provider. | refcnt_lock appears to be NULL? |
@@ -51,12 +51,12 @@ public class DataSourceRuntimeConfig {
* of the connections on boot, while being able to sustain a minimal pool size after boot.
*/
@ConfigItem
- public Optional<Integer> initialSize;
+ public OptionalInt initialSize;
/**
* The datasource pool minimum size
*... | [No CFG could be retrieved] | A list of all configuration options for a single connection. Missing parameters for remove idle connections. | I don't like that change. It's not that obvious IMHO. |
@@ -130,6 +130,7 @@ func (r *retryer) loop() {
for {
select {
case <-r.done:
+
return
case evt := <-r.in:
| [loop->[Drop,eventsRetry,eventsDropped,eventsFailed,sigWait,Info,sigUnWait],loop,Guaranteed] | loop is the main loop of the retryer. It is the main loop that handles the send unwait - signal to consumer. | let's remove this newline again ;) |
@@ -48,6 +48,7 @@ func TestAccBigQueryTable_Basic(t *testing.T) {
func TestAccBigQueryTable_View(t *testing.T) {
t.Parallel()
+ resourceName := "google_bigquery_table.test"
datasetID := fmt.Sprintf("tf_test_%s", acctest.RandString(10))
tableID := fmt.Sprintf("tf_test_%s", acctest.RandString(10))
| [Meta,Test,Get,Sprintf,Do,RootModule,ComposeTestCheckFunc,Parallel,Errorf,RandString,HasSuffix] | TestAccBigQueryTable_Basic tests that the table exists and has the correct number of Parallel test for the . | nit: We can probably just hard code this? |
@@ -1252,6 +1252,11 @@ public class PubsubUnboundedSource<T> extends PTransform<PBegin, PCollection<T>>
@Nullable
public TopicPath getTopic() {
+ return topic.get();
+ }
+
+ @Nullable
+ public ValueProvider<TopicPath> getTopicProvider() {
return topic;
}
| [PubsubUnboundedSource->[PubsubReader->[pull->[pull,InFlightState,now],retire->[now],stats->[now],getWatermark->[now],extend->[InFlightState,extendBatch,now],close->[close],advance->[pull,retire,stats,now,extend],newFun],StatsFn->[populateDisplayData->[populateDisplayData]],PubsubSource->[createReader->[nackAll]],Pubsu... | Gets the topic and subscription. | Something seems off here. I know that `topic.get()` cannot return a `null` value. But `topic` is `@Nullable`, so maybe that is where the `null` should come from? |
@@ -494,7 +494,7 @@ class CheckpointManager(object):
"""
def __init__(self, checkpoint, directory,
- max_to_keep, keep_checkpoint_every_n_hours=None):
+ max_to_keep, keep_checkpoint_every_n_hours=None, checkpoint_name="ckpt"):
"""Configure a `CheckpointManager` for use in `direc... | [get_checkpoint_state->[_GetCheckpointFilename],CheckpointManager->[save->[_sweep,_record_state],_sweep->[_delete_file_if_exists],_record_state->[update_checkpoint_state_internal],__init__->[get_checkpoint_state]],get_checkpoint_mtimes->[match_maybe_append,_prefix_to_checkpoint_path],update_checkpoint_state_internal->[... | Initialize a checkpoint manager. This method is called by checkpoint_manager to determine the checkpoint timestamp and path of the last Check if there are any missing missing files. | Nit: could you wrap the line to 80 characters? |
@@ -1,4 +1,7 @@
# Be sure to restart your server when you modify this file.
# Configure sensitive parameters which will be filtered from the log file.
-Rails.application.config.filter_parameters += [:password]
+Rails.application.config.filter_parameters += [
+ :password, :security_answers_attributes, :mobile, :sec... | [filter_parameters] | Configure sensitive parameters that will be filtered from the log file. | Please add `:code` here to filter the OTP code. |
@@ -33,6 +33,18 @@ namespace Content.Shared.Buckle
}
}
+ private void HandleMove(EntityUid uid, SharedBuckleComponent component, MovementAttemptEvent args)
+ {
+ if (!component.Buckled) return;
+ args.Cancel();
+ }
+
+ private void HandleChangeDi... | [SharedBuckleSystem->[HandleDown->[Cancel,Buckled],Initialize->[Initialize],HandleStand->[Cancel,Buckled],PreventCollision->[IsOnStrapEntityThisFrame,LastEntityBuckledTo,DontCollide,Cancel,Buckled,Uid],HandleThrowPushback->[Cancel,Buckled]]] | HandleDown - handle down - attempt event. | Would be better to probably have a separate "Buckled" component and then use the directed event for it, that way this stuff isn't being called for every single movement / rotation. Downside is that RemoveComponent is currently bugged via networking so would need to check if it has a client version that runs too. |
@@ -86,6 +86,7 @@ def fc(input,
param_attr=None,
bias_attr=None,
use_mkldnn=False,
+ with_bias=False,
act=None,
name=None):
"""
| [conv2d->[_get_default_param_initializer],sequence_first_step->[sequence_pool],matmul->[__check_input],sequence_last_step->[sequence_pool],lstm_unit->[fc]] | A full connected layer which is a partial connected layer with multiple inputs. Adds a n - dimensional tensor to the network. Adds a non - zero weight on the network to the network. | You can use `bias_attr` instead of `with_bias`. i.e. `bias_attr=False` |
@@ -556,7 +556,8 @@ public class InvokeHTTP extends AbstractProcessor {
REL_SUCCESS_REQ, REL_RESPONSE, REL_RETRY, REL_NO_RETRY, REL_FAILURE)));
// RFC 2616 Date Time Formatter with hard-coded GMT Zone
- private static final DateTimeFormatter RFC_2616_DATE_TIME = DateTimeFormatter.ofPattern("EEE, ... | [InvokeHTTP->[convertAttributesFromHeaders->[headers,handshake,getName,peerPrincipal,put,join,isEmpty,forEach,values],onTrigger->[getValue,fetch,create,getMessage,size,equals,configureRequest,logResponse,getBuffer,nanoTime,toString,remove,URL,put,yield,getCharsetFromMediaType,body,message,putAllAttributes,code,isSucces... | This method is used to build a list of all possible properties that can be routed on The name of the error. | There was a unit test that verified a generated date (locale-specific) against the RFC 2616 pattern. In FR locale, the pattern did not match, so the test failed. I interpret the rfc to require the unlocalized version of the formatted date, thus this change. |
@@ -101,7 +101,7 @@ export class AmpStoryQuiz extends AMP.BaseElement {
/** @override */
isLayoutSupported(layout) {
// TODO(jackbsteinberg): This selection is temporary and may need to be revisited later
- return layout === 'flex-item';
+ return layout === 'flex-item' || layout === 'container';
}
... | [No CFG could be retrieved] | Construct a new object. Creates a hidden input element that displays the number of options that can be selected. | Should it always be `container`? |
@@ -215,6 +215,13 @@ public class KsqlConfig extends AbstractConfig {
public static final String KSQL_QUERY_PULL_MAX_QPS_DOC = "The maximum qps allowed for pull "
+ "queries. Once the limit is hit, queries will fail immediately";
+ public static final String KSQL_QUERY_PULL_SET_REPLYING_HOST_CONFIG =
+ ... | [KsqlConfig->[buildConfigDef->[defineLegacy,defineCurrent],ConfigValue->[isResolved->[isResolved]],getKsqlStreamConfigProps->[getKsqlStreamConfigProps],buildStreamingConfig->[applyStreamsConfig],getAllConfigPropsWithSecretsObfuscated->[getKsqlConfigPropsWithSecretsObfuscated],overrideBreakingConfigsWithOriginalValues->... | This class defines the configuration for the pull query. region KSQL Authorization Cache. | I feel like it would be better to add a keyword to the query itself, like `DEBUG` instead of using a server config. This way, we have a control know per pull query and we can add more debug information in the future, like amount of lag, or routing information, etc. |
@@ -7,7 +7,7 @@ def require_theme(theme_name)
theme_lib = Rails.root.join 'lib', 'themes', theme_name, 'lib'
$LOAD_PATH.unshift theme_lib.to_s
theme_main_include = Rails.root.join theme_lib, "alavetelitheme.rb"
- if File.exists? theme_main_include
+ if File.exist? theme_main_include
require theme_main_i... | [require_theme->[to_s,exists?,unshift,join,require],theme_url_to_theme_name,env,require_theme,reverse] | Require a theme. | Use a guard clause instead of wrapping the code inside a conditional expression.<br>Favor modifier if usage when having a single-line body. Another good alternative is the usage of control flow &&/||. |
@@ -78,6 +78,7 @@ public abstract class QueryBasedSource<S, D> extends AbstractSource<S, D> {
public static final boolean DEFAULT_SOURCE_OBTAIN_TABLE_PROPS_FROM_CONFIG_STORE = false;
private static final String QUERY_BASED_SOURCE = "query_based_source";
public static final String WORK_UNIT_STATE_VERSION_KEY = ... | [QueryBasedSource->[getSourceEntitiesHelper->[fromState,fromSourceEntityName],getPreviousWatermarksForAllTables->[fromState],SourceEntity->[hashCode->[hashCode,getDatasetName],fromState->[SourceEntity,sanitizeEntityName],fromSourceEntityName->[SourceEntity,sanitizeEntityName],equals->[getDatasetName,equals]],getTableSp... | A base implementation of a query - based source. Missing - Name for SourceEntity. | How about "source.querybased.workUnitState.isLastWorkUnit" and IS_LAST_WORK_UNIT_KEY? |
@@ -315,6 +315,10 @@ public abstract class AbstractTestRestApi {
}
protected static void shutDown() throws Exception {
+ shutDown(true);
+ }
+
+ protected static void shutDown(final boolean deleteConfDir) throws Exception {
if (!wasRunning) {
// restart interpreter to stop all interpreter proce... | [AbstractTestRestApi->[startUp->[start],isNotAllowed->[responsesWith],isCreated->[responsesWith],getSparkHomeRecursively->[getSparkHomeRecursively],isNotFound->[responsesWith],httpDelete->[httpDelete],startUpWithAuthenticationEnable->[start],httpPut->[httpPut],isForbidden->[responsesWith],isBadRequest->[responsesWith],... | Shuts down the server. | What's the purpose for this change ? whether delete conf is controlled by `ZeppelinConfiguration`, it seems not necessary to be called by user explicitly. |
@@ -141,7 +141,7 @@ public interface AgentManager {
public void pullAgentOutMaintenance(long hostId);
- boolean reconnect(long hostId);
+ void reconnect(long hostId) throws CloudRuntimeException, AgentUnavailableException;
void rescan();
| [No CFG could be retrieved] | Called when a host is going to be removed from the agent s maintenance list. | the `CloudRuntimeException` is a `RuntimeException` you do not need to declare it in the method signature. |
@@ -1133,7 +1133,10 @@ class TreeSearch(object):
# check new hypos for eos label, if we have some, add to finished
for hypid in range(self.beam_size):
if self.outputs[-1][hypid] == self.eos:
- if self.scores[hypid] == neginf(self.scores.dtype):
+ if (
+ ... | [TorchGeneratorAgent->[_compute_nltk_bleu->[_v2t],_init_cuda_buffer->[_dummy_batch],compute_loss->[_model_input],_encoder_input->[_model_input],eval_step->[_compute_fairseq_bleu,_construct_token_losses,decode_forced,_compute_nltk_bleu,reorder_encoder_states,_encoder_input,compute_loss,_v2t],train_step->[_init_cuda_buff... | Advance the beam one step. Missing tokens in the beam. | Let me know if this breaks any assumptions. But it seems like neither a (output, score) progression of `[(ok, -4.3906), (eos, -1.9766), (eos, -65504.0]` nor `[(ok, -4.3906), (eos, -1.9766), (eos, -inf)]` should be added to the stack of finished hypotheses. |
@@ -125,7 +125,7 @@ function registerPlugin( store ) {
</Slot>
</PluginSidebar>
<Provider store={ store } >
- <Sidebar />
+ <Sidebar store={ store } />
</Provider>
{ renderMetaboxPortal() }
</Fragment>
| [No CFG could be retrieved] | Renders the metabox portal. Wraps a component in the required top level components. | Is it okay for the Sidebar to be aware of the store? |
@@ -18,12 +18,12 @@
package org.apache.beam.sdk.io.gcp.spanner;
import com.google.auto.value.AutoValue;
-import com.google.cloud.spanner.BatchReadOnlyTransaction;
-import com.google.cloud.spanner.Partition;
-import com.google.cloud.spanner.ResultSet;
-import com.google.cloud.spanner.Struct;
-import com.google.cloud... | [BatchSpannerRead->[expand->[getTimestampBound,getTxView],ReadFromPartitionFn->[processElement->[execute]]]] | Imports a single object. Read from multiple partitions in a batch. | Could you run ./gradlew spotlessApply ? I think the preferred style is to avoid wildcard imports |
@@ -97,7 +97,7 @@ abstract class Abstract_Jetpack_Site extends SAL_Site {
}
function is_vip() {
- return false; // this may change for VIP Go sites, which sync using Jetpack
+ return defined( 'WPCOM_IS_VIP_ENV' ) ? (bool) WPCOM_IS_VIP_ENV : false;
}
function featured_images_enabled() {
| [Abstract_Jetpack_Site->[wp_max_memory_limit->[get_constant],after_render_options->[wp_version,wp_max_memory_limit,main_network_site,is_main_network,max_upload_size,file_system_write_access,is_version_controlled,get_constant,wp_memory_limit,get_jetpack_version],after_render->[get_updates],featured_images_enabled->[curr... | Checks if the current theme supports VIP Go. | Can this just be `return defined( 'WPCOM_IS_VIP_ENV' ) && true === WPCOM_IS_VIP_ENV;`? We tend to make these kinds of checks explicit to a `true` value, and `false` for anything else. |
@@ -42,15 +42,13 @@ func TestSleeperTask_WakeupAfterStopPanics(t *testing.T) {
gomega.NewGomegaWithT(t).Eventually(worker.getNumJobsPerformed).Should(gomega.Equal(0))
}
-func TestSleeperTask_CallingStopTwicePanics(t *testing.T) {
+func TestSleeperTask_CallingStopTwiceFails(t *testing.T) {
t.Parallel()
worker... | [Work->[AddInt32,Sleep,Work],getNumJobsPerformed->[LoadInt32],Stop,Should,Equal,Panics,BeNumerically,NewGomegaWithT,Consistently,Parallel,NoError,Eventually,WakeUp,NewSleeperTask,getNumJobsPerformed] | sync. atomic TestSleeperTask_WakeupEnqueuesMaxTwice is a test function. | The panic is now an error, is that fine? |
@@ -733,6 +733,8 @@ define([
this.replacementNode = undefined;
this.lastStyleTime = 0;
+ this.clippingPlanesDirty = this._clippingPlanesState === 0;
+ this._clippingPlanesState = 0;
this._debugColorizeTiles = false;
| [No CFG could be retrieved] | Unloads the tile s content. Determines whitting layer on the tile. | We don't chain values like this, but since you're already setting `this._clippingPlanesState` on the next line, I assume this is a copy/paste error. |
@@ -3795,6 +3795,15 @@ namespace System
}
namespace System.Buffers
{
+ public abstract partial class ArrayPool<T>
+ {
+ protected ArrayPool() { }
+ public static System.Buffers.ArrayPool<T> Shared { get { throw null; } }
+ public static System.Buffers.ArrayPool<T> Create() { throw null; }
... | [No CFG could be retrieved] | A weak reference to an object. The MemoryManager class is used to manage memory in a system. | In case this is being moved over, I couldn't find deleted lines corresponding to the APIs for ArrayPool. |
@@ -73,7 +73,7 @@ namespace Dynamo.PythonMigration
private void DisplayIronPythonDialog()
{
// we only want to create the dialog ones for each graph per Dynamo session, if the global setting is not disabled
- if (DialogTracker.ContainsKey(CurrentWorkspace.Guid) || DynamoViewMod... | [PythonMigrationViewExtension->[OnNodeAdded->[LogIronPythonNotification],OnCurrentWorkspaceChanged->[DisplayIronPythonDialog,LogIronPythonNotification,IsIronPythonDialogOpen],UnsubscribeEvents->[UnSubscribeWorkspaceEvents],UnSubscribeWorkspaceEvents->[UnSubscribePythonNodeEvents]]] | Display the dialog if the DynamoWindow doesn t exist yet. | can you make these lines shorter. |
@@ -24,6 +24,9 @@ class Jetpack_Sync_Module_Comments extends Jetpack_Sync_Module {
add_action( 'untrash_post_comments', $callable );
add_action( 'comment_approved_to_unapproved', $callable );
add_action( 'comment_unapproved_to_approved', $callable );
+ add_action( 'jetpack_modified_comment_contents', $callabl... | [Jetpack_Sync_Module_Comments->[filter_meta->[is_whitelisted_comment_meta]]] | init listeners for all comments. | Lets remove this space. |
@@ -443,6 +443,14 @@ class UDPTransport(Runnable):
""" This method exists only for interface compatibility with MatrixTransport """
self.log.warning('UDP is unable to send global messages. Ignoring')
+ def enqueue_global_message( # pylint: disable=unused-argument
+ self,
+ ... | [UDPTransport->[receive_message->[maybe_send],get_queue_for->[init_queue_for],receive_ping->[maybe_send],stop->[stop],start->[start],start_health_check->[whitelist],init_queue_for->[get_health_events],send_async->[get_queue_for]]] | Send a message to a specific recipient if the transport is running. | IMO this should be a RuntimeError (or equivalent). |
@@ -206,6 +206,8 @@ const defaultToolbarButtons = {
},
'camera': {
id: 'toolbar_button_camera',
+ key: '',
+ tooltipPosition: 'bottom',
className: "button icon-camera",
shortcut: 'V',
shortcutAttr: 'toggleVideoPopover',
| [No CFG could be retrieved] | ToolBar buttons. Menu of buttons for the Share Screen Popover. | Main toolbar buttons are created dynamically, so we can safely add this to the _addMainToolbarButton function. In this same method we should also get rid of the popover attribute. |
@@ -249,8 +249,8 @@ export class AmpA4A extends AMP.BaseElement {
/** @private {?AMP.AmpAdXOriginIframeHandler} */
this.xOriginIframeHandler_ = null;
- /** @private {boolean} whether creative has been verified as AMP */
- this.isVerifiedAmpCreative_ = false;
+ /** @type {boolean} whether creative h... | [AmpA4A->[extractSize->[user,get,Number],tryExecuteRealTimeConfig_->[user,RealTimeConfigManager],constructor->[AmpAdUIHandler,AmpAdXOriginIframeHandler,dev,generateSentinel,getBinaryTypeNumericalCode,getBinaryType,now],tearDownSlot->[dev],renderViaNameAttrOfXOriginIframe_->[NAMEFRAME,utf8Decode,dev,checkStillCurrent,us... | Private methods for the keyset. Protected base class for all of the elements in a sequence of a single node. Private methods for the base class. | You only need to know if this is true so rather than allowing sub-classes to potentially modify, please make an accessor (isVerifiedCreative() { return this.isVerifiedCreative_; }) |
@@ -278,14 +278,15 @@ public class QuarkusJsonPlatformDescriptorResolver {
try {
log.debug("Attempting to resolve Quarkus JSON platform descriptor as %s", jsonArtifact);
return loadFromFile(artifactResolver.resolve(jsonArtifact));
- } catch (Throwable e) {
+ } catch (Exc... | [QuarkusJsonPlatformDescriptorResolver->[loadFromJsonArtifact->[loadFromFile,resolve],loadPlatformDescriptor->[getManagedDependencies->[resolve],process->[resolve],resolve],newInstance->[QuarkusJsonPlatformDescriptorResolver]]] | Load the Quarkus platform descriptor from the given JSON artifact. Resolve a Quarkus JSON platform descriptor loader from the classpath. Resolve the given artifact and return the dependency management of it. | > change use of Throwable to Exception as if Throwable happens we have worse problems. For the current state of the code, changing it to Exception is going to break it. IllegalStateException is currently thrown from every method. So until proper checked exceptions are in place, don't change this. |
@@ -538,8 +538,9 @@ func (s *StoresInfo) PauseLeaderTransfer(storeID uint64) error {
func (s *StoresInfo) ResumeLeaderTransfer(storeID uint64) {
store, ok := s.stores[storeID]
if !ok {
- log.Fatal("try to clean a store's pause state, but it is not found",
+ log.Warn("try to clean a store's pause state, but it is... | [GetUptime->[GetStartTime,GetLastHeartbeatTS],SetRegionCount->[Clone],GetAddress->[GetAddress],ResourceWeight->[GetRegionWeight,GetLeaderWeight],GetMetaStores->[GetMeta],GetLabelValue->[GetLabels],PauseLeaderTransfer->[Clone,AllowLeaderTransfer],IsUnhealthy->[DownTime],ResourceSize->[GetLeaderSize,GetRegionSize],NeedPe... | ResumeLeaderTransfer resumes a leader transfer of a store. | No longer need to output error message? |
@@ -609,6 +609,13 @@ func constructEnv(opts *PolicyAnalyzerOptions) ([]string, error) {
}
}
+ langSpecificVar := func(k string) string {
+ if runtime == "nodejs" {
+ return strings.Replace(k, "PULUMI_", "PULUMI_NODEJS_", 1)
+ }
+ return k
+ }
+
config, err := constructConfig(opts)
if err != nil {
ret... | [GetAnalyzerInfo->[label,GetAnalyzerInfo],GetPluginInfo->[label,GetPluginInfo],AnalyzeStack->[label,AnalyzeStack],Configure->[label,Configure],Close->[Close],Analyze->[label,Analyze]] | Construct the environment variables to be used as the environment variables for the policy pack process. configJSON returns a string with the config JSON encoded as a . | Possibly not now - but I wonder if we want to transition to using consistent names, and pass both to Node.js for now, and start reading from both in the Node.js implementation so that we can get to a consistent pattern here soon and not need Node specific code at this layer? |
@@ -351,7 +351,7 @@ const (
// NOTE: these values correspond to the maximum accepted values in
// chat/boxer.go. If these values are changed, they must also be accepted
// there.
-var MaxMessageBoxedVersion MessageBoxedVersion = MessageBoxedVersion_V3
+var MaxMessageBoxedVersion MessageBoxedVersion = MessageBoxedVer... | [Eq->[Eq,Bytes],Etime->[EphemeralMetadata],Summary->[GetMessageID,GetMessageType],Derivable->[Hash],IsValidFull->[IsValid],IsEphemeral->[EphemeralMetadata],Includes->[Eq],DbShortFormString->[DbShortForm],Contains->[Eq],IsEphemeralExpired->[IsNil,IsEphemeral,Etime,EphemeralMetadata],ToConversationID->[Hash],ExplodedBy->... | ParseableVersion checks if a MessageUnboxedError is able to be parsed by the remove this check once it has been live for a few cycles. | @joshblum I had to bump this to pass your new test `TestVersionError`. Does this look ok? |
@@ -49,7 +49,7 @@ def remove_voucher_usage_by_customer(voucher: "Voucher", customer_email: str) ->
def get_product_discount_on_sale(
- product: "Product", product_collections: Set[int], discount: DiscountInfo
+ product: "Product", product_collections: Set[int], discount: DiscountInfo, channel
):
"""Ret... | [calculate_discounted_price->[get_product_discounts],fetch_discounts->[_fetch_collections,_fetch_products,_fetch_categories],fetch_active_discounts->[fetch_discounts],get_product_discounts->[get_product_discount_on_sale]] | Return discount value if product is on sale or raise NotApplicable. | We should add typing. |
@@ -1240,17 +1240,7 @@ func (r *ConmonOCIRuntime) configureConmonEnv(ctr *Container, runtimeDir string)
env = append(env, fmt.Sprintf("HOME=%s", home))
}
- extraFiles := make([]*os.File, 0)
- if !r.sdNotify {
- if listenfds, ok := os.LookupEnv("LISTEN_FDS"); ok {
- env = append(env, fmt.Sprintf("LISTEN_FDS=%s... | [createOCIContainer->[getLogTag,DeleteContainer],StopContainer->[KillContainer],sharedConmonArgs->[Name]] | configureConmonEnv is a helper function that returns the environment variables and the files that should This function is called by the daemon to start the process. appends the necessary arguments to the command line to run the command. | What about this case? Your code looks unconditional - is it still possible to disable sdnotify? |
@@ -141,6 +141,7 @@ int startShell(osquery::Initializer& runner, int argc, char* argv[]) {
retcode = osquery::launchIntoShell(argc, argv);
// Finally shutdown.
runner.requestShutdown();
+ runner.waitForShutdown();
} else {
retcode = profile(argc, argv);
}
| [No CFG could be retrieved] | Starts the OS query runloop. OSQueryD service thread. | Any reason why we don't need to call `runner.requestShutdown()` on the `startDaemon()` version? |
@@ -44,8 +44,8 @@ def ExtractBitsFromFloat16(x):
def SlowAppendFloat16ArrayToTensorProto(tensor_proto, proto_values):
- tensor_proto.half_val.extend(
- [ExtractBitsFromFloat16(x) for x in proto_values])
+ tensor_proto.half_val.extend(np.asarray(proto_values, dtype=np.float16).view(np.uint16))
+
def _Me... | [constant_value_as_shape->[constant_value_as_shape,constant_value],make_tensor_proto->[_GetDenseDimensions,_AssertCompatible,_FlattenToStrings,GetNumpyAppendFn],_FlattenToStrings->[_FlattenToStrings],_FirstNotNone->[_Message],_FilterStr->[_FirstNotNone,_NotNone,_FilterStr],SlowAppendFloat16ArrayToTensorProto->[ExtractB... | Append float16 values to a tensor proto. | is there a unit test checking correctness of this code? |
@@ -205,6 +205,11 @@ class UserAgentPolicy(SansIOHTTPPolicy):
)
if application_id:
+ if application_id.length > self._MAX_APPLICATION_ID_LENGTH:
+ raise ValueError("'applicationId' length cannot be greater than " + self._MAX_APPLICATION_ID_LENGTH)
+ if ' ' in... | [HttpLoggingPolicy->[on_request->[_redact_query_param,_redact_header],on_response->[_redact_header]],ContentDecodePolicy->[deserialize_from_text->[_json_attemp],deserialize_from_http_generics->[deserialize_from_text],on_response->[deserialize_from_http_generics]]] | Initialize the object with a user agent. | If the app_id is too long, I prefer truncating the string rather than failing the app. Your opinions? @johanste @annatisch |
@@ -13,6 +13,7 @@
# It's strongly recommended that you check this file into your version control system.
ActiveRecord::Schema.define(version: 2019_11_06_102826) do
+
# These are extensions that must be enabled in order to support this database
enable_extension "plpgsql"
| [jsonb,bigint,decimal,text,string,add_foreign_key,datetime,integer,enable_extension,create_table,float,boolean,index,define,inet] | This file is automatically generated from the current state of the database. Creates a table in the article table. | this change can be removed so that the file won't have a diff at all |
@@ -119,6 +119,7 @@ public class RunNiFi {
public static final String DUMP_CMD = "DUMP";
public static final String DIAGNOSTICS_CMD = "DIAGNOSTICS";
public static final String IS_LOADED_CMD = "IS_LOADED";
+ public static final String STATUS_HISTORY_CMD = "STATUS_HISTORY";
private static final i... | [RunNiFi->[loadProperties->[getStatusFile],getStatus->[isProcessRunning,loadProperties,isPingSuccessful],sendRequest->[loadProperties],main->[RunNiFi,printUsage],start->[getCurrentPort,getStatusFile,getLockFile,start,isAlive,savePidProperties,getHostname],env->[getStatus],status->[isProcessRunning,getStatus],savePidPro... | This class defines the properties of the nifi daemon. used for logging all the n - i - fi tasks. | Next time please squash commits before publishing. Thanks! |
@@ -151,10 +151,10 @@ class DistributeTranspiler:
Steps to transpile trainer:
1. split variable to multiple blocks, aligned by product(dim[1:]) (width).
2. rename splited grad variables to add trainer_id suffix ".trainer_%d".
- 3. modify trainer program add split_op to ... | [DistributeTranspiler->[_is_op_connected->[_append_inname_remove_beta],_append_pserver_ops->[_get_optimizer_input_shape,same_or_split_var,_orig_varname],get_startup_program->[_get_splited_name_and_shape->[same_or_split_var],_get_splited_name_and_shape],_create_ufind->[_is_op_connected,UnionFind,union],_orig_varname->[f... | Transpiles a single to distributed data - parallelism programs. Initialize the object with the n - node data. Add a n - ary param to the ep - layer. | Is our current implementation one `send_op` for each grad variable or one `send_op` for all grad variable? From my understanding this lines seems to mean one for each, but the implementation seem to be one for all. Maybe we need to have description matching the implementation? |
@@ -100,7 +100,7 @@ class CI_Zip {
function _get_mod_time($dir)
{
// filemtime() will return false, but it does raise an error.
- $date = (@filemtime($dir)) ? filemtime($dir) : getdate($this->now);
+ $date = (file_exists($dir) && @filemtime($dir)) ? filemtime($dir) : getdate($this->now);
$time['file_mtim... | [CI_Zip->[download->[get_zip],archive->[get_zip],read_file->[add_data],read_dir->[read_dir,add_data],add_data->[_get_mod_time]]] | Get mod time of file. | $date = (file_exists($dir) && filemtime($dir)) ? filemtime($dir) : getdate($this->now); I guess @philsturgeon mean that replace @filemtime with filemtime |
@@ -123,6 +123,13 @@ public class TerminalInterpreter extends KerberosInterpreter {
}
}
setParagraphConfig();
+ Properties properties = getProperties();
+ String strIpMapping = properties.getProperty("zeppelin.terminal.ip.mapping");
+ if (!StringUtils.isEmpty(strIpMapping)) {
+ Gson gson ... | [TerminalInterpreter->[close->[close],open->[open],internalInterpret->[setParagraphConfig]]] | This method is called when the interpreter is invoked. | gson could be a static variable so that we don't need to create it for each call. |
@@ -566,6 +566,7 @@ general_group = {
cache_dir,
no_cache,
disable_pip_version_check,
+ no_color
]
}
| [only_binary->[Option,set,FormatControl],_handle_only_binary->[getattr,fmt_ctl_handle_mutual_exclude],exists_action->[Option],trusted_host->[Option],extra_index_url->[Option],make_option_group->[add_option,option,OptionGroup],constraints->[Option],check_install_build_global->[getname->[getattr],any,fmt_ctl_no_binary,wa... | Create a list of object with name options for the given package. | same here, (just like you did not need to update `disable_pip_version_check,` line to add this one ) |
@@ -105,6 +105,17 @@ public class ProcessingStrategyDataConsumersTestCase extends AbstractMuleContext
when(identifier.getName()).thenReturn("test");
when(identifier.getNamespace()).thenReturn("test");
profilingService = getTestProfilingService();
+ enableProfilingFeatures();
+ }
+
+ private void ena... | [ProcessingStrategyDataConsumersTestCase->[eventType->[asList],jsonToLog->[getProcessingStrategyComponentInfoMap,toJson],before->[thenReturn,getTestProfilingService],TestProfilingDataConsumerDiscoveryStrategy->[discover->[TestLoggerComponentProcessingStrategyDataConsumer,of]],getTestProfilingService->[initialiseIfNeede... | This method is called before the test. | Add e as the cause |
@@ -223,6 +223,17 @@ public class GameMap extends GameDataComponent implements Iterable<Territory> {
return getNeighbors(frontier, searched, distance, null);
}
+ Set<Territory> getNeighborsValidatingCanals(final Territory territory, final Predicate<Territory> neighborFilter,
+ final Collection<Unit> uni... | [GameMap->[getDistance->[getDistance],getWaterDistance->[getDistance],getRoute_IgnoreEnd->[getRoute],getDistance_IgnoreEndForCondition->[getDistance],getNeighbors->[getNeighbors],getTerritoryFromCoordinates->[getTerritoryFromCoordinates],getRoute->[getRoute],getLandRoute->[getRoute],getLandDistance->[getDistance],getWa... | Returns the neighbors of the given set of territory that are in the frontier with a. | Parallel stream did seem to make some performance improvement here. This most likely should be used in a lot of other places especially in the AI but gotta start somewhere. |
@@ -1028,6 +1028,8 @@ public class ReplicationManager implements MetricsSource, SCMService {
LOG.info("Sending replicate container command for container {}" +
" to datanode {} from datanodes {}",
container.containerID(), datanode, sources);
+ metrics.incrNumReplicateCmdsSent();
+ metric... | [ReplicationManager->[getNodeStatus->[getNodeStatus],start->[start],isOpenContainerHealthy->[compareState],getContainerReplicaCount->[getInflightAdd,getInflightDel,getContainerReplicaCount],toString->[toString]]] | Sends a replication command to the given datanode and the given list of sources. | Suggest to move the metrics operation after the command is sent. |
@@ -324,8 +324,6 @@ class JarPublish(ScmPublishMixin, JarTask):
'where many artifacts must align.')
register('--transitive', default=True, type=bool,
help='Publish the specified targets and all their internal dependencies transitively.')
- register('--force', type=bool,
- ... | [target_internal_dependencies->[target_internal_dependencies],jar_coordinate->[coordinate],pushdb_coordinate->[version,jar_coordinate],JarPublish->[generate_ivy->[write],changelog->[changelog],check_targets->[check_for_duplicate_artifacts],exported_targets->[get_synthetic],check_for_duplicate_artifacts->[duplication_me... | Register options for the jar publish tool. A sequence of options that can be used to publish a single artifact. | Should probably deprecate instead of removing outright. |
@@ -406,7 +406,8 @@ class PantsDaemon(FingerprintedProcessManager):
"""Synchronously run pantsd."""
# Switch log output to the daemon's log stream from here forward.
self._close_stdio()
- with self._pantsd_logging() as (log_stream, log_filename):
+ with self._pantsd_logging() as (log_stream, log_fi... | [launch->[create],_LoggerStream->[fileno->[fileno]],PantsDaemon->[_close_stdio->[flush,fileno],launch->[Handle,maybe_launch],terminate->[terminate],watchman_launcher->[create],Factory->[create->[create,PantsDaemon],maybe_launch->[Handle]],run_sync->[_close_stdio,_setup_services,_write_named_sockets,_pantsd_logging,_run... | Synchronously run pantsd. | this was failing in pantsd integration tests if I remember correctly, could you modify travis.yml to kick off pantsd integration tests for this change? |
@@ -217,9 +217,9 @@ module.exports = function(grunt) {
},
- docs: {
- process: ['build/docs/*.html', 'build/docs/.htaccess']
- },
+ // docs: {
+ // process: ['build/docs/*.html', 'build/docs/.htaccess']
+ // },
"jasmine_node": {
projectRoot: 'docs/spec'
| [No CFG could be retrieved] | The main build function. Config for node - doc - spec. | is this still needed? |
@@ -175,7 +175,10 @@ namespace System.Security.Cryptography.X509Certificates.Tests
Assert.False(valid);
chainHolder.DisposeChainElements();
+ // Make sure AllowUnknownCertificateAuthority is set, as this test we verifies it does not get reset
chain.Cha... | [ChainTests->[Create->[Create],BuildChainInvalidValues->[Create]]] | Tests if the chain is built validly after reset. | Can you reword this? |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.