hash
stringlengths 40
40
| diff
stringlengths 172
2.63k
| message
stringlengths 12
593
| project
stringlengths 7
65
| split
stringclasses 1
value | diff_languages
stringclasses 54
values |
|---|---|---|---|---|---|
2e628b47e6d00ae31dfde05a8472f5f910ea48bb
|
diff --git a/packages/build/src/util.js b/packages/build/src/util.js
index <HASH>..<HASH> 100644
--- a/packages/build/src/util.js
+++ b/packages/build/src/util.js
@@ -194,14 +194,14 @@ const buildStaticSite = async (options, stats) => {
const serverStats = stats.stats.find(stats =>
stats.compilation.name.includes("Server")
);
- const serverFiles = serverStats.compilation.chunks
- .map(chunk => chunk.files)
- .reduce((all, next) => all.concat(next));
- serverFiles.forEach(fileName => {
- if (!fileName.startsWith(assetsPath)) {
- fs.unlinkSync(path.join(outputPath, fileName));
+
+ for (const chunk of serverStats.compilation.chunks) {
+ for (const fileName of chunk.files) {
+ if (!fileName.startsWith(assetsPath)) {
+ fs.unlinkSync(path.join(outputPath, fileName));
+ }
}
- });
+ }
}
};
|
fix(build): avoid using deprecated webpack apis
|
marko-js_cli
|
train
|
js
|
95cde238149afb6e18c23686210646a08ef0d2a1
|
diff --git a/wheelzoom.js b/wheelzoom.js
index <HASH>..<HASH> 100644
--- a/wheelzoom.js
+++ b/wheelzoom.js
@@ -1,11 +1,12 @@
/*!
- Wheelzoom 3.0.4
+ Wheelzoom 3.1.0
license: MIT
http://www.jacklmoore.com/wheelzoom
*/
window.wheelzoom = (function(){
var defaults = {
- zoom: 0.10
+ zoom: 0.10,
+ maxZoom: false,
};
var canvas = document.createElement('canvas');
@@ -91,6 +92,11 @@ window.wheelzoom = (function(){
bgHeight -= bgHeight*settings.zoom;
}
+ if (settings.maxZoom) {
+ bgWidth = Math.min(width*settings.maxZoom, bgWidth);
+ bgHeight = Math.min(height*settings.maxZoom, bgHeight);
+ }
+
// Take the percent offset and apply it to the new size:
bgPosX = offsetX - (bgWidth * bgRatioX);
bgPosY = offsetY - (bgHeight * bgRatioY);
|
feat: added option for maximum zoom level
|
jackmoore_wheelzoom
|
train
|
js
|
ce6d984aca1fa29f3be5fc169c7dba9182ba3202
|
diff --git a/lib/components/map/elevation-point-marker.js b/lib/components/map/elevation-point-marker.js
index <HASH>..<HASH> 100644
--- a/lib/components/map/elevation-point-marker.js
+++ b/lib/components/map/elevation-point-marker.js
@@ -1,14 +1,9 @@
import coreUtils from '@opentripplanner/core-utils'
import React, { Component } from 'react'
import { connect } from 'react-redux'
-
import { CircleMarker } from 'react-leaflet'
class ElevationPointMarker extends Component {
- createLeafletElement () {}
-
- updateLeafletElement () {}
-
render () {
const { diagramLeg, elevationPoint, showElevationProfile } = this.props
|
refactor(map): remove unneeded methods and import spacing
|
opentripplanner_otp-react-redux
|
train
|
js
|
612449b8cc75106475fd670cc17a18fff7006b06
|
diff --git a/src/navbar/navbar.js b/src/navbar/navbar.js
index <HASH>..<HASH> 100644
--- a/src/navbar/navbar.js
+++ b/src/navbar/navbar.js
@@ -9,7 +9,7 @@ import { AttributeManager } from '../common/attributeManager';
export class MdNavbar {
@bindable({
defaultBindingMode: bindingMode.oneTime
- }) fixed;
+ }) mdFixed;
fixedAttributeManager;
constructor(element) {
@@ -18,13 +18,13 @@ export class MdNavbar {
attached() {
this.fixedAttributeManager = new AttributeManager(this.fixedAnchor);
- if (getBooleanFromAttributeValue(this.fixed)) {
+ if (getBooleanFromAttributeValue(this.mdFixed)) {
this.fixedAttributeManager.addClasses('navbar-fixed');
}
}
detached() {
- if (getBooleanFromAttributeValue(this.fixed)) {
+ if (getBooleanFromAttributeValue(this.mdFixed)) {
this.fixedAttributeManager.removeClasses('navbar-fixed');
}
}
|
refactor(navbar): rename fixed attribute to md-fixed
|
aurelia-ui-toolkits_aurelia-materialize-bridge
|
train
|
js
|
8687c0cc66290fda8842f6b39f9aca32e29ca2fc
|
diff --git a/app/src/components/CalibrateTipLength/AskForCalibrationBlockModal.js b/app/src/components/CalibrateTipLength/AskForCalibrationBlockModal.js
index <HASH>..<HASH> 100644
--- a/app/src/components/CalibrateTipLength/AskForCalibrationBlockModal.js
+++ b/app/src/components/CalibrateTipLength/AskForCalibrationBlockModal.js
@@ -34,7 +34,7 @@ const USE_TRASH = 'Use trash bin for now'
const REMEMBER = "Remember my selection and don't ask again"
const CAN_CHANGE =
'(You can change this selection under More > Robots > Advanced Settings)'
-const SUPPORT_URL = 'https://www.opentrons.com/contact-support'
+const BLOCK_REQUEST_URL = 'https://opentrons-ux.typeform.com/to/DgvBE9Ir'
const CAL_BLOCK_LOAD_NAME = 'opentrons_calibrationblock_short_side_right'
const NOTE_SPACING = '1.75rem'
@@ -71,7 +71,7 @@ export function AskForCalibrationBlockModal(props: Props): React.Node {
<Text marginBottom={SPACING_3}>
{IF_NO_BLOCK}
- <Link href={SUPPORT_URL} external>
+ <Link href={BLOCK_REQUEST_URL} external>
{CONTACT_US}
</Link>
|
refactor(app): tip length cal: link to block request (#<I>)
We have a typeform to request a calibration block; link to it in the
block modal instead of the support site.
Closes #<I>
|
Opentrons_opentrons
|
train
|
js
|
5a04f38395ae36b1fd8140cc7af3df91107351e6
|
diff --git a/src/Resource/Transfers.php b/src/Resource/Transfers.php
index <HASH>..<HASH> 100644
--- a/src/Resource/Transfers.php
+++ b/src/Resource/Transfers.php
@@ -51,7 +51,7 @@ class Transfers extends MoipResource
}
/**
- * Initializes new transferInstrument instance if it doesn't exist
+ * Initializes new transferInstrument instance if it doesn't exist.
*/
private function intializeTransferInstrument()
{
|
style(Transfers): Fix StyleCI in intializeTransferInstrument comment
|
wirecardBrasil_moip-sdk-php
|
train
|
php
|
2f668841ad1c5347227c28f9eb2d96be3413ba07
|
diff --git a/src/Assert.php b/src/Assert.php
index <HASH>..<HASH> 100644
--- a/src/Assert.php
+++ b/src/Assert.php
@@ -85,7 +85,7 @@ trait Assert
$result = \JmesPath\Env::search($expression, $json);
\PHPUnit\Framework\Assert::assertEquals($expected, $result);
- \PHPUnit\Framework\Assert::assertInternalType(gettype($expected), $result);
+ \PHPUnit\Framework\Assert::assertInternalType(strtolower(gettype($expected)), $result);
}
/**
|
fix: assertInternalType invalid when $expected is NULL
|
estahn_phpunit-json-assertions
|
train
|
php
|
06e85f69a9cb2e6c22fdfc948f71e229b8019104
|
diff --git a/lib/config/index.js b/lib/config/index.js
index <HASH>..<HASH> 100644
--- a/lib/config/index.js
+++ b/lib/config/index.js
@@ -47,7 +47,7 @@ module.exports = class Config {
}
forBrowser(id) {
- return this.browsers[id];
+ return _.extend(this.browsers[id], {id});
}
getBrowserIds() {
diff --git a/test/lib/config/index.js b/test/lib/config/index.js
index <HASH>..<HASH> 100644
--- a/test/lib/config/index.js
+++ b/test/lib/config/index.js
@@ -83,7 +83,13 @@ describe('config', () => {
it('should get config for a browser', () => {
const config = initConfig({configParserReturns: {browsers: {bro: {some: 'option'}}}});
- assert.deepEqual(config.forBrowser('bro'), {some: 'option'});
+ assert.include(config.forBrowser('bro'), {some: 'option'});
+ });
+
+ it('should extend browser config with its id', () => {
+ const config = initConfig({configParserReturns: {browsers: {bro: {some: 'option'}}}});
+
+ assert.include(config.forBrowser('bro'), {id: 'bro'});
});
});
|
feat: extend browser config with its id
|
gemini-testing_hermione
|
train
|
js,js
|
335cdbe067f232b00a3035664f3595fe3fff9ac1
|
diff --git a/src/js/core/icon.js b/src/js/core/icon.js
index <HASH>..<HASH> 100644
--- a/src/js/core/icon.js
+++ b/src/js/core/icon.js
@@ -50,7 +50,7 @@ const Icon = {
props: ['icon'],
- data: {exclude: ['id', 'style', 'class', 'src', 'icon', 'ratio']},
+ data: {include: []},
isIcon: true,
diff --git a/src/js/core/svg.js b/src/js/core/svg.js
index <HASH>..<HASH> 100644
--- a/src/js/core/svg.js
+++ b/src/js/core/svg.js
@@ -19,7 +19,7 @@ export default {
data: {
ratio: 1,
id: false,
- exclude: ['ratio', 'src', 'icon', 'width', 'height'],
+ include: ['id', 'style', 'class'],
'class': '',
strokeAnimation: false
},
@@ -81,7 +81,7 @@ export default {
applyAttributes(el) {
for (const prop in this.$options.props) {
- if (this[prop] && !includes(this.exclude, prop)) {
+ if (this[prop] && includes(this.include, prop)) {
attr(el, prop, this[prop]);
}
}
|
refactor: whitelist attributes to copy to svg
|
uikit_uikit
|
train
|
js,js
|
529cdcc043e5ae037aa48fa275f1212d4a97a374
|
diff --git a/tasks/packager/sectv-tizen.js b/tasks/packager/sectv-tizen.js
index <HASH>..<HASH> 100644
--- a/tasks/packager/sectv-tizen.js
+++ b/tasks/packager/sectv-tizen.js
@@ -356,7 +356,7 @@ module.exports = {
throw Error(result.output);
}
else {
- var packagePath = result.output.match(/Package File Location\:\s*(.*)/);
+ var packagePath = result.stdout.match(/Package File Location\:\s*(.*)/);
if(packagePath && packagePath[1]) {
prepareDir(dest);
shelljs.mv('-f', packagePath[1], path.resolve(dest));
|
fix: result match on tizen package command
|
Samsung_grunt-cordova-sectv
|
train
|
js
|
ed14b319f7f604eb822f3d5815063f699e9a8d02
|
diff --git a/src/foremast/slacknotify/slack_notification.py b/src/foremast/slacknotify/slack_notification.py
index <HASH>..<HASH> 100644
--- a/src/foremast/slacknotify/slack_notification.py
+++ b/src/foremast/slacknotify/slack_notification.py
@@ -1,5 +1,4 @@
"""Notify Slack channel."""
-import logging
import time
from ..utils import get_properties, get_template, post_slack_message
|
refactor: Remove unused import
|
foremast_foremast
|
train
|
py
|
fd496467c94102c13756b9fe3ad737f4bccf5364
|
diff --git a/lib/interceptor.js b/lib/interceptor.js
index <HASH>..<HASH> 100644
--- a/lib/interceptor.js
+++ b/lib/interceptor.js
@@ -12,6 +12,9 @@ class LineHeaderInterceptor extends Interceptor {
constructor(endpoint, config) {
super(endpoint, config);
+
+ // just validate the config once
+ parserFactory(config, true);
}
static get type() {
@@ -24,7 +27,7 @@ class LineHeaderInterceptor extends Interceptor {
receive(request, oldRequest) {
if (request.payload) {
- const streamFilter = parserFactory(this.config, true);
+ const streamFilter = parserFactory(this.config);
const stream = request.payload;
request.payload = stream.pipe(streamFilter);
}
|
perf(validation): Moved the validation of the config into the contractor, so it will be validated only once
|
Kronos-Integration_kronos-interceptor-line-header
|
train
|
js
|
604daeca76082d174c69cc41d30f7387e999b82a
|
diff --git a/src/translate.js b/src/translate.js
index <HASH>..<HASH> 100755
--- a/src/translate.js
+++ b/src/translate.js
@@ -815,7 +815,7 @@ angular.module('pascalprecht.translate').provider('$translate', ['$STORAGE_KEY',
// if there isn't a translation table for the language we've requested,
// we load it asynchronously
- if (!$translationTable[key]) {
+ if (!$translationTable[key] && $loaderFactory) {
loadAsync(key).then(useLanguage, function (key) {
$rootScope.$broadcast('$translateChangeError');
deferred.reject(key);
|
fix(translateService): uses should only load if a loader is registered
|
angular-translate_angular-translate
|
train
|
js
|
77f5e980d94f70ee87bb1c2cebe92959671bc3df
|
diff --git a/test/rpc/rpc-handler-reroutingSpec.js b/test/rpc/rpc-handler-reroutingSpec.js
index <HASH>..<HASH> 100644
--- a/test/rpc/rpc-handler-reroutingSpec.js
+++ b/test/rpc/rpc-handler-reroutingSpec.js
@@ -15,8 +15,8 @@ const options = {
messageConnector: new MessageConnectorMock(),
logger: { log: jasmine.createSpy('log') },
serverName: 'thisServer',
- rpcAckTimeout: 5,
- rpcTimeout: 5
+ rpcAckTimeout: 50,
+ rpcTimeout: 50
}
describe('rpc handler returns alternative providers for the same rpc', () => {
@@ -64,7 +64,7 @@ describe('rpc handler returns alternative providers for the same rpc', () => {
data: ['rpcB']
})
- // This is terrible practice, but we don't have any means to access the object otherwise
+ // This is terrible practice, but we don't have any means to access the object otherwise
rpcHandler._subscriptionRegistry.getAllRemoteServers = function (name) {
if (name === 'rpcA') {
return ['random-server-1', 'random-server-2']
|
test: increase rpc ack timeout in rerouting tests
The tests don't mock ack behaviour, so the rpc objects were sometimes
being destroyed by an ack timeout before the tests ran.
|
deepstreamIO_deepstream.io
|
train
|
js
|
9c6e034b3c94094507e6088b48aa54affca4ebac
|
diff --git a/classes/hypeJunction/Prototyper/Plugin.php b/classes/hypeJunction/Prototyper/Plugin.php
index <HASH>..<HASH> 100644
--- a/classes/hypeJunction/Prototyper/Plugin.php
+++ b/classes/hypeJunction/Prototyper/Plugin.php
@@ -143,7 +143,7 @@ final class Plugin extends \hypeJunction\Plugin {
'value' => get_default_access(),
'input_view' => 'input/access',
'output_view' => 'output/access',
- 'value_type' => 'integer',
+ 'value_type' => 'int',
'show_access' => false,
'multiple' => false,
'required' => true,
|
fix(forms): match access id value type with validator label
|
hypeJunction_hypePrototyper
|
train
|
php
|
3e45b5e33d702565d54016b6fa852e543db4a857
|
diff --git a/lib/Bacon/Presenter/Html.php b/lib/Bacon/Presenter/Html.php
index <HASH>..<HASH> 100644
--- a/lib/Bacon/Presenter/Html.php
+++ b/lib/Bacon/Presenter/Html.php
@@ -69,11 +69,15 @@ class Html extends \Bacon\Presenter
}
}
- $translator = new Translator('de_AT', new MessageSelector());
- $translator->addLoader('po', new PoFileLoader());
- $translator->addResource('po', APP_ROOT . '/locales/de_AT/accounting.po', 'de_AT');
+ if (!empty($this->context->locale)) {
+ $locale = $this->context->locale;
- $twig->addExtension(new \Symfony\Bridge\Twig\Extension\TranslationExtension($translator));
+ $translator = new Translator($locale, new MessageSelector());
+ $translator->addLoader('po', new PoFileLoader());
+ $translator->addResource('po', APP_ROOT . '/locales/' . $locale . '/accounting.po', $locale);
+
+ $twig->addExtension(new \Symfony\Bridge\Twig\Extension\TranslationExtension($translator));
+ }
echo $twig->render($template_path, $this->context->getArrayCopy());
}
|
feat(locales): taking locale from controller setting now
|
Brainsware_bacon
|
train
|
php
|
c9c46693088d68ead074c2fe86460906224284ed
|
diff --git a/wandb/wandb_run.py b/wandb/wandb_run.py
index <HASH>..<HASH> 100644
--- a/wandb/wandb_run.py
+++ b/wandb/wandb_run.py
@@ -150,6 +150,9 @@ class Run(object):
self._run_manager = None
self._jupyter_agent = None
+ # give access to watch method
+ self.watch = wandb.watch
+
@property
def config_static(self):
return ConfigStatic(self.config)
|
feat: access watch method from Run object (#<I>)
|
wandb_client
|
train
|
py
|
fe510c4705137c7d0a06831921c97c2536e24df3
|
diff --git a/test/spec/directives/selection-model.js b/test/spec/directives/selection-model.js
index <HASH>..<HASH> 100644
--- a/test/spec/directives/selection-model.js
+++ b/test/spec/directives/selection-model.js
@@ -85,6 +85,28 @@ describe('Directive: selectionModel', function() {
});
});
+ describe('with selectionModelIgnore', function() {
+ var el, tpl = [
+ '<ul>',
+ '<li ng-repeat="item in bag" ',
+ 'selection-model>',
+ '{{$index + 1}}: {{item.value}}',
+ '<span selection-model-ignore>Will not change selection!</span>',
+ '</li>',
+ '</ul>'
+ ].join('');
+
+ beforeEach(function() {
+ el = compile(tpl, scope);
+ });
+
+ it('should ignore clicks on selectionModelIgnore elements', function() {
+ el.children().last().find('span').click();
+ expect(scope.bag[0].selected).toBe(true);
+ expect(scope.bag[2].selected).toBe(false);
+ });
+ });
+
describe('with checkboxes', function() {
var el, tpl = [
'<table>',
|
test: Add test for helper to ignore clicks
Ignoring clicks on certain elements will allow users to have click hanlders
which change selected states without butting heads with the selection model
directive.
[ci skip]
|
jtrussell_angular-selection-model
|
train
|
js
|
7824f822b9e5f3c652ffd893d8a696ff14304aa3
|
diff --git a/vyper/functions/functions.py b/vyper/functions/functions.py
index <HASH>..<HASH> 100644
--- a/vyper/functions/functions.py
+++ b/vyper/functions/functions.py
@@ -843,9 +843,15 @@ class RawCall:
# build sequence LLL
if outsize:
- # only copy the return value to memory if outsize > 0
+ # return minimum of outsize and returndatasize
+ size = [
+ 'with', '_l', outsize, [
+ 'with', '_r', 'returndatasize', ['if', ['gt', '_l', '_r'], '_r', '_l']
+ ]
+ ]
+
seq = [
- 'seq', copier, ['assert', call_lll], ['mstore', output_node, outsize], output_node
+ 'seq', copier, ['assert', call_lll], ['mstore', output_node, size], output_node
]
typ = ByteArrayType(outsize)
else:
|
fix: consider returndatasize for raw_call output
|
ethereum_vyper
|
train
|
py
|
662a7a3b422d83a343a2dab61a3b27acafb4b95a
|
diff --git a/src/Leevel/Kernel/IApp.php b/src/Leevel/Kernel/IApp.php
index <HASH>..<HASH> 100644
--- a/src/Leevel/Kernel/IApp.php
+++ b/src/Leevel/Kernel/IApp.php
@@ -223,9 +223,9 @@ interface IApp
/**
* 获取命名空间目录真实路径.
*
- * 一般用于获取文件 PSR4 所在的命名空间，当然如果存在命名空间。
- * 基于某个具体的类查询该类目录的真实路径。
- * 为简化开发和提升性能，必须提供具体的存在的类才能够获取目录的真实路径。
+ * - 一般用于获取文件 PSR4 所在的命名空间，当然如果存在命名空间。
+ * - 基于某个具体的类查询该类目录的真实路径。
+ * - 为简化开发和提升性能，必须提供具体的存在的类才能够获取目录的真实路径。
*/
public function namespacePath(string $specificClass): string;
|
refactor(kernel): code poem
|
hunzhiwange_framework
|
train
|
php
|
919bcbb2cef2a47cf986eb587858e595c3450873
|
diff --git a/packages/@vue/cli/lib/promptModules/cssPreprocessors.js b/packages/@vue/cli/lib/promptModules/cssPreprocessors.js
index <HASH>..<HASH> 100644
--- a/packages/@vue/cli/lib/promptModules/cssPreprocessors.js
+++ b/packages/@vue/cli/lib/promptModules/cssPreprocessors.js
@@ -3,7 +3,7 @@ module.exports = cli => {
name: 'CSS Pre-processors',
value: 'css-preprocessor',
description: 'Add support for CSS pre-processors like SASS, Less or Stylus',
- link: 'https://github.com/vuejs/vue-cli/blob/dev/docs/css.md'
+ link: 'https://cli.vuejs.org/guide/css.html'
})
cli.injectPrompt({
|
fix(ui): CSS Pre-processors "More info" link leads to <I> (#<I>)
|
vuejs_vue-cli
|
train
|
js
|
e48612bd34b920969b7869d40719e27ef1bd2718
|
diff --git a/lib/options/urls.js b/lib/options/urls.js
index <HASH>..<HASH> 100644
--- a/lib/options/urls.js
+++ b/lib/options/urls.js
@@ -24,8 +24,9 @@ async function parseUrlsOption (state, urls) {
}
const pageUrls = normalizedUrls.filter(isPageUrl)
+
const sectionUrls = normalizedUrls.filter(isSectionUrl)
- return _.uniq((await pageUrls.reduce(toSectionUrls, [])).concat(sectionUrls))
+ return _.uniq((await pageUrls.reduce(toSectionUrls.bind(null, state), [])).concat(sectionUrls))
}
function isntV3DocumentationUrl (url) {
@@ -44,5 +45,6 @@ async function toSectionUrls (state, promise, pageOrUrl) {
const sectionUrls = await promise
const pageSections = await getPageSections(state, pageOrUrl.url || pageOrUrl)
const urls = pageSections.map(section => section.url)
+
return sectionUrls.concat(urls)
}
|
fix: handling of check with custom URLs
|
octokit_routes
|
train
|
js
|
23122bd7f6a676e1f58dbeeb08f477b3f751f235
|
diff --git a/schedula/utils/drw.py b/schedula/utils/drw.py
index <HASH>..<HASH> 100755
--- a/schedula/utils/drw.py
+++ b/schedula/utils/drw.py
@@ -853,6 +853,7 @@ class SiteMap(collections.OrderedDict):
'digraph', 'node_styles', 'node_data', 'node_function', 'edge_data',
'max_lines', 'max_width'
}
+ include_folders_as_filenames = True
def __init__(self):
super(SiteMap, self).__init__()
self._nodes = []
@@ -891,7 +892,8 @@ class SiteMap(collections.OrderedDict):
rule = rule + (self.foldername,)
if filenames is None:
filenames = []
- filenames += [v.foldername for k, v in self.items()]
+ if self.include_folders_as_filenames:
+ filenames += [v.foldername for k, v in self.items()]
if depth != 0:
depth -= 1
for folder, smap in self.items():
|
feat(drw): Add option include_folders_as_filenames to SiteMap.
|
vinci1it2000_schedula
|
train
|
py
|
9467b53a795aa5ba716b20d8db113682570649fd
|
diff --git a/src/components/tabs/tabs.js b/src/components/tabs/tabs.js
index <HASH>..<HASH> 100644
--- a/src/components/tabs/tabs.js
+++ b/src/components/tabs/tabs.js
@@ -66,7 +66,7 @@ class Tab extends ContentSwitcher {
const trigger = eventMatches(event, this.options.selectorTrigger);
if (button) {
super._handleClick(event);
- this._updateMenuState();
+ this._updateMenuState(false);
}
if (trigger) {
this._updateMenuState();
@@ -113,11 +113,12 @@ class Tab extends ContentSwitcher {
/**
* Shows/hides the drop down menu used in narrow mode.
+ * @param {boolean} [force] `true` to show the menu, `false` to hide the menu, otherwise toggles the menu.
*/
- _updateMenuState() {
+ _updateMenuState(force) {
const menu = this.element.querySelector(this.options.selectorMenu);
if (menu) {
- menu.classList.toggle(this.options.classHidden);
+ menu.classList.toggle(this.options.classHidden, typeof force === 'undefined' ? force : !force);
}
}
|
fix(tabs): fix for mobile tab selection not closing the dropdown (#<I>) (#<I>)
Fixes #<I>.
Closes #<I>.
|
carbon-design-system_carbon-components
|
train
|
js
|
993069deef08f349a0e4092c36f9dfb4fa953a80
|
diff --git a/js/src/sidebar.js b/js/src/sidebar.js
index <HASH>..<HASH> 100644
--- a/js/src/sidebar.js
+++ b/js/src/sidebar.js
@@ -352,7 +352,7 @@ class Sidebar extends BaseComponent {
// Static
- static _sidebarInterface(element, config) {
+ static sidebarInterface(element, config) {
let data = Data.getData(element, DATA_KEY)
const _config = typeof config === 'object' && config
@@ -371,7 +371,7 @@ class Sidebar extends BaseComponent {
static jQueryInterface(config) {
return this.each(function () {
- Sidebar._sidebarInterface(this, config)
+ Sidebar.sidebarInterface(this, config)
})
}
}
@@ -385,7 +385,7 @@ class Sidebar extends BaseComponent {
EventHandler.on(window, EVENT_LOAD_DATA_API, () => {
// eslint-disable-next-line unicorn/prefer-spread
Array.from(document.querySelectorAll(SELECTOR_SIDEBAR)).forEach(element => {
- Sidebar._sidebarInterface(element)
+ Sidebar.sidebarInterface(element)
})
})
|
refactor: rename `_sidebarInterface` to `sidebarInterface`
|
coreui_coreui
|
train
|
js
|
3d3e198aa374050ce3110e009d15920d842b04b6
|
diff --git a/test/test_ATR.py b/test/test_ATR.py
index <HASH>..<HASH> 100644
--- a/test/test_ATR.py
+++ b/test/test_ATR.py
@@ -1,4 +1,3 @@
-#! /usr/bin/env python
# -*- coding: utf-8 -*-
import sys
diff --git a/test/test_Exceptions.py b/test/test_Exceptions.py
index <HASH>..<HASH> 100644
--- a/test/test_Exceptions.py
+++ b/test/test_Exceptions.py
@@ -1,4 +1,3 @@
-#! /usr/bin/env python
# -*- coding: utf-8 -*-
# to execute:
diff --git a/test/test_SCardGetErrorMessage.py b/test/test_SCardGetErrorMessage.py
index <HASH>..<HASH> 100644
--- a/test/test_SCardGetErrorMessage.py
+++ b/test/test_SCardGetErrorMessage.py
@@ -1,4 +1,3 @@
-#! /usr/bin/env python
# -*- coding: utf-8 -*-
# to execute:
diff --git a/test/test_util.py b/test/test_util.py
index <HASH>..<HASH> 100644
--- a/test/test_util.py
+++ b/test/test_util.py
@@ -1,4 +1,3 @@
-#! /usr/bin/env python
# -*- coding: utf-8 -*-
# to execute:
|
test: remove #!
The scripts are called from setup.py so and are not executable. So they
do not need a sheband line
|
LudovicRousseau_pyscard
|
train
|
py,py,py,py
|
fb01b6e6061be9a5f2671f66c628e71274bc62c1
|
diff --git a/packages/ad/src/dom-context.js b/packages/ad/src/dom-context.js
index <HASH>..<HASH> 100644
--- a/packages/ad/src/dom-context.js
+++ b/packages/ad/src/dom-context.js
@@ -1,5 +1,5 @@
import React, { PureComponent } from "react";
-import { View, Linking } from "react-native";
+import { View, Linking, Platform } from "react-native";
import { WebView } from "react-native-webview";
import webviewEventCallbackSetup from "./utils/webview-event-callback-setup";
import logger from "./utils/logger";
@@ -125,6 +125,9 @@ class DOMContext extends PureComponent {
<WebView
onMessage={this.handleMessageEvent}
onNavigationStateChange={this.handleNavigationStateChange}
+ originWhitelist={
+ Platform.OS === "android" ? ["http://.*", "https://.*"] : undefined
+ }
ref={ref => {
this.webView = ref;
}}
|
fix: restore fix for android unruly ads (#<I>)
|
newsuk_times-components
|
train
|
js
|
922b42a286857a8fdca64d649614724a8d104757
|
diff --git a/packages/testing-karma-bs/bs-settings.js b/packages/testing-karma-bs/bs-settings.js
index <HASH>..<HASH> 100644
--- a/packages/testing-karma-bs/bs-settings.js
+++ b/packages/testing-karma-bs/bs-settings.js
@@ -49,6 +49,7 @@ module.exports = () => ({
bs_win10_firefox_latest: {
base: 'BrowserStack',
browser: 'Firefox',
+ browser_version: '64.0',
os: 'Windows',
os_version: '10',
},
|
fix(testing-karma-bs): hard code Firefox <I> as <I> produces a timeout
|
open-wc_open-wc
|
train
|
js
|
9ecf888e6e1b7efa1dadbdf5fdc15a57e2019df3
|
diff --git a/lib/loader/egg_loader.js b/lib/loader/egg_loader.js
index <HASH>..<HASH> 100644
--- a/lib/loader/egg_loader.js
+++ b/lib/loader/egg_loader.js
@@ -95,6 +95,7 @@ class EggLoader {
if (process.env.NODE_ENV === 'test') {
serverEnv = 'unittest';
} else if (process.env.NODE_ENV === 'production') {
+ console.warn('NODE_ENV is production but EGG_SERVER_ENV is empty, forgot `EGG_SERVER_ENV=prod`? see https://github.com/eggjs/egg-core/blob/master/lib/loader/egg_loader.js#L82 for more detail.');
serverEnv = 'default';
} else {
serverEnv = 'local';
|
feat: warning when missing EGG_SERVER_ENV at production (#<I>)
|
eggjs_egg-core
|
train
|
js
|
15483a7394ffe738179db9acab3f275534c5028f
|
diff --git a/src/find.js b/src/find.js
index <HASH>..<HASH> 100644
--- a/src/find.js
+++ b/src/find.js
@@ -1,7 +1,7 @@
const _ = require('underscore');
const sanitizeParams = require('./utils/sanitizeParams');
const { prepareResponse, generateSort, generateCursorQuery } = require('./utils/query');
-var config = require('./config');
+const config = require('./config');
/**
* Performs a find() query on a passed-in Mongo collection, using criteria you specify. The results
|
fix: use const in preference to var
|
mixmaxhq_mongo-cursor-pagination
|
train
|
js
|
43b7ded16ca9a9a2067041d6b9bb5e2cc19b47f6
|
diff --git a/server/application/websocket.go b/server/application/websocket.go
index <HASH>..<HASH> 100644
--- a/server/application/websocket.go
+++ b/server/application/websocket.go
@@ -23,11 +23,12 @@ var upgrader = func() websocket.Upgrader {
// terminalSession implements PtyHandler
type terminalSession struct {
- wsConn *websocket.Conn
- sizeChan chan remotecommand.TerminalSize
- doneChan chan struct{}
- tty bool
- readLock sync.Mutex
+ wsConn *websocket.Conn
+ sizeChan chan remotecommand.TerminalSize
+ doneChan chan struct{}
+ tty bool
+ readLock sync.Mutex
+ writeLock sync.Mutex
}
// newTerminalSession create terminalSession
@@ -95,7 +96,10 @@ func (t *terminalSession) Write(p []byte) (int, error) {
log.Errorf("write parse message err: %v", err)
return 0, err
}
- if err := t.wsConn.WriteMessage(websocket.TextMessage, msg); err != nil {
+ t.writeLock.Lock()
+ err = t.wsConn.WriteMessage(websocket.TextMessage, msg)
+ t.writeLock.Unlock()
+ if err != nil {
log.Errorf("write message err: %v", err)
return 0, err
}
|
fix: terminal websocket write lock to avoid races (#<I>)
* fix: protect terminal WriteMessage with a lock
|
argoproj_argo-cd
|
train
|
go
|
bb307493c963874b010d7f4237160d35ee0f5bf5
|
diff --git a/packages/core/lib/config.js b/packages/core/lib/config.js
index <HASH>..<HASH> 100644
--- a/packages/core/lib/config.js
+++ b/packages/core/lib/config.js
@@ -93,20 +93,26 @@ const loadConfig = (context, config) => {
: searchSync(context);
};
-const loadSettings = (context, { dependencies }) => {
+const loadSettings = (context, { dependencies = {}, devDependencies = {} }) => {
const result = loadConfig(context);
const settings = {
...(result ? result.config : {}),
};
if (!settings.presets) {
- settings.presets = Object.keys(dependencies).filter((key) => {
- try {
- return loadConfig(context, key);
- } catch (error) {
- if (!isResolveError(error)) throw error;
- return null;
- }
- });
+ settings.presets = Object.keys(dependencies)
+ .concat(
+ process.env.NODE_ENV !== 'production'
+ ? Object.keys(devDependencies)
+ : []
+ )
+ .filter((key) => {
+ try {
+ return loadConfig(context, key);
+ } catch (error) {
+ if (!isResolveError(error)) throw error;
+ return null;
+ }
+ });
}
return settings;
};
|
fix(core): take devDependencies into account when resolving presets
when NODE_ENV is not production
|
untool_untool
|
train
|
js
|
b3a2f80c90cfa05450b5c6a88cdbda5f2dfee155
|
diff --git a/org/postgresql/jdbc2/AbstractJdbc2Statement.java b/org/postgresql/jdbc2/AbstractJdbc2Statement.java
index <HASH>..<HASH> 100644
--- a/org/postgresql/jdbc2/AbstractJdbc2Statement.java
+++ b/org/postgresql/jdbc2/AbstractJdbc2Statement.java
@@ -22,6 +22,7 @@ import java.util.TimeZone;
import java.util.Calendar;
import org.postgresql.Driver;
+import org.postgresql.core.v3.QueryExecutorImpl;
import org.postgresql.largeobject.*;
import org.postgresql.core.*;
import org.postgresql.core.types.*;
@@ -863,22 +864,9 @@ public abstract class AbstractJdbc2Statement implements BaseStatement
}
/**
- * This finalizer ensures that statements that have allocated server-side
- * resources free them when they become unreferenced.
+ * Statement finalizer is not required as "statement" at the database side
+ * is managed by a {@link java.lang.ref.PhantomReference} in {@link QueryExecutorImpl#processDeadParsedQueries()}.
*/
- protected void finalize() throws Throwable {
- try
- {
- close();
- }
- catch (SQLException e)
- {
- }
- finally
- {
- super.finalize();
- }
- }
/*
* Filter the SQL string of Java SQL Escape clauses.
|
perf: Remove AbstractJdbc2Statement.finalize()
Removes AbstractJdbc2Statement.finalize() as server side resource
cleanup is already handled byQueryExecutorImpl#processDeadParsedQueries.
With this change, if many prepared statements are created, but not
closed, and no further activity occurs on the connection, then the
server side resources for those connections will never be closed. The
scenario is considered to be unlikely and in any event is incorrect
usage of the driver.
|
pgjdbc_pgjdbc
|
train
|
java
|
15ac1aa9a3ad1922f7207f69dec2ff17da38df07
|
diff --git a/lib/components/map/connected-route-viewer-overlay.js b/lib/components/map/connected-route-viewer-overlay.js
index <HASH>..<HASH> 100644
--- a/lib/components/map/connected-route-viewer-overlay.js
+++ b/lib/components/map/connected-route-viewer-overlay.js
@@ -21,7 +21,7 @@ const mapStateToProps = (state, ownProps) => {
return {
clipToPatternStops:
- state.otp.config.routeViewer.hideRouteShapesWithinFlexZones,
+ state.otp.config?.routeViewer?.hideRouteShapesWithinFlexZones,
routeData: { ...routeData, patterns: filteredPatterns }
}
}
|
refactor(connected-route-viewer-overlay): avoid crash when routeViewer missing from config
|
opentripplanner_otp-react-redux
|
train
|
js
|
43a5c8b923e6e974b35fb09e39eed320739d45b7
|
diff --git a/src/foremast/__main__.py b/src/foremast/__main__.py
index <HASH>..<HASH> 100644
--- a/src/foremast/__main__.py
+++ b/src/foremast/__main__.py
@@ -28,8 +28,8 @@ def add_pipeline(subparsers):
pipeline_full_parser.set_defaults(func=runner.prepare_app_pipeline)
pipeline_onetime_parser = pipeline_subparsers.add_parser(
- 'onetime', help='Create onetime Pipeline', formatter_class=argparse.ArgumentDefaultsHelpFormatter)
- pipeline_onetime_parser.set_defaults(func=pipeline_onetime_parser.print_help)
+ 'onetime', help=runner.prepare_onetime_pipeline.__doc__, formatter_class=argparse.ArgumentDefaultsHelpFormatter)
+ pipeline_onetime_parser.set_defaults(func=runner.prepare_onetime_pipeline)
add_env(pipeline_onetime_parser)
|
fix: Point Pipeline onetime to entry point
|
foremast_foremast
|
train
|
py
|
65007e2e718fb86268e1f132e345104381cc313a
|
diff --git a/app/lib/ssr/html-template.js b/app/lib/ssr/html-template.js
index <HASH>..<HASH> 100644
--- a/app/lib/ssr/html-template.js
+++ b/app/lib/ssr/html-template.js
@@ -53,14 +53,15 @@ module.exports.getIndexHtml = function (template, cfg) {
)
let html = compiled(cfg.htmlVariables)
- const data = { body: [], head: [] }
+ const data = { bodyTags: [], headTags: [] }
if (cfg.ctx.mode.pwa) {
fillPwaTags(data, cfg)
}
- if (data.body.length > 0 || data.head.length > 0) {
- html = HtmlWebpackPlugin.prototype.injectAssetsIntoHtml(html, {}, data)
+ if (data.bodyTags.length > 0 || data.headTags.length > 0) {
+ const htmlCtx = { options: { xhtml: false } }
+ html = HtmlWebpackPlugin.prototype.injectAssetsIntoHtml.call(htmlCtx, html, {}, data)
}
html = injectSsrInterpolation(html)
|
fix(app): SSR index file management
|
quasarframework_quasar
|
train
|
js
|
9007abc5056466d77e441b920ae199d6d8d8156a
|
diff --git a/bigtable-client-core-parent/bigtable-hbase/src/main/java/com/google/cloud/bigtable/hbase/util/RowKeyWrapper.java b/bigtable-client-core-parent/bigtable-hbase/src/main/java/com/google/cloud/bigtable/hbase/util/RowKeyWrapper.java
index <HASH>..<HASH> 100644
--- a/bigtable-client-core-parent/bigtable-hbase/src/main/java/com/google/cloud/bigtable/hbase/util/RowKeyWrapper.java
+++ b/bigtable-client-core-parent/bigtable-hbase/src/main/java/com/google/cloud/bigtable/hbase/util/RowKeyWrapper.java
@@ -66,4 +66,9 @@ public class RowKeyWrapper implements Comparable<RowKeyWrapper> {
}
return Integer.compare(key1.size(), key2.size());
}
+
+ @Override
+ public String toString() {
+ return key.toString();
+ }
}
|
feat: add toString for RowKeyWrapper to ease debugging (#<I>)
|
googleapis_cloud-bigtable-client
|
train
|
java
|
e9e6db145519b0b2339f9a2426368edf0ed224a6
|
diff --git a/src/notebook/epics/saving.js b/src/notebook/epics/saving.js
index <HASH>..<HASH> 100644
--- a/src/notebook/epics/saving.js
+++ b/src/notebook/epics/saving.js
@@ -1,5 +1,5 @@
-import { writeFileObservable } from '../../utils/fs';
import { ActionsObservable } from 'redux-observable';
+import { writeFileObservable } from '../../utils/fs';
const Rx = require('rxjs/Rx');
const commutable = require('commutable');
@@ -34,15 +34,14 @@ export function saveEpic(action$) {
null,
1))
.catch(error => {
- const input$ = new Observable.of({type: 'SAVING_ERROR'});
+ const input$ = Observable.of({ type: 'SAVING_ERROR' });
return new ActionsObservable(input$);
})
.map(doneSaving)
// .startWith({ type: START_SAVING })
// since SAVE effectively acts as the same as START_SAVING
// you could just look for that in your reducers instead of START_SAVING
- )
-
+ );
}
export function saveAsEpic(actions) {
|
chore(EpicsTesting): Satisfy linter.
|
nteract_nteract
|
train
|
js
|
d71639bbf8a887c39bce599a45399fa96d180690
|
diff --git a/lib/workers/repository/process/fetch.js b/lib/workers/repository/process/fetch.js
index <HASH>..<HASH> 100644
--- a/lib/workers/repository/process/fetch.js
+++ b/lib/workers/repository/process/fetch.js
@@ -32,7 +32,14 @@ async function fetchDepUpdates(packageFileConfig, dep) {
logger.debug({ depName: dep.depName }, 'Dependency is disabled');
dep.skipReason = 'disabled';
} else {
- dep.updates = await getPackageUpdates(manager, depConfig);
+ const lookupResults = await getPackageUpdates(manager, depConfig);
+ // istanbul ignore else
+ if (Array.isArray(lookupResults)) {
+ dep.updates = lookupResults;
+ } else {
+ Object.assign(dep, lookupResults);
+ }
+ dep.updates = dep.updates || [];
logger.trace({
packageFile,
manager,
|
refactor: fetch array or object
|
renovatebot_renovate
|
train
|
js
|
0a597ceba805a70bd4048247681827077a840383
|
diff --git a/packages/empty-state/src/EmptyState.story.js b/packages/empty-state/src/EmptyState.story.js
index <HASH>..<HASH> 100644
--- a/packages/empty-state/src/EmptyState.story.js
+++ b/packages/empty-state/src/EmptyState.story.js
@@ -4,7 +4,7 @@ import { action } from "@storybook/addon-actions";
import { storiesOf } from "@storybook/react";
import { withInfo } from "@storybook/addon-info";
-import EmptyState from ".";
+import EmptyState from "@crave/farmblocks-empty-state";
const twoLinesDescription =
"Integer posuere erat a ante venenatis dapibus posuere velit aliquet. Etiam porta sem malesuada magna mollis euismod.";
|
test(stories): use the compiled version of the empty state on storybook
affects: @crave/farmblocks-empty-state
in order to have the proptypes generated by babel
|
CraveFood_farmblocks
|
train
|
js
|
2972e3a85ea4d8e1366e86c87b5298b870416151
|
diff --git a/lib/protractor.js b/lib/protractor.js
index <HASH>..<HASH> 100644
--- a/lib/protractor.js
+++ b/lib/protractor.js
@@ -5,6 +5,8 @@ var webdriver = require('selenium-webdriver');
var clientSideScripts = require('./clientsidescripts.js');
var ProtractorBy = require('./locators.js').ProtractorBy;
+/* global angular */
+
var DEFER_LABEL = 'NG_DEFER_BOOTSTRAP!';
var WEB_ELEMENT_FUNCTIONS = [
@@ -1019,7 +1021,7 @@ Protractor.prototype.addBaseMockModules_ = function() {
config(['$compileProvider', function($compileProvider) {
if ($compileProvider.debugInfoEnabled) {
$compileProvider.debugInfoEnabled(true);
- };
+ }
}]);
});
};
|
style(protractor): fix up jshint errors - semicolon and missing global
|
angular_protractor
|
train
|
js
|
4ea4e0436ab66bd49e7a4b0efa422d66bee95a89
|
diff --git a/pkg/services/notifications/mailer.go b/pkg/services/notifications/mailer.go
index <HASH>..<HASH> 100644
--- a/pkg/services/notifications/mailer.go
+++ b/pkg/services/notifications/mailer.go
@@ -101,6 +101,7 @@ func createDialer() (*gomail.Dialer, error) {
d := gomail.NewDialer(host, iPort, setting.Smtp.User, setting.Smtp.Password)
d.TLSConfig = tlsconfig
+ d.LocalName = setting.InstanceName
return d, nil
}
|
feat(mailer): set localname to hostname
Some email providers does not accept localhost
in the HELO message. So we set it to hostname
instead. Our hope is that should be enough for
those providers who does not accept localhost.
closes #<I>
|
grafana_grafana
|
train
|
go
|
e20bc5a25b84b879a9e130e2979872a6c4b191d5
|
diff --git a/lib/bundle-manager.js b/lib/bundle-manager.js
index <HASH>..<HASH> 100644
--- a/lib/bundle-manager.js
+++ b/lib/bundle-manager.js
@@ -233,11 +233,13 @@ module.exports._stopWatching = function () {
watcher.close();
};
-/**
- * Emits a `bundleChanged` event for the given bundle.
- * @param bundleName {String}
- */
function handleChange(bundleName) {
+ setTimeout(() => {
+ _handleChange(bundleName);
+ }, 100);
+}
+
+function _handleChange(bundleName) {
const bundle = module.exports.find(bundleName);
/* istanbul ignore if: It's rare for `bundle` to be undefined here, but it can happen when using black/whitelisting. */
|
fix(bundle-manager): reduce frequency of crash when editing dashboard HTML files
|
nodecg_nodecg
|
train
|
js
|
5b8b6e9c35345c3aa1451201638f3ba419973173
|
diff --git a/packages/drawer/src/react/collapsible.js b/packages/drawer/src/react/collapsible.js
index <HASH>..<HASH> 100644
--- a/packages/drawer/src/react/collapsible.js
+++ b/packages/drawer/src/react/collapsible.js
@@ -5,6 +5,7 @@ import React from 'react'
const Container = glamorous.div({
overflow: 'hidden',
+ visibility: 'hidden',
transition: `height ${core.motion.speedNormal}`,
})
@@ -59,6 +60,7 @@ export default class Collapsible extends React.Component {
}
updateOverflowStyle(isOpen, isTransitioning = false) {
this.containerElement.style.overflow = isTransitioning || !isOpen ? 'hidden' : 'visible'
+ this.containerElement.style.visibility = isTransitioning || isOpen ? 'visible' : 'hidden'
}
setHeightToAuto(element) {
const prevHeight = element.style.height
@@ -98,4 +100,4 @@ Collapsible.displayName = 'Collapsible'
Collapsible.propTypes = {
isOpen: PropTypes.bool.isRequired,
children: PropTypes.node
-}
\ No newline at end of file
+}
|
fix(drawer): prevent tabbing into closed drawers
|
pluralsight_design-system
|
train
|
js
|
4147eb9af3c50cd5f2f62cf973649bf7dc5a6212
|
diff --git a/src/core/balancer.js b/src/core/balancer.js
index <HASH>..<HASH> 100644
--- a/src/core/balancer.js
+++ b/src/core/balancer.js
@@ -65,13 +65,13 @@ export class Balancer {
static _query() {
this._servers.map((server, i) => {
const _server = JSON.stringify(server);
- logger.info(`[balancer]: querying ${_server}`);
+ logger.verbose(`[balancer]: querying ${_server}`);
const startTime = now();
const socket = net.connect(server, () => {
const ping = now() - startTime;
this._pings[i] = ping;
- logger.info(`[balancer]: ${_server} = ${ping}ms`);
+ logger.verbose(`[balancer]: ${_server} = ${ping}ms`);
socket.end();
});
socket.on('error', () => {
|
chore(balancer): use verbose log
|
blinksocks_blinksocks
|
train
|
js
|
56ff7f556747089e636aea554ab3900d2cf03e5b
|
diff --git a/stellar_sdk/server.py b/stellar_sdk/server.py
index <HASH>..<HASH> 100644
--- a/stellar_sdk/server.py
+++ b/stellar_sdk/server.py
@@ -37,7 +37,7 @@ class Server(BaseServer):
:param horizon_url: Horizon Server URL
(ex. ``"https://horizon-testnet.stellar.org"`` for test network,
- ``"https://horizon-testnet.stellar.org"`` for public network)
+ ``"https://horizon.stellar.org"`` for public network)
:param client: Http client used to send the request
"""
diff --git a/stellar_sdk/server_async.py b/stellar_sdk/server_async.py
index <HASH>..<HASH> 100644
--- a/stellar_sdk/server_async.py
+++ b/stellar_sdk/server_async.py
@@ -39,7 +39,7 @@ class ServerAsync(BaseServer):
:param horizon_url: Horizon Server URL
(ex. ``"https://horizon-testnet.stellar.org"`` for test network,
- ``"https://horizon-testnet.stellar.org"`` for public network)
+ ``"https://horizon.stellar.org"`` for public network)
:param client: Http client used to send the request
"""
|
docs: correct the horizon address of the public network (#<I>)
|
StellarCN_py-stellar-base
|
train
|
py,py
|
eec61554a67e5a52675a012788fea928c692ddb1
|
diff --git a/gulpfile.base.js b/gulpfile.base.js
index <HASH>..<HASH> 100644
--- a/gulpfile.base.js
+++ b/gulpfile.base.js
@@ -31,7 +31,7 @@ module.exports.eslint = ({relativePath, gulp}) => gulp.task("eslint", () => {
.pipe(gulpIf(isFixed, gulp.dest(relativePath)))
.pipe(eslint.failAfterError());
- stream.on("finish", () => resultsFile.end());
+ stream.on("finish", () => resultsFile && resultsFile.end());
return stream;
});
@@ -49,10 +49,14 @@ module.exports.sassLint = ({relativePath, gulp}) => gulp.task("sassLint", () =>
: undefined
}
}))
- .pipe(sassLint.format(resultsFile))
+ .pipe(
+ resultsFile
+ ? sassLint.format("junit", resultsFile)
+ : sassLint.format()
+ )
.pipe(sassLint.failOnError());
- stream.on("finish", () => resultsFile.end());
+ stream.on("finish", () => resultsFile && resultsFile.end());
return stream;
});
|
chore(gulp): `gulp eslint` and `gulp sassLint` need to be able complete in non PR environments...
How did this work before?
|
randytarampi_me
|
train
|
js
|
d20bbec708388d2975e27b4d698ccac2427a60aa
|
diff --git a/ibis/backends/base/sql/compiler/extract_subqueries.py b/ibis/backends/base/sql/compiler/extract_subqueries.py
index <HASH>..<HASH> 100644
--- a/ibis/backends/base/sql/compiler/extract_subqueries.py
+++ b/ibis/backends/base/sql/compiler/extract_subqueries.py
@@ -39,7 +39,8 @@ class ExtractSubqueries:
elif isinstance(node, ops.Join):
self.visit_join(expr)
elif isinstance(node, ops.PhysicalTable):
- self.visit_physical_table(expr)
+ # do nothing, because physical tables can be referred to by name
+ pass
elif isinstance(node, ops.TableNode):
for arg in node.flat_args():
if isinstance(arg, ir.Table):
@@ -58,9 +59,6 @@ class ExtractSubqueries:
self.visit(node.left)
self.visit(node.right)
- def visit_physical_table(self, _):
- return
-
def visit_Exists(self, expr):
node = expr.op()
self.visit(node.foreign_table)
|
chore: remove visit_physical_table in favor of pass
|
ibis-project_ibis
|
train
|
py
|
78d92622da64895a7c502f70c2392d14f737c7c7
|
diff --git a/plugins/inputs/elasticsearch_query/elasticsearch_query_test.go b/plugins/inputs/elasticsearch_query/elasticsearch_query_test.go
index <HASH>..<HASH> 100644
--- a/plugins/inputs/elasticsearch_query/elasticsearch_query_test.go
+++ b/plugins/inputs/elasticsearch_query/elasticsearch_query_test.go
@@ -568,8 +568,13 @@ func setupIntegrationTest() error {
return err
}
- // wait 5s (default) for Elasticsearch to index, so results are consistent
- time.Sleep(time.Second * 5)
+ // force elastic to refresh indexes to get new batch data
+ ctx := context.Background()
+ _, err = e.esClient.Refresh().Do(ctx)
+ if err != nil {
+ return err
+ }
+
return nil
}
|
test: force elasticsearch to index batch data (#<I>)
|
influxdata_telegraf
|
train
|
go
|
41dcebeaef610147d2b4081d27071b1f75a72bce
|
diff --git a/tests/jupyter/async_test.py b/tests/jupyter/async_test.py
index <HASH>..<HASH> 100644
--- a/tests/jupyter/async_test.py
+++ b/tests/jupyter/async_test.py
@@ -208,6 +208,9 @@ def test_debounced_await(df_trimmed, as_coroutine, as_method, flush_guard,):
bla2 = other_foo.foo()
result1 = await future1
result2 = await future2
+ if as_method:
+ await bla1
+ await bla2
assert calls == 1
assert result1 is result2
# await asyncio.sleep(0.02)
|
test: fix async test, was missing await
|
vaexio_vaex
|
train
|
py
|
b1e7641884004232d4d66207418f7f3b7836b34b
|
diff --git a/addons/docs/src/frameworks/web-components/config.js b/addons/docs/src/frameworks/web-components/config.js
index <HASH>..<HASH> 100644
--- a/addons/docs/src/frameworks/web-components/config.js
+++ b/addons/docs/src/frameworks/web-components/config.js
@@ -11,7 +11,7 @@ function mapData(data) {
type: { summary: item.type },
required: '',
description: item.description,
- defaultValue: { summary: item.default },
+ defaultValue: { summary: item.defaultValue }
}));
}
|
fix(web-components): update key to reflect specification
|
storybooks_storybook
|
train
|
js
|
eb38cf9d4228b8181aa3f6a360d57d2c0d5ba416
|
diff --git a/src/Tool/ValueExtractorTrait.php b/src/Tool/ValueExtractorTrait.php
index <HASH>..<HASH> 100644
--- a/src/Tool/ValueExtractorTrait.php
+++ b/src/Tool/ValueExtractorTrait.php
@@ -29,7 +29,7 @@ trait ValueExtractorTrait
/**
* Extracts the value of the given property or method from the object.
*
- * @param object $object The object to extract the value from.
+ * @param mixed $object The object to extract the value from.
* @param string $propertyOrMethod The property or method for which the
* value should be extracted.
*
@@ -37,8 +37,12 @@ trait ValueExtractorTrait
*
* @throws ValueExtractionException if the method or property is not defined.
*/
- protected function extractValue(object $object, string $propertyOrMethod)
+ protected function extractValue($object, string $propertyOrMethod)
{
+ if (!is_object($object)) {
+ throw new ValueExtractionException('Unable to extract a value from a non-object');
+ }
+
if (property_exists($object, $propertyOrMethod)) {
return $object->$propertyOrMethod;
}
|
fix: protect against non-objects passed to value extractor
|
ramsey_collection
|
train
|
php
|
086d75bdf1d491d083f5e05dfe764bb9193480aa
|
diff --git a/niworkflows/func/tests/test_util.py b/niworkflows/func/tests/test_util.py
index <HASH>..<HASH> 100755
--- a/niworkflows/func/tests/test_util.py
+++ b/niworkflows/func/tests/test_util.py
@@ -54,6 +54,14 @@ if datapath:
parameters = zip(bold_datasets, exp_masks)
+ if not bold_datasets:
+ raise RuntimeError(
+ f"Data folder <{datapath}> was provided, but no images were found. "
+ "Folder contents:\n{}".format(
+ '\n'.join([str(p) for p in datapath.glob('ds*/*.nii.gz')])
+ )
+ )
+
def symmetric_overlap(img1, img2):
mask1 = load_img(img1).get_fdata() > 0
|
fix: test preamble, failing to discover data
|
poldracklab_niworkflows
|
train
|
py
|
d674263eb71e44c98ba357c943b3dbe204a25d11
|
diff --git a/pkg/disk/disk.go b/pkg/disk/disk.go
index <HASH>..<HASH> 100644
--- a/pkg/disk/disk.go
+++ b/pkg/disk/disk.go
@@ -43,8 +43,8 @@ func SameDisk(di1, di2 Info) bool {
return false
}
- // returns true only if Used, Free and number of free
- // inodes are same, then its the same disk.
- return di1.Used == di2.Used && di1.Free == di2.Free &&
- di1.Ffree == di2.Ffree
+ // returns true only if Used, Free are same, then its the same disk.
+ // we are deliberately not using free inodes as that is unreliable
+ // due the fact that Ffree can vary even for temporary files
+ return di1.Used == di2.Used && di1.Free == di2.Free
}
|
fix: remove inode free as part of SameDisk check (#<I>)
|
minio_minio
|
train
|
go
|
ccdc2ef2872321921912576e70375f77b854e2eb
|
diff --git a/lib/client.js b/lib/client.js
index <HASH>..<HASH> 100644
--- a/lib/client.js
+++ b/lib/client.js
@@ -122,7 +122,6 @@ class Client extends ClientBase {
const ret = new Duplex({
autoDestroy: true,
- writableHighWaterMark: 1,
read () {
if (body) {
body.resume()
|
fix: remove highwatermark override
|
mcollina_undici
|
train
|
js
|
aa8684a3567353c587cc97932ec7b4e4faa0103a
|
diff --git a/src/mixins/overlayable.js b/src/mixins/overlayable.js
index <HASH>..<HASH> 100644
--- a/src/mixins/overlayable.js
+++ b/src/mixins/overlayable.js
@@ -82,6 +82,8 @@ export default {
*/
scrollListener (e) {
if (e.type === 'keydown') {
+ if (['INPUT', 'TEXTAREA', 'SELECT'].includes(e.target.tagName)) return
+
const up = [38, 33]
const down = [40, 34]
|
fix: arrow up/down not working in inputs in dialog (#<I>)
fixes #<I>
|
vuetifyjs_vuetify
|
train
|
js
|
551cb33cbb5db7bc015cfdf231aa908cbbe7d554
|
diff --git a/lib/handlers/git/manifest.js b/lib/handlers/git/manifest.js
index <HASH>..<HASH> 100644
--- a/lib/handlers/git/manifest.js
+++ b/lib/handlers/git/manifest.js
@@ -11,20 +11,27 @@ const semver = require('semver')
module.exports = manifest
function manifest (spec, opts) {
opts = optCheck(opts)
- if (spec.hosted) {
+ if (spec.hosted && spec.spec === spec.hosted.shortcut) {
return hostedManifest(spec, opts)
} else {
+ // If it's not a shortcut, don't do fallbacks.
return plainManifest(spec.spec, spec, opts)
}
}
function hostedManifest (spec, opts) {
- return plainManifest(
- spec.hosted.gitUrl, spec, opts
- ).catch(() => {
- return plainManifest(spec.hosted.sshUrl, spec, opts)
- }).catch(() => {
+ return BB.resolve(null).then(() => {
return plainManifest(spec.hosted.httpsUrl, spec, opts)
+ }).catch(err => {
+ if (!spec.hosted.ssh) {
+ throw err
+ }
+ return plainManifest(spec.hosted.ssh, spec, opts)
+ }).catch(err => {
+ if (!spec.hosted.gitUrl) {
+ throw err
+ }
+ return plainManifest(spec.hosted.gitUrl, spec, opts)
})
}
|
fix(git): fix fallback order and only fall back on hosted shortcuts
|
zkat_pacote
|
train
|
js
|
4932617180a54ac6990bde00d16220e6269ac1fc
|
diff --git a/consumer_group.go b/consumer_group.go
index <HASH>..<HASH> 100644
--- a/consumer_group.go
+++ b/consumer_group.go
@@ -732,6 +732,9 @@ func (s *consumerGroupSession) heartbeatLoop() {
pause := time.NewTicker(s.parent.config.Consumer.Group.Heartbeat.Interval)
defer pause.Stop()
+ retryBackoff := time.NewTimer(s.parent.config.Metadata.Retry.Backoff)
+ defer retryBackoff.Stop()
+
retries := s.parent.config.Metadata.Retry.Max
for {
coordinator, err := s.parent.client.Coordinator(s.parent.groupID)
@@ -740,11 +743,11 @@ func (s *consumerGroupSession) heartbeatLoop() {
s.parent.handleError(err, "", -1)
return
}
-
+ retryBackoff.Reset(s.parent.config.Metadata.Retry.Backoff)
select {
case <-s.hbDying:
return
- case <-time.After(s.parent.config.Metadata.Retry.Backoff):
+ case <-retryBackoff.C:
retries--
}
continue
|
fix: ensure backoff timer is re-used
Unlikely to cause an issue in Sarama unless the user explicitly set
Metadata.Retry.Backoff especially high and was hitting lots of retry
conditions, but no harm in guarding against this.
Ref: <URL>
|
Shopify_sarama
|
train
|
go
|
9bb24c61b9082c745be75043f7668222df37b9be
|
diff --git a/source/rafcon/gui/mygaphas/items/state.py b/source/rafcon/gui/mygaphas/items/state.py
index <HASH>..<HASH> 100644
--- a/source/rafcon/gui/mygaphas/items/state.py
+++ b/source/rafcon/gui/mygaphas/items/state.py
@@ -889,6 +889,10 @@ class NameView(Element):
self._view = self.canvas.get_first_view()
return self._view
+ @property
+ def transparency(self):
+ return self.parent.transparency
+
def apply_meta_data(self):
name_meta = self.parent.model.get_meta_data_editor()['name']
# logger.info("name rel_pos {}".format(name_meta['rel_pos']))
@@ -965,7 +969,7 @@ class NameView(Element):
self._value_cache.store_value("font_size", font_size, font_size_parameters)
c.move_to(*self.handles()[NW].pos)
- c.set_source_rgba(*get_col_rgba(gui_config.gtk_colors['STATE_NAME'], self.parent.transparency))
+ c.set_source_rgba(*get_col_rgba(gui_config.gtk_colors['STATE_NAME'], self.transparency))
c.update_layout(layout)
c.show_layout(layout)
|
refactor(gaphas): Add transparency property to NameView
|
DLR-RM_RAFCON
|
train
|
py
|
bede7f4d57cdb889783ada5430bac635bd3bf4d8
|
diff --git a/test/helpers/common.js b/test/helpers/common.js
index <HASH>..<HASH> 100644
--- a/test/helpers/common.js
+++ b/test/helpers/common.js
@@ -7,6 +7,8 @@ var Readable = require('stream').Readable || require('readable-stream');
var Writable = require('stream').Writable || require('readable-stream').Writable;
function adjustDateByOffset(d, offset) {
+ d = (d instanceof Date) ? d : new Date();
+
if (offset >= 1) {
d.setMinutes(d.getMinutes() - offset);
} else {
|
test: quick fix to helper.
|
archiverjs_node-archiver
|
train
|
js
|
6c212ece31c1c359cd7806d6036f2644033ae1a8
|
diff --git a/test/unit/02-broker-component.js b/test/unit/02-broker-component.js
index <HASH>..<HASH> 100644
--- a/test/unit/02-broker-component.js
+++ b/test/unit/02-broker-component.js
@@ -7,6 +7,7 @@ describe("02 - unit - brokerage component", function() {
var mockModels = {};
var mockMesh = {
_mesh: {
+ disableSchemaPublish: () => {},
config: {
name: "mock"
}
|
test: fixed <I>-broker-component JIRA: SMC-<I>
|
happner_happner-cluster
|
train
|
js
|
46d7ac4487b04d00f9c3c1939aafce34d91f0196
|
diff --git a/core/src/ons/ons.js b/core/src/ons/ons.js
index <HASH>..<HASH> 100644
--- a/core/src/ons/ons.js
+++ b/core/src/ons/ons.js
@@ -436,5 +436,5 @@ function waitDeviceReady() {
}, false);
}
-window._super_secret_ons = ons;
+window._superSecretOns = ons;
export default ons;
|
style(ons): Rename variable.
|
OnsenUI_OnsenUI
|
train
|
js
|
97852af00ee159e154d41f34871813250d43f4ae
|
diff --git a/js/src/mesh.js b/js/src/mesh.js
index <HASH>..<HASH> 100644
--- a/js/src/mesh.js
+++ b/js/src/mesh.js
@@ -67,13 +67,15 @@ var MeshView = widgets.WidgetView.extend( {
this.textures = null
this.texture_video = document.createElement('video')
texture.stream.then(_.bind(function(stream) {
- this.texture_video.src = window.URL.createObjectURL(stream);
+ this.texture_video.srcObject = stream;
+ this.texture_video.play()
var texture = new THREE.VideoTexture(this.texture_video)
//texture.wrapS = THREE.RepeatWrapping;
//texture.wrapT = THREE.RepeatWrapping;
texture.minFilter = THREE.LinearFilter;
//texture.wrapT = THREE.RepeatWrapping;
this.textures = [texture];
+ this._update_materials()
this.update_()
}, this))
} else {
@@ -81,6 +83,7 @@ var MeshView = widgets.WidgetView.extend( {
return this.texture_loader.load(texture_url, _.bind(function(texture) {
texture.wrapS = THREE.RepeatWrapping;
texture.wrapT = THREE.RepeatWrapping;
+ this._update_materials()
this.update_()
}, this));
}, this)
|
fix: was using deprecated api for mediastream
|
maartenbreddels_ipyvolume
|
train
|
js
|
8cae770e4a5738487b77449f85d035591429deb5
|
diff --git a/gulp/tasks/release.js b/gulp/tasks/release.js
index <HASH>..<HASH> 100644
--- a/gulp/tasks/release.js
+++ b/gulp/tasks/release.js
@@ -33,7 +33,8 @@ gulp.task('release:commit', () => {
function updateVersion(type) {
return () => {
const [release, identifier] = type.split('-');
- const version = semver.inc(require(packagepath).version, release, identifier);
+ const prev = require(packagepath).version;
+ const version = semver.inc(prev, new RegExp(identifier).test(prev) ? 'prerelease' : release, identifier);
return gulp
.src(packagepath)
.pipe(bump({ version }))
|
chore(release): fix release task [ci skip]
|
suguru03_aigle
|
train
|
js
|
31cc0b04dabcc25190de11211dc5cd6253f32540
|
diff --git a/webapps/client/scripts/directives/processDiagram.js b/webapps/client/scripts/directives/processDiagram.js
index <HASH>..<HASH> 100644
--- a/webapps/client/scripts/directives/processDiagram.js
+++ b/webapps/client/scripts/directives/processDiagram.js
@@ -2,9 +2,7 @@
define([
'angular',
'jquery',
- 'text!./processDiagram.html',
- 'jquery-overscroll',
- 'jquery-mousewheel'
+ 'text!./processDiagram.html'
], function(angular, $, template) {
'use strict';
/* jshint unused: false */
|
chore(processDiagram): remove dependency on some jquery plugins
Related to CAM-<I>
|
camunda_camunda-bpm-platform
|
train
|
js
|
07b60a6bb42796e6f060730ce4bf22762942b0b8
|
diff --git a/lib/plugins/aws/deploy/lib/validateTemplate.js b/lib/plugins/aws/deploy/lib/validateTemplate.js
index <HASH>..<HASH> 100644
--- a/lib/plugins/aws/deploy/lib/validateTemplate.js
+++ b/lib/plugins/aws/deploy/lib/validateTemplate.js
@@ -2,6 +2,7 @@
const getCompiledTemplateS3Suffix = require('../../lib/naming').getCompiledTemplateS3Suffix;
const getS3EndpointForRegion = require('../../utils/getS3EndpointForRegion');
+const ServerlessError = require('../../../../serverless-error');
module.exports = {
async validateTemplate() {
@@ -18,7 +19,7 @@ module.exports = {
const errorMessage = ['The CloudFormation template is invalid:', ` ${error.message}`].join(
''
);
- throw new Error(errorMessage);
+ throw new ServerlessError(errorMessage, 'INVALID_AWS_CLOUDFORMATION_TEMPLATE');
});
},
};
|
fix: Expose template errror with user error
|
serverless_serverless
|
train
|
js
|
ac748d6b481765093d7663e6c291ec8b5fe24d2c
|
diff --git a/packages/core/src/mixins/source.js b/packages/core/src/mixins/source.js
index <HASH>..<HASH> 100644
--- a/packages/core/src/mixins/source.js
+++ b/packages/core/src/mixins/source.js
@@ -138,7 +138,7 @@ module.exports = mixin(
if (event === 'change' && data.isResource) {
this.emit('updated', data);
this._app.emit('source:updated', this, data);
- } else if (event === 'change' && data.isTemplate) {
+ } else if (event === 'change' && data.isTemplate && data.isView) {
// re-resolve context in case the changed template is used as fully rendered component in context
this._resolveTreeContext(this._fileTree).then(() => {
this.emit('updated', data);
|
fix: sync for docs (#<I>)
|
frctl_fractal
|
train
|
js
|
c57eea7f166d16979be32bfbe8ea25b286af1ace
|
diff --git a/.make-packages.js b/.make-packages.js
index <HASH>..<HASH> 100644
--- a/.make-packages.js
+++ b/.make-packages.js
@@ -20,7 +20,7 @@ const CJS_PKG = PKG_ROOT + '_cjs/';
const ESM5_PKG = PKG_ROOT + '_esm5/';
const ESM2015_PKG = PKG_ROOT + '_esm2015/';
const UMD_PKG = PKG_ROOT + 'bundles/';
-const TYPE_PKG = PKG_ROOT + '_typings/';
+const TYPE_PKG = PKG_ROOT;
// License info for minified files
@@ -35,7 +35,7 @@ let rootPackageJson = Object.assign({}, pkg, {
main: './_cjs/Rx.js',
module: './_esm5/Rx.js',
es2015: './_esm2015/Rx.js',
- typings: './_typings/Rx.d.ts'
+ typings: './Rx.d.ts'
});
// Read the files and create package.json files for each. This allows Node,
@@ -84,7 +84,6 @@ klawSync(CJS_ROOT, {
mkdirp.sync(PKG_ROOT);
// Copy over the sources
-copySources('src/', PKG_ROOT + 'src/');
copySources(CJS_ROOT, CJS_PKG);
copySources(ESM5_ROOT, ESM5_PKG);
copySources(ESM2015_ROOT, ESM2015_PKG);
|
fix(package): remove src directory and fix typings location (#<I>)
Related to #<I>
|
ReactiveX_rxjs
|
train
|
js
|
ab8829a2dcbdb9ab826d5a7fedae1c397e17ee51
|
diff --git a/lib/types/message.js b/lib/types/message.js
index <HASH>..<HASH> 100644
--- a/lib/types/message.js
+++ b/lib/types/message.js
@@ -8,7 +8,8 @@ var Int64 = require('node-int64'),
ForcedType = require('./forced_type'),
AMQPSymbol = require('./amqp_symbol'),
- u = require('../utilities');
+ u = require('../utilities'),
+ errors = require('../errors');
/**
*
@@ -198,6 +199,12 @@ module.exports.Properties = Properties;
*/
function ApplicationProperties(properties) {
ApplicationProperties.super_.call(this, ApplicationProperties, properties);
+
+ if (!(properties instanceof Object))
+ throw errors.MalformedPayloadError('invalid application properties: ', properties);
+
+ var _keys = Object.keys(properties), _len = _keys.length;
+ for (var i = 0; i < _len; ++i) this[_keys[i]] = properties[_keys[i]];
}
util.inherits(ApplicationProperties, DescribedType);
|
fix(application-properties): make properties accessible
|
noodlefrenzy_node-amqp10
|
train
|
js
|
050f8e4e5a046f51dbbbb1c07c40b39df812bddc
|
diff --git a/test/plugins.js b/test/plugins.js
index <HASH>..<HASH> 100644
--- a/test/plugins.js
+++ b/test/plugins.js
@@ -151,8 +151,8 @@ describe('plugins', function() {
assert.propertyVal(entries['executable.sh'], 'externalFileAttributes', 2180972576);
assert.equal((entries['executable.sh'].externalFileAttributes >>> 16) & 0xFFF, 511);
- assert.propertyVal(entries['directory/subdir/'], 'externalFileAttributes', 28704784);
- assert.equal((entries['directory/subdir/'].externalFileAttributes >>> 16) & 0xFFF, 438);
+ assert.propertyVal(entries['directory/subdir/'], 'externalFileAttributes', win32 ? 28704784 : 32309264 );
+ assert.equal((entries['directory/subdir/'].externalFileAttributes >>> 16) & 0xFFF, win32 ? 438 : 493);
});
it('should allow for entry comments', function() {
|
test: account for windows being crap for permissions testing.
|
archiverjs_node-archiver
|
train
|
js
|
8aa4c82c2821a54dae6b53a9762784a18169cc5c
|
diff --git a/setup.py b/setup.py
index <HASH>..<HASH> 100755
--- a/setup.py
+++ b/setup.py
@@ -11,7 +11,7 @@ if sys.version < "2.2.3":
# Workaround for problems caused by this import
# It's either this or hardcoding the version.
#from pyrax.version import version
-with file("pyrax/version.py") as vfile:
+with open("pyrax/version.py", "rt") as vfile:
version_text = vfile.read()
vmatch = re.search(r'version ?= ?"(.+)"$', version_text)
version = vmatch.groups()[0]
|
fix(setup): file() is deprecated. Use open.
|
pycontribs_pyrax
|
train
|
py
|
c0ddb23612fc0fe425dfcb2dda37f90ea2940363
|
diff --git a/src/sass.configure.path.js b/src/sass.configure.path.js
index <HASH>..<HASH> 100644
--- a/src/sass.configure.path.js
+++ b/src/sass.configure.path.js
@@ -10,7 +10,7 @@ var SASSJS_RELATIVE_PATH = (function() {
'use strict';
// in Node things are rather simple
- const hasDir = typeof __dirname !== 'undefined';
+ var hasDir = typeof __dirname !== 'undefined';
if (hasDir) {
return __dirname;
}
|
fix(sass): restore ES5 compatibility
PR #<I>
|
medialize_sass.js
|
train
|
js
|
0e51d8a94611d85d8d947ed093b9682e4b8cd48e
|
diff --git a/views/js/picCreator/dev/studentToolSample/runtime/studentToolSample.js b/views/js/picCreator/dev/studentToolSample/runtime/studentToolSample.js
index <HASH>..<HASH> 100644
--- a/views/js/picCreator/dev/studentToolSample/runtime/studentToolSample.js
+++ b/views/js/picCreator/dev/studentToolSample/runtime/studentToolSample.js
@@ -60,7 +60,7 @@ define(['taoQtiItem/portableLib/jquery_2_1_1', 'taoQtiItem/portableLib/lodash',
}));
//hook it into the toolbar:
- this.$toolbar = $('#'+this.config.toolbarId);
+ this.$toolbar = $container.closest('.qti-itemBody').find('#' + this.config.toolbarId);
this.$toolbar.find('.sts-content').append($container);
//setup hinting engine
|
fix: Render PIC icons to the toolbar in scope of given item
|
oat-sa_extension-tao-itemqti-pic
|
train
|
js
|
188334e64f9d9d7a7c1889dc5eb64c27e925077b
|
diff --git a/EditableColumn.php b/EditableColumn.php
index <HASH>..<HASH> 100644
--- a/EditableColumn.php
+++ b/EditableColumn.php
@@ -66,8 +66,13 @@ class EditableColumn extends DataColumn
*/
protected function renderDataCellContent($model, $key, $index)
{
-
$value = parent::renderDataCellContent($model, $key, $index);
+ $url = (array)$this->url;
+ $this->options['data-url'] = Url::to($url);
+ $this->options['data-pk'] = $key;
+ $this->options['data-name'] = $this->attribute;
+ $this->options['data-type'] = $this->type;
+
if (is_callable($this->editableOptions)) {
$opts = call_user_func($this->editableOptions, $model, $key, $index);
foreach ($opts as $prop => $v) {
@@ -79,12 +84,6 @@ class EditableColumn extends DataColumn
}
}
- $url = (array)$this->url;
- $this->options['data-url'] = Url::to($url);
- $this->options['data-pk'] = $key;
- $this->options['data-name'] = $this->attribute;
- $this->options['data-type'] = $this->type;
-
return Html::a($value, null, $this->options);
}
|
feat: allow to overwrite default options
editableOptions can overwrite default options. It is a must if you want to generate url and params for every column.
|
yii2mod_yii2-editable
|
train
|
php
|
eb504604fe7b6a95ff5d308e4ec32baa81043592
|
diff --git a/packages/components/data-table/src/data-table.story.js b/packages/components/data-table/src/data-table.story.js
index <HASH>..<HASH> 100644
--- a/packages/components/data-table/src/data-table.story.js
+++ b/packages/components/data-table/src/data-table.story.js
@@ -204,7 +204,7 @@ const ColumnConfigForm = (props) => {
const updatedColumn = {
...props.column,
width: values.width,
- align: values.align,
+ align: values.align === 'default' ? undefined : values.align,
isSortable: values.isSortable,
isTruncated: values.isTruncated,
disableResizing: values.disableResizing,
@@ -238,7 +238,7 @@ const ColumnConfigForm = (props) => {
onChange={formik.handleChange}
value={formik.values.align}
>
- <option value={undefined}>default</option>
+ <option value="default">default</option>
<option value="left">left</option>
<option value="center">center</option>
<option value="right">right</option>
|
fix: storybook data-table example (#<I>)
|
commercetools_ui-kit
|
train
|
js
|
d476da297eb9e4604c139d8a6735e536d710ce76
|
diff --git a/components/RefinementList.js b/components/RefinementList.js
index <HASH>..<HASH> 100644
--- a/components/RefinementList.js
+++ b/components/RefinementList.js
@@ -36,14 +36,13 @@ class RefinementList extends React.Component {
//
// So the code here checks if the click was done on or in a LABEL. If this LABEL
// has a checkbox inside, we ignore the first click event because we will get another one.
+ //
+ // We also check if the click was done inside a link and then e.preventDefault() because we already
+ // handle the url
+ //
+ // Finally, we always stop propagation of the event to avoid multiple levels RefinementLists to fail: click
+ // on child would click on parent also
handleClick(value, e) {
- if (e.target.tagName === 'A' && e.target.href) {
- // do not trigger any url change by the href
- e.preventDefault();
- // do not bubble (so that hierarchical lists are not triggering refine twice)
- e.stopPropagation();
- }
-
if (e.target.tagName === 'INPUT') {
this.refine(value);
return;
@@ -56,9 +55,15 @@ class RefinementList extends React.Component {
return;
}
+ if (parent.tagName === 'A' && parent.href) {
+ e.preventDefault();
+ }
+
parent = parent.parentNode;
}
+ e.stopPropagation();
+
this.refine(value);
}
|
fix(RefinementList): click on child should not click on parent
Before this fix, when clicking inside the child of a <a>..</a> would
propagate to the parent and thus in hierarchical facets would close the
parent as soon as we open the child.
fixes #<I>
|
algolia_instantsearch.js
|
train
|
js
|
cdcc22574037df687dc170b1a177347cc5ce1fdf
|
diff --git a/lib/v8-to-istanbul.js b/lib/v8-to-istanbul.js
index <HASH>..<HASH> 100644
--- a/lib/v8-to-istanbul.js
+++ b/lib/v8-to-istanbul.js
@@ -5,9 +5,14 @@ const { dirname, join } = require('path')
const CovBranch = require('./branch')
const CovFunction = require('./function')
const CovSource = require('./source')
-const { readFile } = require('fs').promises
+const compatError = Error(`requires Node.js ${require('../package.json').engines.node}`)
+let readFile = () => { throw compatError }
+try {
+ readFile = require('fs').promises.readFile
+} catch (_err) {
+ // most likely we're on an older version of Node.js.
+}
const { SourceMapConsumer } = require('source-map')
-
const isOlderNode10 = /^v10\.(([0-9]\.)|(1[0-5]\.))/u.test(process.version)
// Injected when Node.js is loading script into isolate pre Node 10.16.x.
|
fix: fs.promises was not introduced until <I> (#<I>)
|
istanbuljs_v8-to-istanbul
|
train
|
js
|
6155916ff2d032a604eb8f409e0ce611d6f1c84b
|
diff --git a/src/components/CodeSnippet/CodeSnippet.js b/src/components/CodeSnippet/CodeSnippet.js
index <HASH>..<HASH> 100644
--- a/src/components/CodeSnippet/CodeSnippet.js
+++ b/src/components/CodeSnippet/CodeSnippet.js
@@ -16,7 +16,7 @@ const CodeSnippet = ({
const wrapperClasses = classNames('bx--snippet', className, snippetType);
return (
<div className={wrapperClasses} {...other}>
- <div className="bx--snippet-container">
+ <div role="textbox" tabIndex={0} className="bx--snippet-container">
<code>
<pre ref={wrappedContentRef}>{children}</pre>
</code>
|
fix(code-snippet): fixed keyboard interactionm (#<I>)
|
carbon-design-system_carbon-components-react
|
train
|
js
|
1327ff22e9c694d5f21494d11132f502c327f4e6
|
diff --git a/lib/components/app/default-main-panel.js b/lib/components/app/default-main-panel.js
index <HASH>..<HASH> 100644
--- a/lib/components/app/default-main-panel.js
+++ b/lib/components/app/default-main-panel.js
@@ -26,7 +26,6 @@ class DefaultMainPanel extends Component {
<div style={{
bottom: showPlanTripButton ? 55 : 0,
left: 0,
- overflow: 'auto',
paddingBottom: 15,
position: 'absolute',
right: 0,
|
refactor(default-main-panel): remove overflow rule to support longer location search dropdown
|
opentripplanner_otp-react-redux
|
train
|
js
|
4aaf500c01eb7072379909eb71fe141688cbfa85
|
diff --git a/packages/vaex-core/vaex/utils.py b/packages/vaex-core/vaex/utils.py
index <HASH>..<HASH> 100644
--- a/packages/vaex-core/vaex/utils.py
+++ b/packages/vaex-core/vaex/utils.py
@@ -247,11 +247,13 @@ class Timer(object):
def get_vaex_home():
'''Get vaex home directory, defaults to $HOME/.vaex.
- The $VAEX_PATH_HOME environment variable can be set to override this default.
+ The $VAEX_HOME environment variable can be set to override this default.
- If both $VAEX_PATH_HOME and $HOME are not define, the current working directory is used.
+ If both $VAEX_HOME and $HOME are not define, the current working directory is used.
'''
- if 'VAEX_PATH_HOME' in os.environ:
+ if 'VAEX_HOME' in os.environ:
+ return os.environ['VAEX_HOME']
+ if 'VAEX_PATH_HOME' in os.environ: # for backwards compatibility
return os.environ['VAEX_PATH_HOME']
elif 'HOME' in os.environ:
return os.path.join(os.environ['HOME'], ".vaex")
|
fix: correct $VAEX_PATH_HOME -> $VAEX_PATH (#<I>)
For some reason we used $VAEX_PATH_HOME, while documented it as $VAEX_HOME
It should have been $VAEX_HOME. For backward compatibility we still
use $VAEX_PATH_HOME if is is set.
|
vaexio_vaex
|
train
|
py
|
9cc44c4984e62a52a93f26e180068ed9242f775a
|
diff --git a/js/ftx.js b/js/ftx.js
index <HASH>..<HASH> 100644
--- a/js/ftx.js
+++ b/js/ftx.js
@@ -2589,6 +2589,8 @@ module.exports = class ftx extends Exchange {
if (typeof address !== 'string') {
tag = this.safeString (address, 'tag');
address = this.safeString (address, 'address');
+ } else {
+ tag = this.safeString (transaction, 'tag');
}
if (address === undefined) {
// parse address from internal transfer
|
fix: parse tag for FTX withdrawals
|
ccxt_ccxt
|
train
|
js
|
343782270df8f4a6c50236d68581553d81554d97
|
diff --git a/src/lambda/handler-runner/worker-thread-runner/workerThreadHelper.js b/src/lambda/handler-runner/worker-thread-runner/workerThreadHelper.js
index <HASH>..<HASH> 100644
--- a/src/lambda/handler-runner/worker-thread-runner/workerThreadHelper.js
+++ b/src/lambda/handler-runner/worker-thread-runner/workerThreadHelper.js
@@ -2,10 +2,10 @@ import { env } from 'node:process'
import { parentPort, workerData } from 'node:worker_threads'
import InProcessRunner from '../in-process-runner/index.js'
-const { functionKey, handlerName, handlerPath } = workerData
+const { functionKey, handlerName, handlerPath, timeout } = workerData
parentPort.on('message', async (messageData) => {
- const { context, event, port, timeout } = messageData
+ const { context, event, port } = messageData
// TODO we could probably cache this in the module scope?
const inProcessRunner = new InProcessRunner(
|
fix: worker-runner timout option (#<I>)
|
dherault_serverless-offline
|
train
|
js
|
b6d4a0eea79f2e2ac1defbb9a0061610166153bc
|
diff --git a/src/filterRows.js b/src/filterRows.js
index <HASH>..<HASH> 100644
--- a/src/filterRows.js
+++ b/src/filterRows.js
@@ -55,6 +55,15 @@ function getFilterMethod(filter) {
.map(cell => cell.rowIndex);
},
+ equals(keyword, cells) {
+ return cells
+ .filter(cell => {
+ const value = parseFloat(cell.content);
+ return value === keyword;
+ })
+ .map(cell => cell.rowIndex);
+ },
+
range(rangeValues, cells) {
return cells
.filter(cell => {
@@ -100,6 +109,17 @@ function guessFilter(keyword = '') {
};
}
+ if (keyword.startsWith('=')) {
+ if (isNumber(keyword.slice(1))) {
+ return {
+ type: 'equals',
+ text: Number(keyword.slice(1).trim())
+ };
+ }
+
+ keyword = keyword.slice(1);
+ }
+
return {
type: 'contains',
text: keyword.toLowerCase()
|
feat: 🎸 Add = keyword for equality matching
Support = keyword for equality matching in numeric columns
|
frappe_datatable
|
train
|
js
|
65165b0a9c737fb478c7c4dec7dcb4ce65958e97
|
diff --git a/sample/src/samples/sample-runner.js b/sample/src/samples/sample-runner.js
index <HASH>..<HASH> 100644
--- a/sample/src/samples/sample-runner.js
+++ b/sample/src/samples/sample-runner.js
@@ -58,10 +58,15 @@ export class SampleRunner {
// if (this.instruction.configureRouter) {
// this.instruction.configureRouter(config, this.router);
// }
- resolve();
- // window.setTimeout(() => this.loading = false, 1500);
+
+ // resolve();
+ window.setTimeout(() => {
+ this.loading = false;
+ resolve();
+ }, 1500);
})
- .delay(800).then(() => this.loading = false);
+ // .delay(800)
+ .then(() => this.loading = false);
}
detached() {
|
chore(sample): fix delay without bluebird
|
aurelia-ui-toolkits_aurelia-materialize-bridge
|
train
|
js
|
77c183e15815baf9c06967b82d95c3c9ab546d8e
|
diff --git a/test/integration/test.discovery.js b/test/integration/test.discovery.js
index <HASH>..<HASH> 100644
--- a/test/integration/test.discovery.js
+++ b/test/integration/test.discovery.js
@@ -50,7 +50,7 @@ describe('discovery_integration', function() {
assert(Array.isArray(res.environments));
assert(res.environments.length);
const environment_ids = res.environments.map(e => e.environment_id);
- assert(environment_ids.includes(environment_id));
+ assert(environment_ids.indexOf(environment_id) > -1);
done();
});
});
|
test: make discovery test node 4 friendly
|
watson-developer-cloud_node-sdk
|
train
|
js
|
9670e2aab316f21d55e4642fb5a585d37c62f351
|
diff --git a/src/Framework/BaseConsoleApplication.php b/src/Framework/BaseConsoleApplication.php
index <HASH>..<HASH> 100644
--- a/src/Framework/BaseConsoleApplication.php
+++ b/src/Framework/BaseConsoleApplication.php
@@ -133,7 +133,7 @@ abstract class BaseConsoleApplication extends SilexApplication implements Framew
Envoi::init($envFilename, $metaFilename);
} else {
// Use standard Dotenv for loading variables
- $dotenv = new Dotenv();
+ $dotenv = new Dotenv(true);
$dotenv->load($envFilename);
}
}
|
refactor: code related envoi #<I> (#<I>)
|
Radvance_Radvance
|
train
|
php
|
6a5df18fa25516977ca71eae0609b9fb4bb9545d
|
diff --git a/lib/config.js b/lib/config.js
index <HASH>..<HASH> 100644
--- a/lib/config.js
+++ b/lib/config.js
@@ -306,11 +306,11 @@ exports.extend = function extend(newConf) {
client.on('error', function(err) {
req.emit('error', err);
});
- if (config.timeout > 0) {
- client.setTimeout(config.timeout, function() {
- client.destroy();
- });
- }
+// if (config.timeout > 0) {
+// client.setTimeout(config.timeout, function() {
+// client.destroy();
+// });
+// }
return client;
};
}
|
refactor: Set idle timeout for the connection
|
avwo_whistle
|
train
|
js
|
1f74392acfd415597555981d7df5c6489cb58da0
|
diff --git a/packages/node_modules/@webex/internal-plugin-conversation/src/conversation.js b/packages/node_modules/@webex/internal-plugin-conversation/src/conversation.js
index <HASH>..<HASH> 100644
--- a/packages/node_modules/@webex/internal-plugin-conversation/src/conversation.js
+++ b/packages/node_modules/@webex/internal-plugin-conversation/src/conversation.js
@@ -468,7 +468,15 @@ const Conversation = SparkPlugin.extend({
objectType: 'activity',
clientTempId: uuid.v4(),
actor: this.spark.internal.device.userId
- }, pick(activity, 'activityType', 'parentActivityId', 'parent'));
+ });
+
+ // Workaround because parent is a reserved props in Ampersand
+ if ((activity.parentActivityId && activity.activityType) || (activity.parent && activity.parent.id && activity.parent.type)) {
+ act.parent = {
+ id: activity.parentActivityId || activity.parent.id,
+ type: activity.activityType || activity.parent.type
+ };
+ }
if (isString(act.actor)) {
act.actor = {
|
fix(internal-conversation-plugin): parent reserved word issue
|
webex_spark-js-sdk
|
train
|
js
|
53bf1d5ff76a55a3ee9c5106a44554464b43a90e
|
diff --git a/test.js b/test.js
index <HASH>..<HASH> 100644
--- a/test.js
+++ b/test.js
@@ -79,8 +79,8 @@ it('should logging request of axios instance', () => axios.create()({
}))
it('should be able to set format of response & response logging', () => {
- const requestLogger = sinon.spy((debug, config) => debug(config.method))
- const responseLogger = sinon.spy((debug, response) => debug(response.statusText))
+ const requestLogger = sinon.spy((debug, config) => debug(config.method.toUpperCase()))
+ const responseLogger = sinon.spy((debug, response) => debug(response.statusText.toUpperCase()))
require('.')({
request: requestLogger,
response: responseLogger
|
test: uppercased method in test case.
ref: mzabriskie/axios@e4e<I>
|
Gerhut_axios-debug-log
|
train
|
js
|
fb100b165adbb00e6331ae0a5594f893da844d7c
|
diff --git a/src/path.js b/src/path.js
index <HASH>..<HASH> 100644
--- a/src/path.js
+++ b/src/path.js
@@ -10,7 +10,7 @@ process.cwd = () => '/';
* a few things we need for the browser environment.
*/
const nodePath = require('path');
-const filerPath = Object.create(nodePath);
+const filerPath = Object.assign({}, nodePath);
/**
* Patch path.basename() to return / vs. ''
|
refactor: use Object.assign instead of Object.create for cloning nodePath
because Object.keys omits many of the methods on the filerPath module when using Object.create
|
filerjs_filer
|
train
|
js
|
b1042496fd4b96244ab2a70169a490e0f92acd1f
|
diff --git a/src/utils.js b/src/utils.js
index <HASH>..<HASH> 100644
--- a/src/utils.js
+++ b/src/utils.js
@@ -231,7 +231,7 @@ function isScrollable(el) {
}
export function getScrollingParent(el) {
- if (!el) {
+ if (!(el instanceof HTMLElement)) {
return null;
} else if (isScrollable(el)) {
return el;
|
fix: issue with getComputedStyle and getScrollingParent
|
clauderic_react-sortable-hoc
|
train
|
js
|
110901f5e26fbc70f19ef43df95c24527432cd45
|
diff --git a/lib/utils/option-parser.js b/lib/utils/option-parser.js
index <HASH>..<HASH> 100644
--- a/lib/utils/option-parser.js
+++ b/lib/utils/option-parser.js
@@ -35,7 +35,7 @@ module.exports = function refineSql (sql, propertyIdToColumn, options) {
if (options) {
// WHERE
// -----
- if (Object.prototype.hasOwnProperty.call(options, 'where')) {
+ if (Object.prototype.hasOwnProperty.call(options, 'where') && Object.keys(options.where).length) {
sql += buildWhereClause(options.where, propertyIdToColumn, values)
}
|
fix: check where is not empty object
|
wmfs_pg-model
|
train
|
js
|
be88cb9ba00a706dc5402e0b5311975bb013972a
|
diff --git a/superset/dashboards/api.py b/superset/dashboards/api.py
index <HASH>..<HASH> 100644
--- a/superset/dashboards/api.py
+++ b/superset/dashboards/api.py
@@ -14,6 +14,7 @@
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
+# pylint: disable=too-many-lines
import json
import logging
from datetime import datetime
@@ -143,6 +144,7 @@ class DashboardRestApi(BaseSupersetModelRestApi):
"owners.username",
"owners.first_name",
"owners.last_name",
+ "owners.email",
"roles.id",
"roles.name",
]
|
feat: show user email in dashboard API (#<I>)
* Feat: show user email in dashboard API
* Fix test
|
apache_incubator-superset
|
train
|
py
|
1f906357b817d7ae92fb7a5230a3d04c35d35647
|
diff --git a/mistletoe/latex_renderer.py b/mistletoe/latex_renderer.py
index <HASH>..<HASH> 100644
--- a/mistletoe/latex_renderer.py
+++ b/mistletoe/latex_renderer.py
@@ -53,7 +53,9 @@ class LaTeXRenderer(BaseRenderer):
def render_raw_text(self, token, escape=True):
return (token.content.replace('$', '\\$').replace('#', '\\#')
.replace('{', '\\{').replace('}', '\\}')
- .replace('&', '\\&')).replace('_', '\\_') if escape else token.content
+ .replace('&', '\\&').replace('_', '\\_')
+ .replace('%', '\\%')
+ ) if escape else token.content
def render_heading(self, token):
inner = self.render_inner(token)
|
fix(latex-renderer): also escape `%` (#<I>)
|
miyuchina_mistletoe
|
train
|
py
|
e7d9e081cdc7fcf100e0346b1dcf0f7fdad7d889
|
diff --git a/lib/runner.js b/lib/runner.js
index <HASH>..<HASH> 100644
--- a/lib/runner.js
+++ b/lib/runner.js
@@ -265,7 +265,7 @@ var runTests = function() {
global.$ = browser.$;
global.$$ = browser.$$;
global.element = browser.element;
- global.by = protractor.By;
+ global.by = global.By = protractor.By;
// Do the framework setup here so that jasmine and mocha globals are
// available to the onPrepare function.
diff --git a/spec/basic/lib_spec.js b/spec/basic/lib_spec.js
index <HASH>..<HASH> 100644
--- a/spec/basic/lib_spec.js
+++ b/spec/basic/lib_spec.js
@@ -11,6 +11,7 @@ describe('protractor library', function() {
expect(protractor).toBeDefined();
expect(browser).toBeDefined();
expect(by).toBeDefined();
+ expect(By).toBeDefined();
expect(element).toBeDefined();
expect($).toBeDefined();
});
|
feat(global): export By (== by) on the global for use with coffeescript (or others who prefer it)
|
angular_protractor
|
train
|
js,js
|
8fa364901a1b8c00601e234ddd970f197e19a63f
|
diff --git a/src/lib/InstantSearch.js b/src/lib/InstantSearch.js
index <HASH>..<HASH> 100644
--- a/src/lib/InstantSearch.js
+++ b/src/lib/InstantSearch.js
@@ -6,7 +6,7 @@ import forEach from 'lodash/forEach';
import mergeWith from 'lodash/mergeWith';
import union from 'lodash/union';
import isPlainObject from 'lodash/isPlainObject';
-import { EventEmitter } from 'events';
+import EventEmitter from 'events';
import urlSyncWidget from './url-sync.js';
import version from './version.js';
import createHelpers from './createHelpers.js';
|
fix(main): correctly import EventEmitter (#<I>)
* fix(main): correctly import EventEmitter
fixes #<I>
I was bumping in this too now
* chore: update snapshot
* Revert "chore: update snapshot"
This reverts commit 5a<I>df<I>ac<I>a<I>c<I>c<I>b<I>c<I>e<I>.
|
algolia_instantsearch.js
|
train
|
js
|
9a9f59fcc6e7b93465ce9848b52a473477dff64a
|
diff --git a/src/Illuminate/Database/Eloquent/Model.php b/src/Illuminate/Database/Eloquent/Model.php
index <HASH>..<HASH> 100644
--- a/src/Illuminate/Database/Eloquent/Model.php
+++ b/src/Illuminate/Database/Eloquent/Model.php
@@ -990,6 +990,16 @@ abstract class Model implements Arrayable, ArrayAccess, Jsonable, JsonSerializab
}
/**
+ * Get all of the current attributes on the model for insert.
+ *
+ * @return array
+ */
+ protected function getAttributesForInsert()
+ {
+ return $this->getAttributes();
+ }
+
+ /**
* Perform a model insert operation.
*
* @param \Illuminate\Database\Eloquent\Builder $query
@@ -1011,7 +1021,7 @@ abstract class Model implements Arrayable, ArrayAccess, Jsonable, JsonSerializab
// If the model has an incrementing key, we can use the "insertGetId" method on
// the query builder, which will give us back the final inserted ID for this
// table from the database. Not all tables have to be incrementing though.
- $attributes = $this->getAttributes();
+ $attributes = $this->getAttributesForInsert();
if ($this->getIncrementing()) {
$this->insertAndSetId($query, $attributes);
|
refactor: extract attribute getter for insert.
|
laravel_framework
|
train
|
php
|
4b8de76e608340f033f54f98d1640fed41bd6680
|
diff --git a/webapps/webapp/src/test/js/e2e/cockpit/specs/dashboard-spec.js b/webapps/webapp/src/test/js/e2e/cockpit/specs/dashboard-spec.js
index <HASH>..<HASH> 100644
--- a/webapps/webapp/src/test/js/e2e/cockpit/specs/dashboard-spec.js
+++ b/webapps/webapp/src/test/js/e2e/cockpit/specs/dashboard-spec.js
@@ -132,7 +132,7 @@ describe('Cockpit Dashboard Spec', function() {
dashboardPage.navigateTo();
// then
- expect(dashboardPage.deployedDecisionsList.decisionCountHeader()).to.eventually.eql('2 decision table deployed');
+ expect(dashboardPage.deployedDecisionsList.decisionCountHeader()).to.eventually.eql('2 decision tables deployed');
expect(dashboardPage.deployedDecisionsList.decisionsList().count()).to.eventually.eql(2);
expect(dashboardPage.deployedDecisionsList.decisionName(0)).to.eventually.eql('invoice-approver');
});
|
fix(tests): expect correct grammar on dashboard
|
camunda_camunda-bpm-platform
|
train
|
js
|
5b55500b08e01339f463468d89794302881f2e2b
|
diff --git a/public/dashboard.js b/public/dashboard.js
index <HASH>..<HASH> 100644
--- a/public/dashboard.js
+++ b/public/dashboard.js
@@ -181,7 +181,6 @@ $(document).ready(() => {
.done(() => {
alert('Job successfully added!');
localStorage.removeItem('arena:savedJob');
- window.location.reload();
})
.fail((jqXHR) => {
window.alert('Failed to save job, check console for error.');
|
refactor(dashboard): delete window location reload
|
bee-queue_arena
|
train
|
js
|
558b024c5b5a6b7f6c7627679a5e4642b4e399f6
|
diff --git a/packages/utils/src/lambdaHandler.js b/packages/utils/src/lambdaHandler.js
index <HASH>..<HASH> 100644
--- a/packages/utils/src/lambdaHandler.js
+++ b/packages/utils/src/lambdaHandler.js
@@ -1,8 +1,8 @@
import log from './log';
-const logEvent = log('Event');
-const logResult = log('Result');
-const logError = log('Error');
+const logEvent = event => log('Event', event);
+const logResult = result => log('Result', result);
+const logError = error => log('Error', error);
const logAndSucceed = (data, callback) => {
logResult(data);
|
fix(utils): fix lambdaHandler using the old curried version of log
affects: @goldwasserexchange/utils
|
goldwasserexchange_public
|
train
|
js
|
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.