hash
stringlengths
40
40
diff
stringlengths
172
2.63k
message
stringlengths
12
593
project
stringlengths
7
65
split
stringclasses
1 value
diff_languages
stringclasses
54 values
8243490f9af4ff602a1426fc105776f0e9c9a942
diff --git a/packages/api/middleware/native/http.js b/packages/api/middleware/native/http.js index <HASH>..<HASH> 100644 --- a/packages/api/middleware/native/http.js +++ b/packages/api/middleware/native/http.js @@ -1,7 +1,7 @@ const jwt = require('jsonwebtoken') const Client = require('cubic-client') const Cookies = require('cookies') -const Authentication = require('../../../auth/endpoints/authenticate') +const Authentication = require('cubic-auth/endpoints/authenticate') class ExpressMiddleware { constructor (config) {
fix(api): fixed wrong require
cubic-js_cubic
train
js
f276423c5bf42c05ca70b65c34f971e70a04e001
diff --git a/tests/test_configuration.py b/tests/test_configuration.py index <HASH>..<HASH> 100644 --- a/tests/test_configuration.py +++ b/tests/test_configuration.py @@ -96,6 +96,24 @@ def test_tox_generative_environments_has_common_definition(): assert tox_environments == tox_ini +def test_single_line_settings_are_written_same_line(): + """Single line tox settings should be written on the same line.""" + single_line_settings = [ + "isolated_build", + "basepython", + "skip_install", + "install_command", + ] + + ini_parser = configparser.ConfigParser() + ini_parser.read("tox.ini") + for section in ini_parser.values(): + for setting in single_line_settings: + value = section.get(setting) + if value is not None: + assert not value.startswith("\n") + + def test_tox_multiline_settings_are_written_next_line(): """Multiline tox settings should be written starting next line.""" multiline_settings = [
test: single line tox settings should be written on the same line
dry-python_dependencies
train
py
f8616ed54b9146a7e360035941c1aeb653a5737d
diff --git a/lib/PipeTransport.js b/lib/PipeTransport.js index <HASH>..<HASH> 100644 --- a/lib/PipeTransport.js +++ b/lib/PipeTransport.js @@ -13,7 +13,7 @@ * See the License for the specific language governing permissions and * limitations under the License. */ -const {helper} = require('./helper'); +const {helper, debugError} = require('./helper'); /** * @implements {!Puppeteer.ConnectionTransport} @@ -31,7 +31,9 @@ class PipeTransport { helper.addEventListener(pipeRead, 'close', () => { if (this.onclose) this.onclose.call(null); - }) + }), + helper.addEventListener(pipeRead, 'error', debugError), + helper.addEventListener(pipeWrite, 'error', debugError), ]; this.onmessage = null; this.onclose = null;
fix(pipe): handle 'error' events on pipes to avoid crashing (#<I>) Fix #<I>
GoogleChrome_puppeteer
train
js
784b28f4b53bd183e26a25ddf8594f6f73b0a974
diff --git a/docs/lib/url_generator.js b/docs/lib/url_generator.js index <HASH>..<HASH> 100644 --- a/docs/lib/url_generator.js +++ b/docs/lib/url_generator.js @@ -54,17 +54,18 @@ function validateExternalUrl (href, source) { return request(href) .then((html) => { + return // bail if we dont have a hash - if (!hash) { - return - } - - assertHashIsPresent(href, source, hash, html) - }) - .catch(errors.StatusCodeError, (err) => { - err.message = `Request to: ${href} failed. (Status Code ${err.statusCode})` - throw err + // if (!hash) { + // return + // } + // + // assertHashIsPresent(href, source, hash, html) }) + // .catch(errors.StatusCodeError, (err) => { + // err.message = `Request to: ${href} failed. (Status Code ${err.statusCode})` + // throw err + // }) } function normalizeNestedPaths (data) {
docs: comment out external url validation until url linking strategy is more thoroughly discussed
cypress-io_cypress
train
js
e02564c42b23f38da792f7169c559c7f15b17cab
diff --git a/p2p/host/peerstore/pstoreds/ds_test.go b/p2p/host/peerstore/pstoreds/ds_test.go index <HASH>..<HASH> 100644 --- a/p2p/host/peerstore/pstoreds/ds_test.go +++ b/p2p/host/peerstore/pstoreds/ds_test.go @@ -33,8 +33,6 @@ func TestDsPeerstore(t *testing.T) { func TestDsAddrBook(t *testing.T) { for name, dsFactory := range dstores { t.Run(name+" Cacheful", func(t *testing.T) { - t.Parallel() - opts := DefaultOpts() opts.GCPurgeInterval = 1 * time.Second opts.CacheSize = 1024 @@ -43,8 +41,6 @@ func TestDsAddrBook(t *testing.T) { }) t.Run(name+" Cacheless", func(t *testing.T) { - t.Parallel() - opts := DefaultOpts() opts.GCPurgeInterval = 1 * time.Second opts.CacheSize = 0
test: don't run datastore tests in parallel We have timing dependencies in some of these tests.
libp2p_go-libp2p
train
go
b3c6833e9993ae887d272798a8e93bea379fa128
diff --git a/src/lib/add-attrs.js b/src/lib/add-attrs.js index <HASH>..<HASH> 100644 --- a/src/lib/add-attrs.js +++ b/src/lib/add-attrs.js @@ -1,10 +1,11 @@ +import Vue from 'vue' + export default function addAttrs (vm, attrs) { - const consoleWarnSave = console.error - console.error = () => {} + Vue.config.silent = true if (attrs) { vm.$attrs = attrs } else { vm.$attrs = {} } - console.error = consoleWarnSave + Vue.config.silent = false } diff --git a/src/lib/add-listeners.js b/src/lib/add-listeners.js index <HASH>..<HASH> 100644 --- a/src/lib/add-listeners.js +++ b/src/lib/add-listeners.js @@ -1,10 +1,11 @@ +import Vue from 'vue' + export default function addListeners (vm, listeners) { - const consoleWarnSave = console.error - console.error = () => {} + Vue.config.silent = true if (listeners) { vm.$listeners = listeners } else { vm.$listeners = {} } - console.error = consoleWarnSave + Vue.config.silent = false }
refactor: set Vue to silent when adding listeners closes #<I>
vuejs_vue-test-utils
train
js,js
6995fa1ff1f5161e550ef952dc5ac0012afdccc0
diff --git a/test/fast_forward_test.go b/test/fast_forward_test.go index <HASH>..<HASH> 100644 --- a/test/fast_forward_test.go +++ b/test/fast_forward_test.go @@ -44,10 +44,15 @@ func TestFastForwardBasic(t *testing.T) { // Wait for the background update to fetch the head. waitForStalledMDGetForTLF(), unstallOneMDGetForTLF(), + // Disable updates as a hack to make sure we wait for + // the fast foward to complete (the unpause channel + // isn't buffered). + disableUpdates(), ), ), as(bob, noSync(), undoStallOnMDGetForTLF(), + reenableUpdatesNoSync(), // Make sure the next sync only calls GetRange once. stallOnMDGetRange(), ),
test: wait for fast-forwarding to complete Issue: KBFS-<I>
keybase_client
train
go
323887e9f3ddd3bcd6db7147de5c716af2cc19fe
diff --git a/packages/puppeteer-extra-plugin-stealth/index.js b/packages/puppeteer-extra-plugin-stealth/index.js index <HASH>..<HASH> 100644 --- a/packages/puppeteer-extra-plugin-stealth/index.js +++ b/packages/puppeteer-extra-plugin-stealth/index.js @@ -80,7 +80,7 @@ class StealthPlugin extends PuppeteerExtraPlugin { get defaults() { const availableEvasions = new Set([ - 'accept-language', + // 'accept-language', // Temp disabled: see issue #91 'chrome.runtime', 'console.debug', 'iframe.contentWindow',
chore(plugin-stealth): Temp disable accept-language (#<I>)
berstend_puppeteer-extra
train
js
a080ce3e3622c2c036abba4b8d370702971f3117
diff --git a/src/client/transport/local.js b/src/client/transport/local.js index <HASH>..<HASH> 100644 --- a/src/client/transport/local.js +++ b/src/client/transport/local.js @@ -210,7 +210,7 @@ export function Local(opts) { return transportOpts => { let master; - if (localMasters.has(transportOpts.gameKey)) { + if (localMasters.has(transportOpts.gameKey) & !opts) { master = localMasters.get(transportOpts.gameKey); } else { master = new LocalMaster({
fix: #<I> (#<I>)
nicolodavis_boardgame.io
train
js
5e62ec7503e649c99fd42e02b0023fd44e31857d
diff --git a/sentry_sdk/utils.py b/sentry_sdk/utils.py index <HASH>..<HASH> 100644 --- a/sentry_sdk/utils.py +++ b/sentry_sdk/utils.py @@ -169,20 +169,15 @@ def get_lines_from_file(filename, lineno, loader=None, module=None): upper_bound = min(lineno + 1 + context_lines, len(source)) try: - pre_context = [line.strip("\r\n") for line in source[lower_bound:lineno]] - context_line = source[lineno].strip("\r\n") + pre_context = [slim_string(line.strip("\r\n")) for line in source[lower_bound:lineno]] + context_line = slim_string(source[lineno].strip("\r\n")) post_context = [ - line.strip("\r\n") for line in source[(lineno + 1) : upper_bound] + slim_string(line.strip("\r\n")) for line in source[(lineno + 1) : upper_bound] ] + return pre_context, context_line, post_context except IndexError: # the file may have changed since it was loaded into memory - return None, None, None - - return ( - slim_string(pre_context), - slim_string(context_line), - slim_string(post_context), - ) + return [], None, [] def get_source_context(frame):
chore: adapt output s.t. jan has less work
getsentry_sentry-python
train
py
81fa9af7497626fdad5d78f6afb7f54b4a39652e
diff --git a/lib/response.js b/lib/response.js index <HASH>..<HASH> 100644 --- a/lib/response.js +++ b/lib/response.js @@ -71,7 +71,7 @@ class Response { * @param {string} type - MIME type of the response data */ type(type) { - this.header('Content-Type', type); + this.header('content-type', type); return this; } }
refactor: Use lowercase key in content-type helper method
godmodelabs_flora
train
js
096a79914527467eecfcf1a7974509c4d7ffd08f
diff --git a/config/webpack.common.js b/config/webpack.common.js index <HASH>..<HASH> 100644 --- a/config/webpack.common.js +++ b/config/webpack.common.js @@ -245,7 +245,7 @@ module.exports = { */ new HtmlWebpackPlugin({ template: 'src/index.html', - chunksSortMode: helpers.packageSort(['polyfills', 'vendor', 'main']) + chunksSortMode: 'dependency' }) ],
chore(webpack): simplify HtmlWebpackPlugin options (#<I>)
inchingorg_xdata-web
train
js
d35b6733237acb554c640924ece340a5f3b6fcba
diff --git a/lib/platform/github/storage.js b/lib/platform/github/storage.js index <HASH>..<HASH> 100644 --- a/lib/platform/github/storage.js +++ b/lib/platform/github/storage.js @@ -151,6 +151,8 @@ class Storage { { branch: branchName }, 'Branch to delete does not exist' ); + } else if (err.message.startsWith('Cannot delete protected branch')) { + logger.info({ branch: branchName }, 'Cannot delete protected branch'); } else { logger.warn({ err, branch: branchName }, 'Error deleting branch'); }
refactor(github): don’t warn deleting protected branch
renovatebot_renovate
train
js
7bdcb48daf68e746681e3835b41a153e4c48fcc3
diff --git a/model/repository/MonitoringRepository.php b/model/repository/MonitoringRepository.php index <HASH>..<HASH> 100644 --- a/model/repository/MonitoringRepository.php +++ b/model/repository/MonitoringRepository.php @@ -482,8 +482,7 @@ class MonitoringRepository extends ConfigurableService implements DeliveryMonito } else { $colName = sprintf('t.%s -> \'%s\'', self::COLUMN_EXTRA_DATA, $colName); } - $this->queryParams[] = $colName; - $sortingColumn = '?'; + $sortingColumn = $colName; } else { $sortingColumn = $ruleParts[1]; }
fix: remove inserting `extra_data` field sorting by as query parameter
oat-sa_extension-tao-proctoring
train
php
cb1d3b34b75c91c9875caa90f6888cf65b03f86c
diff --git a/test/k8sT/Services.go b/test/k8sT/Services.go index <HASH>..<HASH> 100644 --- a/test/k8sT/Services.go +++ b/test/k8sT/Services.go @@ -567,7 +567,9 @@ var _ = SkipDescribeIf(helpers.RunsOn54Kernel, "K8sServicesTest", func() { }) }) - Context("Checks service across nodes", func() { + SkipContextIf(func() bool { + return helpers.SkipQuarantined() && helpers.RunsOnNetNextKernel() + }, "Checks service across nodes", func() { var ( demoYAML string
test: Quarantine K8sServicesTest Checks service across nodes on net-next This test has been unreliable for some time: - <URL>
cilium_cilium
train
go
06883effc62c67e10cbd60619e7a14793ceab17a
diff --git a/index.js b/index.js index <HASH>..<HASH> 100644 --- a/index.js +++ b/index.js @@ -455,8 +455,8 @@ class CrawlKit { delete task.result.error; q.unshift(task); } - workerFinished(err); stopWorkerTimer(); + workerFinished(err); }); }, '', 'm', (workerRuntime) => { workerInfo('Finished. Took %sms.', workerRuntime);
fix: stop the timer before ending the timer
crawlkit_crawlkit
train
js
3e04149464973278d62d2b1647f59e36586c31fa
diff --git a/src/js/util/animation.js b/src/js/util/animation.js index <HASH>..<HASH> 100644 --- a/src/js/util/animation.js +++ b/src/js/util/animation.js @@ -86,7 +86,8 @@ export function animate(element, animation, duration = 200, origin, out) { addClass(element, animation, animationPrefix + (out ? 'leave' : 'enter')); if (startsWith(animation, animationPrefix)) { - addClass(element, origin && `uk-transform-origin-${origin}`, out && `${animationPrefix}reverse`); + origin && addClass(element, `uk-transform-origin-${origin}`); + out && addClass(element, `${animationPrefix}reverse`); } })
fix: animation adds `false` and `undefined` as class
uikit_uikit
train
js
6acd88860968444d85228b7acbab16c35f06bdb1
diff --git a/src/Charcoal/Email/EmailQueueItem.php b/src/Charcoal/Email/EmailQueueItem.php index <HASH>..<HASH> 100644 --- a/src/Charcoal/Email/EmailQueueItem.php +++ b/src/Charcoal/Email/EmailQueueItem.php @@ -254,15 +254,15 @@ class EmailQueueItem extends AbstractModel implements QueueItemInterface try { $result = $email->send(); - $this->setStatus(($result) ? self::SUCCESS_STATUS : self::FAILED_STATUS); + $this->setStatus(($result) ? self::STATUS_SUCCESS : self::STATUS_FAILED); } catch (EmailNotSentException $e) { $this->logProcessingException($e); - $this->setStatus(self::RETRY_STATUS); + $this->setStatus(self::STATUS_RETRY); $result = false; } catch (Exception $e) { $this->logProcessingException($e); - $this->setStatus(self::FAILED_STATUS); + $this->setStatus(self::STATUS_FAILED); $result = false; }
refactor(queue-item-interface): rename status constants
locomotivemtl_charcoal-email
train
php
28555b114fc3db947dd76ef92b66c4f4c60a71fe
diff --git a/packages/webiny-app/src/plugins/fileUploaderPlugin.js b/packages/webiny-app/src/plugins/fileUploaderPlugin.js index <HASH>..<HASH> 100644 --- a/packages/webiny-app/src/plugins/fileUploaderPlugin.js +++ b/packages/webiny-app/src/plugins/fileUploaderPlugin.js @@ -20,7 +20,7 @@ export default (config: Object = {}): FileUploaderPlugin => ({ }); return await new Promise((resolve, reject) => { - const formData = new window.CreateFormData(); + const formData = new window.FormData(); Object.keys(presignedPostPayload.data.s3.fields).forEach(key => { formData.append(key, presignedPostPayload.data.s3.fields[key]); });
fix: undo accidental find / replace (blame storm)
Webiny_webiny-js
train
js
8ec304755a3a8d1ae3d86da688c81b658d8158d3
diff --git a/cypress/plugins/index.js b/cypress/plugins/index.js index <HASH>..<HASH> 100644 --- a/cypress/plugins/index.js +++ b/cypress/plugins/index.js @@ -0,0 +1,3 @@ +module.exports = function () { + // configure plugins here +};
fix: cypress plugins
marmelab_gremlins.js
train
js
12f37ddbe5a77cffcf97d044d59cf2a3a4b44c1b
diff --git a/src/homeAssistant/Websocket.js b/src/homeAssistant/Websocket.js index <HASH>..<HASH> 100644 --- a/src/homeAssistant/Websocket.js +++ b/src/homeAssistant/Websocket.js @@ -66,8 +66,8 @@ class Websocket { const auth = { type: 'auth', - [this.config.legacy ? 'api_password' : 'access_token']: this.config - .apiPass, + [this.config.legacy ? 'api_password' : 'access_token']: + this.config.apiPass, }; this.client = await createConnection({ @@ -76,8 +76,8 @@ class Websocket { auth, connectionDelay: this.config.connectionDelay, eventBus: this.eventBus, - rejectUnauthorizedCerts: this.config - .rejectUnauthorizedCerts, + rejectUnauthorizedCerts: + this.config.rejectUnauthorizedCerts, url, }), }).catch((e) => { @@ -354,9 +354,11 @@ class Websocket { } async updateTagList() { - this.tags = await this.client.sendMessagePromise({ - type: 'tag/list', - }); + try { + this.tags = await this.send({ + type: 'tag/list', + }); + } catch (e) {} } getIntegrationVersion() {
fix: Handle promise rejection when user doesn't have tags component enabled in HA
zachowj_node-red-contrib-home-assistant-websocket
train
js
6b0c3f9fd09bc3329f9b3453794386612a96a7e8
diff --git a/src/gatsby-node.js b/src/gatsby-node.js index <HASH>..<HASH> 100644 --- a/src/gatsby-node.js +++ b/src/gatsby-node.js @@ -32,6 +32,7 @@ export function onCreateWebpackConfig( printRejected: false, printAll: false, debug: false, + develop: false, ignore: [], ...userOptions }; @@ -40,8 +41,12 @@ export function onCreateWebpackConfig( stats.printStats(); } - if (stage !== 'build-javascript') { + if (stage === 'develop-html' || stage === 'build-html') { return; + } else if (stage === 'develop') { + if (!userOptions.develop) { + return; + } } const { setWebpackConfig } = actions;
feat: Add running on develop using `develop` option
anantoghosh_gatsby-plugin-purgecss
train
js
a6b1dad06190bc10930835caefaacfb4e8967a8f
diff --git a/packages/cli/commands/upgrade/index.js b/packages/cli/commands/upgrade/index.js index <HASH>..<HASH> 100644 --- a/packages/cli/commands/upgrade/index.js +++ b/packages/cli/commands/upgrade/index.js @@ -1,5 +1,6 @@ const upgrades = require("./upgrades"); const { red } = require("chalk"); +const execa = require("execa"); module.exports = [ upgrades, @@ -18,6 +19,29 @@ module.exports = [ }); }, async argv => { + // Before doing any upgrading, there must not be any active changes in the current branch. + let gitStatus = ""; + try { + let { stdout } = execa.sync("git", ["status", "--porcelain"]); + gitStatus = stdout.trim(); + } catch {} + + if (gitStatus) { + console.error( + red("This git repository has untracked files or uncommitted changes:") + + "\n\n" + + gitStatus + .split("\n") + .map(line => line.match(/ .*/g)[0].trim()) + .join("\n") + + "\n\n" + + red( + "Remove untracked files, stash or commit any changes, and try again." + ) + ); + process.exit(1); + } + const plugin = context.plugins .byType("cli-upgrade") .find(plugin => plugin.version === argv.targetVersion);
fix: add everything-committed check
Webiny_webiny-js
train
js
4ec5207e800b6c7e9541a46b98c8d669450a1ce1
diff --git a/lib/db/cortex.php b/lib/db/cortex.php index <HASH>..<HASH> 100644 --- a/lib/db/cortex.php +++ b/lib/db/cortex.php @@ -3208,8 +3208,8 @@ class CortexCollection extends \ArrayIterator { $val = $model->get($prop, $raw); if (!empty($val)) $out[] = $val; - } elseif($raw) - $out[] = is_array($model) ? $model[$prop] : $model; + } elseif($raw && is_array($model) && !empty($model[$prop])) + $out[] = $model[$prop]; } return $out; }
fix: getAll property on non-existing fields
ikkez_f3-cortex
train
php
6afd50fac333183994f8c04d7da1f73553cc0f4b
diff --git a/react/MuiCozyTheme/makeOverrides.js b/react/MuiCozyTheme/makeOverrides.js index <HASH>..<HASH> 100644 --- a/react/MuiCozyTheme/makeOverrides.js +++ b/react/MuiCozyTheme/makeOverrides.js @@ -631,7 +631,7 @@ const makeOverrides = theme => ({ // To keep muiV3 behavior // TODO check later if we need this behavior - '& > :not(:first-child):not(:first-child)': { + '&:not(.columnLayout) > :not(:first-child):not(:first-child)': { marginLeft: 4 } }
fix(CozyDialogs): Remove margin on action buttons for column layout
cozy_cozy-ui
train
js
b6c00fb9bc9445098568392a28166be88b403b0f
diff --git a/packages/create-razzle-app/lib/index.js b/packages/create-razzle-app/lib/index.js index <HASH>..<HASH> 100644 --- a/packages/create-razzle-app/lib/index.js +++ b/packages/create-razzle-app/lib/index.js @@ -21,9 +21,6 @@ const razzlePkg = `razzle${branch == 'master' ? '' : '@' + branch}`; const officialExamplesApiUrl = `https://api.github.com/repos/jaredpalmer/razzle/contents/examples${branch == 'master' ? '' : '?ref=' + branch}`; -const branch = 'next-awesome'; // this line auto updates when yarn update-examples is run -const razzlePkg = `razzle${branch == 'canary' ? '@' + branch : ''}`; - const getOfficialExamples = () => { if (typeof process.env.CI === 'undefined') { return axios
fix(create-razzle-app): fixed a merge conflict
jaredpalmer_razzle
train
js
231bd42b87ab30c9742f693aff9d0c6fe9b6cdb3
diff --git a/packages/avatar/src/react/styles.js b/packages/avatar/src/react/styles.js index <HASH>..<HASH> 100644 --- a/packages/avatar/src/react/styles.js +++ b/packages/avatar/src/react/styles.js @@ -63,7 +63,7 @@ const initials = ({ name }) => flexDirection: 'column', justifyContent: 'center', color: core.colors.white, - fontWeight: core.type.fontWeightXLight, + fontWeight: core.type.fontWeightBook, backgroundColor: getColorByName(name) || core.colors.bone })
feat(avatar): change initials font-weight to book
pluralsight_design-system
train
js
a0a8f6edadcf73486fa6485e89951355eaca217f
diff --git a/packages/card/src/styledComponents/Card.js b/packages/card/src/styledComponents/Card.js index <HASH>..<HASH> 100644 --- a/packages/card/src/styledComponents/Card.js +++ b/packages/card/src/styledComponents/Card.js @@ -25,6 +25,7 @@ const Card = styled.div` padding: ${padding}; box-sizing: border-box; border-radius: 4px; + overflow: hidden; `; export default Card;
feat(Card): add a CSS property to prevent children component to overflow its background affects: @crave/farmblocks-card
CraveFood_farmblocks
train
js
70997e7292c5292c3b7038617e341e85d79d1481
diff --git a/example/index.js b/example/index.js index <HASH>..<HASH> 100644 --- a/example/index.js +++ b/example/index.js @@ -35,7 +35,8 @@ db.installUsersBehavior().then(function () { server.register({ register: hapiAccount, options: { - usersDb: db + usersDb: db, + secret: 'NOT SO SECRET' }, routes: { prefix: '/hoodie/account/api'
test: add secret so signIn will work
hoodiehq-archive_hoodie-account
train
js
279d6208222298f9a39d9ca7afd39a9a4f33791d
diff --git a/ignite/contrib/handlers/tqdm_logger.py b/ignite/contrib/handlers/tqdm_logger.py index <HASH>..<HASH> 100644 --- a/ignite/contrib/handlers/tqdm_logger.py +++ b/ignite/contrib/handlers/tqdm_logger.py @@ -161,7 +161,7 @@ class ProgressBar(BaseLogger): def attach( # type: ignore[override] self, engine: Engine, - metric_names: Optional[str] = None, + metric_names: Optional[Union[str, List[str]]] = None, output_transform: Optional[Callable] = None, event_name: Union[Events, CallableEventWithFilter] = Events.ITERATION_COMPLETED, closing_event_name: Union[Events, CallableEventWithFilter] = Events.EPOCH_COMPLETED,
fix: Corrects type hint for ProgressBar (#<I>)
pytorch_ignite
train
py
df75f6ecc43c79a0a50a1683b602e73f5047d477
diff --git a/test/test_project.py b/test/test_project.py index <HASH>..<HASH> 100644 --- a/test/test_project.py +++ b/test/test_project.py @@ -2,16 +2,7 @@ import os import unittest - class ProjectTests(unittest.TestCase): - # ./docker - def test_docker_dir(self): - self.assertTrue(os.path.isfile("./docker/Dockerfile")) - - # ./docker-compose.yml or ./docker/docker-compose.yml - def test_docker_compose(self): - self.assertTrue(os.path.isfile('./docker/docker-compose.yml')) - # ./.env_sample def test_env(self): self.assertTrue(os.path.isfile('./.env_sample'))
fix: drop the silly docker file tests
sendgrid_sendgrid-python
train
py
688d4154b38e2c051b1b7c433f01624442d936a4
diff --git a/packages/blueprint-sequelize/app/services/sequelize.js b/packages/blueprint-sequelize/app/services/sequelize.js index <HASH>..<HASH> 100644 --- a/packages/blueprint-sequelize/app/services/sequelize.js +++ b/packages/blueprint-sequelize/app/services/sequelize.js @@ -190,7 +190,8 @@ module.exports = Service.extend ({ }, seedConnection (name, conn, clear) { - const { clearBeforeSeeding = [] } = clear; + if (!!clear && clear === 'true') + clear = []; // When seeding a connection, we always build a new data model. This // is because we need to generate new ids for all model elements.
fix: always cleared the database, even when false
onehilltech_blueprint
train
js
64fd0ccb0036237b2eec32a38163607eedce4936
diff --git a/docs/src/examples.js b/docs/src/examples.js index <HASH>..<HASH> 100644 --- a/docs/src/examples.js +++ b/docs/src/examples.js @@ -21,7 +21,7 @@ routesConfig.push({ component: DemoList }); const router = new VueRouter({ - mode: 'history', + mode: 'hash', base: '/zanui/vue/examples', routes: routesConfig }); diff --git a/docs/src/index.js b/docs/src/index.js index <HASH>..<HASH> 100644 --- a/docs/src/index.js +++ b/docs/src/index.js @@ -15,7 +15,7 @@ routesConfig.push({ }); const router = new VueRouter({ - mode: 'history', + mode: 'hash', base: '/zanui/vue/', routes: routesConfig });
feat: change doc router mode to hash (#<I>)
youzan_vant
train
js,js
86bf8bf2c3ecb65d278ff657db89e04a80a1b882
diff --git a/lib/util/http-mgr.js b/lib/util/http-mgr.js index <HASH>..<HASH> 100644 --- a/lib/util/http-mgr.js +++ b/lib/util/http-mgr.js @@ -136,7 +136,7 @@ function updateBody(url, callback, init) { } if (!err) { var code = res.statusCode; - if (code >= 400 && code < 500) { + if (code === 404) { body = ''; logger.warn(url, code); } else if (code !== 200) {
refactor: handle the statusCode of remote rules response
avwo_whistle
train
js
823c0c248c3f234d5326633496f6485b56e1d238
diff --git a/plugins/typescript/index.js b/plugins/typescript/index.js index <HASH>..<HASH> 100644 --- a/plugins/typescript/index.js +++ b/plugins/typescript/index.js @@ -50,7 +50,7 @@ exports.apply = ( .options( Object.assign( { - transpileOnly: true, + transpileOnly: api.config.parallel ? undefined : true, appendTsSuffixTo: ['\\.vue$'], // https://github.com/TypeStrong/ts-loader#happypackmode-boolean-defaultfalse happyPackMode: api.config.parallel
fix(typescript): Don't set `transpileOnly` in parallel mode (#<I>)
egoist_poi
train
js
c5d4eba20d0e29df36dcc15598dee6de29163ca6
diff --git a/src/main/java/com/conveyal/gtfs/GTFSFeed.java b/src/main/java/com/conveyal/gtfs/GTFSFeed.java index <HASH>..<HASH> 100644 --- a/src/main/java/com/conveyal/gtfs/GTFSFeed.java +++ b/src/main/java/com/conveyal/gtfs/GTFSFeed.java @@ -234,15 +234,7 @@ public class GTFSFeed implements Cloneable, Closeable { throw new RuntimeException(e); } } -// public void validate (EventBus eventBus, Validator... validators) { -// if (eventBus == null) { -// -// } -// for (Validator validator : validators) { -// validator.getClass().getSimpleName(); -// validator.validate(this, false); -// } -// } + public void validate (boolean repair, Validator... validators) { long startValidation = System.currentTimeMillis(); for (Validator validator : validators) {
refactor(GTFSFeed): remove commented out code BREAKING CHANGE: This PR removes a few heavyweight indexes that are no longer used. It also removes the FeedStats class/stats package.
conveyal_gtfs-lib
train
java
9ba1660d3721342dd353360383b4fe9463ffb723
diff --git a/docs/app/js/codepen.js b/docs/app/js/codepen.js index <HASH>..<HASH> 100644 --- a/docs/app/js/codepen.js +++ b/docs/app/js/codepen.js @@ -122,8 +122,8 @@ return content + '\n\n'+ commentStart + '\n'+ 'Copyright 2016 Google Inc. All Rights Reserved. \n'+ - 'Use of this source code is governed by an MIT-style license that can be in found'+ - 'in the LICENSE file at http://material.angularjs.org/license.\n'+ + 'Use of this source code is governed by an MIT-style license that can be found'+ + 'in the LICENSE file at http://material.angularjs.org/HEAD/license.\n'+ commentEnd; }
fix(docs): codepen should link to correct license link * Currently when checking out a codepen, the license will be appended to all source files. The license of the docs will be linked inside of that comment. But that link is not correct. * Fix incorrect wording for the license footer for codpens Closes #<I>
angular_material
train
js
65a41f6ccc57ef7bb39fe779d9af4ce5e29ba34f
diff --git a/scripts/rollup-build.js b/scripts/rollup-build.js index <HASH>..<HASH> 100644 --- a/scripts/rollup-build.js +++ b/scripts/rollup-build.js @@ -3,6 +3,7 @@ import nodeResolve from 'rollup-plugin-node-resolve'; import babel from 'rollup-plugin-babel'; import uglify from 'rollup-plugin-uglify'; import commonjs from 'rollup-plugin-commonjs'; +import filesize from 'rollup-plugin-filesize'; export default { input: 'src/index.js', @@ -17,6 +18,7 @@ export default { plugins: ['external-helpers'], }), uglify(), + filesize(), ], output: [ {
chore: use filesize rollup plugin during in build script
probil_vue-socket.io-extended
train
js
e2f5bca886c47e18a5eb71d27ee481af6a4a58c0
diff --git a/providers/AppProvider.js b/providers/AppProvider.js index <HASH>..<HASH> 100644 --- a/providers/AppProvider.js +++ b/providers/AppProvider.js @@ -210,7 +210,7 @@ class AppProvider extends ServiceProvider { */ _registerExceptionHandler () { this.app.bind('Adonis/Exceptions/Handler', () => { - return require('../src/App/Handler') + return new (require('../src/App/Handler')) }) }
fix(exception): return instance of exception handler from ioc binding
adonisjs_adonis-framework
train
js
6471e724b912242efc58ac99621c6ff67818da70
diff --git a/src/SortableContainer/index.js b/src/SortableContainer/index.js index <HASH>..<HASH> 100644 --- a/src/SortableContainer/index.js +++ b/src/SortableContainer/index.js @@ -214,11 +214,12 @@ export default function sortableContainer(WrappedComponent, config = {withRef: f }; const fields = node.querySelectorAll('input, textarea, select'); + const fields = node.querySelectorAll('input, textarea, select'); const clonedNode = node.cloneNode(true); + const clonedFields = clonedNode.querySelectorAll('input, textarea, select'); // Returns the clonedFields in the same order as fields - fields.forEach((field) => { - const element = clonedNode.querySelector("input[name='"+field.name+"'], textarea[name='"+field.name+"'], select[name='"+field.name+"']"); - element ? element.value = field.value : null; + clonedFields.forEach((field, index) => { + return field.value = fields[index] && fields[index].value; }); this.helper = this.document.body.appendChild(clonedNode);
fix: Update value pre-population logic to be more reliable
clauderic_react-sortable-hoc
train
js
876db1f4a742813d48473b8bcd7e97d60bda806c
diff --git a/src/candela/components/TrackerDash/InfoPane.js b/src/candela/components/TrackerDash/InfoPane.js index <HASH>..<HASH> 100644 --- a/src/candela/components/TrackerDash/InfoPane.js +++ b/src/candela/components/TrackerDash/InfoPane.js @@ -120,7 +120,7 @@ class InfoPane extends VisComponent { } let current = trend.history[trend.history.length - 1]; current = deArray(current, d3.median); - const el = $(`#${trend.id_selector}-aggregate-bullet`).get(0); + const el = $(`#${trend.id_selector}-aggregate-bullet-svg`).get(0); this.aggBullets[trend.id_selector] = new ErrorBulletWidget(el, { result: { current: Math.round(current * 10000) / 10000
fix(TrackerDash): Use correct target element for InfoPane bullet charts
Kitware_candela
train
js
a136501d43396977b50571a68527333f1c835bb0
diff --git a/test/mp/runtime/directives/bind.spec.js b/test/mp/runtime/directives/bind.spec.js index <HASH>..<HASH> 100644 --- a/test/mp/runtime/directives/bind.spec.js +++ b/test/mp/runtime/directives/bind.spec.js @@ -421,4 +421,27 @@ describe('Directive v-bind', () => { expectAttr(0) }).then(done) }) + + // #188 + it('should work well same attribute value but different element', done => { + const { page, vm } = createPage({ + template: ` + <div> + <img v-if="foo" :src="img1"> + <img v-else :src="img2"> + </div> + `, + data: { foo: true, img1: 'https://a/1.jpg', img2: 'https://a/1.jpg' } + }) + + const pageData = getPageData(page, '0') + expect(pageData.h[1]._if).toBeTruthy() + expect(pageData.h[1].src).toBe('https://a/1.jpg') + expect(pageData.h[2]).toBeUndefined() + vm.foo = false + waitForUpdate(() => { + expect(pageData.h[1]._if).toBeFalsy() + expect(pageData.h[2].src).toBe('https://a/1.jpg') + }).then(done) + }) })
test: update test for same attribute value but different hid
kaola-fed_megalo
train
js
7da2a9d4141cff40801b7959a952b3416ac297ef
diff --git a/test/test_scheduler.go b/test/test_scheduler.go index <HASH>..<HASH> 100644 --- a/test/test_scheduler.go +++ b/test/test_scheduler.go @@ -263,13 +263,15 @@ func (s *SchedulerSuite) TestControllerRestart(t *c.C) { addr := addrs[1] debug(t, "new controller address: ", addr) client, err = controller.NewClient("http://"+addr, s.clusterConf(t).Key) + if err != nil { + return err + } + stream, err = client.StreamJobEvents("controller", lastID) return }), c.IsNil) + defer stream.Close() // kill the first controller and check the scheduler brings it back online - stream, err = client.StreamJobEvents("controller", lastID) - t.Assert(err, c.IsNil) - defer stream.Close() cc, err := cluster.NewClientWithDial(nil, s.discoverdClient(t).NewServiceSet) t.Assert(err, c.IsNil) defer cc.Close()
test: Fix race in TestControllerRestart Creating a client doesn't actually make any connections, so try to connect to the stream inside of the attempts function.
flynn_flynn
train
go
3f7f50c69d06250aaf4c71997b3908fa261c7c6b
diff --git a/spec/JUnitXmlReporterSpec.js b/spec/JUnitXmlReporterSpec.js index <HASH>..<HASH> 100644 --- a/spec/JUnitXmlReporterSpec.js +++ b/spec/JUnitXmlReporterSpec.js @@ -1,6 +1,6 @@ /* globals jasmine, describe, afterEach, beforeEach, it, expect */ var jasmineReporters = require("../index"); -var DOMParser = require("xmldom").DOMParser; +var DOMParser = require("@xmldom/xmldom").DOMParser; var env, suite, reporter, writeCalls, suiteId=0, specId=0, noop=function(){}; diff --git a/spec/NUnitXmlReporterSpec.js b/spec/NUnitXmlReporterSpec.js index <HASH>..<HASH> 100644 --- a/spec/NUnitXmlReporterSpec.js +++ b/spec/NUnitXmlReporterSpec.js @@ -1,6 +1,6 @@ /* globals jasmine, describe, beforeEach, it, expect */ var jasmineReporters = require("../index"); -var DOMParser = require("xmldom").DOMParser; +var DOMParser = require("@xmldom/xmldom").DOMParser; var env, suite, subSuite, subSubSuite, siblingSuite, reporter, writeCalls, suiteId=0, specId=0, noop=function(){};
fix: Adapt require calls to new xmldom
larrymyers_jasmine-reporters
train
js,js
e56970cc69fe7d6d5fbbb795811bdf849ab9924b
diff --git a/lib/auth_41.js b/lib/auth_41.js index <HASH>..<HASH> 100644 --- a/lib/auth_41.js +++ b/lib/auth_41.js @@ -73,8 +73,11 @@ exports.calculateTokenFromPasswordSha = function( scramble1, scramble2 ) { + // we use AUTH 41 here, and we need only the bytes we just need. + const authPluginData1 = scramble1.slice(0, 8); + const authPluginData2 = scramble2.slice(0, 12); const stage2 = sha1(passwordSha); - const stage3 = sha1(scramble1, scramble2, stage2); + const stage3 = sha1(authPluginData1, authPluginData2, stage2); return xor(stage3, passwordSha); };
fix: enhance auth <I>
sidorares_node-mysql2
train
js
fa2a6b8ccc051b428787d64cb719ae650e8802de
diff --git a/intranet/apps/announcements/notifications.py b/intranet/apps/announcements/notifications.py index <HASH>..<HASH> 100644 --- a/intranet/apps/announcements/notifications.py +++ b/intranet/apps/announcements/notifications.py @@ -129,8 +129,9 @@ def announcement_posted_email(request, obj, send_all=False): send_groups = obj.groups.all() emails = [] users_send = [] + is_public = not send_groups.exists() for u in users: - if not send_groups.exists() or send_groups.intersection(u.groups.all()).exists(): + if is_public or send_groups.intersection(u.groups.all()).exists(): # Either it has no groups (public) or user is a member of a send group em = u.emails.first() if u.emails.exists() else u.tj_email if em:
perf(announcements): don't make unnecessary queries
tjcsl_ion
train
py
f43af330a0aeebe3422ca050ed46b3ed2f63b495
diff --git a/src/main/index.js b/src/main/index.js index <HASH>..<HASH> 100644 --- a/src/main/index.js +++ b/src/main/index.js @@ -67,8 +67,13 @@ openFile$ // based on if arguments went through argv or through open-file events if (notebooks.length <= 0 && buffer.length <= 0) { log.info('launching an empty notebook by default'); - kernelSpecsPromise.then(specs => - launchNewNotebook(Object.keys(specs)[0]) + kernelSpecsPromise.then(specs => { + const defaultKernel = 'python3'; + const specList = Object.keys(specs).sort(); + const kernel = specList.python3 || specList.python2 || specList[0]; + + launchNewNotebook(kernel); + } ); } else { notebooks
fix(defaultKernel): default to py3, py2, then 1st lexicographically
nteract_nteract
train
js
3f904916a966e2b249835e0643ffe3a4626c89cb
diff --git a/src/Http/routes.php b/src/Http/routes.php index <HASH>..<HASH> 100644 --- a/src/Http/routes.php +++ b/src/Http/routes.php @@ -1,5 +1,16 @@ <?php +declare(strict_types=1); + +/* + * This file is part of Eloquent Viewable. + * + * (c) Cyril de Wit <github@cyrildewit.nl> + * + * For the full copyright and license information, please view the LICENSE + * file that was distributed with this source code. + */ + Route::middleware(['web'])->group(function () { $cookieName = config('eloquent-viewable.cookie_name', 'eloquent_viewable');
refactor: add declare strict_types=1 and copyright notice to routes.php
cyrildewit_eloquent-viewable
train
php
2cf08d71a9d32311d79846828ecb076d0c978758
diff --git a/src/components/VDataTable/mixins/body.js b/src/components/VDataTable/mixins/body.js index <HASH>..<HASH> 100644 --- a/src/components/VDataTable/mixins/body.js +++ b/src/components/VDataTable/mixins/body.js @@ -31,6 +31,7 @@ export default { return this.genTR([transition], { class: 'datatable__expand-row' }) }, genFilteredItems () { + console.log(this.$scopedSlots.items) if (!this.$scopedSlots.items) { return null } @@ -46,7 +47,7 @@ export default { key: index, attrs: { active: this.isSelected(item) } }) - : Object.assign({ key: index }, row)) + : row) if (this.$scopedSlots.expand) { const expandRow = this.genExpandedRow(props)
fix(v-data-table): removed key assignment to slotted tr if a developer has a top level tr, they will have to apply the key
vuetifyjs_vuetify
train
js
cb9d41e82f6a9ab5208466407650bd2af4af2b06
diff --git a/index.js b/index.js index <HASH>..<HASH> 100644 --- a/index.js +++ b/index.js @@ -119,7 +119,7 @@ PGPubsub.prototype.removeChannel = function (channel, callback) { PGPubsub.prototype.close = function () { this.retry.end(); - this.removeAllListeners(channel); + this.removeAllListeners(); this.channels = []; };
fix(main): removed unknown variable in close()
voxpelli_node-pg-pubsub
train
js
5831035574d9710a5529f478eb7040f54fa3cf20
diff --git a/scripts/build.js b/scripts/build.js index <HASH>..<HASH> 100644 --- a/scripts/build.js +++ b/scripts/build.js @@ -18,6 +18,14 @@ const inputOptions = { commonjs(), // so Rollup can convert `ms` to an ES module babel({ exclude: 'node_modules/**', // 只编译我们的源代码 + presets: [[ + '@babel/preset-env', { + /** + * Do not transpile typeof helper with itself + * https://github.com/babel/babel/pull/10788/files + */ + 'exclude': ['@babel/plugin-transform-typeof-symbol'] + }]], }), ], };
fix: Do not transpile typeof helper with itself.
jaywcjlove_hotkeys
train
js
715641296301a8f08161790c72a07a56c8413658
diff --git a/lib/lift.js b/lib/lift.js index <HASH>..<HASH> 100644 --- a/lib/lift.js +++ b/lib/lift.js @@ -97,7 +97,7 @@ module.exports = function(Future) { */ exports.fromPromise = fromPromise function fromPromise(p) { return new Future(function(reject, resolve) { - p.then(reject, resolve) + p.then(resolve, reject) })} /** @@ -112,10 +112,10 @@ module.exports = function(Future) { * new PromiseConstructor(((α → Void), (β → Void) → Void)) → Promise[α, β] */ exports.toPromise = curry(2, toPromise) - function toPromise(Promise, a) { return new Promise(function(reject, resolve) { + function toPromise(Promise, a) { return new Promise(function(resolve, reject) { a.fork(reject, resolve) })} return exports -} \ No newline at end of file +}
fix(lift): Fixes promise's parameter order While Future/Tasks use (reject, resolve), Promises use (resolve, reject). Closes #7.
folktale_control.async
train
js
5cb93daa6978f3f54cb55c00b114cfd5ed4fb001
diff --git a/cleo/commands/command.py b/cleo/commands/command.py index <HASH>..<HASH> 100644 --- a/cleo/commands/command.py +++ b/cleo/commands/command.py @@ -336,7 +336,7 @@ class Command(BaseCommand): """ Automatically spin a progress indicator. """ - spinner = ProgressIndicator(self.io, fmt, interval, values) + spinner = self.progress_indicator(fmt, interval, values) return spinner.auto(start_message, end_message)
chore: fix failing lint
sdispater_cleo
train
py
51946db8da11a16429c1071da21fe11775ecdb76
diff --git a/scripts/rebuild_specs.js b/scripts/rebuild_specs.js index <HASH>..<HASH> 100644 --- a/scripts/rebuild_specs.js +++ b/scripts/rebuild_specs.js @@ -8,7 +8,7 @@ const ts = require('typescript'); const app = new TypeDoc.Application(); app.bootstrap({ - mode: 'Modules', + mode: TypeDoc.SourceFileMode.Modules, target: ts.ScriptTarget.ES5, module: ts.ModuleKind.CommonJS, experimentalDecorators: true,
fix: Rebuild specs typechecks
TypeStrong_typedoc
train
js
672d052d306123668fffb9e9bfe9b82306d0f585
diff --git a/lib/index.js b/lib/index.js index <HASH>..<HASH> 100644 --- a/lib/index.js +++ b/lib/index.js @@ -297,7 +297,7 @@ function exportInterfaces(obj) { obj.logger = logger; obj.getImpExpService = function(callback) { loadService(function(err, options) { - callback(err, options.port); + callback(err, options && options.port); }); }; return obj;
feat: Export saz file
avwo_whistle
train
js
bfe96af21129c5daaef2e68f6326b237cef954b7
diff --git a/actor-sdk/sdk-core/runtime/runtime-se/src/main/java/im/actor/runtime/se/JavaSeThreadingProvider.java b/actor-sdk/sdk-core/runtime/runtime-se/src/main/java/im/actor/runtime/se/JavaSeThreadingProvider.java index <HASH>..<HASH> 100644 --- a/actor-sdk/sdk-core/runtime/runtime-se/src/main/java/im/actor/runtime/se/JavaSeThreadingProvider.java +++ b/actor-sdk/sdk-core/runtime/runtime-se/src/main/java/im/actor/runtime/se/JavaSeThreadingProvider.java @@ -5,7 +5,12 @@ package im.actor.runtime.se; import im.actor.runtime.generic.GenericThreadingProvider; +import im.actor.runtime.threading.Dispatcher; public class JavaSeThreadingProvider extends GenericThreadingProvider { + @Override + public Dispatcher createDispatcher(String name) { + return null; + } }
fix(runtime): Fixing Java SE compilation error
actorapp_actor-platform
train
java
fafead7c858b5c872f028004ff05c57d96adbaae
diff --git a/recommender/synth.py b/recommender/synth.py index <HASH>..<HASH> 100644 --- a/recommender/synth.py +++ b/recommender/synth.py @@ -29,7 +29,8 @@ common = gcp.CommonTemplates() for version in versions: library = gapic.py_library( "recommender", version, - include_protos=True + include_protos=True, + config_path="/google/cloud/recommender/v1beta1/artman_recommender_v1beta1.yaml" ) s.move(library, excludes=['nox.py', 'docs/index.rst', 'README.rst', 'setup.py'])
chore(recommender): correct config path in synth file for recommender (#<I>)
googleapis_google-cloud-python
train
py
4d3a5986d0d27b3ad4a4ec50274dd7f7cdf776a2
diff --git a/controllers/UserController.js b/controllers/UserController.js index <HASH>..<HASH> 100644 --- a/controllers/UserController.js +++ b/controllers/UserController.js @@ -262,9 +262,7 @@ module.exports = function( config, Controller, passport, UserService ) { .then( this.proxy( function( user ) { require( 'clever-auth' ).controllers.AuthController.authenticate.apply( this, [ null, user ] ); })) - .catch( this.proxy( function( err ) { - this.send( { statusCode: 400, message: err }, 400 ); - })); + .catch( this.proxy( 'handleServiceMessage' ) ) }, /** @@ -277,9 +275,7 @@ module.exports = function( config, Controller, passport, UserService ) { .then( this.proxy( function( user ) { require( 'clever-auth' ).controllers.AuthController.updateSession.apply( this, [ user ] ); })) - .catch( this.proxy( function( err ) { - this.send( { statusCode: 400, message: err }, 400 ); - })); + .catch( this.proxy( 'handleServiceMessage' ) ) }, /**
refactor(auth): Modified user controller to call handleServiceMessage with exceptions as well
CleverStack_clever-auth
train
js
07f61d822d9729118a80692919bfdb236deee10f
diff --git a/packages/api-page-builder/src/plugins/models/pbPage.model.js b/packages/api-page-builder/src/plugins/models/pbPage.model.js index <HASH>..<HASH> 100644 --- a/packages/api-page-builder/src/plugins/models/pbPage.model.js +++ b/packages/api-page-builder/src/plugins/models/pbPage.model.js @@ -92,19 +92,19 @@ export default ({ createBase, context, PbCategory, PbSettings }) => { return new Promise(async resolve => { const settings = await PbSettings.load(); resolve(settings.data.pages.home === this.parent); - }); + }).catch(() => false); }, get isErrorPage() { return new Promise(async resolve => { const settings = await PbSettings.load(); resolve(settings.data.pages.error === this.parent); - }); + }).catch(() => false); }, get isNotFoundPage() { return new Promise(async resolve => { const settings = await PbSettings.load(); resolve(settings.data.pages.notFound === this.parent); - }); + }).catch(() => false); }, get revisions() { return new Promise(async resolve => {
fix: handle errors on missing settings or lack of settings values.
Webiny_webiny-js
train
js
be2359952ebd5672c3b6c4b10e3eed2cf2f62086
diff --git a/src/test/java/com/aparapi/runtime/MultiplePassesMemoryConsumptionTest.java b/src/test/java/com/aparapi/runtime/MultiplePassesMemoryConsumptionTest.java index <HASH>..<HASH> 100644 --- a/src/test/java/com/aparapi/runtime/MultiplePassesMemoryConsumptionTest.java +++ b/src/test/java/com/aparapi/runtime/MultiplePassesMemoryConsumptionTest.java @@ -50,7 +50,7 @@ public class MultiplePassesMemoryConsumptionTest { } } long extraMemory = baseFree - testFree; - Assert.assertTrue("Too much memory consumed: " + extraMemory, extraMemory < 1000); + Assert.assertTrue("Too much memory consumed: " + extraMemory, extraMemory < 4000000); } }
test: increased the max memory consumption to 4 megs on the test.
Syncleus_aparapi
train
java
839974ca432c70d57e82e9b47334f743e0c20281
diff --git a/src/managers/ApplicationCommandPermissionsManager.js b/src/managers/ApplicationCommandPermissionsManager.js index <HASH>..<HASH> 100644 --- a/src/managers/ApplicationCommandPermissionsManager.js +++ b/src/managers/ApplicationCommandPermissionsManager.js @@ -133,12 +133,13 @@ class ApplicationCommandPermissionsManager extends BaseManager { * @returns {Promise<ApplicationCommandPermissions[]|Collection<Snowflake, ApplicationCommandPermissions[]>>} * @example * // Set the permissions for one command - * client.application.commands.permissions.set({ command: '123456789012345678', permissions: [ - * { - * id: '876543210987654321', - * type: 'USER', - * permission: false, - * }, + * client.application.commands.permissions.set({ guild: '892455839386304532', command: '123456789012345678', + * permissions: [ + * { + * id: '876543210987654321', + * type: 'USER', + * permission: false, + * }, * ]}) * .then(console.log) * .catch(console.error);
docs(ApplicationCommandPermissionsManager): fix example set method (#<I>)
discordjs_discord.js
train
js
39609fa45a258519fa9fcb4ebfbbd004e57be1d0
diff --git a/src/foremast/consts.py b/src/foremast/consts.py index <HASH>..<HASH> 100644 --- a/src/foremast/consts.py +++ b/src/foremast/consts.py @@ -23,7 +23,7 @@ def find_config(): cfg_file = config.read(config_locations) if not cfg_file: - LOG.error('No config found in the following locations: {0}\n'.format(CONFIG_LOCATIONS)) + LOG.error('No config found in the following locations: {0}\n'.format(config_locations)) return config @@ -46,5 +46,3 @@ HEADERS = { } LOGGING_FORMAT = ('%(asctime)s [%(levelname)s] %(name)s:%(funcName)s:' '%(lineno)d - %(message)s') - -
fix: Locations was move to a local variable
foremast_foremast
train
py
a77a2a4f82eb8a45ea837003ed16aab5d8bab7f5
diff --git a/packages/eslint-config/index.js b/packages/eslint-config/index.js index <HASH>..<HASH> 100644 --- a/packages/eslint-config/index.js +++ b/packages/eslint-config/index.js @@ -36,7 +36,6 @@ module.exports = { "jsx-a11y/no-noninteractive-element-interactions": 0, "react/forbid-prop-types": 0, "react/jsx-filename-extension": 0, - "react/self-closing-comp": 0, "redux-saga/no-yield-in-race": 2, "redux-saga/yield-effects": 2 },
feat(eslint-config): remove react/self-closing-comp custom rule affects: @goldwasserexchange/eslint-config remove react/self-closing-comp custom eslint rule to use airbnb default behavior
goldwasserexchange_public
train
js
8ea1f134df46c236852c2827ad48ee93399606e6
diff --git a/library.js b/library.js index <HASH>..<HASH> 100644 --- a/library.js +++ b/library.js @@ -388,7 +388,8 @@ async function stripDisallowedFullnames(users) { SocketPlugins.mentions.getTopicUsers = async (socket, data) => { const uids = await Topics.getUids(data.tid); - const users = await User.getUsers(uids); + let users = await User.getUsers(uids); + users = users.filter(u => u && u.userslug); if (Meta.config.hideFullname) { return users; }
fix: #<I>, don't show delete users in topic users
julianlam_nodebb-plugin-mentions
train
js
d5c3750c052649ef9d1b0fc9551c9b740f3d55dc
diff --git a/lib/koa-data-request.js b/lib/koa-data-request.js index <HASH>..<HASH> 100644 --- a/lib/koa-data-request.js +++ b/lib/koa-data-request.js @@ -38,9 +38,8 @@ class KoaDataRequestInterceptor extends Interceptor { receive(ctx, args) { this.ec.properties = args; - return this.connected.receive({ - data: this.ec.expand(this.data) - }, ctx).then(response => { + return this.connected.receive( + this.ec.expand(this.data), ctx).then(response => { ctx.body = response; return Promise.resolve(); }); diff --git a/tests/koa-data_test.js b/tests/koa-data_test.js index <HASH>..<HASH> 100644 --- a/tests/koa-data_test.js +++ b/tests/koa-data_test.js @@ -68,7 +68,7 @@ describe('interceptors', () => { it('passing request', () => itc.receive(ctx, { id: 1234 }).then(() => { - assert.equal(ctx.body.data.a, 'XXX1234YYY'); + assert.equal(ctx.body.a, 'XXX1234YYY'); })); }); });
feat(koa-data-request): no more { data: <<content>> } for outgoing requests BREAKING CHANGE: remove surrounding object with data: key as default request shell
Kronos-Integration_kronos-interceptor-http-request
train
js,js
1f8d1afce0abe16c9888dafe73010e65271cf34d
diff --git a/index.js b/index.js index <HASH>..<HASH> 100644 --- a/index.js +++ b/index.js @@ -15,6 +15,7 @@ const fs = require('fs'); const _ = require('lodash'); const path = require('path'); const loaderUtils = require('loader-utils'); +const webpack = require('webpack'); const { CachedChildCompilation } = require('./lib/cached-child-compiler'); const { createHtmlTagObject, htmlTagObjectToString, HtmlTagArray } = require('./lib/html-tags'); @@ -329,10 +330,7 @@ function hookIntoCompiler (compiler, options, plugin) { return loaderUtils.getHashDigest(Buffer.from(html, 'utf8'), hashType, digestType, parseInt(maxLength, 10)); }); // Add the evaluated html code to the webpack assets - compilation.assets[finalOutputName] = { - source: () => html, - size: () => html.length - }; + compilation.emitAsset(finalOutputName, new webpack.sources.RawSource(html, false)); return finalOutputName; }) .then((finalOutputName) => getHtmlWebpackPluginHooks(compilation).afterEmit.promise({
feat: use webpack 5 api to add assets
jantimon_html-webpack-plugin
train
js
694a4a5148192be14b1ff5dc7353ec0c55297fb4
diff --git a/packages/ncform-common/src/validation-rule.js b/packages/ncform-common/src/validation-rule.js index <HASH>..<HASH> 100755 --- a/packages/ncform-common/src/validation-rule.js +++ b/packages/ncform-common/src/validation-rule.js @@ -29,7 +29,7 @@ class ValidationRule { case "promise": result.then(res => { resolve({ - res, + result: res, errMsg: !res ? this.errMsg || this.defaultErrMsg : "", timeStamp });
fix(ncform-common): Fixed the bug that the promise type rule logic does not take effect when submiss
ncform_ncform
train
js
8cfd2c3d6e9d779472bde7c05c72daff111c6868
diff --git a/system/Commands/Database/ShowTableInfo.php b/system/Commands/Database/ShowTableInfo.php index <HASH>..<HASH> 100644 --- a/system/Commands/Database/ShowTableInfo.php +++ b/system/Commands/Database/ShowTableInfo.php @@ -81,7 +81,9 @@ class ShowTableInfo extends BaseCommand $tables = $this->db->listTables(); - $this->sortIsDESC = CLI::getOption('desc'); + if (CLI::getOption('desc') === true) { + $this->sortIsDESC = true; + } if ($tables === []) { CLI::error('Database has no tables!', 'light_gray', 'red');
fix: $sortIsDESC assignment Ensure that boolean is assigned.
codeigniter4_CodeIgniter4
train
php
03cf1f05842f4f7fbbe3ad53dbee48c83ede3615
diff --git a/src/js/core/scrollspy.js b/src/js/core/scrollspy.js index <HASH>..<HASH> 100644 --- a/src/js/core/scrollspy.js +++ b/src/js/core/scrollspy.js @@ -128,6 +128,10 @@ export default { toggle(el, inview) { const state = this._data.elements.get(el); + if (!state) { + return; + } + state.off?.(); css(el, 'visibility', !inview && this.hidden ? 'hidden' : '');
fix: case where component resets while toggle is enqueued
uikit_uikit
train
js
3592fc22320f942886f96d384db2997bac5b4879
diff --git a/src/modules/cell.js b/src/modules/cell.js index <HASH>..<HASH> 100644 --- a/src/modules/cell.js +++ b/src/modules/cell.js @@ -186,6 +186,7 @@ import { jsPDF } from "../jspdf.js"; var amountOfLines = 0; var height = 0; var tempWidth = 0; + var scope = this; if (!Array.isArray(text) && typeof text !== "string") { if (typeof text === "number") {
fix: scope is not defined in getTextDimensions (#<I>)
MrRio_jsPDF
train
js
b43f79b98011f79cb5e39554ad3e5e9bd5312498
diff --git a/query/stdlib/testing/end_to_end_test.go b/query/stdlib/testing/end_to_end_test.go index <HASH>..<HASH> 100644 --- a/query/stdlib/testing/end_to_end_test.go +++ b/query/stdlib/testing/end_to_end_test.go @@ -190,6 +190,16 @@ func testFlux(t testing.TB, l *launcher.TestLauncher, file *ast.File) { // this time we use a call to `run` so that the assertion error is triggered runCalls := stdlib.TestingRunCalls(pkg) pkg.Files[len(pkg.Files)-1] = runCalls + + bs, err = json.Marshal(pkg) + if err != nil { + t.Fatal(err) + } + + req = &query.Request{ + OrganizationID: l.Org.ID, + Compiler: lang.ASTCompiler{AST: bs}, + } r, err := l.FluxQueryService().Query(ctx, req) if err != nil { t.Fatal(err)
fix: need to rebuild the query request before the second e2e test run (#<I>) The e2e test driver in influxdb runs the tests twice to get past the fact that there is no way to force order between the write to storage and the read back. When the json.Marshal call became mandatory it was added to the first run, but not the second.
influxdata_influxdb
train
go
cbbefcac0e17410d87a88c4031fadde2aa52bdf9
diff --git a/src/super.js b/src/super.js index <HASH>..<HASH> 100644 --- a/src/super.js +++ b/src/super.js @@ -22,7 +22,9 @@ Super.prototype.on = function (arg, cb) { Super.prototype.off = function (type, cb) { var self = this; - if (self.handlers[type] && self.handlers[type].indexOf(cb) >= 0) { + if (cb === undefined) { + self.handlers[type] = []; + } else if (self.handlers[type] && self.handlers[type].indexOf(cb) >= 0) { self.handlers[type].splice(self.handlers[type].indexOf(cb), 1); } return self;
feat(off): allow unsubscribing of a type at once
yoannmoinet_nipplejs
train
js
d143b2d4f0f2e9efbf7b2fe647cab2ddd43c93de
diff --git a/lib/faraday/connection.rb b/lib/faraday/connection.rb index <HASH>..<HASH> 100644 --- a/lib/faraday/connection.rb +++ b/lib/faraday/connection.rb @@ -474,9 +474,7 @@ module Faraday if params uri.query = params.to_query(params_encoder || options.params_encoder) end - # rubocop:disable Style/SafeNavigation uri.query = nil if uri.query && uri.query.empty? - # rubocop:enable Style/SafeNavigation uri end
chore: Remove unnecessary lint skip
lostisland_faraday
train
rb
b0ae9c6b0f79b4c3a3fd46b940bf810c31701eac
diff --git a/packages/blueprint-sequelize/lib/resource-controller.js b/packages/blueprint-sequelize/lib/resource-controller.js index <HASH>..<HASH> 100644 --- a/packages/blueprint-sequelize/lib/resource-controller.js +++ b/packages/blueprint-sequelize/lib/resource-controller.js @@ -310,7 +310,7 @@ module.exports = ResourceController.extend ({ }, getInclude (req, include) { - return null; + return include; }, getProjection () { @@ -373,10 +373,17 @@ module.exports = ResourceController.extend ({ if (query._) delete query._; + // The include query parameter is a special parameter. Let's remove it from the + // query so the model does not process it. + let { include } = query; + + if (!!include) + delete query.include; + const preparations = [ this.getId (req, id), this.getProjection (req), - this.getInclude (req), + this.getInclude (req, include), this.getOptions (req, options) ]; @@ -420,8 +427,8 @@ module.exports = ResourceController.extend ({ return id; }, - getInclude (req) { - return null; + getInclude (req, include) { + return include; }, getProjection () {
fix: includes in the original query were ignored
onehilltech_blueprint
train
js
54f1b7264287a1f7efd8486de56d1becbc666a6f
diff --git a/sass/themes/cr/2019/components/membership-signup/js/membership-signup.js b/sass/themes/cr/2019/components/membership-signup/js/membership-signup.js index <HASH>..<HASH> 100644 --- a/sass/themes/cr/2019/components/membership-signup/js/membership-signup.js +++ b/sass/themes/cr/2019/components/membership-signup/js/membership-signup.js @@ -484,4 +484,4 @@ } } }); -})(jQuery); \ No newline at end of file +})(jQuery);
fix: Collapse and expand white space
comicrelief_pattern-lab
train
js
a3caf4f02318ad757d0a3f8015a74fce8a94d105
diff --git a/samples/analyze.js b/samples/analyze.js index <HASH>..<HASH> 100644 --- a/samples/analyze.js +++ b/samples/analyze.js @@ -251,7 +251,7 @@ async function analyzeSafeSearch(gcsUri) { `.${(result.timeOffset.nanos / 1e6).toFixed(0)}s` ); console.log( - `\t\tPornography liklihood: ${likelihoods[result.pornographyLikelihood]}` + `\t\tPornography likelihood: ${likelihoods[result.pornographyLikelihood]}` ); }); // [END video_analyze_explicit_content]
docs: fix typo in samples/analyze.js (#<I>) docs: fix typo in samples/analyze.js
googleapis_nodejs-video-intelligence
train
js
37c3b736cb4ebfe56d91dcc4c3ec3fc7b40a3474
diff --git a/lib/plugin/components/services/statebox/index.js b/lib/plugin/components/services/statebox/index.js index <HASH>..<HASH> 100644 --- a/lib/plugin/components/services/statebox/index.js +++ b/lib/plugin/components/services/statebox/index.js @@ -124,7 +124,8 @@ class StateboxService { this.statebox.listExecutions(executionOptions, callback) } - describeExecution (executionName, updateLastDescribed, executionOptions, callback) { + describeExecution (executionName, executionOptions, callback) { + const updateLastDescribed = executionOptions.updateLastDescribed === true return promiseOrCallback(this.statebox.describeExecution(executionName, updateLastDescribed), callback) } // describeExecution @@ -217,7 +218,7 @@ class StateboxService { } // reviveIfAuthorised async describeAndProcessIfAuthorised (executionName, executionOptions, action, actionFn) { - const executionDescription = await this.statebox.describeExecution(executionName, executionOptions) + const executionDescription = await this.statebox.describeExecution(executionName) return this.processIfAuthorised( executionOptions.userId, executionDescription.stateMachineName,
fix: get update last described from execution options
wmfs_tymly-core
train
js
9448c0b987ccafb8236468e9f062aef873567685
diff --git a/src/hooks/use-mounted.js b/src/hooks/use-mounted.js index <HASH>..<HASH> 100644 --- a/src/hooks/use-mounted.js +++ b/src/hooks/use-mounted.js @@ -3,7 +3,7 @@ import { useRef, } from 'react'; -export default function useDidMount() { +export default function useMounted() { const mounted = useRef(false); useEffect(() => {
refactor(useDidMount): rename to `useMounted` for consistency with file name
juanca_react-aria-components
train
js
66b65aa3ad549fdeaa8df08c9fc2bad2b0c91226
diff --git a/lib/restore_bundled_with/fetch.rb b/lib/restore_bundled_with/fetch.rb index <HASH>..<HASH> 100644 --- a/lib/restore_bundled_with/fetch.rb +++ b/lib/restore_bundled_with/fetch.rb @@ -2,6 +2,8 @@ module RestoreBundledWith class Fetch LOCK_FILE = 'Gemfile.lock' REF = 'HEAD' + # REGEX_PICK = /^(?<pick>\n^BUNDLED WITH.*\n.+\n)/ + # git.cat_file trims last \n? REGEX_PICK = /^(?<pick>\n^BUNDLED WITH.*\n.+)/ def initialize(file = LOCK_FILE, ref = REF, git_path = '.', git_options = {}) @file = file
chore(fetch): comment for capture regex
packsaddle_ruby-restore_bundled_with
train
rb
78c68772940d1fa77c7ededf55e49014f887962f
diff --git a/packages/@vue/cli-service/lib/config/dev.js b/packages/@vue/cli-service/lib/config/dev.js index <HASH>..<HASH> 100644 --- a/packages/@vue/cli-service/lib/config/dev.js +++ b/packages/@vue/cli-service/lib/config/dev.js @@ -10,6 +10,11 @@ module.exports = (api, options) => { .plugin('hmr') .use(require('webpack/lib/HotModuleReplacementPlugin')) + // https://github.com/webpack/webpack/issues/6642 + webpackConfig + .output + .globalObject('this') + webpackConfig .plugin('no-emit-on-errors') .use(require('webpack/lib/NoEmitOnErrorsPlugin'))
fix: fix hmr compatibility with worker-loader (#<I>) closes #<I>
vuejs_vue-cli
train
js
b1a1fc20e0d239b29fe51470ef5d6b537721deef
diff --git a/lib/Client.js b/lib/Client.js index <HASH>..<HASH> 100644 --- a/lib/Client.js +++ b/lib/Client.js @@ -139,7 +139,8 @@ class Client extends events { // collect topics that have subscriptions const topics = Object.keys(topicSubscriptions).map(topicName => ({ topicName, - lockDuration: topicSubscriptions[topicName].lockDuration + lockDuration: topicSubscriptions[topicName].lockDuration, + variables: topicSubscriptions[topicName].variables, })); const requestBody = { ...pollingOptions, topics };
feat(client): Add variable subset to fetch&lock request related to CAM-<I>
camunda_camunda-external-task-client-js
train
js
e77fb4888ba1aa6f656d00030d96954aaa673acf
diff --git a/website/siteConfig.js b/website/siteConfig.js index <HASH>..<HASH> 100644 --- a/website/siteConfig.js +++ b/website/siteConfig.js @@ -42,7 +42,7 @@ const siteConfig = { /* path to images for header/footer */ headerIcon: 'img/bottender.svg', footerIcon: '', - favicon: 'img/favicon.ico', + favicon: 'img/favicon-192x192.png', /* Colors for website */ colors: {
chore(website): use <I>x<I> favicon
Yoctol_bottender
train
js
69c03985caf7efec742e305aadecf1fe0229c87c
diff --git a/test/cluster/cluster.go b/test/cluster/cluster.go index <HASH>..<HASH> 100644 --- a/test/cluster/cluster.go +++ b/test/cluster/cluster.go @@ -72,7 +72,7 @@ func (c *Cluster) BuildFlynn(rootFS, commit string) (string, error) { Kernel: c.bc.Kernel, User: uid, Group: gid, - Memory: "512", + Memory: "2048", Cores: 8, Drives: map[string]*VMDrive{ "hda": {FS: rootFS, COW: true, Temp: false},
test: Use 2GB RAM when building Flynn
flynn_flynn
train
go
96404a34cb4d2944cbbed9bb24b495b4f7c8952e
diff --git a/webapps/webapp/src/test/js/e2e/cockpit/specs/decision-definition-spec.js b/webapps/webapp/src/test/js/e2e/cockpit/specs/decision-definition-spec.js index <HASH>..<HASH> 100644 --- a/webapps/webapp/src/test/js/e2e/cockpit/specs/decision-definition-spec.js +++ b/webapps/webapp/src/test/js/e2e/cockpit/specs/decision-definition-spec.js @@ -109,7 +109,7 @@ describe('Cockpit Decision Definition Spec', function() { it('should load the requested version on selection', function() { // when - definitionPage.version.getDropdownOption(0).click(); + definitionPage.version.getDropdownOption(1).click(); // then expect(definitionPage.version.getVersion()).to.eventually.eql('1');
chore(e2e): fix decision definition test related to CAM-<I>
camunda_camunda-bpm-platform
train
js
19c61178a983748c03435dd3a508e943dd2190cf
diff --git a/actor-sdk/sdk-core/runtime/runtime-shared/src/template/java/im/actor/runtime/WebRTCRuntimeProvider.java b/actor-sdk/sdk-core/runtime/runtime-shared/src/template/java/im/actor/runtime/WebRTCRuntimeProvider.java index <HASH>..<HASH> 100644 --- a/actor-sdk/sdk-core/runtime/runtime-shared/src/template/java/im/actor/runtime/WebRTCRuntimeProvider.java +++ b/actor-sdk/sdk-core/runtime/runtime-shared/src/template/java/im/actor/runtime/WebRTCRuntimeProvider.java @@ -19,7 +19,7 @@ public class WebRTCRuntimeProvider implements WebRTCRuntime { @NotNull @Override - public Promise<WebRTCMediaStream> getUserAudio() { + public Promise<WebRTCMediaStream> getUserMedia(boolean isVideoEnabled) { return Promise.failure(new RuntimeException("Dumb")); }
fix(runtime): update shared WebRTCRuntimeProvider
actorapp_actor-platform
train
java
01869d7377a1024572fe53ea0a95a8d9a98a8481
diff --git a/scripts/git-precommit-hook.py b/scripts/git-precommit-hook.py index <HASH>..<HASH> 100755 --- a/scripts/git-precommit-hook.py +++ b/scripts/git-precommit-hook.py @@ -7,7 +7,7 @@ import subprocess def has_cargo_fmt(): """Runs a quick check to see if cargo fmt is installed.""" try: - c = subprocess.Popen(['cargo', 'fmt', '--help'], + c = subprocess.Popen(['cargo', 'fmt', '--', '--help'], stdout=subprocess.PIPE, stderr=subprocess.PIPE) return c.wait() == 0 @@ -29,6 +29,7 @@ def run_format_check(files): return 0 return subprocess.Popen(['cargo', 'fmt', '--', '--write-mode=diff', + '--skip-children', '--color=always'] + rust_files).wait()
fix: Skip over children in precommit hook
getsentry_semaphore
train
py
19d6b875a2fa460a58f5d445ebf3786a9c509686
diff --git a/examples/nas/multi-trial/mnist/search.py b/examples/nas/multi-trial/mnist/search.py index <HASH>..<HASH> 100644 --- a/examples/nas/multi-trial/mnist/search.py +++ b/examples/nas/multi-trial/mnist/search.py @@ -107,6 +107,7 @@ def evaluate_model(model_cls): device = torch.device('cuda') if torch.cuda.is_available() else torch.device('cpu') + model.to(device) for epoch in range(3): # train the model for one epoch train_epoch(model, device, train_loader, optimizer, epoch)
fix: model is not synced to device when not using CPU (#<I>)
Microsoft_nni
train
py
8dd2d724de236c52d64a7db3743737f666af9ce6
diff --git a/src/plugin/exec.js b/src/plugin/exec.js index <HASH>..<HASH> 100644 --- a/src/plugin/exec.js +++ b/src/plugin/exec.js @@ -5,25 +5,33 @@ import { onlyPackage, exec as execCmd, separator, - log + log, + filter } from '../util' export const plugin = function exec (program, config, directory) { program.command(command).description(description) .option('-o, --only <packageName>', 'Only execute in a single package directory') + .option('-e, --exclude [packageNames...]', 'Exclude directories') .action((...args) => action(config, directory, ...args)) } const command = 'exec [command...]' const description = 'Execute a command in all packages' +function filterExclusions (packages, exclusions) { + return filter(packages, x => exclusions.indexOf(x) === -1, ) +} + // exported for testing export function action (config, workingDir, args, options) { isInitialized(config, 'exec') - const packages = options.only + const packages = filterExclusions(options.only ? onlyPackage(options.only, config.packages) : config.packages + , options.exclude || [] + ) if (packages.length === 0) { if (options.only) {
feat(northbrook): add option to exclude packages from exec
northbrookjs_northbrook
train
js
db3bd3bc897624cfd081ef5622d019c1f976e02c
diff --git a/src/.stories/index.js b/src/.stories/index.js index <HASH>..<HASH> 100644 --- a/src/.stories/index.js +++ b/src/.stories/index.js @@ -590,8 +590,6 @@ storiesOf('General | Layout / Grid', module) }); }} onSortEnd={({nodes}) => { - console.log(nodes); - nodes.forEach(({node}) => { const wrapperNode = node.querySelector(`.${style.wrapper}`);
chore: remove console.log from grid story
clauderic_react-sortable-hoc
train
js
f3db28c94b50cff322d7b74ccd08d84dfaa651ce
diff --git a/test/requestinterception.spec.js b/test/requestinterception.spec.js index <HASH>..<HASH> 100644 --- a/test/requestinterception.spec.js +++ b/test/requestinterception.spec.js @@ -114,6 +114,20 @@ module.exports.addTests = function({testRunner, expect, CHROME}) { const response = await page.goto(server.EMPTY_PAGE); expect(response.ok()).toBe(true); }); + // @see https://github.com/GoogleChrome/puppeteer/issues/4337 + xit('should work with redirect inside sync XHR', async({page, server}) => { + await page.goto(server.EMPTY_PAGE); + server.setRedirect('/logo.png', '/pptr.png'); + await page.setRequestInterception(true); + page.on('request', request => request.continue()); + const status = await page.evaluate(async() => { + const request = new XMLHttpRequest(); + request.open('GET', '/logo.png', false); // `false` makes the request synchronous + request.send(null); + return request.status; + }); + expect(status).toBe(200); + }); it('should works with customizing referer headers', async({page, server}) => { await page.setExtraHTTPHeaders({ 'referer': server.EMPTY_PAGE }); await page.setRequestInterception(true);
test: add failing test for request interception with sync XHRs (#<I>) `Network.requestWillBeSent` is not issued for the redirect inside sync XHRs. References #<I>.
GoogleChrome_puppeteer
train
js
f1b5bf43f77ea78991f708f9de352444be9183f5
diff --git a/packages/dva-core/src/createStore.js b/packages/dva-core/src/createStore.js index <HASH>..<HASH> 100644 --- a/packages/dva-core/src/createStore.js +++ b/packages/dva-core/src/createStore.js @@ -35,8 +35,8 @@ export default function ({ const enhancers = [ applyMiddleware(...middlewares), - devtools(window.__REDUX_DEVTOOLS_EXTENSION__OPTIONS), ...extraEnhancers, + devtools(window.__REDUX_DEVTOOLS_EXTENSION__OPTIONS), ]; return createStore(reducers, initialState, compose(...enhancers));
fix: redux devtools maybe effect other enhancers. <URL> )); ```
dvajs_dva
train
js
7c76efd6ea6add9246dd4128a1a934fda1015cc5
diff --git a/cmd/influx/query.go b/cmd/influx/query.go index <HASH>..<HASH> 100644 --- a/cmd/influx/query.go +++ b/cmd/influx/query.go @@ -105,7 +105,7 @@ func fluxQueryF(cmd *cobra.Command, args []string) error { "query": q, "type": "flux", "dialect": map[string]interface{}{ - "annotations": []string{"datatype", "group", "default"}, + "annotations": []string{"group", "datatype", "default"}, "delimiter": ",", "header": true, },
fix(cli): update annotation order to match UI (#<I>)
influxdata_influxdb
train
go
623e81749602de818ae37259328120552964ac8e
diff --git a/actor-apps/core/src/main/java/im/actor/core/modules/internal/messages/ConversationActor.java b/actor-apps/core/src/main/java/im/actor/core/modules/internal/messages/ConversationActor.java index <HASH>..<HASH> 100644 --- a/actor-apps/core/src/main/java/im/actor/core/modules/internal/messages/ConversationActor.java +++ b/actor-apps/core/src/main/java/im/actor/core/modules/internal/messages/ConversationActor.java @@ -392,9 +392,7 @@ public class ConversationActor extends ModuleActor { docs.clear(); inPendingIndex.clear(); outPendingIndex.clear(); - if (!isHiddenPeer) { - dialogsActor.send(new DialogsActor.ChatClear(peer)); - } + dialogsActor.send(new DialogsActor.ChatClear(peer)); } @Verified @@ -403,9 +401,7 @@ public class ConversationActor extends ModuleActor { docs.clear(); inPendingIndex.clear(); outPendingIndex.clear(); - if (!isHiddenPeer) { - dialogsActor.send(new DialogsActor.ChatDelete(peer)); - } + dialogsActor.send(new DialogsActor.ChatDelete(peer)); } // History
fix(core): Deleting dialogs even hidden peers
actorapp_actor-platform
train
java
5c833ef034d3f84a4e6f02b674980b1a378d34d2
diff --git a/src/Adapter/BaseAdapter.php b/src/Adapter/BaseAdapter.php index <HASH>..<HASH> 100644 --- a/src/Adapter/BaseAdapter.php +++ b/src/Adapter/BaseAdapter.php @@ -16,12 +16,13 @@ use Symfony\Component\Console\Helper\DialogHelper; use Symfony\Component\Console\Output\OutputInterface; /** + * Provides a base class for adapting Gush to use different providers. + * E.g. Github, GitLab, Bitbucket + * * @author Aaron Scherer <aequasi@gmail.com> */ abstract class BaseAdapter implements Adapter { - const NAME = 'unknown'; - /** * @var Config */ @@ -48,14 +49,6 @@ abstract class BaseAdapter implements Adapter /** * {@inheritdoc} */ - public function getName() - { - return self::NAME; - } - - /** - * {@inheritdoc} - */ public static function doConfiguration(OutputInterface $output, DialogHelper $dialog) { return [];
refactor(Adapter): remove getName() from BaseAdapter Each adapter must return a unique name so defaulting doesn't make sense then
gushphp_gush
train
php
005531ca309ba0c15bfe083070bbd2ff607710fb
diff --git a/middlewares/attributes.js b/middlewares/attributes.js index <HASH>..<HASH> 100644 --- a/middlewares/attributes.js +++ b/middlewares/attributes.js @@ -50,13 +50,13 @@ function processAttributeWithoutHandler (attribute) { if (type === '$') { const name = attribute.name.slice(1) if (!handlers.has(name)) { - const expression = this.$compileExpression(value || name) + const expression = this.$compileExpression(attribute.value || name) processExpression.call(this, expression, name, defaultHandler) } } else if (type === '@') { const name = attribute.name.slice(1) if (!handlers.has(name)) { - const expression = this.$compileExpression(value || name) + const expression = this.$compileExpression(attribute.value || name) this.$observe(processExpression, expression, name, defaultHandler) } }
fix(attributes): fix attribute value passing
nx-js_framework
train
js
228d56e5aa46c4ba72dbde2c3c17e3058dda8318
diff --git a/lib/plugin/components/services/statebox/index.js b/lib/plugin/components/services/statebox/index.js index <HASH>..<HASH> 100644 --- a/lib/plugin/components/services/statebox/index.js +++ b/lib/plugin/components/services/statebox/index.js @@ -151,12 +151,11 @@ class StateboxService { return promiseOrCallback(p, callback) } // waitUntilStoppedRunning - /* authorisationCheck (stateMachineName, executionOptions, action) { return [true] // STUB! } - */ + /* async authorisationCheck (userId, stateMachineName, executionOptions, action) { const rbac = this.services.rbac @@ -184,6 +183,7 @@ class StateboxService { } ] } // authorisationCheck + */ } // class StateboxService function addResources (statebox, options) { diff --git a/test/statebox-service-acl-tests.js b/test/statebox-service-acl-tests.js index <HASH>..<HASH> 100644 --- a/test/statebox-service-acl-tests.js +++ b/test/statebox-service-acl-tests.js @@ -46,7 +46,7 @@ const heartBeatTests = [ } ] -describe('statebox service RBAC authorisation tests', function () { +xdescribe('statebox service RBAC authorisation tests', function () { this.timeout(process.env.TIMEOUT || 5000) let tymlyService
refactor: disable statebox RBAC again :) affects: tymly
wmfs_tymly-core
train
js,js
be04871afbd45efc41b20accc1bb634f9d49a895
diff --git a/annotations/builder/src/main/java/io/sundr/builder/internal/functions/ToPojo.java b/annotations/builder/src/main/java/io/sundr/builder/internal/functions/ToPojo.java index <HASH>..<HASH> 100644 --- a/annotations/builder/src/main/java/io/sundr/builder/internal/functions/ToPojo.java +++ b/annotations/builder/src/main/java/io/sundr/builder/internal/functions/ToPojo.java @@ -886,7 +886,7 @@ public class ToPojo implements Function<TypeDef, TypeDef> { } return sb.toString(); } - if (Constants.STRING_REF.equals(p.getTypeRef()) && !String.valueOf(value).startsWith("\"")) { + if (Constants.STRING_REF.equals(p.getTypeRef()) && value != null && !String.valueOf(value).startsWith("\"")) { return "\"" + value + "\""; } else if (value instanceof Element) { Element element = (Element) value;
fix: do not wrap default value in double quotes if its actually null.
sundrio_sundrio
train
java
45a0eefecf3cfda76be0836ab7554f58abb6ea23
diff --git a/samcli/__init__.py b/samcli/__init__.py index <HASH>..<HASH> 100644 --- a/samcli/__init__.py +++ b/samcli/__init__.py @@ -2,4 +2,4 @@ SAM CLI version """ -__version__ = "0.47.0" +__version__ = "0.48.0"
chore: version to <I> (#<I>) Why is this change necessary? * Needed for new release
awslabs_aws-sam-cli
train
py
5349ca09b735e16bea2c3ba3438804a499a0fc7d
diff --git a/views/default/page/components/interactions.js b/views/default/page/components/interactions.js index <HASH>..<HASH> 100644 --- a/views/default/page/components/interactions.js +++ b/views/default/page/components/interactions.js @@ -108,9 +108,9 @@ define(function (require) { $form.trigger('reset'); } // Hide edit form - if ($form.find('[name="comment_guid"]').val()) { + if ($form.is('.elgg-form-edit')) { if (response.status >= 0) { - $form.siblings().first().replaceWith(response.output.view); + $form.siblings().replaceWith(response.output.view); } $form.siblings().show(); $form.remove(); @@ -132,7 +132,8 @@ define(function (require) { $item.append($form); $form.trigger('initialize'); $form.siblings().hide(); - $form.find('[name="generic_comment"]').focus().trigger('click'); + $form.find('textrea,input[type="text"]').first().focus().trigger('click'); + $form.addClass('elgg-form-edit') $form.find('.elgg-button-cancel').on('click', function () { $form.siblings().show(); $form.remove();
fix(js): fix form bugs
hypeJunction_hypeInteractions
train
js
0a942a9b76c76c2618a5522fe67fdf319dd7d9d6
diff --git a/tests/parser/syntax/test_code_size.py b/tests/parser/syntax/test_code_size.py index <HASH>..<HASH> 100644 --- a/tests/parser/syntax/test_code_size.py +++ b/tests/parser/syntax/test_code_size.py @@ -23,10 +23,15 @@ def test_block_fail(bad_code): valid_list = [ """ @external -def foo() -> int128: +def foo() -> uint256: x: address = 0x1234567890123456789012345678901234567890 return x.codesize + """, """ +@external +def foo() -> uint256: + return self.codesize + """, ]
test: update address.codesize tests
ethereum_vyper
train
py