hash
stringlengths
40
40
diff
stringlengths
172
2.63k
message
stringlengths
12
593
project
stringlengths
7
65
split
stringclasses
1 value
diff_languages
stringclasses
54 values
d1a43ee05e77b91570a95234fa3e23c22a3a1a34
diff --git a/lib/service/generate-saz.js b/lib/service/generate-saz.js index <HASH>..<HASH> 100644 --- a/lib/service/generate-saz.js +++ b/lib/service/generate-saz.js @@ -17,6 +17,14 @@ function filterSessions(sessions) { }); } +function getFiddler2Meta() { + +} + +function getFiddler4Meta() { + +} + module.exports = function(body) { var isFiddler2 = body.exportFileType === 'Fiddler2'; if (!isFiddler2 && body.exportFileType !== 'Fiddler4') {
feat: Export saz file
avwo_whistle
train
js
34aca06d3cca5ac808073e75108665cc704afd73
diff --git a/tests/test_for_support/test_for_biomass.py b/tests/test_for_support/test_for_biomass.py index <HASH>..<HASH> 100644 --- a/tests/test_for_support/test_for_biomass.py +++ b/tests/test_for_support/test_for_biomass.py @@ -589,8 +589,7 @@ def test_production_biomass_precursors_exchange(model, num): """ biomass_rxns = helpers.find_biomass_reaction(model) for rxn in biomass_rxns: - for exchange in model.exchanges: - exchange.bounds = (-1000, 1000) + helpers.open_boundaries(model) blocked_mets = biomass.find_blocked_biomass_precursors(rxn, model) assert len(blocked_mets) == num
refactor: tests should also rely on unit tested functions for routine operations
opencobra_memote
train
py
e24543b96adb208897f4ce3eaab96b2f4df13106
diff --git a/semantic_release/pypi.py b/semantic_release/pypi.py index <HASH>..<HASH> 100644 --- a/semantic_release/pypi.py +++ b/semantic_release/pypi.py @@ -21,7 +21,6 @@ def upload_to_pypi( run('python setup.py {}'.format(dists)) twine_upload.upload( dists=['dist/*'], - repository='pypi', sign=False, identity=None, username=username, diff --git a/tests/test_pypi.py b/tests/test_pypi.py index <HASH>..<HASH> 100644 --- a/tests/test_pypi.py +++ b/tests/test_pypi.py @@ -16,7 +16,6 @@ class PypiTests(TestCase): ) mock_upload.assert_called_once_with( dists=['dist/*'], - repository='pypi', sign=False, identity=None, username=None,
fix: Remove repository argument in twine
relekang_python-semantic-release
train
py,py
6af8e505b5002d2c3e9750212654e02b7483b01f
diff --git a/lib/components/user/places/favorite-place-row.js b/lib/components/user/places/favorite-place-row.js index <HASH>..<HASH> 100644 --- a/lib/components/user/places/favorite-place-row.js +++ b/lib/components/user/places/favorite-place-row.js @@ -101,10 +101,14 @@ const FavoritePlaceRow = ({ isFixed, onDelete, path, place }) => { // If no place is passed, render the Add place button instead. return ( <Container> - <PlaceButton to={path}> - <GreyIcon name='plus' size='2x' /> - Add another place - </PlaceButton> + <LinkContainer + to={path} // FIXME: reinstate query params. + > + <PlaceButton to={path}> + <GreyIcon name='plus' size='2x' /> + Add another place + </PlaceButton> + </LinkContainer> <DeletePlaceholder /> </Container> )
refactor(FavoritePlaceRow): Fix new place broken link.
opentripplanner_otp-react-redux
train
js
1e566151d15a634c11fc56dbb87d756e0611dd52
diff --git a/packages/ra-ui-materialui/src/layout/CardContentInner.js b/packages/ra-ui-materialui/src/layout/CardContentInner.js index <HASH>..<HASH> 100644 --- a/packages/ra-ui-materialui/src/layout/CardContentInner.js +++ b/packages/ra-ui-materialui/src/layout/CardContentInner.js @@ -4,18 +4,22 @@ import classnames from 'classnames'; import CardContent from '@material-ui/core/CardContent'; import { withStyles } from '@material-ui/core/styles'; -const styles = { - root: { - paddingTop: 0, - paddingBottom: 0, - '&:first-child': { - paddingTop: 16, - }, - '&:last-child': { - paddingBottom: 16, - }, +var styles = theme => ({ + root: { + paddingTop: 0, + paddingBottom: 0, + '&:first-child': { + paddingTop: 16, }, -}; + '&:last-child': { + paddingBottom: 16, + // Reset on mouse devices + [theme.breakpoints.only('xs')]: { + paddingBottom: 70, + }, + }, + }, +}); /** * Overrides material-ui CardContent to allow inner content
fix: for issue #<I> making bottom padding for last child to be <I>px for xs media size
marmelab_react-admin
train
js
1775dea43f862aa991d5713a3b2279f64ecf587e
diff --git a/test/server.js b/test/server.js index <HASH>..<HASH> 100644 --- a/test/server.js +++ b/test/server.js @@ -1,6 +1,6 @@ import { expect } from 'chai'; -import uwave, { Uwave } from '../'; +import uwave, { Uwave } from '../src'; import testConfig from './test-server-config.json'; describe('üWave Core', () => { diff --git a/test/sources.js b/test/sources.js index <HASH>..<HASH> 100644 --- a/test/sources.js +++ b/test/sources.js @@ -1,7 +1,7 @@ import { expect } from 'chai'; -import uwave from '../'; -import Source from '../lib/Source'; +import uwave from '../src'; +import Source from '../src/Source'; import testConfig from './test-server-config.json'; describe('Media Sources', () => {
test: Run using src/ files everywhere (#<I>)
u-wave_core
train
js,js
a8adf3b16b9b40f71fa50cc056cf39550d08e885
diff --git a/docs/src/layouts/doc-layout/use-search.js b/docs/src/layouts/doc-layout/use-search.js index <HASH>..<HASH> 100644 --- a/docs/src/layouts/doc-layout/use-search.js +++ b/docs/src/layouts/doc-layout/use-search.js @@ -76,12 +76,9 @@ export default function useSearch (scope, $q, $route) { * @param {Number} datasetNumber this should always be equal to 1 as docs-searchbar.js is searching into one dataset at a time. You can ignore this attribute. * @param {Object} context additional information about the selection. Contains a .selectionMethod key that can be either click, enterKey, tabKey or blur, depending on how the suggestion was selected. */ - handleSelected: (input, event, suggestion, datasetNumber, context) => { - debugger - const url = suggestion.url.replace('https://next.quasar.dev', '') - + handleSelected (input, event, suggestion, datasetNumber, context) { search.value = '' - $router.push(url).catch(() => {}) + $router.push(suggestion.url).catch(() => {}) searchInputRef.value.blur() } })
feat(docs): small tweaks to the client-side search
quasarframework_quasar
train
js
564c6803d26a1781ddcdb3a41d10462bbf14b222
diff --git a/lib/firim/version.rb b/lib/firim/version.rb index <HASH>..<HASH> 100644 --- a/lib/firim/version.rb +++ b/lib/firim/version.rb @@ -1,3 +1,3 @@ module Firim - VERSION = "0.2.3" + VERSION = "0.2.4" end
chore: bump to <I>
whlsxl_firim
train
rb
47029a0e90890cfa56b8c82a7de5a53c1571c4f0
diff --git a/packages/create-webiny-project/bin.js b/packages/create-webiny-project/bin.js index <HASH>..<HASH> 100755 --- a/packages/create-webiny-project/bin.js +++ b/packages/create-webiny-project/bin.js @@ -1,6 +1,7 @@ #!/usr/bin/env node "use strict"; +const semver = require("semver"); const chalk = require("chalk"); const execa = require("execa"); const verifyConfig = require("./utils/verifyConfig"); @@ -30,12 +31,22 @@ const NODE_VERSION_MIN_MINOR = 14; } try { - await execa("yarn", ["--version"]); + const { stdout } = await execa("yarn", ["--version"]); + if (!semver.satisfies(stdout, "^1.22.0 || ^2")) { + console.error( + chalk.red( + `Webiny requires yarn@^1.22.0. Please run "npm install -g yarn" to update.` + ) + ); + process.exit(1); + } } catch (err) { console.error( chalk.red(`Webiny depends on "yarn" and its built-in support for workspaces.`) ); + console.log(`Please visit https://yarnpkg.com/ to install ${chalk.green("yarn")}.`); + process.exit(1); }
fix: check for yarn@^<I>
Webiny_webiny-js
train
js
8e60743c0b60ccddc0cab735b8f8648930bcd370
diff --git a/webpack.config.js b/webpack.config.js index <HASH>..<HASH> 100644 --- a/webpack.config.js +++ b/webpack.config.js @@ -46,7 +46,6 @@ const createConfig = options => { }, }, }, - ...require('snekfetch/webpack.supplemental').rules, ], }, node: {
fix: dont require snekfetch supplemental because they are not a thing anymore
discordjs_discord.js
train
js
92f90278a409ef31918b12647990c13f8025d43c
diff --git a/packages/bonde-admin/src/components/post-donation/finish-post-donation.js b/packages/bonde-admin/src/components/post-donation/finish-post-donation.js index <HASH>..<HASH> 100644 --- a/packages/bonde-admin/src/components/post-donation/finish-post-donation.js +++ b/packages/bonde-admin/src/components/post-donation/finish-post-donation.js @@ -1,8 +1,6 @@ -import { bool, string, object, oneOf } from 'prop-types' +import { bool, string, object } from 'prop-types' import React from 'react' -import TellAFriendBase from 'bonde-webpage/lib/ux/' - const FinishPostDonation = ({ preview, href, @@ -16,7 +14,7 @@ const FinishPostDonation = ({ return ( <div className='center p3 darkengray rounded'> - teste + Seu componente de pós-doação </div> ) }
feat(admin): refactor preview component
nossas_bonde-client
train
js
08e8e048c427d2a0acdb27fb0199776856037c99
diff --git a/java-container/google-cloud-container/src/test/java/com/google/cloud/container/v1/it/ITSystemTest.java b/java-container/google-cloud-container/src/test/java/com/google/cloud/container/v1/it/ITSystemTest.java index <HASH>..<HASH> 100644 --- a/java-container/google-cloud-container/src/test/java/com/google/cloud/container/v1/it/ITSystemTest.java +++ b/java-container/google-cloud-container/src/test/java/com/google/cloud/container/v1/it/ITSystemTest.java @@ -148,7 +148,7 @@ public class ITSystemTest { public void getServerConfigTest() { ServerConfig config = client.getServerConfig(PROJECT_ID, ZONE); assertNotNull(config); - assertEquals("COS", config.getDefaultImageType()); + assertEquals("COS_CONTAINERD", config.getDefaultImageType()); } @Test
fix: change the default node image to cos_containerd (#<I>)
googleapis_google-cloud-java
train
java
3d906de4710d39c0b046f6f1637556bea9c09f70
diff --git a/src/legacy.js b/src/legacy.js index <HASH>..<HASH> 100644 --- a/src/legacy.js +++ b/src/legacy.js @@ -18,8 +18,8 @@ export function Trail({ items, children, ...props }) { export function Transition({ items, keys = null, children, ...props }) { const transitions = useTransition(items, keys, props) - return transitions.map(({ item, key, props, slot }, index) => { - const result = children(item, slot, index) + return transitions.map(({ item, key, props, phase }, index) => { + const result = children(item, phase, index) const element = is.fun(result) ? result(props) : result return element && <element.type key={key} {...element.props} /> })
fix: incorrect property usage in Transition component
react-spring_react-spring
train
js
ebe108c024ebd451e69ac51d85f587a51d212228
diff --git a/test/space.spec.js b/test/space.spec.js index <HASH>..<HASH> 100644 --- a/test/space.spec.js +++ b/test/space.spec.js @@ -728,3 +728,35 @@ test('space supports circular dependencies as long as it is delayed, case2', t = } ).then(t.end); }); + +test('space supports above surface module id', t => { + const space = new Space(tesseract); + space.define('app', ['../package.json'], meta => meta.version); + space.define('../package.json', {version: '1.0.0'}); + + space.req('app').then( + result => { + t.equal(result, '1.0.0'); + } + ).catch( + err => { + t.fail(err.message); + } + ).then(t.end); +}); + +test('space supports above surface module id, case2', t => { + const space = new Space(tesseract); + space.define('foo/bar', ['../../package.json'], meta => meta.version); + space.define('../package.json', {version: '1.0.0'}); + + space.req('foo/bar').then( + result => { + t.equal(result, '1.0.0'); + } + ).catch( + err => { + t.fail(err.message); + } + ).then(t.end); +});
test: add test coverage on above surface module
dumberjs_dumber-module-loader
train
js
c56f6f60bf6c3ff11788de94d2265222412c3027
diff --git a/ipyvolume/test_all.py b/ipyvolume/test_all.py index <HASH>..<HASH> 100644 --- a/ipyvolume/test_all.py +++ b/ipyvolume/test_all.py @@ -4,6 +4,8 @@ import ipyvolume.examples import ipyvolume.datasets import numpy as np import os +import pytest + if not os.path.exists("tmp"): os.makedirs("tmp") @@ -118,6 +120,27 @@ def test_quick(): ipyvolume.quickscatter(x, y, z) ipyvolume.quickquiver(x, y, z, u, v, w) +@pytest.mark.parametrize("performance", [0,1]) +def test_widgets_state(performance): + try: + _remove_buffers = None + try: + from ipywidgets.widgets.widget import _remove_buffers + except: + pass + ipyvolume.serialize.performance = performance + x, y, z = np.random.random((3, 100)) + p3.figure() + scatter = p3.scatter(x, y, z) + state = scatter.get_state() + if _remove_buffers: + _remove_buffers(state) + else: + scatter._split_state_buffers(state) + finally: + ipyvolume.serialize.performance = 0 + + # just cover and call ipyvolume.examples.ball() ipyvolume.examples.example_ylm()
test: reflects changes in ipywidgets (upcoming)
maartenbreddels_ipyvolume
train
py
a26496c563de6ff59d308c9f66c9585b521b7ba8
diff --git a/addon/components/flexi-sustain.js b/addon/components/flexi-sustain.js index <HASH>..<HASH> 100644 --- a/addon/components/flexi-sustain.js +++ b/addon/components/flexi-sustain.js @@ -36,6 +36,8 @@ const component = Component.extend({ if (!this.label) { this.label = this.component; + } else { + this.label = `${this.component}:${this.label}`; } let properties = this.getProperties('label', 'component', 'model', 'copy', 'expires');
fix(labels): ensure labels are namespaced
html-next_flexi-layouts
train
js
3afc78dab5fb2451a2eda04b12eb6394bafc3079
diff --git a/lib/config/definitions.js b/lib/config/definitions.js index <HASH>..<HASH> 100644 --- a/lib/config/definitions.js +++ b/lib/config/definitions.js @@ -774,13 +774,13 @@ const options = [ { name: 'assignees', description: - 'Assignees for Pull Request (user name in GitHub/GitLab, email address in VSTS)', + 'Assignees for Pull Request (username in GitHub/GitLab, email address in VSTS)', type: 'list', }, { name: 'reviewers', description: - 'Requested reviewers for Pull Requests (user name in GitHub/GitLab, email or user name in VSTS)', + 'Requested reviewers for Pull Requests (username in GitHub/GitLab, email or username in VSTS)', type: 'list', }, {
chore: renamed "user name" to "username" in definitions.js (#<I>) Changed `user name` to `username` in description to clarify we want a login name and not the user's actual name.
renovatebot_renovate
train
js
e31c5ca1a88a32e425f9e28abbdfd66d4309c5c6
diff --git a/src/structures/Role.js b/src/structures/Role.js index <HASH>..<HASH> 100644 --- a/src/structures/Role.js +++ b/src/structures/Role.js @@ -20,6 +20,18 @@ class Role extends Base { */ this.guild = guild; + /** + * The icon hash of the role + * @type {?string} + */ + this.icon = null; + + /** + * The unicode emoji for the role + * @type {?string} + */ + this.unicodeEmoji = null; + if (data) this._patch(data); } @@ -91,17 +103,9 @@ class Role extends Base { */ this.deleted = false; - /** - * The icon hash of the role - * @type {?string} - */ - this.icon = data.icon; + if ('icon' in data) this.icon = data.icon; - /** - * The unicode emoji for the role - * @type {?string} - */ - this.unicodeEmoji = data.unicode_emoji; + if ('unicode_emoji' in data) this.unicodeEmoji = data.unicode_emoji; /** * The tags this role has
fix(Role): check for presence of icon and unicode_emoji before patching (#<I>)
discordjs_discord.js
train
js
c21b8a5e404b0c954e9085d52cdd77a3931393e9
diff --git a/packages/simplebar/webpack.config.js b/packages/simplebar/webpack.config.js index <HASH>..<HASH> 100644 --- a/packages/simplebar/webpack.config.js +++ b/packages/simplebar/webpack.config.js @@ -11,6 +11,8 @@ module.exports = { contentBase: './demo', port: 8090, inline: true + // host: "0.0.0.0", + // allowedHosts: ['.local'] }, module: { rules: [ @@ -21,10 +23,10 @@ module.exports = { loader: 'babel-loader', options: { presets: [ - ["@babel/preset-env", { "modules": false }], - "@babel/preset-react" + ['@babel/preset-env', { modules: false }], + '@babel/preset-react' ] - }, + } } }, { @@ -32,5 +34,5 @@ module.exports = { use: ['style-loader', 'css-loader'] } ] - }, + } };
chore: add config for remote debugging
Grsmto_simplebar
train
js
ec6e7d963baa72aec959cc4c62e74ee6a6204662
diff --git a/website/src/data/config.js b/website/src/data/config.js index <HASH>..<HASH> 100644 --- a/website/src/data/config.js +++ b/website/src/data/config.js @@ -1,9 +1,9 @@ export default { // local - // nivoApiUrl: 'http://localhost:3030', + // nivoApiUrl: 'http://localhost:3030/nivo', // storybookUrl: 'http://localhost:6006/', // production - nivoApiUrl: 'https://nivo-api.herokuapp.com', + nivoApiUrl: 'https://nivo-api.herokuapp.com/nivo', storybookUrl: 'https://nivo.rocks/storybook/', }
feat(website): update the API url to match the new path
plouc_nivo
train
js
8c2b7de9c7dcf1f25fa4bf3f2b334994cf3e453f
diff --git a/dramatiq/brokers/__init__.py b/dramatiq/brokers/__init__.py index <HASH>..<HASH> 100644 --- a/dramatiq/brokers/__init__.py +++ b/dramatiq/brokers/__init__.py @@ -1,2 +1,11 @@ -from .rabbitmq import RabbitmqBroker # noqa +import warnings + from .stub import StubBroker # noqa + +try: + from .rabbitmq import RabbitmqBroker # noqa +except ImportError as e: + warnings.warn( + "RabbitmqBroker not available. `pip install dramatiq[rabbitmq]` to get RabbitMQ support.", + category=RuntimeWarning, stacklevel=2, + )
refactor: fail gracefully if rabbitmq support isn't vailable
Bogdanp_dramatiq
train
py
62e88d0236209c1c5e884dfc687571c75fe24fc4
diff --git a/packages/csv-parse/samples/recipe.file.js b/packages/csv-parse/samples/recipe.file.js index <HASH>..<HASH> 100644 --- a/packages/csv-parse/samples/recipe.file.js +++ b/packages/csv-parse/samples/recipe.file.js @@ -1,6 +1,6 @@ import assert from 'assert'; -import fs from 'fs/promises'; +import {promises as fs} from 'fs'; // 'fs/promises' not available in node 12 import os from 'os'; import { parse } from '../lib/sync.js'; diff --git a/packages/csv-parse/samples/recipe.file.utf16le.js b/packages/csv-parse/samples/recipe.file.utf16le.js index <HASH>..<HASH> 100644 --- a/packages/csv-parse/samples/recipe.file.utf16le.js +++ b/packages/csv-parse/samples/recipe.file.utf16le.js @@ -1,6 +1,6 @@ import assert from 'assert'; -import fs from 'fs/promises'; +import {promises as fs} from 'fs'; import os from 'os'; import { parse } from '../lib/sync.js';
docs(csv-parse): file sample compatible with node <I>
adaltas_node-csv
train
js,js
61dae94a8f06b230908c6ef371aba2fa857cb5f2
diff --git a/public/js/editors/panel.js b/public/js/editors/panel.js index <HASH>..<HASH> 100644 --- a/public/js/editors/panel.js +++ b/public/js/editors/panel.js @@ -583,7 +583,9 @@ function populateEditor(editor, panel) { editor.setCode(template[panel]); } - editor.editor.clearHistory(); + if (editor.editor && editor.editor.clearHistory) { + editor.editor.clearHistory(); + } } else { // this means it was set via the url
fix: JS error in mobile view
jsbin_jsbin
train
js
2d66387ffab17052890f5c85cb3a1d438fff2656
diff --git a/lib/commands/build.js b/lib/commands/build.js index <HASH>..<HASH> 100644 --- a/lib/commands/build.js +++ b/lib/commands/build.js @@ -102,7 +102,7 @@ module.exports = Command.extend({ outputPath: options.cordovaOutputPath }); - var cordovaOpts = parseCordovaOpts(platform, platform); + var cordovaOpts = parseCordovaOpts(platform, options); var cordovaBuild = new CdvBuildTask({ project: project, platform: platform,
fix(build-command): pass options to cordova opt parser
isleofcode_ember-cordova
train
js
5181f68a94f48924d2a8c000c1d4357fc7b97078
diff --git a/packages/cli/lib/read-input.js b/packages/cli/lib/read-input.js index <HASH>..<HASH> 100644 --- a/packages/cli/lib/read-input.js +++ b/packages/cli/lib/read-input.js @@ -66,8 +66,11 @@ module.exports = function readInput(include, extensions, sep) { while (input && typeof input === 'object') { const keys = Object.keys(input); - if (keys.length === 1) input = input[keys[0]]; - else break; + if (keys.length === 1) { + const child = input[keys[0]]; + if (!child || typeof child !== 'object') break; + input = child; + } else break; } return input; };
fix(cli): Do not drop initial keys for single-message input files (#<I>)
messageformat_messageformat
train
js
4bd482dbc4702030c2b79aae3676950ba1490805
diff --git a/superset-frontend/temporary_superset_ui/superset-ui/plugins/superset-ui-plugins/packages/superset-ui-legacy-preset-chart-nvd3/src/NVD3Vis.js b/superset-frontend/temporary_superset_ui/superset-ui/plugins/superset-ui-plugins/packages/superset-ui-legacy-preset-chart-nvd3/src/NVD3Vis.js index <HASH>..<HASH> 100644 --- a/superset-frontend/temporary_superset_ui/superset-ui/plugins/superset-ui-plugins/packages/superset-ui-legacy-preset-chart-nvd3/src/NVD3Vis.js +++ b/superset-frontend/temporary_superset_ui/superset-ui/plugins/superset-ui-plugins/packages/superset-ui-legacy-preset-chart-nvd3/src/NVD3Vis.js @@ -554,7 +554,7 @@ function nvd3Vis(element, props) { chart.useInteractiveGuideline(true); if (vizType === 'line') { chart.interactiveLayer.tooltip.contentGenerator(d => - generateRichLineTooltipContent(d, xAxisFormatter, yAxisFormatter), + generateRichLineTooltipContent(d, smartDateVerboseFormatter, yAxisFormatter), ); } }
fix: line chart tooltip should use full datetime format (#<I>)
apache_incubator-superset
train
js
627e376cfb3243d562acee945e31284427a05065
diff --git a/src/dialog/Dialog.js b/src/dialog/Dialog.js index <HASH>..<HASH> 100644 --- a/src/dialog/Dialog.js +++ b/src/dialog/Dialog.js @@ -50,7 +50,7 @@ export default createComponent({ }, }, - emits: ['opened', 'closed', 'confirm', 'cancel', 'update:show'], + emits: ['confirm', 'cancel', 'update:show'], data() { return { @@ -97,14 +97,6 @@ export default createComponent({ } }, - onOpened() { - this.$emit('opened'); - }, - - onClosed() { - this.$emit('closed'); - }, - genRoundButtons() { return ( <ActionBar class={bem('footer')}> @@ -215,8 +207,6 @@ export default createComponent({ transition={this.transition} lazyRender={this.lazyRender} aria-labelledby={this.title || message} - onOpened={this.onOpened} - onClosed={this.onClosed} > {Title} {this.genContent(title)}
perf(Dialog): inherit opened event
youzan_vant
train
js
64dd2e6ebe3a83a1aa57abcaaaec96476f7256dc
diff --git a/lib/parse-args.js b/lib/parse-args.js index <HASH>..<HASH> 100644 --- a/lib/parse-args.js +++ b/lib/parse-args.js @@ -3,6 +3,7 @@ const findUp = require('find-up') const { readFileSync } = require('fs') const Yargs = require('yargs/yargs') const parser = require('yargs-parser') +const { resolve } = require('path') const configPath = findUp.sync(['.c8rc', '.c8rc.json', '.nycrc', `.nycrc.json`]) const config = configPath ? JSON.parse(readFileSync(configPath)) : {} @@ -86,7 +87,7 @@ function buildYargs (withCommands = false) { .demandCommand(1) .check((argv) => { if (!argv.tempDirectory) { - argv.tempDirectory = argv.reportsDir + argv.tempDirectory = resolve(argv.reportsDir, 'tmp') } return true })
fix: temporary files should be in tmp folder (#<I>)
bcoe_c8
train
js
d3f4a11261a5ee94a85c097f9bf0fb0e83447533
diff --git a/packages/modal/src/Modal.js b/packages/modal/src/Modal.js index <HASH>..<HASH> 100644 --- a/packages/modal/src/Modal.js +++ b/packages/modal/src/Modal.js @@ -60,9 +60,9 @@ const Modal = ({ unique: true, }); const slide = useTransition(isOpen, null, { - from: { transform: "translate3D(0, 50px, 0)" }, + from: { transform: "translate3D(0, -50px, 0)" }, enter: { transform: "translate3D(0, 0px, 0)" }, - leave: { transform: "translate3D(0, -100px, 0)" }, + leave: { transform: "translate3D(0, 50px, 0)" }, unique: true, });
feat(modal): swap transition direction affects: @crave/farmblocks-modal
CraveFood_farmblocks
train
js
7601e26360226e77c4c8d631227a248e7a81afc2
diff --git a/scripts/serverless.js b/scripts/serverless.js index <HASH>..<HASH> 100755 --- a/scripts/serverless.js +++ b/scripts/serverless.js @@ -516,7 +516,10 @@ const processSpanPromise = (async () => { } await resolveVariables(resolverConfiguration); - if (!variablesMeta.size) return; + if (!variablesMeta.size) { + serverless.isConfigurationInputResolved = true; + return; + } if ( eventuallyReportVariableResolutionErrors(configurationPath, configuration, variablesMeta) ) {
refactor(Variables): Do not run old resolver when not needed
serverless_serverless
train
js
0a9ee9360c81e12e2a09de6aa76e7c7d2a5a4eee
diff --git a/lib/ditty/controllers/component.rb b/lib/ditty/controllers/component.rb index <HASH>..<HASH> 100644 --- a/lib/ditty/controllers/component.rb +++ b/lib/ditty/controllers/component.rb @@ -29,7 +29,7 @@ module Ditty format.json do # TODO: Add links defined by actions (New #{heading}) json( - 'items' => list.map(&:for_json), + 'items' => list.all.map(&:for_json), 'page' => params[:page], 'count' => list.count, 'total' => dataset.count
fix: Use all, instead of map, because can't run new query within connection. See Dataset#each
EagerELK_ditty
train
rb
707b28ae7ca235911775d799a2c8dfc3a604f8fe
diff --git a/src/Reader/StringReader.php b/src/Reader/StringReader.php index <HASH>..<HASH> 100644 --- a/src/Reader/StringReader.php +++ b/src/Reader/StringReader.php @@ -30,10 +30,8 @@ class StringReader implements ReaderInterface // any lines found? loop them if ( ! empty($lines)) { + $lines = array_values(array_filter($lines)); // filter out blank lines & re-index foreach ($lines as $i => $line) { - if ($line==='') { - continue; // blank line... - } $fields = str_getcsv($line, $d, $e); $data[$i] = array(); // loop the headings to map to columns
fix: better way of filtering lines & reseting indexes to be in order
stilliard_CsvParser
train
php
df69c9e3a25b726f7645fed9487e108f1d9b472c
diff --git a/lib/workers/pr/index.js b/lib/workers/pr/index.js index <HASH>..<HASH> 100644 --- a/lib/workers/pr/index.js +++ b/lib/workers/pr/index.js @@ -175,6 +175,11 @@ async function ensurePr(prConfig) { /(https?:\/\/github.com\/[^/]*\/[^/]*\/(issues|pull)\/\w+)/g, '`$1`' ); + logger.trace('Escaping links to GitHub users'); + prBody = prBody.replace( + /]\(https?:\/\/github.com\/[a-z\d](?:[a-z\d]|-(?=[a-z\d])){0,38}\)/gi, + ']' + ); // convert escaped backticks back to ` const backTickRe = /&#x60;([^/]*?)&#x60;/g; prBody = prBody.replace(backTickRe, '`$1`');
fix: escape links to GitHub usernames
renovatebot_renovate
train
js
8fa04c5786f15affe843eba600bccd557cb2a89d
diff --git a/ui/src/utils/colors.js b/ui/src/utils/colors.js index <HASH>..<HASH> 100644 --- a/ui/src/utils/colors.js +++ b/ui/src/utils/colors.js @@ -241,12 +241,12 @@ export function blend (fgColor, bgColor) { r1 = rgb1.r / 255, g1 = rgb1.g / 255, b1 = rgb1.b / 255, - a1 = rgb1.a !== void 0 ? rgb1.a / 255 : 1, + a1 = rgb1.a !== void 0 ? rgb1.a / 100 : 1, rgb2 = typeof bgColor === 'string' ? textToRgb(bgColor) : bgColor, r2 = rgb2.r / 255, g2 = rgb2.g / 255, b2 = rgb2.b / 255, - a2 = rgb2.a !== void 0 ? rgb2.a / 255 : 1, + a2 = rgb2.a !== void 0 ? rgb2.a / 100 : 1, a = a1 + a2 * (1 - a1), r = Math.round(((r1 * a1 + r2 * a2 * (1 - a1)) / a) * 255), g = Math.round(((g1 * a1 + g2 * a2 * (1 - a1)) / a) * 255),
fix(colors): blend alpha after textToRgb is 0-<I> (#<I>)
quasarframework_quasar
train
js
5e2d52549ff4651ccce8958d5fc8c57ab3d125a6
diff --git a/SpiffWorkflow/storage/DictionarySerializer.py b/SpiffWorkflow/storage/DictionarySerializer.py index <HASH>..<HASH> 100644 --- a/SpiffWorkflow/storage/DictionarySerializer.py +++ b/SpiffWorkflow/storage/DictionarySerializer.py @@ -315,8 +315,8 @@ class DictionarySerializer(Serializer): def _serialize_sub_workflow(self, spec): s_state = self._serialize_task_spec(spec) s_state['file'] = spec.file - s_state['in_assign'] = self._serialize_dict(spec.in_assign) - s_state['out_assign'] = self._serialize_dict(spec.out_assign) + s_state['in_assign'] = self._serialize_list(spec.in_assign) + s_state['out_assign'] = self._serialize_list(spec.out_assign) return s_state def _deserialize_sub_workflow(self, wf_spec, s_state):
fix: DictionarySerializer._(de)serialize_sub_workflow handles in|out_assign as dict instead of list. #<I>
knipknap_SpiffWorkflow
train
py
cc87c56826d89c68628d734b2556972357245bb6
diff --git a/packages/node_modules/@webex/webex-core/src/lib/services/services.js b/packages/node_modules/@webex/webex-core/src/lib/services/services.js index <HASH>..<HASH> 100644 --- a/packages/node_modules/@webex/webex-core/src/lib/services/services.js +++ b/packages/node_modules/@webex/webex-core/src/lib/services/services.js @@ -191,8 +191,8 @@ const Services = WebexPlugin.extend({ return Promise.reject(new Error('`email` is required')); } - // Destructure the credentials config object. - const {canAuthorize} = this.webex.config; + // Destructure the credentials object. + const {canAuthorize} = this.webex.credentials; // Validate that the user is already authorized. if (canAuthorize) {
fix: read canAuthorize from credentials
webex_spark-js-sdk
train
js
166110ccf272f6fb1c6cac76cedd8e10140c6857
diff --git a/rollup.config.js b/rollup.config.js index <HASH>..<HASH> 100644 --- a/rollup.config.js +++ b/rollup.config.js @@ -49,7 +49,7 @@ export default [ scss({ output: 'docs/assets/dist/css/docs.min.css', outputStyle: 'compressed', - watch: 'src/scss', + watch: 'docs/assets/src/scss', }), ], },
chore: add watch for docs scss files
italia_bootstrap-italia
train
js
8d6032b8dc2cbe40e08771f875ea7add94231b20
diff --git a/lib/wireprotocol/3_2_support.js b/lib/wireprotocol/3_2_support.js index <HASH>..<HASH> 100644 --- a/lib/wireprotocol/3_2_support.js +++ b/lib/wireprotocol/3_2_support.js @@ -329,6 +329,11 @@ WireProtocol.prototype.getMore = function( queryOptions.session = cursorState.session; } + // We need to increment the statement id if we're in a transaction + if (options.session && options.session.inTransaction()) { + incrementStatementId(options.session); + } + // Write out the getMore command connection.write(query, queryOptions, queryCallback); };
refactor(wire-protocol): ensure stmtId is incremented on getMore
mongodb-js_mongodb-core
train
js
3a1786f614aff35bf047743bb0cf2e1d84814330
diff --git a/packages/mdc-slider/index.js b/packages/mdc-slider/index.js index <HASH>..<HASH> 100644 --- a/packages/mdc-slider/index.js +++ b/packages/mdc-slider/index.js @@ -202,4 +202,4 @@ class MDCSlider extends MDCComponent { } } -export {MDCSlider}; +export {MDCSliderFoundation, MDCSlider};
fix(slider): Add MDCSliderFoundation export (#<I>)
material-components_material-components-web
train
js
e4c1631be611190992a46ef3ede15514654fa870
diff --git a/src/extensions/physics/physics.js b/src/extensions/physics/physics.js index <HASH>..<HASH> 100644 --- a/src/extensions/physics/physics.js +++ b/src/extensions/physics/physics.js @@ -148,6 +148,7 @@ } space.removeBody(body); } + this._deleteBodies.length = 0; }, /** * 绑定物理刚体
fix: physicss unbindView bug
hiloteam_Hilo
train
js
b42baa340649c5bb0b9919e002657bde014d20a0
diff --git a/src/chart/heatmap/HeatmapView.js b/src/chart/heatmap/HeatmapView.js index <HASH>..<HASH> 100644 --- a/src/chart/heatmap/HeatmapView.js +++ b/src/chart/heatmap/HeatmapView.js @@ -185,10 +185,10 @@ export default echarts.extendChartView({ rect = new graphic.Rect({ shape: { - x: point[0] - width / 2, - y: point[1] - height / 2, - width: width, - height: height + x: Math.floor(point[0] - width / 2), + y: Math.floor(point[1] - height / 2), + width: Math.ceil(width), + height: Math.ceil(height) }, style: { fill: data.getItemVisual(idx, 'color'),
fix(heatmap): Remove seams in heatmap
apache_incubator-echarts
train
js
d22150409640131be870ec9494c2880da6c09b06
diff --git a/test/test.js b/test/test.js index <HASH>..<HASH> 100644 --- a/test/test.js +++ b/test/test.js @@ -242,7 +242,7 @@ test.cb('process all rows', (t) => { test('binary stanity', async (t) => { const binPath = path.resolve(__dirname, '../bin/csv-parser') - const { stdout } = await execa(`echo "a\n1" | node ${binPath}`, { shell: true }) + const { stdout } = await execa(`echo "a\n1" | ${process.execPath} ${binPath}`, { shell: true }) t.snapshot(stdout) })
chore: use `process.execPath` rather than `node` in test (#<I>) Make sure that the test is run with the version of Node.js currently being used to execute the test suite, rather than whatever is first in the user's path.
mafintosh_csv-parser
train
js
91684e213666698ee9ed63ed7225fda7d8c4b41e
diff --git a/packages/webpack/lib/plugins/log.js b/packages/webpack/lib/plugins/log.js index <HASH>..<HASH> 100644 --- a/packages/webpack/lib/plugins/log.js +++ b/packages/webpack/lib/plugins/log.js @@ -54,7 +54,13 @@ exports.LoggerPlugin = class LoggerPlugin { const hasWarnings = stats.hasWarnings(); const hasErrors = stats.hasErrors(); - const { assets, errors, warnings, children } = stats.toJson(); + const { assets, errors, warnings, children } = stats.toJson({ + all: false, + assets: true, + errors: true, + warnings: true, + children: true, + }); if (hasErrors) { this.logger.info(formatError(name, duration, isRebuild)); diff --git a/packages/webpack/mixins/build/mixin.core.js b/packages/webpack/mixins/build/mixin.core.js index <HASH>..<HASH> 100644 --- a/packages/webpack/mixins/build/mixin.core.js +++ b/packages/webpack/mixins/build/mixin.core.js @@ -43,7 +43,7 @@ class WebpackBuildMixin extends Mixin { if (error) { reject(error); } else if (stats.hasErrors()) { - const { errors } = stats.toJson(); + const { errors } = stats.toJson({ all: false, errors: true }); reject(new Error(`Build failed with ${errors.length} error(s)`)); } else { resolve(stats);
refactor(webpack): restrict stats usage to further improve performance
untool_untool
train
js,js
b8036e4d2e0bee66985e6973478148f2dccd43d7
diff --git a/src/navigation-instruction.js b/src/navigation-instruction.js index <HASH>..<HASH> 100644 --- a/src/navigation-instruction.js +++ b/src/navigation-instruction.js @@ -167,6 +167,7 @@ export class NavigationInstruction { return this.fragment; } + path = encodeURI(path); return this.fragment.substr(0, this.fragment.lastIndexOf(path)); }
fix(navigation-instruction): incorrect base url extraction Fixes #<I>
aurelia_router
train
js
b9bdb48e4c2d0de0496b15a035b7d95c326c997e
diff --git a/cloudvolume/skeleton.py b/cloudvolume/skeleton.py index <HASH>..<HASH> 100644 --- a/cloudvolume/skeleton.py +++ b/cloudvolume/skeleton.py @@ -528,7 +528,7 @@ class Skeleton(object): edges = self.edges if self.empty(): - return Skeleton() + return Skeleton(segid=self.id) eff_vertices, uniq_idx, idx_representative = np.unique( nodes, axis=0, return_index=True, return_inverse=True
fix: preserve segid for empty skeleton consolidation
seung-lab_cloud-volume
train
py
7d32c2735a6d1f4468dfd1bc58cc224296e86f3c
diff --git a/util/lua/health_test.go b/util/lua/health_test.go index <HASH>..<HASH> 100644 --- a/util/lua/health_test.go +++ b/util/lua/health_test.go @@ -34,7 +34,7 @@ func getObj(path string) *unstructured.Unstructured { } func TestLuaHealthScript(t *testing.T) { - err := filepath.Walk(".", func(path string, f os.FileInfo, err error) error { + err := filepath.Walk("../../resource_customizations", func(path string, f os.FileInfo, err error) error { if !strings.Contains(path, "health.lua") { return nil }
chore: Correct path to resource_customizations in TestLuaHealthScript (#<I>)
argoproj_argo-cd
train
go
c5a62384da287e17ae82ac161a7e50fa19fcd5e2
diff --git a/google-cloud-asset/synth.py b/google-cloud-asset/synth.py index <HASH>..<HASH> 100644 --- a/google-cloud-asset/synth.py +++ b/google-cloud-asset/synth.py @@ -18,6 +18,7 @@ import synthtool as s import synthtool.gcp as gcp import synthtool.languages.ruby as ruby import logging +import os import re import shutil from subprocess import call @@ -58,7 +59,11 @@ orgpolicy_library = gapic2.ruby_library( s.copy(orgpolicy_library / 'lib/google/cloud/orgpolicy') s.copy(orgpolicy_library / 'proto_docs/google/cloud/orgpolicy') -shutil.move('proto_docs', 'lib/google/cloud/orgpolicy/v1/doc') +os.makedirs('lib/google/cloud/orgpolicy/v1/doc/google/cloud/orgpolicy/v1', exist_ok=True) +shutil.move( + 'proto_docs/google/cloud/orgpolicy/v1/orgpolicy.rb', + 'lib/google/cloud/orgpolicy/v1/doc/google/cloud/orgpolicy/v1/orgpolicy.rb' +) # Copy common templates templates = gcp.CommonTemplates().ruby_library()
chore(asset): move orgpolicy docs to the correct location
googleapis_google-cloud-ruby
train
py
e8284abe9499cbed2f9c7b1033ae35c2ff25a0e6
diff --git a/packages/breadcrumb/src/css/index.js b/packages/breadcrumb/src/css/index.js index <HASH>..<HASH> 100644 --- a/packages/breadcrumb/src/css/index.js +++ b/packages/breadcrumb/src/css/index.js @@ -1,9 +1,9 @@ -import * as core from '@pluralsight/ps-design-system-core' +import { layout } from '@pluralsight/ps-design-system-core' export default { '.psds-breadcrumb': { - paddingTop: core.layout.spacingMedium, - paddingBottom: core.layout.spacingMedium, + paddingTop: layout.spacingMedium, + paddingBottom: layout.spacingMedium, lineHeight: 0 } }
feat(breadcrumb): update to use named import
pluralsight_design-system
train
js
6fab298e1d77864689eaa536e9c1a96d9dd61420
diff --git a/benchbuild/source/git.py b/benchbuild/source/git.py index <HASH>..<HASH> 100644 --- a/benchbuild/source/git.py +++ b/benchbuild/source/git.py @@ -7,7 +7,7 @@ import typing as tp import plumbum as pb from plumbum.commands.base import BoundCommand -from benchbuild.utils.cmd import git, mkdir +from benchbuild.utils.cmd import git, ln, mkdir from . import base @@ -88,7 +88,9 @@ class Git(base.FetchableSource): str: [description] """ src_loc = self.fetch() - tgt_loc = pb.local.path(target_dir) / f'{self.local}-{version}' + active_loc = pb.local.path(target_dir) / f'{self.local}' + tgt_subdir = f'{self.local}-{version}' + tgt_loc = pb.local.path(target_dir) / tgt_subdir clone = git['clone'] pull = git['pull'] @@ -108,6 +110,7 @@ class Git(base.FetchableSource): ) checkout('--detach', version) + ln('-sf', tgt_subdir, active_loc) return tgt_loc def versions(self) -> tp.List[base.Variant]:
feat(source): Link to active location after version() This updates a symlink to our current active version inside the build directory.
PolyJIT_benchbuild
train
py
e03d9e42d6193deeb418fe490a910880418e1b9c
diff --git a/zappa/core.py b/zappa/core.py index <HASH>..<HASH> 100644 --- a/zappa/core.py +++ b/zappa/core.py @@ -2741,14 +2741,7 @@ class Zappa(object): """ Remove the DynamoDB Table used for async return values """ - - topic_name = get_topic_name(lambda_name) - removed_arns = [] - for sub in self.sns_client.list_subscriptions()['Subscriptions']: - if topic_name in sub['TopicArn']: - self.sns_client.delete_topic(TopicArn=sub['TopicArn']) - removed_arns.append(sub['TopicArn']) - return removed_arns + self.dynamodb_client.delete_table(TableName=table_name) ## # CloudWatch Logging
fix: Removed async dynamodb table (resolves #<I>)
Miserlou_Zappa
train
py
f0329754786553f105214ea4bb2a9ea1e9ed1fe7
diff --git a/aresponses/main.py b/aresponses/main.py index <HASH>..<HASH> 100644 --- a/aresponses/main.py +++ b/aresponses/main.py @@ -179,7 +179,7 @@ class ResponsesMockServer(BaseTestServer): return route, response self._unmatched_requests.append(request) - return route, None + return None, None async def passthrough(self, request): """Make non-mocked network request"""
fix: don't return undefined variable
CircleUp_aresponses
train
py
7cb04646b9127db41c507182ef90f36da2a6a0b6
diff --git a/tasks/build.js b/tasks/build.js index <HASH>..<HASH> 100644 --- a/tasks/build.js +++ b/tasks/build.js @@ -1,26 +1,24 @@ 'use strict'; -var del = require('del'); -var prompt = require('gulp-prompt'); -var exec = require('gulp-exec'); - module.exports = function (gulp, config) { return { clean: function (cb) { - del([config.build.distPath + '**/*'], cb); + require('del')([config.build.distPath + '**/*'], cb); }, deploy: function() { - var reportOptions = { err: true, stderr: true, stdout: true }; + var prompt = require('gulp-prompt'); + var exec = require('gulp-exec'); + return gulp.src('gulpfile.js') .pipe(prompt.confirm({ message: 'Do you really want to deploy to production?', default: false })) .pipe(exec('git pull origin master; git push origin master;git push origin master:production')) - .pipe(exec.reporter(reportOptions)); + .pipe(exec.reporter({ err: true, stderr: true, stdout: true })); } };
chore(packages): inline requires in the build tasks
emartech_boar-tasks-client
train
js
80612540b75f7480bb726c8a2982ace4fb076f49
diff --git a/lib/components/user/trip-summary.js b/lib/components/user/trip-summary.js index <HASH>..<HASH> 100644 --- a/lib/components/user/trip-summary.js +++ b/lib/components/user/trip-summary.js @@ -30,11 +30,11 @@ class TripSummary extends Component { }) } - async componentDidMount () { + componentDidMount () { this.updateQueryState() } - async componentDidUpdate (prevProps) { + componentDidUpdate (prevProps) { // Update the state the monitoredTrip prop has changed. if (this.props.monitoredTrip !== prevProps.monitoredTrip) { this.updateQueryState()
refactor(TripSummary): Remove unused async.
opentripplanner_otp-react-redux
train
js
f8f544f14c8b0d1aef00a315aa771750dc4d7ba6
diff --git a/ui/src/components/fab/QFabAction.js b/ui/src/components/fab/QFabAction.js index <HASH>..<HASH> 100644 --- a/ui/src/components/fab/QFabAction.js +++ b/ui/src/components/fab/QFabAction.js @@ -41,7 +41,7 @@ export default defineComponent({ setup (props, { slots, emit }) { const $fab = inject(fabKey, () => ({ - showing: true, + showing: { value: true }, onChildClick: noop }))
feat(QFabAction): Allow using QFabAction outside QFab #<I> (#<I>)
quasarframework_quasar
train
js
627f87fe51ab32110d32f1e54c523ff56ab25908
diff --git a/build/webpack.base.config.js b/build/webpack.base.config.js index <HASH>..<HASH> 100644 --- a/build/webpack.base.config.js +++ b/build/webpack.base.config.js @@ -9,14 +9,6 @@ module.exports = { '@': resolve('../src') } }, - externals: { - vue: { - commonjs: 'vue', - commonjs2: 'vue', - amd: 'vue', - root: 'Vue' - } - }, node: { fs: 'empty' }, diff --git a/build/webpack.prod.config.js b/build/webpack.prod.config.js index <HASH>..<HASH> 100644 --- a/build/webpack.prod.config.js +++ b/build/webpack.prod.config.js @@ -26,6 +26,14 @@ module.exports = merge(baseWebpackConfig, { libraryTarget: 'umd', libraryExport: 'default' }, + externals: { + vue: { + commonjs: 'vue', + commonjs2: 'vue', + amd: 'vue', + root: 'Vue' + } + }, module: { noParse: /es6-promise\.js$/, // avoid webpack shimming process rules: [
fix(dev): only use externals in production builds
vuetifyjs_vuetify
train
js,js
a14f6964a8e32aab51fc922a22f0ebd4169a332b
diff --git a/src/CreateSignalFactory.js b/src/CreateSignalFactory.js index <HASH>..<HASH> 100644 --- a/src/CreateSignalFactory.js +++ b/src/CreateSignalFactory.js @@ -129,8 +129,6 @@ module.exports = function (controller, model, services, compute, modules) { runBranch(branch, index + 1) } else { - controller.emit('change', {signal: signal}) - var promises = currentBranch.map(function (action) { controller.emit('actionStart', {action: action, signal: signal}) var actionFunc = actions[action.actionIndex] @@ -172,6 +170,7 @@ module.exports = function (controller, model, services, compute, modules) { } }) }) + controller.emit('change', {signal: signal}) return Promise.all(promises) .then(function () { return runBranch(branch, index + 1, Date.now())
fix(signalFactory): emit 'change' event after mapping async actions promises Allows debugger to indicate running async actions.
cerebral_cerebral
train
js
10659b87c19a0ef88e7e359408872a6b15609dc0
diff --git a/engine-rest/engine-rest/src/test/java/org/camunda/bpm/engine/rest/util/container/TomcatServerBootstrap.java b/engine-rest/engine-rest/src/test/java/org/camunda/bpm/engine/rest/util/container/TomcatServerBootstrap.java index <HASH>..<HASH> 100644 --- a/engine-rest/engine-rest/src/test/java/org/camunda/bpm/engine/rest/util/container/TomcatServerBootstrap.java +++ b/engine-rest/engine-rest/src/test/java/org/camunda/bpm/engine/rest/util/container/TomcatServerBootstrap.java @@ -40,7 +40,8 @@ public abstract class TomcatServerBootstrap extends EmbeddedServerBootstrap { String contextPath = "/" + getContextPath(); - PomEquippedResolveStage resolver = Maven.resolver().loadPomFromFile("pom.xml"); + PomEquippedResolveStage resolver = Maven.configureResolver() + .useLegacyLocalRepo(true).loadPomFromFile("pom.xml"); WebArchive wa = ShrinkWrap.create(WebArchive.class, "rest-test.war").setWebXML(webXmlPath) .addAsLibraries(resolver.resolve("org.codehaus.jackson:jackson-jaxrs:1.6.5").withTransitivity().asFile())
chore(engine-rest): use local respository for shrinkwrap dependency resolution - the dependency resolution was changed from maven <I> to <I> which shrinkwrap adopted with version <I> - this allows the TomcatServerBootstrap to resolve dependencies from local respository
camunda_camunda-bpm-platform
train
java
22a69abf6679391bde3a0d01e43ef57f1d1c0d3e
diff --git a/setup.py b/setup.py index <HASH>..<HASH> 100644 --- a/setup.py +++ b/setup.py @@ -39,7 +39,7 @@ test_requires = [ ] doc_requires = [ - "sphinx-tabs >= 1.1.13", + "sphinx-tabs < 2", "ipython >= 7.6.1" ]
docs: downgrade sphinx-tabs requirement for rtd
UCL-INGI_INGInious
train
py
5f5c3307e3624a9490b662b8a69573385842e4a1
diff --git a/scripts/pkg/upload/china.js b/scripts/pkg/upload/china.js index <HASH>..<HASH> 100755 --- a/scripts/pkg/upload/china.js +++ b/scripts/pkg/upload/china.js @@ -51,7 +51,7 @@ module.exports = async versionTag => { ...bucketConf, }) .then(() => { - process.stdout.write(chalk.green("'serverless-linux' uploaded to Tencent\n")); + process.stdout.write(chalk.green("'serverless-linux-x64' uploaded to Tencent\n")); }), cos .putObjectAsync({ @@ -60,7 +60,7 @@ module.exports = async versionTag => { ...bucketConf, }) .then(() => { - process.stdout.write(chalk.green("'serverless-macos' uploaded to Tencent\n")); + process.stdout.write(chalk.green("'serverless-macos-x64' uploaded to Tencent\n")); }), ]); };
refactor(Standalone): Improve upload confirmation logs
serverless_serverless
train
js
c30a941e36b8996c9679529c99391430b585da50
diff --git a/generators/client-2/templates/gulp/_copy.js b/generators/client-2/templates/gulp/_copy.js index <HASH>..<HASH> 100644 --- a/generators/client-2/templates/gulp/_copy.js +++ b/generators/client-2/templates/gulp/_copy.js @@ -107,6 +107,7 @@ function deps(){ 'node_modules/reflect-metadata/Reflect.js', 'node_modules/systemjs/dist/system.js', 'node_modules/@angular/**/*.js', + 'node_modules/@ng-bootstrap/ng-bootstrap/**/*.js', 'node_modules/rxjs/**/*.js' ], { base: 'node_modules' }) .pipe(gulp.dest(config.dist + 'vendor'));
feat(ng2): added gulp to move ng-bootstrap files
jhipster_generator-jhipster
train
js
aa98ed6bb8900e9d84ae4650a11da682498692ec
diff --git a/packages/react/src/components/NumberInput/NumberInput.js b/packages/react/src/components/NumberInput/NumberInput.js index <HASH>..<HASH> 100644 --- a/packages/react/src/components/NumberInput/NumberInput.js +++ b/packages/react/src/components/NumberInput/NumberInput.js @@ -301,17 +301,17 @@ class NumberInput extends Component { 'aria-label': ariaLabel, }; - const errorId = `${id}-error-id`; - const buttonProps = { disabled, type: 'button', }; const inputWrapperProps = {}; + let errorId = null; let error = null; if (invalid || (!allowEmpty && this.state.value === '')) { inputWrapperProps['data-invalid'] = true; + errorId = `${id}-error-id`; error = ( <div className={`${prefix}--form-requirement`} id={errorId}> {invalidText}
fix(number-input): update how errorId is applied for aria-labelledby (#<I>)
carbon-design-system_carbon-components
train
js
220b35ecaca7e1cc873bca23b29139af115000e2
diff --git a/checkmgr/checkmgr.go b/checkmgr/checkmgr.go index <HASH>..<HASH> 100644 --- a/checkmgr/checkmgr.go +++ b/checkmgr/checkmgr.go @@ -458,6 +458,11 @@ func (cm *CheckManager) GetSubmissionURL() (*Trap, error) { return trap, nil } + // api.circonus.com uses a public certificate + if u.Hostname() == "api.circonus.com" { + return trap, nil + } + if cm.certPool == nil { if err := cm.loadCACert(); err != nil { return nil, errors.Wrap(err, "get submission url")
fix: if submission host is 'api.circonus.com' do not use private ca cert in tls
circonus-labs_circonus-gometrics
train
go
3f2df554faacd440afe64f36529b96c4ebbc5a34
diff --git a/lib/csv.js b/lib/csv.js index <HASH>..<HASH> 100644 --- a/lib/csv.js +++ b/lib/csv.js @@ -20,6 +20,13 @@ Important, this documentation cover the current version of the node csv parser. The documentation for the current version 0.1.0 is available [here](https://github.com/wdavidw/node-csv-parser/tree/v0.1). +Installation +------------ + +```bash +npm install csv +``` + Quick example -------------
chore(csv): Add install instruction
adaltas_node-csv
train
js
842c307796491e6dc7f1209e1ab1936e1cfe83c9
diff --git a/ibis/backends/pyspark/compiler.py b/ibis/backends/pyspark/compiler.py index <HASH>..<HASH> 100644 --- a/ibis/backends/pyspark/compiler.py +++ b/ibis/backends/pyspark/compiler.py @@ -395,6 +395,15 @@ def compile_aggregation(t, expr, scope, timecontext, **kwargs): src_table = t.translate(op.table, scope, timecontext) + if op.predicates: + src_table = src_table.filter( + t.translate( + functools.reduce(operator.and_, op.predicates), + scope, + timecontext, + ) + ) + if op.by: context = AggregationContext.GROUP aggs = [
fix(pyspark): handle predicates in Aggregation
ibis-project_ibis
train
py
53242acf7644fd3f24bc445a5f722cbb7b80509a
diff --git a/deps.js b/deps.js index <HASH>..<HASH> 100755 --- a/deps.js +++ b/deps.js @@ -18,7 +18,7 @@ // project depend on it. const debug = require('debug')('deps'); -const builtins = require('builtins'); +const builtins = require('builtins')(); const detective = require('detective'); const fs = require('fs'); const _ = require('lodash'); diff --git a/tooling/lib/dependencies.js b/tooling/lib/dependencies.js index <HASH>..<HASH> 100644 --- a/tooling/lib/dependencies.js +++ b/tooling/lib/dependencies.js @@ -3,7 +3,7 @@ */ const debug = require('debug')('tooling:dependencies'); -const builtins = require('builtins'); +const builtins = require('builtins')(); const {read} = require('../util/package'); const path = require('path'); const {values} = require('lodash');
fix(tooling): update to new builtins() behavior
webex_spark-js-sdk
train
js,js
e7647e91124c80d250b443723e8020d55670ec1b
diff --git a/src/types/float.test.js b/src/types/float.test.js index <HASH>..<HASH> 100644 --- a/src/types/float.test.js +++ b/src/types/float.test.js @@ -19,4 +19,12 @@ describe('float type', () => { expect(type.validators[3](282.333)).to.be.true; expect(type.validators[3](282.333333)).to.be.true; }); + + it('precision validator with negative precision', () => { + const type = new FloatType({ precision: -3 }); + + expect(type.validators[3](282)).to.be.true; + expect(type.validators[3](282.33)).to.be.true; + expect(type.validators[3](282.333)).to.be.true; + }); });
test(types): Add testcase with negative precision to NumberType tests.
CheerlessCloud_twconf
train
js
18e503276a7857bc48bae961c02bcd819d3270a0
diff --git a/core/src/elements/ons-select.js b/core/src/elements/ons-select.js index <HASH>..<HASH> 100644 --- a/core/src/elements/ons-select.js +++ b/core/src/elements/ons-select.js @@ -171,10 +171,6 @@ export default class SelectElement extends BaseElement { return this.querySelector('select'); } - static get events() { - return ['change']; - } - _updateBoundAttributes() { INPUT_ATTRIBUTES.forEach((attr) => { if (this.hasAttribute(attr)) {
refactor(ons-select): Should not expose native events.
OnsenUI_OnsenUI
train
js
b52906fdeb5b35743ad3daeaa2c250cca6fd750e
diff --git a/source/rafcon/core/script.py b/source/rafcon/core/script.py index <HASH>..<HASH> 100644 --- a/source/rafcon/core/script.py +++ b/source/rafcon/core/script.py @@ -74,12 +74,15 @@ class Script(Observable, yaml.YAMLObject): return self._script @script.setter - def script(self, value): - if not isinstance(value, string_types): - raise ValueError("The script text needs to be string") - self._script = value + def script(self, script_text): + if not isinstance(script_text, string_types): + raise ValueError("The script text needs to be a string") + self._script = script_text self._compile_module() + def set_script_without_compilation(self, script_text): + self._script = script_text + def execute(self, state, inputs=None, outputs=None, backward_execution=False): """Execute the user 'execute' function specified in the script
feat(script): New method to set script without compiling it
DLR-RM_RAFCON
train
py
202c99583186e4c43b8a6ddb83bc1db19ca4b3bf
diff --git a/lib/ditty/components/ditty.rb b/lib/ditty/components/ditty.rb index <HASH>..<HASH> 100644 --- a/lib/ditty/components/ditty.rb +++ b/lib/ditty/components/ditty.rb @@ -51,7 +51,7 @@ module Ditty [ { group: 'User Management', - order: 10, + order: 50, icon: 'lock', target: ::Ditty::User, items: [
chore: Move User Management further down the navlist
EagerELK_ditty
train
rb
aa45d1bedf2ac85d5fb653ee0c6a0311c8510d27
diff --git a/packages/application-shell/src/components/quick-access/create-commands.js b/packages/application-shell/src/components/quick-access/create-commands.js index <HASH>..<HASH> 100644 --- a/packages/application-shell/src/components/quick-access/create-commands.js +++ b/packages/application-shell/src/components/quick-access/create-commands.js @@ -142,7 +142,7 @@ export default ({ { id: 'go/discounts/carts/list', text: intl.formatMessage(messages.openCartDiscountsList), - action: { type: 'go', to: `/${project.key}/discounts/products` }, + action: { type: 'go', to: `/${project.key}/discounts/carts` }, }, { id: 'go/discounts/codes/list',
fix(quick-access): fix cart-discount-list route
commercetools_merchant-center-application-kit
train
js
7fa6f5f4fb7ef64d828638546b0a691dc68e9516
diff --git a/plugins/inputs/sql/drivers_sqlite.go b/plugins/inputs/sql/drivers_sqlite.go index <HASH>..<HASH> 100644 --- a/plugins/inputs/sql/drivers_sqlite.go +++ b/plugins/inputs/sql/drivers_sqlite.go @@ -1,11 +1,8 @@ -//go:build !arm && !mips && !mipsle && !mips64 && !mips64le && !ppc64 && !(freebsd && arm64) -// +build !arm -// +build !mips -// +build !mipsle -// +build !mips64 -// +build !mips64le -// +build !ppc64 -// +build !freebsd !arm64 +//go:build linux && freebsd && darwin && (!mips || !mips64) +// +build linux +// +build freebsd +// +build darwin +// +build !mips !mips64 package sql
fix: Sync sql output and input build constraints to handle loong<I> in go<I>. (#<I>)
influxdata_telegraf
train
go
d63d0fb541864a9a59e30043a62e5cb1866b0676
diff --git a/src/main/java/com/conveyal/gtfs/loader/JdbcTableWriter.java b/src/main/java/com/conveyal/gtfs/loader/JdbcTableWriter.java index <HASH>..<HASH> 100644 --- a/src/main/java/com/conveyal/gtfs/loader/JdbcTableWriter.java +++ b/src/main/java/com/conveyal/gtfs/loader/JdbcTableWriter.java @@ -421,7 +421,11 @@ public class JdbcTableWriter implements TableWriter { // field statement above. for (Field field : subTable.specFields()) { if (field.referenceTable != null && !field.referenceTable.name.equals(specTable.name)) { - referencesPerTable.put(field.referenceTable, subEntity.get(field.name).asText()); + JsonNode refValueNode = subEntity.get(field.name); + // Skip over references that are null but not required (e.g., route_id in fare_rules). + if (refValueNode.isNull() && !field.isRequired()) continue; + String refValue = refValueNode.asText(); + referencesPerTable.put(field.referenceTable, refValue); } } // Insert new sub-entity.
fix(editor): allow null values for foreign ref fields allowed to be empty This fixes a bug where create/update requests with foreign refs (such as route_id in fare_rules) could not be null even if the table definition permits the null value. fixes catalogueglobal/datatools-ui#<I>
conveyal_gtfs-lib
train
java
3366c11b7dc3be0286f96c828cd87d10fe2aa931
diff --git a/src/service/translate.js b/src/service/translate.js index <HASH>..<HASH> 100644 --- a/src/service/translate.js +++ b/src/service/translate.js @@ -228,7 +228,7 @@ function $translate($STORAGE_KEY, $windowProvider, $translateSanitizationProvide * registered with no language key. Invoking it with a language key returns the * related translation table. * - * @param {string} key A language key. + * @param {string} langKey A language key. * @param {object} translationTable A plain old JavaScript object that represents a translation table. * */
docs(service): fix typo in param name
angular-translate_angular-translate
train
js
f631ec9bfd59f0e8ce1b1ec5fec927945db7a961
diff --git a/packages/plugin-mercury/src/mercury.js b/packages/plugin-mercury/src/mercury.js index <HASH>..<HASH> 100644 --- a/packages/plugin-mercury/src/mercury.js +++ b/packages/plugin-mercury/src/mercury.js @@ -4,7 +4,7 @@ */ import {SparkPlugin} from '@ciscospark/spark-core'; -import {deprcate} from 'core-decorators' +import {deprecated} from 'core-decorators'; import {oneFlight} from '@ciscospark/common'; import {set} from 'lodash'; import S from 'string'; @@ -78,13 +78,13 @@ const Mercury = SparkPlugin.extend({ }); }, - @deprecate(`Mercury#listen(): Use Mercury#connect() instead`) + @deprecated(`Mercury#listen(): Use Mercury#connect() instead`) listen() { /* eslint no-invalid-this: [0] */ return this.connect(); }, - @deprecate(`Mercury#stopListening(): Use Mercury#disconnect() instead`) + @deprecated(`Mercury#stopListening(): Use Mercury#disconnect() instead`) stopListening() { /* eslint no-invalid-this: [0] */ return this.disconnect();
fix(plugin-mercury): use correct name for deprecated decorator
webex_spark-js-sdk
train
js
b5749f348498604d14cc61df2013846e7eda15c8
diff --git a/endpoints/register.js b/endpoints/register.js index <HASH>..<HASH> 100644 --- a/endpoints/register.js +++ b/endpoints/register.js @@ -36,7 +36,7 @@ class Authentication extends Endpoint { * Generate new User into db and return credentials to use */ async newUser (credentials, req) { - let ip = req.headers['x-forwarded-for'] || req.connection.remoteAddress + let ip = req.user.uid let user_id = credentials.user_id let user_secret = credentials.user_secret
refactor: take ip from req.user since that's always assigned
cubic-js_cubic
train
js
0eb4fbdeeb4061b32ac84db857f4f1f76549950b
diff --git a/intranet/apps/eighth/views/attendance.py b/intranet/apps/eighth/views/attendance.py index <HASH>..<HASH> 100644 --- a/intranet/apps/eighth/views/attendance.py +++ b/intranet/apps/eighth/views/attendance.py @@ -373,7 +373,7 @@ def take_attendance_view(request, scheduled_activity_id): if request.user.is_eighth_admin: context["scheduled_activities"] = EighthScheduledActivity.objects.filter(block__id=scheduled_activity.block.id) - context["blocks"] = EighthBlock.objects.filter(date__gte=get_start_date(request)).order_by("date") + context["blocks"] = EighthBlock.objects.filter(date__gte=get_start_date(request)).order_by("date", "block_letter") if request.resolver_match.url_name == "eighth_admin_export_attendance_csv": response = http.HttpResponse(content_type="text/csv")
fix(eighth): order eighth period blocks by block_letter in addition to date in take attendance view
tjcsl_ion
train
py
f9b3ee958aa1182a0b9e73247d289bc830fe9403
diff --git a/src/index.spec.js b/src/index.spec.js index <HASH>..<HASH> 100644 --- a/src/index.spec.js +++ b/src/index.spec.js @@ -14,12 +14,14 @@ const sinonChai = require('sinon-chai'); chai.use(sinonChai); describe('gulp-inject-partials', function () { - beforeEach(function() { - sinon.spy(console, 'log'); + let consoleSpy; + + beforeEach(function () { + consoleSpy = sinon.spy(process.stdout, 'write'); }); - afterEach(function() { - console.log.restore(); + afterEach(function () { + consoleSpy.restore(); }); it('should inject single partial', function (done) { @@ -87,7 +89,7 @@ describe('gulp-inject-partials', function () { }); stream.on('end', function () { - expect(console.log).not.to.be.called; + expect(consoleSpy).not.to.be.called; done(); }); }); @@ -99,7 +101,7 @@ describe('gulp-inject-partials', function () { }); stream.on('end', function () { - expect(console.log).to.be.called; + expect(consoleSpy).to.be.called; done(); }); });
test: improve console.log test case
meeroslav_gulp-inject-partials
train
js
cde0e9908cf3136055e7b613ebbb229421a758a0
diff --git a/gulpfile.js b/gulpfile.js index <HASH>..<HASH> 100644 --- a/gulpfile.js +++ b/gulpfile.js @@ -58,8 +58,6 @@ gulp.task('default', ['jshint', 'build'], function() { gulp.watch(path.src.files, ['jshint', 'build']); }); -gulp.task('webdriver_update', require('gulp-protractor').webdriver_update); - gulp.task('serve', ['build'], function() { var express = require('express'); var server = express(); @@ -70,7 +68,7 @@ gulp.task('serve', ['build'], function() { }); }); -gulp.task('test', ['webdriver_update', 'serve'], function() { +gulp.task('test', ['serve'], function() { var protractor = require('gulp-protractor').protractor; gulp.src(['./test/spec.js']) diff --git a/test/conf.js b/test/conf.js index <HASH>..<HASH> 100644 --- a/test/conf.js +++ b/test/conf.js @@ -1,4 +1,5 @@ var config = { + directConnect: true, multiCapabilities: [{ 'browserName': 'chrome' }],
chore: use directConnect instead of selenium
assisrafael_angular-input-masks
train
js,js
e8b5a6472e77382580d58e054ce71c4241b08ae6
diff --git a/lib/ridgepole/diff.rb b/lib/ridgepole/diff.rb index <HASH>..<HASH> 100644 --- a/lib/ridgepole/diff.rb +++ b/lib/ridgepole/diff.rb @@ -1,5 +1,5 @@ class Ridgepole::Diff - PRIMARY_KEY_OPTIONS = %i(id limit default null precision scale collation unsigned comment).freeze + PRIMARY_KEY_OPTIONS = %i(id limit default null precision scale collation unsigned).freeze def initialize(options = {}) @options = options
fix: don't treat the `comment` option as a option of primary key ActiveRecord 5 allows to specify the `comment` option on `create_table`, but this option adds the comment for tables not a primary key.
winebarrel_ridgepole
train
rb
93b01edd4f7144accdd067387e8b489a3f4b2435
diff --git a/cmd/helm/helm.go b/cmd/helm/helm.go index <HASH>..<HASH> 100644 --- a/cmd/helm/helm.go +++ b/cmd/helm/helm.go @@ -14,7 +14,7 @@ import ( const ( homeEnvVar = "HELM_HOME" defaultHome = "$HOME/.helm" // FIXME: is $HOME windows compatible? - hostEnvVar = "TILLER_HOST" + hostEnvVar = "HELM_HOST" defaultHost = ":44134" ) @@ -42,7 +42,7 @@ Common actions from this point include: Environment: $HELM_HOME Set an alternative location for Helm files. By default, these are stored in ~/.helm - $TILLER_HOST Set an alternative Tiller host. The format is host:port (default ":44134"). + $HELM_HOST Set an alternative Tiller host. The format is host:port (default ":44134"). ` // RootCommand is the top-level command for Helm. @@ -64,7 +64,7 @@ func init() { } p := RootCommand.PersistentFlags() p.StringVar(&helmHome, "home", home, "location of your Helm config. Overrides $HELM_HOME.") - p.StringVar(&tillerHost, "host", thost, "address of tiller. Overrides $TILLER_HOST.") + p.StringVar(&tillerHost, "host", thost, "address of tiller. Overrides $HELM_HOST.") p.BoolVarP(&flagVerbose, "verbose", "v", false, "enable verbose output") }
fix(helm): change TILLER_HOST to HELM_HOST This makes the naming of client-side environment variables consistent.
helm_helm
train
go
18fa15cef14c66de395dab5fb2c7991517fce205
diff --git a/src/utils.js b/src/utils.js index <HASH>..<HASH> 100644 --- a/src/utils.js +++ b/src/utils.js @@ -1,5 +1,11 @@ +const camelToDashMap = new Map(); export function camelToDash(str) { - return str.replace(/([a-z])([A-Z])/g, '$1-$2').toLowerCase(); + let result = camelToDashMap.get(str); + if (result === undefined) { + result = str.replace(/([a-z])([A-Z])/g, '$1-$2').toLowerCase(); + camelToDashMap.set(str, result); + } + return result; } export function pascalToDash(str) {
fix(utils): memonize camelToDash result
hybridsjs_hybrids
train
js
be4bef39543eb5bc391899e18ac95b65627a46f7
diff --git a/backend/fleet/state.go b/backend/fleet/state.go index <HASH>..<HASH> 100644 --- a/backend/fleet/state.go +++ b/backend/fleet/state.go @@ -3,6 +3,7 @@ package fleet import ( "errors" "fmt" + "strings" "sync" "time" @@ -157,10 +158,13 @@ func printUnitSubState(name string, outchan chan *schema.Unit, errchan chan erro // continue processing if error channel closed if err == nil { continue + } else if strings.Contains(err.Error(), "timeout reached") { + // ignore intermittent timeout errors + continue } return err } - time.Sleep(200 * time.Millisecond) + time.Sleep(1000 * time.Millisecond) } } @@ -191,9 +195,12 @@ func printUnitState(name string, outchan chan *schema.Unit, errchan chan error) // continue processing if error channel closed if err == nil { continue + } else if strings.Contains(err.Error(), "timeout reached") { + // ignore intermittent timeout errors + continue } return err } - time.Sleep(200 * time.Millisecond) + time.Sleep(1000 * time.Millisecond) } }
fix(state): ignore intermittent timeouts when polling for UnitState
deis_deis
train
go
2086470e316d44afa8bb66f01e5b4631f054a991
diff --git a/src/components/Modal/Modal.js b/src/components/Modal/Modal.js index <HASH>..<HASH> 100644 --- a/src/components/Modal/Modal.js +++ b/src/components/Modal/Modal.js @@ -46,11 +46,10 @@ export default class Modal extends Component { * Specify the content of the modal header title. */ modalHeading: PropTypes.string, - /** * Specify the content of the modal header label. */ - modalLabel: PropTypes.string, + modalLabel: PropTypes.node, /** * Specify a label to be read by screen readers on the modal root node
fix(Modal): Allow components as modal heading (#<I>) * fix(Modal): Allow components as modal heading * fix(Modal): Any renderable type for label
carbon-design-system_carbon-components-react
train
js
a2b8a0a05b3b9295e1bca1af47886f6f895fc41d
diff --git a/lib/TransactionRunner.js b/lib/TransactionRunner.js index <HASH>..<HASH> 100644 --- a/lib/TransactionRunner.js +++ b/lib/TransactionRunner.js @@ -573,15 +573,18 @@ include a message body: https://tools.ietf.org/html/rfc7231#section-6.3\ let message = ''; const object = gavelResult || {}; let validatorOutput; - for (const sectionName of Object.keys(object || {})) { - // Section names are 'statusCode', 'headers', 'body' (and 'version', which is irrelevant) + + // Order-sensitive list of validation sections to output in the log + const resultSections = ['headers', 'body', 'statusCode'] + .filter(sectionName => Object.prototype.hasOwnProperty.call(object, sectionName)); + + resultSections.forEach((sectionName) => { validatorOutput = object[sectionName]; - if (sectionName !== 'version') { - for (const gavelError of validatorOutput.results || []) { - message += `${sectionName}: ${gavelError.message}\n`; - } - } - } + (validatorOutput.results || []).forEach((gavelError) => { + message += `${sectionName}: ${gavelError.message}\n`; + }); + }); + test.message = message; // Record raw validation output to transaction results object
fix: uses explicit validation result sections list for logging output
apiaryio_dredd
train
js
db821cc8d99f0eded68ba780fa05dcbe5407f902
diff --git a/src/Model/Repository/CartRepository.php b/src/Model/Repository/CartRepository.php index <HASH>..<HASH> 100644 --- a/src/Model/Repository/CartRepository.php +++ b/src/Model/Repository/CartRepository.php @@ -167,12 +167,13 @@ class CartRepository extends Repository $client = $this->getClient($locale); $cartUpdateRequest = CartUpdateRequest::ofIdAndVersion($cart->getId(), $cart->getVersion()); + $cartUpdateRequest->addAction(CartSetShippingAddressAction::of()->setAddress($shippingAddress)); + $billingAddressAction = CartSetBillingAddressAction::of(); if (!is_null($billingAddress)) { $billingAddressAction->setAddress($billingAddress); + $cartUpdateRequest->addAction($billingAddressAction); } - $cartUpdateRequest->addAction(CartSetShippingAddressAction::of()->setAddress($shippingAddress)) - ->addAction($billingAddressAction); $cartResponse = $cartUpdateRequest->executeWithClient($client); $cart = $cartUpdateRequest->mapResponse($cartResponse);
fix(CartRepository): only add billing action if billing address is provided
commercetools_commercetools-php-symfony
train
php
2c1020a6e668cd2a6620d3a5e4ba865567b10301
diff --git a/system/Validation/FormatRules.php b/system/Validation/FormatRules.php index <HASH>..<HASH> 100644 --- a/system/Validation/FormatRules.php +++ b/system/Validation/FormatRules.php @@ -317,7 +317,8 @@ class FormatRules return false; } - $scheme = strtolower(parse_url($str, PHP_URL_SCHEME) ?? ''); // absent scheme gives null + // parse_url() may return null and false + $scheme = strtolower((string) parse_url($str, PHP_URL_SCHEME)); $validSchemes = explode( ',', strtolower($validSchemes ?? 'http,https')
refactor: strtolower() should take only string
codeigniter4_CodeIgniter4
train
php
50e1e96e9f970cbbb375e7940316aaeff1182372
diff --git a/test/dict/CharacterDefinitionTest.js b/test/dict/CharacterDefinitionTest.js index <HASH>..<HASH> 100644 --- a/test/dict/CharacterDefinitionTest.js +++ b/test/dict/CharacterDefinitionTest.js @@ -19,18 +19,15 @@ var CharacterDefinition = require("../../src/dict/CharacterDefinition.js"); var InvokeDefinitionMap = require("../../src/dict/InvokeDefinitionMap.js"); var fs = require("fs"); -var jconv = require("jconv"); var expect = require("chai").expect; var DIC_DIR = "test/resource/minimum-dic/"; -var ENCODING = "EUCJP"; - describe("CharacterDefinition from char.def", function () { var char_def; // target object before("Create CharacterDefinition", function (done) { - var text = readFile(DIC_DIR + "char.def"); + var text = fs.readFileSync(DIC_DIR + "char.def", "utf-8"); char_def = CharacterDefinition.readCharacterDefinition(text); done(); }); @@ -129,10 +126,3 @@ describe("CharacterDefinition from char.def", function () { }); }); }); - - -var readFile = function(filename) { - var text = fs.readFileSync(filename); - text = jconv.decode(text, ENCODING); - return text; -};
test(dic): stop to use jconv
takuyaa_kuromoji.js
train
js
4c229542df9b91226312f662d41ae8da9f7262ce
diff --git a/test/test-build-pack.js b/test/test-build-pack.js index <HASH>..<HASH> 100644 --- a/test/test-build-pack.js +++ b/test/test-build-pack.js @@ -3,7 +3,7 @@ require('./build-example')(['--install', '-p'], function(er) { assert.ifError(er); assert(test('-d', 'node_modules')); var info = require(path.resolve('package.json')); - assert.equal(info.name, 'sls-sample-app'); + assert.equal(info.name, 'loopback-example-app'); var tgz = path.join('..', util.format('%s-%s.tgz', info.name, info.version)); assert(test('-f', tgz), 'expected to find ' + tgz);
test: sls-sample-app loopback-example-app rename Update refrence to match upstream example app's name change.
strongloop_strong-build
train
js
51e8ef34cb52a575f4b587c9449fcd1da9415109
diff --git a/lib/step.js b/lib/step.js index <HASH>..<HASH> 100644 --- a/lib/step.js +++ b/lib/step.js @@ -154,8 +154,11 @@ function detectMetaStep(stack) { if (isTest(line) || isBDD(line)) break; const fnName = line.match(/^at (\w+)\.(\w+)\s\(/); if (!fnName) continue; - if (fnName[1] === 'Generator') return; // don't track meta steps inside generators - if (fnName[1] === 'recorder') return; // don't track meta steps inside generators + if (fnName[1] === 'Generator' + || fnName[1] === 'recorder' + || fnName[1] === 'Runner' + ) { return; } // don't track meta steps inside generators + if (fnName[1] === 'Object') { // detect PO name from includes for (const name in support) {
fix: skip Runner to detect MetaStep (#<I>)
Codeception_CodeceptJS
train
js
4e430bab6f904c185ca64aeac9b9c06e0a03ec97
diff --git a/src/tools/OverlayTool.js b/src/tools/OverlayTool.js index <HASH>..<HASH> 100644 --- a/src/tools/OverlayTool.js +++ b/src/tools/OverlayTool.js @@ -103,8 +103,12 @@ export default class OverlayTool extends BaseTool { } } + // Guard against non-number values + const overlayX = (!isNaN(parseFloat(overlay.x)) && isFinite(overlay.x)) ? overlay.x : 0; + const overlayY = (!isNaN(parseFloat(overlay.y)) && isFinite(overlay.y)) ? overlay.y : 0; + // Draw the overlay layer onto the canvas - canvasContext.drawImage(layerCanvas, overlay.x, overlay.y); + canvasContext.drawImage(layerCanvas, overlayX, overlayY); }); } }
fix: guard against non-number values
cornerstonejs_cornerstoneTools
train
js
9e068622c1cdd3f2d00432ffcf02453784692421
diff --git a/src/AdminPlugin.php b/src/AdminPlugin.php index <HASH>..<HASH> 100644 --- a/src/AdminPlugin.php +++ b/src/AdminPlugin.php @@ -38,6 +38,11 @@ class AdminPlugin extends BasePlugin 'sort' => 100, ]; + $categories['content'] = [ + 'name' => '内容', + 'sort' => 95, + ]; + $categories['setting'] = [ 'name' => '设置', 'sort' => 90,
refactor(article): 增加内容菜单
miaoxing_admin
train
php
db6a40ef9d5d813b2d5a3a35dbcf34e93cfa15cb
diff --git a/setup.py b/setup.py index <HASH>..<HASH> 100644 --- a/setup.py +++ b/setup.py @@ -61,7 +61,7 @@ extras["test"] = ( extras["all"], "tox", "flake8", - "pytest", + "pytest<6.1.0", "pytest-cov", "pytest-rerunfailures", "pytest-xdist",
fix: pin pytest version <<I> to avoid pytest-rerunfailures breaking changes (#<I>)
aws_sagemaker-python-sdk
train
py
2d158819b0b6a87557d2e1a5f321fcb39c366a07
diff --git a/src/TypesGenerator.php b/src/TypesGenerator.php index <HASH>..<HASH> 100644 --- a/src/TypesGenerator.php +++ b/src/TypesGenerator.php @@ -258,7 +258,7 @@ class TypesGenerator } foreach ($this->getParentClasses($type) as $typeInHierarchy) { - foreach ($propertiesMap[$typeInHierarchy->getUri()] as $property) { + foreach ($propertiesMap[$typeInHierarchy->getUri()] ?? [] as $property) { if ($key !== $property->localName()) { continue; }
fix: Check if key is set to prevent warning (#<I>) * fix: Check if key is set to prevent warning When the properitesMap array gets iterated to generate the fields, it happens that the uri of the typeInHierarchy is not a key of the said array; this triggers a PHP Warning: Undefined array key. Seems to happen only for custom classes definition though. This does not prevent the command to run, this is really not critical. * Update src/TypesGenerator.php
api-platform_schema-generator
train
php
e86f6bbabcc85f7005b6af85aabdfcf93acc6e82
diff --git a/superset/security/manager.py b/superset/security/manager.py index <HASH>..<HASH> 100644 --- a/superset/security/manager.py +++ b/superset/security/manager.py @@ -235,13 +235,17 @@ class SupersetSecurityManager( # pylint: disable=too-many-public-methods guest_user_cls = GuestUser def create_login_manager(self, app: Flask) -> LoginManager: + lm = super().create_login_manager(app) + lm.request_loader(self.request_loader) + return lm + + def request_loader(self, request: Request) -> Optional[User]: # pylint: disable=import-outside-toplevel from superset.extensions import feature_flag_manager - lm = super().create_login_manager(app) if feature_flag_manager.is_feature_enabled("EMBEDDED_SUPERSET"): - lm.request_loader(self.get_guest_user_from_request) - return lm + return self.get_guest_user_from_request(request) + return None def get_schema_perm( # pylint: disable=no-self-use self, database: Union["Database", str], schema: Optional[str] = None
fix: check embedded feature flag in request loader (#<I>) * check embedded feature flag in request loader * lint * type annotation
apache_incubator-superset
train
py
9f13e6c4c62b5b7ffc4064f85b21619f7181f14f
diff --git a/src/geshi/css.php b/src/geshi/css.php index <HASH>..<HASH> 100644 --- a/src/geshi/css.php +++ b/src/geshi/css.php @@ -193,7 +193,8 @@ $language_data = array ( //CSS classname 1 => '\.(?!\d)[a-zA-Z0-9\-_]+\b(?=[\{\.#\s,:].|<\|)', //CSS Pseudo classes - 2 => ':(?!\d)[a-zA-Z0-9\-]+\b(?:\s*(?=[\{\.#a-zA-Z,:](.|\n)|<\|))', + //note: & is needed for &gt; (i.e. > ) + 2 => ':(?!\d)[a-zA-Z0-9\-]+\b(?:\s*(?=[\{\.#a-zA-Z,:+*&](.|\n)|<\|))', //Measurements 3 => '[+\-]?(\d+|(\d*\.\d+))(em|ex|pt|px|cm|in|%)', ),
fix: even more fancier selectors are supported now
GeSHi_geshi-1.0
train
php
aa8a5c20a23083e876e078ad2de4f0910c09b6d3
diff --git a/src/directives/highlight/index.js b/src/directives/highlight/index.js index <HASH>..<HASH> 100644 --- a/src/directives/highlight/index.js +++ b/src/directives/highlight/index.js @@ -8,6 +8,6 @@ export const highlight = (Vue) => { const highlightee = binding.value.split('::')[0]; const highlighter = binding.value.split('::')[1]; const regex = new RegExp(highlightee, 'gi'); - el.innerHTML = str.replace(regex, `<span style="background-color: ${ highlighter }">${ highlightee }</span>`) + el.innerHTML = str.replace(regex, `<mark style="background-color: ${ highlighter }">${ highlightee }</mark>`) } }; \ No newline at end of file
fix(highlight): changed the span to mark, because of semantics
jofftiquez_vue-morphling
train
js
9af5eeb53144608d61f5e7ca5ed7854c4bed4c70
diff --git a/lib/babel-config.js b/lib/babel-config.js index <HASH>..<HASH> 100644 --- a/lib/babel-config.js +++ b/lib/babel-config.js @@ -5,7 +5,6 @@ const react = require('@babel/preset-react') const reactRequire = require('babel-plugin-react-require').default const lodash = require('babel-plugin-lodash') const reactDisplayName = require('@babel/plugin-transform-react-display-name') -const transformRuntime = require('@babel/plugin-transform-runtime') const classProperties = require('@babel/plugin-proposal-class-properties') const exportFrom = require('@babel/plugin-proposal-export-namespace-from') @@ -18,8 +17,7 @@ module.exports = function (env) { exportFrom, lodash, reactDisplayName, - reactRequire, - transformRuntime + reactRequire ] return { @@ -29,7 +27,8 @@ module.exports = function (env) { babelEnv, { loose: false, // Loose mode breaks spread operator on `Set`s - targets: { browsers } + targets: { browsers }, + useBuiltIns: 'usage' } ], flow,
refactor(babel): Remove direct transform runtime requirement and turn on the userBuiltIns flag for b
conveyal_mastarm
train
js
92a5f0f8b493f8cbe6d09768ab7d061bfecf10c2
diff --git a/webpack.prod.js b/webpack.prod.js index <HASH>..<HASH> 100644 --- a/webpack.prod.js +++ b/webpack.prod.js @@ -9,6 +9,11 @@ var baseConfig = require('./webpack.base.js'); var prodConfig = { plugins: [ + new webpack.DefinePlugin({ + 'process.env': { + NODE_ENV: JSON.stringify('production') + } + }), new webpack.optimize.UglifyJsPlugin({minimize: true}), new webpack.NoErrorsPlugin() ]
chore: added process_env to prod build
chrisbateman_webpack-visualizer
train
js
a135f5cf424c1323eb02d941bb2c88435d3a4edd
diff --git a/packages/react/src/internal/FloatingMenu.js b/packages/react/src/internal/FloatingMenu.js index <HASH>..<HASH> 100644 --- a/packages/react/src/internal/FloatingMenu.js +++ b/packages/react/src/internal/FloatingMenu.js @@ -336,8 +336,10 @@ class FloatingMenu extends React.Component { const primaryFocusNode = menuBody.querySelector( this.props.selectorPrimaryFocus || null ); - const tabbableNode = menuBody.querySelector(selectorTabbable); - const focusableNode = menuBody.querySelector(selectorFocusable); + const tabbableNodes = menuBody.querySelectorAll(selectorTabbable); + const focusableNodes = menuBody.querySelectorAll(selectorFocusable); + const tabbableNode = [...tabbableNodes].find((node) => !node.disabled); + const focusableNode = [...focusableNodes].find((node) => !node.disabled); const focusTarget = primaryFocusNode || // User defined focusable node tabbableNode || // First sequentially focusable node
fix(FloatingMenu): ignore disabled nodes for autofocus (#<I>)
carbon-design-system_carbon-components
train
js
a07e466149b4f51787b5a1cee0c264dc75d65017
diff --git a/deezer/client.py b/deezer/client.py index <HASH>..<HASH> 100644 --- a/deezer/client.py +++ b/deezer/client.py @@ -185,12 +185,12 @@ class Client: """ url = self.object_url(object_t, object_id, relation, **kwargs) response = self.session.get(url) - json = response.json() - if "error" in json: + json_data = response.json() + if "error" in json_data: raise ValueError( f"API request return error for object: {object_t} id: {object_id}" ) - return self._process_json(json, parent) + return self._process_json(json_data, parent) def get_album(self, object_id, relation=None, **kwargs): """
refactor: rename variable to avoid confusion with json module
browniebroke_deezer-python
train
py