patch
stringlengths
17
31.2k
y
int64
1
1
oldf
stringlengths
0
2.21M
idx
int64
1
1
id
int64
4.29k
68.4k
msg
stringlengths
8
843
proj
stringclasses
212 values
lang
stringclasses
9 values
@@ -387,7 +387,7 @@ import browser from './browser'; videoAudioCodecs.push('mp2'); } - let supportsDts = browser.tizen || browser.web0s || options.supportsDts || videoTestElement.canPlayType('video/mp4; codecs="dts-"').replace(/no/, '') || videoTestElement.canPlayType('video/mp4; codecs="...
1
import appSettings from './settings/appSettings'; import * as userSettings from './settings/userSettings'; import browser from './browser'; /* eslint-disable indent */ function canPlayH264(videoTestElement) { return !!(videoTestElement.canPlayType && videoTestElement.canPlayType('video/mp4; codecs="avc1.42...
1
19,587
It is not a "perfect" test, but: webOS 1.2 emulator says `probably`. webOS 3 emulator says \``. webOS 4 emulator says \``. Why did you remove `options.supportsDts`?
jellyfin-jellyfin-web
js
@@ -152,6 +152,8 @@ hipError_t ihipEnablePeerAccess(hipCtx_t peerCtx, unsigned int flags) { //--- hipError_t hipMemcpyPeer(void* dst, hipCtx_t dstCtx, const void* src, hipCtx_t srcCtx, size_t sizeBytes) { + if(dstCtx == srcCtx) return hipErrorInvalidValue; + HIP_INIT_API(NONE, dst, d...
1
/* Copyright (c) 2015 - present Advanced Micro Devices, Inc. All rights reserved. Permission is hereby granted, free of charge, to any person obtaining a copy of this software and associated documentation files (the "Software"), to deal in the Software without restriction, including without limitation the rights to us...
1
7,839
This check should be after the HIP_INIT_API to ensure HIP tracing & lazy init works correctly. Also return should be wrapped in ihipLogStatus() so that logging works correctly.
ROCm-Developer-Tools-HIP
cpp
@@ -54,7 +54,14 @@ class ReIndexTask extends AbstractTask * * @var array */ - protected $indexingConfigurationsToReIndex = array(); + protected $indexingConfigurationsToReIndex = []; + + /** + * Clear Index for selected sites and record types + * + * @var boolean + */ + pro...
1
<?php namespace ApacheSolrForTypo3\Solr\Task; /*************************************************************** * Copyright notice * * (c) 2011-2015 Christoph Moeller <support@network-publishing.de> * (c) 2012-2015 Ingo Renner <ingo@typo3.org> * * All rights reserved * * This script is part of the TYPO3 pr...
1
6,074
Can't use short array syntax for the 3.1 release branch.
TYPO3-Solr-ext-solr
php
@@ -2103,7 +2103,8 @@ static pmix_status_t server_switchyard(pmix_peer_t *peer, uint32_t tag, PMIX_ERROR_LOG(rc); return rc; } - pmix_output_verbose(2, pmix_globals.debug_output, + // pmix_output_verbose(2, pmix_globals.debug_output, + pmix_output(0, ...
1
/* -*- Mode: C; c-basic-offset:4 ; indent-tabs-mode:nil -*- */ /* * Copyright (c) 2014-2017 Intel, Inc. All rights reserved. * Copyright (c) 2014-2017 Research Organization for Information Science * and Technology (RIST). All rights reserved. * Copyright (c) 2014-2015 Artem Y. Polyakov <art...
1
7,402
@rhc54 Is this intentional or for debug purposes?
openpmix-openpmix
c
@@ -12,7 +12,14 @@ def includeme(config): # Activate end-points. config.scan('kinto.plugins.history.views') + # If StatsD is enabled, monitor execution time of listener. + if config.registry.statsd: + key = 'listeners.history' + listener = config.registry.statsd.timer(key)(on_resource_ch...
1
from kinto.core.events import ResourceChanged from .listener import on_resource_changed def includeme(config): config.add_api_capability( 'history', description='Track changes on data.', url='http://kinto.readthedocs.io/en/latest/api/1.x/history.html') # Activate end-points. conf...
1
9,802
Maybe it should be `plugins.history` here instead of `listeners.X`, since we use those for listeners configured via `.ini` files?
Kinto-kinto
py
@@ -6,6 +6,10 @@ module TeamPlansHelper end end + def team_page? + @team_page.present? + end + private def team_plan_quantity_select_attributes(plan)
1
module TeamPlansHelper def team_plan_quantity_select(form, checkout, plan) content_tag :li, team_plan_quantity_select_attributes(plan) do form.label(:quantity, 'Number of team members') + form.select(:quantity, options_for_team_quantity(checkout, plan)) end end private def team_plan_quan...
1
16,647
Hmm, I also don't have a better idea here. As a small thing, could you make this `@team_page.present?` or similar to make the intent slightly more clear?
thoughtbot-upcase
rb
@@ -45,7 +45,12 @@ public class DecrypterInputStream extends InputStream implements WatchableStream public DecrypterInputStream(FileInputStream inputStream, String encryptionKey) throws GeneralSecurityException, IOException { + // First byte should be iv length int ivLength = inputSt...
1
/* * Copyright (c) 2020-present, salesforce.com, inc. * All rights reserved. * Redistribution and use of this software in source and binary forms, with or * without modification, are permitted provided that the following conditions * are met: * - Redistributions of source code must retain the above copyright noti...
1
17,743
Without that check it would fail later (probably in the getDecryptingCipher method) but the error could be hard to make sense of.
forcedotcom-SalesforceMobileSDK-Android
java
@@ -379,6 +379,13 @@ module Beaker return result end + def do_take_snapshot snapshot_name + self[:hypervisor].take_snapshot(name, snapshot_name) + end + + def do_restore_snapshot snapshot_name + self[:hypervisor].restore_snapshot(name, snapshot_name) + end end [ 'windows', 'u...
1
require 'socket' require 'timeout' require 'benchmark' [ 'command', 'ssh_connection' ].each do |lib| require "beaker/#{lib}" end module Beaker class Host SELECT_TIMEOUT = 30 class CommandFailure < StandardError; end # This class provides array syntax for using puppet --configprint on a host clas...
1
8,534
I don't think that this belongs in the host code. A host is pretty much unaware of what hypervisor is running it and I don't want them to be so coupled to their hypervisor.
voxpupuli-beaker
rb
@@ -23,5 +23,6 @@ import setuptools setuptools.setup( packages=setuptools.find_packages(), pbr=True, - setup_requires=['pbr'] + setup_requires=['pbr', 'setuptools>=12'] + # setuptools due https://github.com/ansible/molecule/issues/1859 )
1
# Copyright (c) 2015-2018 Cisco Systems, Inc. # # Permission is hereby granted, free of charge, to any person obtaining a copy # of this software and associated documentation files (the "Software"), to # deal in the Software without restriction, including without limitation the # rights to use, copy, modify, merge...
1
8,898
I'm here to tell you that this doesn't make sense because of the way it works. `setuptools.setup()` installs this only for setup-time and then discards those. But the problem is that it will not pick up a newer version because the older version is already in runtime and module cannot substitute itself. The proper place...
ansible-community-molecule
py
@@ -34,7 +34,7 @@ import ( "github.com/stretchr/testify/assert" ) -type fakeManager struct { +type fakeConnectionManager struct { onConnectReturn error onDisconnectReturn error onStatusReturn connection.Status
1
/* * Copyright (C) 2017 The "MysteriumNetwork/node" Authors. * * This program is free software: you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by * the Free Software Foundation, either version 3 of the License, or * (at your option) any later version. * ...
1
13,540
fakeConnectionManager -> mockConnectionManager. We probably should not use the `fake` anymore.
mysteriumnetwork-node
go
@@ -364,6 +364,7 @@ class JUnitTester(AbstractTestRunner): self.base_class_path = [self.selenium_server_jar_path, self.junit_path, self.junit_listener_path, self.hamcrest_path, self.json_jar_path] self.base_class_path.extend(self.scenario.get("additional-classpath", []...
1
""" Copyright 2015 BlazeMeter Inc. Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software...
1
13,934
Code style. Btw, it's weird Codacy didn't catch that.
Blazemeter-taurus
py
@@ -72,6 +72,14 @@ func (m *EthAddress) UnmarshalYAML(unmarshal func(interface{}) error) error { return nil } +func (m *EthAddress) IsZero() bool { + return NewBigInt(m.Unwrap().Big()).IsZero() +} + +func NewEthAddress(addr common.Address) *EthAddress { + return &EthAddress{Address: addr.Bytes()} +} + func (m *Da...
1
package sonm import ( "errors" "fmt" "math/big" "strings" "time" "github.com/ethereum/go-ethereum/common" "github.com/ethereum/go-ethereum/params" "github.com/sonm-io/core/util/datasize" ) var bigEther = big.NewFloat(params.Ether).SetPrec(256) var priceSuffixes = map[string]big.Float{ "SNM/s": *bigEther, ...
1
6,772
no need in BigInt just m.Unwrap().Big().Bitlen() == 0
sonm-io-core
go
@@ -197,7 +197,7 @@ func (ctx *conjMatchFlowContext) installOrUpdateFlow(actions []*conjunctiveActio // Build the Openflow entry. actions here should not be empty for either add or update case. flow := ctx.client.conjunctiveMatchFlow(ctx.tableID, ctx.matchKey, ctx.matchValue, actions...) - if err := flow.Add()...
1
// Copyright 2019 Antrea Authors // // Licensed under the Apache License, Version 2.0 (the "License"); // you may not use this file except in compliance with the License. // You may obtain a copy of the License at // // http://www.apache.org/licenses/LICENSE-2.0 // // Unless required by applicable law or agreed to ...
1
10,880
I assume you want to change NetworkPolicy to use bundles in a separate PR later?
antrea-io-antrea
go
@@ -77,7 +77,7 @@ MARKER_FILE_LIGHT_VERSION = "%s/.light-version" % dirs.static_libs IMAGE_NAME_SFN_LOCAL = "amazon/aws-stepfunctions-local" ARTIFACTS_REPO = "https://github.com/localstack/localstack-artifacts" SFN_PATCH_URL_PREFIX = ( - f"{ARTIFACTS_REPO}/raw/047cc6dcd2e31f5ff3ec52d293c61b875f606958/stepfunction...
1
#!/usr/bin/env python import functools import glob import logging import os import platform import re import shutil import stat import sys import tempfile import time from pathlib import Path from typing import Callable, Dict, List, Tuple import requests from plugin import Plugin, PluginManager from localstack import...
1
14,245
nit: We could parameterize the commit hash, as it's used in multiple places.
localstack-localstack
py
@@ -2,6 +2,7 @@ // Licensed under the MIT License. See License.txt in the project root for license information. var Constants = require('./constants'); +var _ = require('underscore'); /** * Checks if a parsed URL is HTTPS
1
// Copyright (c) Microsoft Corporation. All rights reserved. // Licensed under the MIT License. See License.txt in the project root for license information. var Constants = require('./constants'); /** * Checks if a parsed URL is HTTPS * * @param {object} urlToCheck The url to check * @return {bool} True if the URL i...
1
20,700
move this above the "Constants" as this is 3rd party ones
Azure-autorest
java
@@ -12,10 +12,16 @@ class AuthenticationPoliciesTest(BaseWebTest, unittest.TestCase): def test_basic_auth_is_accepted_by_default(self): self.app.get(self.collection_url, headers=self.headers, status=200) + # Check that the capability is exposed on the homepage. + resp = self.app.get('/') +...
1
import mock import uuid from kinto.core import authentication from kinto.core import utils from kinto.core.testing import DummyRequest, unittest from .support import BaseWebTest class AuthenticationPoliciesTest(BaseWebTest, unittest.TestCase): def test_basic_auth_is_accepted_by_default(self): self.app....
1
10,238
`assert not in`
Kinto-kinto
py
@@ -310,13 +310,15 @@ func (engine *DockerTaskEngine) monitorExecAgentRunning(ctx context.Context, // to finish monitoring. // This is inspired from containers streaming stats from Docker. time.Sleep(retry.AddJitter(time.Nanosecond, engine.monitorExecAgentsInterval/2)) - _, err = engine.execCmdMgr.RestartAgentIfS...
1
// Copyright Amazon.com Inc. or its affiliates. All Rights Reserved. // // Licensed under the Apache License, Version 2.0 (the "License"). You may // not use this file except in compliance with the License. A copy of the // License is located at // // http://aws.amazon.com/apache2.0/ // // or in the "license" file acco...
1
25,565
just curious, why was this modified?
aws-amazon-ecs-agent
go
@@ -1302,6 +1302,7 @@ void ComTdbExeUtilFastDelete::displayContents(Space * space, ComTdbExeUtilHiveTruncate::ComTdbExeUtilHiveTruncate( char * tableName, ULng32 tableNameLen, + char * hiveTableName, char * tableLocation, char * partnLocation, char * hostName,
1
/********************************************************************** // @@@ START COPYRIGHT @@@ // // Licensed to the Apache Software Foundation (ASF) under one // or more contributor license agreements. See the NOTICE file // distributed with this work for additional information // regarding copyright ownership. ...
1
14,451
I'm curious why the table name is bound at compile time? Is it just to save the table create/drop overhead in a prepare-once-execute-many situation?
apache-trafodion
cpp
@@ -58,10 +58,6 @@ public class ProcessJob extends AbstractProcessJob { public ProcessJob(final String jobId, final Props sysProps, final Props jobProps, final Logger log) { super(jobId, sysProps, jobProps, log); - - // this is in line with what other job types (hadoopJava, spark, pig, hive) - // i...
1
/* * Copyright 2012 LinkedIn Corp. * * Licensed under the Apache License, Version 2.0 (the "License"); you may not * use this file except in compliance with the License. You may obtain a copy of * the License at * * http://www.apache.org/licenses/LICENSE-2.0 * * Unless required by applicable law or agreed to i...
1
12,423
quick question, isn't ProcessJob used by all job types? Then why is JOB_ID not found?
azkaban-azkaban
java
@@ -264,6 +264,15 @@ public class AccountSettings { s.put("trashFolderSelection", Settings.versions( new V(54, new EnumSetting<>(SpecialFolderSelection.class, SpecialFolderSelection.AUTOMATIC)) )); + s.put("resize_image_enabled", Settings.versions( + new V(55, ne...
1
package com.fsck.k9.preferences; import java.util.Collections; import java.util.HashMap; import java.util.LinkedHashMap; import java.util.Map; import java.util.Set; import java.util.TreeMap; import android.content.Context; import com.fsck.k9.Account; import com.fsck.k9.Account.DeletePolicy; import com.fsck.k9.Accou...
1
17,351
looks like you forgot to actually increase the version
k9mail-k-9
java
@@ -43,5 +43,13 @@ namespace OpenTelemetry.Instrumentation.AspNet /// The type of this object depends on the event, which is given by the above parameter.</para> /// </remarks> public Action<Activity, string, object> Enrich { get; set; } + + /// <summary> + /// Gets or sets a va...
1
// <copyright file="AspNetInstrumentationOptions.cs" company="OpenTelemetry Authors"> // Copyright The OpenTelemetry Authors // // Licensed under the Apache License, Version 2.0 (the "License"); // you may not use this file except in compliance with the License. // You may obtain a copy of the License at // // http...
1
18,226
I think it might be helpful if we add `Default value: False.` on the end of the summary.
open-telemetry-opentelemetry-dotnet
.cs
@@ -80,7 +80,7 @@ module.exports = function(realmConstructor) { // result in sync rejecting the writes. `_waitForDownload` ensures that the session is kept // alive until our callback has returned, which prevents it from being torn down and recreated // when we close the schemales...
1
//////////////////////////////////////////////////////////////////////////// // // Copyright 2016 Realm Inc. // // Licensed under the Apache License, Version 2.0 (the "License"); // you may not use this file except in compliance with the License. // You may obtain a copy of the License at // // http://www.apache.org/li...
1
17,124
I think the check should be `config.sync.fullSynchronization === false` - otherwise this will get triggered even when full sync is `true`.
realm-realm-js
js
@@ -924,8 +924,11 @@ func (a *WebAPI) GenerateApplicationSealedSecret(ctx context.Context, req *webse return nil, err } - sse := piped.SealedSecretEncryption - if sse == nil { + se := piped.SecretEncryption + if se == nil { + se = piped.SealedSecretEncryption + } + if se == nil { return nil, status.Error(cod...
1
// Copyright 2020 The PipeCD Authors. // // Licensed under the Apache License, Version 2.0 (the "License"); // you may not use this file except in compliance with the License. // You may obtain a copy of the License at // // http://www.apache.org/licenses/LICENSE-2.0 // // Unless required by applicable law or agree...
1
17,197
this blown my mind
pipe-cd-pipe
go
@@ -335,6 +335,10 @@ type MayaAPIServiceOutputLabel string const ( ReplicaStatusAPILbl MayaAPIServiceOutputLabel = "vsm.openebs.io/replica-status" + //ReplicaContainerStatus MayaAPIServiceOutputLabel = "vsm.openebs.io/replica-cont-status" + + ControllerContainerStatus MayaAPIServiceOutputLabel = "vsm.openebs.io/co...
1
package v1 // NomadEnvironmentVariable is a typed label that defines environment variables // that are understood by Nomad type NomadEnvironmentVariable string const ( // NomadAddressEnvKey is the environment variable that determines the // Nomad server address where the Job request can be directed to. NomadAddres...
1
7,188
this should be controller-container-status
openebs-maya
go
@@ -16,10 +16,12 @@ package azkaban.scheduler; +import azkaban.utils.Utils; import java.util.ArrayList; import java.util.HashMap; import java.util.List; import java.util.Map; +import java.util.Date; import org.joda.time.DateTime; import org.joda.time.DateTimeZone;
1
/* * Copyright 2012 LinkedIn Corp. * * Licensed under the Apache License, Version 2.0 (the "License"); you may not * use this file except in compliance with the License. You may obtain a copy of * the License at * * http://www.apache.org/licenses/LICENSE-2.0 * * Unless required by applicable law or agreed to i...
1
11,364
Sort import. You can use IDE's organize import feature.
azkaban-azkaban
java
@@ -24,6 +24,7 @@ import org.openqa.selenium.WebDriver; import org.openqa.selenium.WebElement; import java.io.IOException; +import java.io.UncheckedIOException; import java.net.URL; import java.nio.charset.StandardCharsets; import java.util.ArrayList;
1
// Licensed to the Software Freedom Conservancy (SFC) under one // or more contributor license agreements. See the NOTICE file // distributed with this work for additional information // regarding copyright ownership. The SFC licenses this file // to you under the Apache License, Version 2.0 (the // "License"); you m...
1
19,388
Can you please revert changes to files in the `thoughtworks` package? This is legacy code and we will eventually phase out RC.
SeleniumHQ-selenium
rb
@@ -16,6 +16,7 @@ import ( ) func TestMiningPledgeSector(t *testing.T) { + t.Skip("Unskip when we have implemented production drand component and local drand network for functional tests") tf.FunctionalTest(t) ctx, cancel := context.WithCancel(context.Background())
1
package functional import ( "context" "os" "path/filepath" "testing" "time" "github.com/stretchr/testify/require" "github.com/filecoin-project/go-filecoin/internal/app/go-filecoin/node" "github.com/filecoin-project/go-filecoin/internal/pkg/clock" tf "github.com/filecoin-project/go-filecoin/internal/pkg/test...
1
23,520
This PR is off to a rough start. :)
filecoin-project-venus
go
@@ -380,7 +380,7 @@ function normalizeProxyConfiguration(config) { } } else if ('pac' === config.proxyType) { if (config.proxyAutoconfigUrl && !config.pacUrl) { - config.pacUrl = config.proxyAutoconfigUrl; + config.proxyAutoconfigUrl = config.proxyAutoconfigUrl; } } return config;
1
// Licensed to the Software Freedom Conservancy (SFC) under one // or more contributor license agreements. See the NOTICE file // distributed with this work for additional information // regarding copyright ownership. The SFC licenses this file // to you under the Apache License, Version 2.0 (the // "License"); you m...
1
14,984
Actually, it looks like the entire `normalizeProxyConfiguration` function isn't needed anymore
SeleniumHQ-selenium
rb
@@ -32,6 +32,8 @@ </div> </div> -<ul id='breadcrumb-nav'> - <li><%= link_to "Back to main portal", carts_path %></li> -</ul> +<%- unless excluded_portal_link %> + <ul id='breadcrumb-nav'> + <li><%= link_to "Back to main portal", carts_path %></li> + </ul> +<%- end %>
1
<div id='communicart_header'> <div class='container'> <div id='header-identity'> <div id="communicart_logo">Communicart</div> <h1>Approval Portal</h1> </div> <ul class='header-nav'> <%- unless signed_in? %> <li> <%= link_to 'Sign in with MyUSA', "/auth/myusa" %> ...
1
12,277
How about `unless current_path == carts_path`?
18F-C2
rb
@@ -63,7 +63,7 @@ # Copyright (c) 2021 Lorena B <46202743+lorena-b@users.noreply.github.com> # Copyright (c) 2021 David Liu <david@cs.toronto.edu> # Copyright (c) 2021 Andreas Finkler <andi.finkler@gmail.com> -# Copyright (c) 2021 Or Bahari <orbahari@mail.tau.ac.il> +# Copyright (c) 2021-2022 Or Bahari <or.ba402@gma...
1
# Copyright (c) 2006-2016 LOGILAB S.A. (Paris, FRANCE) <contact@logilab.fr> # Copyright (c) 2010 Daniel Harding <dharding@gmail.com> # Copyright (c) 2012-2014 Google, Inc. # Copyright (c) 2013-2020 Claudiu Popa <pcmanticore@gmail.com> # Copyright (c) 2014 Brett Cannon <brett@python.org> # Copyright (c) 2014 Arun Persau...
1
19,947
You need to modify the copyrite aliases so it's done automatically.
PyCQA-pylint
py
@@ -174,6 +174,13 @@ function createElement(...args) { let type = vnode.type, props = vnode.props; if (typeof type!='function') { + Object.keys(props).forEach(key => { + if (/^on(Ani|Tra)/.test(key)) { + props[key.toLowerCase()] = props[key]; + delete props[key]; + } + }); + if (props.defaultValue)...
1
import { hydrate, render as preactRender, cloneElement as preactCloneElement, createRef, h, Component, options, toChildArray, createContext, Fragment, _unmount } from 'preact'; import * as hooks from 'preact/hooks'; import { Suspense, lazy } from './suspense'; import { assign, removeNode } from '../../src/util'; const...
1
13,985
Quick question: Is this true for all `onAnimation*` and all `onTransition*` events?
preactjs-preact
js
@@ -59,6 +59,8 @@ function Address(data, network, type) { info = Address._transformPublicKey(data); } else if (data.constructor && (data.constructor.name && data.constructor.name === 'Script')) { info = Address._transformScript(data); + } else if (data instanceof Address) { + return data; } else if ...
1
'use strict'; var base58check = require('./encoding/base58check'); var networks = require('./networks'); var Hash = require('./crypto/hash'); /** * * Instantiate an address from an address String or Buffer, a public key or script hash Buffer, * or an instance of PublicKey or Script. * * @example * * // validat...
1
13,169
Should sending an address into address error? Since the call isn't needed, and could be fixed easily.
bitpay-bitcore
js
@@ -26,6 +26,7 @@ import java.util.List; import java.util.Map; import java.util.TreeMap; +import org.apache.log4j.MDC; import org.apache.lucene.index.MultiTerms; import org.apache.lucene.index.Terms; import org.apache.lucene.index.TermsEnum;
1
/* * Licensed to the Apache Software Foundation (ASF) under one or more * contributor license agreements. See the NOTICE file distributed with * this work for additional information regarding copyright ownership. * The ASF licenses this file to You under the Apache License, Version 2.0 * (the "License"); you may ...
1
33,687
This is the wrong MDC; see MDCLoggingContext which imports `org.slf4j.MDC`
apache-lucene-solr
java
@@ -127,6 +127,9 @@ public interface HistoricDetailQuery extends Query<HistoricDetailQuery, Historic /** Only select historic details that have occurred after the given date (inclusive). */ HistoricDetailQuery occurredAfter(Date date); + /** Only select historic details that were set during the process start. ...
1
/* * Copyright Camunda Services GmbH and/or licensed to Camunda Services GmbH * under one or more contributor license agreements. See the NOTICE file * distributed with this work for additional information regarding copyright * ownership. Camunda licenses this file to you under the Apache License, * Version 2.0; y...
1
9,932
Maybe we can clarify a bit what that means.
camunda-camunda-bpm-platform
java
@@ -94,7 +94,7 @@ namespace Microsoft.AspNet.Server.Kestrel.Http { tcs2.SetResult(task2.Result); } - }, tcs); + }, tcs, cancellationToken); return tcs.Task; }
1
// Copyright (c) .NET Foundation. All rights reserved. // Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information. using System; using System.IO; using System.Threading; using System.Threading.Tasks; namespace Microsoft.AspNet.Server.Kestrel.Http { public class ...
1
6,604
This entire method can be deleted; it isn't used and it isn't an override of Stream.
aspnet-KestrelHttpServer
.cs
@@ -50,6 +50,8 @@ import org.apache.iceberg.util.Pair; import org.slf4j.Logger; import org.slf4j.LoggerFactory; +import static org.apache.iceberg.MetadataTableUtils.createMetadataTableInstance; + /** * Implementation of Iceberg tables that uses the Hadoop FileSystem * to store metadata and manifests.
1
/* * Licensed to the Apache Software Foundation (ASF) under one * or more contributor license agreements. See the NOTICE file * distributed with this work for additional information * regarding copyright ownership. The ASF licenses this file * to you under the Apache License, Version 2.0 (the * "License"); you ...
1
24,382
We avoid static method imports. Can you call `MetadataTableUtils.createMetadataTableInstance` instead?
apache-iceberg
java
@@ -254,6 +254,7 @@ class PACFetcher(QObject): def __eq__(self, other): # pylint: disable=protected-access return self._pac_url == other._pac_url + # pylint: enable=protected-access def __repr__(self): return utils.get_repr(self, url=self._pac_url, constructor=True)
1
# vim: ft=python fileencoding=utf-8 sts=4 sw=4 et: # Copyright 2016-2017 Florian Bruhin (The Compiler) <mail@qutebrowser.org> # # This file is part of qutebrowser. # # qutebrowser is free software: you can redistribute it and/or modify # it under the terms of the GNU General Public License as published by # the Free S...
1
19,410
No need for this, as pylint already only turns things off for this function and it's needed for the entire function.
qutebrowser-qutebrowser
py
@@ -37,7 +37,13 @@ class Purchase < ActiveRecord::Base to: :purchaseable, prefix: :purchaseable, allow_nil: true - delegate :fulfilled_with_github?, :subscription?, :terms, to: :purchaseable + delegate( + :fulfilled_with_github?, + :includes_mentor?, + :subscription?, + :terms, + to: :pu...
1
require 'digest/md5' class Purchase < ActiveRecord::Base PAYMENT_METHODS = %w(stripe paypal subscription free) belongs_to :user belongs_to :purchaseable, polymorphic: true belongs_to :coupon serialize :github_usernames attr_accessor :stripe_token, :paypal_url, :password validates :email, presence: tru...
1
9,785
I'm actually surprised this is valid Ruby. I thought you'd need either `delegate(...)` or `delegate \ ...`.
thoughtbot-upcase
rb
@@ -99,7 +99,7 @@ public class TestHelpers { if (checkArrowValidityVector) { ColumnVector columnVector = batch.column(i); ValueVector arrowVector = ((IcebergArrowColumnVector) columnVector).vectorAccessor().getVector(); - Assert.assertEquals("Nullability doesn't match", expectedV...
1
/* * Licensed to the Apache Software Foundation (ASF) under one * or more contributor license agreements. See the NOTICE file * distributed with this work for additional information * regarding copyright ownership. The ASF licenses this file * to you under the Apache License, Version 2.0 (the * "License"); you ...
1
24,883
Why change this?
apache-iceberg
java
@@ -537,6 +537,12 @@ module.exports = class XHRUpload extends Plugin { const files = fileIDs.map((fileID) => this.uppy.getFile(fileID)) if (this.opts.bundle) { + // if bundle: true, we don’t support remote uploads + const isSomeFileRemote = files.some(file => file.isRemote) + if (isSomeFileRe...
1
const { Plugin } = require('@uppy/core') const cuid = require('cuid') const Translator = require('@uppy/utils/lib/Translator') const { Provider, RequestClient, Socket } = require('@uppy/companion-client') const emitSocketProgress = require('@uppy/utils/lib/emitSocketProgress') const getSocketHost = require('@uppy/utils...
1
12,368
Maybe change it to `'Can't UPLOAD remote files when bundle: true is set'`?
transloadit-uppy
js
@@ -217,7 +217,14 @@ namespace OpenTelemetry if (this.circularBuffer.Count > 0) { - this.exporter.Export(new Batch<T>(this.circularBuffer, this.maxExportBatchSize)); + try + { + this.exporter.Export(new B...
1
// <copyright file="BatchExportProcessor.cs" company="OpenTelemetry Authors"> // Copyright The OpenTelemetry Authors // // Licensed under the Apache License, Version 2.0 (the "License"); // you may not use this file except in compliance with the License. // You may obtain a copy of the License at // // http://www.a...
1
18,524
Do we need to drop the remaining items from the batch? Otherwise we might end up with a dead loop. Add @CodeBlanch for awareness.
open-telemetry-opentelemetry-dotnet
.cs
@@ -292,6 +292,19 @@ func setupMiners(st state.Tree, sm vm.StorageMap, keys []*types.KeyInfo, miners return nil, err } } + if m.NumCommittedSectors > 0 { + // Now submit a dummy PoSt right away to trigger power updates. + // Don't worry, bootstrap miner actors don't need to verify + // that the PoSt ...
1
package gengen import ( "context" "fmt" "io" mrand "math/rand" "strconv" "github.com/filecoin-project/go-filecoin/actor" "github.com/filecoin-project/go-filecoin/actor/builtin" "github.com/filecoin-project/go-filecoin/actor/builtin/account" "github.com/filecoin-project/go-filecoin/address" "github.com/filec...
1
19,929
Because power is now added during `submitPoSt` this is needed for setting power in the genesis block. Again let me know if this bootstrapping solution is flawed.
filecoin-project-venus
go
@@ -40,6 +40,10 @@ return [ 'session_gc' => ['int'], 'timezone_identifiers_list' => ['list<string>|false', 'timezoneGroup='=>'int', 'countryCode='=>'?string'], 'unpack' => ['array', 'format'=>'string', 'string'=>'string', 'offset='=>'int'], + 'ReflectionFunction::getReturnType' => ['?ReflectionNamedTy...
1
<?php // phpcs:ignoreFile /** * This contains the information needed to convert the function signatures for php 7.1 to php 7.0 (and vice versa) * * This has two sections. * The 'new' section contains function/method names from FunctionSignatureMap (And alternates, if applicable) that do not exist in php7.0 or have...
1
10,711
To be consistent, these should go at the top between `DateTimeZone::listIdentifiers` and `SQLite3::createFunction`.
vimeo-psalm
php
@@ -165,4 +165,13 @@ public abstract class Directory implements Closeable { * @throws AlreadyClosedException if this Directory is closed */ protected void ensureOpen() throws AlreadyClosedException {} + + /** + * Implementations can override this if they are capable of reporting modification time + * ...
1
/* * Licensed to the Apache Software Foundation (ASF) under one or more * contributor license agreements. See the NOTICE file distributed with * this work for additional information regarding copyright ownership. * The ASF licenses this file to You under the Apache License, Version 2.0 * (the "License"); you may ...
1
25,985
I think we should avoid changing any lucene classes for the moment - fileModified() can probably stay where it is?
apache-lucene-solr
java
@@ -1174,7 +1174,7 @@ public class OverviewFragment extends Fragment implements View.OnClickListener, extendedBolusView.setText(extendedBolusText); } if (extendedBolusText.equals("")) - extendedBolusView.setVisibility(View.INVISIBLE); + extendedBo...
1
package info.nightscout.androidaps.plugins.Overview; import android.annotation.SuppressLint; import android.app.Activity; import android.app.NotificationManager; import android.content.ActivityNotFoundException; import android.content.Context; import android.content.Intent; import android.content.pm.PackageManager; im...
1
30,313
GONE breaks formating of ":". or is it fixed below?
MilosKozak-AndroidAPS
java
@@ -20,6 +20,9 @@ public class ASTResource extends ASTFormalParameter { public Object jjtAccept(JavaParserVisitor visitor, Object data) { return visitor.visit(this, data); } + + // TODO Should we deprecate all methods from ASTFormalParameter? + } /* * JavaCC - OriginalChecksum=92734fc70bba91fd...
1
/** * BSD-style license; for more info see http://pmd.sourceforge.net/license.html */ /* Generated By:JJTree: Do not edit this line. ASTResource.java Version 4.1 */ /* JavaCCOptions:MULTI=true,NODE_USES_PARSER=true,VISITOR=true,TRACK_TOKENS=false,NODE_PREFIX=AST,NODE_EXTENDS=,NODE_FACTORY= */ package net.sourceforge...
1
14,899
What do you mean with this? Won't the deprecation be inherited?
pmd-pmd
java
@@ -90,6 +90,8 @@ std::string FlatCompiler::GetUsageString(const char* program_name) const { " --cpp-ptr-type T Set object API pointer type (default std::unique_ptr)\n" " --cpp-str-type T Set object API string type (default std::string)\n" " T::c_str() and T::length() must...
1
/* * Copyright 2014 Google Inc. All rights reserved. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. * You may obtain a copy of the License at * * http://www.apache.org/licenses/LICENSE-2.0 * * Unless required by applica...
1
12,406
line between " and " should be <80 chars.
google-flatbuffers
java
@@ -7,7 +7,6 @@ module Travis class Script class Ruby < Script DEFAULTS = { - rvm: 'default', gemfile: 'Gemfile' }
1
require 'travis/build/script/shared/bundler' require 'travis/build/script/shared/jdk' require 'travis/build/script/shared/rvm' module Travis module Build class Script class Ruby < Script DEFAULTS = { rvm: 'default', gemfile: 'Gemfile' } include Bundler, RVM,...
1
13,366
What will happen if neither `rvm` nor `ruby` is present in the .travis.yml?
travis-ci-travis-build
rb
@@ -71,8 +71,7 @@ class HCI_ACL_Hdr(Packet): def post_build(self, p, pay): p += pay if self.len is None: - l = len(p)-4 - p = p[:2]+chr(l&0xff)+chr((l>>8)&0xff)+p[4:] + p = p[:2] + struct.pack("<H", len(pay)) + p[4:] return p
1
## This file is part of Scapy ## See http://www.secdev.org/projects/scapy for more informations ## Copyright (C) Philippe Biondi <phil@secdev.org> ## Copyright (C) Mike Ryan <mikeryan@lacklustre.net> ## This program is published under a GPLv2 license """ Bluetooth layers, sockets and send/receive functions. """ impor...
1
11,095
@p-l- Hey it seems that this was len-4 ?!
secdev-scapy
py
@@ -23,12 +23,14 @@ import AdBlockerWarning from './ad-blocker-warning'; import { render } from '../../../../../tests/js/test-utils'; import { STORE_NAME } from '../datastore/constants'; -const setupAdBlockerRegistry = async ( registry ) => { - await registry.dispatch( STORE_NAME ).receiveIsAdBlockerActive( true );...
1
/** * AdSense AdBlocker Warning component tests. * * Site Kit by Google, Copyright 2020 Google LLC * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. * You may obtain a copy of the License at * * https://www.apache.org/lice...
1
29,213
This is something I added which resolved a few large errors in the output, although not related to the refactor here I don't think.
google-site-kit-wp
js
@@ -200,7 +200,6 @@ public class ExternalPlayerFragment extends Fragment { .into(imgvCover); if (controller != null && controller.isPlayingVideoLocally()) { - butPlay.setVisibility(View.GONE); ((MainActivity) getActivity()).getBottomSheet().setLocked(true); ...
1
package de.danoeh.antennapod.fragment; import android.content.Intent; import android.os.Bundle; import android.util.Log; import android.view.LayoutInflater; import android.view.View; import android.view.ViewGroup; import android.widget.ImageButton; import android.widget.ImageView; import android.widget.ProgressBar; im...
1
17,104
i have removed this line because whenever a video is played in AntennaPod this line was making play button invisible
AntennaPod-AntennaPod
java
@@ -0,0 +1,10 @@ +package org.apache.servicecomb.foundation.vertx; + +import org.junit.Test; + +public class MyTest { + @Test + public void myTest() { + System.out.println(System.getProperty("java.io.tmpdir")); + } +}
1
1
12,292
remove temporary code
apache-servicecomb-java-chassis
java
@@ -154,4 +154,11 @@ public interface BlockHeader { * @return The Keccak 256-bit hash of this header. */ Hash getBlockHash(); + + /** + * The BASEFEE of this header. + * + * @return TheBASEFEE of this header. + */ + Long getBaseFee(); }
1
/* * Copyright ConsenSys AG. * * Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with * the License. You may obtain a copy of the License at * * http://www.apache.org/licenses/LICENSE-2.0 * * Unless required by applicable law or agreed to in writing...
1
22,002
* Should be tagged `@Unstable` * Should be a default method, returning `null` * Also, perhaps `Optional<Long>` instead of just `Long`? Always empty when the BASEFEE isn't relevant? If so the default is `Optional.empty()`
hyperledger-besu
java
@@ -30,6 +30,7 @@ import { STORE_NAME as CORE_SITE } from '../datastore/site/constants'; import { STORE_NAME as CORE_USER } from '../datastore/user/constants'; const MODULE_SLUG = 'test-slug'; +const TEST_STORE_NAME = 'test/' + MODULE_SLUG; describe( 'createInfoStore store', () => { let registry;
1
/** * Info datastore functions tests. * * Site Kit by Google, Copyright 2020 Google LLC * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. * You may obtain a copy of the License at * * https://www.apache.org/licenses/LICENS...
1
34,704
Minor detail, but let's use the interpolated template string syntax instead.
google-site-kit-wp
js
@@ -53,6 +53,11 @@ type TimeChaosSpec struct { // TimeOffset defines the delta time of injected program TimeOffset TimeOffset `json:"timeOffset"` + // ClockIds defines all affected clock id + // All available options are ["CLOCK_REALTIME","CLOCK_MONOTONIC","CLOCK_PROCESS_CPUTIME_ID","CLOCK_THREAD_CPUTIME_ID","CLO...
1
// Copyright 2020 PingCAP, Inc. // // Licensed under the Apache License, Version 2.0 (the "License"); // you may not use this file except in compliance with the License. // You may obtain a copy of the License at // // http://www.apache.org/licenses/LICENSE-2.0 // // Unless required by applicable law or agreed to i...
1
13,643
this line is so long, split it to multi lines.
chaos-mesh-chaos-mesh
go
@@ -2865,7 +2865,7 @@ void AdjustValidatorOptions(const DeviceExtensions &device_extensions, const Dev if (device_extensions.vk_khr_uniform_buffer_standard_layout && enabled_features.core12.uniformBufferStandardLayout == VK_TRUE) { options.SetUniformBufferStandardLayout(true); } - if (device_exten...
1
/* Copyright (c) 2015-2021 The Khronos Group Inc. * Copyright (c) 2015-2021 Valve Corporation * Copyright (c) 2015-2021 LunarG, Inc. * Copyright (C) 2015-2021 Google Inc. * Modifications Copyright (C) 2020 Advanced Micro Devices, Inc. All rights reserved. * * Licensed under the Apache License, Version 2.0 (the "L...
1
19,973
Looks like this might be one of those "promoted features" where you can enable it by _either_ enabling the extension _or_ enabling the feature bit. If that is the case, I think this needs to be: `(device_extensions.vk_ext_scalar_block_layout == kEnabledByCreateinfo) || (enabled_features.core12.scalarBlockLayout == VK_T...
KhronosGroup-Vulkan-ValidationLayers
cpp
@@ -52,6 +52,10 @@ template struct ONEDAL_EXPORT integer_overflow_ops<std::uint16_t>; template struct ONEDAL_EXPORT integer_overflow_ops<std::uint32_t>; template struct ONEDAL_EXPORT integer_overflow_ops<std::uint64_t>; +#if defined(__APPLE__) +template struct ONEDAL_EXPORT integer_overflow_ops<std::size_t>; +#endi...
1
/******************************************************************************* * Copyright 2020-2021 Intel Corporation * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. * You may obtain a copy of the License at * * http://www.apa...
1
29,935
Why should we define it for v1? This is preserved only for backward compatibility, all further modifications must be done in the latest vX
oneapi-src-oneDAL
cpp
@@ -229,12 +229,8 @@ class DaskInterface(PandasInterface): return columns.data.compute() @classmethod - def length(cls, dataset): - """ - Length of dask dataframe is unknown, always return 1 - for performance, use shape to compute dataframe shape. - """ - return 1 +...
1
from __future__ import absolute_import try: import itertools.izip as zip except ImportError: pass import numpy as np import pandas as pd import dask.dataframe as dd from dask.dataframe import DataFrame from dask.dataframe.core import Scalar from .. import util from ..element import Element from ..ndmapping i...
1
15,886
This is a definite improvement! Hardcoding nonzero is vastly better than hardcoding length. Even so, is there no way to determine the actual value of nonzero in a way that doesn't load the entire dataset?
holoviz-holoviews
py
@@ -94,6 +94,13 @@ namespace OpenTelemetry.Instrumentation.Http.Implementation return hostTagValue; } + /// <summary> + /// Gets the OpenTelemetry standard uri tag value for a span based on its request <see cref="Uri"/>. + /// </summary> + /// <param name="uri"><see c...
1
// <copyright file="HttpTagHelper.cs" company="OpenTelemetry Authors"> // Copyright The OpenTelemetry Authors // // Licensed under the Apache License, Version 2.0 (the "License"); // you may not use this file except in compliance with the License. // You may obtain a copy of the License at // // http://www.apache.o...
1
19,868
do we have a way to avoid the string concats, if there is no username/password in the Uri? if (uri has UsernameInfo) { do what is done in this PR. } else { existing behavior. }
open-telemetry-opentelemetry-dotnet
.cs
@@ -1862,6 +1862,7 @@ static void cb_stackdriver_flush(const void *data, size_t bytes, else { /* The request was issued successfully, validate the 'error' field */ flb_plg_debug(ctx->ins, "HTTP Status=%i", c->resp.status); + flb_plg_debug(ctx->ins, "HTTP data=%s", c->resp.data); i...
1
/* -*- Mode: C; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */ /* Fluent Bit * ========== * Copyright (C) 2019-2020 The Fluent Bit Authors * Copyright (C) 2015-2018 Treasure Data Inc. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in co...
1
13,036
do not print the payload since it might be corrupted, you can get the data with _debug.http.response_payload configuration property
fluent-fluent-bit
c
@@ -33,6 +33,7 @@ var _ = Describe("addons flow", func() { It("app init creates an copilot directory", func() { Expect("./copilot").Should(BeADirectory()) + Expect("./copilot/.workspace").Should(BeAnExistingFile()) }) It("app ls includes new app", func() {
1
// Copyright Amazon.com Inc. or its affiliates. All Rights Reserved. // SPDX-License-Identifier: Apache-2.0 package addons_test import ( "encoding/json" "fmt" "io" "io/ioutil" "net/http" "os" "github.com/aws/amazon-ecs-cli-v2/e2e/internal/client" . "github.com/onsi/ginkgo" . "github.com/onsi/gomega" ) var ...
1
13,771
maybe "app init creates an copilot directory and a workspace file"? since you validate for the file as well.
aws-copilot-cli
go
@@ -7,10 +7,9 @@ class Topic < ActiveRecord::Base options.has_many :products, source_type: 'Product' options.has_many :topics, source_type: 'Topic' options.has_many :videos, source_type: 'Video' + options.has_many :trails, source_type: 'Trail' end - has_many :trails - validates :name, presenc...
1
class Topic < ActiveRecord::Base extend FriendlyId has_many :classifications, dependent: :destroy with_options(through: :classifications, source: :classifiable) do |options| options.has_many :products, source_type: 'Product' options.has_many :topics, source_type: 'Topic' options.has_many :videos, so...
1
17,455
Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
thoughtbot-upcase
rb
@@ -1,6 +1,6 @@ <?php -namespace Sabre\Event; +namespace Amp; /** * @template TReturn
1
<?php namespace Sabre\Event; /** * @template TReturn * @param callable():\Generator<mixed, mixed, mixed, TReturn> $gen * @return Promise<TReturn> */ function coroutine(callable $gen) : Promise {} /** * @template TReturn */ class Promise { /** * @return TReturn */ function wait() {} }
1
7,173
Nit: Could rename this file from SabreEvent.php now that it's not for Sabre
vimeo-psalm
php
@@ -39,4 +39,9 @@ func Start() { func Stop() { tch.Stop() yarpc.Stop() + http.Stop() + apachethrift.Stop() } + +// TODO(abg): We should probably use defers to ensure things that started up +// successfully are stopped before we exit.
1
// Copyright (c) 2016 Uber Technologies, Inc. // // Permission is hereby granted, free of charge, to any person obtaining a copy // of this software and associated documentation files (the "Software"), to deal // in the Software without restriction, including without limitation the rights // to use, copy, modify, merge...
1
10,601
I believe this `Stop` function _is_ called with deferred.
yarpc-yarpc-go
go
@@ -28,13 +28,11 @@ import { __ } from '@wordpress/i18n'; import API from 'googlesitekit-api'; import Data from 'googlesitekit-data'; import { STORE_NAME } from './constants'; -import { parseAccountID } from '../util'; import { createFetchStore } from '../../../googlesitekit/data/create-fetch-store'; const fetch...
1
/** * modules/adsense data store: URL channels. * * Site Kit by Google, Copyright 2020 Google LLC * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. * You may obtain a copy of the License at * * https://www.apache.org/licen...
1
30,632
This entire clause should now be removed. It was only relevant if `accountID` couldn't be parsed from `clientID`, which is now no longer needed.
google-site-kit-wp
js
@@ -77,10 +77,12 @@ extlinks = { } intersphinx_mapping = { - 'ansible': ('https://docs.ansible.com/ansible/devel/', None), + 'ansible': ('https://docs.ansible.com/ansible/latest/', None), 'pip': ('https://pip.pypa.io/en/latest/', None), 'python': ('https://docs.python.org/3', None), 'python2': ...
1
# -*- coding: utf-8 -*- # # Molecule documentation build configuration file, created by # sphinx-quickstart on Sat Oct 17 16:07:47 2015. # # This file is execfile()d with the current directory set to its # containing dir. # # Note that not all possible configuration values are present in this # autogenerated file. # # ...
1
8,526
FTR: Unlike commonly known practice, `latest` in Ansible docs corresponds to the stable version, not to the latest state of the main Git branch. Is this your intention? Just checking...
ansible-community-molecule
py
@@ -5207,6 +5207,18 @@ const NAType *Translate::synthesizeType() err4106arg = SQLCHARSETSTRING_UTF8; break; + case GBK_TO_UTF8: + if (translateSource->getCharSet() == CharInfo::GBK || translateSource->getCharSet() == CharInfo::UnknownCharSet ) + charsetTarget = CharInfo::UTF8; + ...
1
/********************************************************************** // @@@ START COPYRIGHT @@@ // // Licensed to the Apache Software Foundation (ASF) under one // or more contributor license agreements. See the NOTICE file // distributed with this work for additional information // regarding copyright ownership. ...
1
9,643
Why do we have || CharInfo::UnknownCharSet here? I do not see it it in neighbouring statements. This is just for my understanding.
apache-trafodion
cpp
@@ -180,6 +180,7 @@ namespace NLog.Targets /// <docgen category='Web Service Options' order='10' /> public string XmlRootNamespace { get; set; } + private readonly Dictionary<HttpWebRequest, KeyValuePair<DateTime,AsyncContinuation>> _pendingRequests = new Dictionary<HttpWebRequest, KeyValuePa...
1
// // Copyright (c) 2004-2016 Jaroslaw Kowalski <jaak@jkowalski.net>, Kim Christensen, Julian Verdurmen // // All rights reserved. // // Redistribution and use in source and binary forms, with or without // modification, are permitted provided that the following conditions // are met: // // * Redistributions of s...
1
14,515
isn't `HttpWebRequest` an expensive key value?
NLog-NLog
.cs
@@ -148,6 +148,14 @@ class Proposal < ActiveRecord::Base observations.find_by(user: user) end + def eligible_observers + if observations.count > 0 + User.where(client_slug: client).where('id not in (?)', observations.pluck('user_id')) + else + User.where(client_slug: client) + end + end +...
1
class Proposal < ActiveRecord::Base include WorkflowModel include ValueHelper has_paper_trail class_name: 'C2Version' CLIENT_MODELS = [] # this gets populated later FLOWS = %w(parallel linear).freeze workflow do state :pending do event :approve, :transitions_to => :approved event :restart...
1
15,328
couldn't we run this query whether there are observations or not?
18F-C2
rb
@@ -125,12 +125,12 @@ class CmdlineTest(unittest.TestCase): @mock.patch("logging.getLogger") def test_cmdline_other_task(self, logger): - luigi.run(['--local-scheduler', '--no-lock', 'SomeTask', '--n', '1000']) + luigi.run(['SomeTask', '--local-scheduler', '--no-lock', '--n', '1000']) ...
1
# -*- coding: utf-8 -*- # # Copyright 2012-2015 Spotify AB # # Licensed under the Apache License, Version 2.0 (the "License"); # you may not use this file except in compliance with the License. # You may obtain a copy of the License at # # http://www.apache.org/licenses/LICENSE-2.0 # # Unless required by applicable law...
1
17,969
This shouldn't be needed to change right?
spotify-luigi
py
@@ -18,14 +18,14 @@ module.exports = { "port": 8080 } }, - "files": [ "examples/cdn/*"], + "files": [ "examples/bundle/*"], "index": "index.html", "watchOptions": {}, "server": true, "proxy": false, "port": 3000, "middleware": false, - "serveStatic": ["e...
1
/* |-------------------------------------------------------------------------- | Browser-sync config file |-------------------------------------------------------------------------- | | For up-to-date information about the options: | http://www.browsersync.io/docs/options/ | | There are more options than you ...
1
9,293
This seemed broken to me. Why would browserify only check the (previously `cdn`, now) `bundle` example? And even so, the path is incorrect here. Fixing this is unrelated so should not go into this PR I feel. But when we fix this in master, perhaps that solves the reload issues that you experienced @hedgerh?
transloadit-uppy
js
@@ -11,13 +11,12 @@ namespace Datadog.Trace.AppSec.Waf.NativeBindings [StructLayout(LayoutKind.Sequential)] internal struct DdwafResultStruct { - [Obsolete("This member will be removed from then ddwaf library by a future PR")] - public DDWAF_RET_CODE Action; + public bool Timeout; + ...
1
// <copyright file="DdwafResultStruct.cs" company="Datadog"> // Unless explicitly stated otherwise all files in this repository are licensed under the Apache 2 License. // This product includes software developed at Datadog (https://www.datadoghq.com/). Copyright 2017 Datadog, Inc. // </copyright> using System; using ...
1
25,888
Same question, do we have potential version-conflict crashing scenarios here?
DataDog-dd-trace-dotnet
.cs
@@ -89,6 +89,18 @@ int RGroupDecomposition::add(const ROMol &inmol) { const bool addCoords = true; MolOps::addHs(mol, explicitOnly, addCoords); + // mark any wildcards in input molecule: + for (auto &atom : mol.atoms()) { + if (atom->getAtomicNum() == 0) { + atom->setProp("INPUT_DUMMY", true); + ...
1
// // Copyright (c) 2017-2021, Novartis Institutes for BioMedical Research Inc. // and other RDKit contributors // // All rights reserved. // // Redistribution and use in source and binary forms, with or without // modification, are permitted provided that the following conditions are // met: // // * Redistribut...
1
23,962
Definitely not required, but it would be better if you had a constexpr for `"INPUT_DUMMY"`
rdkit-rdkit
cpp
@@ -1831,11 +1831,7 @@ namespace NLog.Targets #endif try { - archiveFile = this.GetArchiveFileName(fileName, ev, upcomingWriteSize); - if (!string.IsNullOrEmpty(archiveFile)) - { - this.DoAutoArchive(archi...
1
// // Copyright (c) 2004-2016 Jaroslaw Kowalski <jaak@jkowalski.net>, Kim Christensen, Julian Verdurmen // // All rights reserved. // // Redistribution and use in source and binary forms, with or without // modification, are permitted provided that the following conditions // are met: // // * Redistributions of s...
1
13,948
It seems ok. Because already created a file name at line 1815 and already checked if it is null or empty at line 1816. If file name is null, then already this line will not executed.
NLog-NLog
.cs
@@ -71,8 +71,9 @@ public interface GenesisConfigOptions { OptionalLong getLondonBlockNumber(); - // TODO EIP-1559 change for the actual fork name when known - OptionalLong getAleutBlockNumber(); + OptionalLong getArrowGlacierBlockNumber(); + + OptionalLong getBaseFeePerGas(); OptionalLong getEIP1559Bloc...
1
/* * Copyright ConsenSys AG. * * Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with * the License. You may obtain a copy of the License at * * http://www.apache.org/licenses/LICENSE-2.0 * * Unless required by applicable law or agreed to in writing...
1
26,519
Can all the BaseFeePerGas methods that are added be removed? It's not needed for the bomb and not referenced anywhere else in this PR.
hyperledger-besu
java
@@ -172,7 +172,7 @@ func handleMainConfigArgs(cmd *cobra.Command, args []string, app *ddevapp.DdevAp if docrootRelPath != "" { app.Docroot = docrootRelPath if _, err = os.Stat(docrootRelPath); os.IsNotExist(err) { - util.Failed("The docroot provided (%v) does not exist", docrootRelPath) + output.UserOut.War...
1
package cmd import ( "fmt" "os" "strings" "path/filepath" "github.com/drud/ddev/pkg/ddevapp" "github.com/drud/ddev/pkg/output" "github.com/drud/ddev/pkg/util" "github.com/spf13/cobra" ) // docrootRelPath is the relative path to the docroot where index.php is var docrootRelPath string // siteName is the nam...
1
13,056
util.Warning()? Easier to say.
drud-ddev
php
@@ -64,8 +64,6 @@ type ( rootHash hash.Hash32B toRoot *list.List // stores the path from root to diverging node bucket string // bucket name to store the nodes - clpsK []byte // path if the node can collapse after deleting an entry - clpsV []byte // value if the node can collapse a...
1
// Copyright (c) 2018 IoTeX // This is an alpha (internal) release and is not suitable for production. This source code is provided 'as is' and no // warranties are given as to title or non-infringement, merchantability or fitness for purpose and, to the extent // permitted by law, all liability for your use of the cod...
1
12,768
these 2 no longer needed after refactor
iotexproject-iotex-core
go
@@ -63,6 +63,8 @@ const ( SpecExportOptionsEmpty = "empty_export_options" SpecMountOptions = "mount_options" SpecCSIMountOptions = "csi_mount_options" + SpecCSIRawBlock = "fadirectRawBlock" + SpecCSIFsType = "fsType" SpecSharedv4MountOptions = "sharedv4_mount_options" SpecProxyProtocolS3 ...
1
package api import ( "context" "fmt" "math" "strconv" "strings" "time" "github.com/golang/protobuf/ptypes" "github.com/libopenstorage/openstorage/pkg/auth" "github.com/mohae/deepcopy" protoimpl "google.golang.org/protobuf/runtime/protoimpl" ) // Strings for VolumeSpec const ( Name = "n...
1
8,993
most spec options appear to be snake case - `fa_direct_raw_block`, let's stick to that convention
libopenstorage-openstorage
go
@@ -4,7 +4,6 @@ var globby = require('globby'); var WebDriver = require('selenium-webdriver'); var chrome = require('selenium-webdriver/chrome'); var chromedriver = require('chromedriver'); -var isCI = require('is-ci'); var args = process.argv.slice(2);
1
/*global window, Promise */ var globby = require('globby'); var WebDriver = require('selenium-webdriver'); var chrome = require('selenium-webdriver/chrome'); var chromedriver = require('chromedriver'); var isCI = require('is-ci'); var args = process.argv.slice(2); // allow running certain browsers through command li...
1
16,114
Looks like we can then drop this dependency.
dequelabs-axe-core
js
@@ -667,6 +667,10 @@ class FlowMaster(controller.Master): self.add_event("Script error:\n" + str(e), "error") self.scripts.remove(script_obj) + def reload_scripts(self): + for s in self.scripts[:]: + s.load() + def load_script(self, command): """ ...
1
""" This module provides more sophisticated flow tracking and provides filtering and interception facilities. """ from __future__ import absolute_import from abc import abstractmethod, ABCMeta import hashlib import Cookie import cookielib import os import re import urlparse from netlib import wsgi from netlib.exc...
1
10,889
3) Subscribe to the script change signal in `FlowMaster.__init__`. The event handler should call `self.masterq.put(("script_change", script))`. 4) Add a `handle_script_change` function, that once called, takes the script object and calls `script.reload()`.
mitmproxy-mitmproxy
py
@@ -287,4 +287,13 @@ public class EmailMessage { return this; } + + public String getBody() { + return _body.toString(); + } + + public String getSubject() { + return _subject; + } + }
1
/* * Copyright 2012 LinkedIn Corp. * * Licensed under the Apache License, Version 2.0 (the "License"); you may not * use this file except in compliance with the License. You may obtain a copy of * the License at * * http://www.apache.org/licenses/LICENSE-2.0 * * Unless required by applicable law or agreed to i...
1
11,250
This method is for unit testing only, right? How about making it package private? This way the readers would know that this is not a public API outside this package and would reduce the search space.
azkaban-azkaban
java
@@ -0,0 +1 @@ +package project
1
1
11,308
accidental? i guess it's the same as any other boilerplate
lyft-clutch
go
@@ -1,7 +1,10 @@ +from concurrent.futures import ThreadPoolExecutor, TimeoutError from pyramid.security import NO_PERMISSION_REQUIRED +from kinto import logger from kinto.core import Service + heartbeat = Service(name="heartbeat", path='/__heartbeat__', description="Server health")
1
from pyramid.security import NO_PERMISSION_REQUIRED from kinto.core import Service heartbeat = Service(name="heartbeat", path='/__heartbeat__', description="Server health") @heartbeat.get(permission=NO_PERMISSION_REQUIRED) def get_heartbeat(request): """Return information about server health...
1
9,295
shadowing the builtin, let's use function or func or callable_
Kinto-kinto
py
@@ -0,0 +1,8 @@ +# pylint: disable=missing-docstring,expression-not-assigned,too-few-public-methods,pointless-statement + +class Unhashable(object): + __hash__ = list.__hash__ + +{}[[]] # [unhashable-dict-key] +{}[{}] # [unhashable-dict-key] +{}[Unhashable()] # [unhashable-dict-key]
1
1
10,211
Can you add some good examples, for instance integers, strings and whatnot?
PyCQA-pylint
py
@@ -1,3 +1,17 @@ +// Copyright © 2017-2019 The OpenEBS Authors +// +// Licensed under the Apache License, Version 2.0 (the "License"); +// you may not use this file except in compliance with the License. +// You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless re...
1
package command import ( "reflect" "testing" "github.com/spf13/cobra" ) // TestNewCStorPoolMgmt is to test cstor-pool-mgmt command. func TestNewCStorPoolMgmt(t *testing.T) { cases := []struct { use string }{ {"start"}, } cmd, err := NewCStorPoolMgmt() if err != nil { t.Errorf("Unable to Instantiate cst...
1
14,784
Can we just have 2017 here @kmova if possible, as i seen in other projects as well( kubernetes etc..), they mentioned only the year when the file has been created.
openebs-maya
go
@@ -460,8 +460,7 @@ std::vector<DPFSubstring> DebugPrintf::ParseFormatString(const std::string forma std::string DebugPrintf::FindFormatString(std::vector<unsigned int> pgm, uint32_t string_id) { std::string format_string; - SHADER_MODULE_STATE shader; - shader.words = pgm; + SHADER_MODULE_STATE shader...
1
/* Copyright (c) 2020-2021 The Khronos Group Inc. * Copyright (c) 2020-2021 Valve Corporation * Copyright (c) 2020-2021 LunarG, Inc. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. * You may obtain a copy of the License at * ...
1
21,494
@Tony-LunarG I just realized that this differs from the previous behavior in that spirv-opt will run on the byte code if there are any "group decorations." If this is a problem, I can add an additional constructor to keep the pre-existing behavior.
KhronosGroup-Vulkan-ValidationLayers
cpp
@@ -86,9 +86,9 @@ public class ParquetMetrics implements Serializable { Types.NestedField field = fileSchema.asStruct().field(fieldId); if (field != null && stats.hasNonNullValue()) { updateMin(lowerBounds, fieldId, - fromParquetPrimitive(field.type(), stats.genericGetM...
1
/* * Licensed to the Apache Software Foundation (ASF) under one * or more contributor license agreements. See the NOTICE file * distributed with this work for additional information * regarding copyright ownership. The ASF licenses this file * to you under the Apache License, Version 2.0 (the * "License"); you ...
1
12,956
Nit: continuation lines should be indented 4 spaces from the start of the statement.
apache-iceberg
java
@@ -487,6 +487,7 @@ int sysfs_finalize(void) sysfs_region_destroy(&_regions[i]); } _sysfs_region_count = 0; + _sysfs_format_ptr = NULL; return FPGA_OK; }
1
// Copyright(c) 2017-2018, Intel Corporation // // Redistribution and use in source and binary forms, with or without // modification, are permitted provided that the following conditions are met: // // * Redistributions of source code must retain the above copyright notice, // this list of conditions and...
1
17,801
Are these protected by any kind of lock?
OPAE-opae-sdk
c
@@ -66,6 +66,7 @@ class FirewallRule(object): self.resource_id = kwargs.get('id') self.create_time = kwargs.get('firewall_rule_create_time') self.name = kwargs.get('firewall_rule_name') + self.hierarchical_name = kwargs.get('firewall_rule_hierarchical_name') self.kind = kwargs...
1
# Copyright 2017 The Forseti Security Authors. All rights reserved. # # Licensed under the Apache License, Version 2.0 (the "License"); # you may not use this file except in compliance with the License. # You may obtain a copy of the License at # # http://www.apache.org/licenses/LICENSE-2.0 # # Unless required by ap...
1
28,040
This should probably default to a string, as get_resource_ancestors is causing the tests to fail due to the rsplit on a None hierarchical_name.
forseti-security-forseti-security
py
@@ -170,6 +170,7 @@ type ACMEChallengeSolverHTTP01Ingress struct { // The ingress class to use when creating Ingress resources to solve ACME // challenges that use this challenge solver. + // A reference by name to a Kubernetes [IngressClass](https://kubernetes.io/docs/concepts/services-networking/ingress/#ingres...
1
/* Copyright 2019 The Jetstack cert-manager contributors. Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed...
1
22,959
I prefer not to have markdown here, while it is nice for the site this is also shown for `kubectl explain` where this will look weird
jetstack-cert-manager
go
@@ -26,7 +26,7 @@ describe('monitoring', function () { mockServer.setMessageHandler(request => { const doc = request.document; if (doc.ismaster || doc.hello) { - request.reply(Object.assign({}, mock.DEFAULT_ISMASTER)); + request.reply(Object.assign({}, mock.DEFAULT_ISMASTER_36)); ...
1
'use strict'; const mock = require('../../tools/mock'); const { ServerType } = require('../../../src/sdam/common'); const { Topology } = require('../../../src/sdam/topology'); const { Monitor } = require('../../../src/sdam/monitor'); const { expect } = require('chai'); const { ServerDescription } = require('../../../sr...
1
21,292
@durran Was this change intended to be included in this PR?
mongodb-node-mongodb-native
js
@@ -110,7 +110,7 @@ namespace pwiz.SkylineTestFunctional Assert.AreEqual(z, key.Charge); Assert.AreEqual(adduct, key.Adduct); Assert.AreEqual(caffeineInChiKey, key.Target.ToString()); - var viewLibPepInfo = new ViewLibraryPepInfo(key); + v...
1
/* * Original author: Brendan MacLean <brendanx .at. u.washington.edu>, * MacCoss Lab, Department of Genome Sciences, UW * * Copyright 2009 University of Washington - Seattle, WA * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in co...
1
13,522
Feels like this could have a default null value to remove the need for this explicit "null" use.
ProteoWizard-pwiz
.cs
@@ -145,12 +145,12 @@ func (s *server) run(ctx context.Context, t cli.Telemetry) error { fs, err := s.createFilestore(ctx, cfg, t.Logger) if err != nil { - t.Logger.Error("failed creating firestore", zap.Error(err)) + t.Logger.Error("failed creating filestore", zap.Error(err)) return err } defer func() {...
1
// Copyright 2020 The PipeCD Authors. // // Licensed under the Apache License, Version 2.0 (the "License"); // you may not use this file except in compliance with the License. // You may obtain a copy of the License at // // http://www.apache.org/licenses/LICENSE-2.0 // // Unless required by applicable law or agree...
1
9,571
"failed to create ..."
pipe-cd-pipe
go
@@ -69,7 +69,7 @@ func PodCreator(fakeKubeClient kubernetes.Interface, podName string) { } _, err := fakeKubeClient.CoreV1().Pods("openebs").Create(podObjet) if err != nil { - glog.Errorf("Fake pod object could not be created:", err) + glog.Error("Fake pod object could not be created:", err) } } }
1
/* Copyright 2018 The OpenEBS Authors Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, soft...
1
10,207
No formatting directives, `glog.Error` will do just fine.
openebs-maya
go
@@ -34,7 +34,7 @@ module Selenium driver.manage.timeouts.implicit_wait = 6 driver.find_element(id: 'adder').click - driver.find_element(id: 'box0') + expect { driver.find_element(id: 'box0') }.not_to raise_error(WebDriver::Error::NoSuchElementError) end it '...
1
# frozen_string_literal: true # Licensed to the Software Freedom Conservancy (SFC) under one # or more contributor license agreements. See the NOTICE file # distributed with this work for additional information # regarding copyright ownership. The SFC licenses this file # to you under the Apache License, Version 2.0...
1
16,703
This should just be `.not_to raise_error` otherwise it potentially hides errors
SeleniumHQ-selenium
java
@@ -442,7 +442,18 @@ configRetry: log.Infof("Starting the Typha connection") err := typhaConnection.Start(context.Background()) if err != nil { - log.WithError(err).Fatal("Failed to connect to Typha") + log.WithError(err).Error("Failed to connect to Typha. Retrying...") + startTime := time.Now() + for ...
1
// Copyright (c) 2017-2019 Tigera, Inc. All rights reserved. // // Licensed under the Apache License, Version 2.0 (the "License"); // you may not use this file except in compliance with the License. // You may obtain a copy of the License at // // http://www.apache.org/licenses/LICENSE-2.0 // // Unless required by ...
1
16,841
Need an `if err == nil {break}` above this line so that we don't log/sleep if the retry succeeds.
projectcalico-felix
go
@@ -10,17 +10,14 @@ declare(strict_types = 1); namespace Ergonode\Attribute\Persistence\Dbal\Projector\Attribute; use Doctrine\DBAL\Connection; +use Doctrine\DBAL\DBALException; use Ergonode\Attribute\Domain\Event\Attribute\AttributeCreatedEvent; -use Ergonode\Core\Domain\Entity\AbstractId; -use Ergonode\EventSour...
1
<?php /** * Copyright © Bold Brand Commerce Sp. z o.o. All rights reserved. * See LICENSE.txt for license details. */ declare(strict_types = 1); namespace Ergonode\Attribute\Persistence\Dbal\Projector\Attribute; use Doctrine\DBAL\Connection; use Ergonode\Attribute\Domain\Event\Attribute\AttributeCreatedEvent; us...
1
8,460
Separate it to different methods :D Invoke method look's like old fashion portal class :D
ergonode-backend
php
@@ -11,11 +11,7 @@ import 'emby-button'; elem.classList.remove('hide'); elem.classList.add('expanded'); elem.style.height = 'auto'; - const height = elem.offsetHeight + 'px'; - elem.style.height = '0'; - - // trigger reflow - const newHeight = elem.offsetHeight; + ...
1
import 'css!./emby-collapse'; import 'webcomponents'; import 'emby-button'; /* eslint-disable indent */ const EmbyButtonPrototype = Object.create(HTMLDivElement.prototype); function slideDownToShow(button, elem) { elem.classList.remove('hide'); elem.classList.add('expanded'); elem.st...
1
16,758
Collapse/expand animation of filter is broken - not smooth.
jellyfin-jellyfin-web
js
@@ -16,16 +16,10 @@ module Travis install_sdk_components(config[:android][:components]) unless config[:android][:components].empty? end - def install - self.if '-f gradlew', './gradlew assemble', fold: 'install', retry: true - self.elif '-f build.gradle', 'gradle as...
1
module Travis module Build class Script class Android < Script include Jdk DEFAULTS = { android: { components: [], licenses: [] } } def setup super install_sdk_components(config[:android][:components]) unless ...
1
11,479
so during the `script` stage we run `mvn install`?
travis-ci-travis-build
rb
@@ -19,6 +19,7 @@ import ( "github.com/iotexproject/iotex-core/action" "github.com/iotexproject/iotex-core/action/protocol" "github.com/iotexproject/iotex-core/pkg/log" + "github.com/iotexproject/iotex-core/state/factory" ) // protocolID is the protocol ID
1
// Copyright (c) 2020 IoTeX Foundation // This is an alpha (internal) release and is not suitable for production. This source code is provided 'as is' and no // warranties are given as to title or non-infringement, merchantability or fitness for purpose and, to the extent // permitted by law, all liability for your use...
1
21,116
we may need to move CandidateNamespace to this protocol as it is only used here.
iotexproject-iotex-core
go