patch
stringlengths
17
31.2k
y
int64
1
1
oldf
stringlengths
0
2.21M
idx
int64
1
1
id
int64
4.29k
68.4k
msg
stringlengths
8
843
proj
stringclasses
212 values
lang
stringclasses
9 values
@@ -230,7 +230,12 @@ public class ExecutionControllerUtils { continue; // case UNKNOWN: case READY: - node.setStatus(Status.KILLING); + // if flow status is EXECUTION_STOPPED due to e.g. pod failure, set sub node to KILLED + if (exFlow.getStatus()==Status.EXECUT...
1
/* * Copyright 2018 LinkedIn Corp. * * Licensed under the Apache License, Version 2.0 (the "License"); you may not * use this file except in compliance with the License. You may obtain a copy of * the License at * * http://www.apache.org/licenses/LICENSE-2.0 * * Unless required by applicable law or agreed to i...
1
22,321
Just to confirm, this will take care of all the nodes in graph. right?
azkaban-azkaban
java
@@ -175,10 +175,16 @@ namespace TestPlatform.CrossPlatEngine.UnitTests.Hosting public void GetTestHostProcessStartInfoShouldIncludeConnectionInfo() { var connectionInfo = new TestRunnerConnectionInfo { Port = 123 }; + var parentProcessId = 101; + + mockProcessHelper....
1
// Copyright (c) Microsoft. All rights reserved. namespace TestPlatform.CrossPlatEngine.UnitTests.Hosting { using System; using System.Collections.Generic; using System.Diagnostics; using System.IO; using System.Linq; using System.Reflection; using System.Security.Cryptography; using M...
1
11,211
nit: remove this line. All "arrange" may be in one code block.
microsoft-vstest
.cs
@@ -14,10 +14,17 @@ import ( "runtime" + "bytes" "restic/debug" "restic/fs" ) +// Xattr is a tuple storing the xattr name and value. +type Xattr struct { + XattrName string `json:"xattrname"` + XattrValue []byte `json:"xattrvalue"` +} + // Node is a file, directory or other item in a backup. type Node s...
1
package restic import ( "encoding/json" "fmt" "os" "os/user" "strconv" "sync" "syscall" "time" "restic/errors" "runtime" "restic/debug" "restic/fs" ) // Node is a file, directory or other item in a backup. type Node struct { Name string `json:"name"` Type string `json:"type"` M...
1
7,751
This name is not a good fit, what about `ExtendedAttribute`? Or even just `Attribute`?
restic-restic
go
@@ -0,0 +1,18 @@ +#include "test_assert.h" + +int testing_fails = 0; + +void TestFail(const char *expval, const char *val, const char *exp, + const char *file, int line) { + TEST_OUTPUT_LINE("VALUE: \"%s\"", expval); + TEST_OUTPUT_LINE("EXPECTED: \"%s\"", val); + TEST_OUTPUT_LINE("TEST FAILED: %s:%d, %s...
1
1
13,989
lets keep our "testing framework" header only if possible. since there is an `assert(0)` in there, it is intended to halt on the first test failure.
google-flatbuffers
java
@@ -26,9 +26,8 @@ import ( "github.com/iotexproject/iotex-core/action/protocol" "github.com/iotexproject/iotex-core/action/protocol/account" - accountutil "github.com/iotexproject/iotex-core/action/protocol/account/util" + "github.com/iotexproject/iotex-core/action/protocol/account/util" "github.com/iotexprojec...
1
// Copyright (c) 2018 IoTeX // This is an alpha (internal) release and is not suitable for production. This source code is provided 'as is' and no // warranties are given as to title or non-infringement, merchantability or fitness for purpose and, to the extent // permitted by law, all liability for your use of the cod...
1
17,593
File is not `goimports`-ed (from `goimports`)
iotexproject-iotex-core
go
@@ -104,7 +104,6 @@ public class TableMigrationUtil { .withMetrics(metrics) .withPartitionPath(partitionKey) .build(); - }).collect(Collectors.toList()); } catch (IOException e) { throw new RuntimeException("Unable to list files in partition: " +...
1
/* * Licensed to the Apache Software Foundation (ASF) under one * or more contributor license agreements. See the NOTICE file * distributed with this work for additional information * regarding copyright ownership. The ASF licenses this file * to you under the Apache License, Version 2.0 (the * "License"); you ...
1
43,289
I was saving this white-space for my retirement :nit:
apache-iceberg
java
@@ -133,6 +133,10 @@ module Blacklight::Controller def discard_flash_if_xhr flash.discard if request.xhr? end + deprecation_deprecate discard_flash_if_xhr: "Discarding flash messages on XHR requests is deprecated. + If you wish to continue this behavior, add this method to your ApplicationContr...
1
# frozen_string_literal: true # Filters added to this controller apply to all controllers in the hosting application # as this module is mixed-in to the application controller in the hosting app on installation. module Blacklight::Controller extend ActiveSupport::Concern extend Deprecation self.deprecation_horizo...
1
7,952
What if you don't want to continue with the behavior, but you just want the deprecation to go away? Should we add `skip_after_action :discard_flash_if_xhr`?
projectblacklight-blacklight
rb
@@ -309,7 +309,7 @@ func (ws *workingSet) validateNonce(blk *block.Block) error { } // Verify each account's Nonce for srcAddr, receivedNonces := range accountNonceMap { - confirmedState, err := accountutil.AccountState(ws, srcAddr) + confirmedState, err := accountutil.AccountStateByHash160(ws, srcAddr) if e...
1
// Copyright (c) 2019 IoTeX Foundation // This is an alpha (internal) release and is not suitable for production. This source code is provided 'as is' and no // warranties are given as to title or non-infringement, merchantability or fitness for purpose and, to the extent // permitted by law, all liability for your use...
1
23,691
change `accountNonceMap` to map[address.Address][]uint64
iotexproject-iotex-core
go
@@ -38,6 +38,7 @@ public class GapicCodeGeneratorTest extends GapicTestBase2 { .put(MainGapicProviderFactory.NODEJS, MainGapicProviderFactory.NODEJS) .put(MainGapicProviderFactory.NODEJS_DOC, MainGapicProviderFactory.NODEJS) .put(MainGapicProviderFactory.CSHARP, MainGapicProviderFactory...
1
/* Copyright 2016 Google Inc * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. * You may obtain a copy of the License at * * http://www.apache.org/licenses/LICENSE-2.0 * * Unless required by applicable law or agreed to in ...
1
23,910
The `CLIENT_CONFIG` is "client_config" with underscore, so we can't reuse it in the second arg.
googleapis-gapic-generator
java
@@ -62,6 +62,19 @@ func serviceLoggedIn(ctx context.Context, config Config, name string, } } + if adminFeatureList[session.UID] { + log.CDebugf(ctx, "Enabling a dir op batch size of %d", + bgFlushDirOpBatchSizeDefault) + // NOTE: This overrides any command-line parameter. It only + // matters until we un-f...
1
// Copyright 2016 Keybase Inc. All rights reserved. // Use of this source code is governed by a BSD // license that can be found in the LICENSE file. package libkbfs import ( "github.com/keybase/client/go/protocol/keybase1" "golang.org/x/net/context" ) // TODO: Add a server endpoint to get this data. var adminFeat...
1
16,639
Does this mean all admins get the default batch size (which is 20) no matter the value of `-sync-batch-size`? It seems the command line flag doesn't do anything then does it?
keybase-kbfs
go
@@ -35,8 +35,11 @@ class CurlDownloader implements DownloaderInterface * * @throws DownloaderException */ - public function download(string $url, array $headers = []): string + public function download(string $url, array $headers = [], array $acceptedContentTypes = null): string { + ...
1
<?php /** * Copyright © Ergonode Sp. z o.o. All rights reserved. * See LICENSE.txt for license details. */ declare(strict_types=1); namespace Ergonode\Core\Infrastructure\Service; use Symfony\Component\HttpFoundation\Response; use Ergonode\Core\Infrastructure\Exception\DownloaderException; use Psr\Log\LoggerInter...
1
9,718
Set default value as empty array instead of null
ergonode-backend
php
@@ -121,6 +121,10 @@ mainLoop: logrus.WithField("route", routeUpd).Debug("Ignoring route with no link index.") continue } + if routeUpd.Dst == nil { + logrus.WithField("route", routeUpd).Debug("Ignoring route with no destination") + continue + } idx := routeUpd.LinkIndex oldUpds := upd...
1
// Copyright (c) 2020-2021 Tigera, Inc. All rights reserved. // // Licensed under the Apache License, Version 2.0 (the "License"); // you may not use this file except in compliance with the License. // You may obtain a copy of the License at // // http://www.apache.org/licenses/LICENSE-2.0 // // Unless required by ...
1
19,028
Would be good to UT this case
projectcalico-felix
go
@@ -40,7 +40,7 @@ namespace Ethereum.Blockchain.Test { string expectedTypeName = ExpectedTypeName(directory); Type type = types.SingleOrDefault(t => string.Equals(t.Name, expectedTypeName, StringComparison.InvariantCultureIgnoreCase)); - if(type == null && d...
1
/* * Copyright (c) 2018 Demerzel Solutions Limited * This file is part of the Nethermind library. * * The Nethermind library is free software: you can redistribute it and/or modify * it under the terms of the GNU Lesser General Public License as published by * the Free Software Foundation, either version 3 of th...
1
24,367
this was updated after linking the latest ethereum/tests after a submodules recursive update
NethermindEth-nethermind
.cs
@@ -13,6 +13,7 @@ import { Fragment } from './create-element'; export function Component(props, context) { this.props = props; this.context = context; + this.__data = {}; } /**
1
import { assign } from './util'; import { diff, commitRoot } from './diff/index'; import options from './options'; import { Fragment } from './create-element'; /** * Base Component class. Provides `setState()` and `forceUpdate()`, which * trigger rendering * @param {object} props The initial component props * @par...
1
14,624
Todo: find a way to only do this in one spot, ideally with defaults for the stuff we use
preactjs-preact
js
@@ -21,14 +21,19 @@ package org.apache.iceberg.parquet; import java.io.File; import java.io.IOException; +import java.util.Map; + import org.apache.avro.generic.GenericData; import org.apache.iceberg.Metrics; import org.apache.iceberg.Schema; import org.apache.iceberg.TestMetrics; import org.apache.iceberg.io....
1
/* * Licensed to the Apache Software Foundation (ASF) under one * or more contributor license agreements. See the NOTICE file * distributed with this work for additional information * regarding copyright ownership. The ASF licenses this file * to you under the Apache License, Version 2.0 (the * "License"); you ...
1
15,123
Imports should not have blank lines. Sorry there isn't a checkstyle rule running for this yet, we still need to update the build for this one.
apache-iceberg
java
@@ -3096,6 +3096,8 @@ class Booster(object): """Evaluate training or validation data.""" if data_idx >= self.__num_dataset: raise ValueError("Data_idx should be smaller than number of dataset") + if callable(feval): + feval = [feval] self.__get_eval_info() ...
1
# coding: utf-8 """Wrapper for C API of LightGBM.""" from __future__ import absolute_import, print_function import copy import ctypes import os import warnings from tempfile import NamedTemporaryFile from collections import OrderedDict import numpy as np import scipy.sparse from .compat import (PANDAS_INSTALLED, Dat...
1
25,339
Please move this to L3115 to group the code logically - all code for `feval` in one place.
microsoft-LightGBM
cpp
@@ -103,7 +103,7 @@ import org.apache.tuweni.bytes.Bytes; import org.apache.tuweni.bytes.Bytes32; /** Provides EVMs supporting the appropriate operations for mainnet hard forks. */ -abstract class MainnetEvmRegistries { +public abstract class MainnetEvmRegistries { static EVM frontier(final GasCalculator gasCa...
1
/* * Copyright ConsenSys AG. * * Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with * the License. You may obtain a copy of the License at * * http://www.apache.org/licenses/LICENSE-2.0 * * Unless required by applicable law or agreed to in writing...
1
25,703
This was done to wrap the operation so it could be spied upon during testing. Likely needs to be undone once an alternative test is discovered.
hyperledger-besu
java
@@ -1062,7 +1062,7 @@ func nextReqFromMsg(msg []byte) (time.Time, int, bool, error) { if err := json.Unmarshal(msg, &cr); err != nil { return time.Time{}, -1, false, err } - return cr.Expires, cr.Batch, cr.NoWait, nil + return time.Now().Add(time.Duration(cr.Expires) * time.Millisecond), cr.Batch, cr.NoWait...
1
// Copyright 2019-2020 The NATS Authors // Licensed under the Apache License, Version 2.0 (the "License"); // you may not use this file except in compliance with the License. // You may obtain a copy of the License at // // http://www.apache.org/licenses/LICENSE-2.0 // // Unless required by applicable law or agreed to ...
1
11,726
I feel we need to impose a lower limit here maybe? What about a max and default for when none is set?
nats-io-nats-server
go
@@ -245,7 +245,15 @@ func (cds *contentDirectoryService) Handle(action string, argsXML []byte, r *htt "UpdateID": cds.updateIDString(), }, nil case "BrowseMetadata": - result, err := xml.Marshal(obj) + node, err := cds.vfs.Stat(obj.Path) + if err != nil { + return nil, err + } + upnpObjec...
1
package dlna import ( "context" "encoding/xml" "fmt" "log" "mime" "net/http" "net/url" "os" "path" "path/filepath" "regexp" "sort" "strings" "github.com/anacrolix/dms/dlna" "github.com/anacrolix/dms/upnp" "github.com/anacrolix/dms/upnpav" "github.com/pkg/errors" "github.com/rclone/rclone/fs" "githu...
1
9,421
ineffectual assignment to `err` (from `ineffassign`)
rclone-rclone
go
@@ -37,8 +37,8 @@ type Replacer interface { // they will be used to overwrite other replacements // if there is a name conflict. type replacer struct { - replacements map[string]string - customReplacements map[string]string + replacements map[string]func() string + customReplacements map[string]func() st...
1
package httpserver import ( "net" "net/http" "net/http/httputil" "net/url" "os" "path" "strconv" "strings" "time" ) // requestReplacer is a strings.Replacer which is used to // encode literal \r and \n characters and keep everything // on one line var requestReplacer = strings.NewReplacer( "\r", "\\r", "\n...
1
8,617
Ahhh... this makes sense. Does using functions to defer evaluation of these values have anything to do with #916 (where the `Host: {host}` was 'cached' between different hostnames)? If not, could you help me understand what this change does?
caddyserver-caddy
go
@@ -1324,7 +1324,7 @@ TNonblockingIOThread::~TNonblockingIOThread() { ownEventBase_ = false; } - if (listenSocket_ >= 0) { + if (listenSocket_ >= 0 && listenSocket_ != THRIFT_INVALID_SOCKET) { if (0 != ::THRIFT_CLOSESOCKET(listenSocket_)) { GlobalOutput.perror("TNonblockingIOThread listenSocket_...
1
/* * Licensed to the Apache Software Foundation (ASF) under one * or more contributor license agreements. See the NOTICE file * distributed with this work for additional information * regarding copyright ownership. The ASF licenses this file * to you under the Apache License, Version 2.0 (the * "License"); you ma...
1
12,733
Perhaps the only test needed is to see if the socket is not an invalid socket? Is the >= 0 test necessary at this point?
apache-thrift
c
@@ -20,7 +20,16 @@ </div> <% if current_user.subscription && current_user.stripe_customer %> - <%= render 'credit_card_form' %> + <div class='text-box'> + <%= semantic_form_for current_user.subscription, url: subscription_path(current_user.subscription) do |form| %> + <%= form.inputs "Your Sub...
1
<%= content_for :subject, 'Account' %> <div class="text-box-wrapper"> <div class="text-box"> <%= semantic_form_for current_user, url: my_account_path do |form| %> <%= form.inputs "Your Information [#{link_to('Sign out', sign_out_path, method: :delete)}]" do %> <%= form.input :first_name, label: 'Yo...
1
7,332
Could this line use `url: current_user.subscription`?
thoughtbot-upcase
rb
@@ -477,7 +477,7 @@ class Context $quoted_remove_var_id = preg_quote($remove_var_id); foreach ($clause->possibilities as $var_id => $_) { - if (preg_match('/' . $quoted_remove_var_id . '[\]\[\-]/', $var_id)) { + if (preg_match('/' . preg_quote($quoted_remove_var...
1
<?php namespace Psalm; use PhpParser; use Psalm\Checker\StatementsChecker; use Psalm\Storage\FunctionLikeStorage; use Psalm\Type\Reconciler; use Psalm\Type\Union; class Context { /** * @var array<string, Type\Union> */ public $vars_in_scope = []; /** * @var array<string, bool> */ ...
1
7,012
I was seeing `Warning: preg_match(): Unknown modifier 'a' in /path/to/project/vendor/vimeo/psalm/src/Psalm/Context.php on line 480` here
vimeo-psalm
php
@@ -1,10 +1,18 @@ package com.github.javaparser.ast.stmt; +import com.github.javaparser.JavaParser; +import com.github.javaparser.ParserConfiguration; +import com.github.javaparser.StaticJavaParser; import com.github.javaparser.ast.expr.Expression; import com.github.javaparser.ast.expr.MethodCallExpr; import com....
1
package com.github.javaparser.ast.stmt; import com.github.javaparser.ast.expr.Expression; import com.github.javaparser.ast.expr.MethodCallExpr; import com.github.javaparser.ast.expr.NameExpr; import org.junit.jupiter.api.Test; class BlockStmtTest { @Test void issue748AddingIdenticalStatementsDoesParentingRigh...
1
13,353
The changes in this file are not necessary.
javaparser-javaparser
java
@@ -1,6 +1,7 @@ package manager import ( + "github.com/kubeedge/kubeedge/pkg/apiserverlite/util" "k8s.io/apimachinery/pkg/runtime" "k8s.io/apimachinery/pkg/watch" "k8s.io/klog/v2"
1
package manager import ( "k8s.io/apimachinery/pkg/runtime" "k8s.io/apimachinery/pkg/watch" "k8s.io/klog/v2" ) // Manager define the interface of a Manager, configmapManager and podManager implement it type Manager interface { Events() chan watch.Event } // CommonResourceEventHandler can be used by configmapManag...
1
20,472
run `make lint` to fix
kubeedge-kubeedge
go
@@ -0,0 +1,7 @@ +from dagster import execute_pipeline +from docs_snippets.guides.dagster.reexecution.pipeline.unreliable_pipeline import unreliable_pipeline + + +def test_pipeline_compiles_and_executes(): + result = execute_pipeline(unreliable_pipeline) + assert result
1
1
14,392
we will need `assert result.success` instead. result will always be not null because it returns an execution result including several metadata - when the execution fails, it'd return an execution result whose `success` attribute is false.
dagster-io-dagster
py
@@ -52,6 +52,8 @@ type CStorVolumeReplica struct { type CStorVolumeReplicaSpec struct { TargetIP string `json:"targetIP"` Capacity string `json:"capacity"` + // ZvolWorkers represents number of threads that executes client IOs + ZvolWorkers string `json:"zvolWorkers"` } // CStorVolumeReplicaPhase is to hold re...
1
/* Copyright 2018 The OpenEBS Authors. Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, sof...
1
11,776
Can we mention how can one determine the best value given an infrastructure? Does it default to any value?
openebs-maya
go
@@ -1,4 +1,6 @@ -<?php namespace Backend\Widgets; +<?php + +namespace Backend\Widgets; use Lang; use Backend\Classes\WidgetBase;
1
<?php namespace Backend\Widgets; use Lang; use Backend\Classes\WidgetBase; /** * Search Widget * Used for building a toolbar, Renders a search container. * * @package october\backend * @author Alexey Bobkov, Samuel Georges */ class Search extends WidgetBase { // // Configurable properties // /*...
1
13,243
Leave this formatting the way it was please, that's the standard across all of October's files.
octobercms-october
php
@@ -7,7 +7,7 @@ import ( "strings" "github.com/opencontainers/runc/libcontainer/configs" - "github.com/opencontainers/runc/libcontainer/selinux" + selinux "github.com/opencontainers/selinux/go-selinux" ) type Validator interface {
1
package validate import ( "fmt" "os" "path/filepath" "strings" "github.com/opencontainers/runc/libcontainer/configs" "github.com/opencontainers/runc/libcontainer/selinux" ) type Validator interface { Validate(*configs.Config) error } func New() Validator { return &ConfigValidator{} } type ConfigValidator s...
1
14,371
@runcom says there is no need to use `selinux` here. `selinux` "github.com/opencontainers/selinux/go-selinux" The code should work fine without it.
opencontainers-runc
go
@@ -20,8 +20,8 @@ CREATE_PROJECT_TABLE = """ `project_number` bigint(20) NOT NULL, `project_id` varchar(255) NOT NULL, `project_name` varchar(255) DEFAULT NULL, - `lifecycle_state` enum('ACTIVE','DELETE_REQUESTED', - 'DELETE_IN_PROGRESS','DELETED') DEFAULT NULL, + `li...
1
# Copyright 2017 Google Inc. # # Licensed under the Apache License, Version 2.0 (the "License"); # you may not use this file except in compliance with the License. # You may obtain a copy of the License at # # http://www.apache.org/licenses/LICENSE-2.0 # # Unless required by applicable law or agreed to in writing, s...
1
25,612
nit: It might be worth defining these elsewhere as a python-type?
forseti-security-forseti-security
py
@@ -151,6 +151,9 @@ public class Constants { * implies save latest 3 versions saved in storage. **/ public static final String AZKABAN_STORAGE_ARTIFACT_MAX_RETENTION = "azkaban.storage.artifact.max.retention"; + + // enable Quartz Scheduler if true. + public static final String ENABLE_QUARTZ= ...
1
/* * Copyright 2017 LinkedIn Corp. * * Licensed under the Apache License, Version 2.0 (the "License"); you may not * use this file except in compliance with the License. You may obtain a copy of * the License at * * http://www.apache.org/licenses/LICENSE-2.0 * * Unless required by applicable law or agreed to i...
1
14,949
prefix it with azkaban. Maybe azkaban.server.schedule.enable_quartz?
azkaban-azkaban
java
@@ -145,6 +145,13 @@ module Bolt end rescue Bolt::Error => e e + rescue Puppet::DataBinding::LookupError => e + if /Undefined variable/.match(e.message) + message = "Interpolations are not supported in lookups outside of an apply block: #{e.message}"...
1
# frozen_string_literal: true require 'bolt/applicator' require 'bolt/executor' require 'bolt/error' require 'bolt/plan_result' require 'bolt/util' require 'etc' module Bolt class PAL BOLTLIB_PATH = File.expand_path('../../bolt-modules', __dir__) MODULES_PATH = File.expand_path('../../modules', __dir__) ...
1
14,216
It'd be nice if we also caught `Unknown variable $trusted / $server_facts / $settings::` here - while I highly doubt anyone is using them (and if they are they're surely misusing them) it'd be crazy-making to have a working plan suddenly start failing with no clue as to why.
puppetlabs-bolt
rb
@@ -967,6 +967,11 @@ type serviceInfo struct { onlyNodeLocalEndpoints bool } +// TopologyKeys is part of ServicePort interface. +func (info *serviceInfo) TopologyKeys() []string { + panic("NOT IMPLEMENTED") +} + // String is part of ServicePort interface. func (info *serviceInfo) String() string { return fmt...
1
// Copyright (c) 2017-2020 Tigera, Inc. All rights reserved. // // Licensed under the Apache License, Version 2.0 (the "License"); // you may not use this file except in compliance with the License. // You may obtain a copy of the License at // // http://www.apache.org/licenses/LICENSE-2.0 // // Unless required by ...
1
17,884
Probably need to understand/implement this one now.
projectcalico-felix
go
@@ -91,8 +91,13 @@ public class JdbcDependencyManager { while (rs.next()) { // Columns are (starting at index 1): file_name, file_sha1, validation_status Dependency d = hashAndFileNameToDep.remove(rs.getString(1) + rs.getString(2)); - FileValidationStatus v = FileValidationStatus.valueOf...
1
/* * Copyright 2019 LinkedIn Corp. * * Licensed under the Apache License, Version 2.0 (the "License"); you may not * use this file except in compliance with the License. You may obtain a copy of * the License at * * http://www.apache.org/licenses/LICENSE-2.0 * * Unless required by applicable law or agreed to i...
1
19,750
It will be better to add contains check for key in hashAndFileNameToDep instead of null check over here. All of these should be inside that contains if case.
azkaban-azkaban
java
@@ -300,8 +300,18 @@ module Beaker new_conf end + # Restarts the named puppet service + # + # @param [Host] host Host the service runs on + # @param [String] service Name of the service to restart + # @param [Fixnum] curl_retries Number of times to retry the rest...
1
require 'timeout' require 'inifile' require 'resolv' module Beaker module DSL module Helpers # Methods that help you interact with your puppet installation, puppet must be installed # for these methods to execute correctly module PuppetHelpers # @!macro [new] common_opts # @p...
1
11,558
perhaps these magic numbers could go into a Defaults module somewhere? 8140 implies the default is for puppet server. i guess that's somewhat reasonable. but if we're trying to decouple beaker from puppet, maybe this should be 80?
voxpupuli-beaker
rb
@@ -7595,6 +7595,13 @@ dr_prepopulate_cache(app_pc *tags, size_t tags_count) return true; } +DR_API +uint64 +dr_stats_get_built_blocks_count() { + return GLOBAL_STAT(num_bbs); +} + + /*************************************************************************** * PERSISTENCE */
1
/* ****************************************************************************** * Copyright (c) 2010-2018 Google, Inc. All rights reserved. * Copyright (c) 2010-2011 Massachusetts Institute of Technology All rights reserved. * Copyright (c) 2002-2010 VMware, Inc. All rights reserved. * ************************...
1
13,120
style violation: { on own line
DynamoRIO-dynamorio
c
@@ -421,6 +421,10 @@ static h2o_http1client_body_cb on_head(h2o_http1client_t *client, const char *er goto AddHeaderDuped; } else if (token == H2O_TOKEN_LINK) { h2o_push_path_in_link_header(req, headers[i].value, headers[i].value_len); + } else if (token == H2O_...
1
/* * Copyright (c) 2014,2015 DeNA Co., Ltd., Kazuho Oku, Masahiro Nagano * * Permission is hereby granted, free of charge, to any person obtaining a copy * of this software and associated documentation files (the "Software"), to * deal in the Software without restriction, including without limitation the * rights...
1
11,673
Could we accept caseless strings (e.g. `off`, `on`, `auto`) instead of numbers to indicate the mode? Of course, we should use an enum internally (as we already do).
h2o-h2o
c
@@ -28,7 +28,8 @@ const Topic = "/fil/msgs" // Abstracts over a store of blockchain state. type chainState interface { GetHead() types.SortedCidSet - GetTipSetAndState(tsKey types.SortedCidSet) (*chain.TipSetAndState, error) + GetTipSet(tsKey types.SortedCidSet) (*types.TipSet, error) + GetTipSetStateRoot(tsKey typ...
1
package msg import ( "context" "sync" "github.com/ipfs/go-cid" hamt "github.com/ipfs/go-hamt-ipld" "github.com/pkg/errors" "github.com/filecoin-project/go-filecoin/abi" "github.com/filecoin-project/go-filecoin/actor" "github.com/filecoin-project/go-filecoin/actor/builtin" "github.com/filecoin-project/go-fil...
1
19,134
The sender doesn't use `GetTipSet`, so please remove it from this interface.
filecoin-project-venus
go
@@ -32,10 +32,10 @@ import org.openqa.selenium.remote.tracing.HttpTracing; import org.openqa.selenium.remote.tracing.Tracer; import java.net.URL; +import java.util.Objects; import java.util.UUID; import java.util.logging.Logger; -import static org.openqa.selenium.net.Urls.fromUri; import static org.openqa.sele...
1
// Licensed to the Software Freedom Conservancy (SFC) under one // or more contributor license agreements. See the NOTICE file // distributed with this work for additional information // regarding copyright ownership. The SFC licenses this file // to you under the Apache License, Version 2.0 (the // "License"); you m...
1
17,752
We can get rid of this import then.
SeleniumHQ-selenium
rb
@@ -92,9 +92,9 @@ public class KubernetesContainerizedImpl implements ContainerizedImpl { public static final String DEFAULT_NSCD_SOCKET_HOST_PATH = "/var/run/nscd/socket"; public static final String HOST_PATH_TYPE = "Socket"; public static final String DEFAULT_NSCD_SOCKET_VOLUME_MOUNT_PATH = "/var/run/nscd/so...
1
/* * Copyright 2020 LinkedIn Corp. * * Licensed under the Apache License, Version 2.0 (the "License"); you may not * use this file except in compliance with the License. You may obtain a copy of * the License at * * http://www.apache.org/licenses/LICENSE-2.0 * * Unless required by applicable law or agreed to i...
1
21,205
These configurations are currently overwritten in the props we provide in our config files. They need to be overridden there as well after you make this change.
azkaban-azkaban
java
@@ -54,7 +54,12 @@ func PopulateMissingParameters(project *string, zone *string, region *string, scratchBucketRegion := "" if *scratchBucketGcsPath == "" { - scratchBucketName, sbr, err := scratchBucketCreator.CreateScratchBucket(file, *project) + fallbackZone := *zone + if fallbackZone == "" && mgce.OnGCE() {...
1
// Copyright 2019 Google Inc. All Rights Reserved. // // Licensed under the Apache License, Version 2.0 (the "License"); // you may not use this file except in compliance with the License. // You may obtain a copy of the License at // // http://www.apache.org/licenses/LICENSE-2.0 // // Unless required by appl...
1
9,066
Why is error ignored here?
GoogleCloudPlatform-compute-image-tools
go
@@ -20,6 +20,8 @@ const ( PartitionFlagGrub PartitionFlag = "grub" // PartitionFlagBiosGrub indicates this is a bios grub boot partition PartitionFlagBiosGrub PartitionFlag = "bios_grub" + // PartitionFlagBiosGrubLegacy indicates this is a bios grub boot partition. Needed to preserve legacy config behavior. + Par...
1
// Copyright (c) Microsoft Corporation. // Licensed under the MIT License. // Parser for the image builder's configuration schemas. package configuration import ( "encoding/json" "fmt" ) // PartitionFlag describes the features of a partition type PartitionFlag string const ( // PartitionFlagESP indicates this i...
1
14,053
>PartitionFlagBiosGrubLegacy PartitionFlag = "bios-grub" [](start = 1, length = 55) I presume this is to fix a breaking change...and it's too late to fix the breaking change (since it already escaped into the world?)
microsoft-CBL-Mariner
go
@@ -159,7 +159,7 @@ public class ScanSummary { removeTimeFilters(filters, Expressions.rewriteNot(scan.filter())); Expression rowFilter = joinFilters(filters); - Iterable<ManifestFile> manifests = table.currentSnapshot().manifests(); + Iterable<ManifestFile> manifests = table.currentSnapshot()....
1
/* * Licensed to the Apache Software Foundation (ASF) under one * or more contributor license agreements. See the NOTICE file * distributed with this work for additional information * regarding copyright ownership. The ASF licenses this file * to you under the Apache License, Version 2.0 (the * "License"); you ...
1
20,257
Is this explicitly ignoring the effect of deleted rows on partition metrics or is it just that you are short circuiting any delete files (as we can't use them anyways)
apache-iceberg
java
@@ -149,6 +149,12 @@ namespace Microsoft.DotNet.Execute private string BuildParametersForCommand(Dictionary<string, string> commandParameters, string toolName) { string commandSetting = string.Empty; + + if (Tools.ContainsKey(toolName)) + { + commandSe...
1
// Licensed to the .NET Foundation under one or more agreements. // The .NET Foundation licenses this file to you under the MIT license. // See the LICENSE file in the project root for more information. using System; using System.IO; using System.Collections.Generic; using System.Text; namespace Microsoft.DotNet.Exe...
1
10,608
I would also check whether or not this "defaultParameters" is null or empty to allow for people to omit it from the config file.
dotnet-buildtools
.cs
@@ -170,5 +170,5 @@ func (event *Event) IsToEdge() bool { // GetContent dumps the content to string func (event *Event) GetContent() string { - return fmt.Sprintf("%v", event.Content) + return fmt.Sprintf("%s", event.Content) }
1
package model import ( // Mapping value of json to struct member _ "encoding/json" "fmt" "strings" "github.com/kubeedge/beehive/pkg/common/log" "github.com/kubeedge/beehive/pkg/core/model" ) // constants for resource types const ( ResNode = "node" ResMember = "membership" ResTwin = "twin" ResAuth = "...
1
10,438
I think event.Content is of type interface{}, so we may need %v here?
kubeedge-kubeedge
go
@@ -17,10 +17,12 @@ # along with Invenio; if not, write to the Free Software Foundation, Inc., # 59 Temple Place, Suite 330, Boston, MA 02111-1307, USA. +"""Legacy BibEdit.""" + import warnings -from invenio.utils.deprecation import RemovedInInvenio22Warning +from invenio.utils.deprecation import RemovedInInveni...
1
# -*- coding: utf-8 -*- # # This file is part of Invenio. # Copyright (C) 2015 CERN. # # Invenio is free software; you can redistribute it and/or # modify it under the terms of the GNU General Public License as # published by the Free Software Foundation; either version 2 of the # License, or (at your option) any later...
1
16,020
Note: `editor` depends on legacy `BibEdit`
inveniosoftware-invenio
py
@@ -39,5 +39,5 @@ class InputDevice(object): def clear_actions(self): self.actions = [] - def create_pause(self, duraton=0): + def create_pause(self, duration=0): pass
1
# Licensed to the Software Freedom Conservancy (SFC) under one # or more contributor license agreements. See the NOTICE file # distributed with this work for additional information # regarding copyright ownership. The SFC licenses this file # to you under the Apache License, Version 2.0 (the # "License"); you may not...
1
14,870
we should probably deprecate (and display a warning) the misspelled keyword arg here rather than removing it... and then add the new one. This changes a public API and will break any code that is currently using the misspelled version.
SeleniumHQ-selenium
rb
@@ -2608,3 +2608,16 @@ class GroupByTest(ReusedSQLTestCase, TestUtils): self.assertRaises( ValueError, lambda: kdf.groupby([("B", "class"), ("A", "name")]).get_group("mammal") ) + + def test_median(self): + kdf = ks.DataFrame( + { + "a": [1.0, 1.0, 1.0,...
1
# # Copyright (C) 2019 Databricks, Inc. # # Licensed under the Apache License, Version 2.0 (the "License"); # you may not use this file except in compliance with the License. # You may obtain a copy of the License at # # http://www.apache.org/licenses/LICENSE-2.0 # # Unless required by applicable law or agreed to i...
1
17,258
I'm wondering if a positive test case is needed here? Then we might compare the result DataFrame with a pre-created Koalas DataFrame.
databricks-koalas
py
@@ -328,9 +328,9 @@ public interface Value<T> extends Iterable<T> { } /** - * Checks, this {@code Value} is empty, i.e. if the underlying value is absent. + * Checks whether this {@code Value} is empty, i.e. if the underlying value is absent. * - * @return false, if no underlying value is ...
1
/* / \____ _ _ ____ ______ / \ ____ __ _______ * / / \/ \ / \/ \ / /\__\/ // \/ \ // /\__\ JΛVΛSLΛNG * _/ / /\ \ \/ / /\ \\__\\ \ // /\ \ /\\/ \ /__\ \ Copyright 2014-2016 Javaslang, http://javaslang.io * /___/\_/ \_/\____/\_/ \_/\__\/__/\__\_/ \_// \__/\_____/ ...
1
8,167
I think it was reversed
vavr-io-vavr
java
@@ -12,14 +12,10 @@ public class ASTJspDirective extends AbstractJspNode { */ private String name; - public ASTJspDirective(int id) { + ASTJspDirective(int id) { super(id); } - public ASTJspDirective(JspParser p, int id) { - super(p, id); - } - /** * @return Re...
1
/** * BSD-style license; for more info see http://pmd.sourceforge.net/license.html */ /* Generated By:JJTree: Do not edit this line. ASTJspDirective.java */ package net.sourceforge.pmd.lang.jsp.ast; public class ASTJspDirective extends AbstractJspNode { /** * Name of the element-tag. Cannot be null. ...
1
17,011
The setter "setName" can be package-private as well
pmd-pmd
java
@@ -30,7 +30,7 @@ void AdamSolver<Dtype>::ComputeUpdateValue(int param_id, Dtype rate) { Blob<Dtype>* val_v = this->history_[param_id + update_history_offset].get(); Blob<Dtype>* val_t = this->temp_[param_id].get(); - const int t = this->iter_ + 1; + const int t = this->iter_ + 1; const Dtype correction =...
1
#include <vector> #include "caffe/sgd_solvers.hpp" namespace caffe { template <typename Dtype> void AdamSolver<Dtype>::AdamPreSolve() { // Add the extra history entries for Adam after those from // SGDSolver::PreSolve const vector<Blob<Dtype>*>& net_params = this->net_->learnable_params(); for (int i = 0; i ...
1
35,899
Not sure if this is intentional or snuck in through find/replace; while this is a correct style fix (and is welcome in another PR), it should not be done here so that the commit maintains a logical changeset.
BVLC-caffe
cpp
@@ -117,4 +117,17 @@ BOOST_AUTO_TEST_CASE(test_exceptions) { BOOST_CHECK_NO_THROW(buf2.write((const uint8_t*)"bar", 3)); } +#ifndef _WIN32 +// We can't allocate 1 GB of memory in 32-bit environments. +BOOST_AUTO_TEST_CASE(test_over_two_gb) { + TMemoryBuffer buf; + std::vector<uint8_t> small_buff(1); + std::vec...
1
/* * Licensed to the Apache Software Foundation (ASF) under one * or more contributor license agreements. See the NOTICE file * distributed with this work for additional information * regarding copyright ownership. The ASF licenses this file * to you under the Apache License, Version 2.0 (the * "License"); you ma...
1
13,392
This makes me wonder if the TBufferTransport should have a size limit that is configurable, with a default of INT32_MAX, and then the test can make a smaller one like 4KB, and write 4KB and then one byte more, instead of using up 2GB of memory.
apache-thrift
c
@@ -255,6 +255,8 @@ public class ApiMethodTransformer { methodViewBuilder.stubName(namer.getStubName(context.getTargetInterface())); methodViewBuilder.settingsGetterName(namer.getSettingsFunctionName(context.getMethod())); methodViewBuilder.callableName(context.getNamer().getCallableName(context.getMetho...
1
/* Copyright 2016 Google Inc * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. * You may obtain a copy of the License at * * http://www.apache.org/licenses/LICENSE-2.0 * * Unless required by applicable law or agreed to in ...
1
18,252
If you use an enum for the streaming type, you wouldn't need to add each boolean as a separate attribute.
googleapis-gapic-generator
java
@@ -98,6 +98,7 @@ from invenio.utils.serializers import serialize_via_marshal, \ deserialize_via_marshal from sqlalchemy.exc import DatabaseError +from MySQLdb import IntegrityError from .engine_utils import get_index_id_from_index_name
1
# -*- coding: utf-8 -*- # # This file is part of Invenio. # Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, # 2010, 2011, 2012, 2013, 2014, 2015 CERN. # # Invenio is free software; you can redistribute it and/or # modify it under the terms of the GNU General Public License as # published by the Free Sof...
1
16,277
can you check if you can use `sqlalchemy.exc.IntegrityError` instead?
inveniosoftware-invenio
py
@@ -144,7 +144,7 @@ void JobManager::scheduleThread() { // @return: true if all task dispatched, else false bool JobManager::runJobInternal(const JobDescription& jobDesc, JbOp op) { - std::lock_guard<std::mutex> lk(muJobFinished_); + std::lock_guard<std::recursive_mutex> lk(muJobFinished_); std::unique_ptr<Job...
1
/* Copyright (c) 2019 vesoft inc. All rights reserved. * * This source code is licensed under Apache 2.0 License. */ #include "meta/processors/job/JobManager.h" #include <folly/synchronization/Baton.h> #include <gtest/gtest.h> #include <thrift/lib/cpp/util/EnumUtils.h> #include <boost/stacktrace.hpp> #include "c...
1
33,190
Why we need to use recursive_mutex here?
vesoft-inc-nebula
cpp
@@ -68,8 +68,7 @@ var _ = framework.CertManagerDescribe("ACME Certificate (HTTP01)", func() { validations := f.Helper().ValidationSetForUnsupportedFeatureSet(unsupportedFeatures) BeforeEach(func() { - acmeIssuer := util.NewCertManagerACMEIssuer(issuerName, f.Config.Addons.ACMEServer.URL, testingACMEEmail, testin...
1
/* Copyright 2020 The cert-manager Authors. Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing...
1
26,104
am I correct these changes are related to: > I have removed a bunch of legacy functions for issuer generation ... if so, I can see why that's a valuable change but this is already a pretty huge PR and these changes to use `gen` here feel quite distant from the goal of this specific PR; they should maybe be in their own...
jetstack-cert-manager
go
@@ -19,8 +19,10 @@ package org.openqa.selenium.grid.graphql; import com.google.common.base.Suppliers; import com.google.common.collect.ImmutableList; + import org.openqa.selenium.grid.data.DistributorStatus; import org.openqa.selenium.grid.distributor.Distributor; +import org.openqa.selenium.grid.sessionmap.Sessi...
1
// Licensed to the Software Freedom Conservancy (SFC) under one // or more contributor license agreements. See the NOTICE file // distributed with this work for additional information // regarding copyright ownership. The SFC licenses this file // to you under the Apache License, Version 2.0 (the // "License"); you m...
1
17,778
I think that this is an unused import
SeleniumHQ-selenium
java
@@ -328,7 +328,7 @@ public class DdiExportUtil { private static void writeVersionStatement(XMLStreamWriter xmlw, DatasetVersionDTO datasetVersionDTO) throws XMLStreamException{ xmlw.writeStartElement("verStmt"); - writeAttribute(xmlw,"source","DVN"); + writeAttribute(xmlw,"source","pr...
1
package edu.harvard.iq.dataverse.export.ddi; import com.google.gson.Gson; import edu.harvard.iq.dataverse.DataFile; import edu.harvard.iq.dataverse.DataTable; import edu.harvard.iq.dataverse.DatasetFieldConstant; import edu.harvard.iq.dataverse.DatasetVersion; import edu.harvard.iq.dataverse.FileMetadata; import edu.h...
1
42,521
The string "DVN_3_0" appears in `if (!SOURCE_DVN_3_0.equals(xmlr.getAttributeValue(null, "source"))) {` in ImportDDIServiceBean. It's not an exact match so I don't *think* this will break dataset import from DDI but I thought I'd at least mention it.
IQSS-dataverse
java
@@ -361,6 +361,15 @@ func (s *svc) CompareCommits(ctx context.Context, ref *RemoteRef, compareSHA str }, nil } +func (s *svc) ListCommitsViaComparison(ctx context.Context, ref *RemoteRef, compareSHA string) ([]*githubv3.RepositoryCommit, error) { + comp, _, err := s.rest.Repositories.CompareCommits(ctx, ref.RepoOw...
1
package github // <!-- START clutchdoc --> // description: GitHub client that combines the REST/GraphQL APIs and raw git capabilities into a single interface. // <!-- END clutchdoc --> import ( "context" "errors" "fmt" "io" "io/ioutil" "strings" "time" "github.com/go-git/go-billy/v5/memfs" "github.com/go-gi...
1
11,548
Can you add docstring to this? Also, this might be a nit but I think `CompareCommits` or `CommitRange` might be a better name. What do you think?
lyft-clutch
go
@@ -33,6 +33,11 @@ import ( func (current *PullSubscription) Validate(ctx context.Context) *apis.FieldError { errs := current.Spec.Validate(ctx).ViaField("spec") + + if apis.IsInUpdate(ctx) { + original := apis.GetBaseline(ctx).(*PullSubscription) + errs = errs.Also(current.CheckImmutableFields(ctx, original)) +...
1
/* Copyright 2019 Google LLC Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software dist...
1
16,991
were all these ones missed in the previous PR so you are adding them now? the sources v1 and some of this? Is that right? If so, can you update the PR title
google-knative-gcp
go
@@ -124,7 +124,10 @@ public final class SegmentInfos implements Cloneable, Iterable<SegmentCommitInfo public static final int VERSION_72 = 8; /** The version that recorded softDelCount */ public static final int VERSION_74 = 9; - static final int VERSION_CURRENT = VERSION_74; + /** The version that recorded ...
1
/* * Licensed to the Apache Software Foundation (ASF) under one or more * contributor license agreements. See the NOTICE file distributed with * this work for additional information regarding copyright ownership. * The ASF licenses this file to You under the Apache License, Version 2.0 * (the "License"); you may ...
1
28,816
hmm should this be `VERSION_81` instead?
apache-lucene-solr
java
@@ -50,7 +50,9 @@ const ( pendingDeltasFlushThreshold = 128 // trieRebuildAccountChunkSize defines the number of accounts that would get read at a single chunk // before added to the trie during trie construction - trieRebuildAccountChunkSize = 512 + trieRebuildAccountChunkSize = 16384 + // trieRebuildCommitFrequ...
1
// Copyright (C) 2019-2020 Algorand, Inc. // This file is part of go-algorand // // go-algorand is free software: you can redistribute it and/or modify // it under the terms of the GNU Affero General Public License as // published by the Free Software Foundation, either version 3 of the // License, or (at your option) ...
1
39,817
What is the reason for increasing this?
algorand-go-algorand
go
@@ -153,7 +153,9 @@ module.exports = class Transloadit extends Plugin { // Add Assembly-specific Tus endpoint. const tus = { ...file.tus, - endpoint: status.tus_url + endpoint: status.tus_url, + // Include X-Request-ID headers for better debugging. + addRequestId: true } ...
1
const Translator = require('@uppy/utils/lib/Translator') const hasProperty = require('@uppy/utils/lib/hasProperty') const { Plugin } = require('@uppy/core') const Tus = require('@uppy/tus') const Assembly = require('./Assembly') const Client = require('./Client') const AssemblyOptions = require('./AssemblyOptions') con...
1
13,070
is there any reason we are not adding this to companion as well? There are no CORS concerns there, so adding probably shouldn't be a problem, no? **One question about the requestId;** Are the request Ids unique to each tus-js-client request, or are they unique to an upload instance instead?
transloadit-uppy
js
@@ -76,6 +76,8 @@ public final class CsrfConfigurer<H extends HttpSecurityBuilder<H>> extends Abst private CsrfTokenRepository csrfTokenRepository = new HttpSessionCsrfTokenRepository(); private RequestMatcher requireCsrfProtectionMatcher = CsrfFilter.DEFAULT_CSRF_MATCHER; private List<RequestMatcher> ig...
1
/* * Copyright 2002-2013 the original author or authors. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. * You may obtain a copy of the License at * * http://www.apache.org/licenses/LICENSE-2.0 * * Unless required by ap...
1
8,840
The formatting is a little off here.
spring-projects-spring-security
java
@@ -263,7 +263,7 @@ public class TestCustomFunctions extends LuceneTestCase { PrintWriter pw = new PrintWriter(sw); expected.printStackTrace(pw); pw.flush(); - assertTrue(sw.toString().contains("JavascriptCompiler$CompiledExpression.evaluate(" + source + ")")); + assertTrue(sw.toString(), sw.toStri...
1
/* * Licensed to the Apache Software Foundation (ASF) under one or more * contributor license agreements. See the NOTICE file distributed with * this work for additional information regarding copyright ownership. * The ASF licenses this file to You under the Apache License, Version 2.0 * (the "License"); you may ...
1
36,869
Perhaps we should import assertj for tests. These assertions are so much cleaner with assertj. Don't know whether hamcrest equivalent exist (maybe it does).
apache-lucene-solr
java
@@ -2449,16 +2449,9 @@ void ProtocolGame::sendAddCreature(const Creature* creature, const Position& pos sendMagicEffect(pos, CONST_ME_TELEPORT); } - sendInventoryItem(CONST_SLOT_HEAD, player->getInventoryItem(CONST_SLOT_HEAD)); - sendInventoryItem(CONST_SLOT_NECKLACE, player->getInventoryItem(CONST_SLOT_NECKLACE...
1
/** * The Forgotten Server - a free and open-source MMORPG server emulator * Copyright (C) 2018 Mark Samman <mark.samman@gmail.com> * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by * the Free Software Foundation; eithe...
1
15,801
You should use C++-type casts instead.
otland-forgottenserver
cpp
@@ -865,7 +865,12 @@ func (d *cassandraPersistence) UpdateShard( } func (d *cassandraPersistence) CreateWorkflowExecution( request *p.InternalCreateWorkflowExecutionRequest, -) (*p.CreateWorkflowExecutionResponse, error) { +) (*p.InternalCreateWorkflowExecutionResponse, error) { + for _, req := range request.NewWor...
1
// The MIT License // // Copyright (c) 2020 Temporal Technologies Inc. All rights reserved. // // Copyright (c) 2020 Uber Technologies, Inc. // // Permission is hereby granted, free of charge, to any person obtaining a copy // of this software and associated documentation files (the "Software"), to deal // in the Soft...
1
12,461
Looks like each AppendHistoryNodes is its own transaction - what happens if `len(request.NewWorkflowNewEvents) == 5` but we only succeed in writing 3 of them? Will the system be able to pick up from there later? I'm _guessing_ the answer is related to the `ON CONFLICT` and `INSERT IGNORE` changes below? What does Cassa...
temporalio-temporal
go
@@ -107,7 +107,12 @@ func (s *SVIDStoreService) deleteSVID(ctx context.Context, log logrus.FieldLogge return false } - log = log.WithField(telemetry.SVIDStore, storeName) + log = log.WithFields(logrus.Fields{ + telemetry.SVIDStore: storeName, + telemetry.Entry: entry.EntryId, + telemetry.SPIFFEID: entry....
1
package store import ( "context" "crypto/x509" "errors" "fmt" "time" "github.com/andres-erbsen/clock" "github.com/sirupsen/logrus" "github.com/spiffe/go-spiffe/v2/spiffeid" "github.com/spiffe/spire/pkg/agent/catalog" "github.com/spiffe/spire/pkg/agent/manager/storecache" "github.com/spiffe/spire/pkg/agent/...
1
18,145
why are you replacing log here? it is defined above and contains EntryID and SPIFFEID
spiffe-spire
go
@@ -34,11 +34,17 @@ type Command struct { vpnServerFactory func(sessionManager session.Manager, serviceLocation dto_discovery.Location, providerID identity.Identity, callback state.Callback) *openvpn.Server - vpnServer *openvpn.Server + vpnServer *openvpn.Server + openvpnBinaryCheck func() error } /...
1
package server import ( "errors" log "github.com/cihub/seelog" "github.com/mysterium/node/communication" "github.com/mysterium/node/identity" "github.com/mysterium/node/ip" "github.com/mysterium/node/location" "github.com/mysterium/node/nat" "github.com/mysterium/node/openvpn" "github.com/mysterium/node/openv...
1
10,635
Why not `checkOpenvpn` as in client command?
mysteriumnetwork-node
go
@@ -1,6 +1,11 @@ /*global mocha, console */ (function() { 'use strict'; + + if (!mocha || !mocha.reporter || !mocha.reporter('base')) { + return; + } + var Base = mocha.reporter('base')._reporter; mocha.reporter(function(runner) { Base.call(this, runner);
1
/*global mocha, console */ (function() { 'use strict'; var Base = mocha.reporter('base')._reporter; mocha.reporter(function(runner) { Base.call(this, runner); var passes = 0; var failures = 0; runner.on('pass', function(test) { passes++; console.log('pass: %s', test.fullTitle()); }); runner.on('f...
1
15,220
> Note: Non-headless tests (that run on selenium-webdriver) need to wire up to mocha reporter to collect all the results and report them. (See `test-webdriver.js`). But for other tests this can be skipped.
dequelabs-axe-core
js
@@ -241,8 +241,8 @@ class Pathoc(tcp.TCPClient): def http_connect(self, connect_to): self.wfile.write( - 'CONNECT %s:%s HTTP/1.1\r\n' % tuple(connect_to) + - '\r\n' + b'CONNECT %s:%d HTTP/1.1\r\n' % (connect_to[0].encode(), connect_to[1]) + + b'\r\n' ...
1
from __future__ import print_function import contextlib import sys import os import itertools import hashlib from six.moves import queue import random import select import time import OpenSSL.crypto import six from netlib import tcp, certutils, websockets, socks from netlib import exceptions from netlib.http import h...
1
11,700
I think we should apply IDNA encoding for the host here.
mitmproxy-mitmproxy
py
@@ -10127,8 +10127,10 @@ void Client::Handle_OP_PetCommands(const EQApplicationPacket *app) mypet->SayString(this, Chat::PetResponse, PET_GETLOST_STRING); mypet->CastToNPC()->Depop(); + this->Save(1); //Oddly, the client (Titanium) will still allow "/pet get lost" command despite me adding the code below....
1
/* EQEMu: Everquest Server Emulator Copyright (C) 2001-2016 EQEMu Development Team (http://eqemulator.net) This program is free software; you can redistribute it and/or modify it under the terms of the GNU General Public License as published by the Free Software Foundation; version 2 of the License. This program is di...
1
9,924
No need to use `this->` here
EQEmu-Server
cpp
@@ -151,6 +151,7 @@ func (r *ReconcileClusterDeployment) reconcileExistingInstallingClusterInstall(c statusModified = true } + completed = controllerutils.FindClusterDeploymentCondition(conditions, hivev1.ClusterInstallCompletedClusterDeploymentCondition) if completed.Status == corev1.ConditionTrue { // the cl...
1
package clusterdeployment import ( "context" "reflect" "time" log "github.com/sirupsen/logrus" corev1 "k8s.io/api/core/v1" apierrors "k8s.io/apimachinery/pkg/api/errors" "k8s.io/apimachinery/pkg/apis/meta/v1/unstructured" "k8s.io/apimachinery/pkg/runtime/schema" "k8s.io/apimachinery/pkg/types" "sigs.k8s.io...
1
17,943
I can't quite tell, is there a reason why we're finding this condition again when it was done a few lines above? Or was this a mistaken paste?
openshift-hive
go
@@ -22,7 +22,7 @@ // OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN // THE SOFTWARE. -//go:generate mockgen -copyright_file ../../LICENSE -package $GOPACKAGE -source $GOFILE -destination namespaceCache_mock.go +//go:generate mockgen -copyright_file ../../LICENSE -package $GOPACKAGE -sourc...
1
// The MIT License // // Copyright (c) 2020 Temporal Technologies Inc. All rights reserved. // // Copyright (c) 2020 Uber Technologies, Inc. // // Permission is hereby granted, free of charge, to any person obtaining a copy // of this software and associated documentation files (the "Software"), to deal // in the Soft...
1
12,542
doh. My fault, sorry.
temporalio-temporal
go
@@ -80,3 +80,11 @@ func conditionIsProvider1(provider market.ServiceProposal) bool { func conditionIsStreaming(provider market.ServiceProposal) bool { return provider.ServiceType == "streaming" } + +func fieldID(proposal market.ServiceProposal) interface{} { + return proposal.ID +} + +func fieldProviderID(proposal ...
1
/* * Copyright (C) 2019 The "MysteriumNetwork/node" Authors. * * This program is free software: you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by * the Free Software Foundation, either version 3 of the License, or * (at your option) any later version. * ...
1
14,593
Why do we returning `interface{}` here? Don't we have a predefined type for `ID`?
mysteriumnetwork-node
go
@@ -34,9 +34,12 @@ import MiniChart from 'GoogleComponents/mini-chart'; */ import { trafficSourcesReportDataDefaults } from '../util'; -const { __, sprintf } = wp.i18n; -const { map } = lodash; -const { Component, Fragment } = wp.element; +/** + * WordPress dependencies + */ +import { __, sprintf } from '@wordpres...
1
/** * AnalyticsDashboardWidgetTopAcquisitionSources component. * * Site Kit by Google, Copyright 2019 Google LLC * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. * You may obtain a copy of the License at * * https://www.a...
1
24,749
`lodash` shouldn't be grouped under WordPress dependencies
google-site-kit-wp
js
@@ -8,6 +8,8 @@ import ( "context" "flag" "fmt" + "github.com/rclone/rclone/fs/config/provider/goconfig" + "github.com/rclone/rclone/fs/config/provider/viper" "io" "io/ioutil" "log"
1
// Package fstest provides utilities for testing the Fs package fstest // FIXME put name of test FS in Fs structure import ( "bytes" "context" "flag" "fmt" "io" "io/ioutil" "log" "math/rand" "os" "path" "path/filepath" "regexp" "runtime" "sort" "strings" "testing" "time" "github.com/rclone/rclone/f...
1
9,513
File is not `goimports`-ed (from `goimports`)
rclone-rclone
go
@@ -96,6 +96,11 @@ class InteropServiceHelper { } static async defaultFilename(noteIds, fileExtension) { + // Use of == here is because noteIds is potentiall undefined + if (noteIds == null) { + return ''; + } + const note = await Note.load(noteIds[0]); // In a rare case the passed not will be null, us...
1
const { _ } = require('lib/locale'); const { bridge } = require('electron').remote.require('./bridge'); const InteropService = require('lib/services/InteropService'); const Setting = require('lib/models/Setting'); const Note = require('lib/models/Note.js'); const Folder = require('lib/models/Folder.js'); const { friend...
1
14,126
Not sure why you want to make the distinction between null and undefined? And also `null == undefined` anyway so I think you could simply have `!noteIds` here.
laurent22-joplin
js
@@ -21,6 +21,15 @@ package http const ( + // ApplicationHeaderPrefix is the prefix added to application headers over + // the wire. + ApplicationHeaderPrefix = "Rpc-Header-" + + // ContextHeaderPrefix is the prefix added to context headers over the wire. + ContextHeaderPrefix = "Context-" + + // TODO(abg): Allow cu...
1
// Copyright (c) 2016 Uber Technologies, Inc. // // Permission is hereby granted, free of charge, to any person obtaining a copy // of this software and associated documentation files (the "Software"), to deal // in the Software without restriction, including without limitation the rights // to use, copy, modify, merge...
1
9,871
Almost makes me wonder if this should default to Rpc-Context so everything defaults under Rpc-
yarpc-yarpc-go
go
@@ -26,7 +26,7 @@ import ( "github.com/iotexproject/iotex-core/action" "github.com/iotexproject/iotex-core/action/protocol" "github.com/iotexproject/iotex-core/action/protocol/account" - accountutil "github.com/iotexproject/iotex-core/action/protocol/account/util" + "github.com/iotexproject/iotex-core/action/prot...
1
// Copyright (c) 2018 IoTeX // This is an alpha (internal) release and is not suitable for production. This source code is provided 'as is' and no // warranties are given as to title or non-infringement, merchantability or fitness for purpose and, to the extent // permitted by law, all liability for your use of the cod...
1
17,677
File is not `goimports`-ed (from `goimports`)
iotexproject-iotex-core
go
@@ -317,8 +317,16 @@ func (mset *Stream) AddConsumer(config *ConsumerConfig) (*Consumer, error) { } } - // Check for any limits. - if mset.config.MaxConsumers > 0 && len(mset.consumers) >= mset.config.MaxConsumers { + // Check for any limits, if the config for the consumer sets a limit we check against that + //...
1
// Copyright 2019-2020 The NATS Authors // Licensed under the Apache License, Version 2.0 (the "License"); // you may not use this file except in compliance with the License. // You may obtain a copy of the License at // // http://www.apache.org/licenses/LICENSE-2.0 // // Unless required by applicable law or agreed to ...
1
11,114
would these require any account lock here?
nats-io-nats-server
go
@@ -142,7 +142,7 @@ class RemoteConnection(object): :Returns: Timeout value in seconds for all http requests made to the Remote Connection """ - return None if cls._timeout == socket._GLOBAL_DEFAULT_TIMEOUT or cls._timeout + return None if cls._timeout == socket._GLOBAL_DEFAULT_...
1
# Licensed to the Software Freedom Conservancy (SFC) under one # or more contributor license agreements. See the NOTICE file # distributed with this work for additional information # regarding copyright ownership. The SFC licenses this file # to you under the Apache License, Version 2.0 (the # "License"); you may not...
1
12,281
The else doesn't return anything?
SeleniumHQ-selenium
js
@@ -112,6 +112,7 @@ function TransactionBuilder(opts) { if (opts.fee || opts.feeSat) { this.givenFeeSat = opts.fee ? opts.fee * util.COIN : opts.feeSat; } + if (opts.fee == 0 || opts.feeSat == 0) this.givenFeeSat = 0; this.remainderOut = opts.remainderOut; this.signhash = opts.signhash || Transaction....
1
// TransactionBuilder // ================== // // Creates a bitcore Transaction object // // // Synopsis // -------- // ``` // var tx = (new TransactionBuilder(opts)) // .setUnspent(utxos) // .setOutputs(outs) // .sign(keys) // .build(); // // // var builder = (new TransactionBuilder(opt...
1
12,993
if (typeof (opts.fee) !== 'undefined' || typeof (opts.feeSat) !=='undefined') {
bitpay-bitcore
js
@@ -38,7 +38,13 @@ type Device struct { } func (d *Device) CgroupString() string { - return fmt.Sprintf("%c %s:%s %s", d.Type, deviceNumberString(d.Major), deviceNumberString(d.Minor), d.Permissions) + var p string + if d.Permissions == "" { + p = "rwm" // empty permissions is invalid... causes a write invalid arg...
1
package configs import ( "fmt" "os" ) const ( Wildcard = -1 ) // TODO Windows: This can be factored out in the future type Device struct { // Device type, block, char, etc. Type rune `json:"type"` // Path to the device. Path string `json:"path"` // Major is the device's major number. Major int64 `json:"m...
1
9,683
I not sure we need to change this method's logic. Isn't no perms and invalid config?
opencontainers-runc
go
@@ -23,7 +23,7 @@ const ( protocolName = "hive" protocolVersion = "1.0.0" peersStreamName = "peers" - messageTimeout = 5 * time.Second // maximum allowed time for a message to be read or written. + messageTimeout = 1 * time.Minute // maximum allowed time for a message to be read or written. maxBatchSize ...
1
// Copyright 2020 The Swarm Authors. All rights reserved. // Use of this source code is governed by a BSD-style // license that can be found in the LICENSE file. package hive import ( "context" "fmt" "time" "github.com/ethersphere/bee/pkg/addressbook" "github.com/ethersphere/bee/pkg/hive/pb" "github.com/ethers...
1
9,096
this is an abysmal amount of time. can you explain under which circumstances you should wait for a minute for a message?
ethersphere-bee
go
@@ -342,6 +342,8 @@ func (o *deployJobOpts) runtimeConfig(addonsURL string) (*stack.RuntimeConfig, e AddonsTemplateURL: addonsURL, AdditionalTags: tags.Merge(o.targetApp.Tags, o.resourceTags), ServiceDiscoveryEndpoint: endpoint, + AccountID: o.targetApp.AccountID, + Region: ...
1
// Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved. // SPDX-License-Identifier: Apache-2.0 package cli import ( "errors" "fmt" "os" "strings" "github.com/aws/copilot-cli/internal/pkg/deploy" "github.com/aws/copilot-cli/internal/pkg/describe" "github.com/aws/copilot-cli/internal/pkg/addon" ...
1
18,497
Can we add this code to `job_package.go` and `svc_package.go`?
aws-copilot-cli
go
@@ -273,7 +273,9 @@ func CreatePhysicalNode(id NodeID, spec PhysicalProcedureSpec) *PhysicalPlanNode } } -const NextPlanNodeIDKey = "NextPlanNodeID" +type nodeIDKey string + +const NextPlanNodeIDKey nodeIDKey = "NextPlanNodeID" func CreateUniquePhysicalNode(ctx context.Context, prefix string, spec PhysicalProce...
1
package plan import ( "context" "fmt" "math" "github.com/influxdata/flux/interpreter" ) // PhysicalPlanner performs transforms a logical plan to a physical plan, // by applying any registered physical rules. type PhysicalPlanner interface { Plan(ctx context.Context, lplan *Spec) (*Spec, error) } // NewPhysical...
1
16,192
While you're here, can you change the casing on this so it is unexported? `nextPlanNodeIDKey` instead.
influxdata-flux
go
@@ -1,4 +1,5 @@ -// +build proto +// +build !bootstrap + // Contains functions related to dispatching work to remote processes. // Right now those processes must be on the same box because they use // the local temporary directories, but in the future this might form
1
// +build proto // Contains functions related to dispatching work to remote processes. // Right now those processes must be on the same box because they use // the local temporary directories, but in the future this might form // a foundation for doing real distributed work. package build import ( "encoding/binary" ...
1
8,117
thanks for tidying all these up, as you can tell they've been used pretty arbitrarily in the past to just exclude things from bootstrap...
thought-machine-please
go
@@ -204,7 +204,7 @@ class Renderer(Exporter): if (((len(plot) == 1 and not plot.dynamic) or (len(plot) > 1 and self.holomap is None) or (plot.dynamic and len(plot.keys[0]) == 0)) or - not unbound_dimensions(plot.streams, plot.dimensions)): + n...
1
""" Public API for all plotting renderers supported by HoloViews, regardless of plotting package or backend. """ from __future__ import unicode_literals from io import BytesIO import os, base64 from contextlib import contextmanager import param from ..core.io import Exporter from ..core.options import Store, StoreOpt...
1
15,764
Again, `no_duplicates=False` would be clearer here...
holoviz-holoviews
py
@@ -36,7 +36,7 @@ import ( // function will terminate current and further iterations without errors, and also close the returned channel. // Make sure that you check the second returned parameter from the channel to stop iteration when its value // is false. -func (db *DB) SubscribePull(ctx context.Context, bin uint...
1
// Copyright 2019 The go-ethereum Authors // This file is part of the go-ethereum library. // // The go-ethereum library is free software: you can redistribute it and/or modify // it under the terms of the GNU Lesser General Public License as published by // the Free Software Foundation, either version 3 of the License...
1
10,069
shouldnt we stop these routines BEFORE the db closed?
ethersphere-bee
go
@@ -25,6 +25,7 @@ import com.google.common.collect.HashMultimap; import com.google.common.collect.ImmutableMap; import com.google.common.collect.Multimap; +import org.openqa.selenium.devtools.target.model.SessionId; import org.openqa.selenium.json.Json; import org.openqa.selenium.json.JsonInput; import org.openq...
1
// Licensed to the Software Freedom Conservancy (SFC) under one // or more contributor license agreements. See the NOTICE file // distributed with this work for additional information // regarding copyright ownership. The SFC licenses this file // to you under the Apache License, Version 2.0 (the // "License"); you m...
1
16,697
It fills me with endless sadness that we can't use Selenium's own `SessionId` here.
SeleniumHQ-selenium
py
@@ -88,7 +88,7 @@ public class Docker { findImage(new ImageNamePredicate(name, tag)); - LOG.info(String.format("Pulling %s:%s", name, tag)); + LOG.finest(String.format("Pulling %s:%s", name, tag)); HttpRequest request = new HttpRequest(POST, "/images/create"); request.addQueryParameter("fromI...
1
// Licensed to the Software Freedom Conservancy (SFC) under one // or more contributor license agreements. See the NOTICE file // distributed with this work for additional information // regarding copyright ownership. The SFC licenses this file // to you under the Apache License, Version 2.0 (the // "License"); you m...
1
16,460
This will always need to be displayed to users.
SeleniumHQ-selenium
rb
@@ -1,6 +1,8 @@ class CartDecorator < Draper::Decorator delegate_all + CUSTOM_TEMPLATES = %w(navigator whsc) + def total_price price = object.cart_items.reduce(0) do |sum,citem| sum + citem.quantity * citem.price end Float("%0.02f" % price)
1
class CartDecorator < Draper::Decorator delegate_all def total_price price = object.cart_items.reduce(0) do |sum,citem| sum + citem.quantity * citem.price end Float("%0.02f" % price) end def number_approved object.approved_approvals.count end def total_approvers object.approver_approvals....
1
12,231
Maybe we make an `ORIGINS` constant on the Cart model instead?
18F-C2
rb
@@ -115,7 +115,7 @@ const ( // a) Add 'authorizationConfig', 'transitEncryption' and 'transitEncryptionPort' to 'taskresource.volume.EFSVolumeConfig' // b) Add 'pauseContainerPID' field to 'taskresource.volume.VolumeResource' // 28) Add 'envfile' field to 'resources' - // 29) Add 'ExecCommandAgentMetadata' fiel...
1
// Copyright Amazon.com Inc. or its affiliates. All Rights Reserved. // // Licensed under the Apache License, Version 2.0 (the "License"). You may // not use this file except in compliance with the License. A copy of the // License is located at // // http://aws.amazon.com/apache2.0/ // // or in the "license" file acco...
1
25,492
looks like this is not needed anymore with boltdb migration. lets confirm with @fenxiong
aws-amazon-ecs-agent
go
@@ -409,7 +409,7 @@ func TestRollDPoSConsensus(t *testing.T) { require.NoError(t, err) require.NoError(t, sf.Start(ctx)) for j := 0; j < numNodes; j++ { - ws, err := sf.NewWorkingSet() + ws, err := sf.NewWorkingSet(false) require.NoError(t, err) _, err = accountutil.LoadOrCreateAccount(ws, c...
1
// Copyright (c) 2019 IoTeX Foundation // This is an alpha (internal) release and is not suitable for production. This source code is provided 'as is' and no // warranties are given as to title or non-infringement, merchantability or fitness for purpose and, to the extent // permitted by law, all liability for your use...
1
19,583
shadow: declaration of "err" shadows declaration at line 408 (from `govet`)
iotexproject-iotex-core
go
@@ -380,7 +380,7 @@ public class Actions { // Of course, this is the offset from the centre of the element. We have no idea what the width // and height are once we execute this method. - LOG.info("When using the W3C Action commands, offsets are from the center of element"); + LOG.finest("When using t...
1
// Licensed to the Software Freedom Conservancy (SFC) under one // or more contributor license agreements. See the NOTICE file // distributed with this work for additional information // regarding copyright ownership. The SFC licenses this file // to you under the Apache License, Version 2.0 (the // "License"); you m...
1
16,442
Again, the existing level is correct --- we're letting users know about something that might cause there tests to fail.
SeleniumHQ-selenium
rb
@@ -34,7 +34,7 @@ type ProfileDecoder struct { } func NewProfileDecoder(callbacks passthruCallbacks) *ProfileDecoder { - return &ProfileDecoder{callbacks: callbacks, converter: conversion.Converter{}} + return &ProfileDecoder{callbacks: callbacks, converter: conversion.NewConverter()} } func (p *ProfileDecoder)...
1
// Copyright (c) 2018 Tigera, Inc. All rights reserved. // // Licensed under the Apache License, Version 2.0 (the "License"); // you may not use this file except in compliance with the License. // You may obtain a copy of the License at // // http://www.apache.org/licenses/LICENSE-2.0 // // Unless required by appli...
1
17,619
Required by the libcalico-go changes
projectcalico-felix
c
@@ -438,10 +438,12 @@ void write_variables_gnuplot(struct histogram *h, struct histogram *all) FILE *f = open_file(fname); free(fname); + fprintf(f, "%s = %" PRId64"\n", "current_buckets", h->nbuckets); fprintf(f, "%s = %lf\n", "current_minimum", h->min_value); fprintf(f, "%s = %lf\n", ...
1
/* Copyright (C) 2015- The University of Notre Dame This software is distributed under the GNU General Public License. See the file COPYING for details. */ #include <float.h> #include <omp.h> #include "rmon_tools.h" #include "create_dir.h" #include "category.h" #include "macros.h" #include "copy_stream.h" #define MA...
1
12,694
You want "current_min_count"
cooperative-computing-lab-cctools
c
@@ -85,14 +85,10 @@ public class MediaStoreProvider { MediaStore.Files.FileColumns.PARENT, MediaStore.Images.Media.BUCKET_DISPLAY_NAME }; - String selection, selectionArgs[]; - - selection = - MediaStore.Files.FileColumns.MEDIA_TYPE - + "=? ) GROUP BY ( " - + Med...
1
package org.fossasia.phimpme.gallery.data.providers; import android.content.Context; import android.database.Cursor; import android.net.Uri; import android.provider.MediaStore; import androidx.annotation.Nullable; import java.io.File; import java.util.ArrayList; import java.util.HashSet; import org.fossasia.phimpme.ga...
1
13,744
Why changes in this file?
fossasia-phimpme-android
java
@@ -26,6 +26,7 @@ public final class CommentPatterns { Pattern.compile("\\[([^\\]]+)\\]\\((\\p{Alpha}+:[^\\)]+)\\)"); public static final Pattern CLOUD_LINK_PATTERN = Pattern.compile("\\[([^\\]]+)\\]\\(((?!\\p{Alpha}+:)[^\\)]+)\\)"); - public static final Pattern PROTO_LINK_PATTERN = Pattern.compile("...
1
/* Copyright 2016 Google Inc * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. * You may obtain a copy of the License at * * http://www.apache.org/licenses/LICENSE-2.0 * * Unless required by applicable law or agreed to in ...
1
19,430
This doesn't look right. I think what you want here is `\\[([^\\]]+)\\]\\[[A-Za-z_][A-Za-z_.0-9]*]*\\]`.
googleapis-gapic-generator
java