patch
stringlengths
17
31.2k
y
int64
1
1
oldf
stringlengths
0
2.21M
idx
int64
1
1
id
int64
4.29k
68.4k
msg
stringlengths
8
843
proj
stringclasses
212 values
lang
stringclasses
9 values
@@ -16,7 +16,7 @@ module Faker return result end - raise RetryLimitExceeded + raise RetryLimitExceeded, "Retry limit exceeded for #{name}" end RetryLimitExceeded = Class.new(StandardError)
1
module Faker class UniqueGenerator def initialize(generator, max_retries) @generator = generator @max_retries = max_retries @previous_results = Hash.new { |hash, key| hash[key] = Set.new } end def method_missing(name, *arguments) @max_retries.times do result = @generator.p...
1
8,486
@AndrewRayCode thanks for contributing Could you write/modify the specs to make sure that this description is working properly?
faker-ruby-faker
rb
@@ -120,7 +120,8 @@ def default_bucket(request): try: response = request.invoke_subrequest(subrequest) except httpexceptions.HTTPException as error: - if error.content_type == 'application/json': + is_redirect = error.status_code < 400 + if error.content_type == 'application/json...
1
import uuid import six from pyramid import httpexceptions from pyramid.settings import asbool from pyramid.security import NO_PERMISSION_REQUIRED from cliquet.errors import raise_invalid from cliquet.utils import build_request, reapply_cors, hmac_digest from cliquet.storage import exceptions as storage_exceptions fr...
1
8,643
I would have tested 304 only there.
Kinto-kinto
py
@@ -36,16 +36,15 @@ namespace Microsoft.AspNetCore.Server.Kestrel.FunctionalTests { // Close socket immediately } - } - await loggerFactory.FilterLogger.LogTcs.Task; + await loggerFactory.FilterLogger.LogTcs.Task.TimeoutAfter(...
1
// Copyright (c) .NET Foundation. All rights reserved. // Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information. using System; using System.Net.Sockets; using System.Threading.Tasks; using Microsoft.AspNetCore.Hosting; using Microsoft.AspNetCore.Server.Kestrel.Htt...
1
9,876
`TimeoutAfter` to be safe.
aspnet-KestrelHttpServer
.cs
@@ -244,8 +244,14 @@ init_build_bb(build_bb_t *bb, app_pc start_pc, bool app_interp, bool for_cache, * whose fall-through hits our hook. We avoid interpreting our own hook * by shifting it to the displaced pc. */ - if (DYNAMO_OPTION(hook_vsyscall) && start_pc == vsyscall_sysenter_return_pc) - ...
1
/* ********************************************************** * Copyright (c) 2011-2021 Google, Inc. All rights reserved. * Copyright (c) 2001-2010 VMware, Inc. All rights reserved. * **********************************************************/ /* * Redistribution and use in source and binary forms, with or witho...
1
24,692
So the 32-bit tests on the new kernel hit this case? Won't they fail in debug build?
DynamoRIO-dynamorio
c
@@ -46,7 +46,9 @@ public class HTMLTestResults { private final HTMLSuiteResult suite; private static final String HEADER = "<html>\n" + - "<head><style type='text/css'>\n" + + "<head>\n"+ + "<meta charset=\"UTF-8\">\n"+ + "<style type='text/css'>\n" + "body, table {\n" + " f...
1
// Licensed to the Software Freedom Conservancy (SFC) under one // or more contributor license agreements. See the NOTICE file // distributed with this work for additional information // regarding copyright ownership. The SFC licenses this file // to you under the Apache License, Version 2.0 (the // "License"); you m...
1
13,139
Is there a recommended quote style for attributes? I see single and double here, double further down.
SeleniumHQ-selenium
rb
@@ -5,12 +5,14 @@ module RSpec::Core # with information about a particular event of interest. module Notifications - # The `CountNotification` represents notifications sent by the formatter - # which a single numerical count attribute. Currently used to notify - # formatters of the expected number of e...
1
RSpec::Support.require_rspec_core "formatters/helpers" module RSpec::Core # Notifications are value objects passed to formatters to provide them # with information about a particular event of interest. module Notifications # The `CountNotification` represents notifications sent by the formatter # which ...
1
12,286
The description of `load_time` here is different from the description below..is that intentional?
rspec-rspec-core
rb
@@ -1547,6 +1547,10 @@ import 'programStyles'; return '<span class="cardImageIcon material-icons book"></span>'; case 'Folder': return '<span class="cardImageIcon material-icons folder"></span>'; + case 'BoxSet': + return '<spa...
1
/* eslint-disable indent */ /** * Module for building cards from item data. * @module components/cardBuilder/cardBuilder */ import datetime from 'datetime'; import imageLoader from 'imageLoader'; import connectionManager from 'connectionManager'; import itemHelper from 'itemHelper'; import focusManager from 'focus...
1
16,396
Actually it could also be a video playlist. But music is used more often.
jellyfin-jellyfin-web
js
@@ -36,6 +36,11 @@ function writeCommand(server, type, opsField, ns, ops, options, callback) { writeCommand.bypassDocumentValidation = options.bypassDocumentValidation; } + if (writeConcern.w === 0) { + // don't include session for unacknowledged writes + delete options.session; + } + const command...
1
'use strict'; const MongoError = require('../error').MongoError; const collectionNamespace = require('./shared').collectionNamespace; const command = require('./command'); function writeCommand(server, type, opsField, ns, ops, options, callback) { if (ops.length === 0) throw new MongoError(`${type} must contain at ...
1
18,051
From the ticket: > I understand why a session ID would be silently omitted for implicit sessions, but what is the reasoning behind omitting it for explicit sessions instead of raising a logic error to the user? So what this change is doing is "silently omitting" the session if its an unacknowledged write. I think we wa...
mongodb-node-mongodb-native
js
@@ -85,6 +85,17 @@ namespace pwiz.Skyline.Model.Databinding.Entities [Format(NullValue = TextUtil.EXCEL_NA)] public int? PointsAcrossPeak { get { return ChromInfo.PointsAcrossPeak; } } + [Format(Formats.RETENTION_TIME, NullValue = TextUtil.EXCEL_NA)] + public double? AverageCycleTime +...
1
/* * Original author: Nicholas Shulman <nicksh .at. u.washington.edu>, * MacCoss Lab, Department of Genome Sciences, UW * * Copyright 2012 University of Washington - Seattle, WA * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in comp...
1
13,930
You can simplify this by doing: return (EndTime - StartTime) * 60 / PointsAcrossPeak;
ProteoWizard-pwiz
.cs
@@ -56,7 +56,7 @@ ColorPickerWidget::ColorPickerWidget(QWidget *parent): QFrame(parent) { QFontMetrics fm (mLineEdit.font()); - mLineEdit.setFixedWidth ( 10*fm.width (QStringLiteral("a")) ); + mLineEdit.setFixedWidth ( 10*fm.horizontalAdvance (QStringLiteral("a")) ); QHBoxLayout *layout = new QH...
1
/* BEGIN_COMMON_COPYRIGHT_HEADER * (c)LGPL2+ * * LXQt - a lightweight, Qt based, desktop toolset * https://lxqt.org * * Copyright: 2012 Razor team * Authors: * Aaron Lewis <the.warl0ck.1989@gmail.com> * * This program or library is free software; you can redistribute it * and/or modify it under the terms o...
1
6,669
I think it's the time for bumping `REQUIRED_QT_VERSION` to the last LTS, 5.12. `QFontMetrics::horizontalAdvance()` doesn't exist in 5.10.
lxqt-lxqt-panel
cpp
@@ -21,7 +21,8 @@ module Bolt statement_count: :cd6, resource_mean: :cd7, plan_steps: :cd8, - return_type: :cd9 + return_type: :cd9, + boltdir_type: :cd11 }.freeze def self.build_client
1
# frozen_string_literal: true require 'bolt/util' require 'bolt/version' require 'json' require 'logging' require 'securerandom' module Bolt module Analytics PROTOCOL_VERSION = 1 APPLICATION_NAME = 'bolt' TRACKING_ID = 'UA-120367942-1' TRACKING_URL = 'https://google-analytics.com/collect' CUSTOM...
1
12,013
I already set up cd10 for "inventory_version in google analytics. I've added cd11 for Boltdir Type now
puppetlabs-bolt
rb
@@ -45,6 +45,10 @@ module Travis module Build class Script TEMPLATES_PATH = File.expand_path('../templates', __FILE__) + INTERNAL_RUBY_REGEX = ENV.fetch( + 'TRAVIS_INTERNAL_RUBY_REGEX', + 'ruby-(2\.[0-2]\.[0-9]|1\.9\.3)' + ).untaint DEFAULTS = {} class << self
1
require 'core_ext/hash/deep_merge' require 'core_ext/hash/deep_symbolize_keys' require 'core_ext/object/false' require 'erb' require 'rbconfig' require 'travis/build/addons' require 'travis/build/appliances' require 'travis/build/git' require 'travis/build/helpers' require 'travis/build/stages' require 'travis/build/...
1
14,454
@henrikhodne We are lazily skipping `jruby-*` here (assuming that JRuby all of a sudden start using these version numbers).
travis-ci-travis-build
rb
@@ -739,8 +739,11 @@ void CPaintStatistics::DrawAxis(wxDC &dc, const double max_val_y, const double m double y_start_val = ceil(min_val_y / d_oy_val) * d_oy_val; d_oy_count = (int)floor((max_val_y - y_start_val) / d_oy_val); + double temp_int_part; + int prec = modf(d_oy_val, &temp_int_part) == 0.0 ? 0 : 2;...
1
// This file is part of BOINC. // http://boinc.berkeley.edu // Copyright (C) 2008 University of California // // BOINC is free software; you can redistribute it and/or modify it // under the terms of the GNU Lesser General Public License // as published by the Free Software Foundation, // either version 3 of the Licens...
1
9,275
How does this cope with values like `5.001`? Shouldn't that set precision to 0? Instead it is set to 2.
BOINC-boinc
php
@@ -40,7 +40,7 @@ class APITestCase(IntegrationTestCase): # This sleep allows for the influx subscriber to take its time in getting # the listen submitted from redis and writing it to influx. # Removing it causes an empty list of listens to be returned. - time.sleep(10) + time.s...
1
from __future__ import absolute_import, print_function import sys import os import uuid sys.path.append(os.path.join(os.path.dirname(os.path.realpath(__file__)), "..", "..")) from tests.integration import IntegrationTestCase from flask import url_for import db.user import time import json TEST_DATA_PATH = os.path.joi...
1
14,196
Rather than having a sleep here, we should check to see if the service we're waiting for is up yet, using something like dockerize. Not critical this second, but would be nice for later.
metabrainz-listenbrainz-server
py
@@ -0,0 +1,18 @@ +import path from 'path'; +import execa from 'execa'; +import { + displayErrorMessage +} from '../../scripts/utils/console.mjs'; + +((async function() { + try { + await execa('npm', ['run', 'swap-package-links'], { + cwd: path.resolve(process.cwd(), '..'), + stdio: 'inherit' + }); + +...
1
1
20,131
I'm not sure if there are any links to swap for Handosntable package. Should this be a top lvl script?
handsontable-handsontable
js
@@ -537,7 +537,16 @@ signal_thread_init(dcontext_t *dcontext, void *os_data) signal_frame_extra_size(true) /* sigpending_t has xstate inside it already */ IF_LINUX(IF_X86(-sizeof(kernel_xstate_t))); - IF_LINUX(IF_X86(ASSERT(!YMM_ENABLED() || ALIGNED(pend_unit_size, AVX_ALIGNMENT)))); +/* A...
1
/* ********************************************************** * Copyright (c) 2011-2019 Google, Inc. All rights reserved. * Copyright (c) 2000-2010 VMware, Inc. All rights reserved. * **********************************************************/ /* * Redistribution and use in source and binary forms, with or witho...
1
17,994
It seems like it's too big now: can we remove signal_frame_extra_size from line 537? That should only be needed when placing xstate separately. It seems like it isn't needed at all for pending? Also, if we have special heap align forward for us, we don't need this align here either.
DynamoRIO-dynamorio
c
@@ -128,9 +128,12 @@ catch # fortunately, using PS with stdin input_method should never happen if input_method == 'powershell' conn.execute(<<-PS) -$private:taskArgs = Get-ContentAsJson ( +$private:tempArgs = Get-ContentAsJson ( $utf8.GetString([System.Convert]::F...
1
# frozen_string_literal: true require 'bolt/transport/base' module Bolt module Transport class WinRM < Base PS_ARGS = %w[ -NoProfile -NonInteractive -NoLogo -ExecutionPolicy Bypass ].freeze def self.options %w[port user password connect-timeout ssl ssl-verify tmpdir cacert ext...
1
8,873
Just double checked the `-in` operator. It's PS3 only, so we might want to change `$_ -in $allowedArgs` to `$allowedArgs -contains $_`
puppetlabs-bolt
rb
@@ -152,6 +152,14 @@ class StartButton(IAccessible): states = super(StartButton, self).states states.discard(controlTypes.STATE_SELECTED) return states + +class UIProperty(UIA): + #Used for columns in Windows Explorer Details view. + #These can contain dates that include unwanted left-to-right and right-to-l...
1
#appModules/explorer.py #A part of NonVisual Desktop Access (NVDA) #Copyright (C) 2006-2015 NV Access Limited, Joseph Lee #This file is covered by the GNU General Public License. #See the file COPYING for more details. from comtypes import COMError import time import appModuleHandler import controlTypes impo...
1
17,642
Might as well use translate here, as @jcsteh suggested
nvaccess-nvda
py
@@ -145,8 +145,9 @@ class DimensionedPlot(Plot): show_title = param.Boolean(default=True, doc=""" Whether to display the plot title.""") - title_format = param.String(default="{label} {group}", doc=""" - The formatting string for the title of this plot.""") + title_format = param.String(def...
1
""" Public API for all plots supported by HoloViews, regardless of plotting package or backend. Every plotting classes must be a subclass of this Plot baseclass. """ from itertools import groupby, product from collections import Counter import numpy as np import param from ..core import OrderedDict from ..core impor...
1
14,261
Definitely an improvement as long as the old tests pass (i.e backwards compatible).
holoviz-holoviews
py
@@ -22,11 +22,11 @@ package com.netflix.iceberg; import com.google.common.collect.Maps; import com.netflix.iceberg.exceptions.RuntimeIOException; import com.netflix.iceberg.io.FileIO; -import java.util.Map; import com.netflix.iceberg.io.LocationProvider; import org.junit.rules.TemporaryFolder; import java.io.IO...
1
/* * Licensed to the Apache Software Foundation (ASF) under one * or more contributor license agreements. See the NOTICE file * distributed with this work for additional information * regarding copyright ownership. The ASF licenses this file * to you under the Apache License, Version 2.0 (the * "License"); you ...
1
12,710
nit: non functional change
apache-iceberg
java
@@ -130,6 +130,17 @@ func main() { }() } + // Fail fast if the AWS credentials are not present. + awsCredentialsPath := os.Getenv("AWS_SHARED_CREDENTIALS_FILE") + if len(awsCredentialsPath) == 0 { + awsCredentialsPath = "/home/.aws/credentials" + } + _, err := os.Stat(awsCredentialsPath) + if err != nil { + se...
1
/* Copyright 2018 The Kubernetes Authors. Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, ...
1
11,720
The file is not required - if you're using an IAM instance profile, for example. I'm not sure we can error 100% of the time if it's missing. @randomvariable any suggestions?
kubernetes-sigs-cluster-api-provider-aws
go
@@ -2527,7 +2527,7 @@ func (c *Compiler) parseExpr(frame *Frame, expr ssa.Value) (llvm.Value, error) { } if expr.High != nil { - highType = expr.High.Type().(*types.Basic) + highType = expr.High.Type().Underlying().(*types.Basic) high, err = c.parseExpr(frame, expr.High) if err != nil { return ...
1
package compiler import ( "errors" "fmt" "go/build" "go/constant" "go/parser" "go/token" "go/types" "os" "path/filepath" "regexp" "runtime" "strconv" "strings" "github.com/aykevl/go-llvm" "github.com/aykevl/tinygo/ir" "golang.org/x/tools/go/loader" "golang.org/x/tools/go/ssa" ) func init() { llvm.I...
1
6,100
There is a very similar line `lowType = expr.Low.Type().(*types.Basic)` a few lines above this line. Can you change that in the same way?
tinygo-org-tinygo
go
@@ -0,0 +1,19 @@ +/* + * Copyright ConsenSys AG. + * + * Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable l...
1
1
26,393
New files should be copyright Hyperledger Besu Contributors.
hyperledger-besu
java
@@ -34,5 +34,18 @@ module Bolt sftp.upload!(source, destination) end end + + def make_tempdir + @session.exec!('mktemp -d').chomp + end + + def run_script(script) + dir = make_tempdir + remote_path = "#{dir}/#{File.basename(script)}" + copy(script, remote_path) + e...
1
require 'net/ssh' require 'net/sftp' module Bolt class SSH < Node def initialize(host, user, port = nil, password = nil) @host = host @user = user @port = port @password = password end def connect options = {} options[:port] = @port if @port options[:password] =...
1
6,373
if I give a non-existent script, then I don't get an errors. I would have expected the `copy` method to raise, but maybe `net-sftp` silently exits?
puppetlabs-bolt
rb
@@ -4343,10 +4343,12 @@ class Series(Frame, IndexOpsMixin, Generic[T]): """ if to_replace is None: return self.fillna(method="ffill") - if not isinstance(to_replace, (str, list, dict, int, float)): - raise ValueError("'to_replace' should be one of str, list, dict, int, f...
1
# # Copyright (C) 2019 Databricks, Inc. # # Licensed under the Apache License, Version 2.0 (the "License"); # you may not use this file except in compliance with the License. # You may obtain a copy of the License at # # http://www.apache.org/licenses/LICENSE-2.0 # # Unless required by applicable law or agreed to i...
1
17,931
@itholic can you also update the parameters in the docs?
databricks-koalas
py
@@ -292,6 +292,11 @@ public final class IntMap<T> implements Traversable<T>, Serializable { public int characteristics() { return spliterator.characteristics(); } + + @Override + public Comparator<? super T> getComparator() { + return null;...
1
/* / \____ _ _ ____ ______ / \ ____ __ _______ * / / \/ \ / \/ \ / /\__\/ // \/ \ // /\__\ JΛVΛSLΛNG * _/ / /\ \ \/ / /\ \\__\\ \ // /\ \ /\\/ \ /__\ \ Copyright 2014-2017 Javaslang, http://javaslang.io * /___/\_/ \_/\____/\_/ \_/\__\/__/\__\_/ \_// \__/\_____/ ...
1
12,074
The super impl Spliterator.getComparator() throws an IllegalStateException by default. Is it really necessary to return null? If null is used somewhere it will throw a NPE, which is roughly the same as throwing an IllegalStateException. I'm just curious - I'm sure there is a reason!
vavr-io-vavr
java
@@ -256,7 +256,7 @@ public class Avro { schema(table.schema()); withSpec(table.spec()); setAll(table.properties()); - metricsConfig(MetricsConfig.fromProperties(table.properties())); + metricsConfig(MetricsConfig.forTable(table)); return this; }
1
/* * Licensed to the Apache Software Foundation (ASF) under one * or more contributor license agreements. See the NOTICE file * distributed with this work for additional information * regarding copyright ownership. The ASF licenses this file * to you under the Apache License, Version 2.0 (the * "License"); you ...
1
33,751
Do we need to do the same in Avro `WriteBuilder` too? I don't think we use that method right now but should make sense for consistency. We already handle that for Parquet.
apache-iceberg
java
@@ -319,6 +319,8 @@ int FlatCompiler::Compile(int argc, const char **argv) { opts.force_defaults = true; } else if (arg == "--force-empty") { opts.set_empty_to_null = false; + } else if (arg == "--java_primitive_has_method") { + opts.java_primitive_has_method = true; } else {...
1
/* * Copyright 2014 Google Inc. All rights reserved. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. * You may obtain a copy of the License at * * http://www.apache.org/licenses/LICENSE-2.0 * * Unless required by applica...
1
16,325
can you make all the `_` into `-` to be consistent with the other options?
google-flatbuffers
java
@@ -0,0 +1,15 @@ +// Copyright 2019 Amazon.com, Inc. or its affiliates. All Rights Reserved. +// SPDX-License-Identifier: Apache-2.0 + +package archer + +import "github.com/aws/aws-sdk-go/service/cloudformation" + +// StackConfiguration represents an entity that can be serialized +// into a Cloudformation template +typ...
1
1
10,705
What do you think of renaming this file to `stack.go` or `cfn_stack.go`? `common.go`/`util.go` don't provide us anything descriptive about the contents of the file.
aws-copilot-cli
go
@@ -19,12 +19,14 @@ using System.Runtime.CompilerServices; #if SIGNED [assembly: InternalsVisibleTo("OpenTelemetry.Exporter.OpenTelemetryProtocol.Tests, PublicKey=002400000480000094000000060200000024000052534131000400000100010051c1562a090fb0c9f391012a32198b5e5d9a60e9b80fa2d7b434c9e5ccb7259bd606e66f9660676afc6692b8cdc...
1
// <copyright file="AssemblyInfo.cs" company="OpenTelemetry Authors"> // Copyright The OpenTelemetry Authors // // Licensed under the Apache License, Version 2.0 (the "License"); // you may not use this file except in compliance with the License. // You may obtain a copy of the License at // // http://www.apache.or...
1
21,202
It isn't a very effective example if it requires access to the internals I can't tell just looking at the diff why this is needed, can you provide a little context?
open-telemetry-opentelemetry-dotnet
.cs
@@ -3,13 +3,16 @@ require 'spec_helper' require 'bolt/transport/local' require 'bolt/target' +require 'bolt/inventory' +require 'bolt_spec/transport' require_relative 'shared_examples' describe Bolt::Transport::Local, bash: true do - let(:runner) { Bolt::Transport::Local.new } + include BoltSpec::Transport +...
1
# frozen_string_literal: true require 'spec_helper' require 'bolt/transport/local' require 'bolt/target' require_relative 'shared_examples' describe Bolt::Transport::Local, bash: true do let(:runner) { Bolt::Transport::Local.new } let(:os_context) { posix_context } let(:transport_conf) { {} } let(:target) { ...
1
10,101
Why does this include `bolt/inventory`?
puppetlabs-bolt
rb
@@ -427,7 +427,7 @@ public final class LinkedHashMap<K, V> implements Kind2<LinkedHashMap<?, ?>, K, Queue<Tuple2<K, V>> newList = list; HashMap<K, V> newMap = map; if (containsKey(key)) { - newList = newList.filter(t -> !t._1.equals(key)); + newList = newList.filter(t ->...
1
/* / \____ _ _ ____ ______ / \ ____ __ _______ * / / \/ \ / \/ \ / /\__\/ // \/ \ // /\__\ JΛVΛSLΛNG * _/ / /\ \ \/ / /\ \\__\\ \ // /\ \ /\\/ \ /__\ \ Copyright 2014-2016 Javaslang, http://javaslang.io * /___/\_/ \_/\____/\_/ \_/\__\/__/\__\_/ \_// \__/\_____/ ...
1
10,351
We called `t._1.equals(...)` where `t._1` potentially could be `null`.
vavr-io-vavr
java
@@ -0,0 +1,14 @@ +/* global forms */ +const rangeRoles = ['progressbar', 'scrollbar', 'slider', 'spinbutton']; + +/** + * Determines if an element is an aria range element + * @method isAriaRange + * @memberof axe.commons.forms + * @param {Element} node Node to determine if aria range + * @returns {Bool} + */ +forms.is...
1
1
14,525
I don't think we should include the `hasAttribute` test here. Even without aria-valuenow, it's still an aria range element. This check is going to make reuse of this function problematic. Better to move the attribute check part outside this function IMO.
dequelabs-axe-core
js
@@ -35,6 +35,7 @@ class ErgonodeFixtureCommand extends Command $this->setName('ergonode:fixture:load'); $this->setDescription('Fill database with data'); $this->addOption('group', 'g', InputOption::VALUE_REQUIRED, 'Group'); + $this->addOption('file', 'f', InputOption::VALUE_REQUIRED, '...
1
<?php /** * Copyright © Ergonode Sp. z o.o. All rights reserved. * See LICENSE.txt for license details. */ declare(strict_types=1); namespace Ergonode\Fixture\Application\Command; use Doctrine\Migrations\Tools\BytesFormatter; use Ergonode\Fixture\Infrastructure\Process\FixtureProcess; use Symfony\Component\Conso...
1
9,527
Shouldn't it be optional?
ergonode-backend
php
@@ -55,6 +55,7 @@ func newClient(cfg aws.Config, handlers request.Handlers, endpoint, signingRegio cfg, metadata.ClientInfo{ ServiceName: ServiceName, + ServiceID: "API Gateway", SigningName: signingName, SigningRegion: signingRegion, Endpoint: endpoint,
1
// Code generated by private/model/cli/gen-api/main.go. DO NOT EDIT. package apigateway import ( "github.com/aws/aws-sdk-go/aws" "github.com/aws/aws-sdk-go/aws/client" "github.com/aws/aws-sdk-go/aws/client/metadata" "github.com/aws/aws-sdk-go/aws/request" "github.com/aws/aws-sdk-go/aws/signer/v4" "github.com/aw...
1
9,205
would be helpful to make these a package level constant so they are accessible to the user. similar to Service Name. Not directly related note, v2 SDK ServiceName should be renamed to ServiceEndpointPrefix.
aws-aws-sdk-go
go
@@ -18,7 +18,7 @@ class Storage public function load(string $path) { - return include $this->realpath($path); + return file_exists($this->realpath($path)) ? include $this->realpath($path) : null; } public function store(string $path, string $content): void
1
<?php class Storage { public function directories(string $path): DirectoryIterator { return new DirectoryIterator( $this->realpath($path) ); } public function getDecodedJson(string $filename) { return file_exists($filename) ? json_decode(file_get_con...
1
7,895
Duplicate call to the method. Better to put in a variable.
Laravel-Lang-lang
php
@@ -1023,8 +1023,9 @@ type Prefetcher interface { // PrefetchAfterBlockRetrieved allows the prefetcher to trigger prefetches // after a block has been retrieved. Whichever component is responsible for // retrieving blocks will call this method once it's done retrieving a - // block. - PrefetchAfterBlockRetrieved(...
1
// Copyright 2016 Keybase Inc. All rights reserved. // Use of this source code is governed by a BSD // license that can be found in the LICENSE file. package libkbfs import ( "time" "github.com/keybase/client/go/libkb" "github.com/keybase/client/go/logger" "github.com/keybase/client/go/protocol/keybase1" "githu...
1
15,356
"and returns that" -- it looks like this method has no return value.
keybase-kbfs
go
@@ -212,7 +212,7 @@ class BitmapMasks(BaseInstanceMasks): def flip(self, flip_direction='horizontal'): """See :func:`BaseInstanceMasks.flip`.""" - assert flip_direction in ('horizontal', 'vertical') + assert flip_direction in ('horizontal', 'vertical', 'diagonal') if len(self.ma...
1
from abc import ABCMeta, abstractmethod import mmcv import numpy as np import pycocotools.mask as maskUtils import torch from mmcv.ops.roi_align import roi_align class BaseInstanceMasks(metaclass=ABCMeta): """Base class for instance masks.""" @abstractmethod def rescale(self, scale, interpolation='neare...
1
21,146
Modifications are also needed for PolygonMask.
open-mmlab-mmdetection
py
@@ -3,12 +3,9 @@ using System; using System.Net; -using Microsoft.AspNetCore; using Microsoft.AspNetCore.Hosting; -using Microsoft.AspNetCore.Server.Kestrel.Core; -using Microsoft.AspNetCore.Server.Kestrel.Transport.Abstractions.Internal; +using Microsoft.AspNetCore.Server.Kestrel.Core.Internal.Http; using Micros...
1
// Copyright (c) .NET Foundation. All rights reserved. // Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information. using System; using System.Net; using Microsoft.AspNetCore; using Microsoft.AspNetCore.Hosting; using Microsoft.AspNetCore.Server.Kestrel.Core; using M...
1
15,690
Does this really make a difference?
aspnet-KestrelHttpServer
.cs
@@ -70,6 +70,9 @@ public class TestRandomFlRTGCloud extends SolrCloudTestCase { /** Always included in fl so we can vet what doc we're looking at */ private static final FlValidator ID_VALIDATOR = new SimpleFieldValueValidator("id"); + + /** Since nested documents are not tested, when _root_ is declared in sch...
1
/* * Licensed to the Apache Software Foundation (ASF) under one or more * contributor license agreements. See the NOTICE file distributed with * this work for additional information regarding copyright ownership. * The ASF licenses this file to You under the Apache License, Version 2.0 * (the "License"); you may ...
1
28,011
Added a validator for _root_, which is now added automatically since the schema used here declares _root_.
apache-lucene-solr
java
@@ -76,6 +76,12 @@ public interface RewriteDataFiles extends SnapshotUpdate<RewriteDataFiles, Rewri */ String TARGET_FILE_SIZE_BYTES = "target-file-size-bytes"; + /** + * The estimated cost to open a file, used as a minimum weight when combining splits. By default this + * will use the "read.split.open-fi...
1
/* * Licensed to the Apache Software Foundation (ASF) under one * or more contributor license agreements. See the NOTICE file * distributed with this work for additional information * regarding copyright ownership. The ASF licenses this file * to you under the Apache License, Version 2.0 (the * "License"); you ...
1
41,655
The other properties are `file-open-cost`, not `open-file-cost`.
apache-iceberg
java
@@ -337,6 +337,19 @@ AC_ARG_ENABLE(easylogging, [Disable easylogging])) AM_CONDITIONAL(USE_EASYLOGGING, [test x$enable_easylogging != xno]) +case "${host_os}" in + *darwin*) + # libunwind comes standard with the command-line tools on macos + AC_DEFINE([HAVE_LIBUNWIND], [1], + [De...
1
# -*- Autoconf -*- # Process this file with autoconf to produce a configure script. # Copyright 2015 Stellar Development Foundation and contributors. Licensed # under the Apache License, Version 2.0. See the COPYING file at the root # of this distribution or at http://www.apache.org/licenses/LICENSE-2.0 AC_PREREQ([2....
1
17,688
confused by this: what we need here is not libunwind but libunwind-dev right? Why skipping detection?
stellar-stellar-core
c
@@ -24,8 +24,8 @@ namespace Microsoft.Azure throw new ArgumentNullException("serializer"); } JsonSerializer newSerializer = new JsonSerializer(); - PropertyInfo[] properties = typeof(JsonSerializer).GetProperties(); - foreach (var property in properties.W...
1
// Copyright (c) Microsoft Corporation. All rights reserved. // Licensed under the MIT License. See License.txt in the project root for license information. using System; using System.Linq; using System.Reflection; using Newtonsoft.Json; namespace Microsoft.Azure { public static class JsonSerializerExtensions ...
1
20,842
just in case helps, it this related with this PR?
Azure-autorest
java
@@ -88,6 +88,11 @@ def convert_019_100(data): def convert_100_200(data): data["version"] = (2, 0, 0) + data["client_conn"]["address"] = data["client_conn"]["address"]["address"] + data["server_conn"]["address"] = data["server_conn"]["address"]["address"] + data["server_conn"]["source_address"] = data["...
1
""" This module handles the import of mitmproxy flows generated by old versions. """ from typing import Any from mitmproxy import version from mitmproxy.utils import strutils def convert_011_012(data): data[b"version"] = (0, 12) return data def convert_012_013(data): data[b"version"] = (0, 13) ret...
1
12,888
This is incomplete I think (at least source_address and ip_address are missing)
mitmproxy-mitmproxy
py
@@ -126,7 +126,16 @@ public class DefaultSynchronizer<C> implements Synchronizer { LOG.info("Starting synchronizer."); blockPropagationManager.start(); if (fastSyncDownloader.isPresent()) { - fastSyncDownloader.get().start().whenComplete(this::handleFastSyncResult); + fastSyncDownload...
1
/* * Copyright ConsenSys AG. * * Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with * the License. You may obtain a copy of the License at * * http://www.apache.org/licenses/LICENSE-2.0 * * Unless required by applicable law or agreed to in writing...
1
22,669
We have a `stop` method here, we should probably be calling that instead of just exiting. There could be important resources to close or cleanup nicely now or in the future.
hyperledger-besu
java
@@ -35,6 +35,7 @@ namespace AutoRest.Extensions //Constraints = parameter.Constraints, Omit these since we don't want to perform parameter validation Documentation = parameter.Documentation, ModelType = parameter.ModelType, + RealPath = new string[] { },...
1
using System; using System.Collections.Generic; using System.Globalization; using System.Linq; using AutoRest.Core.Model; using Newtonsoft.Json.Linq; using static AutoRest.Core.Utilities.DependencyInjection; using AutoRest.Core.Utilities; namespace AutoRest.Extensions { public static class ParameterGroupExtension...
1
24,797
fixes ArgNullEx when using both `x-ms-parameter-grouping` and media type `application/xml` in the same operation (issue #2236)
Azure-autorest
java
@@ -33,6 +33,12 @@ const ( // The specified bucket does not exist. ErrCodeNoSuchBucket = "NoSuchBucket" + // ErrCodeBucketNotFound for service response error code + // "NotFound". + // + // The specified bucket does not exist + ErrCodeBucketNotFound = "NotFound" + // ErrCodeNoSuchKey for service response error ...
1
// Code generated by private/model/cli/gen-api/main.go. DO NOT EDIT. package s3 const ( // ErrCodeBucketAlreadyExists for service response error code // "BucketAlreadyExists". // // The requested bucket name is not available. The bucket namespace is shared // by all users of the system. Select a different name ...
1
10,298
`NotFound` is a generic error code derived from the HTTP response message's status code, and can be returned for any S3 operation that responds with a 404 status code and no other error code present. Due to this the constant `ErrCodeBucketNotFound`. In addition, these constants are generated based on the API model defi...
aws-aws-sdk-go
go
@@ -0,0 +1,18 @@ +test_name 'test generic installers' + +step 'install arbitrary msi via url' do + hosts.each do |host| + if host['platform'] =~ /win/ + # this should be implemented at the host/win/pkg.rb level someday + generic_install_msi_on(host, 'https://releases.hashicorp.com/vagrant/1.8.4/vagrant_1....
1
1
13,255
@johnduarte I was curious about the case when the operating system was neither `osx` or `win`; in this case, the test will indeed pass, but nothing will have actually really been tested. Should this have a `skip_test` condition at the top?
voxpupuli-beaker
rb
@@ -0,0 +1,10 @@ +package main + +import "time" + +func main() { + for { + println("hello world!") + time.Sleep(time.Second) + } +}
1
1
5,760
I think this example was included by accident? It doesn't seem to belong in this PR (but a separate PR with this would be nice!).
tinygo-org-tinygo
go
@@ -128,7 +128,7 @@ public class RestRequest { * * @param method the HTTP method for the request (GET/POST/DELETE etc) * @param path the URI path, this will automatically be resolved against the users current instance host. - * @param httpEntity the request body if there is one, can be null. + * @p...
1
/* * Copyright (c) 2011, salesforce.com, inc. * All rights reserved. * Redistribution and use of this software in source and binary forms, with or * without modification, are permitted provided that the following conditions * are met: * - Redistributions of source code must retain the above copyright notice, this...
1
14,722
Just fixing a bunch of outdated java docs in this file
forcedotcom-SalesforceMobileSDK-Android
java
@@ -51,7 +51,7 @@ namespace Nethermind.TxPool private readonly object _locker = new(); - private readonly ConcurrentDictionary<Address, AddressNonces> _nonces = + private readonly Dictionary<Address, AddressNonces> _nonces = new(); private readonly LruKeyCache<Keccak> ...
1
// Copyright (c) 2021 Demerzel Solutions Limited // This file is part of the Nethermind library. // // The Nethermind library is free software: you can redistribute it and/or modify // it under the terms of the GNU Lesser General Public License as published by // the Free Software Foundation, either version 3 of ...
1
25,102
I think it may be safer not to touch Concurrent to normal.
NethermindEth-nethermind
.cs
@@ -158,6 +158,10 @@ class Server extends EventEmitter { // setup listeners this.s.pool.on('parseError', parseErrorEventHandler(this)); + this.s.pool.on('drain', err => { + this.emit('error', err); + }); + // it is unclear whether consumers should even know about these events // this.s....
1
'use strict'; const EventEmitter = require('events'); const MongoError = require('../error').MongoError; const Pool = require('../connection/pool'); const relayEvents = require('../utils').relayEvents; const wireProtocol = require('../wireprotocol'); const BSON = require('../connection/utils').retrieveBSON(); const cre...
1
16,892
is this for everything, or just legacy?
mongodb-node-mongodb-native
js
@@ -368,6 +368,15 @@ function processNewChange(args) { const change = args.change; const callback = args.callback; const eventEmitter = args.eventEmitter || false; + + if (changeStream.isClosed()) { + if (eventEmitter) return; + + const error = new Error('ChangeStream is closed'); + if (typeof callba...
1
'use strict'; const EventEmitter = require('events'); const isResumableError = require('./error').isResumableError; const MongoError = require('mongodb-core').MongoError; var cursorOptionNames = ['maxAwaitTimeMS', 'collation', 'readPreference']; const CHANGE_DOMAIN_TYPES = { COLLECTION: Symbol('Collection'), DAT...
1
15,194
I think this should be a `MongoError` right?
mongodb-node-mongodb-native
js
@@ -14,8 +14,10 @@ var ( DdevBin = "ddev" DevTestSites = []testcommon.TestSite{ { - Name: "drupal8", - DownloadURL: "https://github.com/drud/drupal8/archive/v0.2.2.tar.gz", + Name: "drupal8", + SourceURL: "https://github.com/drud/drupal8/archive/v0.2.2.tar.gz", + FileURL: "https://gi...
1
package cmd import ( "fmt" "os" "testing" log "github.com/Sirupsen/logrus" "github.com/drud/ddev/pkg/testcommon" ) var ( // DdevBin is the full path to the drud binary DdevBin = "ddev" DevTestSites = []testcommon.TestSite{ { Name: "drupal8", DownloadURL: "https://github.com/drud/drupal8/a...
1
10,876
This is currently a db.tar.gz with just one .sql file in it. It might be worth another test (or maybe I'll find one) that has more than one sql file in it.
drud-ddev
go
@@ -218,6 +218,14 @@ var _ = infrastructure.DatastoreDescribe("VXLAN topology before adding host IPs policy.Spec.Selector = "has(host-endpoint)" _, err = client.GlobalNetworkPolicies().Create(utils.Ctx, policy, utils.NoOptions) Expect(err).NotTo(HaveOccurred()) + + policy = api.NewGlobalNetworkPol...
1
// Copyright (c) 2020 Tigera, Inc. All rights reserved. // // Licensed under the Apache License, Version 2.0 (the "License"); // you may not use this file except in compliance with the License. // You may obtain a copy of the License at // // http://www.apache.org/licenses/LICENSE-2.0 // // Unless required by appli...
1
17,408
Why these changes to existing tests?
projectcalico-felix
c
@@ -141,6 +141,12 @@ namespace Datadog.Trace.Configuration HeaderTags = HeaderTags.Where(kvp => !string.IsNullOrEmpty(kvp.Key) && !string.IsNullOrEmpty(kvp.Value)) .ToDictionary(kvp => kvp.Key.Trim(), kvp => kvp.Value.Trim()); + var serviceNameMappings = sou...
1
using System; using System.Collections; using System.Collections.Concurrent; using System.Collections.Generic; using System.Linq; using System.Text.RegularExpressions; using Datadog.Trace.PlatformHelpers; using Datadog.Trace.Util; using Datadog.Trace.Vendors.Serilog; namespace Datadog.Trace.Configuration { /// <su...
1
18,827
It should be `IsNullOrWhitespace` I believe, since we're going to trim the value afterwards (and I just realized the other configuration keys have the same issue)
DataDog-dd-trace-dotnet
.cs
@@ -72,9 +72,9 @@ module Bolt # Returns a hash of implementation name, path to executable, input method (if defined), # and any additional files (name and path) - def select_implementation(target, additional_features = []) + def select_implementation(target, provided_features = []) impl = if (i...
1
# frozen_string_literal: true module Bolt class NoImplementationError < Bolt::Error def initialize(target, task) msg = "No suitable implementation of #{task.name} for #{target.name}" super(msg, 'bolt/no-implementation') end end # Represents a Task. # @file and @files are mutually exclusive...
1
11,042
This is just for consistency + searchability with the transports
puppetlabs-bolt
rb
@@ -42,6 +42,7 @@ import ( const ( CertFile = "/tmp/kubeedge/certs/edge.crt" KeyFile = "/tmp/kubeedge/certs/edge.key" + ConfigPath = "/tmp/kubeedge/testData" ) //testServer is a fake http server created for testing
1
/* Copyright 2019 The KubeEdge Authors. Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, sof...
1
9,663
please run gofmt.
kubeedge-kubeedge
go
@@ -1,4 +1,4 @@ -package porcelain_test +package porcelain import ( "context"
1
package porcelain_test import ( "context" "testing" "time" cid "gx/ipfs/QmR8BauakNcBa3RbE4nbQu76PDiJgoQgz8AJdhJuiU4TAw/go-cid" "github.com/filecoin-project/go-filecoin/address" "github.com/filecoin-project/go-filecoin/porcelain" "github.com/filecoin-project/go-filecoin/types" "github.com/stretchr/testify/ass...
1
16,358
thats kind of a bummer, why do we have to give it full access? if it is just for the private interfaces i'd personally rather have those interfaces pollute the public exported symbols than open the tests up like this.
filecoin-project-venus
go
@@ -69,6 +69,11 @@ func (s *store) initialize() { continue } + // Ignore in case appNodes with appID not existed in store. + if s.apps[appID] == nil { + continue + } + // Add the missing resource into the dependedResources of the app. key := provider.MakeResourceKey(an.resource) s.apps[appID].add...
1
// Copyright 2020 The PipeCD Authors. // // Licensed under the Apache License, Version 2.0 (the "License"); // you may not use this file except in compliance with the License. // You may obtain a copy of the License at // // http://www.apache.org/licenses/LICENSE-2.0 // // Unless required by applicable law or agree...
1
19,351
Because this is an unexpected situation so can you add a log here to help us figure out what resource is causing this problem?
pipe-cd-pipe
go
@@ -554,12 +554,11 @@ public class OverseerCollectionMessageHandler implements OverseerMessageHandler, final String collectionName = message.getStr(ZkStateReader.COLLECTION_PROP); //the rest of the processing is based on writing cluster state properties //remove the property here to avoid any errors down...
1
/* * Licensed to the Apache Software Foundation (ASF) under one or more * contributor license agreements. See the NOTICE file distributed with * this work for additional information regarding copyright ownership. * The ASF licenses this file to You under the Apache License, Version 2.0 * (the "License"); you may ...
1
40,402
just observing that this innocent looking change seems important to this PR. Previously this data had disappeared from the state.
apache-lucene-solr
java
@@ -1442,7 +1442,8 @@ short ExExeUtilHBaseBulkLoadTcb::work() ComCondition *cond; Lng32 entryNumber; while ((cond = diagsArea->findCondition(EXE_ERROR_ROWS_FOUND, &entryNumber)) != NULL) { - errorRowCount = cond->getOptionalInteger(0); + if (errorRowCount < ...
1
/********************************************************************** // @@@ START COPYRIGHT @@@ // // Licensed to the Apache Software Foundation (ASF) under one // or more contributor license agreements. See the NOTICE file // distributed with this work for additional information // regarding copyright ownership. ...
1
15,819
Actually, I do have one question: You mention that each warning is for a different range. Should we add the rowcounts instead of using the max?
apache-trafodion
cpp
@@ -31,6 +31,7 @@ type Protocol interface { ReadState(context.Context, StateReader, []byte, ...[]byte) ([]byte, error) Register(*Registry) error ForceRegister(*Registry) error + Name() string } // GenesisStateCreator creates some genesis states
1
// Copyright (c) 2019 IoTeX Foundation // This is an alpha (internal) release and is not suitable for production. This source code is provided 'as is' and no // warranties are given as to title or non-infringement, merchantability or fitness for purpose and, to the extent // permitted by law, all liability for your use...
1
21,426
it is confusing to return ID as Name
iotexproject-iotex-core
go
@@ -380,8 +380,15 @@ class RemoteConnection(object): # Authorization header headers["Authorization"] = "Basic %s" % auth - self._conn.request(method, parsed_url.path, data, headers) - resp = self._conn.getresponse() + if body and method != 'POST' and method != 'PUT': + ...
1
# Copyright 2008-2009 WebDriver committers # Copyright 2008-2009 Google Inc. # Copyright 2013 BrowserStack # # Licensed under the Apache License, Version 2.0 (the "License"); # you may not use this file except in compliance with the License. # You may obtain a copy of the License at # # http://www.apache.org/licens...
1
10,707
body is being used here for the first time without every being populated. This will error. To run tests do `./go clean test_py` and that will run the Firefox tests
SeleniumHQ-selenium
java
@@ -48,7 +48,7 @@ class Bootstrap } $kernel = new AppKernel($this->environment, Environment::isEnvironmentDebug($this->environment)); - $kernel->loadClassCache(); + Request::setTrustedProxies(['127.0.0.1'], Request::HEADER_X_FORWARDED_ALL); if ($this->console) { $...
1
<?php namespace Shopsys; use AppKernel; use Doctrine\Common\Annotations\AnnotationRegistry; use Shopsys\Environment; use Symfony\Bundle\FrameworkBundle\Console\Application; use Symfony\Component\Console\Input\ArgvInput; use Symfony\Component\Console\Output\ConsoleOutput; use Symfony\Component\Debug\Debug; use Symfony...
1
8,764
commit mesasge: I would append "...Kernel::loadClassCache() method call"
shopsys-shopsys
php
@@ -76,8 +76,9 @@ public class Actions { * Note that the modifier key is <b>never</b> released implicitly - either * <i>keyUp(theKey)</i> or <i>sendKeys(Keys.NULL)</i> * must be called to release the modifier. - * @param theKey Either {@link Keys#SHIFT}, {@link Keys#ALT} or {@link Keys#CONTROL}. If the - ...
1
/* Copyright 2007-2011 Selenium committers Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing...
1
10,429
Keys.COMMAND seems to be an alias to Keys.META. That isn't mentioned?
SeleniumHQ-selenium
py
@@ -2,7 +2,7 @@ package azkaban.test.utils; import java.io.File; -import junit.framework.Assert; +import org.junit.Assert; import org.apache.log4j.Logger; import org.junit.Test;
1
package azkaban.test.utils; import java.io.File; import junit.framework.Assert; import org.apache.log4j.Logger; import org.junit.Test; import azkaban.utils.DirectoryFlowLoader; public class DirectoryFlowLoaderTest { @Test public void testDirectoryLoad() { Logger logger = Logger.getLogger(this.getClass()); D...
1
9,510
You can move this import down to before line 8 (import org.junit.Test;).
azkaban-azkaban
java
@@ -52,7 +52,7 @@ class Findingsnotifier(object): 'resource_type': violation.get('resource_type'), 'resource_id': violation.get('resource_id'), 'rule_index': violation.get('rule_index'), - 'inventory_index_id': violation.get('inventory_in...
1
# Copyright 2017 The Forseti Security Authors. All rights reserved. # # Licensed under the Apache License, Version 2.0 (the "License"); # you may not use this file except in compliance with the License. # You may obtain a copy of the License at # # http://www.apache.org/licenses/LICENSE-2.0 # # Unless required by ap...
1
29,616
It's okay to add the `scanner_index_id` here. But we still should keep the `inventory_index_id` reference because it will help the user to know right away, which inventory the violation is coming from, without having to do another lookup.
forseti-security-forseti-security
py
@@ -349,7 +349,9 @@ public class EventFiringWebDriver implements WebDriver, JavascriptExecutor, Take } public void submit() { + dispatcher.beforeClickOn(element, driver); element.submit(); + dispatcher.afterClickOn(element, driver); } public void sendKeys(CharSequence... keysToS...
1
// Licensed to the Software Freedom Conservancy (SFC) under one // or more contributor license agreements. See the NOTICE file // distributed with this work for additional information // regarding copyright ownership. The SFC licenses this file // to you under the Apache License, Version 2.0 (the // "License"); you m...
1
12,685
this shouldn't be beforeClickOn, but rather beforeSubmit? and added to WebDriverEventListener. Since submit does not synthesize the 'click' events, this isn't accurate.
SeleniumHQ-selenium
py
@@ -1,5 +1,7 @@ <h2> - Single + <% unless current_user_has_active_subscription? %> + Single + <% end %> <% if pricing_scheme == "primary" %> <%= render 'price', product: product, price: product.individual_price,
1
<h2> Single <% if pricing_scheme == "primary" %> <%= render 'price', product: product, price: product.individual_price, original_price: product.original_individual_price %> <% else %> <%= render 'price', product: product, price: product.alternate_individual_price, original_price: p...
1
6,905
Should this be I18n'd?
thoughtbot-upcase
rb
@@ -93,7 +93,7 @@ public class CheckCompatibility extends TypeUtil.CustomOrderSchemaVisitor<List<S } @Override - public List<String> struct(Types.StructType readStruct, Iterable<List<String>> fieldErrorLists) { + public ImmutableList<String> struct(Types.StructType readStruct, Iterable<List<String>> fieldErro...
1
/* * Licensed to the Apache Software Foundation (ASF) under one * or more contributor license agreements. See the NOTICE file * distributed with this work for additional information * regarding copyright ownership. The ASF licenses this file * to you under the Apache License, Version 2.0 (the * "License"); you ...
1
17,353
We don't typically use `ImmutableList` to avoid leaking it in methods that are accidentally public or purposely part of the API. I'm +1 for returning `ImmutableList.copyOf(errors)` below, but I don't think we should guarantee the list will be an `ImmutableList`.
apache-iceberg
java
@@ -441,10 +441,18 @@ class TestCase(unittest.TestCase): m = Chem.MolFromSmiles('C1=CN=CC=C1') pkl = cPickle.dumps(m) m2 = cPickle.loads(pkl) + self.assertTrue(type(m2) == Chem.Mol) smi1 = Chem.MolToSmiles(m) smi2 = Chem.MolToSmiles(m2) self.assertTrue(smi1 == smi2) + pkl = cPickle...
1
# # Copyright (C) 2003-2017 Greg Landrum and Rational Discovery LLC # All Rights Reserved # """ This is a rough coverage test of the python wrapper it's intended to be shallow, but broad """ from __future__ import print_function import os, sys, tempfile, gzip, gc import unittest, doctest from rdkit import R...
1
18,866
@greglandrum Is this test sufficient?
rdkit-rdkit
cpp
@@ -1,2 +1 @@ -GITHUB_USER = ENV['GITHUB_USER'] -GITHUB_PASSWORD = ENV['GITHUB_PASSWORD'] +GITHUB_ACCESS_TOKEN = ENV['GITHUB_ACCESS_TOKEN']
1
GITHUB_USER = ENV['GITHUB_USER'] GITHUB_PASSWORD = ENV['GITHUB_PASSWORD']
1
17,502
Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
thoughtbot-upcase
rb
@@ -0,0 +1,5 @@ +class MakePlansPolymorphic < ActiveRecord::Migration + def change + add_column :subscriptions, :plan_type, :string, null: false + end +end
1
1
8,009
I think Rails complains about the `null: false` part if we ever decide to roll this migration back. Might need to split this up into separate `up/down` methods to handle that.
thoughtbot-upcase
rb
@@ -618,8 +618,8 @@ func (mtask *managedTask) progressContainers() { // We've kicked off one or more transitions, wait for them to // complete, but keep reading events as we do. in fact, we have to for // transitions to complete - mtask.waitForContainerTransitions(transitions, transitionChange, transitionChangeCo...
1
// Copyright 2014-2018 Amazon.com, Inc. or its affiliates. All Rights Reserved. // // Licensed under the Apache License, Version 2.0 (the "License"). You may // not use this file except in compliance with the License. A copy of the // License is located at // // http://aws.amazon.com/apache2.0/ // // or in the "license...
1
19,274
I don't think we need this line. You're logging in `waitForContainerTransition()` anyway
aws-amazon-ecs-agent
go
@@ -13,7 +13,7 @@ return [ 'accepted' => ':attribute ला स्वीकार केला गेला पाहिजे.', - 'accepted_if' => 'The :attribute must be accepted when :other is :value.', + 'accepted_if' => ':other हे :value असेल तेव्हा हे फील्ड स्वीकारणे आवश्यक आहे.', 'active_url' => ':...
1
<?php /* |-------------------------------------------------------------------------- | Validation Language Lines |-------------------------------------------------------------------------- | | The following language lines contain the default error messages used by | the validator class. Some of these rules have multip...
1
9,247
Shouldn't the `:attribute` placeholder appear?
Laravel-Lang-lang
php
@@ -78,8 +78,8 @@ public class ResidualEvaluator implements Serializable { private class ResidualVisitor extends ExpressionVisitors.BoundExpressionVisitor<Expression> { private StructLike struct; - private Expression eval(StructLike struct) { - this.struct = struct; + private Expression eval(Struct...
1
/* * Licensed to the Apache Software Foundation (ASF) under one * or more contributor license agreements. See the NOTICE file * distributed with this work for additional information * regarding copyright ownership. The ASF licenses this file * to you under the Apache License, Version 2.0 (the * "License"); you ...
1
13,106
Could you update this to `structLike` instead of `arg`?
apache-iceberg
java
@@ -0,0 +1,14 @@ +// +build darwin linux,!baremetal freebsd,!baremetal + +// +build gc.conservative gc.leaking + +package runtime + +const heapSize = 1 * 1024 * 1024 // 1MB to start + +var heapStart, heapEnd uintptr + +func preinit() { + heapStart = uintptr(malloc(heapSize)) + heapEnd = heapStart + heapSize +}
1
1
9,182
I only now spot this `freebsd,!baremetal` in the code, which doesn't make a lot of sense. The fact that there is `linux,!baremetal` is because baremetal targets pretend to be linux/arm to get the standard library to compile. Such a `!baremetal` exclusion is not necessary for FreeBSD. But this is not something that need...
tinygo-org-tinygo
go
@@ -455,7 +455,7 @@ get_unpacked_unlinked_content (OstreeRepo *repo, GError **error) { gboolean ret = FALSE; - g_autofree char *tmpname = g_strdup ("tmpostree-deltaobj-XXXXXX"); + g_autofree char *tmpname = g_strdup ("/var/tmp/tmpostree-deltaobj-XXXXXX"); glnx_fd_...
1
/* -*- mode: C; c-file-style: "gnu"; indent-tabs-mode: nil; -*- * * Copyright (C) 2013,2014 Colin Walters <walters@verbum.org> * * This library is free software; you can redistribute it and/or * modify it under the terms of the GNU Lesser General Public * License as published by the Free Software Foundation; eith...
1
7,289
Ugh, we were using cwd? =(
ostreedev-ostree
c
@@ -21,7 +21,6 @@ struct screencopy_damage { struct pixman_region32 damage; struct wl_listener output_precommit; struct wl_listener output_destroy; - uint32_t last_commit_seq; }; static const struct zwlr_screencopy_frame_v1_interface frame_impl;
1
#include <assert.h> #include <stdlib.h> #include <drm_fourcc.h> #include <wlr/render/wlr_renderer.h> #include <wlr/types/wlr_matrix.h> #include <wlr/types/wlr_output.h> #include <wlr/types/wlr_linux_dmabuf_v1.h> #include <wlr/types/wlr_screencopy_v1.h> #include <wlr/backend.h> #include <wlr/util/box.h> #include <wlr/ut...
1
16,548
This can probably be removed?
swaywm-wlroots
c
@@ -89,8 +89,9 @@ void FetchExecutor::setupResponse(cpp2::ExecutionResponse &resp) { } void FetchExecutor::onEmptyInputs() { + auto outputs = std::make_unique<InterimResult>(std::move(resultColNames_)); if (onResult_) { - onResult_(nullptr); + onResult_(std::move(outputs)); } else if (res...
1
/* Copyright (c) 2019 vesoft inc. All rights reserved. * * This source code is licensed under Apache 2.0 License, * attached with Common Clause Condition 1.0, found in the LICENSES directory. */ #include "base/Base.h" #include "FetchExecutor.h" namespace nebula { namespace graph { Status FetchExecutor::prepareYi...
1
21,468
put this sentence in `if (onResult_) { }`
vesoft-inc-nebula
cpp
@@ -235,11 +235,16 @@ echo "echo '{export_forseti_vars}' >> /etc/profile.d/forseti_environment.sh" | s gsutil cp gs://{scanner_bucket}/configs/forseti_conf_server.yaml {forseti_server_conf} gsutil cp -r gs://{scanner_bucket}/rules {forseti_home}/ +# Download the Newest Config Validator constraints from GCS +rm -rf ...
1
# Copyright 2017 The Forseti Security Authors. All rights reserved. # # Licensed under the Apache License, Version 2.0 (the "License"); # you may not use this file except in compliance with the License. # You may obtain a copy of the License at # # http://www.apache.org/licenses/LICENSE-2.0 # # Unless required by ap...
1
33,781
Will this always be started up as default? Is there any impact to the VM in terms of load and memory usage?
forseti-security-forseti-security
py
@@ -374,7 +374,7 @@ class CommandLine /// parsable types (values are comma separated without space). /// /// Qualifiers that are defined BEFORE any parameter sets apply to ALL parameter sets. qualifiers that - /// are defined AFTER a parameter set will apply only the the parameter set...
1
// Licensed to the .NET Foundation under one or more agreements. // The .NET Foundation licenses this file to you under the MIT license. // See the LICENSE file in the project root for more information. using System; using System.Diagnostics; using System.Text; using System.Collections.Generic; using System.IO; using ...
1
11,895
Thanks for fixing the typo's but given that this is a fork of the other commandline.cs file they will still exist there :( Part of the reason forks suck.
dotnet-buildtools
.cs
@@ -141,8 +141,14 @@ import datetime import itertools import logging import luigi -import sqlalchemy import os +import warnings + +try: + import sqlalchemy +except ImportError: + # Don't fail on import because we want the documentation to be generated + warnings.warn("sqlalchemy could not be imported, db_t...
1
# -*- coding: utf-8 -*- # # Copyright (c) 2015 Gouthaman Balaraman # # Licensed under the Apache License, Version 2.0 (the "License"); you may not # use this file except in compliance with the License. You may obtain a copy of # the License at # # http://www.apache.org/licenses/LICENSE-2.0 # # Unless required...
1
11,162
This doesn't seem related to docs? :)
spotify-luigi
py
@@ -233,7 +233,7 @@ public class K9 extends Application { private static boolean hideSpecialAccounts = false; private static boolean autofitWidth; private static boolean quietTimeEnabled = false; - private static boolean notificationDuringQuietTimeEnabled = true; + private static boolean notificati...
1
package com.fsck.k9; import java.io.File; import java.util.ArrayList; import java.util.HashMap; import java.util.List; import java.util.Map; import java.util.concurrent.BlockingQueue; import java.util.concurrent.SynchronousQueue; import android.app.Application; import android.content.ComponentName; import android.c...
1
16,829
Having a negative in the variable/method name makes the code harder to read. Also, you inverted the logic but didn't invert the default value. I suggest sticking to the original name.
k9mail-k-9
java
@@ -66,8 +66,8 @@ namespace NLog.Targets /// Always use <see cref="Trace.WriteLine(string)"/> independent of <see cref="LogLevel"/> /// </summary> /// <docgen category='Output Options' order='100' /> - [DefaultValue(false)] - public bool RawWrite { get; set; } + [DefaultV...
1
// // Copyright (c) 2004-2020 Jaroslaw Kowalski <jaak@jkowalski.net>, Kim Christensen, Julian Verdurmen // // All rights reserved. // // Redistribution and use in source and binary forms, with or without // modification, are permitted provided that the following conditions // are met: // // * Redistributions of s...
1
21,582
Think you need to keep `RawWrite` around as obsolete until NLog6 (Property that just assigns `ForceTraceWriteLine`)
NLog-NLog
.cs
@@ -45,6 +45,9 @@ proc_init_arch(void) num_simd_registers = MCXT_NUM_SIMD_SLOTS; num_opmask_registers = MCXT_NUM_OPMASK_SLOTS; + set_cache_line_size_using_ctr_el0(/* dcache_line_size= */ &cache_line_size, + /* icache_line_size= */ NULL); + /* FIXME i#1569: NYI */...
1
/* ********************************************************** * Copyright (c) 2016 ARM Limited. All rights reserved. * **********************************************************/ /* * Redistribution and use in source and binary forms, with or without * modification, are permitted provided that the following condit...
1
21,691
I would expect this to be named *get* not *set*: it's a query; it's not setting some persistent state.
DynamoRIO-dynamorio
c
@@ -2,7 +2,7 @@ import os from typing import Dict, List from dagster import SensorDefinition -from dagster.core.definitions.pipeline_sensor import PipelineFailureSensorContext +from dagster.core.definitions.pipeline_definition_sensor import PipelineFailureSensorContext from dagster_slack import make_slack_on_pipel...
1
import os from typing import Dict, List from dagster import SensorDefinition from dagster.core.definitions.pipeline_sensor import PipelineFailureSensorContext from dagster_slack import make_slack_on_pipeline_failure_sensor from hacker_news_assets.utils.slack_message import build_slack_message_blocks def slack_messag...
1
16,492
maybe should rename this to be `run_status_sensor_definition.py`
dagster-io-dagster
py
@@ -0,0 +1,19 @@ +/* + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writi...
1
1
29,722
Do we want to add the other write options in this PR or keep the refactor separate?
apache-iceberg
java
@@ -68,7 +68,17 @@ def refresh_user_token(spotify_user): user (domain.spotify.Spotify): the same user with updated tokens """ auth = get_spotify_oauth() - new_token = auth.refresh_access_token(spotify_user.refresh_token) + + retries = 5 + new_token = None + while retries > 0: + new...
1
import pytz from flask import current_app import spotipy.oauth2 from listenbrainz.db import spotify as db_spotify import datetime class Spotify: def __init__(self, user_id, musicbrainz_id, user_token, token_expires, refresh_token, last_updated, active, error_message, latest_listened_at): ...
1
15,042
either make this a config or a constant we can define at the top. Burying this in the code is no good.
metabrainz-listenbrainz-server
py
@@ -73,6 +73,13 @@ def multi_error(y_true, y_pred): def multi_logloss(y_true, y_pred): return np.mean([-math.log(y_pred[i][y]) for i, y in enumerate(y_true)]) +def custom_recall(y_true, y_pred): + return 'custom_recall', recall_score(y_true, y_pred > 0.5), True + + +def custom_precision(y_true, y_pred): + ...
1
# coding: utf-8 import itertools import joblib import math import os import unittest import warnings import lightgbm as lgb import numpy as np from sklearn import __version__ as sk_version from sklearn.base import clone from sklearn.datasets import (load_boston, load_breast_cancer, load_digits, ...
1
25,329
Same about new metrics. Can we avoid adding them?
microsoft-LightGBM
cpp
@@ -40,6 +40,15 @@ def run(): group.add_argument('--cloudsql-region', help='The Cloud SQL region') + network = parser.add_argument_group(title='network') + network.add_argument('--network-host-project-id', + help='The project id that is hosting the network ' ...
1
# Copyright 2017 The Forseti Security Authors. All rights reserved. # # Licensed under the Apache License, Version 2.0 (the "License"); # you may not use this file except in compliance with the License. # You may obtain a copy of the License at # # http://www.apache.org/licenses/LICENSE-2.0 # # Unless required by a...
1
28,123
I know this is a port from the previous PR, but I am wondering if we can take the chance to improve the naming? `--vpc-host-project-id` ?
forseti-security-forseti-security
py
@@ -228,7 +228,7 @@ describe('Formulas general', () => { afterChange, }); - hot.getSourceData()[1][1] = 20; + hot.setSourceDataAtCell(1, 1, 20); hot.getPlugin('formulas').recalculateFull(); hot.render();
1
describe('Formulas general', () => { const id = 'testContainer'; beforeEach(function() { this.$container = $(`<div id="${id}"></div>`).appendTo('body'); }); afterEach(function() { if (this.$container) { destroy(); this.$container.remove(); } }); it('should calculate table (simple ...
1
16,468
The test description says it's "by reference". We should change the description
handsontable-handsontable
js
@@ -16,9 +16,15 @@ namespace AutoRest.Core.Validation { } + /// <summary> + /// Id of the Rule. + /// </summary> public virtual string Id => "!!! implement me and make me abstract !!!"; - public ValidationCategory ValidationCategory => ((ValidationCategory)0); ...
1
// Copyright (c) Microsoft Corporation. All rights reserved. // Licensed under the MIT License. See License.txt in the project root for license information. using System.Collections.Generic; using AutoRest.Core.Logging; using System; namespace AutoRest.Core.Validation { /// <summary> /// Defines validation l...
1
23,911
A C# newbie question here: would it make sense to declare Id as an abstract property so any subclass Must have its own Id?
Azure-autorest
java
@@ -47,6 +47,11 @@ func (r *Repository) Proposals(filter *proposal.Filter) ([]market.ServiceProposa return []market.ServiceProposal{}, nil } +// Countries returns proposals per country matching the filter. +func (r *Repository) Countries(filter *proposal.Filter) (map[string]int, error) { + return nil, nil +} + //...
1
/* * Copyright (C) 2020 The "MysteriumNetwork/node" Authors. * * This program is free software: you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by * the Free Software Foundation, either version 3 of the License, or * (at your option) any later version. * ...
1
17,395
just looks like you should return an **empty map** with nil error
mysteriumnetwork-node
go
@@ -103,11 +103,18 @@ func main() { reloadURL := app.Flag("reload-url", "reload URL to trigger Prometheus reload on"). Default("http://127.0.0.1:9090/-/reload").URL() + version.RegisterIntoKingpinFlags(app) + if _, err := app.Parse(os.Args[1:]); err != nil { fmt.Fprintln(os.Stderr, err) os.Exit(2) } ...
1
// Copyright 2016 The prometheus-operator Authors // // Licensed under the Apache License, Version 2.0 (the "License"); // you may not use this file except in compliance with the License. // You may obtain a copy of the License at // // http://www.apache.org/licenses/LICENSE-2.0 // // Unless required by applicable ...
1
15,073
could you also update the starting log at L146?
prometheus-operator-prometheus-operator
go
@@ -312,6 +312,16 @@ func isUnitExists(err error) bool { return false } +// isDbusClosed returns true if the error is that connection closed. +func isDbusClosed(err error) bool { + if err != nil { + if dbusError, ok := err.(dbus.Error); ok { + return strings.Contains(dbusError.Name, "connection closed by user")...
1
package systemd import ( "bufio" "fmt" "math" "os" "regexp" "strconv" "strings" "sync" "time" systemdDbus "github.com/coreos/go-systemd/v22/dbus" dbus "github.com/godbus/dbus/v5" cgroupdevices "github.com/opencontainers/runc/libcontainer/cgroups/devices" "github.com/opencontainers/runc/libcontainer/confi...
1
22,817
Also this probably should be `error.As()` or something like it.
opencontainers-runc
go
@@ -219,7 +219,9 @@ webdriver.CommandName = { GET_SESSION_LOGS: 'getSessionLogs', // Non-standard commands used by the standalone Selenium server. - UPLOAD_FILE: 'uploadFile' + UPLOAD_FILE: 'uploadFile', + + GET_CANVAS_URL: 'getCanvasUrl' };
1
// Copyright 2011 Software Freedom Conservancy. All Rights Reserved. // // Licensed under the Apache License, Version 2.0 (the "License"); // you may not use this file except in compliance with the License. // You may obtain a copy of the License at // // http://www.apache.org/licenses/LICENSE-2.0 // // Unless req...
1
11,766
This is Safari specific and should be defined somewhere in the `safaridriver` namespace
SeleniumHQ-selenium
py
@@ -49,6 +49,13 @@ main(int argc, char *argv[]) exit (EXIT_SUCCESS); } + /* We conflict with the magic ostree-mount-deployment-var file for ostree-prepare-root */ + { struct stat stbuf; + if (fstatat (AT_FDCWD, "/run/ostree-mount-deployment-var", &stbuf, 0) == 0) + exit (EXIT_SUCCESS); + } + + ...
1
/* * Copyright (C) 2017 Colin Walters <walters@verbum.org> * * SPDX-License-Identifier: LGPL-2.0+ * * This library is free software; you can redistribute it and/or * modify it under the terms of the GNU Lesser General Public * License as published by the Free Software Foundation; either * version 2 of the Licen...
1
15,116
Let's maybe be nice and `unlinkat()` here in the interest of having `/run` be less littered. Or in addition/alternatively, make the file `/run/ostree/initramfs-mount-var` since we already made `/run/ostree/` for the deployment staging bits.
ostreedev-ostree
c
@@ -21,6 +21,7 @@ #include "teleport.h" #include "game.h" +#include <boost/format.hpp> extern Game g_game;
1
/** * The Forgotten Server - a free and open-source MMORPG server emulator * Copyright (C) 2019 Mark Samman <mark.samman@gmail.com> * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by * the Free Software Foundation; eithe...
1
17,184
Not sure if this doesn't require explicitly adding this library to cmake.
otland-forgottenserver
cpp