patch
stringlengths
17
31.2k
y
int64
1
1
oldf
stringlengths
0
2.21M
idx
int64
1
1
id
int64
4.29k
68.4k
msg
stringlengths
8
843
proj
stringclasses
212 values
lang
stringclasses
9 values
@@ -47,7 +47,7 @@ class SolrVersionStatus extends AbstractSolrStatus * * @var string */ - const REQUIRED_SOLR_VERSION = '6.3.0'; + const REQUIRED_SOLR_VERSION = '6.6.2'; /** * Compiles a version check against each configured Solr server.
1
<?php namespace ApacheSolrForTypo3\Solr\Report; /*************************************************************** * Copyright notice * * (c) 2011-2015 Stefan Sprenger <stefan.sprenger@dkd.de> * (c) 2012-2015 Ingo Renner <ingo@typo3.org> * All rights reserved * * This script is part of the TYPO3 project. The...
1
6,438
Solr dependency was downgraded?
TYPO3-Solr-ext-solr
php
@@ -38,6 +38,7 @@ module C2 config.autoload_paths << Rails.root.join('app', 'mailers', 'concerns') config.autoload_paths << Rails.root.join('app', 'policies', 'concerns') config.autoload_paths << Rails.root.join('lib') + config.autoload_paths << Rails.root.join("lib", "services") config.assets....
1
require File.expand_path('../boot', __FILE__) require 'rails/all' # Require the gems listed in Gemfile, including any gems # you've limited to :test, :development, or :production. Bundler.require(:default, Rails.env) module C2 class Application < Rails::Application # Settings in config/environments/* take prec...
1
14,969
or should we just autoload everything in `lib` ?
18F-C2
rb
@@ -59,6 +59,13 @@ public class NodeStatus { } } + public boolean hasCapability(Capabilities caps) { + long count = slots.stream() + .filter(slot -> slot.isSupporting(caps)) + .count(); + return count > 0; + } + public boolean hasCapacity() { return slots.stream().anyMatch(slot -...
1
// Licensed to the Software Freedom Conservancy (SFC) under one // or more contributor license agreements. See the NOTICE file // distributed with this work for additional information // regarding copyright ownership. The SFC licenses this file // to you under the Apache License, Version 2.0 (the // "License"); you m...
1
18,174
Prefer `Stream.anyMatch` instead of iterating over all slots.
SeleniumHQ-selenium
java
@@ -533,6 +533,7 @@ CREATE_VIOLATIONS_TABLE = """ `violation_type` enum('UNSPECIFIED', 'ADDED','REMOVED', 'BIGQUERY_VIOLATION', + 'BLACKLIST_VIOLATION', 'BUCKET_VIOLATION', ...
1
# Copyright 2017 The Forseti Security Authors. All rights reserved. # # Licensed under the Apache License, Version 2.0 (the "License"); # you may not use this file except in compliance with the License. # You may obtain a copy of the License at # # http://www.apache.org/licenses/LICENSE-2.0 # # Unless required by ap...
1
28,557
create_tables isn't used in 2.0 (should probably be deleted?)
forseti-security-forseti-security
py
@@ -29,6 +29,7 @@ namespace OpenTelemetry.Exporter internal Func<DateTimeOffset> GetUtcNowDateTimeOffset = () => DateTimeOffset.UtcNow; private int scrapeResponseCacheDurationMilliseconds = 10 * 1000; + private IReadOnlyCollection<string> httpListenerPrefixes = new string[] { "http://*:80/" }...
1
// <copyright file="PrometheusExporterOptions.cs" company="OpenTelemetry Authors"> // Copyright The OpenTelemetry Authors // // Licensed under the Apache License, Version 2.0 (the "License"); // you may not use this file except in compliance with the License. // You may obtain a copy of the License at // // http://...
1
23,134
Now I start to wonder, do we want to have `80` as the default or `9090` (or depending on whether we are exposing it via `PrometheusExporterMiddleware` vs. `PrometheusExporterHttpServer`)?
open-telemetry-opentelemetry-dotnet
.cs
@@ -980,7 +980,9 @@ TEST(Parser, UserOperation) { { GQLParser parser; std::string query = "CREATE USER IF NOT EXISTS user1 WITH PASSWORD \"aaa\" , " - "FIRSTNAME \"a\", LASTNAME \"a\", EMAIL \"a\", PHONE \"111\""; + "ACCOUNT LOCK, MAX_QUERIES_...
1
/* Copyright (c) 2018 vesoft inc. All rights reserved. * * This source code is licensed under Apache 2.0 License, * attached with Common Clause Condition 1.0, found in the LICENSES directory. */ #include <gtest/gtest.h> #include "base/Base.h" #include "parser/GQLParser.h" // TODO(dutor) Inspect the internal struc...
1
18,243
try an illegal case. and the result is syntax error.
vesoft-inc-nebula
cpp
@@ -23,6 +23,7 @@ void MemoryDataLayer<Dtype>::DataLayerSetUp(const vector<Blob<Dtype>*>& bottom, added_label_.Reshape(batch_size_, 1, 1, 1); data_ = NULL; labels_ = NULL; + needs_reshape_ = false; added_data_.cpu_data(); added_label_.cpu_data(); }
1
#include <vector> #include "caffe/data_layers.hpp" #include "caffe/layer.hpp" #include "caffe/util/io.hpp" namespace caffe { template <typename Dtype> void MemoryDataLayer<Dtype>::DataLayerSetUp(const vector<Blob<Dtype>*>& bottom, const vector<Blob<Dtype>*>& top) { batch_size_ = this->layer_param_.memory_data...
1
31,165
Initialize `needs_reshape_` with true and call `Reshape` method
BVLC-caffe
cpp
@@ -936,7 +936,10 @@ EOM # @private RANDOM_ORDERING = lambda do |list| Kernel.srand RSpec.configuration.seed - ordering = list.sort_by { Kernel.rand(list.size) } + orders = list.map {|x| !(x.respond_to?(:order)) || x.order.nil? || x.order == :random ? Kernel.rand(list.size) : 1} + ...
1
require 'fileutils' require 'rspec/core/backtrace_cleaner' require 'rspec/core/ruby_project' module RSpec module Core # Stores runtime configuration information. # # Configuration options are loaded from `~/.rspec`, `.rspec`, # `.rspec-local`, command line switches, and the `SPEC_OPTS` environment ...
1
9,151
This is a _very_ complicated line. I'm not a fan of ternaries to begin with (although, I allow them in very simple situations), but this ternary has compound conditionals and would really need to be broken up. That said: if I'm reading this right, it sounds like this logic can make it where this lambda (which is called...
rspec-rspec-core
rb
@@ -52,7 +52,8 @@ if (TYPO3_MODE == 'BE') { '', [ // An array holding the controller-action-combinations that are accessible - 'Administration' => 'index,setSite,setCore,noSiteAvailable' + 'Administration' => 'index,setSite,setCore,noSiteAvailable', + 'Bac...
1
<?php if (!defined('TYPO3_MODE')) { die('Access denied.'); } # ----- # ----- # ----- # ----- # ----- # ----- # ----- # ----- # ----- # // add search plugin to content element wizard if (TYPO3_MODE == 'BE') { $TBE_MODULES_EXT['xMOD_db_new_content_el']['addElClasses']['ApacheSolrForTypo3\\Solr\\Backend\\Content...
1
6,177
We should remove this
TYPO3-Solr-ext-solr
php
@@ -205,6 +205,8 @@ type Config struct { sourceToRawConfig map[Source]map[string]string rawValues map[string]string Err error + + IptablesNATOutgoingInterfaceFilter string `config:"string;"` } type ProtoPort struct {
1
// Copyright (c) 2016-2019 Tigera, Inc. All rights reserved. // Licensed under the Apache License, Version 2.0 (the "License"); // you may not use this file except in compliance with the License. // You may obtain a copy of the License at // // http://www.apache.org/licenses/LICENSE-2.0 // // Unless required by ap...
1
16,676
We should validate this, I think. To add a validator: - change `string` to, say `iface-pattern` - add a new `case "iface-pattern"` to the `switch` in the `loadParams()` function: - in that `case`, you should be able to use a RegexpPattern like the one for `iface-list`. However, you'll need a different regexp. I think t...
projectcalico-felix
c
@@ -59,6 +59,10 @@ func TestBalance(t *testing.T) { require.Nil(err) // Balance should == 30 now require.Equal(0, state.Balance.Cmp(big.NewInt(30))) + + // Sub 40 to the balance + err = state.SubBalance(big.NewInt(40)) + require.Equal(err, ErrNotEnoughBalance) } func TestClone(t *testing.T) {
1
// Copyright (c) 2019 IoTeX Foundation // This is an alpha (internal) release and is not suitable for production. This source code is provided 'as is' and no // warranties are given as to title or non-infringement, merchantability or fitness for purpose and, to the extent // permitted by law, all liability for your use...
1
19,963
File is not `goimports`-ed with -local github.com/iotexproject/iotex-core (from `goimports`)
iotexproject-iotex-core
go
@@ -53,6 +53,11 @@ public class FlinkOrcWriter implements OrcRowWriter<RowData> { writer.writeRow(row, output); } + @Override + public List<OrcValueWriter<?>> writers() { + return this.writer.writers(); + } + @Override public Stream<FieldMetrics<?>> metrics() { return writer.metrics();
1
/* * Licensed to the Apache Software Foundation (ASF) under one * or more contributor license agreements. See the NOTICE file * distributed with this work for additional information * regarding copyright ownership. The ASF licenses this file * to you under the Apache License, Version 2.0 (the * "License"); you ...
1
43,025
Nit: Here we don't need the extra `this` in iceberg because we usually use the `this` to distinguish whether it is a member variable or local variable when assigning value.
apache-iceberg
java
@@ -71,7 +71,7 @@ public class AuthorizationLoggingTest { engineRule.getManagementService().toggleTelemetry(true); // then - String message = "ENGINE-03029 Required admin authenticated group or user."; + String message = "ENGINE-16002 Exception while closing command context: ENGINE-03110 Required admi...
1
/* * Copyright Camunda Services GmbH and/or licensed to Camunda Services GmbH * under one or more contributor license agreements. See the NOTICE file * distributed with this work for additional information regarding copyright * ownership. Camunda licenses this file to you under the Apache License, * Version 2.0; y...
1
12,622
Why do we have that extra "ENGINE-16002 Exception while closing command context:" now? Is that done intentionally by us or where does that now come from?
camunda-camunda-bpm-platform
java
@@ -4,10 +4,15 @@ import org.slf4j.Logger; import org.slf4j.LoggerFactory; import org.slf4j.Marker; +import java.util.Collections; import java.util.Map.Entry; +import java.util.Set; import java.util.SortedMap; import java.util.concurrent.ScheduledExecutorService; import java.util.concurrent.TimeUnit; +import ja...
1
package com.codahale.metrics; import org.slf4j.Logger; import org.slf4j.LoggerFactory; import org.slf4j.Marker; import java.util.Map.Entry; import java.util.SortedMap; import java.util.concurrent.ScheduledExecutorService; import java.util.concurrent.TimeUnit; /** * A reporter class for logging metrics values to a S...
1
7,088
Please don't use star imports, in the codebase we tend to use direct imports.
dropwizard-metrics
java
@@ -1,8 +1,10 @@ +import {CREDENTIALS} from "../config.func"; + module.exports = function(server) { test('who am I?', () => { return server.whoami().then(function (username) { - expect(username).toMatch('test'); + expect(username).toMatch(CREDENTIALS.user); }); });
1
module.exports = function(server) { test('who am I?', () => { return server.whoami().then(function (username) { expect(username).toMatch('test'); }); }); };
1
18,070
Filename can be `config.functional`
verdaccio-verdaccio
js
@@ -44,11 +44,19 @@ nano::block_processor::block_processor (nano::node & node_a, nano::write_databas this->condition.notify_all (); } }; + thread = std::thread ([this] () { + nano::thread_role::set (nano::thread_role::name::block_processing); + this->process_blocks (); + }); } nano::block_processor::~blo...
1
#include <nano/lib/threading.hpp> #include <nano/lib/timer.hpp> #include <nano/node/blockprocessor.hpp> #include <nano/node/election.hpp> #include <nano/node/node.hpp> #include <nano/node/websocket.hpp> #include <nano/secure/blockstore.hpp> #include <boost/format.hpp> std::chrono::milliseconds constexpr nano::block_p...
1
16,688
Should the thread join be done in the stop function maybe? I am simply wondering and sharing my thoughts. This is my thinking: * The join used to be done in the stop function of node class and now it has moved in the destructor. * The class state_block_signature_verification joins its thread at the stop function too.
nanocurrency-nano-node
cpp
@@ -22,3 +22,8 @@ var WalletCmd = &cobra.Command{ fmt.Println("Print: " + strings.Join(args, " ")) }, } + +func init() { + WalletCmd.AddCommand(walletCreateCmd) + WalletCmd.AddCommand(walletListCmd) +}
1
// Copyright (c) 2019 IoTeX // This is an alpha (internal) release and is not suitable for production. This source code is provided 'as is' and no // warranties are given as to title or non-infringement, merchantability or fitness for purpose and, to the extent // permitted by law, all liability for your use of the cod...
1
15,755
don't use `init` function (from `gochecknoinits`)
iotexproject-iotex-core
go
@@ -3,7 +3,7 @@ # Purpose: # sns-ruby-example-enable-resource.rb demonstrates how to enable an Amazon Simple Notification Services (SNS) resource using -# the AWS SDK for JavaScript (v3). +# the AWS SDK for Ruby. # Inputs: # - MY_TOPIC_ARN
1
# Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved. # SPDX-License-Identifier: Apache-2.0 # Purpose: # sns-ruby-example-enable-resource.rb demonstrates how to enable an Amazon Simple Notification Services (SNS) resource using # the AWS SDK for JavaScript (v3). # Inputs: # - MY_TOPIC_ARN # - ...
1
20,566
Simple Notification **Service** (singular)
awsdocs-aws-doc-sdk-examples
rb
@@ -15,6 +15,7 @@ DEFINE_int64(int64_test, 10, "Test flag for int64 type"); DEFINE_bool(bool_test, false, "Test flag for bool type"); DEFINE_double(double_test, 3.14159, "Test flag for double type"); DEFINE_string(string_test, "Hello World", "Test flag for string type"); +DEFINE_uint32(crash_test, 1024, "The flag co...
1
/* Copyright (c) 2018 - present, VE Software Inc. All rights reserved * * This source code is licensed under Apache 2.0 License * (found in the LICENSE.Apache file in the root directory) */ #include "base/Base.h" #include <gtest/gtest.h> #include <folly/json.h> #include "webservice/WebService.h" #include "process...
1
16,592
You are fixing the crash problem, and you have fixed it, so it won't crash anymore. So `crash_test` is not a proper name.
vesoft-inc-nebula
cpp
@@ -68,8 +68,12 @@ public class SampleNamer extends NameFormatterDelegator { return localVarName(Name.lowerCamel("request")); } - /** Returns the variable name of the request body. */ public String getRequestBodyVarName() { + return getRequestBodyVarName(""); + } + + /** Returns the variable name of ...
1
/* Copyright 2016 Google Inc * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. * You may obtain a copy of the License at * * http://www.apache.org/licenses/LICENSE-2.0 * * Unless required by applicable law or agreed to in ...
1
19,741
If this default doesn't depend on the argument, shouldn't it be delegated as the default for the no-arg version instead?
googleapis-gapic-generator
java
@@ -84,7 +84,7 @@ def read_api_key_safe(): def _get_config_file(path): - get_or_create_file(path) + get_or_create_file(path, permissions=0o600) return path
1
import json import os import time from six.moves import queue from localstack import config from localstack.constants import API_ENDPOINT from localstack.utils.common import JsonObject, get_or_create_file from localstack.utils.common import safe_requests as requests from localstack.utils.common import save_file, shor...
1
13,593
I did not use the new save_config_file method in here, because I am not sure whether this whole logic is still necessary? There is an TODO about it there as well.
localstack-localstack
py
@@ -22,7 +22,7 @@ define(['dom', 'appRouter', 'connectionManager'], function (dom, appRouter, conn return void appRouter.showItem(items[0]); } - var url = 'itemdetails.html?id=' + itemId + '&serverId=' + serverId; + var url = 'details?id=' + itemId +...
1
define(['dom', 'appRouter', 'connectionManager'], function (dom, appRouter, connectionManager) { 'use strict'; function onGroupedCardClick(e, card) { var itemId = card.getAttribute('data-id'); var serverId = card.getAttribute('data-serverid'); var apiClient = connectionManager.getApiCli...
1
15,407
Why was this changed?
jellyfin-jellyfin-web
js
@@ -98,6 +98,8 @@ class IoUBalancedNegSampler(RandomSampler): floor_set = set() iou_sampling_set = set( np.where(max_overlaps > self.floor_thr)[0]) + # for sampling interval calculation + self.floor_thr == 0 floor_neg_in...
1
import numpy as np import torch from .random_sampler import RandomSampler class IoUBalancedNegSampler(RandomSampler): """IoU Balanced Sampling arXiv: https://arxiv.org/pdf/1904.02701.pdf (CVPR 2019) Sampling proposals according to their IoU. `floor_fraction` of needed RoIs are sampled from proposal...
1
18,323
I think you meant, self.floor_thr = 0
open-mmlab-mmdetection
py
@@ -14,13 +14,12 @@ import ( "github.com/99designs/gqlgen/graphql" "github.com/99designs/gqlgen/graphql/introspection" + "github.com/chaos-mesh/chaos-mesh/api/v1alpha1" + "github.com/chaos-mesh/chaos-mesh/pkg/ctrlserver/graph/model" gqlparser "github.com/vektah/gqlparser/v2" "github.com/vektah/gqlparser/v2/as...
1
// Code generated by github.com/99designs/gqlgen, DO NOT EDIT. package generated import ( "bytes" "context" "errors" "io" "strconv" "sync" "sync/atomic" "time" "github.com/99designs/gqlgen/graphql" "github.com/99designs/gqlgen/graphql/introspection" gqlparser "github.com/vektah/gqlparser/v2" "github.com/...
1
25,818
Can you revert these changes?
chaos-mesh-chaos-mesh
go
@@ -18,10 +18,13 @@ 'use strict'; -import React, { +import React from 'react'; + +import { Component, Navigator, - StatusBarIOS, + Platform, + StatusBar, Text, TouchableOpacity, View,
1
//////////////////////////////////////////////////////////////////////////// // // Copyright 2016 Realm Inc. // // Licensed under the Apache License, Version 2.0 (the "License"); // you may not use this file except in compliance with the License. // You may obtain a copy of the License at // // http://www.apache.org/li...
1
15,396
Do we need to change this?
realm-realm-js
js
@@ -104,14 +104,12 @@ func setKernelMemory(path string, kernelMemoryLimit uint64) error { } func setMemoryAndSwap(path string, cgroup *configs.Cgroup) error { - ulimited := -1 - - // If the memory update is set to uint64(-1) we should also - // set swap to uint64(-1), it means unlimited memory. - if cgroup.Resource...
1
// +build linux package fs import ( "bufio" "fmt" "io/ioutil" "os" "path/filepath" "strconv" "strings" "syscall" "github.com/opencontainers/runc/libcontainer/cgroups" "github.com/opencontainers/runc/libcontainer/configs" ) const ( cgroupKernelMemoryLimit = "memory.kmem.limit_in_bytes" cgroupMemorySwapLi...
1
14,635
With this commit, `MemoryUnlimited` is defined as a `unit64`, so I think you can drop the redundant cast from this line (and the later lines which also have `uint64(configs.MemoryUnlimited)`.
opencontainers-runc
go
@@ -7,6 +7,8 @@ function DashboardContentTitle (props) { } function PanelTopBar (props) { + const notOverFileLimit = props.maxNumberOfFiles !== props.totalFileCount + return ( <div class="uppy-DashboardContent-bar"> <button class="uppy-DashboardContent-back"
1
const { h } = require('preact') function DashboardContentTitle (props) { if (props.newFiles.length) { return props.i18n('xFilesSelected', { smart_count: props.newFiles.length }) } } function PanelTopBar (props) { return ( <div class="uppy-DashboardContent-bar"> <button class="uppy-DashboardContent...
1
11,130
`props.totalFileCount < props.maxNumberOfFiles` makes the intent a bit more clear I think. And a check to see if maxNumberOfFiles even exists?
transloadit-uppy
js
@@ -12,7 +12,8 @@ import ( // Flags var ( - epochNum uint64 + epochNum uint64 + nextEpoch bool ) // NodeCmd represents the node command
1
// Copyright (c) 2019 IoTeX // This is an alpha (internal) release and is not suitable for production. This source code is provided 'as is' and no // warranties are given as to title or non-infringement, merchantability or fitness for purpose and, to the extent // permitted by law, all liability for your use of the cod...
1
16,899
`epochNum` is a global variable (from `gochecknoglobals`)
iotexproject-iotex-core
go
@@ -1083,6 +1083,8 @@ angular.module('ui.grid') } else { // otherwise, manually search the oldRows to see if we can find this row newRow = self.getRow(newEntity, oldRows); + } else { + newRow.entity = newEntity; } // if we didn't find the row, it must be new, so cr...
1
(function(){ angular.module('ui.grid') .factory('Grid', ['$q', '$compile', '$parse', 'gridUtil', 'uiGridConstants', 'GridOptions', 'GridColumn', 'GridRow', 'GridApi', 'rowSorter', 'rowSearcher', 'GridRenderContainer', '$timeout','ScrollEvent', function($q, $compile, $parse, gridUtil, uiGridConstants, GridOptions, ...
1
10,831
This needs to be fixed before we can accept the PR
angular-ui-ui-grid
js
@@ -14,6 +14,11 @@ constexpr double bootstrap_minimum_termination_time_sec = 30.0; constexpr unsigned bootstrap_max_new_connections = 10; constexpr unsigned bulk_push_cost_limit = 200; +size_t constexpr nano::frontier_req::size; +size_t constexpr nano::bulk_pull_blocks::size; +size_t constexpr nano::bulk_pull_accou...
1
#include <nano/node/bootstrap.hpp> #include <nano/node/common.hpp> #include <nano/node/node.hpp> #include <boost/log/trivial.hpp> constexpr double bootstrap_connection_scale_target_blocks = 50000.0; constexpr double bootstrap_connection_warmup_time_sec = 5.0; constexpr double bootstrap_minimum_blocks_per_sec = 10.0;...
1
14,740
Are these forward declarations needed if we `#include <node/common.hpp>` which includes the definition ?
nanocurrency-nano-node
cpp
@@ -76,7 +76,7 @@ func (m *Message) Bytes() []byte { } func (m *Message) String() string { - return fmt.Sprintf("MESSAGE: connectid %v MessageType %s", m.ConnectID, m.MessageType) + return fmt.Sprintf("MESSAGE: ConnectID %v MessageType %s", m.ConnectID, m.MessageType) } func ReadMessageFromTunnel(r io.Reader) (...
1
/* Copyright 2020 The KubeEdge Authors. Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, sof...
1
22,494
can you use either `connectID` or `ConnectID` i would preffer `connectID`
kubeedge-kubeedge
go
@@ -112,6 +112,11 @@ class Shopware6ChannelFormModel */ public array $customField = []; + /** + * @var array|null + */ + public ?array $crossSelling = []; + public function __construct(Shopware6Channel $channel = null) { if ($channel) {
1
<?php /** * Copyright © Bold Brand Commerce Sp. z o.o. All rights reserved. * See LICENSE.txt for license details. */ declare(strict_types=1); namespace Ergonode\ExporterShopware6\Application\Model; use Ergonode\Core\Infrastructure\Validator\Constraint as CoreAssert; use Ergonode\ExporterShopware6\Application\Mod...
1
9,230
It seems like it cannot be null?
ergonode-backend
php
@@ -19,6 +19,7 @@ package azkaban.executor; public class ExecutionReference { private final int execId; private Executor executor; + //Todo jamiesjc: deprecate updateTime in ExecutionReference class gradually. private long updateTime; private long nextCheckTime = -1; private int numErrors = 0;
1
/* * Copyright 2012 LinkedIn Corp. * * Licensed under the Apache License, Version 2.0 (the "License"); you may not * use this file except in compliance with the License. You may obtain a copy of * the License at * * http://www.apache.org/licenses/LICENSE-2.0 * * Unless required by applicable law or agreed to i...
1
13,578
should we consider add deprecated annotation here?
azkaban-azkaban
java
@@ -27,8 +27,8 @@ import ( "golang.org/x/net/context" ) -type createUserFn func(t testing.TB, ith int, config *libkbfs.ConfigLocal, - opTimeout time.Duration) *fsUser +type createUserFn func(t testing.TB, ith int, name libkb.NormalizedUsername, + config *libkbfs.ConfigLocal, opTimeout time.Duration) *fsUser typ...
1
// Copyright 2016 Keybase Inc. All rights reserved. // Use of this source code is governed by a BSD // license that can be found in the LICENSE file. // Without any build tags the tests are run on libkbfs directly. // With the tag dokan all tests are run through a dokan filesystem. // With the tag fuse all tests are r...
1
14,339
Why can't the implementor get the username from the config?
keybase-kbfs
go
@@ -87,7 +87,7 @@ func NewParams(raCtx protocol.RunActionsCtx, execution *action.Execution, stateD BlockNumber: new(big.Int).SetUint64(raCtx.BlockHeight), Time: new(big.Int).SetInt64(raCtx.BlockTimeStamp), Difficulty: new(big.Int).SetUint64(uint64(50)), - GasLimit: raCtx.ActionGasLimit, + GasLimit...
1
// Copyright (c) 2018 IoTeX // This is an alpha (internal) release and is not suitable for production. This source code is provided 'as is' and no // warranties are given as to title or non-infringement, merchantability or fitness for purpose and, to the extent // permitted by law, all liability for your use of the cod...
1
15,260
@CoderZhi Please confirm if this change makes sense
iotexproject-iotex-core
go
@@ -127,6 +127,7 @@ public enum JsonRpcError { PMT_FAILED_INTRINSIC_GAS_EXCEEDS_LIMIT( -50100, "Private Marker Transaction failed due to intrinsic gas exeeding the limit. Gas limit used from the Private Transaction."), + PRIVATE_SUBSCRIPTION_MULTI_TENANCY_ERROR(-50100, "foo."), CANT_CONNECT_TO_LO...
1
/* * Copyright ConsenSys AG. * * Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with * the License. You may obtain a copy of the License at * * http://www.apache.org/licenses/LICENSE-2.0 * * Unless required by applicable law or agreed to in writing...
1
22,512
Do you think you can come up with a better message? :-) It looks like this is not used anywhere. So maybe just delete the line.
hyperledger-besu
java
@@ -1065,11 +1065,7 @@ public interface Traversable<T> extends Foldable<T>, Value<T> { @Override default T reduceLeft(BiFunction<? super T, ? super T, ? extends T> op) { Objects.requireNonNull(op, "op is null"); - if (isEmpty()) { - throw new NoSuchElementException("reduceLeft on Ni...
1
/* __ __ __ __ __ ___ * \ \ / / \ \ / / __/ * \ \/ / /\ \ \/ / / * \____/__/ \__\____/__/.ɪᴏ * ᶜᵒᵖʸʳᶦᵍʰᵗ ᵇʸ ᵛᵃᵛʳ ⁻ ˡᶦᶜᵉⁿˢᵉᵈ ᵘⁿᵈᵉʳ ᵗʰᵉ ᵃᵖᵃᶜʰᵉ ˡᶦᶜᵉⁿˢᵉ ᵛᵉʳˢᶦᵒⁿ ᵗʷᵒ ᵈᵒᵗ ᶻᵉʳᵒ */ package io.vavr.collect...
1
12,360
`tail()` is an expensive operation for certain collections
vavr-io-vavr
java
@@ -86,7 +86,8 @@ var rubyMappings = { 'http_infrastructure':['../../../TestServer/swagger/httpInfrastructure.json','HttpInfrastructureModule'], 'required_optional':['../../../TestServer/swagger/required-optional.json','RequiredOptionalModule'], 'report':['../../../TestServer/swagger/report.json','ReportModule...
1
/// <binding Clean='clean' /> var gulp = require('gulp'), msbuild = require('gulp-msbuild'), debug = require('gulp-debug'), env = require('gulp-env'), path = require('path'), fs = require('fs'), merge = require('merge2'), shell = require('gulp-shell'), glob = require('glob'), spawn = require('child_process').spawn, ass...
1
22,190
do we need to add this one in this PR?
Azure-autorest
java
@@ -223,7 +223,6 @@ namespace Nethermind.State.Test.Runner public void ReportGasUpdateForVmTrace(long refund, long gasAvailable) { - throw new NotImplementedException(); } public void ReportRefundForVmTrace(long refund, long gasAvailable)
1
/* * Copyright (c) 2018 Demerzel Solutions Limited * This file is part of the Nethermind library. * * The Nethermind library is free software: you can redistribute it and/or modify * it under the terms of the GNU Lesser General Public License as published by * the Free Software Foundation, either version 3 of th...
1
24,305
where is a test for it?
NethermindEth-nethermind
.cs
@@ -46,7 +46,7 @@ class Page extends CmsCompoundObject */ public $rules = [ 'title' => 'required', - 'url' => ['required', 'regex:/^\/[a-z0-9\/\:_\-\*\[\]\+\?\|\.\^\\\$]*$/i'] + 'url' => ['required', 'regex:/^\/[a-z0-9\/\:_\-\*\[\]\+\?\|\.\^\\\$]*$/i'] ]; /**
1
<?php namespace Cms\Classes; use Lang; use Cms\Classes\Theme; use Cms\Classes\Layout; use ApplicationException; use October\Rain\Filesystem\Definitions as FileDefinitions; /** * The CMS page class. * * @package october\cms * @author Alexey Bobkov, Samuel Georges */ class Page extends CmsCompoundObject { /** ...
1
12,958
Why has this spacing been adjusted?
octobercms-october
php
@@ -90,10 +90,15 @@ class PipelineBuilder(object): raise api_errors.ApiInitializationError(e) api_version = self.api_map.get(api_name).get('version') - if api_version is None: - api = api_class() - else: - api = api_class(version=api_ve...
1
# Copyright 2017 Google Inc. # # Licensed under the Apache License, Version 2.0 (the "License"); # you may not use this file except in compliance with the License. # You may obtain a copy of the License at # # http://www.apache.org/licenses/LICENSE-2.0 # # Unless required by applicable law or agreed to in writing, s...
1
26,323
Sorry to do this, since you're touching this file can you resolve the pylint doc messages above?
forseti-security-forseti-security
py
@@ -81,7 +81,7 @@ class BigQueryWriter(object): } bq_data.append({ 'json': row, - 'insertId': "%s-%s" % (listen['user_name'], listen['listened_at']) + 'insertId': "%s-%s-%s" % (listen['user_name'], listen['listened_at'], listen['recording_msid']) ...
1
#!/usr/bin/env python3 import sys import os import ujson import json import logging import pika from time import time, sleep import listenbrainz.config as config from redis import Redis from googleapiclient import discovery from googleapiclient.errors import HttpError from oauth2client.client import GoogleCredentials...
1
14,454
@alastair, because the `insertId` for two listens with different metadata and same ts was the same, only one of them would get written into BQ. A question is what would be the ideal way to write tests for stuff like this, so that this doesn't break again?
metabrainz-listenbrainz-server
py
@@ -1883,7 +1883,7 @@ UDS_RDBI.dataIdentifiers[0x4080] = "AirbagLock_NEU" UDS_RDBI.dataIdentifiers[0x4140] = "BodyComConfig" UDS_RDBI.dataIdentifiers[0x4ab4] = "Betriebsstundenzaehler" UDS_RDBI.dataIdentifiers[0x5fc2] = "WDBI_DME_ABGLEICH_PROG_REQ" -UDS_RDBI.dataIdentifiers[0xd114] = "Gesamtweg-Streckenzähler Offset...
1
# This file is part of Scapy # See http://www.secdev.org/projects/scapy for more information # Copyright (C) Nils Weiss <nils@we155.de> # This program is published under a GPLv2 license # scapy.contrib.description = BMW specific definitions for UDS # scapy.contrib.status = loads from scapy.packet import Packet, bind...
1
20,125
Wondering where this breaks btw (although pretty understandable)
secdev-scapy
py
@@ -64,6 +64,7 @@ public class Spark3BinPackStrategy extends BinPackStrategy { Dataset<Row> scanDF = cloneSession.read().format("iceberg") .option(SparkReadOptions.FILE_SCAN_TASK_SET_ID, groupID) .option(SparkReadOptions.SPLIT_SIZE, splitSize(inputFileSize(filesToRewrite))) + .opti...
1
/* * Licensed to the Apache Software Foundation (ASF) under one * or more contributor license agreements. See the NOTICE file * distributed with this work for additional information * regarding copyright ownership. The ASF licenses this file * to you under the Apache License, Version 2.0 (the * "License"); you ...
1
43,717
is this needed? 10 is already the default
apache-iceberg
java
@@ -35,9 +35,13 @@ class TextPlot(ElementPlot): data = dict(x=[element.x], y=[element.y]) self._categorize_data(data, ('x', 'y'), element.dimensions()) data['text'] = [element.text] - style['text_align'] = element.halign + if 'text_align' not in style: + style['te...
1
from collections import defaultdict import numpy as np from bokeh.models import Span, Arrow try: from bokeh.models.arrow_heads import TeeHead, NormalHead arrow_start = {'<->': NormalHead, '<|-|>': NormalHead} arrow_end = {'->': NormalHead, '-[': TeeHead, '-|>': NormalHead, '-': None} excep...
1
20,336
One day we can try to allow the user to specify font sizes in something other than points. For now this is fine though...
holoviz-holoviews
py
@@ -29,7 +29,13 @@ namespace rtps { WriterProxyData::WriterProxyData() +#if HAVE_SECURITY + : security_attributes_(0) + , plugin_security_attributes_(0) + , m_userDefinedId(0) +#else : m_userDefinedId(0) +#endif , m_typeMaxSerialized(0) , m_isAlive(true) , m_topicKind(NO_KEY)
1
// Copyright 2016 Proyectos y Sistemas de Mantenimiento SL (eProsima). // // Licensed under the Apache License, Version 2.0 (the "License"); // you may not use this file except in compliance with the License. // You may obtain a copy of the License at // // http://www.apache.org/licenses/LICENSE-2.0 // // Unless re...
1
13,000
duplicated in both block of preprocessor condition. Can you join in one?
eProsima-Fast-DDS
cpp
@@ -50,9 +50,10 @@ function getXPathArray(node, path) { var element = {}; element.str = node.nodeName.toLowerCase(); // add the id and the count so we can construct robust versions of the xpath - if(node.getAttribute && node.getAttribute('id') && - node.ownerDocument.querySelectorAll('#' + axe.utils.escapeS...
1
/*global axe */ //jshint maxstatements: false, maxcomplexity: false function getXPathArray(node, path) { var sibling, count; // Gets an XPath for an element which describes its hierarchical location. if(!node) { return []; } if (!path && node.nodeType === 9) { // special case for when we are called and give t...
1
11,200
Can we put the first part of the expression inline with the `if(` for consistency's sake?
dequelabs-axe-core
js
@@ -26,9 +26,15 @@ import "github.com/yarpc/yarpc-go/transport" type CallReqMeta interface { Procedure(string) CallReqMeta Headers(Headers) CallReqMeta + ShardKey(string) CallReqMeta + RoutingKey(string) CallReqMeta + RoutingDelegate(string) CallReqMeta GetProcedure() string GetHeaders() Headers + GetShardKe...
1
// Copyright (c) 2016 Uber Technologies, Inc. // // Permission is hereby granted, free of charge, to any person obtaining a copy // of this software and associated documentation files (the "Software"), to deal // in the Software without restriction, including without limitation the rights // to use, copy, modify, merge...
1
10,572
Do servers have no need of accessing this information?
yarpc-yarpc-go
go
@@ -51,7 +51,7 @@ // @vue/component var commonFormattersMixin = { methods: { - formatTimeAgo: countlyCommon.formatTimeAgo, + formatTimeAgo: countlyCommon.formatTimeAgoText, formatNumber: countlyCommon.formatNumber, getShortNumber: countlyCommon.getShort...
1
/* global countlyCommon, jQuery, Vue, Vuex, T, countlyView, Promise, VueCompositionAPI, app, countlyGlobal */ (function(countlyVue, $) { // @vue/component var autoRefreshMixin = { mounted: function() { var self = this; this.$root.$on("cly-refresh", function() { ...
1
14,171
It feels like this will break some stuff, but let it break. We need "text" version anyway.
Countly-countly-server
js
@@ -717,7 +717,7 @@ static ItemExpr *intersectColumns(const RETDesc &leftTable, ItemExpr *leftExpr = leftTable.getValueId(i).getItemExpr(); ItemExpr *rightExpr = rightTable.getValueId(i).getItemExpr(); BiRelat *compare = new (bindWA->wHeap()) - BiRelat(ITM_EQUAL, leftExpr, rightExpr); + BiRela...
1
/********************************************************************** // @@@ START COPYRIGHT @@@ // // Licensed to the Apache Software Foundation (ASF) under one // or more contributor license agreements. See the NOTICE file // distributed with this work for additional information // regarding copyright ownership. ...
1
13,151
Here are two things I wonder: First, would it make sense to replace the TRUE here with "leftExpr->getValueId().getType().supportsSQLnull() && rightExpr->getValueId().getType().supportsSQLnull()". I'm not sure we have optimizations elsewhere that set the "special nulls" semantics back to FALSE if one of the operands it ...
apache-trafodion
cpp
@@ -267,7 +267,8 @@ T *LookupTableByName(const SymbolTable<T> &table, const std::string &name, TD(StringConstant, 257, "string constant") \ TD(IntegerConstant, 258, "integer constant") \ TD(FloatConstant, 259, "float constant") \ - TD(Identifier, 260, "identifier") + TD(NumericConstant, 260, "nan, inf or fun...
1
/* * Copyright 2014 Google Inc. All rights reserved. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. * You may obtain a copy of the License at * * http://www.apache.org/licenses/LICENSE-2.0 * * Unless required by applica...
1
20,503
This will cause someone writing a schema field like `inf:string` to get a pretty confusing error? If they intended to use `inf` as short for `information` or whatever :) Might it be better to keep it as `Identifier` and explicitly recognize the few identifiers we care about only when parsing values (not while parsing f...
google-flatbuffers
java
@@ -46,7 +46,7 @@ export function generateRandomHexString(length: number = 8) { export function signPayload(payload: JWTPayload, secret: string, options: JWTSignOptions) { return jwt.sign(payload, secret, { - notBefore: '1000', // Make sure the time will not rollback :) + notBefore: '1', // Make sure the ti...
1
// @flow import {createDecipher, createCipher, createHash, pseudoRandomBytes} from 'crypto'; import jwt from 'jsonwebtoken'; import type {JWTPayload, JWTSignOptions} from '../../types'; export const defaultAlgorithm = 'aes192'; export function aesEncrypt(buf: Buffer, secret: string): Buffer { const c = createCiphe...
1
18,855
Mmm .... this affect #168 I'll need to research the collateral damage
verdaccio-verdaccio
js
@@ -268,7 +268,7 @@ func checkSrvRecord(dnsBootstrap string) { func doDeleteDNS(network string, noPrompt bool, excludePattern string) bool { - if network == "" || network == "testnet" || network == "devnet" || network == "mainnet" { + if network == "" || network == "testnet" || network == "devnet" || network == "m...
1
// Copyright (C) 2019 Algorand, Inc. // This file is part of go-algorand // // go-algorand is free software: you can redistribute it and/or modify // it under the terms of the GNU Affero General Public License as // published by the Free Software Foundation, either version 3 of the // License, or (at your option) any l...
1
35,964
nit: refactor into a const map lookup.
algorand-go-algorand
go
@@ -26,7 +26,7 @@ namespace MvvmCross.Forms.Droid.Views { BindingContext = new MvxAndroidBindingContext(this, this); this.AddEventListeners(); - _resourceAssembly = Assembly.GetCallingAssembly(); + _resourceAssembly = this.GetType().Assembly; } ...
1
using System.Reflection; using Android.Content; using Android.OS; using Android.Util; using Android.Views; using MvvmCross.Binding.BindingContext; using MvvmCross.Binding.Droid.BindingContext; using MvvmCross.Binding.Droid.Views; using MvvmCross.Core.ViewModels; using MvvmCross.Droid.Platform; using MvvmCross.Droid.Sup...
1
13,532
I don't think this is going to work. We need to get the actual assembly of the app project. @johnnywebb thoughts?
MvvmCross-MvvmCross
.cs
@@ -306,7 +306,7 @@ def get_kbr_keys(kb_name, searchkey="", searchvalue="", searchtype='s'): searchvalue, searchtype) def get_kbr_values(kb_name, searchkey="", searchvalue="", searchtype='s', - use_memoise=False): + use_memoize=False):...
1
# -*- coding: utf-8 -*- ## ## This file is part of Invenio. ## Copyright (C) 2009, 2010, 2011, 2013 CERN. ## ## Invenio is free software; you can redistribute it and/or ## modify it under the terms of the GNU General Public License as ## published by the Free Software Foundation; either version 2 of the ## License, or ...
1
11,601
@MSusik be careful about changing existing API. I think in this case you shouldn't rename the argument.
inveniosoftware-invenio
py
@@ -176,8 +176,8 @@ int produce_message(struct flb_time *tm, msgpack_object *map, /* Add extracted topic on the fly to topiclist */ if (ctx->dynamic_topic) { /* Only if default topic is set and this topicname is not set for this message */ - if (...
1
/* -*- Mode: C; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */ /* Fluent Bit * ========== * Copyright (C) 2019-2020 The Fluent Bit Authors * Copyright (C) 2015-2018 Treasure Data Inc. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in co...
1
11,546
This is bad. It is not a NULL-terminated string here.
fluent-fluent-bit
c
@@ -48,9 +48,10 @@ class UserIpReader protected $server; /** - * Should we respect the X-Forwarded-For header? + * Configuration specifying allowed HTTP headers containing IPs (false for none). + * See [Proxy] allow_forwarded_ips setting in config.ini for more details. * - * @var bool ...
1
<?php /** * Service to retrieve user IP address. * * PHP version 7 * * Copyright (C) Villanova University 2020. * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License version 2, * as published by the Free Software Foundation. * * This p...
1
29,879
This probably should be @param string|false.
vufind-org-vufind
php
@@ -195,7 +195,7 @@ public class SmartSqlTest extends SmartStoreTestCase { */ public void testSmartQueryReturningOneRowWithTwoIntegers() throws JSONException { loadData(); - JSONArray result = store.query(QuerySpec.buildSmartQuerySpec("select mgr.{employees:salary}, e.{employees:salary} from {employees} as mgr...
1
/* * Copyright (c) 2012, salesforce.com, inc. * All rights reserved. * Redistribution and use of this software in source and binary forms, with or * without modification, are permitted provided that the following conditions * are met: * - Redistributions of source code must retain the above copyright notice, this...
1
13,873
Unrelated test fix. Already in cordova34 branch.
forcedotcom-SalesforceMobileSDK-Android
java
@@ -87,10 +87,6 @@ func (sc *stakingCommand) CreatePostSystemActions(ctx context.Context, sr protoc } func (sc *stakingCommand) Handle(ctx context.Context, act action.Action, sm protocol.StateManager) (*action.Receipt, error) { - // no height here, v1 v2 has the same validate method, so directly use common one - i...
1
// Copyright (c) 2019 IoTeX Foundation // This is an alpha (internal) release and is not suitable for production. This source code is provided 'as is' and no // warranties are given as to title or non-infringement, merchantability or fitness for purpose and, to the extent // permitted by law, all liability for your use...
1
21,659
validate() will be called by either V1 or V2
iotexproject-iotex-core
go
@@ -100,6 +100,13 @@ class CppGenerator : public BaseGenerator { assert(!cur_name_space_); + code_ += "#if defined(_MSC_VER)"; + code_ += "#define NOEXCEPT"; + code_ += "#else"; + code_ += "#define NOEXCEPT noexcept"; + code_ += "#endif"; + code_ += ""; + // Generate forward declarations...
1
/* * Copyright 2014 Google Inc. All rights reserved. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. * You may obtain a copy of the License at * * http://www.apache.org/licenses/LICENSE-2.0 * * Unless required by applica...
1
11,540
rather than generate code for this every time, stick it in `flatbuffers.h` (and call it `FLATBUFFERS_NOEXCEPT` to avoid clashes).
google-flatbuffers
java
@@ -14,7 +14,9 @@ import ( // GetBlockByNumber see https://github.com/ethereum/wiki/wiki/JSON-RPC#eth_getblockbynumber // see internal/ethapi.PublicBlockChainAPI.GetBlockByNumber func (api *APIImpl) GetBlockByNumber(ctx context.Context, number rpc.BlockNumber, fullTx bool) (map[string]interface{}, error) { - tx, err...
1
package commands import ( "context" "fmt" "github.com/ledgerwatch/turbo-geth/common" "github.com/ledgerwatch/turbo-geth/common/hexutil" "github.com/ledgerwatch/turbo-geth/core/rawdb" "github.com/ledgerwatch/turbo-geth/rpc" "github.com/ledgerwatch/turbo-geth/turbo/adapter/ethapi" ) // GetBlockByNumber see http...
1
21,891
@AskAlexSharov @tjayrush , I'm still feeling uncomfortable with this change: - because it works by accident. For example in next lines `tx` object used as: `ReadBlockByNumber(tx)`. If you go inside `ReadBlockByNumber` you can find `!errors.Is(err, ethdb.ErrKeyNotFound)` - but ethdb.Tx doesn't return this error - and it...
ledgerwatch-erigon
go
@@ -159,3 +159,4 @@ def createTemporalAnomaly(recordParams, spatialParams=_SP_PARAMS, temporalPoolerRegion.setParameter("anomalyMode", True) return network +
1
#!/usr/bin/env python # ---------------------------------------------------------------------- # Numenta Platform for Intelligent Computing (NuPIC) # Copyright (C) 2015, Numenta, Inc. Unless you have an agreement # with Numenta, Inc., for a separate license for this software code, the # following terms and conditions ...
1
18,778
I think this means the file doesn't have a newline character at the end.
numenta-nupic
py
@@ -469,6 +469,15 @@ fpga_result fpgaPerfCounterGet(fpga_token token, fpga_perf_counter *fpga_perf) memset(fpga_perf, 0, sizeof(fpga_perf_counter)); + //check if its being run as root or not + uid_t uid = getuid(); + if (uid != 0) { + fpga_perf->previlege = false; + return FPGA_OK; + } else { + fpga_perf->prev...
1
// Copyright(c) 2021, Intel Corporation // // Redistribution and use in source and binary forms, with or without // modification, are permitted provided that the following conditions are met: // // * Redistributions of source code must retain the above copyright notice, // this list of conditions and the ...
1
20,838
Hi Ramya, rather than checking here in the perf counter library, we should add the privilege check in the host_exerciser app.
OPAE-opae-sdk
c
@@ -20,7 +20,9 @@ class TrackedObject: """ def __del__(self): - notifyObjectDeletion(self) + # notifyObjectDeletion could be None if Python is shutting down. + if notifyObjectDeletion: + notifyObjectDeletion(self) _collectionThreadID = 0
1
# -*- coding: UTF-8 -*- # A part of NonVisual Desktop Access (NVDA) # Copyright (C) 2020 NV Access Limited # This file is covered by the GNU General Public License. # See the file COPYING for more details. import gc import threading from logHandler import log """ Watches Python's cyclic garbage collector ...
1
31,729
Could you elaborate on this some more? Has this behavior changed with Python 3.8?
nvaccess-nvda
py
@@ -89,7 +89,10 @@ const logReqMsg = `DEBUG: Request %s/%s Details: func logRequest(r *request.Request) { logBody := r.Config.LogLevel.Matches(aws.LogDebugWithHTTPBody) - dumpedBody, _ := httputil.DumpRequestOut(r.HTTPRequest, logBody) + dumpedBody, err := httputil.DumpRequestOut(r.HTTPRequest, logBody) + if err !...
1
package client import ( "fmt" "io/ioutil" "net/http/httputil" "github.com/aws/aws-sdk-go/aws" "github.com/aws/aws-sdk-go/aws/client/metadata" "github.com/aws/aws-sdk-go/aws/request" ) // A Config provides configuration to a service client instance. type Config struct { Config *aws.Config Han...
1
8,254
Do we want to continue on logging the `dumpedBody`, if an error was thrown? It is probably an empty string. This would make the log after this one pretty much useless.
aws-aws-sdk-go
go
@@ -1,6 +1,7 @@ <fieldset class="annotation_fields" id="<%= unique_dom_id(f.object, "fields") %>"> <div class="form-group col-md-10"> - <%= f.label(:type, f.object.type.humanize, class: "control-label") %> + <% lbl = f.object.type.humanize.downcase == 'example answer' ? _('Example answer') : _('Guidance') %> ...
1
<fieldset class="annotation_fields" id="<%= unique_dom_id(f.object, "fields") %>"> <div class="form-group col-md-10"> <%= f.label(:type, f.object.type.humanize, class: "control-label") %> <div data-toggle="tooltip" title="<%= tooltip_for_annotation_text(f.object) %>"> <em class="sr-only"><%= tooltip_for...
1
18,439
the text here is derived from the object type and not getting properly handled by get text
DMPRoadmap-roadmap
rb
@@ -27,10 +27,13 @@ const ( var ( // runtimeMode tells which mode antctl is running against. runtimeMode string + inPod bool ) func init() { - if strings.HasPrefix(os.Getenv("POD_NAME"), "antrea-agent") { + podName, found := os.LookupEnv("POD_NAME") + inPod = found && (strings.HasPrefix(podName, "antrea-...
1
// Copyright 2020 Antrea Authors // // Licensed under the Apache License, Version 2.0 (the "License"); // you may not use this file except in compliance with the License. // You may obtain a copy of the License at // // http://www.apache.org/licenses/LICENSE-2.0 // // Unless required by applicable law or agreed to ...
1
15,833
This will make other pods that run antctl will also connect its localhost? Maybe only do it when it's in antrea-agent and antrea-controller
antrea-io-antrea
go
@@ -168,9 +168,6 @@ define(["jQuery", "globalize", "scripts/taskbutton", "dom", "libraryMenu", "layo }), menuItems.push({ name: "Xml TV", id: "xmltv" - }), menuItems.push({ - name: globalize.translate("ButtonOther"), - id: "other" }), require(["ac...
1
define(["jQuery", "globalize", "scripts/taskbutton", "dom", "libraryMenu", "layoutManager", "loading", "listViewStyle", "flexStyles", "emby-itemscontainer", "cardStyle", "material-icons", "emby-button"], function($, globalize, taskButton, dom, libraryMenu, layoutManager, loading) { "use strict"; function getDe...
1
11,662
The corresponding action for this key needs to be removed as well, along with any unused translations.
jellyfin-jellyfin-web
js
@@ -48,15 +48,15 @@ namespace Datadog.Trace.ClrProfiler.AutoInstrumentation.AWS.SQS var requestProxy = request.DuckCast<ISendMessageBatchRequest>(); - var scope = AwsSqsCommon.CreateScope(Tracer.Instance, Operation, out AwsSqsTags tags); + var scope = AwsSqsCommon.CreateScope(Trac...
1
// <copyright file="SendMessageBatchAsyncIntegration.cs" company="Datadog"> // Unless explicitly stated otherwise all files in this repository are licensed under the Apache 2 License. // This product includes software developed at Datadog (https://www.datadoghq.com/). Copyright 2017 Datadog, Inc. // </copyright> using...
1
24,081
Can't Span cannot be null anymore? I assume it was a useless check as there are discrepencies within integrations, but as you explicitly removed this one, I was wondering
DataDog-dd-trace-dotnet
.cs
@@ -210,7 +210,7 @@ namespace Nethermind.JsonRpc.Modules.Trace Block block = blockSearch.Object; - ParityLikeTxTrace txTrace = TraceTx(block, txHash, ParityTraceTypes.Trace | ParityTraceTypes.Rewards); + ParityLikeTxTrace txTrace = TraceTx(block, txHash, ParityTraceTypes.Trace); ...
1
// Copyright (c) 2021 Demerzel Solutions Limited // This file is part of the Nethermind library. // // The Nethermind library is free software: you can redistribute it and/or modify // it under the terms of the GNU Lesser General Public License as published by // the Free Software Foundation, either version 3 of ...
1
26,145
hmmm, ok, this is interesting -> Lukasz definitely uses rewards traces
NethermindEth-nethermind
.cs
@@ -78,6 +78,9 @@ public class TableProperties { public static final String SPLIT_OPEN_FILE_COST = "read.split.open-file-cost"; public static final long SPLIT_OPEN_FILE_COST_DEFAULT = 4 * 1024 * 1024; // 4MB + public static final String SPLIT_BY_PARTITION = "read.split.by-partition"; + public static final boo...
1
/* * Licensed to the Apache Software Foundation (ASF) under one * or more contributor license agreements. See the NOTICE file * distributed with this work for additional information * regarding copyright ownership. The ASF licenses this file * to you under the Apache License, Version 2.0 (the * "License"); you ...
1
34,209
Why do we need this flag? can this be detected if the table is bucketed/partitioned and enabled/disabled automatically? Is this for backwards compatibility?
apache-iceberg
java
@@ -188,7 +188,7 @@ bool is_name_type(const char* name) { if(*name == '$') name++; - + if(*name == '_') name++;
1
#include "ponyassert.h" #include "id.h" #include "id_internal.h" bool check_id(pass_opt_t* opt, ast_t* id_node, const char* desc, int spec) { pony_assert(id_node != NULL); pony_assert(ast_id(id_node) == TK_ID); pony_assert(desc != NULL); const char* name = ast_name(id_node); pony_assert(name != NULL); ch...
1
13,816
can you revert changes to this file.
ponylang-ponyc
c
@@ -2,6 +2,8 @@ // Use of this source code is governed by a BSD-style // license that can be found in the LICENSE file. +// Package soc provides the single-owner chunk implemenation +// and validator. package soc import (
1
// Copyright 2020 The Swarm Authors. All rights reserved. // Use of this source code is governed by a BSD-style // license that can be found in the LICENSE file. package soc import ( "bytes" "errors" "fmt" "github.com/ethersphere/bee/pkg/bmtpool" "github.com/ethersphere/bee/pkg/crypto" "github.com/ethersphere/...
1
13,700
suggestion to add: An soc is a chunks whose address is derived of (...)
ethersphere-bee
go
@@ -110,6 +110,8 @@ export const API_ERROR = { DEPRECATED_BASIC_HEADER: 'basic authentication is deprecated, please use JWT instead', BAD_FORMAT_USER_GROUP: 'user groups is different than an array', RESOURCE_UNAVAILABLE: 'resource unavailable', + USERNAME_PASSWORD_REQUIRED: 'username and password is required'...
1
/** * @prettier */ // @flow export const DEFAULT_PORT: string = '4873'; export const DEFAULT_PROTOCOL: string = 'http'; export const DEFAULT_DOMAIN: string = 'localhost'; export const TIME_EXPIRATION_24H: string = '24h'; export const TIME_EXPIRATION_7D: string = '7d'; export const DIST_TAGS = 'dist-tags'; export c...
1
19,492
It doesn't make sense. if we are going to have the profile page where the user can change the password and he / she is already logged in ... I do not need to register a new username. only: new password..confirm new password..something similar...and "USERNAME_ALREADY_REGISTERED" only if I have a register page..are we go...
verdaccio-verdaccio
js
@@ -747,14 +747,14 @@ namespace Nethermind.State _needsStateRootUpdate = false; } - public void CommitTree() + public void CommitTree(long blockNumber) { if (_needsStateRootUpdate) { RecalculateStateRoot(); } - ...
1
// Copyright (c) 2018 Demerzel Solutions Limited // This file is part of the Nethermind library. // // The Nethermind library is free software: you can redistribute it and/or modify // it under the terms of the GNU Lesser General Public License as published by // the Free Software Foundation, either version 3 of ...
1
24,272
not a great fan of this change - maybe worth splitting into CommitTree() and CloseBlock(long blockNumber)?
NethermindEth-nethermind
.cs
@@ -65,7 +65,9 @@ namespace Microsoft.AspNetCore.Connections public CancellationToken ConnectionClosed { get; set; } - public virtual void Abort() + public void Abort() => Abort(abortReason: null); + + public virtual void Abort(ConnectionAbortedException abortReason) { ...
1
// Copyright (c) .NET Foundation. All rights reserved. // Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information. using System; using System.Collections.Generic; using System.IO.Pipelines; using System.Security.Claims; using System.Threading; using Microsoft.AspNetC...
1
15,815
Ugh, if we're going to make a breaking change, I'd like this to be moved to ConnectionContext.
aspnet-KestrelHttpServer
.cs
@@ -1286,6 +1286,12 @@ func NewFs(path string) (Fs, error) { if err != nil { return nil, err } + // TODO: Fix import for rc + // f, err := fsInfo.NewFs(configName, fsPath, config) + // if err != nil && f.reload != nil { + // rc.AddOptionReload(f.name, &f.opt, f.reload) + // } + // return f, err return fsInfo....
1
// Package fs is a generic file system interface for rclone object storage systems package fs import ( "context" "encoding/json" "fmt" "io" "io/ioutil" "log" "math" "os" "path/filepath" "reflect" "sort" "strings" "time" "github.com/pkg/errors" "github.com/rclone/rclone/fs/config/configmap" "github.com...
1
10,912
I was planning to add it as a common option, but there is a cyclic import for the rc & fs libs. Thoughts on avoiding it or should I remove this for now?
rclone-rclone
go
@@ -65,6 +65,10 @@ namespace SynchronizeVersions "src/Datadog.Trace/Datadog.Trace.csproj", NugetVersionReplace); + SynchronizeVersion( + "/deploy/Nuget/Datadog.Trace.nuspec", + NugetVersionReplace); + Console.WriteLine($"Completed...
1
using System; using System.IO; using System.Text; using System.Text.RegularExpressions; using Datadog.Trace.TestHelpers; namespace SynchronizeVersions { public class Program { private static int major = 1; private static int minor = 7; private static int patch = 0; public stati...
1
15,714
I think this entry can be removed now, right?
DataDog-dd-trace-dotnet
.cs
@@ -230,6 +230,18 @@ class Key(object): else: self.encrypted = None + def handle_storage_class_header(self, resp): + provider = self.bucket.connection.provider + if provider.storage_class_header: + self._storage_class = resp.getheader( + provider.storag...
1
# Copyright (c) 2006-2012 Mitch Garnaat http://garnaat.org/ # Copyright (c) 2011, Nexenta Systems Inc. # Copyright (c) 2012 Amazon.com, Inc. or its affiliates. All Rights Reserved # # Permission is hereby granted, free of charge, to any person obtaining a # copy of this software and associated documentation files (the...
1
11,964
I don't understand why you want to populate the storage class in this case, if the S3 docs say they won't populate the header in this case?
boto-boto
py
@@ -47,6 +47,10 @@ public interface CapabilityType { String HAS_TOUCHSCREEN = "hasTouchScreen"; String OVERLAPPING_CHECK_DISABLED = "overlappingCheckDisabled"; String STRICT_FILE_INTERACTABILITY = "strictFileInteractability"; + String TIMEOUTS = "timeouts"; + String IMPLICIT_TIMEOUT = "implicit"; + String P...
1
// Licensed to the Software Freedom Conservancy (SFC) under one // or more contributor license agreements. See the NOTICE file // distributed with this work for additional information // regarding copyright ownership. The SFC licenses this file // to you under the Apache License, Version 2.0 (the // "License"); you m...
1
19,072
These are really meant to be the keys in the capabilities, not the keys of values within the capabilities
SeleniumHQ-selenium
java
@@ -14,8 +14,11 @@ import ( // // The request will not be signed, and will not use your AWS credentials. // -// A "NotFound" error code will be returned if the bucket does not exist in -// the AWS partition the regionHint belongs to. +// A "NotFound" error code will be returned if the bucket does not exist in the +/...
1
package s3manager import ( "github.com/aws/aws-sdk-go/aws" "github.com/aws/aws-sdk-go/aws/client" "github.com/aws/aws-sdk-go/aws/credentials" "github.com/aws/aws-sdk-go/aws/request" "github.com/aws/aws-sdk-go/service/s3" "github.com/aws/aws-sdk-go/service/s3/s3iface" ) // GetBucketRegion will attempt to get the...
1
9,116
Should the last sentence be `If no region was found` rather than `specified`?
aws-aws-sdk-go
go
@@ -217,9 +217,16 @@ public class CoxPlugin extends Plugin { for (Player player : client.getPlayers()) { - if (player.getName().equals(tpMatcher.group(1))) + final String rawPlayerName = player.getName(); + + if (rawPlayerName != null) { - victims.add(new Victim(player, Victim.Type....
1
/* * Copyright (c) 2019, xzact <https://github.com/xzact> * Copyright (c) 2019, ganom <https://github.com/Ganom> * Copyright (c) 2019, gazivodag <https://github.com/gazivodag> * Copyright (c) 2019, lyzrds <https://discord.gg/5eb9Fe> * All rights reserved. * * Redistribution and use in source and binary forms, wi...
1
15,811
Text.sanitize just removes images from names, for instance, the hardcore ironman symbol when someone talks. A better option would be text.standardize, or text.toJagexName
open-osrs-runelite
java
@@ -81,3 +81,13 @@ func (a *Application) IsOutOfSync() bool { func IsApplicationConfigFile(filename string) bool { return filename == DefaultApplicationConfigFilename || strings.HasSuffix(filename, applicationConfigFileExtention) } + +func ToApplicationKind(kind string) (ApplicationKind, bool) { + upper := strings....
1
// Copyright 2020 The PipeCD Authors. // // Licensed under the Apache License, Version 2.0 (the "License"); // you may not use this file except in compliance with the License. // You may obtain a copy of the License at // // http://www.apache.org/licenses/LICENSE-2.0 // // Unless required by applicable law or agree...
1
23,462
How about `ApplicationKindFromConfigKind`? And I think this function should be better in the config package. The reason is `config` package can import and refer things from the model package but not vice versa.
pipe-cd-pipe
go
@@ -101,9 +101,14 @@ const ( // Options sets options for constructing a *blob.Bucket backed by Azure Block Blob. type Options struct { // Credential represents the authorizer for SignedURL. - // Required to use SignedURL. + // Required to use SignedURL. If you're using MSI for authentication, this will + // attempt...
1
// Copyright 2018 The Go Cloud Development Kit Authors // // Licensed under the Apache License, Version 2.0 (the "License"); // you may not use this file except in compliance with the License. // You may obtain a copy of the License at // // https://www.apache.org/licenses/LICENSE-2.0 // // Unless required by appli...
1
20,259
Nit: missing closing ".".
google-go-cloud
go
@@ -35,3 +35,6 @@ def testCanClickOnALinkThatOverflowsAndFollowIt(driver): def testClickingALinkMadeUpOfNumbersIsHandledCorrectly(driver): driver.find_element(By.LINK_TEXT, "333333").click() WebDriverWait(driver, 3).until(EC.title_is("XHTML Test Page")) + +def testCannotClickDisabledButton(driver): + WebD...
1
# Licensed to the Software Freedom Conservancy (SFC) under one # or more contributor license agreements. See the NOTICE file # distributed with this work for additional information # regarding copyright ownership. The SFC licenses this file # to you under the Apache License, Version 2.0 (the # "License"); you may not...
1
16,343
I believe it's misleading name for the condition. I prefer "element_to_be_disable" We can have a condition, when element is enabled but we can't click it, because another element overlays above it. So, If we use "unclickable" we might mislead people, who use that condition to verify if element can be clicked
SeleniumHQ-selenium
js
@@ -123,9 +123,9 @@ func CreatePipeline(pipelineName string, provider Provider, stageNames []string) }, nil } -// Marshal serializes the pipeline manifest object into byte array that +// MarshalBinary serializes the pipeline manifest object into byte array that // represents the pipeline.yml document. -func (m *P...
1
// Copyright 2020 Amazon.com, Inc. or its affiliates. All Rights Reserved. // SPDX-License-Identifier: Apache-2.0 package manifest import ( "bytes" "errors" "fmt" "text/template" "github.com/fatih/structs" "gopkg.in/yaml.v3" "github.com/aws/amazon-ecs-cli-v2/templates" ) const ( GithubProviderName = "Gi...
1
11,995
Same here. Should this be pipeline YAML file? Like `MarshalPipelineManifest`
aws-copilot-cli
go
@@ -213,6 +213,9 @@ func (i *Instance) Restart(newCaddyfile Input) (*Instance, error) { } i.Stop() + // Execute instantiation events + EmitEvent(InstanceStartupEvent, newInst) + log.Println("[INFO] Reloading complete") return newInst, nil
1
// Copyright 2015 Light Code Labs, LLC // // Licensed under the Apache License, Version 2.0 (the "License"); // you may not use this file except in compliance with the License. // You may obtain a copy of the License at // // http://www.apache.org/licenses/LICENSE-2.0 // // Unless required by applicable law or agre...
1
11,481
I will add this to my PR
caddyserver-caddy
go
@@ -19,4 +19,8 @@ class RolePolicy < ApplicationPolicy def destroy? @role.plan.owned_by?(@user.id) end + + def archive? + @role.user_id = @user.id + end end
1
class RolePolicy < ApplicationPolicy attr_reader :user attr_reader :role def initialize(user, role) raise Pundit::NotAuthorizedError, "must be logged in" unless user @user = user @role = role end def create? @role.plan.administerable_by?(@user.id) end def update? @role.plan.administ...
1
16,817
Again not 100% sold on the name
DMPRoadmap-roadmap
rb
@@ -226,8 +226,9 @@ func runWeb(ctx *cli.Context) error { m.Group("/user/settings", func() { m.Get("", user.Settings) m.Post("", bindIgnErr(auth.UpdateProfileForm{}), user.SettingsPost) - m.Post("/avatar", binding.MultipartForm(auth.UploadAvatarForm{}), user.SettingsAvatar) + m.Post("/avatar", binding.Multipa...
1
// Copyright 2014 The Gogs Authors. All rights reserved. // Use of this source code is governed by a MIT-style // license that can be found in the LICENSE file. package cmd import ( "crypto/tls" "fmt" "io/ioutil" "net/http" "net/http/fcgi" "os" "path" "strings" "github.com/codegangsta/cli" "github.com/go-m...
1
11,577
Use `m.Combo` for `Get` and `Post` methods.
gogs-gogs
go
@@ -446,6 +446,13 @@ class DownloadItem(QObject): # The file already exists, so ask the user if it should be # overwritten. self._ask_overwrite_question() + # FIFO, device node, etc. Don't even try. + elif (os.path.exists(self._filename) and not + os.p...
1
# vim: ft=python fileencoding=utf-8 sts=4 sw=4 et: # Copyright 2014-2015 Florian Bruhin (The Compiler) <mail@qutebrowser.org> # # This file is part of qutebrowser. # # qutebrowser is free software: you can redistribute it and/or modify # it under the terms of the GNU General Public License as published by # the Free S...
1
13,168
Is there a reason you're not using `self._die("The file {} ...")` here?
qutebrowser-qutebrowser
py
@@ -13,7 +13,7 @@ import ( // LocalDevExecCmd allows users to execute arbitrary bash commands within a container. var LocalDevExecCmd = &cobra.Command{ - Use: "exec [app_name] [environment_name] '[cmd]'", + Use: "exec '[cmd]'", Short: "run a command in an app container.", Long: `Execs into container and ru...
1
package cmd import ( "fmt" "log" "path" "strings" "github.com/drud/ddev/pkg/plugins/platform" "github.com/drud/drud-go/utils/dockerutil" "github.com/spf13/cobra" ) // LocalDevExecCmd allows users to execute arbitrary bash commands within a container. var LocalDevExecCmd = &cobra.Command{ Use: "exec [app_na...
1
10,695
I think we'll want @rickmanelius (or somebody) to go through all the help and make it more accessible. Probably later in the cycle. But "Run a command in an app container" doesn't do it for me :)
drud-ddev
go
@@ -8,6 +8,10 @@ import ( . "github.com/weaveworks/weave/common" ) +var ( + weaveWaitEntrypoint = []string{"/home/weavewait/weavewait"} +) + func callWeave(args ...string) ([]byte, error) { args = append([]string{"--local"}, args...) Debug.Print("Calling weave", args)
1
package proxy import ( "os/exec" "strings" "github.com/fsouza/go-dockerclient" . "github.com/weaveworks/weave/common" ) func callWeave(args ...string) ([]byte, error) { args = append([]string{"--local"}, args...) Debug.Print("Calling weave", args) cmd := exec.Command("./weave", args...) cmd.Env = []string{"P...
1
8,693
shouldn't this be a const?
weaveworks-weave
go
@@ -135,10 +135,7 @@ class MongoDBMochaReporter extends mocha.reporters.Spec { timestamp = timestamp ? timestamp.toISOString().split('.')[0] : ''; output.testSuites.push({ - package: - suite.file.includes('functional') || suite.file.includes('integration') - ? 'Funct...
1
//@ts-check 'use strict'; const mocha = require('mocha'); const chalk = require('chalk'); chalk.level = 3; const { EVENT_RUN_BEGIN, EVENT_RUN_END, EVENT_TEST_FAIL, EVENT_TEST_PASS, EVENT_SUITE_BEGIN, EVENT_SUITE_END, EVENT_TEST_PENDING, EVENT_TEST_BEGIN, EVENT_TEST_END } = mocha.Runner.constants; c...
1
21,921
This is a bit of a throwaway field in the xunit output, it doesn't impact anything on EVG, should we just name it `integration` now?
mongodb-node-mongodb-native
js
@@ -29,6 +29,6 @@ import java.lang.annotation.Target; @Documented @Retention(SOURCE) @Target(TYPE) -public @interface SolrSingleThreaded { +public @interface SolrThreadUnsafe { }
1
/* * Licensed to the Apache Software Foundation (ASF) under one or more * contributor license agreements. See the NOTICE file distributed with * this work for additional information regarding copyright ownership. * The ASF licenses this file to You under the Apache License, Version 2.0 * (the "License"); you may ...
1
36,353
Please change the name of the file too.
apache-lucene-solr
java
@@ -286,7 +286,7 @@ func inject(args []string) string { func init() { flag := injectCmd.Flags() - flag.StringVar(&injectCfg.configPath, "injector-config-path", "./tools/actioninjector/gentsfaddrs.yaml", "path of config file of genesis transfer addresses") + flag.StringVar(&injectCfg.configPath, "injector-config-pa...
1
// Copyright (c) 2018 IoTeX // This is an alpha (internal) release and is not suitable for production. This source code is provided 'as is' and no // warranties are given as to title or non-infringement, merchantability or fitness for purpose and, to the extent // permitted by law, all liability for your use of the cod...
1
15,590
line is 161 characters (from `lll`)
iotexproject-iotex-core
go
@@ -195,8 +195,10 @@ module Bolt @outputter.stop_spin # Automatically generate types after installing modules - @outputter.print_action_step("Generating type references") - @pal.generate_types(cache: true) + if ok + @outputter.print_action_step("Generating type references") + ...
1
# frozen_string_literal: true require 'bolt/error' require 'bolt/logger' require 'bolt/module_installer/installer' require 'bolt/module_installer/puppetfile' require 'bolt/module_installer/resolver' require 'bolt/module_installer/specs' module Bolt class ModuleInstaller def initialize(outputter, pal) @out...
1
17,487
When is this false?
puppetlabs-bolt
rb
@@ -540,7 +540,6 @@ Dispose() [InlineData("${counter}", DbType.Int16, (short)1)] [InlineData("${counter}", DbType.Int32, 1)] [InlineData("${counter}", DbType.Int64, (long)1)] - [InlineData("${counter}", DbType.Int16, (short)1)] [InlineData("${counter:norawvalue=true}", DbType....
1
// // Copyright (c) 2004-2019 Jaroslaw Kowalski <jaak@jkowalski.net>, Kim Christensen, Julian Verdurmen // // All rights reserved. // // Redistribution and use in source and binary forms, with or without // modification, are permitted provided that the following conditions // are met: // // * Redistributions of s...
1
18,947
note: also here ;)
NLog-NLog
.cs
@@ -145,6 +145,10 @@ public class TemporaryFilesystem { } public boolean deleteBaseDir() { - return baseDir.delete(); + boolean wasDeleted = baseDir.delete(); + if (wasDeleted) { + Runtime.getRuntime().removeShutdownHook(shutdownHook); + } + return wasDeleted; } }
1
// Licensed to the Software Freedom Conservancy (SFC) under one // or more contributor license agreements. See the NOTICE file // distributed with this work for additional information // regarding copyright ownership. The SFC licenses this file // to you under the Apache License, Version 2.0 (the // "License"); you m...
1
13,021
I don't think we need to necessarily check if that returned true or not, we should just remove the shutdown hook. Since nothing would check or do anything with this flag anyways.
SeleniumHQ-selenium
js
@@ -38,10 +38,15 @@ const kytheExtractionConfigFile = ".kythe-extraction-config" // Repo is a container of input/output parameters for doing extraction on remote // repositories. type Repo struct { - // Clone extracts a copy of the repo to the specified output Directory. - Clone func(ctx context.Context, outputDir s...
1
/* * Copyright 2018 Google Inc. All rights reserved. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. * You may obtain a copy of the License at * * http://www.apache.org/licenses/LICENSE-2.0 * * Unless required by applicabl...
1
8,478
nit: blank between, for consistency.
kythe-kythe
go
@@ -21,8 +21,10 @@ import java.util.regex.Matcher; /** Utility class for formatting source comments to follow RDoc style. */ public class RDocCommentFixer { - /** Returns a Sphinx-formatted comment string. */ + /** Returns a RDoc-formatted comment string. */ public static String rdocify(String comment) { + ...
1
/* Copyright 2016 Google Inc * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. * You may obtain a copy of the License at * * http://www.apache.org/licenses/LICENSE-2.0 * * Unless required by applicable law or agreed to in ...
1
19,424
ditto for RDoc or YARD link
googleapis-gapic-generator
java