patch stringlengths 17 31.2k | y int64 1 1 | oldf stringlengths 0 2.21M | idx int64 1 1 | id int64 4.29k 68.4k | msg stringlengths 8 843 | proj stringclasses 212
values | lang stringclasses 9
values |
|---|---|---|---|---|---|---|---|
@@ -173,7 +173,7 @@ public class DefaultConditionRunner implements ConditionRunner {
}
protected void log(String message) {
- logger.info(new Date() + " - " + message);
+ logger.finest(new Date() + " - " + message);
}
} | 1 | // Licensed to the Software Freedom Conservancy (SFC) under one
// or more contributor license agreements. See the NOTICE file
// distributed with this work for additional information
// regarding copyright ownership. The SFC licenses this file
// to you under the Apache License, Version 2.0 (the
// "License"); you m... | 1 | 16,441 | This method is designed to allow the condition runner to tell users something interesting. The current `INFO` log level is correct. | SeleniumHQ-selenium | js |
@@ -36,7 +36,7 @@ type Info struct {
SSLRequired bool `json:"ssl_required"` // DEPRECATED: ssl json used for older clients
TLSRequired bool `json:"tls_required"`
TLSVerify bool `json:"tls_verify"`
- MaxPayload int `json:"max_payload"`
+ MaxPayload int64 `json:... | 1 | // Copyright 2012-2016 Apcera Inc. All rights reserved.
package server
import (
"bufio"
"crypto/tls"
"encoding/json"
"flag"
"fmt"
"io/ioutil"
"net"
"net/http"
"os"
"runtime"
"strconv"
"strings"
"sync"
"time"
// Allow dynamic profiling.
_ "net/http/pprof"
"github.com/nats-io/gnatsd/util"
)
// Info ... | 1 | 7,133 | Again, would not change that. | nats-io-nats-server | go |
@@ -98,4 +98,16 @@ public enum Status {
return false;
}
}
+
+ public static boolean isStatusFailed(Status status) {
+ switch (status) {
+ case FAILED:
+ case KILLED:
+ case CANCELLED:
+ case FAILED_FINISHING:
+ return true;
+ default:
+ return false;
+ }
+ }... | 1 | /*
* Copyright 2014 LinkedIn Corp.
*
* Licensed under the Apache License, Version 2.0 (the "License"); you may not
* use this file except in compliance with the License. You may obtain a copy of
* the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to i... | 1 | 12,346 | Is canceled considered failed? | azkaban-azkaban | java |
@@ -300,7 +300,7 @@ func TestBrowseJson(t *testing.T) {
req.Header.Set("Accept", "application/json")
rec := httptest.NewRecorder()
- code, err := b.ServeHTTP(rec, req)
+ code, _ := b.ServeHTTP(rec, req)
if code != http.StatusOK {
t.Fatalf("In test %d: Wrong status, expected %d, got %d", i, http.Statu... | 1 | package browse
import (
"encoding/json"
"net/http"
"net/http/httptest"
"net/url"
"os"
"path/filepath"
"sort"
"testing"
"text/template"
"time"
"github.com/mholt/caddy/caddyhttp/httpserver"
)
func TestSort(t *testing.T) {
// making up []fileInfo with bogus values;
// to be used to make up our "listing"
f... | 1 | 8,966 | These ineffectual assignment changes intrigue me. Our CI tests have been checking for these for months; how come the tests haven't been failing? How did you catch these? | caddyserver-caddy | go |
@@ -103,10 +103,15 @@ func TestMintX509CA(t *testing.T) {
wrapper := Wrap(upstreamCA)
// Request Mint to wrapper
- resp, err := wrapper.MintX509CA(ctx, &MintX509CARequest{
+ stream, err := wrapper.MintX509CA(ctx, &MintX509CARequest{
Csr: testCase.csr,
PreferredTtl: testCase.preferredTTL... | 1 | package upstreamauthority
import (
"context"
"encoding/pem"
"errors"
"testing"
"github.com/spiffe/spire/pkg/server/plugin/upstreamca"
"github.com/spiffe/spire/test/spiretest"
"github.com/stretchr/testify/require"
"google.golang.org/grpc/codes"
)
var (
ctx = context.Background()
ca1 = pemBytes([]byte(`-----... | 1 | 12,991 | We should add an additional call to Recv() somewhere after here that we assert returns io.EOF. | spiffe-spire | go |
@@ -35,7 +35,8 @@ func setupJournalBlockServerTest(t *testing.T) (
// Clean up the config if the rest of the setup fails.
defer func() {
if !setupSucceeded {
- CheckConfigAndShutdown(t, config)
+ ctx := context.Background()
+ CheckConfigAndShutdown(ctx, t, config)
}
}()
| 1 | // Copyright 2016 Keybase Inc. All rights reserved.
// Use of this source code is governed by a BSD
// license that can be found in the LICENSE file.
package libkbfs
import (
"os"
"testing"
"github.com/keybase/client/go/protocol/keybase1"
"github.com/keybase/kbfs/ioutil"
"github.com/keybase/kbfs/tlf"
"github.c... | 1 | 15,020 | Why not return a `ctx` from `setupJournalBlockServerTest` and use it everywhere, like in the other test files? And maybe put a test timeout on it while you're at it? (Same for the other journal test files below.) | keybase-kbfs | go |
@@ -33,7 +33,17 @@
// ObjectTracker undestroyed objects validation function
-bool ObjectLifetimes::ReportUndestroyedObjects(VkDevice device, const std::string& error_code) {
+bool ObjectLifetimes::ReportUndestroyedInstanceObjects(VkInstance instance, const std::string& error_code) {
+ bool skip = false;
+ sk... | 1 | // *** THIS FILE IS GENERATED - DO NOT EDIT ***
// See object_tracker_generator.py for modifications
/***************************************************************************
*
* Copyright (c) 2015-2019 The Khronos Group Inc.
* Copyright (c) 2015-2019 Valve Corporation
* Copyright (c) 2015-2019 LunarG, Inc.
*... | 1 | 11,765 | Do we need HeadlessSurface and DisplayPlaneSurface here too? | KhronosGroup-Vulkan-ValidationLayers | cpp |
@@ -473,7 +473,7 @@ describe('GridFS Stream', function () {
// Fail if user tries to abort an aborted stream
uploadStream.abort().then(null, function (error) {
expect(error.toString()).to.equal(
- 'MongoDriverError: Cannot call abor... | 1 | 'use strict';
const { Double } = require('bson');
const stream = require('stream');
const { EJSON } = require('bson');
const fs = require('fs');
const { setupDatabase, withClient } = require('./shared');
const { expect } = require('chai');
const { GridFSBucket, ObjectId } = require('../../src');
describe('GridFS Stre... | 1 | 20,700 | Would it be appropriate for this to be a `MongoStreamClosedError`? | mongodb-node-mongodb-native | js |
@@ -26,11 +26,13 @@ import (
"github.com/golang/glog"
"github.com/openebs/maya/pkg/apis/openebs.io/v1alpha1"
clientset "github.com/openebs/maya/pkg/client/generated/clientset/internalclientset"
+ snapclient "github.com/openebs/maya/pkg/client/generated/openebs.io/snapshot/v1/clientset/internalclientset"
"k8s.io... | 1 | /*
Copyright 2019 The OpenEBS Authors.
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, sof... | 1 | 12,113 | Can you raise new issue that talks about refactoring webhook code. It should follow `idiomatic maya` patterns. | openebs-maya | go |
@@ -0,0 +1,9 @@
+using Datadog.Trace.Interfaces;
+
+namespace Datadog.Trace.ClrProfiler.Interfaces
+{
+ internal interface ISpanDecorator
+ {
+ void Decorate(ISpan span);
+ }
+} | 1 | 1 | 14,665 | (Probably repeating myself) Instead of `Datadog.Trace.Interfaces`, should we move this and several other files into a `Datadog.Trace.Decorators` namespace instead? | DataDog-dd-trace-dotnet | .cs | |
@@ -1,6 +1,7 @@
# -*- encoding : utf-8 -*-
require 'kaminari'
require 'rsolr'
+require 'deprecation'
module Blacklight
autoload :Configurable, 'blacklight/configurable' | 1 | # -*- encoding : utf-8 -*-
require 'kaminari'
require 'rsolr'
module Blacklight
autoload :Configurable, 'blacklight/configurable'
autoload :Configuration, 'blacklight/configuration'
autoload :SearchFields, 'blacklight/search_fields'
autoload :Solr, 'blacklight/solr'
autoload :SolrHelper, 'blacklight/solr... | 1 | 5,639 | Should we generate `gem "rsolr"` into the application Gemfile? | projectblacklight-blacklight | rb |
@@ -130,6 +130,8 @@ static struct optparse_option attach_opts[] = {
{ .name = "label-io", .key = 'l', .has_arg = 0,
.usage = "Label output by rank",
},
+ { .name = "verbose", .key = 'v', .has_arg = 0,
+ .usage = "Increase verbosity" },
{ .name = "quiet", .key = 'q', .has_arg = 0,
.... | 1 | /************************************************************\
* Copyright 2018 Lawrence Livermore National Security, LLC
* (c.f. AUTHORS, NOTICE.LLNS, COPYING)
*
* This file is part of the Flux resource manager framework.
* For details, see https://github.com/flux-framework.
*
* SPDX-License-Identifier: LGPL-3.... | 1 | 25,942 | commit message, "currently ignored"? (-ed) | flux-framework-flux-core | c |
@@ -37,6 +37,12 @@ module Selenium
def bridge_class
Bridge
end
+
+ def print_page(**options)
+ options[:page_ranges] &&= Array(options[:page_ranges])
+
+ bridge.print_page(options)
+ end
end # Driver
end # Firefox
end # WebDriver | 1 | # frozen_string_literal: true
# Licensed to the Software Freedom Conservancy (SFC) under one
# or more contributor license agreements. See the NOTICE file
# distributed with this work for additional information
# regarding copyright ownership. The SFC licenses this file
# to you under the Apache License, Version 2.0... | 1 | 18,368 | Same here. and all others. | SeleniumHQ-selenium | py |
@@ -25,14 +25,16 @@ namespace Nethermind.Blockchain
public class OneTimeChainProcessor : IBlockchainProcessor
{
private readonly IBlockchainProcessor _processor;
+ private readonly IBlockchainProcessor _mainChainProcessor;
private readonly IReadOnlyDbProvider _readOnlyDbProvider;
... | 1 | // Copyright (c) 2018 Demerzel Solutions Limited
// This file is part of the Nethermind library.
//
// The Nethermind library is free software: you can redistribute it and/or modify
// it under the terms of the GNU Lesser General Public License as published by
// the Free Software Foundation, either version 3 of ... | 1 | 23,055 | can we pass some simple interface instead of a full additional processor? (an imterface with these two events only) | NethermindEth-nethermind | .cs |
@@ -107,6 +107,8 @@ insert_exit_stub_other_flags(dcontext_t *dcontext, fragment_t *f,
/* FIXME i#1575: coarse-grain NYI on ARM */
ASSERT_NOT_IMPLEMENTED(!TEST(FRAG_COARSE_GRAIN, f->flags));
if (LINKSTUB_DIRECT(l_flags)) {
+ /* We put a NOP here for future linking. */
+ *pc++ = 0xd503201f;
... | 1 | /* **********************************************************
* Copyright (c) 2014-2017 Google, Inc. All rights reserved.
* Copyright (c) 2016 ARM Limited. All rights reserved.
* **********************************************************/
/*
* Redistribution and use in source and binary forms, with or without
* ... | 1 | 11,680 | Use a named constant | DynamoRIO-dynamorio | c |
@@ -56,7 +56,7 @@ namespace Microsoft.AspNetCore.Server.Kestrel.FunctionalTests
var stop = Assert.Single(events, e => e.EventName == "ConnectionStop");
Assert.All(new[] { "connectionId" }, p => Assert.Contains(p, stop.PayloadNames));
- Assert.Same(KestrelEventSource.Log, stop.Even... | 1 | // Copyright (c) .NET Foundation. All rights reserved.
// Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.
using System;
using System.Collections.Concurrent;
using System.Collections.Generic;
using System.Diagnostics.Tracing;
using System.Linq;
using System.... | 1 | 12,412 | The `?` is unnecessary since `Assert.Single` will fail if it can't find the stop event. | aspnet-KestrelHttpServer | .cs |
@@ -29,6 +29,12 @@ import org.apache.iceberg.StructLike;
* Implementations must be {@link Serializable} because instances will be serialized to tasks.
*/
public interface LocationProvider extends Serializable {
+
+ /**
+ * Return a fully-qualified data location.
+ */
+ String dataLocation();
+
/**
* R... | 1 | /*
* Licensed to the Apache Software Foundation (ASF) under one
* or more contributor license agreements. See the NOTICE file
* distributed with this work for additional information
* regarding copyright ownership. The ASF licenses this file
* to you under the Apache License, Version 2.0 (the
* "License"); you ... | 1 | 18,984 | What about providers that don't have a reliable location? Do they return null? | apache-iceberg | java |
@@ -14,9 +14,14 @@
// limitations under the License.
// </copyright>
+using System;
+
namespace OpenTelemetry.Metrics
{
public abstract class MetricProcessor : BaseProcessor<MetricItem>
{
+ // GetMetric or GetMemoryState or GetAggregatedMetrics..
+ // ...or some other names
+ public... | 1 | // <copyright file="MetricProcessor.cs" company="OpenTelemetry Authors">
// Copyright The OpenTelemetry Authors
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache... | 1 | 20,580 | I might not be thinking about things right, but would it make sense for a MetricProcessor to have a handle on the ParentProvider kinda like how we do for traces? That way instead of calling `SetGetMetricFunction(this.Collect)` in the MeterProviderSdk you'd have a handle on the provider to call `Collect` directly. | open-telemetry-opentelemetry-dotnet | .cs |
@@ -30,7 +30,8 @@ def check_dynamodb(expect_shutdown=False, print_error=False):
# wait for backend port to be opened
wait_for_port_open(PORT_DYNAMODB_BACKEND, http_path="/", expect_success=False, sleep_time=1)
# check DynamoDB
- out = aws_stack.connect_to_service("dynamodb").list_table... | 1 | import logging
import os
import traceback
from localstack import config
from localstack.constants import MODULE_MAIN_PATH
from localstack.services import install
from localstack.services.dynamodb import dynamodb_listener
from localstack.services.infra import do_run, log_startup_message, start_proxy_for_service
from lo... | 1 | 13,243 | nit: If we want to squeeze out a few more milliseconds from the startup, we may actually be able to remove this line (`wait_for_port_open(PORT_DYNAMODB_BACKEND, http_path="/", ...` should already be sufficient to ensure that the service is up and responding to HTTP requests). Thoughts? | localstack-localstack | py |
@@ -4880,7 +4880,7 @@ os_normalized_sysnum(int num_raw, instr_t *gateway, dcontext_t *dcontext)
}
}
# ifdef X64
- if (num_raw >> 24 == 0x2)
+ if (num_raw & SYSCALL_NUM_MARKER_BSD)
return (int)(num_raw & 0xffffff); /* Drop BSD bit */
else
num = (int)num_raw; /* Keep Mach an... | 1 | /* *******************************************************************************
* Copyright (c) 2010-2021 Google, Inc. All rights reserved.
* Copyright (c) 2011 Massachusetts Institute of Technology All rights reserved.
* Copyright (c) 2000-2010 VMware, Inc. All rights reserved.
* ****************************... | 1 | 25,793 | Convention is to use TEST | DynamoRIO-dynamorio | c |
@@ -38,9 +38,9 @@ class TemporalMemoryCompatibilityTest(unittest.TestCase):
"""
- @unittest.skip("There are slight differences between implementations that"
- "prevent this from passing still. See "
- "https://github.com/numenta/nupic/issues/2980")
+ # @unittest.skip("There are ... | 1 | #!/usr/bin/env python
# ----------------------------------------------------------------------
# Numenta Platform for Intelligent Computing (NuPIC)
# Copyright (C) 2016, Numenta, Inc. Unless you have an agreement
# with Numenta, Inc., for a separate license for this software code, the
# following terms and conditions ... | 1 | 21,224 | Just in case: remember to remove this. | numenta-nupic | py |
@@ -61,7 +61,7 @@ public class EIP1559 {
final BigInteger target = BigInteger.valueOf(targetGasUsed);
final BigInteger denominator = BigInteger.valueOf(feeMarket.getBasefeeMaxChangeDenominator());
feeDelta = pBaseFee.multiply(gDelta).divide(target).divide(denominator).longValue();
- baseFee = ... | 1 | /*
* Copyright ConsenSys AG.
*
* Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with
* the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing... | 1 | 25,507 | I am not certain if this should be 0 or 7 here. I think a basefee under 7 is pathological | hyperledger-besu | java |
@@ -20,6 +20,12 @@ vm[] = {
.0002908882086657216,
.0000048481368110953599
};
+/* byte sequence for Degree Sign U+00B0 in UTF-8. */
+ static constexpr char
+DEG_SIGN1 = '\xc2';
+ static constexpr char
+DEG_SIGN2 = '\xb0';
+
double
dmstor(const char *is, char **rs) {
return dmstor_ctx( pj_get_default_ctx(), is,... | 1 | /* Convert DMS string to radians */
#include <ctype.h>
#include <math.h>
#include <stdlib.h>
#include <string.h>
#include "proj.h"
#include "proj_internal.h"
static double proj_strtod(char *nptr, char **endptr);
/* following should be sufficient for all but the ridiculous */
#define MAX_WORK 64
static const char
*... | 1 | 12,684 | it would be better to move the declaration of the variable with its initialization at line 68 | OSGeo-PROJ | cpp |
@@ -12,6 +12,7 @@
defined in: Hall and Kier JCICS _35_ 1039-1045 (1995) Table 1
"""
+import sys
from rdkit import Chem
_rawD = [ | 1 | # $Id$
#
# Copyright (C) 2002-2006 greg Landrum and Rational Discovery LLC
#
# @@ All Rights Reserved @@
# This file is part of the RDKit.
# The contents are covered by the terms of the BSD license
# which is included in the file license.txt, found at the root
# of the RDKit source tree.
#
""" contains SMARTS d... | 1 | 24,026 | I don't think this is required. | rdkit-rdkit | cpp |
@@ -48,7 +48,7 @@ func TestSyncServiceContextUpdated(t *testing.T) {
}
// run the update context call once
- err := service.updateContext()
+ err := service.updateEthContext()
if err != nil {
t.Fatal(err)
} | 1 | package rollup
import (
"context"
"errors"
"fmt"
"math/big"
"reflect"
"testing"
"github.com/ethereum/go-ethereum/common"
"github.com/ethereum/go-ethereum/consensus/ethash"
"github.com/ethereum/go-ethereum/core"
"github.com/ethereum/go-ethereum/core/rawdb"
"github.com/ethereum/go-ethereum/core/types"
"gith... | 1 | 14,999 | This rename should also ideally be in a separate PR. | ethereum-optimism-optimism | go |
@@ -86,11 +86,14 @@ public final class HttpCall<V> extends Call.Base<V> {
if (t != null) {
callback.onError(t);
} else {
+ V value = null;
try {
- callback.onSuccess(parseResponse(response, bodyConverter));
- } catch (IOException e) {
- callback.onError(e)... | 1 | /*
* Copyright 2015-2019 The OpenZipkin Authors
*
* Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except
* in compliance with the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or a... | 1 | 15,316 | Think this needs to go right below line 91. `parseResponse` can return `null` (line 133), which will cause this future to never complete. | openzipkin-zipkin | java |
@@ -46,8 +46,8 @@ import java.util.List;
public class HttpCommandProcessor implements CommandProcessor {
private String pathToServlet;
- private String browserStartCommand;
- private String browserURL;
+ private final String browserStartCommand;
+ private final String browserURL;
private String sessionId;
... | 1 | // Licensed to the Software Freedom Conservancy (SFC) under one
// or more contributor license agreements. See the NOTICE file
// distributed with this work for additional information
// regarding copyright ownership. The SFC licenses this file
// to you under the Apache License, Version 2.0 (the
// "License"); you m... | 1 | 19,387 | Can you please revert changes to files in the `thoughtworks` package? This is legacy code and we will eventually phase out RC. | SeleniumHQ-selenium | java |
@@ -520,8 +520,7 @@ public class AzkabanWebServer extends AzkabanServer {
startWebMetrics();
}
- if(this.props.containsKey(ConfigurationKeys.ENABLE_QUARTZ) && this.props.getBoolean(ConfigurationKeys
- .ENABLE_QUARTZ)) {
+ if (this.props.getBoolean(ConfigurationKeys.ENABLE_QUARTZ, false)) {
... | 1 | /*
* Copyright 2012 LinkedIn Corp.
*
* Licensed under the Apache License, Version 2.0 (the "License"); you may not
* use this file except in compliance with the License. You may obtain a copy of
* the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to i... | 1 | 15,135 | Yeah, why not use this method instead of checking with `containsKey`? | azkaban-azkaban | java |
@@ -39,9 +39,9 @@ for i in range(loop_num):
torch.cuda.synchronize()
time_backward += timer.since_last_check()
bar.update()
-print('\nCARAFE time forward: {} ms/iter | time backward: {} ms/iter'.format(
- (time_forward + 1e-3) * 1e3 / loop_num,
- (time_backward + 1e-3) * 1e3 / loop_num))
+print(f'\... | 1 | import os.path as osp
import sys
import mmcv
import torch
from torch.autograd import gradcheck
sys.path.append(osp.abspath(osp.join(__file__, '../../')))
from mmdet.ops.carafe import CARAFE, CARAFENaive # noqa: E402, isort:skip
from mmdet.ops.carafe import carafe, carafe_naive # noqa: E402, isort:skip
feat = torch... | 1 | 19,265 | Compute `(time_forward + 1e-3) * 1e3 / loop_num` ahead. | open-mmlab-mmdetection | py |
@@ -74,18 +74,13 @@ namespace NLog.Internal
throw;
}
- if (LogManager.ThrowExceptions)
- {
- throw;
- }
-
ReportExceptionInHandler(ex);
}
}
private static void Report... | 1 | //
// Copyright (c) 2004-2011 Jaroslaw Kowalski <jaak@jkowalski.net>
//
// All rights reserved.
//
// Redistribution and use in source and binary forms, with or without
// modification, are permitted provided that the following conditions
// are met:
//
// * Redistributions of source code must retain the above c... | 1 | 12,503 | Mh... `MustBeRethrown()` above already logs `ex`, so `ex` will be logged here for the second time. I think this line must be moved to before `MustBeRethrown()`. | NLog-NLog | .cs |
@@ -29,11 +29,13 @@ import java.util.Map;
*/
public class CommonDiscoveryProvider implements DiscoveryProvider {
private final DiscoveryContext context;
- private final SnippetSetRunner<Method> snippetSetRunner;
+ private final SnippetSetRunner.Generator<Method> snippetSetRunner;
private final String snippet... | 1 | /* Copyright 2016 Google Inc
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in ... | 1 | 15,783 | Since this never changes, why not pass it into the constructor instead? | googleapis-gapic-generator | java |
@@ -48,10 +48,10 @@ namespace Nethermind.Synchronization.BeamSync
private readonly ISyncModeSelector _syncModeSelector;
- private readonly Func<bool> _writeThrough;
-
private ILogger _logger;
+ private IDb _targetDbForSaves;
+
public BeamSyncDb(IDb stateDb, IDb tempDb, ISy... | 1 | // Copyright (c) 2018 Demerzel Solutions Limited
// This file is part of the Nethermind library.
//
// The Nethermind library is free software: you can redistribute it and/or modify
// it under the terms of the GNU Lesser General Public License as published by
// the Free Software Foundation, either version 3 of ... | 1 | 23,711 | this is critical to avoid state root saving from beam | NethermindEth-nethermind | .cs |
@@ -231,7 +231,8 @@ class AnchorHead(nn.Module):
# map up to original set of anchors
if unmap_outputs:
num_total_anchors = flat_anchors.size(0)
- labels = unmap(labels, num_total_anchors, inside_flags)
+ labels = unmap(labels, num_total_anchors, inside_flags,
+ ... | 1 | import torch
import torch.nn as nn
from mmcv.cnn import normal_init
from mmdet.core import (anchor_inside_flags, build_anchor_generator,
build_assigner, build_bbox_coder, build_sampler,
force_fp32, images_to_levels, multi_apply,
multiclass_nms, un... | 1 | 19,315 | To make it more clear, `fill=self.num_classes`. | open-mmlab-mmdetection | py |
@@ -78,6 +78,11 @@ type Message struct {
AfterSend func(asFunc func(interface{}) bool) error
}
+// Implement batcher item for byte sized based batching
+func (m *Message) ByteSize() int {
+ return len(m.Body)
+}
+
// Topic publishes messages.
// Drivers may optionally also implement io.Closer; Close will be call... | 1 | // Copyright 2018 The Go Cloud Development Kit Authors
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// https://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by appli... | 1 | 20,569 | Nit: "ByteSize estimates the size in bytes of the message for the purpose of restricting batch sizes." | google-go-cloud | go |
@@ -61,9 +61,11 @@ namespace SampleApp
// The following section should be used to demo sockets
//options.ListenUnixSocket("/tmp/kestrel-test.sock");
-
+ })
+ .UseLibuv(options =>
+ {
// Uncomment the following ... | 1 | // Copyright (c) .NET Foundation. All rights reserved.
// Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.
using System;
using System.IO;
using System.Net;
using System.Threading.Tasks;
using Microsoft.AspNetCore.Builder;
using Microsoft.AspNetCore.Hosting;
u... | 1 | 12,314 | It's weird to have this on the same level as kestrel. This needs to move to options. | aspnet-KestrelHttpServer | .cs |
@@ -476,7 +476,11 @@ module.exports = class Webcam extends Plugin {
}
getVideo () {
- const mimeType = this.recordingChunks[0].type
+ // Sometimes in iOS Safari, Blobs (especially the first Blob in the recordingChunks Array)
+ // have empty 'type' attributes (e.g. '') so we need to find a Blob that has... | 1 | const { h } = require('preact')
const { Plugin } = require('@uppy/core')
const Translator = require('@uppy/utils/lib/Translator')
const getFileTypeExtension = require('@uppy/utils/lib/getFileTypeExtension')
const mimeTypes = require('@uppy/utils/lib/mimeTypes')
const canvasToBlob = require('@uppy/utils/lib/canvasToBlob... | 1 | 13,942 | is it safe for us to use the `blob.type?.length` optional chaining with IE11 support? @goto-bus-stop | transloadit-uppy | js |
@@ -125,13 +125,14 @@ class User < ActiveRecord::Base
# @param new_organisation_id [Integer] the id for an organisation
# @return [String] the empty string as a causality of setting api_token
def org_id=(new_org_id)
+ puts "$$$$ new_org_id: #{new_org_id}"
unless self.can_change_org? || new_org_id.nil? ... | 1 | class User < ActiveRecord::Base
include ConditionalUserMailer
##
# Devise
# Include default devise modules. Others available are:
# :token_authenticatable, :confirmable,
# :lockable, :timeoutable and :omniauthable
devise :invitable, :database_authenticatable, :registerable, :recoverable,
:r... | 1 | 17,420 | remove this debug statement | DMPRoadmap-roadmap | rb |
@@ -2357,7 +2357,12 @@ bool StatelessValidation::manual_PreCallValidateCmdCopyImage(VkCommandBuffer com
VkImageAspectFlags legal_aspect_flags =
VK_IMAGE_ASPECT_COLOR_BIT | VK_IMAGE_ASPECT_DEPTH_BIT | VK_IMAGE_ASPECT_STENCIL_BIT | VK_IMAGE_ASPECT_METADATA_BIT;
- if (device_extensions.vk_khr_sampler_yc... | 1 | /* Copyright (c) 2015-2019 The Khronos Group Inc.
* Copyright (c) 2015-2019 Valve Corporation
* Copyright (c) 2015-2019 LunarG, Inc.
* Copyright (C) 2015-2019 Google Inc.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You m... | 1 | 9,947 | This should not be needed. 1) all 1.1 promoted extensions are marked as enabled when a 1.1 device is created (which happens iff both physical device support and apiVersion are set to 1.1) 2) The KHR and non-KHR versions of the bits are aliases of each other, so no different set is required. | KhronosGroup-Vulkan-ValidationLayers | cpp |
@@ -656,7 +656,11 @@ static void makeflow_node_complete(struct dag *d, struct dag_node *n, struct bat
struct list *outputs = makeflow_generate_output_files(n, wrapper, monitor);
- if(info->exited_normally && info->exit_code == 0) {
+
+ if(getenv("CCTOOLS_LOOP_DEV_FULL")) {
+ job_failed = 1;
+ }
+ else if(info->e... | 1 | /*
Copyright (C) 2008- The University of Notre Dame
This software is distributed under the GNU General Public License.
See the file COPYING for details.
*/
#include "auth_all.h"
#include "auth_ticket.h"
#include "batch_job.h"
#include "cctools.h"
#include "copy_stream.h"
#include "debug.h"
#include "getopt_aux.h"
#inc... | 1 | 12,829 | I can see why you did it this way, but let's not get into the habit of passing information back via an environment variable. Add an element to `batch_job_info` instead, which is where we send back detailed info about jobs. | cooperative-computing-lab-cctools | c |
@@ -438,7 +438,11 @@ function diffElementNodes(
if (
'value' in newProps &&
(i = newProps.value) !== undefined &&
- i !== dom.value
+ // #2756 For the <progress>-element the initial value is 0,
+ // despite the attribute not being present. When the attribute
+ // is missing the progress bar is... | 1 | import { EMPTY_OBJ, EMPTY_ARR } from '../constants';
import { Component } from '../component';
import { Fragment } from '../create-element';
import { diffChildren, placeChild } from './children';
import { diffProps, setProperty } from './props';
import { assign, removeNode } from '../util';
import options from '../opti... | 1 | 16,163 | Turns out my previous fix of doing `!dom.hasAttribute('value')` is not a good one as it leads to all input values always being updated. The new fix only updates it, despite `dom.value === props.value` when the value is `0` for progress elements. | preactjs-preact | js |
@@ -3,6 +3,7 @@
#include <cmath>
#include <cstdio>
#include <ctime>
+#include <vector>
#include "caffe/common.hpp"
#include "caffe/util/rng.hpp" | 1 | #include <boost/thread.hpp>
#include <glog/logging.h>
#include <cmath>
#include <cstdio>
#include <ctime>
#include "caffe/common.hpp"
#include "caffe/util/rng.hpp"
namespace caffe {
// Make sure each thread can have different values.
static boost::thread_specific_ptr<Caffe> thread_instance_;
Caffe& Caffe::Get() {
... | 1 | 36,629 | Why is this being added here? Is this relevant to these changes? | BVLC-caffe | cpp |
@@ -74,7 +74,7 @@ public class SeleniumServer extends JettyServer {
getClass().getClassLoader())
.asSubclass(Routable.class);
Constructor<? extends Routable> constructor = rcHandler.getConstructor(ActiveSessions.class);
- LOG.info("Bound legacy RC support");
+ LOG.finest("Bound le... | 1 | // Licensed to the Software Freedom Conservancy (SFC) under one
// or more contributor license agreements. See the NOTICE file
// distributed with this work for additional information
// regarding copyright ownership. The SFC licenses this file
// to you under the Apache License, Version 2.0 (the
// "License"); you m... | 1 | 17,125 | This informational message is important to users. Please leave. | SeleniumHQ-selenium | py |
@@ -0,0 +1,4 @@
+All unapproved FY15 credit card funding requests are being cancelled.
+If the need still exists, please submit a new FY16 funding request.
+
+<%= url_for(controller: 'proposals', action: 'show', id: @proposal.id) %> | 1 | 1 | 15,173 | why isn't rubocop failing for single quotes? | 18F-C2 | rb | |
@@ -36,14 +36,10 @@ class StatusAttributeDataSetQueryBuilder extends AbstractAttributeDataSetBuilder
{
$query->addSelect(sprintf(
'(
- SELECT value FROM product_value pv
- JOIN value_translation vt ON vt.value_id = pv.value_id
- WHERE pv.attribute_... | 1 | <?php
/**
* Copyright © Bold Brand Commerce Sp. z o.o. All rights reserved.
* See LICENSE.txt for license details.
*/
declare(strict_types = 1);
namespace Ergonode\Workflow\Infrastructure\Grid\Builder\Query;
use Ergonode\Attribute\Domain\Entity\AbstractAttribute;
use Ergonode\Product\Infrastructure\Grid\Builder\Q... | 1 | 8,896 | Is `WHERE` should `Language` param ? | ergonode-backend | php |
@@ -46,6 +46,7 @@ namespace oneapi::dal::basic_statistics::backend {
namespace de = dal::detail;
namespace be = dal::backend;
namespace pr = dal::backend::primitives;
+namespace ps = oneapi::dal::preview::spmd;
using alloc = sycl::usm::alloc;
| 1 | /*******************************************************************************
* Copyright 2021 Intel Corporation
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.o... | 1 | 32,424 | ps - first letter from preview, when we move it into public it will not be relevant. my suggestion is spmd or ds(distributed) | oneapi-src-oneDAL | cpp |
@@ -1757,7 +1757,18 @@ class Frame(object, metaclass=ABCMeta):
2 6 30 30
3 7 40 50
"""
- return self._apply_series_op(lambda kser: kser._with_new_scol(F.abs(kser.spark.column)))
+
+ def abs(kser):
+ if isinstance(kser.spark.data_type, BooleanType):
+ ... | 1 | #
# Copyright (C) 2019 Databricks, Inc.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to i... | 1 | 17,420 | Hm, should we show pandas' dtype instead of Spark data type? | databricks-koalas | py |
@@ -23,10 +23,13 @@ namespace OpenTelemetry.Metrics
{
/*
Type:
- 0x10: Sum
- 0x20: Gauge
- 0x30: Histogram
- 0x40: Summary (reserved)
+ 0x10 0b00010000: Sum
+ 0x20 0b00100000: Gauge
+ 0x40 0b01000000: Histogram
+ ... | 1 | // <copyright file="MetricType.cs" company="OpenTelemetry Authors">
// Copyright The OpenTelemetry Authors
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/... | 1 | 22,750 | @reyang when exponentialhistogram arrives, we won't have any bits left for it.. unless we take Summary or make this 16 bits instead of current 8 bytes | open-telemetry-opentelemetry-dotnet | .cs |
@@ -2,6 +2,8 @@
class PdoStatement {
/**
+ * @psalm-taint-sink text $class
+ *
* @template T
* @param class-string<T> $class
* @return false|T | 1 | <?php
class PdoStatement {
/**
* @template T
* @param class-string<T> $class
* @return false|T
*/
public function fetchObject($class = "stdclass") {}
}
| 1 | 9,429 | This change is not tested.. I guess this is how these taint-annotations work..? | vimeo-psalm | php |
@@ -485,6 +485,14 @@ class ConfigOverrider(object):
dest.dump()
+ def __apply_mult_override(self, obj, key, replace_value):
+ for k, v in obj.items():
+ if isinstance(v, dict):
+ obj[k] = self.__apply_mult_override(v, key, replace_value)
+ if key in obj:
+ ... | 1 | #! /usr/bin/env python
"""
Copyright 2015 BlazeMeter Inc.
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed ... | 1 | 15,395 | Fails if obj is list. Please fix! | Blazemeter-taurus | py |
@@ -28,5 +28,16 @@ class TestInstanceStatusResponseParsing(unittest.TestCase):
self.assertEqual(all_statuses.next_token, 'page-2')
+ def test_include_all_instances(self):
+ ec2 = EC2Connection(aws_access_key_id='aws_access_key_id',
+ aws_secret_access_key='aws_secret_ac... | 1 | #!/usr/bin/env python
from tests.unit import unittest
from tests.unit import AWSMockServiceTestCase
import mock
from boto.ec2.connection import EC2Connection
INSTANCE_STATUS_RESPONSE = br"""<?xml version="1.0" encoding="UTF-8"?>
<DescribeInstanceStatusResponse xmlns="http://ec2.amazonaws.com/doc/2013-02-01/">
<... | 1 | 10,369 | Could you add an assertion to make sure the `IncludeAllInstances` parameter is actually set and passed to the request? | boto-boto | py |
@@ -79,7 +79,8 @@ def __get_analyzer_version(context, analyzer_config_map):
version = [analyzer_bin, u' --version']
try:
output = subprocess.check_output(shlex.split(' '.join(version)),
- env=check_env)
+ ... | 1 | # -------------------------------------------------------------------------
# The CodeChecker Infrastructure
# This file is distributed under the University of Illinois Open Source
# License. See LICENSE.TXT for details.
# -------------------------------------------------------------------------... | 1 | 10,403 | The name of this argument is not too intuitive. The point is, these kind of subprocess calls will return `str`s in Python2 and 'byte`s in Python3. It would be a lot of work to make CodeChecker handle both `str` and `byte` everywhere. Using the `universal_newlines` argument, we can force Python3 to return text rather th... | Ericsson-codechecker | c |
@@ -63,7 +63,7 @@ func toProtoDomainReplicationConfiguration(in *shared.DomainReplicationConfigura
}
return &common.DomainReplicationConfiguration{
ActiveClusterName: in.GetActiveClusterName(),
- Clusters: toProtoClusterReplicationConfigurations(in.Clusters),
+ Clusters: toProtoClusterReplica... | 1 | // Copyright (c) 2019 Temporal Technologies, Inc.
//
// Permission is hereby granted, free of charge, to any person obtaining a copy
// of this software and associated documentation files (the "Software"), to deal
// in the Software without restriction, including without limitation the rights
// to use, copy, modify, m... | 1 | 9,129 | These `Get`s are just cosmetic changes for consistency. | temporalio-temporal | go |
@@ -55,13 +55,7 @@ def test_read_yaml(tmpdir):
assert parsed_string == parsed_path_obj
-def test_yaml_has_comments(tmpdir):
- no_comments_yaml = """blah: foo\nfizz: boop"""
-
- assert not util.yaml_has_comments(util.read_yaml(no_comments_yaml))
- assert util.yaml_has_comments(util.read_yaml(TEST_YAML)... | 1 | # -*- coding: utf-8 -*-
""" Testing for util.py """
### Python imports
import pathlib
### Third Party imports
import pytest
### Project imports
from quilt3 import util
### Constants
TEST_YAML = """
# This is an arbitrary comment solely for the purposes of testing.
c: the speed of light
d: a programming... | 1 | 18,359 | We should never skip unit tests, but instead fix them. Look at `pytest.raises` for cases where we expect an exception. | quiltdata-quilt | py |
@@ -79,11 +79,15 @@ namespace Microsoft.DotNet.Build.Tasks.Feed
public async Task<bool> PushItemsToFeedAsync(IEnumerable<string> items, bool allowOverwrite)
{
Log.LogMessage(MessageImportance.Low, $"START pushing items to feed");
- Random rnd = new Random();
- try
... | 1 | // Licensed to the .NET Foundation under one or more agreements.
// The .NET Foundation licenses this file to you under the MIT license.
// See the LICENSE file in the project root for more information.
using Microsoft.Build.Framework;
using Microsoft.DotNet.Build.CloudTestTasks;
using Microsoft.WindowsAzure.Storage;... | 1 | 14,115 | Do we need to call ToList here? | dotnet-buildtools | .cs |
@@ -5,5 +5,8 @@ class EpisodesController < ApplicationController
def show
@episode = Episode.find(params[:id])
+ if topic = @episode.topics.first
+ @products = topic.products.ordered
+ end
end
end | 1 | class EpisodesController < ApplicationController
def index
@episodes = Episode.published
end
def show
@episode = Episode.find(params[:id])
end
end
| 1 | 6,637 | I think this can be moved into the model, at the very least, but I also think you might be able to do a has many through. | thoughtbot-upcase | rb |
@@ -785,7 +785,7 @@ public interface Tree<T> extends Traversable<T> {
if (tree.isLeaf()) {
return value;
} else {
- return String.format("(%s %s)", value, tree.getChildren().map(Node::toLispString).mkString(" "));
+ return "(" + value + " " + (tre... | 1 | /* / \____ _ _ ____ ______ / \ ____ __ _______
* / / \/ \ / \/ \ / /\__\/ // \/ \ // /\__\ JΛVΛSLΛNG
* _/ / /\ \ \/ / /\ \\__\\ \ // /\ \ /\\/ \ /__\ \ Copyright 2014-2016 Javaslang, http://javaslang.io
* /___/\_/ \_/\____/\_/ \_/\__\/__/\__\_/ \_// \__/\_____/ ... | 1 | 7,801 | could you please separate computations from string concatenation? | vavr-io-vavr | java |
@@ -216,8 +216,8 @@ namespace Microsoft.Rest.Generator.Tests
var type = clientModel.ModelTypes.First();
- Assert.Equal("code", type.Properties[0].Name);
- Assert.Equal("message", type.Properties[1].Name);
+ Assert.Equal("errorCode", type.Properties[0].Name);
+ ... | 1 | // Copyright (c) Microsoft Corporation. All rights reserved.
// Licensed under the MIT License. See License.txt in the project root for license information.
using System.IO;
using System.Linq;
using Microsoft.Rest.Generator.Ruby.TemplateModels;
using Microsoft.Rest.Modeler.Swagger;
using Xunit;
namespace Microsoft.R... | 1 | 21,657 | @NiklasGustafsson - I had to make these changes for the x-ms-client-name extension tests for java and python. The tests were expecting wire format instead of the client name. Hence modified them appropriately. Let me know what you think ? | Azure-autorest | java |
@@ -59,6 +59,13 @@ static int on_req(h2o_handler_t *_self, h2o_req_t *req)
authority = &self->upstream.authority;
}
+ /* rewrite headers */
+ if (self->config.header_cmds.size != 0) {
+ h2o_headers_command_t *cmd;
+ for (cmd = self->config.header_cmds.entries; cmd->cmd != H2O_HEADERS... | 1 | /*
* Copyright (c) 2014,2015 DeNA Co., Ltd., Masahiro Nagano
*
* Permission is hereby granted, free of charge, to any person obtaining a copy
* of this software and associated documentation files (the "Software"), to
* deal in the Software without restriction, including without limitation the
* rights to use, cop... | 1 | 11,802 | Could we just set the list of header modification commands to `req->overrides` and apply them only when the request is sent upstream in lib/core/proxy.c? The reason I ask is because an upstream server (accessed using the modified headers) might return 399. In such case, the request would be delegated to the next handle... | h2o-h2o | c |
@@ -214,6 +214,12 @@ type Table struct {
// to top-level chains.
insertMode string
+ // Record when we did our most recent updates and refreshes of the table. We use these to
+ // calculate the next time we should force a refresh.
+ lastUpdateTime time.Time
+ lastRefreshTime time.Time
+ refreshInterval time.Dur... | 1 | // Copyright (c) 2016-2017 Tigera, Inc. All rights reserved.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by ... | 1 | 15,090 | Can we rename 'refresh' to 'read' and 'update' to 'write'? Until I had read more of the code below, I couldn't tell the difference between 'update' and 'refresh'. | projectcalico-felix | go |
@@ -76,7 +76,7 @@ export default class VerdaccioProcess implements IServerProcess {
});
this.childFork.on('error', (err) => {
- console.log('error process', err);
+ // console.log('error process', err);
reject([err, this]);
});
| 1 | // @flow
import _ from 'lodash';
import rimRaf from 'rimraf';
import path from 'path';
import {fork} from 'child_process';
import {CREDENTIALS} from '../functional/config.functional';
import {HTTP_STATUS} from '../../src/lib/constants';
import type {IVerdaccioConfig, IServerBridge, IServerProcess} from '../types';
exp... | 1 | 18,484 | can we remove it ? | verdaccio-verdaccio | js |
@@ -228,4 +228,17 @@ NAString ComConvertTrafNameToNativeName(
return convertedName;
}
+NABoolean ComTrafReservedColName(
+ const NAString &colName)
+{
+
+ if ((colName == TRAF_SALT_COLNAME) ||
+ (colName == TRAF_SYSKEY_COLNAME))
+ return TRUE;
+ if ((memcmp(colName.data(), TRAF_DIVISION_COLNAME_PR... | 1 | /* -*-C++-*-
*****************************************************************************
*
* File: ComMisc.cpp
* Description: Miscellaneous global functions
*
*
* Created: 11/07/09
* Language: C++
*
*
// @@@ START COPYRIGHT @@@
//
// Licensed to the Apache Software Foundation (ASF) under o... | 1 | 10,932 | I take it that by the time we get here, colName has already been case-shifted to upper case? | apache-trafodion | cpp |
@@ -126,11 +126,14 @@ func ResponseHeaders(h *map[string]string) CallOption {
return CallOption{func(o *OutboundCall) { o.responseHeaders = h }}
}
-// TODO(abg): Example tests to document the different options
-
-// WithHeader adds a new header to the request.
+// WithHeader adds a new header to the request. Heade... | 1 | // Copyright (c) 2016 Uber Technologies, Inc.
//
// Permission is hereby granted, free of charge, to any person obtaining a copy
// of this software and associated documentation files (the "Software"), to deal
// in the Software without restriction, including without limitation the rights
// to use, copy, modify, merge... | 1 | 12,063 | Super clear desc - thx. | yarpc-yarpc-go | go |
@@ -3551,7 +3551,11 @@ void SwiftASTContext::LoadModule(swift::ModuleDecl *swift_module,
all_dlopen_errors.GetData());
};
- swift_module->collectLinkLibraries(addLinkLibrary);
+ swift_module->forAllVisibleModules(
+ {}, [&](swift::ModuleDecl::ImportedModule import) {
+ import.second->collect... | 1 | //===-- SwiftASTContext.cpp -------------------------------------*- C++ -*-===//
//
// This source file is part of the Swift.org open source project
//
// Copyright (c) 2014 - 2016 Apple Inc. and the Swift project authors
// Licensed under Apache License v2.0 with Runtime Library Exception
//
// See https://swift.org/L... | 1 | 16,513 | Ahh the correct fix is to call `collectLinkLibraries` on the SourceFile being compiled, not the module. Sorry for our mistake! | apple-swift-lldb | cpp |
@@ -64,6 +64,7 @@ func TestConfigDefault(t *testing.T) {
"Default TaskMetadataSteadyStateRate is set incorrectly")
assert.Equal(t, DefaultTaskMetadataBurstRate, cfg.TaskMetadataBurstRate,
"Default TaskMetadataBurstRate is set incorrectly")
+ assert.False(t, cfg.SharedVolumeMatchFullConfig, "Default SharedVolume... | 1 | // +build !windows,unit
// Copyright 2014-2018 Amazon.com, Inc. or its affiliates. All Rights Reserved.
//
// Licensed under the Apache License, Version 2.0 (the "License"). You may
// not use this file except in compliance with the License. A copy of the
// License is located at
//
// http://aws.amazon.com/apache2.0/... | 1 | 20,723 | Can you also modify the `TestEnvironmentConfig` in `config_test.go` to cover this? | aws-amazon-ecs-agent | go |
@@ -120,8 +120,12 @@ public class SalesforceNetworkPlugin extends ForcePlugin {
}
restClient.sendAsync(request, new RestClient.AsyncRequestCallback() {
+ // TODO: Remove onSuccess for 9.0 Release.
@Override
- public void onSuccess(RestRequest re... | 1 | /*
* Copyright (c) 2016-present, salesforce.com, inc.
* All rights reserved.
* Redistribution and use of this software in source and binary forms, with or
* without modification, are permitted provided that the following conditions
* are met:
* - Redistributions of source code must retain the above copyright noti... | 1 | 17,758 | There's no point "deprecating" this interface method (the customer still has to implement the new callback that we have introduced which makes it a breaking change). I'd make an exception and simply rename it to `onResponse`. | forcedotcom-SalesforceMobileSDK-Android | java |
@@ -102,7 +102,7 @@ class ExternalDriverSupplier implements Supplier<WebDriver> {
Optional<Class<? extends Supplier<WebDriver>>> supplierClass = getDelegateClass();
if (supplierClass.isPresent()) {
Class<? extends Supplier<WebDriver>> clazz = supplierClass.get();
- logger.info("Using delegate supp... | 1 | // Licensed to the Software Freedom Conservancy (SFC) under one
// or more contributor license agreements. See the NOTICE file
// distributed with this work for additional information
// regarding copyright ownership. The SFC licenses this file
// to you under the Apache License, Version 2.0 (the
// "License"); you m... | 1 | 16,449 | We chose `info` in the test code for obvious reasons. Changing to `finest` makes debugging harder and noisier. | SeleniumHQ-selenium | js |
@@ -40,6 +40,8 @@ THE SOFTWARE.
#include "hip_hcc_internal.h"
#include "trace_helper.h"
+//TODO Add support for multiple modules
+static std::unordered_map<std::string, uintptr_t> coGlobals;
//TODO Use Pool APIs from HCC to get memory regions.
#include <cassert> | 1 | /*
Copyright (c) 2015 - present Advanced Micro Devices, Inc. All rights reserved.
Permission is hereby granted, free of charge, to any person obtaining a copy
of this software and associated documentation files (the "Software"), to deal
in the Software without restriction, including without limitation the rights
to us... | 1 | 6,466 | I know this is not new here but we need to remove this global or protect access from multiple threads. | ROCm-Developer-Tools-HIP | cpp |
@@ -30,13 +30,13 @@ namespace OpenTelemetry.Trace
/// Enables HttpClient and HttpWebRequest instrumentation.
/// </summary>
/// <param name="builder"><see cref="TracerProviderBuilder"/> being configured.</param>
- /// <param name="configureHttpClientInstrumentationOptions">HttpClient c... | 1 | // <copyright file="TracerProviderBuilderExtensions.cs" company="OpenTelemetry Authors">
// Copyright The OpenTelemetry Authors
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// h... | 1 | 19,929 | Doesn't seem any less confusing or error-prone to me. IMO the solution is to not use "object" in the enrich callback signatures. Type safety/compile-time checking is our friend! | open-telemetry-opentelemetry-dotnet | .cs |
@@ -19,6 +19,9 @@ module Travis
def export
super
sh.export 'TRAVIS_GO_VERSION', go_version, echo: false
+ sh.if '-z $GOMAXPROCS' do
+ sh.export 'GOMAXPROCS', '2', echo: true
+ end
end
def prepare | 1 | require 'uri'
module Travis
module Build
class Script
class Go < Script
DEFAULTS = {
gobuild_args: '-v',
gimme_config: {
url: "#{ENV.fetch(
'TRAVIS_BUILD_GIMME_URL',
'https://raw.githubusercontent.com/meatballhat/gimme/v0.2.3/gimme'
... | 1 | 13,169 | I think this should be `GOMAXPROCS=$(nproc 2>/dev/null || echo 2)` | travis-ci-travis-build | rb |
@@ -175,8 +175,9 @@ func (ctx *rollDPoSCtx) validateProposeBlock(blk Block, expectedProposer string)
errorLog.Msg("error when validating the block signature")
return false
}
- if producer == ctx.addr.RawAddress {
- // If the block is self proposed, skip validation
+ // TODO: in long term, block in process and ... | 1 | // Copyright (c) 2018 IoTeX
// This is an alpha (internal) release and is not suitable for production. This source code is provided 'as is' and no
// warranties are given as to title or non-infringement, merchantability or fitness for purpose and, to the extent
// permitted by law, all liability for your use of the cod... | 1 | 14,248 | Can we log if this actually happens. | iotexproject-iotex-core | go |
@@ -203,6 +203,9 @@ public class RegistrationRequest {
if (pendingConfiguration.port != null) {
pendingRequest.configuration.port = pendingConfiguration.port;
}
+ if (pendingConfiguration.remoteHost != null) {
+ pendingRequest.configuration.remoteHost = pendingConfiguration.remoteHost;
+ }
... | 1 | // Licensed to the Software Freedom Conservancy (SFC) under one
// or more contributor license agreements. See the NOTICE file
// distributed with this work for additional information
// regarding copyright ownership. The SFC licenses this file
// to you under the Apache License, Version 2.0 (the
// "License"); you m... | 1 | 15,979 | This is not really needed, the line added in `GridNodeConfiguration.java` is what really fixes the `remoteHost` regression. | SeleniumHQ-selenium | py |
@@ -1,8 +1,10 @@
/* eslint-disable no-restricted-globals */
/* global __STORYBOOK_CLIENT_API__ */
+
/**
* External dependencies
*/
+import lodash from 'lodash';
import React from 'react';
import { addDecorator, configure } from '@storybook/react';
| 1 | /* eslint-disable no-restricted-globals */
/* global __STORYBOOK_CLIENT_API__ */
/**
* External dependencies
*/
import React from 'react';
import { addDecorator, configure } from '@storybook/react';
/**
* WordPress dependencies
*/
import { createHigherOrderComponent } from '@wordpress/compose';
import {
Component... | 1 | 32,448 | It looks like the import format was only changed from one-per-line to all on one line here. Can we keep it as it was so it's easier to see what changed? It's also more consistent with how we format multiple imports in other components. | google-site-kit-wp | js |
@@ -57,8 +57,10 @@ module Selenium
#
# @return [Driver]
#
- # @see Selenium::WebDriver::Remote::Bridge
+ # @see Selenium::WebDriver::Remote::OSSBridge
+ # @see Selenium::WebDriver::Remote::W3CBridge
# @see Selenium::WebDriver::Firefox::Bridge
+ # @see Selenium::WebDriver::Firefox::W3CBri... | 1 | # encoding: utf-8
#
# Licensed to the Software Freedom Conservancy (SFC) under one
# or more contributor license agreements. See the NOTICE file
# distributed with this work for additional information
# regarding copyright ownership. The SFC licenses this file
# to you under the Apache License, Version 2.0 (the
# "Li... | 1 | 14,227 | Maybe call it `WireBridge`? | SeleniumHQ-selenium | py |
@@ -5,12 +5,16 @@ import android.content.SharedPreferences;
import android.graphics.Color;
import android.os.StrictMode;
import android.preference.PreferenceManager;
+import android.util.Log;
+import org.json.JSONException;
+import org.json.JSONObject;
import org.mozilla.geckoview.GeckoSessionSettings;
import or... | 1 | package org.mozilla.vrbrowser.browser;
import android.content.Context;
import android.content.SharedPreferences;
import android.graphics.Color;
import android.os.StrictMode;
import android.preference.PreferenceManager;
import org.mozilla.geckoview.GeckoSessionSettings;
import org.mozilla.telemetry.TelemetryHolder;
im... | 1 | 7,936 | Looks like `org.json.*` can be removed? | MozillaReality-FirefoxReality | java |
@@ -890,7 +890,9 @@ public enum WidgetInfo
SECOND_TRADING_WITH_MY_ITEMS(WidgetID.PLAYER_TRADE_CONFIRM_GROUP_ID, WidgetID.TradeScreen.SECOND_MY_ITEMS),
SECOND_TRADING_WITH_THEIR_ITEMS(WidgetID.PLAYER_TRADE_CONFIRM_GROUP_ID, WidgetID.TradeScreen.SECOND_THEIR_ITEMS),
- GAUNTLET_TIMER_CONTAINER(WidgetID.GAUNTLET_TIME... | 1 | /*
* Copyright (c) 2017, Adam <Adam@sigterm.info>
* All rights reserved.
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions are met:
*
* 1. Redistributions of source code must retain the above copyright notice, this
* li... | 1 | 16,462 | remove the extra comma and newline | open-osrs-runelite | java |
@@ -1,3 +1,5 @@
+<% @page_title = t('blacklight.saved_searches.page_title', :application_name => application_name) %>
+
<div id="content" class="col-md-9">
<h1 class='page-heading'><%= t('blacklight.saved_searches.title') %></h1> | 1 | <div id="content" class="col-md-9">
<h1 class='page-heading'><%= t('blacklight.saved_searches.title') %></h1>
<%- if current_or_guest_user.blank? -%>
<h2 class='section-heading'><%= t('blacklight.saved_searches.need_login') %></h2>
<%- elsif @searches.blank? -%>
<h2 class='section-heading'><%= t('blackli... | 1 | 6,043 | Can we try to use Ruby 1.9-style hashes? | projectblacklight-blacklight | rb |
@@ -120,6 +120,17 @@ func RegisterHandlerDirective(dir string, setupFunc UnmarshalHandlerFunc) {
})
}
+// RegisterGlobalOption registers a unique global option opt with
+// an associated unmarshaling (setup) function. When the global
+// option opt is encountered in a Caddyfile, setupFunc will be
+// called to unm... | 1 | // Copyright 2015 Matthew Holt and The Caddy Authors
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicab... | 1 | 14,667 | Terminology question - these are called "global options" in the code, but the parallel non-global versions of these are called "directives"... Should this be `RegisterGlobalDirective`? Or does that have different semantics? | caddyserver-caddy | go |
@@ -244,7 +244,7 @@ def isTypingProtected():
@rtype: boolean
"""
focusObject=getFocusObject()
- if focusObject and (controlTypes.STATE_PROTECTED in focusObject.states or focusObject.role==controlTypes.ROLE_PASSWORDEDIT):
+ if focusObject and focusObject.isProtected:
return True
else:
return False | 1 | #api.py
#A part of NonVisual Desktop Access (NVDA)
#Copyright (C) 2006-2012 NVDA Contributors
#This file is covered by the GNU General Public License.
#See the file COPYING for more details.
"""General functions for NVDA"""
import config
import textInfos
import review
import globalVars
from logHandler imp... | 1 | 21,563 | I do not care much, but you could as well just return bool(focusObject and focusObject.isProtected) here and avoid the if check? I know, really trivial. | nvaccess-nvda | py |
@@ -35,3 +35,6 @@ def testCanClickOnALinkThatOverflowsAndFollowIt(driver):
def testClickingALinkMadeUpOfNumbersIsHandledCorrectly(driver):
driver.find_element(By.LINK_TEXT, "333333").click()
WebDriverWait(driver, 3).until(EC.title_is("XHTML Test Page"))
+
+def testCannotClickDisabledButton(driver):
+ WebD... | 1 | # Licensed to the Software Freedom Conservancy (SFC) under one
# or more contributor license agreements. See the NOTICE file
# distributed with this work for additional information
# regarding copyright ownership. The SFC licenses this file
# to you under the Apache License, Version 2.0 (the
# "License"); you may not... | 1 | 16,343 | I believe it's misleading name for the condition. I prefer "element_to_be_disable" We can have a condition, when element is enabled but we can't click it, because another element overlays above it. So, If we use "unclickable" we might mislead people, who use that condition to verify if element can be clicked | SeleniumHQ-selenium | java |
@@ -50,7 +50,7 @@ public class GoLanguageProvider {
@SuppressWarnings("unchecked")
public <Element> GeneratedResult generate(
- Element element, SnippetDescriptor snippetDescriptor, GoGapicContext context) {
+ Element element, SnippetDescriptor snippetDescriptor, Object context) {
GoSnippetSet<El... | 1 | /* Copyright 2016 Google Inc
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in ... | 1 | 14,535 | Do DiscoveryContext and GoGapicContext have a more specific common ancestor than Object? If so, let's use that. | googleapis-gapic-generator | java |
@@ -119,7 +119,7 @@ module Beaker
:timeout => 300,
:fail_mode => 'slow',
:timesync => false,
- :disable_iptables => true,
+ :disable_iptables => false,
:repo_proxy => false,
:package_proxy ... | 1 | module Beaker
module Options
#A class representing the environment variables and preset argument values to be incorporated
#into the Beaker options Object.
class Presets
# This is a constant that describes the variables we want to collect
# from the environment. The keys correspond to the key... | 1 | 7,500 | is this the intended behavior now? | voxpupuli-beaker | rb |
@@ -27,6 +27,5 @@ public class TestDutchIJ extends StemmerTestBase {
public void testStemming() {
assertStemsTo("ijs", "ijs");
assertStemsTo("IJs", "ijs");
- assertStemsTo("Ijs");
}
} | 1 | /*
* Licensed to the Apache Software Foundation (ASF) under one or more
* contributor license agreements. See the NOTICE file distributed with
* this work for additional information regarding copyright ownership.
* The ASF licenses this file to You under the Apache License, Version 2.0
* (the "License"); you may ... | 1 | 40,288 | Hunspell/C++ stems that a bit differently from Lucene, but in a controversial way, so I removed the check instead of changing the expectation | apache-lucene-solr | java |
@@ -172,7 +172,7 @@ func (o *opt) close() {
func (o *opt) runInitOnce() {
o.initOnce.Do(func() {
o.clock = &libkbfs.TestClock{}
- o.clock.Set(time.Unix(0, 0))
+ o.clock.Set(time.Unix(1, 0))
o.users = o.engine.InitTest(o.ver, o.blockSize,
o.blockChangeSize, o.batchSize, o.bwKBps, o.timeout, o.usernames,
... | 1 | // Copyright 2016 Keybase Inc. All rights reserved.
// Use of this source code is governed by a BSD
// license that can be found in the LICENSE file.
package test
import (
"bytes"
"fmt"
"path"
"reflect"
"regexp"
"sort"
"strings"
"sync"
"testing"
"time"
"github.com/keybase/client/go/libkb"
"github.com/key... | 1 | 19,942 | I'm curious why this is needed? | keybase-kbfs | go |
@@ -742,7 +742,7 @@ void Combat::doCombat(Creature* caster, Creature* target) const
}
*/
- if (caster && params.distanceEffect != CONST_ANI_NONE) {
+ if (caster && target && params.distanceEffect != CONST_ANI_NONE) {
addDistanceEffect(caster, caster->getPosition(), target->getPosition(), params.dista... | 1 | /**
* The Forgotten Server - a free and open-source MMORPG server emulator
* Copyright (C) 2019 Mark Samman <mark.samman@gmail.com>
*
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation; eithe... | 1 | 19,520 | I do not see how that changes anything, as the target is operated on many times before that line? | otland-forgottenserver | cpp |
@@ -513,7 +513,7 @@ $(document).ready(function() {
app.addSubMenuForType("web", "analytics", {code: "analytics-geo", url: "#/analytics/geo", text: "sidebar.analytics.geo", priority: 30});
app.addSubMenuForType("web", "analytics", {code: "analytics-sessions", url: "#/analytics/sessions", text: "sidebar... | 1 | /*global countlyAnalyticsAPI, countlyAuth, CountlyHelpers, countlyView, _, WebDashboardView, countlyLocation, countlyTotalUsers, countlySources, countlyWebDashboard, countlyCommon, countlyGlobal, countlySession, Handlebars, app, $, jQuery*/
window.WebDashboardView = countlyView.extend({
featureName: 'web',
sel... | 1 | 14,500 | Same user/visitor thing. | Countly-countly-server | js |
@@ -167,6 +167,13 @@ exit /B %errorlevel%
reg_query_command = %Q(reg query "#{reg_key}" /v "RememberedPuppetAgentStartupMode" | findstr #{msi_opts['PUPPET_AGENT_STARTUP_MODE']})
on host, Command.new(reg_query_command, [], { :cmdexe => true })
+ # (PA-620) environment.bat should be... | 1 | module Beaker
module DSL
module InstallUtils
#
# This module contains methods useful for Windows installs
#
module WindowsUtils
# Given a host, returns it's system TEMP path
#
# @param [Host] host An object implementing {Beaker::Hosts}'s interface.
#
... | 1 | 13,991 | This is not the correct path on all hosts. How can I correctly determine whether I will need to look in `Program Files` or `Program Files (x86)` for the script? | voxpupuli-beaker | rb |
@@ -73,8 +73,15 @@ namespace OpenTelemetry.Exporter.Jaeger.Implementation
this.maxFlushIntervalTimer.Elapsed += async (sender, args) =>
{
- await this.FlushAsyncInternal(false, CancellationToken.None).ConfigureAwait(false);
- };
+ try
+ ... | 1 | // <copyright file="JaegerUdpBatcher.cs" company="OpenTelemetry Authors">
// Copyright The OpenTelemetry Authors
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apac... | 1 | 14,109 | I think it would be better to move this try/catch block inside of the `FlushAsyncInternal` function as there are a few of places that can call it, eg event timer (here), AppendAsync, FlushAsync and CloseAsync. | open-telemetry-opentelemetry-dotnet | .cs |
@@ -79,6 +79,7 @@ final class IndexingChain implements Accountable {
// Holds fields seen in each document
private PerField[] fields = new PerField[1];
+ private PerField[] docFields = new PerField[10];
private final InfoStream infoStream;
private final ByteBlockPool.Allocator byteBlockAllocator;
priv... | 1 | /*
* Licensed to the Apache Software Foundation (ASF) under one or more
* contributor license agreements. See the NOTICE file distributed with
* this work for additional information regarding copyright ownership.
* The ASF licenses this file to You under the Apache License, Version 2.0
* (the "License"); you may ... | 1 | 39,256 | should we set a smaller initial size to make sure that we exercise the growing logic in our tests? | apache-lucene-solr | java |
@@ -230,3 +230,9 @@ def test_sum():
assert str(dt.sum(f[:])) == str(f[:].sum())
DT = dt.Frame(A=range(1, 10))
assert_equals(DT[:, f.A.sum()], DT[:, dt.sum(f.A)])
+
+def test_max():
+ assert str(dt.max(f.A)) == str(f.A.max())
+ assert str(dt.max(f[:])) == str(f[:].max())
+ DT = dt.Frame(A=range(1... | 1 | #!/usr/bin/env python
# -*- coding: utf-8 -*-
#-------------------------------------------------------------------------------
# Copyright 2019-2020 H2O.ai
#
# Permission is hereby granted, free of charge, to any person obtaining a
# copy of this software and associated documentation files (the "Software"),
# to deal i... | 1 | 12,954 | Let's add a new line at the end of this file, so that the last line becomes a valid line of code. | h2oai-datatable | py |
@@ -3131,7 +3131,7 @@ Offset<reflection::Field> FieldDef::Serialize(FlatBufferBuilder *builder,
}
bool FieldDef::Deserialize(Parser &parser, const reflection::Field *field) {
- name = parser.UnqualifiedName(field->name()->str());
+ name = field->name()->str();
defined_namespace = parser.current_namespace_;
... | 1 | /*
* Copyright 2014 Google Inc. All rights reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applica... | 1 | 16,274 | Why was this removed? | google-flatbuffers | java |
@@ -20,5 +20,12 @@ namespace Microsoft.CodeAnalysis.Sarif.SarifValidator
HelpText = "Path of the SARIF file to validate",
Required = true)]
public string InstanceFilePath { get; set; }
+
+ [Option(
+ 'l',
+ "log-file-path",
+ HelpText = "Path to... | 1 | // Copyright (c) Microsoft. All rights reserved. Licensed under the MIT
// license. See LICENSE file in the project root for full license information.
using CommandLine;
namespace Microsoft.CodeAnalysis.Sarif.SarifValidator
{
internal class Options
{
[Option(
's',
"sch... | 1 | 10,099 | I would prefer that this tool follow the driver framework conventions, which use OutputFilePath as an argument, take a look at AnalyzeCommandBase. You can propose changes to that if you'd like, but binskim, sqlskim, this tool should all conform (in the interests of building an eco-system with consistent command-line in... | microsoft-sarif-sdk | .cs |
@@ -308,6 +308,18 @@ public final class Queue<T> extends AbstractQueue<T, Queue<T>> implements Linear
return io.vavr.collection.Collections.fill(n, s, empty(), Queue::of);
}
+ /**
+ * Returns a Queue containing {@code n} times the given {@code element}
+ *
+ * @param <T> Component typ... | 1 | /* __ __ __ __ __ ___
* \ \ / / \ \ / / __/
* \ \/ / /\ \ \/ / /
* \____/__/ \__\____/__/
*
* Copyright 2014-2018 Vavr, http://vavr.io
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may ... | 1 | 12,931 | (...), where each element ~are~ **is the** given {@code element}. | vavr-io-vavr | java |
@@ -57,7 +57,7 @@ namespace Examples.AspNetCore
switch (exporter)
{
case "jaeger":
- services.AddOpenTelemetryTracerProvider((builder) => builder
+ services.AddOpenTelemetryTracing((builder) => builder
.AddAspNetCo... | 1 | // <copyright file="Startup.cs" company="OpenTelemetry Authors">
// Copyright The OpenTelemetry Authors
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/li... | 1 | 16,912 | What if `AddOpenTelemetryTracing` is called multiple times? | open-telemetry-opentelemetry-dotnet | .cs |
@@ -16,9 +16,10 @@ FileBasedWalIterator::FileBasedWalIterator(
std::shared_ptr<FileBasedWal> wal,
LogID startId,
LogID lastId)
- : wal_(std::move(wal))
+ : wal_(wal)
, currId_(startId) {
- if (lastId >= 0) {
+ holder_ = std::make_unique<folly::RWSpinLock::ReadHolder>(wal_->ro... | 1 | /* Copyright (c) 2018 vesoft inc. All rights reserved.
*
* This source code is licensed under Apache 2.0 License,
* attached with Common Clause Condition 1.0, found in the LICENSES directory.
*/
#include "base/Base.h"
#include "kvstore/wal/FileBasedWalIterator.h"
#include "kvstore/wal/FileBasedWal.h"
#include "kvs... | 1 | 24,614 | Why is the condition of "lastId <= wal _-> lastLogId() " added here? | vesoft-inc-nebula | cpp |
@@ -13,3 +13,9 @@
// limitations under the License.
package model
+
+import "path"
+
+func MakeEnvironmentURL(baseURL, environmentID string) string {
+ return path.Join(baseURL, "settings", "environment")
+} | 1 | // Copyright 2020 The PipeCD Authors.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agree... | 1 | 17,638 | `environmentID` is unused in MakeEnvironmentURL | pipe-cd-pipe | go |
@@ -1700,10 +1700,14 @@ public class LFMainActivity extends SharedMediaActivity {
}
}
- private void checkNoSearchResults(String result){
- textView.setText(getString(R.string.null_search_result) + " " + '"' + result + '"' );
- textView.setTextColor(getTextColor());
- textView.se... | 1 | package org.fossasia.phimpme.gallery.activities;
import android.animation.Animator;
import android.annotation.TargetApi;
import android.content.ContentResolver;
import android.content.ContentUris;
import android.content.Context;
import android.content.DialogInterface;
import android.content.Intent;
import android.con... | 1 | 12,977 | Just hide the textview | fossasia-phimpme-android | java |
@@ -54,7 +54,14 @@ type SessionDto struct {
Config json.RawMessage `json:"config"`
}
+// PaymentVersion represents the different payment versions we have
+type PaymentVersion string
+
+// PaymentVersionV2 represents the new pingpong version
+const PaymentVersionV2 PaymentVersion = "v2"
+
// ConsumerInfo represent... | 1 | /*
* Copyright (C) 2017 The "MysteriumNetwork/node" Authors.
*
* This program is free software: you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation, either version 3 of the License, or
* (at your option) any later version.
*
... | 1 | 14,952 | 'Supports'? Very uninformative naming inside protocol. Why not just paymentVersion, or just recognise supported payment version from generic protocol version supported by the client. | mysteriumnetwork-node | go |
@@ -162,7 +162,11 @@ func (s *DiskSuite) TestExplicitBundleAndVerify() {
csr, pubKey, err := util.NewCSRTemplate(validSpiffeID)
require.NoError(err)
- resp, err := s.p.MintX509CA(ctx, &upstreamauthority.MintX509CARequest{Csr: csr})
+ stream, err := s.p.MintX509CA(ctx, &upstreamauthority.MintX509CARequest{Csr: csr... | 1 | package disk
import (
"context"
"crypto"
"crypto/x509"
"encoding/json"
"testing"
"time"
"github.com/spiffe/spire/pkg/common/cryptoutil"
"github.com/spiffe/spire/pkg/common/x509svid"
"github.com/spiffe/spire/pkg/common/x509util"
"github.com/spiffe/spire/pkg/server/plugin/upstreamauthority"
spi "github.com/s... | 1 | 12,980 | We should add an additional call to Recv() somewhere after here that we assert returns io.EOF. | spiffe-spire | go |
@@ -16,10 +16,13 @@
package azkaban.database;
+import static azkaban.ServiceProvider.SERVICE_PROVIDER;
+
import azkaban.metrics.CommonMetrics;
import azkaban.utils.Props;
import java.io.IOException;
import java.sql.Connection;
+import javax.inject.Inject;
import org.apache.commons.dbutils.DbUtils;
import org... | 1 | /*
* Copyright 2012 LinkedIn Corp.
*
* Licensed under the Apache License, Version 2.0 (the "License"); you may not
* use this file except in compliance with the License. You may obtain a copy of
* the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to i... | 1 | 13,704 | What is this used for? | azkaban-azkaban | java |
@@ -7,9 +7,8 @@ package net.sourceforge.pmd.lang.java.ast;
import java.util.List;
-public class ASTAnnotationTypeDeclaration extends AbstractJavaAccessTypeNode implements ASTAnyTypeDeclaration {
+public class ASTAnnotationTypeDeclaration extends ASTAnyTypeDeclaration {
- private JavaQualifiedName qualifiedNam... | 1 | /**
* BSD-style license; for more info see http://pmd.sourceforge.net/license.html
*/
/* Generated By:JJTree: Do not edit this line. ASTAnnotationTypeDeclaration.java */
package net.sourceforge.pmd.lang.java.ast;
import java.util.List;
public class ASTAnnotationTypeDeclaration extends AbstractJavaAccessTypeNode im... | 1 | 13,538 | this is a breaking API change. Do we really need to do it in 6.2.0? Can't we just deprecate the methods? | pmd-pmd | java |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.