patch
stringlengths
17
31.2k
y
int64
1
1
oldf
stringlengths
0
2.21M
idx
int64
1
1
id
int64
4.29k
68.4k
msg
stringlengths
8
843
proj
stringclasses
212 values
lang
stringclasses
9 values
@@ -123,6 +123,12 @@ public class DatabaseHelper extends DaoMaster.OpenHelper { } } break; + case 10: + AllergenDao.dropTable(db, true); + AllergenDao.createTable(db, true); + AllergenNameDao.dropTable(db, tru...
1
package openfoodfacts.github.scrachx.openfood.models; import android.content.Context; import android.content.SharedPreferences; import android.database.Cursor; import android.database.sqlite.SQLiteDatabase; import android.util.Log; import org.greenrobot.greendao.database.Database; import openfoodfacts.github.scrachx...
1
65,977
Is dropping the **Allergen table** necessary? Can't we just add the two new columns to the existing table using a raw query?
openfoodfacts-openfoodfacts-androidapp
java
@@ -13,11 +13,11 @@ feature "Subscriber views completed trails" do within ".completed-trails" do expect(page).to have_content(just_finished_trail.name) - expect(page).to have_no_content(incomplete_trail.name) + expect(page).not_to have_content(incomplete_trail.name) end within ".inco...
1
require "rails_helper" feature "Subscriber views completed trails" do scenario "completed and incompleted trails are separated" do completed_trail = create(:trail, :published, :completed) user = completed_trail.users.last just_finished_trail = create(:trail, :published) create(:status, :completed, co...
1
17,450
I'm confused why the expectations here would have inverted? Seems unrelated to topic stuff. Can you clarify?
thoughtbot-upcase
rb
@@ -127,12 +127,13 @@ std::string MetaServiceUtils::schemaEdgesPrefix(GraphSpaceID spaceId) { std::string MetaServiceUtils::schemaEdgeKey(GraphSpaceID spaceId, EdgeType edgeType, int64_t version) { + int64_t storageVer = std::...
1
/* Copyright (c) 2018 - present, VE Software Inc. All rights reserved * * This source code is licensed under Apache 2.0 License * (found in the LICENSE.Apache file in the root directory) */ #include "meta/MetaServiceUtils.h" #include <thrift/lib/cpp2/protocol/Serializer.h> #include <thrift/lib/cpp2/protocol/Compa...
1
16,857
I am very sorry that I neglected to resolve the conflict and did not fully unit test edge
vesoft-inc-nebula
cpp
@@ -25,13 +25,14 @@ import org.apache.iceberg.catalog.TableIdentifier; import org.apache.iceberg.exceptions.AlreadyExistsException; import org.apache.iceberg.exceptions.CommitFailedException; import org.apache.iceberg.exceptions.NoSuchTableException; +import org.apache.iceberg.io.CloseableGroup; import org.apache.i...
1
/* * Licensed to the Apache Software Foundation (ASF) under one * or more contributor license agreements. See the NOTICE file * distributed with this work for additional information * regarding copyright ownership. The ASF licenses this file * to you under the Apache License, Version 2.0 (the * "License"); you ...
1
39,812
I think closeable should be handled by the concrete impl of a catalog and not by the base class, I don't think all catalogs must implement closeable by design. This should be done via composition rather than inheritance. Additionally, I don't know what the effect of this change is on other catalogs so this feels a bit ...
apache-iceberg
java
@@ -9,11 +9,13 @@ void ConvolutionLayer<Dtype>::compute_output_shape() { const int* kernel_shape_data = this->kernel_shape_.cpu_data(); const int* stride_data = this->stride_.cpu_data(); const int* pad_data = this->pad_.cpu_data(); + const int* dilation_data = this->dilation_.cpu_data(); this->output_shape...
1
#include <vector> #include "caffe/layers/conv_layer.hpp" namespace caffe { template <typename Dtype> void ConvolutionLayer<Dtype>::compute_output_shape() { const int* kernel_shape_data = this->kernel_shape_.cpu_data(); const int* stride_data = this->stride_.cpu_data(); const int* pad_data = this->pad_.cpu_data...
1
35,873
Should this be `const`?
BVLC-caffe
cpp
@@ -6,7 +6,7 @@ namespace Benchmarks.Trace { private static void Main(string[] args) { - BenchmarkRunner.Run<SpanBenchmark>(); + BenchmarkSwitcher.FromAssembly(typeof(Program).Assembly).Run(args); } } }
1
using BenchmarkDotNet.Running; namespace Benchmarks.Trace { internal class Program { private static void Main(string[] args) { BenchmarkRunner.Run<SpanBenchmark>(); } } }
1
17,518
Can we also add the Exporters here by using `DefaultConfig.AddExporter(...)`? At least the Datadog exporter that can't be configured from the command line...
DataDog-dd-trace-dotnet
.cs
@@ -77,7 +77,7 @@ int main(int argc, char *argv[]) { // When using checkpoint states, skip training as those could be the result // of checkpointing by steps. - if (!opts->has_string("ckpt_dir")){ + if (!opts->has_string("no_model1_train")){ model_1->train( pb_model.num_epochs() ); } ...
1
//////////////////////////////////////////////////////////////////////////////// // Copyright (c) 2014-2016, Lawrence Livermore National Security, LLC. // Produced at the Lawrence Livermore National Laboratory. // Written by the LBANN Research Team (B. Van Essen, et al.) listed in // the CONTRIBUTORS file. <lbann-dev@l...
1
12,910
@JaeseungYeom I believe you had set this in a previous commit to, by default, not train model1 when loading from ckpt. Would it work for you to have this as a command line option `--no_model1_train` instead of the default behavior?
LLNL-lbann
cpp
@@ -86,6 +86,11 @@ namespace Microsoft.Rest.Generator.Ruby.TemplateModels return "Array<Integer>"; } + if (type == PrimaryType.TimeSpan) + { + return "Duration"; //TODO: Is this a real Ruby type...? + } + if (compositeType != n...
1
// Copyright (c) Microsoft Open Technologies, Inc. All rights reserved. // Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information. using System; using Microsoft.Rest.Generator.ClientModel; using System.Linq; namespace Microsoft.Rest.Generator.Ruby.TemplateModels {...
1
21,148
@devigned, please clarify
Azure-autorest
java
@@ -19,6 +19,7 @@ import ( "reflect" "testing" "time" + "github.com/jmcvetta/randutil" ) func TestConcurrentCommand_UnmarshalJSON(t *testing.T) {
1
// Copyright 2018 Istio Authors // // Licensed under the Apache License, Version 2.0 (the "License"); // you may not use this currentFile except in compliance with the License. // You may obtain a copy of the License at // // http://www.apache.org/licenses/LICENSE-2.0 // // Unless required by applicable law or agre...
1
6,724
File is not `gofmt`-ed with `-s` (from `gofmt`)
istio-tools
go
@@ -127,7 +127,7 @@ def GenerateConfig(context): 'items': [{ 'key': 'startup-script', 'value': """#!/bin/bash -sudo apt-get install -y unzip +sudo apt-get install -y unzip git sudo apt-get install -y libmysqlclient-dev sudo apt-get install -y python-pip pytho...
1
# Copyright 2017 Google Inc. # # Licensed under the Apache License, Version 2.0 (the "License"); # you may not use this file except in compliance with the License. # You may obtain a copy of the License at # # http://www.apache.org/licenses/LICENSE-2.0 # # Unless required by applicable law or agreed to in writing, s...
1
25,519
Should we break this up into a separate line?
forseti-security-forseti-security
py
@@ -57,6 +57,7 @@ var _ = Describe("conformance tests", func() { Measure(specName, func(b Benchmarker) { name := fmt.Sprintf("cluster-%s", util.RandomString(6)) + setEnvVar("USE_CI_ARTIFACTS", "true", false) kubernetesVersion := e2eConfig.GetVariable(KubernetesVersion) flavor := clusterctl.DefaultFlavor ...
1
// +build e2e /* Copyright 2020 The Kubernetes Authors. Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed ...
1
16,753
Why the override on the env variable, wouldn't we want to use the value set from Prow?
kubernetes-sigs-cluster-api-provider-aws
go
@@ -0,0 +1,13 @@ +widget :projected_monthly_revenue do + key "74b333b94cd772ee15be863e646f8ca1e535f1c6" + type "number_and_secondary" + data do + { + value: + IndividualPlan.prime_basic.projected_monthly_revenue + + IndividualPlan.prime_workshops.projected_monthly_revenue + + IndividualP...
1
1
7,893
I don't see anything here that excludes people on a Team plan from from the revenue report. I see that TeamPlans are counted below, but the individual subscribers on the plan would still be included.
thoughtbot-upcase
rb
@@ -1078,11 +1078,8 @@ public final class Vector<T> implements IndexedSeq<T>, Serializable { @Override public Vector<T> subSequence(int beginIndex, int endIndex) { - if ((beginIndex >= 0) && (beginIndex <= endIndex) && (endIndex <= length())) { - return slice(beginIndex, endIndex); - ...
1
/* __ __ __ __ __ ___ * \ \ / / \ \ / / __/ * \ \/ / /\ \ \/ / / * \____/__/ \__\____/__/.ɪᴏ * ᶜᵒᵖʸʳᶦᵍʰᵗ ᵇʸ ᵛᵃᵛʳ ⁻ ˡᶦᶜᵉⁿˢᵉᵈ ᵘⁿᵈᵉʳ ᵗʰᵉ ᵃᵖᵃᶜʰᵉ ˡᶦᶜᵉⁿˢᵉ ᵛᵉʳˢᶦᵒⁿ ᵗʷᵒ ᵈᵒᵗ ᶻᵉʳᵒ */ package io.vavr.collect...
1
12,242
I know that we do not pull the last bit of performance out of the JVM but it is more robust and removes redundant code.
vavr-io-vavr
java
@@ -130,6 +130,11 @@ public abstract class ScheduledReporter implements Closeable, Reporter { ScheduledExecutorService executor, boolean shutdownExecutorOnStop, Set<MetricAttribute> disabledMetricAttributes) { + + ...
1
package com.codahale.metrics; import org.slf4j.Logger; import org.slf4j.LoggerFactory; import java.io.Closeable; import java.util.Collections; import java.util.Locale; import java.util.Set; import java.util.SortedMap; import java.util.concurrent.Executors; import java.util.concurrent.ScheduledExecutorService; import ...
1
7,297
I'd make this a `throw new NullPointerException("registry == null");` instead
dropwizard-metrics
java
@@ -163,10 +163,12 @@ type Config struct { FailsafeInboundHostPorts []ProtoPort `config:"port-list;tcp:22,udp:68;die-on-fail"` FailsafeOutboundHostPorts []ProtoPort `config:"port-list;tcp:2379,tcp:2380,tcp:4001,tcp:7001,udp:53,udp:67;die-on-fail"` - UsageReportingEnabled bool `config:"bool;true"` - ClusterGUID...
1
// Copyright (c) 2016-2017 Tigera, Inc. All rights reserved. // // Licensed under the Apache License, Version 2.0 (the "License"); // you may not use this file except in compliance with the License. // You may obtain a copy of the License at // // http://www.apache.org/licenses/LICENSE-2.0 // // Unless required by ...
1
15,931
Does adding things here require us also to extend the FelixConfiguration resource in libcalico-go?
projectcalico-felix
go
@@ -31,7 +31,11 @@ import ( "github.com/pkg/errors" ) -const currentCNISpec = "0.3.1" +const ( + currentCNISpec = "0.3.1" + currentCNIVersion = "2018.08.0" + CNIGitHash = "a134a973585b560439ed25ec3857e4789bfeb89f" +) // CNIClient defines the method of setting/cleaning up container namespace type CNIClient inte...
1
// Copyright 2017 Amazon.com, Inc. or its affiliates. All Rights Reserved. // // Licensed under the Apache License, Version 2.0 (the "License"). You may // not use this file except in compliance with the License. A copy of the // License is located at // // http://aws.amazon.com/apache2.0/ // // or in the "license" fil...
1
20,950
does this need to be public?
aws-amazon-ecs-agent
go
@@ -15,6 +15,7 @@ from . import encode from . import number_types as N +FILEIDENTIFIER_LENGTH = 4 class Table(object): """Table wraps a byte slice and provides read access to its data.
1
# Copyright 2014 Google Inc. All rights reserved. # # Licensed under the Apache License, Version 2.0 (the "License"); # you may not use this file except in compliance with the License. # You may obtain a copy of the License at # # http://www.apache.org/licenses/LICENSE-2.0 # # Unless required by applicable law or a...
1
13,776
Please import this from a pre-existing definition.
google-flatbuffers
java
@@ -0,0 +1,18 @@ +class WebOptions: + def load(self, loader): + loader.add_option( + "web_open_browser", bool, True, + "Start a browser." + ) + loader.add_option( + "web_debug", bool, False, + "Mitmweb debugging." + ) + loader.add_option(...
1
1
13,477
File name does not represent class name... if we ever cared for such things?
mitmproxy-mitmproxy
py
@@ -39,7 +39,7 @@ Rails.application.routes.draw do get :languages get :commits_by_project_chart get :commits_by_language_chart - post :make_spammer + post :label_as_spammer get 'edit_privacy' => 'privacy#edit', as: :edit_account_privacy put 'update_privacy' => 'privacy#u...
1
Rails.application.routes.draw do ActiveAdmin.routes(self) root 'home#index' resources :sessions, only: [:new, :create] do collection do delete :destroy end end resources :password_reset, only: [:new, :create] do collection do get :confirm post :reset end end resources :a...
1
7,015
I don't mind the `make_spammer` route name. It seems to more clearly convey that the state of the account will change. The "label as" route name seems less definitive, as if one is simply adding something to the account -- a new label -- instead of changing the status of the account.
blackducksoftware-ohloh-ui
rb
@@ -46,7 +46,8 @@ var loggingCmd = &cobra.Command{ Long: `Enable/disable and configure Algorand remote logging`, Args: validateNoPosArgsFn, Run: func(cmd *cobra.Command, _ []string) { - cfg, err := logging.EnsureTelemetryConfig(nil, "") + dataDir := ensureSingleDataDir() + cfg, err := logging.EnsureTelemetry...
1
// Copyright (C) 2019 Algorand, Inc. // This file is part of go-algorand // // go-algorand is free software: you can redistribute it and/or modify // it under the terms of the GNU Affero General Public License as // published by the Free Software Foundation, either version 3 of the // License, or (at your option) any l...
1
35,755
This exits if `-d` not specified which isn't exactly what we want, right?
algorand-go-algorand
go
@@ -313,3 +313,10 @@ def sizeof_fmt(num, suffix='B'): return "%3.1f%s%s" % (num, unit, suffix) num /= 1024.0 return "%.1f%s%s" % (num, 'Yi', suffix) + + +def escape_like(string, escape_char='*'): + """Escape the string parameter used in SQL LIKE expressions.""" + return string.replace(e...
1
# ------------------------------------------------------------------------- # The CodeChecker Infrastructure # This file is distributed under the University of Illinois Open Source # License. See LICENSE.TXT for details. # -------------------------------------------------------------------------...
1
8,157
So a `*` becomes `**`? How does this affect the query? If I have `csordas*marton` as filter and I have `csordas*marton` and `csordasFOOBARmarton` as run names in the database I get only the first as result?
Ericsson-codechecker
c
@@ -191,11 +191,14 @@ InterimResult::buildIndex(const std::string &vidColumn) const { auto name = schema->getFieldName(i); if (vidColumn == name) { VLOG(1) << "col name: " << vidColumn << ", col index: " << i; - if (schema->getFieldType(i).type != SupportedType::VID) { + ...
1
/* Copyright (c) 2018 vesoft inc. All rights reserved. * * This source code is licensed under Apache 2.0 License, * attached with Common Clause Condition 1.0, found in the LICENSES directory. */ #include "base/Base.h" #include "graph/InterimResult.h" #include "dataman/RowReader.h" namespace nebula { namespace gra...
1
29,370
I want to know in which situation you need to traverse from "Timestamp" data.....
vesoft-inc-nebula
cpp
@@ -687,7 +687,11 @@ func (ctx *signingCtx) buildBodyDigest() error { if !aws.IsReaderSeekable(ctx.Body) { return fmt.Errorf("cannot use unseekable request body %T, for signed request with body", ctx.Body) } - hash = hex.EncodeToString(makeSha256Reader(ctx.Body)) + hasBytes, err := makeSha256Reader(ctx...
1
// Package v4 implements signing for AWS V4 signer // // Provides request signing for request that need to be signed with // AWS V4 Signatures. // // Standalone Signer // // Generally using the signer outside of the SDK should not require any additional // logic when using Go v1.5 or higher. The signer does this by tak...
1
9,777
nit: hasBytes should be hashBytes
aws-aws-sdk-go
go
@@ -171,6 +171,15 @@ def perform_analysis(args, skip_handler, context, actions, metadata): config_map[ClangSA.ANALYZER_NAME].set_checker_enabled( ReturnValueCollector.checker_analyze) + # Statistics collector checkers must be explicitly disabled + # as they trash the output. + if "clang...
1
# ------------------------------------------------------------------------- # The CodeChecker Infrastructure # This file is distributed under the University of Illinois Open Source # License. See LICENSE.TXT for details. # -------------------------------------------------------------------------...
1
10,610
If I enable the clangsa analyzer with the `--stats` flag the checkers will be disabled even if they were enabled previously. I think we should check here if stats was enabled. `if 'stats_enabled' in args and args.stats_enabled` we should leave them enabled.
Ericsson-codechecker
c
@@ -1041,6 +1041,9 @@ func DoEstimateGas(ctx context.Context, b Backend, args CallArgs, blockNrOrHash // 3. calculate the fee and normalize by the default gas price fee := core.CalculateRollupFee(*args.Data, uint64(gasUsed), dataPrice, executionPrice).Uint64() / defaultGasPrice + if fee < 21000 { + fee = 21000 +...
1
// Copyright 2015 The go-ethereum Authors // This file is part of the go-ethereum library. // // The go-ethereum library is free software: you can redistribute it and/or modify // it under the terms of the GNU Lesser General Public License as published by // the Free Software Foundation, either version 3 of the License...
1
15,638
Note that we probably should set the default gasPrice to `0.1 gwei` considering our minimum gas limit has to be 21k. At 21k the minimum fee would end up being `0.000021 ETH` which is just a little too high
ethereum-optimism-optimism
go
@@ -132,7 +132,9 @@ func validateTrustedOperators(o *Options) error { if o.TrustedKeys == nil { o.TrustedKeys = make([]string, 0, 4) } - o.TrustedKeys = append(o.TrustedKeys, opc.Issuer) + if !opc.StrictSigningKeyUsage { + o.TrustedKeys = append(o.TrustedKeys, opc.Subject) + } o.TrustedKeys = append(o...
1
// Copyright 2018-2019 The NATS Authors // Licensed under the Apache License, Version 2.0 (the "License"); // you may not use this file except in compliance with the License. // You may obtain a copy of the License at // // http://www.apache.org/licenses/LICENSE-2.0 // // Unless required by applicable law or agreed to ...
1
12,359
So during a config reload, this function is invoked, but prior to that the o.TrustedKeys slice is set to nil, so this code would work. However, I am wondering what happens to s.trustedKeys, I am not sure this is handled at all. (same with the new map you are adding). I am not sure if this is supposed to be supported wi...
nats-io-nats-server
go
@@ -64,15 +64,12 @@ func SecurityHandler(authenticators map[string]auth.Authenticator, next http.Han } return func(w http.ResponseWriter, r *http.Request) { - tokenHeader := r.Header.Get("Authorization") tokens := strings.Split(tokenHeader, " ") if len(tokens) < 2 { w.WriteHeader(http.StatusUnautho...
1
package server import ( "bytes" "encoding/json" "fmt" "io" "io/ioutil" "net/http" "strings" "github.com/gorilla/mux" "github.com/libopenstorage/openstorage/api" "github.com/libopenstorage/openstorage/pkg/auth" "github.com/libopenstorage/openstorage/pkg/auth/secrets" osecrets "github.com/libopenstorage/ope...
1
8,594
I think the logic should be to check for token len of 0 then check for token len of less than 2. The way the logic is now, it is hard to determine if it is empty or malformed.
libopenstorage-openstorage
go
@@ -267,6 +267,15 @@ void wlr_output_set_subpixel(struct wlr_output *output, wlr_output_schedule_done(output); } +void wlr_output_set_format(struct wlr_output *output, + enum wl_shm_format format) { + if (output->format == format) { + return; + } + + output->format = format; +} + void wlr_output_set_description...
1
#define _POSIX_C_SOURCE 200809L #include <assert.h> #include <stdlib.h> #include <string.h> #include <tgmath.h> #include <time.h> #include <wayland-server-core.h> #include <wlr/interfaces/wlr_output.h> #include <wlr/render/interface.h> #include <wlr/render/wlr_renderer.h> #include <wlr/types/wlr_box.h> #include <wlr/ty...
1
15,769
Nothing would change here even if this `if` statement were removed.
swaywm-wlroots
c
@@ -38,10 +38,11 @@ assert_pyspark_version() from databricks.koalas.frame import DataFrame from databricks.koalas.indexes import Index, MultiIndex from databricks.koalas.series import Series -from databricks.koalas.typedef import Col, pandas_wraps +from databricks.koalas.typedef import pandas_wraps +from databricks....
1
# # Copyright (C) 2019 Databricks, Inc. # # Licensed under the Apache License, Version 2.0 (the "License"); # you may not use this file except in compliance with the License. # You may obtain a copy of the License at # # http://www.apache.org/licenses/LICENSE-2.0 # # Unless required by applicable law or agreed to i...
1
10,052
`sql` module is imported later.
databricks-koalas
py
@@ -69,6 +69,15 @@ class GARPNHead(RPNTestMixin, GuidedAnchorHead): cfg, rescale=False): cfg = self.test_cfg if cfg is None else cfg + + # refactor the nms cfg + # this is used for avoid breaking change + if 'nms' not in cfg: + ...
1
import torch import torch.nn as nn import torch.nn.functional as F from mmcv.cnn import normal_init from mmcv.ops import nms from ..builder import HEADS from .guided_anchor_head import GuidedAnchorHead from .rpn_test_mixin import RPNTestMixin @HEADS.register_module() class GARPNHead(RPNTestMixin, GuidedAnchorHead): ...
1
22,598
I think it's strange, whether `assert cfg.nms.type == 'nms'` would be better.
open-mmlab-mmdetection
py
@@ -33,14 +33,7 @@ import globalize from '../scripts/globalize'; }); options.buttons = items; - - return dialog.show(options).then(function (result) { - if (result === 'ok') { - return Promise.resolve(); - } - - retur...
1
import browser from '../scripts/browser'; import dialog from './dialog/dialog'; import globalize from '../scripts/globalize'; /* eslint-disable indent */ function replaceAll(originalString, strReplace, strWith) { const reg = new RegExp(strReplace, 'ig'); return originalString.replace(reg, strWith...
1
18,667
Doing a quick search, it looks like there are other places that would be handling this promise rejection. How did you confirm this is not needed?
jellyfin-jellyfin-web
js
@@ -68,7 +68,7 @@ func TestCreateContract(t *testing.T) { _, err = accountutil.LoadOrCreateAccount(sm, addr.String()) require.NoError(err) hu := config.NewHeightUpgrade(&cfg.Genesis) - stateDB := NewStateDBAdapter(sm, 0, hu.IsPre(config.Aleutian, 0), hash.ZeroHash256) + stateDB := NewStateDBAdapter(sm, 0, hu.IsPr...
1
// Copyright (c) 2019 IoTeX Foundation // This is an alpha (internal) release and is not suitable for production. This source code is provided 'as is' and no // warranties are given as to title or non-infringement, merchantability or fitness for purpose and, to the extent // permitted by law, all liability for your use...
1
21,945
let's use greenland in the unit tests as well
iotexproject-iotex-core
go
@@ -48,8 +48,10 @@ def reportPassThrough(treeInterceptor,onlyIfChanged=True): nvwave.playWaveFile(sound) else: if treeInterceptor.passThrough: + # Translators: The mode to interact with controls in documents ui.message(_("Focus mode")) else: + # Translators: The mode that presents text in a fl...
1
#browseMode.py #A part of NonVisual Desktop Access (NVDA) #Copyright (C) 2007-2017 NV Access Limited, Babbage B.V. #This file is covered by the GNU General Public License. #See the file COPYING for more details. import itertools import collections import winsound import time import weakref import wx from l...
1
20,719
Please split this into two lines
nvaccess-nvda
py
@@ -77,6 +77,12 @@ namespace MvvmCross.Platform.Tvos.Views public virtual bool ShowChildView(UIViewController viewController) { + if (SelectedIndex > 5) // when more menu item is currently visible, selected index has value higher than 5 + { + MoreNavigationContro...
1
// Licensed to the .NET Foundation under one or more agreements. // The .NET Foundation licenses this file to you under the MS-PL license. // See the LICENSE file in the project root for more information. using System; using System.Collections.Generic; using System.Linq; using MvvmCross.Platform.Tvos.Presenters; usin...
1
13,767
Is there any variable available instead of hardcoding 5?
MvvmCross-MvvmCross
.cs
@@ -385,9 +385,7 @@ public class LoginActivity extends AccountAuthenticatorActivity @Override protected void onActivityResult(int requestCode, int resultCode, Intent data) { - if (requestCode == PasscodeManager.PASSCODE_REQUEST_CODE && resultCode == Activity.RESULT_OK) { - webviewHelper.onNewPasscode(); - } e...
1
/* * Copyright (c) 2011-present, salesforce.com, inc. * All rights reserved. * Redistribution and use of this software in source and binary forms, with or * without modification, are permitted provided that the following conditions * are met: * - Redistributions of source code must retain the above copyright noti...
1
17,195
The onNewPasscode method was taking care of creating the user account. Now the user account will already have been created.
forcedotcom-SalesforceMobileSDK-Android
java
@@ -29,7 +29,8 @@ import ( ) const ( - MaxChainNameLength = 28 + MaxChainNameLength = 28 + defaultPostWriteInterval = 50 * time.Millisecond ) var (
1
// Copyright (c) 2016-2017 Tigera, Inc. All rights reserved. // // Licensed under the Apache License, Version 2.0 (the "License"); // you may not use this file except in compliance with the License. // You may obtain a copy of the License at // // http://www.apache.org/licenses/LICENSE-2.0 // // Unless required by ...
1
15,436
This is really a minimum, isn't it, so `minPostWriteInterval` perhaps? IIUC it never gets used as a default, because the default IptablesPostWriteCheckInterval is 1s, which is larger than this.
projectcalico-felix
go
@@ -1,11 +1,9 @@ <ul class="bookmarkTools nav nav-pills"> - <li class="cite"> - <%= link_to t('blacklight.tools.cite'), citation_catalog_path(:sort=>params[:sort], :per_page=>params[:per_page], :id => @response.documents.map {|doc| doc.id}), {:id => 'citeLink', :name => 'citation', :class => 'btn btn-default', :da...
1
<ul class="bookmarkTools nav nav-pills"> <li class="cite"> <%= link_to t('blacklight.tools.cite'), citation_catalog_path(:sort=>params[:sort], :per_page=>params[:per_page], :id => @response.documents.map {|doc| doc.id}), {:id => 'citeLink', :name => 'citation', :class => 'btn btn-default', :data => {:ajax_modal =...
1
5,536
I wonder if you can use the controller's context instead of using it explicitly?
projectblacklight-blacklight
rb
@@ -94,6 +94,7 @@ func (e *Executor) ensureCanaryClean(ctx context.Context) model.StageStatus { resources := strings.Split(value, ",") if err := e.removeCanaryResources(ctx, resources); err != nil { + e.LogPersister.AppendErrorf("Unable to remove canary resources: %v", err) return model.StageStatus_STAGE_FAIL...
1
// Copyright 2020 The PipeCD Authors. // // Licensed under the Apache License, Version 2.0 (the "License"); // you may not use this file except in compliance with the License. // You may obtain a copy of the License at // // http://www.apache.org/licenses/LICENSE-2.0 // // Unless required by applicable law or agree...
1
8,483
Can you add this log for `baseline` too?
pipe-cd-pipe
go
@@ -148,6 +148,10 @@ Blockly.Msg.CANNOT_DELETE_VARIABLE_PROCEDURE = 'Can\'t delete the variable "%1" /// dropdown choice - Delete the currently selected variable. Blockly.Msg.DELETE_VARIABLE = 'Delete the "%1" variable'; +// Broadcast Message creation +/// dropdown choice - Create a new message. +Blockly.Msg.NEW_ME...
1
/** * @license * Visual Blocks Language * * Copyright 2012 Google Inc. * https://developers.google.com/blockly/ * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. * You may obtain a copy of the License at * * http://www.apa...
1
8,883
Let's call this "NEW_BROADCAST_MESSAGE". Msg.NEW_MESSAGE will be confusing down the line.
LLK-scratch-blocks
js
@@ -128,11 +128,17 @@ type Container struct { // is handled properly so that the state storage continues to work. KnownStatusUnsafe ContainerStatus `json:"KnownStatus"` + // TransitionDependenciesMap is a map of the dependent container status to other + // dependencies that must be satisfied in order for this con...
1
// Copyright 2014-2017 Amazon.com, Inc. or its affiliates. All Rights Reserved. // // Licensed under the Apache License, Version 2.0 (the "License"). You may // not use this file except in compliance with the License. A copy of the // License is located at // // http://aws.amazon.com/apache2.0/ // // or in the "license...
1
19,147
A better way to do this (in your future PR) would be to: 1. get rid of `TransitionDependencySet` altogether 2. tag `TransitionDependenciesMap` as `"TransitionDependencySet"` in JSON 3. update the JSON marshaler to deal with `"TransitionDependencySet"` tag. If it's a map, no big deal. Else, construct the `TransitionDepe...
aws-amazon-ecs-agent
go
@@ -81,10 +81,10 @@ def file_list_to_folder(df: pd.DataFrame, limit: int, offset: int) -> dict: axis=1 ).to_dict(orient='records') objects = folder[~folder.logical_key.str.contains('/')].to_dict(orient='records') - returned_results = len(prefixes) + len(objects) - except Attribu...
1
""" Provide a virtual-file-system view of a package's logical keys. """ import json import os import boto3 import botocore import pandas as pd from t4_lambda_shared.decorator import api, validate from t4_lambda_shared.utils import ( get_default_origins, make_json_response, query_manifest_content, sql...
1
20,707
It's very error-prone to have so large `try` clause with such non-specific exceptions handled. Consider rewriting it with either of these: 1. Check that expected columns are present in `DataFrame` (`{'physical_key', 'logical_key', 'size'}.issubset(df.columns)`). 2. Normalizing output of query by using `COALESCE()` (or ...
quiltdata-quilt
py
@@ -116,6 +116,7 @@ var ( MirrorQueueLength int PullRequestQueueLength int PreferredLicenses []string + DisableHttpGit bool // Repository editor settings Editor struct {
1
// Copyright 2014 The Gogs Authors. All rights reserved. // Use of this source code is governed by a MIT-style // license that can be found in the LICENSE file. package setting import ( "fmt" "net/url" "os" "os/exec" "path" "path/filepath" "runtime" "strconv" "strings" "time" "github.com/Unknwon/com" _ "...
1
12,065
Change to `DisableHTTPGit`
gogs-gogs
go
@@ -71,10 +71,9 @@ class UserMailer < ActionMailer::Base end def feedback_notification(recipient, plan, requestor) - return unless @user.org.present? && recipient.active? + return unless recipient.active? @user = requestor - @org = @user.org @plan = plan @recipient = recipient
1
# frozen_string_literal: true class UserMailer < ActionMailer::Base prepend_view_path "app/views/branded/" include MailerHelper helper MailerHelper helper FeedbacksHelper default from: Rails.configuration.x.organisation.email def welcome_notification(user) @user = user FastGettext.with_locale F...
1
19,096
org was not used in the mail content
DMPRoadmap-roadmap
rb
@@ -128,6 +128,9 @@ export default Service.extend({ return this.lazyLoader.loadStyle('dark', 'assets/ghost-dark.css', true).then(() => { $('link[title=dark]').prop('disabled', !nightShift); $('link[title=light]').prop('disabled', nightShift); + }).catch((err) => { + ...
1
import $ from 'jquery'; import Ember from 'ember'; import EmberError from '@ember/error'; import RSVP from 'rsvp'; import Service, {inject as service} from '@ember/service'; import {computed} from '@ember/object'; import {set} from '@ember/object'; export function feature(name, options = {}) { let {user, onChange}...
1
9,272
Is this gonna cause a lint issue, because of unused var? Maybe we should log it out?
TryGhost-Admin
js
@@ -321,7 +321,11 @@ module Beaker def hack_etc_hosts hosts, opts etc_hosts = "127.0.0.1\tlocalhost localhost.localdomain\n" hosts.each do |host| - etc_hosts += "#{host['ip'].to_s}\t#{host[:vmhostname] || host.name}\n" + if host['hypervisor'] == 'docker' + etc_hosts += "#{host[...
1
require 'pathname' [ 'command', "dsl/patterns" ].each do |lib| require "beaker/#{lib}" end module Beaker #Provides convienience methods for commonly run actions on hosts module HostPrebuiltSteps include Beaker::DSL::Patterns NTPSERVER = 'pool.ntp.org' SLEEPWAIT = 5 TRIES = 5 UNIX_PACKAGES =...
1
9,144
My understanding is that this will always be set to the actual containers IP, and never to the `DOCKER_HOST` IP if that env_var is set.
voxpupuli-beaker
rb
@@ -49,11 +49,14 @@ function ResetButton( { children } ) { * the navigate call starting, we will just set a debounce to keep the spinner for 3 seconds. */ const debouncedSetInProgress = useDebounce( setInProgress, 3000 ); - const mediatedSetInProgress = ( bool ) => bool ? setInProgress( true ) : debouncedSetInP...
1
/** * ResetButton component. * * Site Kit by Google, Copyright 2021 Google LLC * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. * You may obtain a copy of the License at * * https://www.apache.org/licenses/LICENSE-2.0 * ...
1
37,753
this dependency to a callback also has to be a callback (eslint now warns us)
google-site-kit-wp
js
@@ -95,7 +95,7 @@ func (c *CStorPoolController) reconcile(key string) error { return c.updateStatus(csp) } -func (c *CStorPoolController) destroy(csp *apis.NewTestCStorPool) error { +func (c *CStorPoolController) destroy(csp *apis.CStorPoolInstance) error { var phase apis.CStorPoolPhase // DeletePool is to d...
1
/* Copyright 2018 The OpenEBS Authors. Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, sof...
1
17,143
directory name as well needs change..
openebs-maya
go
@@ -348,7 +348,8 @@ class PluginManager public function findByIdentifier($identifier) { if (!isset($this->plugins[$identifier])) { - $identifier = $this->normalizeIdentifier($identifier); + $code = $this->getIdentifier($identifier); + $identifier = $this->normalizeIde...
1
<?php namespace System\Classes; use Db; use App; use Str; use File; use Lang; use Log; use View; use Config; use Schema; use RecursiveIteratorIterator; use RecursiveDirectoryIterator; use SystemException; /** * Plugin manager * * @package october\system * @author Alexey Bobkov, Samuel Georges */ class PluginMana...
1
17,725
Why is the getIdentifier() call required here?
octobercms-october
php
@@ -92,7 +92,11 @@ std::string MakeCamel(const std::string &in, bool first) { } void Parser::Message(const std::string &msg) { +#ifndef FLATBUFFERS_PLATFORM_NO_FILE_SUPPORT error_ = file_being_parsed_.length() ? AbsolutePath(file_being_parsed_) : ""; +#else // FLATBUFFERS_PLATFORM_NO_FILE_SUPPORT + error_ = fil...
1
/* * Copyright 2014 Google Inc. All rights reserved. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. * You may obtain a copy of the License at * * http://www.apache.org/licenses/LICENSE-2.0 * * Unless required by applica...
1
13,499
Looks more appropriate to stick this in `AbsolutePath`.. actually that already has `FLATBUFFERS_NO_ABSOLUTE_PATH_RESOLUTION`
google-flatbuffers
java
@@ -1,4 +1,8 @@ -const html = require('yo-yo') +const { h } = require('preact') +const hyperx = require('hyperx') +const html = hyperx(h) + +let inputEl module.exports = (props) => { const input = html`
1
const html = require('yo-yo') module.exports = (props) => { const input = html` <input class="UppyDashboard-input" hidden="true" aria-hidden="true" tabindex="-1" type="file" name="files[]" multiple="true" onchange=${props.handleInpu...
1
10,253
this might interfere when we have multiple dashboards. maybe ActionBrowseTagline needs to be a Component so we can store the reference to the element on it.
transloadit-uppy
js
@@ -376,8 +376,15 @@ func (b *BlockServerRemote) Get(ctx context.Context, tlfID tlf.ID, id kbfsblock. context kbfsblock.Context) ( buf []byte, serverHalf kbfscrypto.BlockCryptKeyServerHalf, err error) { ctx = rpc.WithFireNow(ctx) + var res keybase1.GetBlockRes b.log.LazyTrace(ctx, "BServer: Get %s", id) + + // ...
1
// Copyright 2016 Keybase Inc. All rights reserved. // Use of this source code is governed by a BSD // license that can be found in the LICENSE file. package libkbfs import ( "sync" "time" "github.com/keybase/backoff" "github.com/keybase/client/go/libkb" "github.com/keybase/client/go/logger" "github.com/keybas...
1
20,660
Should this be inside the `else` below and right after `CDebugf` so that we still get the logs?
keybase-kbfs
go
@@ -540,4 +540,5 @@ var errorCodeMap = map[string]gcerrors.ErrorCode{ dyn.ErrCodeTransactionCanceledException: gcerr.FailedPrecondition, dyn.ErrCodeTransactionInProgressException: gcerr.InvalidArgument, dyn.ErrCodeIdempotentParameterMismatchException: gcerr.InvalidArgument, + "Validation...
1
// Copyright 2019 The Go Cloud Development Kit Authors // // Licensed under the Apache License, Version 2.0 (the "License"); // you may not use this file except in compliance with the License. // You may obtain a copy of the License at // // https://www.apache.org/licenses/LICENSE-2.0 // // Unless required by appli...
1
17,138
Weird they don't expose the type for dynamo and this seems a pretty common error.
google-go-cloud
go
@@ -33,10 +33,11 @@ namespace OpenTelemetry.Trace.Configuration /// Enables OpenTelemetry. /// </summary> /// <param name="configureOpenTelemetryBuilder">Function that configures OpenTelemetryBuilder.</param> + /// <returns><see cref="IDisposable"/> to be disposed on application shutdo...
1
// <copyright file="OpenTelemetrySdk.cs" company="OpenTelemetry Authors"> // Copyright The OpenTelemetry Authors // // Licensed under the Apache License, Version 2.0 (the "License"); // you may not use this file except in compliance with the License. // You may obtain a copy of the License at // // http://www.apac...
1
14,064
@cijothomas I couldn't make the unit tests work without a way to destroy the ActivityListener we create internally so I return it as an IDisposable here. But we'll also need to also stop any ActivityProcessors/ActivityExporters on application shutdown right?
open-telemetry-opentelemetry-dotnet
.cs
@@ -592,7 +592,7 @@ class Commands: @command('wp') async def payto(self, destination, amount, fee=None, feerate=None, from_addr=None, from_coins=None, change_addr=None, - nocheck=False, unsigned=False, rbf=None, password=None, locktime=None, wallet: Abstract_Wallet = None): + ...
1
#!/usr/bin/env python # # Electrum - lightweight Bitcoin client # Copyright (C) 2011 thomasv@gitorious # # Permission is hereby granted, free of charge, to any person # obtaining a copy of this software and associated documentation files # (the "Software"), to deal in the Software without restriction, # including witho...
1
13,791
The default should be "False", as "True" would be a significant change in behaviour.
spesmilo-electrum
py
@@ -161,8 +161,16 @@ class Package(object): # Serialize DataFrame to chosen format if enumformat is PackageFormat.HDF5: - with pd.HDFStore(storepath, mode='w') as store: - store[self.DF_NAME] = df + # HACK: Force the use of old pickle to ensure Python 2/3 compati...
1
from enum import Enum import json import os from shutil import copyfile import tempfile import zlib import pandas as pd import requests from six import iteritems try: import fastparquet except ImportError: fastparquet = None try: import pyarrow as pa from pyarrow import parquet except ImportError: ...
1
14,941
since goal is to restore old_protocol, shouldn't we get it from pandas if possible? e.g. this will break if their source code changes.
quiltdata-quilt
py
@@ -299,7 +299,7 @@ class ErrorBaseline "\n" . ' php-version="' . "\n " . - implode("\n ", explode('&#10;&#9;', $matches[2])) . + str_replace('&#10;&#9;', "\n ", $matches[2]). "\n" . ...
1
<?php namespace Psalm; use function array_filter; use function array_intersect; use function array_map; use function array_merge; use function array_reduce; use function explode; use function get_loaded_extensions; use function implode; use function ksort; use const LIBXML_NOBLANKS; use function min; use const PHP_VER...
1
9,155
This should consume less resources because str_replace don't need to assign arrays with all the values
vimeo-psalm
php
@@ -240,6 +240,10 @@ static bool check_arg_types(pass_opt_t* opt, ast_t* params, ast_t* positional, { errorframe_t frame = NULL; ast_error_frame(&frame, arg, "argument not a subtype of parameter"); + ast_error_frame(&frame, arg, "argument type is %s", + ast_print_type(a_type...
1
#include "call.h" #include "postfix.h" #include "control.h" #include "literal.h" #include "reference.h" #include "../ast/astbuild.h" #include "../pkg/package.h" #include "../pass/expr.h" #include "../pass/sugar.h" #include "../type/alias.h" #include "../type/assemble.h" #include "../type/lookup.h" #include "../type/rei...
1
12,093
It would be better to pass `param` as the second argument here, so that the parameter declaration is printed alongside the type. Same thing for the changes in `ffi.c` and `lambda.c`.
ponylang-ponyc
c
@@ -27,6 +27,7 @@ import org.joda.time.DateTime; import azkaban.utils.JSONUtils; + public class Trigger { private static Logger logger = Logger.getLogger(Trigger.class);
1
/* * Copyright 2012 LinkedIn Corp. * * Licensed under the Apache License, Version 2.0 (the "License"); you may not * use this file except in compliance with the License. You may obtain a copy of * the License at * * http://www.apache.org/licenses/LICENSE-2.0 * * Unless required by applicable law or agreed to i...
1
13,121
Do we need to set the members to final like submitTime, submitUser ...? They are only used by getter method.
azkaban-azkaban
java
@@ -13,7 +13,7 @@ class MediaLibraryItem extends SystemMediaLibraryItem { public function __construct() { - traceLog('Class Cms\Classes\MediaLibraryItem has been deprecated, use System\Classes\MediaLibraryItem instead.'); + traceLog('Class ' . __CLASS__ . ' has been deprecated, use ' . SystemMe...
1
<?php namespace Cms\Classes; use System\Classes\MediaLibraryItem as SystemMediaLibraryItem; /** * Represents a file or folder in the Media Library. * * @package october\cms * @author Alexey Bobkov, Samuel Georges * @deprecated Use System\Classes\MediaLibraryItem. Remove if year >= 2020. */ class MediaLibraryIte...
1
12,954
That makes this error message incorrect; if someone has extended Cms\Classes\MediaLibraryItem, then this error message will read "Class My\Classes\CustomMediaLibraryItem has been deprecated".
octobercms-october
php
@@ -97,6 +97,6 @@ class Factory implements \Zend\ServiceManager\FactoryInterface $config = $sm->get('VuFind\Config')->get('config'); // Create service: - return new \VuFind\Mailer\Mailer($this->getTransport($config)); + return new \VuFind\Mailer\Mailer($this->getTransport($config), $co...
1
<?php /** * Factory for instantiating Mailer objects * * PHP version 5 * * Copyright (C) Villanova University 2009. * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License version 2, * as published by the Free Software Foundation. * * Th...
1
26,083
Is it worth injecting the whole configuration object for just one setting? Would it be more generic to pass an $options array with the override_from in it? I'm not completely opposed to passing $config, but since we've avoided it so far, it seems like it would be cleaner to maintain that separation. Simply adding a get...
vufind-org-vufind
php
@@ -44,3 +44,14 @@ const ( SDA_PIN = 26 SCL_PIN = 27 ) + +// SPI pins +const ( + SPI0_SCK_PIN = 25 + SPI0_MOSI_PIN = 23 + SPI0_MISO_PIN = 24 + + SPI1_SCK_PIN = 2 + SPI1_MOSI_PIN = 3 + SPI1_MISO_PIN = 4 +)
1
// +build nrf,pca10040 package machine // The PCA10040 has a low-frequency (32kHz) crystal oscillator on board. const HasLowFrequencyCrystal = true // LEDs on the PCA10040 (nRF52832 dev board) const ( LED = LED1 LED1 = 17 LED2 = 18 LED3 = 19 LED4 = 20 ) // Buttons on the PCA10040 (nRF52832 dev board) const ( ...
1
6,156
Just curious: where do these pin numbers come from? I see you took the SPI0 pin numbers from the Arduino board layout which is good, but I can't find such a relation for `SPI1`.
tinygo-org-tinygo
go
@@ -450,10 +450,14 @@ public final class MethodTypeResolution { Class<?> contextClass = context.getType(); // search the class - for (Method method : contextClass.getDeclaredMethods()) { - if (isMethodApplicable(method, methodName, argArity, accessingClass, typeArguments)) { - ...
1
/** * BSD-style license; for more info see http://pmd.sourceforge.net/license.html */ package net.sourceforge.pmd.lang.java.typeresolution; import static net.sourceforge.pmd.lang.java.typeresolution.typeinference.InferenceRuleType.LOOSE_INVOCATION; import static net.sourceforge.pmd.lang.java.typeresolution.typeinfe...
1
13,007
Isn't that already too late? I'd expect, that the LinkageError occurs the first time, we have the class instance (the classloader tried to load the class) - or do we get a partially linked class back, and we get the exception when retrieving the methods?
pmd-pmd
java
@@ -31,7 +31,7 @@ import ( const ( supportedVersion = 0 maxVersion = 254 - traceparentHeader = "traceparent" + TraceparentHeader = "Traceparent" ) type httpTraceContextPropagator struct{}
1
// Copyright 2019, OpenTelemetry Authors // // Licensed under the Apache License, Version 2.0 (the "License"); // you may not use this file except in compliance with the License. // You may obtain a copy of the License at // // http://www.apache.org/licenses/LICENSE-2.0 // // Unless required by applicable law or ag...
1
9,880
nit:s/Traceparent/traceparent/ - As per the spec header name is all lowercase.
open-telemetry-opentelemetry-go
go
@@ -484,3 +484,16 @@ type ErrDockerfileNotFound struct { func (e *ErrDockerfileNotFound) Error() string { return fmt.Sprintf("no Dockerfiles found within %s or a sub-directory level below", e.dir) } + +// RelPath returns the path relative to the current working directory. +func RelPath(fullPath string) (string, err...
1
// Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved. // SPDX-License-Identifier: Apache-2.0 // Package workspace contains functionality to manage a user's local workspace. This includes // creating an application directory, reading and writing a summary file to associate the workspace with the applica...
1
15,487
We need to have unit tests for it since it is now a public function. Also I'm not a fan for making this movement since `relPath` doesn't consume any info in this pkg.
aws-copilot-cli
go
@@ -5,16 +5,11 @@ */ package edu.harvard.iq.dataverse.datasetutility; -import edu.harvard.iq.dataverse.DataFile; +import edu.harvard.iq.dataverse.*; import edu.harvard.iq.dataverse.DataFile.ChecksumType; -import edu.harvard.iq.dataverse.DataFileServiceBean; -import edu.harvard.iq.dataverse.Dataset; -import edu.ha...
1
/* * To change this license header, choose License Headers in Project Properties. * To change this template file, choose Tools | Templates * and open the template in the editor. */ package edu.harvard.iq.dataverse.datasetutility; import edu.harvard.iq.dataverse.DataFile; import edu.harvard.iq.dataverse.DataFile.Ch...
1
44,437
We generally avoid wildcard imports. If you feel like changing it back, great. Otherwise, no big deal.
IQSS-dataverse
java
@@ -51,7 +51,7 @@ // dispatcher := yarpc.NewDispatcher(yarpc.Config{ // Name: "myservice", // Outbounds: yarpc.OUtbounds{ -// {Unary: myserviceOutbound}, +// "outboundservice": {Unary: myserviceOutbound}, // }, // }) //
1
// Copyright (c) 2018 Uber Technologies, Inc. // // Permission is hereby granted, free of charge, to any person obtaining a copy // of this software and associated documentation files (the "Software"), to deal // in the Software without restriction, including without limitation the rights // to use, copy, modify, merge...
1
16,223
We also have a typo on the line above! OUt or Out?
yarpc-yarpc-go
go
@@ -7,5 +7,7 @@ <%= @step.action_name %> <%= generate_approve_url(@step) %> -<%= t("mailer.step_mailer.proposal_notification.cta") %> -<%= proposal_url(@proposal, anchor: "comments") %> +<%= t("mailer.view_request_cta") %> +<%= proposal_url(@proposal) %> + +<%= t("mailer.footer", feedback_url: feedback_url) %>
1
<%= t("mailer.step_mailer.proposal_notification.header", requester_name: @proposal.requester.full_name, step_type_noun: @step.noun) %> <%= t("mailer.step_mailer.proposal_notification.step_status") %> <%= @step.action_name %> <%= generate_approve_url(@step) %> <%= t("mailer.step_mailer.proposal_notification.c...
1
16,848
OH! These are text.... (Ignore above)
18F-C2
rb
@@ -98,7 +98,6 @@ class Reader implements DataSourceReader, SupportsScanColumnarBatch, SupportsPus private List<Expression> filterExpressions = null; private Filter[] pushedFilters = NO_FILTERS; private final boolean localityPreferred; - private final int batchSize; private final boolean readTimestampWitho...
1
/* * Licensed to the Apache Software Foundation (ASF) under one * or more contributor license agreements. See the NOTICE file * distributed with this work for additional information * regarding copyright ownership. The ASF licenses this file * to you under the Apache License, Version 2.0 (the * "License"); you ...
1
42,105
How was this set before? Was it just ignored?
apache-iceberg
java
@@ -0,0 +1,12 @@ +class CreditCardsController < ApplicationController + def update + customer = Stripe::Customer.retrieve(current_user.stripe_customer_id) + customer.card = params['stripe_token'] + begin + customer.save + redirect_to my_account_path, notice: I18n.t('subscriptions.flashes.update.succ...
1
1
8,049
Should we `save!` here?
thoughtbot-upcase
rb
@@ -284,7 +284,7 @@ void TServerSocket::listen() { hints.ai_family = PF_UNSPEC; hints.ai_socktype = SOCK_STREAM; hints.ai_flags = AI_PASSIVE | AI_ADDRCONFIG; - sprintf(port, "%d", port_); + snprintf(port, sizeof("65535"), "%d", port_); // If address is not specified use wildcard address (NULL) TGetAd...
1
/* * Licensed to the Apache Software Foundation (ASF) under one * or more contributor license agreements. See the NOTICE file * distributed with this work for additional information * regarding copyright ownership. The ASF licenses this file * to you under the Apache License, Version 2.0 (the * "License"); you ma...
1
12,095
sizeof(port) seems ever-so-slightly clearer.
apache-thrift
c
@@ -116,6 +116,12 @@ type Rule struct { // conjunction with NetworkPolicySpec/ClusterNetworkPolicySpec.AppliedTo. // +optional AppliedTo []NetworkPolicyPeer `json:"appliedTo,omitempty"` + // SourceGroups is a list of ClusterGroup names which must be set as the + // source for this rule. + SourceGroups []string `j...
1
// Copyright 2020 Antrea Authors // // Licensed under the Apache License, Version 2.0 (the "License"); // you may not use this file except in compliance with the License. // You may obtain a copy of the License at // // http://www.apache.org/licenses/LICENSE-2.0 // // Unless required by applicable law or agreed to ...
1
31,043
Not sure if this has been discussed. I wonder why SourceGroups and DestinationGroups are not in From and To NetworkPolicyPeer as NetworkPolicyPeer already describes the source/destination of the traffic.
antrea-io-antrea
go
@@ -151,6 +151,19 @@ class Completer(QObject): except KeyError: # No completion model for this section/option. model = None + elif completion == usertypes.Completion.keybinding: + # look for --mode to provide mode-specific binding completions + ...
1
# vim: ft=python fileencoding=utf-8 sts=4 sw=4 et: # Copyright 2014-2016 Florian Bruhin (The Compiler) <mail@qutebrowser.org> # # This file is part of qutebrowser. # # qutebrowser is free software: you can redistribute it and/or modify # it under the terms of the GNU General Public License as published by # the Free S...
1
14,623
This doesn't account for `:bind --mode caret ...` (i.e. `--mode caret` instead of `--mode=caret`; both work). Do you see an easy way to make that work?
qutebrowser-qutebrowser
py
@@ -41,7 +41,8 @@ var ( errorPriority = map[reflect.Type]int{ reflect.TypeOf(&p.ShardOwnershipLostError{}): 0, reflect.TypeOf(&p.CurrentWorkflowConditionFailedError{}): 1, - reflect.TypeOf(&p.ConditionFailedError{}): 2, + reflect.TypeOf(&p.WorkflowConditionFailedError{}): 2, ...
1
// The MIT License // // Copyright (c) 2020 Temporal Technologies Inc. All rights reserved. // // Copyright (c) 2020 Uber Technologies, Inc. // // Permission is hereby granted, free of charge, to any person obtaining a copy // of this software and associated documentation files (the "Software"), to deal // in the Soft...
1
12,170
Is this map used for durable state anywhere? If so we probably want to keep ConditionFailedError as 2
temporalio-temporal
go
@@ -25,6 +25,7 @@ type roundTripperOpts struct { } var dialAddr = quic.DialAddr +var methodHEAD = "HEAD" // client is a HTTP2 client doing QUIC requests type client struct {
1
package h2quic import ( "crypto/tls" "errors" "fmt" "io" "net" "net/http" "strings" "sync" "golang.org/x/net/http2" "golang.org/x/net/http2/hpack" "golang.org/x/net/idna" quic "github.com/lucas-clemente/quic-go" "github.com/lucas-clemente/quic-go/internal/protocol" "github.com/lucas-clemente/quic-go/in...
1
6,408
You can use `http.MethodHead` here.
lucas-clemente-quic-go
go
@@ -0,0 +1,5 @@ +package org.openqa.selenium.grid.session.remote; + +public class SessionTest { + +}
1
1
16,858
And another empty test. Please remove until there's content.
SeleniumHQ-selenium
py
@@ -2,9 +2,9 @@ define(["localassetmanager"], function(localassetmanager) { "use strict"; function processDownloadStatus(apiClient, serverInfo, options) { - return console.log("[mediasync] Begin processDownloadStatus"), localassetmanager.resyncTransfers().then(function() { + return console.deb...
1
define(["localassetmanager"], function(localassetmanager) { "use strict"; function processDownloadStatus(apiClient, serverInfo, options) { return console.log("[mediasync] Begin processDownloadStatus"), localassetmanager.resyncTransfers().then(function() { return localassetmanager.getServerI...
1
13,293
You really didn't need to do any of these, we need to remove the API client from source eventually anyway.
jellyfin-jellyfin-web
js
@@ -58,6 +58,9 @@ import org.tikv.kvproto.Pdpb.TsoResponse; public class PDClient extends AbstractGRPCClient<PDBlockingStub, PDStub> implements ReadOnlyPDClient { + + private TiSession session; + private RequestHeader header; private TsoRequest tsoReq; private volatile LeaderWrapper leaderWrapper;
1
/* * Copyright 2017 PingCAP, Inc. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. * You may obtain a copy of the License at * * http://www.apache.org/licenses/LICENSE-2.0 * * Unless required by applicable law or agreed ...
1
9,181
seems pretty strange here because TiSession contains PDClient.
pingcap-tispark
java
@@ -73,4 +73,11 @@ class NotesControllerTest < ActionDispatch::IntegrationTest assert_response :success assert_select "table.note_list tr", :count => 11 end + + def test_empty_page + user = create(:user) + get user_notes_path(:display_name => user.display_name) + assert_response :success + ass...
1
require "test_helper" class NotesControllerTest < ActionDispatch::IntegrationTest def setup super # Stub nominatim response for note locations stub_request(:get, %r{^https://nominatim\.openstreetmap\.org/reverse\?}) .to_return(:status => 404) end ## # test all routes which lead to this contr...
1
13,306
I created a test method for this scenario. Would you normally split it out like that or bundle this into one of the existing test methods? I'm more accustomed to creating lots of separate `it` blocks in nested `context` blocks in rspec
openstreetmap-openstreetmap-website
rb
@@ -76,6 +76,8 @@ public abstract class NewSessionQueuer implements HasReadyState, Routable { .with(requiresSecret), get("/se/grid/newsessionqueuer/queue/size") .to(() -> new GetNewSessionQueueSize(tracer, this)), + get("/se/grid/newsessionqueue") + .to(() -> new GetSessionQueue(tra...
1
// Licensed to the Software Freedom Conservancy (SFC) under one // or more contributor license agreements. See the NOTICE file // distributed with this work for additional information // regarding copyright ownership. The SFC licenses this file // to you under the Apache License, Version 2.0 (the // "License"); you m...
1
18,614
should it be `newsessionqueue` or `newsessionqueuer`? In case we'd like to be consistent
SeleniumHQ-selenium
js
@@ -5463,6 +5463,13 @@ public class IndexWriter implements Closeable, TwoPhaseCommit, Accountable, throw new IllegalArgumentException("number of documents in the index cannot exceed " + actualMaxDocs + " (current document count is " + pendingNumDocs.get() + "; added numDocs is " + addedNumDocs + ")"); } + /*...
1
/* * Licensed to the Apache Software Foundation (ASF) under one or more * contributor license agreements. See the NOTICE file distributed with * this work for additional information regarding copyright ownership. * The ASF licenses this file to You under the Apache License, Version 2.0 * (the "License"); you may ...
1
37,480
Maybe add `@lucene.experimental`? We are exposing (slightly) internal details about `IndexWriter` so maybe we need to reserve the right to change this API in the future ...
apache-lucene-solr
java
@@ -676,7 +676,10 @@ module Beaker def sleep_until_puppetdb_started(host, nonssl_port = nil, ssl_port = nil) nonssl_port = options[:puppetdb_port_nonssl] if nonssl_port.nil? ssl_port = options[:puppetdb_port_ssl] if ssl_port.nil? - curl_with_retries("start puppetdb", host, "http:...
1
require 'timeout' require 'inifile' require 'resolv' module Beaker module DSL module Helpers # Methods that help you interact with your puppet installation, puppet must be installed # for these methods to execute correctly module PuppetHelpers # Return the regular expression pattern fo...
1
14,337
@johnduarte I know this isn't part of your code change, but it seems to me that this `curl_with_retries` is not necessary. If the `retry_on` host command is successful, isn't puppetdb ostensibly listening to the ssl port as well? What do you think about removing that `curl_with_retries` after the `retry_on`?
voxpupuli-beaker
rb
@@ -17,13 +17,15 @@ package labelindex import ( log "github.com/Sirupsen/logrus" + "github.com/projectcalico/felix/set" "github.com/projectcalico/libcalico-go/lib/selector" + "github.com/projectcalico/libcalico-go/lib/selector/parser" ) type Index interface { UpdateSelector(id interface{}, sel selector.Sel...
1
// Copyright (c) 2016-2017 Tigera, Inc. All rights reserved. // Licensed under the Apache License, Version 2.0 (the "License"); // you may not use this file except in compliance with the License. // You may obtain a copy of the License at // // http://www.apache.org/licenses/LICENSE-2.0 // // Unless required by ap...
1
15,217
Does an empty struct really take less storage than a bool? I guess it must be, or else you wouldn't have changed this, but I'm curious about the detail.
projectcalico-felix
go
@@ -259,6 +259,12 @@ class EditableTextWithoutAutoSelectDetection(EditableText): This should be used when an object does not notify of selection changes. """ + def waitForAndSpeakSelectionChange(self, oldTextInfo): + api.processPendingEvents(processEventQueue=False) + newInfo=self.makeTextInfo(textInfos.POSITIO...
1
#editableText.py #A part of NonVisual Desktop Access (NVDA) #This file is covered by the GNU General Public License. #See the file COPYING for more details. #Copyright (C) 2006-2012 NV Access Limited """Common support for editable text. @note: If you want editable text functionality for an NVDAObject, you sho...
1
17,956
nit: This should perhaps be called `waitForAndReportSelectionChange`, as it affects braille as well, not just speech.
nvaccess-nvda
py
@@ -127,10 +127,14 @@ class ProxyListenerSNS(ProxyListener): elif req_action == 'CreateTopic': topic_arn = aws_stack.sns_topic_arn(req_data['Name'][0]) - self._extract_tags(topic_arn, req_data) + tag_error_response = self._extract_tags(topic_arn, req_data, T...
1
import ast import json import uuid import logging import traceback import six import requests import xmltodict from flask import Response as FlaskResponse from requests.models import Response, Request from six.moves.urllib import parse as urlparse from localstack.config import external_service_url from localstack.const...
1
11,061
nit: I suggest that we rename `tag_error_response` to `tag_resource_success`, as later in line 132 we're returning an error if this value is *not* truthy.
localstack-localstack
py
@@ -0,0 +1,15 @@ +<?php + +declare(strict_types=1); + +namespace Shopsys\ShopBundle\Controller\Styleguide; + +use Shopsys\ShopBundle\Controller\Front\FrontBaseController; + +class StyleguideController extends FrontBaseController +{ + public function styleguideAction() + { + return $this->render('@ShopsysSh...
1
1
19,677
I am missing return typehint
shopsys-shopsys
php
@@ -0,0 +1,8 @@ +_base_ = [ + 'retinanet_pvt-t_fpn_1x_coco.py', +] +model = dict( + backbone=dict( + num_layers=[3, 4, 6, 3], + init_cfg=dict(checkpoint='https://github.com/whai362/PVT/' + 'releases/download/v2/pvt_small.pth')))
1
1
25,037
_base_ = 'retinanet_pvt-t_fpn_1x_coco.py'
open-mmlab-mmdetection
py
@@ -394,11 +394,12 @@ public class OAuthWebviewHelper implements KeyChainAliasCallback { private class SwapJWTForAccessTokenTask extends BaseFinishAuthFlowTask<LoginOptions> { @Override - protected TokenEndpointResponse performRequest(LoginOptions options) { + protected TokenEndpointRespon...
1
/* * Copyright (c) 2011-2015, salesforce.com, inc. * All rights reserved. * Redistribution and use of this software in source and binary forms, with or * without modification, are permitted provided that the following conditions * are met: * - Redistributions of source code must retain the above copyright notice,...
1
15,517
We should remove `throws Exception` here, since we're catching it anyway and triggering `onAuthFlowError`.
forcedotcom-SalesforceMobileSDK-Android
java
@@ -0,0 +1,18 @@ +package ps + +import "gx/ipfs/QmepvmmYNM6q4RaUiwEikQFhgMFHXg2PLhx2E9iaRd3jmS/go-libp2p-pubsub" + +// Publisher publishes to pubsub topics +type Publisher struct { + pubsub *pubsub.PubSub +} + +// NewPublisher builds a new publisher +func NewPublisher(sub *pubsub.PubSub) *Publisher { + return &Publishe...
1
1
17,039
a super thin wrapper like this makes me think we should consider not having it, instead just defining in the plumbing.api the publisher and subscriber interfaces we expect a ps dependency passed in to support and then to pass calls directly to that thing rather than through this wrapper
filecoin-project-venus
go
@@ -93,7 +93,7 @@ public class Docker { throw new WebDriverException("Unable to pull container: " + name); } - LOG.info(String.format("Pull of %s:%s complete", name, tag)); + LOG.fine(String.format("Pull of %s:%s complete", name, tag)); return findImage(new ImageNamePredicate(name, tag)) ...
1
// Licensed to the Software Freedom Conservancy (SFC) under one // or more contributor license agreements. See the NOTICE file // distributed with this work for additional information // regarding copyright ownership. The SFC licenses this file // to you under the Apache License, Version 2.0 (the // "License"); you m...
1
17,123
Waiting for the pull takes a long time. This message informs the user that at least one of the images being pulled is available. Please leave.
SeleniumHQ-selenium
py
@@ -67,10 +67,12 @@ setup( "configargparse>=0.10, <0.11", "construct>=2.5.2, <2.6", "cryptography>=1.3, <1.5", + "cssutils>=1.0.1, <1.1", "Flask>=0.10.1, <0.12", "h2>=2.4.0, <3", "html2text>=2016.1.8, <=2016.5.29", "hyperframe>=4.0.1, <5", + "...
1
from setuptools import setup, find_packages from codecs import open import os from netlib import version # Based on https://github.com/pypa/sampleproject/blob/master/setup.py # and https://python-packaging-user-guide.readthedocs.org/ here = os.path.abspath(os.path.dirname(__file__)) with open(os.path.join(here, 'RE...
1
12,006
We should set a 1.7 upper bound for this as well. :smiley:
mitmproxy-mitmproxy
py
@@ -39,11 +39,14 @@ import Spinner from 'GoogleComponents/spinner'; import SettingsOverlay from 'GoogleComponents/settings/settings-overlay'; import GenericError from 'GoogleComponents/notifications/generic-error'; -const { Component, Fragment } = wp.element; -const { __, sprintf } = wp.i18n; -const { filter, map }...
1
/** * SettingsModule component. * * Site Kit by Google, Copyright 2019 Google LLC * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. * You may obtain a copy of the License at * * https://www.apache.org/licenses/LICENSE-2.0 ...
1
24,794
Lodash mixed in with WordPress dependencies
google-site-kit-wp
js
@@ -22,10 +22,10 @@ class StripeEvents if subscription = Subscription.find_by(stripe_id: stripe_subscription.id) subscription else - Airbrake.notify_or_ignore( + Honeybadger.notify( error_message: "No subscription found for #{stripe_subscription.id}", error_class: "StripeEve...
1
class StripeEvents def initialize(event) @event = event end def customer_subscription_deleted if subscription Cancellation.new(subscription: subscription).process end end def customer_subscription_updated if subscription subscription.write_plan(sku: stripe_subscription.plan.id) ...
1
16,925
Put a comma after the last parameter of a multiline method call.
thoughtbot-upcase
rb
@@ -0,0 +1,11 @@ +describe "User can manage their own profile" do + it "allows editing of name" do + user = create(:user) + login_as(user) + visit "/me" + fill_in :first_name, with: "Some" + fill_in :last_name, with: "Body" + click_button "Update profile" + expect(page).to have_content("Welcome, S...
1
1
15,454
perhaps we should test that users cannot edit the profiles of others?
18F-C2
rb
@@ -43,7 +43,7 @@ class TestMasterSecretLogger(tservers.ServerTestBase): tls.log_master_secret.close() with open(logfile, "rb") as f: - assert f.read().count(b"CLIENT_RANDOM") >= 2 + assert f.read().count(b"SERVER_HANDSHAKE_TRAFFIC_SECRET") >= 2 tls.l...
1
import io import pytest from mitmproxy import exceptions from mitmproxy.net import tls from mitmproxy.net.tcp import TCPClient from test.mitmproxy.net.test_tcp import EchoHandler from . import tservers CLIENT_HELLO_NO_EXTENSIONS = bytes.fromhex( "03015658a756ab2c2bff55f636814deac086b7ca56b65058c7893ffc6074f5245f...
1
15,275
Does this mean the content changed with the new pyopenssl version? Is Wireshark already compatible with this new format?
mitmproxy-mitmproxy
py
@@ -618,7 +618,7 @@ func TestCachedBatch(t *testing.T) { } func TestSTXCachedBatch(t *testing.T) { - ws := newStateTX(0, db.NewMemKVStore(), []protocol.ActionHandler{account.NewProtocol(config.NewHeightUpgrade(config.Default))}) + ws := newStateTX(0, db.NewMemKVStore(), []protocol.ActionHandler{account.NewProtocol(...
1
// Copyright (c) 2019 IoTeX Foundation // This is an alpha (internal) release and is not suitable for production. This source code is provided 'as is' and no // warranties are given as to title or non-infringement, merchantability or fitness for purpose and, to the extent // permitted by law, all liability for your use...
1
19,224
line is 147 characters (from `lll`)
iotexproject-iotex-core
go
@@ -65,6 +65,7 @@ confspec = ConfigObj(StringIO( #possible log levels are DEBUG, IO, DEBUGWARNING, INFO loggingLevel = string(default="INFO") showWelcomeDialogAtStartup = boolean(default=true) + showSpeechViewerAtStartup = boolean(default=false) # Speech settings [speech]
1
"""Manages NVDA configuration. """ import globalVars import _winreg import ctypes import ctypes.wintypes import os import sys from cStringIO import StringIO import itertools import contextlib from collections import OrderedDict from configobj import ConfigObj, ConfigObjError from validate import Validat...
1
18,201
Perhaps move this option into a separate speechViewer section, as we are planning to also save position information as well.
nvaccess-nvda
py
@@ -22,4 +22,9 @@ interface SegmentProductsQueryInterface * @return array */ public function getProductsByType(SegmentId $segmentId, string $type): array; + + /** + * @return array + */ + public function getAllEditedProducts(SegmentId $segmentId, ?\DateTime $dateTime = null): array; }
1
<?php /** * Copyright © Ergonode Sp. z o.o. All rights reserved. * See LICENSE.txt for license details. */ declare(strict_types=1); namespace Ergonode\Segment\Domain\Query; use Ergonode\SharedKernel\Domain\Aggregate\SegmentId; interface SegmentProductsQueryInterface { /** * @return string[] */ ...
1
9,742
This is not a segment responsibility this query should be in exporter-File module
ergonode-backend
php
@@ -174,6 +174,8 @@ class ClangTidy(analyzer_base.SourceAnalyzer): analyzer_cmd.append(self.source_file) + analyzer_cmd.extend(['--export-fixes', result_handler.fixit_file]) + analyzer_cmd.append("--") analyzer_cmd.append('-Qunused-arguments')
1
# ------------------------------------------------------------------------- # # Part of the CodeChecker project, under the Apache License v2.0 with # LLVM Exceptions. See LICENSE for license information. # SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception # # ---------------------------------------------------...
1
11,990
Did you measure the performance with and without this option. Do we want to export fixits even if the `clang-apply-replacements` tool is not available in the user's PATH?
Ericsson-codechecker
c
@@ -19,12 +19,12 @@ package v1alpha1 import ( apis "github.com/openebs/maya/pkg/apis/openebs.io/ndm/v1alpha1" "github.com/pkg/errors" - "k8s.io/apimachinery/pkg/apis/meta/v1" + metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" ) // Get is spc client implementation to get disk. func (s *SpcObjectClient) Get(name s...
1
/* Copyright 2019 The OpenEBS Authors Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, soft...
1
15,892
What if we do not change this file ? Are we using this `pkg/disk/v1alpha1` elsewhere for block device requirement?
openebs-maya
go
@@ -27,7 +27,7 @@ module Bolt non_interactive: true } - options[:port] = @port if @port + options[:port] = port if port options[:password] = @password if @password options[:keys] = @key if @key options[:verify_host_key] = if @insecure
1
require 'json' require 'shellwords' require 'logging' require 'net/ssh' require 'net/scp' require 'bolt/node/output' module Bolt class SSH < Node def self.initialize_transport(logger) require 'net/ssh/krb' rescue LoadError logger.debug { "Authentication method 'gssapi-with-mic' is not ava...
1
7,470
regarding dropping the port/host/uri methods on Nod: this would `options[:port] = target.port if target.port`
puppetlabs-bolt
rb