instance_id stringlengths 17 39 | repo stringclasses 8
values | issue_id stringlengths 14 34 | pr_id stringlengths 14 34 | linking_methods listlengths 1 3 | base_commit stringlengths 40 40 | merge_commit stringlengths 0 40 ⌀ | hints_text listlengths 0 106 | resolved_comments listlengths 0 119 | created_at timestamp[ns, tz=UTC] | labeled_as listlengths 0 7 | problem_title stringlengths 7 174 | problem_statement stringlengths 0 55.4k | gold_files listlengths 0 10 | gold_files_postpatch listlengths 1 10 | test_files listlengths 0 60 | gold_patch stringlengths 220 5.83M | test_patch stringlengths 386 194k ⌀ | split_random stringclasses 3
values | split_time stringclasses 3
values | issue_start_time timestamp[ns] | issue_created_at timestamp[ns, tz=UTC] | issue_by_user stringlengths 3 21 | split_repo stringclasses 3
values |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
provectus/kafka-ui/1520_1524 | provectus/kafka-ui | provectus/kafka-ui/1520 | provectus/kafka-ui/1524 | [
"timestamp(timedelta=0.0, similarity=0.9533965407773565)"
] | 42a004af1c46e10c1c127472edcb02f78f601675 | 4390923e482c08d1e27ff0e1e783231f9fc6ee5c | [] | [] | 2022-01-31T15:46:15Z | [
"type/bug",
"scope/frontend",
"status/accepted",
"status/confirmed",
"type/regression"
] | Too short visible list for Schema compatibility level selector | ### Is your proposal related to a problem?
<!--
Provide a clear and concise description of what the problem is.
For example, "I'm always frustrated when..."
-->
(Write your answer here.)
There is list of 3 levels (other are invisible) on Schema overview and Schema Edit pages (see attachment)
There is a ... | [
"kafka-ui-react-app/src/components/Connect/List/__tests__/__snapshots__/ListItem.spec.tsx.snap",
"kafka-ui-react-app/src/components/Topics/Topic/Details/__test__/__snapshots__/Details.spec.tsx.snap",
"kafka-ui-react-app/src/components/common/Select/Select.styled.ts",
"kafka-ui-react-app/src/theme/theme.ts"
] | [
"kafka-ui-react-app/src/components/Connect/List/__tests__/__snapshots__/ListItem.spec.tsx.snap",
"kafka-ui-react-app/src/components/Topics/Topic/Details/__test__/__snapshots__/Details.spec.tsx.snap",
"kafka-ui-react-app/src/components/common/Select/Select.styled.ts",
"kafka-ui-react-app/src/theme/theme.ts"
] | [] | diff --git a/kafka-ui-react-app/src/components/Connect/List/__tests__/__snapshots__/ListItem.spec.tsx.snap b/kafka-ui-react-app/src/components/Connect/List/__tests__/__snapshots__/ListItem.spec.tsx.snap
index 0f83bd30884..282738e8de0 100644
--- a/kafka-ui-react-app/src/components/Connect/List/__tests__/__snapshots__/Li... | null | val | train | 2022-02-01T11:14:05 | 2022-01-31T09:06:16Z | agolosen | train |
provectus/kafka-ui/1556_1568 | provectus/kafka-ui | provectus/kafka-ui/1556 | provectus/kafka-ui/1568 | [
"timestamp(timedelta=1.0, similarity=0.8694037738763447)"
] | 6424a88acadc1f85cabf66a982cbe08ee7e11914 | 136f12d76ac8d65233d13cbf7301ac5cb9873ad4 | [
"Hi, thanks for reaching out.\r\n\r\nAn example comes within #1568. \r\n\r\nLet me know if you more questions!",
"Hi, thank you for the answer.\r\n",
"An example is located [here](https://github.com/provectus/kafka-ui/blob/master/documentation/compose/kafka-ssl.yml).",
"Hi, no changes on my side.\r\nI tried t... | [
"I think we dont need this constants here, pls move/embed to KafkaSSLManager",
"minor, but I think naming is vague and too general here",
"Why do we need this special config? Could we just push these params?",
"Discussed, found the problem, turns out it does work with properties.",
"location of this this fi... | 2022-02-07T15:18:10Z | [
"type/documentation",
"status/duplicate"
] | Kafka with SSL doesn't work | Hello.
Try connect to three kafka brokers.
KAFKA_CLUSTERS_0 have not security and all ok
KAFKA_CLUSTERS_1 and KAFKA_CLUSTERS_2 have SSL.
in docker compose add certs and all configs.
as a result, kafka without ssl is only connected, two othert crash with exception
**Caused by: org.apache.kafka.common.errors.Clus... | [
"README.md",
"documentation/compose/DOCKER_COMPOSE.md"
] | [
"README.md",
"documentation/compose/DOCKER_COMPOSE.md",
"documentation/compose/kafka-ssl.yml",
"documentation/compose/ssl/creds",
"documentation/compose/ssl/generate_certs.sh"
] | [] | diff --git a/README.md b/README.md
index 10e61d65c0f..55deb5f4a0f 100644
--- a/README.md
+++ b/README.md
@@ -65,6 +65,18 @@ To run UI for Apache Kafka, you can use a pre-built Docker image or build it loc
We have plenty of [docker-compose files](documentation/compose/DOCKER_COMPOSE.md) as examples. They're built for... | null | val | train | 2022-02-08T10:42:15 | 2022-02-05T22:19:20Z | iamtechnomage | train |
provectus/kafka-ui/1591_1595 | provectus/kafka-ui | provectus/kafka-ui/1591 | provectus/kafka-ui/1595 | [
"timestamp(timedelta=0.0, similarity=1.0000000000000002)"
] | 217f0ead0d871205f7a05062cdf56649b8eecc79 | 95a9047114b499c61e478c584ea14c66d7d8ef3e | [
"Hello there montebove! 👋\n\nThank you and congratulations 🎉 for opening your very first issue in this project! 💖\n\nIn case you want to claim this issue, please comment down below! We will try to get back to you as soon as we can. 👀",
"Hi @montebove \r\n\r\n> 2)Modify generated server to create an Internal L... | [] | 2022-02-13T09:58:42Z | [
"type/bug",
"status/accepted",
"scope/k8s"
] | Specify distinct image tag version for helm chart | **Describe the bug**
Trying to upgrade to last 3.3 version after the kafka-ui started, when trying to access to the Web UI I get immediately disconnected and in containers log I see these lines:
`15:45:34.875 [parallel-1] DEBUG com.provectus.kafka.ui.service.MetricsUpdateService - Start getting metrics for kafkaClus... | [
".github/workflows/release.yaml",
"charts/kafka-ui/values.yaml"
] | [
".github/workflows/release.yaml",
"charts/kafka-ui/values.yaml"
] | [] | diff --git a/.github/workflows/release.yaml b/.github/workflows/release.yaml
index a88c7d05d81..12c11a771d2 100644
--- a/.github/workflows/release.yaml
+++ b/.github/workflows/release.yaml
@@ -109,6 +109,7 @@ jobs:
run: |
export version=${{needs.release.outputs.version}}
sed -i "s/version... | null | val | train | 2022-02-13T12:08:37 | 2022-02-11T15:57:21Z | montebove | train |
provectus/kafka-ui/1604_1605 | provectus/kafka-ui | provectus/kafka-ui/1604 | provectus/kafka-ui/1605 | [
"timestamp(timedelta=1.0, similarity=0.9517366317775952)"
] | 4862687956ad7880332d26aecc047064a524b0e9 | da27d3c844373cfb61ee78a4047311d9a592d91e | [] | [] | 2022-02-15T08:25:14Z | [
"type/bug",
"status/accepted",
"status/confirmed",
"scope/infrastructure"
] | Fix release and tag naming | Need to name release and tag as it was previously.
```
Release name: 0.3.2
Tag name: v0.3.2
``` | [
".github/release_drafter.yaml"
] | [
".github/release_drafter.yaml"
] | [] | diff --git a/.github/release_drafter.yaml b/.github/release_drafter.yaml
index 21ad76787bc..952d2b5d905 100644
--- a/.github/release_drafter.yaml
+++ b/.github/release_drafter.yaml
@@ -1,5 +1,5 @@
-name-template: 'v$RESOLVED_VERSION'
-tag-template: '$RESOLVED_VERSION'
+name-template: '$RESOLVED_VERSION'
+tag-template: ... | null | test | train | 2022-02-15T12:01:40 | 2022-02-15T08:22:21Z | 5hin0bi | train |
provectus/kafka-ui/1606_1607 | provectus/kafka-ui | provectus/kafka-ui/1606 | provectus/kafka-ui/1607 | [
"timestamp(timedelta=0.0, similarity=0.9492560378155623)"
] | ce8627ea59be60367c3d824375dd3feca6f8479a | 4862687956ad7880332d26aecc047064a524b0e9 | [] | [] | 2022-02-15T10:15:31Z | [
"type/bug",
"status/accepted",
"status/confirmed",
"scope/infrastructure"
] | [Bug] Fix workflow for documentation | Documentation is not triggered due to incorrect path filters. Need to fix. | [
".github/workflows/documentation.yaml"
] | [
".github/workflows/documentation.yaml"
] | [] | diff --git a/.github/workflows/documentation.yaml b/.github/workflows/documentation.yaml
index 2a1171394dc..464af01fe80 100644
--- a/.github/workflows/documentation.yaml
+++ b/.github/workflows/documentation.yaml
@@ -7,8 +7,8 @@ on:
- reopened
- synchronize
paths:
- - 'documentation/*'
- - ... | null | test | train | 2022-02-14T19:26:51 | 2022-02-15T10:13:03Z | 5hin0bi | train |
provectus/kafka-ui/1608_1645 | provectus/kafka-ui | provectus/kafka-ui/1608 | provectus/kafka-ui/1645 | [
"timestamp(timedelta=0.0, similarity=0.8484217522077585)"
] | 8125814eed049c2f91f53c140b5f9221d8a45bd4 | b8761b500de0609a2e1fe94f6f47151a6f4b7722 | [] | [] | 2022-02-21T10:43:31Z | [
"status/accepted",
"scope/infrastructure",
"type/feature"
] | [Feature] Add workflow to check workflows in .github/workflows/** | Currently we have required job build-and-test for different paths that pull requests affect.
However, we lack the job for changes in workflows path and merges are possible only with admin privileges.
The task is to add the workflow that will contain build-and-test job for changes in .github/workflows/** path. | [
".github/workflows/aws_publisher.yaml",
".github/workflows/helm.yaml",
".github/workflows/release_drafter.yml",
".github/workflows/welcome-first-time-contributors.yml"
] | [
".github/workflows/aws_publisher.yaml",
".github/workflows/helm.yaml",
".github/workflows/release_drafter.yml",
".github/workflows/welcome-first-time-contributors.yml",
".github/workflows/workflow_linter.yaml"
] | [] | diff --git a/.github/workflows/aws_publisher.yaml b/.github/workflows/aws_publisher.yaml
index 052f4e8ed9e..39468d4dde3 100644
--- a/.github/workflows/aws_publisher.yaml
+++ b/.github/workflows/aws_publisher.yaml
@@ -48,4 +48,4 @@ jobs:
arguments: "-color=false -on-error=abort -var=kafka_ui_release_version=$... | null | train | train | 2022-02-21T10:40:06 | 2022-02-15T10:48:46Z | 5hin0bi | train |
provectus/kafka-ui/1615_1617 | provectus/kafka-ui | provectus/kafka-ui/1615 | provectus/kafka-ui/1617 | [
"timestamp(timedelta=0.0, similarity=0.9267386712500169)"
] | c3d44c95c27826a7cc6275cf6ae58411097efb8f | 6428cbef4a2948748fd58eec3dbc764aa713d527 | [] | [] | 2022-02-16T15:21:54Z | [
"type/bug",
"scope/infrastructure"
] | [Bug] fix sonar scans | Sonar scans were broken after recent workflow updates. Need to fix it. | [
".github/workflows/backend.yml",
".github/workflows/e2e-checks.yaml",
".github/workflows/frontend.yaml",
".github/workflows/pr-checks.yaml",
"kafka-ui-react-app/sonar-project.properties"
] | [
".github/workflows/backend.yml",
".github/workflows/e2e-checks.yaml",
".github/workflows/frontend.yaml",
".github/workflows/pr-checks.yaml",
"kafka-ui-react-app/sonar-project.properties"
] | [] | diff --git a/.github/workflows/backend.yml b/.github/workflows/backend.yml
index 573f1b08ac7..4cebf3557cb 100644
--- a/.github/workflows/backend.yml
+++ b/.github/workflows/backend.yml
@@ -1,13 +1,20 @@
name: backend
on:
+ push:
+ branches:
+ - master
pull_request_target:
- types: ['opened', 'edited', ... | null | train | train | 2022-02-16T15:58:36 | 2022-02-16T13:47:28Z | 5hin0bi | train |
provectus/kafka-ui/1625_1634 | provectus/kafka-ui | provectus/kafka-ui/1625 | provectus/kafka-ui/1634 | [
"timestamp(timedelta=0.0, similarity=0.9640426703985836)"
] | efb8410bd631dbd3f3ffab4f532c8e0d5445660e | 25d00988ad1e9d4f5acb7087afee144f2ce6e91b | [] | [] | 2022-02-18T08:37:14Z | [
"type/bug",
"status/accepted",
"status/confirmed",
"scope/infrastructure"
] | Trigger backend workflow if pom.xml in the repo root is changed | pom.xml
mvnw?
mvnw.cmd? | [
".github/workflows/backend.yml",
".github/workflows/e2e-checks.yaml"
] | [
".github/workflows/backend.yml",
".github/workflows/e2e-checks.yaml"
] | [] | diff --git a/.github/workflows/backend.yml b/.github/workflows/backend.yml
index 4cebf3557cb..73663a5392b 100644
--- a/.github/workflows/backend.yml
+++ b/.github/workflows/backend.yml
@@ -7,6 +7,7 @@ on:
types: ["opened", "edited", "reopened", "synchronize"]
paths:
- "kafka-ui-api/**"
+ - "pom.xm... | null | val | train | 2022-02-17T17:26:15 | 2022-02-17T16:44:26Z | 5hin0bi | train |
provectus/kafka-ui/1661_1681 | provectus/kafka-ui | provectus/kafka-ui/1661 | provectus/kafka-ui/1681 | [
"timestamp(timedelta=0.0, similarity=0.8415795965537826)"
] | fd7ba5e1958966423e0966fcf1ac25f66ce61429 | 04fbd05d117ef54083e33631d9a8fec4beb32745 | [] | [] | 2022-02-25T11:42:52Z | [
"scope/infrastructure"
] | Implement a workflow for periodic CVE scanning | With a manual run so far.
#1656
#1240 | [] | [
".github/workflows/cve.yaml"
] | [] | diff --git a/.github/workflows/cve.yaml b/.github/workflows/cve.yaml
new file mode 100644
index 00000000000..8a8c2ac09ed
--- /dev/null
+++ b/.github/workflows/cve.yaml
@@ -0,0 +1,68 @@
+name: CVE checks docker master
+on:
+ workflow_dispatch:
+ schedule:
+ # * is a special character in YAML so you have to quote th... | null | test | train | 2022-02-25T08:18:14 | 2022-02-22T15:46:05Z | Haarolean | train |
provectus/kafka-ui/1961_2011 | provectus/kafka-ui | provectus/kafka-ui/1961 | provectus/kafka-ui/2011 | [
"timestamp(timedelta=71.0, similarity=0.9106017175741157)"
] | 8393232a8301277fd397b5910134dc2a754fda52 | 99e2663c24303c2a3319b770070ed081de961eba | [] | [] | 2022-05-23T07:06:24Z | [
"scope/frontend",
"type/refactoring",
"status/accepted",
"type/chore"
] | Upgrade react-router-dom to v6 | ### Is your proposal related to a problem?
App uses legacy version of react-router-dom
### Describe the solution you'd like
Please follow instruction from https://reactrouter.com/docs/en/v6/upgrading/v5
| [
"kafka-ui-react-app/package-lock.json",
"kafka-ui-react-app/package.json"
] | [
"kafka-ui-react-app/package-lock.json",
"kafka-ui-react-app/package.json"
] | [] | diff --git a/kafka-ui-react-app/package-lock.json b/kafka-ui-react-app/package-lock.json
index afff9bf5238..b177a59b33d 100644
--- a/kafka-ui-react-app/package-lock.json
+++ b/kafka-ui-react-app/package-lock.json
@@ -36,7 +36,7 @@
"react-multi-select-component": "^4.0.6",
"react-redux": "^7.2.6",
... | null | val | train | 2022-05-27T12:29:54 | 2022-05-12T11:07:46Z | workshur | train |
provectus/kafka-ui/2287_2396 | provectus/kafka-ui | provectus/kafka-ui/2287 | provectus/kafka-ui/2396 | [
"timestamp(timedelta=8499.0, similarity=0.8878472267011186)"
] | edb7da6fce83e149b9e9c34182708f17f1c1240c | b1bcf3061341af472e4c1f99e548320902667629 | [
"is not actual as we agreed with the team due to useless of Steps class on current framework stage"
] | [] | 2022-08-04T13:32:58Z | [
"type/enhancement",
"scope/QA",
"status/accepted"
] | [e2e] Prepare steps for topic | create a separate Class with steps src/test/java/com/provectus/kafka/ui/steps/kafka (TopicSteps.java)
1. create steps such createTopic, deleteTopic, isTopicExist etc
See tests that should be automated https://docs.google.com/spreadsheets/d/1Vf6yZSqCYwh33t-pTy1PiYewk-jFSfPZppzIuUVVyO0/edit#gid=0
2. Remove all slee... | [
"kafka-ui-e2e-checks/src/main/java/com/provectus/kafka/ui/pages/topic/TopicCreateEditSettingsView.java",
"kafka-ui-e2e-checks/src/main/java/com/provectus/kafka/ui/pages/topic/TopicView.java",
"kafka-ui-e2e-checks/src/main/java/com/provectus/kafka/ui/pages/topic/TopicsList.java"
] | [
"kafka-ui-e2e-checks/src/main/java/com/provectus/kafka/ui/pages/topic/TopicCreateEditSettingsView.java",
"kafka-ui-e2e-checks/src/main/java/com/provectus/kafka/ui/pages/topic/TopicView.java",
"kafka-ui-e2e-checks/src/main/java/com/provectus/kafka/ui/pages/topic/TopicsList.java"
] | [
"kafka-ui-e2e-checks/src/test/java/com/provectus/kafka/ui/steps/kafka/TopicSteps.java",
"kafka-ui-e2e-checks/src/test/java/com/provectus/kafka/ui/tests/TopicTests.java"
] | diff --git a/kafka-ui-e2e-checks/src/main/java/com/provectus/kafka/ui/pages/topic/TopicCreateEditSettingsView.java b/kafka-ui-e2e-checks/src/main/java/com/provectus/kafka/ui/pages/topic/TopicCreateEditSettingsView.java
index bd6bc8fc0de..b22821db44a 100644
--- a/kafka-ui-e2e-checks/src/main/java/com/provectus/kafka/ui/... | diff --git a/kafka-ui-e2e-checks/src/test/java/com/provectus/kafka/ui/steps/kafka/TopicSteps.java b/kafka-ui-e2e-checks/src/test/java/com/provectus/kafka/ui/steps/kafka/TopicSteps.java
new file mode 100644
index 00000000000..d179c33e5bb
--- /dev/null
+++ b/kafka-ui-e2e-checks/src/test/java/com/provectus/kafka/ui/steps/... | train | train | 2022-08-04T15:38:27 | 2022-07-18T13:53:19Z | kshpilchyna | train |
provectus/kafka-ui/2308_2484 | provectus/kafka-ui | provectus/kafka-ui/2308 | provectus/kafka-ui/2484 | [
"timestamp(timedelta=1.0, similarity=0.9138298394008482)"
] | 63a451452250eb20e2230afaac6516604f639d69 | 0ca69fb142013c1ec73033af15de47e040f218a3 | [] | [] | 2022-08-23T21:34:22Z | [
"type/enhancement",
"good first issue",
"scope/frontend",
"status/accepted"
] | No warning message about in use saved filter in case of deleting it |
**Describe the bug**
Possible to delete the saved filter although it's in use
**Set up**
https://www.kafka-ui.provectus.io/
**Steps to Reproduce**
1. Navigate to Topics
2. Select the Topic
3. Turn to Messages
4. Use the saved filter
5. Try to delete the used filter
**Expected behavior**
Should ... | [
"kafka-ui-react-app/src/components/Topics/Topic/Messages/Filters/AddFilter.tsx",
"kafka-ui-react-app/src/components/Topics/Topic/Messages/Filters/FilterModal.tsx",
"kafka-ui-react-app/src/components/Topics/Topic/Messages/Filters/Filters.tsx",
"kafka-ui-react-app/src/components/Topics/Topic/Messages/Filters/Sa... | [
"kafka-ui-react-app/src/components/Topics/Topic/Messages/Filters/AddFilter.tsx",
"kafka-ui-react-app/src/components/Topics/Topic/Messages/Filters/FilterModal.tsx",
"kafka-ui-react-app/src/components/Topics/Topic/Messages/Filters/Filters.tsx",
"kafka-ui-react-app/src/components/Topics/Topic/Messages/Filters/Sa... | [] | diff --git a/kafka-ui-react-app/src/components/Topics/Topic/Messages/Filters/AddFilter.tsx b/kafka-ui-react-app/src/components/Topics/Topic/Messages/Filters/AddFilter.tsx
index e9ff5366cd8..510fcd03590 100644
--- a/kafka-ui-react-app/src/components/Topics/Topic/Messages/Filters/AddFilter.tsx
+++ b/kafka-ui-react-app/sr... | null | train | train | 2022-08-29T12:04:27 | 2022-07-21T03:53:23Z | armenuikafka | train |
provectus/kafka-ui/2451_2552 | provectus/kafka-ui | provectus/kafka-ui/2451 | provectus/kafka-ui/2552 | [
"timestamp(timedelta=2642.0, similarity=0.857957340403778)"
] | 3bfdc98cc962560df5bb001bb2a63e0222d4bc9f | 4a261c6e0b4aadaf13d235d74d5a74f84eefbe83 | [
"@Haarolean can you please assign this to me ?",
"Checked ok on http://master.internal.kafka-ui.provectus.io/ui/clusters/local/schemas\r\nWorks ok."
] | [] | 2022-09-08T16:57:32Z | [
"type/bug",
"good first issue",
"scope/frontend",
"status/accepted",
"status/confirmed"
] | Improvement for the pagination "Go to page" field logic | **Describe the bug**
Not allowed to decrease the "Go to page" value from 1, but possible to delete the value
**Set up**
https://www.kafka-ui.provectus.io/
**Steps to Reproduce**
<!-- We'd like you to provide an example setup (via docker-compose, helm, etc.)
to reproduce the problem, especially with a compl... | [
"kafka-ui-react-app/src/components/common/NewTable/Table.tsx"
] | [
"kafka-ui-react-app/src/components/common/NewTable/Table.tsx"
] | [] | diff --git a/kafka-ui-react-app/src/components/common/NewTable/Table.tsx b/kafka-ui-react-app/src/components/common/NewTable/Table.tsx
index 3b3a780674c..646762bf548 100644
--- a/kafka-ui-react-app/src/components/common/NewTable/Table.tsx
+++ b/kafka-ui-react-app/src/components/common/NewTable/Table.tsx
@@ -190,6 +190,... | null | test | train | 2022-09-18T14:19:22 | 2022-08-16T07:55:25Z | armenuikafka | train |
provectus/kafka-ui/2530_2602 | provectus/kafka-ui | provectus/kafka-ui/2530 | provectus/kafka-ui/2602 | [
"timestamp(timedelta=1.0, similarity=0.9635293354085905)"
] | 3bfdc98cc962560df5bb001bb2a63e0222d4bc9f | 3b8cbd1dbf92300e795658c3496378f4abd25263 | [
"messagesBehind field in api request",
"I'd like to work on this task."
] | [] | 2022-09-18T11:36:16Z | [
"type/enhancement",
"good first issue",
"scope/frontend",
"status/accepted"
] | Add "Total lag" within Consumer group |
**Describe the bug**
Add "Total lag" into Consumer group profile
**Set up**
https://www.kafka-ui.provectus.io/
**Screenshots**
<img width="1356" alt="total lag" src="https://user-images.githubusercontent.com/104780608/188556151-c77c8eba-0dd2-44b8-95c2-da5a8863a4aa.png">
| [
"kafka-ui-react-app/src/components/ConsumerGroups/Details/Details.tsx"
] | [
"kafka-ui-react-app/src/components/ConsumerGroups/Details/Details.tsx"
] | [] | diff --git a/kafka-ui-react-app/src/components/ConsumerGroups/Details/Details.tsx b/kafka-ui-react-app/src/components/ConsumerGroups/Details/Details.tsx
index 912b88a8a38..f1ce947fdb7 100644
--- a/kafka-ui-react-app/src/components/ConsumerGroups/Details/Details.tsx
+++ b/kafka-ui-react-app/src/components/ConsumerGroups... | null | test | train | 2022-09-18T14:19:22 | 2022-09-06T05:42:20Z | armenuikafka | train |
provectus/kafka-ui/2537_2607 | provectus/kafka-ui | provectus/kafka-ui/2537 | provectus/kafka-ui/2607 | [
"timestamp(timedelta=0.0, similarity=0.9627177911522665)"
] | 596f4233fcd4f7ace80141f5e3b5e1f3ed640be5 | 9962d29926436ffa10d18db02edb839ee28e3951 | [
"`/api/clusters/<cluster>/topics/<topic>/consumer-groups`, field \"topics\".",
"I'd like to take this issue."
] | [] | 2022-09-19T13:23:56Z | [
"good first issue",
"scope/frontend",
"status/accepted",
"type/chore"
] | Add "Num of Topics" to Topic/Consumer tab |
**Describe the bug**
"Num of Topics" should be displayed within Topic/Consumer tab
**Set up**
https://www.kafka-ui.provectus.io/
**Steps to Reproduce**
<!-- We'd like you to provide an example setup (via docker-compose, helm, etc.)
to reproduce the problem, especially with a complex setups. -->
Steps to... | [
"kafka-ui-react-app/src/components/Topics/Topic/ConsumerGroups/TopicConsumerGroups.tsx"
] | [
"kafka-ui-react-app/src/components/Topics/Topic/ConsumerGroups/TopicConsumerGroups.tsx"
] | [] | diff --git a/kafka-ui-react-app/src/components/Topics/Topic/ConsumerGroups/TopicConsumerGroups.tsx b/kafka-ui-react-app/src/components/Topics/Topic/ConsumerGroups/TopicConsumerGroups.tsx
index 82551ac2502..d1d6c4ece2c 100644
--- a/kafka-ui-react-app/src/components/Topics/Topic/ConsumerGroups/TopicConsumerGroups.tsx
+++... | null | train | train | 2022-09-19T14:32:47 | 2022-09-07T09:01:10Z | armenuikafka | train |
provectus/kafka-ui/2542_2614 | provectus/kafka-ui | provectus/kafka-ui/2542 | provectus/kafka-ui/2614 | [
"timestamp(timedelta=1.0, similarity=0.9637324970299261)"
] | 9962d29926436ffa10d18db02edb839ee28e3951 | 9632ffdbdbf119c2e6de41b6d992a2bd9bec3a20 | [
"would be nice if that's possible to implement",
"I'd like to work on this. "
] | [] | 2022-09-20T08:14:56Z | [
"type/enhancement",
"good first issue",
"scope/frontend",
"status/accepted",
"hacktoberfest"
] | Add "Messages behind" for Topics within Consumer group profile |
**Describe the bug**
Add "Messages behind" for Topics within Consumer group profile
**Set up**
https://www.kafka-ui.provectus.io/
**Steps to Reproduce**
<!-- We'd like you to provide an example setup (via docker-compose, helm, etc.)
to reproduce the problem, especially with a complex setups. -->
Steps... | [
"kafka-ui-react-app/src/components/ConsumerGroups/Details/Details.tsx",
"kafka-ui-react-app/src/components/ConsumerGroups/Details/ListItem.tsx",
"kafka-ui-react-app/src/components/ConsumerGroups/Details/__tests__/Details.spec.tsx"
] | [
"kafka-ui-react-app/src/components/ConsumerGroups/Details/Details.tsx",
"kafka-ui-react-app/src/components/ConsumerGroups/Details/ListItem.tsx",
"kafka-ui-react-app/src/components/ConsumerGroups/Details/__tests__/Details.spec.tsx"
] | [] | diff --git a/kafka-ui-react-app/src/components/ConsumerGroups/Details/Details.tsx b/kafka-ui-react-app/src/components/ConsumerGroups/Details/Details.tsx
index f1ce947fdb7..0a5c76b9de4 100644
--- a/kafka-ui-react-app/src/components/ConsumerGroups/Details/Details.tsx
+++ b/kafka-ui-react-app/src/components/ConsumerGroups... | null | train | train | 2022-09-20T01:37:21 | 2022-09-08T03:20:45Z | armenuikafka | train |
provectus/kafka-ui/2707_2773 | provectus/kafka-ui | provectus/kafka-ui/2707 | provectus/kafka-ui/2773 | [
"timestamp(timedelta=2.0, similarity=0.9619268052186397)"
] | d5a5f66528ee6dbb73d182a864e74a9a04c2e384 | 76fbaa7ead44de2a9cb7baf6473c810394ac0e5b | [
"I reproduce the problem. It's showing like the screenshot down below. Is this issue still need to be modified? or it can be closed.\r\n\r\n",
"@winnie-chiu you're running an old version of the app, try... | [
"```suggestion\r\n emptyMessage=\"No clusters are online\"\r\n```"
] | 2022-10-18T09:22:54Z | [
"good first issue",
"scope/frontend",
"status/accepted",
"type/chore"
] | Add message about not existing offline clusters in Dashboard |
**Describe the bug**
In case of missing offline clusters, user should see the corresponding message with toggling the offline clusters in Dashboard
**Set up**
https://www.kafka-ui.provectus.io/
**Steps to Reproduce**
1. Turn the "Only offline clusters" on
2. Make sure no clusters are available
**Ex... | [
"kafka-ui-react-app/src/components/Brokers/BrokersList/BrokersList.tsx",
"kafka-ui-react-app/src/components/Brokers/BrokersList/__test__/BrokersList.spec.tsx"
] | [
"kafka-ui-react-app/src/components/Brokers/BrokersList/BrokersList.tsx",
"kafka-ui-react-app/src/components/Brokers/BrokersList/__test__/BrokersList.spec.tsx"
] | [] | diff --git a/kafka-ui-react-app/src/components/Brokers/BrokersList/BrokersList.tsx b/kafka-ui-react-app/src/components/Brokers/BrokersList/BrokersList.tsx
index f1aa4988112..966edecf1fd 100644
--- a/kafka-ui-react-app/src/components/Brokers/BrokersList/BrokersList.tsx
+++ b/kafka-ui-react-app/src/components/Brokers/Bro... | null | train | val | 2023-03-09T19:10:11 | 2022-10-06T11:31:44Z | armenuikafka | train |
netty/netty/72_73 | netty/netty | netty/netty/72 | netty/netty/73 | [
"keyword_pr_to_issue"
] | 3ecb93eadeaaf4df065862709dc4b456bd5a7f66 | b39aad13418a61990649e6b69aab29b02cf9c7bf | [
"We love patches ;)\n",
"I think we can preprocess by converting all ; to &. Is that OK?\n",
"yes sounds right to me\n"
] | [] | 2011-11-22T19:15:46Z | [
"improvement"
] | QueryStringDecoder should also support ; | QueryStringDecoder currently does not parse
field1=value1;field2=value2
correctly.
http://en.wikipedia.org/wiki/Query_string says
This convention is a W3C recommendation.[3] W3C recommends that all web servers support semicolon separators in the place of ampersand separators.
| [
"src/main/java/org/jboss/netty/handler/codec/http/QueryStringDecoder.java"
] | [
"src/main/java/org/jboss/netty/handler/codec/http/QueryStringDecoder.java"
] | [] | diff --git a/src/main/java/org/jboss/netty/handler/codec/http/QueryStringDecoder.java b/src/main/java/org/jboss/netty/handler/codec/http/QueryStringDecoder.java
index 743875e5b80..94d2715923a 100644
--- a/src/main/java/org/jboss/netty/handler/codec/http/QueryStringDecoder.java
+++ b/src/main/java/org/jboss/netty/handle... | null | train | train | 2011-11-22T17:29:54 | 2011-11-22T16:56:04Z | ngocdaothanh | val |
netty/netty/87_98 | netty/netty | netty/netty/87 | netty/netty/98 | [
"timestamp(timedelta=55667.0, similarity=0.8681251034619513)"
] | 0d5c7d3d2e8a0de5aa48ecfc3bb761e90c633026 | 99446458b994809bcce36d9201a6a1bd78abdb95 | [
"It's not really a build issue because it works without a problem with\nMaven. M2eclipse problem probably? write-version has to be executed at\nleast at code generation phase because it generates Version.java.\n\n## \n\nSent from a mobile device.\nOn Nov 30, 2011 10:55 AM, \"Vibul Imtarnasan\" <\nreply@reply.gith... | [] | 2011-12-02T04:40:09Z | [] | Build Issue with maven-antrun-plugin: "Plugin execution not covered by lifecycle configuration" | Just installed Eclipse Indigo Service Release 1
It comes with M2E - Maven Integration for Eclipse 1.1
When I load up the Netty project, I get the following error:
```
Plugin execution not covered by lifecycle configuration: org.apache.maven.plugins:maven-antrun-plugin:1.7:run (execution: write-version, phase: valida... | [
"pom.xml"
] | [
"pom.xml"
] | [] | diff --git a/pom.xml b/pom.xml
index 44cc22f2176..c01a7926df6 100644
--- a/pom.xml
+++ b/pom.xml
@@ -207,6 +207,37 @@
</resource>
</resources>
+ <pluginManagement>
+ <plugins>
+ <!--This plugin's configuration is used to store Eclipse m2e settings only.
+ It has no influence on ... | null | val | train | 2011-12-01T14:12:24 | 2011-11-30T01:54:58Z | veebs | val |
netty/netty/122_123 | netty/netty | netty/netty/122 | netty/netty/123 | [
"timestamp(timedelta=6308.0, similarity=0.9021925714996629)"
] | 5398a5274afbeec894080cea147c785fbd417ece | 62d715949e99dafe35ab056eca3cc022752cf7a5 | [
"Maybe it's WebSocketClientHandshaker instead of (or in addition to) WebSocketClient.\n",
"Pulled #123.\n",
"Thanks veebs!\n"
] | [] | 2011-12-15T03:02:45Z | [
"feature"
] | Allow custom headers on WebSocketClientFactory or WebSocketClient | A service may need to add service-specific headers in addition to the WebSocket handshake headers (such as additional application-specific authentication tokens). It'd be nice to be able to add those custom headers before the connect method is called on the WebSocketClient.
| [
"src/main/java/io/netty/example/http/websocketx/client/WebSocketClient.java",
"src/main/java/io/netty/example/http/websocketx/client/WebSocketClientHandler.java",
"src/main/java/io/netty/handler/codec/http/websocketx/WebSocketClientHandshaker.java",
"src/main/java/io/netty/handler/codec/http/websocketx/WebSoc... | [
"src/main/java/io/netty/example/http/websocketx/client/WebSocketClient.java",
"src/main/java/io/netty/example/http/websocketx/client/WebSocketClientHandler.java",
"src/main/java/io/netty/handler/codec/http/websocketx/WebSocketClientHandshaker.java",
"src/main/java/io/netty/handler/codec/http/websocketx/WebSoc... | [] | diff --git a/src/main/java/io/netty/example/http/websocketx/client/WebSocketClient.java b/src/main/java/io/netty/example/http/websocketx/client/WebSocketClient.java
index 24064bb56b9..e45d1173c0c 100644
--- a/src/main/java/io/netty/example/http/websocketx/client/WebSocketClient.java
+++ b/src/main/java/io/netty/example... | null | test | train | 2011-12-15T03:27:52 | 2011-12-15T02:01:27Z | rshelley | val |
netty/netty/157_159 | netty/netty | netty/netty/157 | netty/netty/159 | [
"timestamp(timedelta=10.0, similarity=0.9348904138647295)"
] | b96768c9a6e305c0000242d67b9ced3e24b8e067 | a62509b60aee3c3d414792a3455996ac0d61b484 | [
"Both pull requests merged.. Thanks!\n"
] | [] | 2012-01-22T00:13:02Z | [] | ZlibDecoder does not support preset dictionary | Attempting to create a ZlibDecoder using the preset dictionary constructor throws a compression exception:
org.jboss.netty.handler.codec.compression.CompressionException: failed to set the dictionary (-2)
z.inflateSetDictionary should not be called until the inflate returns JZlib.Z_NEED_DICT
| [
"codec/src/main/java/io/netty/handler/codec/compression/ZlibDecoder.java"
] | [
"codec/src/main/java/io/netty/handler/codec/compression/ZlibDecoder.java"
] | [] | diff --git a/codec/src/main/java/io/netty/handler/codec/compression/ZlibDecoder.java b/codec/src/main/java/io/netty/handler/codec/compression/ZlibDecoder.java
index 1c89d42436b..7904ef5b60d 100644
--- a/codec/src/main/java/io/netty/handler/codec/compression/ZlibDecoder.java
+++ b/codec/src/main/java/io/netty/handler/co... | null | val | train | 2012-01-19T21:22:48 | 2012-01-21T22:31:04Z | jpinner | val |
netty/netty/164_172 | netty/netty | netty/netty/164 | netty/netty/172 | [
"timestamp(timedelta=1.0, similarity=0.8943262078098045)"
] | 4116c44c7749f0889b5ceef6067bf13ff3c1ad21 | 617003235223024aeefbe2318838a3f726dcbffa | [] | [] | 2012-01-31T22:40:28Z | [
"defect"
] | HttpContentEncoder/Decoder accepts the encoding whose qvalue is 0 | The following accept-encoding headers have 0 qvalue which means 'do not accept', but Netty does not handle qvalues at all. We at least handle the case where qvalue is 0 or invalid so that we don't accept the wrong encodings.
```
[deflate;q=0, gzip, x-gzip, compress, x-compress]=> [gzip, x-gzip, compress, x-compress]
... | [
"src/main/java/org/jboss/netty/handler/codec/http/HttpContentCompressor.java"
] | [
"src/main/java/org/jboss/netty/handler/codec/http/HttpContentCompressor.java"
] | [
"src/test/java/org/jboss/netty/handler/codec/http/HttpContentCompressorTest.java"
] | diff --git a/src/main/java/org/jboss/netty/handler/codec/http/HttpContentCompressor.java b/src/main/java/org/jboss/netty/handler/codec/http/HttpContentCompressor.java
index 803c2c53b56..8f455234f2f 100644
--- a/src/main/java/org/jboss/netty/handler/codec/http/HttpContentCompressor.java
+++ b/src/main/java/org/jboss/net... | diff --git a/src/test/java/org/jboss/netty/handler/codec/http/HttpContentCompressorTest.java b/src/test/java/org/jboss/netty/handler/codec/http/HttpContentCompressorTest.java
new file mode 100644
index 00000000000..3fb962ccabd
--- /dev/null
+++ b/src/test/java/org/jboss/netty/handler/codec/http/HttpContentCompressorTes... | train | train | 2012-01-31T21:02:00 | 2012-01-27T08:27:40Z | trustin | val |
netty/netty/163_174 | netty/netty | netty/netty/163 | netty/netty/174 | [
"timestamp(timedelta=0.0, similarity=0.9115166251394476)"
] | 4116c44c7749f0889b5ceef6067bf13ff3c1ad21 | 9d8c833c75ff7cc8f79f2d9066392df5693f8bd0 | [
"Yes if the buffers can be released somehow that would be great too. FYI - I did notice that once I change bits and memLevel down to 12 and 5 my memory usage drops 10x. On the compression side effective compression goes down from 5x to 3.25x. This is still quite an acceptable value.\n",
"Sounds interesting...\n",... | [] | 2012-02-02T00:02:46Z | [
"improvement"
] | ZlibDecoder and HttpContentCompressor consumes too much memory | Got the following message:
Hi Trustin - need your help to add a change to HttpContentCompressor. I need to set bits and memLevel along with compression level. Currently, compression level is the only value that can be set. Here is what the issue is -
In our cluster we have 10-20K long lived user connections. Once I en... | [
"src/main/java/org/jboss/netty/handler/codec/compression/ZlibEncoder.java",
"src/main/java/org/jboss/netty/handler/codec/http/HttpContentCompressor.java",
"src/main/java/org/jboss/netty/util/internal/jzlib/Deflate.java",
"src/main/java/org/jboss/netty/util/internal/jzlib/ZStream.java"
] | [
"src/main/java/org/jboss/netty/handler/codec/compression/ZlibEncoder.java",
"src/main/java/org/jboss/netty/handler/codec/http/HttpContentCompressor.java",
"src/main/java/org/jboss/netty/util/internal/jzlib/Deflate.java",
"src/main/java/org/jboss/netty/util/internal/jzlib/ZStream.java"
] | [] | diff --git a/src/main/java/org/jboss/netty/handler/codec/compression/ZlibEncoder.java b/src/main/java/org/jboss/netty/handler/codec/compression/ZlibEncoder.java
index 5925d6fb890..bd518755ef7 100644
--- a/src/main/java/org/jboss/netty/handler/codec/compression/ZlibEncoder.java
+++ b/src/main/java/org/jboss/netty/handle... | null | train | train | 2012-01-31T21:02:00 | 2012-01-27T08:20:24Z | trustin | val |
netty/netty/250_253 | netty/netty | netty/netty/250 | netty/netty/253 | [
"timestamp(timedelta=744.0, similarity=0.8633606818966223)"
] | 778f4a3cbcb203a47fb5400c268481809e20770d | b312203e947cacaceb03e9685de821ea22d2b700 | [
"Hi Jeanfrancois,\n\nI just need clarification of your use case. Is your request for Netty to:\n1. Extract error status/messages sent from the browser\n2. Send error status/message to the browser\n3. Both?\n\nJust want to make sure I fully understand your use case.\n\nThanks.\n",
"Hi,\n\nit's mostly for [AHC](ht... | [] | 2012-04-09T04:46:30Z | [] | [rfe] [websocket] Close cause code should be available | When closing a WebSocket connection using Javascript, it is possible to learn the closing 'cause'. As an example
```
_websocket.onclose = function(message) {
var reason = message.reason;
if (reason === "") {
switch (message.code) {
... | [
"codec-http/src/main/java/io/netty/handler/codec/http/websocketx/CloseWebSocketFrame.java",
"codec-http/src/main/java/io/netty/handler/codec/http/websocketx/WebSocket08FrameDecoder.java",
"example/src/main/java/io/netty/example/http/websocketx/autobahn/AutobahnServerHandler.java"
] | [
"codec-http/src/main/java/io/netty/handler/codec/http/websocketx/CloseWebSocketFrame.java",
"codec-http/src/main/java/io/netty/handler/codec/http/websocketx/WebSocket08FrameDecoder.java",
"example/src/main/java/io/netty/example/http/websocketx/autobahn/AutobahnServerHandler.java"
] | [] | diff --git a/codec-http/src/main/java/io/netty/handler/codec/http/websocketx/CloseWebSocketFrame.java b/codec-http/src/main/java/io/netty/handler/codec/http/websocketx/CloseWebSocketFrame.java
index 1f8ed460282..8ed9acb20b5 100644
--- a/codec-http/src/main/java/io/netty/handler/codec/http/websocketx/CloseWebSocketFrame... | null | test | train | 2012-04-07T21:56:58 | 2012-04-04T13:24:48Z | jfarcand | val |
netty/netty/250_254 | netty/netty | netty/netty/250 | netty/netty/254 | [
"timestamp(timedelta=644.0, similarity=0.8633606818966223)"
] | 16c3d4bc3c24d1481849ba1aba18122f14472395 | 372d794c3da684bf8c3611eaf8986b9388b24198 | [
"Hi Jeanfrancois,\n\nI just need clarification of your use case. Is your request for Netty to:\n1. Extract error status/messages sent from the browser\n2. Send error status/message to the browser\n3. Both?\n\nJust want to make sure I fully understand your use case.\n\nThanks.\n",
"Hi,\n\nit's mostly for [AHC](ht... | [] | 2012-04-09T04:47:24Z | [] | [rfe] [websocket] Close cause code should be available | When closing a WebSocket connection using Javascript, it is possible to learn the closing 'cause'. As an example
```
_websocket.onclose = function(message) {
var reason = message.reason;
if (reason === "") {
switch (message.code) {
... | [
"src/main/java/org/jboss/netty/handler/codec/http/websocketx/CloseWebSocketFrame.java",
"src/main/java/org/jboss/netty/handler/codec/http/websocketx/WebSocket08FrameDecoder.java"
] | [
"src/main/java/org/jboss/netty/handler/codec/http/websocketx/CloseWebSocketFrame.java",
"src/main/java/org/jboss/netty/handler/codec/http/websocketx/WebSocket08FrameDecoder.java"
] | [] | diff --git a/src/main/java/org/jboss/netty/handler/codec/http/websocketx/CloseWebSocketFrame.java b/src/main/java/org/jboss/netty/handler/codec/http/websocketx/CloseWebSocketFrame.java
index e79c40b8157..9e904ddd001 100644
--- a/src/main/java/org/jboss/netty/handler/codec/http/websocketx/CloseWebSocketFrame.java
+++ b/... | null | train | train | 2012-04-07T22:01:36 | 2012-04-04T13:24:48Z | jfarcand | val |
netty/netty/269_271 | netty/netty | netty/netty/269 | netty/netty/271 | [
"timestamp(timedelta=2098.0, similarity=0.8531394699270975)"
] | 3d762a7594d9cbd7f9289627665ebdfeeb049f58 | 690323a438d4bbd7ea9ad65b550dc2bfbeafdd16 | [
"First test are looking ok so far.. need todo some benchmarks \n"
] | [] | 2012-04-18T19:56:06Z | [
"improvement"
] | Use gathering writes when using java >= 7 | We disabled gathering writes because of some java bug. The problem is now fixed in java7 and above, so we should use it of we detect a java version >= 7.
See
http://bugs.sun.com/view_bug.do?bug_id=6812202
http://bugs.sun.com/view_bug.do?bug_id=6210541
| [
"src/main/java/org/jboss/netty/buffer/CompositeChannelBuffer.java",
"src/main/java/org/jboss/netty/channel/socket/nio/SocketSendBufferPool.java"
] | [
"src/main/java/org/jboss/netty/buffer/CompositeChannelBuffer.java",
"src/main/java/org/jboss/netty/channel/socket/nio/SocketSendBufferPool.java"
] | [
"src/test/java/org/jboss/netty/channel/socket/NioGatheringWriteBenchmark.java"
] | diff --git a/src/main/java/org/jboss/netty/buffer/CompositeChannelBuffer.java b/src/main/java/org/jboss/netty/buffer/CompositeChannelBuffer.java
index fc72fd7ea48..66d1cd0da9e 100644
--- a/src/main/java/org/jboss/netty/buffer/CompositeChannelBuffer.java
+++ b/src/main/java/org/jboss/netty/buffer/CompositeChannelBuffer.... | diff --git a/src/test/java/org/jboss/netty/channel/socket/NioGatheringWriteBenchmark.java b/src/test/java/org/jboss/netty/channel/socket/NioGatheringWriteBenchmark.java
new file mode 100644
index 00000000000..409a0457910
--- /dev/null
+++ b/src/test/java/org/jboss/netty/channel/socket/NioGatheringWriteBenchmark.java
@@... | train | train | 2012-04-17T20:15:20 | 2012-04-18T12:54:50Z | normanmaurer | val |
netty/netty/290_299 | netty/netty | netty/netty/290 | netty/netty/299 | [
"keyword_pr_to_issue"
] | 97069027a8e6324fd1a59ced4259ac8d6c5b516c | e1be65201c6d3a5f6e0560f7d0bc4f66d9b0eacd | [
"All changes proposed through git pull request\n"
] | [] | 2012-05-02T09:40:10Z | [
"improvement"
] | Optimize HttpPostRequest in Disk access on AbstractXXXHttpData | Hi,
It should be related to V4 only (except if Post support is in 3.X).
I made several improvements on HttpPostRequest support.
This first set is about moving the "flush" operations at the end of the write, not at every write (not useful).
Frederic
| [
"src/main/java/org/jboss/netty/handler/codec/http/AbstractDiskHttpData.java",
"src/main/java/org/jboss/netty/handler/codec/http/AbstractMemoryHttpData.java",
"src/main/java/org/jboss/netty/handler/codec/http/HttpPostBodyUtil.java",
"src/main/java/org/jboss/netty/handler/codec/http/HttpPostRequestDecoder.java"... | [
"src/main/java/org/jboss/netty/handler/codec/http/AbstractDiskHttpData.java",
"src/main/java/org/jboss/netty/handler/codec/http/AbstractMemoryHttpData.java",
"src/main/java/org/jboss/netty/handler/codec/http/HttpPostBodyUtil.java",
"src/main/java/org/jboss/netty/handler/codec/http/HttpPostRequestDecoder.java"... | [] | diff --git a/src/main/java/org/jboss/netty/handler/codec/http/AbstractDiskHttpData.java b/src/main/java/org/jboss/netty/handler/codec/http/AbstractDiskHttpData.java
index 1cf8bd9f223..2a851139d03 100644
--- a/src/main/java/org/jboss/netty/handler/codec/http/AbstractDiskHttpData.java
+++ b/src/main/java/org/jboss/netty/... | null | train | train | 2012-05-02T11:29:20 | 2012-04-29T12:36:34Z | fredericBregier | val |
netty/netty/292_299 | netty/netty | netty/netty/292 | netty/netty/299 | [
"keyword_pr_to_issue"
] | 97069027a8e6324fd1a59ced4259ac8d6c5b516c | e1be65201c6d3a5f6e0560f7d0bc4f66d9b0eacd | [
"All changes propose through Git Pull request\n"
] | [] | 2012-05-02T09:40:10Z | [
"improvement"
] | Optimize HttpPostRequest in Buffer access on HttpPostRequestDecoder | Hi,
It should be related to V4 only (except if Post support is in 3.X).
I made several improvements on HttpPostRequest support.
This second set is about improving the buffer access. Too many readByte() where occuring.
This improvement almost divide by 2 the CPU consumption.
Frederic
| [
"src/main/java/org/jboss/netty/handler/codec/http/AbstractDiskHttpData.java",
"src/main/java/org/jboss/netty/handler/codec/http/AbstractMemoryHttpData.java",
"src/main/java/org/jboss/netty/handler/codec/http/HttpPostBodyUtil.java",
"src/main/java/org/jboss/netty/handler/codec/http/HttpPostRequestDecoder.java"... | [
"src/main/java/org/jboss/netty/handler/codec/http/AbstractDiskHttpData.java",
"src/main/java/org/jboss/netty/handler/codec/http/AbstractMemoryHttpData.java",
"src/main/java/org/jboss/netty/handler/codec/http/HttpPostBodyUtil.java",
"src/main/java/org/jboss/netty/handler/codec/http/HttpPostRequestDecoder.java"... | [] | diff --git a/src/main/java/org/jboss/netty/handler/codec/http/AbstractDiskHttpData.java b/src/main/java/org/jboss/netty/handler/codec/http/AbstractDiskHttpData.java
index 1cf8bd9f223..2a851139d03 100644
--- a/src/main/java/org/jboss/netty/handler/codec/http/AbstractDiskHttpData.java
+++ b/src/main/java/org/jboss/netty/... | null | test | train | 2012-05-02T11:29:20 | 2012-04-29T12:57:39Z | fredericBregier | val |
netty/netty/291_299 | netty/netty | netty/netty/291 | netty/netty/299 | [
"keyword_pr_to_issue"
] | 97069027a8e6324fd1a59ced4259ac8d6c5b516c | e1be65201c6d3a5f6e0560f7d0bc4f66d9b0eacd | [
"All changes proposed through git pull request\n"
] | [] | 2012-05-02T09:40:10Z | [
"defect"
] | Fix a small issue on HttpPostRequest on addContent | Hi,
It should be related to V4 only (except if Post support is in 3.X).
A fix for issue where addContent may try to finalize too early a content while this is the last block to add.
Frederc
| [
"src/main/java/org/jboss/netty/handler/codec/http/AbstractDiskHttpData.java",
"src/main/java/org/jboss/netty/handler/codec/http/AbstractMemoryHttpData.java",
"src/main/java/org/jboss/netty/handler/codec/http/HttpPostBodyUtil.java",
"src/main/java/org/jboss/netty/handler/codec/http/HttpPostRequestDecoder.java"... | [
"src/main/java/org/jboss/netty/handler/codec/http/AbstractDiskHttpData.java",
"src/main/java/org/jboss/netty/handler/codec/http/AbstractMemoryHttpData.java",
"src/main/java/org/jboss/netty/handler/codec/http/HttpPostBodyUtil.java",
"src/main/java/org/jboss/netty/handler/codec/http/HttpPostRequestDecoder.java"... | [] | diff --git a/src/main/java/org/jboss/netty/handler/codec/http/AbstractDiskHttpData.java b/src/main/java/org/jboss/netty/handler/codec/http/AbstractDiskHttpData.java
index 1cf8bd9f223..2a851139d03 100644
--- a/src/main/java/org/jboss/netty/handler/codec/http/AbstractDiskHttpData.java
+++ b/src/main/java/org/jboss/netty/... | null | val | train | 2012-05-02T11:29:20 | 2012-04-29T12:51:06Z | fredericBregier | val |
netty/netty/300_301 | netty/netty | netty/netty/300 | netty/netty/301 | [
"timestamp(timedelta=165015.0, similarity=0.8659035254419507)"
] | 308afcaa405dffb7bf7bd93e0956376e8b8e2529 | be094d8aaa3696ac572a68acf9b98fb3866332a6 | [] | [] | 2012-05-02T12:15:03Z | [
"defect"
] | Small race in ChunkedWriteHandler | We have a small race in ChunkedWriteHandler as currentMessageEvent is not "marked" volatile. This needs to get changed
| [
"src/main/java/org/jboss/netty/handler/stream/ChunkedWriteHandler.java"
] | [
"src/main/java/org/jboss/netty/handler/stream/ChunkedWriteHandler.java"
] | [] | diff --git a/src/main/java/org/jboss/netty/handler/stream/ChunkedWriteHandler.java b/src/main/java/org/jboss/netty/handler/stream/ChunkedWriteHandler.java
index 96b2838511b..1e714ed3b0d 100644
--- a/src/main/java/org/jboss/netty/handler/stream/ChunkedWriteHandler.java
+++ b/src/main/java/org/jboss/netty/handler/stream/... | null | train | train | 2012-05-02T12:13:00 | 2012-05-02T10:04:43Z | normanmaurer | val |
netty/netty/317_318 | netty/netty | netty/netty/317 | netty/netty/318 | [
"keyword_pr_to_issue"
] | 33cee3dc9d5f5cf46c0201c624b2d5eb25dcc50a | 88331593f607bd4579236c97671a1d1769827b81 | [
"Hi @robotbrains \n\nConcerning the moveTo, is it renameTo() you talk about ? (I suppose yes)\n\nI would recommend to not use HttpChunkAggregator, since one of the interest of this upload feature is to limit as much as possible the memory impact. Having such a HttpChunkAggregator in your pipeline will put all the f... | [
"This will break compatiblity with java5\n",
"This will break compatiblity with java5\n",
"This will break compatiblity with java5\n",
"This will break compatiblity with java5\n",
"This will break compatiblity with java5\n",
"Ah, I see !\nUnderstood\n"
] | 2012-05-10T18:00:56Z | [] | MixedFileUpload in Netty 3.5.0 snapshot doesn't write out entire file. | I duplicated the functionality of file upload handler in the example for my application.
My HttpDataFactory was done the same way as the example, where I would have a certain size which would be in memory only, but it it got larger, it would be on disk. I also had no HttpChunkAggregator in my pipeline.
HttpDataFactor... | [
"src/main/java/org/jboss/netty/handler/codec/http/MixedAttribute.java",
"src/main/java/org/jboss/netty/handler/codec/http/MixedFileUpload.java"
] | [
"src/main/java/org/jboss/netty/handler/codec/http/MixedAttribute.java",
"src/main/java/org/jboss/netty/handler/codec/http/MixedFileUpload.java"
] | [] | diff --git a/src/main/java/org/jboss/netty/handler/codec/http/MixedAttribute.java b/src/main/java/org/jboss/netty/handler/codec/http/MixedAttribute.java
index 292b0bc4d17..caad1b492fb 100644
--- a/src/main/java/org/jboss/netty/handler/codec/http/MixedAttribute.java
+++ b/src/main/java/org/jboss/netty/handler/codec/http... | null | val | train | 2012-05-10T10:15:40 | 2012-05-10T13:45:10Z | robotbrains | val |
netty/netty/336_341 | netty/netty | netty/netty/336 | netty/netty/341 | [
"timestamp(timedelta=52706.0, similarity=0.9171606088937482)"
] | 288ed13b6b14375204316d68c28f446cb7b9d23d | a477eb23149e5c03baf88d2f139a54ce553ff0af | [] | [] | 2012-05-18T19:01:39Z | [
"improvement"
] | Make SslBufferPool's methods public | We should make all Methods of SslBufferPool public so its easy to have a custom implementation in another package. For example a user may want to have a custom impl that use direct ByteBuffers.
| [
"src/main/java/org/jboss/netty/handler/ssl/SslBufferPool.java",
"src/main/java/org/jboss/netty/handler/ssl/SslHandler.java"
] | [
"src/main/java/org/jboss/netty/handler/ssl/DefaultSslBufferPool.java",
"src/main/java/org/jboss/netty/handler/ssl/SslBufferPool.java",
"src/main/java/org/jboss/netty/handler/ssl/SslHandler.java"
] | [] | diff --git a/src/main/java/org/jboss/netty/handler/ssl/DefaultSslBufferPool.java b/src/main/java/org/jboss/netty/handler/ssl/DefaultSslBufferPool.java
new file mode 100644
index 00000000000..3c2dc387bde
--- /dev/null
+++ b/src/main/java/org/jboss/netty/handler/ssl/DefaultSslBufferPool.java
@@ -0,0 +1,109 @@
+/*
+ * Cop... | null | train | train | 2012-05-18T11:21:29 | 2012-05-18T06:00:02Z | normanmaurer | val |
netty/netty/336_342 | netty/netty | netty/netty/336 | netty/netty/342 | [
"timestamp(timedelta=102587.0, similarity=0.9171606088937482)"
] | 3d49975a3cc87cd263d479b0e0b6281dcd51ae50 | a82fd9cd5b13485913c45e2c8ba688f05f430b14 | [] | [] | 2012-05-18T20:51:23Z | [
"improvement"
] | Make SslBufferPool's methods public | We should make all Methods of SslBufferPool public so its easy to have a custom implementation in another package. For example a user may want to have a custom impl that use direct ByteBuffers.
| [
"handler/src/main/java/io/netty/handler/ssl/SslBufferPool.java",
"handler/src/main/java/io/netty/handler/ssl/SslHandler.java"
] | [
"handler/src/main/java/io/netty/handler/ssl/DefaultSslBufferPool.java",
"handler/src/main/java/io/netty/handler/ssl/SslBufferPool.java",
"handler/src/main/java/io/netty/handler/ssl/SslHandler.java"
] | [] | diff --git a/handler/src/main/java/io/netty/handler/ssl/DefaultSslBufferPool.java b/handler/src/main/java/io/netty/handler/ssl/DefaultSslBufferPool.java
new file mode 100644
index 00000000000..6fe44d58943
--- /dev/null
+++ b/handler/src/main/java/io/netty/handler/ssl/DefaultSslBufferPool.java
@@ -0,0 +1,93 @@
+/*
+ * C... | null | train | train | 2012-05-18T21:41:57 | 2012-05-18T06:00:02Z | normanmaurer | val |
netty/netty/345_346 | netty/netty | netty/netty/345 | netty/netty/346 | [
"keyword_pr_to_issue"
] | ed538209e588e8ba7e94371a801067d73eb2ab74 | 1af6e443ac864a5d1b1769478155e88b8d97e8b6 | [
"PS: if desired I could provide these changes.\n",
"Hi @rzorzorzo \n\nOn the first item, I was really unaware of this ! Thanks for spotting this !\n\nOn the second item, I could agree but the idea is to be able to change the timer... (traffic handler could changed during runtime due to special request).\nHow coul... | [] | 2012-05-19T12:06:45Z | [] | Enhancements to AbstractTrafficShapingHandler / TrafficCounter | 1. do not sleep 101 ms due to issues with java and windows
see: http://www.javamex.com/tutorials/threads/sleep_issues.shtml
in getTimeToWait change
return wait;
to:
return (wait/10)*10;
1. do not "waste" a thread in TrafficCounter. use netty's Timer instead.
-- Ron
| [
"handler/src/main/java/io/netty/handler/traffic/AbstractTrafficShapingHandler.java",
"handler/src/main/java/io/netty/handler/traffic/TrafficCounter.java"
] | [
"handler/src/main/java/io/netty/handler/traffic/AbstractTrafficShapingHandler.java",
"handler/src/main/java/io/netty/handler/traffic/TrafficCounter.java"
] | [] | diff --git a/handler/src/main/java/io/netty/handler/traffic/AbstractTrafficShapingHandler.java b/handler/src/main/java/io/netty/handler/traffic/AbstractTrafficShapingHandler.java
index 7da4b29a96c..b0c6fcfda95 100644
--- a/handler/src/main/java/io/netty/handler/traffic/AbstractTrafficShapingHandler.java
+++ b/handler/s... | null | train | train | 2012-05-19T13:19:24 | 2012-05-19T08:24:33Z | rzorzorzo | val |
netty/netty/345_347 | netty/netty | netty/netty/345 | netty/netty/347 | [
"keyword_pr_to_issue"
] | 2a05afd418a12f437391bf83f18c97700615019d | b241fca16c06916ac4f2c4a1f8b85e9baddd38a1 | [
"PS: if desired I could provide these changes.\n",
"Hi @rzorzorzo \n\nOn the first item, I was really unaware of this ! Thanks for spotting this !\n\nOn the second item, I could agree but the idea is to be able to change the timer... (traffic handler could changed during runtime due to special request).\nHow coul... | [] | 2012-05-19T15:19:54Z | [] | Enhancements to AbstractTrafficShapingHandler / TrafficCounter | 1. do not sleep 101 ms due to issues with java and windows
see: http://www.javamex.com/tutorials/threads/sleep_issues.shtml
in getTimeToWait change
return wait;
to:
return (wait/10)*10;
1. do not "waste" a thread in TrafficCounter. use netty's Timer instead.
-- Ron
| [
"src/main/java/org/jboss/netty/handler/traffic/AbstractTrafficShapingHandler.java",
"src/main/java/org/jboss/netty/handler/traffic/TrafficCounter.java"
] | [
"src/main/java/org/jboss/netty/handler/traffic/AbstractTrafficShapingHandler.java",
"src/main/java/org/jboss/netty/handler/traffic/TrafficCounter.java"
] | [] | diff --git a/src/main/java/org/jboss/netty/handler/traffic/AbstractTrafficShapingHandler.java b/src/main/java/org/jboss/netty/handler/traffic/AbstractTrafficShapingHandler.java
index 3cfb28e3900..2ec65af93b4 100644
--- a/src/main/java/org/jboss/netty/handler/traffic/AbstractTrafficShapingHandler.java
+++ b/src/main/jav... | null | train | train | 2012-05-18T22:16:17 | 2012-05-19T08:24:33Z | rzorzorzo | val |
netty/netty/345_348 | netty/netty | netty/netty/345 | netty/netty/348 | [
"keyword_pr_to_issue"
] | 4bf2257d1adcaea802b0a1ca8802272b756905cc | 154e9f152139bd2c8dd4d658149b0721a56a3300 | [
"PS: if desired I could provide these changes.\n",
"Hi @rzorzorzo \n\nOn the first item, I was really unaware of this ! Thanks for spotting this !\n\nOn the second item, I could agree but the idea is to be able to change the timer... (traffic handler could changed during runtime due to special request).\nHow coul... | [] | 2012-05-20T08:42:22Z | [] | Enhancements to AbstractTrafficShapingHandler / TrafficCounter | 1. do not sleep 101 ms due to issues with java and windows
see: http://www.javamex.com/tutorials/threads/sleep_issues.shtml
in getTimeToWait change
return wait;
to:
return (wait/10)*10;
1. do not "waste" a thread in TrafficCounter. use netty's Timer instead.
-- Ron
| [
"src/main/java/org/jboss/netty/handler/traffic/AbstractTrafficShapingHandler.java",
"src/main/java/org/jboss/netty/handler/traffic/ChannelTrafficShapingHandler.java",
"src/main/java/org/jboss/netty/handler/traffic/GlobalTrafficShapingHandler.java",
"src/main/java/org/jboss/netty/handler/traffic/TrafficCounter... | [
"src/main/java/org/jboss/netty/handler/traffic/AbstractTrafficShapingHandler.java",
"src/main/java/org/jboss/netty/handler/traffic/ChannelTrafficShapingHandler.java",
"src/main/java/org/jboss/netty/handler/traffic/GlobalTrafficShapingHandler.java",
"src/main/java/org/jboss/netty/handler/traffic/TrafficCounter... | [] | diff --git a/src/main/java/org/jboss/netty/handler/traffic/AbstractTrafficShapingHandler.java b/src/main/java/org/jboss/netty/handler/traffic/AbstractTrafficShapingHandler.java
index 2ec65af93b4..fe0fdd2ed30 100644
--- a/src/main/java/org/jboss/netty/handler/traffic/AbstractTrafficShapingHandler.java
+++ b/src/main/jav... | null | train | train | 2012-05-19T20:51:25 | 2012-05-19T08:24:33Z | rzorzorzo | val |
netty/netty/378_379 | netty/netty | netty/netty/378 | netty/netty/379 | [
"timestamp(timedelta=148.0, similarity=0.8879426217002148)"
] | f34fc73e89e88da32c36786c8634afa9dc090207 | 40f4ee22fb7f9790d7ec936c692944b54f2c4337 | [
"This bug has consequences on downstream projects depending on Netty:\n\nhttps://play.lighthouseapp.com/projects/82401-play-20/tickets/511-adding-a-cookie-twice-to-a-result-doesnt-override-the-old-cookie\n",
"Pull request: https://github.com/netty/netty/pull/379\n",
"Merged into '3' and 'master'. Thanks!\n"
] | [] | 2012-06-02T22:05:46Z | [
"defect"
] | DefaultCookie equals and compareTo implementation wrong | The equals and compareTo implementations in DefaultCookie are wrong. Sample code from the equals method:
```
if (getPath() == null && that.getPath() != null) {
return false;
} else if (that.getPath() == null) {
return false;
}
if (!getPath().equals(that.getPath())) {
return fals... | [
"codec-http/src/main/java/io/netty/handler/codec/http/DefaultCookie.java"
] | [
"codec-http/src/main/java/io/netty/handler/codec/http/DefaultCookie.java"
] | [] | diff --git a/codec-http/src/main/java/io/netty/handler/codec/http/DefaultCookie.java b/codec-http/src/main/java/io/netty/handler/codec/http/DefaultCookie.java
index e94e5dc145f..cb5d3c6eaeb 100644
--- a/codec-http/src/main/java/io/netty/handler/codec/http/DefaultCookie.java
+++ b/codec-http/src/main/java/io/netty/handl... | null | train | train | 2012-06-02T20:13:58 | 2012-06-02T21:49:37Z | jroper | val |
netty/netty/398_399 | netty/netty | netty/netty/398 | netty/netty/399 | [
"keyword_pr_to_issue"
] | df11cfab255c376ed0f2482156b9a5dd35a9f2f4 | 472d0a3c4ece00b17b979e58f78fdb1293797607 | [
"So the JVM implementation is buggy (not the Netty one), since the transferTo method on FileChannel should be optimized carefully in JVM, taking in consideration the memory footprint. If I'm correct, this method is system optimized, so the reason we used it.\nAnd for the record, the \"renameTo\" method of Netty fir... | [] | 2012-06-15T06:18:25Z | [
"defect"
] | AbstractDiskHttpData.renameTo() can fail when mmap'ing fails. | See: http://stackoverflow.com/questions/11006968/netty-file-upload-out-of-memory-error
The current implementation of `renameTo` is not correct. It has to copy data chunk by chunk (e.g. 8KiB) instead of issuing full transfer at once.
| [
"src/main/java/org/jboss/netty/handler/codec/http/multipart/AbstractDiskHttpData.java"
] | [
"src/main/java/org/jboss/netty/handler/codec/http/multipart/AbstractDiskHttpData.java"
] | [] | diff --git a/src/main/java/org/jboss/netty/handler/codec/http/multipart/AbstractDiskHttpData.java b/src/main/java/org/jboss/netty/handler/codec/http/multipart/AbstractDiskHttpData.java
index 0df3500de38..010bd1d55ff 100644
--- a/src/main/java/org/jboss/netty/handler/codec/http/multipart/AbstractDiskHttpData.java
+++ b/... | null | val | train | 2012-06-13T11:22:37 | 2012-06-15T02:05:03Z | trustin | val |
netty/netty/398_400 | netty/netty | netty/netty/398 | netty/netty/400 | [
"keyword_pr_to_issue"
] | 6d29d2feb193214b5e548f570f3b8e25a1e3637e | fe59cd1631d80542b908f4621000ee0d911131ae | [
"So the JVM implementation is buggy (not the Netty one), since the transferTo method on FileChannel should be optimized carefully in JVM, taking in consideration the memory footprint. If I'm correct, this method is system optimized, so the reason we used it.\nAnd for the record, the \"renameTo\" method of Netty fir... | [] | 2012-06-15T17:42:24Z | [
"defect"
] | AbstractDiskHttpData.renameTo() can fail when mmap'ing fails. | See: http://stackoverflow.com/questions/11006968/netty-file-upload-out-of-memory-error
The current implementation of `renameTo` is not correct. It has to copy data chunk by chunk (e.g. 8KiB) instead of issuing full transfer at once.
| [
"src/main/java/org/jboss/netty/handler/codec/http/multipart/AbstractDiskHttpData.java"
] | [
"src/main/java/org/jboss/netty/handler/codec/http/multipart/AbstractDiskHttpData.java"
] | [] | diff --git a/src/main/java/org/jboss/netty/handler/codec/http/multipart/AbstractDiskHttpData.java b/src/main/java/org/jboss/netty/handler/codec/http/multipart/AbstractDiskHttpData.java
index 010bd1d55ff..e1400cae675 100644
--- a/src/main/java/org/jboss/netty/handler/codec/http/multipart/AbstractDiskHttpData.java
+++ b/... | null | train | train | 2012-06-15T12:04:34 | 2012-06-15T02:05:03Z | trustin | val |
netty/netty/414_415 | netty/netty | netty/netty/414 | netty/netty/415 | [
"keyword_pr_to_issue",
"timestamp(timedelta=1.0, similarity=0.8466891398433595)"
] | 33c42bee6d2cbc1fadecbb82440ddff9e13e1692 | a60db57faa54e475fbc776827ee7c3a0ee018ca5 | [
"I understand the probable need.\nHere are some remarks on my side:\n\n1- a clear documentation must indicate that the returned ByteBuf is limited to the portion of bytes where the index given is physically located\n\n2- why do you make \n\n```\nreturn components[componentId].duplicate();\n```\n\ninstead of\n\n```\... | [] | 2012-06-28T00:26:00Z | [] | CompositeChannelBuffer: Add expert method to return the ChannelBuffer for a specific index | It would be nice to add an expert method to CompositeChannelBuffer that allows to get the ChannelBuffer for a specific index. Pretty simple to add, would help a lot in my case when trying to optimize buffer copies when possible.
If it makes sense, I can easily send a pull request.
| [
"buffer/src/main/java/io/netty/buffer/CompositeByteBuf.java"
] | [
"buffer/src/main/java/io/netty/buffer/CompositeByteBuf.java"
] | [
"buffer/src/test/java/io/netty/buffer/AbstractCompositeChannelBufferTest.java"
] | diff --git a/buffer/src/main/java/io/netty/buffer/CompositeByteBuf.java b/buffer/src/main/java/io/netty/buffer/CompositeByteBuf.java
index 9329de90231..ca86eb3cd06 100644
--- a/buffer/src/main/java/io/netty/buffer/CompositeByteBuf.java
+++ b/buffer/src/main/java/io/netty/buffer/CompositeByteBuf.java
@@ -575,6 +575,34 @... | diff --git a/buffer/src/test/java/io/netty/buffer/AbstractCompositeChannelBufferTest.java b/buffer/src/test/java/io/netty/buffer/AbstractCompositeChannelBufferTest.java
index 2d68c5cd1d3..86fa2a50098 100644
--- a/buffer/src/test/java/io/netty/buffer/AbstractCompositeChannelBufferTest.java
+++ b/buffer/src/test/java/io/... | train | train | 2012-06-28T14:08:01 | 2012-06-27T23:44:44Z | kimchy | val |
netty/netty/434_436 | netty/netty | netty/netty/434 | netty/netty/436 | [
"keyword_pr_to_issue"
] | f16c7472deac81ea54c29b84e07fc6756f8b608e | 4936ac4dc481bc70c447fb667a8820cba77c73c9 | [
"I understand your concern, but according to RFC 1867, chapter 5.9 :\n\n```\n5.9 CRLF used as line separator\n\n As with all MIME transmissions, CRLF is used as the separator for\n lines in a POST of the data in multipart/form-data.\n```\n\nSo my guess is that the Adobe Flash Uploader code is incorrect... ?\nThe ... | [] | 2012-07-03T13:05:44Z | [] | HttpPostRequestDecoder doesn't work if last disposition delimiter doesn't end with CRLF | Some Adobe Flash based uploaders such as SWFUpload doesn't end the last disposition delimiter with CRLF.
> SWFUpload sends this:
> ------------ei4ae0GI3Ef1gL6Ij5gL6gL6ei4KM7--
>
> instead of this:
> ------------ei4ae0GI3Ef1gL6Ij5gL6gL6ei4KM7--\r\n
So multipart uploads always fail with an "ErrorDataDecoderException:... | [
"src/main/java/org/jboss/netty/example/http/upload/HttpUploadServerHandler.java",
"src/main/java/org/jboss/netty/handler/codec/http/multipart/HttpPostRequestDecoder.java"
] | [
"src/main/java/org/jboss/netty/example/http/upload/HttpUploadServerHandler.java",
"src/main/java/org/jboss/netty/handler/codec/http/multipart/HttpPostRequestDecoder.java"
] | [] | diff --git a/src/main/java/org/jboss/netty/example/http/upload/HttpUploadServerHandler.java b/src/main/java/org/jboss/netty/example/http/upload/HttpUploadServerHandler.java
index 4e844afdfbf..5a23e729f60 100644
--- a/src/main/java/org/jboss/netty/example/http/upload/HttpUploadServerHandler.java
+++ b/src/main/java/org/... | null | train | train | 2012-07-03T10:40:49 | 2012-07-02T15:29:02Z | nitroduna | val |
netty/netty/444_446 | netty/netty | netty/netty/444 | netty/netty/446 | [
"timestamp(timedelta=6838.0, similarity=0.9016470800548596)"
] | f648aae747b4531d80ad3f4b86746c5d93d3821f | 4b2010a7f8a2930007c16ab380230fe62ccb520e | [
"not necessary after calling 'deflater.finish()' on line 235\n\nOn Fri, Jul 6, 2012 at 8:00 AM, naude-r\nreply@reply.github.com\nwrote:\n\n> Hi,\n> \n> Using netty-3.5.0.Final http compression works just fine. After upgrading to netty-3.5.2.Final I found that some resources do not compress completely.\n> \n> This i... | [] | 2012-07-09T18:03:03Z | [
"defect"
] | Http compression error | Hi,
Using netty-3.5.0.Final http compression works just fine. After upgrading to netty-3.5.2.Final I found that some resources do not compress completely.
This is evident in the actual sizes of the files as well:
> -rw-rw-r--. 1 roelof roelof 192628 Jul 6 16:14 netty-3.5.0.js
> -rw-rw-r--. 1 roelof roelof 167636 Ju... | [
"src/main/java/org/jboss/netty/handler/codec/compression/JdkZlibEncoder.java"
] | [
"src/main/java/org/jboss/netty/handler/codec/compression/JdkZlibEncoder.java"
] | [] | diff --git a/src/main/java/org/jboss/netty/handler/codec/compression/JdkZlibEncoder.java b/src/main/java/org/jboss/netty/handler/codec/compression/JdkZlibEncoder.java
index cd7b161be10..59d78a67d33 100644
--- a/src/main/java/org/jboss/netty/handler/codec/compression/JdkZlibEncoder.java
+++ b/src/main/java/org/jboss/net... | null | train | train | 2012-07-08T11:24:26 | 2012-07-06T14:39:11Z | naude-r | val |
netty/netty/456_460 | netty/netty | netty/netty/456 | netty/netty/460 | [
"timestamp(timedelta=74809.0, similarity=0.8526710381688708)",
"keyword_pr_to_issue"
] | 3447e8711227f83ff8d02a90078e376c3fbf5a0f | 1134715697e30d9fa8f0637b79d05889c54d45f3 | [
"@trustin @veebs @fredericBregier wdyt ?\n",
"Sorry. Saw the issue but been a bit busy with work. Will make some time to look at it tomorrow. \n\nSent from my iPhone\n\nOn 18/07/2012, at 5:57 PM, Norman Maurerreply@reply.github.com wrote:\n\n> @trustin @veebs @fredericBregier wdyt ?\n> \n> ---\n> \n> Reply to thi... | [] | 2012-07-18T08:48:11Z | [
"defect"
] | Completely broken WebSocket08FrameEncoder (v13 broken too) (includes 1 line fix) | Bug exists in 4.0.0.Alpha1 AND verified it still exists in master. Didn't check previous to those.
Symptom:
- Other end will get an undecodable garbage payload from a netty WebSocket client.
Cause:
- Netty picks two random numbers. One random number is stored in the mask field in the WebSocket frame that is sent to t... | [
"codec-http/src/main/java/io/netty/handler/codec/http/websocketx/WebSocket08FrameEncoder.java"
] | [
"codec-http/src/main/java/io/netty/handler/codec/http/websocketx/WebSocket08FrameEncoder.java"
] | [] | diff --git a/codec-http/src/main/java/io/netty/handler/codec/http/websocketx/WebSocket08FrameEncoder.java b/codec-http/src/main/java/io/netty/handler/codec/http/websocketx/WebSocket08FrameEncoder.java
index f32d01a2d05..715123a311d 100644
--- a/codec-http/src/main/java/io/netty/handler/codec/http/websocketx/WebSocket08... | null | train | train | 2012-07-18T09:26:11 | 2012-07-17T10:53:44Z | garypart | val |
netty/netty/456_461 | netty/netty | netty/netty/456 | netty/netty/461 | [
"keyword_pr_to_issue"
] | b5412c956359200f66076c4f99da163fb1df6ed5 | 19eba3ec596151da63719929d0746479cdff13d7 | [
"@trustin @veebs @fredericBregier wdyt ?\n",
"Sorry. Saw the issue but been a bit busy with work. Will make some time to look at it tomorrow. \n\nSent from my iPhone\n\nOn 18/07/2012, at 5:57 PM, Norman Maurerreply@reply.github.com wrote:\n\n> @trustin @veebs @fredericBregier wdyt ?\n> \n> ---\n> \n> Reply to thi... | [] | 2012-07-18T08:50:57Z | [
"defect"
] | Completely broken WebSocket08FrameEncoder (v13 broken too) (includes 1 line fix) | Bug exists in 4.0.0.Alpha1 AND verified it still exists in master. Didn't check previous to those.
Symptom:
- Other end will get an undecodable garbage payload from a netty WebSocket client.
Cause:
- Netty picks two random numbers. One random number is stored in the mask field in the WebSocket frame that is sent to t... | [
"codec-http/src/main/java/io/netty/handler/codec/http/websocketx/WebSocket08FrameEncoder.java"
] | [
"codec-http/src/main/java/io/netty/handler/codec/http/websocketx/WebSocket08FrameEncoder.java"
] | [] | diff --git a/codec-http/src/main/java/io/netty/handler/codec/http/websocketx/WebSocket08FrameEncoder.java b/codec-http/src/main/java/io/netty/handler/codec/http/websocketx/WebSocket08FrameEncoder.java
index 715123a311d..1d773852296 100644
--- a/codec-http/src/main/java/io/netty/handler/codec/http/websocketx/WebSocket08... | null | train | train | 2012-07-18T10:50:23 | 2012-07-17T10:53:44Z | garypart | val |
netty/netty/489_490 | netty/netty | netty/netty/489 | netty/netty/490 | [
"timestamp(timedelta=29.0, similarity=0.9177840192781919)"
] | f2eeed77e0d1a850b9e77212191af457f05cbfbc | 1a4bbc0f39eb0cd5062d873871c73d9d3925a3b0 | [
"@jfallows merged your pull request.. Thanks again1\n",
"Awesome. Thanks @jfallows!\n"
] | [] | 2012-08-05T22:26:13Z | [
"defect"
] | Suspend-resume in AIO can cause a ReadPendingException | When a read completes in AioSocketChannel and the newly read buffer is advertised via fireInboundBufferUpdated(), user code can trigger a ChannelHandlerContext.readable(false), followed by a ChannelHandlerContext.readable(true).
The ChannelHandlerContext.readable(true) causes a new AioSocketChannel.beginRead() call to... | [
"transport/src/main/java/io/netty/channel/socket/aio/AioSocketChannel.java"
] | [
"transport/src/main/java/io/netty/channel/socket/aio/AioSocketChannel.java"
] | [] | diff --git a/transport/src/main/java/io/netty/channel/socket/aio/AioSocketChannel.java b/transport/src/main/java/io/netty/channel/socket/aio/AioSocketChannel.java
index 817cbc0af71..16a44c6c773 100755
--- a/transport/src/main/java/io/netty/channel/socket/aio/AioSocketChannel.java
+++ b/transport/src/main/java/io/netty/... | null | train | train | 2012-08-05T11:43:32 | 2012-08-05T21:58:26Z | jfallows | val |
netty/netty/497_498 | netty/netty | netty/netty/497 | netty/netty/498 | [
"timestamp(timedelta=37.0, similarity=0.8947825777299173)"
] | e0a88a0f1596ca91a2d31c6d39936a54e102354f | 5b48f8bc0daba1a740bba130a3a58fc0417aeaa7 | [
"This will break the api. Its fixed in master already but should not\nget touched in 3\n\nSent from my iPhone. Excuse any typos....\n\nAm 09.08.2012 um 01:12 schrieb Cruz Bishop notifications@github.com:\n\n> As noted by a TODO note in line 505 (branch: 3)\n> \n> ```\n> public void cancel() {\n> if (!state.comp... | [] | 2012-08-08T23:21:35Z | [
"won't fix"
] | HashedWheelTimer.cancel() cannot report failure | As noted by a TODO note in line 505 (branch: 3)
```
public void cancel() {
if (!state.compareAndSet(ST_INIT, ST_CANCELLED)) {
// TODO return false
return;
}
wheel[stopIndex].remove(this);
}
```
I'll make a pull request to fix this in a moment
| [
"src/main/java/org/jboss/netty/util/HashedWheelTimer.java",
"src/main/java/org/jboss/netty/util/Timeout.java"
] | [
"src/main/java/org/jboss/netty/util/HashedWheelTimer.java",
"src/main/java/org/jboss/netty/util/Timeout.java"
] | [] | diff --git a/src/main/java/org/jboss/netty/util/HashedWheelTimer.java b/src/main/java/org/jboss/netty/util/HashedWheelTimer.java
index 3b8d1d2ae22..fad43274e9a 100644
--- a/src/main/java/org/jboss/netty/util/HashedWheelTimer.java
+++ b/src/main/java/org/jboss/netty/util/HashedWheelTimer.java
@@ -500,13 +500,13 @@ publi... | null | train | train | 2012-08-01T09:00:13 | 2012-08-08T23:12:26Z | CruzBishop | val |
netty/netty/431_508 | netty/netty | netty/netty/431 | netty/netty/508 | [
"keyword_pr_to_issue",
"timestamp(timedelta=1.0, similarity=0.8819787003609638)"
] | b5aa2108ec06382a45f79f1876e6014baf836ee3 | 2d5896b30631d252d90646abfcaccf6805a7ff7a | [] | [] | 2012-08-14T05:46:13Z | [] | No way to get a UniqueName's ID | There is currently no way to get a raw UniqueName's ID without subclassing.
I'm already working on this, but I thought I should make a bug report anyway.
| [
"common/src/main/java/io/netty/util/UniqueName.java"
] | [
"common/src/main/java/io/netty/util/UniqueName.java"
] | [] | diff --git a/common/src/main/java/io/netty/util/UniqueName.java b/common/src/main/java/io/netty/util/UniqueName.java
index dbdd47617d9..9eb3e8b4bab 100644
--- a/common/src/main/java/io/netty/util/UniqueName.java
+++ b/common/src/main/java/io/netty/util/UniqueName.java
@@ -55,6 +55,10 @@ public final String name() {
... | null | train | train | 2012-08-14T07:10:40 | 2012-07-02T08:50:15Z | CruzBishop | val |
netty/netty/510_512 | netty/netty | netty/netty/510 | netty/netty/512 | [
"keyword_pr_to_issue",
"timestamp(timedelta=1.0, similarity=0.8576154479389824)"
] | ad534efc58d8be5eb7f5b1a211639ce451bf2009 | 553b97f0a4d8f706ae687f728e30e8dea32413e2 | [
"Looks like a copy/paste error :P\n\nI'll go fix that, thanks.\n"
] | [] | 2012-08-14T09:54:09Z | [] | netty example: comment error in ObjectEchoClientHandler.java | @bobmcwhirter
public void messageReceived(ChannelHandlerContext ctx, List<Integer> msg) throws Exception {
// Echo back the received object to the client.
ctx.write(msg);
}
does the "to client" in comment should be "to server" ?
| [
"example/src/main/java/io/netty/example/objectecho/ObjectEchoClientHandler.java"
] | [
"example/src/main/java/io/netty/example/objectecho/ObjectEchoClientHandler.java"
] | [] | diff --git a/example/src/main/java/io/netty/example/objectecho/ObjectEchoClientHandler.java b/example/src/main/java/io/netty/example/objectecho/ObjectEchoClientHandler.java
index c7b583d99e0..62acef8dddd 100644
--- a/example/src/main/java/io/netty/example/objectecho/ObjectEchoClientHandler.java
+++ b/example/src/main/j... | null | test | train | 2012-08-14T08:07:21 | 2012-08-14T08:36:20Z | tianyuanzhonglu | val |
netty/netty/510_513 | netty/netty | netty/netty/510 | netty/netty/513 | [
"timestamp(timedelta=110.0, similarity=0.8583523126024742)",
"keyword_pr_to_issue"
] | 3a3c5de76b11a15e91b223f3c0ebc1d744d5fa6d | f450dfd958c05e2a9a8ebc51fc0873b123b73741 | [
"Looks like a copy/paste error :P\n\nI'll go fix that, thanks.\n"
] | [] | 2012-08-14T09:57:04Z | [] | netty example: comment error in ObjectEchoClientHandler.java | @bobmcwhirter
public void messageReceived(ChannelHandlerContext ctx, List<Integer> msg) throws Exception {
// Echo back the received object to the client.
ctx.write(msg);
}
does the "to client" in comment should be "to server" ?
| [
"src/main/java/org/jboss/netty/example/objectecho/ObjectEchoClientHandler.java"
] | [
"src/main/java/org/jboss/netty/example/objectecho/ObjectEchoClientHandler.java"
] | [] | diff --git a/src/main/java/org/jboss/netty/example/objectecho/ObjectEchoClientHandler.java b/src/main/java/org/jboss/netty/example/objectecho/ObjectEchoClientHandler.java
index c70aea0590d..61b0ef6d26f 100644
--- a/src/main/java/org/jboss/netty/example/objectecho/ObjectEchoClientHandler.java
+++ b/src/main/java/org/jbo... | null | test | train | 2012-08-12T10:59:04 | 2012-08-14T08:36:20Z | tianyuanzhonglu | val |
netty/netty/514_515 | netty/netty | netty/netty/514 | netty/netty/515 | [
"timestamp(timedelta=74.0, similarity=0.9100228567346533)"
] | 1f1403697bdcb70de4bd4717cfcbb343e72b5804 | 5c9d13713141a756b6f38470baffae9c3755c5a7 | [
"You are right.. Thanks for the report and fix!\n",
"However, the accepted AioSocketChannel's AsynchronousChannelGroup is identical to that of AioServerSocketChannel. It means any async I/O events will be firstly handled by the parent AsyncChannelGroup and then forwarded to the child AsyncChannelGroup. Do you s... | [] | 2012-08-14T14:43:13Z | [
"feature"
] | AIO server channel accepts channels onto server event loop group | When a parent `AioServerSocketChannel` accepts a new inbound connection, the child `AioSocketChannel` is created with the server event loop group instead of a separate child event loop group.
Forcing both parent and child channels onto the same event loop group is still functionally correct, but can lead to connection... | [
"transport/src/main/java/io/netty/channel/socket/aio/AioServerSocketChannel.java"
] | [
"transport/src/main/java/io/netty/channel/socket/aio/AioServerSocketChannel.java"
] | [] | diff --git a/transport/src/main/java/io/netty/channel/socket/aio/AioServerSocketChannel.java b/transport/src/main/java/io/netty/channel/socket/aio/AioServerSocketChannel.java
index d7eca8dc7a4..4a83008d7ba 100755
--- a/transport/src/main/java/io/netty/channel/socket/aio/AioServerSocketChannel.java
+++ b/transport/src/m... | null | train | train | 2012-08-14T11:58:33 | 2012-08-14T14:37:49Z | jfallows | val |
netty/netty/521_522 | netty/netty | netty/netty/521 | netty/netty/522 | [
"timestamp(timedelta=1.0, similarity=0.9007243028816602)"
] | b6264c02d98b7e0335460c393e46adc42039bd74 | 2eae71843268b3d065408a8f6dc8bc9eb008e3a8 | [
"@jpinner makes sense.. I want to cut 3.5.4.Final tomorrow. Would be nice if you could \"fix it\" before that..\n"
] | [] | 2012-08-15T21:06:46Z | [
"defect"
] | Encode URI using UTF-8 charset | Starting with IE7, all URLs are encoded using the UTF-8 character set (http://support.microsoft.com/kb/934279).
Netty assumes that the request uri string is encoded as ASCII -- see HttpRequestEncoder: buf.writeBytes(request.getUri().getBytes("ASCII"))
Requests that are generated by HttpMessageDecoder use StringBuilde... | [
"src/main/java/org/jboss/netty/handler/codec/http/HttpRequestEncoder.java"
] | [
"src/main/java/org/jboss/netty/handler/codec/http/HttpRequestEncoder.java"
] | [] | diff --git a/src/main/java/org/jboss/netty/handler/codec/http/HttpRequestEncoder.java b/src/main/java/org/jboss/netty/handler/codec/http/HttpRequestEncoder.java
index 43d4167af6e..6da12766335 100644
--- a/src/main/java/org/jboss/netty/handler/codec/http/HttpRequestEncoder.java
+++ b/src/main/java/org/jboss/netty/handle... | null | train | train | 2012-08-15T22:39:40 | 2012-08-15T20:47:03Z | jpinner | val |
netty/netty/521_523 | netty/netty | netty/netty/521 | netty/netty/523 | [
"timestamp(timedelta=69770.0, similarity=0.9007243028816602)"
] | 5787e2eac9c151f63055b9dd9d5b03dbaa38c3d2 | 44a2525687746b481f005386d0a61bfe11078519 | [
"@jpinner makes sense.. I want to cut 3.5.4.Final tomorrow. Would be nice if you could \"fix it\" before that..\n"
] | [] | 2012-08-15T21:07:09Z | [
"defect"
] | Encode URI using UTF-8 charset | Starting with IE7, all URLs are encoded using the UTF-8 character set (http://support.microsoft.com/kb/934279).
Netty assumes that the request uri string is encoded as ASCII -- see HttpRequestEncoder: buf.writeBytes(request.getUri().getBytes("ASCII"))
Requests that are generated by HttpMessageDecoder use StringBuilde... | [
"codec-http/src/main/java/io/netty/handler/codec/http/HttpMessageEncoder.java",
"codec-http/src/main/java/io/netty/handler/codec/http/HttpRequestEncoder.java",
"codec-http/src/main/java/io/netty/handler/codec/http/HttpResponseEncoder.java",
"codec-http/src/main/java/io/netty/handler/codec/rtsp/RtspRequestEnco... | [
"codec-http/src/main/java/io/netty/handler/codec/http/HttpMessageEncoder.java",
"codec-http/src/main/java/io/netty/handler/codec/http/HttpRequestEncoder.java",
"codec-http/src/main/java/io/netty/handler/codec/http/HttpResponseEncoder.java",
"codec-http/src/main/java/io/netty/handler/codec/rtsp/RtspRequestEnco... | [] | diff --git a/codec-http/src/main/java/io/netty/handler/codec/http/HttpMessageEncoder.java b/codec-http/src/main/java/io/netty/handler/codec/http/HttpMessageEncoder.java
index c83c1921904..b1c56222325 100644
--- a/codec-http/src/main/java/io/netty/handler/codec/http/HttpMessageEncoder.java
+++ b/codec-http/src/main/java... | null | val | train | 2012-08-15T03:10:23 | 2012-08-15T20:47:03Z | jpinner | val |
netty/netty/494_526 | netty/netty | netty/netty/494 | netty/netty/526 | [
"timestamp(timedelta=1095.0, similarity=0.94711738258233)"
] | 3f709efcea850ee352df4b88e4b759fa44a22569 | bfe8d1a70fd120ba20ad6ac4662bfe83abddcf39 | [
"The fix would be modifying `HttpMessageEncoder` so that it removes `Content-Length` when `Transfer-Encoding: chunked` is set. WDYT?\n",
"@trustin makes sense.. should I make the change later today ?\n",
"If you wish to do it by yourself, please go ahead. :-)\n\nOn Thu, Aug 9, 2012 at 5:39 PM, Norman Maurer no... | [] | 2012-08-16T08:24:30Z | [
"defect"
] | Automatically adding chunked encoding header breaks streaming | Previously, a change was committed to automatically add the Transfer-Encoding: chunk header to any HttpMessage for which isChunked() == true.
https://github.com/netty/netty/issues/171
https://github.com/netty/netty/commit/01225b0a522720a7423390673581a0e48bf1d7c2
According to the javadoc
https://github.com/netty/netty/... | [
"src/main/java/org/jboss/netty/handler/codec/http/HttpCodecUtil.java",
"src/main/java/org/jboss/netty/handler/codec/http/HttpMessageEncoder.java"
] | [
"src/main/java/org/jboss/netty/handler/codec/http/HttpCodecUtil.java",
"src/main/java/org/jboss/netty/handler/codec/http/HttpMessageEncoder.java"
] | [] | diff --git a/src/main/java/org/jboss/netty/handler/codec/http/HttpCodecUtil.java b/src/main/java/org/jboss/netty/handler/codec/http/HttpCodecUtil.java
index 94c685f6f5b..8105f67fd96 100644
--- a/src/main/java/org/jboss/netty/handler/codec/http/HttpCodecUtil.java
+++ b/src/main/java/org/jboss/netty/handler/codec/http/Ht... | null | train | train | 2012-08-16T09:22:19 | 2012-08-08T16:55:59Z | zampani | val |
netty/netty/442_545 | netty/netty | netty/netty/442 | netty/netty/545 | [
"keyword_pr_to_issue"
] | 31a51b4937b782b542023ab92df2fcfb1c51c72c | 6aa51e1496cd1212ee32329bf46cbb1b39acd70a | [
"hexdump of the frame causing the error would be helpful\n\nOn Fri, Jul 6, 2012 at 3:17 AM, naude-r\nreply@reply.github.com\nwrote:\n\n> hi,\n> \n> I have added spdy support to a web server. The pipeline is fairly typical:\n> \n> ``` java\n> pipeline.addLast(\"decoder\", new SpdyFrameDecoder(spdyVersion));\n>... | [] | 2012-08-21T12:33:20Z | [
"defect"
] | Spdy error -> Error 337 (net::ERR_SPDY_PROTOCOL_ERROR): Unknown error | hi,
I have added spdy support to a web server. The pipeline is fairly typical:
``` java
pipeline.addLast("decoder", new SpdyFrameDecoder(spdyVersion));
pipeline.addLast("spdy_encoder", new SpdyFrameEncoder(spdyVersion));
pipeline.addLast("spdy_session_handler", new SpdySessionHandler(spdyVersion, tr... | [
"src/main/java/org/jboss/netty/handler/codec/spdy/SpdyFrameEncoder.java"
] | [
"src/main/java/org/jboss/netty/handler/codec/spdy/SpdyFrameEncoder.java"
] | [] | diff --git a/src/main/java/org/jboss/netty/handler/codec/spdy/SpdyFrameEncoder.java b/src/main/java/org/jboss/netty/handler/codec/spdy/SpdyFrameEncoder.java
index d8bdd9b62c0..e6ed2ff325a 100644
--- a/src/main/java/org/jboss/netty/handler/codec/spdy/SpdyFrameEncoder.java
+++ b/src/main/java/org/jboss/netty/handler/code... | null | val | train | 2012-08-21T13:13:44 | 2012-07-06T10:16:04Z | naude-r | val |
netty/netty/547_564 | netty/netty | netty/netty/547 | netty/netty/564 | [
"timestamp(timedelta=38013.0, similarity=0.8614472946287012)"
] | 573fbfa518dc7dbf38397e5b603a4cd2b0c79cc4 | 36a6a9ec2680dc7387e426bedfb88dfaf7f3ea39 | [
"Ah, if only this was Launchpad - I'd assign myself to this \n\nI've made a patch to use Random, but it looks like the IDs have to be negative - To \"avoid conflicts with user-specified IDs\"\n\nI'll make this pull request and add some test cases later, then if required, I'll see if it's viable to use Long values i... | [
"Please remove the public getter..\n",
"Alright\n"
] | 2012-08-25T03:46:37Z | [
"improvement"
] | Improved channel ID entropy | The Netty channel ID is an ideal key that can be used to help track and diagnose problems occurring within a server. For example I log the channel ID with all notable events that occur in my server. I also store usage and throughput statistic keyed on channel ID. These can then be queried and correlated when we have an... | [
"src/main/java/org/jboss/netty/channel/AbstractChannel.java"
] | [
"src/main/java/org/jboss/netty/channel/AbstractChannel.java"
] | [] | diff --git a/src/main/java/org/jboss/netty/channel/AbstractChannel.java b/src/main/java/org/jboss/netty/channel/AbstractChannel.java
index 6de954403ee..bf182668275 100644
--- a/src/main/java/org/jboss/netty/channel/AbstractChannel.java
+++ b/src/main/java/org/jboss/netty/channel/AbstractChannel.java
@@ -16,6 +16,7 @@
... | null | train | train | 2012-08-24T08:34:04 | 2012-08-22T16:32:31Z | psweeny | val |
netty/netty/569_572 | netty/netty | netty/netty/569 | netty/netty/572 | [
"keyword_pr_to_issue"
] | dc56905630030364fd37cc1a1e1abe2b8ea4e36c | 781a8e4dcd82a2cfab11d9b652367ce92e733e21 | [
"@ngocdaothanh does this also happen with older versions ?\n",
"1.\n\nYes, same problem with 3.5.3.Final.\n\n2.\n\nThis problem can be reproduced with the last form (no file is selected) at:\norg.jboss.netty.example.http.upload.HttpUploadServerHandler\nof the latest Netty 3 branch.\n\nI guess this problem may be ... | [] | 2012-08-28T13:48:06Z | [
"defect"
] | [3.5.5.Final] Error when uploading nothing | I'm using Netty 3.5.5.Final and Firefox 14.0.1.
When uploading a form like this:
```
<form class="well span6" method="post" action="/apps/573d3849f224f9f1a160b6feb2759967/markers/7ab50bf507ac9bd3cf08f2141b4e2158" enctype="multipart/form-data">
<input type="hidden" name="csrf-token" value="9d26ddeb-3b38-4a49-924e-9f... | [
"src/main/java/org/jboss/netty/handler/codec/http/multipart/HttpPostBodyUtil.java",
"src/main/java/org/jboss/netty/handler/codec/http/multipart/HttpPostRequestDecoder.java"
] | [
"src/main/java/org/jboss/netty/handler/codec/http/multipart/HttpPostBodyUtil.java",
"src/main/java/org/jboss/netty/handler/codec/http/multipart/HttpPostRequestDecoder.java"
] | [] | diff --git a/src/main/java/org/jboss/netty/handler/codec/http/multipart/HttpPostBodyUtil.java b/src/main/java/org/jboss/netty/handler/codec/http/multipart/HttpPostBodyUtil.java
index c0d923c83e4..12a4a0e5e1d 100644
--- a/src/main/java/org/jboss/netty/handler/codec/http/multipart/HttpPostBodyUtil.java
+++ b/src/main/jav... | null | val | train | 2012-08-28T14:38:58 | 2012-08-27T03:59:30Z | ngocdaothanh | val |
netty/netty/605_613 | netty/netty | netty/netty/605 | netty/netty/613 | [
"keyword_issue_to_pr"
] | c3af4427bbb6118e60fdfd4e81e5f7c4b7d2efac | 27c65199bd997d783deb31c89a8122a86e6834f5 | [
"In 3.5.3, the context switching was high in websocket client connections but in 3.5.7 the context switching is high for both server and client connections.\n",
"The main reason for I believe is lowering the select timeout from `500` to `10` milliseconds. @trustin / @normanmaurer, I think the solution of lowering... | [
"newTimeout() accepts 'delay', not 'dead line'.\n",
"Doh.. Thanks\n\nSent from my iPhone. Excuse any typos....\n\nAm 18.09.2012 um 08:28 schrieb Trustin Lee notifications@github.com:\n\n> In src/main/java/org/jboss/netty/channel/socket/nio/NioClientSocketPipelineSink.java:\n> \n> > @@ -231,10 +246,16 @@ void regi... | 2012-09-18T06:23:01Z | [] | very high context switching when using netty to establish websocket connection in 3.5.7 | The context switching on centos 5 has almost doubled when I switched from netty 3.5.3 to netty 3.5.7 for creating websocket connections.
Just upgrading netty jar caused context switches to jump from 2000 to 5000. Even 2000 were high especially when there was no websocket traffic and now it is just ridiculously high.
| [
"src/main/java/org/jboss/netty/channel/socket/nio/NioClientSocketChannel.java",
"src/main/java/org/jboss/netty/channel/socket/nio/NioClientSocketChannelFactory.java",
"src/main/java/org/jboss/netty/channel/socket/nio/NioClientSocketPipelineSink.java",
"src/main/java/org/jboss/netty/channel/socket/nio/Selector... | [
"src/main/java/org/jboss/netty/channel/socket/nio/NioClientSocketChannel.java",
"src/main/java/org/jboss/netty/channel/socket/nio/NioClientSocketChannelFactory.java",
"src/main/java/org/jboss/netty/channel/socket/nio/NioClientSocketPipelineSink.java",
"src/main/java/org/jboss/netty/channel/socket/nio/Selector... | [] | diff --git a/src/main/java/org/jboss/netty/channel/socket/nio/NioClientSocketChannel.java b/src/main/java/org/jboss/netty/channel/socket/nio/NioClientSocketChannel.java
index 2753f649730..b473c059289 100644
--- a/src/main/java/org/jboss/netty/channel/socket/nio/NioClientSocketChannel.java
+++ b/src/main/java/org/jboss/... | null | test | train | 2012-09-14T14:00:16 | 2012-09-14T22:27:03Z | gauravsri | val |
netty/netty/620_621 | netty/netty | netty/netty/620 | netty/netty/621 | [
"timestamp(timedelta=923.0, similarity=0.8640943361991529)",
"keyword_pr_to_issue"
] | a7d205075b59b0fd6eb37dbc47228881ed1bdb4e | 16d73e247e4030d408892b40334ebb65e7e82dd1 | [
"Thanks for the detailed analysis and also for the pull-request.. We love contributions :)\n\nI merged your patch in and it will be part of 3.5.8.Final\n"
] | [] | 2012-09-21T12:59:57Z | [] | pipelining + suspended ChunkedInput triggers StackOverflowError in ChunkedWriteHandler.flush() | We encountered an issue with ChunkedWriteHandler (netty version 3.5.7).
We get StackOverflowError in following scenario:
- ChunkWriteHandler.queue is not empty
- ChunkedWriteHandler.currentEvent is not null and it stores ChunkedInput as message
- chunkedInput stored in currentEvent is in suspended mode (nextChunk retu... | [
"src/main/java/org/jboss/netty/handler/stream/ChunkedWriteHandler.java"
] | [
"src/main/java/org/jboss/netty/handler/stream/ChunkedWriteHandler.java"
] | [] | diff --git a/src/main/java/org/jboss/netty/handler/stream/ChunkedWriteHandler.java b/src/main/java/org/jboss/netty/handler/stream/ChunkedWriteHandler.java
index 0cb6d4ef55c..e06c45b4608 100644
--- a/src/main/java/org/jboss/netty/handler/stream/ChunkedWriteHandler.java
+++ b/src/main/java/org/jboss/netty/handler/stream/... | null | train | train | 2012-09-19T21:22:36 | 2012-09-21T12:43:22Z | losipiuk | val |
netty/netty/702_703 | netty/netty | netty/netty/702 | netty/netty/703 | [
"timestamp(timedelta=40.0, similarity=0.9563708796915518)"
] | d9090ecb1bb884fd1cd856b985cfda925537cfb0 | 8b50af9163506e36bf4e9a8cbfade9b06ecfe93c | [
"Go ahead!\n\nSent from my iPhone. Excuse any typos....\n\nAm 02.11.2012 um 02:21 schrieb Jeff Pinner notifications@github.com:\n\n> According to the spec method should be case sensitive:\n> \n> http://www.w3.org/Protocols/rfc2616/rfc2616-sec5.html#sec5.1.1\n> \n> but the case is ignored in HttpMethod.java:\n> \n> ... | [] | 2012-11-02T05:54:14Z | [] | HTTP method should be case sensitive | According to the spec method should be case sensitive:
http://www.w3.org/Protocols/rfc2616/rfc2616-sec5.html#sec5.1.1
but the case is ignored in HttpMethod.java:
name = name.trim().toUpperCase();
If there are no objections, I'd like to drop the toUpperCase() in both 3.x and 4.0 in order to comply with the spec.
| [
"src/main/java/org/jboss/netty/handler/codec/http/HttpMethod.java"
] | [
"src/main/java/org/jboss/netty/handler/codec/http/HttpMethod.java"
] | [] | diff --git a/src/main/java/org/jboss/netty/handler/codec/http/HttpMethod.java b/src/main/java/org/jboss/netty/handler/codec/http/HttpMethod.java
index d8cf627d558..7c8c3b96de2 100644
--- a/src/main/java/org/jboss/netty/handler/codec/http/HttpMethod.java
+++ b/src/main/java/org/jboss/netty/handler/codec/http/HttpMethod.... | null | test | train | 2012-10-30T08:49:11 | 2012-11-02T01:21:41Z | jpinner | val |
netty/netty/702_704 | netty/netty | netty/netty/702 | netty/netty/704 | [
"timestamp(timedelta=89.0, similarity=0.9563708796915518)"
] | a9814fbf9330d8f2e2dbdd570045876841e903d3 | 9529f66540fa1380c098b50b01a3a035a1573cbb | [
"Go ahead!\n\nSent from my iPhone. Excuse any typos....\n\nAm 02.11.2012 um 02:21 schrieb Jeff Pinner notifications@github.com:\n\n> According to the spec method should be case sensitive:\n> \n> http://www.w3.org/Protocols/rfc2616/rfc2616-sec5.html#sec5.1.1\n> \n> but the case is ignored in HttpMethod.java:\n> \n> ... | [] | 2012-11-02T05:55:42Z | [] | HTTP method should be case sensitive | According to the spec method should be case sensitive:
http://www.w3.org/Protocols/rfc2616/rfc2616-sec5.html#sec5.1.1
but the case is ignored in HttpMethod.java:
name = name.trim().toUpperCase();
If there are no objections, I'd like to drop the toUpperCase() in both 3.x and 4.0 in order to comply with the spec.
| [
"codec-http/src/main/java/io/netty/handler/codec/http/HttpMethod.java"
] | [
"codec-http/src/main/java/io/netty/handler/codec/http/HttpMethod.java"
] | [] | diff --git a/codec-http/src/main/java/io/netty/handler/codec/http/HttpMethod.java b/codec-http/src/main/java/io/netty/handler/codec/http/HttpMethod.java
index 6a97242a566..166df645c49 100644
--- a/codec-http/src/main/java/io/netty/handler/codec/http/HttpMethod.java
+++ b/codec-http/src/main/java/io/netty/handler/codec/... | null | val | train | 2012-10-30T13:04:27 | 2012-11-02T01:21:41Z | jpinner | val |
netty/netty/672_732 | netty/netty | netty/netty/672 | netty/netty/732 | [
"timestamp(timedelta=23.0, similarity=0.891991349326418)"
] | 2d5028bfd6872f551bf33b9fba9b0dd416c0dd8f | 0773786b8a03c9aac8a0f9a98058ad16667a0769 | [
"Sounds good.. We just need to make it safe to ensure the other does not mess-up something once we use pooled buffers.\n",
"Hi, all. I'm still learning the Netty internals and would appreciate some opinions on my attempted solution to this issue:\n1. What should the behaviour be when replacing with a null value?... | [
"please add \"newInboundMsgBuf\" as message of the NPE.\n",
"please add \"newOutboundMsgBuf\" as message of the NPE.\n",
"Just in case it's unclear, it should be:\n\n```\nthrow new NullPointerException(\"newInboundMsgBuf\");\n```\n\nto be consistent with all NPE messages in Netty.\n"
] | 2012-11-13T00:04:13Z | [
"feature"
] | Allow replacing an inbound or outbound buffer of a handler. | Previous Netty 4 alphas did not allow replacing a handler's inbound/outbound buffer once it's created - it's final. Is there any reason to keep it final though?
Just like a user can replace a decoder on the fly using `ByteToMessageDecoder.replace(..)`, what if a user can replace a handler's inbound (or outbound) buff... | [
"transport/src/main/java/io/netty/channel/ChannelHandlerContext.java",
"transport/src/main/java/io/netty/channel/DefaultChannelHandlerContext.java",
"transport/src/main/java/io/netty/channel/DefaultChannelPipeline.java",
"transport/src/main/java/io/netty/channel/DefaultChannelPipelineModificationTask.java"
] | [
"transport/src/main/java/io/netty/channel/ChannelHandlerContext.java",
"transport/src/main/java/io/netty/channel/DefaultChannelHandlerContext.java",
"transport/src/main/java/io/netty/channel/DefaultChannelPipeline.java"
] | [] | diff --git a/transport/src/main/java/io/netty/channel/ChannelHandlerContext.java b/transport/src/main/java/io/netty/channel/ChannelHandlerContext.java
index 86172fb6e8c..a095f877c3b 100755
--- a/transport/src/main/java/io/netty/channel/ChannelHandlerContext.java
+++ b/transport/src/main/java/io/netty/channel/ChannelHan... | null | val | train | 2012-11-12T15:29:02 | 2012-10-22T22:09:03Z | trustin | val |
netty/netty/722_802 | netty/netty | netty/netty/722 | netty/netty/802 | [
"timestamp(timedelta=32.0, similarity=0.9166131880386778)"
] | 2903b91e66c6e6615b7ba67c8c6ff286e392ad95 | 63cadb22eb22c94c5d7e8b792eeccba69881aacc | [
"@trustin @normanmaurer Want me to tackle this one?\n",
"Go ahead!\n\nSent from my iPhone. Excuse any typos....\n\nAm 09.12.2012 um 05:00 schrieb \"Vibul Imtarnasan @vibuli\" notifications@github.com:\n\n> @trustin @normanmaurer Want me to tackle this one?\n> \n> —\n> Reply to this email directly or view it on Gi... | [
"`return` is unnecessary.\n"
] | 2012-12-12T06:44:53Z | [
"cleanup"
] | Make WebSocketClientHandshakerFactory a utility class | WebSocketClientHandshakerFactory does not need instantiation actually. Let's make the methods static and make it a utility class.
| [
"codec-http/src/main/java/io/netty/handler/codec/http/websocketx/WebSocketClientHandshakerFactory.java",
"example/src/main/java/io/netty/example/http/websocketx/client/WebSocketClient.java"
] | [
"codec-http/src/main/java/io/netty/handler/codec/http/websocketx/WebSocketClientHandshakerFactory.java",
"example/src/main/java/io/netty/example/http/websocketx/client/WebSocketClient.java"
] | [] | diff --git a/codec-http/src/main/java/io/netty/handler/codec/http/websocketx/WebSocketClientHandshakerFactory.java b/codec-http/src/main/java/io/netty/handler/codec/http/websocketx/WebSocketClientHandshakerFactory.java
index baef4c6f5e1..06d768e5e77 100644
--- a/codec-http/src/main/java/io/netty/handler/codec/http/webs... | null | test | train | 2012-12-10T20:12:59 | 2012-11-09T22:50:42Z | trustin | val |
netty/netty/751_821 | netty/netty | netty/netty/751 | netty/netty/821 | [
"timestamp(timedelta=1358.0, similarity=0.8458491573177721)"
] | ba3c795fdfbc03d5422107051000f218047f3d5b | a2afa3ea305d322c4f53422903f66282b6b579dd | [
"I think you will have to dig up the spec and compare. A change in web socket version typically means a change in the wire protocol so it may take a bit of work to support.\n\nHowever, which clients do u expect to use WebSocket 7? I'm not sure there are that many.\n\nFrom http://en.wikipedia.org/wiki/WebSocket#Br... | [
"I think it would make \"more sense\" to let 08 extend from 07. At least it sounds more logic, even if it will not matter :)\n",
"I think it would make \"more sense\" to let 08 extend from 07. At least it sounds more logic, even if it will not matter :)\n"
] | 2012-12-14T23:02:50Z | [
"feature"
] | Support WebSocket 07 | After reading the doc and doing some experiment, as I understand Netty currently only support WebSocket version 00, 08, and 13:
http://static.netty.io/3.5/api/org/jboss/netty/handler/codec/http/websocketx/package-summary.html
I am adding SockJS feature to my Xitrum web framework which is based on Netty. But SockJS req... | [
"codec-http/src/main/java/io/netty/handler/codec/http/websocketx/WebSocketClientHandshakerFactory.java",
"codec-http/src/main/java/io/netty/handler/codec/http/websocketx/WebSocketServerHandshakerFactory.java",
"codec-http/src/main/java/io/netty/handler/codec/http/websocketx/WebSocketVersion.java"
] | [
"codec-http/src/main/java/io/netty/handler/codec/http/websocketx/WebSocket07FrameDecoder.java",
"codec-http/src/main/java/io/netty/handler/codec/http/websocketx/WebSocket07FrameEncoder.java",
"codec-http/src/main/java/io/netty/handler/codec/http/websocketx/WebSocketClientHandshaker07.java",
"codec-http/src/ma... | [] | diff --git a/codec-http/src/main/java/io/netty/handler/codec/http/websocketx/WebSocket07FrameDecoder.java b/codec-http/src/main/java/io/netty/handler/codec/http/websocketx/WebSocket07FrameDecoder.java
new file mode 100644
index 00000000000..55ef8d941bc
--- /dev/null
+++ b/codec-http/src/main/java/io/netty/handler/codec... | null | train | train | 2012-12-14T17:06:31 | 2012-11-18T23:58:42Z | ngocdaothanh | val |
netty/netty/829_830 | netty/netty | netty/netty/829 | netty/netty/830 | [
"timestamp(timedelta=62.0, similarity=0.854182584804582)"
] | 44938973b4d09608b655d32d0693dc1119e56da8 | 13a446aecc30bd534fbeb987552ec3b47061ac0d | [
"This was first discovered by a hornetq user. For more details:\n\nhttps://community.jboss.org/thread/214134?start=15&tstart=0\n",
"Pull request #830 was merged in to fix it...\n",
"The same issue was observed in 3.6.6 Release. Stacktrace is following:\n Exception caught in channel [id: 0x363a30c8, /192.168.1.6... | [] | 2012-12-17T12:55:01Z | [] | Race in SslHandler which can lead to failing handshake and also other bad side-effects | Here is the related stack:
UNKNOWN SERVER CERTIFICATE: CN=securechat.example.netty.gleamynode.net, OU=Contributors, O=The Netty Project, L=Seongnam-si, ST=Kyunggi-do, C=KR
javax.net.ssl.SSLException: Algorithm missing:
at com.sun.net.ssl.internal.ssl.SSLEngineImpl.changeReadCiphers(SSLEngineImpl.java:554)
at c... | [
"src/main/java/org/jboss/netty/handler/ssl/SslHandler.java"
] | [
"src/main/java/org/jboss/netty/handler/ssl/SslHandler.java"
] | [
"src/test/java/org/jboss/netty/handler/ssl/SslHandshakeRaceTester.java"
] | diff --git a/src/main/java/org/jboss/netty/handler/ssl/SslHandler.java b/src/main/java/org/jboss/netty/handler/ssl/SslHandler.java
index de66e562a71..2e7e494a726 100644
--- a/src/main/java/org/jboss/netty/handler/ssl/SslHandler.java
+++ b/src/main/java/org/jboss/netty/handler/ssl/SslHandler.java
@@ -54,7 +54,6 @@
impo... | diff --git a/src/test/java/org/jboss/netty/handler/ssl/SslHandshakeRaceTester.java b/src/test/java/org/jboss/netty/handler/ssl/SslHandshakeRaceTester.java
new file mode 100644
index 00000000000..fdf99d897e6
--- /dev/null
+++ b/src/test/java/org/jboss/netty/handler/ssl/SslHandshakeRaceTester.java
@@ -0,0 +1,197 @@
+/*
+... | train | train | 2012-12-14T10:35:39 | 2012-12-17T11:40:53Z | normanmaurer | val |
netty/netty/799_835 | netty/netty | netty/netty/799 | netty/netty/835 | [
"timestamp(timedelta=6.0, similarity=0.8830975234270076)"
] | 44938973b4d09608b655d32d0693dc1119e56da8 | [] | [
"Unnecessary empty line\n",
"Unnecessary empty line\n",
"How about adding a private method like this:\n\n```\nprivate void cancelHandshakeTimeout() {\n if (handshakeTimeout != null) { ... }\n}\n```\n\nto reduce duplicates\n",
"good idea :)\n"
] | 2012-12-19T08:38:14Z | [
"defect",
"improvement",
"feature"
] | Backport SslHandler.handshake() timeout | We have a "strong" need for SslHandler.handshake() timeout in HornetQ so I would like to backport it to 3.x
| [
"src/main/java/org/jboss/netty/handler/ssl/SslHandler.java"
] | [
"src/main/java/org/jboss/netty/handler/ssl/SslHandler.java"
] | [] | diff --git a/src/main/java/org/jboss/netty/handler/ssl/SslHandler.java b/src/main/java/org/jboss/netty/handler/ssl/SslHandler.java
index 6b4cec0470c..9e6fa600b11 100644
--- a/src/main/java/org/jboss/netty/handler/ssl/SslHandler.java
+++ b/src/main/java/org/jboss/netty/handler/ssl/SslHandler.java
@@ -33,6 +33,9 @@
impo... | null | train | train | 2012-12-14T10:35:39 | 2012-12-11T16:50:19Z | normanmaurer | val | |
netty/netty/690_848 | netty/netty | netty/netty/690 | netty/netty/848 | [
"timestamp(timedelta=68.0, similarity=0.9339016503041959)"
] | 71b089cb3bf30706a9da17bd91f0a67146732059 | 6284fc3af315ba943fa99ba1597c9dbf3f315a26 | [
"@phoenix we are currently try to \"port\" one \"piece\" after the other. But as you may realize we are quite busy at the moment to the the API rock stable. \n\nSo the best thing for you to get it add back in a quick manner is to chime in an port it by yourself.. After that a pull-request would be really welcome :)... | [
"I think we don't need that anymore as the readable(..) flag is now per ChannelHandlerContext and so it should be enough to just use this method...\n",
"See above...\n",
"I know it is just the same as in 3 but this just is an anti-pattern as it will block the IO-Thread. Let us fix this.\n",
"See above\n",
"... | 2012-12-23T19:33:50Z | [] | the traffic package need ported back to 4.0 | We miss the traffic package so much,can you port it back to 4.0 please?
And how about the JMX support plan in 4.0?
| [] | [
"handler/src/main/java/io/netty/handler/traffic/AbstractTrafficShapingHandler.java",
"handler/src/main/java/io/netty/handler/traffic/ChannelTrafficShapingHandler.java",
"handler/src/main/java/io/netty/handler/traffic/GlobalTrafficShapingHandler.java",
"handler/src/main/java/io/netty/handler/traffic/TrafficCou... | [] | diff --git a/handler/src/main/java/io/netty/handler/traffic/AbstractTrafficShapingHandler.java b/handler/src/main/java/io/netty/handler/traffic/AbstractTrafficShapingHandler.java
new file mode 100644
index 00000000000..b061647b089
--- /dev/null
+++ b/handler/src/main/java/io/netty/handler/traffic/AbstractTrafficShaping... | null | train | train | 2012-12-23T19:24:20 | 2012-10-29T05:55:57Z | phoenix | val |
netty/netty/561_912 | netty/netty | netty/netty/561 | netty/netty/912 | [
"timestamp(timedelta=64.0, similarity=0.940854927279281)"
] | 7755a8267415ab9d8b432e87dab4397e14553880 | a2350718824d8badf227e178096ca0453211209f | [
"@danbim you are working on it ?\n",
"\"Unfortunately\" I'm on holidays, so no. I'll try to do it next week. Is that fine with you guys?\n",
"Sure!\n\nSent from my iPhone. Excuse any typos....\n\nAm 11.09.2012 um 11:57 schrieb Daniel Bimschas notifications@github.com:\n\n> \"Unfortunately\" I'm on holidays, so ... | [
"Can you update to 2013 ?\n",
"Can you update to 2013 ?\n",
"Javadocs please :)\n",
"Javadocs to all the methods following please :)\n",
"These must be volatile ...\n",
"Can you update to 2013 ?\n",
"Can you update to 2013 ?\n",
"Can you update to 2013 ?\n",
"Can you update to 2013 ?\n",
"I think ... | 2013-01-09T13:01:28Z | [
"feature"
] | Port the RXTX transport | Now that the core API got pretty stable, it's good time to port the RXTX transport to the new API.
| [
"example/pom.xml",
"pom.xml"
] | [
"example/pom.xml",
"example/src/main/java/io/netty/example/rxtx/RxtxClient.java",
"example/src/main/java/io/netty/example/rxtx/RxtxClientHandler.java",
"pom.xml",
"transport-rxtx/pom.xml",
"transport-rxtx/src/main/java/io/netty/transport/rxtx/RxtxChannel.java",
"transport-rxtx/src/main/java/io/netty/tra... | [] | diff --git a/example/pom.xml b/example/pom.xml
index 24c22d7e502..8416c11ad66 100644
--- a/example/pom.xml
+++ b/example/pom.xml
@@ -75,6 +75,11 @@
<artifactId>netty-transport-udt</artifactId>
<version>${project.version}</version>
</dependency>
+ <dependency>
+ <grou... | null | test | train | 2013-01-09T13:29:41 | 2012-08-24T09:00:21Z | trustin | val |
netty/netty/952_953 | netty/netty | netty/netty/952 | netty/netty/953 | [
"timestamp(timedelta=62.0, similarity=0.8670852673075325)"
] | 4dd462d0b501d15ec5b1adba2438d9d2a3c106cb | 3c01f59fad61277491ee2d7853d98c3f0b917b17 | [] | [] | 2013-01-18T07:22:16Z | [
"improvement",
"feature"
] | Allow to switch to single decoding mode | In our *Decoder implementation we always try to decode as many messages as possible. This is the best performance wise but is sometimes problematic. Especially when you are about to do a protocol upgrade and so will replace the decoder.
To fix this we should provide a way to switch to only decode one message per inbou... | [
"codec-http/src/main/java/io/netty/handler/codec/http/websocketx/WebSocketClientHandshaker00.java",
"codec-http/src/main/java/io/netty/handler/codec/http/websocketx/WebSocketClientHandshaker07.java",
"codec-http/src/main/java/io/netty/handler/codec/http/websocketx/WebSocketClientHandshaker08.java",
"codec-htt... | [
"codec-http/src/main/java/io/netty/handler/codec/http/websocketx/WebSocketClientHandshaker00.java",
"codec-http/src/main/java/io/netty/handler/codec/http/websocketx/WebSocketClientHandshaker07.java",
"codec-http/src/main/java/io/netty/handler/codec/http/websocketx/WebSocketClientHandshaker08.java",
"codec-htt... | [] | diff --git a/codec-http/src/main/java/io/netty/handler/codec/http/websocketx/WebSocketClientHandshaker00.java b/codec-http/src/main/java/io/netty/handler/codec/http/websocketx/WebSocketClientHandshaker00.java
index 040399d3991..6cb8768e10d 100644
--- a/codec-http/src/main/java/io/netty/handler/codec/http/websocketx/Web... | null | val | train | 2013-01-18T07:08:11 | 2013-01-18T07:19:45Z | normanmaurer | val |
netty/netty/1100_1102 | netty/netty | netty/netty/1100 | netty/netty/1102 | [
"timestamp(timedelta=61.0, similarity=0.8802064381510787)"
] | d4d01ba52c8c4c57f53386ae6e6505f91349772d | 23a098c1f8e3962ad5f198f437a67f7a824287d1 | [
"@justinsb thanks again for your fix.. I did adjust it a bit and merged it + deployed it to the snapshot repository.\n\nCould you please test with the snapshot: \nhttps://oss.sonatype.org/content/repositories/snapshots/io/netty/netty-all/4.0.0.Beta3-SNAPSHOT/netty-all-4.0.0.Beta3-20130228.104616-2.jar\n",
"Thanks... | [
"This change doesn't look right... Can you explain ?\n",
"This change is not necessary..\n",
"Obviously you know better than me, but here's my understanding...\n\nIn Netty 4, all HTTP transfers are \"chunked\" in the Netty 3 sense. They all comprise a HttpResponse, 0 or more HttpContent messages, then HttpLast... | 2013-02-27T23:39:10Z | [
"defect"
] | SPDY codec broken in 4.0.0.Beta1 | Commit 238e03f75bf7d73b22b475f6f070223857613cd2 broke SPDY; in that commit method() was renamed getMethod(). However, it looks like all occurences of method in strings were also changed to getMethod.
This broke the METHOD constant in Spdy2HttpNames et al
I think the refactoring also accidentally changed a bunch of j... | [
"codec-http/src/main/java/io/netty/handler/codec/spdy/SpdyHeaders.java",
"codec-http/src/main/java/io/netty/handler/codec/spdy/SpdyHttpEncoder.java",
"codec-http/src/main/java/io/netty/handler/codec/spdy/SpdySessionHandler.java"
] | [
"codec-http/src/main/java/io/netty/handler/codec/spdy/SpdyHeaders.java",
"codec-http/src/main/java/io/netty/handler/codec/spdy/SpdyHttpEncoder.java",
"codec-http/src/main/java/io/netty/handler/codec/spdy/SpdySessionHandler.java"
] | [] | diff --git a/codec-http/src/main/java/io/netty/handler/codec/spdy/SpdyHeaders.java b/codec-http/src/main/java/io/netty/handler/codec/spdy/SpdyHeaders.java
index 7afa1555902..6ab424cf22a 100644
--- a/codec-http/src/main/java/io/netty/handler/codec/spdy/SpdyHeaders.java
+++ b/codec-http/src/main/java/io/netty/handler/cod... | null | train | train | 2013-02-28T00:19:25 | 2013-02-27T22:06:34Z | justinsb | val |
netty/netty/1138_1146 | netty/netty | netty/netty/1138 | netty/netty/1146 | [
"timestamp(timedelta=90374.0, similarity=0.9142520246612053)"
] | a49c1047f50f31c25d94392e1f4e902d7e808b0c | 315493bfff83d4687ff8be929993e7aa22dcac80 | [
"@kryptonics411 sounds nice.. pull-req welcome :)\n",
"yeah,your are right,the decoder should be update,but I think they are so busy now~:P\n",
"It's already fixed thanks to user contrubution.\n"
] | [] | 2013-03-12T13:03:31Z | [] | ProtobufDecoder should be upgraded to take advantage of protobuf 2.5 features | From protobuf 2.5 release notes:
"Added Parser to parse directly into messages without a Builder. For
example,
Foo foo = Foo.getParser().ParseFrom(input);
Using Parser is ~25% faster than using Builder to parse messages."
see FastProtobufDecoder:
https://code.google.com/p/protobuf-rpc-pro/issues/detail?i... | [
"pom.xml",
"src/main/java/org/jboss/netty/handler/codec/protobuf/ProtobufDecoder.java"
] | [
"pom.xml",
"src/main/java/org/jboss/netty/handler/codec/protobuf/ProtobufDecoder.java"
] | [] | diff --git a/pom.xml b/pom.xml
index f1ffa4bada2..a669eeda8c1 100644
--- a/pom.xml
+++ b/pom.xml
@@ -84,7 +84,7 @@
<dependency>
<groupId>com.google.protobuf</groupId>
<artifactId>protobuf-java</artifactId>
- <version>2.4.1</version>
+ <version>2.5.0</version>
<scope>compile</scope>
... | null | train | train | 2013-03-11T01:54:35 | 2013-03-09T20:12:20Z | kryptonics411 | val |
netty/netty/1186_1190 | netty/netty | netty/netty/1186 | netty/netty/1190 | [
"timestamp(timedelta=8351.0, similarity=0.8516756070893446)"
] | 8fb80e91796e8567aca5e2b8244f853f8631217b | 240d8e246243cc13ec231fbb381c3b694959cd55 | [
"`Unpooled.wrappedBuffer(ByteBuffer)` should not fail even if a user specified a read-only buffer. However, it should return a different `ByteBuf` implementation than `UnpooledUnsafeDirectByteBuf` because it will make the read-only buffer writable.\n",
"@trustin will you take care ?\n",
"working on it....\n",
... | [] | 2013-03-21T15:47:03Z | [
"defect"
] | Is there a way to create a ByteBuf backed by a read-only ByteBuffer? | I'm mmaping a file (read-only), and would like to send it using Netty.
When I do Unpooled.wrappedBuffer(myByteBuffer) Netty throws because of these lines in UnpooledUnsafeDirectByteBuf:
```
if (initialBuffer.isReadOnly()) {
throw new IllegalArgumentException("initialBuffer is a read-only buffer.");
}... | [
"buffer/src/main/java/io/netty/buffer/Unpooled.java",
"buffer/src/main/java/io/netty/buffer/UnpooledUnsafeDirectByteBuf.java"
] | [
"buffer/src/main/java/io/netty/buffer/ReadOnlyDirectByteBuf.java",
"buffer/src/main/java/io/netty/buffer/ReadOnlyUnsafeDirectByteBuf.java",
"buffer/src/main/java/io/netty/buffer/Unpooled.java",
"buffer/src/main/java/io/netty/buffer/UnpooledUnsafeDirectByteBuf.java"
] | [
"buffer/src/test/java/io/netty/buffer/ReadOnlyDirectByteBufTest.java",
"buffer/src/test/java/io/netty/buffer/ReadOnlyUnsafeDirectByteBufTest.java",
"buffer/src/test/java/io/netty/buffer/UnpooledTest.java"
] | diff --git a/buffer/src/main/java/io/netty/buffer/ReadOnlyDirectByteBuf.java b/buffer/src/main/java/io/netty/buffer/ReadOnlyDirectByteBuf.java
new file mode 100644
index 00000000000..b1b4d8b2124
--- /dev/null
+++ b/buffer/src/main/java/io/netty/buffer/ReadOnlyDirectByteBuf.java
@@ -0,0 +1,327 @@
+/*
+ * Copyright 2013 ... | diff --git a/buffer/src/test/java/io/netty/buffer/ReadOnlyDirectByteBufTest.java b/buffer/src/test/java/io/netty/buffer/ReadOnlyDirectByteBufTest.java
new file mode 100644
index 00000000000..5c8fc9d7c08
--- /dev/null
+++ b/buffer/src/test/java/io/netty/buffer/ReadOnlyDirectByteBufTest.java
@@ -0,0 +1,142 @@
+/*
+ * Cop... | train | train | 2013-03-21T13:34:13 | 2013-03-21T00:35:00Z | justinsb | val |
netty/netty/1202_1217 | netty/netty | netty/netty/1202 | netty/netty/1217 | [
"timestamp(timedelta=100013.0, similarity=0.8897228510456948)"
] | c2cd99d90cde91d2dc91c21b8006fc947c4f5a67 | a43f5349ad72abb12728eece77ec62784ae15b61 | [
"@openaphid fixed.. thanks!\n"
] | [] | 2013-03-28T22:50:28Z | [] | Minor issue in javadoc of ByteBuf | Inside the section of **NIO Buffers** (generated from master branch), I found it states following:
```
To determine if a buffer can be converted into an NIO buffer, use nioBuffer().
```
Should `nioBufferCount()` be used here instead of `nioBuffer()`?
| [
"buffer/src/main/java/io/netty/buffer/BufType.java",
"transport/src/main/java/io/netty/channel/DefaultChannelHandlerContext.java"
] | [
"buffer/src/main/java/io/netty/buffer/BufType.java",
"transport/src/main/java/io/netty/channel/DefaultChannelHandlerContext.java"
] | [] | diff --git a/buffer/src/main/java/io/netty/buffer/BufType.java b/buffer/src/main/java/io/netty/buffer/BufType.java
index 2a82223a7e9..8b9ffd06740 100644
--- a/buffer/src/main/java/io/netty/buffer/BufType.java
+++ b/buffer/src/main/java/io/netty/buffer/BufType.java
@@ -20,7 +20,7 @@
*/
public enum BufType {
/**
... | null | test | train | 2013-03-28T21:49:36 | 2013-03-24T03:22:43Z | openaphid | val |
netty/netty/1234_1235 | netty/netty | netty/netty/1234 | netty/netty/1235 | [
"timestamp(timedelta=16.0, similarity=0.9477986483800093)"
] | 7ee2adb5878b7261abf8ce5f3e7e977627ff8c84 | a72d1bc2fc014edcc9b96d43caf68c8ed658885c | [
"If you kill `package-info.java` from tests, build will fail because of existing check style rule.\n",
"well, this rule was not there before. lets kill it too :-)\n",
"Or may be modify https://github.com/netty/netty-build/blob/master/src/main/resources/io/netty/checkstyle.xml#L25 to ignore `package-info.java` a... | [] | 2013-04-04T03:20:01Z | [] | duplicate package-info.java errors in eclipse | see below
possible work around
1) kill these files from *_/test/_ path
2) try to use package-info.html
3) try to use both package-info.html and package-info.java
```
Description Resource Path Location Type
The type package-info is already defined package-info.java /netty-buffer/src/test/java/io/netty... | [
"pom.xml"
] | [
"pom.xml"
] | [] | diff --git a/pom.xml b/pom.xml
index b1aab0aba36..be97bb753d8 100644
--- a/pom.xml
+++ b/pom.xml
@@ -369,7 +369,7 @@
<dependency>
<groupId>${project.groupId}</groupId>
<artifactId>netty-build</artifactId>
- <version>18</version>
+ <version>19-SNAPSHOT</version>... | diff --git a/buffer/src/test/java/io/netty/buffer/package-info.java b/buffer/src/test/java/io/netty/buffer/package-info.java
deleted file mode 100644
index 4271c3f5c91..00000000000
--- a/buffer/src/test/java/io/netty/buffer/package-info.java
+++ /dev/null
@@ -1,21 +0,0 @@
-/*
- * Copyright 2012 The Netty Project
- *
- ... | test | train | 2013-04-03T18:52:57 | 2013-04-03T17:11:15Z | Andrei-Pozolotin | val |
netty/netty/1228_1255 | netty/netty | netty/netty/1228 | netty/netty/1255 | [
"timestamp(timedelta=129.0, similarity=0.8571149236625287)"
] | 067a2af700b1cfa476a4bcf1f55071ccb178e25e | 19fd684a2cc3e92f91a3239f3601fad3ee67aa7f | [
"Could anyone take a look a this one? It causes lots of web site to fail\n",
"Sorry I'm quite busy… maybe you could issue a pull-req with a fix ?\n\nAm 08.04.2013 um 18:45 schrieb xhh11 notifications@github.com:\n\n> Could anyone take a look a this one? It causes lots of web site to fail\n> \n> —\n> Reply to this... | [
"Do we have to disable the check code completely? Shouldn't the characters like `\\t`, `\\r`, `\\n`, `\\f`, `0x0b` be prohibited yet?\n",
"Please keep the old signature and add a new one. We should probably set the default less strict.\n",
"Please fill the Javadoc correctly or just leave it empty.\n",
"The ... | 2013-04-08T23:08:18Z | [
"defect"
] | AbstractHttpData is too restrict in name | When a html form input name includes space, an IllegalArgumentException will be thrown. However, in the specification, name is actually defined as CDATA. See http://www.w3.org/TR/xhtml1/dtds.html#dtdentry_xhtml1-transitional.dtd_input
```
protected AbstractHttpData(String name, Charset charset, long size) {
if (na... | [
"codec-http/src/main/java/io/netty/handler/codec/http/multipart/AbstractDiskHttpData.java",
"codec-http/src/main/java/io/netty/handler/codec/http/multipart/AbstractHttpData.java",
"codec-http/src/main/java/io/netty/handler/codec/http/multipart/AbstractMemoryHttpData.java",
"codec-http/src/main/java/io/netty/h... | [
"codec-http/src/main/java/io/netty/handler/codec/http/multipart/AbstractDiskHttpData.java",
"codec-http/src/main/java/io/netty/handler/codec/http/multipart/AbstractHttpData.java",
"codec-http/src/main/java/io/netty/handler/codec/http/multipart/AbstractMemoryHttpData.java",
"codec-http/src/main/java/io/netty/h... | [
"codec-http/src/test/java/io/netty/handler/codec/http/multipart/AbstractMemoryHttpDataTest.java"
] | diff --git a/codec-http/src/main/java/io/netty/handler/codec/http/multipart/AbstractDiskHttpData.java b/codec-http/src/main/java/io/netty/handler/codec/http/multipart/AbstractDiskHttpData.java
index c854a719d23..6199b676f32 100644
--- a/codec-http/src/main/java/io/netty/handler/codec/http/multipart/AbstractDiskHttpData... | diff --git a/codec-http/src/test/java/io/netty/handler/codec/http/multipart/AbstractMemoryHttpDataTest.java b/codec-http/src/test/java/io/netty/handler/codec/http/multipart/AbstractMemoryHttpDataTest.java
index 0334ba612df..82c14bf7c9c 100644
--- a/codec-http/src/test/java/io/netty/handler/codec/http/multipart/Abstract... | val | train | 2013-04-08T21:23:53 | 2013-04-02T16:54:21Z | xhh11 | val |
netty/netty/1426_1429 | netty/netty | netty/netty/1426 | netty/netty/1429 | [
"timestamp(timedelta=52.0, similarity=0.9419155171733438)"
] | dbab41cc50f4ddb71a153df342748ca1d85ab8e7 | a094341c566ddfe82d44bbbcbc2adabc7ddbdc50 | [
"@menacher I wonder why you not can just pass the thread count in by your own ? The problem is that there is not a good \"default\" value as it really depends on how many NioEventLoopGroups you create and what they do.\n",
"@normanmaurer Agreed. But normally when you pass in 0 or -ve to such api it goes for a def... | [] | 2013-06-07T04:13:05Z | [
"defect"
] | Spring instantiation of NioEventLoopGroup with 0 number of threads is now complicated | I used to use the following constructor while instantiating `NioEventLoopGroup` boss and worker threads.
``` java
/**
* Create a new instance using nThreads number of threads, the given {@link ThreadFactory} and the
* {@link SelectorProvider} which is returned by {@link SelectorProvider#provider()}.
... | [
"transport/src/main/java/io/netty/channel/nio/NioEventLoopGroup.java"
] | [
"transport/src/main/java/io/netty/channel/nio/NioEventLoopGroup.java"
] | [] | diff --git a/transport/src/main/java/io/netty/channel/nio/NioEventLoopGroup.java b/transport/src/main/java/io/netty/channel/nio/NioEventLoopGroup.java
index 04d89b68fac..d11bb12865f 100644
--- a/transport/src/main/java/io/netty/channel/nio/NioEventLoopGroup.java
+++ b/transport/src/main/java/io/netty/channel/nio/NioEve... | null | train | train | 2013-06-25T04:07:15 | 2013-06-06T03:06:56Z | menacher | val |
netty/netty/1508_1510 | netty/netty | netty/netty/1508 | netty/netty/1510 | [
"timestamp(timedelta=120917.0, similarity=0.8648559196228794)"
] | a4ee2841be0be8e69d624f0543ab9d0ebb4b9567 | b632e26bea7f9615ba74808b9a89d21dc21078a9 | [
"@fbettag I get the following exception when run latest code from master:\n\n[info] Running io.wasted.netty.websocket.bench.Client ws://localhost:5555 50\n21:19:49.042 DEBUG i.n.u.i.l.InternalLoggerFactory - Using SLF4J as the default logging framework\n21:19:49.046 DEBUG i.n.c.MultithreadEventLoopGroup - io.netty.... | [] | 2013-07-02T15:51:48Z | [
"defect"
] | ResourceLeakException in CR7 | During our tests with our benchmark, we saw a Leak which according to us and norman did not make sense.
Test-Case can be found at https://github.com/wasted/netty-websocket-bench
Output from Server:
fbettag@committers:~/netty-bench$ ./sbt 'run-main io.wasted.netty.websocket.bench.Server'
[info] Loading project defini... | [
"common/src/main/java/io/netty/util/ResourceLeakException.java"
] | [
"common/src/main/java/io/netty/util/ResourceLeakException.java"
] | [] | diff --git a/common/src/main/java/io/netty/util/ResourceLeakException.java b/common/src/main/java/io/netty/util/ResourceLeakException.java
index a69238884bf..d1bdec0c4ff 100644
--- a/common/src/main/java/io/netty/util/ResourceLeakException.java
+++ b/common/src/main/java/io/netty/util/ResourceLeakException.java
@@ -16,... | null | train | train | 2013-07-02T13:46:09 | 2013-07-02T12:57:29Z | fbettag | val |
netty/netty/1469_1510 | netty/netty | netty/netty/1469 | netty/netty/1510 | [
"timestamp(timedelta=61230.0, similarity=0.8410950705895608)"
] | a4ee2841be0be8e69d624f0543ab9d0ebb4b9567 | b632e26bea7f9615ba74808b9a89d21dc21078a9 | [
"It is for netty-4.0.0.CR5\n",
"What are the types of the handlers in the pipeline?\n\nWhen extending `ChannelInboundHandler(Adapter)`, you have to call `MessageList.releaseAllAndRecycle()` on the incoming message lists after processing them.\n\n(some utilities for this being worked in #1446)\n",
"Hello,\n\nI e... | [] | 2013-07-02T15:51:48Z | [] | io.netty.util.ResourceLeakDetector reportLeak | ```
Jun 18, 2013 7:05:31 PM io.netty.util.ResourceLeakDetector reportLeak
WARNING: LEAK: ByteBuf was GC'd before being released correctly.
io.netty.util.ResourceLeakException: io.netty.buffer.DefaultCompositeByteBuf@32f5627f
at io.netty.util.ResourceLeakDetector$DefaultResourceLeak.<init>(ResourceLeakDetector.ja... | [
"common/src/main/java/io/netty/util/ResourceLeakException.java"
] | [
"common/src/main/java/io/netty/util/ResourceLeakException.java"
] | [] | diff --git a/common/src/main/java/io/netty/util/ResourceLeakException.java b/common/src/main/java/io/netty/util/ResourceLeakException.java
index a69238884bf..d1bdec0c4ff 100644
--- a/common/src/main/java/io/netty/util/ResourceLeakException.java
+++ b/common/src/main/java/io/netty/util/ResourceLeakException.java
@@ -16,... | null | val | train | 2013-07-02T13:46:09 | 2013-06-19T09:29:05Z | rostaocenasek | val |
netty/netty/1534_1541 | netty/netty | netty/netty/1534 | netty/netty/1541 | [
"timestamp(timedelta=138586.0, similarity=0.8643002822383684)"
] | 75229e145a8a593c6058938eb78c3b6dacdf9315 | 7663149e7373fdce308f99e3df6988078b531b47 | [
"Tested with netty-handler-4.0.0.CR10-20130707.150539-39.jar -- still occurs but with much less frequency.\n",
"Hmm.. Maybe a way to reproduce?\n\nAm 07.07.2013 um 18:14 schrieb Jeff Pinner notifications@github.com:\n\n> Tested with netty-handler-4.0.0.CR10-20130707.150539-39.jar -- still occurs but with much les... | [
"Why was this moved before the instantiation of the exception?\n",
"Isn't `this.packetLength` already `0`?\n"
] | 2013-07-08T13:35:41Z | [
"defect"
] | SSLHandler throws NotSslRecordException on partial data | In Netty 3, SSLHandler read the SSL packet length and aggregated the data until the entire packet had been received:
if (buffer.readableBytes() < packetLength) {
return null;
}
In Netty 4, SSLHandler computes the packet length, but then calls unwrap without aggregating the data. If the engine reads the available ... | [
"handler/src/main/java/io/netty/handler/ssl/SslHandler.java"
] | [
"handler/src/main/java/io/netty/handler/ssl/SslHandler.java"
] | [] | diff --git a/handler/src/main/java/io/netty/handler/ssl/SslHandler.java b/handler/src/main/java/io/netty/handler/ssl/SslHandler.java
index 01ef75131a2..ee8ae7554a1 100644
--- a/handler/src/main/java/io/netty/handler/ssl/SslHandler.java
+++ b/handler/src/main/java/io/netty/handler/ssl/SslHandler.java
@@ -19,6 +19,7 @@
... | null | test | train | 2013-07-09T07:53:05 | 2013-07-06T23:33:48Z | jpinner | val |
netty/netty/1545_1546 | netty/netty | netty/netty/1545 | netty/netty/1546 | [
"timestamp(timedelta=83676.0, similarity=0.8647030483939786)"
] | 7bedd8f28ef52a0c825133bc5926764444d7b3a9 | 4ab35bfa512c107ecbb0f1ddeabddb1691c78816 | [
"@jestan after more thoughts I wonder why you not use InitMaxStreams.create(...) directly... Can you provide more info ?\n",
"@jestan reverted this fix again as after more review I think the current impl is correct.\n",
"@normanmaurer I think there is a problem. SctpChannelOption validates for List<Integer>. Th... | [] | 2013-07-09T18:38:39Z | [] | ClassCastException while setting Sctp Inbound/Outbound streams in ChannelConfig in CR10-SNAPSHOT | In Netty CR-10 SNAPSHOT
``` Java
final int MAX_INBOUND_STREAMS = 10;
final int MAX_OUTBOUND_STREAMS = 10;
List<Integer> streamConfig = new ArrayList<Integer>(2);
streamConfig.add(MAX_INBOUND_STREAMS);
streamConfig.add(MAX_OUTBOUND_STREAMS);
Bootstrap cb = new Bootstrap();
cb.group(new N... | [
"transport-sctp/src/main/java/io/netty/channel/sctp/DefaultSctpChannelConfig.java"
] | [
"transport-sctp/src/main/java/io/netty/channel/sctp/DefaultSctpChannelConfig.java"
] | [] | diff --git a/transport-sctp/src/main/java/io/netty/channel/sctp/DefaultSctpChannelConfig.java b/transport-sctp/src/main/java/io/netty/channel/sctp/DefaultSctpChannelConfig.java
index 8e7c2ffb222..37ec6ee79fc 100644
--- a/transport-sctp/src/main/java/io/netty/channel/sctp/DefaultSctpChannelConfig.java
+++ b/transport-sc... | null | train | train | 2013-07-09T17:36:47 | 2013-07-09T18:24:18Z | jestan | val |
netty/netty/1551_1552 | netty/netty | netty/netty/1551 | netty/netty/1552 | [
"timestamp(timedelta=21.0, similarity=0.9527485477144009)"
] | 4d44b379394f0ce82c5b0cfa610d8ba5a0d5d4e3 | 84846ab56110b61af15c43bace1d1cc095e067cb | [
"Issued pull request #1552.\n",
"Will you provide a fix?\n\nAm 10.07.2013 um 20:00 schrieb Jeff Pinner notifications@github.com:\n\n> —\n> Reply to this email directly or view it on GitHub.\n",
"Yep -- see #1552 :)\n",
"@jpinner merged your pullreq in.. Thanks\n"
] | [] | 2013-07-10T18:17:58Z | [
"defect"
] | HttpContentEncoder should not remove Content-Length when acting as a passthrough. | [
"codec-http/src/main/java/io/netty/handler/codec/http/HttpContentEncoder.java"
] | [
"codec-http/src/main/java/io/netty/handler/codec/http/HttpContentEncoder.java"
] | [] | diff --git a/codec-http/src/main/java/io/netty/handler/codec/http/HttpContentEncoder.java b/codec-http/src/main/java/io/netty/handler/codec/http/HttpContentEncoder.java
index fb8ec835cab..106e37233a1 100644
--- a/codec-http/src/main/java/io/netty/handler/codec/http/HttpContentEncoder.java
+++ b/codec-http/src/main/java... | null | val | train | 2013-07-10T18:10:52 | 2013-07-10T18:00:43Z | jpinner | val | |
netty/netty/1550_1554 | netty/netty | netty/netty/1550 | netty/netty/1554 | [
"timestamp(timedelta=25.0, similarity=0.8970638251443727)"
] | cf9ee928b012bb2af24372ab180bacdb02cf7c74 | 60e00f27e922ab6a979714c82e3733bf17422448 | [
"I will try to go through the codec carefully and see if anything else is broken.\n",
"So you will issue a pullreq?\n\nAm 10.07.2013 um 19:34 schrieb Jeff Pinner notifications@github.com:\n\n> I will try to go through the codec carefully and see if anything else is broken.\n> \n> —\n> Reply to this email directly... | [] | 2013-07-10T19:22:16Z | [
"defect"
] | SpdyHttpDecoder broken | At some point in the porting to netty 4 the SpdyHttpDecoder stopped writing RstStreams. As an example, the following code:
// If a client receives a response with a truncated header block,
// reply with a RST_STREAM with error code INTERNAL_ERROR.
if (spdySynStreamFrame.isTruncated()) {
SpdyRstStreamFrame spdyRstS... | [
"codec-http/src/main/java/io/netty/handler/codec/spdy/SpdyHttpDecoder.java"
] | [
"codec-http/src/main/java/io/netty/handler/codec/spdy/SpdyHttpDecoder.java"
] | [] | diff --git a/codec-http/src/main/java/io/netty/handler/codec/spdy/SpdyHttpDecoder.java b/codec-http/src/main/java/io/netty/handler/codec/spdy/SpdyHttpDecoder.java
index f9a991916eb..7041cfda79a 100644
--- a/codec-http/src/main/java/io/netty/handler/codec/spdy/SpdyHttpDecoder.java
+++ b/codec-http/src/main/java/io/netty... | null | test | train | 2013-07-10T21:02:00 | 2013-07-10T17:33:28Z | jpinner | val |
netty/netty/1616_1617 | netty/netty | netty/netty/1616 | netty/netty/1617 | [
"timestamp(timedelta=55.0, similarity=0.8490939366657063)"
] | a4d0341ea11140b1cfed2414f5292dffd3445dc8 | 0891c024d092f89f8790d0c0f8b1e99dc09b530c | [
"fixed with 80f92f90cbc9a8267cad3f338641982b53478e8a\n"
] | [] | 2013-07-19T20:19:57Z | [
"defect"
] | SpdyHttpEncoder does not correctly set isLast() when sending a FullHttpMessage | For a FullHttpMessage with no content, two SPDY frames are sent, one SpdySynStreamFrame(last=false) plus one SpdyDataFrame with content and last=true. For known empty messages, last should be set to true in the SpdySynStreamFrame.
| [
"codec-http/src/main/java/io/netty/handler/codec/spdy/SpdyHttpEncoder.java"
] | [
"codec-http/src/main/java/io/netty/handler/codec/spdy/SpdyHttpEncoder.java"
] | [] | diff --git a/codec-http/src/main/java/io/netty/handler/codec/spdy/SpdyHttpEncoder.java b/codec-http/src/main/java/io/netty/handler/codec/spdy/SpdyHttpEncoder.java
index 3862e2aedb3..a8e3eefd262 100644
--- a/codec-http/src/main/java/io/netty/handler/codec/spdy/SpdyHttpEncoder.java
+++ b/codec-http/src/main/java/io/netty... | null | train | train | 2013-07-19T12:30:40 | 2013-07-19T18:29:37Z | ssilverman | val |
netty/netty/1597_1618 | netty/netty | netty/netty/1597 | netty/netty/1618 | [
"timestamp(timedelta=521.0, similarity=0.8774795595937743)"
] | a4d0341ea11140b1cfed2414f5292dffd3445dc8 | d3f59be0b0270c0094a1fba9058504a1d2adfcb8 | [
"This is also broken in Netty 3.6, line 188.\n",
"Thanks.. Let me look into it\n\nAm 17.07.2013 um 18:04 schrieb ssilverman notifications@github.com:\n\n> The problem is on line 188. This will fail with a StringIndexOutOfBoundsException if the line contains just \"\\r\\n\". The length() check for > 0 needs to be ... | [] | 2013-07-20T00:50:09Z | [
"defect"
] | Bug in ByteBufInputStream.readLine() | The problem is on lines 201-202. This will fail with a StringIndexOutOfBoundsException if the line contains just "\r\n". The length() check for > 0 needs to be done each time through the loop.
| [
"buffer/src/main/java/io/netty/buffer/ByteBufInputStream.java"
] | [
"buffer/src/main/java/io/netty/buffer/ByteBufInputStream.java"
] | [
"buffer/src/test/java/io/netty/buffer/ByteBufStreamTest.java"
] | diff --git a/buffer/src/main/java/io/netty/buffer/ByteBufInputStream.java b/buffer/src/main/java/io/netty/buffer/ByteBufInputStream.java
index f99e4c6444b..46b11b090c4 100644
--- a/buffer/src/main/java/io/netty/buffer/ByteBufInputStream.java
+++ b/buffer/src/main/java/io/netty/buffer/ByteBufInputStream.java
@@ -186,21 ... | diff --git a/buffer/src/test/java/io/netty/buffer/ByteBufStreamTest.java b/buffer/src/test/java/io/netty/buffer/ByteBufStreamTest.java
index 430df8ff5dd..7f2d180061f 100644
--- a/buffer/src/test/java/io/netty/buffer/ByteBufStreamTest.java
+++ b/buffer/src/test/java/io/netty/buffer/ByteBufStreamTest.java
@@ -134,6 +134,... | test | train | 2013-07-19T12:30:40 | 2013-07-17T16:04:44Z | ssilverman | val |
netty/netty/1654_1655 | netty/netty | netty/netty/1654 | netty/netty/1655 | [
"timestamp(timedelta=53224.0, similarity=0.9381250108264462)"
] | fabefba79185ce7ec143d911ae86f5ab8bb08845 | a09d6f95fa2c9f371588a62182cc0605c66174d2 | [
"@jpinner what you mean with \"local sockets\" ?\n",
"@normanmaurer i mean LocalChannel.java LocalServerChannel.java\n",
"I'm happy to take a stab at this tonight and try to get you a pull req if you want.\n",
"Sure thing! Thanks a lot :)\n\nAm 26.07.2013 um 07:45 schrieb Jeff Pinner notifications@github.com:... | [] | 2013-07-26T06:23:27Z | [
"defect",
"cleanup"
] | Remove AbstractChannel#doPreClose() | tl;dr this is broken and should be removed instead of fixed
doPreClose is currently called in closeFuture.setClosed():
1) During registration failure closeForcily() calls doClose before setting the closeFuture -- so doPreClose() is called after doClose().
2) During early registration failure (unable to schedule run ... | [
"transport/src/main/java/io/netty/channel/AbstractChannel.java",
"transport/src/main/java/io/netty/channel/local/LocalChannel.java",
"transport/src/main/java/io/netty/channel/local/LocalServerChannel.java"
] | [
"transport/src/main/java/io/netty/channel/AbstractChannel.java",
"transport/src/main/java/io/netty/channel/local/LocalChannel.java",
"transport/src/main/java/io/netty/channel/local/LocalServerChannel.java"
] | [] | diff --git a/transport/src/main/java/io/netty/channel/AbstractChannel.java b/transport/src/main/java/io/netty/channel/AbstractChannel.java
index 4f544bc67ac..638207b5b3a 100644
--- a/transport/src/main/java/io/netty/channel/AbstractChannel.java
+++ b/transport/src/main/java/io/netty/channel/AbstractChannel.java
@@ -415... | null | val | train | 2013-07-25T20:24:27 | 2013-07-26T01:44:08Z | jpinner | val |
netty/netty/1720_1721 | netty/netty | netty/netty/1720 | netty/netty/1721 | [
"timestamp(timedelta=53.0, similarity=0.9601021091043038)"
] | 0b4adc0889e638f474f5876668cda0851ee3cfd7 | cdd000e8551cc6bbe4dfeb81973c8ba5df5168f0 | [
"duplicate of #1721 \n"
] | [
"You should move the setSuccess() call before the fireWriteComplete as we always notify the future first before fire this event in other transports\n"
] | 2013-08-09T16:03:45Z | [] | intermittent: local channel sometimes sends messages after close (3.6) | A local channel can receive messages after it has been closed. This is the result of a race condition in DefaultLocalChannel.flushWriteBuffer:
```
e.getFuture().setSuccess();
fireMessageReceived(pairedChannel, e.getMessage());
fireWriteComplete(this, 1);
```
The future listener in this case is HttpConnectionHandler.... | [
"src/main/java/org/jboss/netty/channel/local/DefaultLocalChannel.java"
] | [
"src/main/java/org/jboss/netty/channel/local/DefaultLocalChannel.java"
] | [] | diff --git a/src/main/java/org/jboss/netty/channel/local/DefaultLocalChannel.java b/src/main/java/org/jboss/netty/channel/local/DefaultLocalChannel.java
index da02be3ece8..d127cd4d0a1 100644
--- a/src/main/java/org/jboss/netty/channel/local/DefaultLocalChannel.java
+++ b/src/main/java/org/jboss/netty/channel/local/Defa... | null | train | train | 2013-06-05T08:52:56 | 2013-08-09T15:59:39Z | wgallagher | val |
netty/netty/1481_1735 | netty/netty | netty/netty/1481 | netty/netty/1735 | [
"timestamp(timedelta=40.0, similarity=0.8580937807760761)"
] | cc12e40065a0a27d81266cda863a4d24b4487a59 | 8c6520212206543f199a73a006469a4f1c51031a | [
"I found [this example ](http://www.jcraft.com/jsch/examples/CompressionJUZ.java) which explains how to \n**solely** use JDK for compression/decompression of a byte array as opposed to relying on external library JZlib.\n\nThe example is actually made by the author of JZlib. \n",
"Let us try to do this for 4.1\n"... | [
"`Unpooled.copiedBuffer()`?\n",
"Same for similar `wrapperBuffer()` calls\n",
"Better use do-while because we already know `in` is readable at this point. Same applies for similar loops.\n"
] | 2013-08-12T18:33:59Z | [
"improvement",
"feature"
] | JDK zlib decompression support | With the changes implemented in JDK 7 I'm a bit uncertain as to whether a dependency on JZLib is still required.
Currently Netty implements `JdkZlibEncoder` but doesn't implement a corresponding `JdkZlibDecoder`. I believe this is a historical omission based on the inability of previous versions of the JDK.
Source co... | [
"codec/src/main/java/io/netty/handler/codec/compression/ZlibCodecFactory.java"
] | [
"codec/src/main/java/io/netty/handler/codec/compression/JdkZlibDecoder.java",
"codec/src/main/java/io/netty/handler/codec/compression/ZlibCodecFactory.java"
] | [
"codec/src/test/java/io/netty/handler/codec/compression/JdkZlibTest.java"
] | diff --git a/codec/src/main/java/io/netty/handler/codec/compression/JdkZlibDecoder.java b/codec/src/main/java/io/netty/handler/codec/compression/JdkZlibDecoder.java
new file mode 100644
index 00000000000..5d860a15202
--- /dev/null
+++ b/codec/src/main/java/io/netty/handler/codec/compression/JdkZlibDecoder.java
@@ -0,0 ... | diff --git a/codec/src/test/java/io/netty/handler/codec/compression/JdkZlibTest.java b/codec/src/test/java/io/netty/handler/codec/compression/JdkZlibTest.java
new file mode 100644
index 00000000000..9a93aa8fb2f
--- /dev/null
+++ b/codec/src/test/java/io/netty/handler/codec/compression/JdkZlibTest.java
@@ -0,0 +1,89 @@
... | train | train | 2013-08-12T07:23:00 | 2013-06-23T11:25:26Z | phansson | val |
netty/netty/1765_1767 | netty/netty | netty/netty/1765 | netty/netty/1767 | [
"timestamp(timedelta=16622.0, similarity=0.8519716299467585)"
] | fb619f23947aab158a11730e00f4dbd490093669 | be70d42a340f4cba19069b1c5d194c0d02930425 | [
"adding `buf.append(Long.toHexString(ThreadLocalRandom.current().nextLong() & 0xFFFFFFFFL | 0x100000000L));` in the LocalAddress constructor makes the collision less likely, although I don't think it removes it altogether. Perhaps using something like `java.util.UUID` would be more appropriate, ala `buf.append(UUI... | [] | 2013-08-21T15:52:16Z | [
"defect"
] | LocalAddress's can collide in a multi-client setup | Using Netty 4.0.7, I'm randomly running into this exception when connecting many clients to the server over a LocalChannel:
```
io.netty.channel.ChannelException: address already in use by: [id: 0x65219647, local:E:65219647 => local:stardog]
at io.netty.channel.local.LocalChannelRegistry.register(LocalChannelRegis... | [
"transport/src/main/java/io/netty/channel/local/LocalAddress.java"
] | [
"transport/src/main/java/io/netty/channel/local/LocalAddress.java"
] | [] | diff --git a/transport/src/main/java/io/netty/channel/local/LocalAddress.java b/transport/src/main/java/io/netty/channel/local/LocalAddress.java
index 6098cca470e..511f012b65c 100644
--- a/transport/src/main/java/io/netty/channel/local/LocalAddress.java
+++ b/transport/src/main/java/io/netty/channel/local/LocalAddress.... | null | test | train | 2013-08-21T16:39:50 | 2013-08-21T13:47:36Z | mhgrove | val |
netty/netty/1833_1834 | netty/netty | netty/netty/1833 | netty/netty/1834 | [
"timestamp(timedelta=37.0, similarity=0.8890629724375693)"
] | 87a6a68059f27b3118d56f76f0d98621f4a618be | c38ef2c4c86396b8c9521a8eb6312cfde414b56c | [
"@jianjin can you give some details on what not work and what you expect it to do ?\n",
"If an url like this : http://foo.com/images;num=10?query=name;value=123\nthe first \";\" should not be replaced by &, because it is part of path but NOT query.\nHost:foo.com\nPath:/images\nPath Parameter:num=10\nQueryParamete... | [] | 2013-09-12T12:10:02Z | [
"defect"
] | QueryStringDecoder replace all ; using & | If the url is /hello;pathparameter
Then System.out.println(decoder.getPath());
will replace ; to & : /hello&pathparameter
Simply replace ; use & does not work.
| [
"codec-http/src/main/java/io/netty/handler/codec/http/QueryStringDecoder.java"
] | [
"codec-http/src/main/java/io/netty/handler/codec/http/QueryStringDecoder.java"
] | [] | diff --git a/codec-http/src/main/java/io/netty/handler/codec/http/QueryStringDecoder.java b/codec-http/src/main/java/io/netty/handler/codec/http/QueryStringDecoder.java
index 792452f44e3..4075efa25b1 100644
--- a/codec-http/src/main/java/io/netty/handler/codec/http/QueryStringDecoder.java
+++ b/codec-http/src/main/java... | null | test | train | 2013-09-12T09:29:40 | 2013-09-12T03:35:43Z | jianjin | val |
netty/netty/1844_1856 | netty/netty | netty/netty/1844 | netty/netty/1856 | [
"timestamp(timedelta=23.0, similarity=0.8510320016967471)"
] | a855f19ad6fd79a3b6034bff3fdeab710d5563d1 | 92433c31fcb845052ec51c35126a0c15dfe41311 | [
"The following fix should work:\n\n``` java\n String uri = request.getUri();\n\n if (uri.length() == 0) {\n uri += SLASH;\n } else {\n int start = uri.indexOf(\"://\");\n if (start != -1 && uri.charAt(0) != SLASH) {\n int startIndex = start + 3;\n... | [] | 2013-09-19T15:49:40Z | [] | HttpRequestEncoder erroneously appending '/' to absolute path requests that contain '://' in the path, query, or fragment | `io.netty.handler.codec.http.HttpRequestEncoder` contains the following code:
``` java
// Add / as absolute path if no is present.
// See http://tools.ietf.org/html/rfc2616#section-5.1.2
String uri = request.getUri();
int start = uri.indexOf("://");
if (start != -1) {
... | [
"codec-http/src/main/java/io/netty/handler/codec/http/HttpRequestEncoder.java"
] | [
"codec-http/src/main/java/io/netty/handler/codec/http/HttpRequestEncoder.java"
] | [
"codec-http/src/test/java/io/netty/handler/codec/http/HttpRequestEncoderTest.java"
] | diff --git a/codec-http/src/main/java/io/netty/handler/codec/http/HttpRequestEncoder.java b/codec-http/src/main/java/io/netty/handler/codec/http/HttpRequestEncoder.java
index c7aa051596e..3dc959bd1d1 100644
--- a/codec-http/src/main/java/io/netty/handler/codec/http/HttpRequestEncoder.java
+++ b/codec-http/src/main/java... | diff --git a/codec-http/src/test/java/io/netty/handler/codec/http/HttpRequestEncoderTest.java b/codec-http/src/test/java/io/netty/handler/codec/http/HttpRequestEncoderTest.java
index 3d13cf9faef..6ed9b95ff62 100644
--- a/codec-http/src/test/java/io/netty/handler/codec/http/HttpRequestEncoderTest.java
+++ b/codec-http/s... | val | train | 2013-09-19T07:29:21 | 2013-09-16T14:57:23Z | ANorwell | val |
netty/netty/1832_1877 | netty/netty | netty/netty/1832 | netty/netty/1877 | [
"timestamp(timedelta=47.0, similarity=0.9259862956779858)"
] | 512908f993d183cc2a7d8f8f9ebec44d174b7488 | 474672b120d25ddb95d5ff2ad3a202b8b645f6e3 | [
"@wgallagher and assigned to you... have fun ;)\n",
"@wgallagher ping ;)\n",
"@wgallagher any news here ? I would love to cut 4.0.10.Final early next week.\n",
"@oxtoacart was fixed... please retest with latest snapshot.\n",
"@wgallagher I tried `4.1.0.Alpha1-SNAPSHOT` and this seems to be working fine for ... | [] | 2013-09-30T15:35:58Z | [] | Channel writability change notifications sometimes fail to fire | As of the changes made for #1766, sometimes channel writability notifications are lost. In particular, I've noticed this when writing from a thread other than the channel's EventLoop.
I believe that there's a logic error in `ChannelOutboundBuffer` in the `incrementPendingOutboundBytes` and `decrementPendingOutboundBy... | [
"transport/src/main/java/io/netty/channel/ChannelOutboundBuffer.java",
"transport/src/main/java/io/netty/channel/DefaultChannelHandlerContext.java"
] | [
"transport/src/main/java/io/netty/channel/ChannelOutboundBuffer.java",
"transport/src/main/java/io/netty/channel/DefaultChannelHandlerContext.java"
] | [
"transport/src/test/java/io/netty/channel/ReentrantChannelTest.java"
] | diff --git a/transport/src/main/java/io/netty/channel/ChannelOutboundBuffer.java b/transport/src/main/java/io/netty/channel/ChannelOutboundBuffer.java
index 48a8c31aa78..393aad82463 100644
--- a/transport/src/main/java/io/netty/channel/ChannelOutboundBuffer.java
+++ b/transport/src/main/java/io/netty/channel/ChannelOut... | diff --git a/transport/src/test/java/io/netty/channel/ReentrantChannelTest.java b/transport/src/test/java/io/netty/channel/ReentrantChannelTest.java
index 67cd5fbe177..f0bf9bb308d 100644
--- a/transport/src/test/java/io/netty/channel/ReentrantChannelTest.java
+++ b/transport/src/test/java/io/netty/channel/ReentrantChan... | test | train | 2013-09-30T14:49:03 | 2013-09-11T15:20:29Z | oxtoacart | val |
netty/netty/1958_1963 | netty/netty | netty/netty/1958 | netty/netty/1963 | [
"timestamp(timedelta=26.0, similarity=0.936257143643118)"
] | 285dd79a10ac5363ed0e579005c97af76aac7592 | d52986be214f1bce4ce6b1251084bfb65b24d2de | [
"@nxmbriggs404 I don't think there is any \"real\" reason for this.... @lw346 could you have a look ?\n",
"Sure - I think it's just me failing to read the spec properly. Will sort out by tomorrow.\n",
"This has been slightly hampered by the fact that java doesn't have unsigned types, but I think I've got this ... | [] | 2013-11-01T17:20:50Z | [] | Use CRC32-C in Snappy Framing Format Implementation | I have recently been researching Java Snappy implementations and came across a curiosity in netty's implementation. Specifically, it looks like the code in:
https://github.com/netty/netty/blob/master/codec/src/main/java/io/netty/handler/codec/compression/Snappy.java
is using CRC32 rather than CRC32-C for its masked ... | [
"codec/src/main/java/io/netty/handler/codec/compression/Snappy.java"
] | [
"codec/src/main/java/io/netty/handler/codec/compression/Crc32c.java",
"codec/src/main/java/io/netty/handler/codec/compression/Snappy.java"
] | [
"codec/src/test/java/io/netty/handler/codec/compression/SnappyFramedDecoderTest.java",
"codec/src/test/java/io/netty/handler/codec/compression/SnappyFramedEncoderTest.java",
"codec/src/test/java/io/netty/handler/codec/compression/SnappyTest.java"
] | diff --git a/codec/src/main/java/io/netty/handler/codec/compression/Crc32c.java b/codec/src/main/java/io/netty/handler/codec/compression/Crc32c.java
new file mode 100644
index 00000000000..b67c20004ae
--- /dev/null
+++ b/codec/src/main/java/io/netty/handler/codec/compression/Crc32c.java
@@ -0,0 +1,126 @@
+/*
+ * Copyri... | diff --git a/codec/src/test/java/io/netty/handler/codec/compression/SnappyFramedDecoderTest.java b/codec/src/test/java/io/netty/handler/codec/compression/SnappyFramedDecoderTest.java
index 2b255443090..625ac1f1e05 100644
--- a/codec/src/test/java/io/netty/handler/codec/compression/SnappyFramedDecoderTest.java
+++ b/cod... | train | train | 2013-10-31T06:26:41 | 2013-10-28T15:46:34Z | nxmbriggs404 | val |
netty/netty/1810_1983 | netty/netty | netty/netty/1810 | netty/netty/1983 | [
"timestamp(timedelta=18.0, similarity=0.9503122391605027)"
] | 6ba1a85c4b4a317136eac237a1490de4d6c73ac7 | a2a0fb52f974d3e2a925ecee88ebebcad1d21232 | [
"@trustin good idea... will you work on this ?\n",
"Just a proposal : why not using uuid (real one) such that unicity is provable ?\n",
"Note: not uuid from jvm but another implementation...\n",
"Yeah, we can do that, too. 3.x had to work with Java 5 which did not have access to the hardware address of the n... | [
"Could you commit this as a separate thing as it's not related ?\n",
"I find this naming a bit confusing as from the naming I would expect to have a short returned. Same goes for the user where I would expect long\n",
"why transient ?\n",
"Serialization.\n",
"Ah missed that it extends Serializable... makes ... | 2013-11-15T13:52:28Z | [
"feature"
] | Resurrect Channel.id() | If we don't insist the type of `Channel.id()` to be an integer, I think we might be able to make it unique for sure. For example, it could be `hashCode` + `identityHashCode` + `nanoTime` + `sequence`. Practically, this should never collide.
| [
"buffer/src/main/java/io/netty/buffer/ByteBufUtil.java",
"transport/src/main/java/io/netty/channel/AbstractChannel.java",
"transport/src/main/java/io/netty/channel/Channel.java"
] | [
"buffer/src/main/java/io/netty/buffer/ByteBufUtil.java",
"transport/src/main/java/io/netty/channel/AbstractChannel.java",
"transport/src/main/java/io/netty/channel/Channel.java",
"transport/src/main/java/io/netty/channel/ChannelId.java",
"transport/src/main/java/io/netty/channel/DefaultChannelId.java"
] | [] | diff --git a/buffer/src/main/java/io/netty/buffer/ByteBufUtil.java b/buffer/src/main/java/io/netty/buffer/ByteBufUtil.java
index 8860cbae740..f501ed13ca1 100644
--- a/buffer/src/main/java/io/netty/buffer/ByteBufUtil.java
+++ b/buffer/src/main/java/io/netty/buffer/ByteBufUtil.java
@@ -75,6 +75,38 @@ public static String... | null | train | train | 2013-11-15T15:08:25 | 2013-09-04T00:17:30Z | trustin | val |
netty/netty/1988_1995 | netty/netty | netty/netty/1988 | netty/netty/1995 | [
"timestamp(timedelta=20413.0, similarity=0.8800867546478833)"
] | d0e928db707460e00bb1269dc042401246c76324 | cf13bf6ec1068702f949013b8531e486efc3f38e | [
"Checked against examples & submitted PR #1995 \n",
"That one can be closed, #1995 is pulled :)\n",
"@ifesdjeen true.. thanks!\n"
] | [] | 2013-11-20T09:13:46Z | [] | The Javadoc example of IdleStateHandler is incorrect | The second param in userEventTriggered() should be converted to IdleStateEvent instead of IdleState.
The following two lines should be changed:
if (evt instanceof IdleState} {
IdleState e = (IdleState) evt;
| [
"handler/src/main/java/io/netty/handler/timeout/IdleStateHandler.java"
] | [
"handler/src/main/java/io/netty/handler/timeout/IdleStateHandler.java"
] | [] | diff --git a/handler/src/main/java/io/netty/handler/timeout/IdleStateHandler.java b/handler/src/main/java/io/netty/handler/timeout/IdleStateHandler.java
index 19b8b9c8d90..c69aa7b38e5 100644
--- a/handler/src/main/java/io/netty/handler/timeout/IdleStateHandler.java
+++ b/handler/src/main/java/io/netty/handler/timeout/I... | null | val | train | 2013-11-18T09:00:23 | 2013-11-18T09:48:42Z | iridium77 | val |
netty/netty/2014_2015 | netty/netty | netty/netty/2014 | netty/netty/2015 | [
"timestamp(timedelta=23123.0, similarity=0.9999999999999998)"
] | 4ea39aa9df93003f51a304adadc4adffa296d5be | eaee981c4571f08d8d8a86abd0b6e041e795db26 | [
"Fixed via 8b495bb6e14becb5bda5e8b80257d5d186e18181\n"
] | [] | 2013-11-29T02:38:52Z | [
"defect"
] | JDKZlibEncoder hangs (fails to flush) on large messages | If the message is great than 8k the message is not flushed.
| [
"codec/src/main/java/io/netty/handler/codec/compression/JdkZlibEncoder.java"
] | [
"codec/src/main/java/io/netty/handler/codec/compression/JdkZlibEncoder.java"
] | [] | diff --git a/codec/src/main/java/io/netty/handler/codec/compression/JdkZlibEncoder.java b/codec/src/main/java/io/netty/handler/codec/compression/JdkZlibEncoder.java
index d0fa3f0b0c7..be806f65210 100644
--- a/codec/src/main/java/io/netty/handler/codec/compression/JdkZlibEncoder.java
+++ b/codec/src/main/java/io/netty/h... | null | test | train | 2013-11-28T13:50:08 | 2013-11-29T02:19:06Z | craigday | val |
netty/netty/2025_2031 | netty/netty | netty/netty/2025 | netty/netty/2031 | [
"timestamp(timedelta=18.0, similarity=0.85295617730554)"
] | 053c512f6de708f1bb3f402cf6d911f88b1d38aa | 82112699a79b18fe8bee0e6f0b90002c9eeecc13 | [
"@BabyDuncan would you mind do the changes and submit a pullreq ?\n",
"ok , i will do that .\n",
"hi @normanmaurer ,netty 4.x is build under jdk 1.7 , but the applications base on netty 4.x can be build under jdk 1.6 , why ? \n",
"If your application runs on Java 7, Netty will make use of the new classes in... | [
"Should it be?\n\n attribute = new DiskAttribute(name, value, charset);\n",
"yes it should be . i will fix that .\n",
"Not sure it is better, but we could call the very same constructor inside. Something like:\n\n```\npublic DefaultHttpDataFactory(long minSize, Charset charset) {\n this(minSize);\n this.... | 2013-12-03T02:38:22Z | [
"feature"
] | Wish MixedAttribute support user defined charset | MemoryAttribute 's constructor has no i can defined charset .
> public MemoryAttribute(String name) {
> super(name, HttpConstants.DEFAULT_CHARSET, 0);
> }
when i send a utf-8 request ,the gbk encoded server can never decode it correctly !!!
i hope there is a MemoryAttribute constructor
> public ... | [
"codec-http/src/main/java/io/netty/handler/codec/http/multipart/DefaultHttpDataFactory.java",
"codec-http/src/main/java/io/netty/handler/codec/http/multipart/DiskAttribute.java",
"codec-http/src/main/java/io/netty/handler/codec/http/multipart/MemoryAttribute.java",
"codec-http/src/main/java/io/netty/handler/c... | [
"codec-http/src/main/java/io/netty/handler/codec/http/multipart/DefaultHttpDataFactory.java",
"codec-http/src/main/java/io/netty/handler/codec/http/multipart/DiskAttribute.java",
"codec-http/src/main/java/io/netty/handler/codec/http/multipart/MemoryAttribute.java",
"codec-http/src/main/java/io/netty/handler/c... | [] | diff --git a/codec-http/src/main/java/io/netty/handler/codec/http/multipart/DefaultHttpDataFactory.java b/codec-http/src/main/java/io/netty/handler/codec/http/multipart/DefaultHttpDataFactory.java
index 8f6f68e18b5..24873fa4279 100644
--- a/codec-http/src/main/java/io/netty/handler/codec/http/multipart/DefaultHttpDataF... | null | test | train | 2013-12-02T08:23:57 | 2013-12-02T10:31:12Z | BabyDuncan | val |
netty/netty/2040_2118 | netty/netty | netty/netty/2040 | netty/netty/2118 | [
"timestamp(timedelta=85079.0, similarity=0.8540695487194159)"
] | a88584976d89ef6c93cbd48a422ef12bc06f5cbb | 346c9cd96170067f4d417c49efc2ba5fbbf53e0b | [
"Google only supports SPDY over https with NPN. Which protocol version did you negotiate?\n",
"I have try both spdy3 & spdy3.1 with NPN extension. It works few days ago, but failed in recent days.\n",
"@jpinner anything we can do here ?\n",
"What did you send in your settings frame? Google's servers send a GO... | [
"Why not use Unpooled.copiedBuffer(...) ?\n",
"I think you can use SelectedProtocol.protocolForName(...) ?\n",
"`@Override` annotations ?\n",
"You should add it to the parent pom version with version number ...\n",
"Not from the current code.\n\n```\npublic enum SelectedProtocol {\n SPDY_3,\n SPDY_3_1... | 2014-01-15T11:30:54Z | [
"needs info"
] | SPDY receive "PROTOCOL_ERROR" error | Recently connecting to http://www.google.com with spdy is broken.
After two setting frame, I got a GoAwayFrame with "PROTOCOL_ERROR" status. It works just few days ago. Maybe google just update his protocol??
Version: both 3.8.3 and 4.0.13
| [
"example/pom.xml",
"pom.xml"
] | [
"example/pom.xml",
"example/src/main/java/io/netty/example/spdy/SpdyOrHttpHandler.java",
"example/src/main/java/io/netty/example/spdy/SpdyServer.java",
"example/src/main/java/io/netty/example/spdy/SpdyServerHandler.java",
"example/src/main/java/io/netty/example/spdy/SpdyServerInitializer.java",
"example/s... | [] | diff --git a/example/pom.xml b/example/pom.xml
index eed48abf9bf..0dcff3cd82a 100644
--- a/example/pom.xml
+++ b/example/pom.xml
@@ -68,6 +68,10 @@
<artifactId>javassist</artifactId>
<scope>runtime</scope>
</dependency>
+ <dependency>
+ <groupId>org.eclipse.jetty.npn</groupId>
+ <artifac... | null | test | train | 2014-01-15T08:00:18 | 2013-12-05T14:14:56Z | carck | val |
netty/netty/2170_2171 | netty/netty | netty/netty/2170 | netty/netty/2171 | [
"timestamp(timedelta=121.0, similarity=0.8772450393794907)"
] | f7f808c7e0e354e3d468e31e609d8c538fac67e1 | e1213677a2d4d2ef2c54efb9c20c98cabcb5161b | [
"Suggested fix:\n\ninstead of ignoring\n\n> catch (InterruptedException ignore) {\n> // Ignore\n> }\n\nrestore interrupt status\n\n> catch (InterruptedException ignore) {\n> Thread.currentThread().interrupt();\n> }\n\nPull request with the suggested fix: https://github.com/netty/netty/pull/2171\n",
"Was fixed... | [] | 2014-01-31T11:23:43Z | [
"defect"
] | [netty-5.0.0.Alpha1] ThreadLocalRandom.current() clears thread's interrupt status | API method _io.netty.util.internal.ThreadLocalRandom.current()_ clears thread's interrupt status because _ThreadLocalRandom.getInitialSeedUniquifier()_ swallows _InterruptedException_ without restoring interrupt status (see https://github.com/netty/netty/blob/netty-5.0.0.Alpha1/common/src/main/java/io/netty/util/intern... | [
"common/src/main/java/io/netty/util/internal/ThreadLocalRandom.java"
] | [
"common/src/main/java/io/netty/util/internal/ThreadLocalRandom.java"
] | [
"common/src/test/java/io/netty/util/internal/ThreadLocalRandomTest.java"
] | diff --git a/common/src/main/java/io/netty/util/internal/ThreadLocalRandom.java b/common/src/main/java/io/netty/util/internal/ThreadLocalRandom.java
index 22ff7e47e18..3049e48274c 100644
--- a/common/src/main/java/io/netty/util/internal/ThreadLocalRandom.java
+++ b/common/src/main/java/io/netty/util/internal/ThreadLoca... | diff --git a/common/src/test/java/io/netty/util/internal/ThreadLocalRandomTest.java b/common/src/test/java/io/netty/util/internal/ThreadLocalRandomTest.java
new file mode 100644
index 00000000000..8f584d7f52d
--- /dev/null
+++ b/common/src/test/java/io/netty/util/internal/ThreadLocalRandomTest.java
@@ -0,0 +1,37 @@
+/*... | train | train | 2014-01-30T07:00:53 | 2014-01-30T21:07:28Z | stIncMale | val |
netty/netty/2177_2178 | netty/netty | netty/netty/2177 | netty/netty/2178 | [
"timestamp(timedelta=19.0, similarity=0.8764695546904817)"
] | ce053205021a55686d5484fe4f219db0261564f2 | f7c7cf8ad3f6e1fd0f6afe3efeb7634940cd1043 | [
"PR welcome :)\n\n> Am 02.02.2014 um 20:29 schrieb Vladimír Schäfer notifications@github.com:\n> \n> SOCKS5 protocol defines that response to CONNECT command can contain host and port the proxy server connects to the target from. Current implementation fills these fields with zeroes and doesn't support customizatio... | [
"maybe move this after the switch so we not convert an invalid address ?\n",
"could be static\n"
] | 2014-02-02T19:57:53Z | [] | SOCKS5 Response command does not support bound host and port | SOCKS5 protocol defines that response to CONNECT command can contain host and port the proxy server connects to the target from. Current implementation fills these fields with zeroes and doesn't support customization.
The support for bound fields should be added to io.netty.handler.codec.socks.SocksCmdResponse class.
| [
"codec-socks/src/main/java/io/netty/handler/codec/socks/SocksCmdResponse.java",
"codec-socks/src/main/java/io/netty/handler/codec/socks/SocksCmdResponseDecoder.java"
] | [
"codec-socks/src/main/java/io/netty/handler/codec/socks/SocksCmdResponse.java",
"codec-socks/src/main/java/io/netty/handler/codec/socks/SocksCmdResponseDecoder.java"
] | [
"codec-socks/src/test/java/io/netty/handler/codec/socks/SocksCmdResponseDecoderTest.java",
"codec-socks/src/test/java/io/netty/handler/codec/socks/SocksCmdResponseTest.java"
] | diff --git a/codec-socks/src/main/java/io/netty/handler/codec/socks/SocksCmdResponse.java b/codec-socks/src/main/java/io/netty/handler/codec/socks/SocksCmdResponse.java
index 03218b69213..567ceb63fff 100644
--- a/codec-socks/src/main/java/io/netty/handler/codec/socks/SocksCmdResponse.java
+++ b/codec-socks/src/main/jav... | diff --git a/codec-socks/src/test/java/io/netty/handler/codec/socks/SocksCmdResponseDecoderTest.java b/codec-socks/src/test/java/io/netty/handler/codec/socks/SocksCmdResponseDecoderTest.java
index 62af41aa7cf..1a98a8f765e 100644
--- a/codec-socks/src/test/java/io/netty/handler/codec/socks/SocksCmdResponseDecoderTest.ja... | val | train | 2014-02-01T18:35:09 | 2014-02-02T19:29:50Z | vschafer | val |
netty/netty/2183_2184 | netty/netty | netty/netty/2183 | netty/netty/2184 | [
"timestamp(timedelta=46.0, similarity=0.853477353555016)"
] | ff771c0fcbae09eab1d511995f32dfab0cf32ee2 | 7b55ad099981951e4194965d9dbd66099a53a32e | [
"@vschafer good catch! Thanks for the tests and fix!\n"
] | [] | 2014-02-06T18:44:04Z | [] | ByteToMessageDecoder doesn't release cumulation buffer | ByteToMessageDecoder doesn't correctly release internal "cumulation" ByteBuf in case decoder is removed from pipeline during decode operation and all bytes of the buffer were already read (i.e. buf.isReadable() == false).
Buffer is typically released in method handlerRemoved, but only in case it still has content to b... | [
"codec/src/main/java/io/netty/handler/codec/ByteToMessageDecoder.java"
] | [
"codec/src/main/java/io/netty/handler/codec/ByteToMessageDecoder.java"
] | [
"codec/src/test/java/io/netty/handler/codec/ByteToMessageDecoderTest.java"
] | diff --git a/codec/src/main/java/io/netty/handler/codec/ByteToMessageDecoder.java b/codec/src/main/java/io/netty/handler/codec/ByteToMessageDecoder.java
index 50dc125886a..637f4cd9d02 100644
--- a/codec/src/main/java/io/netty/handler/codec/ByteToMessageDecoder.java
+++ b/codec/src/main/java/io/netty/handler/codec/ByteT... | diff --git a/codec/src/test/java/io/netty/handler/codec/ByteToMessageDecoderTest.java b/codec/src/test/java/io/netty/handler/codec/ByteToMessageDecoderTest.java
index 09d5020073a..082ac8a2fca 100644
--- a/codec/src/test/java/io/netty/handler/codec/ByteToMessageDecoderTest.java
+++ b/codec/src/test/java/io/netty/handler... | test | train | 2014-02-06T10:48:56 | 2014-02-06T18:38:56Z | vschafer | val |
netty/netty/1831_2266 | netty/netty | netty/netty/1831 | netty/netty/2266 | [
"timestamp(timedelta=2633.0, similarity=0.9032205947505163)"
] | 3e11c0c39e10be1410f6267a2857ffeb1dab76a3 | 96074dcc29758a25c629e6e5cbb0a3836516e605 | [
"Was fixed by #2266\n"
] | [
"Why this license header ?\n",
"why copied at all and not reused ?\n",
"maybe some javadocs how to use it ?\n",
"Should be final\n"
] | 2014-02-27T02:19:18Z | [
"feature",
"help wanted"
] | Feature request: Websocket SSL client example | It would be nice if a working SSL websocket client example could be added to the examples.
| [
"example/src/main/java/io/netty/example/http/websocketx/client/WebSocketClient.java",
"example/src/main/java/io/netty/example/http/websocketx/client/package-info.java"
] | [
"example/src/main/java/io/netty/example/http/websocketx/client/WebSocketClient.java",
"example/src/main/java/io/netty/example/http/websocketx/client/WebSocketClientRunner.java",
"example/src/main/java/io/netty/example/http/websocketx/client/WebSocketSslClient.java",
"example/src/main/java/io/netty/example/htt... | [] | diff --git a/example/src/main/java/io/netty/example/http/websocketx/client/WebSocketClient.java b/example/src/main/java/io/netty/example/http/websocketx/client/WebSocketClient.java
index 5e6095167f3..6224c45ad17 100644
--- a/example/src/main/java/io/netty/example/http/websocketx/client/WebSocketClient.java
+++ b/exampl... | null | val | train | 2014-03-01T16:26:39 | 2013-09-11T14:21:55Z | mantesat | val |
Subsets and Splits
Java Code Detection in Problems
Identifies and categorizes entries in the dataset that are likely related to Java programming, providing insights into the prevalence and type of Java content in the problem statements.